I USE HDR
#👾-core-development
austere talon
austere talon
because you have shit a shit monitor where it looks bad
crude hearth
because you have shit a shit monitor where it looks bad
MY MONITOR ISNT SHIT
170HZ 2K
VERY HIGH SRGB
whats ur monitor @austere talon @austere talon
austere talon
whats ur monitor <@343383572805058560> <@343383572805058560>
very expensive oled..
crude hearth
how much did u spend
160 dollar
austere talon
160 dollar
THAT'S THE PROBLEM
austere talon
spend 500dolar and you will enjoy hdr
crude hearth
because hdr is teriblee
austere talon
it's not terrible it looks incredible @crude hearth
manti has never played a game in hdr and seen how insane it looks
crude hearth
manti has never played a game in hdr and seen how insane it looks
YES BECAUSE IT BREAKS EVERYTHING
austere talon
that's your own fault for buying an expensive monitor but not backing it up with an expensive gpu
crude hearth
oh my god I enabled hdr and everything looks terrible now
austere talon
oh my god I enabled hdr and everything looks terrible now
because you have a cheap ips monitor of course hdr will look garbage
crude hearth
ITS NOT CHEAP
austere talon
if you buy expensive oled monitor with good hdr it will look incredible
austere talon
ITS NOT CHEAP
170$ for 1440p 170hz monitor is very budget
how did u spend 600dolar on monitor and not get oled
crude hearth
170$ for 1440p 170hz monitor is very budget
dont look at price
it has good hdr range
austere talon
it has good hdr range
irrelevant this monitor has really shit hdr implementation
insane
75hz isn't that bad I guess
slightly better than 60 but still cheap probably
crude hearth
ven trying to justify spenjding 99999$ on oled monitor
austere talon
bro im just telling you how it is
hdr will always look shit on entry level hdr monitor
hdr is only good if you get an expensive monitor with great hdr implementation, then it's incredible
but on budget monitor it's bad
your monitor only has hdr400 which is the lowest level of hdr certification
crude hearth
your monitor only has hdr400 which is the lowest level of hdr certification
yes
but hdr
austere talon
yes
the point is that this is like buying phone that has extremely bad and slow wireless charging then concluding that wireless charging is bad in its entirety
no it's only bad on that device
crude hearth
bugs wont change on better monitor
austere talon
or using gpt1 then complaining that ai is bad
crude hearth
hdr is still so buggy
austere talon
bugs wont change on better monitor
well yeah there are some software issues like for me if I take screenshots on my hdr monitor it comes out so dark because gnome is insane and has shit hdr support
but it's well worth the better looks especially in games 
you will understand once you game on a good hdr oled monitor
crude hearth
well yeah there are some software issues like for me if I take screenshots on my...
thats same everywhere
windows is buggy too
austere talon
it works well on kde I heard
gritty iris
I USE HDR
did discord ever fix this for streaming 😭
I flashbang my friends every time I streamed with hdr
still maple
Seems like an entire life plan
toxic forge
I guess bro
desert cosmos
sorry for spam posting it was just too good
charred monolithBOT
glass jasper
“Files added via upload” 🥀
hybrid blaze
sterile oak
lmao
scenic brook
I also made this a while back but I found in practice it's actually not often that useful
It's nice to have when it is actually applicable though
burnt galleon
I also made this a while back but I found in practice it's actually not often th...
just saw it was a plugin request from 2024 never replied to so figured I'd add it. Also is pretty useful to me and I think would be to others as well
scenic brook
I think I also did it because I saw a request for it lol
chrome coral
you know what this is not a bad idea
austere talon
i don't really get the point unless this includes the entire reply tree
burnt galleon
i don't really get the point unless this includes the entire reply tree
it does
includes every reply, future and past
austere talon
like
message a
reply b
reply b2
reply c
reply c2
austere talon
it's not really possible
also dont make your own ui
use discords components
and hardcoding rgb colour values is unacceptable
burnt galleon
bru wut
austere talon
look at how other plugins function
you want to use discord's own components to be theme compatible and not look out of place
burnt galleon
ah okay
austere talon
your modal should
- use Discord's message component
- Use a Discord button (import from @components/Button)
- Use Discord's paginator
austere talon
bru wut
we want plugins to be themeable, for that only Discord colour variables should be used
they have like 3000 colour variables
you can just look for a colour in Discord's ui and inspect elements to get the variable name
anyway if you use Discord's components you shouldn't need any variables
also it really doesn't matter ignore krystall
but you should learn the git basics it's very useful knowledge
burnt galleon
but you should learn the git basics it's very useful knowledge
gotcha, sounds good. So if I was to do all of that, would it have a chance at being accepted or nah. Just don't wanna do all that work for nothing lol
still maple
i like the idea, but not the UI
i'd rather have it one of the message actions buttons like viewRaw or smth
but only shown when relevant, so when a message is a reply
austere talon
also that as well yeah ^
chrome coral
make it look like a twitter post
austere talon
gotcha, sounds good. So if I was to do all of that, would it have a chance at be...
not sure
a plugin like this will never be able to provide a satisfying experience imo due to the limitations
still maple
also actually if you make it into a message graph it'd be fire
austere talon
users will expect it to include all replies even when the messages are more apart
i feel thats where it is mostly useful
the way you wrote it right now it only considers the current 50 messages in chat if I'm seeing correctly
if it's just that, you can just look at chat and see it too, you don't need a special view
personally I would only find this view useful for longer threads that are many messages apart and the plugin will never be able to support those without fetching everything which isnt possible
still maple
it'd need to like request linked messages and stuff to include everything
and on a big reply chain it could turn into smth that spam a bit the API or smth
tho i mean you could do smth where it build a partial tree and when you click on a message, you can view higher / as it loads you can view more or smth
but that sounds awfully complicated
or we could cache every single message locally smh, surely that wouldn't be an issue
-# notice that my small server backup made by my bot is 200GB+ ok maybe it's not a good idea
austere talon
fetching upwards is not the issue
fetching downwards is
if you want to view the replies to this message
[imagine 1000 messages here]
austere talon
if you want to view the replies to **this** message
oh wow i missed this message 
austere talon
oh wow i missed this message <:catlaugh:1142782209451896884>
if you want to get this reply from the first message you literally have to fetch the entire chat history after the message you're inspecting
still maple
i didn't really think of that
tho ig if the surrounding messages have been loaded it's possible i guess
but that means it'd only work in the event of a chat which is really not dense, which goes against the point of having a reply tree
austere talon
personally I would only find this view useful for longer threads that are many m...
yeah that's what I meant here
The plugin will only function with close together reply chains where you don't really need a better view anyway
also how would the plugin even display non linear chains like
austere talon
also how would the plugin even display non linear chains like
this is chain 1
austere talon
also how would the plugin even display non linear chains like
this is chain 2
austere talon
this is chain 1
this is chain 1 part 2
austere talon
this is chain 1 part 2
this is chain 1 part 3
still maple
that's the fun part
austere talon
this is chain 1 part 2
this is chain 3
austere talon
this is chain 3
this is chain 3 part 2
austere talon
you would have to make some reply tree like twitter like samy said
chrome coral
TWITTER POSTT
burnt galleon
hmm
still maple
what's twitter ?
burnt galleon
lemme see what I can do
still maple
also i imagined like root messages at top
austere talon
well the reply tree issue can be solved without too much effort
still maple
and as you go down, you go down the chain
austere talon
personally I would only find this view useful for longer threads that are many m...
this is the much bigger issue
austere talon
this is the much bigger issue
and with that issue, i think the plugin is likely too niche and limited to be included in the main distribution
(but can always be posted in #1032200195582197831)
burnt galleon
personally I would only find this view useful for longer threads that are many m...
well I was just able to fetch a message from 2023 with no problems
Unless I'm confused on what you are saying
burnt galleon
it can fetch any new message?
anytime there is a new reply to the reply chain the UI updates and shows the newest reply too
no matter which message u clicked on
scenic brook
If you press the button on a really old message it doesn't know where more recent replies to that message are
Is the issue
austere talon
it doesnt have to be really old
imagine I reply to a message from 2 days ago
then later someone wants to see that new reply by me from the original message
that will never be possible to add
scenic brook
The plugin will only function with close together reply chains where you don't r...
This is also basically what I meant about it not being that useful in practice, it's fairly rare I ever found a use for mine
burnt galleon
yeah i understand what youre saying now
still maple
kinda like git log
i wanted to show, but i'm a rebaser, but basically this, but like with root being on top instead of bottom
me when discord takes 7 minutes to upload a picture : 🤦♂️
burnt galleon
what about like making better discord plugins but for Vencord
ex: the personal pins plugin
if i remade that for vencord
chrome coral
its not about porting plugins over, most of vencord plugins aren't original and usually stem off of what other people made in the past
it just needs to follow plugin rules and be useful enough for a lot of people
austere talon
what about like making better discord plugins but for Vencord
generally you can make anything as long as it follows our guidelines
you can always publish plugins to #1256395889354997771 but if you want it in the official distribution it has to match our standard and be considered useful enough
best to discuss your idea here beforehand to make sure it's good
still maple
doesn't this alr exist ?
burnt galleon
i couldnt find it in the plugin search, so if it does it has some random name
austere talon
someone already made this ages ago but it was rejected because Discord was going to add it themselves
well clearly they are not adding it lmao
so yes it's okay
just erm one tip don't get inspired by DevilBro plugins code or design wise
still maple
maybe the experiment is still there :copium:
burnt galleon
just erm one tip don't get inspired by DevilBro plugins code or design wise
nah im not
austere talon
This time make sure to use Discord / Vencord components
See how other plugins do their UI
you can look at MessageLinkEmbeds for how to render Discord's native message component
austere talon
oh yeah we still have to update Vencord's css
austere talon
am i allowed to use like custom SVG or no
Better not to
look for icons inside Discord and use those
there's no reason for this plugin to need any non Discord svgs
Generally we want plugins to look like they are native Discord features
no custom ui, no custom colours, no custom icons (unless there is no better suited icon)
if you really can't find a good icon, using Material Icons would be the next best option
look for a svg inside Discord then copy paste their svg code
burnt galleon
Better not to
sounds good
austere talon
vext
hybrid blaze
sounds good
what about this? https://discord.com/channels/1015060230222131221/1293357944498556969
here you can easily find native icons, and you can also create a custom findby if you want
austere talon
why do they just have numbers lmao
austere talon
they dont have a matching pattern
oh my god do they hardcode every svg 😭
surely there's a better way
oh wait
the finds are for names
hybrid blaze
oh my god do they hardcode every svg 😭
imagine 
desert cosmos
There was a better way I think
scenic brook
They used to display component names before they obfuscated more
charred monolithBOT
burnt galleon
here you can easily find native icons, and you can also create a custom findby i...
Thank you 💯
hybrid blaze
its replacing the media URL for all uploaded video attachment
hybrid blaze
🙆♂️
austere talon
btw the chromium team accepted the devtools lag issue and seem to be investigating
hopefully fixed soon
elder plinth
hybrid blaze
limber skiff
I think this too https://discord.com/channels/1015060230222131221/10265158800808...
I'm pretty sure the way the gif thing works is they make the url be an image instead of a gif
but since you overwrote function 😭
austere talon
don't they pass something like passthrough=
austere talon
I saw that param before
limber skiff
once I first worked on the plugin I caused the same issues
gritty iris
oh my god do they hardcode every svg 😭
Trust me I would've fixed that 😭
I'll probably get around to adding names soontm
hybrid blaze
good boy
elder plinth
passthrough is for rendering apngs as static png
hybrid blaze
elder plinth
animated is for webp
gritty iris
Should just check if it's an image type else use media
elder plinth
lossless is for webp
gritty iris
Idk of a better way 
hybrid blaze
this was my best, cant think
strong aurora
btw the chromium team accepted the devtools lag issue and seem to be investigati...
do you have a link to that?
scenic brook
strong aurora
awesome thanks
charred monolithBOT
still maple
this was my best, cant think
stupid idea, but what about doing integer scaling ?
gritty iris
usrbg classname includes is broken btw tile_ should be tile
also its borked anyways
this needs to be set to transparent for users with backgrounds
charred monolithBOT
gritty iris
im curious on why we arent doing just if (className.includes("tile") && this.userHasBackground(participantUserId)) { any idea?
charred monolithBOT
turbid hatch
can someone test this besides me just to check
since its relatively small ill just merge it if other people tell me it works
odd heath
hybrid blaze
interesting
gritty iris
did they pr equicord
yes they did
I dont even understand how they got that far because they had trouble commiting a file and in a branch
charred monolithBOT
austere talon
Fixed all the FixImagesQuality issues
and added this note about animated images (no way to fix)
does AlwaysAnimate make images in chat always animate?
only one way to find out
no it doesnt okay
austere talon
vtest
austere talon
@void flower @gritty iris can you confirm this fixes all FixImageQuality issues?
would be appreciated 🙏🏻
austere talon
it fixes
- videos
- gifs shouldnt animate if app isnt focused
- gifs shouldnt animate if this setting is off and image not hovered
all work for me
gritty iris
it fixes
1. videos
2. gifs shouldnt animate if app isnt focused
3. gifs shouldnt...
works
austere talon
<@1264878478168297528> <@848339671629299742> can you confirm this fixes all FixI...
I forgot kim can't even reply because no progamer role 
i fixed
gritty iris
lol
void flower
im programming so hard rn
gritty iris
userpluggie but equi
gritty iris
activity names can be null when the activity first gets assigned
I loaded this
anyways the fix works for me 
void flower
i can test in a bitty
charred monolithBOT
austere talon
some emojis you can only clone if you fetch 64x64 size
like
with 128x128 or any bigger size is 700kb
also some stickers have descriptions that are longer than possible today
like you cant clone
its description is too long
but it's an annoying edge case because
- the maximum allowed length is 100 bytes
- that sticker's description is exactly 100 chars and it includes a newline
- Discord uses FormData for stickers and FormData encodes newline as CRLF (\r\n), which is 2 bytes
- Thus this sticker's description is technically 101 bytes which is too big
idk how it worked in the past, I assumed they just had a higher or no description limit
charred monolithBOT
void flower
i can test in a bitty
quick test shows everything working as expected now
austere talon
nice thank u!!
still maple
i wonder, discord added dev://experiment/2025-10-timestamp-autocomplete which is basically a replacement for https://vencord.dev/plugins/SendTimestamps
but it doesn't offer as many options, would a plugin that add all variants of timestamps be accepted ?
actually i think you can have all types, but you gotta type stuff to see it, which isn't quite convenient, imo by default it should show all options
sterile oak
twilit vector
-# #🖥-vesktop-support-🖥 message
forwarding here so it's not buried in regulars and because it's a good idea to nina
vivid garden
heads up on something like this (i haven't confirmed this yet) but i have an extension that does similar script patching to vencord and a patch failed on the main site page for a few days because i was busy and i lost the featured badge on the chrome web store
haven't confirmed that was the cause yet but it lined up (CWS didn't send me a notification email about why or even alerting me it happened)
still maple
should add a #1257025907625951423 game activity toggle button broken
#1337479880849362994 message
#1337479880849362994 message
austere talon
right
hybrid blaze
right
i have a fix if needed https://github.com/Equicord/Equicord/pull/580/changes/54d1046ad704af74e5eef43c8fdd13722c8f8a5e
hybrid blaze
yap 🙆♂️
charred monolithBOT
austere talon
not a big fan of the find but that component is so generic now
hybrid blaze
not a big fan of the find but that component is so generic now
actually just did this
still not the best but a bit better
austere talon
i love how they randomly broke this then changed their mind
hybrid blaze
well, it was quite unexpected
austere talon
real discord staff conversation:
A: haha I just pushed a commit that breaks another Vencord feature
B: nah bro.. cut them some slack for now they've been dealing with enough over our Settings remake
A: shit man you're right...
hybrid blaze
austere talon
no way badges are broken now
hybrid blaze
seems fine to me
austere talon
huh?
hybrid blaze
oh lol
hybrid blaze
no way badges are broken now
im blind sorry
austere talon
ig ill just merge this Vendicated/Vencord#3827
hybrid blaze
this was my fix
austere talon
for?
charred monolithBOT
hybrid blaze
the ones in messages?
in profiles ig
oh wait im dumb nvm
just realized that file doesnt even exist in vencord
austere talon
hybrid blaze
austere talon
why do you add so many pointless comments xD
Settings.cloud.authenticated && // if cloud integrations are enabled
localStorage.Vencord_cloudSyncDirection !== "manual" // if we're not in manual mode
these just repeat the already existing information
turbid hatch
why do you add so many pointless comments xD
i was copying what i had done before and it was because im making mental notes xd
i just forgot to remove them
sterile oak
is hovering turning the button transparent intended?
austere talon
still wrong lewi 😭
charred monolithBOT
austere talon
and i think the wording is confusing
too technical language
push, pull, bidirectional? no clue what any of that means
charred monolithBOT
austere talon
im fixing
turbid hatch
did i not actually fix it
cuz when i tried it it worked fine and threw no compile errors
although it was during the time where css was busted so i couldnt check tbf
charred monolithBOT
charred monolithBOT
austere talon
@turbid hatch i think this is way clearer
austere talon
I didn't know how to word it well so I asked AI
took like 5 corrections for it to come up with something that was good
austere talon
i restructured it
I also moved the reset buttons into their own section
austere talon
okay
charred monolithBOT
austere talon
maybe we could add https://www.npmjs.com/package/lucide-react to vencord
turbid hatch
i was looking at https://heroicons.com/ but lucide would work too
austere talon
well
it's not that easy
all these libaries use React on the top level
at the point where Vencord loads react isnt there yet
austere talon
i was looking at https://heroicons.com/ but lucide would work too
this is better because you can copy jsx but these would look out of place
turbid hatch
hmm i see i see
austere talon
did i not actually fix it
the color property on button isnt a thing
turbid hatch
o
austere talon
turbid hatch
i see
glass jasper
the icons <:Sob_praying:1332455047904362558>
told you
hybrid blaze
hell nah
austere talon
wtf are u talking about 
hybrid blaze
wait
hybrid blaze
wtf are u talking about <:MalinStare:666111446773399553>
honestly, which one you prefer
austere talon
💀
hybrid blaze
well-well
austere talon
i like the idea but the grey is ugly tbh
charred monolithBOT
hybrid blaze
i like the idea but the grey is ugly tbh
i started with the version with icons, then realized it looked ugly and made a cleaner one, but everyone still thought it looked better with icons :c also, i really dont like the quick action gray buttons so i just yeeted it
sterile oak
i was looking at https://heroicons.com/ but lucide would work too
hm, should I add an option to copy as svg to my plugin?
austere talon
oh yeah we have to fix this
charred monolithBOT
austere talon
I would appreciate if you guys could test this PR Vendicated/Vencord#3797
Just run Vencord with it and see if everything works correctly for you. If the UI looks correctly everwhere, etc
turbid hatch
yayyyy
high oracle
<@423915768191647755> can you cancel the extension update please
Yeah sure one sec
Done
charred monolithBOT
charred monolithBOT
twilit vector
turbid hatch
why on earth were so many prs updated 10 hours ago
still maple
Me : see emoji 👉 AI AI AI right
charred monolithBOT
scenic brook
why on earth were so many prs updated 10 hours ago
Vee force pushed dev
charred monolithBOT
austere talon
pointless just use css @glass jasper
glass jasper
pointless just use css <@929208515883569182>
I remembered that a bit after I sent the message
charred monolithBOT
gritty iris
I was gonna pr the stores I have typed but I figured I would ask if you wanted just the stores I updated that you all use or just all the ones I typed
desert cosmos
I was gonna pr the stores I have typed but I figured I would ask if you wanted j...
typed stores...
desert cosmos
you should pr
gritty iris
I need to fix a few
I had most of the actual getMediaEngine typed
but I dont have all the values
charred monolithBOT
gritty iris
@desert cosmos ^ that what you wanted
desert cosmos
lovee
gritty iris
this is broken now
errant nacelle
A few days ago my client loaded a full css stylesheet where 50% of the color variables were set to hotpink
But it immediately reverted on reload
charred monolithBOT
sterile oak
is the dependency used in
MarkdownAPI, discussable?
austere talon
is the dependency used in
[MarkdownAPI](<https://github.com/Vendicated/Vencord/p...
no
austere talon
https://cdn.discordapp.com/emojis/1144773776215650374.webp?size=80
Oh i misread your message\
its not a problem
sterile oak
Okie dokie ty
charred monolithBOT
LinkScrub
Automatically removes tracking parameters and cleans links in your messages before sending.
Example
fossil inlet
insaneee
nimble pendantBOT
vp clearurls
woven saffron
bruh ffs
I literally wanted this shit for a while, searched in plugins "clean", "sanitize", "links", thought it didnt exist... and didnt fucking think of searching "URLs"
aight bruh killing myself ttyl
sterile oak
I literally wanted this shit for a while, searched in plugins "clean", "sanitize...
could we just add tags for the plugin
woven saffron
yeah....
hybrid blaze
austere talon
that is indeed a duplicate
hybrid blaze
this actually looks cool
charred monolithBOT
twilit vector
#🏥-vencord-support-🏥 message normalizemessagelinks would be a good idea for conversion into a preset then?
charred monolithBOT
This plugin allows you to modify the max number of reactions for the frencency reaction menu
3 was never enough, 5 is the plugin default value, configurable through plugin settings
sterile oak
thororen is typing...
gritty iris
I was wondering if it's possible to apply themes and such to discord's overlay windows since I know they redid it for overlay v2 but I'm not sure if they changed anything in that sense
desert cosmos
erm so actually.. just use viewraw
austere talon
erm so actually.. just use viewraw
no
hybrid blaze
charred monolithBOT
charred monolithBOT
desert cosmos
all wrong
hybrid blaze
all wrong
https://tenor.com/view/prove-it-proof-patrick-star-spongebob-spongebob-meme-gif-18140011542991964976
desert cosmos
all ai automcpleted
austere talon
tbh could probably feed the discord 2022 source leak + current store code into ai and tell it to cross reference them to auto generate types 
But of course I highly advocate against this as this may be immoral or infringe on Discord's copyright, please do not do this
desert cosmos
vee 😭
hybrid blaze
😭 belvoed discord copyright
gritty iris
I just randomly type stores when I get really bored because it gives me something to do
gritty iris
tbh could probably feed the discord 2022 source leak + current store code into a...
There was a source leak 😭
austere talon
yes
dusk blaze
desert cosmos
time for another one
Of course nobody should leak intellectual property, horrible if that happened.
brazen bone
No worries, I don't think there's anything intellectual in there
austere talon
Alongisde
I dont get why people close prs
Even if it doesn't get merged just leave it open maybe it will be merged in 5 years
elder plinth
it's stressful having something lingering open. ocd thing or smthn idk. it's also a clutter to your branches
fossil inlet
it's stressful having something lingering open. ocd thing or smthn idk. it's als...
clutter to your branches
median rapids
tbh could probably feed the discord 2022 source leak + current store code into a...
RAG was made for this...
scenic brook
it's stressful having something lingering open. ocd thing or smthn idk. it's als...
I just don't wanna have to come back to years old code when it finally gets eyes on it
hollow musk
what happened to your lazygit breh
twilit vector
comic sans'd up
lusty vector
Even if it doesn't get merged just leave it open maybe it will be merged in 5 ye...
What's the oldest PR you've merged?
@twilit vector 2017 PR when?
twilit vector
that's a joke
lusty vector
Oh ok
fossil inlet
@austere talon ce8e48bb6db20476ecc743a4002b44af42e5cec5 breaks all vencord css for me
this seems to be the cause
fossil inlet
<@343383572805058560> ce8e48bb6db20476ecc743a4002b44af42e5cec5 breaks all vencor...
UI gets unusable if you have better folders enabled
austere talon
<@343383572805058560> ce8e48bb6db20476ecc743a4002b44af42e5cec5 breaks all vencor...
full restart the app
sterile oak
RAG was made for this...
huh, what's RAG?
charred monolithBOT
crude hearth
RAG was made for this...
whats rag dolfies
possible actually
but need some sane way to feed all discord code without eating all the context
median rapids
but need some sane way to feed all discord code without eating all the context
that's the point
it only loads what's necessary into context
crude hearth
so can you like
feed both source maps and real code
and ask it to generate types
but how will it know which one is new and whichg one is old
median rapids
what i wanna do is put the maps in a rag
and feed it a diff of every build since the maps 1 by 1
crude hearth
yeeees do
crude hearth
that would probably take forever but would work ig
module ids also stay consistent ig
well except big bundler changes
those would be issue
median rapids
no cuz they changed the bundler 3 trillion times
yea
remember this is 3 yrs of changes
so honestly I'd prolly batch em to near max context size
@livid heath we ARE making this TOGETHER
❤️❤️❤️
crude hearth
well for local models i think context size is issue
median rapids
why would I use a local model...
crude hearth
because if u use cloud models wouldnt it cost billions of dollars
imagine how many changes discord pushs
one req for each
median rapids
when I could run up some ai company's vc-funded oai key
crude hearth
gemini support 2 mil context
austere talon
ai
stiff geyser
ai
The descriptions and commits are AI
Also what's wrong with AI if we're getting to the target?
turbid hatch
just going to lock this so it doesn't become a source for a massive argument because i can already forsee where this is going
stiff geyser
just going to lock this so it doesn't become a source for a massive argument bec...
Nah it's fine
I mainly made it for myself but thought it would be cool if someone else used it
turbid hatch
thats fine, and thank you for opening the PR, but as v said the description being fully AI (or at least AI generated and modified) doesnt provide much confidence in the PR because it's a common pattern that people generate whole PRs like this and we're kinda sick of it
turbid hatch
but they did tell you besides the description what was wrong with the PR, and the main reason why we fully close them is because of the issues with it it requires essentially rewriting the whole thing, so its best as its own PR
austere talon
Stop with the crazy hostility
I literally closed it because of the code
Other than that, this PR doesn't follow our guidelines on using React instead of dom manipulation. Adding a dependency is also not ideal. And instead of reinventing the wheel via things like your getAvatarUrl, it'd be better to use Discord's existing apis (e.g. IconUtils webpack common, look at how other plugins do things)
I'll have to reject this PR on those grounds (mainly point 1), but thank you for your contributio regardless!
never seen a jsdoc like that
austere talon
yeah i googled but it doesnt seem to be a recognised jsdoc
stiff geyser
Stop with the crazy hostility
I literally closed it because of the code
> Oth...
I'll try again later
I won't give up unless getting banned
austere talon
i think they tried noting that the return type in the types is not fully correct because it can return undefined
stiff geyser
jkjk
turbid hatch
maybe its like something they made up to indicate "it's supposed to return Guild but it actually returns Guild | undefined in this case" but why not just type it as G|u and the consumer can ! it if appropriate
austere talon
Stop with the crazy hostility
I literally closed it because of the code
> Oth...
by point 1 I meant the dom manipulation, not the description
stiff geyser
by point 1 I meant the dom manipulation, not the description
Yeah fixing it rn
austere talon
maybe its like something they made up to indicate "it's supposed to return Guild...
I typed it without undefined because it shouldn't ever return undefined if you dont misuse it
turbid hatch
ah
austere talon
and working with undefined return types when you know it cant be undefined is annoying imo
turbid hatch
non-null assert it!
austere talon
I typed it without undefined because it shouldn't ever return undefined if you d...
like yes if you do like GuildStore.getGuild("bruh") it will give you undefined
turbid hatch
ah does it do a webreq if you're not in the guild
austere talon
but if you do like
GuildStore.getGuild(SelectedGuildStore.getId())
it will never be undef
austere talon
ah does it do a webreq if you're not in the guild
nooo
if you pass a random guild id it can be undefined too
turbid hatch
ooh i see
so its just a typing convenience because it should only ever be called on guilds u have some sort of access to
austere talon
but using it like that makes no sense (or in the few cases where it makes sense to, you are well aware it can be undef)
austere talon
so its just a typing convenience because it should only ever be called on guilds...
basically
turbid hatch
sounds fair enough
austere talon
a lot of stores are like that
turbid hatch
ive never really noticed before cuz i just dont use them on things i dont have access to anyway
just assumed it always returned a value or errored
but yeah makes sense on why they made up the @correctType doc
though probably not necessary
austere talon
yeah i googled but it doesnt seem to be a recognised jsdoc
Definite proof it's vibecoded || /s ||
turbid hatch
austere talon
i dislike that personally
If you add null/undefined to the return type it means you expect the caller to handle the case
If the caller always just non null asserts it means it probably doesn't need to have nullable return type because it's an unexpected edge case
crude hearth
@austere talon @austere talon @austere talon @austere talon my pr,
gritty iris
Definite proof it's vibecoded || /s ||
not sure if his part is but I did scan over it and it looked good I just dont know jsdoc like that so I left that alone
99 is literally 99 in the store which is funny but he said hes already fixing it before I saw
charred monolithBOT
gritty iris
should I remove the relationship store??
austere talon
just leave it in the pr
see if his pr does anything better/differently and maybe change if so
gritty iris
I cant tell if this is sarcasm 😭
weak thistle
it's vencord development nothing is ever serious
gritty iris
@austere talon should I commit these
charred monolithBOT
livid heath
<@841509053422632990> we ARE making this TOGETHER
keep wishing
if it helps i happen to have a semi updated list of bundler changes and commit ids
well semi updated until i gave up on builds dissector
livid heath
RAG was made for this...
copyright infringement
the avg hn member really doesnt give a damn huh
austere talon
somehow I was scrolled up to this message without realising and thought a weird bot/spammer decided to reopen that PR and leave the same comment
charred monolithBOT
limber skiff
I think the types are missing some kind of standard
for example, this is bad
unknown is extremely annoying to deal with, any should be used instead
but I also think that any case where a type is unfinished should be properly commented, even if that means a lot duplicate comments
limber skiff
an special todo tag could be good
fossil inlet
//TODO: type this
fossil inlet
im going to try and type the unknowns rn myself
limber skiff
removed but this what I mean 😭
limber skiff
im going to try and type the unknowns rn myself
It's fine to not type everything
but use any
and properly annotate that it's unfinished
limber skiff
this should be a type NewThreadsCounts = Record<string, number>
also
my screenshots in the chat look really low quality now
but it's not webp?
fossil inlet
could discord be converting it to webp on upload
i get this log message when uploading bigger images
fossil inlet
limber skiff
@austere talon why is it a webp ^
fossil inlet
probably returning a content-type header which overrides the extension
limber skiff
is the issue it being a media.?
fossil inlet
but i suspect that discord is converting it when you uplopad
limber skiff
shouldnt the plugin be making it use cdn?
austere talon
this should be a type NewThreadsCounts = Record<string, number>
no
the longer syntax gives more information on what the key is
limber skiff
hmmm
limber skiff
okay that's fair
limber skiff
I dont think it's this
limber skiff
but the plugin used to make it load png on the chat too
austere talon
there is no way to get original without using cdn
It doesn't really matter if it's png or webp
open plugin settings and read what it says there
I documentated it
also make sure you're using latest dev
limber skiff
yeah I am
but what happened to the old behavior where it used png on the chat without the caveats?
was there an issue with it
austere talon
you can add format=png but it's not really better and it breaks hdr
stupid auto correct
austere talon
by default in chat the plugin will use media with no parameters which will load full resolution optomised webp
and in the image modal it uses original CDN
fossil inlet
limber skiff
okay restarting fixed
limber skiff
cursed lol
median rapids
>copyright infringement
the avg hn member really doesnt give a damn huh
did u get hit on the head
since when does anyone care abt copyright infringement🥀
gritty iris
im going to try and type the unknowns rn myself
so I shouldnt make them any yet?
fossil inlet
make them any
ill pr types for them if i manage to type them
either to your branch or to vencord depending if i do it before your pr gets merged
gritty iris
alr im also adding the todo comments
fossil inlet
?remind 2d work on discord source browser website
shut vineBOT
Alright @fossil inlet, in 2 days: work on discord source browser website
fossil inlet
javascript is so fast
limber skiff
<@235834946571337729> the pink css debugging chunk is back
canary or stable too?
fossil inlet
canary
gritty iris
thats funny lmfao he just pr'ed fixes for that store lol
hybrid blaze
"full"
fossil inlet
well idk if they're full
limber skiff
oh wait I know why
fossil inlet
but improved
limber skiff
because of this other part
our regex does not match it
which makes this code never run
which in turn makes it a valid chunk here
and thus gets loaded
I could solve it by just using the one commented but ehh
well to be fair I don't think there is a way to solve it without using the proper one 😛
okay I have an idea
fossil inlet
the humble terenary operator
fossil inlet
insane
charred monolithBOT
fossil inlet
oops
fossil inlet
@autumn current what do you mean by using a native api
afaik it's always used a native api on desktop
it only uses the web audio api on web (which includes vesktop)
livid heath
did u get hit on the head
i was dropped as a child
median rapids
i was dropped as a child
same!!
livid heath
but how will it know which one is new and whichg one is old
if youre building a rag on your own that part depends on how you want to do it
a RAG simply refers to pre processing a query to fetch additional bits of context and passing that over to the actual model that is going to answer your query
its completely up to you how you want to chunk the input for your rag (i.e. split up your source code) and how you want to retrieve them for context (most systems use vector embeddings which you can think of it as fancy keyword search)
i feel like im getting too off topic
crude hearth
its completely up to you how you want to chunk the input for your rag (i.e. spli...
so like you could give one minified module to it and give rag source maps and it would check source code for the names
where you do it for each chunk
charred monolithBOT
austere talon
most useful enum
hybrid blaze
rtx 
austere talon
I'm trying to get vesktop to use my dedicated gpu but it's impossible holy shit
5 billion flags and three different ways to tell it to use my dedicated gpu and it still uses igpu
DRI_PRIME=1 vesktop --use-gl=angle --use-angle=vulkan --enable-features=AcceleratedVideoEncoder,VaapiOnNvidiaGPUs,VaapiIgnoreDriverChecks,Vulkan,DefaultANGLEVulkan,VulkanFromANGLE --ignore-gpu-blocklist --disable-gpu-driver-bug-workaround --gpu-testing-vendor-id=0x1002 --gpu-testing-device-id=0x7550 --force_high_performance_gpu --ozone-platform=wayland --disable-features=UseChromeOSDirectVideoDecoder
maybe it is using the correct gpu??
why does it say active on the igpu
desert cosmos
just give up
hybrid blaze
austere talon
crazy
fossil inlet
wait five weeks for chrome devtools to load
hybrid blaze
insanse
fossil inlet
it genuinely took like 10 seconds
the same thing happens to me. I know what you're talking about
charred monolithBOT
fossil inlet
is there a way to control where vencord is loaded from via cli args/env vars when using discord desktop
oh
evil
austere talon
is there a way to control where vencord is loaded from via cli args/env vars whe...
yes
its an env var
the gui tells you the name
you have to set it for both the installer and vencord itself
fossil inlet
you have to set it for both the installer and vencord itself
oh i meant at runtime, not inject time
fossil inlet
eg VENCORD_PATH="/foo/bar" discord
austere talon
not how it works no
fossil inlet
austere talon
not a real use case
austere talon
told you
twilit vector
noo they only had to wait just 3 more months to get pulled :/
gritty iris
fossil inlet
can it even patch appimages
fossil inlet
gritty iris
charred monolithBOT
gritty iris
I was confused on why they didnt just use the tar.gz but I also have no idea why they said it worked or if it did
austere talon
the tar sucks because no auto update
you have to constantly redownload
but using AppImage is dumb
just use https://github.com/diced/dvm
installer supports it too
charred monolithBOT
charred monolithBOT
austere talon
fossil inlet
tim
fossil inlet
what the hell man
@gritty iris did you type these or was it someone else
austere talon
or he ai generated all this 
gritty iris
gritty iris
I didnt even know it was merged
austere talon
i mean not much to review its just types
gritty iris
austere talon
i didnt really look at the types
limber skiff
yeah but the things I mentioned yesterday
gritty iris
limber skiff
windows is so dumb
austere talon
i mean you can have a look now 
I broke Vesktop css hot reload by releasing Vesktop sandbox update but not the vencord update it depends on
it's still in dev
fossil inlet
austere talon
this is kind of a misleading message because it implies it always does that and not just when running reporter
but whatever
fossil inlet
?remind 2 days fix compnaion bug where it will make current file as read-only when live patch helper is dragged out of it's section
