#👾-core-development
charred monolithBOT
twilit vector
the app-region thing seems to have extended to even catppuccin themes (which was fine on canary until today)
charred monolithBOT
gritty iris
im scared i didnt know there were more demons 
charred monolithBOT
The empty catch block will suppress all errors during file deletion, including permission errors, not just the expected "file not found" error. This can hide potential problems and make debugging difficult. It's better to explicitly check for the ENOENT error code and allow other errors to be reported.
await unlink(path).catch(err => { if (err.code !== "ENOENT") throw err; });
chrome coral
builds also expire in 90 days so people wont be able to use outdated builds.. which may be good
auto updates are still available as well
torpid mason
Theres an option to load it from zip or smth right?
chrome coral
Theres an option to load it from zip or smth right?
wdym
alright I finished the workflow for uploading to testflight, but I haven't tested (and the workflow makes it kinda annoying its on my fork and not the main repo)
torpid mason
wdym
As in you can turn on developer mode or smth and load it locally, it not being on the AppStore
I know chrome allows for smth like this
chrome coral
https://github.com/Vendicated/Vencord/pull/4171 @austere talon it needs some of my credentials for upload 
otherwise it should be ok, but see if theres anything wrong with the workflow tanks
chrome coral
https://testflight.apple.com/join/JNPxzZeD @torpid mason
torpid mason
<https://testflight.apple.com/join/JNPxzZeD> <@1007890574050869351>
PEAK
thanks twin :3
love
twilit vector
oh my god vee how long did you spend onthis
prime dew
Holy based
austere talon
oh my god vee how long did you spend onthis
the style guide?
I stole it from equicord
twilit vector
of course you did
austere talon
Also I think that style guide was partially ai generated
chilly gyro
#🧩-plugin-development message
that aged well lol
charred monolithBOT
charred monolithBOT
elder plinth
https://tenor.com/view/gojo-absolute-cinema-gif-8932131737123141805
you got V hooked on gemini just to replace equicord's with greptile a day later 
charred monolithBOT
gritty iris
you got V hooked on gemini just to replace equicord's with greptile a day later ...
blame prism
austere talon
is greptile better
twilit vector
feature requests are welcome?
elder plinth
according to prism and thor just listens to prism so possibly
charred monolithBOT
For a bug report, this label should use "reported" instead of "suggested". Additionally, this checkbox should be mandatory to ensure users have performed a search before opening a new issue.
- label: I've searched existing issues and this hasn't been reported before
required: true
These checkboxes should be marked as required: true to ensure users acknowledge these conditions before submitting. Note that the checkbox on line 68 is also missing this property and should be updated to maintain consistency with the previous version of the template.
- label: I installed Vencord via an official method (download from vencord.dev or from source), not via something like AUR or Nix p...
These checkboxes should be mandatory (required: true) to ensure the requester confirms they have followed the guidelines and are willing to contribute, as mentioned in the updated CONTRIBUTING.md (line 22).
- label: I've searched existing issues and this hasn't been suggested before
required: true
- label: This is a **core modification feature**, not a plugin request (tho...greptile edits the original pr message with reviews though which is ass and @gritty iris refuses to turn it off
twilit vector
feature requests are welcome?
No plugin requests, go to our Discord server for that
telling them to join server just to get a "no plugin requests" anyway 😭
elder plinth
you can be 5 stages deep in a review and it'll edit the pr message rather than leave a new comment at the bottom
actual buns
austere talon
> No plugin requests, go to our Discord server for that
telling them to join ser...
we can make a forum 
but my ass will not look at that shit
gritty iris
greptile edits the original pr message with reviews though which is ass and <@84...
I did and it ignored my other settings
elder plinth
let it ignore them all. this 1 is not worth compromising
twilit vector
but my ass will not look at that shit
give helpers deletion perms to keep only the greatest ideas
encourage jannies with pay raise for janitoring
elder plinth
back to gemini hooray
gritty iris
gemini is peak
austere talon
i hate that this doesnt do suggestions
elder plinth
gemini does have like a 30-40 pr limit daily I think
could tell it to in the style guide no?
arent suggestions just a formatting thing on the code block
austere talon
I deliberately made them not required so we can immediately see if someone is stupid
LOL
based gemini
forcing feature request openers to work on their suggestion themselves
based ngl
charred monolithBOT
torpid mason
false, pledging to fix stuff and taking the workload of from you is very bad
twilit vector
Some plugins may sometimes break, but we have automatic tracking for that
ehhhhhhhhhh
what about the 6 or so half-broken-half-unbroken plugins currently
gritty iris
can it close prs?
gritty iris
but my ass will not look at that shit
we have a forum for that and I also dont read it
🔥
gritty iris
but the ai can tell people off for you
just like my favorite comment
"this is most likely ai" - gemini
austere talon
name something more aura than gemini telling you your pr is aislop
gritty iris
I know right 😭
austere talon
"this is most likely ai" - gemini
lmaooo same thought
gritty iris
I was laughing so hard when I saw it comment that
jagged cloak
its certainly funnier than ai trying to detecting other ai's writing (turnitin etc)
mfw fully human written paper is 10% plausible but the teachers dont know how to interpret that
chrome coral
@austere talon btw what r we gonna do with credentials do would I need to just give them to u to add 
chrome coral
have u even managed to publish it to safari store yet
its on testflight publicly rn, its the appstore but for beta testing and apps expire in 90 days
the appstore reviewer needs to login to discord for every submission, and it changes reviewer every time
I cant approve login requests every time, so i opted to publish on testflight since theyre super lenient
austere talon
the appstore reviewer needs to login to discord for every submission, and it cha...
insane
austere talon
I cant approve login requests every time, so i opted to publish on testflight si...
mehh
isnt that size limited etc
chrome coral
isnt that size limited etc
I have it set to unlimited (apparently its hardcapped at 10k? dont take my word on that)
auto updates are still available and such, and with how often vencord updates I dont think the expiry issue will be a problem
much lower than I thought, but honestly I dont know if I want to suffer trying to get the reviewers to login to an account just to test each update
I'll try once again to get them logged in but its so annoying
austere talon
how many people would even be able to install from testflight
isnt that an alpha thing dont u have to opt into smth for that
austere talon
I'll try once again to get them logged in but its so annoying
partially why I stopped supporting firefox extension
if safari ext is going to be pain then i dont really want it tbh 
i have ptsd from mozilla maintainers 😭
chrome coral
how many people would even be able to install from testflight
10k users can join the public group
austere talon
isnt that use case against testflight rules though
I'm sure they didn't mean it to be used as standard distribution channel
they might ban no?
chrome coral
idk if it really matters tbh
I was thinking if theyre able to login the first time and they approve it'll be fine afterwards because there are discord clients on the appstore
we can wait a few days and see what happens
austere talon
I prefer minimising third party dependencies
lowkey just fee the action's code into claude + your input variables and tell it to give you bash script that does the same
# Setup Certificates
KEYCHAIN_NAME="build.keychain"
KEYCHAIN_PASSWORD=$(openssl rand -base64 32)
P12_FILE=$(mktemp)
# Decode base64 p12 certificate and save to temp file
echo "${{ secrets.APP_STORE_CONNECT_P12 }}" | base64 --decode > "$P12_FILE"
# Create temporary keychain
security create-keychain -p "$KEYCHAIN_PASSWORD" "$KEYCHAIN_NAME"
# Set keychain timeout to 6 hours
security set-keychain-settings -lut 21600 "$KEYCHAIN_NAME"
# Unlock the keychain
security unlock-keychain -p "$KEYCHAIN_PASSWORD" "$KEYCHAIN_NAME"
# Import certificate into keychain
security import "$P12_FILE" \
-k "$KEYCHAIN_NAME" \
-f pkcs12 \
-T /usr/bin/codesign \
-T /usr/bin/security \
-T /usr/bin/pkgbuild \
-T /usr/bin/productbuild \
-T /usr/bin/productsign \
-P "${{ secrets.APP_STORE_CONNECT_P12_PASS }}"
# Set partition list
security set-key-partition-list \
-S apple-tool:,apple: \
-k "$KEYCHAIN_PASSWORD" \
"$KEYCHAIN_NAME"
# Update keychain search list
security list-keychains -d user -s "$KEYCHAIN_NAME" login.keychain
# Clean up temp p12 file
rm -f "$P12_FILE"
# Optional: At the end of your workflow, delete the temporary keychain
# security delete-keychain "$KEYCHAIN_NAME"
vencord safari*
chrome coral
we're only talking about vencord for safari in this convo
jagged cloak
icic
chilly gyro
how many mac vesktop users do u think even exist
Me for one
twilit vector
how many mac vesktop users do u think even exist
one of the reasons why i'm awaiting vencord analytics 
chrome coral
one of the reasons why i'm awaiting vencord analytics <:GatoMalicioso:1442806707...
github provides download stats
go look at that
unsurprisingly mac is the least
fossil inlet
wtf is an exe blockmap
chrome coral
something electron builder generates idk
signal sundial
wtf is an exe blockmap
vai
nimble pendantBOT
vai
An exe blockmap is a metadata file, usually in XML format, that describes the blocks of data within an executable or application package. It contains cryptographic hashes for each data block and file locations. Its main purposes are to enable efficient differential updates, allowing only changed parts of a file to be downloaded, and to verify file integrity.
-# Response generated by gemini-2.5-flash. AI may be incorrect or misleading.
charred monolithBOT
limber skiff
how does one fix the drag issue
twilit vector
la css
or is that a genuine question cus then it's just body {app-region: no-drag;}
limber skiff
ya I got it
austere talon
bookies caught not updating..
fossil inlet
bookies
limber skiff
havent pulled in 2 days 😭
charred monolithBOT
Security: Using eval() on strings from settings is a critical security risk. It allows for arbitrary code execution (Self-XSS) if malicious content is placed in the settings. This should be replaced with a safer logic evaluator or a predefined set of supported conditions.
Hardcoded Discord class name detected. Using static class names like layer_bc663c is brittle as they change frequently with Discord updates. This should be mapped in modules.ts using findCssClassesLazy or identified via a more stable attribute selector.
Minor formatting issue: missing space after the comma in the import statement.
import { getCurrentLabels, ICONS, PANEL_COUNT } from "./constants";
Performance: getShortcutSets() creates new Set objects for every panel on every call. Since this is called inside tickKeyboardShortcuts which runs on every keydown event, it's better to cache these sets and only update them when settings change.
Redundant DOM query. You already have a reference to the newly created element in the toolbar variable.
toolbarElement = toolbar;
twilit vector
mate please it's ai slop
elder plinth
me when I review a comment: why am I a reviewer
torpid mason
what even is that pr bro
torpid mason
me when im just chasing glowy greenery:
charred monolithBOT
charred monolithBOT
twilit vector
thorogoat
gritty iris
thorogoat
I had friendssince fixed for awhile
lowkey forgot it was from friendssince tho
half of that pr is useless to vencord but its whatever 
charred monolithBOT
Using a hardcoded string like "UserProfileSidebar" as a find anchor is less robust than using an internationalization key, as it's more likely to appear in multiple modules or be changed/removed by Discord. Since the match regex already depends on #{intl::USER_PROFILE_MEMBER_SINCE}, using that as the find string would be more specific and maintainable.
find: "#{intl::USER_PROFILE_MEMBE...do we have a vencord icon svg 
twilit vector
well lmao
charred monolithBOT
To address the rendering issues mentioned (weird holes) and improve code maintainability, you should wrap the paths in a <g> element with fillRule="evenodd". Design tools often require the evenodd fill rule to correctly render subtracted shapes (holes). This also allows you to define the fill prop once for the entire group.
export function VencordIcon(props: IconProps) {
return (
<Icon
...
The Menu.MenuItem component in the provided type definitions (packages/discord-types/src/menu.d.ts) uses the prop name icon, not iconLeft. Using iconLeft will likely result in the icons not being displayed in the settings menu.
const icon = SECTION_ICONS[key];
items.push(
<Menu.MenuItem
key={key}
label=...
austere talon
gritty iris
lol https://github.com/Vencord/vencord.dev/blob/main/public/assets/favicon.png
thats a png 😔
its what I threw at adobe
thats what adobes thing did
austere talon
@gritty iris if u feel like fixing more
FullSearchContext doesnt work, CallTimer doesnt work sometimes due to some voice panel experiment
austere talon
does this also fix the top stuff not being categorised?
gritty iris
does this also fix the top stuff not being categorised?
nop
that stuff just isnt in a category
do you want me to add it too one?
austere talon
it should be
gritty iris
also what experiment
austere talon
its just a bug
austere talon
also what experiment
lol idk
gritty iris
its just a bug
its literally not in a category
I was checking for them when I was logging item they werent there
what should I name the section?
austere talon
probably
gritty iris
ill do account settings
wait it does have one
its just getting ignored 😭
why did it log until I logged list wtf
oh label is undefined
gritty iris
probably
I can move profiles and the developer settings and logout into a section
do you want me to leave as is?
idk how to get rid of the bar but if I map both profiles will do it Edit Profiles and the 2 bottom settings into Misc...
idk how to spell misc fully
im thinking leaving profiles out is fine
just ignore the equicord settings
used intl keys
fullsearchcontext seems fine?
oh wait
I read the wrong line
twilit vector
fullsearchcontext seems fine?
insane search pull
charred monolithBOT
charred monolithBOT
The find string includes a leading backtick (`). This makes the patch brittle because minifiers may convert template literals into regular strings (using " or ') depending on the build configuration and whether the string contains interpolations. Removing the backtick and searching for the string content directly is more robust as it will match both template literals and regular strings.
...@austere talon above has calltimer and fullsearchcontext
twilit vector
vee's gaming 
gritty iris
🔥
austere talon
vee's gaming <:xdd:1373700821874642944>
lie
gritty iris
anymore bugs??
:)
I dont want to fix our betterfolders stuff so I will do literally anything else nvm all of our bugs were fixed
austere talon
lie
I played that one trapper game then closed the game @twilit vector
I'll play some more later
either trapper or pig
twilit vector
spoken like a true killer main
austere talon
why would he need nerfs 😭
ultimately he still needs to m1 chase to down you
he's only oppressive if the player is crazy and gets insane bodyblocks
twilit vector
he's able to ignore dead hard (especially if ur healthy), and can deep wound you from like the opposite side of a rock
well ngl i'm larping as a surv main cus i LOVE doing that
austere talon
legion also does that and he still sucks balls
twilit vector
legion got no mobility 💔
austere talon
the only reason ghoul is "broken" is because the average survivor is terrible at the game so you can follow up the free injury in like 15 seconds and because he can do this while having good map control
twilit vector
i guess bro but being able to launch yourself across the map (especially if you have 3 charges/you're doing a flinging trick off a rock ledge or sth) is way crazier than Murderous Teen Go Stab
austere talon
play ghoul against actually good players and it won't be as easy
twilit vector
that one trickster vaultblock perk has been doing wonders
gritty iris
ghoul is good on some maps and walled maps hes bad imo
austere talon
crowd control
twilit vector
oh right
#👾-core-development message the bullshit that lets me hit behind a wall will save me ❤️
gritty iris
v any idea whats adding the line?
austere talon
is it a separator or a group
gritty iris
removed map for util section
so just push
should I move them to actual menu items?
austere talon
ghoul definitely strong but not broken
gritty iris
I got him because of tokyo ghoul I dont play him tho
twilit vector
i got him because of the ridiculous hits during reveal ptb & awesome feedback from perfect timing on m2 hits
gritty iris
im so sorry vee this looks like ass
twilit vector
I don't like ghoul because he's so fucking corny 😭
*incoherent noises of suffering*
*cracks finger for some reason*
-# i might be making every tg fan frown oops
austere talon
does this even work 😭
yes but itll name them r and i
gritty iris
alr
gritty iris
yes but itll name them r and i
should I move playground and such into the misc section?
gritty iris
yes but itll name them r and i
I just want you to know this code looks like a war crime
but it works
twilit vector
mountain icon is cute
twilit vector
yeah this would be a good merge
charred monolithBOT
somber ginkgo
is IS_STANDALONE supposed to be hardcoded in the buildWeb script? https://github.com/Vendicated/Vencord/blame/698e156e71628f1daeb02e80bb4ec911d7da9053/scripts/build/buildWeb.mjs#L47
does it not just negate certain devtools on web and make buildWebStandalone pointless? https://github.com/Vendicated/Vencord/blob/698e156e71628f1daeb02e80bb4ec911d7da9053/src/plugins/_core/settings.tsx#L211
austere talon
who tf deving web
somber ginkgo
was just an inconsistency i noticed
charred monolithBOT
By unhardcoding IS_STANDALONE in commonOptions, this value is now inherited by all build targets in this file, including the extension and userscript. Since these targets are not 'standalone' environments (they are injected into Discord), they should ideally have IS_STANDALONE set to false.
You should consider explicitly overriding IS_STANDALONE: "false" in the define blocks for the extension (lines 92-95) and userscrip...
signal sundial
who tf deving web
me i used to
somber ginkgo
me i used to
austere talon
ignore the clanker
somber ginkgo
already did xdd
austere talon
is `IS_STANDALONE` supposed to be hardcoded in the buildWeb script? https://gith...
i think the fact that this went unnoticed for years speaks volumes
charred monolithBOT
charred monolithBOT
charred monolithBOT
The !hasNitroSubscription() check is redundant here because the parent patch object already has this predicate defined at line 199. If the parent predicate returns false, this replacement will not be evaluated.
predicate: () => settings.store.enableStickerBypass
The !hasNitroSubscription() check is redundant here because the parent patch object already has this predicate defined at line 332.
predicate: () => (settings.store.transformEmojis || settings.store.transformStickers),
The !hasNitroSubscription() check is redundant here as it is already covered by the parent patch's predicate at line 199.
predicate: () => settings.store.enableStreamQualityBypass
The !hasNitroSubscription() check is redundant here because the parent patch object already has this predicate defined at line 332.
predicate: () => settings.store.transformEmojis,
The !hasNitroSubscription() check is redundant here as it is already covered by the parent patch's predicate at line 199.
predicate: () => settings.store.enableStreamQualityBypass
jagged cloak
who are you that video is muted
charred monolithBOT
charred monolithBOT
To maintain consistency with the official Discord web app and Vesktop, it's recommended to include the pending friend request count in the total. You can use RelationshipStore.getPendingCount() for this. Since you mentioned you might want to hide them, perhaps this could be a plugin setting in the future, but the default should ideally match native behavior.
The current list of events is missing several cases where the mention count might change. Consider adding MESSAGE_DELETE, MESSAGE_DELETE_BULK, MESSAGE_UPDATE, and BULK_ACK (for 'Mark as Read' on folders/guilds) to ensure the counter stays in sync with the actual state.
const EVENTS = ["MESSAGE_CREATE", "MESSAGE_ACK", "MESSAGE_DELETE", "MESSAGE_DELETE_BULK", "MESSAGE_UPDATE", "BULK_ACK", "CHANNEL_SEL...
Windows 11 24H2 is the version that re-introduced the small taskbar buttons and 'never combine' features. 26H2 is likely a typo as it hasn't been released or announced yet.
On Windows 10 (and Windows 11 24H2) turn on Small Taskbar Buttons and set Combine taskbar buttons to something other than always hide labels.
jagged cloak
me when windhawk for some reason
charred monolithBOT
Calling a React component as a function (e.g., $self.LockIcon()) is an anti-pattern that bypasses React's reconciliation and lifecycle management. Additionally, the previous version returned the component reference ($self.LockIcon). If the patched code expects a component to be rendered later (e.g., <Icon />), returning an element here will cause a runtime crash. If an element is truly required, use `React.createElement...
The regex switch\((\i)\.type\) is significantly broader than the previous version and may match unintended locations within the module. It is recommended to include more context in the match (like the previous isNSFW check) to ensure the patch is applied only to the correct switch statement.
match: /(?<=(\i)\.isNSFW\(\);)switch\(\i\.type\)/,
Including permissionOverwrites (an object) in the useEffect dependency array can lead to unnecessary re-executions of the effect. In Discord, channel objects are frequently recreated, meaning permissionOverwrites might have a new reference even if its content hasn't changed. Since this effect dispatches a Flux action and updates state, this could impact performance. Consider using a more stable dependency or a deep ...
The use of the comma operator here (${m},$self.isHiddenChannel...) is potentially dangerous. If this patch targets a property value (e.g., icon: originalValue), the expression will evaluate to the last part. This means for non-hidden channels, the expression evaluates to null, which would hide the icon for all normal channels. If the goal is to replace the icon when hidden, a ternary is safer: `$self.isHiddenChannel(${c...
twilit vector
vee would just ctrl + h
charred monolithBOT
Inconsistent use of single quotes for the Button component import. Other imports in this file and throughout the project use double quotes. Please use double quotes for consistency.
import { Button } from "@components/Button";
Inconsistent use of BaseText with tag="h2". In other parts of this refactor, headings are replaced with the Heading component. Please use Heading here for consistency with the rest of the project.
<Heading tag="h2" size="lg" weight="semibold">No permissions to display!</Heading>
The mapping of Button.Colors.PRIMARY to variant="secondary" seems incorrect, as PRIMARY is mapped to primary in other refactored files. This will change the visual emphasis of the button. Additionally, size="medium" is a significant reduction from XLARGE; please verify if this change was intended.
variant="primary"
size="medium"
hollow musk
so like are we gonna address the gemini in the room
charred monolithBOT
These entries contain trailing semicolons (e.g., "nigger;"), which will prevent them from matching the intended words unless a semicolon is explicitly present in the message. You should remove the trailing semicolons here and on line 150.
"nigger",
"nigur",
"niiger",
"niigr",
The Flux interceptor runs for every single action dispatched in the client. To minimize performance impact, you should check the event type and settings at the very beginning of the callback to avoid unnecessary overhead for unrelated events.
findByProps("_dispatch").addInterceptor(e => {
if (e.type !== "MESSAGE_CREATE" && e.type !== "MESSAGE_UPDATE") return;
switch (settings.store.ver...
The banlist processing, sorting, and regex compilation are currently performed inside the message handlers, meaning they run every time a message is created or updated. This is a significant performance bottleneck. Additionally, the setup logic is duplicated between robloxVersion and hardVersion.
Refactor the code to pre-compile the patterns at the top level of the file. Important: Remove the g (global) flag from t...
The value for 'Hard Version' is set to 1, which is identical to 'Roblox Version'. This will cause a conflict in the settings menu and prevents the logic in the start function (which expects case 2 for the hard version) from being reachable.
{ label: "Hard Version", value: 2 }
Splitting the message content by non-alphanumeric characters prevents the 'Roblox Version' filter from matching banned phrases that contain spaces or special characters (e.g., 'Ass Monkey' or 'f u c k' in your banlist). These will be split into separate parts and fail the regex check.
prime dew
brazen bone
Love when prs explicitly list "It also adds a new developer entry to the constants file." as if anyone gives a shit
austere talon
Love when prs explicitly list "It also adds a new developer entry to the constan...
that's because they didn't write that
that's their claude output
they just copy pasted or maybe even made Claude create the pr
austere talon
they also often include a "test plan" which basically is just ai telling a human how to test it
chilly gyro
bro hard coded them all......
"The plugin normalizes words to catch common obfuscations (e.g., replacing 0 with o, 1/l with i)." my balls
torpid mason
😭
charred monolithBOT
bright island
dear lord gemini
twilit vector
oh wow
jagged cloak
nuke
specifically gemini and copilot
claude costs too much for dumb people to use nowadays
fossil inlet
specifically gemini and copilot
jagged cloak
nop
i will keep hating on gemini because i dont like google
xd
does ur gemini do this i didnt think so
fossil inlet
i will keep hating on gemini because i dont like google
fair
twilit vector
nyako on a roll
charred monolithBOT
If modalScrollerRef.current is a React component instance rather than a DOM element (and does not implement getScrollerNode), modalScroller will resolve to that component instance. Passing a non-Element to ResizeObserver.observe() will throw a runtime TypeError.
To prevent potential runtime crashes and ensure defensive programming, we should verify that modalScroller is an instance of Element before observing...
fossil inlet
holy slop
austere talon
aiception
charred monolithBOT
astral bone
⭐
charred monolithBOT
twilit vector
"v2" we are witnessing a new era 👀
spice python
vendroidenhanced competition
charred monolithBOT
There is an extra literal space before the {" "} expression (i.e., </kbd> {" "}). This is redundant and can be cleaned up to just </kbd>{" "} to keep the JSX clean and avoid potential rendering/spacing inconsistencies.
<kbd className={KbdStyles.key}>{modKey}</kbd>{" "}
<kbd className={KbdStyles.key}>{altKey}</kbd>{" "}
errant nacelle
most useful gemini review
chilly gyro
What
charred monolithBOT
Use Vencord's built-in contextMenus API instead of raw string patches.
Raw string patches on menus are fragile and prone to breaking when Discord updates. Additionally, calling the React component renderClearMentionsMenuItem() as a function inside the patch is a React anti-pattern that breaks the React lifecycle and prevents the ErrorBoundary from catching errors.
Using the contextMenus API is much cleaner, more rob...
Deduplicate the channels by channelId before dispatching BULK_ACK.
Currently, if there are multiple mentions in the same channel, this sends redundant ack requests for the same channel. Since the API returns mentions in reverse chronological order (newest first), we can keep only the first occurrence of each channelId to ack the latest message and mark the channel as read. This reduces the payload size and avoids r...
Add a guard to check if RecentMentionUtils.deleteRecentMention is a function before calling it.
Since RecentMentionUtils is loaded lazily via findByPropsLazy, it might be undefined or missing the method if Discord updates its internal modules. Adding a check prevents a generic TypeError and allows throwing a descriptive error.
async function dismissMention(messageId: string) {
try {
await RestAPI...
If a user has multiple recent mentions within the same channel, mapping all of them directly will result in duplicate channel entries being dispatched in BULK_ACK. Since acking a newer message automatically marks all older messages in that channel as read, we can optimize this by deduplicating the channels and only keeping the latest mention per channel. This reduces redundant dispatches and unnecessary processing overh...
jagged cloak
proves that ain't nobody read before submitting prs
twilit vector
truthnuke
well
the "plz no ai" for contributing.md is in dev branch for some reason
jagged cloak
where merg
twilit vector
just search no-more-aislop-plox in here tbh
kindred tree
charred monolithBOT
charred monolithBOT
To prevent potential runtime crashes if description is undefined or does not contain the expected delimiter, we should add a defensive check and safely destructure the split result.
renderDescription: ErrorBoundary.wrap(({ session, description }: { session: Session, description?: string; }) => {
if (!description) return null;
const [label, timeLabel] = description.split(" \\xb7 ");
The patch does not capture the local variable representing the description text (matched by \i), which means description is not passed to renderDescription and will be undefined. This will cause a runtime TypeError when calling description.split(...) inside renderDescription.
We should capture the variable name using a capture group (\i) and pass it as description:$2 in the replacement.
...beat these people with heavy hammers
gritty iris
@austere talon
the deletion is intended
ill ss the module rq
it needs to replace from i the n
both are labels
i is label n is sublabel
ill cap it rq
alright just fixed it
charred monolithBOT
gritty iris
vee
themeattributes 🥀
all of them are in that pr
also I dont think bettersessions was on main yet 😭
jagged cloak
who is that
twilit vector
vencloud seems to be exploding
twilit vector
vencloud has exploded*
gritty iris
vencloud has exploded*
vencord has exploded*
I dont think anything is actually wrong just funny
ye same 525
rotund canopy
Can someone review this maybe pls? https://github.com/Vendicated/Vencord/pull/3430
twilit vector
in due time
chrome coral
To me action/dep bumps just seem lile contribution farming 
if the actions work they work
fossil inlet
To me action/dep bumps just seem lile contribution farming <:claude:150296700910...
i'd like to think their intentions were pure
chrome coral
I dont doubt
twilit vector
oh it's aspy
yeah doubt it was farming
twilit vector
unable to click out of server owner popup in serverinfo, tapping esc fixes
even if clicking outside the modal
twilit vector
fun
gritty iris
charred monolithBOT
twilit vector
to vencloud (look at the repo the issue is in)
rotund canopy
to vencloud (look at the repo the issue is in)
So it would seem
twilit vector
known bugs so far
- TypingTweaks (everyone, stable)
- AccountPanelServerProfile (occasionally)
- BetterSettings (some plugins missing from context menu -> plugins)
fossil inlet
known bugs so far
- TypingTweaks (everyone, stable)
- AccountPanelServerProfile ...
Did discord push an update recently
guhhhhh
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/f8break/index.ts#L37...
index.ts: Lines 37-40
if (e.code === "F8") {
// Hi! You've just paused the client. Pressing F8 in DevTools or in the main window will unpause it again.
// It's up to you on what to do, friend. Happy travels!
debugger;
oh lewi you're adorable
jagged cloak
hi youve just paused the client
hybrid blaze
how dare you
gritty iris
known bugs so far
- TypingTweaks (everyone, stable)
- AccountPanelServerProfile ...
whats wrong with friendssince?
call timer and fullsearchcontext are both pred already
gritty iris
experiment I wonder
gritty iris
it just doesnt appear for some people
any specific part of ui
or all?
dm sidebar was edited last week by me
idk if my pr fixes bettersettings
gritty iris
?
twilit vector
i completely missed #👾-core-development message
twilit vector
known bugs so far
- TypingTweaks (everyone, stable)
- AccountPanelServerProfile ...
fixed 😭
twilit vector
customrpc
gritty iris
not even in search
I gotchu
austere talon
not even in search
because it has no settings manageable by the context menu
deliberately filtered out
twilit vector
oh
austere talon
the menu only includes plugins with settings because otherwise it'd be too long
twilit vector
why not make it show, but clicking opens its full settings?
i find that easier than having to click & scroll a bunch for the same goal
thoro typing out entire rewrite of vencod
gritty iris
twilit vector
i knew it 😭
gritty iris
keeping it going so I can test typing tweaks
I got the rewrite dw
its uh
when discord opens it install teamspeak 6
well I meant I got it to align this time
I have no idea what its doing but I mean hey
ay
twilit vector
they seem ight as rain to me
gritty iris
alr
twilit vector
pic is on the other side of the planet but otherwise looks good to me
gritty iris
pic is on the other side of the planet but otherwise looks good to me
please dumb that down
I dont have the caffeine for that
oh the gap?
twilit vector
nah gap is normal i think
gritty iris
its ugly tho
twilit vector
oh now it looks good
twilit vector
i'd say no because it would just look ugly
twilit vector
everything's perfectly aligned as is so yknow
twilit vector
Just Make ur Channel List larger Lol
twilit vector
i think it'd be nice to put friendsince right beside their registration date
^ side profile in dm
gritty iris
am I touching better settings or no?
gritty iris
whats wrong with AccountPanelServerProfile
gritty iris
I mentioned it awhile ago
you have to open a profile for it lol
idk why I never looked lol
charred monolithBOT
austere talon
because its useless
gritty iris
^
twilit vector
incredible
gritty iris
it only decodes like 5 of the errors I get
in the past month ive been able to find the file 5 times
its like githubs status page
gritty iris
I'm looking at account server something something rn btw
austere talon
it just needs to load lazy module probably
these issues are hard to find if you use BetterSettings because it preloads a lot of modules
gritty iris
it just needs to load lazy module probably
It is lazy lol
Also it happens with better settings
gritty iris
what the fuck did I do 😭
austere talon
what the fuck did I do 😭
u cant make react components async lmao
gritty iris
aw I cant extract lazy?
austere talon
grave mangoBOT
do like this https://github.com/Vendicated/Vencord/blob/main/src/plugins/shikiCo...
Highlighter.tsx: Lines 46-63
let didLoadHljs = false;
export const HighlighterContainer = (props: HighlighterProps) => {
const [_, _err, isPending] = useAwaiter(requireHljs);
useEffect(() => {
if (!isPending) didLoadHljs = true;
}, [isPending]);
if (!didLoadHljs && isPending) return null;
return (
<pre className={cl("container")}>
<ErrorBoundary>
<Highlighter {...props} />
</ErrorBoundary>
</pre>
);
};
charred monolithBOT
gritty iris
just bad find?
technically no
we were finding solely user profule
one 1s canary is lagging its heart out
I just made it go for this
589022
ill check if its fine without bettersettings
ye its good without it
this module uses 4 different profiles
insane amount but anyways
d is userprofile
gritty iris
I mean atleast it doesnt need extract chunks
charred monolithBOT
austere talon
iull push this for now
gritty iris
there was no promise in the profile so it was annoying me
twilit vector
v1.15 when
austere talon
I hate git
ask gemini to fix conflicts
gritty iris
oh no its easy conflicts lol
type of conflicts tho
it got mad over equicorddevs being in typingtweaks import
gritty iris
type of conflicts tho
guess its a good thing I changed it last second lol
yk it feels great to not have gemini in my email
fossil inlet
I hate git
What program even is that
gritty iris
What program even is that
We don't talk about that
I was never told there was a program called git when I started coding
So I googled GitHub repo manager and found gh desktop
And I just never stopped using it because it's easy
fossil inlet
time for me to shill
gritty iris
Terrible for anything off gh tho
gritty iris
Nah I'd only use smth like gh desktop at this point
I literally just type gh into my search bar lol
It's kinda ingrained into my flow
fossil inlet
The custom patch feature of lazygit is invaluable to me
You can create a custom patch from a commit and then apply or revert it anywhere
gritty iris
I just open up cmd run the cmd atp
fossil inlet
The custom patch can be whole files, lines or anything in between
fossil inlet
I just open up cmd run the cmd atp
git CLI can't do this (easily)
elder plinth
lol. lmao even
charred monolithBOT
elder plinth
make a bot that auto closes when the checkboxes aren't checked
gritty iris
make a bot that auto closes when the checkboxes aren't checked
But I don't wanna fill it out
I went out of my way to delete the entire description
twilit vector
- [x] I've searched existing issues and this hasn't been reported before
charred monolithBOT
signal sundial
@austere talon how do you expect illiterate users to distinguish between a modification feature vs a plugin request
charred monolithBOT
twilit vector
errant nacelle
Author set to 1400hertz.
so kind of them
signal sundial
🇹🇷
fork found in kitchen
hybrid blaze
charred monolithBOT
austere talon
need to make a bot that uses ai to determine if a pr/issue is stupid and auto closes
twilit vector
make gemini do it
weak thistle
shrimply auto close prs by randoms and if it ends up being worth merging reopen
signal sundial
need to make a bot that uses ai to determine if a pr/issue is stupid and auto cl...
first off you can clear anything not following tmplate
or with invalid/ too old license header
twilit vector
old being anything under current year
REAL coders take great PRIDE AND CARE in their submission
gritty iris
need to make a bot that uses ai to determine if a pr/issue is stupid and auto cl...
am I gonna watch half my prs get closed
also feed it vencords prs be like
this list bad:
this list good:
@twilit vector I hope it auto closes yours if you ever make any </3
harassment I need an adult
signal sundial
thororen is like eleven
charred monolithBOT
charred monolithBOT
signal sundial
@tacit light
signal sundial
well do i have a choice
twilit vector
i guess bro
signal sundial
@austere talon I’m gonna ask you not to use slurs, thank you
chrome coral
lets hope this doesnt end up in an unnecessary argument
charred monolithBOT
signal sundial
lets hope this doesnt end up in an unnecessary argument
well well well
twilit vector
genuinely 0 thought in this message
twilit vector
2642 😭
weary bolt
wha about it?
twilit vector
funny ancient pr still being fixed with love