#πŸ‘Ύ-core-development

1 messages Β· Page 254 of 1

charred monolithBOT
scenic brook
#

I don't think passive aggression is very motivating tbh

north knoll
#

neither is doing everything under the sun to try and get this plugin merged for dozens of users who have been waiting on this for over a year; pretty exhausting putting this much time into it only for it to be completely ignored

scenic brook
#

I get it but if I were a maintainer and got that message it'd just make me wanna review it less

north knoll
#

if any maintainer is actively sitting on their role and letting prs go unreviewed for this long to the point where contributors are [pulling out from the lack of interest](#πŸ‘Ύ-core-development message), then clearly they already have little to no interest in actively maintaining an OSS project

jolly egret
#

I think you are forgetting that its free, theres a standard of quality to maintain, this project because of discord moves quite quickly, and that the maintainers can put as much or as little time as they want into this

#

Do not be a dick simply because you don't get your way, please be respectful

granite wharf
#

I'd argue a lot of this comes from only having one person that is actually qualified to do a proper review (vending.machine), well and nucky but they mainly do fixes more than introducing more plugins

#

If you want something to get merged faster realistically have other people to review your code so theres more confirmation that its truly ready to be merged

scenic brook
#

I get the frustration, I have a bunch of PRs open and am not really bothering working on any more because I don't want to end up with like 10 PRs sitting there, but at the same time it's not that big a deal, I've put my shit out there and if it goes it goes, if not then suffoPeepoShrug

scenic brook
charred monolithBOT
charred monolithBOT
desert cosmos
# charred monolith

i dont really see the reason to have two of the same components in vencord

dusk blaze
#

true

#

but as of right now vencord notifications kinda feels off they could use some work

charred monolithBOT
#

wouldnt it be easier to just reuse the notification component that is already available via vencord instead of adding a component that does generally the same

See previous response: https://github.com/Vendicated/Vencord/pull/1806#issuecomment-1793610778

Though this notification component now functions and behaves quite differently than Vencord's one. For the purpose of this plugin, I think it's justified to have it's own very lightweight notification container.

pine topaz
idle fossil
#

notify discord of it so they get a c&d blobcatcozy

pine topaz
#

we should report the repo trolley

austere talon
#

?

charred monolithBOT
charred monolithBOT
austere talon
#

the latter obviously

charred monolithBOT
limber skiff
charred monolithBOT
limber skiff
#

@jagged reef some initial things for you to look out, ill do a more detailed review another time

jagged reef
#

Perfect

limber skiff
#

I meant CUSTOM OptionType

#

iirc

jolly egret
#

IrcColors makes names in chat with users with gradient roles invisible btw

jagged reef
jagged cloak
#

which one

#

one of the two PRs for the option type that didnt get merged iirc

#

xd

#

or maybe they did I dont remember

still maple
#

bruh i'm a mod but i can't jump to a message because likely a scammer ??? WTF is discord doing
i would guess this needs a patch similar to nounblocktojump ?

fossil inlet
still maple
fossil inlet
#

wait im stupid its a user, not a message

limber skiff
#

can prob just search for the string to find where it happens

fossil inlet
#

yeah, but i'm lazy

limber skiff
#

takes less time than having the message or user lol

still maple
#

the user is pinged in the general sadan

fossil inlet
#

πŸ‘

fossil inlet
#

what the hell are copilot results

brazen bone
#

Ai slop as always

charred monolithBOT
fossil inlet
#

@still maple turns out its already done, just not documented

#

i should start writing good readme's for plugins

still maple
#

I don't think that's true tho

fossil inlet
#

like only a few have them

still maple
#

Because i have the plugin enabled

#

Ans yet i received the popup

#

I'm going back home rn

#

I'll see in the train just in case i'm going wild

fossil inlet
still maple
#

Oh yeah i'm on main not on dev

#

Ig i'll cherry pick it for now

#

Thanks for looking into it

dusk blaze
#

salad is a vibe coder

charred monolithBOT
limber skiff
#

@jolly egret thanks for letting us know

#

vtest dev2

nimble pendantBOT
charred monolithBOT
limber skiff
#

made a typo

nimble pendantBOT
nimble pendantBOT
charred monolithBOT
limber skiff
#

should I make AlwaysAnimate include gradients?

#

hmm

#

maybe another time

jolly egret
# charred monolith

question, would this disable colours in cases where irccolors does not apply? Don't have time to test and i'm shit with stuff like this

limber skiff
jolly egret
limber skiff
#

that patch only targets the chat messages in specific, if that answers your question

#

I see

#

yeah I need to fix that

#

would cause issues for the first option

#

makes it a bit more annoying to patch

limber skiff
#

how hacky is this

#

it did work at least

charred monolithBOT
limber skiff
#

vtest

nimble pendantBOT
austere talon
#

hop off force pushing dev 😭

limber skiff
#

happens

nimble pendantBOT
# limber skiff vtest
Bad Patches

MutualGroupDMs (had no effect):
ID: 661462
Match: ```
/(.tabBarItem.+?variant:)"heading-md/normal"/

Slow Patches

ShowHiddenChannels (took 5.3ms):
ID: 473403
Match: ```
/.subtitle,.+?;(?=return(0,\i.jsxs?))(?<={channel:(\i),name:\i,.+?unread:(\i).+?)/

nimble pendantBOT
jolly egret
#

incredible horror patch

austere talon
limber skiff
#

works so well

austere talon
#
replace: () => `([${hasGradientColors},${colorString}]=$self.doThing())`
#

😭

limber skiff
#

does that work

#

cant wait to force push again

austere talon
#

doThing would return an array with the two values

limber skiff
#

meh

#

I dont wanna make a function to return that

austere talon
#

why

#

it's better than writing so much inline code

limber skiff
#

doesnt work

#

still gotta add the let

#

cuz im doing it in the middle of the original assigments

#

unless]

fossil inlet
#

cant you just find the semicolon and insert it there

limber skiff
#

too late

fossil inlet
#

||havent seen the whole conntext||

limber skiff
#

I dont wanna have to patch this too

fossil inlet
austere talon
#

i added those around it cause i didn't know it was in a variable declaration

#

like

var [foo, bar] = [];
([foo, bar] = []);
limber skiff
#

only the way I sent

#

dumb copilot auto completed wrong

#

and I was wondering why my current code didnt work

austere talon
#

oh yeah it redeclares

austere talon
#

works

limber skiff
#

hmmm

#

still not working

#

the server I was using to test suddenly stopped having gradient colors in chat

limber skiff
#

okay some black magic is happening

#

I check the person -> has gradient colors -> I turn on plugin -> they disappear -> I disable the plugin -> they still disappear

#

??

#

I found the cause

#

if you reload your client with the chat open and the person has gradients, they just stop working

#

you need to be outside the chat once your client loads

#

no comments.

charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
nimble pendantBOT
# limber skiff vtest dev2
Bad Patches

MutualGroupDMs (had no effect):
ID: 661462
Match: ```
/(.tabBarItem.+?variant:)"heading-md/normal"/

Slow Patches

WebContextMenus (took 11ms):
ID: 805362
Match: ```
/return \i.\i(?=?|&&)/

nimble pendantBOT
charred monolithBOT
limber skiff
# nimble pendant

the failing patch on stable is related to the new profile modal, so it doesn't matter to be failing

austere talon
#

wtf was that find

charred monolithBOT
jagged cloak
#

i would have never suspected irccolors the culprit of that weirdness i thought discord broke something on their side

charred monolithBOT
granite wharf
charred monolithBOT
shadow mango
prime dew
shadow mango
#

i didnt see one

prime dew
shadow mango
#

didnt see that one

shadow mango
#

i have so many plugins that i just made for myself maybe i should publish some

#

discord archiver 9000 not finished but it is my coolest idk if i'll ever finish it

prime dew
#

The ForceClipRecording one is creepy ngl

shadow mango
#

ok

#

every other clip program records audio like normal

#

i didnt like when i would clip something and half of the people would just not be in it

#

but i just use it for my friends i wouldnt publish that one

#

i dont think its on by default

prime dew
#

Also, isn't MemberCount already in Vencord?

#

vp membercount

nimble pendantBOT
prime dew
#

Oh lol, it's yours

shadow mango
#

🦧

#

i worked on it i forgot what i did it was a few years ago

#

is there a good way to get logs from a native.ts

scenic brook
#

Launch discord from command line

shadow mango
#

thanks, got my other plugin working

scenic brook
#

Sick

limber skiff
#

I forgot to merge

jolly egret
#

and now you have to rebase it kek

limber skiff
#

that too lol

fossil inlet
austere talon
#

oh wow

charred monolithBOT
austere talon
#

this is bad fix

#

we need to find a better fix

#

i tried wrapping the entire blacklisting & webpack listener stuff into setImmediate() but that breaks it even worse

charred monolithBOT
austere talon
#

vtest canary

nimble pendantBOT
austere talon
#

vtest dev canary

nimble pendantBOT
nimble pendantBOT
austere talon
#

MenuItemDemanglerAPI broke

#

wait why tf

#

omg

#

reexport

#

no

#

oh it's cause of the fucking shit

#

how even fix this

#

@limber skiff

limber skiff
#

huh

#

explain the issue

austere talon
#

circular reference problem

#

basically

#

whenever new module is registered

#

we iterate all exports

#

but one of discord's modules exports a forwardref that depends on react

#

trying to access this throws an uninitialised error

limber skiff
#

try avoiding iterating if module.loaded isn't true

charred monolithBOT
austere talon
#

this is dirty try catch wrap

austere talon
#

but that's not even the problem

#

it's a reexport

#

it's accessing a reexport of an uninitialised module

limber skiff
#

hence loaded

austere talon
#

it's their gigamodules module

#

that reexports everything

austere talon
#

it's just that that module re-exports a different module that is not loaded

#

here i just wrapped it in a try catch

limber skiff
#

loaded will only be true after all depencies are loaded too

austere talon
limber skiff
#

try it

#

im almost sure that's one of the reasons it exists

#

what's the module id it fails?

austere talon
#

how do you detect when a module has loaded

#

is there any way

limber skiff
#

no

austere talon
#

is there webpack.waitforloaded(1234)

limber skiff
austere talon
#

somehow

#

is it cause module is cleared

limber skiff
#

okay let me see wait

austere talon
#

yeah no this doesn't work

charred monolithBOT
austere talon
#

im gonna push this for now

charred monolithBOT
limber skiff
#

why are you pushing in a hurry

austere talon
#

because this completely breaks the app fr

#

this isn't minor inconvenience this is app literally boots as a whitescreen

limber skiff
#

something is straight up wrong here

#

this happens after the original factory is called

#

which means after this is called

#

which should make m defined

austere talon
#

yeah indeed

#

we already ran the entire module

limber skiff
#

ah

#

which means

#

one of the dependencies of m is requiring the huge exports

austere talon
#

yeah like i said circular import bug

limber skiff
#

ya

austere talon
#

how do we even fix this without try catch

#

we could blacklist the megamodule maybe?

#

lot of finds use the megamodule instead of the original module

limber skiff
#

I'm thinking

#

there has to be a non hacky way

austere talon
#

but the megamodule is just rexporter

#

we could just defer all callbacks to the next tick

#

but this breaks our current webpack search

#

for some reason

#

also that has some issues too

limber skiff
#

did the menu break because of circular import?

#

ahh

#

I see

austere talon
#

gigamodule reexports context menu components

limber skiff
#

okay so

#

the main issue is easy to fix

austere talon
limber skiff
#

you just applied the try catch in the wrong place

#

this is perfect

#

and makes total sense

#

doesnt break checking the other exports, only the circular ones

#

I dont think there's another solution

austere talon
#

okay so basically exactly what I did right now

limber skiff
#

ye

#

and the same for menu

austere talon
#

except move the try catch to a more specific place

limber skiff
#

there's no way to escape this

#

the only way would be checking if every export has been .loaded

austere talon
#

but we sill still need this as is

limber skiff
#

but impossible

#

cuz we dont know the mod ids

limber skiff
#

it's just how it is

austere talon
#

and we need this too

#

well what we could do is only wrap the module access in try catch

#
try {
    var exportValue = exports[exportKey];
} catch {
    continue;
}
if (exportValue != null && filter(exportValue)) {
    waitForSubscriptions.delete(filter);
    callback(exportValue, module.id);
    break;
}
#

like this

limber skiff
#

sure

#

ill do it

austere talon
#

using var like this is so funny

austere talon
#

i wanna push some other stuff too anyway

#

i wanna check updates & refetch badges every 30 minutes

#

rn it only does on startup

limber skiff
#

I wanna clean this solution up tho

austere talon
#

sure

#

just push to dev2 and i will check

limber skiff
#

alr

austere talon
#

dude opening devtools makes discord so laggy

#

it's insane

#

i have to fully close and reopen discord after using devtools to fix the lag

limber skiff
#

but sure

austere talon
#
try {
    var exportValue = exports[exportKey];
} catch {
    continue;
}
```vs
```js
let exportValue;
try {
    exportValue = exports[exportKey];
} catch {
    continue;
}
#

i prefer the first one

fossil inlet
#

what did discord fuck up

austere talon
#

vencord accesses all exports to check them for various things

fossil inlet
#

love

austere talon
#

discord introduced a circular dependency

#

so when you access that export it errors cause not initialised yet

fossil inlet
#

tbh i love how esbuild handles circular deps

when i build vencord with webpack they were hell

austere talon
#

circular deps in general are hell

charred monolithBOT
limber skiff
#

nice typo

austere talon
#

wW

#

the original comment was fine 😭

charred monolithBOT
limber skiff
#

okay this solution seems fine

#

can't escape from it

#

surprised this only turned to be an issue now

austere talon
#

what if

#
const exportValue = tryOrElse(() => exports[exportKey], null);
#

then no try catch is needed

limber skiff
#

it's fine

austere talon
#

okay let me test your commit

limber skiff
#

patching webpack is so complex

austere talon
#

it works

#

looks good to me

limber skiff
#

so many niche cases

austere talon
#

we should verify if there are any other waitFors that iterate exports

#

and also try ctach those

limber skiff
#

none more

austere talon
#

oh

#

thanks

limber skiff
#

does this break bd too

#

it does

austere talon
#

it hallucinated the second one

austere talon
limber skiff
#

they do

austere talon
#

oh

limber skiff
#

shouldSkip accesses it

#

@austere talon bump extension after your commits

austere talon
#

yeee

charred monolithBOT
charred monolithBOT
austere talon
#

oki still works

charred monolithBOT
austere talon
#

making updater changes is so scary cause what if i mess up and it breaks updater

#

it gone

charred monolithBOT
limber skiff
#

ahh right

#

leave it for next release

#

ill review in the next days

#

+remind 3d review

#

peak

austere talon
#

it doesnt really change much

#

just csp

limber skiff
#

i dont know the command

austere talon
#

it's !

limber skiff
#

!remind 3d review

shut vineBOT
#

Alright @limber skiff, in 3 days: review

limber skiff
#

thanks danny

charred monolithBOT
austere talon
#

release? @limber skiff

austere talon
# charred monolith

somehow you forcepushed 92ff9c1 out of existence and it breaks the updater

limber skiff
#

wdym

austere talon
#

idk bro you tell me

limber skiff
#

updater doesnt even support dev tho

austere talon
#

yes but

#

even tho that's a valid real commit

limber skiff
#

gotta be kidding me

austere talon
#

hopefully pushing again will fix it

austere talon
#

should i

#

or anything else

limber skiff
charred monolithBOT
limber skiff
#

github smoking with that issue

charred monolithBOT
austere talon
#

didnt fix

charred monolithBOT
austere talon
#

why is github like this

limber skiff
#

cant do much about it

#

but that's very weird

#

seems like an edge case

charred monolithBOT
#
[Vendicated/Vencord] New tag created: v1.12.1
austere talon
#

how did u achieve that

limber skiff
#

I did nothing differently lol

#

just a normal force push to dev

#

why doesn't the API use the full hash?

austere talon
#

ye it should

limber skiff
#

it prob works with full hash

austere talon
#

it does

limber skiff
#

weird tho

austere talon
#

it shouldn't use short hash yeah

#

we should migrate to long hash

limber skiff
#

change it to use full hash and push

#

no one updated yet probably

austere talon
#

there is no urgency

limber skiff
#

no reason not to rn tho

austere talon
#

okay you're gonna hate this but i have an idea that might work @limber skiff

#

i will try creating a branch called 92ff9c1 with commit 92ff9c1

#

and it might fix it

charred monolithBOT
#
[Vendicated/Vencord] New branch created: 92ff9c1
austere talon
#

IT WORKS

#

lmfao

#

i might be a genius

#

even the commit link works again somehow

#

magic

#

just keep that branch for a while

limber skiff
#

HORRIBLE

#

😭 😭

austere talon
#

i think you force pushing multiple branches to 92ff9c1 at the same time somehow confused github and it assumed it was ambiguous so it gave 404

#

but yeah we really should just not be using short hash

jolly egret
#

lmao

#

crazy

austere talon
fossil inlet
#

guhhh i need to de-dupe my n key

nimble pendantBOT
# granite wharf vds

🟒 API: Operational
🟒 Media Proxy: Operational
🟒 Gateway: Operational
🟑 Push Notifications: Degraded_performance
🟒 Search: Operational
🟒 Voice: Operational

Latest Outage Information

Incident: ⚫ Discord attachments unavailable
Status: πŸ”΄ Investigating
Identified At: N/A
Last Updated: <t:1747172721:F>

Incident: 🟑 Push notifications for muted conversations
Status: πŸ”΄ Investigating
Identified At: N/A
Last Updated: <t:1747171442:F>

granite wharf
#

we will have

#

vvs

#

v vencord status

fossil inlet
granite wharf
#

vtest

nimble pendantBOT
fossil inlet
#

there should be a command that just sends the output of the last run

nimble pendantBOT
nimble pendantBOT
granite wharf
#

m

#

chrome extension users 😒

fossil inlet
#

vext

nimble pendantBOT
fossil inlet
#

update soonℒ️

austere talon
#

i need to make the command better

#

cause rn it's kinda misleading

#

it doesn't say anything about being out of date, it just says if google approved the current update

#

i should make it say like

Google is still reviewing the latest update. 17 commits behind main


10 commits behind main
#

first is if update pending

#

need better message but smth like that

fossil inlet
#

it neneds version numbers too

austere talon
#

duhhh

charred monolithBOT
odd heath
charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
austere talon
#

wait wha

#

oh

#

looks good to me

limber skiff
#

alr

austere talon
#

keep it in dev for now imo

charred monolithBOT
limber skiff
#

okay

odd heath
#

thankis for the push notification

limber skiff
odd heath
#

dont review them just press the funny button and comment lgtm like a true dev

charred monolithBOT
austere talon
#

is "this pull request is closed" without actually closing it not enough of a giveaway

fossil inlet
hollow musk
charred monolithBOT
limber skiff
#

!remind 5h try catch more code in runFactoryWithWrap

shut vineBOT
#

Alright @limber skiff, in 5 hours: try catch more code in runFactoryWithWrap

odd heath
austere talon
limber skiff
#

some things in the blacklist function

#

still doesn't cover all cases that could error for any reason

grizzled halo
#

(I did it anyways)

limber skiff
#

vext

nimble pendantBOT
grizzled halo
#

I can repro (cant send logs however currently)

limber skiff
#

will look into it

charred monolithBOT
limber skiff
#

we have so many circular imports 😭

shut vineBOT
#

@limber skiff, <t:1747234918:R>: try catch more code in runFactoryWithWrap

brazen bone
#

Top tier pr

charred monolithBOT
limber skiff
#

forgot to change a comment

remote violet
#

can someone tell me what VencordAsarPath is supposed to be in gui.go in the installer?

limber skiff
#

who passes a ref as the first prop

#

gotta be kidding me

limber skiff
charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
limber skiff
# charred monolith

also updated shiki languages json to latest commit to attempt to fix it failing to load languages due to github not responding correct to the old commit

#

and I bricked reporter

fossil inlet
#

is it possible to make a plugin require restart without adding a patch

limber skiff
#

why would it need?

scenic brook
limber skiff
#

everything in this ends up being a circular import

#

structural problem 😞

fossil inlet
#

discord designing circular imports just to fuck with vencord

limber skiff
#

no

#

vencord circular imports

fossil inlet
#

love

charred monolithBOT
#

What happens when the bug or crash occurs?

https://discord.com/channels/@me displays a white screen when Vencord extension is installed on Brave.

By UA is: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/136.0.0.0 Safari/537.36 Brave version: Version 1.78.97 Chromium: 136.0.7103.93 (Official Build) (x86_64)

What is the expected behaviour?

Discord loads normally

How do you recreate this bug or crash?

  1. Install the Vencord exte...
limber skiff
#

vtest dev2

nimble pendantBOT
jolly egret
# charred monolith

i don't care about this what i care about is how the fuck are you 3200 commits ahead

nimble pendantBOT
nimble pendantBOT
limber skiff
#

what now

#

vtest dev2

nimble pendantBOT
limber skiff
#

random error?

fossil inlet
limber skiff
#

I just realized I broke the reporter with another change too

nimble pendantBOT
nimble pendantBOT
charred monolithBOT
limber skiff
#

@fossil inlet I changed webpack patcher logger name to WebpackPatcher

#

that might break some thing you did so

#

vtest dev2

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
fossil inlet
charred monolithBOT
limber skiff
#

vtest

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
limber skiff
#

I'll have to wait for their next stable release

#

unless I should break AccountPanelServerProfile in purpose

#

seems fine, I'll wait for tomorrow

fossil inlet
#

i will be productive today and get 3+ prs ready for review blobcatcozy

limber skiff
#

instead review some pr

fossil inlet
#

?remind 5h did you do it

shut vineBOT
#

Alright @fossil inlet, in 5 hours: did you do it

limber skiff
#

one for interesting new plugin

#

or interesting change to one

fossil inlet
limber skiff
#

so new feat

fossil inlet
#

alr

limber skiff
#

vext

nimble pendantBOT
north knoll
scenic brook
opaque silo
#

i love PRing my entire tree

charred monolithBOT
scenic brook
dapper tiger
#

vee so evil

#

they put in so much hard work for it to just be closed

north knoll
#

commit messages in that pr go hard

limber skiff
#

vext

nimble pendantBOT
charred monolithBOT
pine topaz
#

its gone

#

πŸ”₯

#

nvm its venkord now

shut vineBOT
#

@fossil inlet, <t:1747256316:R>: did you do it

fossil inlet
#

nop

#

ate a burrito and watched tv

charred monolithBOT
charred monolithBOT
#

Wait for chrome extension to be updated

could you provide the crx file extension to manually update to the latest version without waiting for publication on the Chrome Web Store? This problem is critical, we have to completely disable the extension in order to use discord.

you can easily build it yourself

requires pnpm and git

git clone https://github.com/Vendicated/Vencord
cd Vencord
pnpm i
pnpm buildWeb
#

you misunderstood me, you're suggesting that I install the extension as "unpacked", if I install it that way, I'll have to manually update and build it. I'm asking you to give me the "crx" file, which can be obtained from the developer's personal account on the Chrome Web Store. Using it, you can manually update the extension without waiting for publication on the Chrome Web Store.

Image

#

You misunderstood me, you're suggesting that I install the extension as "unpacked", if I install it that way, I'll have to manually update and build it if new versions are released. I'm asking you to give me the "crx" file, which can be obtained from the developer's personal account on the Chrome Web Store. Using it, you can manually update the extension without waiting for publication on the Chrome Web Store.

![Image](https://github.com/user-attachments/assets/53873215-6b22-4aa2-b8cd-...

fossil inlet
# charred monolith

No, I’m not a dev and have never touched vencord or anything related, that’s why it says contributor next to my name

charred monolithBOT
desert cosmos
charred monolithBOT
dusk blaze
granite wharf
#

adguars blocking vencord?? 1984

dusk blaze
#

maybe

#

okay no

limber skiff
#

vext

nimble pendantBOT
limber skiff
#

takes so long

grizzled halo
#

they sleepin

austere talon
#

google extension reviewers are busy fighting pakistan

charred monolithBOT
#

This is a working version of Vencord with added support for the Russian language. A new option to select the interface language has been introduced in the settings.

A directory-based system for language files has been implemented, along with a new settings tab for choosing the language. Currently, the content of the main tabs has been translated.

Translations are retrieved using the getLanguage() function from the Language.ts file. This function accepts the directory type (api, `c...

odd heath
#

why did bro change mode on ALL files

austere talon
#

please tell me that's ai

#

i hope they didn't manually do all that effort

charred monolithBOT
grizzled halo
#

Personally it hasn’t happened to me

austere talon
#

yeah it's a vencord issue

charred monolithBOT
austere talon
#

lol how did this code ever work

#

we don't wait for the store

limber skiff
#

yeah

grizzled halo
limber skiff
#

I fixed it yesterday

#

somehow before ThemeStore always loaded fast enough

austere talon
#

ur ErrorBoundary change

limber skiff
#

partially

#

I figured it was a good change either way

#

because of the reason I explained

#

well I'm glad I didnt push 10 mins ago

grizzled halo
#

They’re watching this channel blobcatcozy

austere talon
#
limber skiff
#

it needs a bit of rewrite in the project structure

austere talon
#

😭

#

so bad

limber skiff
#

first a lot of places use imports they shouldnt do, like webpack ones which shit everything

austere talon
#

okay there we go

limber skiff
#

and then the settings api is a huge one too

austere talon
#

first two are fine

#

eh those all look fine

#

it didn't include plugins i think

#

the bad ones aren't included there

#

why did I do this lmfao

austere talon
#

gonna have to create some fake files that import all plugins to get a proper report

#

i have a super easy idea to fix settings circular import @limber skiff

limber skiff
#

which

austere talon
#
// Settings.ts
let Plugins: typeof import("~plugins");

export const _setPlugins = (p) => Plugins = p;

// plugins/index.ts
import { _setPlugins } from "@api/Settings";

_setPlugins(plugins);
#

now settings won't import plugins anymore

charred monolithBOT
#

I am currently on Fedora Workstation 42.
My main user is not in the sudoers list - when sudo is required, i elevate my terminal to root and continue from there.

As of right now, this has not caused me any issues except when trying to install Vencord using the official curl.
My current procedure is to run visudo to temporarily add myself to the sudoers list, install Vencord and then run visudo again to remove myself from the sudoers list.

This is extremely frustrating, especially in comb...

austere talon
#

yeah but it still means you can't use Settings (and have defaults working) on top level

limber skiff
#

yeah

#

hmm

austere talon
#

we can never fix that because of how it's defined

#

the only possible way to fix it would be introducing a new settings.ts file that has to export your settings definition

limber skiff
#

you are right

austere talon
limber skiff
#

but then some settings import components

#

and things boom already

austere talon
#

well if settings import the plugin yeah

#

otherwise it's fine

#

if your settings import from your plugin it will have a circular dependency again but only for your plugin

charred monolithBOT
#

I am currently on Fedora Workstation 42.
Since there is no official RPM for Discord, I am currently using the RPM Fusion release, which works like a charm as is.
When additionally adding Vencord to the mix, I am having an absolute blast using it this way.

The issue arises whenever RPM Fusion pushes an update to Discord, which patches out Vencord entirely every single time.
This mean that I need to manually reinstall and patch in Vencord every other week or so.

This is pretty frustrating, bu...

limber skiff
charred monolithBOT
#

Jesus, that was a quick answer - unfortunately doesn't solve my problem.

Running the CLI directly as my main user:

user@fw16:~/Downloads$ ./VencordInstallerCli-linux 
βœ” Install Vencord
βœ” Stable - /usr/lib64/discord [PATCHED]
INFO  Patching /usr/lib64/discord...
INFO  /usr/lib64/discord is already patched. Unpatching first...
INFO  Unpatching /usr/lib64/discord...
ERROR rename /usr/lib64/discord/resources/app.asar /usr/lib64/discord/resources/app.asar.tmp: permission denied
ERROR rename /...
charred monolithBOT
#

Okay, real talk – I do feel very stupid for not running export SUDO_USER=user before.
Still, I’d appreciate not being talked down to like I’m an utter moron; elitism doesn’t really help anyone here.

To keep the ball rolling - I had two ideas for this now that you set me on the right track.

if the user has used su - before running the CLI installer, then the EUID should be 0 and $SUDO_USER should be empty.
The installer could probably detect that and echo an info text so the user knows...

charred monolithBOT
#

Bruh, no one "talked down to you". I objectively pointed out the error that you missed and told you the solution with no further comment. If that makes you feel like a moron, that's on you.

The installer could probably detect that and echo an info text so the user knows they need to set SUDO_USER before they run into the panic.

That is exactly what that message is for. It's telling you the problem (SUDO_USER is not set) and the solution (set it manually)

Alternatively, since β€œsu - when...

austere talon
#

i don't understand people like this

#

Yes I could add a bunch of filler boilerplate to sound nicer but it's a developer forum, I prefer being efficient and to the point with no bullshit

austere talon
#

@limber skiff are those SHC breakages relevant?

dusk blaze
austere talon
#

it does sound kinda like ai yeah lol

dusk blaze
#

noone talks like that 😭

austere talon
#

but i think some people just talk like that unironically

#

It's mostly the -

#

ai LOOOOVES to add that everywhere

limber skiff
#

but I can fix them

austere talon
#

we should merge into main then

limber skiff
#

do you wanna push?

austere talon
#

the theme stuff is getting many complaints

limber skiff
#

alright just wait a bit then

dusk blaze
#

his other reply uses capitalized I

limber skiff
#

ill fix real quick

#

then we push those as well

austere talon
fossil inlet
granite wharf
austere talon
#

when are u refactoring FakeNitro @limber skiff

#

so it's not a devilbro plugin

limber skiff
#

fakenitro?

#

or shc

austere talon
#

yee

#

fakenitro

#

1000 line file

#

literal devilbro plugin SKULL

#

does anyone even use this plugin

limber skiff
#

1000 line but it's kinda good at least

fossil inlet
austere talon
#

one day nuckyz will add backdoor to vencord and no one will notice just like xzutils

#

or maybe he already did

#

quick someone check the build scripts

fossil inlet
#

insane

austere talon
#

btw messagelogger edit logging is broken apparentlyb

#

ab

limber skiff
#

fixed just not pushed

austere talon
#

ye it is

limber skiff
austere talon
limber skiff
limber skiff
austere talon
#

bro really put it as "other patches" as if these two plugins are even close to being as popular as ML

fossil inlet
limber skiff
#

I didnt realize it was message logger edits

austere talon
#

lmfao

limber skiff
#

I just fixed the single patch that broke from all the plugin

#

lmao

austere talon
#

this patch is crap btw

#

if u want u can improve it with ur SHC fixes

#

if not that's also okay

limber skiff
#

all message logger patches are bad

#

but sure

#

Ill improve it

#

and say fix message logger

austere talon
#

but yeahtrue

limber skiff
#

yeah but they are bad regardless

limber skiff
#

just to avoid rebase

austere talon
#

sure

#

just blame sadan for bad ML patches

limber skiff
#

sadan didnt make ml patches tho

austere talon
#

he probably didn't write them but still, Sadan is a good scapegoat

limber skiff
#

LOL

fossil inlet
#

😭

austere talon
#

personally I always pick a random contributor to blame for my own faults

#

that's how all real developers do it, no?

limber skiff
#

there's a . behind the J

#

can't even see

austere talon
#

before u mean

#

why's ur font like that

fossil inlet
fossil inlet
austere talon
#

how do u even change console font lmfao

#

I just use whatever the default is

#

i didnt know u can change it

limber skiff
#

same

odd heath
#

same

austere talon
#

sadan has his own 2000 lines devtools css

fossil inlet
#

stylix did it for me

austere talon
fossil inlet
#

GUHHHHH

#

what did discord cook

austere talon
#

are u sure it's not ur css

#

also discord becomes ULTRA laggy when using devtools

#

it's fine without

fossil inlet
#

wtf

limber skiff
#

I see

#

the buttons SHC was disabling for the hidden screen were already being disabled by another experiment

#

they removed the experiment and removed the buttons

fossil inlet
limber skiff
#

hidden screen is also now black for voice chats

#

ugh

limber skiff
#

I dont wanna look at that right now tho

#

so I will just fix these broken patches

austere talon
#

I barely know how to use the profiler

clever sierraBOT
austere talon
#

GUHHHHH

#

send as attachment

fossil inlet
limber skiff
austere talon
#

nop

limber skiff
#

wow this extension is so bad now

austere talon
fossil inlet
austere talon
#

delete the folder from your vencord folder

#

vencord does not update extensions

fossil inlet
#

you might need to clear the extension cache

austere talon
#

you need to manually delete it to update

limber skiff
#

aah

fossil inlet
#

since when does chromium devtools have gutter decorations for the profiler

austere talon
#

in vencord settings folder delete ExtensionCache/fmkadmapgofadopljbjfkapdkoienihi

limber skiff
#

shiki keeps erroring

#

not sure why now

#

the other day I fixed an issue with languages request

#

I cant jump

fossil inlet
#

am i insane or does this say the file is at the root?

or does chromium interpret it some other way

prime dew
#

So the codeblocks theme selector doesn't really work

limber skiff
#

shiki suffering

charred monolithBOT
austere talon
#

looks good

#

vext

nimble pendantBOT
austere talon
#

brother...

limber skiff
#

does anyone remember the devtools funciton to jump to source

fossil inlet
#

GUHHHHH

#

i do not want to open the react folder rn

dusk blaze
#

When the @fossil inlet is immutable

limber skiff
#

ah

#

they changed how they view source for a component

#

openResource expects a url

fossil inlet
#

ah

limber skiff
#

that's kinda bad

#

and it doesnt even jump to source map

#

whew.

#

this extension needs to be patched, so many annoying things

limber skiff
#

but for now

scenic brook
#

Would you be able to distribute a custom build of the extension?

#

Or is that a nono

limber skiff
#

I think so

charred monolithBOT
limber skiff
#

we were already distributing an old version

#

vtest

nimble pendantBOT
scenic brook
#

pogMe

nimble pendantBOT
nimble pendantBOT
limber skiff
#

neat

charred monolithBOT
#

98b1b11 Fix NoServerEmojis, InvisibleChat & other patches - Nuckyz
707d688 WebpackPatcher: Try catch more code prone to er... - Nuckyz
c1f19d5 Fix initializing custom themes with ThemeStore ... - Nuckyz
cb8e8bd AccountPanelServerProfile: Fix plugin not working - Nuckyz
c2e5dcc Fix MessageLogger edit history & misc SHC patches - Nuckyz

limber skiff
#

vext

nimble pendantBOT
jolly egret
#

thanks all

fossil inlet
#

if i have time soon, i want to patch the old mv2 version to support react 19 or fix the source jumping and service worker not loadinng with the new version

fossil inlet
austere talon
#

In electron

#

just needs to be updated

#

possibly works on latest vesktop

fossil inlet
# austere talon already fixed, no?

well, source jumping is still broken according to nuckyz

(it's been working for me, but that just might be vesktop/linux vs. desktop/windows)

limber skiff
#

jumping for patched modules

#

and I just merged the fix

austere talon
#

@limber skiff I wanna start putting vesktop code in the vencord repo

#

cause it's way easier to upgrade that fast

#

idk how to best do it, should i just add a new folder like src/plugins/vesktop

#

putting patches in vesktop codebase is aids cause it breaks

#

well actually this one I'm doing rn can be in Vesktop

#

but in general

austere talon
#

vtest dev

nimble pendantBOT
nimble pendantBOT
austere talon
#

dude wtf did discord just push @limber skiff

#

looks like vencord catches the wasm fetcher webpack and it breaks everything

#

yeah it just catches the wrong instance

charred monolithBOT
austere talon
#

vtest dev

nimble pendantBOT
austere talon
#

this is so bad

nimble pendantBOT
nimble pendantBOT
limber skiff
#

how does it break?

#

it was already catching the other one but nothing wrong

austere talon
#

try it yourselr

austere talon
limber skiff
#

ah

#

I get it

#

they made it load earlier than web

#

wasn't the case

limber skiff
#

ill see what I can do tomorrow

#

vext

nimble pendantBOT
limber skiff
#

yall gotta work we need to push another version

charred monolithBOT
limber skiff
#

did it already

#

let me know what you think

charred monolithBOT
limber skiff
#

just in case

#

should have expected it

#

makes more sense for libDiscore and sentry to load before the main

#

all good tho

#

simply chrome extension users will suffer more as usual

charred monolithBOT
jolly egret
#

lol they broke it again before it even got fixes on the extension?

#

our rating on the extension page is gonna get obliterated

charred monolithBOT
austere talon
#

and maybe also check for sentry

granite wharf
charred monolithBOT
fossil inlet
#

vext

nimble pendantBOT
limber skiff
#

I made all the effort to avoid relying on names

austere talon
#

why

limber skiff
#

because it's silly and will break as soon as they stop sending the file with a name or add a new one

austere talon
#

you're relying on some random behaviour that could change at any time

#

just leave the filename check in

limber skiff
#

not so random tho

#

since it's a wasm loader the only chunk is the wasm file

#

ill keep both then

#

either way I wonder how BD will fix it

charred monolithBOT