#πŸ‘Ύ-core-development

1 messages Β· Page 237 of 1

austere talon
#

sure but you should be mad at yourself not them

fossil inlet
austere talon
#

if you don't want people to copy your code (while properly crediting you and following the license), you shouldn't release it under a free software license

#

lol yes

#

you're putting a box with your belongings on the street with a sign "free to take" and getting mad at people taking it

#

the entire point of free software is that others can copy it

charred monolithBOT
limber skiff
#

vtest patcher-rewrite

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,\i.jsx)(\i.\i.Item,{id:\i.\i).BLOCKED,className:([^\s]+?).item,children:\i.\i.string(\i.\i#{intl::BLOCKED})})/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

@austere talon do these variables name look horrible just for me or for you too?

#

I hate calling them something "canon"

austere talon
#

what would u call them instead lol

limber skiff
#

not sure but should I try changing?

#

they seem so non intuitive

austere talon
#

just leave it as is

limber skiff
#

alrightt

glass jasper
#

||People are just mad because you want the one who made the PR so you don’t get that on your commit history or whatever||

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,\i.jsx)(\i.\i.Item,{id:\i.\i).BLOCKED,className:([^\s]+?).item,children:\i.\i.string(\i.\i(?:["4bDptL"]))})/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
scenic brook
#

@surreal fiber finally thumb

surreal fiber
#

:3

scenic brook
#

Big ass readme

wary palm
#

OwO

fossil inlet
#

arent you that vesktop packager

wary palm
#

You owe me a taco

wary palm
dusk blaze
#

@opaque silo add vesktop premium

wary palm
#

I agree

opaque silo
#

every time you ping me the closer i get to pushing malware

wary palm
#

We need vesktop premum

dusk blaze
#

@opaque silo

fossil inlet
#

@opaque silo guhhh when will we be able to change the icon and loading gif (a rainbow and shiggy genuinely suck as loading images if you're not in private)

fossil inlet
#

actually something i really want

opaque silo
#

despair

#

raindow not big deal

#

this is my splash :33 i love stich

shut vineBOT
#

@fossil inlet, <t:1738203318:R>: migrate from TS 4.9.5 to 5.7.x

fossil inlet
#

never

opaque silo
fossil inlet
#

you will fix

dapper tiger
dapper tiger
#

blob cat cozy loading gif

fossil inlet
#

gays and furries arent exactly something i want on my screen when i open discord

opaque silo
#

πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€ πŸ’€

dapper tiger
#

a πŸͺ splash screen @opaque silo

fossil inlet
opaque silo
#

noi one is thinking youre a furry because of a little split second gif

#

and who cares

#

skull emoji

dapper tiger
#

well technically it lasts like 4 - 6 seconds

fossil inlet
fossil inlet
dapper tiger
#

husk

fossil inlet
#

i love laptop

dapper tiger
#

@fossil inlet sadancord

opaque silo
#

youre insane

dapper tiger
#

nop

#

its taken 10+ seconds for me at times

opaque silo
#

poop computer

dapper tiger
#

nop

opaque silo
#

is that for coldboot first start of veksot

dapper tiger
#

yes

opaque silo
#

oh

dapper tiger
#

@opaque silo wyd

opaque silo
#

i never cold boot

#

i love hibernating

dapper tiger
#

guhhh

#

hibernating doesnt work for me cause my ram is bad or osmething

charred monolithBOT
dapper tiger
#

it just shuts down when i hibernate

jolly egret
#

πŸ™„

opaque silo
dapper tiger
#

nop

#

wdym configure

#

theres no configuring it should just work

fossil inlet
#

no harm in it

opaque silo
dapper tiger
#

yop

#

should just work

#

cookieeee 😭

limber skiff
fossil inlet
#

@dapper tiger you use manjaro

dapper tiger
#

nop

opaque silo
#

ive been meaning to switch to cachy repos for so long

#

i need the extra 5% perf for having v3 compiled packages

dapper tiger
#

the install script is funny

jolly egret
opaque silo
#

im either not on my laptop or doing something else

charred monolithBOT
scenic brook
#

That's explained horribly but basically this inner stuff was unnecessary and overrode what the timestamp tag actually renders

limber skiff
#

I didnt even know timestamp accepted children 😭

shut vineBOT
#

@hollow musk, <t:1737864257:R>: if you didnt finish the fix, tell @/home/meow to make it

hollow musk
charred monolithBOT
charred monolithBOT
#

This plugin aims to add support to copy and open sticker urls from the context menu. Normal emojis have this feature, but stickers on the other hand do not seem to have this. This makes it much more complicated to do simple things such as download stickers or open them in a browser. Discord makes it very hard to find the sticker URLs, so this plugin's goal is to get around that.

There have been many times where I myself and others have wanted to access a sticker url, but have not been ab...

fossil inlet
#

epic lint fail

shell shuttle
#

oop

#

deadass this feature needs to be in base discord

#

ts shit pmo me off

charred monolithBOT
rugged spire
#

remember this bundler change

#

how it killed one of my plugins

#

i just rewrote the patch for it

#

and it works perfectly fine

odd heath
glass jasper
#

It deserved its death

odd heath
#

How

glass jasper
#

because we would just star the weirdest shit and get it posted there

odd heath
#

Good

woeful sable
scenic brook
charred monolithBOT
brazen bone
#

Oh and remember to remove the Sep component itself if you're gonna change that. Would've expected the unused variable warnings to fail CI...

scenic brook
#

Oh yeah, thanks

#

I should also quickly make sure it's the same in compact mode, just realised I only compared in cozy

charred monolithBOT
brazen bone
#

I think when I made it, it produced [Timestamp] in cozy but [Timestampβ€” in compact, or something like that. If that's changed, that's nice.

scenic brook
#

I guess they must've, I've checked every combination and it seems to produce the same thing

#

Makes it easier so that's cool

#

Also removes a find since we don't need the messageclasses anymore

charred monolithBOT
leaden furnace
charred monolithBOT
odd heath
#

We really need to merge that pr of me

fossil inlet
rugged spire
leaden furnace
#

QOL

jolly egret
#

or being nice idk

#

i just did the second one

leaden furnace
#

i have cheese

#

as bribe

brazen bone
#

πŸͺ€

odd heath
brazen bone
#

I got mine merged by making useful and objectively amazing plugins

jolly egret
#

no don't fall for it

leaden furnace
jolly egret
#

idk i just ask ed and then my changes were merged its so simple

odd heath
shell shuttle
limber skiff
#

vtest

nimble pendantBOT
frail skyBOT
#
Bad Patches

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,\i.jsx)(\i.\i.Item,{id:\i.\i).BLOCKED,className:([^\s]+?).item,children:\i.\i.string(\i.\i(?:["4bDptL"]))})/


**__NotificationVolume (found no module):__**
ID: `-`
Match: ```
_ensureAudio(){
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,\i.jsx)(\i.\i.Item,{id:\i.\i).BLOCKED,className:([^\s]+?).item,children:\i.\i.string(\i.\i(?:["4bDptL"]))})/


**__NotificationVolume (found no module):__**
ID: `-`
Match: ```
_ensureAudio(){
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

expect people to complain fake nitro doesn't work

#

in the browser

rugged spire
#

also when token lagger being added back

#

πŸ₯Ί

limber skiff
#

message events api broke yesterday

rugged spire
#

guh

#

i already updated

limber skiff
#

I already fixed in desktop

#

but not extension

jolly egret
#

guh

shell shuttle
#

could someone give me feedback on something

#

should the buttons be called "Copy Sticker Link" or "Copy Link"

scenic brook
#

Everything else just says Copy Link so I'd go with that

scenic brook
#

Could probably take the intl message so it blends in nicely too

brazen bone
#

Should be copy url though

#

A link is a gui element that when clicked takes you to an url

scenic brook
#

Sure but that's on discord rather than byeoon

brazen bone
#

Indeed

shell shuttle
#

When you right click an emote it'll say "Copy Link" and "Open Link" so i might go off of that

brazen bone
#

Better stick with it, even though it's technically wrong

shell shuttle
brazen bone
#

Isn't it copy message link on nessages though

shell shuttle
#

blobcatcozy right click the emote

shell shuttle
charred monolithBOT
limber skiff
#

vtest fix/implicit-relationships

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

shell shuttle
#

vtest

jolly egret
#

nah

charred monolithBOT
limber skiff
#

I wonder if I can like

#

vtest pull/3170/head:tags

nimble pendantBOT
limber skiff
#

nop

shell shuttle
jolly egret
#

is that even the right format

limber skiff
#

it's how you can checkout prs locally

#

let me see how the test command works

jolly egret
#

vtest refs/pull/3184/head

nimble pendantBOT
jolly egret
#

Β―_(ツ)_/Β―

shell shuttle
#

uuuhhh will i need to make a readme for my@plugin

still maple
jolly egret
grizzled halo
#

So a few friends of mine and some people in support have noticed some big performance hits with only vencord installed, they don’t have themes enabled or always animate

limber skiff
#

on startup or after?

jolly egret
#

real

rugged spire
#

does it even consider light mode

#

if no then that's a good feature to add

jolly egret
#

i think i broke it actually

rugged spire
jolly egret
#

wait no reverting doesn't fix it did an update kill it already Thonk

grizzled halo
#

A while after startup

grizzled halo
#

On vesktop it seems lesser, but on discord I can reproduce it on startup

jolly egret
#

i done fucked it beacuse dms doesn't work when the setting is off

#

how did i break it

#

Yeah this is wrong i hate collapsing conditions i just shouldn't have done it Clueless

return (settings.store.applyColorOnlyToUsersWithoutColor && !colorString)
    ? color
    : colorString;
scenic brook
grizzled halo
#

Ive noticed it too

limber skiff
#

I personally havent noticed a single change

grizzled halo
limber skiff
#

and I have my discord open for quite some time

scenic brook
#

Yeah just in general use

#

Switching channels, typing, even just hovering over servers the tooltip is pretty slow

rugged spire
#

After the recent changes I rewrote a small amount of one of my plugins and it's REALLY slow

grizzled halo
#

Seeing someone uninstall vesktop and reinstall and still see the same issue

limber skiff
#

all of you use vesktop?

scenic brook
#

I don't

grizzled halo
#

It’s happened on both for me

limber skiff
#

when did it start to happen

#

we did have some pretty big changes recently

#

but nothing that I could see cause an issue

rugged spire
grizzled halo
#

I only noticed it today

#

Someone said they noticed it for a month

rugged spire
#

Can everyone try this button in user profiles and see if it's REALLY slow?

grizzled halo
#

(Which I doubt)

limber skiff
#

seems fine for me?

#

the modal transition is a bit slow but nothing too much

rugged spire
#

it's not a modal transition issue

limber skiff
#

that's what I'm asking

#

slow how?

#

record it or something

fossil inlet
rugged spire
#

it genuinely just takes a moment before it even closes the modal

limber skiff
#

lets compare enabled plugins

#

Enabled Plugins (103):

AccountPanelServerProfile, AlwaysExpandRoles, AlwaysTrust, BetterGifAltText, BetterRoleContext, BetterSettings, BiggerStreamPreview, CallTimer, ClearURLs, ClientTheme, ConsoleJanitor, ConsoleShortcuts, CopyEmojiMarkdown, CopyFileContents, CopyUserURLs, CrashHandler, Dearrow, Decor, DevCompanion, DisableCallIdle, DontRoundMyTimestamps, EmoteCloner, Experiments, FakeNitro, FakeProfileThemes, FavoriteGifSearch, FixImagesQuality, FixSpotifyEmbeds, FixYoutubeEmbeds, ForceOwnerCrown, FriendsSince, FullSearchContext, FullUserInChatbox, GameActivityToggle, GreetStickerPicker, IgnoreActivities, iLoveSpam, ImageZoom, ImplicitRelationships, MentionAvatars, MessageClickActions, MessageLatency, MessageLinkEmbeds, MessageLogger, Moyai, MutualGroupDMs, NewGuildSettings, NoDevtoolsWarning, NoMaskedUrlPaste, NoOnboardingDelay, NoPendingCount, NormalizeMessageLinks, NoUnblockToJump, NSFWGateBypass, OpenInApp, PauseInvitesForever, PermissionFreeWill, PermissionsViewer, petpet, PictureInPicture, PinDMs, PlatformIndicators, QuickReply, ReactErrorDecoder, ReadAllNotificationsButton, ReplaceGoogleSearch, ReplyTimestamp, RevealAllSpoilers, ReverseImageSearch, ReviewDB, RoleColorEverywhere, Summaries, SendTimestamps, ServerInfo, ShikiCodeblocks, ShowAllMessageButtons, ShowConnections, ShowHiddenThings, ShowTimeoutDuration, SilentMessageToggle, SortFriendRequests, SpotifyControls, SpotifyCrack, StartupTimings, SuperReactionTweaks, ThemeAttributes, Translate, TypingIndicator, TypingTweaks, UnsuppressEmbeds, UserMessagesPronouns, UserVoiceShow, USRBG, ValidReply, ValidUser, VencordToolbox, ViewIcons, ViewRaw, VoiceDownload, VoiceMessages, VolumeBooster, WhoReacted, YoutubeAdblock
```**Enabled UserPlugins (1):**

AliucordDetector

#

perhaps all of you have one enabled which I dont

jolly egret
grizzled halo
#

I’m not on my pc, ill start it up

limber skiff
#

that's whats funny lol

#

I have so many enabled yet no issues

#

@jolly egret I will be pushing to main once I merge yours

fossil inlet
#

idk how to measure performance, but i can give data when i get home

scenic brook
#

Disabling quickcss makes mine marginally better which is why I didn't say anything really but I haven't added anything new to it that would make it worse

grizzled halo
#

Cant vencord debug here blobcatcozy

limber skiff
#

hold on

grizzled halo
#

Enabled Plugins (73):

AlwaysExpandRoles, AlwaysTrust, BetterFolders, BetterGifAltText, BetterSessions, BetterSettings, BetterUploadButton, CallTimer, ClearURLs, CrashHandler, Dearrow, Decor, Experiments, FakeNitro, FakeProfileThemes, FixImagesQuality, FixYoutubeEmbeds, GameActivityToggle, IgnoreActivities, ImageZoom, ImplicitRelationships, LoadingQuotes, MemberCount, MessageClickActions, MessageLatency, MessageLinkEmbeds, MessageLogger, MessageTags, Moyai, NewGuildSettings, NoDevtoolsWarning, NoMosaic, NoProfileThemes, NoReplyMention, NoTypingAnimation, NoUnblockToJump, NSFWGateBypass, PauseInvitesForever, petpet, PinDMs, PlatformIndicators, QuickReply, RelationshipNotifier, ReverseImageSearch, ReviewDB, Summaries, SendTimestamps, ServerInfo, ShikiCodeblocks, ShowConnections, ShowHiddenChannels, ShowHiddenThings, ShowTimeoutDuration, TextReplace, ThemeAttributes, Translate, TypingIndicator, TypingTweaks, Unindent, UserMessagesPronouns, UserVoiceShow, USRBG, ValidUser, VcNarrator, VencordToolbox, ViewIcons, VoiceMessages, VolumeBooster, WebKeybinds, WebScreenShareFixes, WhoReacted, XSOverlay, YoutubeAdblock
```**Enabled UserPlugins (2):**

Sekai Stickers, MessageLoggerEnhanced

limber skiff
#

hmm

#

@fossil inlet can you easily notice the performance issue

#

or only sometimes

#

might be time for your dissect

grizzled halo
#

i just started vesktop, its happening right now

limber skiff
#

can you record it?

grizzled halo
#

already ahead of you

rugged spire
#

maybe my system is just busted

#

the lag isnt long but I can definitely feel it

grizzled halo
limber skiff
#

'BetterFolders', 'BetterSessions', 'BetterUploadButton', 'LoadingQuotes', 'MemberCount', 'MessageTags', 'NoMosaic', 'NoProfileThemes', 'NoReplyMention', 'NoTypingAnimation', 'RelationshipNotifier', 'ShowHiddenChannels', 'TextReplace', 'Unindent', 'VcNarrator', 'WebKeybinds', 'WebScreenShareFixes', 'XSOverlay'

#

these are the plugins you have enabled that I dont

grizzled halo
#

its more noticeable on the channel scrolling

scenic brook
jolly egret
scenic brook
#

I can feel it typing too

jolly egret
#

idk i'm confusing myself 😭

scenic brook
#

Sometimes

limber skiff
#

oh

#

scrolliing is actually so slow

grizzled halo
scenic brook
#

Yeah that's what I was saying about my quickcss too

#

Like I don't have a ton in there so it shouldn't make much difference I don't think

#

It didn't feel like it before

rugged spire
#

but its why i don't use channeltabs or maintain a fork of it anymore

grizzled halo
#

Enabled Plugins (56):

BetterFolders, BetterRoleContext, BetterRoleDot, BetterSettings, BetterUploadButton, BiggerStreamPreview, CallTimer, ClearURLs, CopyFileContents, CopyUserURLs, Decor, EmoteCloner, FavoriteGifSearch, FixCodeblockGap, FixSpotifyEmbeds, FixYoutubeEmbeds, FriendsSince, FullSearchContext, iLoveSpam, ImageLink, ImageZoom, MemberCount, MentionAvatars, MessageClickActions, MutualGroupDMs, NoF1, NoTypingAnimation, NoUnblockToJump, NotificationVolume, OpenInApp, PermissionsViewer, QuickMention, RelationshipNotifier, ReviewDB, RoleColorEverywhere, SendTimestamps, ServerInfo, ServerListIndicators, ShowAllMessageButtons, ShowConnections, ShowHiddenChannels, ShowHiddenThings, ShowTimeoutDuration, SortFriendRequests, ThemeAttributes, Translate, TypingIndicator, TypingTweaks, UnlockedAvatarZoom, VoiceChatDoubleClick, ViewIcons, VoiceDownload, VoiceMessages, VolumeBooster, WhoReacted, YoutubeAdblock
#

Someone else’s

#

Same issue and after startup

scenic brook
#

Watch it be the only line I've contributed to the entire project somehow

limber skiff
#

'BetterFolders', 'BetterRoleDot', 'BetterUploadButton', 'FixCodeblockGap', 'ImageLink', 'MemberCount', 'NoF1', 'NoTypingAnimation', 'NotificationVolume', 'QuickMention', 'RelationshipNotifier', 'ServerListIndicators', 'ShowHiddenChannels', 'UnlockedAvatarZoom', 'VoiceChatDoubleClick'

#

try disabling SHC and BetterFolders

grizzled halo
#

Someone else

Enabled Plugins (29):

BetterRoleContext, BiggerStreamPreview, ClearURLs, EmoteCloner, FakeNitro, FixYoutubeEmbeds, ForceOwnerCrown, FriendsSince, ImageZoom, LoadingQuotes, MemberCount, MessageLogger, NoTypingAnimation, OnePingPerDM, PictureInPicture, ReadAllNotificationsButton, RoleColorEverywhere, SecretRingToneEnabler, ShowHiddenThings, SortFriendRequests, SpotifyControls, SpotifyCrack, Translate, TypingTweaks, UserVoiceShow, USRBG, ViewIcons, VoiceMessages, WhoReacted
limber skiff
#

no betterfolders and shc

rugged spire
#

i only have one hundred and thirty nine plugins enabled

limber skiff
scenic brook
#

I can get my plugin list but I can only remote into my PC from my phone atm so I can't really check if disabling any improves anything

limber skiff
#

but that shouldnt be an issue unless something is doing something with them over and over

scenic brook
#

Enabled Plugins (62):

AccountPanelServerProfile, AlwaysExpandRoles, BetterRoleContext, BetterSessions, BetterSettings, ClientTheme, ConsoleJanitor, ConsoleShortcuts, CrashHandler, DevCompanion, Experiments, F8Break, FixYoutubeEmbeds, FriendsSince, FullSearchContext, FullUserInChatbox, HideAttachments, ImageZoom, ImplicitRelationships, MemberCount, MessageClickActions, MessageLinkEmbeds, MessageLogger, MoreCommands, NoDevtoolsWarning, NoF1, NoPendingCount, NormalizeMessageLinks, OpenInApp, OverrideForumDefaults, PermissionsViewer, petpet, PreviewMessage, ReactErrorDecoder, RelationshipNotifier, ReplyTimestamp, ReverseImageSearch, ReviewDB, RoleColorEverywhere, ServerInfo, ShowHiddenThings, ShowMeYourName, ShowTimeoutDuration, SpotifyControls, SpotifyShareCommands, TextReplace, ThemeAttributes, Translate, TypingIndicator, TypingTweaks, UnsuppressEmbeds, UserMessagesPronouns, ValidReply, ValidUser, VoiceChatDoubleClick, VencordToolbox, ViewIcons, ViewRaw, VoiceDownload, VoiceMessages, WhoReacted, YoutubeAdblock
```**Enabled UserPlugins (21):**

CustomTimestamps, EmbedReplace, ExecutableCodeblocks, SortForumsByUnreadUser, Fuckaround, IconViewer, IncognitoLinks, MaskedPasteOptions, UnitConverter, QualityOfLife, ReorderAttachmentsUser, ShowMessageEmbedsUser, SortFriendList, SortReactions, MediaPlaybackSpeed, SidebarChat, SpotifyLyrics, Timezone, KeywordNotify, ViewReplyThread, WigglyText

limber skiff
#

I'm not sure honestly

#

nothing was changed that really could cause something like that

scenic brook
#

Is it just discord atm?

grizzled halo
#

Its only happening with vencord enabled

fossil inlet
grizzled halo
#

I would help more but I gotta sleep

scenic brook
#

I won't be able to get on my PC for a few hours lol

#

Check Discord experiments for the 2025-01_make_vencord_annoying experiment

limber skiff
#

should make a support command to check what bucket an user is assigned to an experiment

limber skiff
#

@jolly egret did you test it well?

jolly egret
#

yep i tested it

limber skiff
#

alright then I will trust it

jolly egret
#

real

limber skiff
#

pretty small changes anyway

jolly egret
#

would be nice if you could pin a shortcut to open a specific plugins settings into the toolbox, having to go all the way through and search the plugin up to change a setting while debugging is... ass

rugged spire
charred monolithBOT
limber skiff
#

@fossil inlet are you looking into it?

fossil inlet
#

in not at home yet 😭

limber skiff
#

oh alright

#

@grizzled halo are you still awake

jolly egret
#

whats the performance issue?

scenic brook
jolly egret
#

i don't think i'm getting anything

scenic brook
#

Marginally faster

grizzled halo
#

Not on pc however

limber skiff
#

ah

#

I wanted to ask for your settings.json

grizzled halo
#

I can provide it tomorrow if its not figured out by then

limber skiff
#

alright

limber skiff
#

does anyone have this

jolly egret
#

it doesn't jump perfectly but it gets pretty close from my testing

prime dew
#

I have no themes nor quickcss enabled

jolly egret
#

i can't repo

limber skiff
#

I never had this

fossil inlet
#
  • didnt update after discord removed discriminators
#

needs a rewrite imo

glass jasper
limber skiff
#

alright

jolly egret
#

gotta love an issue cleanup

limber skiff
#

whos this person creating issues for their own plugin

jolly egret
limber skiff
#

might as well just restrict them

jolly egret
#

its everyone elses problem now KannaSip

limber skiff
#

literally deferring the issues to someone else

jolly egret
#

hide the issues so the PR gets merged then open issues after

limber skiff
#

@twin tendon

#

omg

#

NO WAY LOL

#

I'm so sorry

jolly egret
#

who is that lol

limber skiff
#

I grabbed a random user from another server to mention here and test

#

AND THEY ARE HERE

jolly egret
#

LMAO

#

incredible

limber skiff
#

god damnn

glass jasper
#

What are the chances of that?

jolly egret
#

depends on what kind of community

limber skiff
#

@timid grail

#

alright

#

hmm

#

valid user should fix this

#

@timid grail

#

actually it's fine

charred monolithBOT
limber skiff
#

sadan lazy to do this

charred monolithBOT
jolly egret
#

what does that do, get the user from cache and if they're not there don't make it clickable?

limber skiff
#

if they are not there it returns the original mention

#

which is not "full"

jolly egret
#

ye

#

makes sense

limber skiff
#

and says unknown user

#

ideally it should work with valid user and cache it

#

but hmm

#

I'm not sure how easy it would be

#

dont wanna look into that right now

#

vtest

nimble pendantBOT
fossil inlet
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
[Vendicated/Vencord] branch deleted: fix/implicit-relationships
#
[Vendicated/Vencord] branch deleted: mangle-everything
#
[Vendicated/Vencord] branch deleted: mangled-context-menu-api
jolly egret
#

delete dev 😁

charred monolithBOT
#

b2d5c00 Delete NoScreensharePreview ~now a stock feature - Nuckyz
414539f Add more FIXME and explain better TODOS for mig... - Nuckyz
1eff1a0 IrcColors: Fix causing react errors sometimes - Nuckyz
fc4e958 Fix ImplicitRelationships and NotificationsVolu... - Nuckyz
7b9f0a3 IrcColors: Allow coloring only users with no co... - jamesbt365

jolly egret
#

should be okay to tag push later if they don't work weekends

limber skiff
#

vtest discord-fixes

nimble pendantBOT
limber skiff
jolly egret
#

i can't even reproduce the lag 😭

limber skiff
#

me neither

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jolly egret
#

i wonder if its experiment based?

limber skiff
#

should I make platform indicators be added here

#

instead of badge

jolly egret
#

i feel like its ideal yeah

limber skiff
#

I really wanna merge discord-fixes but I'm not sure if vee approves it

#

you gotta be kidding the setting is called badges

fossil inlet
#

Enabled Plugins (67):

AlwaysAnimate, AlwaysTrust, WebRichPresence (arRPC), BetterFolders, BetterSettings, BetterUploadButton, CallTimer, ClearURLs, ConsoleJanitor, ConsoleShortcuts, CopyFileContents, CrashHandler, EmoteCloner, Experiments, FixYoutubeEmbeds, ForceOwnerCrown, FriendInvites, FriendsSince, GifPaste, ImageZoom, ImplicitRelationships, LoadingQuotes, MemberCount, MessageLinkEmbeds, MessageLogger, MutualGroupDMs, NewGuildSettings, NoBlockedMessages, NoDevtoolsWarning, NoF1, NSFWGateBypass, PermissionsViewer, PictureInPicture, PinDMs, PlainFolderIcon, PlatformIndicators, QuickReply, ReactErrorDecoder, RelationshipNotifier, ReverseImageSearch, ReviewDB, RoleColorEverywhere, ServerInfo, ShikiCodeblocks, ShowHiddenChannels, ShowHiddenThings, ShowTimeoutDuration, SortFriendRequests, SpotifyControls, SpotifyCrack, StickerPaste, TextReplace, ThemeAttributes, Translate, TypingIndicator, TypingTweaks, UserVoiceShow, ValidUser, VoiceChatDoubleClick, VencordToolbox, ViewIcons, ViewRaw, VoiceMessages, VolumeBooster, WebKeybinds, WebScreenShareFixes, WhoReacted
```**Enabled UserPlugins (7):**

CopyStatusUrls, CtrlEnterSave, EmojiOnMouseUp, UnitConverter, StaticTitle, UrbanDictionary, UserDevCompanion

fossil inlet
limber skiff
#

I know

#

that's up to valid user to fix

fossil inlet
limber skiff
#

you cant get the effects of a full mention without the user being cached

#

and when you get unknown user it's uncached

#

valid user is the plugin that fixes uncached mentions

#

if it is updated to cache mentions in the chat bar, then FullUserInChatbox will automatically convert it to a full mention

#

since I used useStateFromStores

fossil inlet
#

guhhh thats not happening for me

#

its just staying as a mention without fulluser

limber skiff
#

huh?

#

it's staying as unknown user right?

#

as I said valid user doesnt support caching mentions in the chat bar

fossil inlet
#

oh

#

i think im going crazy

#

i swore validuser worked in the chatbar at one point

charred monolithBOT
glass jasper
jolly egret
#

Feel free

#

you can make one for fakenitro/text replace not working on chrome extension too if you like

shell shuttle
#

ffs i cant fix the issue because pnpm doesnt work

#

FUCKING HELL

#

WHAT IS WRONG WITH THE IMPORTS

#

IS IT RETARDED

scenic brook
#

?

jolly egret
#

ty

shell shuttle
#

fixed pnpm,

fossil inlet
#

GUHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHHH

#

HOW DID THIS GET MERGED

limber skiff
#

how do we feel

fossil inlet
limber skiff
scenic brook
limber skiff
#

I had to make an API for this

glass jasper
limber skiff
#

actually there is a gap

glass jasper
#

They seem to squished together

limber skiff
#

it's just very small

#

and that's not even my styling

glass jasper
shell shuttle
glass jasper
#

still tho

limber skiff
#

uhh

#

it's actually the same as the member list

#

both have a gap of 2px

glass jasper
#

…

#

huh

limber skiff
#

this looks horrible

#

the yellow lmao

charred monolithBOT
fossil inlet
#

wonder what caused it

limber skiff
austere talon
glass jasper
austere talon
#

unconfirmed report by a few people != known issue

glass jasper
jolly egret
#

don't know what repos it but having it listed may save a few users from bugging us in the support channel lol

austere talon
#

dont create known issues about stuff unless it's 100% confirmed

jolly egret
#

but more than a handful of users have reported it and it only happens with vencord installed though?

#

seems reasonable enough

limber skiff
#

vtest dev

nimble pendantBOT
limber skiff
#

uhh

#

I have bad news

fossil inlet
#

what did they do fear

glass jasper
jolly egret
#

did... something explode

limber skiff
#

nvm

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

fossil inlet
#

😭

limber skiff
#

dzi tricked me

fossil inlet
#

husk

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

blame mantika

austere talon
#

never listen to dzi he's insane

fossil inlet
#

horror emote

limber skiff
#

nah it's actually mantika fault

glass jasper
limber skiff
#

@crude hearth you 😠

charred monolithBOT
jolly egret
#

WHY would you want that

glass jasper
crude hearth
#

no problem

fossil inlet
#

like if you're inserting chars that need to be ecaped before an \i

#

you crash

jolly egret
#

what is with people with wanting RPC with everything though

shell shuttle
charred monolithBOT
fossil inlet
#

how tf

charred monolithBOT
fossil inlet
#

@shell shuttle

diff --git a/src/plugins/copyStickerLinks/index.tsx b/src/plugins/copyStickerLinks/index.tsx
index dee508173..0a3248f7a 100644
--- a/src/plugins/copyStickerLinks/index.tsx
+++ b/src/plugins/copyStickerLinks/index.tsx
@@ -16,11 +16,11 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
 */
 
-import { Constants, Clipboard, FluxDispatcher, Menu, React, RestAPI, Toasts } from "@webpack/common";
 import { findGroupChildrenByChildId, NavContextMenuPatchCallback } from "@api/ContextMenu";
 import { Devs } from "@utils/constants";
 import definePlugin from "@utils/types";
 import { findStoreLazy } from "@webpack";
+import { Clipboard, Constants, FluxDispatcher, Menu, React, RestAPI, Toasts } from "@webpack/common";
 import { Promisable } from "type-fest";
 
 const StickersStore = findStoreLazy("StickersStore");
fossil inlet
#

if you have eslint installed in your editor, you should be able to open your autofix menu and it should be there

austere talon
#

why spoonfeed insteadof telling them how to fix it wires

#

(run lint / configure eslint correctly)

shell shuttle
austere talon
jolly egret
#

We tried, vee

austere talon
#

and?

jolly egret
#

Β―_(ツ)_/Β―

fossil inlet
#

@jolly egret does it happen only on canary

jolly egret
#

stable too I think

#

I can't repo it though

#

check the info above

glass jasper
fossil inlet
#

i really need to make that vencord-plugins parser

austere talon
#

there's a lot of recalculate style

#

but it is caused by discord code think

jagged cloak
#

is part of it slate being slate Sip

#

cause i was having a loooot of random glitching with slate yesterday

#

should have recorded it

austere talon
#

seems like it#s some loop but that's from discord code

shell shuttle
jagged cloak
#

what lol

shell shuttle
fossil inlet
#

nixcord so insane

austere talon
#

pretty sure it has to do with some css

#

but idk which lol

#

discord css is so cooked that adding our own css has a 50% chance of exploding performance somehow

charred monolithBOT
tropic valley
#

WHY HUSK

#

my old account is still linked under the devs constant

#

I wanna contribute with some fixes on a plugin

#

is it okay if I migrate the dev constant to this account alongside the PR

jagged cloak
#

thats fine i think ppl do it sometimes (ive changed my constant once)

tropic valley
#

I see

#

thank you

glass jasper
tropic valley
#

codeberg my beloved

austere talon
#

i managed to reproduce the lag and disabling all vencord css fixed it

scenic brook
#

I knew I couldn't have fucked my quickcss that bad lol

austere talon
#

somehow the bundler update made a lot of CSS very laggy

#

some of Vencord's CSS is laggy, ClearVision is laggy, etc

tropic valley
#

i'm getting husked for nothing πŸ’”

median rapids
#

husked because codeberg

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jagged cloak
#

codeburger

#

why do i have this color and not battlepass

#

irccolors insane default settings

jolly egret
#

i feel like they're fine

#

it is the closest to irc afterall

jagged cloak
#

they're fine albeit offputting

#

that way most people wont enable it not check the settings and go "why does it not work!!"

shell shuttle
#

its taking so long to type idk why

#

everything sis basically frozen up

#

reloading helps it a little tho

charred monolithBOT
#

HideProfilePictures

This plugin allows the user to hide/unhide the profile pictures of particular users via a new context menu option. It keeps track of users for whom the pictures were hidden so that they remain hidden between sessions, if the users wants to revert the action they simply rightclick on the user again and select 'unhide profile picture'.

By default a hidden user's profile picture is reverted to the default discord avatar image. Optionally, the user can select the "Blur...

granite wharf
#

Im having a bit of lag spikes but I cant even test out whats causing it

#

due to the css window not even loading anymore after updating the extension DunktsukiStare

limber skiff
#

it's some vencord style doing it

granite wharf
#

I have no idea why its being like this

jolly egret
glass jasper
#

^^
css that can easily do it

limber skiff
#

oh yeah discord fixed their css having comments @austere talon

charred monolithBOT
#
[Vendicated/Vencord] New branch created: platform-indicators
limber skiff
#

still have work to do because the icons have different heights

limber skiff
#

@fossil inlet try deleting SHC css and see if you experience lag

fossil inlet
limber skiff
#

o

fossil inlet
#

ima try reporter and see if that makes a difference

limber skiff
#

it might be because of this

#

not sure tho

#

even discord has so much of this

fossil inlet
#

performance graphs make no sense to me, but reporter performance is quite a bit worse

grizzled halo
#

@limber skiff do you still need my settings.json?

limber skiff
#

nop, thanks

#

vee found out it's css related

grizzled halo
#

Alrighty

#

Glad it got narrowed down blobcatcozy

rugged spire
# limber skiff

idk about the background but this would make me actually use platformindicators in profiles

charred monolithBOT
limber skiff
rugged spire
limber skiff
#

ya

rugged spire
rugged spire
#

and the icons feel small

#

oh wtf

#

they're 14px

#

that explains at least some of it

#

i'm just going to say it but

#

the sizes of the icons just look super wrong

#

i can barely see the left and right edges of the mobile indicator

#

oh yeah they are totally being blended in

#

though, the desktop icon is too

#

okay

#

i have a conclusion

#

and idk if you're going to like it

limber skiff
#

ik

#

the sizes are all different as I said

#

as the background is really needed for vee profile for example

rugged spire
limber skiff
#

though yes the icons are small

#

that whole section is smaller

rugged spire
#

i know the section is smaller

limber skiff
#

same size as the member list icons though

rugged spire
limber skiff
#

damn

rugged spire
#

i was going to ask about that

limber skiff
#

and I don't use the one in messages

rugged spire
#

the small icons definitely look wrong due to the scaling

#

this is an existing issue though blobcatcozy

limber skiff
#

the icons need work yeah

rugged spire
#

is it possible to put a hook into the nicknameicons api

#

to update them when icons are added/removed

limber skiff
#

wdym?

#

it's already using state from store in the icons, yes you can put hooks

rugged spire
#

no

#

add a hook to _renderIcons itself

#

it's especially noticeable with the icons in the member list

#

you will tell me soon that this was broken before the api too

limber skiff
#

I don't get what you are trying to say

#

oh

#

yes it was broken

#

and I fixed already

#

as I said I use state from stores insider the icons now

#

they update in real time when the presence changes

rugged spire
#

thats not what I mean but thanks for fixing it

#

i mean

when enabling/disabling the icons in the settings, there is no react hook to rerender the icons

#

what if i told you to abuse my favourite react hook that shouldn't be used when writing good react code

limber skiff
#

okay you are right that needs fixing

#

I think most apis have that issue

rugged spire
#

afaik restart required tracking is also kinda broken too if you enable/disable plugins and settings of the plugin

limber skiff
rugged spire
#

✨ useSyncExternalStore ✨ (don't follow my advice)

#

i know there is at least one plugin that does something even more cursed

limber skiff
#

useSyncExternalStore seems like the right thing to do

rugged spire
#

honestly we need a wrapper for that

#

just a simple factory for useSyncExternalStore would be nice

limber skiff
#

I will make one using proxy which will update when the object is changed

#

not recursively tho

rugged spire
#

somehow i only have one useSyncExternalStore hook throughout all of my plugins

#

and it's because the stock CallTimer code is cursed

#

love?

#

this needs a fake external store at some point soon

#

also this code is half a year old

#

guh

#

i will fix IrcColors

charred monolithBOT
limber skiff
rugged spire
#

add functionality

#

I shouldn't have said fix

#

It's not broken it just doesn't have the functionality that I'm looking for

austere talon
#

my brain is fried

odd heath
#

Stop giving me merge conflicts >:(

jolly egret
#

more merge conflicts please

odd heath
#

Nop

#

So bad

austere talon
#

waiter waiter! more merge conflicts

odd heath
#

Waiter should service (review) me (my PR) already

#

Tho I have some bug in there I can't figure out 😭 I need to take another look at it

#

Something causes react to always re-render the modal on a click

hollow wing
odd heath
#

It's still changing on click and I haven't figured out why

austere talon
#
  • dearrow
  • clienttheme
  • fakeprofile
  • ml
  • permviewer
  • rdb
  • sendtimestamps
  • serverinfo
  • shiki
  • showconnections
  • showhiddenchannels
  • spotify
  • translate
  • toolbox
  • voice message
#

all these plugins use unoptimised css (out of the ones that use unmanaged styles)

limber skiff
#

client theme only changes vars

#

how is it unoptimized

austere talon
#

i just wrote down all plugins that use bad selectors like this that could be part of it

limber skiff
#

ah

#

but btw

#

if you search in dev tools discord does that so much too

#

specially > *

#

so that gets me thinking the little amount of times we do it in vencord is not the issue

austere talon
#

well it's an issue and we need to fix it

#

i just wrote down everything that uses bad css

#

i will change them all to use better css

limber skiff
#

they are saying USRBG causes lag too

charred monolithBOT
tropic valley
limber skiff
#

oh mb I didnt notice that

austere talon
#

im fixing vesktop screenshare picker css rn

#

and god that code is so horror

shell shuttle
glass jasper
#

that they turned into a plugin

limber skiff
#

recreation of an experiment

austere talon
#

anyway yeah i can confirm usrbg causes lag

tropic valley
limber skiff
#

could the issue be the creation of many styles tags

austere talon
#

definitely not

#

discord makes 3 billion

limber skiff
#

initially it's only one

austere talon
limber skiff
#

vencord creates style tho

#

not link

#

not sure

#

prob not yeah

austere talon
#

it shouldn't matter

#

it didnt matter before

#

and we know it's bad selectors

#

i disabled usrbg and immediately lag got better

limber skiff
#

feels the same for me with it or not

austere talon
#

anyway i'm fixing that list rn

austere talon
#

@limber skiff can you improve SHC

#

replace anything that selects generic html element with a proper classname

#

and try to remove > * if possible

charred monolithBOT
#
[Vendicated/Vencord] New branch created: fix-lag
austere talon
#

like this

austere talon
charred monolithBOT
austere talon
charred monolithBOT
limber skiff
#

nah its def not lagging how other people are sa5

fossil inlet
#

How bad is the lag for people that have it, because I can't manage to get any lag

austere talon
#

pretty bad

#

frame drops when typing, scrolling, etc

scenic brook
#

It was bad enough that it had me thinking I'd fucked up a plugin or something

rugged spire
#

when is automatically managed css being added to vencord

scenic brook
#

Showing my lack of experience but what does managed css do?

rugged spire
#

Thanks for falling for the husk bait

fossil inlet
rugged spire
scenic brook
#

Ah

#

I tried to Google it earlier and it had no idea what I was on about lol

rugged spire
#

@fossil inlet What if I actually did it based on some cursed esbuild code

fossil inlet
rugged spire
#

Why?

fossil inlet
rugged spire
#

That's it?

fossil inlet
#

Yeah

limber skiff
#

isnt it better to just hardcode

#

performance wise

austere talon
#

there's hardly any difference

#

we use wildcards for discord classes too :P

limber skiff
#

yes but we can avoid for vencord classes

#

shc is horrible lmao

charred monolithBOT
austere talon
#

brooo

#

why is HideAttachments so shitcode

#

what idiot wrote this shit πŸ’€

#

this guy is fucking stupid

scenic brook
fossil inlet
rugged spire
rugged spire
#

(happened many times)

limber skiff
#

I hate this

#

where's my scroller

rugged spire
fossil inlet
limber skiff
#

now I have scroller and it goes inside the fucking top and bottom

#

when did css get this hard?

fossil inlet
#

this is why i never touch css blobcatcozy

limber skiff
#

ahaaa

#

got it

#

I had one more class I shouldnt have

#

I guess discord changed this at some point

#

now it's beautiful

#

(not really but I'm not re-doing this UI)

fossil inlet
#

@limber skiff why is allowed rules there like ten times instead of just once

limber skiff
#

to test the scroll lol

fossil inlet
#

ah

jolly egret
#

you should deploy it like that

charred monolithBOT
limber skiff
charred monolithBOT
limber skiff
#

@austere talon also made the css use em blobwob

fossil inlet
limber skiff
austere talon
#

broo

#

i just rewrote HideAttachments to not be shit

#

and it's so much easier than the cursed css

limber skiff
#

may I change this

austere talon
limber skiff
#

it's better to avoid when we can

rugged spire
limber skiff
#

there

charred monolithBOT
limber skiff
austere talon
#

example with

some text

#

you cooked so hard with MessageUpdaterAPI @limber skiff

limber skiff
#

stared at discord code for like 5 hours just to make 10 lines

#

holyyy

#

my discord feels so slow now

#

I started having the lag randomly, didnt even restart discord

#

god damn

austere talon
#

do you use vesktop or discord desktop

limber skiff
#

discor dekstop

#

cant even type properly now

#

tf?

austere talon
#

LOL

limber skiff
#

I havent even restarted discord and it just started

austere talon
#

use my branch

charred monolithBOT
austere talon
#

this was so much easier than expected

limber skiff
#

I just opened ptb in dev and I have no lag

#

what

austere talon
#

trol

limber skiff
#

something very specific caused it

#

and I have no idea what

austere talon
#

thanks for doing SHC

#

lag is fixed for me now

#

with that branch

limber skiff
#

okay I restarted my discord and its good again

austere talon
#

should we merge

limber skiff
austere talon
#

i checked all css files and none have any more bad stuff

limber skiff
#

because it just happened for the first time for me for example

limber skiff
#

and I restarted in dev branch and it's all good now

austere talon
#

there are still a few bad rules

#

that target generic elements

#

but

#

we can't easily fix those

limber skiff
#

which ones

austere talon
#

well we could actually

limber skiff
austere talon
#

this for example

limber skiff
#

you missed a . here

austere talon
#

lmaoo good catch

#

can u fix that

limber skiff
#

review db has so many of those

austere talon
limber skiff
charred monolithBOT
austere talon
#

lol that was easy

#

that div div rule was broken

#

didnt do anything

#

discord still hasn't fixed their shitty badge css

#

discord does 2px instead of 1px

#

without the fix this happens

#

(and no it's not vencord badges fault)

rugged spire
fossil inlet
austere talon
#

(and with fix)

#

discord probably hasn't noticed because you never see 12 badges on stock discord

limber skiff
#

found more

#

blurnsfw is horrible too

austere talon
#

yeah ig

rugged spire
#

why are you making more merge conflicts for me to solve later

austere talon
#

so selecting them by class pain

#

but yeah can use *=

austere talon
#

have to patch multiple places probably

#

actually

limber skiff
#

message logger has some too but idk about it

austere talon
#

we could rewrite it to use smth like spoilers

austere talon
#

cause it selects so much lol

#

we want to basically affect the entire message

#

actually

#

i have an idea

#

let me have a go at it

#

how did no one ever think of just doing this

limber skiff
#

omg

#

you cooked HARD now

#

holy shit

austere talon
#

now just need to fix this

#

thats better

limber skiff
#

im doing send timestamps

#

@austere talon just abused it too

#

to remove this background

charred monolithBOT
limber skiff
#

now what about blurnsfw