#πŸ‘Ύ-core-development

1 messages Β· Page 225 of 1

long stream
#

the last patch was to disable the client-side discovery search filter

#

iirc it just didn't allow you to search if you had any of the words in the list in your query

#

that was moved to server-side and removed from the client

prime dew
#

Yeah but
"pepe" "nude" lmao

limber skiff
#

it could have been way worse blobwob

charred monolithBOT
dusty finch
charred monolithBOT
charred monolithBOT
charred monolithBOT
fringe basalt
#

calm before the storm

long stream
fossil inlet
#

what does that mean

long stream
#

discord purged all of the old i18n keys

fossil inlet
#

what

#

they are ALL new keys

long stream
#

not all

shy veldt
#

calm before the storm

#

not even that πŸ—£οΈ

DiscordCanary_opfLHhpmq8.png
fossil inlet
#

killing myself

long stream
shy veldt
#

o opening the attachment fixed my discord

#

nice

fossil inlet
#

@long stream is it on canary yet?

long stream
#

yes

fossil inlet
#

stable?

shy veldt
#

no

fringe basalt
#

nop

#

just canary

fossil inlet
#

i think ill archive the current modules

shy veldt
#

only canary

#

not even ptb

#

ptb is dead from new builds

odd heath
#

Horror fear

fringe basalt
#

the funny

fossil inlet
#

@limber skiff preapare

long stream
sterile oak
shy veldt
#

design is my passion

DiscordCanary_nBOdH9bVH0.png
fossil inlet
#

@long stream do you have any idea what the new keys are

#

or did they just rename everything

hollow wing
fossil inlet
long stream
fossil inlet
#

LMAO ABOUT TIME

long stream
#

ill search for them since i still have an old build loaded

#

actually

#

@shy veldt hii pookie, can you send a list of all of the broken plugins blobcatcozy

shy veldt
#

just run reporter

long stream
#

lazy

shy veldt
#

then get @austere talon to run it

#

huge if true

DiscordCanary_VdXEWC2BMS.png
fossil inlet
shy veldt
#

now im stuck like that

fossil inlet
odd heath
fossil inlet
#

yea

#

at least the reporter runs

odd heath
#

Didn't destroy that much

#

True lmao

long stream
fossil inlet
#

but i feel like a lot of finds will be a pain in the ass

long stream
#

yea

fossil inlet
#

you could prob reverse a lot of the i18n tags from their contents

#

then find agianst those

long stream
#

there's a builtin menu for that

#

ctrl + alt + o then click on the arrow and select intl in the dropdown

fossil inlet
#

isnt that only tags from keys tho

long stream
#

oh wait

#

right

#

okay im stupid ignore

odd heath
fringe basalt
#

fwiw the string keys didn't actually change, it just broke the parser so it thought all of them got removed

long stream
#

oh

odd heath
long stream
#

okay im stupid x2

odd heath
fringe basalt
fossil inlet
#

need to make my own version of that blobcatcozy

odd heath
#

Thanks

long stream
#

nelly <3

fringe basalt
long stream
#

or discord forcing you to work on your scraper because of small changes like this

odd heath
fringe basalt
#

omg i think tiemen's thing broke too 😭

fossil inlet
#

if anyone has any need for it later, i have a local copy of every discord module, with all current patches applied before the changes, formatted

rugged spire
odd heath
#

They'll surely revert again Clueless

fossil inlet
brazen bone
#

I have a copy from before they scrunged import names

rugged spire
fossil inlet
rugged spire
#

How did you get that repo picker dropdown menu
I've never seen it before
Have I just not used GitHub actions enough

fossil inlet
#

@grizzled halo you should know that canary will probably break soon

grizzled halo
#

It already did

fossil inlet
#

Love

hollow wing
teal nest
#

such a great app

shy veldt
jolly egret
#

how ba dis the damage

hollow wing
#

so bad

fossil inlet
#

is it just me, or is canary not broken

hollow wing
#

Works for me now, seems like they reverted the changes

charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New branch created: update-dependencies-eslint
fossil inlet
fringe basalt
#

yea reverted in 355214

fossil inlet
fringe basalt
#

now you will never know when they push again blobcatcozy

fossil inlet
#

@fringe basalt do you know if they're going to un revert

fringe basalt
#

no clue

#

i don't work at discord (yet)

charred monolithBOT
fossil inlet
charred monolithBOT
#
Accelar17
[Vendicated/Vencord] Issue opened: #3092 [Bug] <title>Failed Vencord

Discord Account

@accelar

What happens when the bug or crash occurs?

Π‘Π½ΠΈΠΌΠΎΠΊ экрана 2024-12-19 211557

What is the expected behaviour?

I just started the PC and went to discord, I see my theme is not working correctly, I go to the settings and it gives an error, I reinstalled discord and cleared the cache, but nothing helped

How do you recreate this bug or crash?

I don't know

Err...

austere talon
#

guh some plugin glitches profiles

#

opening profile popout via guild list makes discord go off screen

#

it doesnt happen on stock so it's most likely a plugin

#

i disabled all the profile editing plugins but still happens

limber skiff
#

what happened

austere talon
#

idk

limber skiff
#

oh

#

they changed all the old keys?

austere talon
#

😭

glass jasper
fossil inlet
#

doesnt happen to me

fossil inlet
austere talon
#

both of u run plugins command

fossil inlet
#

i will just enable everything that bisect

#

then*

odd heath
fossil inlet
odd heath
#

Do

fossil inlet
#

soon

odd heath
#

Also how does reporter look like with the revert?

charred monolithBOT
glass jasper
jolly egret
#

why is that happening

glass jasper
#

and yes, I’m well aware of the artifacting. It is making hypercam freak out.

jolly egret
#

do i dare restart discord

odd heath
odd heath
#

Why not obs husk

glass jasper
odd heath
glass jasper
odd heath
#

Is hyper cam even open source?

charred monolithBOT
jolly egret
odd heath
austere talon
#

i disabled random plugins and now it's fixed

long stream
fossil inlet
#

i swear discord reverted

long stream
#

they did a revert

fossil inlet
#

i went crazy thinking my bisect logic was broken for some reason

long stream
#

horror

chrome_O48TlRb6pf.png
#

same-day stable release

austere talon
fossil inlet
long stream
#

yop

#

i reloaded and the bug doesn't occur anymore

austere talon
#

oh wait im on canary not stable

#

mb

#

so discord did fix

#

so it was a discord issue

#

now it all makes sense

#

i tested it on stable vanilla discord and vesktop canary

#

i thought i was using stable on vesktop

#

so i concluded "happens on vencord but not stock so it's vencord issue"

fossil inlet
long stream
austere talon
fossil inlet
austere talon
#

cause it was global before but it's not anymore in new react types

fossil inlet
#

ah

austere talon
fossil inlet
austere talon
#

i really dont care about discord changes much

#

unless they break vencord

austere talon
#

it's the type

#

JSX.Element

fossil inlet
#

because in your pr, its not added to every tsx file

austere talon
#

insane

image.png
jolly egret
#

did they redeploy the thing that break severything again

fossil inlet
#

so what files does it need to be added to

long stream
fossil inlet
austere talon
glass jasper
long stream
#

private channels

#

sowwy

fossil inlet
#

im stupid

austere talon
long stream
#

vee 😭

austere talon
charred monolithBOT
austere talon
#

idk how people use the react hooks eslint plugin

#

it's so obnoxious

#

"missing dependencies"

#

except i dont want that shit to be a dependency

odd heath
austere talon
#

random dependencies

#

irrelevant

glass jasper
crude hearth
#

everything is object RedTick
everything is dependency GreenTick

austere talon
#

no

#

this is react hooks stuff

charred monolithBOT
limber skiff
#

so like

#

does anyone know what they actually changed and reverted

#

that caused many broken things

fossil inlet
#

everything reverted

austere talon
#

in hindsight i think yes

limber skiff
#

but they will push it again probably

fossil inlet
#

there was one that renamed all i18n keys

limber skiff
#

nono

#

they didn't rename

fossil inlet
#

and a seprate that bugged profile popouts

austere talon
#

did theyj ust change the hash algorithm

fossil inlet
austere talon
#

they might patch it internally lol

#

for the funnies

fossil inlet
austere talon
limber skiff
fossil inlet
austere talon
limber skiff
#

so something else then

austere talon
#

idk how to test it

#

i couldn't manage to make it use hljs

limber skiff
#

once im in my pc

austere talon
#

insane

image.png
odd heath
jolly egret
#

i am quickly losing track of if there is or isn't an issue

image.png
austere talon
#

nvm managed to test and it seems to work fine

fossil inlet
long stream
charred monolithBOT
#
Julienraptor01
[Vendicated/Vencord] Pull request opened: #3093 Update the prodversion in the extension download URL

The version 32 is too old and cause the request to fail
The 32bit int limit seems to be the max value and should make the request not fail for a few years hopefully
This change doesn't really matter for Vencord as its only use is to load react dev tools which are not taken from the chrome web store anyway, but it will fix the feature if a userplugin try to load chrome extensions

charred monolithBOT
#
million1156
[Vendicated/Vencord] Pull request opened: #3094 feat: Disable faulty plugins to prevent unrecoverable loop

An issue a lot of people have when Discord updates is their plugins break. Sometimes, the update is so significant that Vencord itself is broken (i.e. cannot manually disable plugins). I experienced this issue myself, and so I created a pretty decent solution.

When the user enters an "unrecoverable loop" (this is triggered when Vencord crashes 2x in <1s), we disable all plugins EXCEPT for plugins that are API related (i.e. CommandsAPI, plugins that are marked as required (such as `...

limber skiff
#

@austere talon their build that broke shit had webpack not so minified?

image.png
#

lmao?

#

also wreq.O was back

#

__webpack_require__.ruid = "bundler=rspack@1.1.7-canary-b97d7643-20241217072837" blobwob

austere talon
#

probably accidental lol

charred monolithBOT
limber skiff
#

so this is what they turned off a while ago

opaque silo
charred monolithBOT
#
million1156
[Vendicated/Vencord] New comment on pull request #3094: feat: Disable faulty plugins to prevent unrecoverable loop

in its current state this is kinda awful because it will completely overwrite your settings and force you to reenable everything

it doesn't override settings, it just disables plugins. they can easily be re-enabled and that's why there's a simple button to copy any disabled plugins. and again, this is really only triggered in the worst-case scenario (i.e. when a user cannot disable faulty plugins & they need to access discord).

for example, in the latest episode of "vencord broke plz...

#
Vendicated
[Vendicated/Vencord] New comment on pull request #3094: feat: Disable faulty plugins to prevent unrecoverable loop

doing so would be fairly trivial. you just need to add a new safeMode setting and edit this function:

https://github.com/Vendicated/Vencord/blob/48a9aef2ebafbc72a0245a3725bf3c84bc9d76c6/src/plugins/index.ts#L45-L51

new code would look something like this

 export function isPluginEnabled(p: string) { 
     return ( 
         Plugins[p]?.required || 
         Plugins[p]?.isDependency || 
         (settings[p]?.enabled && !settings.safeMode) 
     ) ?? false; 
 }
#
million1156
[Vendicated/Vencord] New comment on pull request #3094: feat: Disable faulty plugins to prevent unrecoverable loop

sorry but you cannot "easily re-enable" 100 plugins 😭

if you actually want to make this better, you should not do any disabling and instead add a safe mode functionality that skips starting non essential plugins and such without needing to modify any settings

this safe mode could then be used to disable plugins / update / whatever

fair point, i'm coming from the perspective of only having like 4-5 plugins but if you're a power-user then yeah you're right. i'll change this b...

#
million1156
[Vendicated/Vencord] New comment on pull request #3094: feat: Disable faulty plugins to prevent unrecoverable loop

doing so would be fairly trivial. you just need to add a new safeMode setting and edit this function:

https://github.com/Vendicated/Vencord/blob/48a9aef2ebafbc72a0245a3725bf3c84bc9d76c6/src/plugins/index.ts#L45-L51

new code would look something like this

 export function isPluginEnabled(p: string) { 
     return ( 
         Plugins[p]?.required || 
         Plugins[p]?.isDependency || 
         (settings[p]?.enabled && !settings.safeMode) 
     )...
#
Vendicated
[Vendicated/Vencord] New comment on pull request #3094: feat: Disable faulty plugins to prevent unrecoverable loop

what I am thinking of:

when an unrecoverable crash happens, it should show a popup notifying the user of such and offer them the option to restart in safe mode. now vencord will set the safeMode setting to true and restart the app.

once all plugins finished initialising, it should automatically change the setting back to false so the next time the user opens the app it will be normal mode again

a command line toggle --vencord-safe-mode (or similar) could also be added

frail skyBOT
#
Bad Patches

ShowHiddenThings (found no module):
ID: -
Match: ```
prod_discoverable_guilds


**__ShowHiddenThings (found no module):__**
ID: `-`
Match: ```
">200"

ShowHiddenThings (found no module):
ID: -
Match: ```
"pepe","nude"

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ShowHiddenThings (found no module):
ID: -
Match: ```
prod_discoverable_guilds


**__ShowHiddenThings (found no module):__**
ID: `-`
Match: ```
">200"

ShowHiddenThings (found no module):
ID: -
Match: ```
"pepe","nude"

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
million1156
[Vendicated/Vencord] New comment on pull request #3094: feat: Disable faulty plugins to prevent unrecoverable loop

what I am thinking of:

when an unrecoverable crash happens, it should show a popup notifying the user of such and offer them the option to restart in safe mode. now vencord will set the safeMode setting to true and restart the app.

once Vencord finished initialising, it should automatically change the setting back to false so the next time the user opens the app it will be normal mode again

a command line toggle --vencord-safe-mode (or similar) could also be added

...

jolly egret
#

the amount of deployments to canary today scares me

glass jasper
opaque silo
long stream
#

they deploy to canary 24/7

#

sometimes less than a minute after the last build

opaque silo
#

ctrl+s deploys to canary

charred monolithBOT
long stream
#

lmao 😭

rugged spire
rugged spire
signal rover
#

the 25mb upload limit has been working fine on Aliucord for awhile now and me and a friend decided to get it working on desktop

rugged spire
#

shouldnt this be patched less generically

#

what does global discovery have to do with it

#

i'd assume they check super props

signal rover
#

Not sure how to do it a better way

long stream
#

i'd say there's no good way to patch it

signal rover
#

Eh well it works so

#

Β―_(ツ)_/Β―

long stream
#

anti-spam would definitely be suspicious if there were a bunch of requests coming from an ancient or non-existent build

#

especially on web where it's almost impossible

rugged spire
#

yes build 10000 very not sus

signal rover
#

I'll see if I could change it to something that works and is a more valid build number

rugged spire
#

also fyi vencord includes a built in regex macro thing for js identifiers

#

you can just use \i

#

see src/utils/patches.ts

fossil inlet
signal rover
#

Based

#

There I made it use a real build number

limber skiff
opaque silo
#

you should define a range of working build numbers and first run it picks one

limber skiff
#

I suppose that number is used in super properties?

long stream
signal rover
#

Yes

limber skiff
#

what if we change it just for attachment request

rugged spire
signal rover
#

Yes but im stupid

opaque silo
signal rover
#

and cant figure that out

long stream
#

cuz restapi sends it

limber skiff
#

maybe

#

but would definitely be interesting ;)

opaque silo
#

you will spend 5 hours doing that for the same functionality

long stream
#

also that patch probably breaks rollouts for experiments past sky_load i think?

#

actually no

limber skiff
signal rover
#

anyway right now I made it use the aliucord build number for their super props

#

Feel free to improve on it if you want

limber skiff
#

using aliucord build number is definitely the smartest move

signal rover
#

I would use a more proper desktop build number

#

but the issue is there is no list of them

opaque silo
#

inb4 all aliucord and vencord users are banned for using it

fossil inlet
long stream
signal rover
long stream
#

sky load started rolling out <t:1725898898>

signal rover
#

sky load?

long stream
#

the experiment that controls the limit

rugged spire
#

the experiment for it

signal rover
#

Ok so use a build number from that day?

rugged spire
#

idk

long stream
signal rover
#

So 307825

limber skiff
#

hear me out

#

we can probably store a cached super properties in the plugin

#

and then patch rest api, if the route is the attachments one, use the plugin one

#

(which has modified build number)

rugged spire
#

bad idea

fossil inlet
#

tbh i feel like this is a bit too cursed

rugged spire
#

why patch the whole object

limber skiff
#

huh?

fossil inlet
#

vencord shouldnt be fucking with build number / super props

signal rover
#

God nelly.tools sucks to use

#

why cant I pick a page

rugged spire
fossil inlet
rugged spire
#

just read the existing super props and edit the build number?

limber skiff
#

super props is base64 encoded

#

and cached

#

and even then, if you do that, you are changing the build number in every request

rugged spire
#

okay

#

do it once and cache it

limber skiff
#

which might limit some other things

limber skiff
rugged spire
#

yop

limber skiff
#

and then just use it for the attachment upload

rugged spire
#

when you said cached i thought you meant "ship a preset super properties"

limber skiff
#

nono

signal rover
#

307825 works

#

btw

limber skiff
#

cache an encoded super prop with just the build number changed

fossil inlet
#

also wouldnt this plugin go under fake nitro

#

instead of its own thing

rugged spire
#

fakenitro needs a rewrite lol

signal rover
fossil inlet
signal rover
#

No tis not

rugged spire
#

it is now it was not before

signal rover
#

you cant go past 25mb without nitro

#

and the free limit is 25mb

opaque silo
# signal rover 307825 works

a single build number for all users seems so insane.. discord HQ getting a billion hits on an old ass build 🀨

signal rover
#

*server side

signal rover
fossil inlet
#

then why not use aliucords super props?

opaque silo
#

Aliucord soo much smaller than Vencord

rugged spire
signal rover
grave mangoBOT
signal rover
#

and I have been using it daily for years now

fossil inlet
signal rover
#

and the build number for it has not changed for a long time since react native

#

as its still on the last kotlin build

opaque silo
#

does discord have a history of catching old build numbers in its spam filter (excluding Aliucord)

signal rover
#

No

#

not that im aware of

#

it would be very weird if they did as that would basically make it so people who just leave discord on 24/7 and barely restart it have issues

long stream
#

well eitherway, this probably wouldn't last too long

#

discord usually removes experiments like this after they're fully rolled out

signal rover
#

Its not an experiment anymore and has already been rolled out

long stream
#

it still is

#

the only reason your patch works is because it has a build filter

#

once they fully remove it from both the client and the backend, it won't work anymore

signal rover
#

Well lets see how long it last

jagged cloak
#

(not very long)

#

i wouldn't rely on it regardless

charred monolithBOT
rugged spire
#

vee has exploded it

jolly egret
charred monolithBOT
still maple
charred monolithBOT
fossil inlet
#

tbh no point in plugin if rollout in jan

rugged spire
fossil inlet
rugged spire
#

oh

#

because I have already tried it

#

where the hell is it coming from?

#

oh

#

userplugin

#

you just copied your userplugin changes to your PR

#

got it

jolly egret
#

it was a PR first

rugged spire
#

i do know that

#

i even left comments there

#

was this a "I remember this exists"

fossil inlet
#

TBH favorite plugin I've made

rugged spire
#

i have made so many plugins that I don't know what my favourite would be

#

you know what would be fun

#

experiments have an "exposure" tracking system

#

what if we did this for plugins

#

not to report it or anything

#

just as a sort of "fun thing"

#

could also be used to sort plugins in the settings list

#

a "sort by recently interacted with" for example

fossil inlet
rugged spire
fossil inlet
rugged spire
#

WHY

#

it doesn't have to be sent to a server

fossil inlet
#

am i not understanding your idea

rugged spire
#

do i need to make the description more brief

fossil inlet
#

no i dont understand your idea

rugged spire
#

system that tracks when you interact with plugins, all locally

i don't exactly know what should be tracked and how
on hover/click in plugin UIs could be tracked as an active interaction
rendering something visible without user interaction could be a passive exposure event

this data could be used to sort the plugins list

changing settings could also be some kind of interaction

#

its a bit weird considering there is a notrack plugin for stock discord events

#

maybe only the latest interaction date could be stored?

fossil inlet
#

Nope

#

That seems like a really bad idea for a bunch of reasons

rugged spire
#

Please explain why

#

Is it just a huge pain to implement in every plugin

fossil inlet
#

Like

rugged spire
#

I'm scared.

fossil inlet
#

Really cursed

rugged spire
#

go on it cant be that bad

#

we are having a deranged conversation in DMs about this

#

WHAT IS THAT

Sqaaakoi-21-12-2024-04-49-00.png
rugged spire
rugged spire
fossil inlet
#

either way, i dont think the gain is worth it

scenic brook
#

So you can do it in a way that sucks or a way that sucks

fossil inlet
#

most users wont care

scenic brook
#

People would probably be happier to see plugin categories

rugged spire
#

should i be scared

Sqaaakoi-21-12-2024-05-27-20.png
rugged spire
rugged spire
scenic brook
#

Or maybe like tags if not categories

rugged spire
#

Tags exist

#

Barely any plugins implement them

fossil inlet
#

arent those just addtional search terms

rugged spire
#

yes

#

they exist but arent really displayed trolley

#

should we display them?

fossil inlet
#

no

#

see how they are used in showHiddenThings

#

those arent categories

rugged spire
#

true

scenic brook
#

Could have an additional option per tag whether to display it on the plugin list I guess but that'd probably look meh

rugged spire
#

thats husk

#

just implement categories

scenic brook
#

Gonna have to start telling people off for adding unnecessary new categories in future lol

brazen bone
#

Categories shouldn't be free text

#

They should be from a defined enum

rugged spire
#

I disagree

#

I think there should be a middle ground

#

Enum for known categories but userplugins for example can implement their own

brazen bone
#

Kinda like authors?

rugged spire
#

Categories listed in the client could be filtered to be known or at least 2 plugins using them

scenic brook
#

Hasn't it been mentioned somewhere that the plugin menu could do with a rewrite or something?

rugged spire
# 
VV       VV              sqaaakoi
 VV     VV               Version: 1.10.9 ~ dc7a7866 (Dev) - 19 Dec 2024
  VV   VV                Client: Canary ~ Vesktop v1.5.4
   VV VV                 Build Number: 355506 ~ Hash: 88ce261
    VVV
        CCCCCCC          Platform: Linux (Linux x86_64)
       CC                Plugins: 106 / 179 (official), 34 / 59 (userplugins)
      CC                 Uptime: 2835s
       CC
        CCCCCCC          Donor: no
                         Contributor: yes

                         β–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆβ–ˆ
#

husk

scenic brook
#

I think I'm thinking of this convo

rugged spire
#

i do not want a full page plugins menu if the client unloads

charred monolithBOT
#
nay-cat
[Vendicated/Vencord] Pull request opened: #3096 Fixed fucked links

I use the translate plugin very often, but there is something that makes me very nervous.

When I go to send memes to my friends, THIS HAPPENS

image

Or this also happens!

image

I have added a small piece of code that takes care of checking the links in the message, avoiding them when translating the message, I hav...

fossil inlet
limber skiff
frail skyBOT
#
Bad Patches

ShowHiddenThings (found no module):
ID: -
Match: ```
prod_discoverable_guilds


**__ShowHiddenThings (found no module):__**
ID: `-`
Match: ```
">200"

ShowHiddenThings (found no module):
ID: -
Match: ```
"pepe","nude"

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ShowHiddenThings (found no module):
ID: -
Match: ```
prod_discoverable_guilds


**__ShowHiddenThings (found no module):__**
ID: `-`
Match: ```
">200"

ShowHiddenThings (found no module):
ID: -
Match: ```
"pepe","nude"

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
million1156
[Vendicated/Vencord] New comment on pull request #3094: feat: Disable faulty plugins to prevent unrecoverable loop

@Vendicated πŸ‘‹ As requested, I went ahead and did what you suggested instead, which is as follows:

charred monolithBOT
charred monolithBOT
jolly egret
#

overengineering instead of figuring out why what you did didn't work despairge

charred monolithBOT
charred monolithBOT
jolly egret
#

I think the whole point of client mods is to improve your experience in ways that doesn't result in your account getting nuked

#

don't need to act all entitled because the owner of a client mod doesn't want to gamble peoples accounts

rugged spire
#

even if you forget risking user accounts, you will have users that get the update in a few days to a week, try it, and in a month people will complain it broke

scenic brook
#

Ideally there would be no uncategorised or it'd just be labelled misc or something but for the moment it's fine, I just threw a some labels onto a handful of plugins

charred monolithBOT
rugged spire
#

Where's your source code?

scenic brook
#

Yeah that's something to consider, it's ORed atm

rugged spire
#

I can tell

scenic brook
rugged spire
#

I recommend making sure it is on a dedicated branch

#

This seems like something that would be very welcome upstream

charred monolithBOT
fossil inlet
odd heath
#

Yop

#

Need this in stock vencord blobcatcozy

brazen bone
#

Stock needs plugin categories yes

scenic brook
#

I will open a draft Soonℒ️ but for the moment, I also made the plugin list scrollable separate from the page so it's less jarring when you change filters and you don't have to scroll all the way back up

rugged spire
#

just found an obscure bug

rugged spire
#

there's just a lot of wasted vertical space without these changes

#

i think people know how to enable plugins now

brazen bone
rugged spire
charred monolithBOT
jolly egret
#

Opening PRs from VSC despairge

charred monolithBOT
fossil inlet
#

Vsc so good

granite wharf
odd heath
#

yeah i dont think thats necessary

#

that does absolutely nothing

granite wharf
#

I do feel like just disabling them completely would also work but vencord isn't modular so disabling individual plugins if they don't work is okay I guess

#

It would probably be good for plugins to have an indicator that it is faulty

odd heath
granite wharf
#

I don't like force disabled plugins like that

austere talon
#

so much overengineering

granite wharf
#

have you ever thought of having something before discord loads up so people can disable plugins and stuff @austere talon

austere talon
#

?

granite wharf
#

hard to explain

#

hold on

long stream
granite wharf
#

like the website

long stream
#

o the actual app

austere talon
#

that doesn't make any sense nor is it feasible

granite wharf
#

not sure what u mean it is feasible silly

#

not sure why it doesn't make sense either because it would give people an option to at least access settings in case the plugin is broken nachoAho

charred monolithBOT
austere talon
granite wharf
#

it was unrelated to that pr

austere talon
#

and infeasible because you need to completely stop discords initialisation, which in turn makes their modules unavailable which are depended on by the ui

charred monolithBOT
still maple
limber skiff
#

plugins list need more horizontal space

#

specially if we wanna use pics later

scenic brook
#

I always found it kinda weird that all of Discord's settings tabs are so narrow, so much empty screen

limber skiff
#

this is just horrible

#

needs to be more like this

scenic brook
limber skiff
#

and even then I feel like too much space wasted

scenic brook
#

Would you just have the tab open a full screen page similar to the text playground thing in the dev settings or put a button for it somewhere else instead?

limber skiff
#

yeah I think

#

but the text playground thing seems kinda meh too

scenic brook
#

Yeah it's annoying to accidentally click, it fully takes you out of settings when you close it

charred monolithBOT
long stream
#

ShowHiddenThings: Discovery filter bypass is pa..

fossil inlet
long stream
#

i just found it funny how many times it was repeated xd

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
teal nest
#

hey, i'm trying to change the help icon on the top right when i click it from, for example, a.CircleQuestionIcon to a.PauseIcon. How would I go about doing so?

image.png
fossil inlet
teal nest
#

maybe, how do i do that?

fossil inlet
#

with a patch?

#

if you want, send a module id and ill send you a patch

teal nest
#

imma see if other plugins do anything similar to see how i can do it

#

300986

fossil inlet
# 
{
    find: "\"ko\",\"ja\"",
    replacement: {
        match: /(?<=icon:a\.).{0,20}(?=,)/,
        replace: "myIcon"
    }
}```
#

@teal nest

teal nest
#

πŸ™ tysm

fossil inlet
#

np

limber skiff
#

why did you hardcode a

fossil inlet
#

@teal nest replace icon:a with icon:\i

teal nest
#

catched that already but ty πŸ™

still maple
brazen bone
#

Wikipedia was always wide, they recently changed it to not be as wide but with a setting to revert it back to normal

charred monolithBOT
rugged spire
rugged spire
fossil inlet
#

is there a vscode plugin that lets you see review comments in vscode

rugged spire
fossil inlet
#

somehow i didnt have that installed

#

@limber skiff can you run reporter

#

wait

#

i might just be stupid

#

yea

#

im just sstupid

charred monolithBOT
limber skiff
#

lil more

rugged spire
#

when will we have proper display names for plugins then

limber skiff
#

pretty sure the plugins in the list will always be like that

#

it's what people are used to

rugged spire
#

we should fix the way settings does it

limber skiff
#

wdym?

fossil inlet
rugged spire
#

it adds a space on every capital letter

fossil inlet
#

eh

rugged spire
#

even if it's after another capital letter

fossil inlet
#

i think pascal case is fine

rugged spire
#

the way it's rendered isn't

#

this mess

Sqaaakoi-22-12-2024-18-42-30.png
limber skiff
#

ya settings definitely need displayName

rugged spire
#

lol something here needs to change

Sqaaakoi-22-12-2024-18-43-49.png
#

i got an error modal to pop up yesterday

#

maybe not this bit of code

limber skiff
grave mangoBOT
limber skiff
#

in your pr

rugged spire
#

what does that do

limber skiff
#

I was casually looking at the source code (which I made) and noticed that

limber skiff
fossil inlet
#

wait, afaik comma doesnt needed to be escaped

limber skiff
#

it likely wont have any difference but just to be sure

rugged spire
#

so many plugins do this

#

it's horrible

#

wtf happened to vscode

fossil inlet
#

@limber skiff are you sure you dont mean the period at the start

#

not the comma at the end

limber skiff
#

oop

rugged spire
limber skiff
#

yes, that

#

I used the wrong word

fossil inlet
rugged spire
fossil inlet
#

need to upload animated steamcatcozy

rugged spire
#

you can get an error here btw lol

Sqaaakoi-22-12-2024-18-46-44.png
limber skiff
#

how so?

rugged spire
#

click this

Sqaaakoi-22-12-2024-18-47-46.png
limber skiff
#

no error

rugged spire
#

why is my gpu running out of memory

fossil inlet
#

i think thats errored for me

#

before

#

but that was before i made plugins

#

so i never looked into that before

#

however it doesnt now

#

@limber skiff should be good blobcatcozy

limber skiff
#

use errorboundary .wrap

#

and if you really want a fallback, pass the original in the patch as an argument

fossil inlet
#

alr

fossil inlet
#

what makes wrap better

limber skiff
#

I don't know how to explain exactly

#

but it wraps more code in the try catch

#

πŸ˜›

fossil inlet
#

love

#

@limber skiff how do i pass props to the wrapped component

limber skiff
#

look at how other plugins do it

fossil inlet
#

@limber skiff this seems cursed, but i have no idea how else to do it

tried looking at other plugins, but only 2 use the fallback

especially line 47

limber skiff
#

what exactly do you not understand?

fossil inlet
#

not that i dont understand

#

it just seems a bit cursed

#

on line 47

#

and theres nothing else to compare against

limber skiff
#

ill modify it tomorrow or something and show you

#

easier like that

fossil inlet
#

alr steamcatcozy ty

austere talon
#

(it was also using idx before that pr because it implicitly uses idx if you don't specify the key)

austere talon
#

there's no guarantee that lines are unique

limber skiff
#

ah

#

not same ref?

charred monolithBOT
charred monolithBOT
#
Rec1dite
[Vendicated/Vencord] Pull request opened: #3099 New Plugin: Collapse

Originally just created this for myself, but it seems to be a pretty popular request on here:

https://github.com/Vendicated/Vencord/issues/1834
https://github.com/Vencord/plugin-requests/issues/568
https://github.com/Vencord/plugin-requests/issues/724
https://github.com/Vencord/plugin-requests/issues/892

At the moment it just adds a single button for enabling/disabling/auto-collapsing the channel list sidebar.
In future I'd like to turn the button into a dropdown for collapsing ot...

charred monolithBOT
scenic brook
# limber skiff

I unset the max width and sidebar size just for that tab (I'm sure the css can be cleaner), doesn't look bad but it could do with a smoother transition. Example with banners if they become a thing eventually as well

image.png
rugged spire
#

did you push the branch for that @scenic brook

#

honestly idk if it should be like that

#

feels jarring

#

maybe a checkbox to do that? but that seems dumb too

rugged spire
#

can you please do so (i want to test it)

#

idc if your commits are ugly

scenic brook
#

This is all just throwing shit at a wall and seeing what sticks anyway so it's fine if it sucks

#

It's good to see ideas actually in action

fossil inlet
scenic brook
#

The initial categories I put on everything are very much a rough draft too, it's pretty mind numbing going through them all and deciding what to assign lol

long stream
#

this should be something that a theme provides

rugged spire
#

this UI is horror

Sqaaakoi-23-12-2024-05-30-41.png
scenic brook
fossil inlet
odd heath
fossil inlet
rugged spire
#

and not what I am talking about

brazen bone
#

0 to disable, separate toggle for max

#

Great ui

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
charred monolithBOT
granite wharf
#

my banners pr looks so good with the visual refresh

image.png
fossil inlet
granite wharf
#

no

#

its still there opened

fossil inlet
#

you will suffer the same fate as timedones

granite wharf
fossil inlet
#

@crude hearth timedones when

granite wharf
#

also surprised my slight changes to the quick actions also work pretty good for the visual refresh

#

I find this very lovely

fossil inlet
#

how do the cards look in light mode

granite wharf
#

blinding light

image.png
fossil inlet
#

the contrib cards

#

do they look horror

granite wharf
#

they just stand out way more

fossil inlet
#

pop more with the dark background

granite wharf
#

mayb

#

the plugin cards aren't so fortunate with the new themes

image.png
#

this too

image.png
crude hearth
scenic brook
#

No music in this one, you're safe

#

Obviously readme images aren't made with the intention to be banners so they are terrible

#

Also if we do eventually have banners for plugin cards, where would they be hosted? I assume they'd be shown on https://vencord.dev/plugins as well so maybe there?

desert cosmos
#

pretty sure there's an github issue which has all the plugin previews

charred monolithBOT
charred monolithBOT
scenic brook
#

So good they forked it twice

charred monolithBOT
jolly egret
#

people need to stop putting themselves at the top of the contributors list put yourself at the bottom !!

scenic brook
#

It's that Alpha Energyℒ️

odd heath
charred monolithBOT
#
rylie-b
[Vendicated/Vencord] Pull request opened: #3102 New Plugin DisableAnimations

Plugin simply disables all animations from profiles/servers/avatars instead of forcing them all on either on load or on hover (always on is already a plugin); I amended the AlwaysAnimate plugin to suit folks like myself with epilepsy, seizure risks, et al - as Discords response to updating their accessibility features functionally neutered this.

fossil inlet
brazen bone
#

Just sort the list alphabetically

#

Or have a data/contributors/*.json which is parsed at build time

odd heath
charred monolithBOT
charred monolithBOT
glass jasper
rugged spire
rugged spire
austere talon
#

it really doesn't matter

#

solving conflict on that file is so easy

#

and why the hell would you move it to a json file

#

pointless

#

and impossible to store bigints

rugged spire
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
rugged spire
#

vendroid moment

charred monolithBOT
dusk blaze
#

@rugged spire you love

rugged spire
#

yes

#

does spotify itself do this

#

if yes then set it to true by default

dusk blaze
#

every single player does

#

including spotify

dusk blaze
#

Guh

rugged spire
#

force push horror

dusk blaze
#

not there

rugged spire
dusk blaze
#

there

charred monolithBOT
rugged spire
charred monolithBOT
fossil inlet
#

@rugged spire Thoughts on a stale bot for PRs?

rugged spire
#

Vencord needs more reviewers instead

#

well

#

what if (i would not)

Sqaaakoi-24-12-2024-14-29-30.png
#

i love trying to fix issues some random user submitted that are totally valid but occur for no good reason

dusk blaze
#

RPCeditor will be instantly obliterated

rugged spire
dusk blaze
#

@austere talon thats an actually good idea

rugged spire
dusk blaze
#

add some good plugin devs as readonly collaborators

#

then they can do request changes/approve

rugged spire
dusk blaze
#

then you just need to go through the approved prs and light review

rugged spire
#

yop

austere talon
#

this is like the 20th time someone has proposed this glorious idea

#

problem: there is literally nothing i have to do for that to become a reality, anyone can just review. however, no one ever does that

rugged spire
austere talon
#

you can still leave review comments.

rugged spire
#

yes but that doesn't leave as much of a marker as an approval

dusk blaze
#

yeah but then how do you know which prs are sane and which still require you/someone else to review

rugged spire
#

^^^

#

reality is 95% of obvious bad plugins are denied, but anything decent is left to rot

charred monolithBOT
rugged spire
#

why does it hate this refactor

Sqaaakoi-24-12-2024-14-50-24.png
#

i'm not going insane am I?

limber skiff
#

DELETE_PENDING_REPLY, onDeletePendingReply

rugged spire
#

i'm dum

brazen bone
#

That would be valid in python

#

(It would make a set)

rugged spire
#

my fix did not work

#

fucking react making their own KeyboardEvent wrapper

rugged spire
limber skiff
#

simply try to save the old state

#

and then move it back after

rugged spire
#

yeah at this point thats probably the only answer

#

what if we unfocus the dom node and reselect it?

#

nop

limber skiff
#

why does it move the caret?

#

ah

#

ctrl + up...

charred monolithBOT
limber skiff
#

@rugged spire

#

uh wait

# 
function onKeydown(e: KeyboardEvent) {
    e.preventDefault();
    const isUp = e.key === "ArrowUp";
    if (!isUp && e.key !== "ArrowDown") return;
    if (!isCtrl(e) || isAltOrMeta(e)) return;

    if (e.shiftKey)
        nextEdit(isUp);
    else
        nextReply(isUp);
}
#

try it

#

if it's a browser thing it makes a lot of sense to just prevent the default

rugged spire
#

you are going to make me look like a dumbass in 15 seconds

charred monolithBOT
limber skiff
#

I havent tested

charred monolithBOT
limber skiff
#

but...

#

it does make a lot of sense

#

AJJSDFDHFDSFSSDF

rugged spire
limber skiff
#

did it work...

rugged spire
#

yeah

limber skiff
#

😭

#

happens to the best of us

rugged spire
#

i wonder if i can nuke injecting there

limber skiff
#

these default events are tricky

rugged spire
#

i was calling stopImmediatePropagation thinking that was the problem

granite wharf
#

@rugged spire should be okay now

charred monolithBOT
rugged spire
#

is it worth firing a component dispatch event like the stock reply button does @limber skiff

limber skiff
#

what component dispatch exactly?

rugged spire
#

ComponentDispatch.dispatchToLastSubscribed("TEXTAREA_FOCUS");

#

hang on

#

maybe this is needed now

#

it is actually

#

else looks weird

limber skiff
#

what's the difference?

rugged spire
#

stock reply button does it to focus immediately rather than when you actually start typing

charred monolithBOT
rugged spire
#

@limber skiff thanks for helping me very obvious things twice

limber skiff
#

dont worryyy

#

the questions I used to do

#

why is it blue...

image.png
fossil inlet
versed fern
#

When i was making my plugin i kept going to the plugins channel to ask questions then figuring out the answer as i was typing out the question.

rugged spire
glass jasper
#

there was a very lenient guideline back then and wasn’t there

charred monolithBOT
rugged spire
charred monolithBOT
scenic brook
#

Gay plugin list

long stream
austere talon
#

that looks so awful 😭

scenic brook
#

I'm just fucking around at this point dw

#

There's like nobody in at work today so I'm bored

charred monolithBOT
#
biast12
[Vencord/Vencloud] New comment on issue #47: Crashing when i try to enable cloud integrations / accept the OAuth2

Hey sorry for not getting back yet, I'm home for the Christmas so I'm not at my PC at the moment, I already turned the security/password off so I'm not sure if that's the issue.

What redis link is supposed to be in the .env? Like is it the Public endpoint, the connect link or?

Also I noticed that it set a password by default so it's probably a good idea to get the pr finished as it might create confusion for someone who's completely new to all of this.

still maple
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

fossil inlet
#

what if discord gave us a bundler update as a christmas gift

limber skiff
#

they aren't pushing new builds

long stream
#

staff are most definitely on a holiday break now

fossil inlet
#

it was a joke 😭

jolly egret
#

the few staff there at discord to make sure things don't explode are going to push a bundler update

rugged spire
#

i should've stated this before but i think a background with low opacity when not focused would look nice

glass jasper
rugged spire
#

I MEAN ON THE PILL BUTTONS

#

FOR THE CATEGORIES

brazen bone
charred monolithBOT
dusk blaze
rugged spire
#

@dusk blaze you. get to work.

scenic brook
dusty finch
charred monolithBOT
charred monolithBOT
sterile oak
charred monolithBOT
desert cosmos
# charred monolith

instead of a dedicated "hide" button i'd probably do it like the spotify controls which expand on hover

jolly egret
#

goes to leave the call
entire menu expands

#

or if its less sensitive than that then you still have the problem of moving the cursor too low accidentally and triggering it lol

odd heath
#

if you hover for certain amount of ms it expands

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

versed fern
#

It has been too long since last better folders break.

charred monolithBOT
brazen bone
charred monolithBOT
versed fern
fossil inlet