so it still has a lot of old broken shit ๐ญ
#๐พ-core-development
austere talon
charred monolithBOT
limber skiff
aight
limber skiff
let me test it again
austere talon
code looks good
you can merge if it's all good
actuall wait
nvm
we did merge it into volumebooster thats good
or wait no
limber skiff
huh
austere talon
i was proposing to extract it into WebVolume or smth like that which is enabled by default to match expected behaviour
limber skiff
nvm it's not good yet
sound is way to loud on lower porcentages
it doesnt really happen and the audio looks way lower on like 10% than with the plugin enabled
it's so much louder that you can easily see where the volume turns to 0% when you are in like 8%
it's impossible to get a good enough low volume with the booster lol
somber thorn
:( โโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโโ
fossil inlet
@limber skiff ill take a look at it and see what i can do
austere talon
should i release then?
limber skiff
yeah
austere talon
lets run test one last time
(im paranoid)
oh yeah i still wanna continue working on auto reporter
fossil inlet
oh yeah i still wanna continue working on auto reporter
whats autoreporter?
austere talon
autoreports
fossil inlet
is that just reporter whenever discord pushed a new commit
frail skyBOT
austere talon
ye
frail skyBOT
limber skiff
I really don't wanna annoy with it but is it possible for my big pr to have a chance to get merged soon
it's been there for so long at this point I just keep doing nitpicks with myself lmao
fallen vale
1.9.8 - the nuckyz update (ft. rniii)
glass jasper
NoMaskedUrlPaste ๐ญ
We had to make a plug-in to stop the feature that was a plug-in that discord stole
austere talon
scared me for a second
dusk blaze
wtf did I do now
sorry i ate the object
austere talon
that means u put something in settings that isnt plain object
austere talon
what did you do
limber skiff
no idea I didnt even touch more user tags recently?
austere talon
why did it turn that into a settings proxy
limber skiff
I probably messed up console shortcuts somehow
^^
happened in the past already but I had fixed it
fossil inlet
@limber skiff on vesktop, with volume booster disabled, i can fully recreate it
if you're experience something else, could you please send me a video so i can understand what you're talking about
fossil inlet
what ๐ญ
limber skiff
actually I might know how to reproduce
I had changed a more user tags setting when that happened
yep
happened
thank god
๐
@austere talon IT HAPPENS IN DEVVVVVVVVVVVVVVVVVVVVVVVVV
austere talon
?
limber skiff
the error
is not only in my branch
it might be only when you change more user tags settings, but i'm not sure yet
austere talon
oh yeah
i can repro
ya
seems to be more user tags
yeah cause this is proxy
and it's calling setValue(proxy)
limber skiff
I think the issue is just that's it's a nested object
austere talon
how was this never caught
no
that should not be using store
it should use plain
or clone the object itself
limber skiff
let me test something
austere talon
that code is just bad
limber skiff
okay yeah
austere talon
it should use plain not store
but that will make it not reactive
so instead it could just forget about the save button and never call props.setValue
limber skiff
MoreUserTags is the only plugin that has a nested object in settings and the settings UI modifies it
austere talon
MoreUserTags is the only plugin that has a nested object in settings and the set...
once again that's not the problem
limber skiff
I know
austere talon
the problem is with the plugin
limber skiff
how it was implemented is the problem
I'm just mentioning that other plugins that have a nested object could have this issue too, but they dont use the settings UI to modify it
ignore activities for example
austere talon
I'm just mentioning that other plugins that have a nested object could have this...
no they cant
limber skiff
they could if they implemented it wrong like more user tags did
but whatever it's just an issue with it as you have mentioned
austere talon
either use plain and handle state urself
or don't call props.setValue() ever
both will work
that code is just wrong
charred monolithBOT
austere talon
i think we should get rid of the temporary settings and the save button entirely
have the settings be live
limber skiff
I had done this
fossil inlet
@limber skiff I was able to fix the stock issue by removing the math.round.
feel kinda stupid now for not thinking of that earlier
while it is accurate now, it is not stock behavior with volumes lower than 100%
austere talon
I had done this
won't update the ui im pretty sure
cause you're not changing any state
limber skiff
it is
const [tagSettings, setTagSettings] = useState(settings.store.tagSettings as TagSettings);
that's the state
austere talon
yes but
setTagSettings(tagSettings)
this does nothing
react ignores that
if the new state is equal it wont change
you would have to create a new object to cause it to rerender
austere talon
you would have to create a new object to cause it to rerender
like
onChange={v => setTagSettings(s => ({ ...s, text: v }))}
anyway that code was just bad
that entire state stuff made no sense
limber skiff
I'm just gonna port settings.plain since it may be useful in the future
austere talon
i think we should get rid of the temporary settings and the save button entirely
what do you think about this though
personally i can't think of a scenario where i changed some settings and then want to reset back
and it makes our logic more complicated
and rn it has some issues with validation where you need to reopen the modal after changing some setting
austere talon
what do you think about this though
personally i can't think of a scenario wher...
even if there were, it's easy to just manually change it back
limber skiff
oops stole your commit
austere talon
honestly entire settings ui needs a refactor anyway, it's so convoluted
we just kept adding more and more to it and now it's so messy
limber skiff
I agree
austere talon
it could benefit greatly from being split in more smaller components in separate files
rn it's a nightmare to change stuff
austere talon
oops stole your commit
xd i dont care
austere talon
i should cherry pick some of my changes from asar pr
austere talon
at least the issue was not caused by me
i still wonder how it wasnt caught until now
limber skiff
ikr
austere talon
oh u added plain
i was confused
anyway if u wanted smth to work on, maybe you could do auto reporter instead, ifeel like you might be interested
essentially just whenever new canary/stable release run tester
austere talon
like we talked about before
i haven't done much so far, only detection for new version (which polls latest.json once a minute)
austere talon
i haven't done much so far, only detection for new version (which polls latest.j...
(if you're gonna finish it, you can choose a different language too if you want, i only did go cause i like it)
austere talon
is it also like this for u
limber skiff
it's not
austere talon
so maybe discord web or vesktop bug
austere talon
anyway feel free to finish it if u want to
(but only if you want to, it's more a "hey here's this cool idea for you" than it actually needing to be done)
austere talon
i started on it but then kinda lost motivation
and much other stuff to do xd
it would certainly be useful tho and help us catch errors literally immediately
limber skiff
yeah for sure
austere talon
btw i forgot, does reporter even still need login?
if it works perfectly without being logged in, we could run it on prs
limber skiff
let me see
austere talon
if it works perfectly without being logged in, we could run it on prs
cause then they can't do anything bad
worst they could do is get the github runner rate limited from discord or smth
limber skiff
looks like it works and doesnt even produces non verified account errors lmao
(ignore the log I removed the login line)
limber skiff
say what lol
austere talon
that u should remove token from validation
limber skiff
oh lol
frail skyBOT
austere talon
so yeah we can run it on prs then
frail skyBOT
limber skiff
buddy what
austere talon
but we have to make it so that only the touched plugins are enabled
limber skiff
it made it so much slower
austere talon
are u sure
limber skiff
nvm
austere talon
btw you pinning the reporter action ruined my muscle memory
limber skiff
17 hours ago
austere talon
austere talon
might just be that github or discord is busier rn
limber skiff
gonna re run on old commit
limber skiff
this is joking with me
now im gonna re-run latest commit and it's gonna be a turtle just watch
fossil inlet
@keen knoll your plugin constantly errors, please for the love of god fix this
just use the store
dont spam discords api
fossil inlet
i might rewrite the whole thing 
fossil inlet
!Discord
!ShareX
!ShareX
dapper crest
true
rugged spire
i will make another PR for a plugin I already contributed to
charred monolithBOT
Renames ShowTimeoutDuration to ShowTimeoutDetails and adds reasons for timeouts.
Opening as draft for now as I haven't looked at the UI for automod timeouts properly and documented what it looks like here
swift fjord
wrong channel
rugged spire
why was ShowAllRoles removed, if there is no default way to have it expanded (to my knowledge)?
someone definitely was not yapping in the wrong channel about it btw
rugged spire
People are complaining in #๐ฅ-vencord-support-๐ฅ about this now
grizzled halo
I wouldnโt say its complaining, more asking and saying they miss it
keen knoll
<@861631850681729045> your plugin constantly errors, please for the love of god ...
๐
rugged spire
I wouldnโt say its complaining, more asking and saying they miss it
True
limber skiff
the only way <:husk:1026532993923293184>
yeah because of proxy
charred monolithBOT
charred monolithBOT
fossil inlet
Is that just what they use for the settings info box?
limber skiff
Is that just what they use for the settings info box?
it's just hardcoded there
this one also returns the build number as number
swift fjord
it's just hardcoded there
i imagine its just inlined
limber skiff
ye
fossil inlet
lmao the downloads for this package spiked when ntts made his video lol
woeful sable
lmao
austere talon
these are such small packages it doesn't matter
turbid hatch
tbf i dont understand why virtual-merge was needed
they are right in this case
nanoid though is fine to keep
its tiny
isnt it like 130 bytes or something
unless im misunderstanding and you want changes to be reflected back to the original
turbid hatch
nanoid though is fine to keep
though it is very slow compared to crypto.randomUUID, however its not frequently used enough that this would really matter
turbid hatch
i think its a relatively new thing, its *very* fast
crypto.randomUUID 7,619,041 ops/sec
uuid v4 7,436,626 ops/sec
@napi-rs/uuid 4,730,614 ops/sec
uid/secure 4,729,185 ops/sec
@lukeed/uuid 4,015,673 ops/sec
nanoid 3,693,964 ops/sec
oh my god it is FAST
austere talon
girl this won't be called more than twice a minute it doesn't matter ๐ญ
turbid hatch
the only advantage nanoid has is that it has a bigger alphabet but for our purposes this doesnt matter xd
turbid hatch
girl this won't be called more than twice a minute it doesn't matter ๐ญ
nah its just cool to see
having a native uuid library thats faster than the third party ones
also dont mind me, ive gotten really into performance optimisation lately
because thats what im employed to do atm xd
charred monolithBOT
spark cove
yap
median rapids
woeful sable
Wouldn't using Object.assign prevent instance methods from borking here? In my (albeit limited and a bit silly) testing, this does shave size off of the bundle and make it work ever so slightly faster
austere talon
but we also don't want to pollute Discord's objects with fake properties because it might break things
woeful sable
It doesn't look like the thing that this is patching actually uses the user value that's returned for anything else though, so would this still pollute even if it's essentially getting immediately discarded after render?
I thought with virtual merge you'd be reflecting the changes to the user object, which sounds like what you don't want
woeful sable
I thought with virtual merge you'd be reflecting the changes to the `user` objec...
I could be confused here, but
However, changes made on merged will not reflect back to the original Objects. This might be desired, in which case sweet, you don't need this module!
Makes it sound like any time you call virtualMerge, the changes are returned and it mutates the first parameter
austere talon
I could be confused here, but
> However, changes made on merged will not reflect...
const obj1 = { im: "so cool" };
const obj2 = { hamburgers: "are delicious!" };
const merged = virtualMerge(obj1, obj2);
merged.im = "so cute!";
console.log(merged.im); // "so cute!"
console.log(obj1.im); // "so cute!"
Yeah that's the example I was looking at.
Reading through the code for virtual-merge, it looks like it just proxies every property that it can? Isn't reflection in JS horribly slow at times? 
besides that, again why would a link between this new user object and discord's user object need to exist if it basically gets immediate discarded after render? fakeUserProfiles should be overwriting keys that already exist, instead of making new ones
sleek inlet
but we also don't want to pollute Discord's objects with fake properties because...
isn't it just setting properties that would already be there?
austere talon
you're not understanding but im too lazy to explain
the way it is is good, just leave it unchanged
spark cove
also virtual-merge is actually tiny but wanting to clean up bundle size is fair
u should be looking at the esbuild analytics thing tho
esbuild has a visualizer for this
i think my shiki plugin takes up like 30% of vencord lol
woeful sable
yeah im aware, it just seemed like an easy cleanup, and for keeping functionality it literally was a one line change
woeful sable
i think my shiki plugin takes up like 30% of vencord lol
Yeah I saw that shikicodeblocks was huge lmao
woeful sable
Also another thing I mentioned in the programmer channel is that vencord contributor icon fetching in the userscript distribution is broken because of CSP
there's two options basically
- embed the image blob into the vencord bundle for userscripts
- use GM.xmlHttpRequest
2 is probably better, but im not 100% sure that gm can handle non sync xhr
spark cove
what about the secret 3rd option
where we maintain a webrtc http proxy
bypass all CSP
spark cove
i might actually genuinely do this for my vencord fork
also yes webrtc has literally 0 cors or csp or anything at all
woeful sable
where we maintain a webrtc http proxy
Boy do I have the semi convoluted not very well suited for this solution for you 
spark cove
theres a csp rule for it being pushed by w3c but it really looks like chrome doesnt wanna add it
woeful sable
Does the websocket ctor have cors also? I've never checked
spark cove
yea i found this while researching how long i'll be able to use WebRTC in discord activities
woeful sable
But I've also never encountered cors issues with websockets
spark cove
this makes me think pretty much forever unless discord adds it in their electron fork or something
or chrome team has change of heart
spark cove
Does the websocket ctor have cors also? I've never checked
does this mean constructor?
austere talon
Also another thing I mentioned in the programmer channel is that vencord contrib...
it doesnt matter much
badges are all broken
woeful sable
I mean if they haven't implemented it in 8 years, what's the chance they're gonna implement it any time soon
austere talon
no way to fix it without awful workarounds
people should just not use the userscript
woeful sable
no way to fix it without awful workarounds
gm.xmlhttprequest and blobbing the response?
That doesn't seem super awful to me
sleek inlet
Does the websocket ctor have cors also? I've never checked
no
spark cove
does that entail making a fetch-ish util that uses a buildtime constant for impl
spark cove
lol what the hell is this https://github.com/MercuryWorkshop/wisp-protocol
austere talon
does that entail making a fetch-ish util that uses a buildtime constant for impl
we alr do this
userscript build "polyfills" window.fetch
with an impl based on GM_XMLHttpRequest that bypasses csp
anyway there's little reason to do it for badges
spark cove
does that work with manifest v3 userscripts
actually of course it does theres no csp in background scripts
austere talon
speaking of MV3
we should migrate the firefox ext to mv3
it supports it since 128
spark cove
thank god we arent gonna support extensions in our fork
woeful sable
the extension build isn't super practical from what ive seen
but the userscript build is kinda cool
austere talon
wdym not super practical
woeful sable
it's mostly what I use for testing since it's the easiest to just load into the browser for me
austere talon
oh
woeful sable
wdym not super practical
ive seen very few people actually use it
austere talon
i mean...
spark cove
so like not super common?
austere talon
extension is the main build
spark cove
oh u mean ok
austere talon
only benefit of userscript is more frequent updates
woeful sable
fair
are there any current outstanding issues with vencord or vesktop that nobody has fixed yet
i want to contribute and it's easier to ask if there are any big issues right now
spark cove
yes
idk what vee thinks is most pressing but imo
i think its that we need testing for the new updater system
i gave up on it but if someone else helped push along https://github.com/Vendicated/Vencord/pull/2707 that'd be cool
cus i'd still like to add plugin HMR
woeful sable
I can test out building it on linux but i assume that's where pretty much everyone is devving on lol
spark cove
yea we need windows testing
there were some issues another vencord dev ran into
i'd go fetch message links for u but ur not on windows so it prob doesnt matter lol
woeful sable
yeah I'm not even 100% if my windows partition works anymore
spark cove
real, same happened with my arch partition
austere talon
anyway i'm unsure if this is even a good idea
we don't want normal users using this
people should just edit the patcher.js file to change the repo
if you have an api like this in the bundle everyone uses, there's a 100% chance someone will eventually find this and then advise non techy people to do it to change to dev branch for faster fixes
and then we get people asking for support with the unstable branch which sometimes has broken code and frequently gets force pushed which will break the updater
woeful sable
yeah, you could give a warning or something like "we will not give support if you use this" maybe
brazen bone
yeah, you could give a warning or something like "we will not give support if yo...
You're overestimating reading comprehension
woeful sable
yeah excluding it is probably the best idea
brazen bone
See also: "why did ThisWillBreakYourDiscord plugin break my discord ๐คช"
woeful sable
See also: "why did ThisWillBreakYourDiscord plugin break my discord ๐คช"
Did someone actually ask that in support
brazen bone
No idea, but probably
woeful sable
Someone needs to invent a captcha but instead of testing if you're a robot it tests if you're an idiot
brazen bone
Isn't that just fn is_moron(&self) -> bool { 
}
brazen bone
Fixed
spark cove
we don't want normal users using this
thats why theres no UI
austere talon
people will still use it ๐ญ
spark cove
idk any way that makes it easier on us devs that normal people wouldnt be able to do if given instructions
but yea u cant change repo
austere talon
people should just edit the `patcher.js` file to change the repo
this
spark cove
real if u wanted to yea
not really needed cus u can just use ur own repo it'll be the same if its a fork
opaque silo
we don't want normal users using this
then why have the vesktop optiosn
spark cove
theres no 'vesktop option' in my PR
austere talon
then why have the vesktop optiosn
because otherwise there's no way
opaque silo
theres no 'vesktop option' in my PR
nono vesktop has an option to change the vencord source
opaque silo
because otherwise there's no way
but like why make it a user accessible ui instead of a build option
spark cove
vee just prob wanted something easy for them
austere talon
because you dont need to build vesktop from source to change vencord
spark cove
oh yea theres no patcher fuckery
opaque silo
because you dont need to build vesktop from source to change vencord
you just said u dont want normal users to change vencord repo tho ๐ญ
spark cove
i mean if this gets merged you won't need that ui anymore i think
cus u just replace ur build with the devbuild from ur fork, and switch to branch-thing target to test updater
@austere talon do u want me to add a package.json script for downloading build artifacts to ur install folder
actually no thats unnecessary u can just build them urself and copy
actually i might need to fix build scripts before u merge
i know the git updater doesnt actually check what repo ur on, it just assumes ur on origin, so if build script does the same i need to change
spark pivot
Thatโs probably a discord bug ๐ญ
โWhy does this bug happen when I do something like 10 times really fastโ
rugged spire
Doubt it
erm
maybe
wtf is that
something has been oversimplified here for sure
oh i see now
i totally see now
this is bypassing React.createElement
that's almost certainly part of the reason why it breaks
whenever I see that there's sometimes unusual behaviour
limber skiff
no it's not
it's jsx, vencord turns it into a createElement
all vencord components work like that lol
rugged spire
does that really Just Work
rugged spire
wouldnt the hook be 1 level above where you'd ideally want it, though that shouldn't matter too much
opaque silo
ive only ever seen the tooltip get stuck on the game activity toggle ยฏ_(ใ)_/ยฏ
rugged spire
i wonder if it has anything to do with the lack of a key there
maybe the function breaks the auto generation of keys
idk though
hmm theres an ErrorBoundary wrapper though
rugged spire
this is the only place in vencord I've ever seen tooltips break like that
where it just Doesnt Disappear
for some reason
fossil inlet
does this even matter
rugged spire
What the fuck?
rugged spire
does this even matter
maybe, just not as much as I might think it does
rugged spire
What the fuck?
this needs to be refactored (in some way)
rugged spire
this needs to be refactored (in some way)
okay this is definitely its own thing its just super confusing looking
limber skiff
What the fuck?
what's wrong with that lol
rugged spire
you'd think it's the stock Button component when it isn't
limber skiff
it's the one used for the buttons in the side of it
does it happen with the stock buttons
I know it happens a lot when I switch to another windows moving my mouse down while passing above the activity button
rugged spire
stock buttons dont implement this tooltiptext thing
limber skiff
something has been oversimplified here for sure
it's right there
brazen bone
Weird that minifier picked different minifications in different cases
brazen bone
That looks like completely normal minified code, I don't know what you're confused about
limber skiff
yeah
ngl minified code actually made me start to use == null and != null almost all the time
brazen bone
Instead of what?
brazen bone
I'd just do h?.()
limber skiff
!= null only targets undefined and null
brazen bone
Considering the amount of code I've seen that does a != null && a != undefined, I don't think == null targets undefined
brazen bone
Right
limber skiff
it's why the minifier uses != null there
either the original code is d?.()
or if (d != null) d()
because there is no way it would transform if (d) d()
to that
brazen bone
Yeah that'd be d&&d()
limber skiff
yeah
austere talon
definitely ?.
median rapids
definitely !
spark cove
definitely !?.
@austere talon
where all does the build process use/embed the repo
oh yea the ~git-remote plugin my bad
fallen vale
hmm... if only they thought to put the reasoning in the commit message....
glass jasper
hmm... if only they thought to put the reasoning in the commit message....
Because pressing a single button is somehow too much for people
#๐ฅ-vencord-support-๐ฅ message
charred monolithBOT
charred monolithBOT
charred monolithBOT
desert cosmos
pretty sure they meant "why? add this back"
charred monolithBOT
verbal pumice
horror
glass jasper
jumpscare
fallen vale
laydowncalm
charred monolithBOT
Slightly changed the code, here's the result (for automod)
Also the icon is orange when automod does timeouts
austere talon
wtf are you trying to do
rugged spire
discord api is cursed and returns a string of one of these values in audit log responses
i will implement later
austere talon
wait it's actually just css
fallen vale
yea lmao
i just copy/pasted what they put in the plugin and told em to put it in css
gritty canyon
users yearn for a css snippet/theme store
fallen vale
if i make a plugin with a collection of css snippets, would that get merged?
gritty canyon
if i make a plugin with a collection of css snippets, would that get merged?
why would it
thats something called a "theme"
fallen vale
themes dont have individual toggles for each of the things they do
gritty canyon
you can release a series of imports that enable/disable specific snippets
fallen vale
why would it
because its been mentioned before
gritty canyon
?
long stream
if i make a plugin with a collection of css snippets, would that get merged?
i thought there was a usercss pr for that
fossil inlet
if i make a plugin with a collection of css snippets, would that get merged?
we had a thing for that, its called #๐จ-css-snippets
long stream
i thought there was a usercss pr for that
@turbid hatch iirc you were working on it?
turbid hatch
yes but it hasnt been worked on
rugged spire
rate the new UI
I NEED TO TEST
fossil inlet
I NEED TO TEST
none of the buttons work yet, but the ui does
glass jasper
rate the new UI
this is the second time Iโve been sitting near my parents watching a video that you sent and it says the n-word
other then that Nice
also steam jumpscare
glass jasper
wtf
nimble plaza
FREE SMILEY DEALER IS BACK
fallen vale
try sending a ๐ญ
glass jasper
๐ญ
fossil inlet
๐ญ
gritty canyon
not sure if thats a good match, tried my best lmao
fuck forgot to lint before push
austere talon
honestly
just change the default expanded state
so it's expanded by default but u can still minimise it again
it opens as if you clicked the +
gritty canyon
oh wait you can minimise it again? ๐ญ
i did it like this cuz it was easier and i didnt know it would get rid of minimising
ill change it then
fossil inlet
oh wait you can minimise it again? ๐ญ
the collpase roles button in question
gritty canyon
there we go
now just expands by default
also fixed checks
๐ญ
niche feature imo but if so many people request it
shrug
austere talon
is it actually that many people
gritty canyon
well yea
austere talon
rmber vencord has hundreds of thousands of users
gritty canyon
more than with any other request
gritty canyon
20 people crying in support isn't a lot
technically yea but a lot of people also just dont bother requesting it or something but i mean it doesnt really hurt including it now that i made it right? :3
austere talon
i might need to cut my leg off to merge it..
sterile oak
20 people crying in support isn't a lot
i am making that 21
gritty canyon
how would we do that
gritty canyon
alright will push then
limber skiff
the plugin also needs a README
gritty canyon
right
austere talon
girl what is that font
austere talon
look at the method definition I don't remember
its right there xd
austere talon
its not even monospaced
I CAN TELL
gritty canyon
I CAN TELL
another fun fact it looks even worse in the terminal because kerning is disabled there
gritty canyon
there we go
glass jasper
10/10 id use it
gritty canyon
why ๐ญ i think we do not really need to add options for such a simple plugin
glass jasper
why ๐ญ i think we do not really need to add options for such a simple plugin
wouldnt hiding the button just bring back the plug-in that this is meant to replace?
gritty canyon
yeah i was about to say that
gritty canyon
wouldnt hiding the button just bring back the plug-in that this is meant to repl...
what
gritty canyon
ah
well shrug
if you want it to be like the old plugin, as @sadan4 said you can use css
glass jasper
if you want it to be like the old plugin, as @sadan4 said you can use css
exactly
rugged spire
every time someone says "use css" a little bit of #๐ฅ-vencord-support-๐ฅ enters my soul
glass jasper
every time someone says "use css" a little bit of <#1026515880080842772> enters ...
I would agree with you, if it wasnโt to hide a single button at that point yes use CSS
glass jasper
me when i dont use
#1257070841372610581 message
also, you could just be like this person and ask in support like a normal person
#๐ฅ-vencord-support-๐ฅ message
fossil inlet
whenever i import from plugins in my file, i get this error
what am i doing wrong
limber skiff
recursive imports
fossil inlet
is there a simple way to fix?
limber skiff
use Vencord.Plugins instead
fossil inlet
thanks
wary relic
green 
glass jasper
green <:PepeHappy:472000779604066305>
you donโt have your server role on this new account?
wary relic
you donโt have your server role on this new account?
was never given them upon request
๐
glass jasper
Can you stop advertising the forks?
charred monolithBOT
glass jasper
thank you nyx
No matter how many times we tell people not to go talking about the forks in the official repository, they do it anyways
fossil inlet
@limber skiff would it be possible to still set $$vencordOriginal even if a patch errors?
limber skiff
why
fossil inlet
to diff patches that error
limber skiff
you mean the patched source?
fossil inlet
yea
limber skiff
hmmm
unsure
a successful patch after the error would overwrite the errored source though
since it would use the old code that doesnt error + the patch that succeeded
fossil inlet
a successful patch after the error would overwrite the errored source though
yea, i think ill just manually apply the patch for diffing an error
limber skiff
we can maybe create a set/array with the errored sources
fossil inlet
all i need to do now is make the jump button
limber skiff
they broke permissions viewer again nice
fossil inlet
@rugged spire you love
limber skiff
why lmao
glass jasper
idk because itโs different for my own
jagged reef
if (typeof Object.entries(members).map(member=>member) === โstringโ) return true;```
brazen bone
Smart quotes found ๐ซ
limber skiff
what is that
jagged reef
```go
if (typeof Object.entries(members).map(member=>member) === โstringโ) retur...
my favourite go snippet
limber skiff
charred monolithBOT
I am aware that theres the option to hide it, but the label still remains there. What this does it completely hiding anything related to that feature.
charred monolithBOT
nimble plaza
mods, lobotomise this user
umbral hillBOT
mods, lobotomise this user
๐ง ๐จ
opaque silo
mods, lobotomize me
gritty canyon
vee, close his pr
charred monolithBOT
charred monolithBOT
Using the GameToggleActivity button code I was able to add a similar feature to CustomRPC, where before this, you would need to enter the plugins page and disable it from there, now, all you need to do is click on the "Disable CustomRPC" button added to the account panel.
charred monolithBOT
This change is way to niche, no one really needs a shortcut to enable/disable CustomRPC, additionally this clutters up the profile space and even breaks without a theme:
charred monolithBOT
glass jasper
prolly this
charred monolithBOT
rugged spire
<@259558259491340288> you love
can you unlearn the massive margins thing im begging you you're not a megacorp
dusk blaze
can you unlearn the massive margins thing im begging you you're not a megacorp
i will margin you
fossil inlet
if you dont like the UI, make it yourself
rugged spire
?remindme 1h try dev companion on my laptop
shut vineBOT
Alright @rugged spire, in 1 hour: try dev companion on my laptop
shut vineBOT
@rugged spire, <t:1724876884:R>: try dev companion on my laptop
wary relic
i think its time
charred monolithBOT
I get it, but moments like this don't look good
- Instead of broadcasting in the profile banner, I'd leave the voice channel icon, just with a different tooltip
fossil inlet
not console janitor
Console janitor mid anyway, my version better
rugged spire
Console janitor mid anyway, my version better
What changes does your version have
fossil inlet
What changes does your version have
limber skiff
why is the patches broken on stable and not canary
normally it's the other way around
rugged spire
pr review jumpscare
limber skiff
rugged spire
limber skiff
in fact i'm gonna include the other one too
it's not used in replacement but in the match
rugged spire
you have a typo in your suggestion
limber skiff
where?
limber skiff
nono
rugged spire
oh?
limber skiff
reference to second capturing group
limber skiff
ill explain in a bit
limber skiff
they make the match super unreadable
can you figure the magic
here's the hint
(roles:\i(?=.+?(\i)\(!0\)[,;]\i\({action:"EXPAND_ROLES"}\))
fossil inlet
you have a typo in your suggestion
I LOVE REGEX BACKREFERENCES
limber skiff
does the mobile app have something similar to user voice show?
limber skiff
limber skiff
did you enable this
gritty canyon
yea i did
i was concerned specifically cuz it didnt show as working on web for me
but its whatever now ๐ญ
thanks!!
limber skiff
as scary as that regex seems like it actually should not break easily
in fact super reaction tweaks has on similar
same concept
gritty canyon
There we go, checked through the reviews again and applied the changes
gritty canyon
in fact super reaction tweaks has on similar
ah, alright!
still getting into patches :3
limber skiff
no worries it was good
it's just that modifying useState sometimes can be very hard to be specific and you are forced to use complicated techniques if you want to be sure of what it's patching
glass jasper
rip ConsoleJanitor
limber skiff
notosans error is gone
fossil inlet
chain breaking image
still wasp
limber skiff
AlwaysExpandRoles is fire
limber skiff
pushing to main
gritty canyon
AlwaysExpandRoles is fire
:3
limber skiff
what's the worst that can happen, right?
fossil inlet
what's the worst that can happen, *right?*
while you werent looking, i exploded a patch
glass jasper
Canโt wait for the announcement thatโs never gonna happen in #plugin-news about this new plugin
rugged spire
wtf am i cooking?
fossil inlet
@rugged spire you will make setting pop out to external window
like you can do with vc's
rugged spire
fossil inlet
what
limber skiff
wtf am i cooking?
that's pretty cool ngl
rugged spire
toolbar is where elements like these are defined
hot take
GuildSettingsAuditLogStore should be rewritten by Discord
its such a bad mistake
fossil inlet
guhhh i do not want to write AST parsing code at 3 am
rugged spire
it is a Store being treated like a Cache for the current audit log view
fossil inlet
!remind 8pm write PluginDefCodeLensProvider.ts
shut vineBOT
Alright @fossil inlet, in 16 hours, 43 minutes and 42 seconds: write PluginDefCodeLensProvider.ts
limber skiff
honestly I'm not sure if that's weird or not
maybe it's good for use with useStateFromStores
I wonder how many people peek in this channel daily
in powercord ages when I didn't do dev I used to peek the development channel everyday to see if there was interesting stuff happening
any new messages were a great time for me
gritty canyon
I wonder how many people peek in this channel daily
there are probably a couple of people
and then those who'd love to participate here but dont know how to and are too scared to ask
fossil inlet
ive lurked in random channels from time to time
limber skiff
I just now realized the amount of reactions in this message
fossil inlet
a few
gritty canyon
is that channel dead..
glass jasper
is that channel dead..
Most announcement channels are
limber skiff
is that channel dead..
it's not dead, just there hasn't been any new plugins merged
fossil inlet
it's not dead, just there hasn't been any new plugins merged
Hasnโt there been a release since that last message
limber skiff
releases are just for the browser extension
gritty canyon
Hasnโt there been a release since that last message
yea about 20 mins ago :3
oh
you mean version release
limber skiff
they are not the mark for new updates
gritty canyon
im stupid
limber skiff
main commits are
actually this should be announced
and AlwaysExpandRoles
if vee doesn't do it soon I will do
charred monolithBOT
Here's another example. I am seeking feedback on this now
Could this be improved?
rugged spire
it seems too cluttered
it is
gritty canyon
so imo its fine
limber skiff
honestly the issue is not that it's a popout
because they can look good
maybe it just needs a better design instead of being all text
rugged spire
hm maybe
rugged spire
because they can look good
ironically this popout has horrible UX
limber skiff
I like it
rugged spire
this is how it renders 8 people (that's 2 voice, 3 streaming, 3 playing games, 2 in activity)
opaque silo
that reminded me of this so pretty please merge Vencord | PR #2712
shut vineBOT
Alright @limber skiff, in 10 hours: merge that
jagged reef
it seems too cluttered
Yeah, itโd probably look better if they make it wider than like 2rem
shut vineBOT
@limber skiff, <t:1724931090:R>: merge that
fallen vale
will they though
limber skiff
when I actually wake up
fallen vale
what tz are you in
fossil inlet
new feature!
fallen vale
new feature!
if everything youre doing ends up being usable, ill probably switch over to vscode
fossil inlet
if everything youre doing ends up being usable, ill probably switch over to vsco...
what are you using now?
fossil inlet
I LOVE JETBRAINS I LOVE JETBRAINS 
fallen vale
i used to use pycharm but i dont use python enough now to warrant
fossil inlet
does npp have lsp support?
fallen vale
(and rider i switched over to visual studio)
fallen vale
use notepad++
lemme just fire up the apple notes app for my code rq
fallen vale
I LOVE JETBRAINS I LOVE JETBRAINS <:crazy_fucker:922650012419256331>
what would you rather i use?
fossil inlet
something that you dont have to pay for
fallen vale
i dont pay for jetbrains lol
fossil inlet
its paid tho
shut vineBOT
@fossil inlet, <t:1724915778:R>: write PluginDefCodeLensProvider.ts
scenic brook
webstorm
I'm (slowly) working on an intellij port of the extension, I assume it'd work on webstorm 
Work do be getting in the way though
fossil inlet
I'm (slowly) working on an intellij port of the extension, I assume it'd work on...
im curious how far you've gotten tbh
seems hard to completely port it
esp the webview
and the Typescript AST parsing
scenic brook
Pretty much just the lenses for testing patches/viewing modules and diffs
I had to set it down for a bit because I was spending too much time fucking around with it and not doing my actual job lol
heady rapids
yess
fallen vale
I had to set it down for a bit because I was spending too much time fucking arou...
i might look into how extensions are made and try to contribute, is the code for it on github?
austere talon
not a problem