#👾-core-development
charred monolithBOT
Discord Account
No response
What happens when the bug or crash occurs?
when clicking a persons profile whom has lots of roles, the profile just gets stuck, you're not able to scroll up or down, leaving to have to use the right click menu if you want to try and add them as a friend and such.
What is the expected behaviour?
I expect ShowAllRoles to handle this kind of probl...
shell shuttle
https://i.dolfi.es/GFJHC2h8uR.png?key=ilMPgeKjMUF8Fd
aw hell naw
Link isn't real
it's <a>
jagged reef
https://i.dolfi.es/GFJHC2h8uR.png?key=ilMPgeKjMUF8Fd
Isn't that not closed anyways?
Shouldn't it be <Lionk href="" />
median rapids
look 2 lines after
crude hearth
Link isn't real
It should be on react
For dynamic sites I think Link is being used, tho it might not make sense in this case
crude hearth
Tbh not a terrible idea
sterile oak
Tbh not a terrible idea
then host it
austere talon
the pinned post in question
sterile oak
she said to open a modmail to get access
This means that your repository needs to have its index.ts file in the root. One plugin per repo! why do I feel targeted 
austere talon
how was it supposed to have worked before
it only checks userplugins/plugin/index.ts
not userplugins/nico/plugins/index.ts
that's fucking awful
vencord could support nested folders so you can clone entire repos
but also people should not have to install all your plugins just to use one
vencord might update userplugins for you
the entire reason the new rule is there so that all userplugins are git repos you can pull
instead of downloading files manually
in the future i might make vencord ignore userplugins that are not git repositories
to enforce proper installation that allows updating them
with some way to still load ur own plugins without a git repo
verbal pumice
in the future i might make vencord ignore userplugins that are not git repositor...
HORROR
oh i should probably read first
fallen vale
in the future i might make vencord ignore userplugins that are not git repositor...
simple, add another plugin loading folder thirdpartyplugins/hj
verbal pumice
cd userplugins/coolplugin
git init
Done
fair
but then vscode gets all pissed
i think
austere talon
nah
i wanted to use submodules for userplugins
but submodules don't work in gitignored folders
turbid hatch
@austere talon i just thought
how do we do localisation for userplugins
or is that a "we're not doing it"
cuz atm everything is in one folder at the root
plugins could probably have a locale folder now that i think about it
i think i can make i18n ally support that
austere talon
we don't
turbid hatch
so only first parties get localisation?
austere talon
why in the world would anyone localise their tp plugin
not happening lmao
powercord allowed plugins to localise and there were only like 2 devs using it and they just did one locale (their native language)
charred monolithBOT
turbid hatch
that was messy :<
charred monolithBOT
firstMessage
This plugin allow see a first message timestamp was sended or recived to user by chat id
dusk blaze
why
rugged spire
git branches should be fine IMO but I have asked about it
i will add you to ticket
horror
rugged spire
is there a fucking permission required to add to ticket
dusk blaze
is there a fucking permission required to add to ticket
per thread i think
desert cosmos
me when snowflakeutils
rugged spire
me thinks the idea of plugin vendors are still a good idea now
fallen vale
sended is crazy
rugged spire
dom manipulation is 
fallen vale
why point them to the rules then close it
dusk blaze
they can remake pr when they don't use deranged practices imo
rugged spire
you can ping people in modmail to add them
You will hop on MessageLogger
and see
I tried
and discord was like nuh uh
austere talon
actually only mods can yeah
turbid hatch
why point them to the rules then close it
because the plugin requires a full rewrite anyway so it's better to resubmit from scratch where you can get fresh reviews
- it's clear they didn't read the rules in the first place
dusk blaze
they opened 3 prs
3 rule breaking
rugged spire
nvm
dusk blaze
yop
so sad
rugged spire
the answer to "Should I be using DOM Manipulation in my Vencord plugin?" is
Short answer: No
Long answer: 99% of cases, no, however Vencord's core does it for things like CSS. If you MUST, do it within React with a ref for very very niche cases
i fixed it
charred monolithBOT
glass jasper
bro really just reuploaded some else’s pr for them
spice python
love how they pretend to not know why it was closed and also know why it was closed
glass jasper
how much we wanna bet they are going to reopen that pr?
fallen vale
Popular services like [...] GitHub are fine
??
genuinely confused
rugged spire
aka: come back when you have a reputation
spice python
bro really just reuploaded some else’s pr for them
just look at that persons prs https://github.com/Vendicated/Vencord/pulls?q=is%3Apr+author%3Ahappyendermangit+is%3Aclosed
austere talon
> Popular services like [...] GitHub are fine
??
genuinely confused
this is different because they load urls from json and fetch them in the plugin
they could put arbitrary urls in that json
rugged spire
this is different because they load urls from json and fetch them in the plugin
oh what the fuck
do you mean
arbitrary code or just "what if secretly ip logger"
probably latter
austere talon
the latter
glass jasper
just look at that persons prs https://github.com/Vendicated/Vencord/pulls?q=is%3...
it’s exactly the same, he just reuploaded a pr for someone
austere talon
unless they find a vulnerability in chromes image parser
rugged spire
dusk blaze
isn't decor cooking profile effects lmao
glass jasper
just look at that persons prs https://github.com/Vendicated/Vencord/pulls?q=is%3...
i just realized what you mean,
rugged spire
isn't decor cooking profile effects lmao
i hope not
the one thing I hate about decor is that there's no "unlisted" privacy option for you to steal other people's decorations
dusk blaze
blackbox is usrbg
dusk blaze
i just realized what you mean,
no offense meant
but this user just seems to make low effort / rule breaking contributions in an attempt to get a contributor badge
or do they already have
rugged spire
they already have
glass jasper
i just realized what you mean,
also “serstars” is a co-dev on almost all them makes me suspicious on the fact that they prolly didn’t actually write any of them themselves or that’s their alt-account or somethin
dusk blaze
idk likely both collaborate on plugins
fallen vale
i just realized what you mean,
lol
rugged spire
they already have
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/77492061f57250717f0140d81ae62a46afa71...
constants.ts: Lines 445-448
HappyEnderman: {
name: "Happy enderman",
id: 1083437693347827764n
},
also
@austere talon is putting links to your donation site allowed in plugin settings, if this plugin requires a custom server that you operate yourself (not planning to do that just wondering)
rugged spire
also
<@343383572805058560> is putting links to your donation site allowed in plu...
Decor does it afaik
dusk blaze
reviuwerdb also does
rugged spire
huh it doesnt
dusk blaze
plugin settings
fallen vale
**constants.ts:** Lines 445-448
```ts
HappyEnderman: {
name: "Happy enderman...
all their PRs seem to be just to get the contrib badge
rugged spire
all their PRs seem to be just to get the contrib badge
yet they already have 
austere talon
also
<@343383572805058560> is putting links to your donation site allowed in plu...
sure
but unless you provide some perks i wouldn't expect anyone to donate
glass jasper
idk likely both collaborate on plugins
but makes me think that one or the other is doing most of the actual work (prolly not the ender dude) and their just slapping their name on it
dusk blaze
but makes me think that one or the other is doing most of the actual work *(prol...
guh idk
tbh we shouldn't speculate on something we don't know and probably won't know
spice python
yet they already have <:hollow:1231282060258312415>
they got it after one of their prs got merged 
actually it was someone elses pr
glass jasper
actually it was someone elses pr
it was some else because that one has better formatting then their pr, just look at the their version
spice python
why were they even added to authors
they state it was an edit, however I dont see anything in common
glass jasper
for that badge i’m guessing
glass jasper
the other person added them to authors of their pr
prolly a friend of theirs that just them slap their name on it, i would guess then
spice python
it says it's an edit of their pr, but I dont see anything in common really
glass jasper
honestly i’m just going to leave it on what Cynosphere said
spice python
petition to block people who repeatedly submit prs that are obviously just to get the contributor badge (also pretty sure I saw this when that pr was opened)
one sec let me try to find that
rugged spire
vencord has the ability to keep someone as a dev but hide the badge 
glass jasper
https://discord.com/channels/1015060230222131221/1015063227299811479/12306264759...
So just validation for what the great the Cyno said
spice python
yes
fallen vale
why did this get closed :( [#2362](<https://github.com/Vendicated/Vencord/pull/2...
💀
at least they admit it
dusk blaze
fallen vale
why did this get closed :( [#2362](<https://github.com/Vendicated/Vencord/pull/2...
nor are they granted automatically
yes, they are-
spice python
> nor are they granted automatically
yes, they are-
they need to add themself to the devs constant
glass jasper
spice python
I take automatically as automatically giving it to them once their pr gets merged, even if they didnt add themself to the devs constant in the pr
fallen vale
photoshop pro over here
spice python
We love Firefox Dev Edition
me when no updates
fallen vale
https://tenor.com/view/average-firefox-enjoyer-gif-26930283
fr
austere talon
afaik firefox source code has vendor too
linux has vendor
glass jasper
me when no updates
that’s why dev edition because you get the update a few month before other people and you have more control over it what you can with it
glass jasper
literally comes preinstalled with vencord
VendorOS when vee?
austere talon
spice python
isnt android just linux
austere talon
android is based on linux yes
glass jasper
MiXplorer reference
rugged spire
i want to add vendor to vencord
spice python
wth is /vendor/libdrm.so
glass jasper
wth is /vendor/libdrm.so
token logger stuff don’t worry about it /j
spice python
is any of this malware
dusk blaze
photoshop pro over here
pixel screenshot editor my beloved
granite sky
they could put arbitrary urls in that json
What if they do a check inside of plugin smth like: "image source should always be from github.com"
hexed star
it says it's an edit of their pr, but I dont see anything in common really
it really was just an edit of his pr
fallen vale
it really was just an edit of his pr
lol
hexed star
btw at that time I didn't know there's even badge for it, I thought u'll just have ur avatar in plugin settings 
rugged spire
vencord experience
rugged spire
yes I know titlegore much
still wasp
Oh i've wanted this for a while
@rugged spire i think it's possible to do a similar thing with the roles page, you can view them and their permissions regardless of permission
I might investigate it
rugged spire
<@259558259491340288> i think it's possible to do a similar thing with the roles...
Pretty sure someone dropped some webpack override code in #🗳-plugin-requests to do this
still wasp
Oh word
rugged spire
fun fact
I was gonna originally make the redirect to channel page button always shown
because I (naively) assumed the redirect icon was its own button to do that
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/roleColorEverywhere/...
index.tsx: Lines 59-68
{
find: 'location:"UserMention',
replacement: [
{
match: /user:(\i),channel:(\i).{0,400}?"@"\.concat\(.+?\)/,
replace: "$&,color:$self.getUserColor($1?.id,{channelId:$2?.id})"
}
],
predicate: () => settings.store.chatMentions,
},
I can't stop thinking about correcting those. WHY THEY ARE ARRAYS IN THE FIRST PLACE
rugged spire
I can't stop thinking about correcting those. WHY THEY ARE ARRAYS IN THE FIRST P...
Multiple replacements in the same module
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/dev/src/plugins/index.ts#L63-L65
index.ts: Lines 63-65
if (!Array.isArray(patch.replacement)) {
patch.replacement = [patch.replacement];
}
you can always just uh 
charred monolithBOT
verbal pumice
inb4 added themselves to devs
sterile oak
**index.ts:** Lines 63-65
```ts
if (!Array.isArray(patch.replacement)) {
pat...
my life is- yeah I knew about this already or I guessed
verbal pumice
inb4 added themselves to devs
ok not the case
rugged spire
insane™️
fallen vale
the comedy tho
glass jasper
can we just block him already <:uwaaaaa:1236383862637203486>
block them and hide the contri badge on their profile
long stream
the comedy tho
hes more annoying than funny tbh
rugged spire
the comedy tho
this is a funny take considering you are terminally obsessed with #🗳-plugin-requests to the point of being annoying to maintainers
rancid sigil
wild
fallen vale
this is a funny take considering you are terminally obsessed with <#120695328853...
i mean, they got mad at me for pointing out the checklist that should be auto-closing the issues anyways
fallen vale
how come?/genq
rugged spire
how come?/genq
because they'll somehow understand it was that and come back 2 minutes later with the same bullshit
if you don't lock them they can complain there
fallen vale
fair
still wasp
because they'll _somehow_ understand it was that and come back 2 minutes later w...
Don't they get banned from posting requests
fossil inlet
Don't they get banned from posting requests
They can be but not automatically
glass jasper
They can be but not automatically
read from here down
#🗳-plugin-requests message
rugged spire
what did they do
2 line patch that effectively does nothing
fossil inlet
read from here down
https://discord.com/channels/1015060230222131221/12069532885...
Yeah, I read that. I just thought they were talking about issues that had the funny check box checked
austere talon
discord update detector
grave mangoBOT
VencordTab.tsx: Line 96
note: "You need a theme that supports transparency or this will do nothing. WILL STOP THE WINDOW FROM BEING RESIZABLE!! Requires a full restart"
charred monolithBOT
Closes https://github.com/Vendicated/Vencord/issues/2645
Discord seems to have changed embed fields. I compared them with embeds from bots and took fields from there, and now it works fine
Before fix:
After fix:
verbal pumice
given it took so long for someone to bother fixing this i wonder if we should just remove the plugin tbh
still wasp
given it took so long for someone to bother fixing this i wonder if we should ju...
I seriously doubt anyone even uses it
granite sky
At least 2 people
fallen vale
I seriously doubt anyone even uses it
dusk blaze
basic form of hiding activity
fallen vale
basic form of hiding activity
how to do something people wont see
- make a server
- dont invite anyone
- profit
dusk blaze
physical access joined chat
glass jasper
how to deal with that
- remotely turn on the computer
- profit
fallen vale
how the ever living fuck do you remotely turn on and unlock a computer you dont own
glass jasper
exactly they never expect it
fallen vale
💀
glass jasper
anyways, it’s pretty easy to remotely turn on a PC. I do it quite often when I’m a over the road with my computer
fallen vale
anyways, it’s pretty easy to remotely turn on a PC. I do it quite often when I’m...
my computer
emphasis on "my"
and if someone else has access to your computer, you obviously dont care that much about hiding stuff.
glass jasper
> my computer
emphasis on ***"my"***
It’s still the fact that I can turn on and shutdown computer, remotely then after that all you need to do is crack the password and with the person that’s pretty easy
fallen vale
my entire point though is that its your computer
you cant argue against my point by saying "but just ignore that tho"
rugged spire
WHAT DID YOU COOK
austere talon
WHAT DID YOU COOK
what
austere talon
no
desert cosmos
insane
shell shuttle
exactly they never expect it
real
dusk blaze
what is vee cooking 🔥
rugged spire
what the fuck
austere talon
he takes 2.5k lines to do something u can do in 100 lines
well more lines once i add ui and stuff
but still nowhere near 2.5k
rugged spire
true
glass jasper
what is vee cooking 🔥
port of DevilBro’s editusers ig
sterile oak
i love DevilBro
edit users? I tho its useless
fallen vale
but still nowhere near 2.5k
like 100+ are just for dependency ensuring
rugged spire
edit users? I tho its useless
no its highly requested
rugged spire
like 100+ are just for dependency ensuring
austere talon
edit users? I tho its useless
i dont think it is
still wasp
It can have some uses
austere talon
my motivation for making it is @opaque pewter
austere talon
my motivation for making it is <@579731384868798464>
rugged spire
my motivation for making it is <@579731384868798464>
why
fallen vale
why the fuck do you have 75 mutual friends with a single person
still wasp
why the fuck do you have 75 mutual friends with a single person
I DIDN'T EVEN NOTICE THAT
rugged spire
sterile oak
Gory banner i assume
its gory? I tho its beautiful (just me? alright I will shut up)
still wasp
I don't even have 75 friends total 
rugged spire
this my best I can find within my friends I think
fallen vale
i have 91 total friends, my most mutual is like 15 😭
fallen vale
10/10 description
poggers
rugged spire
That is a description indeed.
still wasp
Whom
fallen vale
get that'd loser
opaque pewter
hexed star
long heart
still wasp
Venware my beloved
sharp moss
what did i just see
limber skiff
rm -rf message by github
charred monolithBOT
odd heath
pronoundb still needs to be fixed for new profiles
kindred estuary
yeh I kinda prefered the old too
kindred estuary
I never had issues with the old
sterile oak
combine the two, I am thinking of gray button with text, and the icon aside the text
charred monolithBOT
I don't see much use for that with the new profiles already having a "friend added" icon
fossil inlet
i want to see what they do without hovering
normal buttons are fine as long as there's text
but this is really bad
also it clashes with the buttons on the bottom
fossil inlet
yea, but still, thats four other buttons that just look out of place and i have no idea what they do
yea, i saw that
austere talon
fallen vale
also it clashes with the buttons on the bottom
remove the view log button, and move the notification settings into the settings area
fossil inlet
just give the buttons labels
fallen vale
zt is now duke https://cdn.discordapp.com/attachments/889961998794752050/1257717...
read your dms damn
austere talon
what
fossil inlet
read your dms damn
its 1 dm
austere talon
if you don't like the new quick actions, then suggest an alternative cause the old ones also were not it
fossil inlet
if you don't like the new quick actions, then suggest an alternative cause the o...
the old ones were better
austere talon
maybe like this
sterile oak
maybe like this
yeah exactly
charred monolithBOT
sterile oak
now edit messages
austere talon
i should cherry pick those webpack improvements onto dev
austere talon
happy?
still wasp
That is so good
charred monolithBOT
royal panther
🧌
glass jasper
like be responsive
But now it looks weird because it needs more buttons to level them out
glass jasper
like be responsive
austere talon
But now it looks weird because it needs more buttons to level them out
impossible to fix
why do you think i used icons
glass jasper
impossible to fix
just add another button
still wasp
just add another button
The famous do nothing button
glass jasper
The famous do nothing button
Actually yes that would be funny
just a button that does nothing at all
dapper crest
like be responsive
Align-items: center
Justify-content: center
Flex-wrap: wrap
limber skiff
i should cherry pick those webpack improvements onto dev
which you mean
glass jasper
Align-items: center
Justify-content: center
Flex-wrap: wrap
that would work
makes it look better
austere talon
Align-items: center
Justify-content: center
Flex-wrap: wrap
then u don't have evenly sized pills
looks awesome
dapper crest
then u don't have evenly sized pills
True
glass jasper
then u don't have evenly sized pills
that’s a small price to pay
still would make it look better tho
dapper crest
then u don't have evenly sized pills
I think it would still look better that way
glass jasper
still would make it look better tho
smaller pills don’t matter just needs to look even
austere talon
feel free to send a pull request 😉
charred monolithBOT
dapper crest
feel free to send a pull request 😉
You will ignore for 3 years
austere talon
no
dapper crest
OK then I will
dapper crest
Can edit client theme be added to quick actions?
dapper crest
Ah
glass jasper
Can edit client theme be added to quick actions?
how about a donation button or something
nvm
it’s above
desert cosmos
in love
desert cosmos
happy?
stupid question but would it be possible to make that accessible to plugins similar to toolboxActions?
would be fun
dapper crest
am I dumb, there is no error in logs
austere talon
charred monolithBOT
dapper crest
LOOKS SO MUCH BETTER
.vc-settings-quickActions-card {
display: flex;
flex-wrap: wrap;
}
glass jasper
i like that but the edit clienttheme button need to be in the middle
glass jasper
LOOKS SO MUCH BETTER
```css
.vc-settings-quickActions-card {
display: flex;
...
YES
PERFECT
austere talon
LOOKS SO MUCH BETTER
```css
.vc-settings-quickActions-card {
display: flex;
...
i dont think it does
glass jasper
i dont think it does
well my ocd does
charred monolithBOT
austere talon
okay im done now 
austere talon
I will make the buttons evenly sized for you then
not that
i think it looks bad if they're inconsistently aligned
glass jasper
i think it looks bad if they're inconsistently aligned
then add a another button that does something to even them out
woeful sleet
Can you force push an empty commit? just to annoy some people
austere talon
then add a another button that does something to even them out
i already told you thats not possible
charred monolithBOT
austere talon
thats too bad
austere talon
which you mean
look at changes in webpack folder https://github.com/Vendicated/Vencord/commit/b333deb7312107a629920737a0e9cd56936a35a5
limber skiff
yeah I saw
austere talon
cleaned up webpack methods code and made some more functions able to search by regex and use canonicalizeMatch
i needed it for mapMangledModule
limber skiff
I'm gonna add the regex functionality later
to my refactor
didnt think we would ever need it lmao
was an array of code not enough?
austere talon
well
318661: function(e, t, n) {
"use strict";
n.d(t, {
Of: function() {
return c
},
ZP: function() {
return l
}
}),
n(47120),
n(470079);
var r = n(442837)
, i = n(594174)
, a = n(251625)
, o = n(255564)
, s = n(621853);
function l(e, t) {
return (0,
r.e7)([i.default, s.Z], ()=>c(e, t, [i.default, s.Z]))
}
n(484459);
let u = (0,
a.oH)((e,t)=>new o.Z(e,t));
function c(e, t) {
let[n,r] = arguments.length > 2 && void 0 !== arguments[2] ? arguments[2] : [i.default, s.Z]
, a = n.getUser(e)
, o = r.getUserProfile(e)
, l = r.getGuildMemberProfile(e, t);
return null == a || null == o ? null : u(o, l)
}
},
not very robust
also technically regex should be faster
limber skiff
hmm no idea of it's not faster
string searches are super fast
I'm not against adding the support for regex but I would still use array of strings when possible
limber skiff
not very robust
oh i see that's 3 matches
I thought it was one for a second
makes sense
austere talon
how is it so fast
fallen vale
uwu
austere talon
oops
verbal pumice
average github pr
charred monolithBOT
fallen vale
you tell em girl!
desert cosmos
schizophrenia
still wasp
The pipeline
rugged spire
quick find some funny example to reply with that you SHOULD do
hi!!!! please DO go insane like I did or you will explode
charred monolithBOT
nimble plaza
vp applem
desktop only
long stream
@nimble plaza fyi the plugin is hidden if you're not on macOS
you should include that in your reply 
nimble plaza
oh
long stream
nimble plaza
oh
long stream
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/5c05443f454dd04288108330875f437889dc6...
native.ts: Lines 94-113
const playerState = await applescript(['tell application "Music"', "get player state", "end tell"])
.then(out => out.trim());
if (playerState !== "playing") return null;
const playerPosition = await applescript(['tell application "Music"', "get player position", "end tell"])
.then(text => Number.parseFloat(text.trim()));
const stdout = await applescript([
'set output to ""',
'tell application "Music"',
"set t_id to database id of current track",
"set t_name to name of current track",
"set t_album to album of current track",
"set t_artist to artist of current track",
"set t_duration to duration of current track",
'set output to "" & t_id & "\\n" & t_name & "\\n" & t_album & "\\n" & t_artist & "\\n" & t_duration',
"end tell",
"return output"
]);
pretty sure the windows client doesn't let you do any of this
desert cosmos
**native.ts:** Lines 94-113
```ts
const playerState = await applescript(['tell a...
applescript horror
limber skiff
lint is not passing btw
lone wren
W
limber skiff
fixed lint
austere talon
maybe .dev plugin?
limber skiff
thinking better wouldnt it be better to have this enabled by default
less errors for users to send us screenshots
with this disabled
limber skiff
WHY
austere talon
less errors for users to send us screenshots
we already tell them to select error only
limber skiff
we already tell them to select error only
yeah and the plugin removes useless errors that always happen
like the font one
austere talon
can u add something that stops the spotify store from logging ur spotify name and access token
limber skiff
good idea
limber skiff
an option or default behavior?
austere talon
i love when people share debug log and i have to tell them to deauthorise discord from spotify cause the screenshot included their spotify access token 😭
limber skiff
I KNEW IT
limber skiff
i love when people share debug log and i have to tell them to deauthorise discor...
okay so then I should make the plugin enabled by default and not dev only
limber skiff
yeah it's my id
found it
this has too many logs with the account id, I will just disable the logger
austere talon
it logs username and token
austere talon
ye somewhere
Devices updated for {name}
oh it's account id
why is my account id my username
limber skiff
I disabled it completely regardless
limber skiff
god
austere talon
actually we cant fix that i think
limber skiff
the fucking error
limber skiff
might be able to put an error event handler
okay so its here
hmm maybe not
it does have a onerror
limber skiff
that's so stupid
nimble plaza
shitty hacky fix idea:
in electron is it possible to specify default settings for devtools?
ie: console filter
limber skiff
anyways if we dont have any other ideas I'm merging the plugin soon
austere talon
shitty hacky fix idea:
in electron is it possible to specify default settings fo...
i looked into this previously, i dont think so
your best bet is a devtools extension
what if we made patch helper a devtools tab
nimble plaza
scary
dusk blaze
what if we made patch helper a devtools tab
I once thought of making a Recovery tab
independent from vencord
would have things such as disable all plugins
austere talon
wait we could make a devtools tab for updating vencord
dusk blaze
clear themes
dusk blaze
okay
austere talon
will be officially added if good
nimble plaza
wait idea
what if we patch the spotify ws url to
?aaaaaaaaaa<repeat>&access_token=blabla
so console shortens the url
limber skiff
austere talon
since we can't hide the spotify token anyway
limber skiff
why now that I merged 😭
austere talon
?aaaaaaaaaa<repeat>&access_token=blabla
i don't think it works
nimble plaza
aw
austere talon
why now that I merged 😭
i didnt know u were gonna merge instantly 
fallen vale
💀
woeful sable
thank you so much nitro
they gon force you to learn a new language 🙏
limber skiff
you mean that I should have added that?
jagged cloak
i mean sure if u want
jagged cloak
i think its because i have that one dev option on actually
i dont remember if rpcserver spams like that without it
just kidding it does
guess i was hallucinating again 
jagged cloak
this stuff
its either super noisy or not at all
depends
i just have it filtered all the time though
dapper crest
i just have it filtered all the time though
Send filter
pine wadi
esbuild 0.15.18 (released 2022-12-05) doesn't support RegExp literals using the v flag. may i update our esbuild dependency to a newer version?
it looks like https://github.com/Vendicated/Vencord/pull/2446 moves the bounds from ^0.15.18 to ^0.21.5, but that topic branch includes a non-trivial amount of other work
i'll go for submitting a standalone "esbuild": "^0.23.0" then
pine wadi
actually, @limber skiff, since you're around, could you review #1661 please?
limber skiff
I'm gonna let vee see it, but if they dont I will do
pine wadi
it really is just (all in scripts) pnpm run for future-proofing, factoring out the lint scripts in the style of "lint": "pnpm run lint-user --ignore-pattern src/userplugins", adding test-user and testWeb-user which call -user variants when appropriate, and adding .m{t,j}s{,x} to the eslint extensions
if you're strongly opposed to linting src/userplugins then you should be able to cherry pick just the last commit just fine
charred monolithBOT
charred monolithBOT
fallen vale
uwu
glass jasper
jumpscare
pine wadi
it looks like https://github.com/Vendicated/Vencord/pull/2446 moves the bounds f...
turns out that #2446 doesn't handle concurrent esbuild logging robustly. kind of a pain to set up but got that working on 0.17.18 at least, along with proper summary emulation.
buildWeb --watch seems weird but i think it was that way before?
charred monolithBOT
pine wadi
oh, @dire trench isn't here
pine wadi
turns out that \#2446 doesn't handle concurrent esbuild logging robustly. kind o...
okay rest of the versions done yay
charred monolithBOT
limber skiff
it takes so long to load
when it doesn't freeze all of devtools
austere talon
what if we made it so that it splits all modules in dev builds
so we don't have to deal with that massive chunk anymore
austere talon
why?
limber skiff
devtools doesn't like so many source files
limber skiff
okay
rugged spire
as someone who has used that for long enough that I ended up heavily forking it
there is (probably) a reason why it hasnt been merged
not that it is a bad plugin, it's just
- very complicated
- doesnt actually hook around Discord's history wrapper
fossil inlet
not that it is a bad plugin, it's just
- very complicated
- doesnt actually hook...
last time i used it, the main issue i had is that ctrl+click doesnt open in new tab, and there is no option to opne all channels in new tabs by default
rugged spire
last time i used it, the main issue i had is that ctrl+click doesnt open in new ...
mmmm
fossil inlet
might fork it myself and add those features
rugged spire
also the fact it feels laggy just because of expecting tabs to be instant
fossil inlet
also the fact it feels laggy just because of expecting tabs to be instant
i felt no lag using it
rugged spire
isnt there an insane 500 line util file dedicated just to tab management
fossil inlet
also this favorites section superseded it for me
rugged spire
also this favorites section superseded it for me
problem with favorites is uhhhhhhhhh
fossil inlet
problem with favorites is uhhhhhhhhh
you cant search in them
rugged spire
i need to Shove CSS into it
rugged spire
respectfully why did you apply a windows icon skin on linux
jagged reef
respectfully why did you apply a windows icon skin on linux
W > L
rugged spire
cursed
verbal pumice
not that it is a bad plugin, it's just
- very complicated
- doesnt actually hook...
!remindme 10h look through this
shut vineBOT
Alright @verbal pumice, in 10 hours: look through this
💡 Did you know you can set your timezone with "!timezone set"?
rugged spire
!remindme 10h look through this
all I ask is
don't steal my code that tried to do it it's Also Broken
verbal pumice
yeah
wasnt going to
i just gave up on trying to do anything more w the plugin after horribly failing to add keybinds
austere talon
tf is a patch stack
pine wadi
it's probably a "patch series" in gitworkflows(1) terminology
rugged spire
it's probably a "patch series" in [gitworkflows(1)](https://git-scm.com/docs/git...
what do you mean "probably" you made this PR
pine wadi
alternatively, "atomic commits"
pine wadi
what do you mean "probably" you made this PR <:blobcatcozy:1026533070955872337>
i don't do enough git or kernel workflow stuff to feel super confident about those terms?
rugged spire
i don't do enough git or kernel workflow stuff to feel super confident about tho...
real
git scary sometimes
austere talon
what in the world is the point of this
pine wadi
what in the world is the point of this
esbuild is then moved forward one breaking release at a time, to make both authoring and reviewing easier.
the changelog doesn't group breaking changes together either
because esbuild is something i really didn't want to break, this is meant to make reviewing with the changelog open easy
you can see what i thought needed changing for each set of breaking changes on esbuild's side
also if something did break that i didn't catch you can have a better experience bisecting
rugged spire
git bisect cant fix merging in fucked up code that was force pushed over on the remote
rugged spire
it is
pine wadi
i wanted to reduce the pain of debugging a broken build if that happened. the commit list is longer but you can see that most of them only change 2 files and skip them with a better amount of confidence in manual review once you've confirmed that the breaking changes on esbuild's side are irrelevant
pine wadi
also i think pnpm run build from here is now faster with the new logging handling. it at least feels faster than pnpm run build --summary from here, but that may have extra delays to preserve terminal output because esbuild kept on outputting over itself in my local tests (see attached). i haven't benched any of this.
esbuild technically does lock some when logging but it's obviously not enough under concurrent builds across multiple contexts.
also, current pnpm run build output with an error. a bit more compact but i think it's good enough
charred monolithBOT
limber skiff
vee loves sending me merge conflicts
I would keep using Vencord.Plugins here
it's all executed later so it causes no issues
and importing plugins might cause circular
austere talon
and importing plugins might cause circular
nah
it cant
only if u use on top level
theres alr circular dep somewhere
limber skiff
how do you know?
rugged spire
plugin settings
limber skiff
well it works
limber skiff
gonna keep that as a draft
desert cosmos
i love you
charred monolithBOT
long stream
This is very prevalent when using ClientTheme and looking at "channels and roles"
huh
austere talon
that's fucking hilarious did discord fix it at the same time
austere talon
austere talon
inb4 they unhardcoded every colour
long stream
was it ever broken?
austere talon
this is on canary btw
dapper crest
are you on canary or smth?
still wasp
Discord is just tactically planning updates to piss off vencord contributors
dapper crest
was it ever broken?
long stream
yea ive seen the screenshot in the pr
dapper crest
inb4 they unhardcoded every colour
@austere talon or @long stream
run https://github.com/Vendicated/Vencord/pull/2663 on canary and tell me if <style id="hardcodedColorFixes"> contains anything
austere talon
why don't you?
still wasp
Vee is a sacrifice to the canary gods
dapper crest
why don't you?
don't have a canary install right now 
austere talon
do u not have vesktop
still wasp
don't have a canary install right now <:trolley:1211092339423191050>
Shrimply vesktop
austere talon
missing out
dapper crest
so true
I should use vesktop
how do you point vesktop to a custom vencord install?
woeful sable
in the settings
still wasp
how do you point vesktop to a custom vencord install?
Vns
nimble pendantBOT
how do you point vesktop to a custom vencord install?
still wasp
Smh
still wasp
Shrimple
long stream
<@343383572805058560> or <@222069018507345921>
run https://github.com/Vendicate...
omgg its this issue again 😭
whyyy
is my dev install that broken
still wasp
whyyy
I'm no expert but i'd say it cannot read properties of undefined (reading 'Settings')
austere talon
disable BetterNotes
dapper crest
inb4 they unhardcoded every colour
There are still plenty of hardcoded colors
oh those border colors probably won't work
need to fix how I insert var(...)
charred monolithBOT
Discord Account
terminaate
What happens when the bug or crash occurs?
It doesn't show current user's voice channel -
I guess it's happening because of discord ui update
What is the expected behaviour?
Display the current user's voice channel
How do you recreate this bug or crash?
Open any user profile that currently in any voice chat
Errors
Replace th...we need to disable issues on vendicated/vencord and make some private issue tracker exclusively for contributors
soo many people ignore requirement
still wasp
Ruh roh raggy
austere talon
exploder
charred monolithBOT
rugged spire
desert cosmos
some people manage to turn off simplified profiles
sounds like their issue in my opinion
desert cosmos
ZoidCord
shut vineBOT
@verbal pumice, <t:1720032162:R>: look through this
weary bolt
!remindme 8h wake the hell up before i slap the living shit out of you
shut vineBOT
Alright @weary bolt, in 8 hours: wake the hell up before i slap the living shit out of you
charred monolithBOT
The ViewIcons plugin was blocking users from opening the bigger profile by clicking the pfp in the right side panel in dms
Image of where I'm talking about
Before fix: Clicking on this pfp would open the pfp as an image preview
After fix: Clicking on this pfp opens the big profile view as expected
fossil inlet
maybe this should be a toggle instead of flat out removing it
but it should be at least a toggle
rugged spire
click the username?
glass jasper
click the username?
too much work
shut vineBOT
@weary bolt, <t:1720070107:R>: wake the hell up before i slap the living shit out of you
charred monolithBOT
weary cave
@austere talon I think you are better equipped to answer this than me, I don't know what the point is I just re-implemented it for the latest https://github.com/msfragala/eslint-plugin-path-alias/issues/1#issuecomment-2209332213
weary bolt
<@594864203102158859>, <t:1720070107:R>: wake the hell up before i slap the livi...
fuck i now gotta slap myself
weary cave
<@343383572805058560> I think you are better equipped to answer this than me, I ...
Thx ven
fallen vale
lol
fallen vale
someone's obsessed
fossil inlet
someone's obsessed
fallen vale
<#1206953288537210890>
what?
fossil inlet
kindred estuary
pain
kindred estuary
i’m aware
limber skiff
plugin is obsolete anyway
should I not fix
I guess it's fine to keep it working for now
charred monolithBOT
fallen vale
damn
charred monolithBOT
omg epic sigma skibidi rizzler code
that’s cringe, not funny
damn, i cant even make a brainrot joke without some weird gay mf getting mad lol
you’re literally a full stack developer making dumb jokes like this, and you run your own website, get a life gen ass
long stream
this is some fork commit 😭
the commit is part of a pr
for some reason those commits count
charred monolithBOT
charred monolithBOT
glass jasper
Least obvious pr bump
still wasp
😭
rugged spire
hop online first thing i see is 1 minute ago deleted message of someone being a clown
limber skiff
@austere talon can you make a repo for the code you already have for the new reporter?
austere talon
i mean there's not much more to do, i might just finish it tomorrow
also it's in go not js
limber skiff
I've done stuff with go in the past already
limber skiff
really @fallen vale
fallen vale
yes ;-;
fallen vale
if it's there it's for a reason
thats why i asked "why"/gen
limber skiff
okay sure if it was another contributor or first time contributor
but it's vee, he wouldn't do stuff for nothing
it's not the first time you are making useless comments/reviews
fallen vale
but it's vee, he wouldn't do stuff for nothing
im aware. which is why i was curious, and asked about the reasoning.
i didnt suggest removing it, just asked as to its reasoning
fallen vale
it's not the first time you are making useless comments/reviews
yea ik, i pointed out the checkbox, and got kinda yelled at for it lol
and then i stopped doin that, and then the checkbox was removed shortly after
fallen vale
whats the point of opening a pr, if a review asking a genuine question is going to be met with "really, my god, stop making useless reviews"?/genq
limber skiff
my god
fallen vale
im not tryna be rude, just understand the situation a bit better
limber skiff
it's literally the owner of the project
fallen vale
i get that
limber skiff
and thats enough of a reason to not ask why that was placed in that PR
it's needed changes which are gonna go to dev regardless
vee just took the opportunity to do inside that pull requests
my pull requests do that all the time
fallen vale
okay, thank you/gen
fallen vale
and thats enough of a reason to not ask why that was placed in that PR
this, i personally disagree with.
but your project, your rules. ill drop it.
limber skiff
not even my project
fallen vale
no ik
fallen vale
i was sayin that if thats what the owner of the project thinks, and thats whats agreed on here, its non beneficial for anyone to argue against it
alr, i hid the comments
fallen vale
i did mean to response
i need to go to sleep
