#👾-core-development

1 messages · Page 177 of 1

past terrace
#

wtf is that url

rugged spire
#

I KNOW WHAT DISCORD DOT SEX IS

median rapids
rugged spire
#

WHAT DO YOU MEAN USERDOCCERS DEV

median rapids
#

development

rugged spire
subtle leaf
#

the best site

rugged spire
subtle leaf
#

imo

rugged spire
#

describe the usecase

median rapids
#

vscode one monitor

#

pnpm dev on other monitor

weak thistle
#

I used to always have 2 or 3 monitors but I kinda stopped using the other monitors after I started using tiling wms and when I redid my setup I just got rid of the second monitor

charred monolithBOT
weak thistle
#

now I have 20 workspaces open blobcatcozy

median rapids
#

oh i could make polls plugin

#

custom ends

charred monolithBOT
median rapids
#

actually there's a lot of places in the app where they hardcode intervals that don't need to be hardcoded

rugged spire
#

make it for timeouts

subtle leaf
#

polls plugin?

median rapids
#

yea

#

timeouts too

rugged spire
#

i fucking despise how the minimum timeout length is 60 secs

subtle leaf
#

i'm sorry i haven't slept all night

past terrace
#

i'm a massive brainrot fan, and i always have either discord or a video playing on my second monitor whenever i'm doing stuff

charred monolithBOT
subtle leaf
#

how would that poll plugin work

subtle leaf
rugged spire
subtle leaf
#

i think i know this link from somewhere

charred monolithBOT
mortal fractal
#

(the actual answer is "look at code that you know has it used")

#

which is how i even found that it was using an experiment

mortal fractal
median rapids
rugged spire
median rapids
#

iso8601 timestamps

#

iirc

rugged spire
mortal fractal
#

has it always supported timestamps??????

median rapids
#

no

rugged spire
#

thats how the API works

median rapids
#

it used to be just

rugged spire
#

wait

median rapids
#

duration_secs

rugged spire
#

thats for timeouts at least

#

yeah

median rapids
#

i think they added the new field for bots

mortal fractal
#

duration was always in hours

rugged spire
median rapids
#

yeah same thing bleh

mortal fractal
#

so they added a new field for exact time

rugged spire
median rapids
mortal fractal
#

real

#

please do make then

rugged spire
median rapids
#

client still sends hours

rugged spire
#

what is layout_type

median rapids
#

api has timestamp

#

currently all exp locked

#

only default exists

charred monolithBOT
median rapids
#

the field is expiry btw

#

hmm

#

didnt work?

#

looks like 24h is minimum

rugged spire
#

uhhhhhh

Sqaaakoi-24-04-2024-17-03-32.png
median rapids
subtle leaf
median rapids
#

guh

subtle leaf
#

or am i not getting something

rugged spire
median rapids
#

i think it just

#

doesnt work??

#

is it really restricted to bots

#

did they fuck around with super props

#

oh well

#

ima actually sleep

rugged spire
#

@median rapids this is fine right

Sqaaakoi-24-04-2024-17-07-44.png
median rapids
#

I probs could've patched that

#

hard,,,

charred monolithBOT
rugged spire
#

wtf is discord cooking here

Sqaaakoi-24-04-2024-17-16-03.png
austere talon
#

we have an api to easily patch any context menu

#

if they have a prop / module for which tab is open you can easily do it with that

rugged spire
#

nop

#

because

#

pending and blocked dont have such context menus

#

btw it's friend-row if anyone was curious what the id for the context menu was

#

though you could use .target

#

and find info about the parents

#

check if any parents are #implicit-tab

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
crude hearth
long stream
austere talon
long stream
#

silly

#

tho i see why it would be forgotten

#

small plugin thats only useful to like 3 people (me and my 2 alts)

crude hearth
#

my pr has been forgotten

median rapids
austere talon
#

yeah what u said and also that this was a different batch of prs

#

i can do it later

charred monolithBOT
austere talon
#

how do people keep messing up their branches

#

@untold tangle what happened :o

untold tangle
#

github is hard okay

#

getting rid of the declutter plugin

charred monolithBOT
austere talon
#

i see

charred monolithBOT
charred monolithBOT
mortal fractal
#

damn only 3 of them posted

jagged reef
glass jasper
torn knot
shell shuttle
#

at least some plugins are being pushed tho

charred monolithBOT
charred monolithBOT
charred monolithBOT
subtle leaf
#

hopefully

glass jasper
#

one can hope

odd heath
#

discord doesnt stop breaking the plugins jfc

cFdfUTjZRy0b5C6oJgQcG6f541xMuHiKVqi.png
charred monolithBOT
frail skyBOT
#
Bad Patches

OnePingPerDM (had no effect):
ID: 974180
Match: /sound:(\i\?\i:void 0,volume:\i,onClick)/

RoleColorEverywhere (had no effect):
ID: 805009
Match: /renderName\(\).{0,100}speaking:.{50,150}"div",{/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

OnePingPerDM (had no effect):
ID: 974180
Match: /sound:(\i\?\i:void 0,volume:\i,onClick)/

RoleColorEverywhere (had no effect):
ID: 805009
Match: /renderName\(\).{0,100}speaking:.{50,150}"div",{/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

I gotchu dont worry

subtle leaf
odd heath
#

put it into my pr

#

both

limber skiff
#

oh

#

you fixed already

odd heath
#

yop

limber skiff
odd heath
#

wait a sec

#

oh nvm

#

im stupid

#

ofc the plugins are broken on vesktop when my fixes are on discord stable 😭

limber skiff
#

wdym?

#

its broken on all versions

#

this patch is kinda crazy but ig it works

charred monolithBOT
odd heath
# limber skiff its broken on all versions

no i have my dev build point to discord stable so my install of stable is fixed but i was looking at vesktop console and wondering why the broken patches appeared 😭

#

i should stop running multiple instances of discord at once

charred monolithBOT
limber skiff
#

thanks

charred monolithBOT
limber skiff
#

vee please review ^^

#

honestly it doesnt even need a super careful reviewing, I use that branch for months already

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

glass jasper
odd heath
#

theres an error coming from dearrow btw but idk how to reproduce it

BZsshNGqrALoccottNewaStDxNzfQ6M5kv1.png
#

just kinda annoying because it takes up the entire console whenever it occurs

mortal fractal
#

nvm that might just be unminify react errors

#

does vencord not throw component stack on errorboundary errors?

odd heath
mortal fractal
#

can you send that part of the error

odd heath
#

which exactly

mortal fractal
#

component stack

odd heath
#

if i see it pop up again i will

austere talon
#

somehow the this is undefined

#

dunno how

#

oh wait hold on no

mortal fractal
#

thats what i thought but it shouldnt be the case

austere talon
#

for some reason component here is undefined

image.png
mortal fractal
#

which would in fact be this

austere talon
#

yeah literally the this lol

image.png
mortal fractal
# 
-                match: /children:\[(?=null!=\i\?\i\.renderSuppressButton)/,
-                replace: "children:[$self.renderButton(this),"
+                match: /children:\[(?=null!=\i\?(\i)\.renderSuppressButton)/,
+                replace: "children:[$self.renderButton($1),"
austere talon
#

yeah

#

i was just about to say it uses an aliased this

#

but i wonder why it only happens sometimes??

#

they pass the method as a value without binding it

mortal fractal
#

wild

#

makes sense

#

so yeah my fix would work then

charred monolithBOT
charred monolithBOT
glass jasper
#

Why is AliucordPlugins tracked and why are they tracked in to this channel

charred monolithBOT
mortal fractal
glass jasper
mortal fractal
#

to each their own

#

thats just effort

#

cause if you're gonna change the url you're better off just removing it entirely

charred monolithBOT
glass jasper
#

ik vendriod isn’t actively worked on, but it won’t hurt to have a dev channel for it, could be something like
#📱-Moblie-development

jagged cloak
#

meh

charred monolithBOT
#
katlyn
[Vendicated/Vencord] Pull request opened: #2388 feat(USRBG): update USRBG to use new API

USRBG has moved storage to a new dedicated platform, allowing better integration and more control over the data that can be made available for plugins to use. This has allowed creation of a new API that has several benefits:

  • The API's data is updated immediately upon a user's background being approved
  • Data sent over-the-pipe can be reduced, only sending a list of user ids and a small bit of metadata (~600kB instead of the current 1.7MB)
  • Dead links are no longer a possibility and do n...
golden gulch
charred monolithBOT
#
thororen1234
[Vendicated/Vencord] New comment on pull request #2373: Added CustomPFP plugin

Which user pfp plugin?

#1956

Oh i didnt know about it

So if you didn't know, for a few questions why is the let data needed if it isn't used besides what's above the name of the plugin which can be removed, the patch is clearly just a copy and paste with the note included, even the avatarhook was barely changed. So after all of that are you positive you didn't know it existed?

glass jasper
gritty iris
#

Not that

glass jasper
#

Still a good example though

gritty iris
#

But yes ig

rugged spire
#

i still insist userpfp is a niche plugin that has no practical use husk
editing user pfps locally is useful though

charred monolithBOT
#
coolesding
[Vendicated/Vencord] New comment on pull request #2373: Added CustomPFP plugin

The commands sound like an admin feature for the people that made and run UserPFP (Me included). Unless of course you want every user being able to change everyone else's profile picture. We don't need this functionality, though a client side requesting feature would be good, if you want you can ask Nexxpid if you can take the code and add a requesting feature. Contact me on Discord for more.

gritty iris
glass jasper
rugged spire
#

every time someone says

#

DO IT WITH CSS!!!!

#

i die a bit inside

#

why?

#

files

#

thats why

gritty iris
#

I don't like css

#

Mostly because I break stuff with it but

rugged spire
#

CSS feels infinitely more jank thank removing child elements from the source tbh

glass jasper
rugged spire
#

if you mean locally as in css snippets thats one thing

glass jasper
rugged spire
glass jasper
rugged spire
#

i really need to make the replacement to quickcss already

rugged spire
gritty iris
#

I read cease and desist

#

So

glass jasper
gritty iris
#

Tbf it said cnd

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
# charred monolith

sorry does anyone know what this person means? there is already a compose file, what do they mean a docker compose installer?

#

what's casaos?

golden gulch
#

I think they mean they want the image built and published somewhere

charred monolithBOT
rugged spire
# turbid hatch what's casaos?

web ui for managing home servers made by a company who makes home server products that always have some very tiny issue that would make them husk to use

golden gulch
#

CasaOS is one of those all-in-one hosting operating systems, I'd guess that it has a feature to upload a compose file and run it for you or smth like that

rugged spire
rugged spire
#

probably some segment in a hardware haven video

golden gulch
#

any of those all-in-one management solutions tend to be cursed or really bad in some way

rugged spire
golden gulch
#

nop

rugged spire
#

but

#

basically they just suck

#

give me terminal utils

#

i hate docker

rugged spire
golden gulch
#

there's no prebuilt docker image

rugged spire
#

oh

#

and why is that an issue blobcatcozy

charred monolithBOT
charred monolithBOT
charred monolithBOT
#
Luca99iscool1
[Vendicated/Vencord] New comment on pull request #2373: Added CustomPFP plugin

The commands sound like an admin feature for the people that made and run UserPFP (Me included). Unless of course you want every user being able to change everyone else's profile picture. We don't need this functionality, though a client side requesting feature would be good, if you want you can ask Nexxpid if you can take the code and add a requesting feature. Contact me on Discord for more.

My use for it was if someone has something as a pfp that is offensive to you that you can change...

#
Luca99iscool1
[Vendicated/Vencord] New comment on pull request #2373: Added CustomPFP plugin

Which user pfp plugin?

#1956

Oh i didnt know about it

So if you didn't know, for a few questions why is the let data needed if it isn't used besides what's above the name of the plugin which can be removed, the patch is clearly just a copy and paste with the note included, even the avatarhook was barely changed. So after all of that are you positive you didn't know it existed?

Im very sure that i did not copy paste it the only plugin i...

charred monolithBOT
charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New comment on pull request #2373: Added CustomPFP plugin

The commands sound like an admin feature for the people that made and run UserPFP (Me included). Unless of course you want every user being able to change everyone else's profile picture. We don't need this functionality, though a client side requesting feature would be good, if you want you can ask Nexxpid if you can take the code and add a requesting feature. Contact me on Discord for more.

what? this pr has nothing to do with your project. it's just a plugin to locally change user's p...

#
Vendicated
[Vendicated/Vencord] New comment on pull request #2373: Added CustomPFP plugin

hi, thanks for your pr!

i think this feature itself is a good idea but the implementation is bad

why only support the pfp? it would be way nicer if this allowed you to change all user properties just like the existing EditUsers plugin for BD. like username, nickname, pfp, banner and name colour in chat

and instead of using slash commands it would be way nicer to have a button in the user context menu that opens a modal where you can customise everything

austere talon
austere talon
austere talon
charred monolithBOT
glass jasper
turbid hatch
#

im not publishing images to a registry

#

theres no point

charred monolithBOT
charred monolithBOT
austere talon
#

the way everything fades in is so overdone and awful

rugged spire
#

though

#

i am on chrome xwayland

#

because goggle fucked their ozone wayland stuff up even more than it was before

charred monolithBOT
rugged spire
#

i'd imagine it sucks without gpu acceleration (which works under X)

rugged spire
charred monolithBOT
crude hearth
topaz spoke
#

👍

charred monolithBOT
golden gulch
#

they're probably trying to paste a docker compose into a web gui that only supports using pre built images, at least that what seems likely to me given the OS they're running

mortal fractal
#

(yes i am still the only noscript user in $CURRENT_YEAR)

turbid hatch
charred monolithBOT
shell shuttle
verbal pumice
austere talon
#

well yeah this could be used

image.png
#

from the plugin

#

but that wontwork for the plugin i linked actually

#

cause you cant hold shift with the plugin

verbal pumice
#

so that needs to be fixed too

#

lovely vencord, change one plugin fix 2 more

austere talon
#

wdym?

#

what needs to be fixed

#

the plugin i linked works correctly

verbal pumice
#

oh i

#

cant read

austere talon
#

:p

#

oh wait if u pass false to that func as isHoldingShift it wont alter behaviour

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
charred monolithBOT
#
soulfireneedusername
[Vendicated/Vencord] Pull request opened: #2391 Plugin: betterThemes Revamped Theme Tab

Easily add buttons to switch themes to personalize your Discord interface. You can also create these buttons yourself and even add images to them. You can scale, edit them and add your own CSS rules for personalization. This way, all your favourite themes will be saved in the themes tab and it is incredibly easy to switch between them. You can also use the Themes Diashow function and set it to a custom interval to automatically change between themes. If you want to add a theme or browse onlin...

austere talon
#

did devilbro find out about vencord

glass jasper
maiden oracle
#

you can mention people without pinging them by editing their mention into the message after you send it

#

for example, @glass jasper

#

also wait that isn't devilbro?

glass jasper
glass jasper
maiden oracle
glass jasper
maiden oracle
#

test @maiden oracle

#

what the fuck

#

my life is a lie husk

austere talon
#

no it does work

maiden oracle
#

yeah I just had someone else do it to me to confirm

#

it only shows the ping icon if you manually mark it as unread

#

my life is a truth content

charred monolithBOT
charred monolithBOT
mortal fractal
#

what node version is electron 28 though

#

actually nvm im stupid, vencord is built

charred monolithBOT
charred monolithBOT
rugged spire
charred monolithBOT
#
Sqaaakoi
[Vendicated/Vencord] New comment on pull request #2391: Plugin: betterThemes Revamped Theme Tab

This will be denied for many reasons

Devs are always stored in the Devs constant
Vencord uses React and JSX
You should be editing the existing themes code
Do not hardcode randomly generated CSS class names
Do not blindly port BD code to Vencord. It looks like you copied code that DevilBro made

<sub>I genuinely can't tell if this is worse than the time someone submitted AI generated code. FakeNitro is commonly said to be unreadable, this is literally 10 times worse</sub>

...

rugged spire
#

i am not sorry

#

anyway

#

back to writing actual code people won't immediately say "DevilBro wrote that" as soon as I submit the PR

charred monolithBOT
#
soulfireneedusername
[Vendicated/Vencord] New comment on pull request #2391: Plugin: betterThemes Revamped Theme Tab

I knew that the readability would be a problem. But i just don't know how a code with those functionality's could work otherwise. I worked too many hours on this so unless you say it's not worth to try finishing this, please tell me.

  1. I can surely do that (change how information gets store)
  2. I can rename the names (which I named because of complexity, but I understand)
  3. I don't know what you mean by port BD code. I am just importing the theme links. I found that a very useful feature...
rugged spire
charred monolithBOT
#
Sqaaakoi
[Vendicated/Vencord] New comment on pull request #2391: Plugin: betterThemes Revamped Theme Tab

I knew that the readability would be a problem. But i just don't know how a code with those functionality's could work otherwise. I worked too many hours on this so unless you say it's not worth to try finishing this, please tell me.

  1. I can surely do that (change how information gets store)
    We already have IndexedDB support through DataStore
  2. I can rename the names (which I named because of complexity, but I understand)
    You should be removing the complexity as it isn't nee...
jagged cloak
#

wtf

#

bro added a whole db

#

(devilbro)

rugged spire
jagged cloak
#

if you have to press load diff its not getting accepted ever

rugged spire
#

real

#

like

#

wtf is this

Sqaaakoi-26-04-2024-20-11-26.png
jagged cloak
#

also what is stopping them from using datastore

image.png
#

or literally anything but that

rugged spire
#

nothing

jagged cloak
#

lol

rugged spire
#

is it even worth helping

jagged cloak
#

dont waste your effort lmao

rugged spire
#

true

#

i am going insane rn

#

trying to make my own theme stuff husk

#

fuck it

#

i will scrap existing system

jagged cloak
#

gl

rugged spire
#

dont like how it works anyway

jagged cloak
#

themes was already tried like 4 times before

rugged spire
#

idc about themes too much

#

i only care about replacing quick css

jagged cloak
#

actually the local themes thing got merged eventually

#

i forgot

rugged spire
#

yes it did

#

since forever ago

rugged spire
#

because

#

1000 line shitcode

#

=

#

vf lag

#

husk bot dont work here

#

you know what i mean

#

good luck commenting out stuff manually

charred monolithBOT
rugged spire
#

it will go under 1.5k if you write good code

jagged cloak
rugged spire
charred monolithBOT
topaz spoke
#

@rugged spire

image.png
#

hardcoded classnames

rugged spire
#

this could've been easily prevented

#

by

#

not specifying those classes

topaz spoke
#

that's not my code btw

#

it's from the better themes thing plugin

rugged spire
#

i know

#

you know i am the main person trying to help this brainless ex-BD user /s

verbal pumice
austere talon
rugged spire
#

horror

austere talon
#

they're trying to contribute and you're yelling at them and insulting them

rugged spire
#

true

austere talon
#

imagine if that were you in that position

#

yes the pr is unmergeable for many reasons but no need to be so rude about it

grizzled halo
#

Give them constructive feedback so they can become more experienced :3

rugged spire
austere talon
#

i will reply to the pr in a bit

#

jus relax

rugged spire
#

hm

#

i do wonder

#

how do we feel about plugins that modify core behaviour

austere talon
#

no

rugged spire
#

thought so

austere talon
#

if you want to modify core behaviour just change core code xd

rugged spire
#

exactly

austere talon
#

that's the benefit of the centralised model

#

if u need any changes in core u can just make them

rugged spire
#

yop

#

making changes to vencord core code is very useful

#

until it makes you stay up overnight and make you go insane doing cursed IPC stuff

charred monolithBOT
odd heath
rugged spire
#

i will do it anyway

odd heath
#

everytime i do that and look at my code later again im like "wtf was i doing this sucks"

heavy cedar
#

Hackathons are super fun tho

shell shuttle
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

PronounDB (had no effect):
ID: 584045
Match: /{user:(\i),[^}]*,pronouns:(\i),[^}]*}=\i;/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

yep

charred monolithBOT
#
Nuckyz
[Vencord:dev2] 40 new commits

e0becc1 ShowHiddenChannels: Fix incompatibility with fa... - Vendicated
cba611c Better error for primitives on proxyLazy + fix ... - waresnew
3ecd2de plugin settings: fix filter dropdown having no ... - AutumnVN
ae01e88 EmoteCloner: fix low quality; don't count manag... - byeoon
26f3618 TypingIndicator: Add an option to show user ava... - Sqaaakoi

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

sterile oak
charred monolithBOT
charred monolithBOT
limber skiff
#

more stuff broke already 💪

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

MoreUserTags (had no effect):
ID: 467679
Match: /(switch\((\i)\){.+?)case (\i(?:\.\i)?)\.BOT:default:(\i)=.{0,40}(\i\.\i\.Messages)\.BOT_TAG_BOT/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

odd heath
#

Fun

odd heath
odd heath
#

Oh wait it's actually fine

limber skiff
#

I'm fixing already

odd heath
#

im in bed anyway :p

limber skiff
#

this regex is super hard to understand

image.png
austere talon
#

lmao

charred monolithBOT
limber skiff
#

I didnt want to commit the revert

#

💀

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
thorn lantern
#

Yikes!

woeful sable
thorn lantern
#

Sounds like [Vencord] Branch webpack-changes was force-pushed to e65c9cc

charred monolithBOT
limber skiff
#

=

jagged cloak
#

=

quaint sapphire
charred monolithBOT
spark pivot
charred monolithBOT
still wasp
#

WTF 💀

image.png
mortal fractal
#

(this is a joke post i purposely patch it to say bot)

charred monolithBOT
charred monolithBOT
austere talon
#

@limber skiff btw did u see that i reviewed ur webpack changes?

#

seems like u might have missed it

limber skiff
#

oh wtf

austere talon
#

lmao

limber skiff
#

😭 😭 😭 😭 😭

charred monolithBOT
austere talon
#

even ur comment says it might be missing

#

also is .e() fully reliable? i think it existed always right? only .el() disappeared

limber skiff
rugged spire
#

you are doing what now

limber skiff
#

very smart

rugged spire
#

are you hardcoding field names blobcatcozy

austere talon
#

no

rugged spire
#

😌

austere talon
#

wreq.p might also be of interest

#

its /assets/ for the main one

rugged spire
#

OH

austere talon
#

i wonder if sentry one also has /assets/ xd

limber skiff
#

I can't use /assets anymore

#

I used to

austere talon
#

yeah sentry also has /assets lmao

#

wait whats the third

limber skiff
#

but now it's defined after O

austere talon
#

so discord has three wp

#

ohhh

limber skiff
#

haha

austere talon
limber skiff
#

but .e seems like the best we can do

#

since it's related to chunks and only the main should have that

#

also

austere talon
#

how about .b

limber skiff
#

defined after too

#

what do you think of

#

it's the same but this changed

austere talon
#

revert revert

limber skiff
#

we can add the utility function for vesktop later

#

but at least it's not breaking anymore

#

if you accept it I will make the pr use the version that has the revert included

#

if you dont I will just leave the revert outside

austere talon
#

didnt we settle on regex being better than array anyway

limber skiff
#

oh right

#

nvm that will be for another time pr then

austere talon
#

and that wouldnt be breaking anyway

limber skiff
#

I had forgot haha

austere talon
#

:p

charred monolithBOT
limber skiff
#

FOR GODS SAKE

#

ANOTHER ONE

charred monolithBOT
rugged spire
#

that has been exploding for a while i think

rugged spire
#

if it can detect it then can it fix it

charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New comment on pull request #2391: Plugin: betterThemes Revamped Theme Tab

hi! thank you for your efforts but this is not even remotely mergeable for various reasons:

  • way too large. 6k lines of code is just too much. there's no reason a plugin like this should need that much code. and even if it did, you should split your code across multiple files to make it more maintainable
  • vencord uses react & patches. raw dom manipulation is to be avoided
  • we have many apis for doing things like adding css (literally just import a css file) and using the indexeddb. this...
limber skiff
#

ayoooo wtf?

austere talon
#

github-advanced-security-bot is not letting u catch a break

austere talon
limber skiff
#

idk

austere talon
#

did discord brick canary gaian

limber skiff
#

wtf

#

now it's happening anymore

#

maybe they did

#

and revert already

#

welp not our fault then

austere talon
#

did u fix every broken plugin alr?

#

i saw some pushes to dev

limber skiff
#

ye

#

okay so

#

what should I do

austere talon
limber skiff
#

push this fix to webpack-changes and merge it

#

or push the fix only

austere talon
#

push the fix only for now

limber skiff
#

alright

austere talon
#

ill have one last look at wp changes tmrw and then prob merge

#

could u bump & push the fixes to stable please

#

dont forget to also create v* tag

charred monolithBOT
austere talon
#

the .{0,250} arent very robust

limber skiff
#

sure

charred monolithBOT
limber skiff
#

biggest fan of .+?

charred monolithBOT
limber skiff
charred monolithBOT
limber skiff
#

@austere talon what do I do about that

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

it says that sometimes

#

idk why

rugged spire
#

it's because google cant review vencord extension within a reasonable time period

shell shuttle
rugged spire
#

rce love exploding every day

charred monolithBOT
charred monolithBOT
charred monolithBOT
#
soulfireneedusername
[Vendicated/Vencord] New comment on pull request #2391: Plugin: betterThemes Revamped Theme Tab

hi! thank you for your efforts but this is not even remotely mergeable for various reasons:

  • way too large. 6k lines of code is just too much. there's no reason a plugin like this should need that much code. and even if it did, you should split your code across multiple files to make it more maintainable

  • vencord uses react & patches. raw dom manipulation is to be avoided

  • we have many apis for doing things like adding css (literally just import a css file) and using the i...

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
odd heath
#

when will my pr get reviewed

verbal pumice
#

approximately 2067

odd heath
#

pronoundb breaks on june first

#

if pr not merged

glass jasper
odd heath
glass jasper
odd heath
#

NO

#

i love pronoundb

charred monolithBOT
limber skiff
#

btw ven I added an argument for the flux dispatcher so we dont have to worry about race conditions if we change stuff in the future (calling the method before setting the export value)

#

howerver I guess I can simplify a bit

charred monolithBOT
limber skiff
#

if you dont remember that's my branch that uses waitFor for finds

limber skiff
#

@median rapids btw, are _rows in implicitRelationships meant to contain type 5 relationships?

charred monolithBOT
median rapids
limber skiff
#

it broke

median rapids
#

oh

limber skiff
#

this no longer includes implicit relationships in the rows

#

so nothing is rendered

#

I actually dont know how this worked before, that's why I'm asking you

median rapids
#

i don't even remember anymore 😭

#

i'll take a look

#

mm something broke in fetchImplicitRelationships()

limber skiff
#

ohh I see

#

you are the one that sets them to 5

austere talon
#

bro

median rapids
#

yea

austere talon
#

of course as soon as we merge it it breaks immediately

median rapids
#

IKR 😭

#

in a year i only fixed it once

austere talon
#

the vencord classic

median rapids
#

and it was when they switched to rspack

limber skiff
#

someone actually talked about this yesterday 😭

median rapids
#

im pretty sure the dispatcher parts broke

#

idk why

#

did they change anything with dispatcher

austere talon
limber skiff
#

fuck

median rapids
#

lmao

limber skiff
#

hmm

long stream
limber skiff
#

maybe not this

long stream
#

discord spies on everything that dolfies has ever touched

limber skiff
#

still not working

long stream
austere talon
median rapids
#

i make some patches to the handling of that

#

to implement the nonce parameter

austere talon
#

did any of the patches break

median rapids
#

lemme see

austere talon
median rapids
#

patches are fine

#

yeah they completely changed how member chunks are dispatched

limber skiff
median rapids
#

yop

limber skiff
#

but where is the dispatch of that

median rapids
#

it's only the _BATCH one now

#

it's gone

long stream
limber skiff
#

this doesnt seem like it?

#

do they no longer dispatch that

median rapids
#

that is it

#

ok this is easy to fix

#

gimme 5 mins i'll pr

#

but they're cooking something here

#

@shy veldt yk which commit they changed this in?

limber skiff
#

idk what's happening there

median rapids
#

ur just not used to it bleh

long stream
#

inb4 they add it back next build blobcatcozy

limber skiff
#

I am

austere talon
limber skiff
#

but not this part

#

I've never really touch the websocket code

shy veldt
#

idk

#

prob something i didnt check

limber skiff
#

I UNDERSTAND

#

horrible formatting

#

I thought the code above related to sounds was dispatching it

austere talon
#

what did they cook

limber skiff
#

I think they just put the thing inside an array?

#

yopp

charred monolithBOT
limber skiff
#

lmao just a for loop

#

this easy

median rapids
#

yeah

limber skiff
#

tested?

median rapids
#

yeah it works

limber skiff
#

not even going to bother testing myself

#

aight

median rapids
#

scary

limber skiff
#

is that...

charred monolithBOT
limber skiff
#

thank you dolfies

median rapids
#

np bestie

long stream
#

omg

#

fastest vencord pr merge

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

shy veldt
median rapids
charred monolithBOT
charred monolithBOT
rugged spire
charred monolithBOT
charred monolithBOT
#
happyendermangit
[Vendicated/Vencord] Pull request opened: #2393 feat(plugin): Quests completer

This plugin completes quests without having the game. this is useful for quests that rewards you avatar decorations

The "Complete Quest" button is enabled only if:

  • You have uncompleted quests
  • You are streaming something
  • Someone is watching your stream (your alt or your friend.)

For Web, this requires to install an extension (only for chrome)

Screenshots:

![image](https://github.com/Vendicated/Vencor...

charred monolithBOT
#
SerStars
[Vendicated/Vencord] New comment on pull request #2393: feat(plugin): Quests completer

Afaik you don't need someone else watching for it to work as the js snippet works if no one else is there

It doesn't work since yesterday or 2 days ago, they patched so it only works in the desktop app.
By checking the user agent if it has the "Electron/" string and they also started checking how many people are in the VC, I'm pretty they will add "how many people are watching your stream" soon.

#
Vendicated
[Vendicated/Vencord] New comment on pull request #2393: feat(plugin): Quests completer

i don't think having this is a good idea

discord is very clearly cracking down on quest scripts, aamia had to change her script multiple times. so this plugin would possibly require frequent changes and unnecessarily upset discord

this is also more of a one time use thing than something you'd actually need as a plugin. just using the snippet that's floating around makes more sense

median rapids
#

W

#

would be a good 3p plugin tho

austere talon
median rapids
#

not what i said smh

austere talon
charred monolithBOT
median rapids
charred monolithBOT
rugged spire
#

freaky shit again

charred monolithBOT
shell shuttle
#

my auto text replacer 😭

rugged spire
shell shuttle
#

freakie

#

there

austere talon
#

freaky? i was freaky once

#

they locked me in a room

shell shuttle
#

a rubber room

glass jasper
surreal storm
#

wondering if i could get permission to open an issue on the vencord repo about a bug i found with messagelogger. the issue is basically that if someone sends a message, edits it to something else, and then edits it back to what it originally was, the second to last version of the message is not shown. gif of behavior is attached for clarity:

ZdXtuYa.gif
shell shuttle
rugged spire
dapper crest
#

I love the brainrot

rancid dragon
#

my brain is so rotted nothing can harm me anymore

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
tropic wagon
#

it's so free

#

introducing vencord plus (real): pay to get your pr merged more quickly

jagged cloak
#

lmao

#

next level impatience

charred monolithBOT
charred monolithBOT
median rapids
charred monolithBOT
charred monolithBOT
charred monolithBOT
#
PassLoad
[Vendicated/Vencord] Issue opened: #2394 [Bug] <title>3y3 button not appearing

Discord Account

kyotosoul

What happens when the bug or crash occurs?

the 3y3 button doesnt appear when you try to change your profil theme i have disadled and enable the plugin mulitple times but the issue is still there please fix this bug

What is the expected behaviour?

3y3 button not showing

How do you recreate this bug or crash?

i dont know

Errors

Replace this text with your crash-log.

Request Agreement

  • [X] I am using Discord Stable or trie...
surreal storm
limber skiff
#

do it

surreal storm
charred monolithBOT
#
auxtinn
[Vendicated/Vencord] Issue opened: #2395 [Bug] MessageLogger fails to log the second to last version of any message's edit history if the last edit made to the message matches the message'...

Discord Account

auxtinn

What happens when the bug or crash occurs?

MessageLogger fails to log the second to last version of any message's edit history if the last edit made to the message matches the message's original content.

What is the expected behaviour?

MessageLogger logs all versions of an edited message.

How do you recreate this bug or crash?

  1. Enable MessageLogger
  2. Send a message
  3. Edit the message to something different
  4. Edit the message back to what ...
limber skiff
#

lmao you had it as a draft alreaady

surreal storm
#

ye had it all pre-typed

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

woeful sable
#

I await the failure of vencord canary

rugged spire
#

It will explode eventually

woeful sable
#

like you will

rugged spire
#

It will be RoleColorEverywhere that breaks next

#

again

#

i bet

woeful sable
#

💥

austere talon
#

i await vencord deletion

woeful sable
#

soon ™️

rugged spire
#

did i ever push my branch that i wanna work on

#

Yop i am just stupid

jagged cloak
#

I await the explosion of Venchord

median rapids
#

:(

charred monolithBOT
glass jasper
charred monolithBOT
rugged spire
#

need

#

hm

charred monolithBOT
rugged spire
#

dont worry i will clean up before I make PR

charred monolithBOT
mortal fractal
#

y'all who do i have to pay to get this plugin updated and merged into the main thing i'm so serious. do i have to become a sponsor of vencord? like genuinely the only thing that's stopping me from making the switch from BD is the lack of this plugin

charred monolithBOT
spark pivot
rugged spire
#

Yop

#

Anyway I came here to show this off

Sqaaakoi-29-04-2024-17-11-37.png
mortal fractal
#

bumping highlight with this copypasta /s

charred monolithBOT
crude hearth
charred monolithBOT
charred monolithBOT
austere talon
#

satanic commit

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
livid heath
#

explode

charred monolithBOT
woeful sable
charred monolithBOT
charred monolithBOT
charred monolithBOT
limber skiff
#

I was in my bed thinking maybe it's good to add a log that shows our callback patch worked

charred monolithBOT
stark flint
limber skiff
#

WTFF

#

😰 😰 😰

stark flint
#

scary

charred monolithBOT
austere talon
charred monolithBOT
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
rugged spire
#

can I submit a link to my css snippets branch for feedback/testing from more people in #1032200195582197831?

charred monolithBOT
#
Sqaaakoi
[Vendicated/Vencord] Pull request opened: #2397 Cloud Sync: Stop discarding unknown root level values

This will merge local root object values over existing remote values that may not exist in the client.

For example with a change I am making to the core right now where I have added a cssSnippets object to the root, this is so that clients with this patch will not remove that from the cloud data if they don't support it.
This is also useful for people running their own fork that adds more to cloud sync like I have, so they don't accidentally delete that data when using the upstream buil...

rugged spire
#

i will merge into my branch for my project and watch it explode

#

yeah thats fine

Sqaaakoi-30-04-2024-11-07-56.png
#

why github want me to submit my barely working shitcode

Sqaaakoi-30-04-2024-11-14-56.png
spark pivot
#

like ik i just pushed that

mortal fractal
#

its amusing how convoluted vencord's webpack patching has become lol

austere talon
#

can't have it much simpler

limber skiff
mortal fractal
#

patching onChunksLoaded

limber skiff
#

what's bad about it

charred monolithBOT
limber skiff
#

just because it's not a simple push to the webpack modules anymore

#

it's done for a reason, not for nothing

mortal fractal
#

i never implied it was bad

limber skiff
#

hmm

mortal fractal
#

its just a neat thing i would never think to do because of primarily doing webpack interop

limber skiff
#

my bad then, I see convoluted as a bad thing, but that may be cuz I'm not a english speaker

mortal fractal
#

(figuratively) Complex, complicated, or intricate.

limber skiff
#

I see

limber skiff
charred monolithBOT
charred monolithBOT
#
pinetreemoonlight
[Vendicated/Vencord] New comment on pull request #694: feat(plugin): User Voice Show

Hey, hope it's fine that I'm posting here. I have a feature request about your awesome plugin:

  1. incorporate friend list voice activity icon
  2. incorporate individual user's DM panel right-hand side panel voice activity

These two features are present in BetterDiscord's VoiceActivity plugin by Neodymium: https://github.com/Neodymium7/BetterDiscordStuff/blob/main/VoiceActivity/VoiceActivity.plugin.js

Would this be possible?

Here are pics:
Friend list voice activity:
![Screenshot...

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
livid heath
#

update node ❎
force everyone to stay on old ass lts version ☑️

jagged cloak
#

i think version debates are stupid imo just update xd

#

unless you have a really pressing thing forcing you to stay then

#

which most of the time is the dev's own design fault

livid heath
#

oh wait

#

okay i had a brainfart

#

i thought with was 22+

#

wait

#

i mean assert

austere talon
#

yeah that pr is just updating old obsolete syntax to the new one

livid heath
#

i be a bit silly