archived-code-general

[safe ore]

the math breaks

Current code:

public void CalculateBulkSellPrice()
    {
        fakeBulkSellPrice = 0f;
        for (int i = 0; i < sellCorrect; i++)
        {
            upgradePastCost /= 1.15f;
        }
        upgradePastCost = Mathf.Round(upgradePastCost);
    }

[lean sail]

what is sellCorrect supposed to be? I think for the sell function you're gonna need the amount bought in total at one point so you can calculate how much to actually add by

nvm i guess thats just how much you sell

and upgradePastCost is the cost of the latest building?

[safe ore]

sellCorrect is finding the min value between 2 values to know exactly how much to sell

        sellCorrect = Mathf.Min(upgradesBought, bulkAmount);

[safe ore]

correct

https://pastebin.com/tw71GmdQ

the full script

[lean sail]

this code here doesnt change fakeBulkSellPrice

[safe ore]

yeah ignore that

its not used in that example

but with that example selling 1 at a time works

but not selling bulk amounts

[lean sail]

I think what you have with sellCorrect should work mathematically, i dont see any error as long as you add upgradePastCost, then divide it by 1.15

[safe ore]

so this here?

[lean sail]

fakeBulkSellPrice += upgradePastCost
before the division will calculate the correct result i believe

maybe its an issue of some other value being assigned incorrectly if that doesnt work

public void CalculateBulkSellPrice()
    {
        fakeBulkSellPrice = 0f;
        for (int i = 0; i < sellCorrect; i++)
        {
            fakeBulkSellPrice += upgradePastCost;
            upgradePastCost /= 1.15f;
        }
        upgradePastCost = Mathf.Round(upgradePastCost);
    }

just gonna write it out so theres no confusion

[safe ore]

yeah i got that, but still doesn't work, there seems to be an issue where when i press the button to change to the bulk amounts its changing the price

watch when the btns turn red im pressing the 1

and the value goes down?

all that the btns do is call the function to calculate the prices of all buildings

[upbeat flame]

hello guys, I am a noobie of Unity. how can i make the Text above the sprite, however I tried to change the z of the Text, it didn't work at all.

[lean sail]

im really unsure what im looking at, but id just run through debugs instead of looking at the UI. 1 issue might also happen since you're rounding the last cost. If the value rounds up, lets say u buy something for 2.8, then it rounds to 3. You now sell something for 3

[safe ore]

true

but the price shouldn't change when pressing the bulk btns lol

might have found the issue

[lean sail]

https://dotnetfiddle.net/VLtWYj
the math itself without rounding is fine

[safe ore]

not sure testing rn

[lean sail]

i had to do some weird casting stuff in there to use floats and rounding quickly but its still pretty much the same code

[safe ore]

yeah

[lean sail]

oh are you assigning upgradePastCost when buying? maybe thats the difference

it looks like you're assigning it to the bulk cost, and not the cost of 1 unit

[safe ore]

could you explain please?

a bit lost

[rigid island]

#💻┃unity-talk or #📲┃ui-ux
normally UI canvas is above world object

[civic folio]

Why don't compute shaders have/use the new keyword?

[obtuse sonnet]

the code is cut off

[pure cliff]

you wanting to support the entire keyboard?

[fervent furnace]

https://docs.unity3d.com/ScriptReference/Input-inputString.html
maybe this

[lean sail]

dear lord what is this font

[pure cliff]

Whats the use case? There may be a better way

[fervent furnace]

time complexity of using inputstring: O(number of key pressed) <=number of keys on keyboard

[pure cliff]

can you be specific to the "why are you capturing the entire keyboard" part of the problem space

I can pretty much only think of 2 use cases in video games for when you need the whole keyboard

1. Typing/spelling games
2. Emulating a sort of pseudo terminal in game where the user can type commands into it and stuff

so typically for those 2 use cases (what you wrote sounds like #1), I just have a hidden input text box they type into. They cant see the text box, but I just monitor the text box for changes and update my other visuals to match

I do the same for #2 as well actually

then you just add watching for keys for just the "interrupt" keys like Enter, Ctrl+C, pause/break, whatever you wanna actually watch for

[lean sail]

https://docs.unity3d.com/ScriptReference/Input-anyKey.html
is this what you want for "capturing the entire keyboard"?

[pure cliff]

Thats for other languages than C#/Unity but I expect the same principle applies.

1. Hidden input text box
2. Force them into edit mode on it, hidden cursor
3. Monitor whatever its version of "onchanged" is and utilize its new info

This also nicely automatically supports stuff like Ctrl V / Ctrl A / Ctrl C, shift-back, shift-forward, etc etc for tracking them editting it without having to rewrite all the code for how an input box works

[lean sail]

id probably also go with some hidden text box

[lucid valley]

Input.inputString

https://docs.unity3d.com/ScriptReference/Input-inputString.html

might be what you want

[pure cliff]

oh hot dawg thats nice

oh wait

its only ASCII, prolly not enough for some use cases

Probably XY problem

[lucid valley]

ah yeah, not sure what else there is tbh

[pure cliff]

Though I guess even for what I wrote, the inputString is no different, it just automatically handles backspace

I guess it also wont automatically handle ctrl+v and stuff like ctrl+c you'd have to rewrite too

yeah no Im still gonna go with hidden input box being easiest as it will substantially reduce you needing to re-invent... the input box

[lean sail]

honestly i cant imagine any case where you would want to do this. If you want any input at all, that case would be the user typing text. The user can type text into an input field

[pure cliff]

I guess if you wanna make a visualize for like, an in game keyboard and you wanted to highlight all keypresses

[lean sail]

hm i guess thats one very unique case lol

[pure cliff]

@frosty scroll only other thing I'd recommend is start digging into whatever GetKeyDown and friends do at a lower level.

You should be able to eventually find perhaps a lower level class that gives more direct access to the list of what keys are and aren't down.

[earnest gazelle]

It is ugly and bug prone.

but better than several monos in the execution order, yes.

[fervent furnace]

idk how unity detect key but there is a function in c or cpp call getch()
maybe you can write a native plugin to capture all the chars pressed in one frame in other thread, maybe it is low leveler than the engine

[lean sail]

How would this be bug prone?

[swift falcon]

Hey, I'm making a platformer and this is an example of how the rooms should be, they should always be placed randomly per level, can someone help me code the system or does anyone have a good tutorial on how I could do something like this? every room should have a prefabricated room that i created

[earnest gazelle]

It can be easy to be missed. missing reference exception.

Rename class name, etc.
Personally, as I mentioned I do not like to use execution order.

[lean sail]

While I do think itd be awkward to use, you shouldnt get any actual errors in your code. You just have scripts add to the delegate chain if they want access to a pre update, and remove themselves when they dont want it anymore, or on destroy if the manager isnt null. I'd also make it a singleton/DDOL for this purpose.
If the script is renamed that really shouldnt affect anything, since your IDE will update it in every file

The only bugs that pop up would be like if someone destroyed the instance, but in that same logic someone can easily fuck up your update loop by setting timescale to 0 or disabling an object they shouldnt

[prisma birch]

How can I change the active selection on a custom editor? For example, if a text area is actively selected, how can I clear that selection via script?

[solid herald]

Hi, I'm trying to disable and enable buttons. If I do playButton.interactable = false; it works well, but when I do playButton.interactable = true it doesnt work.

Here's the full code if needed
https://pastebin.com/1FrGBGvf

[fervent furnace]

have you logged it first to see if action==3 fired
and you can use switch case

[solid herald]

its triggered bc Destroy(quitWindow); works

(ill add the switch case)

[fervent furnace]

and you can set it active or unactive to avoid the external cost of destroying it

you may try to change the color of higher constract that indicate if the button interactable.. the code seems work

[steady moat]

https://www.youtube.com/watch?v=rI_y2GAlQFM

[low horizon]

    public static System.Type[] allWeaponUpgradeTypes { get; private set; }
    private static bool weaponUpgradeTypesInitialized = false;
    private void Awake()
    {
        if (!weaponUpgradeTypesInitialized)
        {
            weaponUpgradeTypesInitialized = true;
            allWeaponUpgradeTypes = System.AppDomain.CurrentDomain.GetAllDerivedTypes(typeof(WeaponUpgradeBase));
        }
    }

i am getting an array of classes deriving from WeaponUpgradeBase. But i cant cast from System.Type to WeaponUpgradeBase i guess. How can i call functions from this?

[solid herald]

it haves enough constract to indicate it, also it change to another scene, so if its interactable, it should change, but it doesnt

[steady moat]

They type is different than the actual class

What are you trying to do here ?

[low horizon]

im trying to get all weapon upgrades (classes deriving from upgrade base) then check if they can be used, if so randomly choose some of them and instantiate them

i guess i need actual class for that though

how can i get all classes deriving from base

[steady moat]

Usually, in the Unity ecosystem, you use prefabs.

[steady moat]

You can, however I think you would be better with prefabs.

You have list of prefabs, then you can iterate through them and see which one to actually instantiate.

[low horizon]

oh

how do i do that with prefabs though

isn't that usually scriptable objects

[steady moat]

Yes, that would be even better with SO.

[low horizon]

can i make prefabs be something other than gameobjects

guess i'll make them be ScriptableObjects rather than plain classes then

[hardy nova]

I have a fishing game where you draw a renderer line so when the fishs touches it they got dragged from the first of the line until the end, but i don't know how to do this I can't put a collider the player might draw something loopy

[steady moat]

    [SerializedField] private List<GameObject> allWeaponUpgradePrefabs
    private void Awake()
    {
       foreach(GameObject weaponPrefab in allWeaponUpgradePrefabs) 
       {
          if(weaponPrefab.TryGetComponent(out Weapon weapon) && weapon.IsUsable)
          {
            Instantiate(weapon);
            ...
          }
       }
    }

[steady moat]

The best would be to have SO per Weapon then use them to iterate through instead of the prefab.

[low horizon]

thanks for the help

[low horizon]

what about checking the distance between last point of the line and fishes and if its smaller than an amount they get dragged

i think colliders would work better though, why not use them

[fast belfry]

How would one go about creating a scrollable panel where elements inside of it can be dragged and dropped into any position? Without strict grid etc.
Do I need to write a custom script to resize content container based on content? (not sure if this is ui or code related question)

(I have already draggable components and scroll rect working)

[leaden ice]

definitely better done as an animation, or in-code animation of a child object of the main player object

the actual player object shouldn't rotate

[winged mortar]

I assume he means that you rotate the spriterenderer, which should be a childobject of your player object

[leaden ice]

do to a smooth rotation it's as simple as:

void Update() {
  if (isFlipping) {
    transform.Rotate(0, 0, Time.deltaTime * speed);
  }
}```

[mellow barn]

Documentation of terrain clipping, as well as my terrain and capsule collision settings. Any idea what might be going wrong?

[leaden ice]

use continuous collision detection on your player

(not a code question btw)

[thick socket]

for dungeon generation like "Binding of Isaac" I saw something that basically said you make all the rooms in different scenes, and load multiple/many scenes at once.

Is this the best way to do that or should I be doing it some other way?

video was a bit outdated so not sure if thats bad practice now

[mellow barn]

Oh shoot. Terrain? Physics?

[stark sinew]

You don't have to use different Scenes for each Room, that probably doesn't scale too well when you have 100s of them.

I'd say, each Room should be a Prefab, that's enough.

Each Room could have a (flexible) Amount of AnchorPoints (for example, empty GameObjects) where its allowed to spawn a new Room upon completing the current one.

[thick socket]

So when the game "starts" would you spawn in all the prefabs offset so you literally move between rooms? Or when moving between rooms you just "spawnin" a new prefab where you are and hide the old one?

[stark sinew]

In case of Binding of Isaac, you only see one room at a time.

When the Game starts, you only create one Room, the current one.

Then, when changing the Room, you could just transition into a Blackscreen, then deactivate the current Room and create a new one, and then fade out the Blackscreen

You only need a single Room to be active at a time.

I'd still recommend doing ObjectPooling on them, not plain Instantiate/Destroy

[thick socket]

Right

Gotcha

And then when moving to a new room you disable the "old rooms preset" and spawnin the new one?

Or just spawn them all to start and disable them

[mellow barn]

h just what channel I should be in
Also re: continuous detection, it still clips through when there's a sufficiently steep slope

[knotty sun]

I actually prefer your original idea of using multiple scenes, it's more performant and more flexible

[stark sinew]

Yes, sure, having 100 Scenes for 100 Rooms is way more performant and flexible then having a single scene with a single dynamic room, sounds about right

It of course heavily depends on your project, but if it's 1:1 Binding of Isaac style, a single scene is enough

[thick socket]

Good to know...guess the youtube series is pretty solid then, didnt realize you could just like spawnin multiple scenes at once

Always thought they would clash even if everything in the scene was offset

[knotty sun]

scenes can be loaded async, prefabs cannot

[thick socket]

Why is loading async good? Kept seeing stuff about it but couldnt understand it

Tried to read about it but it didnt really help

[stark sinew]

Prefabs can be pooled, that's fine enough if there's only ONE active at a time, also the rooms aren't that big (still comparing to Binding of Isaac here)

[knotty sun]

because it happens in the background so the user does not notice it, no lag

[stark sinew]

The user doesn't notice anyways because the transition happens within a Loading Screen

Let's say each Room is just 8x16 Tiles and there is only ONE active at a time, Scenes seem totally overkill

[thick socket]

Wouldnt the user still be waiting for it to load? Or you always are loading them in advance so they dont have to wait?

[knotty sun]

you would load the one(s) you want in advance but keep them in the background until needed

[thick socket]

Interesting thanks! Hopefully I can find a good youtube video about that

[stark sinew]

@thick socket

I'd advise you to try both approaches on your own and see what fits better in terms of performance, presentation and workflow, after all there are an unlimited number of ways to accomplish this

[knotty sun]

@stark sinew 'The user doesn't notice anyways because the transition happens within a Loading Screen'
Do you realise what an oxymoron this statement is?

[stark sinew]

Did you play binding of Isaac and do you know what an oxymoron is?

Also, we're not here to argue about each other's ideas, correct? At least not in the way we currently do.

I mainly do mobile stuff, and I'd never ever want to have 100 Scenes in a Mobile Game.

The actual question could be, is asynchronous loading of a scene in addition to unloading the current one really faster then activating and deactivating an already pooled GameObject? I can't answer this.

[thick socket]

I mean, while binding of isaac has loading screens I more meant the style of rooms so no loading screens is great 😄

[thick socket]

How would you be able to pool it?

[stark sinew]

@thick socket

In short

Your Game could (should) have multiple States managed by a StateMachine.

The first state could (should) be an Initialization state in which you initialize everything you need, Localization, SaveData etc and do your ObjectPooling

After that, those things can be used by the other States

ObjectPooling basically means you create your frequently used Objects on Startup and disable them, once you need them you can activate and reposition them, when you're done with it you deactivate it again, very simple explanation, it can become a quite in-depth topic.

"Saving" previous for later reuse could be, for example, be done by assigning a unique ID for each room, and activate the corresponding GameObject

[thick socket]

I guess I more mean what about the prefabs could be pooled since you need to save "previous rooms"

So I know about how object pooling works...just wasnt sure what about the rooms/prefabs could be pooled or would be worth pooling

[stark sinew]

Even if you'd only need a single instance of each room, I'd still pool them, they could be quite detailed and an Instantiation while playing the game can very well give you a noticable performance hit.

You might not have multiple instances on the screen at once, but you very well might reuse those single instances within a single playsession, why would you Instantiate/Destroy the same object over and over if you can reuse the same one instead.

My game has only a single player object, but I still don't destroy and instantiate new instances of it for every Gameplay, I just reset the existing one

[knotty sun]

object pooling is only useful when you have multiples of the same object, in your use case I doubt you have multiples of the same room

[thick socket]

Even if I did I would need to fully save prev room incase player went back

[stark sinew]

You would only need to save the ID of that room.

Unless you want to store it's State (enemies killed etc), if that's the case then you should separate the State Data from the actual Room, because you might want to use the same Room again but in a different State

Let's say we have this order

Room 1 - done 
Room 2 - done
Room 3 - Player here
Room 1 - Next 

You don't want to have the next Room 1 to share the same data as the first Room 1 , but preferably you would still want to use the same GameObject for it

You could have an Initialization(RoomData roomData) method on those that you call when you're activating the Room, either passing it a previously saved one or a fresh one

I'd recommend to just find a temporary solution for your situation, experiment a bit, check out some resources, you'll get many different opinions and approaches in here that may prevent you from actually getting it done in the first place, everybody has their own preferences 🙂

[thick socket]

Gotcha thanks

Didnt realize I should be saving the states outside of the room

[stark sinew]

Try to separate Data and the thing that's working on that Data as much as possible, it'll seem tedious at first, but when you get used to it it's quite useful. Just my opinion!

For mapping the actual rooms to some IDs, you could for example use a ScriptableObject and have your RoomSpawner know about those, so it could take a random one of those ScriptableObjects, instantiate the Prefab and store/assign the corresponding ID

[thick socket]

@stark sinew is this how you would recommend doing playerinput?

[thick socket]

Im a big fan of SOs 😄

[stark sinew]

Let me check.. but tbh, I'm probably terrible with my Input practices 😅

I prefer an event based approach to input, I usually either have an InputProvider component that's reusable by components, firing stuff like OnSomeButtonPressed and OnSomeButtonReleased or a single InputService component that basically does the same but is globally accessible

[thick socket]

😄

You seem to have a lot of knowledge so appreciate the help

Will see if I end up doing the scenes method or prefabs

Youtube series uses scenes so Ill likely follow that but will see 🙂

Good things to know for the future reguardless

[stark sinew]

I'd recommend following the tutorial first, and when you're done with it and understand why and when it does what, you're ready to experiment with your own implementation of change the existing one!

Trying to push some custom code into a tutorial may lead to problems when trying to follow it further along

One thing that'll probably be helpful forever (not for your current situation, but in general), experiment with (different) StateMachine architectures! Feels like cheating for a lot of stuff 😂

Also, as a final word, I'd say that both the Scene and the Prefab approaches are totally valid and won't differ too much in terms of presentation to the Player, you should experiment with both and decide on your own what's good/bad about either of those 🙂

[thick socket]

Yeah I learned that following tutorial for one of my classes awhile ago

Better to fully follow and then try and change after lol

[stark sinew]

You're probably having multiple classes named BeanMovement in the same Namespace.

Check if you accidently renamed a file without renaming the actual class inside

[tawny elk]

Posting code

📃 Large Code Blocks
Large code blocks should be posted as links to services like:
https://gdl.space/, https://paste.ofcode.org/, https://hatebin.com/
https://paste.myst.rs/, https://hastebin.com/

📃 Inline Code
Surround code with three backquotes. Not quotation marks.
To get C# formatting the first line should only contain cs or csharp.
Add a comment with a line number if there is an error message.
```cs
// Your code here
```
Do not share screenshots of code unless requested.

[stark sinew]

It's not about the code, it's about how your Files and Classes are named

You're welcome 🤗

[civic carbon]

Hey do you know if there is a smart way to collect the current collisions on call from a trigger Collider ?

Collider[] colliders = Physics.OverlapCollider(hitboxCollider, damageableLayer);

[rigid island]

what you tryina do? also isn't overlapcollider a physics 2D function

[leaden ice]

you could do a query like that, or you could just keep a list or hashset of colliders

populate it in OnTriggerEnter and Exit

HashSet<Collider> currentColliders = new();

void OnTriggerEnter(Collider other) {
  currentColliders.Add(other);
}

void OnTriggetExit(Collider other) {
  currentColliders.Remove(other);
}```

for example^

[civic carbon]

sadly yes it is only for 2D 😦

[civic carbon]

yeah I was just wondering if there is a simpler solution, because I only need to check it once.

[leaden ice]

this is very simple

you can, as mentioned, also uise a physics query as per your example

[spring creek]

There are other overlap methods for 3D

https://docs.unity3d.com/ScriptReference/Physics.OverlapSphere.html

[thick socket]

https://media.discordapp.net/attachments/497874004401586176/936716538818482278/code.gif

[thick socket]

How can you iterate through a hashset since its unordered

[halcyon tusk]

hey ,idk y im getting thsi error text

im trying to make a UI with sliders

this is my codes

but i dont thin its the code issue

im not sure why im getting this error message

[winged mortar]

No line numbers please !code

[tawny elk]

Posting code

📃 Large Code Blocks
Large code blocks should be posted as links to services like:
https://gdl.space/, https://paste.ofcode.org/, https://hatebin.com/
https://paste.myst.rs/, https://hastebin.com/

📃 Inline Code
Surround code with three backquotes. Not quotation marks.
To get C# formatting the first line should only contain cs or csharp.
Add a comment with a line number if there is an error message.
```cs
// Your code here
```
Do not share screenshots of code unless requested.

[halcyon tusk]

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class mainUI : MonoBehaviour
{
public Slider hp_slider;
public Slider ammo_slider;

private gun gun_script;
private player player_script;

void Start()
{
    gun_script = GameObject.Find("gun").GetComponent<gun>();
    player_script = GameObject.Find("character").GetComponent<player>();
    
    
    hp_slider.maxValue = player_script.max_hp;
    ammo_slider.maxValue = gun_script.max_ammo;
}

void Update()
{
  
    hp_slider.value = player_script.current_hp;
    ammo_slider.value = gun_script.current_ammo;
}

}

[winged mortar]

Also your IDE doesn't look to be configured

[halcyon tusk]

ois this better?

[winged mortar]

!ide

[tawny elk]

💡 IDE Configuration

If your IDE is not autocompleting code
or underlining errors, please configure it:

• Visual Studio (Installed via Unity Hub)
• Visual Studio (Installed manually)

• VS Code*
• JetBrains Rider
• Other/None

*VS Code's debugger plugin is unsupported.
We recommend using VS or Rider instead.

[thick socket]

https://media.discordapp.net/attachments/497874004401586176/936716538818482278/code.gif

[halcyon tusk]

ok

[winged mortar]

Worse

[halcyon tusk]

using System.Collections;
using System.Collections.Generic;
using UnityEngine;
using UnityEngine.UI;

public class mainUI : MonoBehaviour
{
    public Slider hp_slider;
    public Slider ammo_slider;

    private gun gun_script;
    private player player_script;

    void Start()
    {
        gun_script = GameObject.Find("gun").GetComponent<gun>();
        player_script = GameObject.Find("character").GetComponent<player>();
        
        
        hp_slider.maxValue = player_script.max_hp;
        ammo_slider.maxValue = gun_script.max_ammo;
    }

    void Update()
    {
      
        hp_slider.value = player_script.current_hp;
        ammo_slider.value = gun_script.current_ammo;
    }
}
```cs

[winged mortar]

Just use the paste websites for this one

[halcyon tusk]

thx

[winged mortar]

Looks like I'm still going to count lines xD

[thick socket]

Np... you didn't quite get it lol

[halcyon tusk]

mb

[halcyon tusk]

oh

[thick socket]

To start then end with ```

[halcyon tusk]

ok

i did it but it didnt show line

[leaden ice]

foreach

[stark sinew]

@halcyon tusk

You either forgot to assign the sliders in the Inspector, or your GameObject.Find doesn't find anything

Use Debug.Log to find out if your player or gun is missing

[winged mortar]

Use one of the websites so we can see linenumbers please

[leaden ice]

foreach (Transform t in mySet)```

[halcyon tusk]

ok, let me check

[thick socket]

Sorry wasnt clear...how can the foreach do that if its unordered?

[winged mortar]

You can still iterate over an unordered list

[thick socket]

Since foreach is just a fancy for loop right?

[dire crown]

Why is

    float dt = 1.0/(B+A+1);

not the same as

    float3 cro = normalize(float3(B,1,A));
    float dt = dot(cro, float3(0,1,0));

[winged mortar]

There's just no guarantee that the list is in a specific order

[rigid island]

dont crosspost

[leaden ice]

internally there's an array or something

https://github.com/microsoft/referencesource/blob/51cf7850defa8a17d815b4700b67116e3fa283c2/System.Core/System/Collections/Generic/HashSet.cs#L1547

[thick socket]

Ah Gotcha, thought you couldn't iterate through with a for loop

[dire crown]

👍

[thick socket]

So thus couldn't with a foreach 😄

[winged mortar]

Foreach uses an enumerator which is an abstraction

So it is different from normal for loop

But the implementation of that abstraction could still be that it uses indicrs

An example would be a linkedlist, which doesn't have indices but are just nodes linked together with a pointer to the next node

The enumerator would return the next node everytime you call movenext

But you can access a specific element using an index

[astral relic]

hello, how do i make the camera "view" fits a certain bounds? (im trying to screencapture a character, i wrote the screencapture code, i got the character bounds, but now i need to know how to make the camera view exactly fits the character bounds, so that when i call screenCapture() it captures it perfectly (and not other objects with it)

[halcyon tusk]

i used ```cs
if (gun_script == null)
{
Debug.LogError("Gun not found!");
}

    if (player_script == null)
    {
        Debug.LogError("Player not found!");
    }

to check if the script are found, are they were found sicne they didnt send the message

also the slider's gameobject are assign

so im not too sure whats wrong

[formal light]

Check if the Object is the same name in Hierarchy

[stark sinew]

Already sorted this out by checking for Null, the objects are found, the Debug.Logs don't get called (apparently)

[tawny mountain]

Idk if someone here can help me , I made a barcode scanner in unity and at first it would display my camera feed rotated -90° , I fixed that with code so camera feed displays correctly but now when I can a barcode , the barcode has to be rotated 90° ( it will only scan sideways )..

[halcyon tusk]

also once i remove the

hp_slider.maxValue = player_script.max_hp;
        ammo_slider.maxValue = gun_script.max_ammo;
hp_slider.value = player_script.current_hp;
        ammo_slider.value = gun_script.current_ammo;

the error doesnt show

so i think it might be the slider that cause the issue

[stark sinew]

If you double click on the error messages, where do they take you?

[tawny mountain]

My script
https://pastebin.com/Zfx0VBC5

[halcyon tusk]

im sorry it was that

it was the gun one

the player was fine

but i think it might be because i used a asset gun

so i change the name of the gun

and now it work

[stark sinew]

No need to be sorry!

I'd recommend to not rely on hard-coded string lookups in general, this will lead to problems if you, for example, decide to rename something

You could expose the Strings your searching for in the Inspector or use a static read-only for it, or you could change the architecture a little bit to look for the Component itself

[halcyon tusk]

im not too sure wat u mean in the second line

[stark sinew]

GameObject.Find("Blabla")

static readonly string BLABLA = "the name"
GameObject.Find(BLABLA)

[SerializeField] string blabla
GameObject.Find(blabla)

FindObjectOfType<gun>()

examples

[halcyon tusk]

oh

[rocky jackal]

why do i get this error everytime i lock my pc. when i come back unity shows this and dies

[halcyon tusk]

so is it better to use [SerializeField] rather than gameobject.find

[stark sinew]

Does this happen in an empty project as well?

[stark sinew]

The issue is more about hard-coding the string then the method you're using for lookup, imagine you accidently rename the Gun or Player Objects and getting an Error because you need to change it in code as well

[halcyon tusk]

oh that make sense

my project rn it rather small, so it will be a eas fix, but i will rememebr that later on

thank u

[formal light]

 GameObject checkBox = Physics.CheckBox(boxPosition.position, boxSize);

Issue: Cannot implicitly convert type 'bool' to 'UnityEngine.GameObject'

how to fix this

[leaden ice]

CheckBox returns a booll

you can't assign a bool to a GameObject variable

bool hitSomething = Physics.CheckBox(boxPosition.position, boxSize); would be correct

[rocky jackal]

i have not tried that

[formal light]

I fix it

        Collider[] colliders = Physics.OverlapBox(boxPosition.position, boxSize);
        foreach (Collider collider in colliders)
        {
            GameObject obj = collider.gameObject;
        }

is work now

[arctic steeple]

does anyone know how to turn off whatever this is

it appeared yesterday when i restarted my computer

[stark sinew]

@rocky jackal you should! First thing would be to find out if it's an error with your project or with your device, or do a quick Google search

[leaden ice]

define "this"?

[arctic steeple]

the grey suggestion stuff

very annoying

i don't know why it appeared

[leaden ice]

looks like AI based suggestion stuff

should be in your settings for your IDE

[arctic steeple]

i was hoping someone would know which setting it was

at first i thought it was autofill, then i thought it was suggestions

[leaden ice]

search for AI in settings

[arctic steeple]

it was off to begin with

oh wait thank you

i found the perpetrator

i don't remember downloading this

dang AI thinking i don't know how to code D:<

[rigid island]

this is included inside C# DevKit

VSC intellicode not as good at VS community intellicode

[rocky jackal]

okay

thanks

[plain nebula]

need help with photon.
Im trying to run c PhotonNetwork.InstantiateRoomObject("flamethrower", playerPos, playerQuat);
the prefab "flamethrower" isnt in the Resources folder, how can i load it?

[rigid island]

#archived-networking

[plain nebula]

thanks

[dapper surge]

Hey I'm new to programming so I find it challenging at times. I have a problem and I would love a solution can y'all help me?

Problem: I have a game where enemies follow you and when they are close enough they attack. Is there a way to code that whenever they attack they perform a specific animation ( attack animation)?

[indigo arrow]

So my ui canvas is set to Screen Space - Camera

and i am trying to set an image's transform to my mouse's position

but it keeps getting set to absurd numbers like 7000 on the z

anyone got an idea

using System.Collections.Generic;
using UnityEngine;

public class Crosshair : MonoBehaviour
{
    void Update()
    {
        Cursor.visible = false;
        transform.position = Input.mousePosition;
    }
}

any ideas?

[untold shard]

hello I'm something new, is there a way to imitate the grab, drop and throw objects from half life 2?

[sleek bough]

General questions go in #💻┃unity-talk

Sorry there, didn't check autocomplete, was wrong channel

[rigid island]

you mean the gravity cannon

[spring creek]

Whenever you call the attack method, use one of the animator methods like SetBool, SetTrigger or just Play to cause the animation.

Look into how the animator works to understand what I said better

[sleek bough]

You can tag them in the correct channel if you want to answer

[rigid island]

okie will do! thought they wanted to know how to code it

[sleek bough]

It's much simpler to do with hinges and/or spring joints

[rigid island]

i think rectTransform.anchoredPosition = Input.mousePosition;

[swift falcon]

can somone help me with something?

[rigid island]

https://dontasktoask.com

[swift falcon]

ok

[indigo arrow]

Assets\Crosshair.cs(10,9): error CS0103: The name 'rectTransform' does not exist in the current context

[rigid island]

you have to make a reference to Rect Transform component

private RectTransform rectTransform

void Awake(){
rectTransform = (RectTransform)transform;

[indigo arrow]

using System.Collections.Generic;
using UnityEngine;

public class Crosshair : MonoBehaviour
{
    RectTransform rectTransform;
    void Start()
    {
        rectTransform = GetComponent<RectTransform>();
    }

    void Update()
    {
        Cursor.visible = false;
        rectTransform.anchoredPosition = Input.mousePosition; 
    }
}

it doesn't move it

at all

[swift falcon]

So is not particulary about coding but i don t know who to ask so i made a tilemap and after you make the tilemap you have to go to your sprites and put the pixels you have, on the sprites but i have 16x17 tiles and if i put 17 is space and if i put 16 they go into each other i have to remake the sprite or i can make it somehow.

[rigid island]

it's not a code question it should go in #🖼️┃2d-tools

or #💻┃unity-talk

[swift falcon]

ok sorry

[rigid island]

also I think you are asking about PPU sizes ye

[sleek bough]

You are just moving the anchor there, I think.
Also you can cast transform as RectTransform, don't have to get it as component

[indigo arrow]

then what can i do

[sleek bough]

UI space has consideration depending on canvas mode, types of anchor. If you want to keep it simple and place a sprite in world space under mouse like you initially tried, you need to convert mouse position from screen space to world space. https://docs.unity3d.com/ScriptReference/Camera.ScreenToWorldPoint.html

[indigo arrow]

that isnt what i am trying to do. i am setting a sprite in the canvas space to my mouse position, which would be 1 for 1

e.g (1920, 1080) with my mouse would equal (1920, 1080) on my sprite

image, not sprite*

[sleek bough]

You are not converting anything here

[grave parrot]

I want to make a game with 4 different cameras, 1 in each corner, how would I do that

[indigo arrow]

cinemachine would be your best bet

[grave parrot]

Does it have something in it already for that

[rigid island]

#💻┃unity-talk

[indigo arrow]

and i do not want to. I want to set an image in the canvas to my mouse's position on the screen, not in the world

[sleek bough]

Also check your input. https://docs.unity3d.com/ScriptReference/Input-mousePosition.html is a normalized range 0-1

[indigo arrow]

but it isn't

it returns your mouse's position in screen coordinates

/vector

[sleek bough]

ah nevermind, when when converted to screen space

Another thing to consider if you insist in working inside UI, make sure you are not using reference resolution. Because local Canvas position will be using it

[rigid island]

btw is your camera in Orthographic view ?

[sleek bough]

You should post your complete question as well, with all detail what you are trying to do.

[indigo arrow]

yes

[dapper surge]

Thanks

[rigid island]

yeah idk
afaik
rectT.anchoredPosition = Input.mousePosition;

should work but idk why its not, it adds offset for me rn.. i forgot what I did last time xD

[untold shard]

Nope

The player only

[indigo arrow]

Nevermind

fixed it with some help of ai

this works:

using System.Collections.Generic;
using UnityEngine;

public class Crosshair : MonoBehaviour
{
    RectTransform rectTransform;
    void Start()
    {
        rectTransform = GetComponent<RectTransform>();
    }

    void Update()
    {
        Cursor.visible = false;

        Vector3 screenPoint = Input.mousePosition;
        transform.position = Camera.main.ScreenToWorldPoint(screenPoint);
    }
}

minus the start function

dont need that

[rigid island]

#archived-code-general message

you were told to do this already though and you argued it 🤷

[indigo arrow]

ye my bad

i misunderstood what they meant

[indigo arrow]

works

thanks mate

[rigid island]

move this conversation to #💻┃unity-talk

[sleek bough]

RectTransform rectTransform = (RectTransform)transform; to get rect transform

[devout solstice]

So I have a loadasset script right to load assets, and im referencing it in another script so I can load a object from assets, how can I get the gameobject it spawns in this other script so I can set its spawn position

[rigid island]

which method is you using to spawn it in/

if it's Instantiate you can already input the position in those params

[devout solstice]

Thats the load asset script

Thats where im referencing it

[rigid island]

the function returns you that object

[devout solstice]

oh shit

im retarded lmao

[modern jewel]

Anyone know why my perlin noise is not consistant across terrain neighbors?

    private float[,] GenerateHeights(Vector3 position)
    {
        float[,] heights = new float[terrainSize, terrainSize];

        // This factor helps in controlling the frequency of the noise
        float frequencyFactor = scale / gridSize / terrainSize;
        for (int x = 0; x < terrainSize; x++)
        {
            float xCoord = (position.x * terrainSize + x) / scale;
            for (int y = 0; y < terrainSize; y++)
            {
                float yCoord = (position.z * terrainSize + y) / scale;
                heights[x, y] = Mathf.PerlinNoise(xCoord, yCoord);
            }
        }

        return heights;
    }```

[sleek bough]

Don't use ableist slurs, please.

[devout solstice]

Do I even have that script right

Will this load a object from assets and put it into the hiearchy?

[rigid island]

no

[devout solstice]

shit

[rigid island]

you would need to instantiate it

[devout solstice]

could you tell me how to do that?

[rigid island]

https://docs.unity3d.com/ScriptReference/Object.Instantiate.html

[devout solstice]

thanks

[modern jewel]

I just don't get it, because the noise should be continuous over these terrains:

[devout solstice]

I tried setting the parent of the loaded asset and it said its disable to prevent data corruption

its also not setting the position right so it looks like im not referencing the loaded object right

[rigid island]

what are you trying to do and what is the point of even going through all this trouble for Resource method? it's almost useless cause it only works in the editor anyway so you mind as well make references to prefabs

[devout solstice]

im trying to spawn a object from the assets, set its parent and position

[rigid island]

chances are you are trying to modify the one from resources and not the instance of it

[devout solstice]

yea prob

[rigid island]

yeah

so you ignored the Instantiate part ig

[rigid island]

no thats not where it goes at all

[devout solstice]

oh

[rigid island]

and ur still returning the asset from resources

[devout solstice]

Like that?

[rigid island]

var objectInstance = Instantiate(LoadObject.Loadassset(assetName), position, Quaternion.identity, parentGoesHere)

[devout solstice]

ohh

[pure cliff]

Take a look at what the Instantiate method does

[devout solstice]

haha it works

i think i finally finished my script

or system

its multiple scripts

[grave parrot]

wait

im stupid

!code

[tawny elk]

Posting code

📃 Large Code Blocks
Large code blocks should be posted as links to services like:
https://gdl.space/, https://paste.ofcode.org/, https://hatebin.com/
https://paste.myst.rs/, https://hastebin.com/

📃 Inline Code
Surround code with three backquotes. Not quotation marks.
To get C# formatting the first line should only contain cs or csharp.
Add a comment with a line number if there is an error message.
```cs
// Your code here
```
Do not share screenshots of code unless requested.

[grave parrot]

https://gdl.space/nihabopule.cpp
I'm not sure why this isn't working, I feel like something is being used by all 4 players in the code that each player needs its own version of, but I don't know what.

[modern jewel]

Are terrain heightmaps 0,0 in the bottom left corner and size,size in the upper right?

lol, heightmaps are indexed y,x

[untold shard]

Ok

[willow minnow]

yo. can someone help me, i have this cat ai, and most of the functions are there, but im trying to add the Pathfinding thing, but after i did, the cat wouldnt move, is there something wrong with the code, or is the Nav Mesh
(the functions of the cat so far are, follow, stop at a certain distance from the player, and run away from the player if the player get too close to the cat)

using UnityEngine;
using UnityEngine.AI;

public class CatController : MonoBehaviour
{
    public Transform player;
    public float stopDistance = 2f;
    public float startFollowingDistance = 4f;
    public float runAwayDistance = 1f;
    public float pathfindingDistance = 6f;
    public LayerMask obstacleLayer;

    private bool isRunningAway = false;
    private NavMeshAgent navMeshAgent;

    private void Start()
    {
        navMeshAgent = GetComponent<NavMeshAgent>();
        navMeshAgent.autoBraking = false;
    }

    private void Update()
    {
        float distanceToPlayer = Vector3.Distance(transform.position, player.position);

        if (isRunningAway)
        {
            if (distanceToPlayer > runAwayDistance)
            {
                isRunningAway = false;
            }
        }
        else
        {
            if (distanceToPlayer <= stopDistance)
            {
                isRunningAway = true;
            }
            else if (distanceToPlayer >= startFollowingDistance)
            {
                isRunningAway = false;
            }
        }

        if (isRunningAway)
        {
            Vector3 runDirection = transform.position - player.position;
            Vector3 runPosition = transform.position + runDirection.normalized * Time.deltaTime;
            MoveTo(runPosition);
        }
        else if (distanceToPlayer <= pathfindingDistance)
        {
            MoveTo(player.position);
        }
        else
        {
            navMeshAgent.ResetPath(); // Stop moving
        }
    }

    private void MoveTo(Vector3 destination)
    {
        if (navMeshAgent.enabled)
        {
            navMeshAgent.SetDestination(destination);
        }
    }
}

[sleek bough]

@cunning meteor Don't cross-post. Not a code question. Not a Unity question even?

[cunning meteor]

you code in visual studio

[sleek bough]

For unrelated tech questions #497872469911404564

[modern jewel]

Anyone want to look at my terrain generator script and see why the terrainlayers aren't being applied and all I get is glorious pink?

    private TerrainData GenerateTerrainData(Vector3 position) {
        TerrainData terrainData = new TerrainData();
        terrainData.heightmapResolution = terrainSize + 1;
        terrainData.size = new Vector3(terrainSize, 10, terrainSize);
        terrainData.SetHeights(0, 0, GenerateHeights(position));
        terrainData.terrainLayers = terrainLayers;

        // Create an alphamap based on the heights and apply the terrain layers
        float[,,] alphamap = new float[terrainSize, terrainSize, terrainLayers.Length];
        float[,] heights = terrainData.GetHeights(0, 0, terrainSize, terrainSize);

        // Initialize alphamap to zeros
        for (int i = 0; i < terrainSize; i++) {
            for (int j = 0; j < terrainSize; j++) {
                for (int layer = 0; layer < terrainLayers.Length; layer++) {
                    alphamap[i, j, layer] = 0;
                }
            }
        }

        for (int y = 0; y < terrainSize; y++) {
            for (int x = 0; x < terrainSize; x++) {
                float height = heights[x, y];

                // Determine the layer based on height (modify as needed)
                int layerIndex = 0;
                if (height < 0.3f) layerIndex = 0; // First layer
                else if (height < 0.6f) layerIndex = 1; // Second layer
                else layerIndex = 2; // Third layer

                // Check for index out of range
                if (layerIndex < terrainLayers.Length) {
                    alphamap[x, y, layerIndex] = 1;
                }
            }
        }
        terrainData.SetAlphamaps(0, 0, alphamap);
        return terrainData;
    }```

[onyx lark]

I'm using the new Unity Extension for VS Code, but it doesn't seem to be linting any of my errors. I've tried uninstalling and reinstalling VS Code, the extension, and the Visual Studio Editor 2.0 package but no luck. I've also tried regenerating the project files. Any ideas what I could do to fix this?

[leaden ice]

!vscode

[tawny elk]

Visual Studio Code guide

If your IDE is not underlining errors in red or autocompleting code,
please configure it using the link below:

https://on.unity.com/vscode

[onyx lark]

I've followed all these steps without any luck.

[rigid island]

show which version you installed from package manager

[leaden ice]

You sure you followed all of them?

[rigid island]

did you restart VSCode after you installed and regenerated

[leaden ice]

Not just the first part?

[willow minnow]

Did you launch the Installer, click modify, and install the unity package?

[modern jewel]

Hmm, I tried to load that VSC Unity plugin and it says my csproj (created by Unity) is in the wrong format: is in unsupported format (for example, a traditional .Net Framework project). It need be converted to new SDK style to work in C# Dev Kit.

[rigid island]

thats VS not VSCode

[willow minnow]

oh whoops, i read studio

mah bad

[rigid island]

you need to install the new Package inside package manager

[rigid island]

https://youtu.be/4KhjzVHQvrg?t=39

[onyx lark]

Yes, I followed all of them.

[onyx lark]

Yes, I tried restarting it after installing and regenerating.

[modern jewel]

You rock, that got it working perfectly. I was just ignoring the VSC errors and using Unity for errors and warns.

[rigid island]

glad it was of help

[stone gust]

idk if this is the right place to ask because this seems to just be a unity editor problem but something really weird is going on with this collider:

im not able to change the Y offset because the center always moves in the opposite direction

ive disabled all the scripts and stuff on this object

[rigid island]

some step you def missed out somewhere

[leaden ice]

Press Z. Make sure your tool handle position is set to Pivot not Center

[stone gust]

im trying to change the offset in a script and its doing this same thing

i was just trying to narrow it down

it even does it in the editor

changed it to pivot and theres no difference

[leaden ice]

Does this object have a parent with negative scale?

Or does it have negative scale itself

[stone gust]

it doesnt have any parents, but this is its transform

could the rotation do it?

[leaden ice]

Or is it rotated

Yeah it's rotated 90 degrees

On the x axis

Set that to 0

[stone gust]

it needed to be rotated to face the camera properly

[leaden ice]

Put the mesh renderer on a child object

And rotate that

Or fix your mesh/ export it properly in blender

[stone gust]

alright ill try that

the mesh is just a plane im using a shader to render everything

[leaden ice]

Why not just use Unity's Quad mesh then?

It'll be oriented properly

[stone gust]

oh that would work yeah

i didnt want to do that because i have to scale it up a ton but thats less annoying than dealing with this

thanks

[leaden ice]

In either case putting the mesh renderer on a child object will make your life easier

[stone gust]

alright ill keep that in mind

[tawny elk]

Posting code

📃 Large Code Blocks
Large code blocks should be posted as links to services like:
https://gdl.space/, https://paste.ofcode.org/, https://hatebin.com/
https://paste.myst.rs/, https://hastebin.com/

📃 Inline Code
Surround code with three backquotes. Not quotation marks.
To get C# formatting the first line should only contain cs or csharp.
Add a comment with a line number if there is an error message.
```cs
// Your code here
```
Do not share screenshots of code unless requested.

[leaden ice]

2.3 not 2,3

C# uses . for decimal separator

You also need an f

2.3f

[rigid island]

#archived-shaders

[onyx lark]

I went through all the steps, and it's still not working right. Some things work, like it suggesting Start().

But when I make typos, it doesn't underline them in red.

[leaden ice]

I mean VSCode integration is known to be kinda poor

[knotty sun]

spot the difference

[leaden ice]

It's not really supported

[rigid island]

screenshot external tools in Unity
and do you have messages in the Output in VSC panel?

[onyx lark]

No messages.

[rigid island]

well that is weird then, it should either tell you it loaded C# plugin or says errors with csproj

[primal wind]

The new extension actually works great, at least most of the time since it literally just came out

[rigid island]

eh I wouldn't say great, the intellicode is still garbage

I type Serial it writes [SerialSerializeField] for me

[primal wind]

Yeah its a bit buggy

[rigid island]

still needs work but the process is less butt hurting than before

[primal wind]

I think it's supposed to use Intellisense (the one from VS)

[rigid island]

the whole disabling modern net bullshit

glad all that is gone

its not 1.0 yet so there is probably still bugs

[onyx lark]

I see in your video you have Output set to "Projects". On mine, I don't have the option to set it to "Projects".

[rigid island]

idk if that part is important, unless until its connected

btw do you have .NET installed ?

[onyx lark]

Like this?

[rigid island]

nah the one from the website

https://dotnet.microsoft.com/en-us/download/dotnet?cid=getdotnetcorecli

i would not use extension for that

[onyx lark]

I'm not sure. Installing in case I don't.

[rigid island]

one way to check
dotnet --info inside command line / terminal

dont forget to restart pc 🙂

[onyx lark]

Just reinstalled it and restarted, but no luck. I'm on a mac, maybe that has something to do with it?

I also wonder if maybe it's working, but I have some setting wrong in VS Code.

[rigid island]

hmm only thing I can think of is delete the csproj files in your project, regen project files then double click a script and open it, then check the output view or look out for anything after like any messages popups

[onyx lark]

where can I find the csproj files?

[rigid island]

its in the root folder of your project

[solemn raven]

hi,
if I have a list of 3 but i want to make it a list of 10 with all extra values to be 0 , do i need a forloop for this or is there is a better solution ?

[rigid island]

loop/LINQ is how you would typically interact with list many items

idk what you mean though by "Extra values to be 0"

0 what?

what type of list

[solemn raven]

like item number 4 =0 , 5=0,6=0 ...10=0

list<float>

[rigid island]

so how are you adding elements to this list because float default is already 0

[solemn raven]

can i just check if the list is less than 10 and if it's just add items of 10-count with the value of 0

like how we would do on the editor if we change the value of the list , it adds items to it and set its value to be default

[lean sail]

The default is 0 so you can probably just addRange a new collection, with the size of 10-count

No need to loop

[onyx lark]

I did this and this is the message I got, but I'm not sure if it's related.

[solemn raven]

could you show me a code please ?

[rigid island]

no not sure whats going on here , idk if u saw my vid but it should either tell you it loaded the c# project or something went wrong, are you able to select Project tab?

[lean sail]

Google addRange, I'm on mobile

[solemn raven]

got it thanks ❤️ ❤️

[rigid island]

i guess You could just use a superior and actually good working IDE

use visual studio community

call it a day

[onyx lark]

There is no project tab on mine. These are the options.

[rigid island]

yeah something in there borked but idk how you would fix it, I don't really use VSCode I'm on VS2022

[onyx lark]

The whole reason I was trying to switch to VS Code is because that one wasn't working for me haha

[rigid island]

really? works great for me, much better than 2019

granted not as good as windows version but works goood

[swift falcon]

I have an ScriptableObject.
Inside of this ScriptableObject, i got some AssetReference's and Methods to load & unload Asynchronously like this:

`public class X : ScriptableObject {
private AssetReference asset1;
private AssetReference asset2;
private List<GameObject> whichAssetsLoadedList = new List<GameObject>();

public void Load(GameObject loadedBy){
    asset1.LoadAssetAsync();
    whichAssetsLoadedList.Add(loadedBy);
}

}`

What i am trying to accomplish is:

I want to create a Base of Loadables.
In that base, i want to make Load() Method and whichAssetsLoadedList List to be required.
I tried Interface but List cannot be private. I tried Abstract class but i want only one class. Like, if i use an abstract class, i will need to use different Abstract class with same thing. Like one for ScriptableObjects, one for Monobehaviour with same Codes in this abstract classes and so on since Abstract classes blocking to add another class in it.
But the Loadables base must take UnityEngine.GameObject. Idk my brain is burned out. Someone can try it? Oh wait what if i create abstract class with UnityEngine.Object but no. IDK
Any idea?

[rigid island]

all you need is this on Macos and ur done

[onyx lark]

Ok, I'll try this.

[stark sinew]

Interesting, what's the use-case?
Do you want to make your own Asset Loading System for Runtime? Or is it something for Editor?

Also, what's the problem you're facing?
You want a Base for something that could be inherited as either a ScriptableObject or a MonoBehaviour, but interfaces won't work, correct?

Instead of having a List Property in your interfaces, you could use a GetMyList method, the MonoBehaviour base and ScriptableObject base could implement them in their own ways, but they're safe to have them, that way you could keep the underlying list private and return a readonly or copy

[vital oracle]

I want to make a crafting system that is basically X + Y = Z essentially.

For my game the player can collect many of each item type. A lot of the tutorials I've seen utilize an inventory with a list of scriptable objects. Which I think would be fine if you don't have a ton of items in an inventory, but I would end up with a list of potentially thousands of scriptable objects.

Are there any better methods for an inventory and item system where you can have the item in the inventory and then an associated value of the total # in the inventory?

[swift falcon]

Firstly, i am loading this ScriptableObject X. After that i want to add to the list which object OR which handle loaded this SO thats it. That way, i can "Unload" that asset directly without actually making many calculations. But what i want is Reuseability.
Yes i tried Interfaces but List cannot be private. I dont want the List to get overriden by something else.
GetMyList? Amazing idea. I should give a shot.

[stark sinew]

Keep a private List on the Implementation Side and return it in that interfaced method

[swift falcon]

Is using "ref" keyword is necessary for that GetMyList? I heard C# automatically does that.

[stark sinew]

ref? In what situation? ref is afaik only used in combination with defining/passing parameters/arguments, in methods

Do you mean return?

PSEUDO CODE

MyInterface
  List<GameObject> GetList()

MyClass : ..., MyInterface
  private myList

  List<GameObject> GetList()
  {
    return myList
    // return myList.Copy()
  }

[swift falcon]

Hm better i go test this :d

[swift falcon]

Yep! so it returns a copy in that code? Better i go test that too

[stark sinew]

You can use anyList.Copy()

Although, if the list contains classes, it doesn't actually copy those, so they're still the same GameObjects inside, just a different List referencing them

[swift falcon]

What if i make that GetList private?

hm

nope

[stark sinew]

You can't, it's an Interface Member

[swift falcon]

i heard c# 8 also allows that tho in what situtation it does? idk.

[stark sinew]

What exactly do you want to do as the end result?

Not in code, I mean, when that thing is done, what is it supposed to be?

[stark sinew]

The only idea behind Interfaces is it to provide a public set of functionality that can be referred to while allowing to abstract the actual implementation away, without using abstract classes or class inheritance at all

In my own bad wording

So there will never ever be private stuff for interfaces, you can't even declare access modifiers there, they're always public members

[swift falcon]

Bad wording? A nice explanation.

[stark sinew]

What you eventually want is

A property with a private setter

But idk, asking for the final goal again 😄

Ah, I think I got it, you want to know which Thing is loaded by What other thing? Hence, the loadedBy?

Ok!

[swift falcon]

I want to get Which objects/loadhandles loaded this SO. If its a loadhandle, i can release this SO from memory or decrement to ref count. If its a gameobject, then i will remove from the list, and release this SO like that. But a reminder there is Reference counts. Since i cant get Reference count in runtime, i will use this list

[stark sinew]

So basically, multiple other Objects could have called Load on that SO instance and you want to keep track of them?

[swift falcon]

Exactly!

I could do event based solution but no believe will complicate my code

[stark sinew]

I'm assuming those ScriptableObjects are created at runtime, and you want to destroy them when the list is back to empty again?

[swift falcon]

Yes. I want to destroy the AssetReferences and itself. So if list count is zero it will unload. If its not, it will decrease the ref count. If it gets loaded again, ref count +1 and assets are here. Another one calls Load then ref +1. I am using Addressables tho but they dont provide any ref count. If they had the "get" ref count of that object, it would be a kid toy

[stark sinew]

Aaaaah, I just googled what those AssetReferences are, just noticed you're doing something with Addressables, never touched that system so far

But I understand further I think

Do you want to unload those Adressable part once it's no longer used?

[swift falcon]

yes

sir

This thing is public i mean idk u said it will be public but um how will i save from other objects

[stark sinew]

Oooh, you want the List to not be accessible from outside at all?! My bad, then an interface isn't the thing you want

[swift falcon]

abstract the way right? You should try in a empty project man lets solve this thing lmao! A base class with private list but allowed in use of ScriptableObject, Monobehaviour or Any type of GameObject. Impossible? idk

[stark sinew]

I know finally got what you're trying to do...... I've scrolled up again haha

Basically, in very simple terms, those ScriptableObjects are Spawners (for Addressables) and you want to keep track of the SpawnCount, unloading the Adressable when the count hits 0

Why do you need a ScriptableObject AND a MonoBehaviour Base in the first place?
So they have a shared functionality of accessing that Spawner SO?

[swift falcon]

Ohooo i scrolled a lot tooo 😭

ScriptableObject contains AssetRefs in it. It is on use in loaded objects.
I dont need a base. If i cant do that, i will use Abstract classes for each
But i am gonna use this trick later on so i thought a base would be a star.

[swift falcon]

Second line seems so attractive to me right now

What if i use another SO for that list? Lets think about that

[stark sinew]

Honestly my head went out, it seems so overcomplicated to me

I have no idea how Addressables work, not even a little bit

[swift falcon]

So if i create an SO like "LoaderSO" like this:

`public class LoaderSO : ScriptableObject
{
private List<GameObject> loadedBy = default;

// For testing
private void AddToLoadedByList(GameObject signalObject){
    loadedBy.Add(signalObject);
}
private void RemoveFromLoadedByList(GameObject signalObject){
    loadedBy.Remove(signalObject);
}
private System.Int32 GetCountOfLoadedByList(){
    return loadedBy.Count;
}

}`

It actually solves my problem. This list reference will be gone after unloading the ScriptableObject X so no memory leaks will be seen if i am not in my dumb time

[stark sinew]

Nice!

But if it's only the ref count you need

Why store the GameObjects instead of incrementing and decrementing a counter?

Ok, I answered it myself, it's useful to see which GameObject forgot to unload something

myList = default should default to null btw, doesn't it? 😱

[swift falcon]

Nice question! I actually thought about this for so many mins and decided to really add UnloadAll() thing. I wanted to notify other objects that this ScriptableObject unloaded. But rn it seems counting will work for now

[swift falcon]

omg lets test it

ur right

i think today i am done.

Thank you for helping me sir. I will think about the ScriptableObject solution and see if its compitable with my project. If its not, i will think about Abstract classes or actually using Event based things again...

[stark sinew]

You're welcome! Wish I could've been more helpful, stupid Addressables q.q

[wild bane]

Could you guys help me figuring out why my character controllers are only colliding each other for a few frames, then walking thru each other?
I'm using CharacterController.Move every frame, and I'm also using a down raycast to adjust the character height when it falls below the ground level.

[obtuse sonnet]

hey, I've got a simple playmode test in place where I load a scene and then find objects in it, but for some reason FindObjectsOfType returns 0 (although the activeScene in debugger variable has these objects listed) - any help?

[onyx lark]

Switched to this and it's working. Thanks for the advice!

[spring creek]

It looks like you're using DOTS, soo, just making sure, these ARE gameobjects, not entities, right?

It looks like you're doing Hybrid, so that's a longshot

[tribal coral]

Hi 👋 Im practising 3d movemet and stumbled across this part of a code on the internet:
playerVelocity.y += Mathf.Sqrt(jumpHeight * -3.0f * gravityValue);
What does this part do? What is Mathf.Sqrt and why are we multiplying with -3f?
Dooes anyone know?
Its from this piece of code https://docs.unity3d.com/ScriptReference/CharacterController.Move.html

[dense estuary]

Im trying to make a stamina bar for my game, and I found this issue. When I start the game and run around and pause while the stamina bar is on screen, it doesnt disappear. It also gives me this weird error and after the error occurs I can't look around. Here is my stamina script: https://hastebin.com/share/anacarewaj.csharp. And here is a video of it happening: https://streamable.com/n2p4wk. (In the video the weird error doesnt happen, if it happens again ill show what it says)

[heavy wren]

hmm, idk why it's -3, it could just be -jumpHeight (still needs to be negative to counter gravity). The Sqrt doesn't really seem necessary either, it simply has the effect of sharply reducing y velocity as jumpHeight increases

[heavy wren]

FixedUpdate is meant for applying physics forces, you should just be using Update here, but if you Debug.Log(menu.gamePaused) is it true? Also are you sure the staminaBar image is a child of the group element?

[tawny mountain]

Anyone know anything about accessing mobile camera?

[warm geyser]

Dumb question but does Unity have some sort of math function that converts negative numbers into their 360 degree angle equivalents?

Like for example, -50 would be represented as 310

This works but I dunno if theres a cleaner way 😅 it bugs me for some reason

[verbal granite]

Right now I have a pretty small prototype that is just one level/scene, that the player can retry many times. For this I have the following line:
SceneManager.LoadScene(SceneManager.GetActiveScene().buildIndex);
However I notice that after 15ish minutes of continuous play, the game starts to get laggy. When I alt+f4 and restart everythings back to normal.
Are there any common reasons why this might be happening?

[tribal coral]

Thank you

[lusty hollow]

Is the game laggy or your editor? Does it continue to lag even if you stop play mode and re-enter?

[verbal granite]

This happens even when I build and run the .exe
When using the editor, stopping and restarting fixes the lag as well

[lusty hollow]

I'm just confused by you alt-f4ing. Does the game lag every time you start it again in play mode (not built, in the Unity editor) after the first time it starts lagging?

[verbal granite]

I alt-f4 when playing the .exe. In the unity editor, restarting fixes the lag

[lusty hollow]

I don't see a reason why that line specifically should be causing the lag. Is your scene being properly cleaned up each time you reload it? You aren't having objects sticking around from previous scenes, or 'persistant objects'?

It sounds to me like something is not being destroyed when you reload the scene, causing it to pile up memory over time

Causing the lag.

You say after 15 minutes, which depending on how complex your game is, sounds about right for a memory leak to form

[verbal granite]

Right, is there something I should do to make sure things get cleaned up?

or like what type of things tend to not automatically get cleaned up when reloading a scene? I'm assuming some or most things are cleaned up

[lusty hollow]

I would first look into each of your objects you're using consistently through the scene, and watch your hierarchy during reloads (so play in the editor, not in a .exe) to see if anything is sticking around that shouldnt.

It can be a complex issue to solve and I'm not exactly sure what's going on in your game, so I can't offer much more advice on the issue -- but from what you're describing, that sounds just like a memory leak from reloading the scene or scene objects improperly. You can also check out the Profiler to get a better idea of what's causing the lag -- definitely look there next.

[verbal granite]

My first hypthesis would be that I call the overlapCircle method many times. Each time the results get stored in a list of Collider2D, and I check if the size of the list is 1 or 0

although that List is scoped within the method

[lusty hollow]

Yes, I would definitely go over any object lists or any other collections. Accumulating such data without disposing of it could be the source of your problem.

[verbal granite]

I see. So if I have a method that gets called often, and it creates a list, I should dispose of the list at the end of that method? How do I do that

I kind of assumed it would just be garbage collected or something

[warm aspen]

How do you dispose of that kind of stuff?

[lusty hollow]

It really depends on what the problem is. If it's a DDOL object you'll need to make instances for example. Object lists that persist through loads could be changed instead to some other data type, then recalled when needed. It's a bit of a broad topic.

[fervent furnace]

you cant reuse the list?

[lusty hollow]

No you can totally reuse lists. I'm just referring to the fact that Popine may have a list that is collecting data without resetting it when he needs to (on load), which might be causing his issue. It just depends what's in your list, how big it is, how often it's being called upon, etc.

Just because he mentioned it.

[warm aspen]

If a list is a field in a class and the class instance is destroyed the list is also destroyed, right?

[verbal granite]

Ok new hypothesis, I create a coroutine every time the player hits the enemy. Maybe that's a problem? I notice the lag that accumulates mostly happens when the player hits the enemy. I tried adding an extra yield break; at the end of all my coroutine methods, I'm not 100% sure if that fixed it but it seems like it's improved

[quaint rock]

if its coroutine related more likely its multiple coroutines trying to work on the same data at the same time

[verbal granite]

interesting. I'm pretty sure I dont have any conflicts like that. I'll have to learn how to use the profiler tomorrow

[hard viper]

what I normally do is I make a private coroutine variable. Then:
if (myCoroutine == null) myCoroutine = StartCoroutine(MyFunction);

this way duplicate calls won’t start a coroutine while it is already going

[warm oasis]

yes never make couroutines for gameplay behaviours it sucks

make a float timer using update to prevent more attacks

[lean sail]

"Never" is quite an extreme, coroutines are useful in their own way

[night harness]

That seems like a pretty broad statement, no?

[warm oasis]

and i wrote never for gameplay behaviour. not just never

honestly it's a pain to debug, and not quite performant.
If it's for UI it's fine

or anything else not "gameplay related" but it's expensive

[lean sail]

My statement is still the same, they have their use cases

a single coroutine isnt gonna cause you any lag whatsoever

[warm oasis]

i mean lag whatsoever is for networked games, that shouldn't be in beginner code sorry.
but to make my point, don't make an attack with a coroutine it's bad

[night harness]

i mean lag whatsoever is for networked games, that shouldn't be in beginner games.

What does this mean?

[lean sail]

I have even less of a clue now what you are trying to say

lag is for networked games??

[warm oasis]

singleplayer doesn't get lag it gets freezes. singleplayer is framerate reliant, networked games is both framerate for clients and ping reliant and that's not even on point on the issue so i will stop replying before i get banned for no reason and spamming

lag is from ping

[night harness]

I'm not trying to be rude but your definition of lag is not how it's used by most people

[lean sail]

Im also not trying to be rude but you are just wrong

[night harness]

inconsistent and low framerates and frametimes are absolutely considered lag

[warm oasis]

and i'm not saying coroutine will make this lag

i'm saying don't it's not best practice

what needs to be profiled must be profiled, but codewise that's kinda wrong

[night harness]

If everyone only used what is considered best practice nothing would get released

saying "don't do x it's bad" is very broad and definitive

[lean sail]

List of things people said is slow/bad (in comparison or just in general) and shouldnt be used

If statements
Reverse for loop
new input system
string.contains
unity running on 1 thread
any while loops in update
ints 

Truly nothing would be coded if people followed this logic

[warm oasis]

i don't care also about slowness, the hard things you would have to debug is collision issues after it

or errors or things you won't get out of it, but anyway i won't speak anymore

i don't have anything to prove here

[spring creek]

I mean, it's not really hard to debug though. Are you using the actual debugger with breakpoints?

[warm oasis]

i make multiplayer games and i can debug my own things

and that's not about the issue again

[lean sail]

I am genuinely curious what kind of errors you would get in a coroutine that you wouldnt get in update

[warm oasis]

i don't have any

[lean sail]

Or what collision has to do with this at all

[spring creek]

So two things you said (it being not as performant, and hard to debug) are now not the issue. I'm confused, what IS the issue?

And yeah, what do collisions have to do with it?

[warm oasis]

collisions are fine, but you could #1 lose references while the coroutine finishes etc...

[mighty yew]

im declaring an enum in one file, and want to have multiple other files inherit from it. For whatever reason I feel like this is wrong? is this fine?

[night harness]

Really depends on context but if you wanted just a general vibe check, that seems like something that would be done yeah

[warm oasis]

or any other issues while it's going on, if you would just use ontriggerenter2d or 3d, and update with a cooldown, you would be way better

[lean sail]

this really sounds like you're doing something wrong instead of it being an issue with the coroutine.

[warm oasis]

i'm not the one having an issue again here

so i'll stop talking

because eh i know how right i am anyway

[lean sail]

Well I actually am questioning if theres some real issue with coroutines, for my own knowledge. But all you've done is present statements then take them back, then change the context, now you're doing something with collisions and losing references? I just think you're trolling at this point

[warm oasis]

coroutines are fine, when used correctly is what i've said

[spring creek]

That's the confusing part
"The problem is x"
"Again, I'm not saying the problem is x"

[warm oasis]

you're just trying to have a point when i'm just trying to help someone why should i care

[night harness]

Completely unrelated to what homie is talking about, But I have heard from a bunch of people that third party implementations of couroutines are vastly better than Unity's built in ones

[lean sail]

you can place the enum in its own file, although im not entirely sure if this is what you're asking

[lean sail]

ah thats interesting, might check some out

[mighty yew]

im aware, but then when I try to use it in other files it makes me do "using static <filename>" so im not really sure

i dont like using stuff i don't fully understand

[lean sail]

you dont have to if its a public enum, you can just use it then unless you are referring to some namespace issue

[spring creek]

MEC coroutines specifically is supposed to be very good

[warm oasis]

and my point was just you're going to have way more trouble debugging and guessing what's wrong when you use them
when i used an example you where smoking weed going out of subject too

[mighty yew]

you sure? since currently i have it as a public enum and it requires me to do that.

[lean sail]

yes, its the same as if you declare a public class

[spring creek]

Wow

[night harness]

Enums are inherently static, because you don't change what they are ever. This means you can reference them from any script without a reference because the programming gods know they will never change

A variable of that enum can and will change (kinda the whole point). So it needs a reference like most things do

Make sure your enum and the class its inside are both public, if it's still a problem there might be some odd hiccup in your c# project file or something

[lean sail]

Yea im adding coroutines to my list now of what people have said is bad. Maybe ill title it to be more encapsulating

[warm oasis]

also you can only have one at one point running in, so if you use it for multple things, the other one will have to wait

[night harness]

No?

[warm oasis]

meaning for gameplay it's real bad

[lean sail]

no

[mighty yew]

Not that I don't trust you guys, but im just confused as to why its doing this?

[night harness]

Item.Behavior

[warm oasis]

yes?

[night harness]

Becuase it's not native to that class 😄

[lean sail]

your enum is current inside a class, it can be in its own file*** entirely

[warm oasis]

ah shit yes

anyway i'll stop talking

[mighty yew]

that makes a lot of sense yeah!

[lean sail]

this isnt even related. for your own reputation yea maybe stop talking lol

[verbal granite]

just to elaborate on what i'm using coroutines for, since i have no idea if its "bad" or not.
Basically I want the player to freeze for a few frames when they hit the enemy (hitlag), to give the impact more weight. So when a hit is detected, I start a coroutine that records the current velocity of the player, sets the velocity to 0 for several frames, then sets the velocity back to what it was originally. That's all it does.

[mighty yew]

do i get rid of the class stuff? theres nothing other than the enum in that file?

[warm oasis]

lmao why remove it then

i'm out

[night harness]

its like having a Matt in your english class but you know a Matt from another school or something, since that other Matt isn't inherintly known by the class you gotta specify which matt it is 😄

[lean sail]

my sentence wasnt directed to you dude. I said "bad wording" because i wrote class instead of file in the message above 🤦‍♂️ you really are clowning right now

[night harness]

Also, when sending code through discord you can just do

looks nicer 😄

[verbal granite]

I could refactor to not have to use coroutines for this, but I figured it would be harmless

[lean sail]

I dont entirely know what this is for, so i dont want to suggest getting rid of the entire class. I was just stating that the enum can exist outside your class and everything can reference it

[lean sail]

that sounds fine to me

just keep track if a coroutine is already started

[spring creek]

Coroutines are absolutely fine to use. For behaviour or anything

There are pitfalls

[verbal granite]

also I tried adding a GC.collect() call before the loadscene, and that didn't fix the problem. Would that rule out a memory leak?

[spring creek]

You just have to understand them and take care to avoid them

[night harness]

When I use Coroutines I usually use a template like this

    Coroutine coroutine;

    void StartStagnate()
    {
        if (coroutine == null)
            coroutine = StartCoroutine(Stagnate());
    }

    void StopStagnate()
    {
        if (coroutine != null)
        {
            StopCoroutine(coroutine);
            coroutine = null;
        }
    }

    IEnumerator Stagnate()
    {
        yield return new WaitForSeconds(detectionStagnateTimer);
        detectionStateToggle = DetectionState.Decreasing;
    }

Might be a better way available but works nice for me

[lean sail]

what are you trying to do with this?

[verbal granite]

is the StopCoroutine() call necessary? Maybe that's what i'm missing. I imagined it would stop once it reaches the end of the method or yield break

[night harness]

For gameplay reasons I need to kill coroutines early sometimes

[lean sail]

It depends, sometimes you want to run a coroutine and not allow others to run while 1 is running. Sometimes you want to restart the coroutine (maybe in your freeze thing)

[verbal granite]

I was thinking if I manually trigger the GC, there wouldnt be any chance of something accumulating over time that would cause problems eventually

[lean sail]

Did you post your code somewhere above? maybe i can see whats wrong, i imagine you are probably just starting a shitton of coroutines

[rigid island]

you could always use UniTask is perfomance is a concern

[verbal granite]

    {
        Vector2 currentPosition = gameObject.transform.position;
        Vector2 currentVelocity = rb.velocity;
        animator.speed = 0;
        for (int i = 0; i < frames; i++)
        {
            gameObject.transform.position = currentPosition;
            rb.velocity = new Vector2(0, 0);
            state = new State(state.GetName(), state.GetFramesInState() - 1, state.GetDirectionFacing(), state.GetAttackId(), state.HasHit(), state.GetChargeFrames());
            yield return null;
        }
        animator.speed = 1;
        rb.velocity = currentVelocity;
        yield break;
    }```

[rigid island]

https://github.com/Cysharp/UniTask

[lean sail]

can you show the full relevant code, like where you start this coroutine. That part is probably more useful to this

on a paste site ideally

other than the state thing, which idk what thats for, this seems fine

[verbal granite]

basically I have a method in fixedUpdate(), which checks if the player's attack overlaps with the enemy, and if it does, calls this method. Then it sets a boolean to make sure it can only happen once per attack

well actually I set the boolean before starting the coroutine

[lean sail]

instead of describing it, just show it. there might be a difference in what you think it does vs what it actually does

[verbal granite]

well it's kind of spread over a few different files

if you're thinking that the method might be getting called way more often than expected, I can try printing a log to show it's only happening once in a while

[lean sail]

you can still show a snippet of the relevant line, but if you rather not, id just suggest doing what was written above in the example of starting a coroutine only if your stored coroutine is null. Or killing the current coroutine and starting a new one, depending on the effect you want

yes also just throw a debug in there

[verbal granite]

yeah i'm certain that too many StartCoroutine() calls is not the issue

[warm oasis]

and i never said it was

[verbal granite]

at least not in a short amount of time

[warm oasis]

i said to profile it

[lean sail]

its hard to really suggest anything then since ive only seen the coroutine. Other than state, all of this clearly wont cause any issues

You can use https://docs.unity3d.com/ScriptReference/Profiling.Profiler.BeginSample.html
if you want to see custom profiling on which part might be causing issues

[verbal granite]

thats at least good to know though thx

[spring creek]

Can I ask, what's your opinion on Jobs?

Or Tasks?

[warm oasis]

they're good too, when used when it's supposed to

like your cpu is overloaded on a single core for example from a single method call

it all depends on the usage but singleplayer needing that is... rare and networked games too i guess

[verbal granite]

i'll get a profiler screenshot just gotta play the game for like 10 minutes before it start lagging

[winged sphinx]

how much is too much to store in playerprefs before I should start saving by other means?

...I'm about to add over 300 integers to it. And this seems like maybe it wasn't designed for that.

[lean sail]

sounds like trouble, considering you'll be autogenerating the names (i really hope you are at least). Id just move onto other means after you start needing to save anything except player settings

https://docs.unity3d.com/ScriptReference/PlayerPrefs.SetString.html
this is the only limit im really aware of

Keep the value at 2 KB or smaller. To store larger amounts of data, write them to a file in Application.persistentDataPath.
Im sure the same logic would apply to your 300 ints, even though its not 2KB its still a lot of numbers

[warm oasis]

honestly don't use playerprefs at all just save a binary save file inside persistentdata as he said

or database if needed

[hexed ingot]

Hi guys! I have a problem with linerenderers and canvas

I have a canvas set to screenspace camera and some linerenderers drawn by code. The problem is the lines appear above the UI panels

I've tried with sorting groups and changing Z (if I change Z of the lines below -10 they don't get drawn but that's all) and no luck

the sorting layers

this panels are in BottomMenu and the Lines in DrawingLines

Thanks in advance 🙂

[rocky helm]

So, I have a script which breaks glass into around 100 pieces, but it has become pretty obvious to me that this causing little lag spikes every time the script is ran. So my question would be, performance wise, what should I do to make it perform better? Currently, For every glass shard I make a new game object and give it a mesh collider&filter&renderer. This is obviously slow, so I have a couple ideas, but I don't know which I should do, or if there are better ways to do this since I have no idea how fast/slow these things really are. One idea is to never destroy the shard game object, but rather remove/disable it's components and mesh and re-use said game object, and another idea is to also make like a hundred new game objects ready before the start of the game and once they get used and there is less than a hundred spare game objects, slowly make more of them. The problem I feel with the first one tho is that, would it even be faster to disable/destroy everything in the shard game object and re-use that over just deleting/disabling the shard and making a completely new one?

[oblique spoke]

Pooling objects is generally always faster. I would avoid having to do component swaps if possible.

[swift falcon]

I got an Audio System. This audio system adds a Monobehaviour Component to inside the GameObject if the GameObject requested PlaySound Action with its AudioSource.
I saw from Unity Projects, they usually use Pooling even in Audio System. But still, they got a Monobehaviour and an AudioSource inside the pooled object.
Should i refactor my system? Or using AddComponent would be fast enough?

[oblique spoke]

I generally either include the AudioSource within the pooled object or use separate (pooled) gameobjects dedicated to playing audio. Often the latter since lifetimes between audio and sources triggering audio differ.

[obtuse sonnet]

yeah, these are gameobjects with my custom type called Entity

[swift falcon]

How can i accept Integer value only inside Generic Type like this: public class X<Num> : where Num : INumber I searched a little and found that it is possible with System.Numerics but it says its not implemented...

[winged mortar]

Where Num : int?

Or alternatively don't make it generic at all

If it can only be an integer

[swift falcon]

integer is not restrictive. However struct is but i want only integer. Hm youre right maybe i should use a field instead

[winged mortar]

You can also try unmanaged

But I think that also takes structs

But realistically you want your generic to only constrain because you are expecting it to have a set of methods / operations

Sometimes you don't need it to be all that constrained

Like vectors implement most operators, would you also want support for that xp?

[rocky helm]

Is there a point to disabling empty game objects if I am going to need them enabled afterwards?

[green breach]

That's pretty vague, it really depends on your usage

[rocky helm]

I pool the game objects and don't use them for some time, then afterwards put them to use

[late lion]

INumber and generic math was introduced in .NET 7. It's not available in Unity.

[green breach]

Disabling just makes unity ignore all the components attached to an object, so if they're empty, you don't have to disable them
If they have any components that require constant updating you'll want to disable them

Eg. If they have rigidbodies, colliders, or scripts with Update methods

[rocky helm]

So rigidbodies stop moving yes?

and lose velocity I hope

[green breach]

If the object is disabled? Yeah

[gleaming gate]

Does anyone know if there's any solution to fixing the particle system? I've done a bunch of things to make it play, but it won't for some reason

I'm on 2019 BTW

[gleaming gate]

Like I know it's not invisible. Setting it to automatically play works. It just has issues with playing through code.

[primal wind]

Why can't we have the nice .NET features

Random.Shuffle

[late lion]

Once they finish the transition from Mono to CoreCLR, it will be easier for them to stay up to date with .NET. That transition won't happen until at least 2024.

[gleaming gate]

OK nevermind. Particles hate switch statements apparently

[west sparrow]

The problems going to be your switch statement - the particle system has no knowledge of it, and isn't impacted from that any different than any other statements

[gleaming gate]

The switch statement does everything fine; spawns an enemy, throw a debug message. It's just .Play() has a hard time with it

[leaden ice]

particle systems don't know or care about switch statements.

[wintry crescent]

I'm trying to set up visual studio code, and I'm having trouble - I keep getting a million errors like "package x is in unsupported format (for example, a traditional .Net Framework project). It need be converted to new SDK style to work in C# Dev Kit." - does anyone know how to solve this?

not only that - I get no error messages. I just wrote AAA(); randomly in one of my functions, and I get no errors. That's weird

it's as if my intellicode didn't work at all - even though it supposedly should, I have everything installed

It did say that some features are disabled due to copilot, but does that include syntax highliting??

that makes no sense, hence why I'm asking

what's more, I save a file with a clear syntax error, and unity console just stays quiet about it... what could be wrong here?

I'm on linux btw, specifically endevourOs

it does find warnings - like a varaible that's never used - but random characters in-between functions or calls to nonexisting variables or functions seem to be invisible

[knotty sun]

looks like C# Dev Kit needs .Net 7 which Unity does not support

https://discussions.unity.com/t/vscode-cant-load-c-project/273373

amazing what you can find when you Google

[heady iris]

I've got everything working right now on my macbook -- vscode with the C# Dev Kit add-on, using the new instructions at https://code.visualstudio.com/docs/other/unity

It was not a painless process. VSCode decided it needed to re-download .NET on two separate flights where I had no internet access...

[knotty sun]

is it using .Net 7?

[wintry crescent]

thanks, didn't find that somehow - but does it mean I have to go to the csproj file of every extension I have (70+) and edit that line there?

or is there an automated way to do it

[heady iris]

It is. 7.0.10

It doesn't really matter what version of .NET the code editor is using. Unless you try to use a feature that Unity's .NET doesn't have, I guess.

[knotty sun]

problem seems to be in the .csproj files

[heady iris]

I had a mangled csproj after setting this up

For some reason, every project was in there twice

even after regenerating external files

completely deleting it and then letting unity re-make it worked

[knotty sun]

hmm, problematical

[heady iris]

once I followed the instructions properly, things have been working well

too well, sometimes

i really wish it would wait a moment before analyzing my code

[knotty sun]

There you go @wintry crescent , @heady iris is your goto man

[heady iris]

leaving the Problems tab open as I type causes an amazing storm of error messages

I have an awful 2,500 line script file that takes just long enough to analyze for it to be pleasant

[quartz folio]

Is both the C# Dev Kit and C# package up to date if you've got them installed manually?

[heady iris]

maybe everything just needs to be that large...

[knotty sun]

@heady iris Sorry bro to dump this on you, I dont do VS Code

[heady iris]

ha, no problem :p

[wintry crescent]

I installed them through visual studio code - they seem to be up to date

[heady iris]

Are you following these instructions?

notably, you're going to be using the Visual Studio package, not the Visual Studio Code package

the most recent version of the former lets you pick VSCode as your external editor

I had to uninstall the "engineering" feature so that I could update the package. it was stuck on an older version.

[wintry crescent]

I did follow them - It still doesn't work

[knotty sun]

Ah, that makes sense now, that will get round the .Net 7 requirement

[wintry crescent]

I don't have the error messages now, so that's good - I switched to .net framework

but I still have no error detection inside vs code

I wrote

private void HandleInput()
    {
        _horizontal = 
        _vertical = Input.GetAxis("Vertical");
        _rotation = Input.GetAxis("Rotation");
    }
``` as a test - unity detects it as an error now, but vs code still doesn't

[knotty sun]

it's not an error

[heady iris]

yeah that's valid syntax

[quartz folio]

That code would compile fine if the variables had been declared

[heady iris]

assuming horizontal exists

[swift falcon]

The Dotnet had an update last days. Go to your settings in vs code, and set the "Use OmniSharp" = True . It reset on me so i needed to do that. Just try if it works

[heady iris]

I have that unchecked.

Have a look in your Output windows. There may an interesting error there.

the "C#" one is not very interesting. It just says that it's starting up.

Dotnet path: /Users/crux/Library/Application Support/Code/User/globalStorage/ms-dotnettools.vscode-dotnet-runtime/.dotnet/7.0.10/dotnet
Activating C# + C# Dev Kit...
info: LanguageServerHost[0]
      Starting server...

[modern jewel]

Anyone have a clue why my terrains are pink here?

  private Terrain GenerateTerrain(Vector3 position) {
        GameObject terrainObject = new GameObject("Terrain");
        terrainObject.transform.position = position;

        Terrain terrain = terrainObject.AddComponent<Terrain>();
        terrain.terrainData = GenerateTerrainData(position);
        TerrainCollider terrainCollider = terrainObject.AddComponent<TerrainCollider>();
        terrainCollider.terrainData = terrain.terrainData;

        return terrain;
    }

    private TerrainData GenerateTerrainData(Vector3 position) {
        TerrainData terrainData = new TerrainData();
        terrainData.heightmapResolution = terrainSize + 1;
        terrainData.size = new Vector3(terrainSize, 10, terrainSize);
        terrainData.SetHeights(0, 0, GenerateHeights(position));
        terrainData.terrainLayers = terrainLayers;

        // Create an alphamap based on the heights and apply the terrain layers
        float[,,] alphamap = new float[terrainSize, terrainSize, terrainLayers.Length];
        float[,] heights = terrainData.GetHeights(0, 0, terrainSize, terrainSize);

        // Initialize alphamap to zeros
        for (int i = 0; i < terrainSize; i++) {
            for (int j = 0; j < terrainSize; j++) {
                for (int layer = 0; layer < terrainLayers.Length; layer++) {
                    alphamap[i, j, layer] = 0;
                }
            }
        }

        for (int y = 0; y < terrainSize; y++) {
            for (int x = 0; x < terrainSize; x++) {
                float height = heights[y, x];

                // Determine the layer based on height (modify as needed)
                int layerIndex = 0;
                if (height < 0.3f) layerIndex = 0; // First layer
                else if (height < 0.6f) layerIndex = 1; // Second layer
                else layerIndex = 2; // Third layer

                // Check for index out of range
                if (layerIndex < terrainLayers.Length) {
                    alphamap[x, y, layerIndex] = 1;
                }
            }
        }
        terrainData.SetAlphamaps(0, 0, alphamap);

        return terrainData;
    }```

[swift falcon]

Its because you are not using OmniSharp

[heady iris]

pink terrain suggests that the material is broken

I do not remember where the terrain's material lives (in the TerrainData, or maybe elsewhere)

[modern jewel]

@heady iris So I need a base material for the terrain and then my alphamaps blend in new layers on top of it? So it's like a base layer all the others are painted on?

[heady iris]

No, you just need a material for the terrain, full stop.

Inspect the generated Terrain component.

[modern jewel]

Okay, I will. Wonder if I can just use this: Material terrainMaterial = new Material(Shader.Find("Standard"));

[heady iris]

The material would be found here.

You'd want to use a terrain shader.

[modern jewel]

okay

[heady iris]

i'm using something custom here, making unity yell at me

the shader name will vary based on your render pipeline

I've never actually created a terrain component through code before. I wouldn't be surprised if it wound up without a material assigned to it.

[modern jewel]

Okay great, I think this is progress 🙂

[heady iris]

Whenever you see that weird pink color, it means a shader isn't working

or that there's just no material assigned at all

[modern jewel]

I created a terrain in the editor and this was the default material:

But TerrainLit isn't returned by Find.

terrainMaterial = new Material(Shader.Find("TerrainLit"));

[stark sinew]

This is looking for a Shader named "TerrainLit" and trying to create a new Material Instance with that Shader

You could Serialize the Material in the Inspector or you could put it into the Resources Folder and use Resources.Load

If you check the Material itself in the Inspector, there's a Drop-down at the top which shows you the name of the actual Shader used by that Material, if you want to know which one it is

[modern jewel]

Doh

Thanks

[stark sinew]

Are you missing a Rigidbody2D or forgot to set the Collider to isTrigger?

It's probably not a coding error but instead something with the composition of your GameObjects

You could show screenshots of the Spawner and Terrain Inspectors

[modern jewel]

terrainMaterial = Resources.Load<Material>("Materials/TerrainLit");

That doesn't appear to be the correct way to load a material. Anyone know what I'm doing wrong?

GameObject.Find?

[cosmic rain]

Assuming that Materials directory is in Resources directory, it should work.🤔

[modern jewel]

terrainMaterial = GameObject.Find("demoterrain").GetComponent<Terrain>().materialTemplate;

Lol, I added a terrain object to the scene and did this. So it works, I just need to find the correct location of hte material 😄

[wild bane]

Guys. I have two character controllers. At every frame, I change the character controller radius and height based on a few values. Both characters collides with each other normally, but sometimes, when their radius or height changes, they don't collide anymore, and pass thru each other. Could that be the reason for them not colliding anymore?

[stark sinew]

I think there could be an intersection between those when you change their radius/height which may lead to not properly receiving a collision, but I'm not sure

I think this applies to Rigidbodies as well, sometimes

[wild bane]

Could using a Rigidbody-based CharacterController handle these?

[vestal summit]

!code

[tawny elk]

Posting code

📃 Large Code Blocks
Large code blocks should be posted as links to services like:
https://gdl.space/, https://paste.ofcode.org/, https://hatebin.com/
https://paste.myst.rs/, https://hastebin.com/

📃 Inline Code
Surround code with three backquotes. Not quotation marks.
To get C# formatting the first line should only contain cs or csharp.
Add a comment with a line number if there is an error message.
```cs
// Your code here
```
Do not share screenshots of code unless requested.

[rigid island]

can't tell without first looking how you move characters inthe first place

[stark sinew]

^ code would be helpful

Possibly, or you could do something towards Physics.CheckBox or whatever when you're changing the Radius/Height to check for a potentially ignored collision by yourself

Does CharacterController have something similar to the Rigidbodies CollisionDetectionMode?

[wild bane]

@rigid island https://github.com/rickomax/Acknex/blob/722c5def53c4cec971de8cb25ef01ac57429ab13/Assets/Scripts/Acknex/Objects/Player.cs#L97

[rigid island]

where is movement? this script is a mess

[steep herald]

I have a list<A> and a list<B>. They contain 4 instances of A and 4 instances of B.

I want to do something like a cartesian product but rather than test values individually, I want to test every configuration of the whole thing.

e.g. 1x 2y 3z 4w = 1 configuration. 1x, 2y, 3w, 4z = 2nd configuration, and so on.

Any idea how I can achieve this?

[wild bane]

https://github.com/rickomax/Acknex/blob/722c5def53c4cec971de8cb25ef01ac57429ab13/Assets/Scripts/Acknex/Objects/Actor.cs#L40
This is a coroutine that all the other moveable objects beside the player uses to move

[wild bane]

If one day you understand what the project is doing, you might know why it "looks like a mess"

It is a raycaster engine port, and the original engine itself is a mess

But the movement is right there CharacterController.Move

[rigid island]

yeah it just takes lots of digging

[stark sinew]

I think it's fine, not toooo messy, but you could definitely extract out a loooot, for example a wrapper around retrieving and updating from the World.instance

[rigid island]

putting everything in one script is difficult to debug

the movemnt code at least is using physics so that can be crossed out as culprit

[stark sinew]

Yes, definitely, and it's a lot of unnecessary responsibility in there, but overall it's clearly understandable I'd say

[wild bane]

All these World.Instance things are updating values the game scripting engine uses

And reading from these values as well

So the game script can change variables that modifies players and objects positions as well, but it is not doing that when the physics breaks

Game script are not ordinal C# scripts, they are C# scripts I transpile from the original game scripting language

[hexed ingot]

Does anyone know? 😦

[stark sinew]

@wild bane
I'm still reading through the code, but just asking, are you doing more then 1 call of Move on the CC per frame? Are you eventually setting transform.position on it somewhere?

Definitely only a single Move per frame, seemingly

[wild bane]

I don't do more than one Move per frame, but yes, I set transform.position, lemme find where

[rigid island]

show canvas inspector

[cosmic rain]

You can't draw line renderers in screen space afaik.
And canvases always render last.
So there's not much you can do.

[hexed ingot]

which part of inspector?

[rigid island]

the whole canvas object

[wild bane]

https://github.com/rickomax/Acknex/blob/722c5def53c4cec971de8cb25ef01ac57429ab13/Assets/Scripts/Acknex/Objects/Player.cs#L85C43-L85C52
Keep in mind all these reading and writing to World values is to keep the character sync with any script changes from the original transpiled scripts

[rigid island]

oh ok ScreenSpace - Camera Should respect sorting

[hexed ingot]

but the line drawing is not done in the canvas

[cosmic rain]

But you want it to draw on top of the canvas, right?

[rigid island]

opposite

[hexed ingot]

no, the problem is the line is drawn on top

[cosmic rain]

Oh

[stark sinew]

            CharacterController.transform.position = initialPosition;```

Inside your `UpdateObject`

Idk if that may be an issue, could you apply those within your CC `.Move()` instead?

Why does it receive an initial position every frame?

[hexed ingot]

all the buttons are the canvas and the yellow and grey line are the linerenderer stuff

[rigid island]

\

did u check this

on line renderer

[hexed ingot]

letmecheck

yes it's checked

[wild bane]

Yes, but I see that the real problem occurs when the CharacterControllers (things and player ones) radius changes

[rigid island]

whats order in layer set to

make it higher than canvas

[cosmic rain]

Can you not use screen space - overlay canvas?

[modern jewel]

If my TerrainLit material is here, why isn't this loading it? terrainMaterial = Resources.Load<Material>("Materials/TerrainLit");

[rigid island]

so if canvas is order in layer of 1, make the order in layer on line render > 1

like2 or 3

should work since you have screen space - camera

[stark sinew]

There is enableOverlapRecovery for CC, but Docs write that it's only for static object overlaps

Maybe skinWidth?

[rigid island]

no nothing sorting layer

[hexed ingot]

Lines use the drawingLines layer and the menu uses the BottomMenu layer

[rigid island]

idk i dont use sorting layers

i just changed this

and tested it

works

[wild bane]

So maybe I need some custom depenetration code?

[hexed ingot]

the bottom menu has order 1

and is on another layer XD

[rigid island]

layer 0 means is at the bottom

[hexed ingot]

no because it destroys other stuff

[rigid island]

afaik

if you want drawing line ontop then I think you need to put as index 4

where bottom menu is

[stark sinew]

That would definitely be an option, but idk if it's the "best" one, sadly I've always used Rigidbody controllers so far

[hexed ingot]

I've tried everything, even putting them in the same layer and nothing works

I've tried that @rigid island

[wild bane]

As far as I know, changing collider radius based on mesh bounds or things like that is kinda normal. Not sure if that is "safe", tho

Lemme try locking their radius

[rigid island]

oh sorry you want line renderer behind right?

switch the order

[wild bane]

@stark sinew , by locking their radius, the problem does not happen anymore :/

And their radius can change very quickly because they're based on a sprite radius (relative to camera)

[hexed ingot]

not working.....

[rigid island]

not sure why, it should..
maybe someone in #📲┃ui-ux knows , this isn't code related so far 😛

[hexed ingot]

thanks for the help

I don't understand either

[stark sinew]

Can you pause in Playmode, then go frame by frame, and check what happens at that exact moment in the scene?
Do the CC bounds look as expected?
Do they suddenly overlap each other?

[wintry crescent]

Hi - I keep having those problems with my linux visual studio code install. I tried basically all of the things that were previously mentioned - including replacing some text in all csproj files from <TargetFrameworkVersion>v4.7.1</TargetFrameworkVersion>
to
<TargetFrameworkVersion>v4.7.1</TargetFrameworkVersion>
<TargetFramework>net7.0</TargetFramework>
which gets immediately reverted anyway whenever I try to open vscode from unity
and even when it's changed after vscode was openend, I still have no autocomplete
I tried everything, from switching to .Net Standard 2.1 or back to Framework 4.7.1, recreating all project files, messing around in vscode extension settings, I don't know what to do anymore

[jolly tulip]

hello, i came from web development, and there's one thing is missing for me, its DI container, for example how can i organize acces to player script from another script on any object, by not adding player field to the another class or using "GameObject.FindObjectsOfType"

[wild bane]

@stark sinew

[knotty sun]

by making the class/ method static, then you can access it by Class name rather than by reference

[hexed ingot]

@rigid island if I put the menu on Z = -21 it is in front for some reason

so fixed

[rigid island]

ahhh forgot u said u changed the Z as well

[wild bane]

@stark sinew the radius grows too much and too fast, I guess, so the collision will break. I can't even interpolate that bc the change could happen at every frame. The best I could do is trying depenetrating them manually

[rigid island]

i kept all mine on 0 @hexed ingot

[cosmic rain]

Dependency injection is not magic. Learn how it works wherever you're used to use it and implement it in similar way in C#.
Or you might want to use some existing dependency injection libraries/assets.

[rigid island]

https://unity.huh.how/programming/references/simple-dependency-injection

[jolly tulip]

thanks

[jolly tulip]

thanks

[obtuse sonnet]

well, this was kinda a stupid mistake - the trees I referenced were Unity Terrain Trees and not my custom tree class...

[thorn summit]

hi there, i want to make a 2d top down game about automation with elements similar to factorio, how would i go about making the conveyor system? do i move the items using physics and effectors or do i make a custom system were i move the items every tick on the next conveyor? i already have a grid system

[wild bane]

Thanks @stark sinew

[knotty sun]

Do not cross post

[thorn summit]

what do you mean?

[rigid island]

don't post the same question in multiple channels

#854851968446365696

[winter fern]

why do I not get any coloured code compared to the tutorial

[rigid island]

!ide

[tawny elk]

💡 IDE Configuration

If your IDE is not autocompleting code
or underlining errors, please configure it:

• Visual Studio (Installed via Unity Hub)
• Visual Studio (Installed manually)

• VS Code*
• JetBrains Rider
• Other/None

*VS Code's debugger plugin is unsupported.
We recommend using VS or Rider instead.

[thorn summit]

ok sorry

[dusky pelican]

hello my rigidbody velocity going down. How can i stop it in the zero?

[merry sierra]

i am trying to rotate a gameobject in update

newRot = steerInput * turnSpeed * Time.deltaTime * moveInput;
        transform.Rotate(0, newRot, 0, Space.World);

but it runs smooth when i have 800 fps but in 60 fps it dont rotate much
so i tried to put the 1st line in update and second in fixed update then its rotating in 60 but not in 800fps
do anyone know why its happening

[verbal granite]

Hi, I'm trying to use the profiler for the first time to investigate a performance problem. I'm not sure where to go from here, but this seems abnormal to me.