#dev-contrib | Python | Page 115

clever wraith May 17, 2021, 7:41 PM

#

i think joe is ascending

patent pivot May 17, 2021, 7:41 PM

#

site is deploying™️

clever wraith May 17, 2021, 7:42 PM

#

hold up, do i need to make a separate pull of the site to work on the bot?

#

because i get this: ```
bot_1 | 2021-05-17 19:41:38 | bot | CRITICAL | Could not connect to site API. Is it running?
bot_1 exited with code 69

brazen charm May 17, 2021, 7:43 PM

#

What was the purpose of the windows path tag? Seems like it just explains how to invoke py in a bit verbose way. I recall it being discussed somewhere but I think that was before tags were files on the bot

clever wraith May 17, 2021, 7:43 PM

#

i mean, kudos to you all for choosing code 69

gritty wind May 17, 2021, 7:43 PM

#

you can run the site using the docker-compose

#

docker-compose up -d web postgres

vocal prairie May 17, 2021, 7:43 PM

#

clever wraith hold up, do i need to make a separate pull of the site to work on the bot?

Are you using docker?

clever wraith May 17, 2021, 7:43 PM

#

yes

gritty wind May 17, 2021, 7:43 PM

#

as a bonus, you could also run redis

#

just add redis to the end of the command up there

#

also check out the contrib guide

#

it'll help

#

a lot

vocal prairie May 17, 2021, 7:44 PM

#

https://pythondiscord.com/pages/guides/pydis-guides/contributing/bot/

Python Discord - Contributing to Bot

A guide to setting up and configuring Bot.

clever wraith May 17, 2021, 7:44 PM

#

im using fakeredis

brazen charm May 17, 2021, 7:44 PM

#

Have you configured the urls?

clever wraith May 17, 2021, 7:44 PM

#

yes

#

i think

#

shit

#

im so dumb

#

did i seriously type web:8080

#

you gotta be shitting me https://paste.pythondiscord.com/vupezohisu.sql

vale ibex May 17, 2021, 7:55 PM

#

any errors in the site container?

clever wraith May 17, 2021, 7:55 PM

#

nope

vale ibex May 17, 2021, 7:56 PM

#

So the site container is running now?

#

bot_web_1

clever wraith May 17, 2021, 7:56 PM

#

yes

vale ibex May 17, 2021, 7:57 PM

#

can you show the last few log messages?

clever wraith May 17, 2021, 7:58 PM

#

Deleting 'images/navbar/pydis_banner_no_square.svg'

Deleting 'images/navbar/discord.svg'

Deleting 'images/waves/wave_white.svg'

Deleting 'images/waves/wave_dark.svg'

Deleting 'images/events/100k.png'

Deleting 'images/events/summer_code_jam_2020.png'


236 static files copied to '/var/www/static'.

Creating a superuser.

Admin superuser already exists.

Existing bot token found: badbot13m0n8f570f942013fc818f234916ca531

Starting server.

Watching for file changes with StatReloader

Performing system checks...


System check identified no issues (0 silenced).

May 17, 2021 - 19:57:08

Django version 3.0.14, using settings 'pydis_site.settings'

Starting development server at http://0.0.0.0:8000/

Quit the server with CONTROL-C.
``` in site

vale ibex May 17, 2021, 7:58 PM

#

you're running the site locally?

clever wraith May 17, 2021, 7:58 PM

#

with docker

vale ibex May 17, 2021, 7:58 PM

#

from the site repo?

clever wraith May 17, 2021, 7:59 PM

#

no, from the bot repo

#

i did docker compose up in the bot dir

vale ibex May 17, 2021, 7:59 PM

#

ok, just checking, since those logs should be prepended with bot_web_1

brazen charm May 17, 2021, 7:59 PM

#

Bot's also in docker?

clever wraith May 17, 2021, 7:59 PM

#

i copied them directly from the bot_web_1 logs as the bot_bot_1 is bootlooping

clever wraith May 17, 2021, 7:59 PM

#

brazen charm Bot's also in docker?

yes

vale ibex May 17, 2021, 8:00 PM

#

can you do docker-compose down and docker-compose up --build

clever wraith May 17, 2021, 8:00 PM

#

aure

#

sure

#

@vale ibex same output

vale ibex May 17, 2021, 8:02 PM

#

Could you paste the full output from the command?

#

from the start

clever wraith May 17, 2021, 8:02 PM

#

sure, but im gonna stop the bot cause its bootlooping again

#

https://paste.pythondiscord.com/biyizekehe.apache

#

@vale ibex it seems the api is not starting

vale ibex May 17, 2021, 8:05 PM

#

There's a bunch cut off from the start it seems

#

also, this line bot_1 | 2021-05-17 20:01:34 | discord.client | WARNING | PyNaCl is not installed, voice will NOT be supported suggests you might be on an old commit?

#

what branch do you have checked out?

#

The output of git log -1 would be good

clever wraith May 17, 2021, 8:07 PM

#

vale ibex what branch do you have checked out?

main

brazen charm May 17, 2021, 8:07 PM

#

vale ibex also, this line `bot_1 | 2021-05-17 20:01:34 | discord.client | WARNING | PyNaCl...

Why would it suggest that?

vale ibex May 17, 2021, 8:07 PM

#

since we don't have voice extras on d.py anymore

#

huh, I thought that log wouldn't show now that we removed the voice extras for d.py

#

My mistake.

clever wraith May 17, 2021, 8:08 PM

#

i refreshed my fork this morning

brazen charm May 17, 2021, 8:08 PM

#

I assume the log shows up because they were removed and it can't find them

clever wraith May 17, 2021, 8:08 PM

#

what im seeing is the api isnt starting

brazen charm May 17, 2021, 8:09 PM

#

So your urls config looks something like this?

    site:        &DOMAIN       "web:8000"
    site_api:    &API    !JOIN ["api.", *DOMAIN]
    site_paste:  &PASTE  !JOIN ["paste.", *DOMAIN]
    site_staff:  &STAFF  !JOIN ["staff.", *DOMAIN]
    site_schema: &SCHEMA       "http://"

clever wraith May 17, 2021, 8:10 PM

#

urls:
    # PyDis site vars
    connect_max_retries:       3
    connect_cooldown:          5
    site:        &DOMAIN       "web:8000"
    site_api:    &API          "api.web:8000"
    site_api_schema:           "http://"
    site_paste:  &PASTE  !JOIN ["paste.", *DOMAIN]
    site_schema: &SCHEMA       "http://"
    site_staff:  &STAFF  !JOIN ["staff.", *DOMAIN]

    paste_service:                      !JOIN [*SCHEMA, *PASTE, "/{key}"]
    site_logs_view:                     !JOIN [*SCHEMA, *STAFF, "/bot/logs"]

    # Snekbox
    snekbox_eval_api: "http://snekbox.default.svc.cluster.local/eval"

    # Discord API URLs
    discord_api:        &DISCORD_API "https://discordapp.com/api/v7/"
    discord_invite_api: !JOIN [*DISCORD_API, "invites"]

    # Misc URLsw
    bot_avatar:      "https://raw.githubusercontent.com/python-discord/branding/main/logos/logo_circle/logo_circle.png"
    github_bot_repo: "https://github.com/python-discord/bot"

#

oh @vale ibex its working now

#

im on a nightly docker and i was using docker compose instead of docker-compose

vale ibex May 17, 2021, 8:14 PM

#

You'd want to update your snekbox url to http://localhost:8060/eval too

brazen charm May 17, 2021, 8:14 PM

#

If you're running through docker I'd also suggest to configure redis and snekbox normally

brazen charm May 17, 2021, 8:17 PM

#

vale ibex You'd want to update your snekbox url to `http://localhost:8060/eval` too

I believe it'd be http://snekbox:8060/eval when it's all within docker, same for redis but with redis

vale ibex May 17, 2021, 8:17 PM

#

huh, yeah that'll probably be better, since it's more ~~verbose~~ descriptive

#

but localhost works too

brazen charm May 17, 2021, 8:18 PM

#

iirc localhost will fail if it's not exposed in some way through docker when it's all ran within it, but not sure as I run the bot outside of docker

vale ibex May 17, 2021, 8:19 PM

#

hmmm, I might be wrong then, let me actually run the container

#

No, you are right. I must have updated my config for the test server recently.

#

I remember setting it up, and localhost is what it's currently configured to

#

so I put 2 and 2 together and got 5

stable mountainBOT May 17, 2021, 8:33 PM

#

@fervent sage

It has arrived!

Here's your reminder: this.
[Jump back to when you created the reminder](#dev-contrib message)

fervent sage May 17, 2021, 8:33 PM

#

!remind 2h ^

stable mountainBOT May 17, 2021, 8:33 PM

#

I got you.

Your reminder will arrive in 2 hours!

fallen patrol May 17, 2021, 8:35 PM

#

vale ibex since we don't have voice extras on d.py anymore

yeah exactly

#

if you don't have the voice extras, discord py displays that message

dusky shoreBOT May 17, 2021, 9:00 PM

#

GitHub

IssueOpen Long-term: Deploy previews!

patent pivot May 17, 2021, 9:01 PM

#

yes, pretty much

fallen patrol May 17, 2021, 9:01 PM

#

have fun

#

i'm currently stuck in a repeat loop and unable to use poetry

patent pivot May 17, 2021, 9:03 PM

#

what's up?

vocal prairie May 17, 2021, 9:04 PM

#

dusky shore

Ooh, such a nice numbered pr with really nice goals

#

That doesn't sound too hard to do after the migrations are over

vale ibex May 17, 2021, 9:08 PM

#

Any idea why we have bs4 listed as a dep in lance?

#

can't see anywhere where it's used

#

Also, pytz isn't needed since we have arrow

patent pivot May 17, 2021, 9:10 PM

#

fallen patrol i'm currently stuck in a repeat loop and unable to use poetry

ping

brazen charm May 17, 2021, 9:12 PM

#

vale ibex Any idea why we have bs4 listed as a dep in lance?

Looks like it was used for the AoC cog's initial implementation

vale ibex May 17, 2021, 9:12 PM

#

Ahhh, that makes sense

fallen patrol May 17, 2021, 9:37 PM

#

patent pivot ping

its not directly #dev-contrib related, & i did fix it, partly

patent pivot May 17, 2021, 9:38 PM

#

ah

fallen patrol May 17, 2021, 9:38 PM

#

its partially related since i had to fix it on my sir lancebot as well

#

i'll type it up in #ot2-never-nester’s-nightmare

gritty wind May 17, 2021, 9:40 PM

#

Whenever an exception is raised in a project

#

The sentry sdk sees it

#

and ships off to sentry.io

fallen patrol May 17, 2021, 9:40 PM

#

https://sentry.io fwiw

Sentry

Application Monitoring and Error Tracking Software

Self-hosted and cloud-based error monitoring that helps software teams discover, triage, and prioritize errors in real-time.

gritty wind May 17, 2021, 9:40 PM

#

Where we can see all our exceptions

fallen patrol May 17, 2021, 9:41 PM

#

you can get a paid plan but

#

also get it free

remote wigeon May 17, 2021, 9:42 PM

#

you can always selfhost CatRee

fallen patrol May 17, 2021, 9:42 PM

#

no, not really.

#

sentry isn't really self hostable

remote wigeon May 17, 2021, 9:43 PM

#

https://develop.sentry.dev/self-hosted/

Self-Hosted Sentry

In addition to making its source code available publicly, Sentry offers and maintains a minimal setup that works out-of-the-box for simple use cases. This repos

fallen patrol May 17, 2021, 9:43 PM

#

I STAND CORRECTED

remote wigeon May 17, 2021, 9:43 PM

#

https://github.com/getsentry/onpremise

GitHub

getsentry/onpremise

Sentry On-Premise setup. Contribute to getsentry/onpremise development by creating an account on GitHub.

patent pivot May 17, 2021, 9:43 PM

#

yeah sentry is oss

remote wigeon May 17, 2021, 9:44 PM

#

kinda pita

#

but decent enough

stable mountainBOT May 17, 2021, 10:33 PM

#

@fervent sage

It has arrived!

Here's your reminder: ^.
[Jump back to when you created the reminder](#dev-contrib message)

vale ibex May 17, 2021, 10:56 PM

#

@sleek steppe oh no 😦 I didn't realise other commands would reference that const

#

lol

sleek steppe May 17, 2021, 10:56 PM

#

lmao

vale ibex May 17, 2021, 10:57 PM

#

luckily it's easy fix too

sleek steppe May 17, 2021, 10:57 PM

#

yep

clever wraith May 17, 2021, 10:58 PM

#

Woohoo my first bot pr is up

vale ibex May 17, 2021, 10:59 PM

#

sleek steppe yep

#

😄

vale ibex May 17, 2021, 10:59 PM

#

clever wraith Woohoo my first bot pr is up

Nice! 😄

sleek steppe May 17, 2021, 11:01 PM

#

Is it fine that I've been ignoring the error in .aoc join lol

#

wait it doesn't error for lancebot for some reason 🤔

vale ibex May 17, 2021, 11:02 PM

#

Is it an empty sequence error?

sleek steppe May 17, 2021, 11:02 PM

#

ye

vale ibex May 17, 2021, 11:02 PM

#

Yea, that's from not having any leaderboards locally

short snow May 18, 2021, 2:35 AM

#

Is America/Chicago EST timezone?

stable mountainBOT May 18, 2021, 2:45 AM

#

@short snow

It has arrived!

Here's your reminder: do now.
[Jump back to when you created the reminder](#dev-contrib message)

sleek steppe May 18, 2021, 2:46 AM

#

lol you reviewed before the reminder came

fervent sage May 18, 2021, 2:46 AM

#

stable mountain <@297045071457681409>

!remind 14h do now mmLol

stable mountainBOT May 18, 2021, 2:46 AM

#

Sure thing!

Your reminder will arrive in 14 hours!

fallen patrol May 18, 2021, 2:48 AM

#

short snow Is `America/Chicago` EST timezone?

no lol

#

America/Detroit
America/NewYork

thorny obsidian May 18, 2021, 2:50 AM

#

short snow Is `America/Chicago` EST timezone?

Chicago is CST/CDT. So one hour before EST/EDT

short snow May 18, 2021, 2:50 AM

#

sure? Chris had set that as EST timezone in the aoc pr

thorny obsidian May 18, 2021, 2:50 AM

#

Silly brit, not knowing our confusing and inconsistent american timezones

fallen patrol May 18, 2021, 2:50 AM

#

yeah

#

i live in the est timezone so i'm 110% sure

short snow May 18, 2021, 2:51 AM

#

https://github.com/python-discord/sir-lancebot/blob/38e7ca7e8530fc9175b79724812892eb82907228/bot/exts/christmas/advent_of_code/_helpers.py#L50..L52

stable mountainBOT May 18, 2021, 2:51 AM

#

bot/exts/christmas/advent_of_code/_helpers.py lines 50 to 52

# Create an easy constant for the EST timezone
EST = "America/Chicago"```

fervent sage May 18, 2021, 2:51 AM

#

thorny obsidian Silly brit, not knowing our confusing and inconsistent american timezones

hang on are you telling me the whole US isnt UTC-5 ??!!! mmLol

sleek steppe May 18, 2021, 2:51 AM

#

EST is UTC-5 though

fallen patrol May 18, 2021, 2:51 AM

#

thorny obsidian Silly brit, not knowing our confusing and inconsistent american timezones

its like the rest of the world..... India is worse even.

thorny obsidian May 18, 2021, 2:51 AM

#

fervent sage hang on are you telling me the whole US isnt UTC-5 ??!!! <:mmLol:356831697385422...

I meaaaan. The best part of the US is

#

Arizona fucks up everything timezone wise

fallen patrol May 18, 2021, 2:52 AM

#

sleek steppe EST is UTC-5 though

mhm. Daylight savings.

fallen patrol May 18, 2021, 2:52 AM

#

thorny obsidian Arizona fucks up everything timezone wise

indiana doesn't even do it iirc

short snow May 18, 2021, 2:54 AM

#

what would be the right EST timezone?

thorny obsidian May 18, 2021, 2:55 AM

#

New York, we're in EDT currently though. But for AOC we should be in EST.

short snow May 18, 2021, 2:56 AM

#

alright

#

its 11pm for you guys, i thought india had a 12 hour game

fallen patrol May 18, 2021, 3:04 AM

#

thorny obsidian New York, we're in EDT currently though. But for AOC we should be in EST.

which we will when it occurs lol

#

so est/edt is the proper timezone

short snow May 18, 2021, 5:35 AM

#

bump

exotic ember May 18, 2021, 5:39 AM

#

is this sir-lancebot?

short snow May 18, 2021, 5:47 AM

#

yeah

exotic ember May 18, 2021, 6:07 AM

#

the extensions are loaded in bot/__main__, so there

short snow May 18, 2021, 6:10 AM

#

exotic ember the extensions are loaded in `bot/__main__`, so there

same way using a async loop?

exotic ember May 18, 2021, 6:13 AM

#

I have no idea what you want to do actually, I thought you were asking where to run code before extensions are loaded

#

what's this for?

short snow May 18, 2021, 6:14 AM

#

Its for https://github.com/python-discord/sir-lancebot/issues/705, I want to call that function get_unloaded_extensions before I start loading all the cogs

exotic ember May 18, 2021, 6:21 AM

#

yeah, at first glance I don't see why you couldn't just get the loop and do cog loading/skip loading there

#

while you're at it extensions.py has a module level constant EXTENSIONS, you should probably walk that rather than call walk_extensions() again

short snow May 18, 2021, 6:30 AM

#

alright, just wanted to know if that's the best way to do it

#

Is this fine?

#

for testing, I am injecting them manually just after redis gets connected

green oriole May 18, 2021, 7:02 AM

#

Can you post that to #dev-alerts btw? (Not sure where it is atm)

vale ibex May 18, 2021, 7:14 AM

#

thorny obsidian New York, we're in EDT currently though. But for AOC we should be in EST.

Aaaaa

#

I hate timezones

#

I even spent a good 3 minutes on Google

short snow May 18, 2021, 7:20 AM

#

green oriole Can you post that to <#820712029245538314> btw? (Not sure where it is atm)

yeah, its getting posted there

#

look at this, how to get cog name from a cog object, before the cog is loaded 🤦‍♂️

#

is there a better way

#

this works for all cases except

#

when you put a object in the file name

placid ermine May 18, 2021, 7:51 AM

#

short snow is there a better way

cog.qualified_name?

short snow May 18, 2021, 8:57 AM

#

placid ermine `cog.qualified_name`?

that would return the cog name not bot.ext.everygreen...

green oriole May 18, 2021, 9:03 AM

#

f"{inspect.getmodule(cog).__name__}.{cog.qualified_name}" maybe?

short snow May 18, 2021, 10:18 AM

#

oops yeah that's what I did, sorry forgot to reply earlier.

short snow May 18, 2021, 10:49 AM

#

https://github.com/python-discord/sir-lancebot/pull/745/checks?check_run_id=2609367724 has been running from 31 minutes

#

Chris 👀

#

@vale ibex pithink is that because of the stuff you did to workflows?

vale ibex May 18, 2021, 10:58 AM

#

lemme take a look

#

huh, it's not even in progress

#

it's stuck starting

#

lemme check other repos

#

https://github.com/python-discord/bot/actions

#

🤔

#

~~@patent pivot Could you take a look at the org level workflow view? Are we hitting concurrency limits?~~

#

https://www.githubstatus.com/

GitHub Status

Welcome to GitHub's home for real-time and historical data on system performance.

#

looks like github is having issues with actions atm

vale ibex May 18, 2021, 11:05 AM

#

short snow <@!126811506632294400> <:pithink:652247559909277706> is that because of the stuf...

This doesn't seem related to my recent changes, but do keep an eye out anyway, since thing we're using is still in beta

patent pivot May 18, 2021, 11:08 AM

#

hmmmmm

vale ibex May 18, 2021, 11:10 AM

#

Update - We have confirmed that run starts are delayed for a number of customers. We have identified the issue and are working on a fix.

#

from an hour ago

#

probably just need to wait it out

green oriole May 18, 2021, 11:11 AM

#

Can always restart it

vale ibex May 18, 2021, 11:11 AM

#

I did restart them

#

didn't fix, just got stuck again

green oriole May 18, 2021, 11:18 AM

#

Maybe the cache

#

Should probably wait it out, yeah

short snow May 18, 2021, 11:39 AM

#

vale ibex This doesn't seem related to my recent changes, but do keep an eye out anyway, s...

oh alright, I thought iceman's actions worked out and I had WIP on earlier to the checks didn't run.

fervent sage May 18, 2021, 12:52 PM

#

object why did you thumbs up your own issue lmao

placid ermine May 18, 2021, 12:57 PM

#

lol

clever wraith May 18, 2021, 1:03 PM

#

fervent sage object why did you thumbs up your own issue lmao

sounds like something he'd do

clever wraith May 18, 2021, 2:30 PM

#

green oriole Can always restart it

yeah its just that issues are fucked atm

vocal wolf May 18, 2021, 2:34 PM

#

https://github.com/python-discord/bot/pull/1594#discussion_r633759351

@sleek steppe shouldn't this return a Coroutine object that isn't lowercase?

sleek steppe May 18, 2021, 2:34 PM

#

!e

async def test():...
print(type(test()))

stable mountainBOT May 18, 2021, 2:34 PM

#

@sleek steppe :white_check_mark: Your eval job has completed with return code 0.

001 | <string>:2: RuntimeWarning: coroutine 'test' was never awaited
002 | RuntimeWarning: Enable tracemalloc to get the object allocation traceback
003 | <class 'coroutine'>

vocal wolf May 18, 2021, 2:35 PM

#

huh

#

I was thinking this was coming from typing.Coroutine

sleek steppe May 18, 2021, 2:35 PM

#

oh lol

vocal wolf May 18, 2021, 2:35 PM

#

in that case, nevermind

#

@fervent sage poke https://github.com/python-discord/bot/pull/1594

fervent sage May 18, 2021, 2:36 PM

#

!reminders

stable mountainBOT May 18, 2021, 2:36 PM

#

Missing required argument

expiration

fervent sage May 18, 2021, 2:36 PM

#

:/

sleek steppe May 18, 2021, 2:36 PM

#

It would be cool is remind list had that root alias 👀

fervent sage May 18, 2021, 2:36 PM

#

im porting it to a site guide soon™️

clever wraith May 18, 2021, 2:37 PM

#

@short snow the cowsay command art is broken on mobile, and beavis was fine on my side

short snow May 18, 2021, 2:40 PM

#

clever wraith <@!736234578745884682> the cowsay command art is broken on mobile, and beavis wa...

see what i just commented

clever wraith May 18, 2021, 2:40 PM

#

I just saw, do you suggest beavis is removed?

#

or should we tighten the character limit on beavis

sleek steppe May 18, 2021, 2:42 PM

#

I feel like it should sent an error message if it gets an HTTPException

clever wraith May 18, 2021, 2:43 PM

#

alright i can do that

#

so i shouldnt use suppress and instead use try except?

sleek steppe May 18, 2021, 2:43 PM

#

yes

gritty wind May 18, 2021, 4:35 PM

#

People that are developing

#

forms.pythondiscord.com

sleek steppe May 18, 2021, 4:38 PM

#

sir-lancebot#740 and sir-lancebot#741 are both small bug fixes that needs a core dev approval

dusky shoreBOT May 18, 2021, 4:38 PM

#

GitHub

PROpen fix: Handle a KeyError when using .quiz stop
PROpen fix: Send the right help message for .src help

#

GitHub

IssueClosed Configure Azure Pipelines to only build & push for master

#

GitHub

IssueOpen Edit on GitHub for content articles.

gritty wind May 18, 2021, 4:40 PM

#

I explained the links here yesterday

#

what are you struggling with?

#

the technical implementation is mostly this

#

the visual part is mostly up to you

#

You'll wanna do it using the path from the URL

vocal prairie May 18, 2021, 4:42 PM

#

You should be able to do it on the page that renders the markdown pages. (the button)

gritty wind May 18, 2021, 4:43 PM

#

for example the contributing home page is at:
https://pythondiscord.com/pages/guides/pydis-guides/contributing/

#

The visual design is completely up to you

#

There is an example positioning on the issue itself

#

I like it there, but if you figure another place it works, that's fine too

stable mountainBOT May 18, 2021, 4:46 PM

#

@fervent sage

It has arrived!

Here's your reminder: do now :mmLol:.
[Jump back to when you created the reminder](#dev-contrib message)

vale ibex May 18, 2021, 4:47 PM

#

sleek steppe sir-lancebot#740 and sir-lancebot#741 are both small bug fixes that needs a core...

out of interest, where did the need for unwrap come from?

vocal prairie May 18, 2021, 4:47 PM

#

You don't need to manually write css

sleek steppe May 18, 2021, 4:48 PM

#

vale ibex out of interest, where did the need for unwrap come from?

https://discordapp.com/channels/267624335836053506/635950537262759947/843585416501133332

vocal prairie May 18, 2021, 4:48 PM

#

Bulma should have everything you need to make a button.

#

The Bulma button?

vale ibex May 18, 2021, 4:49 PM

#

Github is still having issues with actions, might be a while until things get merged/deployed
https://www.githubstatus.com/

sleek steppe May 18, 2021, 4:49 PM

#

oh this isn't gonna get merged any time soon

vocal prairie May 18, 2021, 4:50 PM

#

The Bulma button is what's used across the site, so I'd say you should use that to ensure concistency.

#

You can style the outline to look like what it has in the issue using Bulma too.

#

Is that a custom button?

#

https://bulma.io/documentation/elements/button/ You need the button class too

thorny obsidian May 18, 2021, 4:52 PM

#

the class is what applies the bulma styling, it won't apply via the <button>

vocal prairie May 18, 2021, 4:58 PM

#

is-flex

#

That will also make it so that if a person's screen is too small, it'll go onto two lines.

#

is-inline should work too, but it'll force it all onto one line even if it's a small screen.

#

I wonder why is-flex didn't work.

#

Can you share the html?

#

That should be on the parent element btw.

#

Put is-flex next to content

#

And remove is-inline

#

Oh crap

#

One sec

#

I know what went wrong

#

   <section class="section">
        <div class="container">
            <div class="content">
                <div class="is-flex">
                    <h1 class="title is-inline">{{ page_title }}</h1>
                    <button class="button is-inline">This is a button</button>
                </div>
                {% block page_content %}{% endblock %}
            </div>
        </div>
    </section>```

#

is-inline will force it onto one line, even if they have a small screen.

#

Which looks really messy

#

vertical end?

#

You want it to be at the bottom of it's horizontal container?

#

is-align-content-flex-end maybe?

#

On the button, not the div above

patent pivot May 18, 2021, 5:23 PM

#

maybe it's a good idea to hook it into the ToC area for guides

vocal prairie May 18, 2021, 5:24 PM

#

^ As part of the sidebar it would look good

#

Table of Contents

patent pivot May 18, 2021, 5:25 PM

#

yeah implementation will be different there

sleek steppe May 18, 2021, 5:37 PM

#

Hey @short snow, two things about sir-lancebot#745:

Should https://github.com/python-discord/sir-lancebot/blob/98f3cec4886586d398bfe567129b2e56c8ce4e7b/bot/bot.py#L50 be there? Or did you forget to remove it?
Once your branch is updated, should this part be changed? https://github.com/python-discord/sir-lancebot/blob/main/bot/exts/evergreen/latex.py#L96-L101

dusky shoreBOT May 18, 2021, 5:37 PM

#

GitHub

PROpen Add logic for preserving unloaded Cogs.

stable mountainBOT May 18, 2021, 5:37 PM

#

bot/bot.py line 50

await self.unloads_cache.set("unloaded", 'bot.exts.evergreen.catify | bot.exts.evergreen.xkd')```
`bot/exts/evergreen/latex.py` lines 96 to 101
```py
# As we have resource issues on this cog,
# we have it currently disabled while we fix it.
import logging
logging.info("Latex cog is currently disabled. It won't be loaded.")
return
bot.add_cog(Latex())```

gritty wind May 18, 2021, 5:48 PM

#

It seems I was half right about the path

#

Pages that start with pages in the path are in the content app

#

Pages that start with resources are in the resources app

sleek steppe May 18, 2021, 7:58 PM

#

Why do I get this error when running docker-compose up in snekbox?

Creating snekbox_dev ... error

ERROR: for snekbox_dev  Cannot create container for service snekbox: invalid volume specification: '.::rw': invalid mount config for type "volume": field Target must not be empty

ERROR: for snekbox  Cannot create container for service snekbox: invalid volume specification: '.::rw': invalid mount config for type "volume": field 
Target must not be empty
ERROR: Encountered errors while bringing up the project.

sleek steppe May 18, 2021, 8:22 PM

#

Hey @tawdry vapor do you know any fixes for this? Also, I'm not sure how to go about writing the test for nsjail args

gritty wind May 18, 2021, 8:24 PM

#

What OS are you on

sleek steppe May 18, 2021, 8:25 PM

#

windows 10

gritty wind May 18, 2021, 8:25 PM

#

change line 27 in the docker-compose to .:./

sleek steppe May 18, 2021, 8:27 PM

#

gritty wind change line 27 in the docker-compose to `.:./`

Now I get

Creating snekbox_snekbox_run ... error

ERROR: for snekbox_snekbox_run  Cannot create container for service snekbox: invalid volume specification: '.../PyDis/snekbox:./:rw': invalid mount config for type "bind": invalid mount path: './' mount path must be absolute

ERROR: for snekbox  Cannot create container for service snekbox: invalid volume specification: '.../PyDis/snekbox:./:rw': invalid mount config for type "bind": invalid mount path: './' mount path must be absolute

gritty wind May 18, 2021, 8:27 PM

#

try .:/

#

actually

#

Try .:/snekbox

sleek steppe May 18, 2021, 8:28 PM

#

I think that worked

#

yep it worked, thanks

tawdry vapor May 18, 2021, 8:30 PM

#

That's wrong

#

I believe coverage results will be incorrect if the same path isn't used

#

It's PWD on both sides for a reason

#

You can't use relative paths on the right

#

And I don't know of a PWD equivalent on Windows

gritty wind May 18, 2021, 8:31 PM

#

PWD isn't a command on windows

tawdry vapor May 18, 2021, 8:31 PM

#

So, basically it will never work on Windows

gritty wind May 18, 2021, 8:31 PM

#

cd

#

that'll print the cwd

tawdry vapor May 18, 2021, 8:31 PM

#

There's no way to make it cross platform

fallen patrol May 18, 2021, 9:10 PM

#

tawdry vapor And I don't know of a PWD equivalent on Windows

#

#

its pwd if on powershell

sleek steppe May 18, 2021, 9:13 PM

#

yep, but on cmd it is cd

vale ibex May 18, 2021, 9:44 PM

#

github actions seem to be good now

#

I'm going to kick off the jobs that failed on main

#

alright that should be all the failed jobs re running now

sleek steppe May 18, 2021, 9:52 PM

#

you missed sir-lancebot though 😔

patent pivot May 18, 2021, 9:52 PM

#

no one cares about sir lancebot

sleek steppe May 18, 2021, 9:53 PM

#

lol true

patent pivot May 18, 2021, 9:53 PM

#

which runs failed

sleek steppe May 18, 2021, 9:53 PM

#

I ran them 😛

thorny obsidian May 18, 2021, 9:53 PM

#

I care about sir lance!!

vale ibex May 18, 2021, 9:56 PM

#

wait, I did run sir-lance?

#

#dev-log message

sleek steppe May 18, 2021, 9:58 PM

#

ah I thought you were talking about the errored lint jobs

vale ibex May 18, 2021, 9:58 PM

#

Ahh nah, those are from when i tried to re-run the same one again

fallen patrol May 18, 2021, 9:59 PM

#

Use flake8, they said. Use poetry, they said. It'll make your life easier, they said.

#

its scanning the site packages ;-;

#

any way to fix this

#

gritty wind May 18, 2021, 10:02 PM

#

If your venv is in your project’s directory (it really shouldn’t), mark it as ignored

fallen patrol May 18, 2021, 10:03 PM

#

its not

vale ibex May 18, 2021, 10:03 PM

#

insert into messages select generate_series(11,150), 'user_id_here', 'f', NOW() + (random() * (NOW()+'90 days' - NOW())) + '30 days', 1234;

#

a quick sql statement I ran to seed metricity, in case it's useful for anyone

#

the weird time stuff is so that you get enough time blocks to pass voice gate

fallen patrol May 18, 2021, 10:04 PM

#

gritty wind If your venv is in your project’s directory (it really shouldn’t), mark it as ig...

its not

gritty wind May 18, 2021, 10:05 PM

#

Not really sure what to tell ya

#

Why is flake scanning your venv folder

#

Is that something your IDE is doing

fallen patrol May 18, 2021, 10:06 PM

#

it could be

#

well my lance clone isn't having issues anymore

#

so gonna move to #tools-and-devops since i'm still having issues

clever wraith May 18, 2021, 10:15 PM

#

congrats on whoever made the blocking tag

sleek steppe May 18, 2021, 10:22 PM

#

@tawdry vapor for the nsjail args test, how would that work? I'm not sure what are valid nsjail args

tawdry vapor May 18, 2021, 10:29 PM

#

It doesn't matter

#

It's even sufficient to pass "poop" as an argument and just check that it ends up where it's suppose to

sleek steppe May 18, 2021, 10:30 PM

#

ah I see

fallen patrol May 18, 2021, 10:31 PM

#

tawdry vapor It's even sufficient to pass "poop" as an argument and just check that it ends u...

nsjail passing gas

thorny obsidian May 18, 2021, 10:35 PM

#

whiiiiich staff member wants to review a literal 2 line change to a markdown file? https://github.com/python-discord/site/pull/507

GitHub

Update FAQ to clarify reasoning for disallowing certain file types ...

Small PR that clarifies why we don't allow .py and .txt filetypes even though Discord does offer (limited) support for previewing them.

patent pivot May 18, 2021, 10:35 PM

#

pls no one merge that

#

lol

thorny obsidian May 18, 2021, 10:35 PM

#

D:

patent pivot May 18, 2021, 10:35 PM

#

i am just altering some review policy stuff

#

so just hold 60 secs

thorny obsidian May 18, 2021, 10:36 PM

#

god I loathe coveralls

patent pivot May 18, 2021, 10:36 PM

#

lol

#

sasme

thorny obsidian May 18, 2021, 10:37 PM

#

Coveralls has the same energy as fucking clippy

patent pivot May 18, 2021, 10:37 PM

#

okay, review policy altered

fallen patrol May 18, 2021, 10:37 PM

#

just don't use it

#

ez

#

manually merge it lol

#

#

it took longer than that to upload than it took for joe to merge it smh

patent pivot May 18, 2021, 10:37 PM

#

I've added a review policy item so site content can be shortcutted by 1 admin approval or 2 staff

fallen patrol May 18, 2021, 10:38 PM

#

everything is slower rn since flake8 is scanning my entire hard disk it seems

patent pivot May 18, 2021, 10:38 PM

#

#

it's probably scanning your venv, if you didn't ignore it

fallen patrol May 18, 2021, 10:38 PM

#

I tried multiple times

#

see either #help-donut or #tools-and-devops and Imma go to it with you

patent pivot May 18, 2021, 10:39 PM

#

latter

clever wraith May 18, 2021, 10:46 PM

#

thorny obsidian Coveralls has the same energy as fucking clippy

I swear clippy was just a virus embedded into Microsoft office

sleek steppe May 19, 2021, 12:06 AM

#

Is there any reason the !eval command has code as optional but sends the help command when nothing is passed 🤔

tawdry vapor May 19, 2021, 12:07 AM

#

Doesn't it have to be optional so it can show help when nothing is passed?

sleek steppe May 19, 2021, 12:08 AM

#

The error handler catches it and sends the help message

#

and tells you you're missing an argument

#

Snekbox's lint & test is failing 🤔

short snow May 19, 2021, 12:28 AM

#

sleek steppe Hey <@!736234578745884682>, two things about sir-lancebot#745: 1. Should https:/...

So for your first question, I kept it so that reviewers can test it out, and I could remove that towards the end.

coming to the second question, I wasn’t sure if I had to remove it so didn’t, I could do that now.

sleek steppe May 19, 2021, 12:31 AM

#

Sounds good 👍

fallen patrol May 19, 2021, 12:32 AM

#

why are these on different bots?

#

#

it seems related enough that it should be on the same bot

tawdry vapor May 19, 2021, 12:41 AM

#

sleek steppe The error handler catches it and sends the help message

It's just something many commands do to show help when invoked without arguments. I suppose it is redundant.

#

I don't remember if help was always shown with the error.

tawdry vapor May 19, 2021, 12:42 AM

#

sleek steppe Snekbox's lint & test is failing 🤔

git should be installed. there's a CI step for it

sleek steppe May 19, 2021, 12:42 AM

#

Hmm, wonder why it error'd then

sleek steppe May 19, 2021, 12:45 AM

#

tawdry vapor git should be installed. there's a CI step for it

Is there any other reason that error should be raised?

#

The install git job passed but the pre-commit just fails

tawdry vapor May 19, 2021, 12:46 AM

#

I don't know. You'd have to check the log

sleek steppe May 19, 2021, 12:46 AM

#

How do you do that 🤔

tawdry vapor May 19, 2021, 12:47 AM

#

Edit the workflow to cat the log file

#

Then rerun it

#

Would be a good permanent addition

#

If you can figure out how to make that step run only when precommit fails

sleek steppe May 19, 2021, 12:52 AM

#

tawdry vapor Edit the workflow to cat the log file

How do you do that?

tawdry vapor May 19, 2021, 12:56 AM

#

Do you know what cat means?

sleek steppe May 19, 2021, 12:57 AM

#

It's a command?

tawdry vapor May 19, 2021, 12:58 AM

#

Are you asking how to use the cat command or how to edit the workflow?

sleek steppe May 19, 2021, 12:58 AM

#

How to edit the workflow

tawdry vapor May 19, 2021, 12:59 AM

#

it's in the .github/workflows directory

sleek steppe May 19, 2021, 12:59 AM

#

Oh so you want me to commit the change

tawdry vapor May 19, 2021, 12:59 AM

#

Yes, because you cannot run the workflow any other way.

#

Which is why debugging CI is annoying.

sleek steppe May 19, 2021, 1:06 AM

#

I think I did it wrong

#

because it doesn't show the log file

tawdry vapor May 19, 2021, 1:14 AM

#

Try making it a separate step instead, like I originally suggested

sleek steppe May 19, 2021, 1:14 AM

#

ah

tawdry vapor May 19, 2021, 1:15 AM

#

Feel free to amend and force push so you don't end up with a bunch of commits for debugging CI

#

Keep in mind it normally won't run subsequent steps if a step fails

#

You need to configure it to run even on failure, or ideally, run only on failure of the precommit step.

sleek steppe May 19, 2021, 1:22 AM

#

I think I found a way to do that

#

yeah that didn't work

#

@tawdry vapor I got it

#

and it failed

tawdry vapor May 19, 2021, 1:38 AM

#

The log would be inside the container

sleek steppe May 19, 2021, 1:39 AM

#

ah my bad

#

Alright it worked this time

#

https://paste.pythondiscord.com/rajuvulavi.sql

#

@tawdry vapor is it because it isn't in a git repository?

clever wraith May 19, 2021, 1:55 AM

#

Hey <@&267628507062992896> you might know already but the github actions status embeds are down

tawdry vapor May 19, 2021, 1:58 AM

#

sleek steppe <@!137073073168973824> is it because it isn't in a git repository?

Probably; the .git directory doesn't get copied.

#

I don't understand why it even wants it though.

#

It's set to run on all files.

#

Might be a recent update that changed the behaviour

sleek steppe May 19, 2021, 2:02 AM

#

tawdry vapor Might be a recent update that changed the behaviour

this is the version of pre-commit for snekbox https://github.com/python-discord/snekbox/blob/main/Pipfile#L26 and this is the version for bot https://github.com/python-discord/bot/blob/main/pyproject.toml#L47

stable mountainBOT May 19, 2021, 2:02 AM

#

Pipfile line 26

pre-commit = "~= 2.9.3"```
`pyproject.toml` line 47
```toml
pre-commit = "~=2.1"```

sleek steppe May 19, 2021, 2:03 AM

#

Should I try downgrading and see if that works?

tawdry vapor May 19, 2021, 2:04 AM

#

https://github.com/pre-commit/pre-commit/issues/1894

GitHub

Using pre-commit on gitignored files, or outside of a git repo · Is...

Is it possible to use pre-commit on files that are git-ignored (or even outside of a git repository)? I know pre-commit is meant to be used, ahm, pre commit. But it turns out that pre-commit is sup...

#

Maybe we should just copy the git directory over

#

Or git init && git add . might be simpler.

sleek steppe May 19, 2021, 2:26 AM

#

tawdry vapor Maybe we should just copy the git directory over

I think this one would work

#

but how do you do that?

#

git clone?

tawdry vapor May 19, 2021, 2:30 AM

#

No you'd have to copy the .git folder over. I actually think initiating a new repo would be easier

sleek steppe May 19, 2021, 2:31 AM

#

Yeah, but it says .pre-commit-config.yaml does not exist

tawdry vapor May 19, 2021, 2:32 AM

#

What the fuck

#

How did this ever work before

#

I don't understand how. My best guess is that the .dockerignore was not being respected in CI.

#

Maybe we should just unignore the config and the git directory?

#

I don't really like putting stuff in the container that's only used for CI, but I suppose it won't make a big difference on size. Plus, tests are already being included anyway.

#

Actually, copying over the git directory may fuck up the ability to cache layers.

#

Oh, I see how it was working. I completely forgot volumes are a thing in Docker.

#

It just relies on docker compose to mount the cwd

#

Since you changed the docker-compose volume, it broke everything

#

And as I said, that mount is wrong for other reasons anyway.

sleek steppe May 19, 2021, 2:57 AM

#

Didn't I only change it locally?

tawdry vapor May 19, 2021, 2:57 AM

#

No. It's checked in.

sleek steppe May 19, 2021, 2:57 AM

#

Ah that's my mistake

tawdry vapor May 19, 2021, 2:57 AM

#

So.... yeah just rebase and drop that commit along with the attempted CI fixes, though I suppose leaving the log cat is okay.

#

Ah it's part of some other commit so you can't just drop it, but you can rebase and edit it.

short snow May 19, 2021, 3:07 AM

#

bot#1120 should be moved to lance

dusky shoreBOT May 19, 2021, 3:07 AM

#

GitHub

IssueOpen Escape square brackets in reddit post bodies

sleek steppe May 19, 2021, 3:09 AM

#

Ah nice it worked, I can't believe I made a mistake like that lol

sleek steppe May 19, 2021, 3:10 AM

#

short snow bot#1120 should be moved to lance

I wonder if it's still valid 🤔

#

yeah it probably is

#

For bot#1597, do we even filter invites?

dusky shoreBOT May 19, 2021, 3:17 AM

#

GitHub

IssueOpen Delete Discord Server List Server Links

short snow May 19, 2021, 3:25 AM

#

yes, https://github.com/python-discord/bot/blob/main/bot/exts/filters/filtering.py#L495..L562

tawdry vapor May 19, 2021, 3:26 AM

#

I transferred that issue

fallen patrol May 19, 2021, 4:24 AM

#

@tawdry vapor reddit, I see nothing weird.

#

sir-lancebot#746

dusky shoreBOT May 19, 2021, 4:25 AM

#

GitHub

IssueOpen Escape square brackets in reddit post bodies

tawdry vapor May 19, 2021, 4:30 AM

#

I don't understand what you are trying to say

hardy gorge May 19, 2021, 5:21 AM

#

clever wraith Hey <@&267628507062992896> you might know already but the github actions status ...

That's interesting. I can't find a lot about it, except for runs that show an error stating that GitHub Actions encountered an internal error. It seemed to have been temporary, but I'll look into it later to day to see what was up.

eternal owl May 19, 2021, 6:04 AM

#

haha

#

for the adding Off topic names using post request to the site, why are we passing the ot-name as a query param instead of passing it in the request body?

#

no, but typically with a post request, the data is in the request body

#

we could avoid some code in the backend as the ModelViewSet could handle it if we used request body

#

just don't, pass it with the context

#

you can't xD

exotic ember May 19, 2021, 6:08 AM

#

@clever wraith off the top of my head, custom template tags

eternal owl May 19, 2021, 6:08 AM

#

oh yes, that could work as well

exotic ember May 19, 2021, 6:09 AM

#

https://docs.djangoproject.com/en/3.1/howto/custom-template-tags/

Custom template tags and filters | Django documentation | Django

#

we should have a custom template tag implementation in another app in the repo, you can use that for reference

#

pydis_site/apps/home/templatetags

eternal owl May 19, 2021, 6:10 AM

#

https://github.com/python-discord/site/blob/main/pydis_site/apps/resources/templatetags/as_icon.py

vale ibex May 19, 2021, 8:54 AM

#

Now that we've upgraded to python 3.9, sir-lancebot#610 isn't needed right?

dusky shoreBOT May 19, 2021, 8:54 AM

#

GitHub

PROpen Teapot support

vale ibex May 19, 2021, 8:54 AM

#

Since those codes were added to http package

#

hmmm, I might need to re-read the PR, since it's removing the package entirely and relying on what the APIs respond with

#

might be something we want regardless

green oriole May 19, 2021, 9:09 AM

#

Depends on how we want to validate codes

vale ibex May 19, 2021, 9:09 AM

#

Using the http module did save on requests out

#

but also it's not a huge worry, since it's not really a highly used command

#

i guess the question now is, are there codes supported by the status cat/dog API that aren't by the http module

short snow May 19, 2021, 9:12 AM

#

i don't think there are any right now

vale ibex May 19, 2021, 9:27 AM

#

!e ```py
from http import HTTPStatus
print(*(h.value for h in HTTPStatus), sep='\n')

stable mountainBOT May 19, 2021, 9:27 AM

#

@vale ibex :white_check_mark: Your eval job has completed with return code 0.

001 | 100
002 | 101
003 | 102
004 | 103
005 | 200
006 | 201
007 | 202
008 | 203
009 | 204
010 | 205
011 | 206
... (truncated - too many lines)

Full output: https://paste.pythondiscord.com/mojigoxoxo.txt?noredirect

vale ibex May 19, 2021, 9:28 AM

#

there are 60 codes in httpcat

#

and 59 on status dog

#

62 in http

#

but that's not a real test, since they may not overlap

short snow May 19, 2021, 9:34 AM

#

Its best to request them, or maybe just run a task every x hours to get all the codes from the site

vale ibex May 19, 2021, 9:34 AM

#

I'd rather keep it simple within the bot.

#

I think we should just iter over the codes in http and check if both APIs support them

#

if so, we can close this PR

#

I can do it later after work if someone else hasn't by then.

short snow May 19, 2021, 9:40 AM

#

Hmmm, so to only keep the codes supported by both apis?

vale ibex May 19, 2021, 9:42 AM

#

We want to see if the codes supported by Python 3.9 are a superset of the codes supported by the two APIs

#

if that's the case, then we can use the http package to validate codes, as we are now

short snow May 19, 2021, 9:43 AM

#

Alright, have you tested or should I do it quickly now?

vale ibex May 19, 2021, 9:44 AM

#

I don't have time to write up the script right now

#

So please feel free

short snow May 19, 2021, 9:50 AM

#

alright, time to check now

#

there @vale ibex

vale ibex May 19, 2021, 9:58 AM

#

Ah right, all the unofficial ones

#

I'm surprised about 306 though

#

I guess it's because it's no longer used /s

short snow May 19, 2021, 10:23 AM

#

and
599 is present in cat but not in dog
306 is present in dog but not in cat

vale ibex May 19, 2021, 10:23 AM

#

Yea, 306 isn't used anymore afaik

#

599 isn't official

#

but is used in some places

short snow May 19, 2021, 10:24 AM

#

i don't even know half of them

vale ibex May 19, 2021, 10:24 AM

#

I think we go ahead with this PR and drop the http module

#

it'll be more fun to be able to use the non-official codes

gritty wind May 19, 2021, 10:25 AM

#

You don't know any of them, because there are only like 10 codes ever actually used

short snow May 19, 2021, 10:25 AM

#

yep, chris

short snow May 19, 2021, 10:25 AM

#

gritty wind You don't know any of them, because there are only like 10 codes ever actually u...

lol yes

wicked inlet May 19, 2021, 11:10 AM

#

Thoughts of ending codeblocks like these when the rest of the content is truncated?

fervent sage May 19, 2021, 11:24 AM

#

short snow i don't even know half of them

420: Enhance your calm

patent pivot May 19, 2021, 11:35 AM

#

lol

#

everyone got mad at twitter for using 420

vale ibex May 19, 2021, 11:40 AM

#

Yea, 429 is too mainstream

wise oriole May 19, 2021, 12:24 PM

#

wicked inlet Thoughts of ending codeblocks like these when the rest of the content is truncat...

yes it is kind of unnecessary imho. I even hate the bot randomly dm'ing me I hope there is a feature to opt out of bot dms when a channel is claimed.

wicked inlet May 19, 2021, 12:26 PM

#

yup was definitely not expecting it, prefer to keep it in the actual channel.
But definitely nice to have a log of your previous questions

clever wraith May 19, 2021, 12:47 PM

#

hardy gorge That's interesting. I can't find a lot about it, except for runs that show an er...

Hey Sebastiaan, I've got them up and running for a few repos of mine, are they still down?

vale ibex May 19, 2021, 12:47 PM

#

They seem to be working just fine now

#

see #dev-log

short snow May 19, 2021, 12:52 PM

#

aha, there is onething missing in the quackstack API

#

https://github.com/python-discord/quackstack/blob/96b51e1cdb45c8121bfe0ab0399d7c796c485b46/main.py#L68..L75

stable mountainBOT May 19, 2021, 12:52 PM

#

main.py lines 68 to 75

@app.get("/details")
async def get_details() -> Dict[str, Any]:
    """Get details about accessories which can be used to build ducks."""
    return {
        "hats": list(DuckBuilder.hats.keys()),
        "outfits": list(DuckBuilder.outfits.keys()),
        "equipments": list(DuckBuilder.equipments.keys()),
    }```

short snow May 19, 2021, 12:53 PM

#

it doesn't list manducks

#

should add a query parameter for duck and manduck?

#

cc @fervent sage

vale ibex May 19, 2021, 12:53 PM

#

is the call to .keys() there superfluous? Since if you cast a dict to a list, you'll just get the keys anyway

clever wraith May 19, 2021, 12:54 PM

#

They're up again, just not configured for snekbox

sleek steppe May 19, 2021, 12:54 PM

#

yeah, and that return type hint can be Dict[str, list[str?]]

clever wraith May 19, 2021, 12:54 PM

#

Because 3.9

short snow May 19, 2021, 12:54 PM

#

vale ibex is the call to `.keys()` there superfluous? Since if you cast a dict to a list, ...

Yeah, I can mention that too

#

might also give a bump to quackstack to use python3.9?

fervent sage May 19, 2021, 12:57 PM

#

vale ibex is the call to `.keys()` there superfluous? Since if you cast a dict to a list, ...

yep

fervent sage May 19, 2021, 12:57 PM

#

short snow might also give a bump to quackstack to use python3.9?

go for it

fervent sage May 19, 2021, 12:57 PM

#

short snow should add a query parameter for duck and manduck?

i'd rather

/details/duck and /details/manduck as separate endpoints

short snow May 19, 2021, 12:58 PM

#

If we add more features, that would keep on increasing, I had like ?type=duck/manduck

#

or with some other query name

fervent sage May 19, 2021, 12:58 PM

#

/details/{type}

#

before the details endpoint changes I'd also like to restructure the manduck assets so that they are structured the same as normal ducky for consistency

low hound May 19, 2021, 1:01 PM

#

hey, I want to start contributing to open source, someone suggested me to try sir lancebot, can anyone help me out, all the issues are too overwhelming.

short snow May 19, 2021, 1:01 PM

#

umm, well that would be third time we are changing asset structure lol, but i will look into later

#

btw, what happened about the deepmerge lib?

short snow May 19, 2021, 1:14 PM

#

fervent sage go for it

another question for that, what all do i list, just the accesories?

fervent sage May 19, 2021, 1:16 PM

#

anything customisable that's related to a static asset

short snow May 19, 2021, 1:17 PM

#

{
  "hats":...,
  "outfits":...,
  "equipments":...,
  "gender":...,
}
``` I think that's it

short snow May 19, 2021, 2:13 PM

#

@fervent sage https://github.com/python-discord/quackstack/pull/45 pong, small PR, give it a look once you are free

GitHub

(details): Rework /details endpoint by Shivansh-007 · Pull Request ...

This commit does two major things, it adds a query parameter called type which takes in a string object of the detail they are requesting i.e. either man-duck or ducky as of now. If it is None, the...

sleek steppe May 19, 2021, 2:17 PM

#

I'll give it a review

short snow May 19, 2021, 2:18 PM

#

alright, ty!

vocal prairie May 19, 2021, 2:18 PM

#

Does anyone know how to set the minimum width of a box in Bulma?

short snow May 19, 2021, 2:27 PM

#

once that's done I can upgrade it to python3.9, already tested and it works perfectly 😄

sleek steppe May 19, 2021, 2:30 PM

#

does quackstack not give specific return type hints?

patent pivot May 19, 2021, 2:30 PM

#

fastapi doesn't use return annotations

sleek steppe May 19, 2021, 2:30 PM

#

oh I thought it did

patent pivot May 19, 2021, 2:31 PM

#

https://fastapi.tiangolo.com/tutorial/response-model/

Response Model - FastAPI

FastAPI framework, high performance, easy to learn, fast to code, ready for production

sleek steppe May 19, 2021, 2:31 PM

#

ah I see

patent pivot May 19, 2021, 2:31 PM

#

The response model is declared in this parameter instead of as a function return type annotation, because the path function may not actually return that response model but rather return a dict, database object or some other model, and then use the response_model to perform the field limiting and serialization.

sleek steppe May 19, 2021, 2:32 PM

#

Well, I still think we should use the response model

fervent sage May 19, 2021, 2:32 PM

#

short snow <@!297045071457681409> https://github.com/python-discord/quackstack/pull/45 pong...

why is it using query params instead? it's just more confusing and /details/{type} works fine

fervent sage May 19, 2021, 2:32 PM

#

sleek steppe Well, I still think we should use the response model

already done, not pred yet

short snow May 19, 2021, 2:35 PM

#

fervent sage why is it using query params instead? it's just more confusing and `/details/{ty...

alright, I will do a quick fix for that

#

could we swtich to uvicorn? its faster than hypercorn and supports reloads in docker containers

#

the second point is not really a point since we don't use that, but still

#

pushed, alec and toxic.

#

just curious, is it possible to support both path and query parameters for the same parmeter, type in this case

patent pivot May 19, 2021, 2:45 PM

#

uvicorn is good

short snow May 19, 2021, 2:46 PM

#

who is kgolawaski?

short snow May 19, 2021, 2:47 PM

#

patent pivot uvicorn is good

yep, is that a yes or a no?

patent pivot May 19, 2021, 2:47 PM

#

lol

#

yes from me, would like to hear from others

short snow May 19, 2021, 2:47 PM

#

toxic and his nitpicks 🙇‍♂️

vocal prairie May 19, 2021, 2:48 PM

#

I don't know about Hypercorn, but my experience with Uvicorn and FastAPI has been good

short snow May 19, 2021, 2:49 PM

#

can we add that kek here 🥺 ?

#

and about upgrading to python3.9 on quackstack, i could do that together

sleek steppe May 19, 2021, 2:54 PM

#

Yeah, I think they can both be changed in that PR

short snow May 19, 2021, 2:55 PM

#

alright, just need to get the approve then now

#

merge merge ducky_party

#

toxic can merge 👀 you got powers boy

fervent sage May 19, 2021, 3:01 PM

#

I dont want to switch to uvicorn because it's not fun dealing with the "why didnt you use hypercorn its better" which is the reason i went with hypercorn to start with, and as for speed im pretty sure quackstack gets all of 1 request a month, and the slow bit is image generation not the asgi stuff anyway

sleek steppe May 19, 2021, 3:02 PM

#

short snow toxic can merge 👀 you got powers boy

I just noticed the green merge button after I approved lol

sleek steppe May 19, 2021, 3:02 PM

#

fervent sage already done, not pred yet

When is this PR going to happen? just curious

fervent sage May 19, 2021, 3:03 PM

#

soon, currently working on smth else

short snow May 19, 2021, 3:03 PM

#

fervent sage I dont want to switch to uvicorn because it's not fun dealing with the "why didn...

i am talking about startups, i personally saw uvicorn starts apps faster

short snow May 19, 2021, 3:03 PM

#

sleek steppe I just noticed the green merge button after I approved lol

lol :stonks:

fervent sage May 19, 2021, 3:04 PM

#

hypercorn starts up faster for me /shrug

short snow May 19, 2021, 3:04 PM

#

👀 alright, lets just leave it then, and python3.9 upgrade?

fervent sage May 19, 2021, 3:04 PM

#

hm

#

after consideration, I'll make a pr for 3.9 and using uvicorn

short snow May 19, 2021, 3:05 PM

#

that's exactly what i said lmao, ok

fervent sage May 19, 2021, 3:05 PM

#

i like uvicorn more just as a general thing, and I can just tell people who get annoyed at me for using it "lol /shrug"

thorny obsidian May 19, 2021, 3:06 PM

#

I hereby give you permission to tell people to "get wrekt" if they ask about hypercron or uvicorn since it.. really doesn't matter

short snow May 19, 2021, 3:06 PM

#

hmm, i saw people moving from hypercorn to uvicorn but never the other way around

green oriole May 19, 2021, 3:06 PM

#

That's one tool I never looked into and I don't plan to

fervent sage May 19, 2021, 3:06 PM

#

I only used hypercorn because i was told by 2 people "ew dont use uvicorn hypercorn is better"

sleek steppe May 19, 2021, 3:06 PM

#

I like uvicorn better ¯_(ツ)_/¯

green oriole May 19, 2021, 3:07 PM

#

It looks so uninteresting

fervent sage May 19, 2021, 3:07 PM

#

so i decided to give it a shot

short snow May 19, 2021, 3:07 PM

#

the tool here is? akarys

fervent sage May 19, 2021, 3:07 PM

#

i have used hc in one project

#

and will never again kek

short snow May 19, 2021, 3:07 PM

#

ty, i got the source of kek 🙃 for #community-meta

green oriole May 19, 2021, 3:08 PM

#

short snow the tool here is? akarys

Uvicorn and the similars

short snow May 19, 2021, 3:08 PM

#

oh

#

also we can continue the other issues on quackstack now, since we have enough features on the api now

#

and not deffer them, like i commented on the flesh out readme issue

patent pivot May 19, 2021, 3:10 PM

#

I still need to specify S3

#

we should also have a landing page

#

probably something similar to https://policy-bot.pythondiscord.com/

fervent sage May 19, 2021, 3:10 PM

#

I dont have a way to test s3 stuff locally pensivewobble

patent pivot May 19, 2021, 3:10 PM

#

just project logo and docs

#

lol I'll just provision you creds, but minio is good for self-hosted S3

short snow May 19, 2021, 3:12 PM

#

Minio?

#

Wouldn’t GitHub pages do?

patent pivot May 19, 2021, 3:12 PM

#

not for S3, no

#

minio is a self-hosted S3 server

#

https://github.com/minio/minio

GitHub

minio/minio

High Performance, Kubernetes Native Object Storage - minio/minio

#

quackstack will eventually send uploaded images to an S3 bucket, since ideally we don't want to serve static files

short snow May 19, 2021, 3:14 PM

#

Basically, making the setup complex lol

patent pivot May 19, 2021, 3:14 PM

#

not really

#

S3 is simple

#

you just plug in your endpoint and it's usually just one call to upload

#

like

#

simple really is in the name

#

S3 stands for Simple Storage Service

short snow May 19, 2021, 3:15 PM

#

Yeah, I am reading his biography right now, but I would need to get Amazon services account.

patent pivot May 19, 2021, 3:15 PM

#

No, you can use minio

#

it's just a single docker container, no config

fervent sage May 19, 2021, 3:16 PM

#

pydis would be using linode's S3 compatible object storage not amazon btw

patent pivot May 19, 2021, 3:16 PM

#

yeah

fervent sage May 19, 2021, 3:16 PM

#

:)

short snow May 19, 2021, 3:16 PM

#

patent pivot No, you can use minio

Oh right

sleek steppe May 19, 2021, 3:18 PM

#

need devops daddy approval

short snow May 19, 2021, 3:19 PM

#

Joeeeeeee

#

btw, is ledger still in development didn’t see any progress on it in a while?

patent pivot May 19, 2021, 3:20 PM

#

sleek steppe need devops daddy approval

linky link

patent pivot May 19, 2021, 3:20 PM

#

short snow btw, is ledger still in development didn’t see any progress on it in a while?

pending me finishing exams

sleek steppe May 19, 2021, 3:20 PM

#

quackstack#46

dusky shoreBOT May 19, 2021, 3:20 PM

#

GitHub

PROpen chore: switch to uvicorn

short snow May 19, 2021, 3:20 PM

#

patent pivot pending me finishing exams

Oh gl

patent pivot May 19, 2021, 3:20 PM

#

cheers

#

tomorrow and friday, so, should be able to look at stuff soonish

clever wraith May 19, 2021, 3:21 PM

#

Alright @short snow those changes you asked for have been made

short snow May 19, 2021, 3:21 PM

#

Yeah, I have approved it already

sleek steppe May 19, 2021, 3:22 PM

#

I don't think that was the right change

short snow May 19, 2021, 3:23 PM

#

Which one? Link?

patent pivot May 19, 2021, 3:23 PM

#

🚀

short snow May 19, 2021, 3:24 PM

#

Weeee

sleek steppe May 19, 2021, 3:24 PM

#

short snow Which one? Link?

https://github.com/python-discord/sir-lancebot/pull/699/commits/bad1259749c91687544567bc4f388a8bfea9a7d1 I'll request changes

short snow May 19, 2021, 3:24 PM

#

Joe I demand you to look at #community-meta or any other admin seeing thi

short snow May 19, 2021, 3:24 PM

#

sleek steppe <https://github.com/python-discord/sir-lancebot/pull/699/commits/bad1259749c9168...

Alright, will still have a look

#

Uh oh, that’s not what I meant

#

Also I think for quackstack#12 , it should be done by someone who contributed to the project or has watched it closely, since only that person would be able to explain it properly

dusky shoreBOT May 19, 2021, 3:26 PM

#

GitHub

IssueOpen Flesh out the readme

vocal prairie May 19, 2021, 3:28 PM

#

If quackstack is stable enough, site#465 isn't stalled anymore, right?

dusky shoreBOT May 19, 2021, 3:28 PM

#

GitHub

IssueOpen Build-Your-Own Ducky!

short snow May 19, 2021, 3:28 PM

#

vocal prairie If quackstack is stable enough, site#465 isn't stalled anymore, right?

Yeah, quackstack is stable enough

sleek steppe May 19, 2021, 3:30 PM

#

@clever wraith conflicts still need to be resolved (just pull from upstream/main and run poetry lock). Regarding your comment, if I did

.cowsay abc <three backticks> new stuff

It would place the zero width pace between a and b

clever wraith May 19, 2021, 3:30 PM

#

alright

#

@sleek steppe why dont we just remove backticks alltogether?

sleek steppe May 19, 2021, 3:32 PM

#

I don't see the point of doing that

sour wolf May 19, 2021, 3:34 PM

#

how difficult would it be to have prettyprinted eval output

clever wraith May 19, 2021, 3:34 PM

#

alright, resolved lock

#

wait oops wrong command

#

alright resolved

patent pivot May 19, 2021, 3:35 PM

#

by the time eval output reaches the bot, it's already a string

#

so we'd need to do that inside the sandboxed process

brazen charm May 19, 2021, 3:36 PM

#

I think it's also clearer to the user if they receive the direct output their code generated, can always pprint in your code

fervent sage May 19, 2021, 3:36 PM

#

imo ^

#

took the words right out of my mouth kek

patent pivot May 19, 2021, 3:40 PM

#

yeah

brazen charm May 19, 2021, 3:47 PM

#

Waiting for a consensus on https://github.com/python-discord/bot/issues/1545 if anyone has a bit of time

sleek steppe May 19, 2021, 3:48 PM

#

There are role restricted tags?

brazen charm May 19, 2021, 3:48 PM

#

The feature is there, no tags that use it afaik

sleek steppe May 19, 2021, 3:49 PM

#

Ah I see it now

fervent sage May 19, 2021, 4:50 PM

#

@patent pivot do you mind if I implement the S3 thing, I have a couple ideas and I'd love to get more familiar with object storage in general :P

patent pivot May 19, 2021, 4:50 PM

#

fervent sage <@!165023948638126080> do you mind if I implement the S3 thing, I have a couple ...

greenTick

#

lmk if you want an S3 bucket

#

to test prod with

fervent sage May 19, 2021, 4:51 PM

#

i ahve free linode credits so I'm gonna put them to good use before theyre gone

patent pivot May 19, 2021, 4:52 PM

#

👍

#

it's £5/mo for 250GB of obj storage

sleek steppe May 19, 2021, 4:52 PM

#

Is someone implementing the upgrade to python 3.9 on quackstack? If not I could do that 😛

fervent sage May 19, 2021, 4:52 PM

#

feel free, im not 100% on what i actually need to change so im not touching rn kek

eternal owl May 19, 2021, 4:52 PM

#

I think you get 100$ for new linode account for 2months

fervent sage May 19, 2021, 4:53 PM

#

^

short snow May 19, 2021, 4:53 PM

#

Nothing to change, just use python 3.9, everything works

#

Already tested

eternal owl May 19, 2021, 4:53 PM

#

@trim cradle can you edit the issue description to say that off topic names are going to be rerolled and set as in-active or soft-deletes them instead of delete?
https://github.com/python-discord/bot/issues/1559

sleek steppe May 19, 2021, 5:06 PM

#

I just ran lint in quackstack and every single file got changed 🤔

#

I also see we forgot to update README.md

trim cradle May 19, 2021, 5:16 PM

#

eternal owl <@!253696366952316929> can you edit the issue description to say that off topic ...

so your goal is to implement both the reroll and archiving-of-old-names functionality in one PR?

eternal owl May 19, 2021, 5:16 PM

#

the reroll will be followed by the archive

#

we wanna change the channel name and mark the old name as inactive, meaning, it won't be considered to channel names in the future

#

https://github.com/python-discord/site/issues/490
here is the site issue

GitHub

Re-roll off topic names backend changes. · Issue #490 · python-disc...

Bot side issue: python-discord/bot#1559 Context The re-roll command on the bot side re-names an off-topic channel and marks the previous off-topic channel name to be devoid of being used again. We ...

#

approved by joe

trim cradle May 19, 2021, 5:18 PM

#

@eternal owl I don't think I have the bandwidth to wrap my head around what changes you're moving forward with. Do you think you can leave a comment on the issue in question?

eternal owl May 19, 2021, 5:20 PM

#

you want me to leave a comment about the site issue and updated implementation? not sure what you mean by in question 😓

trim cradle May 19, 2021, 5:20 PM

#

eternal owl you want me to leave a comment about the site issue and updated implementation? ...

you asked me to change an issue description. I'm asking if you can leave a comment on that issue

eternal owl May 19, 2021, 5:20 PM

#

ah right

sleek steppe May 19, 2021, 7:36 PM

#

Since snekbox#108 was merged, can I continue bot#1234 in a seperate PR?

dusky shoreBOT May 19, 2021, 7:36 PM

#

GitHub

PROpen Add timeit eval command
PRMerged feat: Allow custom arguments to be passed to eval

fervent sage May 19, 2021, 8:07 PM

#

sleek steppe I just ran lint in quackstack and every single file got changed 🤔

shhh

vale ibex May 19, 2021, 8:10 PM

#

sleek steppe I just ran lint in quackstack and every single file got changed 🤔

probably LF -> CRLF line endings

#

they likely won't make it to the actual repo on push

sleek steppe May 19, 2021, 8:12 PM

#

ah I see

sleek steppe May 19, 2021, 8:15 PM

#

fervent sage shhh

Also quackstack#47 👀

dusky shoreBOT May 19, 2021, 8:15 PM

#

GitHub

PROpen Upgrade to python 3.9

sleek steppe May 19, 2021, 8:21 PM

#

Oh right

sleek steppe May 19, 2021, 8:21 PM

#

dusky shore

@patent pivot if you don't mind reviewing 👀

patent pivot May 19, 2021, 8:22 PM

#

done

sleek steppe May 19, 2021, 8:22 PM

#

ty

tawdry vapor May 19, 2021, 8:25 PM

#

Just delete the venv directory

#

Then run poetry install or whatever to recreate it

tawdry vapor May 19, 2021, 8:27 PM

#

sleek steppe Since snekbox#108 was merged, can I continue bot#1234 in a seperate PR?

yes

#

What doesn't let you?

#

Just rm -r .venv assuming the directory is named .venv

#

It shows the full path right there

#

You can use rm -r to delete it

#

You technically don't even have to delete it but it'd just be wasted space

twilit juniper May 19, 2021, 8:36 PM

#

For the helpdm on/off command should we delete the command the user sent and the embed that the command sends?

#

Like after 5 seconds or something like that

vale ibex May 19, 2021, 8:38 PM

#

Is this a global opt in/out?

#

or per help channel?

twilit juniper May 19, 2021, 8:39 PM

#

Global opt in/out

vale ibex May 19, 2021, 8:39 PM

#

ah, then don't worry about deleteing

twilit juniper May 19, 2021, 8:39 PM

#

alright

brazen charm May 19, 2021, 8:40 PM

#

Don't see a reason for it to be allowed outside of #bot-commands where nobody cares about the history

vale ibex May 19, 2021, 8:40 PM

#

agreed

#

similar to !subscribe

#

or is it !announcements

#

one of those

twilit juniper May 19, 2021, 8:40 PM

#

Yeah, just an idea hemlock threw out there just wanted to check before I did it

vale ibex May 19, 2021, 8:40 PM

#

👌

#

yes

twilit juniper May 19, 2021, 8:51 PM

#

@tawdry vapor can give me superuser in the test server? I was told you can do that.

tawdry vapor May 19, 2021, 8:54 PM

#

Yes

twilit juniper May 19, 2021, 8:57 PM

#

Thanks

gritty wind May 19, 2021, 9:12 PM

#

the easiest solution would've been running deactivate first

#

seems you got it resolved in the end

granite plaza May 19, 2021, 10:16 PM

#

@patent pivot If your still evaluating/busy thats fine but just want to make sure you didnt miss the requested re-review of sir-lancebot#733

dusky shoreBOT May 19, 2021, 10:16 PM

#

GitHub

PROpen Http status command randomness

patent pivot May 19, 2021, 10:16 PM

#

I saw, but am busy until the end of the week I'm afraid!

granite plaza May 19, 2021, 10:17 PM

#

That is perfectly fine thanks for letting me know!

vale ibex May 19, 2021, 10:17 PM

#

This comment seems unresolved https://github.com/python-discord/sir-lancebot/pull/733#discussion_r632995532

granite plaza May 19, 2021, 10:22 PM

#

done :)

clever wraith May 20, 2021, 2:27 AM

#

how do y’all host y’all postgres server

short snow May 20, 2021, 2:53 AM

#

sir-lancebot#614 and sir-lancebot#649 need one core dev approval each, both have 2 staff aproval as of now

dusky shoreBOT May 20, 2021, 2:53 AM

#

GitHub

PROpen Porting Command Suggestions from python-discord/bot
PROpen Tech Leaders Pride

patent pivot May 20, 2021, 7:19 AM

#

clever wraith how do y’all host y’all postgres server

on our Kubernetes cluster

vale ibex May 20, 2021, 11:17 AM

#

short snow sir-lancebot#614 and sir-lancebot#649 need one core dev approval each, both have...

for 614, I think we should ask #dev-branding to make us a highres icon and host it on our branding repo

#

rather than rely on the discord cdn link

short snow May 20, 2021, 11:19 AM

#

it uses the same link used by @stable mountain, i think which is a emoji on the emoji server, since there are few which use the cdn links

vale ibex May 20, 2021, 11:19 AM

#

will allow us to keep it consistant if we use it in future

#

hmm, which command on python uses it?

#

Again, this might not be needed, but could be a good idea to start doing

short snow May 20, 2021, 11:20 AM

#

the error handler, its command suggestions

exotic ember May 20, 2021, 11:48 AM

#

@vale ibex what icon is this?

vale ibex May 20, 2021, 11:48 AM

#

QUESTION_MARK_ICON = "https://cdn.discordapp.com/emojis/512367613339369475.png"

#

in 649

#

!hep

#

oh, yea mods don't get suggestions

short snow May 20, 2021, 11:51 AM

#

kosa you are doing it? I will scratch out my message in #dev-branding then

exotic ember May 20, 2021, 11:52 AM

#

you can leave it for now incase anyone else wants to do it

short snow May 20, 2021, 11:55 AM

#

Btw it was used as cdn link, since you can't put emojis in set_author.icon_url

vale ibex May 20, 2021, 11:56 AM

#

yea, having a cdn link is fine

#

was just mentioning that we could take this as an opportunity to make and host our own icon

#

but not needed

short snow May 20, 2021, 11:57 AM

#

alright 👍

vale ibex May 20, 2021, 12:28 PM

#

short snow alright 👍

Could you resolve conflicts, I'll give it a quick look and then merge

#

sir-lancebot#649

dusky shoreBOT May 20, 2021, 12:29 PM

#

GitHub

PROpen Porting Command Suggestions from python-discord/bot

short snow May 20, 2021, 1:00 PM

#

done used github itself, 🤞 lint passes

#

oh no as expected 🤦‍♂️

#

@vale ibex merge

sleek steppe May 20, 2021, 1:04 PM

#

nice

short snow May 20, 2021, 1:05 PM

#

free for another one lol 🙃

green oriole May 20, 2021, 1:07 PM

#

short snow oh no as expected 🤦‍♂️

You don't lint locally?

short snow May 20, 2021, 1:07 PM

#

"used github itself" 😛

green oriole May 20, 2021, 1:12 PM

#

Shaking my smh

short snow May 20, 2021, 1:32 PM

#

weee

vale ibex May 20, 2021, 1:38 PM

#

.elp

#

lul

thorny obsidian May 20, 2021, 1:38 PM

#

.ielp

clever wraith May 20, 2021, 1:52 PM

#

patent pivot on our Kubernetes cluster

is it free?

patent pivot May 20, 2021, 1:53 PM

#

It isn't, no

#

We pay around $120/mo for hosting, there are much cheaper solutions available, but an entirely free DB is probably hard to come by

short snow May 20, 2021, 1:58 PM

#

#bot-commands message for some reason !u doesn't work

#

ok it does, but realllly slow

vale ibex May 20, 2021, 2:02 PM

#

Yea, we're looking into it

patent pivot May 20, 2021, 2:04 PM

#

should be back now

short snow May 20, 2021, 2:05 PM

#

ok yeah, what was the issue?

vale ibex May 20, 2021, 2:08 PM

#

jaegger issue afaik

patent pivot May 20, 2021, 2:24 PM

#

short snow ok yeah, what was the issue?

mem leak

green oriole May 20, 2021, 2:25 PM

#

GoLang being GoLang

short snow May 20, 2021, 2:49 PM

#

Lol

clever wraith May 20, 2021, 2:51 PM

#

lmao

#

still slow

vale ibex May 20, 2021, 2:51 PM

#

!sf 844950388368998502 844950408933015583

stable mountainBOT May 20, 2021, 2:51 PM

#

Snowflakes

844950388368998502
Created at 2021-05-20 14:51:11.006000 (37 seconds ago).

844950408933015583
Created at 2021-05-20 14:51:15.909000 (32 seconds ago).

vale ibex May 20, 2021, 2:51 PM

#

5 seconds is reasonable

#

!sf 844950630317555713 844950634931421234

stable mountainBOT May 20, 2021, 2:52 PM

#

Snowflakes

844950630317555713
Created at 2021-05-20 14:52:08.691000 (9 seconds ago).

844950634931421234
Created at 2021-05-20 14:52:09.791000 (8 seconds ago).

vale ibex May 20, 2021, 2:52 PM

#

This one took 1 s

#

seems fine now

vocal prairie May 20, 2021, 2:52 PM

#

It's pretty fast now

clever wraith May 20, 2021, 3:11 PM

#

!sf 788119126450765844

stable mountainBOT May 20, 2021, 3:11 PM

#

You are not allowed to use that command here. Please use the #bot-commands channel instead.

sleek steppe May 20, 2021, 4:03 PM

#

For the !timeit command, it runs the code like 5 million times. So, if you have any print statements, it's 100% going to get terminated because snekbox limits outputs to 1 MB. What should I do about that? (Keep in mind it's possible to limit the amount of time it runs)

#

Limiting the number to like 1000 seems to be fine, but then again, doing !e print("a" * 1_000_000) also gets the process terminated. Maybe it's just enough to put a note in the docstring?

#

I just did python -m timeit and it ran 50 million times

#

that's how it gets a more accurate number

twilit juniper May 20, 2021, 4:09 PM

#

Any reason why ok_handbutflipped isn't in constants if not I just added it and I will push it whenever I finish this issue.

twilit juniper May 20, 2021, 4:12 PM

#

twilit juniper Any reason why ok_handbutflipped isn't in constants if not I just added it and I...

Or is it in the actual running bot just not in the repo?

sleek steppe May 20, 2021, 4:12 PM

#

I don't think the bot uses that emoji

#

It would just use 👌

twilit juniper May 20, 2021, 4:14 PM

#

sleek steppe It would just use 👌

I could've sworn I have seen it with infractions and stuff

vocal prairie May 20, 2021, 4:14 PM

#

What's the url at the time when it fails?

twilit juniper May 20, 2021, 4:14 PM

#

twilit juniper I could've sworn I have seen it with infractions and stuff

Nvm it's not

vocal prairie May 20, 2021, 4:14 PM

#

What's one set?

sleek steppe May 20, 2021, 4:16 PM

#

what link is it bringing you to?

vocal prairie May 20, 2021, 4:16 PM

#

Can you show one PyDis url and the corresponding GitHub url that it takes you to?

#

Okay. But what's one actual example where it fails?

#

Then why don't add .md

#

This is supposed to be /contributing.md, not /contributing/

#

https://github.com/python-discord/site/blob/main/pydis_site/apps/content/resources/guides/pydis-guides/contributing.md takes you to this, which is what that page actually is

short snow May 20, 2021, 4:21 PM

#

I think when you are parsing the md files, add a variable to store the file location too from root, I am not familar with the site source

sleek steppe May 20, 2021, 4:29 PM

#

sleek steppe For the `!timeit` command, it runs the code like 5 million times. So, if you hav...

Any thoughts on this?

green oriole May 20, 2021, 4:29 PM

#

sleek steppe For the `!timeit` command, it runs the code like 5 million times. So, if you hav...

Patch sys.stdout to use a fake devnull object I'd say

sleek steppe May 20, 2021, 4:30 PM

#

Yeah but doesn't timeit need to print

green oriole May 20, 2021, 4:31 PM

#

Oh hmm

#

can probably use contextlib.redirect_stdout then

#

If you do use it, don't forget to delete it from the scope before calling the user code though

brazen charm May 20, 2021, 4:37 PM

#

I'd keep the stdout as is. I don't think anyone really has a reason to time prints and if you intend to do it from invoking the module directly then you're just adding complexity

#

In what way do you plan to implement the command?

green oriole May 20, 2021, 4:44 PM

#

For the workflow to run?

sleek steppe May 20, 2021, 4:44 PM

#

brazen charm In what way do you plan to implement the command?

It passes the ["-m", "timeit"] args to python and finds the n loops, best of 5: n <unit> per loop at the end of the stdout

brazen charm May 20, 2021, 4:45 PM

#

Does timeit adjust the runs and loops depending on the runtime?

sleek steppe May 20, 2021, 4:46 PM

#

Yes, unless you pass the --number | -n argument and it isn't 0

#

It would be cool if timeit redirected the output but ¯_(ツ)_/¯

green oriole May 20, 2021, 4:49 PM

#

oh, okay

#

is your IDE not saving to disk immediately after you stop typing?

#

I think so

#

Well, at least when you tab out

#

It should be fine

vocal prairie May 20, 2021, 5:02 PM

#

Both should work fine. I've been doing the latter, and nothing different happens

sleek steppe May 20, 2021, 5:05 PM

#

I like the first on because the second one doesn't let me put spaces between = in .env

vale ibex May 20, 2021, 5:34 PM

#

It means it wants you to have a docstring like this```py
"""
Attempt to display a tag by interpreting the command name as a tag name.

    The invocation of tags get respects its checks. Any CommandErrors raised will be handled
    by `on_command_error`, but the `invoked_from_error_handler` attribute will be added to
    the context to prevent infinite recursion in the case of a CommandNotFound exception.
    """

not like thispy
"""
Attempt to display a tag by interpreting the command name as a tag name.
The invocation of tags get respects its checks. Any CommandErrors raised will be handled
by on_command_error, but the invoked_from_error_handler attribute will be added to
the context to prevent infinite recursion in the case of a CommandNotFound exception.
"""

dusky shoreBOT May 20, 2021, 5:39 PM

#

GitHub

PROpen Edit on GitHub feature - and small changes

short snow May 20, 2021, 5:43 PM

#

https://github.com/python-discord/site/blob/308d39b4b4e3679c5e2519a97223da7230e5431d/pydis_site/apps/content/views/page_category.py#L76 why not add a parameter for link?

stable mountainBOT May 20, 2021, 5:43 PM

#

pydis_site/apps/content/views/page_category.py line 76

def _get_page_context(path: Path) -> t.Dict[str, t.Any]:```

sleek steppe May 20, 2021, 5:45 PM

#

https://github.com/python-discord/bot/blob/b0b90c8b52f55e19e287e5cbe075967b887169c7/bot/exts/utils/snekbox.py#L13 I'm never trusting pylance auto import again lol

stable mountainBOT May 20, 2021, 5:45 PM

#

bot/exts/utils/snekbox.py line 13

from discord.ext.commands.core import Command```

short snow May 20, 2021, 5:49 PM

#

!d django.http.HttpRequest.get_full_path just get the full path and append it at the end of the GitHub, no need to worry about the host, btw yes that looks right

stable mountainBOT May 20, 2021, 5:49 PM

#

django.http.HttpRequest.get\_full\_path


HttpRequest.get_full_path()```
Returns the `path`, plus an appended query string, if applicable.

Example: `"/music/bands/the_beatles/?print=true"`

patent pivot May 20, 2021, 5:52 PM

#

lol

sleek steppe May 20, 2021, 5:52 PM

#

You didn't see this?

short snow May 20, 2021, 5:52 PM

#

Umm, so you can get the full path and append it after the GitHub link

sleek steppe May 20, 2021, 5:52 PM

#

but yeah I'm about to force push again 😛

short snow May 20, 2021, 5:52 PM

#

Toxic is not that toxic yet, so be happy 😃

sleek steppe May 20, 2021, 5:56 PM

#

I think I'm ready to PR

short snow May 20, 2021, 5:56 PM

#

I know I am bad at explaining this, haven’t worked with django much, so what you are right now are doing is replacing the host right? That is the path I.e. the url after the host remains the same. So you can just get that full path after the host and add to the GitHub link you were switching the host with.

Example, a.com/a/c/d, say this is the url, so full path is a/c/d. You can just put this after the GitHub link.

You can get the full path like said here, #dev-contrib message

sleek steppe May 20, 2021, 5:57 PM

#

except that you'd replace pages with content IIRC

#

I should've known there were tests for snekbox 😔

#

especially because of bot#1600

dusky shoreBOT May 20, 2021, 6:10 PM

#

GitHub

PROpen Using Context.reply in the eval message output

sleek steppe May 20, 2021, 6:12 PM

#

Also tests that I haven't edited are also failing

sleek steppe May 20, 2021, 6:50 PM

#

Should I also write tests for the timeit command?

thorny obsidian May 20, 2021, 7:28 PM

#

@eternal owl feel free to assign yourself on the issue if that's something you want to work on.

eternal owl May 20, 2021, 7:29 PM

#

ty ty

sleek steppe May 20, 2021, 7:57 PM

#

I think I broke something in the tests, because when I ran it locally, it got stuck, and the tests have been running for ten minutes https://github.com/python-discord/bot/pull/1602/checks?check_run_id=2633490481

vale ibex May 20, 2021, 7:59 PM

#

I've cancelled that run for now then

sleek steppe May 20, 2021, 8:00 PM

#

I found the problem though

sleek steppe May 20, 2021, 8:23 PM

#

sir-lancebot#1602 if anyone wants to look at it :P

#

oops

vale ibex May 20, 2021, 8:26 PM

#

That's a very big number 👀

sleek steppe May 20, 2021, 8:26 PM

#

bot#1602

dusky shoreBOT May 20, 2021, 8:26 PM

#

GitHub

PROpen feat: Add the timeit command

eternal owl May 20, 2021, 8:40 PM

#

@sleek steppe did you get in contact with the owner of bot#1234 before going ahead with your PR?

dusky shoreBOT May 20, 2021, 8:40 PM

#

GitHub

PROpen Add timeit eval command

eternal owl May 20, 2021, 8:40 PM

#

cuz he might still wanna continue working on it

brazen charm May 20, 2021, 8:40 PM

#

the pr is marked as up for grabs

eternal owl May 20, 2021, 8:40 PM

#

ah okay, mb did not see that

sleek steppe May 20, 2021, 8:41 PM

#

Yeah it was up for grabs and stalled until snekbox#108 was merged

dusky shoreBOT May 20, 2021, 8:41 PM

#

GitHub

PRMerged feat: Allow custom arguments to be passed to eval

vocal wolf May 20, 2021, 8:46 PM

#

@sleek steppe do you think bot#1234 should be closed now that you're working on the other PR?

dusky shoreBOT May 20, 2021, 8:46 PM

#

GitHub

PROpen Add timeit eval command

vocal wolf May 20, 2021, 8:47 PM

#

oh wait yeah I'm totally closing this, nvm

sleek steppe May 20, 2021, 8:47 PM

#

yes

mint tartan May 21, 2021, 1:03 AM

#

Since there is a #reddit channel you guys should add a python sub Reddit command!

sleek steppe May 21, 2021, 1:04 AM

#

mint tartan Since there is a <#458224812528238616> channel you guys should add a python sub ...

Run .reddit in #sir-lancebot-playground 😄

mint tartan May 21, 2021, 1:06 AM

#

sleek steppe Run `.reddit` in <#607247579608121354> 😄

O 😂 mb

sleek steppe May 21, 2021, 1:08 AM

#

mint tartan O 😂 mb

Yeah, it was on @stable mountain before, but it was migrated to @dusky shore recently

fervent sage May 21, 2021, 1:09 AM

#

if there any interest from literally anyone other than me in having the ability to run commands inline {!e print("lol inline command")} mmLol

fringe sphinx May 21, 2021, 1:11 AM

#

!e print("lol inline command")

stable mountainBOT May 21, 2021, 1:11 AM

#

@fringe sphinx :white_check_mark: Your eval job has completed with return code 0.

lol inline command

fringe sphinx May 21, 2021, 1:11 AM

#

🤨

sleek steppe May 21, 2021, 1:12 AM

#

He means that a command would be invoked if it's {!e print("in these brackets")}

fringe sphinx May 21, 2021, 1:13 AM

#

oh yeah that would be neat

fervent sage May 21, 2021, 1:15 AM

#

ive made a proof of concept before and the implementation is like 10 lines

sleek steppe May 21, 2021, 1:16 AM

#

Does it check if there's a backslash before it 👀

fervent sage May 21, 2021, 1:16 AM

#

actually yes

sleek steppe May 21, 2021, 1:16 AM

#

oh nice

fervent sage May 21, 2021, 1:17 AM

#

it's not perfect because its regex not an actual handwritten parser

#

but its not awful either

fringe sphinx May 21, 2021, 1:17 AM

#

when it's working you should make a pr or smth cuz I'd use that

fervent sage May 21, 2021, 1:17 AM

#

what for lol

fringe sphinx May 21, 2021, 1:18 AM

#

for message context

#

like 'here's how this will work: !e print("here's how it works")'

fervent sage May 21, 2021, 1:19 AM

#

my main motive i'll be honest - and this would work as a standalone feature - is embedded tags, so for example the message:

Hey, there's actually a brief tag explaining how to do that: {!customcheck}

fringe sphinx May 21, 2021, 1:20 AM

#

that would be useful too

fervent sage May 21, 2021, 1:20 AM

#

meaning i no longer need some weird phrasing like !customcheck this tag explains...

fringe sphinx May 21, 2021, 1:20 AM

#

mhm

fervent sage May 21, 2021, 1:21 AM

#

cause i like to give context when sending a tag rather than just drop it there, but 99.9% of my usage of tags is in discord.py which often has a fair amount of slowmode, so being able to easily explain and invoke in one message is ok_handbutflipped

fringe sphinx May 21, 2021, 1:21 AM

#

yeah the same for me and pygen

fervent sage May 21, 2021, 1:22 AM

#

know what i'mma make an issue for that now

vocal prairie May 21, 2021, 1:37 AM

#

fervent sage if there any interest from literally anyone other than me in having the ability ...

That would be nice

balmy sparrow May 21, 2021, 2:39 AM

#

!e what's wrong with invoking like this?

print("hi")

stable mountainBOT May 21, 2021, 2:39 AM

#

@balmy sparrow :white_check_mark: Your eval job has completed with return code 0.

hi

balmy sparrow May 21, 2021, 2:40 AM

#

!customhelp foo bar baz these words do not matter

stable mountainBOT May 21, 2021, 2:40 AM

#

Custom help commands in discord.py

To learn more about how to create custom help commands in discord.py by subclassing the help command, please see this tutorial by Stella#2000

sleek steppe May 21, 2021, 2:45 AM

#

balmy sparrow !customhelp foo bar baz these words do not matter

https://discordapp.com/channels/267624335836053506/635950537262759947/845108698942930985

balmy sparrow May 21, 2021, 2:45 AM

#

huh

#

fair enough I guess

fallen patrol May 21, 2021, 3:02 AM

#

fervent sage actually yes

but does it also check if its part of a code block?

#

~~btw there's a regex for that in the eval cog~~

short snow May 21, 2021, 5:16 AM

#

@sleek steppe @eternal owl I had mentioned your changes on the wikiguess PR, if you could give it another go 😄

link: https://github.com/python-discord/sir-lancebot/pull/618

GitHub

Wikiguess Game by Shivansh-007 · Pull Request #618 · python-discord...

Relevant Issues
Closes #446
Description & Reasoning
Tis PR adds the wikiguess game. To implement this I have used the random wikipedia article API, to get the title, extract. The questions ...

patent pivot May 21, 2021, 8:39 AM

#

FYI: Scheduled downtime of PyDis Site from 21:00-23:00 UTC today.

tough imp May 21, 2021, 10:06 AM

#

I noticed that the async-rediscache repo no longer sends github events to #dev-log since the transfer to @hardy gorge's account, is that a conscious decision? It still feels like a project tightly related to the pydis infrastructure and having an event feed may be good to raise awareness of existing issues & generate more interest in contribution

short snow May 21, 2021, 10:51 AM

#

@green oriole I had a question with bot#1588 , for start and stop time, will it be passed as integer or datetime string which is to be parsed.

Like: !modpings schedule 7 20 so from 7am to 8pm

or like: !modpings schedul 7am 3pm?

dusky shoreBOT May 21, 2021, 10:51 AM

#

GitHub

IssueOpen Modpings schedule feature

green oriole May 21, 2021, 10:52 AM

#

Can we do both with a custom parser?

#

It should be able to handle 7, 7am, 7:30 and 7:30am

vale ibex May 21, 2021, 10:53 AM

#

7 and 7:30 is ambiguous though right

#

I'd expect 7 and 7:30 to convert to the AM equivalent

short snow May 21, 2021, 10:54 AM

#

yeah, by 7 and 20 I meant 24 hour format

vale ibex May 21, 2021, 10:55 AM

#

Yea, that would be my thought too

#

it should allow for both 24hour and 12hour times

short snow May 21, 2021, 10:55 AM

#

sure!

vale ibex May 21, 2021, 10:55 AM

#

So yea, Akarys's point of a custom parser would be good

#

similar to what we have for the duration one now

#

So user could do either of your examples and they'd both work

#

or even mix and match

exotic ember May 21, 2021, 10:56 AM

#

have we considered just using dateutil's parser?

short snow May 21, 2021, 10:57 AM

#

https://dateutil.readthedocs.io/en/stable/parser.html not used yet

vale ibex May 21, 2021, 10:57 AM

#

I assume arrow has something similar?

#

unless dateutil is already in the dep list

green oriole May 21, 2021, 11:01 AM

#

vale ibex I'd expect 7 and 7:30 to convert to the AM equivalent

Yeah, my example wasn't clear

#

Like that

short snow May 21, 2021, 11:10 AM

#

i don't think arrow allows to just parse time, like dateutil does

#

like this

vale ibex May 21, 2021, 11:22 AM

#

there's a dehumanize thing I've seen

#

which might be appropriate

#

but that's from memory, so might serve a different purpose

sharp timber May 21, 2021, 11:27 AM

#

I'm getting Site matching query does not exist trying to log into the admin of a fresh django setup for site

#

I have set up the hosts file, so I'm trying to hit http://pythondiscord.local:8000/admin

vale ibex May 21, 2021, 11:30 AM

#

I think we possibly trashed that with dewikification

#

I might be wrong though

sharp timber May 21, 2021, 11:31 AM

#

I'm just pulling off of main

#

I see

#

my manage.py run did not function as expected

gritty wind May 21, 2021, 11:33 AM

#

admin should still exist

#

It's just

#

Logging in may be tough

sharp timber May 21, 2021, 11:35 AM

#

There we go

#

I need to pass --debug to it

short snow May 21, 2021, 11:36 AM

#

I was looking at the scheduler, it doesn't support repeating events as of now, so i think there are two options right now for scheduling modpings.

Allow scheduler to support repeating events.
In coroutine which is ran on hiting the event, we can just add that event again by shifting it by 1 day

#

I am not really familiar with how scheduler is implemented, so I think I would go with option 2

sharp timber May 21, 2021, 11:42 AM

#

Does anyone know if there's an easier way to add a custom filter other than using get_queryset? I am very not familiar with DRF

sharp timber May 21, 2021, 12:13 PM

#

...I need a guinea pig on the test server, if anyone's available for that?

short snow May 21, 2021, 12:14 PM

#

||me||

sleek steppe May 21, 2021, 12:14 PM

#

👀

thorny obsidian May 21, 2021, 12:16 PM

#

sharp timber ...I need a guinea pig on the test server, if anyone's available for that?

I'm in the server, feel free to do whatever to my account

sharp timber May 21, 2021, 12:16 PM

#

ok

#

Thanks! ignore the pings

sharp timber May 21, 2021, 12:37 PM

#

I could make this really complex but let's.. not

green oriole May 21, 2021, 12:37 PM

#

If you need a second user, you can have fun on me too

sharp timber May 21, 2021, 12:38 PM

#

So I've added a types filter, a permanent filter, and expires_at_gte and expires_at_lte

short snow May 21, 2021, 12:38 PM

#

short snow I was looking at the scheduler, it doesn't support repeating events as of now, s...

give me a ping when someone responds

sharp timber May 21, 2021, 12:40 PM

#

At the moment it simply runs the rescheduler until the api informs it that there's none left that it might need to reschedule in the future, then it stops

green oriole May 21, 2021, 12:44 PM

#

Are you using SearchFilter and OrderingFilter from drf @sharp timber ?

sharp timber May 21, 2021, 12:45 PM

#

No

green oriole May 21, 2021, 12:45 PM

#

hmm why not?

sharp timber May 21, 2021, 12:45 PM

#

They wouldn't apply?

green oriole May 21, 2021, 12:45 PM

#

wouldn’t they?

sharp timber May 21, 2021, 12:45 PM

#

Searchfilter is for searching a field, right?

green oriole May 21, 2021, 12:45 PM

#

lol

#

Yeah

sharp timber May 21, 2021, 12:45 PM

#

I'm not searching, I'm applying a filter

green oriole May 21, 2021, 12:46 PM

#

I mean, you can use it to only return infractions that has active=true for example

#

that’s the search filter

sharp timber May 21, 2021, 12:46 PM

#

what

green oriole May 21, 2021, 12:46 PM

#

Oh wait

sharp timber May 21, 2021, 12:47 PM

#

no, that's specified via filter_fields right?

green oriole May 21, 2021, 12:47 PM

#

Yeah yeah