we shouldn't add these flags because they might be unstable
#🖥-vesktop-development
vernal lintel
there have been some people complaining about artifacts / discoloring in screenshare and I think it's because vesktop enables video hardware encoding
there's a reason these things are all opt in via command line flags
if they were fully stable and had no downsides chromium would just enable them natively
we can create a wiki somewhere and document these things for users but we shouldn't add them natively I think
austere wolf
banana
next sundial
there have been some people complaining about artifacts / discoloring in screens...
that's probably NVIDIA users
next sundial
we can create a wiki somewhere and document these things for users but we should...
I believe that not having H.265 OOTB is an annoyance bigger than possibly causing artifact issues on some drivers/GPUs
like I said earlier, we can make this only for AMD on Linux, so we would be in the safe side
vernal lintel
no
next sundial
from my PoV, AMD is the "correct" base for things to be stable on Linux
tomorrow I'll see if there is an upstream issue for either Chromium or Electron
regarding h.265
austere wolf
thought of an epic hack so i don't have to integrate windows stuff into venmic: develop an "unrelated" package that's just for capturing application audio
humble mortar
@next sundial youre running in circles with known info. full vaapi needs vulkan on amd. Vaapi isnt supported on Nvidia linux.
all of this is on the chromium wiki and archwiki
next sundial
<@678334090704846858> youre running in circles with known info. full vaapi needs...
yeah but
what I'm saying is to enable what is needed by default for GPUs/drivers that are stable (currently only AMD it seems)
humble mortar
theres no proper way to only enable vulkan on amd
- additional environment vars are needed on dual gpu systems
its not hard for users to use google
next sundial
yes but it's inconvenient for users to manually troubleshoot this problem
imagine if the user doesn't even know about h.265 codecs
next sundial
theres no proper way to only enable vulkan on amd
not sure if there's a way to detect it
maybe by checking if specific devices exist in /dev
humble mortar
not sure if there's a way to detect it
yes thats what I just said
humble mortar
maybe by checking if specific devices exist in `/dev`
that is not a proper way to do that
like vee said a vesktop specific wiki page is the only sane choice to centralize the info
simple groveBOT
Yeah, I have the same issue on my machine.
vernal lintel
why is this the average vesktop issue / support request #🖥-vesktop-support-🖥 message
@humble mortar
humble mortar
why is this the average vesktop issue / support request https://discord.com/chan...
people just dont install the portal backend
its not required so if youre not using a distro that installs it explod
humble mortar
that should REALLY be an electron feature
you will open feature request
it'd have to be a dynamic system so u can check for specific portals and not just the entire backend
simple groveBOT
austere wolf
brother switched to the OS of workarounds and says the user shouldn't have to workaround
woeful current
ubuntu is cancer
hot juniper
this is 
advice
simple groveBOT
oblique egret
man ven, how are you so nice
i'd flat out go "we dont support incompetence, premid already works, its user error"
humble mortar
maybe make a github bot that auto replies with basic info when we put a specific tag
humble mortar
less effort to just tag than write a reply 
spiral prairie
make a bot that replies basic info when you close without a message
simple groveBOT
humble mortar
so fast
humble mortar
@vernal lintel veeeee lock it pleasee
humble mortar
what the fuck
humble mortar
I'm so tempted to comment "dm cookie on discord for Portal support"
I'll chop you up into little bits and feed you to the dogs
austere wolf
wake up, screenshare crash, invalid, sleep
humble mortar
im gonna explode if the script left an ipc file causing arrpc to fallback to -1
vernal lintel
alphabetically
austere wolf
woeful current
alphabetically
! Vencord Support Server
spiral prairie
You should rename it to "Vesktop Developer Issue Template" and remove the empty issue
vernal lintel
truee
simple groveBOT
humble mortar
@vernal lintel the arrpc plugin does indeed explode on the asset lookup
im reproing it rn
vernal lintel
no them being insane
humble mortar
different kinds of insane
vernal lintel
it's a vencord issue not a vesktop issue
humble mortar
die
simple groveBOT
woeful current
lc.xkcd workflow
vocal fernBOT
lc.xkcd workflow
simple groveBOT
grizzled hemlock
insane
simple groveBOT
stark falcon
tidal quarry
the world is healing
stark falcon
made it shorter, idk how to do it without hardcoding the shortcut
stark falcon
doesnt work
#🏥-vencord-support-🏥 thers been a couple of ppl saying it here including myself
stark falcon
i promise you that im not 😭
vernal lintel
idk what that means
vernal lintel
⌥⌘I
Command+Option+I
also you should make a minimal electron reproduction example and report it to electron
vernal lintel
⌥⌘I
Command+Option+I
did this keybind work
vernal lintel
then why would u close it
stark falcon
bcs its an electron issue and if it gets fixed itll either way get yeated
but its temporary
i yap too much
simple groveBOT
vernal lintel
it has nothing to do with that 😭
stark falcon
It's not an Electron bug. I don't understand what Vesktop is doing to the keybind, though, since Cmd option I only works to close dev tools afteryou've opened them.
simple groveBOT
simple groveBOT
simple groveBOT
vernal lintel
how do github wikis work for letting people contribute
do you just send a PR
we should make vesktop wiki
😭
simple groveBOT
humble mortar
why did bro delete this as soon as he sent it
Nin0dev solutions
@vernal lintel fire him
simple groveBOT
humble mortar
can't reproduce <a:cope:1333489733191467059>
so you can click on notifs from vesktop flatpak and it brings u to the message?
on gnome right?
vernal lintel
yes
humble mortar
guess it's a plasma issue then
vernal lintel
it's probably electron on wayland moment lol
im just gonna change the flatpak to not use wayland 😭
humble mortar
i can click notifs just fine on wayland with system package
oh thats right
its a libnotify issue
humble mortar
works on my machine doe??
wayland in the flatpak or x11
vernal lintel
flatpakker
humble mortar
flatpakker
wayland or x11
vernal lintel
WAYLAND
humble mortar
ok so just to clarify
On GNOME Wayland, Vesktop in a flatpak running on ozone wayland, you click a notification and it brings you to the message
vernal lintel
yes
humble mortar
yes
either Gnome has a STUPID hacky workaround in libnotify or youre not running on ozone wayland
vernal lintel
i am
humble mortar
the issue is XDG desktop notification portal doesnt have callback support (so STUPID)
vernal lintel
ur so mad
humble mortar
yop
sour muralBOT
https://gitlab.gnome.org/GNOME/libnotify/-/blob/master/libnotify/notify.c#L551
notify.c: Line 551
g_debug ("Running in confined mode, using Portal notifications. "
anyway works on my machine so system issue + mald + ratio
humble mortar
yopppp
humble mortar
did you see the latest Justin trudeau image I sent
humble mortar
no and I don't think I want to
vernal lintel
humble mortar
plasma should simply suck less if it's really a plasma issue
yeah I wonder where its failing if it works on gnome
do you get the confined mode log
from the flatpak
humble mortar
is he an umpa loompa
vernal lintel
just don't cancel the screenshare portal prompt 😭
people are so weird
why do you ever have to cancel it
if you don't want to start a screenshare just don't click the screenshare button
humble mortar
i put you in a little box of hell with all the insane support issues whizzing around your head like bees
simple groveBOT
vernal lintel
we should make vesktop wiki
@humble mortar should we put Vesktop wiki on shithub or make it a proper website
shithub wikis are so cursed
cause to accept "PRs" to them we have to manually copy over edits of people
vernal lintel
oh wait
but this seems like a bad idea lmao
you love trolls
can you edit this https://github.com/Vencord/Vesktop/wiki
i wanna see how it looks from my side
just make some random change like adding 
emoji
humble mortar
yop i edited
humble mortar
did
vernal lintel
I'm reporting you to github for griefing my wiki
humble mortar
kys
vernal lintel
gollum
oh my god
discord doesnt support wiki edit webhook events
so bad
why did they name it gollum 😭
humble mortar
youre gollum
humble mortar
youre insane
vernal lintel
why
I already made https://ghwp.vendicated.dev
I might as well make it also add support for more events
vernal lintel
imagine zapier webhooks but actually good
humble mortar
@vernal lintel can you send me dbus-monitor snippets of you sending the notification and clicking it both from system wayland vesktop and flatpak wayland vesktop
both on gnome ofc
when its in the flatpak on wayland kde the notification isnt created with an action param
vernal lintel
?? 😭
vernal lintel
<@343383572805058560> can you send me dbus-monitor snippets of you sending the n...
idk what that means
humble mortar
run dbus-monitor in terminal
run the snippet
click the notif
stop dbus-monitor
send me the log
vernal lintel
method call time=1741476192.920600 sender=:1.65 -> destination=:1.103 serial=1979 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.impl.portal.Notification; member=AddNotification
string "dev.vencord.Vesktop"
string "libnotify-flatpak.dev.vencord.Vesktop-vesktop-4"
array [
dict entry(
string "title"
variant string "hi"
)
dict entry(
string "body"
variant string ""
)
dict entry(
string "default-action"
variant string "default"
)
dict entry(
string "priority"
variant string "normal"
)
]
method call time=1741476192.920861 sender=:1.103 -> destination=:1.24 serial=1143 path=/org/gtk/Notifications; interface=org.gtk.Notifications; member=AddNotification
string "dev.vencord.Vesktop"
string "libnotify-flatpak.dev.vencord.Vesktop-vesktop-4"
array [
dict entry(
string "title"
variant string "hi"
)
dict entry(
string "body"
variant string ""
)
dict entry(
string "default-action"
variant string "default"
)
dict entry(
string "priority"
variant string "normal"
)
]
method return time=1741476192.920916 sender=:1.103 -> destination=:1.65 serial=1144 reply_serial=1979
method return time=1741476192.927754 sender=:1.24 -> destination=:1.103 serial=11354 reply_serial=1143
signal time=1741476194.760515 sender=:1.24 -> destination=(null destination) serial=11355 path=/org/gtk/Notifications; interface=org.gtk.Notifications; member=ActionInvoked
string "dev.vencord.Vesktop"
string "libnotify-flatpak.dev.vencord.Vesktop-vesktop-4"
string "default"
array [
]
array [
dict entry(
string "activation-token"
variant string "gnome-shell/Vesktop/5001-24-vendingmachine_TIME16072779"
)
]
method call time=1741476194.760752 sender=:1.103 -> destination=dev.vencord.Vesktop serial=1145 path=/dev/vencord/Vesktop; interface=org.freedesktop.Application; member=Activate
array [
dict entry(
string "desktop-startup-id"
variant string "gnome-shell/Vesktop/5001-24-vendingmachine_TIME16072779"
)
dict entry(
string "activation-token"
variant string "gnome-shell/Vesktop/5001-24-vendingmachine_TIME16072779"
)
]
signal time=1741476194.760779 sender=:1.103 -> destination=(null destination) serial=1146 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.impl.portal.Notification; member=ActionInvoked
string "dev.vencord.Vesktop"
string "libnotify-flatpak.dev.vencord.Vesktop-vesktop-4"
string "default"
array [
]
signal time=1741476194.760948 sender=:1.65 -> destination=:1.645 serial=1980 path=/org/freedesktop/portal/desktop; interface=org.freedesktop.portal.Notification; member=ActionInvoked
string "libnotify-flatpak.dev.vencord.Vesktop-vesktop-4"
string "default"
array [
]
AddNotification call is identical
kde just never emits the Action invoked event on the portal
but it DOES on the raw dbus which is why it works out of portal
humble mortar
Libnotify uses when sandboxed -> https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Notification.html#org-freedesktop-portal-notification-addnotification
Libnotify uses when not sandboxxed -> https://specifications.freedesktop.org/notification-spec/1.2/protocol.html
ActionInvoked is never emitted on portal
vernal lintel
you will go complain in kde issue tracker
vernal lintel
probably already reported fwiw
humble mortar
its not afaik
vernal lintel
but is it plasma's fault or Flatpak KDE Runtime's fault
sudden trout
nop appimage is more scuffed but for different reasons
humble mortar
appimage is flatpak but worse
bundle all deps like flatpak but no sandboxxing
no permissions
vernal lintel
bundle all deps like flatpak but no sandboxxing
flatpak isn't even that
flatpak just needs a second copy (one copy for all apps)
appimage needs one copy for each app
humble mortar
yeah
humble mortar
@vernal lintel let me yap on locked issues
im gonna link https://bugs.kde.org/show_bug.cgi?id=501244 in the notification one
simple groveBOT
next sundial
which one?
btw, out of context: is there a way to pass --enable-features to Vesktop without editing desktop files?
humble mortar
@vernal lintel mainWin.show() minimizes then shows when the window is maximized
..,,
what insane logic are they doing
vernal lintel
<@343383572805058560> mainWin.show() minimizes then shows when the window is max...
you love
simple groveBOT
humble mortar
?remindme 8h
small lionBOT
Alright @humble mortar, in 8 hours: …
vernal lintel
you are insane @humble mortar
install shellcheck immediately
and never do an abomination like this ever again
the scripts also have quoting issues
sour muralBOT
https://github.com/Vencord/PKGBUILDs/blob/main/vesktop-electron-git/vesktop.sh#L...
vesktop.sh: Line 7
VESKTOP_USER_FLAGS="$(grep -v '^#' $XDG_CONFIG_HOME/vesktop-flags.conf)"
this will explode if XDG_CONFIG_HOME includes whitespace or other funny characters
it should be quoted
https://www.shellcheck.net will tell you all these things
humble mortar
you are insane <@721853658941227088>
i didnt write those scripts 😭
vernal lintel
who wrote them
humble mortar
way before me
vernal lintel
@worn harness youuuu
humble mortar
dont care smile
vernal lintel
you should just change the shebang to bash anyway
humble mortar
if u have white space in your home dir you deserve to die
(ive been aware of the POSIX and shell expansion stuff but nobody's complained so I havent cared 😀)
I'll fix cause that guy wants me to
yippe
@vernal lintel why specificy exact pnpm version on package.json it makes my life so annoying
i hate corepack
i hate software
I'm deleting my computer
@vernal lintel grabbed
vernal lintel
<@343383572805058560> why specificy exact pnpm version on package.json it makes ...
STOP CRYING
pnpm install --frozen-lockfile --config.package-manager-strict=false
or to do it for everything:
echo "package-manager-strict=false" >> .npmrc
STUPID STUPID
obscure args that fix my problems
(if I test and it doesnt fix I'll kill you btw)
see you in like 7 hours..
OUCH
i dropped my phone on my face
its all crumbling down
humble mortar
i need someone to yell at and youre right here
I'm abusive
you made me full of hate
humble mortar
ive been getting version errors on v10
oh its for minor and patch not major
sigh...
guh the code comment says exact match
idk what to believe
i will test
?remindme 7h
small lionBOT
Alright @humble mortar, in 7 hours: …
small lionBOT
@humble mortar, <t:1741838389:R>: …
worn harness
cookie so silly
small lionBOT
@humble mortar, <t:1741846018:R>: …
worn harness
okay doesn't matter who wrote them but
old aur maintainer is so insane he won't transfer ownership over still
humble mortar
guhhhhhhhhhh
humble mortar
?remindme 48h remember to do the pkgbuild stuff
small lionBOT
Alright @humble mortar, in 2 days: remember to do the pkgbuild stuff
woeful current
whats this woke thing
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
small lionBOT
@humble mortar, <t:1741906417:R>: remember to do the pkgbuild stuff
worn harness
@humble mortar
vernal lintel
@humble mortar
humble mortar
gonna lock you up in prison
vernal lintel
cooki so lazy wont do pkgbuild stuff
worn harness
<@343383572805058560> teleport my laptop to me
can I teleport to you
humble mortar
only if you bring my laptop
Fuckkk
my aur key is on my laptop
sutupud
i can't even do it from termux if I wanted
humble mortar
i can do tmrw morning
i think I won't bump the pkgrel since existing builds won't need to rebuild
only new users
woeful current
my aur key is on my laptop
i have it
humble mortar
vee..
vernal lintel
WRONG CHAT
humble mortar
woeful current
guhhlf of America
hasty pewter
wait seriously
uh oh
hm
well we could disable the app menu
i dont think its even used
Menu.setApplicationMenu(null)
vernal lintel
fym its not even used
it's responsible for all keybinds
and there's an option to show it
hasty pewter
guh i hate electron
vernal lintel
guh i hate electron
doesnt really have anything to do with electron
standard application stuff
vernal lintel
you can add an invisible accelerator
anyway just this
hasty pewter
yeah im looking
hasty pewter
you can add an invisible accelerator
it seems like it doesn't override the windowMenu's accelerator
removing the windowMenu altogether works though
id remove it altogether
seems pretty useless
hasty pewter
id remove it altogether
seems pretty useless
@vernal lintel veeeeee
hasty pewter
is there a shortcut
cause the button doesnt do anything
hasty pewter
oki ill remove then
simple groveBOT
simple groveBOT
Content
This seems to be caused by a regression in electron-builder v25.x.x, and fixed in v26.0.0-alpha.3.
Making this as a tracking issue to update to electron-builder v26 once it reaches a stable release.
"Vesktop is a custom Discord desktop app" lol
humble mortar
https://discord.com/developers/social-sdk @vernal lintel finnalllllyyy dropping the gamesdk
vernal lintel
horror
why did they name it social sdk
bros really think it's gonna be the same as xeeting from your ps3
humble mortar
5 billion years of deprecated gamesdk just to rename it
GUH THEY WANT VOICE STUFF IN THEBGAME ITSELD
overlay is so dead
arrpc will never support...,,
vernal lintel
lmao
doesn't steam have something for that too
why would they use discord over steam
humble mortar
fortnite refusing to be on steam:
vernal lintel
I doubt people want to link their discord to random games lol
unless it's seamless ig
humble mortar
arrpc will never support...,,
inject me with motivation to finish the module replacement likee..
humble mortar
steam overlay is actually good gurgg
vernal lintel
its goal was never to 1:1 reimplement Desktop app
humble mortar
steam overlay is actually good gurgg
discord moving to an electron pinned window is so ass
humble mortar
its goal was never to 1:1 reimplement Desktop app
yeah but RPC is a major feature and doesnt rly make it 1:1
scanning should always be a specific reimplementation so discord doesnt have a complete list of processes on the computer
but IPC and Web sockets should be direct so discords code can do its shit
I'll probably never finish it anyway
humble mortar
@vernal lintel should I add a .install file so the packages can tell the user about the args config after they install or maybe add a log to the startup script that says "checking for args at ..x"
also could .pacman generation be enabled in electron builder so a sane -bin package can be brought in
humble mortar
actually horror
why does github not use the primary email when doing stuff through the gui
vernal lintel
technically they do
humble mortar
technically they do
nop if it works for them rn its fine
humble mortar
yeah but
humble mortar
they will see it exploded and go check the package and see its been updated but not tagged
they will then rebuild
the two users who switch to dash vs the 20 morbillion who are just fine
if youre changing your shell you can do 2 seconds of googling to confirm the problem and fix it
also you shouldnt change your root shell anyway
kinda insane
vernal lintel
also you shouldnt change your root shell anyway
why not
dash is a lot faster than bash
vernal lintel
yes
#!/bin/sh = i want any posix compliant shell
dash is posix compliant
changing to dash is not a bad idea
some distros use dash
ubuntu uses dash for example
humble mortar
`#!/bin/sh` = i want any posix compliant shell
oh guh real?
i thought it was like a standard sh impl
guh ive never looked
i have got to stop saying guh
@worn harness brain infection
hasty pewter
btw if launching vesktop in --start-minimized with tray icon off there's no indication that vesktop is even running at all
i wanna make it show tray icon until first showing the window, regardless of the tray setting when launching in --start-minimized
sound good?
worn harness
<@289556910426816513> brain infection
nop
humble mortar
btw if launching vesktop in --start-minimized with tray icon off there's no indi...
guhhh insane behaviour lmao
yeah should def do that
does having the tray disabled also prevent the close to tray functionality
hasty pewter
yes
worn harness
yes
humble mortar
zop
worn harness
cookii
simple groveBOT
humble mortar
i love passing around state
hasty pewter
yop
simple groveBOT
humble mortar
@hasty pewter client side window controls seem to be missing proper resize tags on the edges or something
meaning you can't resize from the edges which is expected
humble mortar
<@295190422244950017> client side window controls seem to be missing proper resi...
likely vesktop needs to patch a desktop check to enable the correct frame
hasty pewter
huh
i love how like 80% of the issues are because of linux
@rancid geyser could you please fix https://github.com/Dziurwa14/discord-scraping
rancid geyser
how will this affect vesktop development
and no i cant ❤️
i dont use it really so its dead
hasty pewter
gu
rancid geyser
wtf even is that error... absolute
hasty pewter
lol yeah it looks so cursed
rancid geyser
they dont pay me enough to care
hasty pewter
i cant seem to figure out how the stock client handles zooming
there's a flux event handler for ACCESSIBILITY_RESET_TO_DEFAULT that supposedly handled ctrl+0 for zooming out but literally no emitters
okay this seems to be partially responsible??
idk why it uses mod+plus, it should work as mod+equals
guhhh this is so bad
hasty pewter
@vernal lintel i integrated zooming into client like on stock but i had to get rid of this menu cause it was interfering with the new accelerators
what do i do
i could reimplement the menu manually
hasty pewter
this calls into discord to also set internal state
because the stock app also has a scale slider in settings thats disabled on web
vernal lintel
<@343383572805058560> i integrated zooming into client like on stock but i had t...
these should be easy to reimplement anyway
if u wanna go that route
nini
simple groveBOT
hasty pewter
there look @vernal lintel
simple groveBOT
hasty pewter
veeee does this make sense
simple groveBOT
vernal lintel
😭
iron cedar
Horror
simple groveBOT
simple groveBOT
grizzled hemlock
is there any reason this doesn't also set location.href so you dont have to restart vesktop to change branches
vernal lintel
it's easier and more consistent to just require a restart
simple groveBOT
vernal lintel
<@343383572805058560> what does that experiment actually change
makes the web app unusable because discord doesn't test their shit on web
just like visual refresh titlebar
hybrid fjord
Btw do you guys aware of a bug when you start screen share -> close portal's picker and vesktop crashes?
vernal lintel
do u have windows @humble mortar
vernal lintel
bro thinking im rich off of vencord is so funny
humble mortar
do u have windows <@721853658941227088>
vm
vernal lintel
bro thinking im rich off of vencord is so funny
if you calculate the $ i get / hours i worked on vencord over the years you will find that it is way below minimum wage
humble mortar
ok send me money
vernal lintel
WDYM SEND YOU MONEY
humble mortar
im so stupid i just spent like 10 mins wondering why my ssh key wasnt working but i forgort to add a host override for the key
simple groveBOT
vernal lintel
why do some people feel so entitled lmao
uses software completely free of charge
"nooooo you have to fix my issue NOW.... lazy dev smh!!"
guh easyeffects has audio stuttering when a new source starts playing @humble mortar
pr fixes
humble mortar
whats easyeffects
vernal lintel
pulseffects but easy
humble mortar
whjats pulseeffects
sour muralBOT
https://github.com/Vencord/Vesktop/blob/main/src/main/screenShare.ts#L80
screenShare.ts: Line 80
if (choice.audio && process.platform === "win32") streams.audio = "loopback";
- if (choice.audio && process.platform === "win32") streams.audio = "loopback";
+ if (choice.audio && process.platform === "win32") streams.audio = "loopbackWithMute";
oh yeahhh
chromium implemented loopback on linux
did anyone ever test if it works in electron
vernal lintel
love how the difference between loopback and loopbackWithMute isn't documented anywhere whatsoever
so idk if loopbackWithMute is the fix
when you Google it you find chromium source code lmao
vernal lintel
actually i wonder if there's an artifact quota
oh yeah there is for private repos but I think it's unlimited for public repos
humble mortar
@vernal lintel one line kde oversight preventing default-action ActionInvoked signals
you loveeee
it wanted default-action-target even thought its optional
oopsies :p
vernal lintel
what 😭
simple groveBOT
simple groveBOT
hybrid fjord
Electron moment?
humble mortar
I'm fairly certain readFileSync can handle symlinks
vernal lintel
yeah it should
this guy is probably using flatpak and symlinked a file it can't access
humble mortar
is anyone gonna comment asking for bro to fill out the issue template
and if he isn't I'm gonna close it
humble mortar
https://github.com/electron/electron/pull/46112 @vernal lintel looks like the screenshare dismiss crash will be fixed in electron 35
simple groveBOT
cyan flame
simple groveBOT
simple groveBOT
humble mortar
@vernal lintel im going insane people yapping about vesktop CSD window buttons missing on visual refresh...,
vernal lintel
yes need to fix
humble mortar
REVIEW THE PR THAT FIXES IT!!11!
!
inject you with juice that makes your review prs
you will give me repo perms
humble mortar
@vernal lintel those patch changes are for the generic window control stuff, CSD still works on non visual refresh
vernal lintel
yes?
humble mortar
so the old patches are fine to remove..,.
vernal lintel
no
vernal lintel
okay now try clicking the window buttons
humble mortar
yop they work
AH
they close button killed vestkop
instead of going to tray,,,zz
other than that it works
vernal lintel
how
humble mortar
ur insane about the patches
vernal lintel
literally not possible lmao
humble mortar
well it is [JOEyep](https://cdn.discordapp.com/emojis/764008049723179038.webp?si...
False alarm.,!! the close to tray setting was off somehow..,,
ok anyway
the PR's patches changes work
youre insane
humble mortar
ypoo
vernal lintel
so it covers both
humble mortar
@vernal lintel hiiiii
humble mortar
GUH WRONG CHANNEL
vernal lintel
he changed where it's patching
basically Discord has like:
export const NativeCrap = {
window: {
close() {
DiscordNative.window.close();
}
}
}
// elsewhere, in the titlebar component
NativeCrap.window.close();
the old patch patched the NativeCrap.window.close() call in the component so it only applied to the component
His PR instead patches the DiscordNative.window.close() so it applies everywhere
that's where the confusion comes from
vernal lintel
veeb doesnt read PR descriptions
i like never do
simple groveBOT
we should hide this discord titlebar if you have discord titlebar disabled
you won't be able to access your inbox but welp blame discord for being braindead and not testing their web app
surreal agate
humble mortar
trolley I named it that cause you yapped about it
vernal lintel
no 😭
they're gonna remove it on linux and web soon enough once enough people complain
this is just them not testing at all on those clients
humble mortar
well if theyre gonna remove/fix it thats even more of a reason to have it as a vencord plugin 😭
vesktop updates arent fast like that
humble mortar
also the whole visual refresh insane spacing and bad contrast looks like shit
vernal lintel
vesktop updates arent fast like that
n it doesnt matter
wow our code that removes the titlebar doesnt work anymore because discord removed it
whatever will we do
humble mortar
no dingus if it breaks or changes
also exploding the inbox would be an insane choice
moving it would make more sense
but then that wraps around to it should be a vencor plugin so desktop users can not suffer too
vernal lintel
nop
humble mortar
i think you have brainworms
youll be getting people asking where the inbox is on vesktop
simple groveBOT
humble mortar
vee will give me issue lock perms
humble mortar
@vernal lintel gorp still no stable electron builder tag with the Ubuntu apparmour fix
vernal lintel
this is how easy it is to introduce a severe vulnerability btw @humble mortar
you're sending the entire ipcRenderer object back
in the old code
vernal lintel
cause arrow functions implicitly return the value and ipcRenderer.on returns ipcRenderer for chaining, so you can do like
ipcRenderer
.on("Event1", handler1)
.on("Event2", handler2);
that's why I asked you to change it to a normal function
humble mortar
i'm pretty sure w hat i had before was straight from the main->renderer preload docs
vernal lintel
yes 😭
wtf electron
well the severity of it depends on your own code
the problem with that is that you can send arbitrary events
which might or might not be bad
but even Electron docs warn you against exposing ipcRenderer
simple groveBOT
To anyone implementing this, please remember to also ensure the buttons are shown in the settings (as the primary UI's main titlebar isn't shown there), there seems to be some free space above the scrollbars:
On Discord mockups it'd show them like this:
humble mortar
real shit can we fork arrpc for our patches so next vesktop tag has auto db updating @vernal lintel
not a full fork just for patches so we aren't reliant on duckos schedule
simple groveBOT
With the new discord UI changes, it seems that the window controls are missing on Windows (11) when using discord's titlebar instead of the native one.
scenic hollow
ok so i'm trying to solve this
should i just call the preregister function on every start up on hyprland
as in i'd have to check to see if vesktop is being ran on hyprland then run preregister
my main concern is that this is kinda ugly and annoying but i also doubt if i ask any of the hyprland people to fix it they actually will do anything
or i make an issue on kde's side about making the shortcuts page not show up every time bindshortcuts is called
humble mortar
you should be doing that anyway
check if all shortcuts exist and if not register them all
if you try to register an id again intelligent impls will just ignore it
scenic hollow
pretty sure kde doesn't
humble mortar
check if all shortcuts exist and if not register them all
ListShortcuts exists for this reason
humble mortar
pretty sure kde doesn't
it does
& theres PR in the works that overhauls the UX of registering shortcuts
Every startup check if all ids are registered with ListShortcuts, if even one is missing you call BindShortcuts with every shortcut
ok igtg
scenic hollow
kde ignores in the sense that it doesn't make a new one but my main point (and the reason i've made it call bindshortcuts when the keybinds settings page is opened) is that it still opens the keybinds settings page anyways
scenic hollow
Every startup check if all ids are registered with ListShortcuts, if even one is...
ok well yeah if i do that that would be alr
humble mortar
@scenic hollow no shortcut action womp
also BindShortcut ids being simply numerical is bad..
impls use that to distinguish binds
if u remove 5 6 becomes 5 then everything explodes (descriptions dont match and kaboom)
Splash hangs on BindShortcuts and waits for it to return
TOGGLE_CAMERA is missing its readable description/included
this should be a whitelist i think
scenic hollow
also BindShortcut ids being simply numerical is bad..
i agree i just couldn't be bothered to change all that guhh
scenic hollow
yeah
scenic hollow
<@339669513912057857> no shortcut action womp
is that the log for that?
scenic hollow
everything works on kde for me
could it be it doesn't have an app_id??
scenic hollow
hmm
humble mortar
the spec is still the same
systemd-run --user -u app-vesktop@a8sf148gfhg pnpm --prefix /mnt/Bucket/Git/Vesktop/ start --ozone-platform=wayland launched like this
so its in its unit for portal identification
just like how plasma launcher does it
the events are firing
how do i look at what venbind is doing
is there a debug env var
scenic hollow
there is a bit about the bindshortcuts and listshortcuts in this log you sent i'd assume it's doing what it's supposed to??
humble mortar
yep
scenic hollow
how do i look at what venbind is doing
you can also run the rust test
humble mortar
there is a bit about the bindshortcuts and listshortcuts in this log you sent i'...
hangs the splash on BindShortcuts until it returns
i assume it also hangs on ListShortcuts but its too small to notice
it ssomething between the Activated and Deactivated signals and action in the client
humble mortar
you can also run the rust test
howg
scenic hollow
hangs the splash on BindShortcuts until it returns
what splash are u talking about exactly?
humble mortar
vesktop splash
scenic hollow
it shouldn't be getting called when splash is happening pretty sure???
humble mortar
it shouldn't be getting called when splash is happening pretty sure???
happens right after splash destruction but the splash hanags cause the thread is hung
yop works
that has been running for 60 seconds is cause i left the new kde dialog open
scenic hollow
`systemd-run --user -u app-vesktop@a8sf148gfhg pnpm --prefix /mnt/Bucket/Git/Ves...
ok this is completely random but can you try using uwsm instead of systemd-run cause that's what i do
humble mortar
ok this is completely random but can you try using uwsm instead of systemd-run c...
whats the command
scenic hollow
uwsm app -a vesktop -- pnpm start:dev
humble mortar
yeah no
i tried launching straight through plasma launcher
its not an appid issue
venbind?.startKeybinds((id, keyup) => {
mainWin.webContents.executeJavaScript(Vesktop.triggerKeybind(${id}, ${keyup}));
});
this callback isnt happening
im using the latest commit on ur PR branch
ok i just reverted the test kde portal branch i was on
it works now
ur not doing something in spec
only venbind is breaking on that branch
ashpd and my python demo work just fine
scenic hollow
only venbind is breaking on that branch
only venbind THROUGH VESKTOP apparently the tests work fine
humble mortar
yeop
ListShortcuts and BindShortcuts THROUGH VESKTOP work (hangs the thread tho which should be changed) work
Activated and Deactivated signals break through vesktop
ok igtg sorry i cant debug more
scenic hollow
ok i just reverted the test kde portal branch i was on
what version are you testing btw i'm on the 6.3.3 release are you on a newer commit or older
humble mortar
scenic hollow
ohh
simple groveBOT
humble mortar
@scenic hollow it might be worth it to implement the xdg host app registry api
to stop the reliance on systemd units
simple groveBOT
floral ledge
<@339669513912057857> it might be worth it to implement the xdg host app registr...
^
was coming in here to say this
since its officially in xdg no point in not implementing it
and its in ashpd
scenic hollow
ok so trying to use registry and i get Could not register app ID: Connection already associated with an application ID except when the shortcuts page shows up it's named token_ashpd_blabla which means there is definitely no app id???
scenic hollow
apparently that registry function has to be called before anything else including create_session
also the app id you choose is actually supposed to be the name of a .desktop file you've got. i didn't know that
humble mortar
yea
youll have to check if the env is flatpak or not
flatpak .desktop is dev.vencord.Vesktop
non is just vesktop
i think the container env var is set if its in a flatpak
scenic hollow
youll have to check if the env is flatpak or not
i think ashpd already checks that???? https://github.com/bilelmoussaoui/ashpd/blob/ebe5aabe5bd1afb2ed1631c30809a08e7f3c3a0f/src/registry.rs#L42-L44
sour muralBOT
i _think_ ashpd already checks that???? https://github.com/bilelmoussaoui/ashpd/...
registry.rs: Lines 42-44
if crate::is_sandboxed().await {
return Ok(());
}
i mean yeah apparently that's what is_sandboxed is https://github.com/bilelmoussaoui/ashpd/blob/ebe5aabe5bd1afb2ed1631c30809a08e7f3c3a0f/src/lib.rs#L58-L64
sour muralBOT
i mean yeah apparently that's what is_sandboxed is https://github.com/bilelmouss...
lib.rs: Lines 58-64
/// Check whether the application is running inside a sandbox.
///
/// The function checks whether the file `/.flatpak-info` exists, or if the app
/// is running as a snap, or if the environment variable `GTK_USE_PORTAL` is set
/// to `1`. As the return value of this function will not change during the
/// runtime of a program; it is cached for future calls.
pub async fn is_sandboxed() -> bool {
austere wolf
i feel like i could get a binary working that could improve windows screenshare but my bandwidth is taken up by other things
you could probably make it obs-like with enough effort but then i’d have to maintain it
tidal quarry
@vernal lintel would you want vesktop on brew? since its notorized and signing isn't an issue, I think it would be nice for it to be on there
I already made something for brew for it (this is my fork)
hopefully it should require little maintenance considering brew also supports livechecking from the latest yml
theres also taps, if you rather not have it be on the main homebrew cask repository
simple groveBOT
humble mortar
what the hell is ferdium
woeful current
@humble mortar using emojis... so rare
humble mortar
<@721853658941227088> using emojis... so rare
i was in a silly mood
simple groveBOT
simple groveBOT
simple groveBOT
simple groveBOT
woeful current
scenic hollow
@humble mortar didn't you suggest changing the cli design at some point
it does already do this one on XDP i thought you mentioned another thing too???
that's the one nvm
simple groveBOT
simple groveBOT
humble mortar
that's the one nvm
state switching by command is bad
it should be internally tracked
by default anyway
like --trigger=id (optional --type=up/down)
scenic hollow
i'm writing it so it's keyup by default unless specified
scenic hollow
like --trigger=id (optional --type=up/down)
currently it's --keybind=id or --keybind-[up/down]=id
and here --keybind=id means up by default
humble mortar
so I think --keybind should internally track state
otherwise users would need a script to do that
scenic hollow
on the other hand i think if someone used it they wouldn't expect to also have to call it again for keyup
humble mortar
well if its up by default running it wouldn't do anything
scenic hollow
i think most things work on up actually
humble mortar
hm idk
there is no up/down when dealing with commands
its only a state switch
if the bind is a single event it'll simply trigger that
but if its toggle mute or something
or push to speak
oh @scenic hollow did u figure out what was happening with events on the kde portal pr
scenic hollow
if it was so that a state is toggled on keybind it would have to be called twice so it's actually triggered (for example in someones wm config it would have to be vesktop -- --keybind=id && vesktop -- --keybind) cause most things only trigger when upped
unless we make the cli figure that out itself which is harder i think
scenic hollow
oh <@339669513912057857> did u figure out what was happening with events on the ...
nop not yet
humble mortar
if it was so that a state is toggled on keybind it would have to be called twice...
I'm gonna think about this for a bit
scenic hollow
if it was so that a state is toggled on keybind it would have to be called twice...
my point is if it were designed like that it would be expected for all WMs/DEs to call the cli upon keydown and keyup which is probably not gonna be what happens
scenic hollow
i think most things work on up actually
for reference
scenic hollow
this should be a whitelist i think
also i did this these are all the whitelisted ones
humble mortar
having it do up is fine for all the toggle ones but push is a different story
scenic hollow
maybe we could check that and then decide if we should state switch or not
still i think that would still be useless i don't know if we can even make any wm/de trigger the cli on keyup AND keydown
humble mortar
still i think that would still be useless i don't know if we can even make any w...
it would mostly function as a toggle atp
no wms I know of have up down events on command binds
but the state still needs to be swapped internally so only one key is needed
scenic hollow
it would mostly function as a toggle atp
honestly at that point write your own shell script
like i don't think there is any reason to implement that if it's not even gonna be normal
it's probably not that hard to write a shell script for this if that's what someone really wants
scenic hollow
ok trying the new xdp-kde pr and i think the reason why it gets stuck on the splash is because when preregister is triggered (which you'd think happens when the full page is open but apparently not??) BindShortcuts isn't actually completed immediately (which it currently does) because the cancel button there has to work properly
i'm yet to find out why the actual keybinds don't work tho
humble mortar
ok trying the new xdp-kde pr and i _think_ the reason why it gets stuck on the s...
youre synchronously blocking on async dbus calls
humble mortar
i'm yet to find out why the actual keybinds don't work tho
The signals are emitted something is just going wrong with the callbacks
scenic hollow
uhh @humble mortar which keybind were you testing exactly??