no auto accent in sight
#๐ฅ-vesktop-development
humble mortar
hybrid fjord
wha
hybrid fjord
Can you test what's on in-call icons
humble mortar
system accent
hybrid fjord
So only badges broken
humble mortar
yep
hybrid fjord
Oki
I'll take a look in few hours
What do you think of removing white circle in badge?
humble mortar
maybe done like the badge on the notif bell here
humble mortar
So only badges broken
the custom option seems to provide the correct colour tho
hybrid fjord
the custom option seems to provide the correct colour tho
Yeah it just some logic issue
Easy fixable
humble mortar
mhm
hybrid fjord
maybe done like the badge on the notif bell here
And this I'll try, but not sure how to create transparent background a little
hybrid fjord
@humble mortar fixed, you can pull and check
sorry for ping
and i made circle smaller a bit
since it does not have white in center
humble mortar
awesome :3
(u can see it in the top right)
i should setup kitty theme switching hm
simple groveBOT
simple groveBOT
humble mortar
@vernal lintel whats wrong with a tar ๐ญ
vernal lintel
archives have nothing to do in git
humble mortar
hm I assumed packagers would just curl the tar if they just wanted the icons and not the full repo
but yeah that doesnt make sense
if u want the icons u want the repo else youd grab the deb
should they be named the size they are or in a folder with their size
vernal lintel
archives have nothing to do in git
even images shouldn't really be in git
humble mortar
icon.png is there ยฏ_(ใ)_/ยฏ
humble mortar
ah
vernal lintel
generally it'd be better to only store the highest resolution and generate the lower resolutions during the build step
but idk how feasible that is
humble mortar
thatd bring in a build dep for packagers
could be done during vesktops actual build process actually
what actually splits the icon.icns when packaging the deb
humble mortar
magic box
humble mortar
should they be named the size they are or in a folder with their size
im just gonna do the png in a folder of its size for now
wait
hicolor supports scalable
an svg???
who can i harass for the svg
just providing all icons for now
simple groveBOT
azure verge
ive had this issue for a bit but im a little curious as to if yall know whether i should open the issue with vesktop or with vencord
marsh hinge
ive had this issue for a bit but im a little curious as to if yall know whether ...
well, test it on vencord and vesktop
and if it happens on vencord, report it on vencord
never seen that before tho
azure verge
shhh im stupid shhhhh lmfao
marsh hinge
test it on normal client as well
azure verge
ive had it for ages and i cant find out what causes it
hybrid fjord
ive had this issue for a bit but im a little curious as to if yall know whether ...
Maybe something with your dns/firewall or smth?
hybrid fjord
And what's in logs in browser?
azure verge
i def have the same issue on stock discord with no vencord so
ig it has to be some sort of network issue>????
simple groveBOT
marsh hinge
perhaps
marsh hinge
azure verge
omg
simple groveBOT
azure verge
its already enabled
marsh hinge
great !
vernal lintel
ive had this issue for a bit but im a little curious as to if yall know whether ...
neither
spotify issue
simple groveBOT
golden cypress
@vernal lintel did the Flathub issue get resolved by itself?
vernal lintel
the what issue
golden cypress
The one you pinged me a few days ago
Damn, it's already been 4 days
I legit thought it was early yesterday lmao, my bad
next sundial
vee, really liked the new layout, thx for the change! :)
humble mortar
kid named change the icon yourself ๐ญ
hot juniper
Hop off Windows 7
hot juniper
why is linux scary to windows 7 users
@vernal lintel do you have any clue after dealing with this
i only know a few things like
- end users of software are insane
- end users of software will do obviously wrong thing, think it isnt the issue, and make issue
- end users of computer scared of linux because muh vidya need kernel module
hot juniper
not trying to, sorry about that
simple groveBOT
upper pine
Sounds like an antivirus issue tbh
upper pine
Obv it has something to do with win7
But access denied is a weird error in that case
Normally the only issues caused by version differences is some missing export like set dpi awareness
teal summit
is there a way to open vesktop twice at the same time? Cuz I am using two accounts at the same time atm (installed via flatpak)
teal summit
well reasonable, tanks
hot juniper
idea for this thats too overcomplicated for the result you get:
use electron session to do multi-account in vesktop without multiple installations
simple groveBOT
humble mortar
when will people google the error message before opening a bug report ๐ญ๐ญ๐ญ
simple groveBOT
cyan flame
prolly a hardware acceleration issue
simple groveBOT
humble mortar
vesktop is failing to grab the game image hm
also some things like AAGL provide custom rpc via the launcher so some sort of filtering system is needed i think
vernal lintel
vesktop is failing to grab the game image hm
can repro but idk why
humble mortar
maybe one of vesktops privacy blocking things
humble mortar
can repro but idk why
want me to open an issue to track it?
humble mortar
also some things like AAGL provide custom rpc via the launcher so some sort of f...
aagl is detected via ipc and genshin as a process prob could just make ipc take priority
simple groveBOT
Discord Account
No response
Operating System
Arch Linux
Linux Only ~ Desktop Environment
SwayWM (Wayland)
Package Type
AppImage
What happens when the bug or crash occurs?
Application (Looking glass) is not populated in the audio sources list even though it is playing audio when attem...
robust cliff
Wait does vesktop not support third party plugins?\
vernal lintel
humble mortar
should i replace every instance of proacess.id with client.id in venmic.ts?
humble mortar
nothing appears now
upper pine
Check the screensharing modal as well
upper pine
Let me check
simple groveBOT
upper pine
This should do it @humble mortar
upper pine
What are you trying to share / do?
humble mortar
game under proton called vivid/stasis
upper pine
Does it have a node.name property?
humble mortar
how do i check
upper pine
If it doesn't it's more the games fault because we don't have any info to go off off
upper pine
how do i check
pw-cli ls Node
Find the one that's the game
Or look through pw-dump
Also, you should use granular selection if the game only has a node name (if it even does, but would be weird if it didnt)
humble mortar
id 129, type PipeWire:Interface:Node/3
object.serial = "1450"
factory.id = "7"
client.id = "189"
client.api = "pipewire-pulse"
application.name = ""
node.name = ""
media.class = "Stream/Output/Audio"
gamemaker moment
upper pine
id 129, type PipeWire:Interface:Node/3
object.serial = "1450"
...
Yeah, there's literally no information we could use to display that
upper pine
Speedrun PB for merged PR in Vesktop right here
hot juniper
I have a few small issues and questions regarding screensharing that I'm worried someone has asked for
1: Screenshare quality isn't remembered, and I feel it should be. I've read https://github.com/Vencord/Vesktop/issues/559
2: No source resolution option?
3: There's a LOT of assuming the aspect ratio is 16:9 in the source, does this actually affect anything? More specifically stuff like https://github.com/Vencord/Vesktop/blob/main/src/renderer/components/ScreenSharePicker.tsx#L84 and even worse, https://github.com/Vencord/Vesktop/blob/main/src/renderer/components/ScreenSharePicker.tsx#L737
sour muralBOT
I have a few small issues and questions regarding screensharing that I'm worried...
ScreenSharePicker.tsx: Line 84
const width = Math.round(height * (16 / 9));
ScreenSharePicker.tsx: Line 737
const width = Math.round(height * (16 / 9));
What I'm seeing here is my vertical resolution will get reduced because my aspect ratio is 43:18
humble mortar
Yeah, there's literally no information we could use to display that
I'm going insane I swear it was showing up before ๐ญ
hybrid fjord
Bc actually I think that we can stream any resolution we want
hot juniper
We can afaik
upper pine
I'm going insane I swear it was showing up before ๐ญ
Proton issue?
hot juniper
It's just Vesktop's screenshare handling seems to result in ultrawide 1440p looks bad to viewers
at least, from what I can remember
Why is width even required as a max resolution parameter?
hot juniper
What I'm seeing here is my vertical resolution will get reduced because my aspec...
Yes.
humble mortar
Proton issue?
maybe gamemaker exploded something ill try swapping around versions yea
hot juniper
hot juniper
fuck you
I have found the issue
(maybe)
.
yes because the max resolution is set to literally 0
i can be trusted to say I am streaming infinite pixels
hot juniper
i can be trusted to say I am streaming infinite pixels
kaboom
humble mortar
@upper pine sharing entire system crashes pipewire ๐ฃ๏ธ๐ฃ๏ธ
hot juniper
what am i cooking
upper pine
<@349609234985517057> sharing entire system crashes pipewire ๐ฃ๏ธ๐ฃ๏ธ
Can't repro
humble mortar
Can't repro
let me get u logs hold up
upper pine
Even with logs I can't change anything
I simply create links
It's pipewires fault then
hot juniper
hot juniper
โ ๏ธ
hot juniper
some patching required
horrible idea #1028117287716261939 message
@humble mortar does module 37113 explode if you watch my stream
humble mortar
me when i create a discord crasher
hot juniper
my bad
it will happen again
i think I fucked up Math.max and Math.min
hm
if I apply my patch it only streams in half resolution
nop its fine now
@humble mortar can you join my vc now?
humble mortar
yyerp
hybrid fjord
It's just Vesktop's screenshare handling seems to result in ultrawide 1440p look...
What if to add picker for aspect ratio?
humble mortar
literally pointless ๐ฃ๏ธ
hot juniper
What if to add picker for aspect ratio?
It isn't that I think
I've made a disgusting workaround
hot juniper
some patching required
but if anyone joins without this patch their client will crash
turns out discord uses this on viewer end
it exists literally just for this
i think
humble mortar
Can't repro
ok its pipewire 1.2.1 causing the crash
humble mortar
๐ญ๐ญ๐ญ
hot juniper
im gonna admit i've been yapping about how to get ultrawide screenshare to be proper resolution for too long
humble mortar
im gonna admit i've been yapping about how to get ultrawide screenshare to be pr...
keep yapping I run 21:9 ๐ฃ๏ธ๐ฃ๏ธ
hot juniper
@humble mortar can you do me a favor?
do you have discord desktop installed
guh
i would ask friends to help but they're all asleep
hot juniper
@upper pine Do you have discord desktop installed I need to recreate behaviour and need reference
upper pine
no sorry
hot juniper
alright
compact frigate
i would help but away from home and my laptop has shitty wifi
compact frigate
:(
hot juniper
i would help but away from home and my laptop has shitty wifi
idc about actual streaming quality results I just need metadata
hot juniper
stream in source quality from discord desktop
must be source
I'm trying to see what metadata discord returns
ugh
its not in videostreamparameters
hot juniper
alright
compact frigate
actually nvm i use vesktop
vernal lintel
nop doesnt
hot juniper
i had my ternary around the wrong way
vernal lintel
works on my machine
hot juniper
probably because I am trying to copy output of ```ts
[...Stores.MediaEngineStore.getMediaEngine().connections].find(
connection => connection.streamUserId === "799319081723232267"
)
why
hot juniper
update: i asked a support user who was interested in related stuff for how it worked in bd and then i found a vencord port of it
BD dev was here
so verbose
?remindme 3h thanks discord canary go fix SPN
small lionBOT
Alright @hot juniper, in 3 hours: thanks discord canary go fix SPN
hot juniper
i was gonna submit this 
but then i just asked a whole load of stuff in here
and now I'm busy adding source quality settings
wtf its there
next sundial
@upper pine https://github.com/Vencord/Vesktop/commit/9acc6652ff72531194f5159576abcf79845edc84 does this commit also change the UI?
simple groveBOT
hot juniper
How did we get here? (Vesktop will outright crash if you cancel the screenshare request)
hot juniper
How did we get here? (Vesktop will outright crash if you cancel the screenshare ...
Occurs in official release too 
vernal lintel
shrimply dont cancel it lol
hot juniper
too bad i am submitting bug report
hot juniper
ok back to crashing other people's clients
trol
i will say i am streaming an incompatible resolution
hot juniper
BD dev was here
love
?remindme 14h go ~~fuck up ~~ fix vesktop screensharing more and go crash friends clients for fun
small lionBOT
Alright @hot juniper, in 14 hours: go ~~fuck up ~~ fix vesktop screensharing more and go crash friends clients for fun
hot juniper
brain too cooked to finish that now
upper pine
No, only adds a new toggle as we've yet to agree on a proper UI
upper pine
<@349609234985517057> https://github.com/Vencord/Vesktop/commit/9acc6652ff725311...
Replied to this but discord didn't do it for some reason
dark quarry
since the latest vesktop release, window position is not remembered anymore when launching vesktop on system startup, but it is remembered when quitting and then launching it (win11, discord titlebar enabled, no transparencies or disabled windowframe), am I the only one
robust cliff
https://docs.vencord.dev
I've already checked that and you replying to me means thats a yes. The reson I was asking that was because I was trying to build vesktop and it just refused even when doing all of the steps in order
hot juniper
since the latest vesktop release, window position is not remembered anymore when...
This is such a niche issue, good job finding it
robust cliff
since the latest vesktop release, window position is not remembered anymore when...
i dont really pay attention to that friend. you said win11?
what are your monitor settings
dark quarry
monitor settings?
hot juniper
I've already checked that and you replying to me means thats a yes. The reson I ...
Sounds like you forgot to install dependencies. Also make sure you read this tab specifically
hot juniper
what are your monitor settings
what would that have to do with anything
robust cliff
Sounds like you forgot to install dependencies. Also make sure you read this tab...
I've installer dependencies and originally there was no dist folder when I packaged or built
robust cliff
what would that have to do with anything
trying to fix his issues #๐ฅ-vesktop-development message
seeing if it is a monitor specific issue
or like a settings specific issue
hot juniper
seeing if it is a monitor specific issue
Literally impossible
robust cliff
Literally impossible
other things have had hardware specific bugs
my nuc has this bug where the monitors flop randomly on sleep only on certain monitors
robust cliff
that or the window manager is messing up
dark quarry
there is one thing specific to my setup that might also have an effect which I have not yet tested, but I have my vesktop window very close to my taskbar, and my taskbar is narrower than w11 default through a modification, but this has never been an issue before
I'll do a quick test
hot juniper
sour muralBOT
https://github.com/Vencord/Vesktop/blob/f31f06f5c4f99f66acb09d3e6153d4f007f95ac1...
mainWindow.ts: Line 274
const storedDisplay = screen.getAllDisplays().find(display => display.id === State.store.displayid);
i have done exactly that and there is no difference in the build after changing the folder
hot juniper
could be electron returning a different display id based upon the working area @dark quarry
dark quarry
there is one thing specific to my setup that *might* also have an effect which I...
doesn't seem to be caused by any possible taskbar overlap
alright
I only have one monitor fwiw
hot juniper
wtf?
nvm
can you reproduce by removing && storedDisplay from line 276
hm
doing that on startup might be a bit annoying actually
dark quarry
can you reproduce by removing ` && storedDisplay` from line 276
that would mean I have to build vesktop from source
hot juniper
idk sounds like you expected your vencord to be significantly different just because you installed from source
robust cliff
idk sounds like you expected your vencord to be significantly different just bec...
i just followed the docs
hot juniper
reasonable
humble mortar
@upper pine vesktop under wayland pipewire 1.2.1 attempting to share entire system crashes pipewire
im gonna open a pipewire bug report where do i get the crash logs
upper pine
<@349609234985517057> vesktop under wayland pipewire 1.2.1 attempting to share e...
Doesn't crash for me, but open a bug report at pipewire, it's most likely an issue with them
humble mortar
Doesn't crash for me, but open a bug report at pipewire, it's most likely an iss...
wait what electron version
upper pine
Not sure, can check later - But I'd be surprised if thats actually related
humble mortar
wait u said venmic just links stuff right
Jul 12 18:44:54 bakery pipewire[6094]: pw.link: (120.0.1 -> 161.1.1) negotiating -> error (error set input format: -22 (Invalid argument)) (paused-configure)
upper pine
Jul 12 18:44:54 bakery pipewire[6094]: pw.link: (120.0.1 -> 161.1.1) negotiating...
Pipewire is responsible for figuring out the format and regardless, it shouldn't crash if there's a problem with link creation but report back to the client (venmic)
humble mortar
guh its not crashing anymore
now vesktop is freezing if i try to restart the stream after ending a stream that shared the entire system
something is fucked
restarted and now the pipewire crash happens again
hm
the flatpak doesnt cause the crash nor does it create any errors with pipewire
also stops the crash with the system vesktop
but doesnt stop the errors
reseting my config fixed it ?? what the hell
what the hell was fucked with my vesktop config
compact frigate
vernal lintel
looks like venmic issue
azure verge
btw to yall incase you need it, (the gpu sucks cuz there isnt a driver yet, but its being developed) i now have an arm64 device that i can test with
lmk if u need me to test something on arm linux
simple groveBOT
tired oak
I hate this name
so much
I just dont want to think about it
ill rename it later
I might name it EquiBop
because bop it
simple groveBOT
Discord Account
sapling.
Operating System
Arch Linux
Linux Only ~ Desktop Environment
KDE Wayland
Package Type
AUR (git version)
What happens when the bug or crash occurs?
When trying to connect to a voice channel, the connection hangs on "DTLS Connecting" indefinitely.
What is the expected behaviour?
Expected behavior is that the user is connected to the voice chann...
humble mortar
me when I encounter the stuck on DTLS connecting bug and blame vesktop instead of discord
small lionBOT
@hot juniper, <t:1720810263:R>: go ~~fuck up ~~ fix vesktop screensharing more and go crash friends clients for fun
dark quarry
can you reproduce by removing ` && storedDisplay` from line 276
ok so I cloned source and pnpm starting it after a reboot had the window in the middle of the screen. Removed && storedDisplay, started it, moved the window to the desired position, rebooted, started it again and window was in the desired position so success?
I'll try packaging it so 'start with system' works proper
packaged, installed modified version and it works like it used to
robust cliff
packaged, installed modified version and it works like it used to
unrelated to your situation but could you send me the commands you used to build vencord it just doesnt work for me at all
I'm just gonna try to repackage it and maybe that'll worj
vernal lintel
read the readme
simple groveBOT
vernal lintel
begging people to stop blaming everything on vesktop
robust cliff
reinstalling witht he packaged app didnt work either
robust cliff
begging people to stop blaming everything on vesktop
im not im just trying to get help
sorry i should have said not helpful for me
vernal lintel
i was referring to this.
simple groveBOT
robust cliff
i was referring to this.
oh mb mb
robust cliff
ive used vesktop temporarily on linux with gnome and it worked fine so it must be a sys issue i dont really see how a tiny diff in distros would change anything
hybrid fjord
Why kde always breaking something ahahahahahha
On every update something stops working xdd
robust cliff
Why kde always breaking something ahahahahahha
On every update something stops w...
i dont use linux enough in that situation but i heard that and cinnamon were better than gnome
i just dont like the mac look but it works fine
is kde just th at buggy
robust cliff
How do you check if the --dev tag worked in vesktop?
simple groveBOT
I'm having the same issue:
simple groveBOT
upper pine
What kind of fucked up system does this guy have
Not able to connect to pulse and not able to connect to pipewire
vernal lintel
im not sure if this is even venmic related
i just saw venmic error in log so I moved it
if you think it's not venmic issue we can move it back
upper pine
It could very well be venmic, but I think it's more a system issue than something I can fix
vernal lintel
I can repro this on gnome
but idk why it happens, we made no changes to the native screenshare logic
so it's either venmic or electron / chromium regression
basically when you're in the screen / monitor picker portal popup and you cancel it
I doubt it's venmic tho cause it shouldn't run at that point
upper pine
I doubt it's venmic tho cause it shouldn't run at that point
Yeah I think it's electron
Lol why don't they match
vernal lintel
discord is for some reason incapable of properly handling server avatar, so it's a 50/50 whether it uses global avatar or server avatar
idk why it's so hard for them
upper pine
lmao
upper pine
I'll see if I can fix this somehow on mint, their default setup is so fucked that I can't abort the venmic wait
vernal lintel
oh
upper pine
It's super cursed
vernal lintel
wtf is wrong with mint
upper pine
They don't use pipewire, but have a pipewire session which promises to send me some data but then never follows up on that promise and leaves me waiting on like 5 objects that it promised to send but never actually does
And at that point I can't abort the wait on all of them
vernal lintel
how do they manage this
upper pine
Idk
If you install wireplumber it's fixed
Not sure if they have some patched pipewire media session installed
vernal lintel
would it be possible to just move venmic into a thread?
so even if it deadlocks it doesn't crash the app
upper pine
It is threaded, but I want to properly clean up in case of an error
Mint doesn't allow me to properly do that tho, it works on literally any other setup with pulse
vernal lintel
It is threaded, but I want to properly clean up in case of an error
could that also be moved into a thread
basically just run the entire thing in a thread
or does it have to be on the main thread
upper pine
That would be a hacky workaround
I have to respond to the Vesktop requests
I can't defer that
vernal lintel
promises with callbacks
upper pine
ugh, I guess that would work but it would be quite ugly
I'll replace the venmic addon constructor with a static promise factory
And then figure out a way to properly handle the fucked case of mint
upper pine
I'll replace the venmic addon constructor with a static promise factory
I think I'll do that
That would be the best approach
vernal lintel
we could handle the thread in nodejs
you can have independent nodejs threads that can send json messages to each other
vernal lintel
but only if you think it's a good idea
upper pine
Yeah
It's the best approach I can think of
It could also replace the try catch we have on construction
So it would be fairly clean then
vernal lintel
the nodejs solution would also be pretty easy tho
and make everything fully asynchronous
upper pine
Not sure, but a proper solution in venmic would be nice as well, and make third-party integration easier
We could to both
In case one fail safe fails
humble mortar
grrr why does electron 31.1 have so many dumb regressions
vernal lintel
xd
simple groveBOT
simple groveBOT
vernal lintel
READ THE FUCKING ISSUE TEMPLATE CHALLENGE
humble mortar
kid named i dont understand how git works and ading's fork isnt up to date with main so its venmic isnt updated
next sundial
READ THE FUCKING ISSUE TEMPLATE CHALLENGE
please add "I confirm that I am a clown ๐คก by checking this checkbox" ๐
vernal lintel
no
next sundial
๐ญ
scenic hollow
yall i need some guidance on using findbyprops. so i need an export (with a name) from a module right? and what constitutes as a module? the parts starting with random numbers or the whole file?
and if the function i'm looking for doesn't have a proper name what can i do?
compact frigate
yall i need some guidance on using findbyprops. so i need an export (with a name...
what constitutes a module
parts starting with random numbers
and if the function...
findByCode will match the same module, just give it a snippet of code taken from the module
scenic hollow
alright and from what i understand when i use findByCode i don't get the actual function i only get the module. how would i use the function if it has a generated name?
oh apparently it returns a function??
scenic hollow
findbycode just doesn't work wth
hot juniper
findbycode just doesn't work wth
dont put spaces or extra formatting added by the prettifier in devtools
scenic hollow
i didn't pretty sure
chromiums search finds it just fine
hot juniper
also it must be within the class or function returned by the module
hot juniper
also it must be within the class or function returned by the module
likely your case
vernal lintel
all the finds search module exports
hot juniper
this
vernal lintel
if your function isn't exported you can't find it
scenic hollow
i see
in that case i don't think findbycode is useful at all. the main function is returned by another (exported) function
runic inlet
i see
in that case i don't think findbycode is useful at all. the main function...
what function are you trying to find?
hot juniper
i see
in that case i don't think findbycode is useful at all. the main function...
What is the module ID you are trying to find
runic inlet
what function are you trying to find?
so, what does the function do
hot juniper
if you see this assume the return value is what the module exports
scenic hollow
What is the module ID you are trying to find
13140 and the function is BB (on stable branch)
scenic hollow
if you see this assume the return value is what the module exports
yeah it's exactly that except it still doesn't find it??
hot juniper
13140 and the function is BB (on stable branch)
What does this even do
scenic hollow
so, what does the function do
it's for turning an array into a string shortcut sequence
scenic hollow
yes it used to be so that you could use findbyprops to find this function but you can't anymore
hot juniper
please add "I confirm that I am a clown ๐คก by checking this checkbox" ๐
this used to be a thing in #๐ณ-plugin-requests
hot juniper
yes it used to be so that you could use findbyprops to find this function but yo...
what string are you using to find it
i found a unique string in there
scenic hollow
.navigator.appVersion.indexOf i'm pretty sure that's also unique
maybe i'm doing something wrong
hot juniper
i have something really stupid to ask
are you ACTUALLY using findByCode
there is a 99.9999% chance that wont work if you have it as a constant in your code
you need findByCodeLazy
so the find is only attempted upon use
vernal lintel
i see
in that case i don't think findbycode is useful at all. the main function...
what's the problem
hot juniper
are you ACTUALLY using `findByCode`
this has to be it
hot juniper
so the find is only attempted upon use
which should always be after its loaded
scenic hollow
huh alright i'll try again when i get home
hot juniper
hope that helps
dark quarry
@hot juniper btw any thoughts about the window position thing?
hot juniper
<@259558259491340288> btw any thoughts about the window position thing?
i think a debug option to disable the check should be added
actually
why isnt there even an option to disable the feature at all?
dark quarry
what's weird is that it only started happening last vesktop update but that line has been there before
oh wait there were no updates pushed nvm
thought there had been but time flies apparently
hot juniper
At this point blaming Chromium for everything weird with windowing on any OS for any Electron app is starting to sound reasonable
chromium on wayland on linux is cursed
if thats true I know it has to be at least a little bit broken on Windows
simple groveBOT
Discord Account
AJCxZ0
Operating System
Fedora 40 (Workstation Edition)
Linux Only ~ Desktop Environment
GNOME on Wayland
Package Type
Flatpak
What happens when the bug or crash occurs?
Moving the Vesktop window to the top of the screen, below the top bar, reveals that the top of the window is above the title bar.
What is the expected be...
simple groveBOT
simple groveBOT
scenic hollow
oh that might be it
can confirm that works!!!
scenic hollow
@humble mortar ^^
humble mortar
<@721853658941227088> ^^
$ dist/linux-unpacked/vesktop --keybind 3 right?
scenic hollow
yep
humble mortar
hm
scenic hollow
probably
humble mortar
isnt working
scenic hollow
is that the keybind that shows up in the shortcuts page?
humble mortar
id 3 yea
scenic hollow
`$ dist/linux-unpacked/vesktop --keybind 3` right?
there isn't an error or anything when running this right? is it not running another vesktop instance?
humble mortar
there isn't an error or anything when running this right? is it not running anot...
theres a vesktop instance open
APPIMAGE env is not defined, current application is not an AppImage
checkForUpdatesAndNotify called, downloadPromise is null
[kylie@bakery Vesktop]$ dist/linux-unpacked/vesktop
APPIMAGE env is not defined, current application is not an AppImage
Vesktop is already running. Quitting...
checkForUpdatesAndNotify called, downloadPromise is null
[kylie@bakery Vesktop]$ ```passing --keybind doesnt say theres another instance
is that intentional?
scenic hollow
yeah that should be how it works
is it a push to talk/mute/deafen type of keybind?
humble mortar
scenic hollow
huh try setting a keybind?
humble mortar
nope
scenic hollow
i haven't tried it in a production environment lemme see
humble mortar
wait holdon
at IpcRendererInternal.emit (node:events:519:28)
at Object.onMessage (node:electron/js2c/renderer_init:2:8837)
(node:10741) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 13)
(node:10741) UnhandledPromiseRejectionWarning: Error: Script failed to execute, this normally means an error was thrown. Check the renderer console for the error.
at node:electron/js2c/renderer_init:2:16470
at IpcRendererInternal.<anonymous> (node:electron/js2c/renderer_init:2:10723)
at IpcRendererInternal.emit (node:events:519:28)
at Object.onMessage (node:electron/js2c/renderer_init:2:8837)
(node:10741) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 14)
didnt see that at first
different terminal tab
^ happens when i run the --keybind arg
scenic hollow
okay i can confirm it doesn't work in a release environment with my setup either
scenic hollow
``` at IpcRendererInternal.<anonymous> (node:electron/js2c/renderer_init:2:10...
i also get this error
scenic hollow
``` at IpcRendererInternal.<anonymous> (node:electron/js2c/renderer_init:2:10...
what does the VM624 file mentioned in this error contain for you?
scenic hollow
`$ dist/linux-unpacked/vesktop --keybind 3` right?
oh nevermind it's supposed to be vesktop -- --keybind 3
with 2 sets of dashes specifically
humble mortar
@scenic hollow setting the bind in app with your branch doesnt work but then closing and launching normal vesktop it works?! (vesktop has to be focused)
did u specifically block the bind from working in app on your fork?
vernal lintel
lol why do u have to pass --
next sundial
Discord (v0.0.60) for Linux gets native streaming via xdg-portal
saw on reddit
pog
vernal lintel
relevant to this chat how
simple groveBOT
hot juniper
> Discord (v0.0.60) for Linux gets native streaming via xdg-portal
Wtf really?
hot juniper
relevant to this chat how
wayland screenshare is the major vesktop selling point
hot juniper
Wtf really?
It's true
lmao
.
its so unstable
because of their native Sentry module
also the official picker popup works SO BADLY that it just keeps requesting access to capture sources
It also manages to segfault if you dismiss the popup just like Vesktop does
scenic hollow
did u specifically block the bind from working in app on your fork?
yeah because when we have a proper global shorcuts implementation it would still work fine
if i don't do that we'd have to deal with callbacks firing twice when the window is focused
vanilla discord does the same thing
simple groveBOT
Content
I have enables Multi Account Switcher but don't see any changes. Can not log in to a other account.
humble mortar
MOBILE ACCOUNT SWITCHER
I'm insane I'm insane I'm insane I'm insane
who let this user have access to a computer
azure verge
it literally just doesn't say multi account switched and it specifies mobile
I think they're insane
humble mortar
if i don't do that we'd have to deal with callbacks firing twice when the window...
ah ok so youre intentionally blocking it. interesting that the custom bind works without the patch after setting it
humble mortar
I think they're insane
ai hallucinations
scenic hollow
ah ok so youre intentionally blocking it. interesting that the custom bind works...
yeah they literally have support for it on the web but they block the ui
dreamy kiln
teal summit
people who canโt read their own screenshots my beloved
simple groveBOT
Discord Account
Glitchite
Operating System
Debian x11 and Wayland
Linux Only ~ Desktop Environment
Plasma
Package Type
Flatpak
What happens when the bug or crash occurs?
No audio sources show up. And yes I made sure it was playing first.
What is the expected behaviour?
To show all and any playing audosources.
How do you recreate this bug or crash?
- use Debian ...
cyan flame
Bug <title> my fav
humble mortar
in the year of our lord 2024 do we need to tell people to use pipewire omg
upper pine
How do people open issues for this?!?
It literally says in the log:
2024-07-16 04:09:36.027] [venmic] [warning] [patchbay] (get) pipewire was not detected as main audio server
Which means that a warning box shows up in the client where it states that pipewire is not the main server and you have to explicitly click "I know what I'm doing"
And then they open an issue, this is not even the first issue where this happened
sudden trout
can I suggest adding a box to the template that's something along the lines of "Yes I have confirmed pipewire is running"
scenic hollow
oh hey libuiohook is planning to add wayland support https://github.com/kwhat/libuiohook/issues/196
teal summit
How do people open issues for this?!?
It literally says in the log:
```
2024-07...
people donโt read
simple groveBOT
Discord Account
No response
Motivation
Audio slider from Quick Settings Audio Panel GNOME extension
Audio sliders from GNOME settings app
Vesktop audio streams are all referred to in the system as Chromium. This is essentially true, but it would be better to see that they are Vesktop audio strea...
upper pine
people donโt read
Maybe I should add a modal that opens when clicking the text that reads something along the lines of "I understand that I'm probably not using pipewire and that I will not seek support in any official channel in case no application sources show up"
And add a cool down on the ok button lmao
vernal lintel
or just remove it :p
no one has system like this
or if they do they should either embrace pipewire or build from source
hybrid fjord
Maybe I should add a modal that opens when clicking the text that reads somethin...
you can add clown image for cursed systems xd
upper pine
or just remove it :p
you're probably right
Doesn't hurt to be opinionated to deal with less dumb issues
The reply has another pfp again
But I don't see that pfp on this server nor in the dms
I guess the server pfp is just completely broken xd
woeful current
petition to autolock system issue
since either people
- can't acknowledge its their system thats insane
- or can't read "added label
system issue"
simple groveBOT
works on one DE but not the other = definition of a system issue
also you havent read the issue template.
hybrid fjord
V I want reviews on #517 for continuing working on it๐ญ
humble mortar
6 more days till chromium 127 is stable ๐๐
hybrid fjord
And x more days for stable electron update with m127
simple groveBOT
simple groveBOT
simple groveBOT
hot juniper
6 more days till chromium 127 is stable ๐๐
I hate saying this but...
6 more days until Chromium devs announce they broke more native wayland stuff and they're gonna fix in v128
marsh hinge
I hate saying this but...
6 more days until Chromium devs announce they broke mo...
v128:
- fix some bugs
- implement 2x more bugs
hot juniper
v128:
- fix some bugs
- implement 2x more bugs
chromium dev cycle real
teal summit
does chrome even support wayland without xwayland thingy
balmy summit
is there any way to start a screenshare with this as an audio source?
simple groveBOT
upper pine
is there any way to start a screenshare with this as an audio source?
With latest changes that should work (Depending on what kind of node it is)
upper pine
VMWare
vernal lintel
horror
upper pine
I know lmao
hot juniper
have you ever used virt-manager
upper pine
Yes
hot juniper
Thoughts on it?
upper pine
Quite good, however it lacks hardware/3d accel which VMWare has
simple groveBOT
vernal lintel
shrimply PR
how is mint so cooked #๐ฅ-vencord-support-๐ฅ message
all the venmic issues and now this
hot juniper
at this point nobody cares about native web client enough so reasonable people will make it a venmic feature intsead
hot juniper
how is mint so cooked https://discord.com/channels/1015060230222131221/102651588...
not a mint issue
vernal lintel
i tried on ubuntu and can't repro
hot juniper
nvm im stupit
vernal lintel
hot juniper
nvm
wait am i stupid
Does anyone still experience Vencord unloading with Vesktop?
Discord's own app disables the IntensiveWakeUpThrottling feature
Why isn't Vesktop doing this?
Vencord and Vesktop both try to disable some features to stop unloading
azure verge
6 more days till chromium 127 is stable ๐๐
wait what's fixed in 127
hybrid fjord
wait what's fixed in 127
Stream struggles on mousemove
hybrid fjord
There is even test flatpak build of that chromium with fixes
azure verge
that's really cool
hybrid fjord
Check here last messages https://issues.chromium.org/issues/333945842
azure verge
interesting
simple groveBOT
Discord Account
No response
Operating System
Endeavour OS
Linux Only ~ Desktop Environment
KDE6 Wayland
Package Type
Flatpak
What happens when the bug or crash occurs?
I start Vesktop and this appears:
What is the expected behaviour?
This does not appear.
How do you recreate this bug or crash?
Start Vesktop
Debug Logs
Replace this text with your ...
simple groveBOT
simple groveBOT
simple groveBOT
Thanks for the tip there Axel living up to your name. Here's a KDE approximation of this concept
Exported the above to a rule you can import from the GUI, github doesn't like the extension so I added .txt.
simple groveBOT
Discord Account
bingbongboink
Operating System
Fedora 40
Linux Only ~ Desktop Environment
KDE on Wayland
Package Type
Flatpak, RPM
What happens when the bug or crash occurs?
When joining a VC channel, the status gets stuck on "DTLS connecting." Problem does not occur on firefox.
What is the expected behaviour?
Able to join voice channels and communicate with other me...
simple groveBOT
simple groveBOT
I added a preview of the splash image to the Vesktop settings menu. This is an important requirement for loading the animation from the Vesktop cache, since displaying only the file path won't be possible with that approach.
I do eventually plan to implement all of the suggestions in #667, such as adding the ability to choose multiple images that are selected randomly and adding a toggle to...
arctic barn
i cooked a bit in the custom splash animation pr
hybrid fjord
looks good ^^
arctic barn
so with this pr, venmic works again on older linux distributions such as debian stable
upper pine
@vernal lintel I'm not sure what your stance on this is, but I dislike the static builds a lot - Static linking libstdc++ isn't that good of an idea imho and resorting to the flatpak is just better in my opinion - But if enough people think shipping builds with static linked libstdc++ is a good idea I might consider it, eventhough there are a plethora of reaons why it is discouraged
upper pine
@vernal lintel Can we dynamically link the newer libstdc++? Will the rpath be respected when I set it or are there any electron gotchas?
vernal lintel
idk what that means
upper pine
Uh
All shared libaries or executables can load their dependencies dynamically
There's a thing called rpath, which allows a file to register relative paths which are searched to resolve the dependencies
That way, we could ship a libstdc++.so that along side the venmic addon, that will be the fallback in case the system isn't able to find a so file that works with venmic
What I'm wondering is, if electron bundler somehow messes with the rpath (e.g. it's a common thing for python module building tools to fuck up the rpath)
scenic hollow
i'm working on the native side (which is written in rust) of keybinds and i just thought what should i use for communication between the native side and electron?
i'd assume this is a bit more real-time than venmic so maybe whatever venmic's doing isn't as suitable?
i guess the most obvious way would be a websocket or smth
simple groveBOT
vernal lintel
try again @tired oak
tired oak
try again <@848339671629299742>
I'll try in a moment just woke up
I can confirm it works
simple groveBOT
upper pine
i guess the most obvious way would be a websocket or smth
What? How is a websocket faster than a native addon
hybrid fjord
i'm working on the native side (which is written in rust) of keybinds and i just...
Maybe named pipe?
As a variant
vernal lintel
WYSI
simple groveBOT
upper pine
Would the normal electron scheme even work in this case? If discord isn't open it's not a normal browser scheme but a desktop one
vernal lintel
^
next sundial
out of curiosity, why are we migrating Vencord loader to ASAR?
scenic hollow
What? How is a websocket faster than a native addon
i thought you can't do a communication "channel" in an addon. it's important that the native side can talk to the electron side any time it wants
am i wrong on that?
scenic hollow
Maybe named pipe?
but yeah named pipe seems like a good option
scenic hollow
huh i know that person from somewhere
upper pine
i thought you can't do a communication "channel" in an addon. it's important tha...
Use a callback
hybrid fjord
Actually sometimes I get this too
Sounds like sound when audio device dis/connected
upper pine
Sounds like sound when audio device dis/connected
Don't think this is anything we can fix
hybrid fjord
Don't think this is anything we can fix
Yeah, me too
Its like links are recreating or devices are reloaded, sounds something like that
upper pine
Curious that it doesn't happen in obs tho
Most likely an issue with how electron handles mic input
hybrid fjord
Curious that it doesn't happen in obs tho
Obs can use more native solutions for sound capturing
upper pine
Don't think that's the fix tho
I'm fairly certain electron may not be reading the buffer properly
humble mortar
would not passing on process to the client when theres a duplicate ipc detection be a vesktop or arrpc thing
humble mortar
yep electron skill issue
scenic hollow
Use a callback
apparently that's not as hard as i thought huh
simple groveBOT
Discord Account
despera_.
Operating System
Linux - EndeavourOS
Linux Only ~ Desktop Environment
KDE - Wayland
Package Type
Flatpak
What happens when the bug or crash occurs?
Not a bug nor a crash, just an icon fix.
What is the expected behaviour?
Vesktop having a blurry icon inside of Flatpak permissions.
How do you recreate this bug or crash...
simple groveBOT
simple groveBOT
humble mortar
any reason why vesktop doesnt name its processes? th-ch yt music is electron and does correctly
oh its cause vesktop is using global electron
vernal lintel
it's not
that's your package doing it.
if you use officially packaged vesktop it will be named vesktop
humble mortar
oh its cause vesktop is using global electron
yea I realized that
how much space does using system electron even save
simple groveBOT
simple groveBOT
In the meantime,
I used Platypus to register discord:// scheme and open vesktop app.
It doesn't passtrough args to vesktop but merely just opens the app
Example of config for Platypus :
In script path, I just added a script containing this :
#!/bin/sh
open -jga /Applications/Vesktop.app
When you tick "Accept droppe...
simple groveBOT
simple groveBOT
vernal lintel
Arch btw
hybrid fjord
Why users keep saying "same" without new relevant info instead of thumbs up
simple groveBOT
humble mortar
Why users keep saying "same" without new relevant info instead of thumbs up
same!
humble mortar
Any status update on #686 and #517
vernal lintel
wdym by "update your electron"
simple groveBOT
humble mortar
wdym by "update your electron"
the electron version vesktop ships with doesnt have the paste bug so that means their package is using their system electron thus they need to update their electron
vernal lintel
if u use rpm you use packaged
simple groveBOT
simple groveBOT
simple groveBOT
humble mortar
hm must be a dep of electron's that has the bug then
tidal quarry
@sly cairn are you gonna ever get vesktop (maybe vc installer too) notorized because having it signed without it is practically useless if it still cant get passed gatekeeper
simple groveBOT
sly cairn
<@96269247411400704> are you gonna ever get vesktop (maybe vc installer too) not...
i have no idea how to automate the process
because whenever i asked about it i just got told good luck
ok it seems easy enough
next sundial
Discord seems to have changed their accent color for some places. Is this something Vesktop can "fix" to restore old behavior?
(compare "Notification Settings" background, which is old behavior, with the checkboxes colors)
vernal lintel
Discord seems to have changed their accent color for some places. Is this someth...
I think it was an accident
next sundial
I think it was an accident
from Discord or from Vencord/Vesktop code?
dunno from where the change originated, but I remember Vesktop being able to change the color in the screenshare UI to fix it
vernal lintel
discord
sly cairn
haven't got a clue if it'll work
but according to electron builder docs that's all it needs
oh wait
no
sly cairn
issue is the way it works in the CI is different to how i can test it*
so i dont know if it'll work
and also i cant run it on my machine because im not using a mac!
so i dont have xcode or notarytool or anything
vernal lintel
@sly cairn you can test it by pushing an -alpha.1 tag to ur branch
sly cairn
alr
simple groveBOT
vernal lintel
it doesn't matter xd
sly cairn
gonna shred it later anyway xd
vernal lintel
u also have to bump in package.json I think
sly cairn
nah
its running the ci
okay so what ive read
is that this takes 5-15 minutes
so the CI will literally just do nothing
for that time
fun :D
sly cairn
ah
Your app may need to be signed with hardenedRuntime: true option, with the com.apple.security.cs.allow-jit entitlement.
"may"
hm
seems like its on by default
it
didnt seem to do it
okay
sly cairn
idk what the changes to the package.json are for but i guess i'll copy
vernal lintel
I assume the app requires a description
sly cairn
maybe for macos store but no idea
i guess it makes electron builder a bit happier though
i'll just remove the "improve linux support" bit, dont think apple will be happy with me
vernal lintel
btw instead of this generally you would just combine it into the same step https://github.com/Vencord/Vesktop/commit/cfad2f9f833251c85f6e4d96b79d99231c295265
sly cairn
alr