#๐Ÿ‘พ-core-development

1 messages ยท Page 271 of 1

austere talon
#

you're generating this css now

.vc-margin-left8 {
    left: 8px;
}
#

when it should be margin-left

limber skiff
#

.vc-margin-left-8

#

not this?

austere talon
#

doesnt matter

#

the point is the left: 8px

limber skiff
#

oh wait

#

OHHH

#

it's the css value ๐Ÿ˜ญ

#

I thought it was the class name

#

oops

charred monolithBOT
austere talon
#

and now you broke description ๐Ÿ˜ญ

limber skiff
#

huh how

austere talon
#

description &&

#

it's optional

limber skiff
#

I'm blind...

charred monolithBOT
limber skiff
#

some things definitely look a bit more bold

#

in vencord settings

#

like these titles

#

unless my eye is lying to me

#

or these buttons

austere talon
#

this is too small

#

the Plugins

limber skiff
#

yeah true

austere talon
#

its cause I changed this component

#

the HeadingSecondary

#

it used to be bigger but I made it like Discord's FormTitle

charred monolithBOT
austere talon
#

we should rename BaseText -> Text once we remove Discord Text

austere talon
#

we need to recheck everything I already changed to the new Headings

#

cause it'll all be wrong size

austere talon
#

it just has to look good still

charred monolithBOT
austere talon
#

also we can still improve looks later

limber skiff
#

I removed the useless descriptions and made the ones that need full restart alert

#

do I push?

#

also this has too much empty space in the bottom

austere talon
#

cause otherwise the entire ui shifts

limber skiff
#

ahh

#

that's why it has the empty space

austere talon
limber skiff
austere talon
#

hmm

#

it's kinda weird that they're inconsistent

limber skiff
#

I mean I could also descriptions that add nothing new LOL

#

but having Requires a full restart as descriptions seemed weird

austere talon
#

discord does it too

#

yeah it's fine

#

just remove the useless descriptions

#

but it should still tell you that you have to restart

#

via toast or popup

limber skiff
#

ye it does

austere talon
#

okay

#

btw we should try to readd the thing that makes the entire part of the FormSwitch clickable

#

rn only the switch itself is clickable

#

I tried to do some cursed thing where the entire FormSwitch is wrapped in Clickable and uses a ref to the switch input element and calls ref.current.click()

#

but it doesnt work right

limber skiff
#

does the title still not seem small

austere talon
#

pull my changes

austere talon
limber skiff
#

ah

#

I had

#

but I restarted too quickly

#

troll

odd heath
#

wtf did pnpm smoke

limber skiff
#

okay now the theme tabs look too small

#

and the text here seems weird too

austere talon
#

how is it too small

limber skiff
#

do you not think

#

?

austere talon
#

it looks normal

#

compare to main branch

#

nothing changed i think

#

we should also remake Card and Clickable soon

#

but not this PR

#

we need to get this merged sooon

#

Card and Clickable aren't that high priority

#

Settings are fine without all the Cards

#

still usable

limber skiff
#

doesnt it look better with text a bit bigger

#

the warning

austere talon
#

looks same to me

#

look at the switch circle

#

it's cut off at the bottom

limber skiff
#

HHAHA

austere talon
#

we can just add overflow: visible to fix

#

or well, recopy the styles from discord

limber skiff
#

what exactly is Clickable

#

what's special about it

austere talon
#

it's just a button without any styles to it

#

blank button

limber skiff
#

with clickable cursor

austere talon
#

and onClick, onRightClick and keyboard listeners

limber skiff
#

ah yeah

austere talon
#

why is there an empty div lmao

#

i tried removing it but it breaks everything somehow

limber skiff
#

is this compat still needed

charred monolithBOT
austere talon
#

idk what causes the overflow

limber skiff
charred monolithBOT
austere talon
#

we have exactly the same css as Discord

austere talon
#

shouldnt be

limber skiff
#

they were both updated today

austere talon
#

yeah

#

just use newFilter

#

should work

charred monolithBOT
limber skiff
#

looks ready for me

#

vtest uikit

nimble pendantBOT
austere talon
#

need to check all Buttons first

nimble pendantBOT
nimble pendantBOT
austere talon
#

bruh

limber skiff
#

lmao

austere talon
#

bannerButton is canary only

#

i renamed it to Buttonnnnnn so it's easier to find

limber skiff
#

wtf

austere talon
#

good that i checked

limber skiff
#

I just merged dev into sadan branch

austere talon
limber skiff
#

๐Ÿ˜ญ

charred monolithBOT
limber skiff
charred monolithBOT
#

8eabb11 ClearURLs: use rules from ClearURLs browser ext... - thororen1234
479d01a fix FavGifSearch regression - Vendicated
9c0af5a Fix broken MessagePopoverAPI not working (#3661) - thororen1234
fbc2dbe FakeNitro: fix nitro themes not working for som... - sadan4
56d25b0 UserVoiceShow: Improve tooltip & add icons for ... - gabrielmar

austere talon
charred monolithBOT
limber skiff
#

not compatible with stable, but doesn't matter

#

It's only the sidebar profile anyways

#

vtest dev2

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
charred monolithBOT
limber skiff
#

vtest uikit

nimble pendantBOT
austere talon
#

this is wrong

#

need to fix Decor and BetterSessions looking bad

nimble pendantBOT
nimble pendantBOT
# limber skiff vtest uikit
Bad Patches

ReviewDB (had no effect):
ID: 983559
Match: ```
/children:[(?=[^[]+?.SIDEBAR}),\i.bot)/

Slow Patches

ShowHiddenChannels (took 7.1ms):
ID: 950969
Match: ```
/(?<=.id)))(?=&&(0,\i.\i)((\i)))/

Bad Webpack Finds
findByProps("bannerButton")
limber skiff
#

fiery didnt have to touch decor after getting it added to vencord lol

austere talon
#

isnt that wrong

limber skiff
#

I see...

austere talon
limber skiff
#

yeah

austere talon
limber skiff
#

ill fix

#

oh

#

push

austere talon
limber skiff
#

your deco is so funny ngl

charred monolithBOT
austere talon
#

LOL

#

yeah

#

i just put it on for testing

#

omg ahahaha

limber skiff
#

u removed flex from one place

austere talon
#

wait

limber skiff
#

and added to another ๐Ÿ˜ญ

austere talon
#

what did you push

limber skiff
#

merge dev into uikit

#

with latest patch fixes

austere talon
#

i put flex on the wrong one

limber skiff
#

oh

#

LOL

austere talon
#

well

#

I put it on CustomizationSection

#

not realising that title is inside there

#

it looked wrong before

#

it used wrong button

charred monolithBOT
limber skiff
#

the button is smaller than the others

#

by a bit

austere talon
#

it's the same

#

don't look at the Change Decoration above

#

I showed u earlier it's Discord using the old component

limber skiff
#

oh

#

yeah

#

gosh

#

that's so dumb

#

but this is still wrong

austere talon
#

enable the show mana component toggle

austere talon
#

still needs fixing

#

the old button had padding

#

the new one doesnt

#

it shouldnt have padding tbh

#

the plugin should just use flex

limber skiff
#

discord is insane for having padding

austere talon
#

Discord's own new text button also doesnt have padding

limber skiff
austere talon
#

you can turn this on

#

discord is insane

#

dont ask me why some glow green some pink

limber skiff
#

I forgot how to do ui

#

should I use em for gap

#

or pixels

austere talon
#

whatever tf this is

austere talon
#

I only use px when I'm copying Discord's ui

#

discord uses px for everything

#

are u gonna fix Decor

limber skiff
#

ye

#

fix uhh

#

the other one

#

I dont have it enabled

#

session viewer or what its called

austere talon
#

I'm fixing yeah

#

our flex component is so garbage

#

I wanna make it better

#

for Decor, the Cancel button should use Primary button

#

same as this

#

(or if you're using our new component, thats secondary)

limber skiff
#

did du just copy discord css

#

cuz why didnt text button base have centered flex

charred monolithBOT
austere talon
limber skiff
austere talon
#

yeah lol

limber skiff
#

the text was just floating at the top of the button lol

austere talon
#

love

#

should we change the title to Decor (Vencord Plugin)

#

so it's clearer

#

imo yes

austere talon
limber skiff
#

how to remove the background

#

with compat

#

in cancel

#

also god that's a lot of gap

austere talon
#

it should be 8px / 0.5em

austere talon
#

that looks right, just too much gap

#

this decor is so silly

limber skiff
#

the backgrond from cancel

#

it shouldnt have one right?

austere talon
#

it should

#

look at the normal change decoration modal

limber skiff
#

how long has this been like this SKULL_SKELETON

#

vc-decor-vc-decor-modal-footer

austere talon
#

lolol

#

it shouldnt even uses classes

#
cl("change-decoration-modal-footer", "modal-footer");
limber skiff
#

true

charred monolithBOT
limber skiff
#

hmm

turbid hatch
#

next to it

limber skiff
#

should I align center

#

even if all buttons have same height

turbid hatch
#

i think (vencord plugin) is too verbose and will look ugly, subtle plugin icon when you hover that says "this is a feature added by decor!" would be cooler and nicer ui/ux imo

limber skiff
#

@austere talon what have you done to my vencord

austere talon
#

ehehehe

#

is that the badge

#

fire

#

never run pnpm build --dev --anti-crash-test

limber skiff
#

It's the review db thing lol

austere talon
#

it puts ErrorBoundaries everywhere

limber skiff
#

we need to mark all our buttons as mana

#

๐Ÿ”ฅ

austere talon
#

LMAOO

#

i mean we could

#

we just have to add data-mana-component

#

lets do it

limber skiff
#

discord ui is so good

austere talon
#

LOL ikr

#

i saw that earlier and was like what

limber skiff
#

do you think vencord notifications setting title is needed here

#

or just the buttons

austere talon
limber skiff
#

(right now I removed)

austere talon
limber skiff
#

Vencord Notifications or just Notifications

#

I think Vencord is redundant

charred monolithBOT
austere talon
#

and yet people still get confused lmao

limber skiff
#

lol

#

ill keep it then

limber skiff
limber skiff
#

I dont really like it

austere talon
# limber skiff

change description to Settings for Notifications sent by Vencord. This does NOT include Discord notifications (messages, etc)

limber skiff
#

alr

#

looks good

charred monolithBOT
limber skiff
#

why arent my buttons highlighted

charred monolithBOT
limber skiff
#

oh nvm

#

they still have the button

charred monolithBOT
odd heath
#

ts is never getting merged

charred monolithBOT
limber skiff
#

@austere talon what's left

austere talon
limber skiff
#

I did

austere talon
#

we should disable the click for that

limber skiff
#

I had removed the css

austere talon
#

the tooltip is still useful

limber skiff
#

but the css is still needed

austere talon
#

oh

#

we should also disable the onclick

#

when you click it alos bug repoprts

limber skiff
#

69 u said

#

now its 81

austere talon
#

trolley

#

let me pull and test

#

LOL jumpscare

#

im listening to music rn and I have watcher running

#

when I pulled, it rebuilt and reloaded css and for a fraction of a second that meant it didnt have vencord css

#

so the spotifycontrols album cover covered the entire app

#

the pic here

limber skiff
#

LOL

#

I will noop the button real quick

austere talon
#

actually not entire app buit like this

#

the default html image styles are so insane

#

it just becomes as big as it wants

#

AHAHAH

#

even the permviewer is mana highlighted now

charred monolithBOT
limber skiff
#

vtest uikit

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
# limber skiff vtest uikit
Bad Patches

ReviewDB (had no effect):
ID: 983559
Match: ```
/children:[(?=[^[]+?.SIDEBAR}),\i.bot)/

Slow Patches

PinDMs (took 5.2ms):
ID: 831218
Match: ```
/(?<=channels:\i,)privateChannelIds:(\i)(?=,listRef:)/

Bad Webpack Finds
findByProps("bannerButton")
austere talon
#

need to fix that bannerButton shit

limber skiff
#

but they are gonna end up bumping stable at some point

austere talon
#

still gotta fix this

#

maybe make these buttons too

#

what do you think

#

lemme show you

limber skiff
#

yes thats good

#

was it that easy

#

neat components

austere talon
#

look

charred monolithBOT
austere talon
#

it's just variant="link" and variant="dangerSecondary"

limber skiff
#

dang nice

austere talon
#

the link variant isn't a button Discord uses actually

#

it's component v2 button

#

vp Logger

nimble pendantBOT
austere talon
#

lmao

limber skiff
#

lmaoo

austere talon
#

i like it tho

#

looks better than just blue text

limber skiff
#

yeah its good

austere talon
#

then I need to check Vesktop

#

then we can merge

limber skiff
#

I thought u always used vesktop

austere talon
#

even old version is kinda ugly

#

maybe I will change button kind

#

also idk why Discord thinks im in Mainz

#

im hours away

limber skiff
#

I cant even click things because of error boundary

#

can we make clicks go through

austere talon
#

wait where

limber skiff
#

cant open my full profile LOL

austere talon
#

AHAHAHHAA

#

(it only shows in dev build btw)

#

and yeah it's not supposed to show for that element

#

is this good

charred monolithBOT
austere talon
#

should be fully good to go now

limber skiff
austere talon
#

let me test one more thing

#

i added new build var remember

#

IS_ANTI_CRASH_TEST

#

okay we good

#

is it normal that there are no settings on web lol

limber skiff
#

the margin there looks very bad

#

why does it look like that for you

austere talon
#

the margins are off yeah

#

the css priority is wrong

#

good that i tested web

limber skiff
#

is it an issue at base text?

austere talon
#

the css-core should be above everything else

limber skiff
#

what about moving className before base

#

does that work

austere talon
#

no it wont change anything lmao

limber skiff
#

ah okay

austere talon
#

last css file wins

limber skiff
#

good catch

austere talon
#

the problem is that we have a race condition

limber skiff
charred monolithBOT
austere talon
#

I can't for the life of me spell specificity

limber skiff
#

im gonna hit you with the approve

charred monolithBOT
austere talon
#

nooo now it's above ๐Ÿ˜ญ

charred monolithBOT
austere talon
#

now it's perfect

#

vtest uikit

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
limber skiff
#

before releasing web

#

wait a little

#

users on desktop will likely catch any issues fast

austere talon
#

i wanna sleep now

#

are u gonna release in a few hours then

limber skiff
#

yeah sure

#

I'm gonna sleep too but I can put an alarm LOL

charred monolithBOT
limber skiff
#

commit version bump and push to main

#

dont push tag yet

charred monolithBOT
austere talon
#

oh i noticed an issue with our Switch

#

it doesn't have a highlight for when it's tab focused

#

I will add

#

not rn

#

tmrw

#

talking about this ring

#

i see what u mean now

austere talon
#

doubt they will approve within 8h

#

even if they do it's not really worse than rn

#

im gonna push tag

limber skiff
#

alr

charred monolithBOT
#
[Vendicated/Vencord] New tag created: v1.13.3
austere talon
#

it's saturday anyway

#

if we delay any further it'll take til monday or even later

limber skiff
#

what's this bump

austere talon
odd heath
#

how is canary stable and stable broken ๐Ÿ˜ญ

#

average "lets pray with prod and leave it to oncall"

austere talon
#

wdym

#

we decided to push the canary fix already

odd heath
#

i got confused and thought discord broke something oops

elder plinth
#

they pushed the select changes hours early to the development client and had me going crazy on why it was only affecting me

elder plinth
odd heath
elder plinth
#

effort:

#

discord overrides it on every update

#

I think. I did it before

#

gave it my nitro sakura icon

odd heath
#

Just hop on vesktopp

elder plinth
#

no

odd heath
#

Why

charred monolithBOT
charred monolithBOT
charred monolithBOT
fossil inlet
fossil inlet
limber skiff
#

vext

nimble pendantBOT
charred monolithBOT
turbid hatch
#

i merged that horribly

charred monolithBOT
turbid hatch
#

@austere talon lemme merge yop

#

actually no cuz i need an answer to that question

austere talon
#

we should add support for the party thing on vencord customrpc

turbid hatch
#

should be easy enough

charred monolithBOT
austere talon
#

i just realised plugin settings dont use our FormSwitch

#

goofy

austere talon
limber skiff
#

is that really so bad?

#

it uses SettingsSection which all other options also use

#

seems fine for that case

austere talon
#

I'll just make it allow you to customise the tag

#

with label, the entire thing controls the Switch

#

I did that and added focus ring

charred monolithBOT
limber skiff
#

vext

nimble pendantBOT
austere talon
#

tbh we need to come up with a better solution to the ErrorBoundaries

#

tired of this xD

fossil inlet
turbid hatch
#

it'd be great if you could get like the context that the component is used in

#

like if it's too big, it collapses into a โš ๏ธ

austere talon
#

so we can easily spot them

fossil inlet
#

If it's only in dev who cares

austere talon
#

I care

dusk blaze
#

add option

fossil inlet
#

GUHHH I LOVE PAYING FOR NITRO AND STILL GETTING ADS

gritty iris
#

well thats a choice discord

austere talon
#

I โค๏ธ web design

gritty iris
#

I cant even disable game overlays or anything lol

olive aurora
#

make noop error boundary become notification

#

i wonder though if you could like detect the amount of space available for an element

austere talon
olive aurora
#

without rendering it

austere talon
olive aurora
fossil inlet
#

Tbh I like the error boundary

#

If it's annoying me I just fix the issue

olive aurora
#

if you render invisible element it will still shift layout
but i was thinking measuring it + falling back to popup if there's no space to make it readable

fossil inlet
#

I think we should just not use an error boundary and crash discord instead

Can't be an annoying UI element if there's no UI

olive aurora
#

that'd prob be the case for most noops

#

anyway

limber skiff
#

@austere talon FormSwitch behaves differently than plugin settings swich

austere talon
#

thats why I asked why it uses a different component :P

limber skiff
#

didnt we complain it wasnt centered

austere talon
#

optimally it should be uniform

austere talon
limber skiff
#

so which one should be the correct

austere talon
#

both are fine to me

limber skiff
#

it's fine being two different components because of SettingsSection

#

but they should look the same haha

austere talon
#

honestly this looks bad now

#

cause of the inconsistent padding

#

i will fix

limber skiff
#

oh I didnt even notice

#

you are right the padding looks weird

gritty iris
#

will put into practice

inland fable
austere talon
#

it was that way

charred monolithBOT
charred monolithBOT
fossil inlet
desert cosmos
#

soon (in 5 years)

austere talon
#

i wanna remake customrpc settings with a custom component

#

rn it's so ugly

charred monolithBOT
#
5c0

Fix(stickerPaste): Resolve conflict with fakeNitro

This resolves a bug where having both stickerPaste and fakeNitro enabled would cause an infinite loop when sending a sticker.

The Problem:

The stickerPaste plugin works by intercepting the sticker send event, preventing the sticker from being sent, and instead pasting a link into the chatbox. However, it did not clear the sticker data from the message composer.

When a user would then press Enter to send the message, ...

austere talon
#

description smells like ai

#

@fossil inlet check if this is right etc

#

very cursed code

#

try { return } finally {}

#

does that work lmao

#

defer in js

#

no way

odd heath
#

wtf

bright island
#

yeah try finallys just work

odd heath
#

thats so cursed

bright island
#

pretty sure try-finallys work in every lang

austere talon
#

nix propaganda

#

horror

fossil inlet
austere talon
#

love

#

just as i thought

fossil inlet
#

@austere talon is stickerPaste meant to let you send more than one sticker in a message

austere talon
#

yea

#

should

fossil inlet
#

doesnt work for me

austere talon
#

fix

fossil inlet
#

guh

charred monolithBOT
odd heath
#

???? Holy shit

charred monolithBOT
fossil inlet
#

@austere talon did you delete

#

did this guy bot github followers or smth

bright island
#

im sorry, botting github followers?

fossil inlet
#

look at it

bright island
#

waow

#

yeah that's deffo botted, or my dude works for some kind of international company that has a very large amount of private repos (but based on what else i see i heavily doubt that)

fossil inlet
#

i dont think an internal company would explain it either tbh

bright island
charred monolithBOT
fossil inlet
#

i did a terrible job of describing the issue in the video

#

you couldn't watch that and reproduce that

#

the thing is that the sticker is no longer accessible because the server fell below the boosting tier

#

but fake nitro bypasses that

#

and that's what cuases the bug (afaik)

desert cosmos
#

stop shattering my love to javascript

charred monolithBOT
fossil inlet
# charred monolith

I'm going to be honest, I don't know if the reason to cause the bug changed over time or if I just somehow didn't notice it back then

austere talon
#

I remade CustomRPC settings so it's less horrible

austere talon
charred monolithBOT
gritty iris
#

maybe its just .gif?

#

kinda doubt it tho

elder plinth
fossil inlet
charred monolithBOT
limber skiff
#

vext

nimble pendantBOT
dusk blaze
#

asking google to revert it brb

#

@grizzled halo edit known issues post

grizzled halo
#

Kk

limber skiff
#

@austere talon are u sure form switch should have a margin-bottom

#

imo the ui should handle that with gap

austere talon
#

I just remade discord's old switch

#

if you don't want margin you can just set hideBorder

#

then it also won't put the divider underneath

#

for the settings ui it should just handle gap and dividers itself

#

I'm gonna do that like I said

limber skiff
#

im doing it rn

limber skiff
#

I kinda fixed it

#

LOL

#

the small switch ๐Ÿ˜ญ

#

oopsies

limber skiff
#

does it look better like this

#

or more gap

charred monolithBOT
#

โ€ฆnon-plugin users

Problem

Currently, when Vencord users send fake nitro emojis, they appear as proper emojis for other Vencord users but show as plain text links like [emoji name](https://media.discordapp.net/emojis/12345.png) for users without the plugin. This makes the fake nitro feature less useful since only plugin users can see the emojis properly.

Solution

Modified the FakeNitro plugin to send plain emoji URLs instead of markdown hyperlinks. Discord natively embeds these...

prime dew
#

what are they on

austere talon
charred monolithBOT
#

๐Ÿšซ Pull Request Rejected โ€” No Actual Issue Fixed ๐Ÿšซ

Hey there! ๐Ÿ‘‹ Appreciate the effort, but this PR isnโ€™t needed ๐Ÿ˜…

The behavior described here โ€” fake nitro emojis showing correctly for plugin users and as text for others โ€” is already the intended and current functionality โœ… What this PR calls a โ€œproblemโ€ isnโ€™t actually a bug or issue at all ๐Ÿ’ญ

โ€” The feature already works as designed: plugin users see proper emojis, non-plugin users see text links.
โ€” Changing it to send raw URLs d...

charred monolithBOT
austere talon
#

might not be ai tbh

#

but still bad

charred monolithBOT
charred monolithBOT
scenic brook
#

It doesn't even use definePlugin

austere talon
#

doesn't matter tbf

#

that function does nothing

#

it's only for types

fossil inlet
charred monolithBOT
pine topaz
#

Korbo tip: if an issue or PR has "The Problem:" and "The Solution:" in it, it's almost certainly AI

austere talon
fossil inlet
#

not sure about that

austere talon
#

the only way ai would be able to make a plugin is by looking at the existing files to see how plugins are structured

thus it would know to use definePlugin

fossil inlet
#

the first thing i would do if i was making a vencord plugin for the first time is to look at other plugins

austere talon
#

every ai slop pr thus far has had the basic template down right (except the ones that were blatantly hallucinating)

charred monolithBOT
gritty iris
#

I learned how to hit a submit button SHOCKEDDD

#

I honestly think (savedStatus ?? status) could be a const but didnt really think it was needed at the same time

charred monolithBOT
odd heath
#

guys tf is this ๐Ÿ˜ญ

austere talon
odd heath
#

HOW

#

i was on dev after you pushed the select fix

#

but youre right

hollow musk
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
brazen bone
#

Who tf cares about github profiles

dusk blaze
limber skiff
#

why pin

austere talon
#

it's nino he pins everything

limber skiff
dusk blaze
#

you wouldnโ€™t get it

gritty iris
charred monolithBOT
#

cc01bb7 Replace Forms with our own independent componen... - Vendicated
c1556f0 bump to v1.13.3 - Vendicated
b881b60 FormSwitch: make entire Switch clickable & add ... - Vendicated
dfbffd1 VcNarrator: make nickname fallback to displayNa... - TomW1605
dcefa49 CustomRPC: add party option & overhaul settings ui - Vendicated

limber skiff
#

@austere talon did u see they bumped stable and reverted

#

lol

#

and then bumped again

austere talon
#

fire

charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
limber skiff
#

I could make it compatible with stable but that would mean a bigger wildcard which I'm not sure is a good idea

nimble pendantBOT
# limber skiff vtest dev2
Slow Patches

ShowHiddenChannels (took 6.4ms):
ID: 823748
Match: ```
/"renderMobileToolbar",()=>{.+?case \i.\i.GUILD_DIRECTORY:(?<=let{channel:(\i).+?)/

Bad Webpack Finds
extractAndLoadChunks(["initialSelectedDecoration:", "/initialSelectedDecoration:\i,.{0,150}Promise\.all/"], /(?:(?:Promise\.all\(\[)?(\i\.e\("?[^)]+?"?\)[^\]]*?)(?:\]\))?|Promise\.resolve\(\))\.then\(\i\.bind\(\i,"?([^)]+?)"?\)\)/)
nimble pendantBOT
limber skiff
#

actually it probably is

charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
charred monolithBOT
charred monolithBOT
alpine ridge
austere talon
#

impressive

elder plinth
#

you should merge

still maple
fossil inlet
turbid hatch
# charred monolith

i like this pr because it actually weakens some of the guarantees we have set up by switching ts-expect-error to ts-ignore

charred monolithBOT
austere talon
#

discord pushed crazy shit to canary @limber skiff

#

oh

#

it's the i18n update

#

we just need to update i18n function

charred monolithBOT
austere talon
#

vtest dev3

nimble pendantBOT
austere talon
#

it's not gonna be able to send stable

#

we're gonna have to push chrome update yet again

nimble pendantBOT
austere talon
#

how

#

dont we specify some raw - apparently we don't

#

should we add temporary compat that will convert any string using intl: to regex with both old and new hash

austere talon
#

vtest dev3 canary

nimble pendantBOT
nimble pendantBOT
charred monolithBOT
austere talon
#

vtest dev3

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
austere talon
#

nice

#

vtest dev stable

nimble pendantBOT
austere talon
nimble pendantBOT
austere talon
#

well this is an issue

#

cause it now returns regex for compat

limber skiff
austere talon
austere talon
limber skiff
#

it won't work for finds

austere talon
#

it will

#

it just makes them regex

limber skiff
austere talon
austere talon
#

cause it does .includes(regex)

limber skiff
#

you could do some trick where strings are returned with monkey patched toValue (i think that's what it uses)

#

and regex the source or whatever it uses

#

then check at runtime

#

if it's canary or stable

austere talon
#

ehhhhhhh

limber skiff
#

just temporarily

austere talon
#

i think this current way is better

#

it works fine

limber skiff
#

it seems easier than the current solution

#

and faster

charred monolithBOT
austere talon
#

vtest dev3

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
limber skiff
#

so horror๐Ÿ˜ญ

austere talon
#

lets just push like this

#

it's only temporary anyway

limber skiff
#

as long as it's not dogshit slow

austere talon
#

well it would say if it's slow

#

i think

#

idk

limber skiff
#

not for finds

#

so many regex finds seems extremely bad

#

how about we just wait for them to push to stable

#

more members joining to ask how to fix teef

odd heath
limber skiff
#

does it break settings patch

#

@austere talon

odd heath
#

Chrome users gonna be asking about the issue until Monday or longer wires

austere talon
#

actually yes

limber skiff
#

well that sucks

austere talon
#

well

#

it will put them at the very bottom

odd heath
austere talon
#

its just context menu patch

odd heath
#

Oh

austere talon
limber skiff
#

if settings still work we could just let people update after everything breaks

austere talon
#

oh because of this

#

actually no

#

im goated

austere talon
austere talon
#

i say we just push now

#

it's fast

#

try it yourself

limber skiff
#

I cant

#

I'm not home

austere talon
#

it's fine bro

#

regex is 4x slower but still under 1ms

#

some of the speed might even be the canonicaliz

limber skiff
#

it will test the regex to find the right module

#

so like thousands of times

austere talon
#

it's fine

#

we will remove in a week anyway

#

none of these regexes are gonna be complex

#

they're all super linear regex with no groups, lookarounds, wildcards

limber skiff
#

alr

charred monolithBOT
austere talon
#

vtest dev3

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
charred monolithBOT
austere talon
#

i will bump in a few hours

#

actually i can do that rn

#

push commit at least

charred monolithBOT
austere talon
#

vtest dev

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
charred monolithBOT
austere talon
#

I'll push tag later

#

vtest dev2 stable

nimble pendantBOT
austere talon
#

did they already push

nimble pendantBOT
austere talon
#

nop

#

ah yeah

charred monolithBOT
austere talon
#

NoBlockedMessages will be broken for now but ehh

charred monolithBOT
austere talon
#

vtest

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
charred monolithBOT
#
[Vendicated/Vencord] New tag created: v1.13.4
limber skiff
#

might be useful

austere talon
#

yeah

charred monolithBOT
odd heath
odd heath
#

Oh yeah it does

limber skiff
#

god damn discord

elder plinth
#

why is yours so spaced out

limber skiff
#

it's the same

#

yours just has more space

#

I shrank my bar

elder plinth
#

oh I guess the shadow they add for nameplates to make the buttons visible made the illusion of being closer together

#

hm when I shrink my channel bar the buttons move left, cutting off my name, not falling off the right

hollow musk
junior olive
#

i do appreciate yall keeping it working though

#

i hope it isn't too much of a burden

#

i'm really hoping i can find the motivation to do server v2 so it's not backed by such shitty code

austere talon
#

vext

nimble pendantBOT
austere talon
#

damn

charred monolithBOT
austere talon
#

vtest dev3

nimble pendantBOT
austere talon
#

lol they reverted canary i think

#

it uses old one again

#

vtest dev2

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
austere talon
#

lol they did

limber skiff
#

bruh

limber skiff
charred monolithBOT
limber skiff
#

I forgot about this ๐Ÿ˜ญ

charred monolithBOT
austere talon
#

not this guy ๐Ÿ˜ญ

limber skiff
#

lol what

austere talon
#

BetterDiscord plugin vibecoder

austere talon
#

vtest dev3

nimble pendantBOT
dusk blaze
elder plinth
# charred monolith

getIntlMessageFromHash can return a list of strings so this || fails there

austere talon
#

too bad

elder plinth
#

:(

austere talon
#

its only temporary anyway

elder plinth
#

well ill just be making my own wrapper for them then for questify

odd heath
#

Bloat

charred monolithBOT
limber skiff
#

vtest

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
limber skiff
#

lol I didnt call the function

charred monolithBOT
odd heath
#

someone should prolly fix this

#

actually lemme look

charred monolithBOT
#

Developer Education is simply just dead for normal users and including the logout button would still cause a duplicate "Other Settings" section to appear, simplest solution I see is to just remove both because the logout button isnt really necessary in the context menu. Additionally even if you would keep it in, it wouldn't be clickable anyway, as discord prioritizes the other entry with the Changelog tab.
Another, probably more logical option would be to completely remove the "Other Setting...

dusk blaze
odd heath
#

oh shit

#

i didnt think of that

dusk blaze
#

get intl string or something

#

and use that

odd heath
#

trve

#

tyty

odd heath