this will be merged in the coming seconds
#👾-core-development
dusk blaze
austere talon
this will be merged in the coming seconds
negative
dusk blaze
negative
this is the only thing holding me back from leaving betterdiscord…
it’s ok tho i’m just using some random Music Presence app off github
ykyk
elder plinth
love how when previewing sometimes the new xyz is typing shadow gets out of sync with the rest of the theme
hollow musk
love how when previewing sometimes the new xyz is typing shadow gets out of sync...
just remove it, no one needs gradients 
.chatGradientBase__36d07 {
display: none !important;
}
brazen bone
love how when previewing sometimes the new xyz is typing shadow gets out of sync...
It gets out of sync with discord itself, too
Afaict it only appears when you scroll manually, not when you click a link or notification
charred monolithBOT
charred monolithBOT
dusk blaze
what is this idiot on
scenic brook
GitHub
dusk blaze
random thought but why aren’t we using the iTunes API for getting the Apple music album art for rpc
seems more reliable ykyk
and you don’t need to auth or anything
dusk blaze
random thought but why aren’t we using the iTunes API for getting the Apple musi...
why husk @desert cosmos
you will die
gritty iris
I just had a question about the cloud so if I change root redirect to lets say vencord.dev does that breach the license even tho nothing about the code was modified? yes im losing it
charred monolithBOT
gritty iris
@dusk blaze are you actually using BD 😭
gritty iris
Shame on you for not manually typing it
gritty iris
https://discord.com/channels/1015060230222131221/1015063227299811479/12341735127...
What the hell
dusk blaze
true...
scenic brook
Why are you likely spammer
elder plinth
bro got compromised
gritty iris
Why are you likely spammer
who?
scenic brook
nin0
elder plinth
oh bro is no longer likely spammer
gritty iris
hes not?
scenic brook
It's gone now
elder plinth
he answered me in my ticket that he spam reacted to a message in general or smthn
fossil inlet
@vagrant topaz have you tried reconnecting with this button after it says unable to ensure client is up to date
dusk blaze
satan
limber skiff
olive aurora
I just had a question about the cloud so if I change root redirect to lets say v...
yes vecause vencord.dev does not point to vencloud's source code
austere talon
yes vecause vencord.dev does not point to vencloud's source code
erm it does
the api root redirects you to https://vencord.dev/cloud
which links to source code and privacy policy
olive aurora
oh im kinda blind
why change this anyway
assuming they actually mean a website different to vencord.dev
in that case no you can't unless that website links to the source code
fossil inlet
Alright, can you send the git hash of your user plugin, version of the companion from the vscode marketplace
fossil inlet
you're just echoing the servers version back to it 😭
@vagrant topaz run /vencord-plugins rq
how?? it's a required plugin in vencord
open console and read the error
yes
read the error
yeah
i'll make it a notice
oh
forgot to change that
i need to add heuristics to detect the vencord workspace
open the vencord workspace first and you should be fine
bad phrasing
each workspace has it's own extension host
you probably didn't trigger any activation events
grave mangoBOT
https://github.com/sadan4/VencordCompanion/blob/main/package.json#L153-L157
package.json: Lines 153-157
"activationEvents": [
"onLanguage:typescript",
"onLanguage:javascript",
"onLanguage:typescriptreact"
],
yop
bleak blaze
https://github.com/sadan4/VencordCompanion/blob/main/package.json#L153-L157
hey sorry to bother you but does react devtools not load for you also or is that just an issue with me
austere talon
press ctrl r
fossil inlet
hey sorry to bother you but does react devtools not load for you also or is that...
you to have to reload the window (C-R) once after devtools is opened
it's an electron bug
bleak blaze
press ctrl r
thanks and thank you other guy
bleak blaze
it's an electron bug
ok ok i'll do that and see whether it resolves my issue
limpid tusk
I think ctrl r locked them out of their account
they never confirmed whether it worked
gg
gaunt bluff
I think ctrl r locked them out of their account
charred monolithBOT
austere talon
limber skiff
austere talon
guhh sadan will never resolve feedback
austere talon
@limber skiff why not just do this for UserVoiceShow?
instead of manually rendering the guild and channel name
just gotta fix overflow
also this is broken:
const voiceStates = useStateFromStores([VoiceStateStore], () => VoiceStateStore.getVoiceStatesForChannel(channel.id));
it's always the same reference so it's not stateful
well discord also does it lol
fixed the alignment
should i push this @limber skiff
this is old
austere talon
left an unused webpack find in award
limber skiff
this is old
damn did the old really overflow lol
how does the new handle group chats and dms?
does it work well
grizzled halo
had 2 people mention this, both are on latest version, im unable to reproduce so they are probably just going insane
surreal fiber
my pindms categories have also gone, idk if it happened now or some time before
gritty iris
my categories only disappeared once and it was like 4-5 months back
bleak blaze
for react-devtools is there any plans to address issue with it not loading without pressing ctrl+r?
i have to do that almost every time and i'm wondering whether you guys have ever looked into resolving that
austere talon
no because it's an electron issue
elder plinth
Vectron when
bleak blaze
thanks for clarifying that
odd heath
Vectron when
They exist
charred monolithBOT
gritty iris
it was matching xxs which I assume is the image above it was matching
compactInfo was the classname for that one but the one in the pr matches info which fixes it 
dusk blaze
@austere talon private issue tracker when
dusk blaze
when will we push extension updates it’s so falling behind
charred monolithBOT
charred monolithBOT
limber skiff
one week without any broken patches
elder plinth
dont worry on monday every single one will break
odd heath
dont worry on monday every single one will break
Bundler change i pray for it
elder plinth
what if they just shipped it unminified. wouldnt that be neat
limber skiff
isn't the extension outdated
ill bump it this weekend
merge some approved prs, fix the fake nitro issue and bump extension
dusk blaze
okay good
limber skiff
what if they just shipped it unminified. wouldnt that be neat
they've done that in the past
well, kinda
they did even worse
accidentally leaked the source maps which leak the typescript files
basically the source code
odd heath
merge some approved prs, fix the fake nitro issue and bump extension
Approve array option type
dusk blaze
true
austere talon
tbh kinda pointless to use checksums, https already ensures this unless the download gets interrupted in which case any sane browser wouldn't even output a file
austere talon
i forgot about this lmao
people really were like "omg it opens a terminal is this malware!!"
gritty iris
so I have learned clearurls doesnt work on edit is that intended? (atleast it didnt for me)
odd heath
that would mean the entire onBeforeMessageEdit is broken no 
cba to look into this
@fossil inlet salad fix
dusk blaze
satan too busy making his website
hollow musk
thats a bug with textreplace as well
kindred tree
I thought it was a feature lol
like whenever I get a textreplace I don’t want I just edit the message
hollow musk
it would be nice if it can be toggled
odd heath
like whenever I get a textreplace I don’t want I just edit the message
I thimk yoir textreplace rules might be awful
kindred tree
I thimk yoir textreplace rules might be awful
I recently added youtube->koutube but sometimes I just want to keep it youtube anyway, maybe I'll start doing it manually 
usually I don't have issues tho
odd heath
😭
Just add another character
Like a # before the link anything that's one button before pasting it in so it only gets replaced if you want (or vice versa, make it so if there's no # it gets replaced, otherwise it removes she # and keeps the original 
)
I'd be too annoyed to always change the link manually again
kindred tree
oh could do yeah
austere talon
why does this happen for some people #🏥-vencord-support-🏥 message
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
fast tinsel
wanted to ask for thoughts before bothering to open the PR, is this acceptable?
the idea is that third party clients that aren't necessarily supported can declare themselves incase they do something that breaks vencord somehow
I also saw the legcord check for the arrpc plugin and was thinking adding this there too, or removing the legcord specific check and i send a PR to legcord to implement this new 'standard'
something like adding a features array
gritty iris
💀
charred monolithBOT
austere talon
jujst fix ur clock bro
elder plinth
bundle nettime into vencord easy solution
prime dew
Can be done with css
hexed star
Can be done with css
charred monolithBOT
dusk blaze
merge
austere talon
bruh
dusk blaze
put this in an util or something
dusk blaze
historical moment
austere talon
why did you make it a set anyway? @gritty iris
elder plinth
are sets bad or smthn
austere talon
no theyre good
austere talon
vtest dev
charred monolithBOT
austere talon
i swear discord is gonna break everything as soon as i tag
odd heath
i swear discord is gonna break everything as soon as i tag
Good at least I'd have something to do then
Also merge uuuh noblockedmessages pr
limber skiff
why did you make it a set anyway? <@848339671629299742>
the patches handle it as a set
it matches the behavior of how the data was retrieved from the store too
since the method we originally used returned a set
gritty iris
why did you make it a set anyway? <@848339671629299742>
Probably just what I saw at the time I had like 5 files open and I forget arrays existed for a moment
left sequoia
jesus christ, what is discord doing fucking spamming 200kb/s IDB writes in the browser
like NON-STOP
full idle, and its constantly writing to IDB
fossil inlet
love the random property access to React.Component in discord's code
fossil inlet
love the random property access to `React.Component` in discord's code
i lied
not discord's code (react router v5)
but discord's bundler is insane here
austere talon
normal
gritty iris
Probably just what I saw at the time I had like 5 files open and I forget arrays...
Ngl I forgot I made it a set again so it was probably because the others were sets
dusk blaze
satan
odd heath
???
charred monolithBOT
austere talon
guh typescript moment
austere talon
really funny bug
gritty iris
I see cleanup on issues happened
hollow musk
would be nice if it does that, the notification looks neat
fossil inlet
randomly noticed this but tooltip types are incorrect
discord will pass an empty object as props if text is nullish
charred monolithBOT
charred monolithBOT
austere talon
BetterSettings broke but its error safety works and doesnt crash
fossil inlet
BetterSettings broke but its error safety works and doesnt crash
oh
@quick isle your theme is broken
quick isle
fossil inlet
make Satan fix
i did
fossil inlet
@austere talon how would you detect no connection then? error only fires when the socket closes due to an error
limber skiff
horror
that function needs a rewrite
this is too messy
how was it even working
if we never adjusted that
what the heck
I wanna review both these PRS, dont merge them before I do it
https://github.com/Vendicated/Vencord/pull/3681
https://github.com/Vendicated/Vencord/pull/3682
ill do it tomorrow as soon as possible because I'm very tired today
fossil inlet
that function needs a rewrite
yeah, i don't know enough about how discord's settings/protobuf works to do it myself
austere talon
wait it's not broken
we removed it ages ago lmao
makes sense
actually nvm
okay dont mind me i derped
😛
dusk blaze
😛😛😛😛😛
austere talon
oh i commented closing but forgot to actually close
charred monolithBOT
fossil inlet
hybrid jetty
incredible description
dusk blaze
<:blobcatcozy:1026533070955872337>
satan
austere talon
austere talon
@median rapids do u know by chance if this is an intentional change
it's not hard to fix but I'm not gonna bother if this is just a discord screwup
fossil inlet
seems like fetching cdn links is cors violation now
Does discord use something other than cdn links then or wouldn't this break things?
limber skiff
oh
charred monolithBOT
desert cosmos
magic numbers
median rapids
<@852892297661906993> do u know by chance if this is an intentional change
no clue
charred monolithBOT
dusk blaze
yeah we know
charred monolithBOT
austere talon
NoReplyMention is broken guh
recently I merged role whitelist/blacklist feature
to test it i added janny role to my list and forgot about it
today I started wondering why it always didn't ping mods when I replied to them
dusk blaze
veeeediot
elder plinth
does the stock feature not just pick between the "Light" and "Dark" themes?
the plugin seems to let you pick an alternative to light and dark for each.
elder plinth
looking at it I cant really understand how it works lol
huh it only applies on startup? what if your system theme changes with the app open
I assumed thats what it was for originally
like those apps that change your theme at a time of day
charred monolithBOT
Content
When the folder sidebar is open, resizing the channel sidebar will be offset by the width of the folder sidebar. See below video.
Request Agreement
- [x] I have read the requirements for opening an issue above
dusk blaze
you didn’t read the requirements for opening an issue above @fossil inlet
elder plinth
bro uploaded the worst encoded gif in the world as a preview
and had the audacity to call it a video
gritty iris
is that what 144p looks like on a gif?
thought I was on youtube for a moment that was so badly encoded
fossil inlet
is that what 144p looks like on a gif?
idk, i just use peek
charred monolithBOT
odd heath
me when i do useless things cuz im bored
elder plinth
cant even ping them cause they aint here
charred monolithBOT
dusk blaze
translation v4 in a week
turbid hatch
yop
charred monolithBOT
turbid hatch
@austere talon :3
turbid hatch
v3 is just v2 but without all the merge conflicts
imo if we were to actually commit to it i think we can do like
a gradual translationing
so this would get merged initially, and then over time we just update dev with translations
primarily for plugins
dusk blaze
translationing
turbid hatch
might not even use crowdin atp
they dont support zero plurality
so now im looking at weblate and pontoon
tbh pontoon seems quite nice
it was what i was originally going to do as well when we were trying out project fluent but it supports just regular json too and it seems to support plurals
and its meant to focus on a singular project or just a few projects, so it makes the most sense for us
charred monolithBOT
swift fjord
:/
dusk blaze
Opinionated Queer License @austere talon
limber skiff
@fossil inlet can u double check it works for me ^
austere talon
Opinionated Queer License <@343383572805058560>
ATROCIOUS
charred monolithBOT
austere talon
slint is sooooooooo good
austere talon
is that a new issue or has it always been like that
always
well according to support users
limber skiff
It's not trivial to fix
the entire way it restore is by using the user settings proto cache
which is reset when you switch accounts
dusk blaze
yop
limber skiff
pretty easy to abuse custom settings for it
austere talon
just do like this
const fakeNitroSettings = definePluginSettings({}).withPrivateSettings<{
syncedPerAccountState?: Record<string, {
nitroTheme?: number;
}>;
}>();
function getSyncedPerAccountState() {
const s = fakeNitroSettings.store;
s.syncedPerAccountState ??= {};
syncedPerAccountState[AuthenticationStore.getId()] ??= {}; // idk if the value this returns is proxy or not. if it's proxy, you can return it directly
return s.syncedPerAccountState[AuthenticationStore.getId()];;
}
// get
getSyncedPerAccountState().nitroTheme;
// set
getSyncedPerAccountState().nitroTheme = 13;
yeah it's not proxy like i thought
fossil inlet
<@521819891141967883> can u double check it works for me ^
@dusk blaze i love not getting pings because you ban me, then i re-join and the server gets auto muted
evil
carmine wave
<@521819891141967883> can u double check it works for me ^
1939322a92974232628b5ae0173bf8f2b579db7f broke proto updates on non nitro locked theme changes that should send a proto update
eg dark -> onyx doesn't send a proto update
any custom theme -> any free theme doesnt send a proto update
dusk blaze
<@886685857560539176> i love not getting pings because you ban me, then i re-joi...
don't you check your inbox
Stupid Sadan
i have this guild muted and i still answer to pings
carmine wave
so when i say ping, i mean the actual sound
dusk blaze
WHOOOO CARESSSSSS
just be chronically online and constantly check discord yk
but you wouldn't get it
limber skiff
check now @fossil inlet
fossil inlet
alr
fossil inlet
check now <@521819891141967883>
works for me
const hasNitroCustomization = Object.values(clientThemeSettings ?? {}).some(v => v != null);
// couldn't this be
const hasNitroCustomization = clientThemeSettings && Object.values(clientThemeSettings).some(v => v != null);
nevermind, empty object is truthy
charred monolithBOT
limber skiff
vtest
austere talon
vtest dev
charred monolithBOT
fossil inlet
we can merge to main
Will 3682 be in this one?
limber skiff
I still gotta do the persisting of the themes
carmine wave
oh yeah
fossil inlet
can anyone else repro this, doesn't happen if i disable fake nitro
elder plinth
it's a collision between FakeNitro and StickerPaste
only happens with both enabled for me
austere talon
wow it's just like me
austere talon
lmao yeah
so funny
await track("EVENT");
toggleVoiceDebugLogging();
was just pending forever
charred monolithBOT
gritty iris
ngl I cant really think of a name for it
charred monolithBOT
limber skiff
is slint really that good
limber skiff
@austere talon the old ui for user voice show had the feature of showing the channel limit and amount, even tho it was totally not intentional lol
I think it was because of useChannelName for the name component
I had no idea 😂
austere talon
lmao
charred monolithBOT
dusk blaze
i should fix my PR
@austere talon can you reopen https://github.com/Vendicated/Vencord/pull/3105 else i can't merge main branch for some reason
charred monolithBOT
gritty iris
damn I didnt even look over yet 😭
austere talon
working on this rn (not final ui)
elder plinth
way to organize context menu items 
gritty iris
it really isnt I've tried 
austere talon
working on this rn (not final ui)
it could also allow reordering
charred monolithBOT
left sequoia
working on this rn (not final ui)
show examples of what the elements look like
u could try mounting them in under the descriptions with dummy data
or smth idfk
austere talon
yop
that is indeed the plan
all plugins are gonna have to export their icon or smth for that tho
charred monolithBOT
turbid hatch
working on this rn (not final ui)
hmmm.. this seems ... translatable
charred monolithBOT
turbid hatch
(unrelated)
scenic brook
I had no idea that was a thing
charred monolithBOT
dusk blaze
vibe coded slop
scenic brook
Leaving the myCoolPlugin stuff in is pretty funny
charred monolithBOT
fossil inlet
what's the endpoint to poll to get the latest discord version
elder plinth
elder plinth
thats the same thing
fossil inlet
no?
elder plinth
I just linked you to the endpoint
fossil inlet
I just linked you to the endpoint
you linked me to this
elder plinth
yes and if you scroll down on the page you linked you get to that
fossil inlet
https://docs.discord.food/topics/client-distribution#web
wait this isn't it either
fossil inlet
ty
fossil inlet
it's https://discord.com/assets/version.stable.json
what's the one for canary/ptb
elder plinth
no version.ptb or version.canary? oh do you just use the subdomains for those
fossil inlet
tried version.canary.json
fossil inlet
guhhh
why even use .channel.json if they're only hosted on their respective subdomains
fossil inlet
idrc
median rapids
oh you need ptb subdomain for version.ptb
ya
median rapids
why even use .channel.json if they're only hosted on their respective subdomains
it's a cf worker
probably just returns the x-build-id header
charred monolithBOT
untold rock
im trying to add plugin bisect to vencord
where should i put the file that contains the bisecting logic
i added a button in the settings menu im just not sure where the function that it calls should be
actually forget that im just moving it to a plugin
fossil inlet
im trying to add plugin bisect to vencord
i made that a while back lol
untold rock
i made that a while back lol
bruh
fossil inlet
i just made a settings pane for that
untold rock
does it still work
fossil inlet
probably not
untold rock
i just made a settings pane for that
im thinking ill just make a plugin and add a slash command
fossil inlet
i'd have it as a menu
untold rock
i'd have it as a menu
but then it cant be a plugin
untold rock
settings is just a patch lol
i dont wanna patch because theres no docs
seems complicated
untold rock
https://github.com/Vendicated/Vencord/blob/main/src/plugins/startupTimings/index...
i have no idea how that works
fossil inlet
learn
fossil inlet
see what the patch does
play with it
i reccomend you use vencord companion (my version), but you can also use patch helper
untold rock
looks like im having a fun time i dont use vsc
fossil inlet
@dusk blaze is this the correct behavior on mac
still maple
<@886685857560539176> is this the correct behavior on mac
Pretty sure it is
Mac use meta where everyone use ctrl
scenic brook
big one
charred monolithBOT
austere talon
rip reporter @limber skiff #1337479880849362994 message
it's cause it does this
it's a wrapper function
so this doesnt work any longer
limber skiff
austere talon
it's a chunk load error retry thing
anyway it should be easy to fix
yep easy
function getWebpackU(instance) {
const sym = Symbol();
let v;
Object.defineProperty(Object.prototype, sym, {
get() {
v = this;
return "";
},
configurable: true
});
instance.u(sym);
delete Object.prototype[sym];
return v;
}
exactly same hack I use in my UserScript for getting private webpack cache
@fossil inlet ^
austere talon
vtest fix-reporter
nimble pendantBOT
vtest fix-reporter
Now testing! 
austere talon
hmm
limber skiff
Ideally we should still get a reference to the function that returns the path
since webpack sometimes does weird things and doesnt include all chunks in the object
austere talon
insufficient resources error
charred monolithBOT
nimble pendantBOT
vtest fix-reporter
Now testing!
austere talon
why are we even converting to number?
nimble pendantBOT
vtest fix-reporter
Seems like everything is working fine (for now) 
nimble pendantBOT
vtest fix-reporter
Seems like everything is working fine (for now)
austere talon
yeah nice
fossil inlet
it's cause it does this
huskkkkk
this also breaks my offline build scraper/reporter
austere talon
Ideally we should still get a reference to the function that returns the path
not that easy
we would have to monkey patch .u before they do
limber skiff
yeah
austere talon
not that hard but annoying to do
limber skiff
that's why I said ideally 😛
discord is so confused because of ignore activities
it shows that to me everytime
fossil inlet
yeah, they was referring to rspack devs
tbh if i had to guess js code splitting is a native feature but css requires a plugin
but idk
fossil inlet
yeah, `they` was referring to rspack devs
tbh if i had to guess js code splitti...
/they are handled separately
austere talon
yeah i meant discord probably only enabled it for js
gritty iris
oh lord
fossil inlet
idgi either
dusk blaze
<@886685857560539176> is this the correct behavior on mac
yeah
austere talon
this ui is clean
charred monolithBOT
austere talon
vtest fix-reporter
nimble pendantBOT
vtest fix-reporter
Now testing!
nimble pendantBOT
vtest fix-reporter
Seems like everything is working fine (for now)
nimble pendantBOT
vtest fix-reporter
Seems like everything is working fine (for now)
austere talon
I wanna show the icon here but for that plugins have to export their icons
should we just require plugins to also set this property?
for chatbar buttons and message popover buttons
fossil inlet
I wanna show the icon here but for that plugins have to export their icons
sho...
yeah, that would probably make for better ux
easier for things like "how do i hide this annoying icon"
charred monolithBOT
austere talon
breaking change for user plugins 
i made it type error but the error is kinda confusing
imagine if ts allowed custom type errors
fossil inlet
i made it type error but the error is kinda confusing
insane
fossil inlet
me when the ui crashes because of some userplugin
just make it optional
fossil inlet
me when the ui crashes because of some userplugin
just make it optional
(not as a type but dont typeerror if it isn't there)
dusk blaze
i’m not updating all of my abandonware for a fancy icon showing in a popup
show like ❓ for missing icons
austere talon
(not as a type but dont typeerror if it isn't there)
typescript type error 
dusk blaze
or 🧩
fossil inlet
i made it type error but the error is kinda confusing
do you mean typescript error, or runtime typeerror
austere talon
i made it type error but the error is kinda confusing
lovely error
fossil inlet
guh i'm confused
austere talon
type error
austere talon
lovely error
is there any way to make this error less insane
fossil inlet
is there any way to make this error less insane
i have some ideas
ill try them out and see what i can find
austere talon
the error itself is clear but it keeps saying the type of the object you're passing is the issue
fossil inlet
that is not a clear error
too much noise
austere talon
did u read what I said 😭
the error itself (the red circled bits) is clear
the noise is the fact that it keeps repeating the type you're passing
fossil inlet
guhhhhh
austere talon
with a minimal plugin there's way less noise
it would be much nicer if we just made our own eslint plugin
is there a good icon for unknown
like placeholder icon
send
fossil inlet
is there a good icon for unknown
iirc discord has some box with a question mark in it
austere talon
send
fossil inlet
trying to find it
scenic brook
iirc discord has some box with a question mark in it
This one?
fossil inlet
yeah
dusk blaze
i feel like Message Popover isn't that descriptive ykyk
austere talon
fossil inlet
i feel like Message Popover isn't that descriptive ykyk
i feel like you're wrong
fossil inlet
noone calls them popovers
thats what the description is for
scenic brook
send svg
<svg aria-hidden="true" role="img" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none" viewBox="0 0 24 24"><path fill="currentColor" fill-rule="evenodd" d="M5 2a3 3 0 0 0-3 3v14a3 3 0 0 0 3 3h14a3 3 0 0 0 3-3V5a3 3 0 0 0-3-3H5Zm6.81 7c-.54 0-1 .26-1.23.61A1 1 0 0 1 8.92 8.5 3.49 3.49 0 0 1 11.82 7c1.81 0 3.43 1.38 3.43 3.25 0 1.45-.98 2.61-2.27 3.06a1 1 0 0 1-1.96.37l-.19-1a1 1 0 0 1 .98-1.18c.87 0 1.44-.63 1.44-1.25S12.68 9 11.81 9ZM13 16a1 1 0 1 1-2 0 1 1 0 0 1 2 0Zm7-10.5a1.5 1.5 0 1 1-3 0 1.5 1.5 0 0 1 3 0ZM18.5 20a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3ZM7 18.5a1.5 1.5 0 1 1-3 0 1.5 1.5 0 0 1 3 0ZM5.5 7a1.5 1.5 0 1 0 0-3 1.5 1.5 0 0 0 0 3Z" clip-rule="evenodd" class=""></path></svg>
thanks
annoying duplication but once I add the logic idk if it will be worth to make it a component just to slightly deduplicate code
limber skiff
this duplication is kinda annoying
limber skiff
oh come on are they rendering images as webp again
I see degraded quality
it looks choppy
austere talon
yeah lmao it's so low res until you open in browser
it's even discoloured
like washed out
austere talon
this duplication is kinda annoying
i dont think there's a better solution
limber skiff
yeah I'm not sure either
austere talon
fossil inlet
i dont think there's a better solution
the only thing i can think of is something like
export default definePlugin({
messagePopover: {
icon: Icon,
render() {
// render
}
}
})
this would also make the typescript errors a lot better
fossil inlet
discord insane
austere talon
fossil inlet
@limber skiff isn't that what this plugin is for
limber skiff
yeah
austere talon
rn it only removes format=webp iirc
austere talon
the only thing i can think of is something like
```ts
export default definePlugi...
this is better ig but thats not backwards compatible at all
maybe we just break backwards compatibility with userplugins, it's not gonna cause crashes
just less funcitonality but the plugin can fix
limber skiff
<@235834946571337729> isn't that what this plugin is for
it prevented the extension from being set to webp iirc
but now even .png returns webp
austere talon
the only thing i can think of is something like
```ts
export default definePlugi...
this is better I'll go with this
much nicer error too @fossil inlet
I just typed it as never
fossil inlet
much nicer error too <@521819891141967883>
tbh i wouldn't use @deprecated, that makes it seem like it still works but is discouraged
the error will still be there either way
charred monolithBOT
austere talon
backwards compatible
had to refactor some code cause you can't use this anymore this way
well we could bind
should I
charred monolithBOT
fossil inlet
guhhh git evil
no wonder nothing has been updating
how did dev even get that upstream
charred monolithBOT
fossil inlet
working on something™
elder plinth
hello from 2 months in the future, I've just learned that settings.use() subs to every setting from every plugin, not just the current plugin. that seems very not useful, no?
in fact it was causing an infinite rerender crash for me with my changes to NoBlockedMessages cause I forgot to list the specific settings and just used settings.use() 😭
was a very weird bug too. only happened when interacting with thread starter messages from a blocked user.
limber skiff
hello from 2 months in the future, I've just learned that `settings.use()` subs ...
it shouldn't
elder plinth
maybe some conflict where a plugin was updating a setting every time I tried expanding the collapsed thread starter message and so causing a loop. otherwise idk
limber skiff
I mean that settings.use should only subscribe to your plugin
limber skiff
where are you logging that
elder plinth
useSettings
limber skiff
screenshot
elder plinth
1s just started windows for this
gotta load vscode
export function useSettings(paths?: UseSettings<Settings>[]) {
const [, forceUpdate] = React.useReducer(() => ({}), {});
console.log("[!!!!]", paths);
useEffect(() => {
if (paths) {
paths.forEach(p => SettingsStore.addChangeListener(p, forceUpdate));
return () => paths.forEach(p => SettingsStore.removeChangeListener(p, forceUpdate));
} else {
SettingsStore.addGlobalChangeListener(forceUpdate);
return () => SettingsStore.removeGlobalChangeListener(forceUpdate);
}
}, [paths]);
return SettingsStore.store;
}
was logging paths after the const
limber skiff
It's just components re-rendering
elder plinth
but is that global listener not for every plugin
limber skiff
it doesn't mean all settings are triggering a re-render for your plugin
yes
but the others have paths
if they have paths it's for a plugin
is the one with undefined path the one with settings.use() ?
elder plinth
idk how to tell. the console was spamming horrible with that log
im assuming so since in that case paths is undefined
limber skiff
what's your plugin called
elder plinth
I'm just modifying NoBlockedMessages
limber skiff
is there no path which is just plugins.NoBlockedMessages?
elder plinth
it doesn't mean all settings are triggering a re-render for your plugin
ok so to test this I reverted to using settings.use():
filterStream(channelStream: [ChannelStreamGroupProps | ChannelStreamMessageProps | ChannelStreamDividerProps]) {
const {
alsoHideIgnoredUsers,
disableNotifications,
hideBlockedUserReplies,
allowAutoModMessages,
defaultHideUsers,
overrideUsers
} = settings.use();
console.log("[!!!!] Rerendered NoBlockedMessages");
and every time I toggle silenttyping with the icon in the chat bar the log is made to console so
limber skiff
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/8943c90cb0b8be7c6c268ec4fb6931d30ad1d...
Settings.ts: Line 251
settings?.map(name => `plugins.${definedSettings.pluginName}.${name}`) as UseSettings<Settings>[]
lol
on the bright(?) side it doesnt look like any plugins are actually using the settings.use() syntax without specifying settings
not really sure what was the issue but some setting must have been updating every time I tried expanding the blocked group lol cause this is the error it produced
took hours to trace this back to settings.use() 😭
limber skiff
https://github.com/Vendicated/Vencord/blob/8943c90cb0b8be7c6c268ec4fb6931d30ad1d...
@austere talon is it intentional settings.use subscribes to all Vencord settings
I'm pretty sure it should be to the plugin only
how did we never noticed this...
elder plinth
if you look at their message I initially replied to and the one about 5 below it V said settings.use() should work instead of declaring all 20ish settings manually "at least I think so" so I have a feeling it was not in fact intentional
elder plinth
lol that whole function has a todo above it
/**
* Settings hook for React components. Returns a smart settings
* object that automagically triggers a rerender if any properties
* are altered
* @param paths An optional list of paths to whitelist for rerenders
* @returns Settings
*/
// TODO: Representing paths as essentially "string[].join('.')" wont allow dots in paths, change to "paths?: string[][]" later
export function useSettings(paths?: UseSettings<Settings>[]) {
the problem is useSettings should be passing an array with just the plugin path
if no settings were passed to it
elder plinth
docstring kinda makes it seem like it was intentional. though maybe a lot of thought was just not put into it
limber skiff
instead it's just returning undefined
elder plinth
**Settings.ts:** Line 251
```ts
settings?.map(name => `plugins.${definedSettings...
so you mean that if nothing is passed to use then this settings?.map just resolves to undefined which subscribes to every plugin
use: settings => useSettings(
settings?.map(name => `plugins.${definedSettings.pluginName}.${name}`) as UseSettings<Settings>[]
).plugins[definedSettings.pluginName] as any,
it only returns that plugin's settings but it still subs to every plugin's settings 🤔
use: settings => useSettings(
(settings?.map(name => `plugins.${definedSettings.pluginName}.${name}`) ?? [`plugins.${definedSettings.pluginName}`]) as UseSettings<Settings>[]
).plugins[definedSettings.pluginName] as any,
so what something like this?
limber skiff
so you mean that if nothing is passed to use then this `settings?.map` just reso...
yes exactly
austere talon
yeah no copilot we're not doing all that
austere talon
idk which one I should do
maybe we want to allow reordering
so the second would be better
but then we could just have a separate order property
I think I'll go with the second
if we allow reordering then where would new buttons be added?
bleak blaze
context menu reorganizing > 🤑
fossil inlet
idk which one I should do
Id go for the second one
Also, how would this work if a plugin registered more than one chat bar button or something like that
austere talon
Also, how would this work if a plugin registered more than one chat bar button o...
both take ids
limber skiff
5k orbs quest available rn
austere talon
5k orbs quest available rn
yop
idle fossil
there's a quest completer plugin?
charred monolithBOT
austere talon
ready now
i should add a context menu like this
probably should fix this before merge
charred monolithBOT
fossil inlet
probably should fix this before merge
You will double destructure
austere talon
no thats ugly
gritty iris
yeah no copilot we're not doing all that
ATP add a disabled everything button to uninject
fossil inlet
no thats ugly
Wrong!
austere talon
goated module
austere talon
what the horror is this component
gritty iris
I didnt know I was in halloween wtf is that
austere talon
ManaContext Provider
fossil inlet
what the horror is this component
Is that some branch for like visual refresh or something that never got removed
That's my guess
