Oh they split the emoji into its own span
#👾-core-development
scenic brook
All it does is add this class to emojis, surely we can emulate that
I'll have a look Later™️ if nobody else does
scenic brook
works
long stream
scenic brook
Hmm, when you have the username first the glow is still generated from the display name
charred monolithBOT
Prevents emojis getting filled with colour when a user has gradient/holographic role colours.
scenic brook
I'll add a fix later for that if I can find it Added it, not thrilled about the duplicated code but I don't really care enough to think about it more
charred monolithBOT
charred monolithBOT
scenic brook
I like the hardcoded css class
jolly egret
nobody follows the plugin rules
desert cosmos
there are rules?
austere talon
that fix seems very hacky and suboptimal
limber skiff
it's how discord does
limber skiff
All it does is add this class to emojis, surely we can emulate that
^^
but better to use their own code if possible
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing! 
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now) 
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now)
scenic brook
but better to use their own code if possible
I'll have a look later, tbh I was supposed to be working at the time and it didn't even cross my mind lol
charred monolithBOT
austere talon
js finally added array methods like .filter to iterators
too bad it's so new we can't use it yet
opaque silo
too bad it's so new we can't use it yet
https://caniuse.com/mdn-javascript_builtins_iterator_map
i meannn discord desktop and vesktop both support it.., web users can cope or update their browser trol
austere talon
we can use it on vesktop
opaque silo
yop
fossil inlet
@austere talon :megahusk:
austere talon
<@343383572805058560> :megahusk:
what
fossil inlet
what
how do i enable arrpc on vesktop (the builtin version has never worked for me on linux)
austere talon
hop off using flatpak
fossil inlet
hop off using flatpak
fun fact! i am not using, nor have i ever used vesktop as a flatpak
it never worked for me under arch or nixos
also this would make it impossible to use a local build if you were making changes to it
austere talon
how do i enable arrpc on vesktop (the builtin version has never worked for me on...
and you should just debug this 
all it does is run arrpc
opaque silo
built-in arrpc can't even do OBS detection despite out patches enabling the toggle to do so
opaque silo
built-in arrpc can't even do OBS detection despite out patches enabling the togg...
crying and screaming that we soft fork to have the dynamic db and single path patches 😭😭
fossil inlet
normal users just get confused
not a reason to completely remove the feature from vesktop
maybe add a warning when you enable it or something
opaque silo
vee hates choice that's why he uses gnome (the normie users can't be given the ability to have options)
fossil inlet
vee hates choice that's why he uses gnome (the normie users can't be given the a...
choice working software
dusk blaze
saladeath
austere talon
it's not choice
there is 0 reason to use the arrpc plugin on vesktop unless you are making changes to arrpc and want to use your own version, in which case you are definitely competent enough to just add it as a userplugin
"inbuilt one doesn't work so I use external + plugin" is not a valid argument, because that's a very poor solution we shouldn't encourage
opaque silo
crying and screaming that we soft fork to have the dynamic db and single path pa...
I yell into the void and all I hear is silence
austere talon
that is completely unrelated to the plugin being hidden on vesktop now
opaque silo
😭😭🤥
charred monolithBOT
idle fossil
?
torn horizon
waiting for pr review 
jagged reef
Aren’t we all
scenic brook
Pretty minor as it's caught and returns false anyway but opening DMs causes this error in logs
limber skiff
Pretty minor as it's caught and returns false anyway but opening DMs causes this...
what module calls isHidenChannel?
scenic brook
limber skiff
so discord is trying to tell me that the function fetchingMessages receives null as the channel id?
jagged reef
Pretty minor as it's caught and returns false anyway but opening DMs causes this...
A pretty what?
shell shuttle
vtest dev4
charred monolithBOT
charred monolithBOT
austere talon
or just find people who scrobble properly on soulseek and download from them 
charred monolithBOT
last.fm actually does show the album art in my feed. Here's an example from last month:
The Yue songs did not have any album name when scrobbled.
I assume what I do in my PR is similar to what they do to support that, given the API response doesn't include the track image by default. I don't think it's unreasonable for Vencord to do the same.
And I appreciate the suggestion, but I would much rath...
austere talon
bad player...
torn horizon
waiting for pr review day 69 
charred monolithBOT
kindred tree
fuck lastfm 
brazen bone
Do we know anything about how discord's managed to make devtools lag so bad?
austere talon
magic ✨
you know all those sites that try to block devtools
they should just copy from discord
brazen bone
Yeah it's insane, discord has finally succeeded in achieving absolute enshittification
Am I misreading this or does profiler say it downloaded the css a hundred times
And following that, it reports a lot of css updates in devtools, layout computations, and sendPackets between parent and child process
austere talon
how
brazen bone
I don't know, I'm trying to figure it out
brazen bone
I can't make any sense of this other than it has something to do with updating the list of styles in the element inspector
fossil inlet
Am I misreading this or does profiler say it downloaded the css a hundred times
could it just be the nnmber of times it tried to fetch
and it was just returned from disk/memory cache
opaque silo
Do we know anything about how discord's managed to make devtools lag so bad?
i think its just devtools being ass at resolving the stylesheets
brazen bone
If there's one website on the planet that it has issues with, I'm inclined to blame that website, not the devtools
charred monolithBOT
Content
really minor, but annoying
Request Agreement
- [x] I have read the requirements for opening an issue above
dusk blaze
salad virus
fossil inlet
AI ahh readme
dont all context menu callbacks have a ref to the element that triggered them
torn horizon
hollow musk
damn thats rough
hollow musk
couldve used the old pr 
long stream
oh come on, you could at least try to make it look like you didn't ai generate it 
jagged cloak
clearly bro did not use claude 4 opus max mode for this /s
charred monolithBOT
dusk blaze
dusk blaze
???
brazen bone
What even is an 18+ programming language
torn horizon
I'd like to believe it means 18 more 
limber skiff
clearly not
jolly egret
ai readme
discord cdn link that expires
horror formatted codeblock in md
added another plugin too originally?
told people to open issues
charred monolithBOT
charred monolithBOT
What happens when the bug or crash occurs?
No crash
What is the expected behaviour?
Should be displayed on top not next to username
How do you recreate this bug or crash?
The display is a bit weird cf pic :
Im using (next to the timeout icon)
Errors
No errors
Request Agreement
- [x] I am using Discord Stable or tried on Stable and this bug happens there as well
- [x...
charred monolithBOT
dusk blaze
austere talon
wtf is a minus issue
charred monolithBOT
scenic brook
Probably minor not minus
charred monolithBOT
You copied our code you do not have rights to do that without proper licensing.
no you are not, and vencord did not copy any code from betterdiscord lol
charred monolithBOT
scenic brook
Does that just make every vencord user spam them with friend requests?
austere talon
why are u seriously replying to a troll
charred monolithBOT
charred monolithBOT
opaque silo
genuinely what goes through someone's head to post this 😭
jagged cloak
guthub
charred monolithBOT
desert cosmos
issue deleted 
charred monolithBOT
austere talon
"obscure endpoint" and it's just a mobile only feature ported to desktop
still cool but lol
gritty canyon
who is toby
austere talon
toby
gritty canyon
limber skiff
Toby
gritty canyon
the comments are amazing please keep them in
charred monolithBOT
hollow musk
i know you are tempted vee, do not bump him down a cliff
still maple
chatgeppity
more like ChatG3.14T
kindred tree
"obscure endpoint" and it's just a mobile only feature ported to desktop
tbf those endpoints aren’t the easiest to find
compared to the endpoints the pc client uses
kindred tree
that’s so much more effort than pressing f12 lol
also is that even a thing if you use iOS
kindred tree
😢
austere talon
surely ios can use proxies & install a certificate
dusk blaze
also is that even a thing if you use iOS
yea you can
kindred tree
yay
austere talon
i love that they added their own name to the ui
median rapids
yeah😭
jagged reef
200 perfectly
jagged reef
i love that they added their own name to the ui
Append all strings with "by Vee (vending.machine)"
gritty iris
const Kangaroo 😭
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/quickReply/index.ts#...
index.ts: Line 26
const Kangaroo = findByPropsLazy("jumpToMessage");
Perfect lmao
austere talon
I should make that plugin better
gritty iris
I hate event listeners but they are so useful
I know how to use them and all but I just can't with them like they are too simple for me i guess I don't know
charred monolithBOT
opaque silo
did they just call chatgpt geppity-san.,,.
opaque silo
won't be possible without shipping a node dbus lib with vencord
there might also be a node libnotify lib to avoid raw dbus interaction but that's still a native dep that vencord needs to ship
🤥
there's also the portal spec https://flatpak.github.io/xdg-desktop-portal/docs/doc-org.freedesktop.portal.Notification.html so to avoid duplicate work it might be best to interact with libnotify
@rotund canopy
you could also be insane and shell out with notify-send (CLI for libnotify) ... not exactly practical as it doesnt support raw image data
austere talon
won't be possible without shipping a node dbus lib with vencord
there might als...
not happening
limber skiff
**index.ts:** Line 26
```ts
const Kangaroo = findByPropsLazy("jumpToMessage");
`...
lmao don't we have a common for that
with a proper name
scenic brook
MessageActions.jumpToMessage
limber skiff
yep
charred monolithBOT
Update on the Linux notifications:
I have managed to notifications on Linux working. I'm currently facing two problems. The first of which is that this implementation relies on the dbus-next dependency, and the latter being that attachments seem to be capped to a very low resolution (at least on Ubuntu). I've linked a gist below.
| Example scr... |
gritty canyon
holy stupid
dusk blaze
isn't that linux only?
charred monolithBOT
charred monolithBOT
Something like this works, I wouldn't claim feature parity though.
austere talon
it's not a veto as much as it's simply not possible with how vencord currently works lol
but yeah native libs are bad
dusk blaze
vencord will go zero runtime dependencies @austere talon
austere talon
essentially already is
opaque silo
why the hell can't I run this plugin everything on Native is undefined
austere talon
why the hell can't I run this plugin everything on Native is undefined
you need to fully restart discord to reload natives
opaque silo
using AI for a full typescript impl 
scenic brook
You mean you don't just tell copilot to write it and then paste every error that comes up back into it until there stops being errors?
dusk blaze
Just Grok it ✨
charred monolithBOT
dusk blaze
@austere talon you will lock this commit
scenic brook
It is kinda funny that by definition the only people mad at this are children
gritty canyon
It is kinda funny that by definition the only people mad at this are children
not rly
the gate in uk and australia requires id verification and some people just dont want to do that
lime idol
odd heath
Go fix it then
shell shuttle
can't be funny in this server smh
lime idol
Go fix it then <:blobcatcozy:1026533070955872337>
I can't
I'm forwarding this message to Nuckyz
odd heath
what did discord cook
limber skiff
I'll fix if no one does
odd heath
iwanna try if i can find what they nuked
limber skiff
for anonymise file names?
odd heath
yea
ill take a look at webcontextmenus after that
but i dont feel like saveProductWithAttachments is something that it should patch simultaneously i fail to find anything else what couldve been patched prior
unless it is the right thing?
odd heath
I shouldn't had closed my client so I could compare versions
yeag i wish i could compare 😭 would be easy then
limber skiff
take a look at the other patch for anonymise file names
the location it patches is a call to a function
that function was the same called in the other patch, but instead it had one of its parameters as that constant string
find all places where that function is called and try to guess if it's related to attachments
understood what I mean?
limber skiff
if not leave it to me and I will look later
charred monolithBOT
odd heath
wha?
thewy added a ternary
so either make it non-lazy or make it go until after the ternary specifically
cuz if its lazy it ends before the parenthesis and thats why it errors
austere talon
ah
odd heath
also
i just found this
why is cancopyimage here
cuz if i make the patch so it applies for it it causes crashes
austere talon
so u can copy image?
odd heath
so u can copy image?
yes but old version doesnt do anything cuz 50chars isnt enough to match
and if i extend it to 120 it crashes on vesktop
whenever you click on an image
so idk
removing the cancopyimage completely makes it work fine
limber skiff
what's the original method?
odd heath
what's the original method?
same thing but if (false) is if (!h.isPlatformEmbedded)
charred monolithBOT
odd heath
show me canSaveImage
austere talon
or find why `I` is undefined
cause it's DiscordNative.clipboard
limber skiff
ahh
odd heath
actually yeah I shouldn't be undefined lol
it probably shouldnt considering how often its used there
but idk what to do with that patch
limber skiff
or find why `I` is undefined
^^
odd heath
^^
idk it doesnt get redefined anywhere so its window.DiscordNative itself thats undefined
but that seems a bit too broad to look for
and i dont think that gets set to undefined anywhere
or is it just always undefined on vesktop 
yeah it seems like its just generally undefined on vesktop/web
so keeping cancopyimage patched like that probably doesnt make sense at all
but idk what to change it to
limber skiff
just return true to canCopyImage and make it use vencord util for copying
odd heath
just return true to canCopyImage and make it use vencord util for copying
but copying images works fine already
a least for me
dont see what that change would even di
limber skiff
then just return true lol
odd heath
instead of typeof i.clipboard?
ill just put it on line one of the fn
and see what happens
austere talon
just let me fix it
gritty iris
whenever you click on an image
works fine for me on chrome with match: /(?<=(?:canSaveImage|canCopyImage)\((\i,\i)?\)\{.{0,150})!\i\.isPlatformEmbedded/g, 🤷
gritty iris
im checking on vesktop rn
works for me
ill test with your patch 1s
works with yours
gritty iris
why does it crash on vesktop then
it does it now I guess it didnt build mb
odd heath
classic
gritty iris
😭
odd heath
i mean yea but it also works fine if you just dont patch it at all
thats what confused me so much
odd heath
LMAO
gritty iris
now I could be wrong but that aint a file ext
I just saved it twice got this and .png
odd heath
opaque silo
i mean I get their argument
information being in discord servers has been a disaster for access and preservation
cause its not indexable by the wider internet
clear jasper
i thought you were supposed to add author for any change
do you want me to remove it
limber skiff
yeah
limber skiff
i thought you were supposed to add author for any change
only substantial change
clear jasper
alr done
jolly egret
you still added yourselves to devs idk about that
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
limber skiff
you still added yourselves to devs idk about that
that's fine
just not adding themselves to plugin author
nimble pendantBOT
vtest dev2
nimble pendantBOT
vtest dev2
limber skiff
what merge conflicts?
jolly egret
how did you hit merge conflicts in an hour of the PR being open
limber skiff
there should be none
jolly egret
clear jasper
clear jasper
Ty
jolly egret
if you're merging stuff could you take a look at my PRs ty
they both aren't that big
limber skiff
sorryy I'm tired rn
I'm just fixing what is broken to keep everything clean right now
clear jasper
how did you hit merge conflicts in an hour of the PR being open
Conflicts from dev that aren’t there on main
limber skiff
vtest
clear jasper
different build
limber skiff
huh?
clear jasper
this is an older build ^^^
limber skiff
I'm just saying that the error is weird
I can't reproduce and it only happens sometimes
clear jasper
o
limber skiff
it looks like if some module which has not been loaded is trying to be required
guessing the error comes from this .call
just a guess though because I can't see the stack trace of it
jolly egret
sorryy I'm tired rn
all good
dusk blaze
I like how these are looking like
the spotify acrivity is kinda fat
glass jasper
I like how these are looking like
Personally, other than the shop button and the roles is being rounded, It’s not bad.
granite wharf
I thought that was gonna be a simple change but i got jumpscared by it being an entire plugin
clear jasper
I thought that was gonna be a simple change but i got jumpscared by it being an ...
you'd think
jagged reef
if you're merging stuff could you take a look at my PRs ty
And mine 🥺
Holy moly
T- 5 days until my other MR hits one year
.
I don't have the funds to inbest in another cake
fossil inlet
new plugin pr soon™️
glass jasper
new plugin pr soon™️
Merge eta 2030
austere talon
information being in discord servers has been a disaster for access and preserva...
betterfolders being broken for 18 hours is definitely information that needs to be preserved for the future
charred monolithBOT
clear jasper
anyway we don't even support Firefox
you do via the userscript
austere talon
if anything this code should be userscript only
clear jasper
is there a way to do that or do I have to code that
austere talon
there isnt but dw about it
clear jasper
there isnt but dw about it
i just did a simple user agent check
austere talon
I'll add it maybe
austere talon
i just did a simple user agent check
don't 😭
glass jasper
there isnt but dw about it
Thats actually very surprising that there isn’t
austere talon
because the userscript is mostly an afterthought
glass jasper
Understandable
clear jasper
fair enough
clear jasper
otherwise Google extension reviewers might not like
I went ahead and made it a .web plugin for now until you make a userscript check
clear jasper
if anything this code should be userscript only
so as it turns out, you can edit the CSP of a page via a firefox extension, but not a tampermonkey userscript
because of course not why should anything work
and I had been testing with a ff extension this entire time
austere talon
so as it turns out, you can edit the CSP of a page via a firefox extension, but ...
yes because if you compile it as an extension, it uses the extension api to completely remove Discord's csp header
clear jasper
nvm it's a setting in tampermonkey
austere talon
if you compile Vencord as an extension, it will use an extension background script to remove the header
https://github.com/Vendicated/Vencord/blob/main/browser/manifestv2.json#L37-L39
https://github.com/Vendicated/Vencord/blob/main/browser/background.js#L18
grave mangoBOT
if you compile Vencord as an extension, it will use an extension background scri...
manifestv2.json: Lines 37-39
"background": {
"scripts": ["background.js"]
},
background.js: Line 18
removeFirst(responseHeaders, h => h.name.toLowerCase() === "content-security-policy");
clear jasper
**manifestv2.json:** Lines 37-39
```json
"background": {
"scripts": ["backgr...
yea, just tested and it's also broken in the chrome userscript without turning on disable CSP in tampermonkey
austere talon
you cannot make csp more lenient by adding a second rule
^
it only works if u remove discord's header
and then it's pointless cause there's no csp in the first place
grizzled halo
Fakenitro stickers sending isnt working, the stickers are unlocked howerver clicking them does nothing
Happens on vesktop and desktop (with no errors in console)
On latest version of vencord
Multiple (at least 3 others) also have the same problem
just in case it's not known already
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
limber skiff
vtest
charred monolithBOT
desert cosmos
i mean issues necroposting isnt that bad
well only if its still an issue
LOCKED FOR SPAM
vee..
kindred tree
bump 
austere talon
LOCKED FOR SPAM
because it is????
necroing year old irrelevant invalid issue for yet another invalid issue
charred monolithBOT
austere talon
charred monolithBOT
austere talon
better wording i think
scenic brook
Would it be better to exhaustively list the whitelisted sites? Maybe collapsed if you don't want it taking up too much space
Otherwise they have no way of knowing what they are besides those two
austere talon
not really possible
well kinda
idk how to display it there
we can add it in the future if there is demand
scenic brook
Not a huge deal, I just foresee people forever asking what the whitelisted sites are
austere talon
it shouldn't affect many users
austere talon
Not a huge deal, I just foresee people forever asking what the whitelisted sites...
it explicitly mentions github, imgur and (now) google fonts
you don't need more than those 3
woeful sleet
Could just make it so clicking "whitelisted websites" opens a modal that has them all listed. that or a details pane somewhere below the rest of it
scenic brook
tbf I don't use themes anyway so whatever works
charred monolithBOT
dusk blaze
venWOKE
scenic brook
wokecord
versed fern
austere talon
better wording i think
is this good @limber skiff
made the message slightly better
austere talon
ready to merge?
dusk blaze
CSS will be capitalized
@limber skiff surprised you didn't catch that after correcting capitalization on a code comment
dusk blaze
Css
austere talon
@uneven needle btw for your csp thing
if you want a user friendly and secure way to whitelist domains, do the following:
- add ipc methods for adding and removing domains from the whitelist to your plugin
- inside the native ipc handler, validate that the input is a valid URL (just do
new URL(url)with try catch), then show a confirmation dialog (electron dialog api) to the user with a short explanation. confirmation shouldn't be necessary for remove - if the user presses confirm, add it to the
NativeSettingsobject (please choose a reasonable namespace on this object that guarantees compatibility). Settings api but native with no renderer access - Read whitelisted domains from the NativeSettings
maybe if there is a lot of demand vencord can add an api for that
but doubt
scenic brook
There's a parseUrl function in misc as well that's just that try catch
austere talon
which you can't import in native
uneven needle
<@297410829589020673> btw for your csp thing
if you want a user friendly and se...
thanks i'll do that 
(none of this wouldnt had happened if i had realised earlier that discord allows images from twitter 😭)
austere talon
<@297410829589020673> btw for your csp thing
if you want a user friendly and se...
you can even do this dynamically lol
like detect csp violation > whitelist url
actually maybe I can integrate that into vencord natively
could be a good compromise for people wanting to use other sites for their themes
uneven needle
yeah
charred monolithBOT
fossil inlet
Lol didn't I have a PR for fixing that a while ago
austere talon
no it doesnt
clear jasper
where's the actual patcher then
austere talon
oh it does actually
fossil inlet
Lol didn't I have a PR for fixing that a while ago
austere talon
anyway the change is very weird
clear jasper
https://github.com/Vendicated/Vencord/pull/3194
oops
austere talon
https://github.com/Vendicated/Vencord/pull/3194
this already looks better
the one by coot seemed wrong
austere talon
the one by coot seemed wrong
for example \\\i wouldn't be replaced despite being valid
fossil inlet
this already looks better
from what i can tell coot's would fail with more than one \
austere talon
if i'm reading it right
clear jasper
from what i can tell coot's would fail with more than one `\`
it works
see the video in the PR comments
fossil inlet
ill trust you on that, too tired to wrap my head around it
clear jasper
https://github.com/Vendicated/Vencord/pull/3194
go ahead and merge this one tho because it's cleaner
austere talon
i never even use patchhelper
fossil inlet
tbh i stopped using it after i integrated a version into vscode
austere talon
i just use the og companion
fossil inlet
it's also annoying to have to have the settings page open to do it
clear jasper
I only use it because it shows what i'm relpacing in real time
fossil inlet
I only use it because it shows what i'm relpacing in real time
you mean patch helper?
clear jasper
ye
limber skiff
i never even use patchhelper
same lol
I dont even use the companion
I just write the patch and in case case I cant see why it doesnt work I paste into regex101
desert cosmos
review pr
close it
gritty canyon
>review pr
>close it
><:wires:1262562427422244874>
you know you know
at least it got reviewed
desert cosmos
😭
clear jasper
vgithub
austere talon
I don't really want to make any new changes to the installer tbh
austere talon
should I
austere talon
technically u can kinda use css with the userscript but
a) the editor just doesn't work so u have to import with settings sync
b) literally 0 external stuff
so i do think it's better UX to just recommend stylus
but stylus might be confusing to figure out
fossil inlet
Themes Are Not Supported On The Userscript
Use Better Discord On Desktop For A Better Experience
limber skiff
😭
fossil inlet
but stylus might be confusing to figure out
tbh not really
installing a userscript is about as hard as installing a style
austere talon
and this if you click edit quickcss
people who don't use chromium/firefox will simply cope
odd heath
and this if you click edit quickcss
imo that popup is just annoying id just hide the quickcss button altogether
austere talon
confusing
fossil inlet
imo that popup is just annoying id just hide the quickcss button altogether
how is it annoying
you just click out and go about your day
austere talon
why lol
vencord code is structured so bad I wanna do a big refactor
like the file structure
odd heath
do
limber skiff
vencord code is structured so bad I wanna do a big refactor
ikr lmao
fossil inlet
why not just use a discord modal
odd heath
that's so ugly
yea this is exactly why i hate those popups for some reason i never found that word to describe it 😭
limber skiff
vtest
fossil inlet
discord added it randomly only for vencord reporter to mess with you
charred monolithBOT
odd heath
so much effort bro
Just vibecode it
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
austere talon
i made most ErrorBoundaries noop
limber skiff
typo
limber skiff
austere talon
and even show noop in dev
limber skiff
I thought you were gonna ask me to review csp PR before merging it
nimble pendantBOT
vtest dev2
nimble pendantBOT
vtest dev2
austere talon
it's gonna be funny if you have a random errorboundary here or somewhere
austere talon
I thought you were gonna ask me to review csp PR before merging it
i mean you did already
austere talon
the changes I made were just the ui showing u what got blocked
fossil inlet
unable to do anything error boundaries everywhere
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
limber skiff
nah cause I didn't test that it works
trust the code
limber skiff
(I doubt it's gonna have issues)
limber skiff
austere talon
everyone will be stuck on broken version
with broken updater
support nightmare
just need to test
limber skiff
do it real quick and merge then
nimble pendantBOT
vtest dev2
nimble pendantBOT
vtest dev2
limber skiff
I swear github is just being slow again
austere talon
do it real quick and merge then
SCARY
limber skiff
so many patches being marked as slow
austere talon
okay i will test
limber skiff
okay i will test
nice
austere talon
also while doing the ErrorBoundary change
I noticed some bad places that weren't using noop
lmao
like typingtweaks avatar didnt use noop
imagine having big ErrorBoundary card next to typing indicator
limber skiff
so you mean here
because I just fixed it and error boundary was catching it
LOL
users are going to be jumpscared
austere talon
ah no
mentionavatars
thankfully
okay it seems to work
but i'm still scared lol
charred monolithBOT
austere talon
i will merge
i have an idea @limber skiff
we make this update
then we wait until it publishes
we update to it
then immediately push a second change
update to that change too, see if it works
if not we can emergency revert it
austere talon
okay it seems to work
maybe you can also test:
git checkout main
git pull
git reset --hard origin/HEAD~1 # head is now at SHC fix showing lock
curl "https://patch-diff.githubusercontent.com/raw/Vendicated/Vencord/pull/3436.patch" | git apply -
pnpm buildStandalone
then fully restart discord
there should be 1 update
try updating to it and see if it works
dusk blaze
vencord code is structured so bad I wanna do a big refactor
vencord would benefit from Bun
and NixOs
austere talon
vencord code is structured so bad I wanna do a big refactor
i hate that there's so much random shit in the utils folder
like why is quickcss and theme code in utils
odd heath
vencord would benefit if my settingsarray pr was merged
dusk blaze
i hate that there's so much random shit in the utils folder
isn't that your average utils folder
has all the slop with no clear structure
odd heath
yop
austere talon
yeah but it's awful in vencord lmfao
dusk blaze
utils/utils.ts
fossil inlet
isn't that your average utils folder
isnt that the point of a utils folder
odd heath
kinda
fossil inlet
`utils/utils.ts`
limber skiff
i hate that there's so much random shit in the utils folder
that's so true
austere talon
that u havent pushed yet
limber skiff
I mentioned the other day
austere talon
I'm looking at prs but nothing quick
limber skiff
a bunch of files with utils import webpack commons when they shouldnt
austere talon
oh yeah this is good https://github.com/Vendicated/Vencord/pull/2938/files
limber skiff
and then 
odd heath
i also have one open that allows to hide replies to blocked messages
quite short but dont know if it still works 
austere talon
oh yeah this is good https://github.com/Vendicated/Vencord/pull/2938/files
this description is so bad lmao
i dont understand what this is saying
fossil inlet
oh yeah this is good https://github.com/Vendicated/Vencord/pull/2938/files
got jumpscared from my other monitor
scenic brook
I did it while I was supposed to be working 
austere talon
also this looks like it would conflict with other mention plugins
fossil inlet
guhhh this is ulgy
that's what it was when i made that pr
scenic brook
It was coloured previously unintentionally because the thing was broken
austere talon
that's what it was when i made that pr
yes it's good in username
but not mentions
like this is clean
but inside mentions it isnt
scenic brook
Oh these are different things, ignore me
limber skiff
can't believe a vencord dev has to install vencord
austere talon
why tf does this need so much code Vendicated/Vencord#2929
fossil inlet
i'm going to eat then clean up that pr
austere talon
i keep getting jumpscared
see pr title
oh yeah surely this is just 3 lines
look inside
50 new lines of code
limber skiff
ngl we need more reviewers
scenic brook
why tf does this need so much code [Vendicated/Vencord#2929](https://github.com/...
The spoiler component was within the embed class so I couldn't just use a find
It was baby's first pr so it might be able to be done better these days
fossil inlet
doesnt the plugin already use the event
austere talon
doesnt the plugin already use the event
nah
limber skiff
okay I have it installed with http
austere talon
do you love
fossil inlet
kindred tree
I don't think you can scrape a captcha..
austere talon
requiring api key sucks balls
limber skiff
are you saying you always need to resolve a captcha to translate?
austere talon
lmao
austere talon
are you saying you always need to resolve a captcha to translate?
yes
you need to solve a captcha which gives u a session token
austere talon
they really don't want you to scrape it
undertsandbale
do i merge the pr now
and then we test
test in production
🔥
limber skiff
sorry but I dont think it's useful to have that service then
austere talon
i mean we have deepl with required key too and ik some people use it
limber skiff
no one is gonna generate an api token to use it
kindred tree
I did test it from main myself, tho my branch is outdated atm
austere talon
but idk how popular kagi is
limber skiff
never heard of it
austere talon
me neither
kindred tree
it's pretty powerful from my experience, DeepL often throws out quite messy answers
limber skiff
I feel like it fits better being a third party plugin
austere talon
yay?
limber skiff
if one really wants to use it
austere talon
ready for death?
austere talon
okay so
kindred tree
also google translate doesn't even work with traditional chinese for me, lol
odd heath
oh its that pr 
austere talon
- I merge into main
- we wait for build
- We update our client to it
- I merge a pr into main
- We test if we can update to this new change
austere talon
yeah just revert
limber skiff
testing in production
austere talon
only few people will be affected
limber skiff
ye
austere talon
testing in production
i mean I tested already
limber skiff
do it
austere talon
but just in case things go south somehow
limber skiff
it aint gonna break I have faith
austere talon
updater changes are so scary ahaha
charred monolithBOT
kindred tree
also would it be possible to hide these settings until either service is selected? It feels a bit cluttered already
austere talon
nah
kindred tree
oh well
limber skiff
@austere talon merge something now
limber skiff
same
austere talon
did i fuck it up
odd heath
limber skiff
updater works
austere talon
doesnt for me
austere talon
why is this still old commiot
oh it isnt
but updater no work for me
it says up to date
kindred tree
worked for me
odd heath
yop
charred monolithBOT
chrome coral
should I bump extension
ill bump you off a cliff
jolly egret
LMAO https://canary.discord.com/channels/1015060230222131221/1026515880080842772...
incredivle
we pushed strict csp
austere talon
indeed
odd heath
i was gonna say
austere talon
okay updater worked
odd heath
tenor seems like something we should allow
fossil inlet
it's what discord uses lol
austere talon
why tf are u using shit from tenor as background 😭
retarded
you're adding so much lag by using 30mb gifs
fossil inlet
charred monolithBOT
chrome coral
tenor seems reasonable
odd heath
@austere talon vveev you should prolly make venbot sticky for that stuff everyone is gonna come about it
or at least a command
chrome coral
vsticky
limber skiff
genuinely useful not lying
jolly egret
ehh
austere talon
all the background theme goblins gonna come crawling out of their holes
gonna be a fun time
jolly egret
tessie time
fossil inlet
give your git token to venbot then just run shell commands
@austere talon allow tenor for banger gif
people will copy and paste from their favorites
chrome coral
@austere talon you should probably update #theme-support in regarding allowed image hosts for themes, well and put something in #🎨-theme-development
austere talon
give your git token to venbot then just run shell commands
yop
I'm gonna whitelist the top 3
fossil inlet
oh, the top is just pintrest
chrome coral
what is a alphacoders
