#👾-core-development

1 messages · Page 249 of 1

limber skiff
austere talon
#

are u testing that PR

#

i think it can be merged it looks good based on skim

limber skiff
#

yeah

#

I'm testing it

austere talon
#

it changes switch colour here

image.png
#

do we want blue or green

#

blue is what discord also uses

#

but the green was better imo

fossil inlet
#

what does discord use as default

austere talon
#

it uses blue

fossil inlet
#

tbh should be kept like that

charred monolithBOT
fossil inlet
#

will be more in-line with custom themes

glass jasper
#

Actually would be a banger idea

austere talon
#

vext

nimble pendantBOT
austere talon
glass jasper
fossil inlet
austere talon
#

ignore settings jumpscare

limber skiff
#

oh hell nah

glass jasper
#

I can do that

austere talon
fossil inlet
#

have fun learning lottie blobcatcozy

austere talon
#

is it even lottie? or gif

glass jasper
austere talon
#

it's lottie yop

fossil inlet
austere talon
#

that PR look good to u nookies?

limber skiff
#

where does this even apply

#

I looked at typing users now and it doesnt have any wrapper element inside?

charred monolithBOT
fossil inlet
#

does he know how github works

limber skiff
#

nvm found it

charred monolithBOT
limber skiff
charred monolithBOT
limber skiff
#

all good

fossil inlet
limber skiff
#

just rename the PR to something more specific

austere talon
#

stupid google will review RN

limber skiff
#

I'll review better folders one

charred monolithBOT
austere talon
#

we should add vencord category to the app launcher

image.png
#

like inbuilt commands

#

would be fire

fossil inlet
#

insane

#

i have that thing hidden with css

austere talon
#

oh yeah we also really need to integrate it into settings search 😭

limber skiff
#

@fossil inlet did they change this recently lol

image.png
#

I dont remember better folders needing to be rendered in another place

#

unless I have bad memory...?

fossil inlet
#

we should be keeping the conditions anyway

#

the /g just applies it to both

limber skiff
#

yeye I get it

#

let me test it and try to simplify a bit

fossil inlet
#

alr

charred monolithBOT
limber skiff
#

is the grid really needed?

fossil inlet
limber skiff
#

but what is the issue?

#

ahhh

fossil inlet
limber skiff
#

to align with the titleBar and stuff?

austere talon
#

should we merge to main for now

#

so we have the plugin fixes out

limber skiff
#

nah just wait a bit

#

BetterFolders seems almost good to merge

fossil inlet
austere talon
#

when are we getting WorseFolders

limber skiff
#

what issue does it fix

#

what is the grid needed for

#

align here?

image.png
#

swap the order?

fossil inlet
#

did discord change something wires

give me a second

limber skiff
#

which one

#

😭

#

sadan it's all working

#

I just wanna know what issue it fixes lol

fossil inlet
limber skiff
#

lmaooooo

#

okay, that makes sense

fossil inlet
#

i thought you meant you removed the css and there was no issue 😭

charred monolithBOT
limber skiff
#

nitpicks, looks good otherwise

charred monolithBOT
#
Nuckyz
[Vendicated/Vencord] New review comment on pull request #3314: BetterFolders: Fix for visual refresh 
/* These area names need to be hardcode. Only betterFoldersSidebar is added by the plugin. */
.visual-refresh .vc-betterFolders-sidebar-grid {
    grid-template-columns: [start] min-content [guildsEnd] min-content [sidebarEnd] min-content [channelsEnd] 1fr [end]; /* stylelint-disable-line value-keyword-case */
    grid-template-areas:
        "titleBar titleBar titleBar titleBar"
        "guildsList betterFoldersSidebar notice notice"
        "guildsList betterFoldersSide...
limber skiff
#

a bit more

#

hardcoded*

fossil inlet
#

discord uses now uses blobcatcozy

image.png
limber skiff
#

lol

#

that one is annoying

fossil inlet
glass jasper
fossil inlet
#

someone doesnt know how jsx works

glass jasper
#

Trust

austere talon
charred monolithBOT
limber skiff
#

just that it's a good amount of icons

fossil inlet
austere talon
#

you will use ai refactor

limber skiff
#

@fossil inlet do my changes in better folders pr

charred monolithBOT
limber skiff
#

I will update the icons

fossil inlet
#

im already half done 😭

limber skiff
#

oh

#

alr

#

I will do the better folders changes for you

fossil inlet
#

tyyy

limber skiff
#

which isn't so important

#

however why is the code for the plugin so hard to read

austere talon
#

waiting...

fossil inlet
#

not sure what the state of that is because isnt it trying to support pre visual refresh

limber skiff
limber skiff
austere talon
#

it did it right but it didn't scan the codebase properly, only the current file

image.png
limber skiff
#

I think they just nuked the pre visual-refresh

austere talon
#

this is fire

charred monolithBOT
austere talon
#

yeah it worked

fossil inlet
austere talon
#

stupid piece of shit changed the viewBox in one file

image.png
#

okay now this is impressive

image.png
dusk blaze
austere talon
#

AI better than you

fossil inlet
austere talon
#

husk why did you put it here

image.png
#

put it in the function declaration

austere talon
austere talon
fossil inlet
#

but i guess its good enough for very simple things like this

austere talon
#

looks right, right?

image.png
#

yop

charred monolithBOT
limber skiff
#

yeah

#

is that all?

charred monolithBOT
fossil inlet
#

@limber skiff discord only needs 3

image.png
limber skiff
#

titleBar comes from Discord css right?

fossil inlet
#

we need to add an extra to keep things square

limber skiff
#

yeah

#

but I mean that the names are hardcoded

#

I will clarify

charred monolithBOT
fossil inlet
#

thats why i said techinally blobcatcozy

limber skiff
#

actually it's already clarified

#

the css is done by us, but the area names are hardcoded to work with discord css

#

so all good

fossil inlet
austere talon
#

techinally

fossil inlet
#

i cant spell for shit blobcatcozy

clever sierraBOT
#

Hey @fossil inlet! Just a heads-up on the spelling: it's actually "technically," not "techinally."

Think of it this way: the root word is "technical," and you're adding "-ly" to make it an adverb. So it should keep all the letters from "technical." "Technically" describes how something is done or is true, according to a specific set of rules or standards.

charred monolithBOT
limber skiff
#

I want to use it blobwob

fossil inlet
limber skiff
#

the normal colors suck

fossil inlet
#

client theme code confuses me too much blobcatcozy

austere talon
#

jumpscare 😭

image.png
#

ALT

limber skiff
#

ehhhh

#

it doesn't seem too right

#

lol

#

the third theme changes too

#

nvm

#

the color is right

#

guess I'm just not used to visual refresh

fossil inlet
#

does anyone know what causes this

i can repro, but only sometimes

#

||thanks broken kde clipboard manager||

#

GUHHHH HOW DID I MISS THIS

image.png
#

minor visual issue my beloved

charred monolithBOT
limber skiff
#

ehmm I will try to just add what is need to ClientTheme and have it work with old UI

#

however this plugin needs a rewrite in the future

#

🧍‍♂️

#

text got darker

#

ahh

#

mb

charred monolithBOT
odd heath
#

peek_mystic may I ask for a review of my latest or if you're already doing stuff perchance

#

Wtf is thatg emote

#

I wanted this

jolly egret
austere talon
#

im gonna work on fixing the theme flickering shit

hollow musk
fossil inlet
#

also i cant repro rn no matter what i try

hollow musk
#

i need to try

fossil inlet
#

do you have some text that will cause it

hollow musk
#

wait i have an idea

hollow musk
austere talon
#

it's either that or patch webpack but I think MutationObserver is simpler

#

and not every style tag might be added by webpack

#

@limber skiff what do you think

limber skiff
#

ya

#

seems good

fossil inlet
limber skiff
#

I dont exactly know what causes the issue

#

for flickering

austere talon
#

discord somehow makes it reparse the document I think?

#

idk how they achieve that but

fossil inlet
#

that level of shitcode is impressive blobcatcozy

austere talon
#

the flickering is cause it reapplies style and themes are loaded asynchronously

hollow musk
#

@fossil inlet it happens only if you set .container_c8ffbb to have a min-width of none, which kinda makes sense i guess, but it still doesnt make sense when it is forcing the width to change

austere talon
#

that's what I assume

austere talon
#

and I'm gonna put some data property on our styles

hollow musk
#

wait also, it anyone experiencing an issue where discord randomly decides to become blank until you press ctrl+shift+i (open devtools) then it goes back to normal? it ocassionaly happens, ill see if i can get a vid

fossil inlet
fossil inlet
hollow musk
versed fern
#

i messed around awhile ago with trying to fix the theme flickering and came up with a hacky fix by just removing ThemeStore.addChangeListener(initThemes);

austere talon
#

vext

nimble pendantBOT
austere talon
#

guhhh

fossil inlet
#

vext

nimble pendantBOT
hollow musk
#

vext

nimble pendantBOT
austere talon
#

so the reparsing is cause of ThemeStore

versed fern
#

yeah

#

some buttons are causing ThemeStore to update now for some reason

austere talon
#

well i'm just gonna do this then

image.png
#

thanks for saying that, good find

charred monolithBOT
austere talon
#

should we merge main?

austere talon
fossil inlet
limber skiff
#

yeah

#

let me review that one real quick

#

okay ehhh this one looks bad

image.png
versed fern
limber skiff
#

another one which adds a class? surely there's a better way

austere talon
#

avoid matching brackets like that

#

so bad

austere talon
#

putting it in document element is bad

fossil inlet
limber skiff
#

just edit the css

#

I mean

fossil inlet
#

wait, im stupid

#

its a div

limber skiff
#

if you are just adding the class you can just do css with [class^="folderIcon"]

#

but

fossil inlet
#

i can just pass style directly

limber skiff
#

this should only remove the margin if it is actually empty lol

#

not always 🧍‍♂️

austere talon
#

managed style moment

fossil inlet
limber skiff
#

you are applying that to better folders sidebar too

fossil inlet
#

oh

limber skiff
#

do the style directly

#

and check for isBetterFolders

fossil inlet
#

should be better now

austere talon
#

make sure to push to main once that's done (but don't bump version cause we can't yet)

#

im gonna go to bed soooon

fossil inlet
#

gn blobcatcozy

austere talon
#

guhhhh not yet

charred monolithBOT
limber skiff
#

wrong reply

#

I'm so smart

charred monolithBOT
hollow musk
#

vext

nimble pendantBOT
charred monolithBOT
fossil inlet
#

i still dont understand how rebasing works so i always merge toll

limber skiff
hollow musk
limber skiff
#

@fossil inlet say chrome extension users need to wait

#

vtest

nimble pendantBOT
fossil inlet
nimble pendantBOT
nimble pendantBOT
limber skiff
#

thanks for the fixes!

#

someone needs to make the bottom user menu smaller

#

it's so damn big compared to the rest of app, why

glass jasper
idle fossil
#

idk where i'd ask this but do you guys think it's possible to make discord use a faster encoding preset for streaming?

#

it uses like 20% of my gpu video encode at 720p30 lmfao

#

obs can do double the pixels at veryfast nvenc with ~15% usage

charred monolithBOT
hollow musk
#

vext

nimble pendantBOT
charred monolithBOT
fossil inlet
#

INSANE

#

he didnt even manage to get the devs constant right

charred monolithBOT
charred monolithBOT
glass jasper
glass jasper
glass jasper
shut vineBOT
#

@fossil inlet, <t:1743740054:R>: …

carmine wave
#

just started doing this and things started crashing blobcatanki

charred monolithBOT
fossil inlet
#

(if react fails to find we're fucked anyway blobcatcozy )

#

and so far core vencord works fine

#

im going to enable every plugin until they all dont crash blobcatcozy

charred monolithBOT
fossil inlet
fossil inlet
charred monolithBOT
glass jasper
#

Am I geeked? Isn’t there a big thread for read me assets

#

Got it

#

Hate github search

charred monolithBOT
charred monolithBOT
glass jasper
#

@jagged reef

charred monolithBOT
charred monolithBOT
#
jamesbt365
[Vendicated/Vencord] New comment on pull request #3355: New Plugin: WeatherPeek

This doesn't have any use really? Use actual weather widgets instead of packing your chat application with every non chat related feature?

#2957, a plugin that added RPC for weather was denied for simply just having no use either, Weather information has no place in this client mod.

This also goes against the plugin submission rules as you are using DOM manipulation.

Also, your git skills are lacking a lo...

dusk blaze
#

@jagged reef do you write image tags by hand 😭

desert cosmos
#

did they open a separate pr for changing dev constants

#

their other pr wasn't even merged yet

jolly egret
#

they are not good at git in the slightest, they have 7 patch branches, 4? of which add them to the dev constants, one which I think is a stolen plugin and then whatever else

#

apparently they don't know how to add more than one file to a branch via github's website

desert cosmos
#

insane

charred monolithBOT
dusk blaze
#

@white crescent should i

bI2W3Kn.png
white crescent
gritty canyon
#

lazy ass

hollow musk
#

vext

nimble pendantBOT
charred monolithBOT
charred monolithBOT
austere talon
#

vext

nimble pendantBOT
limber skiff
#

gotta wait for the whole weekend now

austere talon
#

surely they can find some hyper teens or whatever who will review on the weekends

#

or use ai to review

limber skiff
#

but I guess don't they dont lol

limber skiff
#

ughh this menu is still so huge

#

I hate the new bottom user menu

fossil inlet
#

vext

nimble pendantBOT
scenic brook
#

Polling vext when

jagged reef
fossil inlet
jagged reef
fossil inlet
fossil inlet
jagged reef
charred monolithBOT
fossil inlet
#

@limber skiff yea I also noticed this last night

glass jasper
#

Me clicking the first image

long stream
charred monolithBOT
charred monolithBOT
opaque silo
austere talon
#

what

#

not even a grammar related change

jagged reef
glass jasper
#

Also think it’s just the difference in simplified vs traditional English

charred monolithBOT
versed fern
#

didnt someone already try to submit this exact same thing?

charred monolithBOT
charred monolithBOT
charred monolithBOT
shut vineBOT
#

@fossil inlet, <t:1743740374:R>: make userpluign to make ctrl-enter-send defaults sane on reporter build

charred monolithBOT
glass jasper
jagged cloak
#

insanity

#

lemme guess fake monkeypatching

charred monolithBOT
glass jasper
charred monolithBOT
fossil inlet
#

this shit wont even compile 😭

jagged cloak
#

(bro did not try it)

scenic brook
#

People on a tear with bad PRs this weekend

brazen bone
#

If we want to give them the benefit of doubt

charred monolithBOT
granite wharf
#

It seems like they don’t know how things work when it comes to this pr

#

they also include a folder path in their pr like that’s not obvious enough

gritty canyon
granite wharf
#

well quite literally everything xD

gritty canyon
#

its kinda funny that they added themselves to the devs constant but also forgot to actually commit the changes to the constant

granite wharf
#

by 2026 100% of vencord plugins will be generated using llvms

gritty canyon
#

yeah i already generate all my vencord plugins using cursor.ai

#

i vibe code them

brazen bone
granite wharf
#

the guy apparently didn’t even check if it compiled

brazen bone
#

But they said they did

#

You think they'd just go on the internet and tell lies?

granite wharf
#

anyways there’s been an increasing amount of AI plug-in prs

#

even my projects have been getting llvm generated prs 😭

#

man

gritty canyon
charred monolithBOT
brazen bone
#

Why does it have a separate toggle rather than just toggling the plugin

charred monolithBOT
hollow musk
#

wonder if it is AI again

scenic brook
#

Just inspect element tbh

hollow musk
#

why would you go through the trouble if you have a plugin for it blobcatcozy

jolly egret
charred monolithBOT
gritty canyon
#

well its still a security measure and we probably rather have people get logged out than lose their account even if its because they were stupid

white crescent
hollow musk
austere talon
#

vext

nimble pendantBOT
austere talon
#

google.....

charred monolithBOT
austere talon
latent lagoon
#

🔫 always have been

charred monolithBOT
austere talon
#

there's only something wrong with them when you spam a lot of them or make some random meaningless change just to get contributor

hollow musk
charred monolithBOT
charred monolithBOT
dusk blaze
#

or embrace the new UI

jagged cloak
#

u have to feed it chunks of discord code to properly do it

#

or else u get garbage in garbage out

austere talon
#

@grizzled halo check this out

#

its like bonzibuddy

charred monolithBOT
austere talon
#

the official name is guild not server 🤓

opaque silo
#

vee so dumb

#

smh

charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New branch created: fix-vc-narrator
gritty canyon
#

branch? whats that?

#

you should start force pushing to main

charred monolithBOT
austere talon
#

i hate this so much

image.png
#

Object.groupBy(arr, fn) instead of arr.groupBy(fn) just because the latter would break existing websites because people are insane enough to pollute array prototype

opaque silo
austere talon
#

branded chromium possibly uses online voices (api)

#

unbranded / offline chromium can use either espeak or speech-dispatcher

dusk blaze
austere talon
#

actually

#

speech-dispatcher is an abstraction

espeak is one possible backend for it

#

let me try festival instead of espeak

jagged cloak
#

how many espeak voices are there

#

cause this is kinda useless rn

image.png
austere talon
#

the PR fixes that

austere talon
austere talon
opaque silo
#

thats why I asked what they used

#

thought maybe they directly used the espeak service and did the voice processing themselves

dusk blaze
#

works @austere talon

image.png
opaque silo
#

nin0 is infected with windows

dusk blaze
#

back to opensuse tumbleweed

jagged cloak
#

infwindows

austere talon
#

idk how to get festival to work

limber skiff
#

because everything could already be a polluted prototype method

charred monolithBOT
austere talon
#

if a change breaks any of those sites it can't be made

fossil inlet
austere talon
#

there was a google blog about this stuff

#

i cant find it rn

jagged cloak
#

smooshgate is funny as hell of a name

#

lol

jolly egret
#

also they are making the same code quality mistakes over and over

glass jasper
charred monolithBOT
jolly egret
#

v+ prog @rich arrow

jolly egret
# jolly egret v+ prog <@691517398523576331>

Lets just get over this, please stop submitting plugins like this, there are serious implications or straight up neglience against the plugin rules every time you submit atp.

Whilst your submission here doesn't seem to be against the plugin rules this is... terrible and I wouldn't be surprised if this was AI slop.

If you're doing this to get yourself on the dev constant, turn around and leave, its not that exciting and bothering maintainers with plugins like this is not gonna cut it, you are just pushing meaningless or otherwise useless plugins to vencord

Skimming through your plugin this time:

  • you are once again using regex when you shouldn't be because:
    • you can avoid it entirely!
    • you are running regex for no reason across every message (for no reason)
    • you are compiling regex for every mention
  • Notifying when friends send messages is just... what??
    • You're asking for a fuck ton of notifications for every message because theres not even cooldown logic to prevent that
  • the mentions setting is just... useless as you get notifications anyway?
  • Notifying for direct messages is useless, because once again you get notifications for this anyway
    • Ontop of this, you don't check if its a dm request, which are otherwise silenced
  • most plugins use a logger and don't just print stderr
  • relying on the user store is not a great idea, not everyone is cached.
  • member avatars are ignored and i'm not even sure if that'll use the default discord ones as a fallback?

Also, this doesn't even consider that you should be patching the default handler for this so you can rely on discord logic and stay consistent, alongside straight up just not duplicating notifications, don't reinvent the wheel, especially when it ends up just being a poor imitation

The code quality here is terrible and this is done in a really bad way and not properly at all.

#

Everything about this plugin is bad

#

and just not thought at at all

jolly egret
#

also i didn't even mention the lack of ping sound you're gonna get, which you know, some might like

#

¯_(ツ)_/¯

#

Like, some of this can just be taken as inexperience, but that doesn't excuse the negligence on your other PRs and the serious lack of code quality on this one

charred monolithBOT
jolly egret
#

Like, i really just wanna take this as inexperience but you're making that basically impossible to do without me twisting whats been put out infront of me

jagged cloak
#

are they genuinely more than just a badge/contrib goblin though

#

didnt look into it cause idc bleh

opaque silo
#

ma discord roles

charred monolithBOT
charred monolithBOT
#
mamasch19
[Vencord/Vencloud] New comment on issue #48: Change the docker-compose.yml to have stack.env instead of .env so it works with Portainer

I'm currently running Vencloud without any problems with Portainer.
This is my compose file if you need reference:

services:
  redis:
    image: redis:alpine
    restart: unless-stopped
    volumes:
      - redis-data:/data
    environment:
      REDIS_ARGS: --save 300 1 60 10
    healthcheck:
      test: ["CMD", "redis-cli", "ping"]
      interval: 5s
      timeout: 5s
      retries: 5

  backend:
    image: ghcr.io/vencord/vencloud:v0.0.1
    restart: unless-stopped
    env_file:
 ...
jagged reef
charred monolithBOT
glass jasper
charred monolithBOT
charred monolithBOT
shell shuttle
#

it's tweaking out 😭

glass jasper
#

What

#

I hate that

#

Eww

shell shuttle
jagged cloak
#

bro does not know troller

charred monolithBOT
left sequoia
grizzled halo
#

has the fixes after the 1.11.8 bump been submitted for the chrome extension?

#

vext

nimble pendantBOT
grizzled halo
#

or does this mean it hasnt

spice python
grizzled halo
#

Makes sense

odd heath
grizzled halo
#

k, good to know

odd heath
#

So we'd have to push another tag

#

(as in, if support users get annoying, you annoy vee or nuckyz over pushing another tag)

charred monolithBOT
dusk blaze
turbid hatch
#

oops

charred monolithBOT
charred monolithBOT
austere talon
#

@limber skiff btw ur ClientTheme changes are not right

#

its completely different than before xD

#

very jarring

limber skiff
#

I copied how the original PR did it

#

and just un did the changes that removed old support

austere talon
#

maybe thats why

limber skiff
#

don't think so

#

but yeah I did notice it looks kinda weird

austere talon
#

either way it's completely different

#

on my colours it straight up has very different background colour

limber skiff
#

u can try commenting the lines for light mode fix and the overrides for non visual refresh colors

#

but I don't think that's gonna fix anything

austere talon
#

doesnt

charred monolithBOT
#
CodiumAI-Agent
[Vendicated/Vencord] New comment on pull request #2136: feat(plugin): Remix

PR Reviewer Guide 🔍

Here are some key observations to aid the review process:

<table>
<tr><td>⏱️ <strong>Estimated effort to review</strong>: 4 🔵🔵🔵🔵⚪</td></tr>
<tr><td>🧪 <strong>No relevant tests</strong></td></tr>
<tr><td>🔒 <strong>No security concerns identified</strong></td></tr>
<tr><td>⚡ <strong>Recommended focus areas for review</strong><br><br>

<details><summary><a href='https://github.com/Vendicated/Vencord/pull/2136/files#diff-6785c712e7d76315188830be749d849...

glass jasper
fossil inlet
glass jasper
long stream
#

which is annoying because that's the most pointless thing they added

glass jasper
#

Zamn

austere talon
#

did they fix it making web unusable...

brazen bone
#

What's deep links?

still maple
gritty canyon
#

which has the side effect of vesktop trying to open the app every 5 seconds

fossil inlet
#

weird, discords bundler didnt strip HMR from the intl system

image.png
charred monolithBOT
left sequoia
#

latest update is giga fucked

jagged cloak
#

okay deleting update.exe now

#

jk (ik it does nothing)

austere talon
#

genuinely kys discord

charred monolithBOT
austere talon
#

Discord once again deliberately breaking features on Web to push you to use their Desktop app

#

what's new

charred monolithBOT
austere talon
#

so we can detect violations in themes and show a card with instructions how to fix

jolly egret
#

i wonder how many themes that would actually break

glass jasper
#

Alot of personal themes ik that much

desert cosmos
#

i still dont see the point of csp restrictions if youre able to modify them with third party plugins

austere talon
fossil inlet
desert cosmos
#

yop exactly

austere talon
#

? ? ? ? ? ?

desert cosmos
austere talon
#

it's not about preventing third party plugins from doing things

#

the point of CSP is to limit how much can be done with XSS

#

and without CSP, themes technically carry risks

#

from less severe risks like ip logging to more severe ones like the fact that themes are actually able to keylog you

#

CSP also ensures we can never accidentally fetch remote urls (like if a plugin has a bug)

desert cosmos
#

but yeah I guess there are more positives to this than negatives

charred monolithBOT
austere talon
#

honestly we should just merge this and see probably

charred monolithBOT
austere talon
#

Equicord Devs might cry when they see this change

#

you will review pr

fossil inlet
austere talon
#

who knows

#

figured

image.png
fossil inlet
#

nest.rip husk

austere talon
#

you love

fossil inlet
#

is the API for plugins to add their own domains to CSP written yet?

#

i couldn't find anything in the pr

austere talon
#

the api in question:

// native.ts
import { CspPolicies } from "@main/csp";

CspPolicies["malware.com"] = ["connect-src"];
fossil inlet
#

love

charred monolithBOT
dusk blaze
#

trolley

fossil inlet
#

nin0 insane

dusk blaze
#

the jogn meyer experience

#

i will make CSPDisabler @fossil inlet

#

user friendly settings to arbitrairily edit csp

dusk blaze
#

now that i think of it how would plugins whitelist themselves on web

austere talon
austere talon
#

this is only for desktop

dusk blaze
#

insane 😭

#

oh wait does vencord web enforce strict csp

charred monolithBOT
austere talon
fossil inlet
#

or am i insane

austere talon
#

we dynamically edit the header

dusk blaze
#

ih

#

i am an idiot

austere talon
#

manifest v3 header manipulation is via json file not code

#

you can't do dynamic shit like this

#

the extension just nukes the header

fossil inlet
#

insane

austere talon
#

the desktop app also just nukes the header right now

#

that's what this pr changes

#

well it actually doesn't nuke

but close to it

#

cause it allows so much

dusk blaze
#

okay so i can still make ip grabber theme for web users

austere talon
#

now only whitelisted stuff is allowed

charred monolithBOT
fossil inlet
#

wonder if it would be possible to add csp issues and other theme info to some kind of /vencord-themes command

austere talon
#

yes but not really necessary imo lol

fossil inlet
#

does the csp block anything other than ip logging css wires

austere talon
#

i dont get that question

#

it blocks connecting to any third party sites in any way

hollow musk
#

to be fair, most put it on github, its just those who think they are special dont

austere talon
hollow musk
opaque silo
#

self hosted git forgers sobbing

glass jasper
dusk blaze
charred monolithBOT
charred monolithBOT
jolly egret
#

stuff like this should be extended to invisible chat and other plugins that currently rely on the message content when they shouldn't but i didn't really wanna rip through all the vencord plugins for this

brazen bone
#

What's this ; for

image.png
scenic brook
#

Someone probably just left a semicolon in their jsx by accident, I've done it plenty lol

#

Can you find it in react dev tools

brazen bone
#

Don't have that on this machine

scenic brook
#

Big brain discord

image.png
long stream
#

not the first time they've done this blobcatcozy

fossil inlet
scenic brook
austere talon
#

when the crappy new feature they added to deliberately make the web app less functional is not just crappy but also sloppily coded

limber skiff
#

why does that have a displayName 😭

long stream
#

they re-added displayname to random components recently iirc

fossil inlet
#

I will copy more of them to my demangler plugin in case they ever remove

austere talon
limber skiff
#

trueeeee

charred monolithBOT
fossil inlet
#

I tested with viewicons and the spotify player plugin and they both worked fine

#

also only on canary rn, but should be good for stable(haven't tested) because it's just using the new image modal

charred monolithBOT
jolly egret
#

fire

hollow musk
granite wharf
#

free stats on profile

versed fern
#

do people really care about github stats?

hollow musk
#

that one homer simpsons meme

I contributed to Vendicated/Vencord
looks inside
fix typo

fossil inlet
hollow musk
fossil inlet
#

tbh if it's fixing a genuine typo i think there's nothing wrong with it

whenever i find a typo in docs im reading, if i have time, ill pr a fix

austere talon
#

^

#

only if it's obvious contribution farming

#

like some person pring typo fixes to dozens of repo

#

or rewording random shit that was fine

charred monolithBOT
dusk blaze
#

virus

charred monolithBOT
still maple
#

this would be so nice to have instead of having to hack around with the custom type

odd heath
#

i tried

#

its not hard to do

#

takey like

#

2h of effort

still maple
#

yeah but annoying

jolly egret
#

just leave it open somebody can rebase at a later date

charred monolithBOT
shell shuttle
#

was there something that said like

#

"if your pr goes stale for over a month or 2 you can ping a maintainer"

#

or am i tripping

odd heath
#

discord added better resources in the meantime

#

just remaking it at some point is better

#

so why leave it open

#

half is bugged and half is shit so

jolly egret
charred monolithBOT
limber skiff
#

I'll review the other at home

#

vext

nimble pendantBOT
austere talon
#

we should remove plugins like NoRPC and similar

#

people are too stupid and enable them then wonder why stuff doesn't work

odd heath
fossil inlet
opaque silo
fossil inlet
gritty canyon
#

what is even the point of norpc?

scenic brook
#

no rpc

jolly egret
#

isn't that basically just turning off activity sharing

charred monolithBOT
#
mufaroxyz
[Vendicated/Vencord] Pull request opened: #3372 Experiments: Support new experiment link embeds & fix outdated patch

Discord added a new embed when sharing an experiment link (hidden behind isStaff flag):

image

So I added support to it (It's not available on stable yet). Also, visual refresh broke the patch for replacement of ? toolbar button so I fixed the patch to find the correct element. Additionally updated how Mac is being detected in plugin settings as it was using a deprecated navigator.platform API and mov...

granite wharf
charred monolithBOT
shell shuttle
#

even if its one ping i lowkey dont feel too confident about asking straight up

fossil inlet
limber skiff
#

w song

woeful sleet
limber skiff
#

okayish feature

#

song more banger

#

(jokes)

fossil inlet
# limber skiff song more banger

oh, while i was recording the video, i noticed that i stopped recording right before the song says but you didn't have to cut me off 😭

part of me wanted to re-do it to get the timing right blobcatcozy

limber skiff
#

😞

jagged reef
scenic brook
#

I don't really see the point in bumping anything unless there's currently reviewing going on, there'll probably just be a force push that fucks up all the recent activity sorting anyway lol

woeful sleet
#

Worked for manti 🤷‍♂️

inland fable
limber skiff
#

didnt have time to review the patch fixes ayer, I will do it later today instead

charred monolithBOT
dusk blaze
shell shuttle
shell shuttle
austere talon
#

sadan finally discovered good music

jolly egret
#

still didn't discover muting his music while recording videos

austere talon
#

no he did for a while

#

well i forced him to

#

venbot sadan video muter return soon

#

oh yeah he bypassed it I remember

#

I restricted it to a very specific content type cause I didn't want him to find some obscure format that will give ffmpeg RCE (probably doesn't exist but still) so he just changed format

limber skiff
#

😭

fossil inlet
austere talon
#

well i just didn't want shenanigans

#

some formats are crazy

fossil inlet
#

also if i cared enough, i'd just use that eval bug instead of telling you toll

austere talon
#

that's why i restricted it

shell shuttle
#

veval

austere talon
fossil inlet
austere talon
#

the perfect backdoor is one that doesn't exist: it can never be found and can never be patched

fossil inlet
austere talon
#

SCARY

jolly egret
woeful sleet
#

Just take away embed perms NODDERS

scenic brook
#

I got threatened with video muter too 🤘😔

fossil inlet
dusty finch
charred monolithBOT
austere talon
#

vtest dev

nimble pendantBOT
nimble pendantBOT
nimble pendantBOT
austere talon
#

smh sadan making the BetterFolders patch slow || /s ||

fossil inlet
#

@austere talon lol i was just about to run reporter on my prs

charred monolithBOT
austere talon
#

i wanna get that pr merged before we make 3 morbillion changes again

charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New tag created: v1.11.9
fossil inlet
#

tbh i might make a top bar remover plugin that handles the buttons there

grizzled halo
#

Discord is looking into removing the title bar

austere talon
#

really?

#

i think the titlebar is not bad but

  1. showing it on web is awful
  2. cramming random buttons in it sucks
fossil inlet
austere talon
#

yes

#

those arent a problem with the titlebar itself

#

just their poor implementation

#

fix those things and no one really cares

#

no one ever minded the old titlebar

fossil inlet
#

yea becasue it took up less space and you could use the native titlebar if you wanted to

austere talon
#

only with vencord lol

fossil inlet
#

yea. it might come as a shock, but i use vencord

austere talon
#

if discord doesnt remove the new titlebar we should update vencord / vesktop

#

to allow disabling it again

#

but for that we have to move the fucking inbox and help button down

#

probably gonna be pain lol

fossil inlet
#

thats the plugin idea i just gave 😭

austere talon
#

yeah but

#

it's a core setting

#

so not really a plugin

#

a core plugin i guess

#

or part of the settings plugin

#

make

fossil inlet
#

ok

austere talon
#

but if they wanna remove it maybe dont

#

waste of time

fossil inlet
# austere talon make

make is not recognized as an internal or external command, operable program or batch file

austere talon
#

how do u not have make installed

#

fucking weirdo

#

also why u on windows

#

arent u supposed to be tweaking ur nix configs rn

fossil inlet
austere talon
#

HOW

#

how does ur laptop not support linux

#

theres arm linux u know

#

dont tell me it's arm32

fossil inlet
austere talon
#

wdym?

#

like weird proprietary hardware that's not supported on linux?

fossil inlet
#

no display output beyond grub, no keyboard or mouse input even in grub

austere talon
#

u sure there's not some chinese guy repo on github with 12 stars that has a working driver

fossil inlet
#

usb doesn't work

austere talon
#

how..

#

wtf kinda laptop is that

fossil inlet
fossil inlet
austere talon
#

idk hop on fedora or smth surely it works ubuntu just has skill issues

long stream
fossil inlet
charred monolithBOT
austere talon
fossil inlet
#

looking in random places and wtf is this

image.png
austere talon
#

that memo is fire

#

maybe bundler removed some code?

#

lmao

#

how tf did their bundler not nuke that entire function

#

ig it can't know that that memo always returns null cause that's runtime behaviour

charred monolithBOT
nimble pendantBOT
fossil inlet
#

LMAO

#

it didnt even have any audio

#

@austere talon fix

austere talon
#

wrong

#

it did

#

well it had an audio track

#

dm me the video

shell shuttle
jolly egret
#

lmaoo

weak thistle
# austere talon how..

qualcomm (yet again) said they're gonna have first party linux driver support in the kernel and it's now been a year and there's been like no patches from qualcomm so most of the drivers are just community so the only laptop that mostly works is the lenovo x1 smth and even that has problems and doesn't work at all with mainline kernel sillycat

#

tl;dr qualcomm bad

long stream
#

good to know that qualcomm sucks at both corporate and public relations

#
  • fails to provide hardware in time for devs to port to woa
  • only provides buggy hardware that has android quirks still in it to vendors
charred monolithBOT
charred monolithBOT
charred monolithBOT
fossil inlet
charred monolithBOT
jolly egret
odd heath
#

Wha

fossil inlet
jolly egret
#

one thing about the desktop visual refresh (or something around that time) is that they made role icons not appear in compact mode anymore

#

before if you enabled pfps in compact mode it would show the icons, then i could just css out the avatar but they changed the setting and it doesn't work on either anymore

#

so now i'm really debating just making a plugin for restoring it

jolly egret
#

yeah except i have NO idea where to start, don't know how to even find where it renders 🔥

fossil inlet
#

discord will fix their shitcode soon ™️

jolly egret
#

i fix

#

trolling ass patch

image.png
#

no idea why discord removed this ability though?

#

you could get this in the old ui, but they pushed a change that removed it there too

#

if you showed the avatar before in compact mode, you would get it, then you could just css it out but i guess in a rewrite of some logic they removed the ability to have it

#

e is compact
t is displayCompactAvatars
n is roleIconProps
r is idk

function ee(e, t, n, r) {
    return (!e || t) && null != n && null != r ? 1 : (!e || t) && null != n ? 2 : 0
}
#

how a silly fix is to just... patch the input to the function but idk if that is up to vencord standards here KannaSip

#

seems kinda niche to add this as an official plugin especially becuse i'm probably one of the few that actully care that this ability is gone

fossil inlet
jolly egret
#

wow

#

it will never be merged officially

fossil inlet
#

yop

#

small™️ update soon™️

image.png
jolly egret
#

incredible

#

how the hell do i write a decent looking, efficent, resilent regex for this 😭

#

making good patches so hard

fossil inlet