#๐พ-core-development
limber skiff
will look soon
fossil inlet
limber skiff
in the mean time can you try to change the find for PRESS_BADGE
glass jasper
bro reviewed is own pr
jolly egret
well, options
better yourself to provide alternatives if you know something you are doing might not be the best way and you want maintainers to check
glass jasper
Fair
limber skiff
vtest dev
limber skiff
vhelp vtest
nimble pendantBOT
vhelp vtest
Reporter (report, vencord-reporter, test-patches, test)
Run the Vencord reporter workflow
Usage
vreporter [ref = dev] [branch = both]
fossil inlet
Lol
limber skiff
thank you
fossil inlet
@limber skiff if this is true, I'll add an error boundary in case it breaks in the future
opaque silo
<@235834946571337729> i got prs open that fix this when you have time
new venbot feature!! failures get an id and PRs can mention those ids then venbot can link the pr in the embed
fossil inlet
new venbot feature!! failures get an id and PRs can mention those ids then venbo...
what??
fossil inlet
husk
@jolly egret you might want to delete this, its fixed
https://canary.discord.com/channels/1015060230222131221/1344397971802030090
jolly egret
vext
jolly egret
done
idle fossil
what if the chrome extension just pulls vencord from github
fossil inlet
what if the chrome extension just pulls vencord from github <:blobcatcozy:102653...
dont think thats possible
iirc chrome only allows signed extensions
idle fossil
limber skiff
it's a modal tho
fossil inlet
guhhhh somehow crashhandler was disabled
limber skiff
someone mention me
glass jasper
@limber skiff
limber skiff
okay thanks
glass jasper
@limber skiff
glass jasper
@limber skiff
limber skiff
alright done
untold rock
i can't imagine why that would be happening
i don't have anything setup to clear dirs
limber skiff
@austere talon btw you should re-commit this https://github.com/Vencord/Vesktop/commit/e6c1a03c5955f8dff8ed741c59f5c9359afc7887
versed fern
OAuth2AuthorizeModal conveniently broke right when i was trying to use it
hollow musk
<@343383572805058560> btw you should re-commit this https://github.com/Vencord/V...
why push a revert commit when you can rebase and remove it, then force push it
austere talon
why push a revert commit when you can rebase and remove it, then force push it <...
you can maybe do this if no one uses your software
but if many people rely on it, force pushing will break many setups
and I need that commit for later
fossil inlet
i love fixing obscure bugs
glass jasper
but if many people rely on it, force pushing will break many setups
one day we will force push Vencord main
hollow musk
and I need that commit for later
iirc force pushing doesnt remove it from github, you still can checkout the commit and view it in the web if you have the commit hash. github themselves need to do a git gc so you can't view those lost commits
fossil inlet
only on canary rn
limber skiff
๐ญ
that's not how mapMangledModule works
it wont have those properties if you dont map them too
fossil inlet
they mangled it
limber skiff
of course they did
that wasnt meant to still be using byProps
(to avoid this exact issue)
anyways can you map the rest?
limber skiff
also improve the find in mapMangledModule to something more specific
once you have that the other finds for the functions dont need to be as good because it onlys targets that one exact module 
fossil inlet
also improve the find in mapMangledModule to something more specific
is something here good enough
limber skiff
getAssetImage: size must ===
fossil inlet
that's not how mapMangledModule works
guhhh thats not what i meant by the comment
i mean they exist, but werent mapped (they're also not in the type)
fossil inlet
@limber skiff i added the rest of the exports as well as some more types
opaque silo
you used the wrong to in the comment 
fossil inlet
you used the wrong to in the comment <:fr:1024751426750132284>
me when i lie
wait
i didnt see the second one ๐ญ
opaque silo
granite wharf
all my homies hate wumpus but at least hes getting special treatment today..
fossil inlet
me when i have free time and open 4 prs in a day
idle fossil
unemployed software developers clocking into their making 4 prs on open source projects shift
rugged spire
dont think thats possible
it's possible, its technically just a script
it wont get past cws review though
rugged spire
unemployed software developers clocking into their making 4 prs on open source p...
hi
scenic brook
I was using intellij's own psi file formatter before which took anywhere from 4-11 minutes lol
I'm currently using google's closure compiler to format before creating the psi file which takes about 20 seconds
fossil inlet
I was using intellij's own psi file formatter before which took anywhere from 4-...
i think anything is fine as long as its a pretty printer and not a formatter
limber skiff
@fossil inlet is this too hard to type?
fossil inlet
<@521819891141967883> is this too hard to type?
tbh i didnt bother with the retrun type so i just put object
let me see if its easy
limber skiff
also seems like there are 5 methods, not 4?
fossil inlet
also seems like there are 5 methods, not 4?
they removed getAssetIds
coudlnt find it in the new module
limber skiff
okay
fossil inlet
im going to try and type assets quickly
fossil inlet
i ignored fetchAssetIds as it was already typed
limber skiff
seems to be a number and defaults to 1
fossil inlet
but ill also do that
limber skiff
let me try to figure what it is
limber skiff
async function fetchAssetIds(applicationId, assets, n = 1) {
dispatch({
type: "APPLICATION_ASSETS_FETCH",
applicationId
});
let result = [];
let linkAssets = assets.filter(e => e?.startsWith("http:")) || e?.startsWith("https:");
if (
linkAssets.length > 0 &&
await N(applicationId, linkAssets),
A(assets, result)
) {
dispatch({
type: "APPLICATION_ASSETS_FETCH_SUCCESS",
applicationId
});
return result;
}
let fetchedAssets = await T(applicationId);
dispatch({
type: "APPLICATION_ASSETS_UPDATE",
applicationId,
assets: fetchedAssets
});
C(assets, result, fetchedAssets, n) ? y(applicationId).then( () => R(applicationId, assets, n - 1)) : dispatch({
type: "APPLICATION_ASSETS_FETCH_SUCCESS",
applicationId
});
return result;
}
it's kinda weird
hmm
tries is a smart guess
that would work
fossil inlet
it looks like a recursive function with tries
fossil inlet
was just about to say
austere talon
asset names
limber skiff
so it only returns the asset names you choose?
austere talon
it's these
lastfm-large
https urls will give you a mp:// url
which is media proxy
names will give you named assets
limber skiff
so it only returns the asset names you choose?
yes
austere talon
try it and see :P
austere talon
it's these
u can try it with this app 1108588077900898414
limber skiff
I got it already
limber skiff
it takes the result, and maps the keys you specify in order
limber skiff
so for example, here the return result is [embedded_background: string]
weird that it returns an array
but it's basically an object in the form of an array in the correct order
limber skiff
<:wires:1262562427422244874>
that's gonna return nothing
cuz no asset name is called placeholder, right?
unless you made one troll
fossil inlet
limber skiff
either way if you wanna use those
fossil inlet
and ive only seen one type of asset
fossil inlet
do Record<string, any>
this ok or would you rather just stick to any?
assets: Record<string, { id: string; name: string; type: number; } & any>;
that doesn't work lol
{ id: string; name: string; type: number; } & any = any
you wanna do & Record<string, any>
shut vineBOT
@fossil inlet, <t:1740014394:R>: check if discord has rolled back
hollow musk
they would never
fossil inlet
still insane bundler change
glass jasper
they would never
|| Not for 3 more days||
fossil inlet
its so weird because they're still using spreads in functions and arrays
even though object spreads have been around since 2017 on all major browsers
glass jasper
I feel more insane/ weird changes are going to be happening more often with them joining the open market soon
limber skiff
@fossil inlet okay ngl I'm just gonna merge the find fix without the typings
I will do the typings another time, I dont wanna push something which isn't totally accurate but this module is kinda shit to type
fossil inlet
<@521819891141967883> okay ngl I'm just gonna merge the find fix without the typ...
Alr
rugged spire
Average #๐ฅ-vencord-support-๐ฅ users will enjoy this
limber skiff
vtest dev
idle fossil
rugged spire
fossil inlet
what is the point in assigning r to the class that is being extended, when r isnt used anywhere else at all
austere talon
it's probably just discord's code maybe
typescript is weird when doing extends foo.bar
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/spotifyControls/Spot...
SpotifyStore.ts: Lines 70-71
// For some reason ts hates extends Flux.Store
const { Store } = Flux;
SpotifyStore.ts: Line 78
class SpotifyStore extends Store {
weird
discords bundler so cursed / weird
it didnt tree-shake an unused function for some reason
and within that function, is code that will always error
* it wont always error, but it makes no sense
d is unused and PopoutWindowStore is not defined anywhere
it feels like that function only got partially minified
austere talon
thats hilarious
they forgot to import it or smth
so the compiler can't minify it
cause it might be a global
fossil inlet
so the compiler can't minify it
why cant they if d is never used?
isnt that just basic tree shaking, remove functions that are never used
austere talon
no clue lmao
fossil inlet
glass jasper
My vencord [merge request](<https://github.com/Vendicated/Vencord/pull/2239>) is...
ShowBadges has to be getting up there too
idle fossil
cake writer confused af rn
fossil inlet
ill fix
grizzled halo
crashes just after pressing the clone button
idle fossil
what kind of error is it? cuz i know there's testing for patch fails so like what happened
just curious
fossil inlet
what kind of error is it? cuz i know there's testing for patch fails so like wha...
runtime error
not a patch/find failing
eg (null).foo
idle fossil
ohhh so wait like the patch still works just a surrounding function got yeeted
fossil inlet
ohhh so wait like the patch still works just a surrounding function got yeeted
in this case it isnt a patch, but discord chainging their internal API
@grizzled halo is this canary only or also stable?
idle fossil
ic
grizzled halo
stable
fossil inlet
on another note, we really need to have our own discord types
the package being used just gets more and more outdated
fossil inlet
alr, i made it a common in the first place because it was on the guild object, but nothing else uses it 
fossil inlet
@austere talon why cast instead of type
austere talon
because type looks atrocious, especially for arrow function syntax
it's very hard to see on a glance whether it's a type or the real function
cast is much clearer
austere talon
it's very hard to see on a glance whether it's a type or the real function
// type
const func: (guild: Guild) => number;
// actual function
const func = (guild: Guild) => number;
i agree with that, but only when a value is not assigned right away
something like
const func: (guild: Guild) => number = foo(/* ... */);
is pretty clear
rugged spire
cast is not much much better
typing a function is just cursed if there is an actual function being declared
austere talon
anyway it doesn't matter
fossil inlet
yop
rugged spire
fossil inlet
am i crazy here, or is r.hydrateRoot a noop
because the assignment operator takes precedence over the comma operator
(yes getters can have side effects, but why would this code ever be generated in the first place)
jolly egret
why delete the head repo it takes nothing to keep it there 
hollow musk
why delete the head repo it takes nothing to keep it there <:KannaStare:91456999...
couldnt bother
wouldnt do any more pull requests because cant bother to learn typescript
fossil inlet
its just javascript ๐ญ
hollow musk
i sure hope you dont want copilot code in vencord
my javascript experience is just enough to make useable websites
fossil inlet
@hollow musk would you mind if, some time in the future, i picked up the pr
i really like the client theme plugin
hollow musk
<@939370315652415488> would you mind if, some time in the future, i picked up th...
go ahead, not stopping you, anyways someone has to fix it, and if it isnt me, im fine
jolly egret
couldnt bother
you weren't even asked to make changes it was just sitting there with no burden to you, could've just left it
fossil inlet
you weren't even asked to make changes it was just sitting there with no burden ...
no, i understand closing it. you dont want to have it pop up in your mind every so often
idle fossil
the humble public archive:
fossil inlet
and the code is still there if anyone wants to open it in the future
why keep your pr open if you dont plan to do anything else with it respond / be active
idle fossil
oh i thought the code was gone nvm
hollow musk
you weren't even asked to make changes it was just sitting there with no burden ...
its stupid, but usually i want some kind of comment when i made my pr, even if the comment is a 'you suck' or something
but that pr just staying there, no one reacting or being involved just gets me annoyed
usually i would wait about 1.5~ months before deciding to close it
hollow musk
why keep your pr open if you dont plan to do ~~anything else with it~~ respond /...
exactly
commit history is still there btw, github needs to do a git gc on the pr manually to get rid of the history
Vendicated/Vencord #3168 @33c680b
austere talon
maybe the bundler does this cause technically hydrateRoot could be a getter with side effects
lmaoo
fossil inlet
maybe the bundler does this cause technically hydrateRoot could be a getter with...
yea, i mentioned that, but this seems like some generated code
and if its written by hand, i dont think they'd leave hydrate root laying around (linters, etc...)
and if its generated, why include hydrate root
long stream
they were running macos this entire time with no hardware acceleration??
also does the installer seriously have no way to default to software rendering?
that seems really stupid
woeful sable
so, i wanted to know a thing, should this be considered a pull request about vencord core, or a plugin
because, technically i edited the permissions viewer plugin, and added a feature there to make it more usable
fossil inlet
so, i wanted to know a thing, should this be considered a pull request about ven...
Plugin, but you can talk about PRS here as well
woeful sable
Plugin, but you can talk about PRS here as well
oh, thanks
charred monolithBOT
jolly egret
sees 2 comments hidden as spam and 1 deleted
adds yet another useless comment
limber skiff
they are just adding a warning, it's their job
austere talon
๐ญ
charred monolithBOT
charred monolithBOT
Adds a plugin that adds more options to the Clips settings, for FPS and duration. More useful now that Clips can be taken without streaming!
Also adds RPC tagging so that games that you add for clipping but have no icon can adopt the icon of their Rich Presence (this would normally be the [?] icon):
vivid garden
that's gotta be the worst i've ever typoed a PR title holyyy shit
long stream
Plguin ๐ง
glass jasper
that's gotta be the worst i've ever typoed a PR title holyyy shit
nah thats the vencord way
jolly egret
timedones
charred monolithBOT
fossil inlet
?remind 12pm bump a pr
shut vineBOT
Alright @fossil inlet, in 13 hours, 55 minutes and 30 seconds: bump a pr
dusk blaze
?remind 12pm bump a pr
charred monolithBOT
fossil inlet
wasnt that fixed with the esbuild update
glass jasper
hop on w3schools
https://www.w3schools.com/cssref/sel_nesting.php
austere talon
w3schools is crap
hollow musk
shut vineBOT
@fossil inlet, <t:1741485870:R>: bump a pr
charred monolithBOT
long stream
it might have been a throwaway or something
the one commit is by another account that still exists
and has the same pfp
hollow musk
it might have been a throwaway or something
why would you make a throwaway bruh
if your pr didn't get accepted, so be it
glass jasper
why would you make a throwaway bruh
if your pr didn't get accepted, so be it
because if it had got accepted, then both accounts would have Contri
atleast thatโs my best guess
odd heath
love how github is like "these conflicts are too complex to be resolved in the web editor" and then the ide just performs the merge without issue ๐ญ
left sequoia
yeah, then you just press . and click resolve button there
and it just works
wtf gh
median rapids
thats not the web editor smh
odd heath
yeah, then you just press `.` and click resolve button there
i didnt even have to resolve anything i just told my ide to merge dev into my branch
and gh was like
fossil inlet
someone should review https://github.com/Vendicated/Vencord/pull/3272
charred monolithBOT
charred monolithBOT
dusk blaze
charred monolithBOT
dusk blaze
@austere talon contributor/collaborator check when:..
glass jasper
<@343383572805058560> contributor/collaborator check when:..
honestly at this point just close them and make https://bugs.vencord.dev forum
glass jasper
Yall have a hive mind 90% of the time
fossil inlet
why does discord embed a base 16 theme ๐ญ
charred monolithBOT
charred monolithBOT
hollow musk
wonder why he couldnt join the server
(he definitely didnt get banned)
gritty canyon
does the vencord installer have any cli flags or anything to automate installing?
nvm checked the source code ^^ tysm to the person that added them
charred monolithBOT
odd heath
oh peak i got a bug i had once before and managed to record it
like wtf is this shit ๐ญ
hollow warren
Hello !
i need Help
i wanna Create a Client Like Vencord but Named wsmXyz ! wich is Like Vencord but with Differnt Things !
jolly egret
i wanna Create a Client Like Vencord but Named wsmXyz ! wich is Like Vencord bu...
??
what does this have to do with the development of vencord
warped frost
i directed them here because they opened a ticket but i misunderstood what they were saying i suppose
jolly egret
You can fork just fine just follow the software license
hollow musk
i wanna Create a Client Like Vencord but Named wsmXyz ! wich is Like Vencord bu...
i will pray for you and your sanity
fossil inlet
oh peak i got a bug i had once before and managed to record it
Some day I will find the cause of the datastore bug
odd heath
Some day I will find the cause of the datastore bug
im too lazy to test it but i wonder if its related to arrpc being on but not connected
cuz thats what was the only different thing this time and the bug happened 
fossil inlet
can that pr be merged already <:AiriJii:1321611664885551164>
Yop
I also have another PR with another fix open
And a tag should probably be pushed
granite sky
nuckyz and vee are dead. vencord will eol soon ๐
limber skiff
I will merge later today
gritty canyon
would anything break if we did this on line 122 in scripts/runInstaller.mjs?
would allow passing args from pnpm run
(i.e. pnpm run inject -- --install --branch canary to save those couple extra clicks while developing)
fossil inlet
would anything break if we did this on line 122 in scripts/runInstaller.mjs?
wou...
it sounds like a good idea, but i don't think slicing with a constant is the best way to do it.
maybe something like parseargs (would also remove the -- after inject)
glass jasper
bro owns 90% of issues 
/j
gritty canyon
it sounds like a good idea, but i don't think slicing with a constant is the bes...
first time using parseArgs - is this fine or should i define all options?
fossil inlet
first time using parseArgs - is this fine or should i define all options?
id define them so --help works
also it can warn you if you pass something that isnt defined
gritty canyon
fair
fossil inlet
(it might also do types, not sure)
fossil inlet
yea
fossil inlet
only bool and string though
thats the only types it supports lol
its either a flag or arg
gritty canyon
wouldve maybe expected numbers i guess, i neither make nor use clis often enough to know whats standard
fossil inlet
wouldve maybe expected numbers i guess, i neither make nor use clis often enough...
i dont think it makes that much sense when you think about it.
ex: would you parse a leading zero as an octal, do you support base prefixes, what's the default prefix, etc...
charred monolithBOT
Changes the runInstaller.mjs to pass through CLI args.
This would allow for skipping the interaction bit which saves a microseconds when developing a plugin with native functions:
very convenient
fossil inlet
@gritty canyon is that the right screenshot?
gritty canyon
yea..?
fossil inlet
because -- tells pnpm to pass the following cli args to the script
wait, i missed the run
why not just pnpm inject --install --branch canary
gritty canyon
without -- pnpm just eats the cli args
or node... im not sure
something eats them though
fossil inlet
try doing this, then re run it without using pnpm run
- execFileSync(installerBin, args.positionals, {
+ execFileSync(installerBin, process.argv.slice(2), {
fossil inlet
without -- pnpm just eats the cli args
btw, nothing eats the args, pnpm just runs the script, which is just node file.js, so process.argv looks like [node, file.js, ...<rest of args>]
fossil inlet
i am wondering why parseArgs doesnt work without -- then
if i had to guess, pnpm run is a pnpm subcommand, meaning the args are passed to pnpm, not the script, but console.log(process.argv) in the script to find out
fossil inlet
first log is just the args object, second one is process.argv
whats the args object
gritty canyon
args object is what parseArgs returns
fossil inlet
args object is what parseArgs returns
๐ญ
i dont think you're using parseargs properly
fossil inlet
wdym
this is how you use it https://github.com/sadan4/AdventOfCode-kotlin/blob/main/scripts/common.mjs#L49-L61
grave mangoBOT
this is how you use it <:blobcatcozy:1026533070955872337> https://github.com/sad...
common.mjs: Lines 49-61
const options = {
year: {
type: "string",
default: getToday().year,
short: "y"
},
day: {
type: "string",
default: getToday().day,
short: "d"
}
}
const {year, day} = node_parseArgs({args: process.argv.slice(2), options}).values;
why would you use process.argv.slice though when parseArgs returns you the parsed args...
wait i didnt see the node_parseArgs (its midnight and im tired)
fossil inlet
@gritty canyon wait, i dont see you passing the processes args to parseArgs
you have to do that
fossil inlet
hold on, im going to figure this out
gritty canyon
im pretty sure #they dont want you to use args.positionals
fossil inlet
(run the code instead of just staring at it and hoping it will work)
gritty canyon
because args.values is always the same
but you cant use args.values in execFileSync because it expects an array for args (amazing)
gritty canyon
because args.values is always the same
nvm its not either args.positionals works or args.values
who made this
im now just converting args.values into an array or passing args.positionals if they are set, works with and without --
fossil inlet
@gritty canyon i figured it all out
positionals is args that depend on their position
pnpm run inject vs. pnpm inject run
this is what i came up with to do it
gritty canyon
im now just converting args.values into an array or passing args.positionals if ...
this works
gritty canyon
positionals is args that depend on their position
`pnpm run inject` vs. `pnpm in...
i checked and -- is apparently standard unix for marking all following arguments as positional.... and tells node that its the end of node options passing the rest to the script
fossil inlet
i checked and `--` is apparently standard unix for marking all following argumen...
huh, i always thought -- was a kind of end of arguments marker, eg: pass these args onto something else, or treat the rest of the CLI as one arg
gritty canyon
hm
mr stackoverflow took out the guidelines https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap12.html
specifically guideline 10 on section 12.2
gritty canyon
this works
whelp i committed this now ^ (without the console log...) works with and without --
charred monolithBOT
long stream
yipee
charred monolithBOT
grizzled halo
i dont think so because now ive had at least 7 people say the same thing now
i even reproduced it myself
this person is on the latest version too
austere talon
I can't reproduce
it's probably some youtube A/B testing
anyway we just use this https://github.com/AdguardTeam/BlockYouTubeAdsShortcut
reproduce with just their script and if you can, open an issue in their repo
gritty canyon
heavily depends
but im just confused as to why ai users dont tell the ai not to add comments like thats the easiest way to tell if code is written with ai
hollow musk
Don't husk me
not husking you bruh
husk for the ai
gritty canyon
but im just confused as to why ai users dont tell the ai not to add comments lik...
@dawn shore make me a vencord plugin but add a comment on every single line of code please thanks
odd heath
Generating any more than that is just a waste of time tbh
Generating svgs isn't but yeah
Chatgpt is also great at quickly making webpack code more readable, though it's not perfect
gritty canyon
Generating svgs isn't <:trolley:1024751352028602449> but yeah
Chatgpt is also g...
may i introduce you to
https://icones.js.org/
!!
glass jasper
may i introduce you to
https://icones.js.org/
Real mfs use
https://icon-sets.iconify.design/
odd heath
may i introduce you to
https://icones.js.org/
I didn't know about that lmao i just used what I knew off ๐ญ
Thanks
gritty canyon
Real mfs use
https://icon-sets.iconify.design/
vue is the first framework tab.... based
odd heath
Oh wait it's about svgs
gritty canyon
I didn't know about that lmao i just used what I knew off ๐ญ
feel free to spread those around, a lot of people dont know and just get their icons from google as low quality pngs or something... incredibly helpful sites
odd heath
feel free to spread those around, a lot of people dont know and just get their i...
Yeah tbh that's useful but if I just want a checkmark svg I'll just ask copilot ๐ญ
astral bone
Ai is good
gritty canyon
Ai is good <:blobcatcozy:1026533070955872337>
depends
sterile oak
Ai is good <:blobcatcozy:1026533070955872337>
gritty canyon
"low lvl"
LLMs arent trained much on low level code, anyone who works in systems programming will put a gun to your head if you even mention AI because it very much sucks there
thats why people like linus very very much dislike AI and all the hype around it
scenic brook
I think they meant low complexity tasks
astral bone
gritty canyon
ยฏ_(ใ)_/ยฏ
austere talon
nimble pendantBOT
vns <#1015060231060983891>
astral bone
I take this encounter as a wake up call to be more specific
fossil inlet
SpotifyControls is lagging whenever i expand it, but if i toggle css on and off it works fine until the window is unfocused then you have to toggle css again
so weird
austere talon
or do the same on discord desktop app
vencordDesktopRenderer.css *
or for discord desktop app the file is named renderer.css
charred monolithBOT
nimble pendantBOT
vtest dev2
Now testing! 
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now) 
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now)
dusk blaze
๐
charred monolithBOT
Adds a plugin that displays a user's popular GitHub Repositories on their profile. It also adds an option to display all repositories of the user in a new window. See sample image to see how it looks like on a user's profile (forgive me cooki, found you on Vencord server).
austere talon
insane
gritty canyon
thats pretty cool imo (not that id use it tho)
sterile oak
@dusk blaze you
still maple
i'd actually use that
but i'd disable the display of repos and only keep the show more
dusk blaze
virus
astral bone
Why switch away from adguard, it worked perfectly fine
austere talon
no it didn't
hollow musk
better off as an unofficial plugin imo
opaque silo
I HATE MANAGING FORKS AND PRS AND USER PLUGINS JUST LET ME ADD WITHOUT REBUILD SRUPID VENCOR
@austere talon woke security
dusk blaze
I HATE MANAGING FORKS AND PRS AND USER PLUGINS JUST LET ME ADD WITHOUT REBUILD S...
userplugininstaller
opaque silo
userplugininstaller
malware
glass jasper
reminds me of @unkempt oak Song Spotlight on Vendetta
https://bunny.nexpid.xyz/song-spotlight/
austere talon
reminds me of <@853550207039832084> Song Spotlight on Vendetta
https://bunny.nex...
HORROR PFP
jolly egret
...why
i can't think of a single time i've wanted to view someones gh repos within discord
unkempt oak
HORROR PFP
left sequoia
so turns out vencords free nitro plugin [i think] forces native steaming on web, so now PWA has everything, max screenshare quality, global keybinds, launch on boot etc
memory usage is still sky high, but at least its not native app levels
left sequoia
92 cpu
idk it spiked
it spikes when it GC's
because we love react
welp, next step is steam PWA
cuz cef is actually worse than electron
my vscode uses x2 the ram of my main browser tho, that's funny
its all TS language server and eslint doe
left sequoia
...if only
fossil inlet
cuz cef is actually worse than electron
I have gone insane trying to patch spotify native
left sequoia
I have gone insane trying to patch spotify native
you should NOT have said that
because now i'll milk you for help
fossil inlet
because now i'll milk you for help
Want me to just send you the GH repo
fossil inlet
modding cef's c++ code seems like utter insanity
Oh, no
I'm hooking and injecting js code
And some native APIs for the js
left sequoia
into cef, or chromium
fossil inlet
into cef, or chromium
Cef
fossil inlet
modding cef's c++ code seems like utter insanity
I don't think you can modify the c++ code, only the c code
fossil inlet
cuz tldr i need to prevent cef from calling window.open
Should be possible by hooking the c method
fossil inlet
but idk where to even start ngl
Start simple
Get a .so injecting that just prints something to stdout
Then, noop hook a cef function
Then work from there
left sequoia
yeah that description is enough for me to abandon the idea
my hatered of native runs deep
limber skiff
I'm hooking and injecting js code
BlockTheSpot might be useful
fossil inlet
BlockTheSpot might be useful
I have JS code injecting already and have a native api injected
I just need to work on writing all of vencords api in c++
limber skiff
why not JS tho
fossil inlet
why not JS tho
WDYM, you can't access the filesystem from js
Also window.open just doesn't work
limber skiff
I see
fossil inlet
There is no node environment, it's all cef
limber skiff
CEF doesn't have easy APIs for communication between main and renderer?
or does it not have main at all
you'll just make an API for context escape then
fossil inlet
CEF doesn't have easy APIs for communication between main and renderer?
Idk how electron works, but I just do this in my thing
And I can define all those functions with c++ code
dusk blaze
sadantify
charred monolithBOT
jolly egret
Translations like that just get outdated real fast
odd heath
I'm gonna shoot myself for this
desert cosmos
is the translation stuff still planned?
fossil inlet
should the badgeapi also inject badges here?
limber skiff
does it not lol
fossil inlet
i dont see them ๐ญ
so im guessing not
lime stone
"thank you but this is not really useful"
scenic brook
Tbh I don't see how it'll be outdated quickly when the readme has been updated twice in a year
I'd get not wanting to set a precedent of supporting certain translations though
still maple
Would a PR that add an option that should be in vanilla discord fine
basically a button to reset profile theme colors
sadly you can do it with the API, you only need to replace the color by null, but discord doesn't have a way to do it vanilla
scenic brook
Nuckyz has a discord fixes plugin in a branch but I dunno if it's actually gonna be merged, could be part of that
still maple
i guess maybe ?
basically i'd just turn this into this
this is just "fancy" html editing here cause i'm not coding smth if it's gonna be refused anyway
austere talon
can you just empty the field
still maple
can you just empty the field
ig emptying the field and pressing enter could be a trigger to reset the color
but it doesn't work as is in vanilla
also it's not really visual
austere talon
this is way too niche for a plugin
charred monolithBOT
jolly egret
people need to stop acting like the other implementations are better and that yours should be closed
like you aren't even a maintainer, you don't know what they want
charred monolithBOT
Previously, a delta such as 25199000 would display as
However, this is just incorrect as it is actually
The logic on this should be correct now, I tested with a few different values.
fossil inlet
@inland fable @west arch you love
inland fable
<@843448897737064448> <@841509134682816542> you love
Hi my screenshot is watermarked and licensed under OQL v1.1 i hope you understand
austere talon
yeah why the hell did that have round
you don't wanna round time
you almost always wanna floor
fossil inlet
yeah why the hell did that have round
i got confused looking at it
was wondering where the extra day was coming from
austere talon
thanks
brave sage
@grizzled halo thank you so much!
charred monolithBOT
jolly egret
wth thats fucking insane ๐ญ
its just not gonna play if they change the location
and people were telling this person there was already an existing PR and acting like it was actaully better ๐ญ
gritty canyon
its not gonna play after one update thats a hash they change like every month
fossil inlet
insane
@jagged reef is there a reason for that?
surely discord has to have a function that does that
jolly egret
it would just be better to hook into the notifications stuff that discord does instead of stupid stuff like this
and hey, the new plugin submission does exactly that
you're better off just suggesting changes to the other plugin now to merge in anything that yours does
median rapids
wait yeah this plugin is def a better impl lol
jolly egret
much better
median rapids
@limber skiff what do u think of hypothetically magically storing all cloudsync settings on discord
scenic brook
Sounds like potentially magically losing it all too
median rapids
i mean this has been sitting dormant for something like 4 years now
gritty canyon
<@235834946571337729> what do u think of hypothetically magically storing all cl...
how..
jagged reef
<@761777382041714690> is there a reason for that?
lol someone else made the sound thing and wanted it, so I just went โgood enoughโ
Planning on doing some sort of rewrite when I get home
gritty canyon
๐ญ please dont rewrite and just suggest changes to the new implementation we dont need 2 competing implementations cuz then none of them will get merged
gritty canyon
if you ever checked hn you'd know...
smh i dont check most of the channels cuz im locked to guest and everyone shitposts there anyway
but damn that could work
median rapids
yeah lol 5mib is plenty
sullen cobalt
its just not gonna play if they change the location
I mean, I imagine the asset would always be there as to not break old clients, but it is still an interesting way to go about it
limber skiff
<@235834946571337729> what do u think of hypothetically magically storing all cl...
omg dont tell me y'all found a way to store arbitrary values on proto settings
dm me about it ;)
austere talon
wth thats fucking insane ๐ญ
what the hell are you guys talking about this is perfectly fine
jolly egret
the whole handling notifications yourself is terrible
austere talon
the asset link is never gonna expire
jolly egret
you should not be manually playing the notification sounds
austere talon
yes that's true
median rapids
omg dont tell me y'all found a way to store arbitrary values on proto settings
sure did lol
jolly egret
this doesn't respect anything
sullen cobalt
what the hell are you guys talking about this is perfectly fine
I mean, I wouldn't call downloading an asset every single time you receive a notification fine
gritty canyon
I mean, I wouldn't call downloading an asset every single time you receive a not...
its cached
sullen cobalt
true
austere talon
I mean, I wouldn't call downloading an asset every single time you receive a not...
cache exists??
gritty canyon
but its still an awful way to do stuff
austere talon
the entire discord app always loads assets every time
that's how Websites work
but it's usually cached
austere talon
<@235834946571337729> what do u think of hypothetically magically storing all cl...
no
median rapids
y not
sullen cobalt
I mean, is it cached? does the service worker actually intercept Audio objects
median rapids
it should be cached
gritty canyon
it is cached unless you specifically disable cache
gritty canyon
y not
no fun allowed
its ok ill store you inside my discord accounts proto settings dolfies
austere talon
y not
because why the hell would we use something we have 0 control over that can change at any time and requires us to mess with their proto when we already have a working solution that we have full control over and works flawlessly
sullen cobalt
do new plugins actually get merged anymore? I saw plugin requests are closed but I'm not sure if that applies here
median rapids
because why the hell would we use something we have 0 control over that can chan...
cuz it's one less dependency and lets everything stay on discord
jolly egret
do new plugins actually get merged anymore? I saw plugin requests are closed but...
Yes they get merged
requests were just ass or duplicates so they were closed
sullen cobalt
understandable
austere talon
everything good has already been requested
sullen cobalt
I'm sure with the release of new discord features there will be more good plugins to follow
left sequoia
could someone fix platform indicators so that they dont tank performance? they keep re-paining every frame inside profile badges
limber skiff
platform indicators?
left sequoia
these
limber skiff
the current code for them doesn't even update in real time, how would they be repainting
left sequoia
took me a day to figure out that they keep being re-mounted on the dom every few hundred milliseconds
\w platform indicator and without
green = repaint
it seems fine in the user list
fossil inlet
huh has discord not pushed anything today, or is venbot broken
jolly egret
they haven't pushed
long stream
scenic brook
They're making up for lost time
limber skiff
also confirmed the other ignore activities patch can be completely removed
can you test if changing NoBlockedMessages find to .__invalid_blocked, fixes it? @fossil inlet
charred monolithBOT
fossil inlet
can you test if changing NoBlockedMessages find to `.__invalid_blocked,` fixes i...
yea, give me a few minutes to finish something else
limber skiff
oh
sullen cobalt
I mean, is it cached? does the service worker actually intercept Audio objects
just wanted to check this, can confirm that the audio requests on the existing pr are in fact not cached, and each ping redownloads the asset.
note the different values of the Date header
unsure what causes it not to be cached though
maybe the response code being 206 causes electron not to cache the asset? im unfamiliar with chromium caching logic so i wouldnt know
upon further research im relatively sure the response code is why the asset isn't cached
fossil inlet
unsure what causes it not to be cached though
basic, but do you have disbale cache toggled in your network settings
fossil inlet
i totally do
๐ญ
fossil inlet
i feel like atp its just pick your posion
charred monolithBOT
charred monolithBOT
scenic brook
Smh now I have to fix CustomMessageTimestamps
gritty canyon
thank god CSS exists!
span[class*="timestamp_"] > [aria-label^="Today at"]::before {
content: "Today at "
}
for everyone actually thinking about making that a plugin
brazen bone
What did they change about tinestamps? I haven't noticed anything
gritty canyon
What did they change about tinestamps? I haven't noticed anything
they removed the "Today at"
gritty canyon
yea
desert cosmos
insane
opaque silo
how do they indicate days other than today now
jolly egret
they only removed the today at for... today
everything else is still there
if it doesn't say a date, its today
fossil inlet
how do they indicate days other than today now
with a ... date?
charred monolithBOT
What happens when the bug or crash occurs?
Plugin noServerEmojis not work
What is the expected behaviour?
Plugin noServerEmojis not work
How do you recreate this bug or crash?
Plugin noServerEmojis not work
!...
sullen cobalt
guh, @jagged reef why though, having 2 competing implementations feels silly
gritty canyon
๐ญ please dont rewrite and just suggest changes to the new implementation we don...
โ๏ธ
sullen cobalt
they removed the "Today at"
it looks gross now imo
sullen cobalt
guh, <@761777382041714690> why though, having 2 competing implementations feels ...
by all means feel free to suggest changes to my implementation if you want to, I'm happy to give you credit for ideas, but I feel just updating yours will result in neither being merged
still maple
thank god CSS exists!
```css
span[class*="timestamp_"] > [aria-label^="Today at"...
isn't there also just an experiment toggle ?
scenic brook
by all means feel free to suggest changes to my implementation if you want to, I...
neither will get merged anyway 
still maple
thank god CSS exists!
```css
span[class*="timestamp_"] > [aria-label^="Today at"...
also aria label trigger moment
does not work on my system cause Fr*nch
gritty canyon
also aria label trigger moment
does not work on my system cause Fr*nch
i hate the french anyway so not my problem
sullen cobalt
neither will get merged anyway <:suffoClueless:1150727519302074419>
true
fossil inlet
They break that way to much
They keep changing the code there
This one should work for a while
fossil inlet
@limber skiff thoughts on rewriting that patch, you could probably match the let at the top of the function
limber skiff
ye sure
fossil inlet
@limber skiff rewrote the patch, should be a bit more resilient now
silk cypress
also aria label trigger moment
does not work on my system cause Fr*nch
this is extremely horrible but it works
span[class*="timestamp_c19a55 timestampInline_c19a55"]::before {
content: "Aujourd'hui ร "
}```
selecting that timestampInline thingy also prevents timestamps on the sides of messages breakingThis does not work no matter the language
Look in #๐จ-theme-development
The goal is to make it work on everything
Tho i'm not even sure it's doable with pure CSS
silk cypress
I hope it is
silk cypress
This does not work no matter the language
this specific css works fine for me but idk
still maple
this specific css works fine for me but idk
change your language to english or anything else other than french
Since you did out french in content, it won't be translated
glass jasper
this is extremely horrible but it works
```css
span[class*="timestamp_c19a55 tim...
Also why use [class*=] but also have a hash in thereโฆ defeats the whole purposeโฆ since thatโs not really how it should be written
scenic brook
Damn
sullen cobalt
are the today at strings still in the i18n definitions?
fossil inlet
are the today at strings still in the i18n definitions?
check the mappings
sullen cobalt
I'll check later I was just hoping someone would happen to know
oh wait, doesn't discord just use momentjs? could hook into whatever calls that to make it add today at in all localisations
fossil inlet
@sullen cobalt taking a closer look, discord doesnt use the common i18n system for dates
they use something else
sullen cobalt
oh wait, doesn't discord just use momentjs? could hook into whatever calls that ...
pretty sure its just this
yeah
it's for sure moment
sullen cobalt
I mean I wasn't planning on doing anything, I was just curious
would it even be worth a plugin? anyone bothered enough by it can just add their own css
fossil inlet
would it even be worth a plugin? anyone bothered enough by it can just add their...
could you, wouldnt that just apply to any date, not just those today
sullen cobalt
oh true
sullen cobalt
<a:aPES2_BeanTyping:903233567310630943>
real
still maple
<@889185889660567583> taking a closer look, discord doesnt use the common i18n s...
i've noticed that when trying to change a timezone userplugin
i noticed i couldn't get the same custom format
btw where is that code / how could i access it in a userplugin to be able to format the dates the same way discord format them
scenic brook
moment is exported in webpack commons, I assume you just set the locale on that
sullen cobalt
moment my beloved
fossil inlet
@limber skiff they pushed stable
limber skiff
I'll merge later, I can't now
fossil inlet
I'll merge later, I can't now
alr
jagged reef
guh, <@761777382041714690> why though, having 2 competing implementations feels ...
Combining means that there can be one implementation
If youโd rather your mr be the one, the code is there
jagged reef
lol
jagged reef
Ok!
sullen cobalt
eh, on second thought i dont think i will, there's still more i'd like to do with my version. whatever gets merged gets merged (or doesn't)
jagged reef
๐
jolly egret
I understand that this may be a burden as its an extra 2 patches to maintain but is there anything against me submitting a patch under unsafeViewAsRole?
thats really annoying because right now you can only select one role using that feature as the dropdown is still locked
I feel like if you're gonna offer it as a hidden setting it might as well be somewhat usable
fossil inlet
I feel like if you're gonna offer it as a hidden setting it might as well be som...
a what
jolly egret
what about it
fossil inlet
is there even a plugin that does that
jolly egret
Vencord.Plugins.plugins["PermissionsViewer"].settings.unsafeViewAsRole = true; ๐
fossil inlet
TIL
jolly egret
it should be as simple as setting this to true regardless & then patching the dropdown to show all roles, which is easy enough
fossil inlet
tbh i feel like it would be better to just remove the feature, as its hidden anyway and i doubt many people use it
jolly egret
i mean all the feature does is just send a flux event
it doesn't use any patches
and if y'all remove it i'd just reimplement it as a third party plugin anyway, as this is still kinda useful for me
fossil inlet
idrc either, its not something id ever have a use for
jolly egret
patch could be improved but that makes the menu accessible, doesn't make all the roles show up though, my brain is mush rn and i don't have patience for it :3
{
find: "impersonateType",
predicate: () => (settings.store as any).unsafeViewAsRole,
replacement: [
{
match: /\|\|\i\.isOwner\(\i.id\)/,
replace: "||true"
}
]
}
that one find shows the dropdown menu but it only shows roles equal or below your current top role, theres a couple arrays above in the code where it has everything but i just don't have the brain to match and patch it out
charred monolithBOT
limber skiff
just merging fixes now
fossil inlet
Email Jumpscare
limber skiff
vtest
limber skiff
sorry for the lack of activity right now, been more busy and tired
limber skiff
I'll give it a bit and push extension later
jolly egret
sorry for the lack of activity right now, been more busy and tired
no need to apologise, you've done great
fossil inlet
sorry for the lack of activity right now, been more busy and tired
all good
fossil inlet
@granite wharf
glass jasper
Email Jumpscare
Kevin
limber skiff
vext
fossil inlet
vext
fossil inlet
?remind 9pm fix
shut vineBOT
Alright @fossil inlet, in 8 hours and 41 minutes: fix
granite sky
can anyone repro this, i wasn't able to
i somehow reproduced it
fossil inlet
i somehow reproduced it
can you consistently reproduce it (it doesnt matter if you dont know how)
granite sky
i've enabled this option and than opened my normal profile
