that was what you wrote 😭
#👾-core-development
fossil inlet
yea thats what im doing
im not redoing all those files 
@limber skiff uhhh
no patches fail, but is this normal?
fossil inlet
limber skiff
LMAOOO
fossil inlet
why did you `not` twice
boolean cast, idk
limber skiff
<@235834946571337729> uhhh
no patches fail, but is this normal?
you ran it too early I think
limber skiff
boolean cast, idk
includes returns boolean
limber skiff
to have things more clear
limber skiff
omggg
@fossil inlet makeLazy is just fucking broken
it doesnt work with false...
export function makeLazy<T>(factory: () => T, attempts = 5): () => T {
let tries = 0;
let cache: T;
return () => {
if (cache === undefined && attempts > tries++) {
cache = factory();
if (cache === undefined && attempts === tries)
console.error("Lazy factory failed:", factory);
}
return cache;
};
}
change it in your PR too
jolly egret
incredible
fossil inlet
@cobalt atlasies wont makelazy just not work with booleans
because it just checks that cache is truthy
whoops, sorry random
limber skiff
<@133800774961594368>ies wont makelazy just not work with booleans
I sent you the fix lol
fossil inlet
I sent you the fix lol
guhhh i love discord being slow to load messages
90k members 🎉
austere talon
it doesnt work with false...
cause it wasnt meant to be used like that 😭
limber skiff
since when is it meant to be used in a specific way
@fossil inlet kill those !!
also make it return false here
austere talon
to have things more clear
seems super overengineered and unnecessary
just have two patches and add a comment
limber skiff
just keep itt
austere talon
no i dont like it
limber skiff
this is gonna be shit
#1337479880849362994 is going to be spammed
just like it already is
and adding noWarn is even worse
limber skiff
just add a todo or fixme
fossil inlet
log being spammed would be 
limber skiff
but having the log spammed is just horrible
austere talon
it's fine
limber skiff
you cant even track properly if something new breaks
fossil inlet
log being spammed is not fine
fossil inlet
?remind 2 weeks check if discord has rolled back
shut vineBOT
Alright @fossil inlet, in 2 weeks: check if discord has rolled back
austere talon
that skip thing is horrible
fossil inlet
better than logs being spammed
limber skiff
what else are you supposed to do
you cant track if discord reverted or not without something like this
and this change is so dumb they are likely gonna revert
but right now a lot of things are broken and we gotta fix
I already added the build number stuff before to be able to push early fixes
but this one you just cant track with a build number, since it's a bundler change
fossil inlet
- without something like this people in support might get the wrong idea when asked to ss their console
just overall more confusing
austere talon
it really doesn't matter that much
just fix it and if they revert it we revert the commit
you're overcomplicating and overengineering this a lot
austere talon
we can notice and revert so quickly no one will even notice
fossil inlet
the logs will still be spammed, that matters
limber skiff
there's no downside in doing this besides duplicate patches
which you already told us to do anyways
austere talon
don't then
if they revert, we see it in reporter, revert the commit and done
its not a big deal
fossil inlet
if they do revert, we wont have 5000 people asking for help in support
limber skiff
I dont get why you are so against it
it's not a one time thing, we can use this in the future too
of course we could just push things quickly if they change something, but extension exists
@fossil inlet holy shit the bundler cooked so hard here
what even is this
fossil inlet
<@521819891141967883> holy shit the bundler cooked so hard here
used to be an object spread
limber skiff
they just inlined the whole thing lmao
fossil inlet
it was this
return (
e.forEach((e) => {
0 !== e.settings.length &&
(!0 === e.divider && i.push({ section: l.ID.DIVIDER }),
Vencord.Plugins.plugins["Settings"].addSettings(
i,
e,
l.ID,
),
null != e.header &&
i.push({ section: l.ID.HEADER, label: e.header }),
e.settings.forEach((e) => {
i.push({
...t[e],
tabPredicate: () =>
null == n ||
(e === M.s6.SEARCH_NO_RESULTS &&
0 === n.size) ||
r.has(e) ||
n.has(e),
});
}),
e.settings?.[0] === "CHANGELOG" &&
i.push({
section: "StartupTimings",
label: "Startup Timings",
element:
Vencord.Plugins.plugins["StartupTimings"]
.StartupTimingPage,
}));
}),
i
);
you should message brandon and tell him the bundler is cooked
fossil inlet
who 
austere talon
🙏🏻
limber skiff
telling him to fix it and also enable the merge modules option
limber skiff
surely their build reduces so much like that
fossil inlet
i fear that would cook 200000 patches
limber skiff
yeah
austere talon
why do u want merge modules 😭
itd be bad for us
only slightly better for finding stuff from small generic modules
but worse for everything else
fossil inlet
merge modules is cursed with rspack (from my testing)
shut vineBOT
@fossil inlet, <t:1739929078:R>: fix
fossil inlet
<@521819891141967883> this feels inverted
i feel like that patch needs to be rewritten
it doesnt feel right
limber skiff
I know it's ugly
but it was on purpose lol
they kept changing a lot so I made it as generic as possible
austere talon
honestly just don't have that patch
either add it to the vencord category or don't add a page at all, have it render in the plugin settings
it's honestly pretty weird that it's down there
fossil inlet
yea, it could prob just be added to vencord settings
rendering in plugin settings is husk
(tbh i dont think anyone even uses it)
limber skiff
I inverted shouldSkip to shouldApply
fossil inlet
alr
limber skiff
already pushed to your pr lol
austere talon
no
fossil inlet
love
fossil inlet
@limber skiff shouldApply doesnt make much sense if you want this to be used in the future as well
limber skiff
why?
austere talon
i don't like the skip option, it's not getting added
^
charred monolithBOT
fossil inlet
@dusk blaze
fossil inlet
ill fix it tomorrow morning if someone hasnt done it already
scenic brook
There's some jank in it (it makes youtube embeds really small) but I'll upload it later
scenic brook
ill fix it tomorrow morning if someone hasnt done it already
I had a quick look into it and the channel prop being passed to isHiddenChannel is undefined for some reason, I don't have time to go further into it though (I'm slacking off work)
charred monolithBOT
still maple
i just updated my vencord fork with the changes of 1.11.4 and .5 and it seems like platform indicators css is weird
the phone icon is higher and the 2 platforms are aligned on the bottom instead of the top and pushed to the right, was that intentional ?
also the order changed and is inconsitent
nova agate
i just updated my vencord fork with the changes of 1.11.4 and .5 and it seems li...
Wait, how did you notice such an insignificant detail?
still maple
Wait, how did you notice such an insignificant detail?
idk i'm built like that
it's called the combo of ADHD and Autism traits, details stand out to me
scenic brook
Nuckyz did some work to make it more centered in the div overall a few weeks ago
still maple
also the order being inconsistent is this
like sometimes one is before the other and it's weird
jagged cloak
probably just the order discord reports them in
still maple
Nuckyz did some work to make it more centered in the div overall a few weeks ago
i'm gonna be the annoying person here, but i like it like it was before
https://xkcd.com/1172
jagged cloak
sadly true
scenic brook
^
jagged cloak
people do insane shit and complain when their bug abuse doesn't work anymore
happens all the time
still maple
probably just the order discord reports them in
it's consistent even with different logging order
it seems like the classic nothing is in a defined order because map or set or smth
ok but that didn't include phone
it's the phone that stand out to me a lot
phone be too high just like me after i took... nvm forget that /j
scenic brook
I think they're more aligned to the centre rather than top now
still maple
i mean technically it cannot be centered as one is 1px bigger than the other
it's just offset in the other direction
ok i found the issue
it's not aligned with what discord do
discord stuff is aligned higher
nova agate
Also reminded me to hide clan tags in quickcss again
bruh 
scenic brook
I'm never gonna join anyone's clan, I don't need to see them 
hollow musk
i just updated my vencord fork with the changes of 1.11.4 and .5 and it seems li...
this will drastically affect fishing season
jolly egret
I'm never gonna join anyone's clan, I don't need to see them <:suffoPeepoShrug:1...
well the clan experiment ending anyway
still maple
well the clan experiment ending anyway
They gonna keep the tag for everyone smh
still maple
the phone and web should be 1px higher i think
odd heath
Also reminded me to hide clan tags in quickcss again
I wrote a snippet
You can go find it it still works
I've been hiding them ever since they came out
charred monolithBOT
nova agate
wtfff
hollow musk
vext
hollow musk
oh cool
glass jasper
Also reminded me to hide clan tags in quickcss again
Isnt there a setting in accessibility to hide them?
scenic brook
So there is
charred monolithBOT
StatsFMRPC is a plugin to display what you are playing on stats.fm. (Based off of Lastfm)
nova agate
that means vendicated is actually reviewing plugins
i hope he won't close my pull request 
scenic brook
It'd probably already be closed if it were a quick easy rejection like that one
nova agate
It'd probably already be closed if it were a quick easy rejection like that one
true
then i have my chances
charred monolithBOT
nova agate
that would be useful 
glass jasper
Can be done with
#🎨-css-snippets message
charred monolithBOT
fossil inlet
limber skiff
ok but that didn't include phone
it's the phone that stand out to me a lot
it's a problem with the phone icon, which has a different height
limber skiff
discord stuff is aligned higher
also about this
still maple
the phone and web should be 1px higher i think
The phone is nearly normal sized, in comparison, console is wild
limber skiff
I know they are not centered in the container
they are placed a bit lower, to match more with the date and nickname text
discord elements are inconsistent too, so I chose the one which looked better, which is aligning a bit more down
still maple
Personal opinion but i preferred when they matched with tags and name
Because those are tied to the users and not the date imo
Also the fridge (i really thought that before i realized it was a console) is really big, idk if it could be slightly smaller
limber skiff
I had some screenshot hold on
.
huh
why are they being inconsistent
now sometimes it's aligning in one way, other times in another
still maple
.
2 looks so weird with the speaker being way too low
It's like if it had gravity
While 1 it feel floaty
limber skiff
2 looks so weird with the speaker being way too low
It's like if it had gravity
...
1 looks weird comparing the speaker with the text in the right
limber skiff
also this is just different lmao?
still maple
Eeeeh
Thing is my brain consider the team of the right to be part of a different group
limber skiff
same css, yet different
still maple
Icons are all a single groups with tags and role icons imo
still maple
Idk why but i feel like cursed discord CSS is acting again
still maple
Ok what
limber skiff
they are placed super low too
still maple
💀
still maple
I wonder if at that point i shouldn't just patch the entirety of discord CSS
limber skiff
nah do you wanna know the problem?
still maple
They CSS is some spaghetti layering
still maple
:pain:
limber skiff
and they manually apply top or bottom
margin-top or magin-bottom
to center each one manually
still maple
Do UI designers really not care about it ?
limber skiff
okay so, 21px
lets see the other
21 too
but you can clearly see the difference on alignment?
still maple
And the one different thing is the date after
I wonder if old messages have different CSS
still maple
Is it some inherit bs ?
Like somehow it inherit diff CSS or like it gets calculated differently because funni layered CSS
still maple
Opening discord CSS be like :
https://tenor.com/view/explosion-on-the-face-jokey-smurf-smurfs-gift-exploded-kaboom-gif-24671707
limber skiff
oh uhmm
my vencord isn't working properly
on canary
ah I broke something
okay
anyways
for that platform indicator problem you are right
phone is smaller in height
so it's alignment gets scuffed too
still maple
phone is smaller in height
And fridge is bigger, but it gets properly centered cause 2px smaller than the container
limber skiff
the fridge 😭
I'll look into this another time
specially this weird moving css that is inconsistent
limber skiff
ah I broke something
I just had it too lmao
still maple
Also idk if it could be done easily, i have thought doing it with index CSS or smth, but make the icons always in the same order
Like if it was always desktop, web, phone, fridge, it'd be nice, but just a consistency nit
fossil inlet
i havent pulled yet
fossil inlet
yea
limber skiff
Also idk if it could be done easily, i have thought doing it with index CSS or s...
yeah it's possible with the JS part of the plugin
fossil inlet
fossil inlet
GUHHHHH WHY DOES MY DISCORD KEEP BREAKING ON RANDOM REPLACMENTS IN CONSOME
limber skiff
@austere talon we switched to noWarn, is it good now? https://github.com/Vendicated/Vencord/pull/3237/files
granite wharf
salad
scenic brook
I think it's more that the doc is on the wrong line
fossil inlet
@limber skiff is there anything else blocking the fixes?
limber skiff
nop
fossil inlet
10k stars 🎉
dusk blaze
this might actually be a sane idea
reporter will update a #1257025907625951423 post
The following plugins might be broken: with a list of pluggers
fossil inlet
this might actually be a sane idea
if it were added, there should be venbot commands to add/remove plugins from that list
eg: shc is broken rn, but no patches are broken
limber skiff
vtest
limber skiff
@fossil inlet god damn you were faster than me lmao
fossil inlet
<@521819891141967883> god damn you were faster than me lmao
@grizzled halo can you update the title in known issues
grizzled halo
good timing cause I just woke up again
fossil inlet
@limber skiff are you going to tag for browser given we have patches with nowarn if they revert
limber skiff
wait a bit
fossil inlet
alr
glass jasper
charred monolithBOT
fossil inlet
they're out of date dummy
charred monolithBOT
Megred Statsfm into lastfm, Added Devs of Statsfm into Contributors
Originally from https://github.com/Vendicated/Vencord/pull/3242
granite sky
charred monolithBOT
scenic brook
I just stole sadan's fix for the unread patch 
charred monolithBOT
charred monolithBOT
charred monolithBOT
pine topaz
would this be worth implementing to remove one less hacky replace
because its kinda redundant with this
scenic brook
Damn, time to close this then 
fossil inlet
does he know you dont get badge just by making pr
he didnt add himself to contribs?
jagged cloak
nop
just changed the casing of one thing lol
me when i pronounce a capital M instead of lowercase
granite wharf
I didnt add myself to contributors when I made my pr for changing some icons
didn't feel it was significant enough
fossil inlet
67 closed 0 merged
yop
ive never had a pr merged
(the merged button is added by RGH, so it doesnt have a counter)
opaque silo
what is rgh
opaque silo
nop use new github ui
left sequoia
HOW MANY LANGS <:wires:1262562427422244874>
booo, this isnt showing all languages tho, i have typescript, yaml and xml in this repo too
fossil inlet
booo, this isnt showing all languages tho, i have typescript, yaml and xml in th...
one of my repos
fossil inlet
what is that 1.5%
nix
left sequoia
why does it look like that lol
its wild that rust is my 2nd most used language, when i wrote a SINGLE hello world project in rust, and it generated so much loc that its my 2nd biggest lang
💀
fossil inlet
its wild that rust is my 2nd most used language, when i wrote a SINGLE hello wor...
how do i get that
austere talon
booo, this isnt showing all languages tho, i have typescript, yaml and xml in th...
this is my craziest project 
left sequoia
that smells like a uni project form a mile away
somber thorn
that smells like a pride flag from a mile away
left sequoia
ah right i forgot
limber skiff
vtest dev
scenic brook
Sick
austere talon
that smells like a pride flag from a mile away
pride flag not trans 😭
somber thorn
pride flag not trans 😭
sorry, there's too many flags to remember
scenic brook
Submit and find out
left sequoia
does google review on weekends
review what
limber skiff
extension
left sequoia
heh.
austere talon
insane
desert cosmos
Why would github yeet that image
brazen bone
What if imgur yeets the image
fossil inlet
austere talon
what 😭
austere talon
what the banana is the point of them messaging you on discord
charred monolithBOT
dusk blaze
@glass jasper holy shit stop nerd reacting every little thing you see its annoying
jolly egret
vee plus brainrot
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing! 
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now) 
nimble pendantBOT
vtest dev2
Seems like everything is working fine (for now)
limber skiff
vtest
fossil inlet
youre all good
charred monolithBOT
charred monolithBOT
Content
- Automatically Select Roles of User has using that option if you have server permissions
- I alrady know the plugin requests are closes but this one is really productive for server builders & also for modrators to view as users perspective of server much faster.
Request Agreement
- [x] I have read the requirements for opening an issue above
charred monolithBOT
dusk blaze
statsfm is lastfm but bad...
jolly egret
husk
charred monolithBOT
ashen phoenix
i want to make some changes to code in src/ but i have no way to test anything atm
i could setup an ide on my arm chromebook but i think it would be too much hassle. do i just add my code and make a pr?
im planning on adding a setting to the showHiddenChannels plugin
glass jasper
Because you was selfapping some signature/ advert
left sequoia
i want to make some changes to code in `src/` but i have no way to test anything...
you can get a github workspace
and code from there
just press , while in the repo
ashen phoenix
true
ive had bad luck with it in the past with our crappy internet but i guess i could try it again
also do i use the dev branch first or does it matter
dusk blaze
idiot
idle fossil
should add the json clause to the license
you're not allowed to use vencord for evil
dusk blaze
you're not allowed to use vencord for evil
is this serious
idle fossil
no lol
dusk blaze
good
idle fossil
dusk blaze
because then vencord would become source available...
idle fossil
no no it would just be not free
ashen phoenix
also do i use the dev branch first or does it matter
should i?
i dont wanna go making a pr to main only to find out that i should have made a pr to dev
brazen bone
is this serious
It's not in the license, but we do have a couple of well trained ninjas.
idle fossil
support ninjas
dusk blaze
i dont wanna go making a pr to main only to find out that i should have made a p...
your pr will be merged to dev anyway
idle fossil
issue tracker ban him
dusk blaze
me when i have to wait 10 minutes and go through rules screening to get in the server
brazen bone
Me when I deliberately add weirdass obnoxious functionality and get banned for no reason
glass jasper
You was asked, but didnt
idle fossil
wtf
idle fossil
LMAO
who the actual fuck adds a watermark to their NORMAL messages
i can see like special things maybe
but that shit just annoying wtf
dusk blaze
who the actual fuck adds a watermark to their NORMAL messages
love?
ashen phoenix
your pr will be merged to dev anyway
oh ok
should i go to #🧩-plugin-development since im trying to add a feature to a plugin
ok so since i have no idea what im doing im going to make a pr that has the setting in the showHiddenChannels plugin, but it does nothing yet
charred monolithBOT
fossil inlet
should i go to <#1032770730703716362> since im trying to add a feature to a plug...
if its plugin related ask there, otherwise it will prob get burried here
ashen phoenix
ok
idle fossil
ok so since i have no idea what im doing im going to make a pr that has the sett...
set it as draft
ashen phoenix
done
ty for telling me, i didnt really know you could do that
(ive seen the button but its never crossed my mind)
idle fossil
ya np
jolly egret
why open it prematurely are you dumb
you know where the channel is to get help implementing it
😭
ashen phoenix
i dont know javascript
i want to learn but im too lazy
i guess i can give it a try
charred monolithBOT
median rapids
good idea but just do it bruh 😭
scenic brook
I don't understand the point of the setting
I guess if you just want channel mentions to work but not have them in the list?
rugged spire
I guess if you just want channel mentions to work but not have them in the list?
This is a completely reasonable thing to want
scenic brook
Yeah I just didn't really understand what they were going for until I was speaking it out
median rapids
I guess if you just want channel mentions to work but not have them in the list?
yeah lol
charred monolithBOT
What happens when the bug or crash occurs?
When viewing a Hidden voice / text channel, There is an error stating "Invalid time value".
( screenshots added for more context )
What is the expected behaviour?
I expect it to show the permissions preview
How do you recreate this bug or crash?
-
Open a hidden text channel
-
Open a hidden voice channel
Errors
`...
exotic zenith
Hello! 👋 I made a small pull request 6 months ago. Is there anything i can do in order to have it reviewed and merged, or should i just wait indefinitely? Thanks in advance! 🙏
jolly egret
try mentioning and even linking your PR
exotic zenith
exotic zenith
try mentioning and even linking your PR
sorry i was just about to do that, my bad
opaque silo
Hello! 👋 I made a small pull request 6 months ago. Is there anything i can do i...
stalk this channel and wait for nuckzys to be merging/doing work then ambush him
exotic zenith
stalk this channel and wait for nuckzys to be merging/doing work then ambush him
so i should just wait for him to be around here? i see, thanks!
austere talon
link here: https://github.com/Vendicated/Vencord/pull/2765
should probably just use a proper file input instead of reinventing the wheel with a button
exotic zenith
should probably just use a proper file input instead of reinventing the wheel wi...
what? the button was already there, i just added the drop event to it, thats the entire thing xD
fossil inlet
stalk this channel and wait for nuckzys to be merging/doing work then ambush him
Ping vee until they merge
jolly egret
limber skiff
stalk this channel and wait for nuckzys to be merging/doing work then ambush him
crazy strategy
dusk blaze
stalk this channel and wait for nuckzys to be merging/doing work then ambush him
or vee
at some point one of them go on a merge session and you sneakily mention your pr
jolly egret
sometimes you don't even have to wait you can just mention it infront and depending on how they feel they'll do it
fossil inlet
crazy strategy
I've done it successfully before 😭
hexed cloak
I love when discord makes a change that needs me to change one character in my replace regex
charred monolithBOT
odd heath
dusk blaze
vban
nimble pendantBOT
vban
Failed to ban @charred monolith: DiscordRESTError: Unknown User on PUT /api/v10/guilds/1015060230222131221/bans/1015063255854633081
dusk blaze
gonna bump u down a cliff soon @odd heath
scenic brook
He said the thing
odd heath
gonna bump u down a cliff soon <@708275751816003615>
Hot
odd heath
By husking you agree to review within 2 business days in Germany
fossil inlet
The last time I looked at the code for this PR it gave me a headache.
fossil inlet
ngl rspack code is so unreadable
i was trying to do something in rspack recently, and it turns out that they have so many webpack plugin hooks implimented, but only in rust and not exposed via javascript
glass jasper
https://github.com/web-infra-dev/rspack/blob/e8b77c456b8c2d299a16cd548a1eef5389c...
Isnt "Bytedance" the tiktok people?
fossil inlet
yes
fossil inlet
iirc webpack was created for tiktok
glass jasper
Insane if true
fossil inlet
Insane if true
scenic brook
Kinda like airbnb being the ones to create lottie
glass jasper
Kinda like airbnb being the ones to create lottie
What?
scenic brook
Just not the kind of company I'd expect a new animation format to come from
scenic brook
Not sure if it's a discord thing or a vencord thing but going to the intl tab in Discord's dev tools crashes Discord
And then because they make it reopen dev tools when you restart it just keeps crashing until you clear the last tab in local storage
That tab isn't super important but considering you guys were messing with proxies and intl stuff it might be worth flagging in case it is vencord related
limber skiff
I think they broke their own tools lol
fossil inlet
Not sure if it's a discord thing or a vencord thing but going to the intl tab in...
prob discord issue
scenic brook
rugged spire
Not sure if it's a discord thing or a vencord thing but going to the intl tab in...
consequence of disabling spread syntax in the bundler causing this broken code?
scenic brook
I imagine it's more likely the change to the intl proxy
rugged spire
guh
rugged spire
charred monolithBOT
charred monolithBOT
scenic brook
Is there any interest in standardising the style of setting titles like this?
If so I may as well throw it in this PR too
rugged spire
Maybe?
If you do
DO NOT use it as an excuse to skip out on not fixing the casing
Visual Refresh does not do a text transform on those elements
scenic brook
I've already fixed the casing regardless of style so we should be fine
Good to know though
charred monolithBOT
As part of just generally tidying up the look of settings I've also changed switch option titles to match every other type.
scenic brook
I actually prefer the non-caps look tbf but it's probably better to bring switches in line than the other way round
scenic brook
If they're that far apart could they just be split into two matches?
I haven't looked at the module
fossil inlet
If they're that far apart could they just be split into two matches?
not that far, just check out the module
leaden furnace
brazen bone
Modern translators also use ai, just a different architecture
jolly egret
yeah but they're actually built for that
fossil inlet
@limber skiff im really confused about something
so i was looking at how the context menu was found
in the module where the names are mapped, 830447, name is defined on a bunch of different exports from module 828214, however when i took a look at that module, all the exports were just null
how does this work if the exports are all null
limber skiff
because each function is a different reference
they arent actually called
they map references -> components
it's absolutely shit
limber skiff
<@235834946571337729> im really confused about something
so i was looking at ho...
patched by ""?
limber skiff
is it my fault or yours
fossil inlet
mine
(i think)
if not ill fix it or let you know
its not like a bunch of people are using this anyway
charred monolithBOT
austere talon
<@235834946571337729> im really confused about something
so i was looking at ho...
the exports are not null
the exports are function() { return null }
charred monolithBOT
fossil inlet
they arent actually called
im confused now, because they're called as JSX components all over the place
brazen bone
React.createComponent(x, {...props}) doesn't actually call x
limber skiff
fossil inlet
do they map over the children and replace them in some other funciton
guh, i understand it now but it just seems a lot more confusing that it needs to be
limber skiff
the dev who made this was smoking
oh yeah and vencord needs a patch for this lol
or else they were impossible to map properly when webpack finding
fossil inlet
yea, i found that then got lost
limber skiff
that's done by MenuItemDemanglerAPI
austere talon
guh, i understand it now but it just seems a lot more confusing that it needs to...
yeah idk why they did it like that lol
seems pointless
limber skiff
they just implemented getOwnPropertyDescriptor wrong for the intl proxy
I'm gonna pr a fix for it
limber skiff
here we go again
glass jasper
i will not conform to the mass WOKE husk mob
you husk every other dm I send you
opaque silo
time to update the plugin
why is it hardcoded
austere talon
why is it hardcoded <:blobcatcozy:1026533070955872337>
because if you wanna dynamically fetch it you have to use the api which requires an api key
limber skiff
@fossil inlet I found a way to generate discord message ast
it's just a format called ICU https://formatjs.github.io/docs/icu-messageformat-parser/
fossil inlet
sick
limber skiff
now how can we integrate this with discord-intl
I wonder if we could parse at build time
to avoid bundling formatjs
limber skiff
because I suppose it's kinda like a intermediate format
and discord-intl has methods to format it with values
fossil inlet
depends what format you want the keys at build time
are you leaning more towards json or js/ts
limber skiff
json in js
we could just json.parse
just insert the string
I think that's how discord does it
just have to find out how to generate those getters they have
fossil inlet
just have to find out how to generate those getters they have
i dont think you need to do that
limber skiff
or create our own proxy instance
which is what generate the getters
gotta see what values you pass to it
fossil inlet
@limber skiff i think you're overcomplicating it
limber skiff
how so?
austere talon
what's the use case
fossil inlet
you just need a function that returns the AST
austere talon
why would we need any of this
fossil inlet
then you can pass that to the intl format functions
limber skiff
then you can pass that to the intl format functions
hmmm
limber skiff
what's the use case
since we dont have translations, mainly to use plural stuff
austere talon
pretty pointless
limber skiff
without having to do all the discord-intl setup
fossil inlet
since we dont have translations, mainly to use plural stuff
tbh the only use case i can think for this is when we need to replace discords keys with our own
austere talon
just do plurals manually or use the pluralise function for simple plural
fossil inlet
and iirc theres only one need for that rn
austere talon
this isn't a real need
you only need a proper solution when you want to support multiple languages
but we don't
opaque silo
horror
median rapids
W
fossil inlet
do proper solution now for future translations
i feel like it doesnt make sense to have other languages when #🏥-vencord-support-🏥 is only in english
limber skiff
me when #🌐-translation
fossil inlet
me when No Access
fossil inlet
grave mangoBOT
Provided link did not match any services.
long stream
how could devtools cause crashes <:wires:1262562427422244874>
https://github.com...
open the intl tab in devtools and find out xd
fossil inlet
open the intl tab in devtools and find out xd
OHHH, i thought that was inspect element 😭
forgot discord had their own devtools
long stream
so silly
fossil inlet
yop
glass jasper
open the intl tab in devtools and find out xd
Did discord break their own tools?
long stream
i think so yea
fossil inlet
Did discord break their own tools?
yes
long stream
iirc nuckyz said it's a result of the proxy changes
rugged spire
how could devtools cause crashes <:wires:1262562427422244874>
https://github.com...
trolley
limber skiff
tbh it would prob be easy to fix with a patch
fossil inlet
lmao
fossil inlet
Was a tag ever pushed for the spread changes
glass jasper
nah
charred monolithBOT
charred monolithBOT
limber skiff
badges get turned into orbs in latest canary
limber skiff
it's a virtual currency discord is adding
scenic brook
Gross
fossil inlet
badges get turned into orbs in latest canary
wdym, in what way
weak thistle
quest badges I think
limber skiff
fossil inlet
doesnt look like it will be that hard to fix
the onclick actions and the tooltips both work
opaque silo
discord gets more horror every day that passes
limber skiff
omgg
it's just a silly error
src: e.vencordImage ?? isOrb ? orbImage : getIcon(e.icon),
spot the problem
fossil inlet
`src: e.vencordImage ?? isOrb ? orbImage : getIcon(e.icon),`
Does nullish coalescing really have a higher precedence than ternary, iirc nullish coalescing had one of the lowest
left sequoia
Does nullish coalescing really have a higher precedence than ternary, iirc null...
it's a logical operator like || so yeah it does
fossil inlet
it's doing this:
I got that part (otherwise it would be working) but I could have sword ternary was higher than nullish
limber skiff
oh yeah
limber skiff
vtest ev
limber skiff
no one apparently
carmine wave
@limber skiff i somehow made a plugin that shows this screen ~1s after going to any guild channel, you have to go back to @me and wait a few seconds for it to disappear
how did i manage this 😭
carmine wave
no errors or anything
rugged spire
badges get turned into orbs in latest canary
HUSK
carmine wave
are you sure your gateway isnt erroring
yes as nothing happens if i dont navigate to a guild channel
(and my plugin is patching the member list)
carmine wave
i still havent figured it out 
but i found it only happens when the window is focused
scenic brook
You can turn on gateway logging in the dev settings if that's any help
fossil inlet
it would have been really easy if i knew it was a react error
frail kernel
I found an issue building when using pnpm 10.5.0
for some reason Vencord has a requirement in package.json for a very specific pnpm version and I'm wondering if I should open a PR to remove that requirement
this happens when building with 10.5.0: ERROR Failed to switch pnpm to v10.4.1. Looks like pnpm CLI is missing at ".."
- "packageManager": "pnpm@10.4.1",
+ "packageManager": "pnpm",
^ (this solves it in my case but I'm not sure if there's a reason for it, and I've noticed there were previous "update pnpm" PRs that were closed as unresolved)
fossil inlet
I found an issue building when using pnpm 10.5.0
for some reason Vencord has a r...
use corepack
left sequoia
isnt corepack alr deprecated?
fossil inlet
isnt corepack alr deprecated?
no? corepack isnt deprecated
i cant find anything on the corepack docs that mentions its depreaciton
left sequoia
ah, corepack will no longer be part of node and not supported by node, just its own thing
because nodejs memebers said no to corepack realising its a bad idea, but people like it, so they will make its own standalone thing
median rapids
minor config change
fossil inlet
minor config change
glass jasper
scenic brook
Badge of shame
glass jasper
Quest badge already is
shell shuttle
fossil inlet
still dont know know how a react error was caught by discords loggers and never made its way to the console
limber skiff
@fossil inlet if I understood your description right then by default it allows everything
fossil inlet
<@521819891141967883> if I understood your description right then by default it ...
no
limber skiff
because error is below everything, which means everything is above it and is allowed
fossil inlet
by default it only whitelists error
guhhh i didnt mean the description visually 😭
didnt think of that
fossil inlet
then what is considered above this level 😭
idk 
fossil inlet
FJDSFHDSFDSFDSF
wait i remember, i was thinking about severity
eg error > warn > log > debug
limber skiff
just switch the order of the select
fossil inlet
yop
limber skiff
nop
we never used it before
that could be a good first use tho
better than a multiple option select
fossil inlet
yea, its on my list of things to demangle 😭
limber skiff
do you have a find for it?
fossil inlet
not yet, but it should prob be pretty easy
limber skiff
we dont need to make a setting component implementation for it
just do a custom for console shotcurts, and make the actual setting an object
with each value as a boolean
fossil inlet
i went into the design components and made a list of components that i need finds for for my demangler plugin
fossil inlet
holy I never saw this designs sections
HOW
rugged spire
does vencord even find the checkbox component
No
rugged spire
i recall using a find like that blobcatcozy
fossil inlet
yop
limber skiff
something like it
fossil inlet
that actually looks a lot better then what i had in my head
really happy with how this plugin is coming along so far
(i wish react devtools wasnt that jumpy)
limber skiff
I pushed it to your branch
fossil inlet
love
limber skiff
gotta fix the checkbox texts which have extra width for some reason
will do that tomorrow once I can
charred monolithBOT
This makes it wildly easier to find what you are looking for in react devtools
Before
After
*not all of those names are provided by this patch, only the ones used in vencord are
fossil inlet
😭
fossil inlet
its fine, im going to test it all sometime tomorrow anyway
brazen bone
How cursed would it be to identify module exports based on order rather than finds?
rugged spire
charred monolithBOT
scenic brook
This is pretty sick
If even just to help keep your place in the shitty node tree
I want a "collapse all but this node" in react dev tools
brazen bone
I've never touched react devtools tbh
scenic brook
They're good except for the fact they constantly jump around every time anything happens onscreen
With things like typing indicators and member list changes it can be annoying
jolly egret
lmao
scenic brook
I want a "collapse all but this node" in react dev tools
and/or a thing like task manager where you can hold ctrl to pause list updates
brazen bone
vp f8
scenic brook
Unfortunately that stops react dev tools from working
scenic brook
Little bit
I installed a more up to date version of dev tools a bit ago but it was kinda buggy and there weren't really any meaningful improvements so I just reverted back
scenic brook
I want a "collapse all but this node" in react dev tools
I kinda found a way to do this. If you turn off Expand component tree by default and then select the element via chrome dev tools, then go back to the react dev tools tab it'll have that node expanded with everything else still collapsed
If you select the element via the react one it expands everything you mouse over on the way there smh
rugged spire
Unfortunately that stops react dev tools from working
Yop
fossil inlet
How cursed would it be to identify module exports based on order rather than fin...
No
brazen bone
No as in "not cursed" or "you will explod"?
scenic brook
I installed a more up to date version of dev tools a bit ago but it was kinda bu...
I just tried it again and realised the biggest issue (besides the node tree refusing to render sometimes) is that it can't Go To Definition where the source is a patched module (nvm I fixed it)
rugged spire
No as in "not cursed" or "you will explod"?
limber skiff
How cursed would it be to identify module exports based on order rather than fin...
bad
I'm not sure how realiable is that
fossil inlet
@limber skiff i love typescript https://github.com/sadan4/Vencord/blob/feat/consoleJanitor/levels/src/plugins/consoleJanitor/index.tsx#L109
grave mangoBOT
<@235834946571337729> i love typescript https://github.com/sadan4/Vencord/blob/f...
index.tsx: Line 109
} satisfies AllowLevels as AllowLevels,
lol
fossil inlet
tbh idk why i have to do that, because iirc you need to do a const assertion to take the narrowest type by default
so it should just work with satisfies, but it doesnt
nevermind, satisfies asserts const
but then how do you ensure a type inline, without casting it or asserting as const
fossil inlet
@limber skiff where did the logDangerously and verboseDangerously methods come from, i cant find them on the mdn page for console
https://github.com/sadan4/Vencord/blob/feat/consoleJanitor/levels/src/plugins/consoleJanitor/index.tsx#L15-L26
grave mangoBOT
<@235834946571337729> where did the logDangerously and verboseDangerously method...
index.tsx: Lines 15-26
const NoopLogger = {
logDangerously: Noop,
log: Noop,
verboseDangerously: Noop,
verbose: Noop,
info: Noop,
warn: Noop,
error: Noop,
trace: Noop,
time: Noop,
fileOnly: Noop
};
They're added by discord
fossil inlet
ah, they're used by native
limber skiff
but then how do you ensure a type inline, without casting it or asserting as con...
you dont
fossil inlet
even if FunctionComponent can return a promise, it isnt be handled
rugged spire
But why are you blocked
fossil inlet
But why are you blocked
idk
shell shuttle
it's been a few weeks
uhmmmm
😭
can someone review my pr
i don't know the cutoff date on when i can ask or not
limber skiff
even if FunctionComponent can return a promise, it isnt be handled
it doesn't matter
that's future proofing
limber skiff
@fossil inlet I fixed it
fossil inlet
horror
limber skiff
no other way lol
fossil inlet
@limber skiff how cursed would it be to patch react internals
limber skiff
why tho
fossil inlet
I keep getting insane ideas that I just want to make
Ill send it if it works
limber skiff
alright
fossil inlet
I think I've been staring at the react source for too long
brazen bone
<@235834946571337729> how cursed would it be to patch react internals
Worked fine for me
But cursed? Absolutely
glass jasper
The break has been pushed to stable
charred monolithBOT
median rapids
i really need to make my own version
hahaha gl
did u try to access /.git or something
fossil inlet
hahaha gl
the only part i use is the build logger
and i have partially done that already
i just need to make a web ui (i suck at UI/UX)
fossil inlet
did u try to access /.git or something
nah, just typed nelly.tools into the search bar
swift fjord
did u try to access /.git or something
interestingly visiting that gives me a 429 error code instead of a 403/404
median rapids
ur gonna get banned silly
swift fjord
insane
austere talon
bruh @limber skiff
limber skiff
what happened
limber skiff
lmaoooo
limber skiff
do you wanna push anything along with that
I just wanna push the fix for now
vtest dev
glass jasper
