👾-core-development

[austere talon]

btw we should consider remaking vencord settings ui without discord components

or at least the important bits like updater

so you can still open it even if shit breaks

[cyan bloom]

That's genuenly so smart, because when discord decideds to update into some breaking update it won't break the important stuff

[austere talon]

or make a minimal alternative ui and use it as ErrorBoundary fallback

[limber skiff]

oh yeah @austere talon delete the prop after this

[austere talon]

wdym?

oh

like delete it off value

[limber skiff]

if (...) {
delete value[...];
return true
}

ya

[austere talon]

there isn't really any reason to tbh

but sure ig

[limber skiff]

just to clean it up

that wont even clean it actually...

nvm it will

[austere talon]

we should maybe make reporter log in again

[limber skiff]

why tho?

[austere talon]

one of its functions is logging discord errors

but it didn't catch any of these errors

which makes sense because if it never logs in it never renders the main ui

so the vast majority of code never runs and errors won't happen

[limber skiff]

ahhh

[austere talon]

but idk if the token i added to github ages ago even still works

[limber skiff]

it does I think

[austere talon]

and need to make sure it's not phone number locked cause that would also make the ui not render i think

[limber skiff]

https://github.com/discord/discord-intl/pull/19

the actual culprit lol

@austere talon are you still gonna do the changes or should I do them?

[austere talon]

soon

[charred monolith]

Vendicated

[Vencord:fix-canary-proxy] 1 new commit

434fd8a Apply suggestions from code review - Vendicated

[austere talon]

should we cherry pick this commit onto main or push dev to main @limber skiff

[charred monolith]

Vendicated

[Vencord:fix-canary-proxy] 1 new commit

9e82021 address feedback - Vendicated

[austere talon]

vtest fix-canary-proxy

[nimble pendant]

Now testing!

[nimble pendant]

Discord Stable (369195)

No issues found

Seems like everything is working fine (for now)

[nimble pendant]

Discord Canary (369225)

Bad Webpack Finds

mapMangledModule("defaultLocale:"en-US"", {
	t: (m) => m[props[0]] !== void 0...
})

[austere talon]

huh

whats that

[odd heath]

looks like i18n

[austere talon]

it's a false positive tho

[odd heath]

well something is setting of the t for reporter

why does it only have t shouldnt it have intl too

huh

[austere talon]

oh i know why

[charred monolith]

Vendicated

[Vencord:fix-canary-proxy] 1 new commit

6bdd60f fix reporter false positive - Vendicated

[austere talon]

vtest fix-canary-proxy

[nimble pendant]

Now testing!

[nimble pendant]

Discord Canary (369225)

Slow Patches

ReviewDB (took 6.8ms):
ID: 177222
Match: ```
/{profileType:\i.\i.PANEL,children:[/

**__ShowHiddenChannels (took 6ms):__**
ID: `734386`
Match: ```
/forceRoles:.+?.value\(\)(?<=channel:(\i).+?)/

Bad Webpack Finds

mapMangledModule("defaultLocale:"en-US"", {
	t: (m) => m[props[0]] !== void 0...
})

[nimble pendant]

Discord Stable (369195)

No issues found

Seems like everything is working fine (for now)

[austere talon]

hmm

[glass jasper]

Vencord Eol time

[shut vine]

Reminders

1470480: <t:1990423612:R>

make docs better

1450069: <t:2102184146:R>

remind potato to fix Vencord

1443532: <t:33273946759:R>

EOL vencord

3 reminders

[glass jasper]

yeah i do

[charred monolith]

Vendicated

[Vencord:fix-canary-proxy] 1 new commit

1a0a70e fix reporter false positive this time for real - Vendicated

[odd heath]

NOP

no fix

[austere talon]

vtest fix-canary-proxy

[nimble pendant]

Now testing!

[odd heath]

imagine if google reviewed this before discord pushed to stable

thatd be fire

[nimble pendant]

Discord Canary (369225)

Slow Patches

ShowHiddenChannels (took 5.1ms):
ID: 734386
Match: ```
/sortBy.{0,30}?.filter(\i=>(?<=channel:(\i).+?)/

[nimble pendant]

Discord Stable (369195)

No issues found

Seems like everything is working fine (for now)

[austere talon]

yep

[odd heath]

love

[austere talon]

@limber skiff

i wanna sleep

we need to push tag immediately

and should we do this just to be on the safe side

[glass jasper]

ok see you 4hour

[median rapids]

just patch it and force it to login

[austere talon]

wouldnt that cause api errors?

[median rapids]

yea but who cares xd

[austere talon]

us cause the point of this is detecting errors

😭

[median rapids]

u shouldnt be detecting the api killing itself xd

api errors all the time

[limber skiff]

push dev to main

[austere talon]

should i push this to my pr

and i addressed all ur feedback

[limber skiff]

yaaa

[austere talon]

they probably wont remove it but just in case

cause they technically don't need that method

they killed the __getLocalVars too

[charred monolith]

Vendicated

[Vencord:fix-canary-proxy] 1 new commit

3dc7e8e future proof findStore - Vendicated

Nuckyz

[Vendicated/Vencord] New review comment on pull request #3231: Fix webpack search on Canary

delete the property before returning, use Reflect.deleteProperty because we cant be sure if it's configurable after acessing it

Nuckyz

[Vendicated/Vencord] Pull request review submitted: #3231 Fix webpack search on Canary

[limber skiff]

alright that's it

looks good after you do that last one

[charred monolith]

Vendicated

[Vencord:fix-canary-proxy] 1 new commit

5f547a1 delete - Vendicated

[austere talon]

there

[charred monolith]

Vendicated

[Vencord:fix-canary-proxy] 1 new commit

5082553 use undefined - Vendicated

[limber skiff]

looks good

[austere talon]

null should still pass

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request review submitted: #3231 Fix webpack search on Canary

[austere talon]

and empty string

[charred monolith]

AsyrenB

[Vencord/Vendroid] Fork created: AsyrenB/vendroid

Vendicated

[Vendicated/Vencord] Pull request closed: #3231 fix issues & crashes caused by recent Discord changes

Vendicated

[Vencord:dev] 1 new commit

6b0c02d fix issues & crashes caused by recent Discord c... - Vendicated

[glass jasper]

just give Vee your token for it

[limber skiff]

@austere talon I just now realized when I imported wreq types I forgot to define this

doesn't really matter tho

it just turned into any

[austere talon]

i think cause we have skipLibCheck enabled

lmfaooo

there are so many errors

[limber skiff]

woahh

[limber skiff]

I'll push a fix for those in dev later

[austere talon]

why does this happen

[limber skiff]

self exists in workers

so idkk

ohh is it like this

nvm, no

[austere talon]

remove skipLibCheck from tsconfig

[limber skiff]

(that was so stupid LOL)

[austere talon]

so you get errors

[limber skiff]

I did

[austere talon]

oke

but idk how to fix that typescript error

assuming you get it too

[limber skiff]

that's weird tho

[austere talon]

i think it's not our fault

conflict in some types

[limber skiff]

how else am I supposed to use a type as a key?

well, I guess then

[austere talon]

[key in Type]: 

usually

[limber skiff]

thankss

[austere talon]

or [key: Type]

idk the difference rn

[limber skiff]

nvm

[austere talon]

try this

[limber skiff]

I dont even know why I wrote that

I'm forgetting how typescript works

[austere talon]

xD

should we push to main rn

& tag

[limber skiff]

1 sec

[jagged cloak]

become shelter

with the insane discordn't ui

[limber skiff]

found some other funny type errors

[austere talon]

guh these are irrelevant 😭

[limber skiff]

okayy then push

I will push to dev after

[austere talon]

vtest dev

[nimble pendant]

Now testing!

[nimble pendant]

Discord Canary (369225)

No issues found

Seems like everything is working fine (for now)

[nimble pendant]

Discord Stable (369195)

No issues found

Seems like everything is working fine (for now)

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

f91e2ca bump to v1.11.5 - Vendicated

[austere talon]

im gonna test web too

works

[glass jasper]

also rip people with dev builds

[charred monolith]

Vendicated

[Vencord:main] 14 new commits

e8639e2 Rewrite WebpackPatcher to support new features ... - Nuckyz
5d482ff Reporter: Add framework for automatic testing o... - Vendicated
306890a WebpackPatcher: Use way less closures (#3217) - Nuckyz
5196c2a Update esbuild to latest version (#3218) - Vendicated
5917514 Merge branch 'main' into dev - Nuckyz

Ura404

[Vencord/Vendroid] New star added

Vendicated

[Vendicated/Vencord] New tag created: v1.11.5

[austere talon]

oh fuck i fucked up workflow

[limber skiff]

boom

[charred monolith]

Vendicated

[Vencord:main] 1 new commit

1f67203 fix ci - Vendicated

[austere talon]

its fine

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

1f67203 fix ci - Vendicated

[limber skiff]

that error is so weird

[austere talon]

yea

errors like that are why I added skipLibCheck

shit like this is not uncommon

back then it was something in zustand types iirc

btw I really need to make another @types/vencord publish

i forgot how

i love past me

past me knew I would forget

oh thats easy

but have to push for that lmao

[median rapids]

LMAO

[charred monolith]

Nuckyz

[Vencord:dev2] 4 new commits

6b0c02d fix issues & crashes caused by recent Discord c... - Vendicated
f91e2ca bump to v1.11.5 - Vendicated
1f67203 fix ci - Vendicated
798394d Fix lib typings with errors - Nuckyz

[austere talon]

so I will do it another time

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `766b845`

Compare changes

Nuckyz

[Vencord] Branch dev2 was force-pushed to `1f0635f`

Compare changes

Nuckyz

[Vencord:dev] 1 new commit

1f0635f Fix lib typings with errors - Nuckyz

[austere talon]

why that any[] for stores

use proper type

[limber skiff]

nahh

some stores dont extend FluxStore

because they use discord-typing shit

[austere talon]

guhh we really need to yeet that shit lmaoo

[limber skiff]

for now just make it any, until we make everything proper extend it

[austere talon]

honestly should automate this

publish types package whenever vencord is tagged

but it's only used by Vesktop so doesnt matter much

[charred monolith]

Nuckyz

[Vencord:dev2] 1 new commit

6adae20 Priority blacklist module over returning if nul... - Nuckyz

Nuckyz

[Vencord:dev] 1 new commit

6adae20 Priority blacklist module over returning if nul... - Nuckyz

[limber skiff]

Priority?

Prioritize dummy

whatever tho

[fossil inlet]

?remind tomorrow

[shut vine]

Alright @fossil inlet, in 1 day: …

[charred monolith]

thelordakuma

[Vendicated/Vencord] New comment on pull request #3170: moreUserTags: attempt to rewrite

did bro die

[charred monolith]

henmalib

[Vendicated/Vencord] New comment on pull request #3170: moreUserTags: attempt to rewrite

did bro die

I will haunt your family till the death of your grandchildre

[charred monolith]

BREDEN444

[Vencord/Vendroid] Fork created: BREDEN444/Vendroid

[charred monolith]

BREDEN444

[Vencord/Vendroid] Fork created: BREDEN444/Vendroid

[scenic brook]

Vendroid2

[granite sky]

Why husk, i just wanna be a friendly ghost and see his kids grow

[rugged spire]

Husk Nuke

[charred monolith]

Snowy-Fluffy

[Vendicated/Vencord] New comment on pull request #2872: new plugin: betterInvites

Can you update this nice plugin?

[rugged spire]

i forgot that plugin existed

PLEASE FIX GUHHH

[unkempt oak]

?remind 12h

[shut vine]

Alright @unkempt oak, in 12 hours: …

[odd heath]

theres a bug where the plugin on-off toggle stops displaying a change but idk how to reproduce it 😭

[limber skiff]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[idle fossil]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[idle fossil]

[astral bone]

Text

:((

[fossil inlet]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[jolly egret]

one more time then the extension will update surely

[granite sky]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[granite sky]

[idle fossil]

[scenic brook]

My uncle works at Google, I'll ask him to approve

[charred monolith]

opalhyral

[Vencord/Vendroid] New star added

[odd heath]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[odd heath]

i told the team to leave it for a few days already so support people get to be annoying again

[glass jasper]

vban

[odd heath]

NOP

[charred monolith]

sadan4

[Vendicated/Vencord] Issue opened: #3233 Trying to copy the image in a deleted message (via context menu) throws an error, even though the image is loaded and can be opened in a modal fine

Content

Error comes from webcontextmenus, however this seems more like a message logger issue

Request Agreement

• [x] I have read the requirements for opening an issue above

[austere talon]

i dont think its loaded lol

well

it is loaded in memory and possibly disk cache

but trying to fetch it errors

try to fix it @fossil inlet

[fossil inlet]

soon

[shut vine]

@fossil inlet, <t:1739579919:R>: finish live reporter + diffing + formatted modules + history

[limber skiff]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[odd heath]

Crazy that there was no pushes since the proxy thing

Something bad is gonna come with the next push

[shut vine]

@unkempt oak, <t:1739803330:R>: …

[jolly egret]

wow 12 hours already

[limber skiff]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[austere talon]

bro i hate how discord auto archives the thread

need to add sticky threads to venbot

[heady gyro]

Actually they aren’t wrong, we are taking a page out of our competitors book (teamspeaks) and we are actually discontinue our current client and releasing a new one, which we’ve been working on in secret. This new client switches back to Babel, We’ll stop using Rspack, and we’ll be removing the Unique CSS class names, but the class names will still change with like they do.

[median rapids]

just make it delete and post instead of edit

[shut vine]

@fossil inlet, <t:1739775970:R>: …

[rugged spire]

load all images as blobs and use those everywhere (DONT DO THIS)

[fossil inlet]

was thinking of just loading it into a canvas and copying it from there somehow

[still maple]

yes you can do that
i had to do that to bypass csp to get back attachments i had dropped on discord from my clipboard that weren't there anymore

(() => {
    const attachmentSelector = '.channelAttachmentArea_b77158 img.media__41ea0';
    const images = document.querySelectorAll(attachmentSelector);
    let counter = 0;
    for (const img of images) {
        if (!img.src.startsWith('blob:')) continue;
        const canvas = document.createElement('canvas');
        const ctx = canvas.getContext('2d');
        canvas.width = img.naturalWidth;
        canvas.height = img.naturalHeight;
        ctx.drawImage(img, 0, 0);
        canvas.toBlob(blob => {
            const a = document.createElement("a");
            a.href = URL.createObjectURL(blob);
            a.download = String.fromCharCode(97 + counter) + '.png';
            document.body.appendChild(a);
            a.click();
            a.remove();
            counter++;
        }, "image/png");
    }
})();

[scenic brook]

You could've also accessed them from the sources tab in dev tools

[scenic brook]

Would it be feasible to replace the image url with a data uri on message delete?

I don't know if it'd Just Work™️

[rugged spire]

This is Not As Smart As You Think it Is

you need to already have the image trol

unless you already accounted for that idk

[scenic brook]

Nah I'm just throwing out options

[austere talon]

@limber skiff wtf they're pushing ptb but not canary

lmao

https://nelly.tools/builds

[rugged spire]

husk

why

[still maple]

No, it didn't work, i could save them, but it gave me corrupted shit

[charred monolith]

cnordenb

[Vendicated/Vencord] Issue opened: #3234 [Bug] VoiceMessages plugin: recording not working

Discord Account

hjoerleif

What happens when the bug or crash occurs?

When I attempt to record a voice message, it fails to record. When I try again, Discord logs me out and sometimes also crashes. See attached video link for a demonstration of the issue.

https://youtu.be/xOZ0gwRwzUM

Here are the versions I am running, up-to-date at time of writing:

What is the expected behaviour?

In...

Vendicated

[Vendicated/Vencord] Issue closed: #3234 [Bug] VoiceMessages plugin: recording not working

Vendicated

[Vendicated/Vencord] New comment on issue #3234: [Bug] VoiceMessages plugin: recording not working

Discord issue. Try reinstalling. Use our support channel in the future

[jolly egret]

idiot was told not to in the support channel as well

[grizzled halo]

i even said it was a discord issue

[astral bone]

[austere talon]

wonder why it even is broken for some people

but investigating is hard without way to reproduce

[astral bone]

The guy had his DC typed in, could js ask him for details

[jolly egret]

#🏥-vencord-support-🏥 message

[rugged spire]

husk

[astral bone]

[austere talon]

i just made this banger

should it be underlined

[rugged spire]

this is too simple tbh

[scenic brook]

The code to make it render diff and js highlighting is disgusting and I would never let it see the light of day but this is nice

Also kinda broken I think with that second diff

[rugged spire]

Please find a way to make this work in the console logger

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

05566ae update issue templates - Vendicated

[austere talon]

i made a repo and bumped to latest electron version https://github.com/Vendicated/standalone-electron-types

also added a bump script so it's easier to bump in the future (or might automate with github actions perhaps)

@limber skiff wtf is display: relative lmaooo

LOL

[rugged spire]

[left sequoia]

XD

[austere talon]

funny discord moment

i only noticed cause I updated stylelint

and it pointed it out

[limber skiff]

no idea what is that lol

[left sequoia]

ven review webPWA pls, i cba leaving it open, if ya dont have time i'll just nuke it cuz i cba waiting tbf

[limber skiff]

I don't think I did that css

[rugged spire]

whats the harm in leaving it open and updating it if theres interest later

[austere talon]

yeah copy pasted from discord

git blamed you so I thoughtj you wrote it

but nah just copy pasted

might have even been me cause that comment sounds more like me but git blame does say u

[left sequoia]

cuz i wanna use it, and i cba waiting 3 months for it, if its gonna sit there i'll just make my own workflow to autobuild it instead of waiting for upstream

[austere talon]

okay bro what

[rugged spire]

theres nothing stopping you from just merging it into another branch

[left sequoia]

and there's little stopping a review, there's about 4 LOC in that PR that is original, rest is pretty much copied from vesktop

[rugged spire]

i could take a look soon

[left sequoia]

you can ask questions, there's a buch of PWA shit there that people arent aware of so some stuff might not make sense

[odd heath]

Vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[rugged spire]

i am busy fixing vesktop window controls

[left sequoia]

hmmm i'll probs need to copy those fixes then, since i steal vesktop code for that XD

[rugged spire]

no

you wont

[median rapids]

evalmachine

[rugged spire]

it's just that vesktop had a hacky fix for window controls in popouts on the native side

[left sequoia]

ah IPC

ic

[rugged spire]

i might add extra functionality too

[graceful grotto]

yay ty!!

[rugged spire]

idk

[graceful grotto]

im gonna update to this and see if i get the ci working

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

c627b50 update dependencies and @vencord/types package - Vendicated

[graceful grotto]

https://github.com/electron/electron/pull/45456
https://github.com/electron/electron/issues/41824

Also, just a heads up, the background material maximize bug is now fixed.

it is electron v34 tho, idk when discord will switch to electron v34

[rugged spire]

idk

next year

[left sequoia]

thats very optimistic

[rugged spire]

i mean in 4 years

wait no

thats too long

[left sequoia]

i dont blame them, i myself update electron once every few years

cuz fixing patches for newer electron/chromium versions sucks

[rugged spire]

me and my system after half a year

genuinely this thing is sooooooo cooked now

i love broken software

[graceful grotto]

@austere talon sorry for the ping but should i uh include something like if electron.version >= 34 then use native maximize, otherwise use the workaround maximize function?

[graceful grotto]

i think theyll not update it before v33 goes EOL

[left sequoia]

legit me: thats folders with patches for diff electron versions

[graceful grotto]

3rd last versions go EOL in 8 weeks

what version of electron is current discord on?

[left sequoia]

32.2.7

[graceful grotto]

oh then it is not that long just about 16 weeks

[left sequoia]

im on 32.1.1 myself

https://cdn.discordapp.com/emojis/1047142393402638428.webp?size=48&name=Frieren6

[austere talon]

just merge dev branch

nvm

lint exploded

[graceful grotto]

[charred monolith]

Vendicated

[Vencord] Branch dev was force-pushed to `edf6480`

Compare changes

[austere talon]

fixed

[rugged spire]

warningzoom

[scenic brook]

PTB and canary are on 33.4.0

[graceful grotto]

ty vee, im gonna take a look and merge soon

[odd heath]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[odd heath]

Jfc

[limber skiff]

I think they were just pushing canary -> ptb

also might as well bump pnpm too

[graceful grotto]

folks what's the vencordnativestub file?

nvm got it

finally

ci succeeded

thanks vee

wtf https://github.com/Vendicated/Vencord/pull/3135/files#diff-d65f72c288c4e7ddf502c3c54292e7a4c2aa3c0ed800a3cb7fc83d351baab08d

ummmmm

what the

oh i think it's from vee's and nucky's commits

i think it should go away if you merge to dev instead of main

[charred monolith]

xyloflake

[Vendicated/Vencord] Pull request opened: #3235 [feat.] Add Background Material customization for win11 in settings

Old PR: #3135

This PR introduces the following background material elements for windows 11 only :

• None
• Auto
• Mica
• Tabbed
• Acrylic

A few additional changes have been made:

1. Change all occurrences of frame. to frame?. to support optional chaining (will be needed when standalone-electron-types get updated).
2. Addition of user-agent-types lib to support types for navigator.userAgentData.

xyloflake

[Vendicated/Vencord] Pull request closed: #3135 [feat.] Add Background Material customization for win11 in settings

xyloflake

[Vendicated/Vencord] New comment on pull request #3135: [feat.] Add Background Material customization for win11 in settings

Closing as I've opened #3235 for a cleaner review :)

[graceful grotto]

yep that worked

[hexed cloak]

time to read about what discord did to break everything for me again :D

[hexed cloak]

that looks coool

oh my goodness a quick dev pull fixed it

you guys are amazing

[limber skiff]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[limber skiff]

they pushed to stable

[fossil inlet]

[charred monolith]

Nuckyz

[Vencord:dev2] 3 new commits

05566ae update issue templates - Vendicated
edf6480 update dependencies and @vencord/types package - Vendicated
71ade7d Make sure i18n find does not match the wrong ma... - Nuckyz

Nuckyz

[Vencord:dev] 1 new commit

71ade7d Make sure i18n find does not match the wrong ma... - Nuckyz

[limber skiff]

@austere talon should I update pnpm too?

[austere talon]

that isn't necessary

[limber skiff]

I know it follows the order

but it's better to be sure

[austere talon]

is this a real issue

[austere talon]

pretty pointless just tuck it in with some other commit at some point

[limber skiff]

works for me

that's SHC too

[granite sky]

I'm fine

[glass jasper]

this guy was a dev build, id ignore it until/if someone on standalone build reports it

[granite sky]

They are also outdated

not too much, but still

[scenic brook]

You can change the branch your PR is targeting without closing it

[austere talon]

i forgot about this

it's so peak

[glass jasper]

steal that meme from cookie

https://cdn.discordapp.com/attachments/1216096162008924291/1335836799498719253/0lmnwiiwglge1.jpg?ex=67b60db7&is=67b4bc37&hm=b03aba1b0e527e88e0a5a42d3c66b165083b8f185927cba7fcdcc641c186d125&

[limber skiff]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[austere talon]

googol will never approve

we need to befriend a google reviewer

[limber skiff]

I'll keep it in my working dir and once I have something else to push I'll do along with it

trueee

[limber skiff]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[odd heath]

I didn't expect thsi to need a support lock 💀

Thought more people would've updated in those 3 days

[charred monolith]

Benjas333

[Vendicated/Vencord] New comment on pull request #3216: messageTags: Add custom params support (and listing existing tags in commands)

So... if there's something you don't like or would like to change, that's fine. I will be sure to stay tuned for anything.

[scenic brook]

That's actually a pretty nice addition

Not that I use message tags anyway

[charred monolith]

no72soap

[Vencord/Companion] Fork created: no72soap/Companion

[limber skiff]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[idle fossil]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[idle fossil]

thought i had it this time

[scenic brook]

Extension version polling when

[fossil inlet]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[limber skiff]

who ever gets it will get push permissions

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[limber skiff]

aww man

[glass jasper]

Vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[glass jasper]

Damn

[rugged spire]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[charred monolith]

Delfic

[Vendicated/Vencord] Issue opened: #3236 [Bug] Blocked messages are showing up

Discord Account

delfic

What happens when the bug or crash occurs?

What is the expected behaviour?

No blocked messages showing up

How do you recreate this bug or crash?

Just open discord and look at a channel where someone blocked typed

Errors

Replace this text with your crash-log.

Request Agreement

• [x] I am using Discord Stable or tried on Stable and this bug...

[fossil inlet]

guhhh ISTG if i cant repro

[rugged spire]

watch this be a bug on an older version

[fossil inlet]

cant repro

someone close

[fossil inlet]

if they were on an older version, they couldnt even open a channel

[rugged spire]

guh????

[fossil inlet]

i18n proxy fucked everythingg

remember

[rugged spire]

yop

[charred monolith]

Vendicated

[Vendicated/Vencord] Issue closed: #3236 [Bug] Blocked messages are showing up

Vendicated

[Vendicated/Vencord] New comment on issue #3236: [Bug] Blocked messages are showing up

use our support channel. issues are for development.

[rugged spire]

trolley

me when support is closed now

[idle fossil]

trol

[glass jasper]

Vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[glass jasper]

Damn it

[idle fossil]

close

[scenic brook]

Just 0.0.1 off

[glass jasper]

Vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[glass jasper]

IMMA GET THOSE WROTE PERMS

[odd heath]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[limber skiff]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[left sequoia]

ya'll loosing it

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[hollow musk]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[glass jasper]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[hollow musk]

definitely not coping that chrome would accept it

[odd heath]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[glass jasper]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[odd heath]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[glass jasper]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[jolly egret]

[rugged spire]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[rugged spire]

[idle fossil]

[glass jasper]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[versed fern]

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[glass jasper]

Canary might have exploded

[fossil inlet]

@jolly egret run vtest

[jolly egret]

vtest

[nimble pendant]

Now testing!

[scenic brook]

[nimble pendant]

Discord Stable (369256)

No issues found

Seems like everything is working fine (for now)

[fossil inlet]

@limber skiff guhhhhhh

[austere talon]

what did they cook

[fossil inlet]

also check reporter log

its timing out

[austere talon]

doesn't seem too bad

does it work fine

[fossil inlet]

vencord doesnt shit itself, if thats what you mean

[austere talon]

so just a few broken patches and reporter broken

maybe a faulty chunk or smth

[fossil inlet]

?remind tomorrow fix

[shut vine]

Alright @fossil inlet, in 1 day: fix

[austere talon]

https://canary.discord.com/assets/a642c4e9c18bcc4f.js

seems like some worker thing?

so it's expected that it errors cause it's supposed to be run on a separate worker

we just need to blacklist

[rugged spire]

me when i hopped off and don't have to fix it for myself for a few hours

[scenic brook]

A bunch of the patches are just a case of replacing let with var

[austere talon]

I had a bad feeling about relying on let

[scenic brook]

(let|var) everywhere

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #3237 Fix: Bunch of patched for new discord update

Just RCE for now, will add more as I get to them

[jolly egret]

its always "fix RCE"

[fossil inlet]

@dusk blaze rce coming to vencord soon

[fossil inlet]

yop

[glass jasper]

We gotta stop calling it that

[fossil inlet]

@limber skiff i think its a bundler mis config

object spreads are replaced with this

[limber skiff]

what happened?

[fossil inlet]

discord pushed update

i think its a bundler misconfiguration

because it looks like they're transforming spreads into that

[jolly egret]

discord is trolling

[fossil inlet]

i fixed RCE, but i dont feel like fixing a bunch of bundler changes that i think will be reverted

if they dont revert by tomorrow ill start fixing if needed

[glass jasper]

Hit up that one dude who is staff and ask them to revert

[rugged spire]

Thanks for fixing remote code execution

[fossil inlet]

[limber skiff]

and reporter doesnt work?

[fossil inlet]

reporter worked on my client

but i think venbot was having some issues with it

[limber skiff]

how tho

[jolly egret]

we need a vtesttest command to debug the vtest command

[fossil inlet]

@limber skiff i lied, this chunk errored, but it doesnt matter
#👾-core-development message

[limber skiff]

that should NOT happen

[fossil inlet]

[jolly egret]

lol

[limber skiff]

ahh okay

it is a worker

[limber skiff]

trueee

[charred monolith]

Nuckyz

[Vencord:dev2] 1 new commit

a10bee1 Reporter: Fix loading worker chunks - Nuckyz

[limber skiff]

vtest dev2

[nimble pendant]

Now testing!

[limber skiff]

I fucked it more?

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `d1393f3`

Compare changes

[limber skiff]

vtest dev2

[nimble pendant]

Now testing!

[glass jasper]

they haven’t pushed since 9:07

[fossil inlet]

like i said, im waiting 'till tomorrow or a push to stable

[limber skiff]

I will at least fix reporter before sleeping

[idle fossil]

okay but

vext

[nimble pendant]

The Vencord Chrome Extension is out of date! (v1.11.4 vs v1.11.5)

[idle fossil]

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `4127932`

Compare changes

[limber skiff]

vtest dev2

[nimble pendant]

Now testing!

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `d84aa97`

Compare changes

[limber skiff]

vtest dev2

[nimble pendant]

Now testing!

[frail sky]

Discord Stable (369256)

No issues found

Seems like everything is working fine (for now)

[fossil inlet]

love

[limber skiff]

hmm

my commit somehow fucks up stable too

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `a164fac`

Compare changes

[limber skiff]

vtest dev2

[nimble pendant]

Now testing!

[limber skiff]

@fossil inlet I fixed that duplicate plugin patchedBy too

[fossil inlet]

didnt it use a set internally

[limber skiff]

ye

[fossil inlet]

thought it was my issue

[limber skiff]

nah it was mb

alright, reporter is fixed

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `fd5ccbb`

Compare changes

Nuckyz

[Vencord:dev] 1 new commit

fd5ccbb Reporter: Fix wrongly loading worker chunks - Nuckyz

[limber skiff]

vtest

[nimble pendant]

Now testing!

[nimble pendant]

Discord Stable (369256)

No issues found

Seems like everything is working fine (for now)

[nimble pendant]

Discord Canary (369689)

Bad Patches

Decor (had no effect):
ID: 818611
Match: ```
/(?<==)\i=>{let{children.{20,100}decorationGridItem/

**__Decor (had no effect):__**
ID: `818611`
Match: ```
/(?<==)\i=>{let{user:\i,avatarDecoration/

RoleColorEverywhere (had no effect):
ID: 819366
Match: ```
/onContextMenu:\i,color:\i,...\i(?=,children:)(?<=user:(\i),channel:(\i).{0,500}?)/

**__ViewIcons (had no effect):__**
ID: `899007`
Match: ```
/avatarSrc:(\i),eventHandlers:(\i).+?"div",{...\2,/

MemberCount (had no effect):
ID: 915287
Match: ```
/(?<=let{className:(\i),.+?children):[(\i.useMemo[^}]+"aria-multiselectable")/

**__UserMessagesPronouns (had no effect):__**
ID: `421399`
Match: ```
/className:\i\(\)\(\i\.className(?:,\i\.clickable)?,\i\)}\),(?=\i)/g

StartupTimings (had no effect):
ID: 991346
Match: ```
/(?<=})([,;])(\i.settings).forEach.+?(\i).push.+})}))/

**__DynamicImageModalAPI (had no effect):__**
ID: `341176`
Match: ```
/!\(null==(\i)\|\|0===\i\|\|null==(\i)\|\|0===\i\)/

BetterUploadButton (had no effect):
ID: 974251
Match: ```
/.attachButtonInner,"aria-label":.{0,50},onDoubleClick:(.+?:void 0),.{0,30}?...(\i),/

**__ShowHiddenChannels (found no module):__**
ID: `-`
Match: ```
="NowPlayingViewStore",

Bad Webpack Finds

mapMangledModule(".tooltipTop,bottom:", {
	TooltipContainer: (m) => {
            let inner = m;
            while (inner != null) {
              if (byCodeFilter(inner)) return true;
              else if (...
})

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `dd714ff`

Compare changes

Nuckyz

[Vencord] Branch dev was force-pushed to `dd714ff`

Compare changes

[idle fossil]

nuckyz try not to force push challenge (impossible)

[fossil inlet]

@rugged spire send the gif

[limber skiff]

in dev2 normal since I was just using the action to test the reporter

but this one in dev was just cuz I actually realized something I did in another commit was wrong

and I didnt wanna do an extra commit to fix it

WHOS HUSKING

oh it's you

[idle fossil]

[fossil inlet]

vext

[nimble pendant]

The Vencord Chrome Extension is up to date! (v1.11.5)

[fossil inlet]

@limber skiff you love

[glass jasper]

@shrewd wren was the first person to get

[charred monolith]

T14D3

[Vendicated/Vencord] Pull request opened: #3238 Fix FakeNitro loading

Might need some more changes, but seems to work for now

[fossil inlet]

Whar

[glass jasper]

okai

[charred monolith]

ThaUnknown

[Vendicated/Vencord] Pull request closed: #2994 feat(plugin): WebPWA

[charred monolith]

BAHO777

[Vendicated/Vencord] New comment on commit `f43badd`

Hi, can you make sure that the blocked messages don't pop up in other users' replies?

BAHO777

[Vendicated/Vencord] New comment on pull request #3126: NoBlockedMessages: Add ignored messages

Hi, can you make sure that the blocked messages don't pop up in other users' replies? That would be really cool!

[charred monolith]

moxie-coder

[Vendicated/Vencord] New comment on pull request #3238: Fix FakeNitro loading

does this fix the issue with it not working properly when having nitro?

[glass jasper]

if you have nitro… then dont use the plugin

am I going crazy?

[scenic brook]

You are

[glass jasper]

true I’am trans

[limber skiff]

it works fine if you have nitro lol

what does that even fix

[glass jasper]

but why use it if you do????

[limber skiff]

because it does more than allowing you to use fake emojis lol

[glass jasper]

but what does the plugin give you that actually nitro doesnt

[scenic brook]

Emote and sticker permission bypass

[limber skiff]

lets you view people fake emojis better too

[glass jasper]

ig thats fair

but of y’all got a point

[charred monolith]

jamesbt365

[Vendicated/Vencord] New comment on pull request #3126: NoBlockedMessages: Add ignored messages

Hi, can you make sure that the blocked messages don't pop up in other users' replies? That would be really cool!

Hey! Could you not necro an old PR and send me notifications and emails for something that has fuck all to what I fixed please? That would be really cool!

[scenic brook]

Damn

[fossil inlet]

If discord doesn't revert by 3-4 I'll start working on fixes.

[brazen bone]

Wow that's a lot of blobcatcozies

[fossil inlet]

[jolly egret]

incredible

[charred monolith]

sadan4

[Vendicated/Vencord] Issue opened: #3239 RoleColorEverywhere: in the reactions modal, users are not loaded, leading to inconsistent role coloring, which looks wierd

Content

Request Agreement

• [x] I have read the requirements for opening an issue above

[fossil inlet]

you will not husk

[jolly egret]

eh i guess it chunk members

[fossil inlet]

LMFAO

[jolly egret]

isn't just a problem with reactions its basically anywhere RCE is used

[fossil inlet]

i cant find it an issue elsewhere

if so, it should be fixed there too

[jolly egret]

poll results for example

[fossil inlet]

i wouldnt be shocked if they used the same modal internally

(also i dont remember what they look like

[limber skiff]

just gotta request guild members using the gateway for all the uncached ids in reactions

[fossil inlet]

yop

[limber skiff]

surely they use a state so that it updates immediately

right?

I hope so

[fossil inlet]

?remind 6hr do that

[shut vine]

Alright @fossil inlet, in 6 hours: do that

[fossil inlet]

?remind 4hr finish deobfuscator plugin

[shut vine]

Alright @fossil inlet, in 4 hours: finish deobfuscator plugin

[fossil inlet]

guhh?

[limber skiff]

update your corepack

[fossil inlet]

Ah, ty

I'll try that

its working now, but i really shouldnt need the latest version of corepack

[limber skiff]

idk what they cooked lol

they pushed to stable

ehh

@fossil inlet

suchh a weird change

[fossil inlet]

love

ill start working on fixes now

[limber skiff]

this doesnt even make sense

why is it converting spreads specifically?

[fossil inlet]

who knows

[limber skiff]

all other ES6 features are still used

[fossil inlet]

also doesnt this make their bundle size go up a lot

because from what ive seen each spread convert function is in each bundle

not its own module

[limber skiff]

yeah

[fossil inlet]

thats why i thought this has to be accidental

but guess not

ill start with dynamciimagemodalAPi

[limber skiff]

object spread was added on ES2018

yet they use for await

and Promise.finally

which are from ES2018 too

[austere talon]

average discord bundler config

[fossil inlet]

doing viewicons now

[rugged spire]

HUSK

[limber skiff]

@fossil inlet making a generic way to switch every find to a patch

(jk that's a crazy idea)

[fossil inlet]

horror

[limber skiff]

not worth actually

[fossil inlet]

yop

parsing would be too hard

[limber skiff]

would be better to cook something which instead of relying on cache lets you webpack require them

so you could webpack find modules which havent been required once

webpack require React before even discord does it

[fossil inlet]

i think i could do it with an ast parser, but idfk how i would translate back to bundled code

[limber skiff]

that would be so slow lol

[fossil inlet]

the ast parser is faster than you would think

but its still slow

compared to patches

[limber skiff]

I mean

[fossil inlet]

(iirc its like 50ms to parse)

[limber skiff]

if you use a native one

but if you use something like babel, ehhh

[fossil inlet]

SWC has a wasm version

[limber skiff]

yep, exactly

that would likely be extremely fast

[fossil inlet]

that was with typescrirpt

[fossil inlet]

fun fact, its 20mb compared to typescripts 4mb

[limber skiff]

sadly I think swc doesnt have bindings for javascript anymore

so you gotta learn how to write the parser in rust

[fossil inlet]

wdym

[limber skiff]

and compile native

[fossil inlet]

horror

not touching rust with a 10ft pole

[limber skiff]

imagine turning every find into ast

we could even do patches like that

[fossil inlet]

horror

i had a terrible idea a while back that invloved parsing asts at runtime

but i forgot what it was for

[limber skiff]

https://www.npmjs.com/package/@swc/core

oh hmm

they might still have

[fossil inlet]

https://www.npmjs.com/package/@swc/wasm

tbh you could prob just use the deprecated bindings with no issue

[limber skiff]

oh waitt

[fossil inlet]

@limber skiff horror patch

basing off css class name

[limber skiff]

I'm slapping a module into that

lets see what it gives

[fossil inlet]

GUHH

why is it var

@limber skiff is there an API to add pages to settings
or do plugins need to patch them in themselves

[limber skiff]

its an array you push lol

[fossil inlet]

no, ik that, but is there an api for it

[rugged spire]

look at how the settings plugin does it

[scenic brook]

https://github.com/coldcord/iconViewer/blob/master/index.tsx#L33 also does it

[rugged spire]

rest in peace iconviewer

[scenic brook]

[austere talon]

the api is you push to the array

[rugged spire]

i actually wish that wasnt how it worked

because its not how the built in discord settings work

so the search bar in settings just doesnt support vencord settings

[limber skiff]

😞

inling binary as base64 just to get that error...

[fossil inlet]

guhhh we really need a settings api
this patch sucks lol

[limber skiff]

wdym

[austere talon]

what are u doing

[fossil inlet]

https://github.com/Vendicated/Vencord/pull/3237/files#diff-d51c3e5d949ee1ce1b4f10676e719ec37975a5ca6f540d1ad132f0272930d97dL31-R31

[limber skiff]

tryna run swc/asm-web

[fossil inlet]

@limber skiff could you review my fixes, i have at least half done rn

[austere talon]

dont hardcode brackets

[shut vine]

@fossil inlet, <t:1739985828:R>: finish deobfuscator plugin

[limber skiff]

lets just make T always true here, instead of patching the variable

[fossil inlet]

have you tested that yet, if not ill do that

[limber skiff]

tested?

[austere talon]

lets not just change let to var

stupid

we should add some special replacement that will match var let and const

[fossil inlet]

alr, i did that

uhhhhh where can i see blocked users

trying to fix implicit relationships

[jolly egret]

settings > content and social

[rugged spire]

i have seen screenshots where there is a message to tell you that its been moved

[fossil inlet]

i didnt get that

[fossil inlet]

you cant search it :megahusk:

@limber skiff i fixed all the patches, but idkf how the mapmangledmodule is failing

[limber skiff]

TooltipContainer is failing, specifically

I looked into it already

there is no comma after ="div"

[fossil inlet]

idk if that is necessart, its only a handful that need it rn

[fossil inlet]

just relized that, im blind 😭

[limber skiff]

it used to be someProp: a = "div", ...s

but yeah since they shitted spreads that's no longer the case

just remove the comma

[fossil inlet]

yop, just did that

how is this not signed

[limber skiff]

it is signed

the commit wasnt tested by workflow

because you pushed more than one at once

[fossil inlet]

😭

ima go eat, be back soonish

[limber skiff]

ughh

I swear they are gonna end up reverting this

[fossil inlet]

Yea, I have a feeling that this isn't intentional

[limber skiff]

I'm adding a shouldSkip prop to patches

then we can match a random module that has this weird spread

[fossil inlet]

What does that do?

[limber skiff]

keep both versions of patches

[fossil inlet]

Ah

[limber skiff]

and apply the correct one depending on it

sadly cant rely on build numbers for this

[fossil inlet]

Sounds good

[charred monolith]

Nuckyz

[Vencord:dev2] 1 new commit

38d7d88 WebpackPatcher: Allow patches to be skipped - Nuckyz

[limber skiff]

hmm

that's gonna make some horrible reporter logs

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `f95175b`

Compare changes

[nova agate]

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `bc3b979`

Compare changes

[limber skiff]

no one saw it

oh my god that's still wrong

[fossil inlet]

@limber skiff what if one if the fixes is also compatable with stable before they pushed these changes

how would it handle that

[limber skiff]

dont define shouldSkip

lol

[limber skiff]

actually better to just test how that works

ill steal your branch real quick

[fossil inlet]

[charred monolith]

Nuckyz

[Vendicated/Vencord] New branch created: test

Nuckyz

[Vencord:test] 15 new commits

f033a35 fix RCE - sadan4
c3ad4f9 Merge branch 'dev' into fix/all - sadan4
cb4f97d fix dynamic modal image api - sadan4
05e3836 fix viewicons - sadan4
e71a378 fix betterUploadButton - sadan4

[limber skiff]

vtest test

[nimble pendant]

Now testing!

[limber skiff]

cool it didnt work

[charred monolith]

fox3000foxy

[Vendicated/Vencord] Pull request opened: #3240 Added customVoiceFilter plugin

This plugin is in progress, and should add the possibility to let user create their own voices from the Flamingo experiment.

No simple slash command plugins like /cat. Instead, make a user installable Discord bot ✅
No simple text replace plugins like Let me Google that for you. The TextReplace plugin can do this ✅
No raw DOM manipulation. Use proper patches and React ✅
No FakeDeafen or FakeMu...

fox3000foxy

[Vendicated/Vencord] New comment on pull request #3240: Added customVoiceFilter plugin

The plugin is ready, apart for the voice modification itself.

[limber skiff]

circular dep my beloved

[charred monolith]

Nuckyz

[Vencord:test] 1 new commit

ca111e5 ff - Nuckyz

[limber skiff]

vtest test

[nimble pendant]

Now testing!

[nimble pendant]

Discord Canary (369963)

Bad Patches

BetterUploadButton (had no effect):
ID: 974251
Match: ```
/.attachButtonInner,"aria-label":.{0,50},onDoubleClick:(.+?:void 0),.{0,30}?...(\i),/

[nimble pendant]

Discord Stable (369751)

Bad Patches

BetterUploadButton (had no effect):
ID: 974251
Match: ```
/.attachButtonInner,"aria-label":.{0,50},onDoubleClick:(.+?:void 0),.{0,30}?...(\i),/

[charred monolith]

fox3000foxy

[Vendicated/Vencord] New comment on pull request #3240: Added customVoiceFilter plugin

Added a comment in the modal which explains that the Voice Filters are in rollout, but that they can still create and download Voicepacks. In this case, the plugin has no reason to be in draft.

[austere talon]

whats the use case

[limber skiff]

have duplicate patches

for different builds

(when we cant rely on build number)

[fossil inlet]

guhh???

wait

[charred monolith]

Nuckyz

[Vencord:test] 1 new commit

38431e6 now - Nuckyz

[fossil inlet]

why is that the old one

[nova agate]

interesting. how does the bot is testing it through clients ?

[fossil inlet]

puppeteer

[limber skiff]

vtest test

[nimble pendant]

Now testing!

[nova agate]

puppeteer works with DiscordNative?

[fossil inlet]

no, its loading the browser version

[nova agate]

ah

interesting

[fossil inlet]

the code for it is open source if you want to take a look

[nimble pendant]

Discord Canary (369976)

No issues found

Seems like everything is working fine (for now)

[nimble pendant]

Discord Stable (369751)

No issues found

Seems like everything is working fine (for now)

[nova agate]

[nova agate]

is this how you are testing the plugins approvals ?

[fossil inlet]

thats a linter

[nova agate]

thats just a linter test??

[fossil inlet]

yes, the reporter runs seprately

[nova agate]

oh

[austere talon]

minus logging in but we should add it back

[glass jasper]

leak that token
/j

[fossil inlet]

yea, thats what i said?

[nova agate]

very interesting

[glass jasper]

ik I just said it in less of a nerd way /j

I just had that screenshot on my phone and I reminded me of it

[nova agate]

is the linter workflow automated ?

[fossil inlet]

just look at the github repo

it has all the info you need

[nova agate]

if i understand, i need to write a plugin request ?

[fossil inlet]

no

if you have already made your plugin, just pr it

[nova agate]

i did

[fossil inlet]

okay, now just be paitent and wait

it can take a long time to get reviews

[nova agate]

https://github.com/Vendicated/Vencord/pull/3240 here

[nova agate]

ah ok

[charred monolith]

Nuckyz

[Vencord:test] 1 new commit

3ac2a0e fdgdfg - Nuckyz

[limber skiff]

@fossil inlet pick that to your branch and convert the others too

I cant help you right now, sorry

[shut vine]

@fossil inlet, <t:1739985789:R>: do that

[limber skiff]

just this single commit and the one in dev2

[fossil inlet]

so
https://github.com/Vendicated/Vencord/commit/3ac2a0ed733830407b9669d58f5fc6bf80e5513a
and
https://github.com/Vendicated/Vencord/commit/bc3b979e100fd195da6ddc9064be04e76c9ebce8

[limber skiff]

ya

[fossil inlet]

wdym by convert the others

[limber skiff]

the patches

[fossil inlet]

so add shouldSkip to all of them

[limber skiff]

most

dynamic image doesnt need it

neither does the mapMangledModule of course

ohhh that's kinda shit

I didnt think of finds

[fossil inlet]

ill make it something compatable with before and after

[limber skiff]

nahh

ill fix it

[nova agate]

what are you cooking ? 👀

[limber skiff]

there you go

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `826ec13`

Compare changes

[limber skiff]

I lied

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `e3acac0`

Compare changes

[nova agate]

git push --force

is this a rebase ?

[fossil inlet]

😭

[nova agate]

im asking

[fossil inlet]

nop

force push

[nova agate]

[fossil inlet]

love when they dont apply cleanly

im just going to merge origin/test into my branch

[glass jasper]

You’ll learn how often these actually happen

[nova agate]

actually im getting more and more interested about vencord developing side

i was afraid to dev plugins before

i though this was difficult

but no

[limber skiff]

@fossil inlet you will not believe it

I have to force push again

just realized reporter can now test for buildNumber too

[nova agate]

[fossil inlet]

[nova agate]

special emoji

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `2bf4391`

Compare changes

[limber skiff]

vtest dev2

[nimble pendant]

Now testing!

[nova agate]

vtest

[fossil inlet]

mod only

[limber skiff]

MINUS ONE?

[nova agate]

oh oki

[limber skiff]

It didn't work

[fossil inlet]

wdym -1

[limber skiff]

Discord Stable (-1)

[fossil inlet]

😭

[limber skiff]

I know why

easy fix

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `ee1545e`

Compare changes

[limber skiff]

vtest dev2

[nimble pendant]

Now testing!

[scenic brook]

CollapsibleEmbeds doing work in #1337479880849362994

[limber skiff]

holy shit I broke it

[fossil inlet]

@scenic brook did you ever add anything like this?

[limber skiff]

woahh

how did I break it

[fossil inlet]

i flipped a random bit

[scenic brook]

Nah, it's not something I would've thought of a use for tbh

[limber skiff]

I flipped a line

[fossil inlet]

same thing

[limber skiff]

and it now breaks vencord completely

it shouldnt tho

[glass jasper]

Vencord Eol confirmed

[limber skiff]

how did it break....

[fossil inlet]

@limber skiff is this a better find?

[limber skiff]

duplicate

[fossil inlet]

compatable with both before and after

[idle fossil]

vext

[nimble pendant]

The Vencord Chrome Extension is up to date! (v1.11.5)

[idle fossil]

holy moly

[limber skiff]

somehow swapping one line is changing the order things are required?

how...

nvm

ohh

some are running without the wrapper

[fossil inlet]

@limber skiff do you want to do the same or a different identifier for let/var

or do you want to do something else for that

or just ignore it

[limber skiff]

do the same for now

[fossil inlet]

you mean just use spreaddisabled

[limber skiff]

ya

[fossil inlet]

alr

[limber skiff]

okay I finally understood the problem

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `dd714ff`

Compare changes

Nuckyz

[Vencord:dev2] 1 new commit

9bcc67d WebpackPatcher: Allow patches to be skipped - Nuckyz

[limber skiff]

vtest dev2

[nimble pendant]

Now testing!

[nimble pendant]

Discord Canary (370043)

Bad Patches

Decor (had no effect):
ID: 818611
Match: ```
/(?<==)\i=>{let{children.{20,100}decorationGridItem/

**__Decor (had no effect):__**
ID: `818611`
Match: ```
/(?<==)\i=>{let{user:\i,avatarDecoration/

RoleColorEverywhere (had no effect):
ID: 819366
Match: ```
/onContextMenu:\i,color:\i,...\i(?=,children:)(?<=user:(\i),channel:(\i).{0,500}?)/

**__ViewIcons (had no effect):__**
ID: `899007`
Match: ```
/avatarSrc:(\i),eventHandlers:(\i).+?"div",{...\2,/

MemberCount (had no effect):
ID: 915287
Match: ```
/(?<=let{className:(\i),.+?children):[(\i.useMemo[^}]+"aria-multiselectable")/

**__UserMessagesPronouns (had no effect):__**
ID: `421399`
Match: ```
/className:\i\(\)\(\i\.className(?:,\i\.clickable)?,\i\)}\),(?=\i)/g

StartupTimings (had no effect):
ID: 991346
Match: ```
/(?<=})([,;])(\i.settings).forEach.+?(\i).push.+})}))/

**__DynamicImageModalAPI (had no effect):__**
ID: `341176`
Match: ```
/!\(null==(\i)\|\|0===\i\|\|null==(\i)\|\|0===\i\)/

BetterUploadButton (had no effect):
ID: 974251
Match: ```
/.attachButtonInner,"aria-label":.{0,50},onDoubleClick:(.+?:void 0),.{0,30}?...(\i),/

**__ImplicitRelationships (had no effect):__**
ID: `270759`
Match: ```
/,{id:(\i\.\i)\.BLOCKED,show:.+?className:(\i\.item)/

ImplicitRelationships (had no effect):
ID: 596957
Match: ```
/toString()});case (\i.\i).BLOCKED/

**__ImplicitRelationships (had no effect):__**
ID: `974042`
Match: ```
/(?<=case (\i\.\i)\.BLOCKED:return (\i)\.type===\i\.\i\.BLOCKED)/

ShowHiddenChannels (found no module):
ID: -
Match: ```
="NowPlayingViewStore",

Bad Webpack Finds

mapMangledModule(".tooltipTop,bottom:", {
	TooltipContainer: (m) => {
            let inner = m;
            while (inner != null) {
              if (byCodeFilter(inner)) return true;
              else if (...
})

[nimble pendant]

Discord Stable (369751)

Bad Patches

Decor (had no effect):
ID: 818611
Match: ```
/(?<==)\i=>{let{children.{20,100}decorationGridItem/

**__Decor (had no effect):__**
ID: `818611`
Match: ```
/(?<==)\i=>{let{user:\i,avatarDecoration/

RoleColorEverywhere (had no effect):
ID: 819366
Match: ```
/onContextMenu:\i,color:\i,...\i(?=,children:)(?<=user:(\i),channel:(\i).{0,500}?)/

**__ViewIcons (had no effect):__**
ID: `899007`
Match: ```
/avatarSrc:(\i),eventHandlers:(\i).+?"div",{...\2,/

MemberCount (had no effect):
ID: 915287
Match: ```
/(?<=let{className:(\i),.+?children):[(\i.useMemo[^}]+"aria-multiselectable")/

**__UserMessagesPronouns (had no effect):__**
ID: `421399`
Match: ```
/className:\i\(\)\(\i\.className(?:,\i\.clickable)?,\i\)}\),(?=\i)/g

StartupTimings (had no effect):
ID: 991346
Match: ```
/(?<=})([,;])(\i.settings).forEach.+?(\i).push.+})}))/

**__DynamicImageModalAPI (had no effect):__**
ID: `341176`
Match: ```
/!\(null==(\i)\|\|0===\i\|\|null==(\i)\|\|0===\i\)/

BetterUploadButton (had no effect):
ID: 974251
Match: ```
/.attachButtonInner,"aria-label":.{0,50},onDoubleClick:(.+?:void 0),.{0,30}?...(\i),/

**__ShowHiddenChannels (found no module):__**
ID: `-`
Match: ```
="NowPlayingViewStore",

Bad Webpack Finds

mapMangledModule(".tooltipTop,bottom:", {
	TooltipContainer: (m) => {
            let inner = m;
            while (inner != null) {
              if (byCodeFilter(inner)) return true;
              else if (...
})

[limber skiff]

🙏

finally got it

@fossil inlet pull it again

[jolly egret]

uh oh

[rugged spire]

Need

[fossil inlet]

Alr

[charred monolith]

Trojaner

[Vendicated/Vencord] Issue opened: #3241 [Bug] Developer options: "Enable Forced Canary" option does not work

Discord Account

trojaner

What happens when the bug or crash occurs?

Requests should go to discord canary domain when "Enable Forced Canary" is enabled.

What is the expected behaviour?

Requests should go to canary domain.

How do you recreate this bug or crash?

1. Enable Forced Canary
   

2. Restart discord

3. Trigger any API request and check it in devtools

Errors

![Image](https...

no72soap

[Vencord/Companion] Pull request opened: #10 Updated README with build instructions

I was setting up a dev environment but noticed that you can no longer download VSCode extensions from Microsoft's website. I tried searching for this extension in the extensions tab of VSCodium but could not find it, so I built it and wrote down the steps I took to do so. I also added some headers.

Vendicated

[Vendicated/Vencord] Issue closed: #3241 [Bug] Developer options: "Enable Forced Canary" option does not work

Vendicated

[Vendicated/Vencord] New comment on issue #3241: [Bug] Developer options: "Enable Forced Canary" option does not work

this ui is hidden Discord developer ui go complain to Discord (don't) not us 😭

[austere talon]

insane 😭

[fossil inlet]

Why did he downvote 😭

@sudden fog insane

[limber skiff]

they just got banned from support lol

[dusk blaze]

have you seen #🏥-vencord-support-🏥

he has been warned, he kept being "erm ashktually" so i banned

[charred monolith]

Vendicated

[Vencord/Companion] Pull request closed: #10 Updated README with build instructions

Vendicated

[Vencord/Companion] New comment on pull request #10: Updated README with build instructions

These instructions are not correct, sorry. Thank you regardless

I tried searching for this extension in the extensions tab of VSCodium but could not find it

https://stackoverflow.com/a/64537579

[fossil inlet]

you will use a bookmarklet

javascript:(function()%7Bconst URL_VSIX_PATTERN %3D 'https%3A%2F%2Fmarketplace.visualstudio.com%2F_apis%2Fpublic%2Fgallery%2Fpublishers%2F%24%7Bpublisher%7D%2Fvsextensions%2F%24%7Bextension%7D%2F%24%7Bversion%7D%2Fvspackage'%3B%0A%0Alet itemName %3D new URL(window.location.href).searchParams.get('itemName')%3B%0Alet %5Bpublisher%2C extension%5D %3D itemName.split('.')%3B%0Alet version %3D document.querySelector('%23versionHistoryTab tbody tr .version-history-container-column').textContent%3B%0A%0Alet url %3D URL_VSIX_PATTERN.replace('%24%7Bpublisher%7D'%2C publisher)%0A%09%09%09%09%09%09  .replace('%24%7Bextension%7D'%2C extension)%0A%09%09%09%09%09%09  .replace('%24%7Bversion%7D'%2C version)%3B%0A%0Awindow.open(url%2C '_blank')%3B%7D)()%3B

DONT HUSK

so good

[limber skiff]

more unreadable than discord code

[fossil inlet]

you love url encodingg

guhhhh the g key is broken on my keyboard

sometimes sends twice

@limber skiff my pr should be good, i think i got everythingg

nevermind, how??

i think your commit broken something

[charred monolith]

Vendicated

[Vendicated/Vencord] New comment on issue #3241: [Bug] Developer options: "Enable Forced Canary" option does not work

You're not real for downvoting that

This ui you're looking at is Discord's UI, NOT our UI
This switch you're looking at is Discord's Switch, NOT our switch
This feature is Discord's feature, NOT our feature

This switch does nothing because Discord removed the code for it so it's unused. It's also entirely useless. If you want requests to go to the canary domain, just use Canary?

You also completely ignored the issue rules that require you to be a contributor to open...

[limber skiff]

uhh

[fossil inlet]

GGUHHHHH

why does spread disabled mean use spread

[limber skiff]

LMAOO

are you sure?

well you inverted those

[limber skiff]

if not spread disable use spread