#๐พ-core-development
charred monolithBOT
austere talon
now it also handles headers
charred monolithBOT
limber skiff
I only realized that was possible too when dealing with platform indicators yesterday
austere talon
yeahhh
limber skiff
discord changes the vars depending if the profile theme is light or dark too
austere talon
it shouldnt be that hard
limber skiff
how should we do it
limber skiff
which
austere talon
not actually deleted
limber skiff
also vencord adds styles all over the places lmao
some in head
some in root
some in body
austere talon
trolley
austere talon
there is messagelogger-deleted-attachment on some random video
bro
item: deleted
who cooked this up
charred monolithBOT
limber skiff
๐ญ
limber skiff
๐
austere talon
it removes first patch right?
limber skiff
ya
austere talon
yeah thats better
guh BlurNSFW is fine i think
i have it on and doesnt seem laggy
just keep it for now im lazy
unless you wanna rewrite it
limber skiff
unless you wanna rewrite it
I meann we just did the effort to remove all of these
just to keep one in the end?
austere talon
guhhhh
the thing is
discord is insane
they put image classes on videos
๐ญ
discoooooord
it's easy to fix if you're okay with playing video being blurred
austere talon
VIDOE IS LAZYIMG
limber skiff
god damn
austere talon
and not all images have lazyimg
lol
sometimes they put img with 0 classes
imageWrapper.lazyImg > img
the child has no class
videos have both of those classes on parent too
well
we can make BlurNSFW add better class ig
but then we need to add more patches
limber skiff
which things do we need to target exactly?
I'm kinda confused
just normal images?
limber skiff
videos thumbnails?
austere talon
yes
austere talon
have to patch so many places probably
limber skiff
why is that so small
austere talon
hmm
ig it shouldn't be too hard
yeah it's easy okay
916616
nvm because no way to detect if it's an image or video
also wtf why is devtools so laggy
chrome devtools are laggy and it also makes discord laggy
limber skiff
hmm
what about srcIsAnimated
actually this should only target the thumbnail of videos so whats the issue?
scenic brook
Tbf they got feedback immediately and didn't act on it 
austere talon
image vs video
limber skiff
use the alt
austere talon
no
limber skiff
๐
austere talon
it probably is language dependant
austere talon
image vs video
there's literally no way to differentiate
unless you wanna check if src contains mp4 webm etc but that's horrrible
well we can match this
that's where messagelogger adds deleted classname
austere talon
well we can match this
no this is better
austere talon
well we can match this
i will do this
limber skiff
alright
austere talon
i will copy paste ur patch
limber skiff
we are gonna fix discord lag by memoizing everything @austere talon
{
find: ".createElement=",
replacement: {
match: /function (?=.+?\.createElement=(\i))\1\((\i),\i,\i\){/,
replace: "$&$2=$self.getMemoizedComponent($2);"
}
}
MemoSymbol: Symbol.for("react.memo"),
FragmentSymbol: Symbol.for("react.fragment"),
getMemoizedComponent(original: any) {
if (!original || typeof original === "string" || original.$$typeof === this.MemoSymbol || original === this.FragmentSymbol) {
return original;
}
let component = componentCache.get(original);
if (!component) {
component = React.memo(original);
componentCache.set(original, component);
}
return component;
}
LOL
limber skiff
(it works)
limber skiff
I used for a bit and had no issues lmao
median rapids
we are gonna fix discord lag by memoizing everything <@343383572805058560>
```...
u will make a 3rd party client
limber skiff
but yeah that would def need a lot of testing
austere talon
๐ญ
austere talon
okay nvm
limber skiff
look at how many memos
charred monolithBOT
limber skiff
actually is this even working
austere talon
i dont think it's working lol
if it did it would cause many bugs
should we merge @limber skiff
WAIT
NOT YET
COPILOT IS COOKED
limber skiff
i dont think it's working lol
I got it working before
charred monolithBOT
austere talon
anyway should be good now
frail skyBOT
austere talon
did u run
frail skyBOT
austere talon
vtest fix-lag
nimble pendantBOT
vtest fix-lag
Now testing! 
limber skiff
should we merge <@235834946571337729>
ya
nimble pendantBOT
Merging into main 
austere talon
vtag 1.10.4
nimble pendantBOT
Creating release
austere talon
soon Venbot will be chief automation
tropic valley
repo management via discord
rugged spire
is this real
austere talon
|| no ||
tropic valley
very cool honestly
tropic valley
smh i believed u
scenic brook
Would be a bit rough since we're on 1.11.3
rugged spire
what if i made a discord bot that let people edit a git repo
and only let people edit through the bot
send git patches over discord
limber skiff
Merging into main <:shipit:1330992641466433556>
YOO WHAT
austere talon
|| fake ||
rugged spire
what if i made a discord bot that let people edit a git repo
@fossil inlet Steal my idea
rugged spire
no love for dev branch...
fossil inlet
guhhhhhhh not on dev ๐ญ
charred monolithBOT
austere talon
patience my children ๐ญ
fossil inlet
HOW MANY PEOPLE LURK THIS CHANNEL ๐ญ
rugged spire
idk occasionally i say some dumb stuff and get reactions from people who cant type here
scenic brook
I only read this channel and #๐งฉ-plugin-development tbh
rugged spire
is it wrong that I treat #๐งฉ-plugin-development as a questions channel
fossil inlet
is it wrong that I treat <#1032770730703716362> as a questions channel
same thing i do 
rugged spire
i lurk this channel way more than #๐งฉ-plugin-development
rugged spire
same thing i do <:blobcatcozy:1026533070955872337>
then i proceed to dump my questions here instead
surreal fiber
I lurk occasionally, saw there's a lag fix that's relevant to my interests but not really clear to me what's suddenly causing it and how to avoid it when doing css
austere talon
I lurk occasionally, saw there's a lag fix that's relevant to my interests but n...
most lag I've seen caused by :has()
which didn't lag before but does now
idk just don't use :has ever
surreal fiber
I see I see
rugged spire
https://discord.com/channels/1015060230222131221/1335030867759730790/13354097360...
many crimes are committed in my own plugins
fossil inlet
many crimes are committed in my own plugins
whats wrong with >div 
rugged spire
whats wrong with >div <:wires:1262562427422244874>
css goes from right to left. try to avoid patterns where the rightmost selector is generic and the leftmost selector is complex as this will essentially have exponential performance impact. for example, this is catastrophic:
.thing:has(.thing) > *
dusk blaze
what if i made a discord bot that let people edit a git repo
this is actually such a great idea
rugged spire
this is actually such a great idea
billions will make vencord plugins and dont even need github account
glass jasper
billions will make vencord plugins and dont even need github account
I still say we delete both the GitHub and Codeberg repos for Vencord and host everything solely on @dusk blaze โs forgejo
jolly egret
would be great when its down all the time
complaints in #๐ฅ-vencord-support-๐ฅ up 1000%
rugged spire
remember when github was down a few days ago 
dusk blaze
would be great when its down all the time
jolly egret
fake
fossil inlet
@jolly egret dont worry, ill crash it somehow
rugged spire
<@158567567487795200> dont worry, ill crash it somehow
sudo init 0
dusk blaze
sudo init 0
fossil inlet
sudo init 0
guhhh i still dont understand run levels
rugged spire
guhhh i still dont understand run levels
good
you shouldn't need to
it's legacy stuff anyways
scenic brook
most lag I've seen caused by :has()
This one seems to hit mine especially hard lol, particularly hovering servers #1285418433042714667 message
austere talon
according to some guy in support, some themes that lag on vencord don't lag on betterdiscord
probably ๐งข but we should still investigate. maybe it's something about how we insert the styles (average chrome moment, wouldn't even be surprised)
scenic brook
I dunno if it's massively relevant but if you go to the performance tab and enable this in settings, it crashes when it tries to load the profile after recording, which doesn't happen if you uninstall vencord
Which is annoying because it'd probably be pretty useful
Disabled all plugins and tried it and still crashed
austere talon
maybe cause we put styles in the body which is technically invalid
scenic brook
I dragged all the style tags into head and it didn't seem to change anything
austere talon
it probably caches tbf
austere talon
I dunno if it's massively relevant but if you go to the performance tab and enab...
is this on chrome?
or edge
scenic brook
I still had one more :has() in my own fork, oops, even just getting rid of that one makes so much difference
austere talon
I didnt know chrome also has one
limber skiff
according to some guy in support, some themes that lag on vencord don't lag on b...
I wouldnt be surprised if this is true
but nah
scenic brook
maybe cause we put styles in the body which is technically invalid
Most of them were actually on the document element and not the body but I moved them all into head within vencord rather than just dragging and it's no better still
limber skiff
discord must have fucked up somehow and made styles recalculate way more
scenic brook
Kinda crazy that :has() is so detrimental
still maple
i think discord F up smth
personally now if i am in vc at some point discord get randomly cooked and hang up even in vanilla
scenic brook
I have a #id > div rule above that has next to no effect comparatively
limber skiff
@median rapids btw are you actually using that plugin
context menus need fixing for it so here you go
scenic brook
I dunno if it's massively relevant but if you go to the performance tab and enab...
Now when I try it this crashes stable with no vencord as well so I guess it was a fluke the first few times I tried somehow
fwiw when it did work I got this
but again that's no vencord
77k matches attempted, only 1000 succeeded lol
fossil inlet
I LOVE OVERRIDING CONSOLE METHODS I LOVE BEING ABLE TO JUMP TO WHERE THEY WERE CALLED 
rugged spire
I LOVE OVERRIDING CONSOLE METHODS I LOVE BEING ABLE TO JUMP TO WHERE THEY WERE C...
You love React devtools providing absolutely no value by doing this
scenic brook
Can you not just expand the stack
austere talon
ah okay
austere talon
the point isn't the warning its the stacktrace
fossil inlet
i hope this error explodes
vp consolejanitor
nimble pendantBOT
vp consolejanitor
austere talon
nop
austere talon
no it doesnt
rugged spire
then it is broken
fossil inlet
then it is **broken**
send ss of settings
austere talon
disabling discord loggers is so bad
rugged spire
austere talon
many are useful
rugged spire
disabling discord loggers is so bad
yop
fossil inlet
disabling discord loggers is so bad
nopppp
limber skiff
I LOVE OVERRIDING CONSOLE METHODS I LOVE BEING ABLE TO JUMP TO WHERE THEY WERE C...
yeah we gotta disable that shit
limber skiff
cuz they be pushing to ptb at sunday
charred monolithBOT
scenic brook
I know the comment on the API clarifies the icons are added to profiles but I feel like the name NicknameIcons kind of sounds like they'd appear next to the nickname in messages too
granite sky
Why does the GitHub webhook still use my old pfp ๐ญ
long stream
Why does the GitHub webhook still use my old pfp ๐ญ
probably still cached by discord's media proxy xd
limber skiff
I know the comment on the API clarifies the icons are added to profiles but I fe...
the container they are added is called nicknameIcons, and so is the property in the component
limber skiff
@granite sky I will review your changes after I try this API and discord-fixes merged
planning to also change how the container of member list decorators is, to allow centering with flex and having margin with gap, which is easier than having to add the margins manually into the components
or I might move those patches into the actual API for those decorators
(thinking now it makes more sense)
the current approach of centering things in the message and member list decorators is horrible
scenic brook
the container they are added is called nicknameIcons, and so is the property in ...
Fair enough
odd heath
@limber skiff pindms is breaking for me after reloads and also i noticed the values get added to userBasedCategoryList infinite times; think you fucked smth up ๐ญ
works fine if i put it back into datastore and reload but every reload after that its broken
dont have time to look into ti more rn so im just leaving it to you :3
limber skiff
odd heath
this is what i mean btw
granite sky
So basically it's green light for me to use decorations
Should i do it the way theKodeToad did?
limber skiff
this is what i mean btw
that's outdated tho
odd heath
how
limber skiff
this is what i mean btw
this is what the current settings look like
odd heath
got troleld
vesktop wasnt closed properly ๐ญ
works fine now
it wasnt in the app icons but the process was running
killed it and cleared settings so now it works
austere talon
untrue ๐ญ
austere talon
left sequoia
since CSS introduced fancy color spaces that work outside of RGB
yeah hsl was misspoke
because its within rgb colorspace
austere talon
but this doesn't work
left sequoia
well
it works for u
because the launch splash is still a full DOM
the controls overlay isnt
it passes whatever string u give it to the OS "for the most part"
left sequoia
just find a new solution <:bleh:1047549509745524777>
yeah i aint writing a matrix multiplication lib for colorspace conversion
i dont even know where to find the colorspace normals to do that
austere talon
left sequoia
i've done it before, but its not enjoyable
yeah see that uses some fucking normals that they pulled fucknows from where
casual "0.6299787005"
yes that makes sense
austere talon
function clamp(value, min, max) {
return Math.max(Math.min(value, max), min);
}
const linearToGamma = (c) =>
c >= 0.0031308 ? 1.055 * Math.pow(c, 1 / 2.4) - 0.055 : 12.92 * c;
function oklabToSRGB({L, a, b}) {
var l = L + a * +0.3963377774 + b * +0.2158037573;
var m = L + a * -0.1055613458 + b * -0.0638541728;
var s = L + a * -0.0894841775 + b * -1.2914855480;
// The ** operator here cubes; same as l_*l_*l_ in the C++ example:
l = l ** 3; m = m ** 3; s = s ** 3;
var r = l * +4.0767416621 + m * -3.3077115913 + s * +0.2309699292;
var g = l * -1.2684380046 + m * +2.6097574011 + s * -0.3413193965;
var b = l * -0.0041960863 + m * -0.7034186147 + s * +1.7076147010;
// Convert linear RGB values returned from oklab math to sRGB for our use before returning them:
r = 255 * linearToGamma(r); g = 255 * linearToGamma(g); b = 255 * linearToGamma(b);
// OPTION: clamp r g and b values to the range 0-255; but if you use the values immediately to draw, JavaScript clamps them on use:
r = clamp(r, 0, 255); g = clamp(g, 0, 255); b = clamp(b, 0, 255);
// OPTION: round the values. May not be necessary if you use them immediately for rendering in JavaScript, as JavaScript (also) discards decimals on render:
r = Math.round(r); g = Math.round(g); b = Math.round(b);
return {r, g, b};
}
its flat out easier
to paint oklab to a canvas
then read the pixel colors
as uint8
then convert that to HEX
austere talon
much slower tho probably
austere talon
i mean it shouldn't matter but still
left sequoia
austere talon
```js
function clamp(value, min, max) {
return Math.max(Math.min(value, max), ...
we should see if this works
we need it for Vesktop anyway
and you could also use it for your PR
left sequoia
except for the part
where its inside vesktop only
and not a utility
and except for the part where noone is actually reviewing the PR
ยฏ_(ใ)_/ยฏ
also fuck the new refresh is fucking LAGGY
left sequoia
const {arr2hex}=await import('https://esm.sh/uint8-util')
const canvas = document.createElement("canvas")
const ctx = canvas.getContext("2d")
canvas.width = 1
canvas.height = 1
ctx.fillStyle = 'oklab(0.323409 0.00288205 -0.0101295)'
ctx.fillRect(0, 0, 1, 1)
const img = ctx.getImageData(0, 0, 1, 1)
const color = console.log("#"+arr2hex(img.data))
#323239ff
ez
its actually #323238ff but its close enough
considering the colorspace conversion
ah, so thats why my discord is lagging
austere talon
what am i looking at
left sequoia
discord having a spasm
and constantly re-mounting some padding component
which is re-painting the entire window each frame
i'm doing nothing btw
austere talon
is that why it's lagging with css
when I was debugging performance it had so many long recalculate style entries
that's why I even thought of CSS being the culprit (and it was), but Discord has to be doing something wrong to cause this
left sequoia
is that why it's lagging with css
nah its one of many things
css being laggy is another story
i fixed it for the most part by simply doing
* {
will-change: scroll-position
}
that removed all scrolling perf problems
but there are still quite a bit more issues
typing for some reason re-paints the userlist sidebar for each character
and if you're connected to VC, some icons on the left
austere talon
i fixed it for the most part by simply doing
```css
* {
will-change: scroll-posi...
* {
will-change: all;
}
u cant stop me
almost as insane as nookies' plugin that memoises every discord component
austere talon
i fixed it for the most part by simply doing
```css
* {
will-change: scroll-posi...
idk if placebo or not but this really feels better
left sequoia
fortunately all doesnt exist, but if it did, it would work the same way as transition all, which means it would apply to stuff like transform, which means it would RESET EACH Z INDEX CONTEXT FOR EACH COMPONENT
left sequoia
idk if placebo or not but this really feels better
open dev tools, open rendering tab, enable paint flashing
and scroll chat
with and without that css
will-change scroll-position doesnt change z index contexts, it preserves them, while rendering scrolling via GPU, so its actually a "free performance" css flag
austere talon
would probably be better to only apply to the right elements tho, no?
and if it actually makes a difference, why don't they do it
left sequoia
there are very very rare edge cases where that's not the case, but thats only if you were already using will-change or are using transforms on weird properies
left sequoia
and if it actually makes a difference, why don't they do it
i cant tell if you're pretenting or are actually that stupid?
austere talon
would probably be better to only apply to the right elements tho, no?
urs seems like it would override other will-change directives
left sequoia
you're expecting basic competence from discord developers?
you're insane
left sequoia
urs seems like it would override other will-change directives
yes, thats exactly why its not backwards compatible, all other will-change properies reset the z-index context
so overriding it, means you no longer reset the z-index context
which is in theory breaking
fortunately discord developers are too retarded to use semi-modern css, so they never used that property
so this is trully a "free perf" case for discord
austere talon
nah they have it a few times
left sequoia
will-change opacity is rarely useful, because taht only helps when going from not having opacity defined, to having opacity defined
which you'd never do
aka when switching rendering contexts from CPU to GPU
transform3d is useless, because you'd already have it defined too
transform can be useful for togglable animations, but rarely does much
austere talon
will-change opacity is rarely useful, because taht only helps when going from no...
yeah I was wondering about this
since opacity should already be GPU accelerated
left sequoia
^
as u linked above
its good if u dont want to use the transform hack
because it'd override ur other transforms you'd have in animations
but if you havea animations that switch between trasnforms you have other issues
it can be useful if you're doing perspective shit, but discord doesnt do parallax
austere talon
because it'd override ur other transforms you'd have in animations
i wish css had a way to not override
left sequoia
will-change contents is unironically good, but difficult to use
austere talon
have properties cascade
austere talon
nono
i mean have a way to merge them
.foo {
transform: translateX(10px);
}
.bar .foo {
transform: translateY(10px) attr(transform);
}
something like this
left sequoia
ah, propery merging
austere talon
idk how the syntax / naming would look
austere talon
no it'd be opt in
via some function
like attr(transform)
by default it doesn't merge but you can merge
left sequoia
if you need to opt into it, you might as well just write the transform with multiple properies
austere talon
effort
left sequoia
1:1 the same effort
you'd need to spare effort to opt in anwaysy
anyways, review webpwa
austere talon
dont whip me motherfucker
left sequoia
awww
you like that, dont ya
man cant do any suggestive wording
shit gets blocked
i saw ur spendings
50% anime waifu figurines, 30% food, 20% renting a dominatrix
left sequoia
nah im unhinged
there's a difference
i'm highly functional, insane people arent
left sequoia
does userscript have is_extension defined as true?
austere talon
nop
austere talon
yes
austere talon
grave mangoBOT
it's used for this
https://github.com/Vendicated/Vencord/blob/main/src/utils/web...
web-metadata.ts: Lines 7-19
export let EXTENSION_BASE_URL: string;
export let EXTENSION_VERSION: string;
if (IS_EXTENSION) {
const listener = (e: MessageEvent) => {
if (e.data?.type === "vencord:meta") {
({ EXTENSION_BASE_URL, EXTENSION_VERSION } = e.data.meta);
window.removeEventListener("message", listener);
}
};
window.addEventListener("message", listener);
}
content.js: Lines 14-20
window.postMessage({
type: "vencord:meta",
meta: {
EXTENSION_VERSION: browser.runtime.getManifest().version,
EXTENSION_BASE_URL: browser.runtime.getURL(""),
}
});
yah i know, i also use it in my plugin
because you dont have an "extension only" build target
because web is both vesktop and extension
austere talon
it makes sense
vesktop is considered both desktop and web
because all web plugins also make sense on vesktop
left sequoia
yeah but ur build targets should be singular, like all compilers do it, and instead have targets defined as array
so instead of doing .web
austere talon
there's a more specific tag for DiscordDesktop only / Vesktop only but for web there was never a use case for this
austere talon
cant really think of any other use case than pwa
left sequoia
im sure people would come out with some extension specific plugins
but extension interest overall is low
austere talon
why cant the PWA work on userscript? besides shortcuts I don't see anything that wouldn't work there
charred monolithBOT
This plugin lets you quickly view role members through a submenu in two contexts:
Dev Context Menu
Message Context Menu
Key Technical Points:
- Chunked Fetching:
Uses FluxDispatcher to dispatch multipleGUILD_MEMBERS_REQUESTevents, ensuring ...
left sequoia
why cant the PWA work on userscript? besides shortcuts I don't see anything that...
i think same reason that css doesnt work in us
URL.createObjectURL
austere talon
oh does CSP lock it
left sequoia
yes
austere talon
ah okay and this is the only way to get pwa working?
left sequoia
yep
it needs to be a specific link element mounted to dom
only way
there actually also used to be a service worker requirement
but they removed that
as in W3C did
austere talon
TamperMonkey has a CSP bypass but idk if it will work for this
austere talon
i think it's only for GM_* functions
left sequoia
and ff doesnt have any of these features
austere talon
why is ff so bad
left sequoia
uuuuh
its bad because it doesnt support a fuckload of W3C standards
but i think your question is more of "why do they arrive at those decisions"
austere talon
URL.createObjectURL
have you tried a data url instead of a blob
left sequoia
but that's not public knowledge, for the most part i assume they dont like draft specs that chrome suggests
austere talon
idk if discord csp also blocks data urls
left sequoia
have you tried a data url instead of a blob
no because i have little interest in userscripts
and even less in making only 1/2 a plugin work on userscript only
and then making coniditonal userscript checks for ff and chrome
its just asking for cancer and confusion
especially considering i patch the borwserNotice component
i guess that could be conditional too
uuugh
shivers
naah
if you introduce a separate userscript and extension build target i could
but that means there would be 2 plugins for this
or 3 probably for the core functionality, unless you're okay with importing utility functions across plugins
median rapids
<@852892297661906993> btw are you actually using that plugin
i wasn't but i will now :p
left sequoia
@austere talon sry for ping, but considering, should this be enabled by default? it feels like the notifications and keybinds should be at least... when looking at other force enabled plugins i'm torn on it
like web context, keybinds and screenshare are, and they fix... what discord is missing and rly should have anyways
this... kinda feels like that? but not all of it?
idk
since you said you'll review it, i'm putting actual effort into this, https://cdn.discordapp.com/emojis/1207393766458007562.webp?size=48&name=kekwolf
odd heath
true
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
frail skyBOT
frail skyBOT
limber skiff
wait ehh that's the wrong commit
left sequoia
shit, what inspired every1 to fix their css all at once all of a sudden
fossil inlet
shit, what inspired every1 to fix their css all at once all of a sudden
Lag
left sequoia
not1 gave a fuck before tho
rugged spire
begging for y'all to just come up with One Good Solution soon
limber skiff
shit, what inspired every1 to fix their css all at once all of a sudden
that was unrelated lol
dusk blaze
AI pr desc
rugged spire
so true
left sequoia
that was unrelated lol
?
dusk blaze
@rugged spire i will take all good solutions add into InRole and make it the ultimate role member viewing plugin
fossil inlet
Isn't there already an open PR for this that isn't AI slop
dusk blaze
speaking of which i need to merge ryfters pr
rugged spire
<@259558259491340288> i will take all good solutions add into InRole and make it...
the name for it is horror
rugged spire
speaking of which i need to merge ryfters pr
oh so something did get sorted out?
dusk blaze
oh so something did get sorted out?
he PRed improvements of his plugin to mine
ill merge today probably
rugged spire
i should make a rolepopouts plugin
dusk blaze
i do feel like a plugin like this should not be in upstream
soooo many will ask "why doesn't it have all members"
rugged spire
soooo many will ask "why doesn't it have all members"
add disclaimer icon to modal header
maybe make default enabled hidden setting to show a warning
doesnt have to be hidden
just set a description that explains that it shows a warning to stop people complaining in #๐ฅ-vencord-support-๐ฅ
left sequoia
idk
just seen like 3 commits related to css perf
then every1 in theme dev is suddenly rallied around perf
scenic brook
Because a ton of people's discords have been horribly laggy all of a sudden the last few days and fixing the css fixes it
rugged spire
i should make a rolepopouts plugin
I REALLY want to do this but I can tell it will just be recreating stock UI. PermissionViewer reuse, and a lot of FriendBar components
surreal fiber
then every1 in theme dev is suddenly rallied around perf
I was having perf issues even before discord did a discord - perf on on linux is just not as good as I had on windows but might be my cpu/gpu is just clocking much lower when "idle" on linux idk
rugged spire
i will not
rugged spire
guh
it does use member ids endpoint
it's so rare to see somone mention a role anyway
limber skiff
@median rapids I think memoize all breaks mentions lol
median rapids
<@852892297661906993> I think memoize all breaks mentions lol
@median rapids
works for me
oh clicking them
yeah it does lol
limber skiff
(the plugin leaks memory rn too)
median rapids
(the plugin leaks memory rn too)
yk funnily
they still work in embeds
maybe it's placebo but server switching does seem a little faster
it also breaks clicking the xxx new messages bar
limber skiff
๐ญ
median rapids
checked it out :3
austere talon
lol that's copy pasted from StickerCloner https://github.com/Vendicated/Vencord/blob/main/src/plugins/emoteCloner/index.tsx#L59
grave mangoBOT
lol that's copy pasted from StickerCloner https://github.com/Vendicated/Vencord/...
index.tsx: Line 59
return `${window.GLOBAL_ENV.MEDIA_PROXY_ENDPOINT}/stickers/${data.id}.${StickerExt[data.format_type]}?size=4096&lossless=true`;
shell shuttle
lol that's copy pasted from StickerCloner https://github.com/Vendicated/Vencord/...
i used it as a base for learning how menu components work
shell shuttle
checked it out :3
yay will fix tmr
the reason i downscaled to 2k is that it's massive in the chat
but i'll set it back
limber skiff
client theme causes massive lag when starting
and I noticed discord is taking longer to load initially too
it might be because of it
I swear to god why is it not aligned again
austere talon
client theme causes massive lag when starting
horror
shell shuttle
limber skiff
actually I want yall opinions
austere talon
maybe im retarded but they look the same to me
austere talon
the timestamp looks misaligned in the first
limber skiff
maybe im retarded but they look the same to me
nah pay attention to the center of the volume icon and the "Today" text
austere talon
yea
limber skiff
the timestamp looks misaligned in the first
exactlyy lmao
when it's perfectly centered it looks worse
austere talon
welcome to the reality of design lmao
actually centered doesn't necessarily mean it looks centered
fossil inlet
20000 force pushes
austere talon
we love
I hate how force push fucks up pr sorting ๐ญ
cause it updates all prs
so it resets the last updated
glass jasper
20000 force pushes <:blobcatcozy:1026533070955872337>
imma make a selfapp to watch this channel and log all of the force pushes and who does it and then make a graph with that data
median rapids
do
limber skiff
it's always gonna be me
median rapids
make the graph but it actually logs nookies mistakes
fossil inlet
?remind 7.5hr bump pr
shut vineBOT
Alright @fossil inlet, in 7 hours and 30 minutes: bump pr
charred monolithBOT
rugged spire
what have you been force pushing ๐ญ
shut vineBOT
@fossil inlet, <t:1738564087:R>: bump pr
jolly egret
Even though its now a weekday, we should probably push a tag, the last couple times they have reviewed quite quickly so chances are we'll get it in before anything super breaking hits
granite sky
Is this supposed to be like this?
charred monolithBOT
Yop, decorations without trying to override original ones are good
The only thing that seems to be weird for me is that [ADMIN] comes before [APP], but it messages it goes in another direction
The only thing left is profiles, which currently requires 3 patches
( 1st is to make discord use our tags, 2nd to p...
charred monolithBOT
limber skiff
that ^
granite sky
you love off by one errors
Idk, seems right for me
limber skiff
or SelectedGuildStore if you only need guild id
granite sky
I didn't knew it existed
limber skiff
but question, why is guild/channel needed?
granite sky
Fire
granite sky
but question, why is guild/channel needed?
to get permissions
limber skiff
ahh, right
charred monolithBOT
Also profiles don't have any tags by default, so [APP] tags are missing there
I might just render 2 tags at the same time to stay consistent with every other field, but it is worth it?
charred monolithBOT
glass jasper
lint fail
scenic brook
Yeah I missed a type
fossil inlet
@scenic brook did they change on discords end?
scenic brook
Should be good now
Yeah
As opposed to js return e[e.MESSAGE = 0] = "MESSAGE", e[e.SUCCESS = 1] = "SUCCESS", e[e.FAILURE = 2] = "FAILURE", before
formatting smh
Third time lucky
shell shuttle
@median rapids can u send me an example of a sticker using the cdn
i have no idea how to find the url for it ๐ญ
wait nvm i could go to the docs it probaly has it
median rapids
<@852892297661906993> can u send me an example of a sticker using the cdn
its the same
but yeah
odd heath
copy discord code
render
crash
granite sky
is this valid
Wouldn't it just return 3 no matter what?
shell shuttle
Wouldn't it just return 3 no matter what?
are stickers always uploaded as LOTTIE's?
im not sure
cuz like
uhhhhh
granite sky
shell shuttle
i want it to check if it isnt a png or lottie
and then change it to the other endpoint
sterile oak
is this valid
in a programming perspective it doesn't seem right, but I won't be suprised if it did work
granite sky
![1,3].includes(data.format_type) - ?
scenic brook
in a programming perspective it doesn't seem right, but I won't be suprised if i...
It'd just evaluate to if(3) all the time like hen said
sterile oak
keep it simple, !(data.format_type === 1 || data.format_type === 3);
sterile oak
how do you- nvm
granite sky
![1,3].includes(data.format_type) - ?
I would prefer this one, but yeah
long stream
are stickers always uploaded as LOTTIE's?
nop
most if not all stickers are just images
idk if you can still upload lottie stickers
median rapids
is this valid
this does not do what you think it does ๐ญ
median rapids
and then change it to the other endpoint
why ru doing this backwards dawg
just check if it's a gif and use media proxy, otherwise use cdn
fossil inlet
is this valid
๐ญ
jolly egret
i've been too lazy to do that but i wanted to
fossil inlet
didnt know that was even possible
brazen bone
Wtf
jolly egret
are you shocked at the code quality or the fact that you can even do that
brazen bone
That you can do it
sterile oak
is there a reason of why those two are the same but with different names?
nvm ig vencord web is outdated
austere talon
the plugin was renamed
limber skiff
or better yet just generate a snowflake
jolly egret
i mean yeah that works but its not a snowflake on discords end so generating a snowflake is kinda redundant
it just happens that the current attachment's length is the expected value (its just adding one, not reordering), though anything bigger than the current attachment count works
limber skiff
ugh
jolly egret
damn
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/a3ee0784e29a78f7a1c124628e6964d0c13c3...
SearchModal.tsx: Lines 604-619
const setSelectedCallback = useCallback((e: DestinationItem) => {
setSelected((currentSelected: DestinationItem[]) => {
const index = currentSelected.findIndex(item => {
const { type, id } = item;
return type === e.type && id === e.id;
});
if (index === -1) {
return [e, ...currentSelected];
}
currentSelected.splice(index, 1);
return [...currentSelected];
});
}, []);
thanks
so can someone explain to me how it causes a TypeError: Cannot read properties of undefined (reading 'length')
i dont fucking get it
fossil inlet
so can someone explain to me how it causes a TypeError: Cannot read properties o...
My guess is that currentSelected is undefined and it errors when spread
odd heath
nop
it doesnt get executed
i can put error throws and console logs none of them do anything when that error happens
neither does changing the dep array do anything
odd heath
and if i remove the usecallback react complains about rendering less components than expected
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
odd heath
guhhhhh this is making me go insane
limber skiff
vtest dev2
nimble pendantBOT
vtest dev2
Now testing!
limber skiff
ughhhhhh
jolly egret
Multiple people have been complaining about NotificationVolume not working but i don't really wanna test it right now, just thought i'd put it here if it is an actual issue (reporter says nothing so idk if its just user error)
limber skiff
vtest
frail skyBOT
frail skyBOT
limber skiff
@quasi surge there you go
jolly egret
imagine not getting it right now you have to wait another week
fossil inlet
<@521819891141967883> why does it throw
a sole leading backslash can escape the capturing group created by \i, leading to a regex syntax error
patch helper used RegExp(//) as a syntax check
and \\i is valid regex
fossil inlet
@rugged spire soon
fossil inlet
@rugged spire thoughts?
charred monolithBOT
So discord usesRemSizies in messages, so should I
Manual padding by .1rem from the bottom is not perfect, but without it it looks really off-set
fossil inlet
<@259558259491340288> thoughts?
@scenic brook you might also be intrested in this
granite sky
@limber skiff look at my screenshot here, that's where i returned remSizes
In the member list discord uses px for sizing
In messages - rem
limber skiff
the height is still different
and that's causing you to have to apply bottom to center
unless it's because the API centers it badly...
hmm I will have to see
granite sky
the height is still different
Is it?
granite sky
unless it's because the API centers it badly...
Discord adds it's own offset if that's what are you talking about
.botTag_bla { position: relative; top: .1rem }
That's where bottom: .1rem comes from
It's an issue with tags themselves, not an api
granite sky
use inspect elements and check the sizes
I'm not home, but when i checked it was the same
I use same props as discord does
limber skiff
does the component itself without the classes have that offset?
granite sky
But I've removed classes as you've told me
granite sky
does the component itself without the classes have that offset?
Yop
granite sky
first looks a bit smaller
?remind 8pm check if this is true
shut vineBOT
Alright @granite sky, in 12 hours, 44 minutes and 18 seconds: check if this is true
granite sky
what if you set top: unset instead
Well, we will find it out in 12h44m18s 
I might actually try my horror setup to check it
granite sky
1 - discord original tag
2 - I've found a more specific thing
@limber skiff does it look better for you?
scenic brook
<@259558259491340288> thoughts?
That's cool, are you doing the regex replace in vencord or in the ide?
I kinda have to do it in vencord because my plugin is written in java and the regex engine is slightly different
jagged cloak
I kinda have to do it in vencord because my plugin is written in java and the re...
@crude hearth love?
scenic brook
Ew I just reloaded and they gave me visual refresh
crude hearth
I kinda have to do it in vencord because my plugin is written in java and the re...
how did bro write vencord plugin in java
odd heath
Multiple people have been complaining about NotificationVolume not working but i...
I've been getting audio sink errors in console that might be related
odd heath
this is broken too
cannot read properties of undefined
dunno if its just a canary bug tho
fossil inlet
That's cool, are you doing the regex replace in vencord or in the ide?
Ide
fossil inlet
<@259558259491340288> thoughts?
@odd heath do you like?
fossil inlet
I kinda have to do it in vencord because my plugin is written in java and the re...
Horror
Use some regex library
granite sky
<@259558259491340288> thoughts?
I need this
fossil inlet
I need this
It's available as a user-plugin and I'll update my version on the marketplace soon
jolly egret
I've been getting audio sink errors in console that might be related
Okay then we should probably throw something in known issues
the question is why are no patches broken then
i assume something like that would use one
fossil inlet
I've been getting audio sink errors in console that might be related
dont think so
ive been getting those for months
odd heath
dont think so
they come from the place that gets patched by notificationvolume though
idk i wouldnt be surprised if they related in some way
but im not familiar with how that stuff works
odd heath
this is broken too
someone should fix this though it spams console a lot lmao
fossil inlet
they come from the place that gets patched by notificationvolume though
I think it's a discord audio issue because I got them from the place where discord handles call audio
odd heath
I think it's a discord audio issue because I got them from the place where disco...
Yeah but if it always happens on all audio played it could prevent the plugin patch from having an effect, no?
fossil inlet
Yeah but if it always happens on all audio played it could prevent the plugin pa...
hmmmm, ill look at it later
odd heath
hmmmm, ill look at it later <:blobcatcozy:1026533070955872337>
It patches like 2 lines above the error that's why I'm saying it could be
odd heath
hmmmm, ill look at it later <:blobcatcozy:1026533070955872337>
Also please look at my PR and tell me how tf that error happens ๐ญ I'm losing my mind /srs
jolly egret
yeah something is wrong with notificationvolume 
fossil inlet
@odd heath is there an easy way to test without getting a notification
odd heath
<@708275751816003615> is there an easy way to test without getting a notificatio...
NOP
Open alt and spam dms
Also it only happens on desktop for me
scenic brook
Can you just use the preview button in notification settings?
odd heath
works fine on vesktop rn
Yeah I haven't seen any audio error on vesktop either so that'd check out
fossil inlet
Yeah I haven't seen any audio error on vesktop either so that'd check out
heres the thing
the only other time ive seen that error was on vesktop
odd heath
Guh
I had both vesktop and desktop running, vesktop only had the error for the toolbox because of canary and desktop had audio sink errors on stable, I didn't look at canary
odd heath
Hm
odd heath
<@708275751816003615> can't repro on vesktop or canary
I'll try it again if it happens for me or not
Look at my PR in the meantime pretty please :3
fossil inlet
?remind 5pm
shut vineBOT
Alright @fossil inlet, in 5 hours, 41 minutes and 27 seconds: โฆ
scenic brook
It's a pretty easy fix, I'd pr but I gotta work
odd heath
idgi
scenic brook
They just added overridePositionRef in the middle of the current popout find
odd heath
huh
the find just worked for me
did discord do a silly revert
ah no its just fixed on dev
omg im so dumb
scenic brook
Oh lol
odd heath
<@708275751816003615> can't repro on vesktop or canary
cant repro either anymore
on linux
fossil inlet
Iirc its fixed on dev
fossil inlet
Iirc its fixed on dev
Toolbox, not the audio
limber skiff
it is, yes
still maple
<@708275751816003615> is there an easy way to test without getting a notificatio...
Yes notification volume actually affect way more than notifications, by example the mute and the deafen sound or the voice channel join
(and it's why i love this plugin, i have notifications disabled, but lowering the volume of the app without lowering the volume of people is W)
limber skiff
there are two occurences ensureAudio now
_ensureAudio() {
var e;
return this._audio = null !== (e = this._audio) && void 0 !== e ? e : new Promise( (e, t) => {
let i = new Audio;
i.src = n(451343)("./".concat(this.name, ".mp3")),
i.onloadeddata = () => {
i.volume = Vencord.Plugins.plugins["NotificationVolume"].settings.store.notificationVolume / 100 * Math.min(l.Z.getOutputVolume() / 100 * this._volume, 1),
u.isPlatformEmbedded && i.setSinkId(f),
e(i)
}
,
i.onerror = () => t(Error("could not play audio")),
i.onended = () => this._destroyAudio(),
i.load()
}
),
this._audio
async _ensureAudio() {
if (null == this._ensureAudioPromise) {
let e = Vencord.Plugins.plugins["NotificationVolume"].settings.store.notificationVolume / 100 * Math.min(l.Z.getOutputVolume() / 100 * this._volume, 1);
this._ensureAudioPromise = h(this.name).then(t => null == t ? Promise.reject(Error("Failed to load audio: ".concat(this.name))) : (this._audioContext = (0,
a.N)(),
this._gain = new GainNode(this._audioContext),
this._gain.gain.value = e,
u.isPlatformEmbedded && this._audioContext.setSinkId(f),
this._buffer = t,
this._source = this._audioContext.createBufferSource(),
this._source.buffer = t,
this._source.connect(this._gain).connect(this._audioContext.destination),
this._source.loop = !1,
this._source.onended = () => this._destroyAudio(),
Promise.resolve({
context: this._audioContext,
gainNode: this._gain,
source: this._source
}))).catch( () => Promise.reject(Error("Failed to load audio: ".concat(this.name))))
}
return await this._ensureAudioPromise
}
one is the old which the plugin already patched, and which should still be working
how nice of Discord to not mangle those
limber skiff
one is the old which the plugin already patched, and which should still be worki...
and it is working
so the question is why patching WebAudioAPISound throwing errors too
one is the replacement of another
it has to be related to this
I was wrong it is this 2024-03_web_audio_api_rollout
shut vineBOT
@granite sky, <t:1738649742:R>: check if this is true
limber skiff
okay, looked into it, the setSinkId error is not caused by us and is simply malfunctioning discord code
NotificationsVolume works fine with both audio APIs
limber skiff
it still works fine even when erroring, from my tests
left sequoia
honestly, I'd consider blaming electron, I've seen this issue in electron itself when i was fucking around with barebones electron ages ago
limber skiff
sounds play normally
I tried the mute button, calls that method, plays normally and with lower sound
they are just trying to set the sink to "default"
which I'm pretty sure does not work like this and every sink has its proper id
anyways, nothing on us and everything is working
the ones complaining it doesn't work are probably from the extension
I hate to say it but ClientThemes need a rewrite too
left sequoia
they are just trying to set the sink to "default"
try looking for ||'default'
TLDR IIRC there are some cases where deviceId simply isnt returned because chromium
jolly egret
yeah i looked at it the other day and what the fuck is going on there lmao
