#šŸ‘¾-core-development

1 messages Ā· Page 232 of 1

limber skiff
#

well

#

I don't recall it breaking any time recently

#

so that's really weird

limber skiff
carmine wave
#

works on my account without nitro

limber skiff
#

alright

#

that regular color is peak

#

I love it

carmine wave
#

@limber skiff nevermind, i was out of date

#

stickers are broken, but i get a different error

limber skiff
#

oh what

carmine wave
#

guhh

#

so weird

#

wait

limber skiff
#

so an outdated build works

carmine wave
#

i may be stupid (pt2)

limber skiff
#

and the latest doesn't

carmine wave
#

vencord didnt update and i thought it did

limber skiff
#

@austere talon they accepted the extension already lol

#

hmm should we bump again

carmine wave
#

nah im crazy

#

works on new

#
  • works on old version
  • reloads discord
  • doesnt update, breaks on old verison
  • updates to new version
  • works
odd heath
#

you love randomly finding a bunch of things that are wrong with your code

austere talon
#

😭

#

oh theyre greyed out

#

what if bro disabled the sticker bypass

#

idk test on alt

glass jasper
#

@jagged reef Might be wrong about that... but still you very much should

grave mangoBOT
odd heath
#

They mean this

#

Last line

glass jasper
odd heath
#

@jagged reef

odd heath
austere talon
#

oh yeah @high oracle did you disable the current chrome version

#

1.11.0

#

we need to push 1.11.1

high oracle
#

Do you want me to?

jagged reef
#

And modernised the patches

high oracle
#

@austere talon good?

austere talon
#

for reason just write "broken release"

high oracle
#

ok

high oracle
# austere talon yea

I'm required to make this number larger than the current release, so consider releasing the next one as 1.11.2

odd heath
#

@jagged reef use #{intl::string} instead of making it the hash for the find

#

Such as here

#

Too lazy to put a review

jagged reef
#

Does it need the hashtag?

odd heath
#

Yeah

odd heath
#

Vee will merge arrays before 1.11.2 blobcatcozy

limber skiff
#

vtest

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
[Vendicated/Vencord] branch deleted: componentUpdaterAPI
#
[Vendicated/Vencord] branch deleted: partial-array-settings
#
[Vendicated/Vencord] branch deleted: plugin-apis-sugar
#
[Vendicated/Vencord] branch deleted: update-dependencies-eslint
limber skiff
#

proceeding to delete all of vencord

#

// Webpack Module 464891 - Patched by MessageDecorationsAPI, MessageLatency, ShowHiddenThings, ShowTimeoutDuration, ThemeAttributes, UserMessagesPronouns, AliucordDetector

#

holy shit lmao

fossil inlet
limber skiff
#

ya

fossil inlet
#

I think it would be funny if they all used different finds so one of them randomly breaks from time to time

dusk blaze
#

branch deleted: main

charred monolithBOT
jagged reef
austere talon
#

won't work guh

jolly egret
#

you could just revert it šŸ™„

#

first push malware to find all vencord repos and delete them on peoples system, then force push away the gh history

#

and also do the same to the mirror

jagged reef
#

New plugin!

const optimizedCode = "Y29uc29sZS5sb2coYXRvYigiV1c5MUozWmxJR0psWlc0Z2FHRmphMlZrSVE9PSIpKQ==";
eval(atob(optimizedCode));
#

not malware at all

woeful bisonBOT
#

Only the bot owner can use eval!

odd heath
#

WHY DID IT RUN THAT

#

STUPID

dusk blaze
glass jasper
dusk blaze
fossil inlet
dusk blaze
jolly egret
#

fake

austere talon
#

oh yeah @limber skiff im gonna push new tag rn

#

vtest main

nimble pendantBOT
limber skiff
#

uhh

#

directly to main?

austere talon
#

yes

limber skiff
#

we are gonna have to force push dev after

austere talon
#

we dont want dev changes yet

limber skiff
#

and thats gonna cause so many conflicts in some prs lol

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

just merge commit

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
[Vendicated/Vencord] New tag created: v1.11.2
austere talon
#

(had to skip .1 cause chrome makes you re-version the old version)

#

this 1.11.1 is actually 1.9.10

jolly egret
#

moment

dusk blaze
charred monolithBOT
limber skiff
#

love it

charred monolithBOT
limber skiff
#

merge remote-tracking vs remote branch

jolly egret
limber skiff
#

so true lmao

#

we should had been doing x.xx.xx or even x.xx.xxx

jolly egret
#

no point bumping the first number

limber skiff
#

not even the second is having much point

#

totally fake semver

dusk blaze
#

@limber skiff 1.9.9.9 and when we reach 10 we add another digit

#

1.3.6.5.9.7

jolly egret
#

i've got one better

#

we just append .1 every time we update

#

1.1.1.1.1.1.1.1.1.1.1.1

glass jasper
austere talon
#

i would leave first number 1

#

eventually we will have 1.69.420

glass jasper
# dusk blaze Vemcord 2.0 wen

And actually isn’t this technically Vencord 2… since Vee often talks about ā€œoldā€ Vencord/ oldcord?

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

he wont accept

#

so mean

limber skiff
#

lmaooo

#

I forgot about it since I have the taskbar number for it disabled

median rapids
#

evil..

austere talon
#

btw we should update preload to work with sandbox

#

then we can make vesktop sandboxed fully and if discord ever enables sandbox vencord will not have to force disable it

austere talon
rugged spire
#

ipc?

austere talon
#

so stuff like this will have to be moved to main and done via ipc

rugged spire
#

i need to get back to fixing the ugly edit function thing

#

i understand why you hate it

austere talon
rugged spire
austere talon
rugged spire
rugged spire
austere talon
rugged spire
#

?remindme 2h Nuke OverrideCSS.tsx

shut vineBOT
#

Alright @rugged spire, in 2 hours: Nuke OverrideCSS.tsx

limber skiff
austere talon
#

context isolated yes

#

sandbox no

#

but even discord doesn't use sandbox

#

but you really should

#

sandbox makes preload process very limited and run in browser sandbox too

#

without it, preload runs in node proccess which isn't as secure

#

oh also i wanna make CSP stricter

#

rn we just allow anything

#

I wanna only allow specific domains

rugged spire
#

it's way too late to do that

rugged spire
#

you will break every theme

#

even if you specify popular git hosts, there will be at least one thing you miss

#

for things like worker-src and MAYBE connect-src i understand doing it

austere talon
#

too bad

rugged spire
austere talon
#

someone download all top bd themes and analyse which domains they use

rugged spire
#

😭

#

you're gonna need at least a wildcard for github.io subdomains

austere talon
#

duh

rugged spire
#

whats the concern for anyway?

#

users tracking each other with themes?

glass jasper
austere talon
#

even Zere wants to re-enable CSP

#

this is so old

rugged spire
#

what is on that whitelist

austere talon
#

i dont think that experiment made it

glass jasper
austere talon
#

please use your brain for a second

#

Zere = BD

#

Zere wants to enable it = BD wants to enable it

#

BD wants to enable it = themes will have to migrate anyway

glass jasper
#

sobbign I’m not that stupid

austere talon
#

then dont post stupid comments

rugged spire
#

here's my thoughts

It is impossible to do this without annoying at least someone
I think the existing CSP is too strict due to it not including file: though IDK if it's possible anyway
if you want to do this as seamlessly as possible, then you must consult the community to see what hosts they use for themes. Remember that there are people in this server building their own theme hosting sites
I have no idea if this is possible, but userplugins should be able to add domains to the CSP
I think a disable CSP option would be useful, though it shouldn't be recommended to users

austere talon
#

mine now (it somehow downloaded more than 113)

rugged spire
limber skiff
#

why do they all do that...

austere talon
#
*.github.io
i.imgur.com
raw.githubusercontent.com

i removed all domains that are these three and only 32 urls left

limber skiff
#

LMAOOO

austere talon
#

trol

limber skiff
#

I suppose google fonts is also a valid one

austere talon
rugged spire
#

honestly this list could be quite simple

austere talon
#
*.github.io
i.imgur.com
raw.githubusercontent.com
fonts.googleapis.com
upload.wikimedia.org
cdn.discordapp.com
githack.com
jsdelivr.net

NOT allowing:

devevil.com ( some guys personal site bruh )
pages.dev ( you really do not need cloudflare pages for this )
rawgit.com ( dead )
statically.io ( looks sus )
cdnfonts.com ( looks sus )
limber skiff
#

look at this banger

limber skiff
#

why wikimedia tho

austere talon
#

and it's safe

rugged spire
#

i think you should also be supporting @desert cosmos's theme library

#

WHY HUSK

#

at least support codeburger

glass jasper
rugged spire
#

trust me if you push this without any testers it will be a disaster

austere talon
rugged spire
austere talon
#

that defeats the point

limber skiff
#

it really won't be as bad as you are thinking

rugged spire
#

true

#

i think you should warn people before making the changes

limber skiff
#

introducing vencord experiments

#

unironically should exist

#

and most people would enable the shit cuz everyone loves experiments

rugged spire
#

REAL

dusk blaze
glass jasper
dusk blaze
#

we got people to migrate decades ago, only targeted person was f53 and shes gone now

glass jasper
rugged spire
#

plugin UI redesign??

glass jasper
woeful sleet
# austere talon ``` *.github.io i.imgur.com raw.githubusercontent.com fonts.googleapis.com uploa...

I don't know if you saw it, but Zere did send this in response to your question earlier. Seems outdated, though https://github.com/BetterDiscord/BetterDiscord/pull/1662

GitHub

This will re-enable the Discord CSP but whitelist all currently known used remote resources. This would finally fix #442
I personally think that we should strongly encourage themes to move off of s...

woeful sleet
#

The list itself, I mean. I'm not sure how many of those image hosts are still used

rugged spire
#

full of github mirrors and someone's personal site?

#

do i not immediately know the significance of this site?

glass jasper
rugged spire
#

yeah this is font hosting

rugged spire
glass jasper
rugged spire
#

😭

#

image host dying of natural causes

glass jasper
#

OK, never mind I guess they changed some shit

#

I don’t know. I’m IP band on my computer from their website anyways

rugged spire
#

besides I have never seen an imgbb file be used in a theme

glass jasper
austere talon
rugged spire
#

or just hotlinking

glass jasper
#

I plead the fifth

charred monolithBOT
#
[Vendicated/Vencord] New branch created: strict-csp
austere talon
#

bro github has been so laggy lately

rugged spire
austere talon
#

true

#

cobu, shitlab

glass jasper
dusk blaze
#

niƱ0git

dusk blaze
austere talon
#

i ate imgur somehow

dusk blaze
glass jasper
rugged spire
austere talon
#

whats cobu pages domain

#

oh codeberg.page

glass jasper
#

no reason for it not to be

rugged spire
#

it's trusted indeed but i wish people would stop using it

dusk blaze
#

catbox

rugged spire
dusk blaze
#

every ez host/guns lol/nest rip domain

glass jasper
rugged spire
#

ok you're trolling

dusk blaze
rugged spire
glass jasper
dusk blaze
#

idiot

#

litterbox expires…

rugged spire
dusk blaze
#

i just use base64 urls

#

const DUKE_B64 reference…

dusk blaze
charred monolithBOT
glass jasper
#

calm down

austere talon
rugged spire
rugged spire
austere talon
dusk blaze
rugged spire
#

i wish public image hosting sites a very [explode]

glass jasper
# charred monolith

I wanna make another joke about including git.gay but Nin0 might not understand it

rugged spire
#

is the joke oql

dusk blaze
austere talon
rugged spire
dusk blaze
#

@austere talon will add CSP disabling to vencord premium

austere talon
charred monolithBOT
austere talon
#

GUH CONSOLE LOG

dusk blaze
#

are themes this dangerous to even restrict that way…

rugged spire
#

it's not a security issue it's a potential tracking issue

dusk blaze
#

true

austere talon
dusk blaze
# dusk blaze true

once @inland fable made a theme to share last 3 digits of userid…

rugged spire
#

just make the lists a set and and attempt to add 'self' to every list

#

trust me nothing wrong will happen

glass jasper
dusk blaze
#

@desert cosmos will start using local themes

rugged spire
dusk blaze
#

@austere talon would the csp changes mess with third party plugins considering you accidentally bombed discord

charred monolithBOT
austere talon
#

now shush

dusk blaze
#

gooood

glass jasper
#

Mb

rugged spire
dusk blaze
rugged spire
austere talon
#

that will defeat the entire point of csp

rugged spire
#

true

#

when plugin natives for browser

woeful sleet
glass jasper
dusk blaze
rugged spire
dusk blaze
#

it will communicate with some native helper exe and then UserpluginInstaller will be able to be exploited anywhere

rugged spire
#

a significant amount of plugin natives are just cors bypass anyways

glass jasper
#

Ohh

rugged spire
shell shuttle
austere talon
#

bruh

#

*.vencord.dev doesnt whitelist vencord.dev

glass jasper
rugged spire
#

doesnt exist at all

glass jasper
rugged spire
austere talon
fossil inlet
fossil inlet
#

also add pages.dev blobcatcozy

austere talon
#

no

rugged spire
#

i want to hear whats wrong with pages.dev and what themes actually use it

austere talon
#

ip logging

rugged spire
#

other than cloudflare

#

ah

#

makes sense

charred monolithBOT
austere talon
#

and there's 0 reason to use cf pages over gh pages for themes

shut vineBOT
#

@rugged spire, <t:1737679746:R>: Nuke OverrideCSS.tsx

shell shuttle
#

no looner exist slightlyfrowningfacev2

rugged spire
#

i forgot to click commit

shell shuttle
#

FOR NOW...

glass jasper
austere talon
#

maybe we can use this to remove unsafe-inline from csp list (prevents XSS) @limber skiff

#

it disables <script>hi</script> from working, you need nonce

but strict-dynamic allows any valid script tag to create scripts without nonce. so we just need to give nonce to the initial vencord script and it can create child scripts without nonce

#

inb4 discord uses unsafe-inline anyway

#

oh discord 😭 😭

austere talon
#

discord is so dumb i swear

rugged spire
#

i am so dumb

#

i am trying to use Object.entries like it is Object.entries(something).forEach

charred monolithBOT
rugged spire
#

oh thats horror

#

seems like legacy options doesnt pass the new value in onChange

fossil inlet
#

SINCE WHEN WAS THIS A THING

#

jumpscare

rugged spire
fossil inlet
#

@austere talon what did you add to the extension 😭

austere talon
#

wdym

fossil inlet
#

see the above image

austere talon
#

idk what that is

fossil inlet
limber skiff
#

oh yeah right

#

it doesn't add the change listeners for legacy option

#

only when settings are defined in the plugin object

rugged spire
limber skiff
#

nop

#

it's because of a change I did

#

didn't realize that would happen

rugged spire
#

i mean the set css after updating the value

#

when was that change

#

might want to fix MessageLogger then

charred monolithBOT
limber skiff
#

@rugged spire try that now

rugged spire
#

😭

#

i already refactored away from the options api lol

limber skiff
#

😭

#

well just make sure it still works

#

lmao

rugged spire
limber skiff
#

(saying that because I didn't test)

fossil inlet
rugged spire
austere talon
#

push permissions revoked šŸ’¢

fossil inlet
#

@rugged spire how do i open a window in CEF

window.open does nothing no matter what i do

limber skiff
#

that react thing was so evil and unexpected

rugged spire
#

i will either test before committing or ship it and make another commit after I immediately find out that I just pushed something broken

#

it works @limber skiff

limber skiff
#

good

#

lmao

rugged spire
#

i was almost about to say it doesnt work but i didnt build the code

charred monolithBOT
glass jasper
#

bruh

sly veldt
#

did not mean to advertise, sorry

#

edited the comment

rugged spire
rugged spire
#

also daily driving a feature branch is kinda ????

sly veldt
sly veldt
rugged spire
#

its just odd to do one specific branch

sly veldt
#

bc i feel like default MoreUserTags colors would bug me

rugged spire
sly veldt
#

whenever i need to update vencord i just check the pr and solve merge conflicts

sly veldt
#

i had a few ideas but because of the way i made my fork i wanted that change to be merged before working on the others

#

because using discord without it would really bug me personally

#

obviously that never happened so

#

ĀÆ_(惄)_/ĀÆ

#

i don't mind though

austere talon
#

wtf 😭

rugged spire
#

has it actually reached that many

sly veldt
#

and try them

rugged spire
#

there is my old code for some questionable plugins in there

#

being maintained somehow

sly veldt
#

i finally settled on enabling a grand total of 62

#

might even disable some

rugged spire
#

i have 50+ userplugins

#

i think

sly veldt
#

nice

rugged spire
#

57

austere talon
#

not only maintaining all those plugins but also probably fixing merge conflicts a lot 😭

sly veldt
#

i did end up enabling a couple of those plugins but most of them i didn't want

rugged spire
austere talon
#

they're gonna be in for a fun time with our new api changes

sly veldt
#

i mainly went onto it because they accepted my pr and so i get to use a maintained version xd

rugged spire
#

all i can say is Good Luck

austere talon
rugged spire
sly veldt
#

somehow they implemented my pr without breaking a few of their plugins that change usertags

rugged spire
#

i mean contrib back to upstream from it will be bombcatcozy2

rugged spire
sly veldt
rugged spire
glass jasper
rugged spire
#

the code was soooo bad

sly veldt
#

ah

glass jasper
rugged spire
#

i dont even want to maintain them because of how annoying they were

sly veldt
#

✨technical debt✨

rugged spire
#

is this part of why you dont want to try to promote it 😭

sly veldt
#

i didn't intend to advertise it but i got a ping telling me to cut it out CS_bonk

rugged spire
#

this looks horror

austere talon
#

I have multiple user plugins that are so uber shit code and I'm too lazy to make better

fossil inlet
#

Enabled Plugins (91):

AccountPanelServerProfile, AlwaysTrust, WebRichPresence (arRPC), BANger, BetterFolders, BetterGifAltText, BetterNotesBox, BetterRoleContext, BetterRoleDot, BetterSettings, BetterUploadButton, BiggerStreamPreview, BlurNSFW, CallTimer, ClearURLs, ConsoleJanitor, ConsoleShortcuts, CopyFileContents, CrashHandler, Dearrow, EmoteCloner, Experiments, FakeProfileThemes, FixYoutubeEmbeds, ForceOwnerCrown, FriendInvites, FriendsSince, FullUserInChatbox, GifPaste, iLoveSpam, ImageZoom, ImplicitRelationships, LastFMRichPresence, LoadingQuotes, MemberCount, MessageLogger, MessageTags, MoreKaomoji, MutualGroupDMs, NewGuildSettings, NoBlockedMessages, NoDevtoolsWarning, NoF1, NoProfileThemes, NoUnblockToJump, NSFWGateBypass, OpenInApp, PermissionsViewer, petpet, PictureInPicture, PinDMs, PlainFolderIcon, PlatformIndicators, QuickMention, ReactErrorDecoder, RelationshipNotifier, RevealAllSpoilers, ReverseImageSearch, ReviewDB, RoleColorEverywhere, Summaries, ServerInfo, ShikiCodeblocks, ShowConnections, ShowHiddenChannels, ShowHiddenThings, ShowMeYourName, ShowTimeoutDuration, SilentTyping, SortFriendRequests, SpotifyControls, SpotifyCrack, StartupTimings, StickerPaste, TextReplace, ThemeAttributes, Translate, TypingIndicator, TypingTweaks, UserVoiceShow, USRBG, ValidUser, VoiceChatDoubleClick, VencordToolbox, ViewIcons, ViewRaw, VoiceMessages, VolumeBooster, WebKeybinds, WebScreenShareFixes, WhoReacted
```**Enabled UserPlugins (11):**

FriendCodes, CopyFolderId, CopyStatusUrls, CtrlEnterSave, EmojiOnMouseUp, IconViewer, UnitConverter, ShowChars, StaticTitle, UrbanDictionary, UserDevCompanion

#

GUHH HOW DID 20000 pluygins appear

#

i had like 50 last time i checked

rugged spire
#

i have too many plugins to use that command

fossil inlet
#

@dusk blaze i have been running urban dictionary plugin as user plugin because userapps suck

austere talon
#

the horror

charred monolithBOT
jolly egret
#

and now all 4 of my open PRs are actually ready

#

and i go bed because i have scrubbed 300 issues in a couple hours in a different repo and now fixed by PRs and now its nearly 5am

#

gn chat

fossil inlet
#

?remind saturday bump a random pr

shut vineBOT
#

Alright @fossil inlet, in 2 days: bump a random pr

jolly egret
#

hey you should merge my PRs they're all small things that would never break stuff Clueless

limber skiff
#

I thought I had merged 2928 already lmao

sly veldt
#

breaking stuff is actually completely impossible

#

it's a myth

#

trust

jolly egret
glass jasper
austere talon
#

PR roulette (merge random pr without reviewing)

fossil inlet
#

hold on, let me open 10 token loggers

sly veldt
#

wait for it to so-called "break something"

grave mangoBOT
rugged spire
#

@fossil inlet i'm lagging ur token....

fossil inlet
sly veldt
#

@austere talon your goofy token automod regex thought my joke fake token i pasted in here for the memes was real and muted me for 10 minutes

austere talon
sly veldt
#

i trolled myself

rugged spire
#

your fake token got stolen....

sly veldt
#

don't look at automod logs or else you'll get rickrolled

#

i searched about the token automod while i was muted

#

and found that

#

no way am i running that

sly veldt
#

i see

#

fun

sly veldt
#

normal deobfuscators don't do shit for jsfuck

#

bruh and the second one they posted just deobfuscates to the first one

grizzled halo
#

was the google chrome extension submitted? it said it updated yet its still the old version

fossil inlet
grizzled halo
#

so tldr its not out because issues

fossil inlet
#

its out of date rn

#

it will be up to date when the webstore says 1.11.2

fossil inlet
grizzled halo
#

alright

scenic brook
#

lol I've still been running this stupid plugin categories fork in my personal so now I'm gonna have conflicts in every plugin with this apis change

limber skiff
jolly egret
#

huh they are doing it fast recently

odd heath
desert cosmos
jolly egret
sly veldt
rugged spire
odd heath
austere talon
#

wtf Google is so fast reviewing

#

new version already approved

odd heath
scenic brook
#

damn

austere talon
#

sometimes they take ages, other times they review in less than a day

#

they're just like me šŸ’•

jolly egret
#

lol

odd heath
#

Lmao

dusk blaze
limber skiff
#

they need to start being like me and accept without review

#

(kidding)

charred monolithBOT
limber skiff
#

I wanna add array support for finds again, once vesktop is ready for it

jolly egret
odd heath
#

And mine

dusk blaze
#

and mine

scenic brook
#

Not mine

opaque silo
#

make merge roulette bot

#

randomly merge one pr a day

#

will merge all prs in less than a year!

odd heath
#

True

granite sky
jolly egret
#

it can't even render the diff despairge

glass jasper
long stream
#

that one manti pr from 2022:

charred monolithBOT
limber skiff
#

do we still want usrbg

#

I feel like it's just so bad to use

#

Decor for example is so practical and easy

#

usrbg you gotta join their server

#

and no idea how the process even is after that

austere talon
#

people like it

#

no point removing xD

limber skiff
#

well

#

if anything, this seems so mediocre and unprofessional

austere talon
scenic brook
#

Could just make it a nicer looking link button

limber skiff
#

they should have a API for requesting stuff we could use to make a proper UI

austere talon
# limber skiff

@cunning canyon you could make an api endpoint for submitting banner via discord oauth maybe

#

i was gonna ping katlyn too but shes not here anymore

limber skiff
#

does autumn have anything to do with black-box?

#

Do not ask me about getting banned in Black Box, I am not even in the server.

glass jasper
austere talon
#

like I said I was gonna ping her too but she left xD

limber skiff
limber skiff
#

vtest

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

finally a day without breakage

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

and they just pushed stable šŸ™

jolly egret
#

lets go

#

okay now to merge every PR without checking if they still work 😁

limber skiff
#

bet

#

nvm gotta review

odd heath
limber skiff
#

okay ngl this setting is weird

#

cuz then this one is super confusing

#

okay I know what to do

#

@jolly egret rename ignoreIgnoredMessages to applyToIgnoredUsers, then rename and migrate ignoreBlockedMessages to ignoreIncoming

#

I'll review again once you do it

jolly egret
#

I just rm rfed my Linux system intentionally and now you look at it? 😭

#

will fix it when I reinstall

limber skiff
#

LMAOO

#

I mean if you want me to do it I can

fossil inlet
#

if so, deserved

fossil inlet
austere talon
#

this is so annoying

limber skiff
#

god I hate trailing commas

fossil inlet
austere talon
#

should we just upload the favicons to github and import

limber skiff
#

but all of message logger is like that

fossil inlet
#

trailing commas so good

limber skiff
#

we really need better linting rules 😭

fossil inlet
#

yop

#

eslint so good

austere talon
limber skiff
austere talon
#

trailing commas prevent merge conflicts

fossil inlet
limber skiff
#

hmm

austere talon
#

yeah that too

#

trailing commas have advantages but still idont like how they look xD

limber skiff
#

I would accept them if it's everywhere

#

but this inconsistency

#

I hate it

#

can we please just add more linting rules and modify all files in a commit

#

😭

austere talon
#

i deliberately didn't make them too strict tbh

fossil inlet
#

why?

austere talon
#

cause too strict is annoying

limber skiff
#

yeah but right now it's wayy too un-strict

limber skiff
fossil inlet
#

tbh i think strict is fine as long as eslint is used as the formatter

charred monolithBOT
limber skiff
#

maybe we should switch to biome

fossil inlet
#

tbh never heard of that

austere talon
#

wtf is biome

limber skiff
#

rust eslint

glass jasper
austere talon
#

but why

#

eslint is fine

fossil inlet
#

join the biome discord server to learn more trolley

limber skiff
#

eslint is so slow lol

#

but ig

austere talon
#

doesnt matter

fossil inlet
austere talon
#

eslint doesnt have to be fast

limber skiff
#

the main issue is the lint command

#

but that doesn't matter much tho

fossil inlet
#

how often do you run the command

limber skiff
#

I remember I used to always have eslint issues with the extension before

#

but honestly now days its pretty stable

#

always works

limber skiff
#

the workflows do

#

LOL

austere talon
#

see it doesnt matter

#

you only run it via ci and in the background in vscode

#

for speed doesnt matter for either of those blobcatcozy

#

if it actually has better things then maybe we can

#

but if it's just speed then waste of time 😭

austere talon
#

will use google instead ig

jagged reef
austere talon
#

doesnt have the icons

jagged reef
#

why bother with DDG?

charred monolithBOT
limber skiff
#

@jolly egret

jolly egret
#

cool

#

will look at it when my install is back lol

charred monolithBOT
jagged reef
#

Damn bruh, time flies

#

One of my PRs is already on page 8

limber skiff
#

@fossil inlet is class list some kind of fake array

fossil inlet
#
MDN Web Docs

NodeList objects are collections of nodes, usually returned by properties such as Node.childNodes and methods such as document.querySelectorAll().

limber skiff
#

can you remove the try catch and just null check for props?.target?.classList != null

#

and then do the rest normally

jagged reef
#

@glass jasper nah, Bypass DND

limber skiff
#

@fossil inlet it's even weirder now lol

#

re-uses...reuse

#

just keep the for honestly

fossil inlet
limber skiff
#

dont worry haha

long stream
#

afaik asar isn't just js soo

austere talon
#

no

charred monolithBOT
austere talon
#

.includes() anyone??

limber skiff
#

LOOL

fossil inlet
#

you love

limber skiff
#

omg I didnt even notice

austere talon
#

also .classList.contains()

#

and this optional chaining makes no sense

#

"href" in undefined throws an error

limber skiff
#

that doesnt matter much but yeah

#

hold on what is the type of target @fossil inlet

fossil inlet
#

element

austere talon
#

props.target?.classList.contains("emoji")

limber skiff
#

it's this then

fossil inlet
#

guhhhh somehow i missed that husk

limber skiff
#

I'm gonna just in case target is somehow something else

#

better be prepared than not be

fossil inlet
charred monolithBOT
#

e45b867 ServerInfo: Add Ignored Users tab (#3127) - jamesbt365
7ee70e8 MessageLogger: Make collapseDeleted require a r... - jamesbt365
79cbfe9 HideAttachments, UnsupressEmbeds: Work with for... - jamesbt365
4036fba ConsoleJanitor: Remove old patch and add getLas... - sadan4
aac5242 ImageZoom: Fix incorrectly adding context menu ... - sadan4

limber skiff
#

goddd

#

might as well use indexOf(...) != -1 instead

austere talon
#

it looks like there's a space before ?

limber skiff
#

Fira Code

#

with ligatures

fossil inlet
#

is it monospaced?

limber skiff
#

I dont think so

fossil inlet
#

horror

charred monolithBOT
limber skiff
#

ImageZoom also has to be fixed for the new ImageModal

austere talon
#

is that even stable

#

do people have natural rollout

fossil inlet
limber skiff
#

yeah some people do

fossil inlet
#

not sure how to check

#

is it even worth fixing while its still an experiment

odd heath
#

i thought it did

#

but probably in a husk way

limber skiff
limber skiff
odd heath
#

average shitcord moment

#

we should probably also hide the zoom icon at the bottom then

fossil inlet
limber skiff
#

CallTimer does not like long times

fossil inlet
#

how does that even happen in the first place 😭

limber skiff
#

well...

odd heath
#

instead of having it on right click

charred monolithBOT
limber skiff
#

this is genuinely pretty good

#

besides it using generator functions which isn't really needed

austere talon
austere talon
fossil inlet
#

@sterile oak why did you use generators?

odd heath
#

or well

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

odd heath
#

i knew it was i just didnt know the function* syntax n stuff

fossil inlet
#

i knew they were thing, but never had a use for them

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

this one is just dead

austere talon
#

and google cant get imgops favicon 😭

fossil inlet
limber skiff
#

I really love all the idea behind it

#

but it's just too much...

austere talon
#

but where

#

what if static.vencord.dev

austere talon
#

replies to reviewdb is such a horrifying idea 😭

crude hearth
fossil inlet
#

vencord force push log blobcatcozy

crude hearth
#

Anyway I dont really care about rdb much rn

#

I try to do different stuff

austere talon
#

reviewdb deleted

fossil inlet
crude hearth
#

I made Nin0 slave to handle reports and I havent written any rdb code in the past months

austere talon
#

discord emojis unironically such a good cdn

#

nah I think we should really introduce static.vencord.dev but how do we best store the images? git repo kinda sucks for binary data

limber skiff
#

@rugged spire

WhoReacted, TypingIndicator: Fix typing in message user box activating parent Clickable handlers

I dont get this PR title... WhoReacted and TypingIndicator, yet "message user box"?

limber skiff
#

also if this is to avoid some propagation, shouldnt it add in the top most div to also include the dots element below

austere talon
#

storage is easy

#

but how do we allow plugin devs to upload

crude hearth
#

So you wont bankrupt

#

:(

austere talon
#

and i would like to have some form of repo so it's easy to transfer between devices and for other people to host

fossil inlet
glass jasper
crude hearth
fossil inlet
crude hearth
#

Drag drop to github issues get link and use that

#

Btw whats the topic too lazy to read

austere talon
#

vencord is meant to be foss anyone can host

if plugins start depending on some vencord cdn that isn't drop in replace, it's no longer easily hostable by others

#

if that makes sense

fossil inlet
limber skiff
#

yes I know, but what does the chat bar have to do with those plugins?

#

they dont touch it

fossil inlet
#

the chat bar has nothing to do with it

#

i think they are talking about this typing indicator

limber skiff
#

the PR title mentions on it so

fossil inlet
#

when you click on it, it opens the users profile

limber skiff
#

I do get the PR purpose, just not the title

jolly egret
#

Okay i have to use --disable-gpu but we are almost back

#

šŸ”„

fossil inlet
#

or novideo moment

jolly egret
austere talon
#

as for allowing plugin devs to upload media

#

we can make some venbot command for it

fossil inlet
#

why not just an assets repo on the vencord org

austere talon
#

and a mod has to accept it

austere talon
#

😭

#

storing hundreds of images is a horror idea

glass jasper
#

I still think think we should have a Vencord File Uploader like Ez or PixelVault prayingcar

crude hearth
#

Git LFS

austere talon
#

LFS is literally a git extension

crude hearth
#

Yes

#

But

#

Its git

austere talon
#

and LFS is horror because it's no different than uploading to some shit like cloudflare

crude hearth
#

Just link it to your main repo

#

So if people recursively clone it will get that too

#

ALSO WHAT ARE YOU GONNA STORE

austere talon
#

images stupit

crude hearth
#

what images

limber skiff
#

šŸ—æšŸ—æšŸ—æšŸ—æšŸ—æšŸ—æšŸ—æšŸ—æ

austere talon
limber skiff
#

I gotta start using moyai more

austere talon
limber skiff
#

GOD

#

YOU SCARED THE FUCK OUT OF ME

#

LOL

crude hearth
#

Its german word

#

Means bro

austere talon
#

i think he got scared cause of vine boom

limber skiff
fossil inlet
#

does moyai trigger on any emoji that contains moyai

limber skiff
#

what does optimistic even mean

austere talon
crude hearth
#

Anyway time to go

limber skiff
austere talon
#

you know how when your message is still sending it displays but greyed out

crude hearth
#

@austere talon git lfs

charred monolithBOT
fossil inlet
austere talon
#

discord dispatches multiple events every time u send a message

limber skiff
austere talon
#

thats why u gotta check optimistic and state == "SENT"

austere talon
limber skiff
#

lmaoo

#

funny

glass jasper
hollow wing
#

this will get 100 members/role, inrole will get 100 members/server

limber skiff
#

doesn't this need some permission in the guild

long stream
#

i remember someone else making a plugin like that

#

@dusk blaze i think it was u?

glass jasper
hollow wing
long stream
#

o xd

fossil inlet
# hollow wing

does it work in a guild where you dont have audit log role

#

?remind 12pm right-click to clear filters in members tab

shut vineBOT
#

Alright @fossil inlet, in 16 hours, 1 minute and 55 seconds: right-click to clear filters in members tab

hollow wing
fossil inlet
#

error boundary jumpscare

hollow wing
fossil inlet
#

@austere talon add venbot command to check if the chrome extension is up to date

dusk blaze
#

quite scuffed tho because it checks on cached members

fossil inlet
#

WHY HUSK

dusk blaze
#

so you need to go on a scrolling rampage to cache more members blobCatCozy

long stream
#

right weren't u using a gateway event for that xd

dusk blaze
austere talon
fossil inlet
somber thorn
#

why even look at the google api if you can just request github commit history and look at most recent tag push

limber skiff
#

web scrape it

#

šŸ˜›

somber thorn
austere talon
#

😭

fossil inlet
#

@austere talon the version is returned in the raw html file

austere talon
#

scraping this would be soo fun

limber skiff
#

😭

odd heath
#

husk

long stream
#

just make a regex for it
then wonder why it suddenly doesn't work after you add another .1

long stream
odd heath
#

hate

long stream
#

aka u don't touch our precious boring website MikaXD

austere talon
#

it's not minification

#

it's deliberate obfuscation

long stream
#

that's why i put in quotation marks :p

limber skiff
fossil inlet
odd heath
#

or am i dum

limber skiff
#

thats the regex

#

lol

jolly egret
#

how do you migrate settings again

odd heath
limber skiff
#

migratePluginSettings

jolly egret
#

ty

golden gulch
limber skiff