#👾-core-development

1 messages · Page 231 of 1

charred monolithBOT
rugged spire
#

I learned the hard way why plugin creation date is not stored in PluginMeta

scenic brook
#

I did do that initially but I took it away because I was closing the popout anyway lol

#

I don't mind keeping it open though

scenic brook
scenic brook
#

Added it as an option to keep the menu open, that way I also don't have to redo the readme gif lol

charred monolithBOT
fossil inlet
#

@cunning canyon does your pr fix this issue (i can repro)
if not, i have the time to fix it rn

cunning canyon
fossil inlet
#

alr, ill fix it

charred monolithBOT
austere talon
#

btw can we make Application ID not required? people said just filling random fake ID works

limber skiff
#

just generate a snowflake

#

that seems more right to do

#

once plugin is initiated for the first time it generates a id

charred monolithBOT
austere talon
#

vreport dev

nimble pendantBOT
frail skyBOT
#
Bad Patches

MessageEventsAPI (had no effect):
ID: 287746
Match: ```
/(type:this.props.chatInputType.+?.then()(\i=>{.+?let (\i)=\i.\i.parse((\i),.+?let (\i)=\i.\i.getSendMessageOptionsForReply(\i);)(?<=)(({.+?})).then.+?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

MessageEventsAPI (had no effect):
ID: 287746
Match: ```
/(type:this.props.chatInputType.+?.then()(\i=>{.+?let (\i)=\i.\i.parse((\i),.+?let (\i)=\i.\i.getSendMessageOptionsForReply(\i);)(?<=)(({.+?})).then.+?)/


**__SortFriendRequests (had no effect):__**
ID: `696577`
Match: ```
/subText:(\i)(?<=user:(\i).+?)/
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

oh they pushed to main

#

did you fix that yet @limber skiff

#

cause u were looking at it yesterday

#

if not i will look into it rn

limber skiff
#

I havent looked

#

but also fix the replace loool

#

shouldClear might have to be set to false actually

#

I think the only reason it was working with true now was because it had a typo

austere talon
#

LOL

#

we just leave it with the typo 🔥

#

dont fix what's not broken

#

omg both replaces have the typo

#

how tf did i never notice

image.png
#

spellcheck even highlights

#

wait what

image.png
#

guh they changed so much

#

but it shouldnt be too hard

jolly egret
#

vreport dev

nimble pendantBOT
grizzled halo
#

3 people just reported fakenitro dyin, this known?

jolly egret
grizzled halo
#

4 now

frail skyBOT
jolly egret
#

If its MessageEventsAPI's fault then idk why we suddenly got 3 people complaining all at the same time

austere talon
#

nuckyz and i literally already talking about this

jolly egret
#

unlucky i guess

austere talon
#

okay works

#

hmm idk @limber skiff

#

i fixed typos and it still works fine

#

so idk if shouldClear should be true or false LOL

test

limber skiff
#

trigger the fake nitro modal

#

"blabla you dont have embed message permission"

odd heath
limber skiff
#

the shouldClear part gets triggered when you cancel

#

so the question is, is it clearing now?

austere talon
#

is shouldClear even used

limber skiff
#

because it shouldn't

#

before it wasn't clearing, and I suppose because of the typo

#

but now, if fixing the typo makes it clear, then it should be changed to false

charred monolithBOT
austere talon
#

this is fix btw

limber skiff
#

did you test what I said 😭

austere talon
#

no

#

you test

limber skiff
#

I dont even have it open...

grizzled halo
#

Tell everyone to update to test blobcatcozy

limber skiff
#

you should keep this part the same

image.png
austere talon
#

it is the same

limber skiff
#

quantified wildcards are ehhh

#

always causes us issues later

austere talon
#

it needs to match this thing

image.png
median rapids
#

like basically at all

austere talon
#

im too lazy to grammar

median rapids
#

basically at all

austere talon
median rapids
#

it is a little

#

:p

#

but app id can be any int

limber skiff
#

ah, I get it

#

alright

scenic brook
#

Nothing to report PES_Salute

image.png
limber skiff
#

fair enough

#

let me test tho

austere talon
#

we can also use .+? but i was worried it might match wrong thing

limber skiff
#

it's fine honestly

austere talon
#

and [^}]+ doesnt work because of the setState call xD

limber skiff
#

if it's just that object it probably won't change

austere talon
#

they restructured the code a lot it's weird

#

oh wait no

#

we can still use the lookbehind im stupid

limber skiff
#

yes but, it's finee

#

oh yeah

#

shouldClear should be false now

austere talon
#

alright

#

on both edit and send?

limber skiff
#

honestly the api should let you choose

#

but

austere talon
limber skiff
#

just keep it false for now

austere talon
limber skiff
#

as it has always been

#

lmao

austere talon
#

okay

limber skiff
#

hugee

#

are you gonna force push?

charred monolithBOT
austere talon
#

i also did lookbehind again

limber skiff
#

can you make it "Fix plugins modifying message content"

austere talon
limber skiff
#

just to be consistent with how I do messages

austere talon
#

it doesnt really matter

#

i always do lower case messages

#

this is better now

image.png
#

i changed less

limber skiff
#

you didnt escape the dots

austere talon
#

where

#

oh in type

limber skiff
#

this.props.

austere talon
#

doesnt matter tho

#

discord aint gonna have thisaprops 😭

limber skiff
#

😛

#

alright

austere talon
#

vreport dev

nimble pendantBOT
austere talon
#

why didnt i add test alias

limber skiff
#

let me look at this other change real quick

#

the sort friends one

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

SortFriendRequests (had no effect):
ID: 696577
Match: ```
/subText:(\i)(?<=user:(\i).+?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

malware

austere talon
#

i thought u were talking about a PR

limber skiff
#

ya wait

#

ugh I need a friend request lmao

odd heath
limber skiff
#

@odd heath send me one

odd heath
#

sent

#

you better accept /j

limber skiff
#

okay that's annoying

#

and now they use a generic component which will cause issues in other places if I patch

austere talon
#

horror

#

we remove the plugin (no one notices)

#

oh it's just the subtext i see

limber skiff
#

where to place it now...

austere talon
#

what the horror is this

image.png
limber skiff
#

adding a button and tooltip for this is soooo eh

austere talon
limber skiff
#

okay I have an idea

austere talon
fossil inlet
#

Has anyone looked into fake nitro yet

austere talon
#

it's already fixed broski

limber skiff
austere talon
#

no it just modifies the username text

#

to add that text

#

it doesnt affect in other places

limber skiff
#

how so?

#

it uses useUserTag

charred monolithBOT
austere talon
limber skiff
#

but as I said it's used in other places

austere talon
#

well what I actually did was

#

use the first patch

#

xD

#

anyway idk if that's a good idea

#

i just did it as proof of concept

#

it's so funny that the shouldClear was wrong but it still worked fine because we typod 😭

#

i wonder who made the typo (also not once but TWICE)

limber skiff
#

me probably

austere talon
#

bro

limber skiff
#

is this horrible?

austere talon
limber skiff
#

told u lmao

austere talon
#

how did you do it

limber skiff
#

how does one do newline in Text again

austere talon
#

<br /> or use margin

# 
<Text variant="text-xs/normal" className={Margins.top8}>
limber skiff
#

still too bad?

austere talon
#

why cant you put it below

#

flex column

limber skiff
#

doesn't fit

austere talon
#

hmm

limber skiff
#

this is kinda hacky

austere talon
# limber skiff

this is gonna be kinda ugly because if you have multiple it wont be aligned

#

check now that u have 2

limber skiff
#

GOD

austere talon
#

yeah told you it'd be ugly

limber skiff
#

lol

austere talon
#

try right aligning it

limber skiff
#

alright

austere talon
#

justifyContent: "space-between"

limber skiff
#

ya

austere talon
# limber skiff

wait you have center here but it's not center aligned (horizontally) (good)

#

did you change that code

limber skiff
austere talon
#

wouldn't that move this into the middle

image.png
limber skiff
#

cuz the div doesnt expand with all the width

austere talon
#

oh i see

limber skiff
#

and now because of that this too

image.png
#

adding space-between changed nothing

austere talon
#

then the space-between isn't gonna work yeah

#

just make the div width 100% lol

limber skiff
#

just did that

#

okay it's horrible

austere talon
#

better than before

scenic brook
#

Now put it before the pfps suffoMischief

austere talon
#

maybe we could do headers instead?

#

Jan 22 2025

weihnachtsklöckchen
Elvyra

Some Other Date

other guy

#

if that's not too hard xD

limber skiff
#

oh nahh

#

this is not sooo bad

austere talon
#

make it other colour

#

muted colour

limber skiff
#

yep

#

doesn't Text have a variant with gray color?

austere talon
#

i forgot

#

nah lol

image.png
#

well

#

wrong tab but u egt the idea

image.png
#

you can set color to --text-muted

limber skiff
#

bro this shit

#

finally

image.png
#

okay this is good

austere talon
#

maybe add a bit of margin on the right (between the date and buttons)?

#

like an em or two

limber skiff
#

too much?

austere talon
#

yeah that looks worse

limber skiff
#

ill try 0.5em

#

okay I like this

#

this should be compatible with stable too

charred monolithBOT
#
Nuckyz
[Vencord:dev2] 5 new commits

19361ef BadgeApi, AccountPanelServerProfile: Fix not wo... - sadan4
88e3bc0 ConsoleShortcuts: Set FluxStore toStringTag to ... - Sqaaakoi
a60af65 RevealAllSpoilers: Fix error on <C-S-Click> (#3... - sadan4
47315b0 fix plugins modifying message content - Vendicated
8346dba SortFriendRequests: Fix showing dates - Nuckyz

limber skiff
#

vreport dev2

nimble pendantBOT
limber skiff
#

bump browser finally?

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

@austere talon should I push to main and push a tag?

charred monolithBOT
limber skiff
#

vreport main

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

SortFriendRequests (had no effect):
ID: 696577
Match: ```
/subText:(\i)(?<=user:(\i).+?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

wait let me see

#

i hate how it's not aligned aligned on the left

image.png
limber skiff
#

oh god

#

wrap in div and align to right

#

easy fix

austere talon
#

btw

#

we should use moment to format it

#

instead of Date

#

well use Discord's Date formatter

limber skiff
#

actually

limber skiff
austere talon
#

or at least use toLocaleDateString()

limber skiff
#

I only have the same date so it's hard to test

austere talon
#

lmaooo

image.png
austere talon
#

can't really do that

#

need grid for that but for that we would have to have a common parent

limber skiff
#

cant you make a div with set width and align inside

austere talon
#

we could do monospace font

image.png
#

(american format)

image.png
#

which one is better

image.png
#

should we do month as 3 letters or numeric

#

im not asking for german vs US fr

#

i'm asking for numeric vs month as text

glass jasper
austere talon
#

no

glass jasper
#

zambian

#

what

austere talon
#

omg why is September 4 letters

image.png
glass jasper
#

auto correct

austere talon
#

horror what is this option

image.png
glass jasper
#

use that /joke

odd heath
austere talon
#

you dont?

#

@limber skiff wait im gonna make it better

#

a bit

odd heath
#

Nuckyz leaving me on pending 💔

limber skiff
austere talon
#

precise tooltip

image.png
#

monospace looks better i think?

image.png image.png
#

should we do normal or monospace

austere talon
limber skiff
limber skiff
austere talon
#

peak

limber skiff
#

with max-width

#

look at user voice show

austere talon
glass jasper
#

bone apple teeth

austere talon
#

oh god what did i do ahahahah

image.png
#

so good

limber skiff
#

😭

austere talon
#

okay is it good like this now?

#

should i push

limber skiff
#

ya

#

force push to dev

austere talon
#

scary

charred monolithBOT
austere talon
#

new commit is fine

limber skiff
#

okay that's good

austere talon
#

did u test locally

limber skiff
#

nop

#

testing now

#

okay yeah I like it

#

should I push to main now?

austere talon
#

sure

charred monolithBOT
limber skiff
#

vreport main

nimble pendantBOT
limber skiff
#

just to be sure

austere talon
#

imagine ahahahaha

#

that DateUtils thing i added to commons is super useful btw

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

odd heath
#

Yippe

charred monolithBOT
#
Nuckyz
[Vendicated/Vencord] New tag created: v1.11.0
austere talon
charred monolithBOT
limber skiff
austere talon
#

not fully sure tho lol

#

it's module 232551 (ctrl + f ^MMMM)

limber skiff
#

we should merge this to dev now

austere talon
#

do we really still need forceUpdater

#

forceUpdateDms

#

well it's whatever I guess

limber skiff
#

yeah

#

because we only grab the setting

#

and that doesn't cause a re-render

charred monolithBOT
limber skiff
austere talon
#

why

limber skiff
#

then I have to create an extra closure to store a reference to this

austere talon
#

no

limber skiff
#

to access proxyContents from within the handler

#

yes...

austere talon
#

it doesn't matter tho lol

limber skiff
#

actually the point is

#

if I move it inside

#

I will have to create a handler for each proxy again

austere talon
#

you can make one closure per (root) instance

#

and pass it to child proxies

limber skiff
#

because how else will I access this from within the handler

#

hmm

#

I think I see what you mean

#

is it really needed tho?

#

actually yes it does

austere talon
# 
class SettingsStore {
  private readonly proxyContexts = new WeakMap<any, ProxyContext>();
  private readonly proxyHandler = ... // use `this` here
}
#

this is fine

#

btw maybe we should make a <@&1015072428843601962>encord/utils repo for stuff shared between vesktop and vencord and add it as submodule to both

#

because a bunch of utils are copy pasted between the two 😭

limber skiff
#

can I keep the eslint change?

#

it's kinda useful

austere talon
#

sure yeah

#

I didnt know it was a thing tbh else I would have done that too

limber skiff
#

I know it from oceanic lol

charred monolithBOT
limber skiff
#

that's good yeah?

austere talon
#

do we even need iife

limber skiff
#

yeah

austere talon
#

it should work without

limber skiff
#

this is the target

#

inside handlers

austere talon
#

oh

#

hmm

#

fair

#

kinda ugly but whatever

#

btw take a look at my PR

#

the api change one

#

we should merge that too

limber skiff
#

yep

#

I will review it later today

umbral hedge
#

grrrr

jolly egret
#

seems to cause ratelimiting when clicking on your profile and stuff, rendering the buttons unusable

fossil inlet
#

@rugged spire you will fix

#

for some reason, it spans requests to your own profile untill you reload the window

limber skiff
jolly egret
#

I'm on latest main rn so yes

limber skiff
fossil inlet
#

i know

limber skiff
#

why didn't no one tell me it was with the fix

fossil inlet
#

i just knew it was an issue, i never looked into it more 😭

#

midterms week blobcatcozy

limber skiff
#

I thought the issue was because of the broken patch so I didnt bother looking

jolly egret
#

if you knew there was an issue with something you should've commented on the PR or made an issue despairge

fossil inlet
limber skiff
#

@austere talon of course something is broken just as we bumped the extension

#

that's gonna cause so many people to get rate limited

#

shit

fossil inlet
#

wonder if its best to disable the plugin on main until there is a fix

#

i dont think having people rate-limit themselves is a good idea

limber skiff
#

the issue is the extension

#

it is always the extension

#

fucking ass

fossil inlet
#

well, wasnt it already an issue with the extension

#

(i could be mis-remembering)

limber skiff
#

I'm not sure

#

but the point is, we just bumped it

#

the issue is this

fossil inlet
#

doesnt that get transpiled to the same thing

limber skiff
#

that's what I would guess

#

however doing that is somehow rendering it so many times in a way that react is not-

#

fuck

#

the functional component is created everytime it's rendering

fossil inlet
#

difference

#

one is wrapped with react again (i think)

#

idk

limber skiff
#

and by using the appropriate react render, it can't track whether it's the same functional component

#

because the function reference is different

#

so every it renders it, useEffects apply again

#

so basically, it cannot be a proper react render, but instead a simple function call

#

which is probably also not right to do, however it's the only way

austere talon
#

oof

limber skiff
#

but then how does that differ from this

image.png
#

it creates a different reference on every render too

#

how does that work and our doesn't?

austere talon
#

you can use useCallback()

limber skiff
#

oh my god

#

return n(e)

#

it is the right way to do

#

😭

#

I cant believe it

austere talon
#

omg yeah it's spamming so hard

#

this is not acceptable

#

did no one test that plugin 😭

limber skiff
#

I did that change and wouldnt think it would make an actual difference

#

so didnt bother re-testing

#

how come google does not have a way to cancel it

charred monolithBOT
austere talon
#

you have to do this

Rg13a.png VoBJP.png
austere talon
#

originalRenderPopout

limber skiff
#

alright

austere talon
#

and is this correct

image.png
limber skiff
#

nop

#

I mean

#

yes*

#

it's the same approach of wrapping in a function

limber skiff
charred monolithBOT
limber skiff
#

vreport dev

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

BetterUploadButton (had no effect):
ID: 974251
Match: ```
/.attachButtonInner,"aria-label":.{0,50},onDoubleClick:(.+?:void 0),...(\i),/


**__FixImagesQuality (found no module):__**
ID: `-`
Match: ```
getFormatQuality(){
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

OF COURSEEEEE

#

@austere talon they are joking with us

jolly egret
#

lmao

fossil inlet
#

loveeee

limber skiff
glass jasper
austere talon
#

skull issues

image.png
#

bro what

image.png
rugged spire
charred monolithBOT
limber skiff
#

vreport dev2

nimble pendantBOT
rugged spire
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

alright they can stop breaking things already

charred monolithBOT
prime dew
#

that's not grammatical errors, but rather personal preferences in wording

charred monolithBOT
jolly egret
charred monolithBOT
glass jasper
# charred monolith

The inconsistency behind the full stops aside… I think the only difference is their PO change. Is it to more of a rural english… like how you would talk in a normal day, versus the original having proper English like how a document should be written

fossil inlet
#

GUHHH HOW HAS NOBODY EVER NOTICED THIS

image.png
limber skiff
#

lmaoooooooooooooo

fossil inlet
#

(i will fix when i fix some error in rpc)

#

if i can manage to repro on my desktop

rugged spire
#

theres much worse afaik

#

idk why nobody uses a displayname for their settings or if it's even supported

#

if it's not, then it should be

fossil inlet
#

does anyone know what mp: does here

austere talon
#

autumn already opened PR

#

check it

rugged spire
fossil inlet
austere talon
#

it should be fixed

#

probably

#

lol

rugged spire
#

that PR has so many unrelated changes

austere talon
#

anyway autumn pr is bugged rn

fossil inlet
#

im on dev

rugged spire
#

i noticed this

Sqaaakoi-23-01-2025-10-46-13.png
austere talon
#

thats actually not that good because that user wont be cached

rugged spire
#

oh it's the discord account

#

why though

fossil inlet
rugged spire
#

does it look different if you look at your own activities

fossil inlet
rugged spire
#

fakenitro exploded moment do i have to update

#

no

#

it's me running without this fix

Sqaaakoi-23-01-2025-10-50-47.png
#

and being too lazy to update

fossil inlet
charred monolithBOT
limber skiff
#

this,

#

this diff is complete buillshit lmao

#

omg this option

image.png
#

sooo much easier now

#

okay yeah pr is good, just those two things

austere talon
#

i already did that the last time 😭

limber skiff
#

lool

austere talon
#

btw

#

MutableRefObject is deprecated

#

should i just push that change too

charred monolithBOT
limber skiff
charred monolithBOT
austere talon
#

what was accessories again

#

oh

#

hmm

#

ClearUrls no work

#

oh it doesnt have messageevents fix

limber skiff
#

troll

charred monolithBOT
austere talon
#

yeah works

charred monolithBOT
limber skiff
#

@austere talon while ur at it add vtest alias

austere talon
#

oki

#

vupdate

nimble pendantBOT
#

I'm back !!! :DDD

austere talon
#

vtest

nimble pendantBOT
limber skiff
#

😭

#

yk github is running the reporter in one minute too

#

lmaoooo

austere talon
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

ShowHiddenThings (found no module):
ID: -
Match: ```
/context:\i,checkElevated:!1}),\i.\i.{0,200}autoTrackExposure/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

fucker

charred monolithBOT
austere talon
#

LOOOL

limber skiff
#

I swearrrr

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

I just wanna push stuff to dev and they keep breaking shit

fossil inlet
jolly egret
#

just ignore canary if you can't fix it

austere talon
jolly egret
#

people probably shouldn't be using canary anyway

limber skiff
#

it's a regex find

fossil inlet
#

oh

limber skiff
#

woah

fossil inlet
#

iirc that find can be replaced with a string

#

found it while working on the companion and thought it was a weird find to be regex

limber skiff
#

send it

austere talon
#

bro this api change PR is so annoying

fossil inlet
#

😭

austere talon
#

or it wont build

jolly egret
#

lol

fossil inlet
charred monolithBOT
limber skiff
#

of course

#

they deleted the experiment and the patch used it for the find

glass jasper
fossil inlet
#

i would cry if they removed mod view as a feature

#

so good

charred monolithBOT
limber skiff
#

@fossil inlet

image.png
#

are you sure?

#

how does one find this with one string

austere talon
#

oh

#

hold on

fossil inlet
austere talon
#

wait it didnt work

#

oh cause of broken message events 😭

fossil inlet
#

now i want to find the regex patch that can be replaced with a string

glass jasper
austere talon
#

"port" of this

#

(port = mantika skidded the code and made it work with Vencord (AWFUL, NEEDS PROPER REWRITE))

fossil inlet
#

are there really only two regex finds wires

image.png
limber skiff
#

fake nitro has a regex find?

glass jasper
glass jasper
charred monolithBOT
fossil inlet
#

i only fix good userplugins

glass jasper
charred monolithBOT
limber skiff
#

true.

austere talon
#

these {} really make me wanna gouge my eyes out

image.png
fossil inlet
limber skiff
#

nop that's bad

fossil inlet
#

why

limber skiff
#

experiment tracking

#

remove experiment = no longer works

#

.isEditorOpen,true])

#

this is better

charred monolithBOT
limber skiff
fossil inlet
limber skiff
#

OH

#

HAHAHAHAA

#

it's fine I got another

#

?24:30,

fossil inlet
#

you can do one with width as well
,width:48}):

limber skiff
#

we should have still allowed array finds

#

it's so op to be able to combine string + regex

charred monolithBOT
austere talon
#

looks good now but like I said i wanna leave it in dev for a day or two for testing so rn might not be the best timing 😭

#

maybe dev2 time or smth

limber skiff
#

in dev2 no one will use

#

just me

austere talon
#

ya true

fossil inlet
limber skiff
#

it's way better

#

because you first check for the string

#

which is as fast as we can be

#

and then you use the regex after to only select the right one

austere talon
limber skiff
#

instead of always checking for the regex, which is slower

charred monolithBOT
limber skiff
austere talon
#

i read that as Fucking ModView

limber skiff
#

is this one safe to push to main

austere talon
limber skiff
#

why isn't currentUser... currentUser

austere talon
#

because then it doesnt show button

limber skiff
#

o

austere talon
#

i think

#

lmao

#

remember it dfoesnt show button for urself for some ungodly reason

limber skiff
#

don't discord have any user that is always cached

#

besides the current user

#

clyde or something

austere talon
#

i dont think so

#

clyde is fake

limber skiff
#

doing those fake users with just id is kinda scary

#

always prone to a crash later

austere talon
#

nah

#

it's only settings ui

#

with errorboundary

limber skiff
#

also hmm

austere talon
#

oh this is bad tho

image.png
limber skiff
#

const ActivityView = findComponentByCodeLazy('location:"UserProfileActivityCard",');

#

find that depends in experiment

austere talon
#

it's not experiment

#

it's analytics

limber skiff
#

well

#

yeah that

#

but I dont like those either

#

surely there is something else

fossil inlet
#

i got one to test earlier

austere talon
limber skiff
#

show me it

#

I can just change in this fix commit

#

to make it better

austere talon
#

findComponentByCode('location:"UserProfileActivityCard",')

limber skiff
austere talon
limber skiff
#

what if CustomRPC patched activity card to show your own buttons?

fossil inlet
austere talon
#

yeah discord deliberately doesn't show buttons for urself husk

image.png
limber skiff
#

but it still has location 😭

austere talon
limber skiff
#

I was looking

#

I will patch that out and send the correct current user

austere talon
#

but there's also this idk what this is

image.png
limber skiff
#

["u//9Bw"]

#

let me find this string

#

that's a good find probably

austere talon
#

insane

limber skiff
#

USER_ACTIVITY_STATE_SIZE

austere talon
#

it uses in multiple places

limber skiff
#

oh wait nvm

image.png
#

I'm blind

#

lmao

austere talon
#

the UserProfileActivityCard is the most unique thing in that module

#

they wouldn't just change their analytics

#

only if they change code drastically

#

lol it's so hard to find unique find

image.png
fossil inlet
austere talon
#

we should check what the second one is

#

what's difference between 443375.Z and 409057.Z (the one currently used)

limber skiff
#

I found .party?(

#

"crunchyroll":"default";

#

this one is good

austere talon
#

well this is the other one

image.png
limber skiff
#

even location: "UserProfileActivityCard", is duplicated

austere talon
# 
findComponentByCode("largeImage:", ".WATCHING", ".card")
#

the .card is unique 😭

limber skiff
#

alright

image.png
#

this is good enough for the component

#

for the patch I will do "crunchyroll":"default";

#

and all: true

austere talon
#

dont use that crunchyroll thing

#

😭

#

that's more likely to change than the analytics name

austere talon
#

patch not important

limber skiff
limber skiff
#

.party?(0

#

it's a ternary for a component render

austere talon
austere talon
#

i was wondering wtf that syntax wass

#

party?()

limber skiff
#

lol

#

this one is fine

image.png
#

I'm more worried about the patch

#

oh I shuld probably make reporter warn for all

#

and only avoid for noWarn

#

that seems more right

charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
limber skiff
#

nvm im stupid loool

#

we dont track if a patch was applied at least once

charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

ShowHiddenThings (found no module):
ID: -
Match: ```
/,checkElevated:!1}),\i.\i)};function/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

really...

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

lets see if we have duplicate finds

#

vtest

nimble pendantBOT
limber skiff
#

vtest dev2

nimble pendantBOT
frail skyBOT
#
Bad Patches

NoUnblockToJump (had no effect):
ID: 507435
Match: ```
/.?(.{1,10}.show({.{1,50}(?:["j7eA/v"]))/


**__NoUnblockToJump (had no effect):__**
ID: `507435`
Match: ```
/.\?(.{1,10}\.show\({.{1,50}(?:\.XyWoKS))/

ShowHiddenThings (had no effect):
ID: 813872
Match: ```
/\i(?=?null)/


**__AlwaysAnimate (had no effect):__**
ID: `81509`
Match: ```
/(?<=\.activityEmoji,.+?animate:)\i/

ForceOwnerCrown (had no effect):
ID: 81509
Match: ```
/,isOwner:(\i),/


**__MoreUserTags (had no effect):__**
ID: `81509`
Match: ```
/(?<type>\i)=\(null==.{0,100}\.BOT;return null!=(?<user>\i)&&\i\.bot/

AlwaysAnimate (had no effect):
ID: 596443
Match: ```
/(?<=.activityEmoji,.+?animate:)\i/


**__ForceOwnerCrown (had no effect):__**
ID: `596443`
Match: ```
/,isOwner:(\i),/

MoreUserTags (had no effect):
ID: 596443
Match: ```
/(?<type>\i)=(null==.{0,100}.BOT;return null!=(?<user>\i)&&\i.bot/


**__ShowHiddenThings (had no effect):__**
ID: `791176`
Match: ```
/(role:)\i(?=,guildId.{0,100}role:(\i\[))/

ReverseImageSearch (had no effect):
ID: 858341
Match: ```
/favoriteableType:\i,(?<=(\i).getAttribute("data-type").+?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

@austere talon the duplicate finds go crazy

austere talon
#

what does that do exactly

limber skiff
#

wdym?

#

I just set all patches to all to see which would match something else and not work

#

lol

austere talon
#

oh

#

now how many of these are just discord having the same module 4 times

image.png
limber skiff
#

however huhh

#

they arent duplicate...?

#

o

#

nvm

#

it is this one

image.png
charred monolithBOT
limber skiff
#

vtest dev2

nimble pendantBOT
austere talon
#

😭

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

good shit

austere talon
#

insane

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

most were easy to fix lol

charred monolithBOT
limber skiff
#

vtest dev

nimble pendantBOT
limber skiff
#

okay just to be sure

frail skyBOT
#
Bad Patches

ShowHiddenThings (found no module):
ID: -
Match: ```
["0g8Xd3"],allowOverflow:

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

scenic brook
#

Duplicate finds makes it sound like it's patches that have the same find as other patches

limber skiff
#

but

#

what

frail skyBOT
#
Bad Patches

ShowHiddenThings (found no module):
ID: -
Match: ```
["0g8Xd3"],allowOverflow:

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

it just worked fine?

#

eehm?

charred monolithBOT
limber skiff
#

genuinely confused if I remove the ) somehow

charred monolithBOT
limber skiff
#

vtest dev

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

vtest patcher-rewrite

nimble pendantBOT
jolly egret
#

what did they do despairge

limber skiff
#

surely the explosion of custom plugins

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
frail skyBOT
#
Bad Patches

ShowHiddenChannels (took 6.2999999999883585ms):
ID: 823748
Match: ```
/(?<="renderHeaderToolbar",()=>{.+?case \i.\i.GUILD_TEXT:)(?=.+?(\i.push.{0,50}channel:(\i)},"notifications"))))(?<=isLurking:(\i).+?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jolly egret
#

oh you're just running reporter on a different branch

#

i thought something exploded

limber skiff
#

ah, quantifier inside the lookbehind

charred monolithBOT
long stream
#

e0000

#

chromium cache file reference

charred monolithBOT
limber skiff
#

no way

#

that bot could shut up already

austere talon
#

the fucking bot omg

charred monolithBOT
limber skiff
#

why does the branch include changes from a commit in dev

image.png
#

same commit?

image.png image.png
#

tf?

austere talon
#

i added those now

#

(if u dont like u can do smth else)

#

looks cute btw

#

but i had to shrink them a lot cause it was just way too much 😭

#

when u open settings and ur entire screen is just those cards

#

🫡

austere talon
limber skiff
#

I said tomorrow

austere talon
#

oh

limber skiff
austere talon
#

ya oki

austere talon
#

apparently u cant transition text-decoration

#

(u can work around it by using box shadow instead of text decoration but thats dumb we will just wait until google adds support in 2030)

charred monolithBOT
limber skiff
#

simply squashed everything into a commit since git just didnt want the diff to work

#

doesn't change anything since review hasnt started

charred monolithBOT
austere talon
#

can that console filter plugin disable this ahahahah

image.png
#

or is it impossivle to disable 😭

#

1000 times is crazy

granite wharf
granite wharf
#

also those cards in particular were meant to be a copy of the hypesquad cards MikuGift so yeah they were gonna be a bit big

austere talon
#

I see

#

but those are their own page and the main content there so it's not really comparable xD

#

the cards aren't what you're opening the settings for is the thing

#

so it's annoying when they get in ur way so much

opaque silo
#

maybe have them dismissable to little icons next to the X/esc button

granite wharf
#

I don’t plan on that

granite wharf
#

Also some css nerd will post a snippet hiding it anyway

rugged spire
rugged spire
#

vencord kinda needs a discord fixes feature separate from individual plugins

#

i say this fully knowing that I wrote one of those fixes

grave mangoBOT
# rugged spire https://github.com/Vendicated/Vencord/blob/30647b6bd9f61e80a2bde2eb259887f6eb3b1...

index.ts: Lines 68-76

// fixes a bug where Members page must be loaded to see highest role, why is Discord depending on MemberSafetyStore.getEnhancedMember for something that can be obtained here?
{
    find: "#{intl::GUILD_MEMBER_MOD_VIEW_PERMISSION_GRANTED_BY_ARIA_LABEL}),allowOverflow:",
    predicate: () => settings.store.showModView,
    replacement: {
        match: /(role:)\i(?=,guildId.{0,100}role:(\i\[))/,
        replace: "$1$2arguments[0].member.highestRoleId]",
    }
},
rugged spire
median rapids
rugged spire
#

i feel like only 4 or 5 will be coming back

high oracle
#

only when deferring

rugged spire
#

😭

charred monolithBOT
limber skiff
rugged spire
#

This screenshot was taken by a professional in bad plugin design

Sqaaakoi-23-01-2025-20-02-46.png
median rapids
#

vencord reinventing aliucord coreplugins

#

actually it already has those

fossil inlet
charred monolithBOT
jagged cloak
#

love

charred monolithBOT
odd heath
#

Ok I will just force push my last commit idgaf 🙏

austere talon
#

I messed up like one line just fix it man 😭

odd heath
odd heath
#

GOD MY ENTIRE GIT IS FUCKED NOW

#

GUHHHHHHHHH

#

your stupid force pushes blobcatcozy

#

fixed

#

git reset hard my beloved

#

@austere talon veeeeeeeeev its fixed nyow

austere talon
#

just delete the faulty commits is the fastest fix by far

odd heath
#

I did

#

xd

austere talon
#

just git fetch then git reset --hard origin/branch

odd heath
charred monolithBOT
limber skiff
#

vtest

nimble pendantBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

limber skiff
#

Fake Nitro isn't working for stickers apparently

#

which is weird because the patch isn't broken

austere talon
#

bro is proably just outdated

#

works on my machine

1107344881308925962.gif