👾-core-development

[limber skiff]

damnn

they broke all the plugin

[charred monolith]

nin0-dev

[Vendicated/Vencord] Pull request review submitted: #3106 break better folders

lgtm

[dusk blaze]

i would approve but vee went WOKE and disabled approvals for non collaborators

[odd heath]

love discord

plugin to fix when

[shell shuttle]

actually this is really fire

[charred monolith]

sadan4

[Vendicated/Vencord] New comment on pull request #3106: break better folders

10/10 LGTM

Vendicated

[Vendicated/Vencord] Pull request closed: #3106 break better folders

[versed fern]

I did that pr on my phone

[dusk blaze]

mergeee

[charred monolith]

null-dev

[Vencord/Vendroid] New star added

[rugged spire]

its good now

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #3101 openInApp: add support for geo.music.apple.com links

looks good now

[rugged spire]

horror fix pls

[jolly egret]

its to prevent the random people coming in out of nowhere clicking approve with no reason and then vanishing into the horizon

[dusk blaze]

AI

[charred monolith]

EtorixDev

[Vendicated/Vencord] Pull request opened: #3107 feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

Changes

1. Added a setting to respect Streamer Mode which is enabled by default.
2. Added all permutations (15) of Nick, Display, and Usernames.
   • Added a setting to exclude duplicates if there is overlap.
   • Nick/Display fill in for each other if either is missing, and if both are then username fills in.
3. Set custom prefixes and suffixes (up to 3 characters long) for each. Example: Nick [DISPLAY] (@username)
   • The first in the order does not have the symbols unless t...

iblamefyze

[Vencord/Installer] Fork created: iblamefyze/Installer

[odd heath]

i like this

[austere talon]

so much code

scary

[elder plinth]

:)

[fossil inlet]

?remind 9pm review #3107

[shut vine]

Alright @fossil inlet, in 9 hours, 49 minutes and 4 seconds: review #3107

[odd heath]

you will merge

good stuff

[dusk blaze]

my goal is to add as many prs to vee's backlog

very big too

[dusk blaze]

love

[elder plinth]

is this a good time to press the "request another review" button in my previous pr

[fossil inlet]

I will review later

Send link

[elder plinth]

https://github.com/Vendicated/Vencord/pull/3053

[fossil inlet]

?remind 24hr review

[shut vine]

Alright @fossil inlet, in 1 day: review

[rugged spire]

?remindme 7pm shy typing

[shut vine]

Alright @rugged spire, in 6 hours, 44 minutes and 57 seconds: shy typing

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[fossil inlet]

Fifty broken patches

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[dusk blaze]

alright time to break some

@fossil inlet can you help

[fossil inlet]

Yopp

[shut vine]

@fossil inlet, <t:1735229456:R>: review #3107

[odd heath]

Why do u call it shy typing

[jolly egret]

because its funny

[odd heath]

Nop

Insulting

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3107 feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

sadan4

[Vendicated/Vencord] New review comment on pull request #3107: feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

it would be eaiser to just only allow an hex code as the color.

[elder plinth]

perhaps but it's already implemented so idk what limiting it further would achieve

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3107 feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

it would probably be eaiser if the user just passed a format string eg{username} ({nickname}) instead of having six settings for prefixes and suffixes

[elder plinth]

yeah but then they couldn't color them independently

[limber skiff]

the dropdown with all the permutations is not good...

make them separate switches and then just add/removed stuff as needed

[fossil inlet]

you wouldnt need that with a format string i think

[limber skiff]

uhmm

[elder plinth]

why is the drop down bad?

[limber skiff]

because

[fossil inlet]

massive

[limber skiff]

15 options...

[elder plinth]

that's not that many? it's also all the possible options so it makes sense

[fossil inlet]

i feel like this pr over-engineers a lot

[limber skiff]

it's not good ux tho

[elder plinth]

I feel like it's better UX than making users format it themselves

I'm open to suggestions I just don't think it's as bad as you're making it seem

100 options sure but 15?

[limber skiff]

@fossil inlet btw do you still want help with the error boundary

my pc had went boom because of a usb cable

[fossil inlet]

oh yeah

turns out im stupid and i think that is the correct way

[fossil inlet]

#🧩-plugin-development message

[limber skiff]

right before Christmas lmao

i honestly don't even know that's that props.children

but for what I think you want I dont understand how it's that

well I will see another time

[fossil inlet]

neither do i tbh

ill ask vee about it later

@elder plinth what is a nickname symbol

[elder plinth]

the affixes

listed right above it

( ) [ ] (@ ) < > etc whatever the user puts

Im on my pc now and was about to reply to your comment on the pr about that

the main goal of this PR was uncomplicated customization

[fossil inlet]

im reworking the settings a bit

[elder plinth]

making users do string formatting would complicate it to hell and back

[fossil inlet]

feel like theres a bit too many options rn

[fossil inlet]

it already is imo

[elder plinth]

it's a lot of options but super straightforward

you go through it once in 2 minutes and you're done

you could combine the 3 always show symbols settings into 1 and the 3 always show colors settings into 1 tbh I doubt that niche use case would be missed

here's the regex check on the color btw https://regex101.com/r/2GAAVC/1

[fossil inlet]

@elder plinth thinking something more like this for the settings

[elder plinth]

I would really prefer the color to be completely custom

[fossil inlet]

just add a class to the span rendered

[elder plinth]

I was particuarly fond of my Role+- coloring

[fossil inlet]

the user can then use css to style it

[elder plinth]

what

rest of the settings look good btw you condensed them well.

other than dropping color support for the symbols but I didnt plan on using that personally so idrc I guess

[elder plinth]

it was already using css

the function takes their input and confirms it is valid and then applies it to the style

[fossil inlet]

function renderUsername() {
return (<span> <span className="vc-smyn-username"> username</span> <span className="vc-smyn-nickname"> nickname </span> </span>)
}

the user can then add something like this to their custom css

.vc-symn-username {
color: red;
}

[elder plinth]

oh. I greatly dislike that personally

[fossil inlet]

i think its a good compromise between a custom color parser and a constant color

[elder plinth]

why does the custom color parser need to be compromised on

I can understand why a dozen settings was too much but what does this need changing

[fossil inlet]

i feel like for most users the color input was confusing

for the few that will want to change it, css offers them a way to do it

without confusing 90% of the normal users

[elder plinth]

It's basic color coding. hex rgb or hsl

thats not confusing

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3107 feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

sadan4

[Vendicated/Vencord] New review comment on pull request #3107: feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

    description: "Display any permutation of nicknames, display names, and usernames in chat",

describing nicknames and display names doesn't belong in the plugin description

if you don't want to hover over messages to update them after changing settings, you can use settings as react state

[fossil inlet]

@elder plinth

[elder plinth]

yeah?

[fossil inlet]

sorry

testing

[elder plinth]

ah ok.

[elder plinth]

ok wrote a validator for the name format input and removed the other settings. how do I go about the react state thing you mentioned @fossil inlet

[fossil inlet]

settings.useStateFromStore iirrc

see how rolecoloreverywhere uses it

[elder plinth]

ok think I might have it lets see

yeah worked

instantly updated chat when I closed settings

[rugged spire]

i want to have silent typing until you actually commit to saying the first message

[charred monolith]

rushy-me

[Vendicated/Vencord] Pull request opened: #3108 feat(plugin): SpoilerReveal

Allows spoilers to be revealed on hover, with ctrl+click to hide them again.

[fossil inlet]

am i crazy or can this be done with css

||test||

nop

i think im crazy

[elder plinth]

pushed my changes. removed all the excess settings you did and switched to the formatted string input. only thing I didnt change was the color input cause I still feel strongly about it.

[shut vine]

@rugged spire, <t:1735254903:R>: shy typing

[elder plinth]

guess ill comment on the pr too

[charred monolith]

EtorixDev

[Vendicated/Vencord] New comment on pull request #3107: feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

it would probably be eaiser if the user just passed a format string eg{username} ({nickname}) instead of having six settings for prefixes and suffixes

Updated to switch to a string format input instead of a drop down.

EtorixDev

[Vendicated/Vencord] Pull request review submitted: #3107 feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

EtorixDev

[Vendicated/Vencord] New review comment on pull request #3107: feat(ShowMeYourName): Nick, Display, Username Permutations; Streamer Mode; Mentions; Affixes; Colors

Perhaps but it's already implemented and as far as I can tell quite robust and allows more freedom of input.

[elder plinth]

so whats the correct way to handle a review that you disagree with. I dont mean to be rude I just don't have much experience with this. do I leave it unresolved until I manage to change their mind, until I cave in, or what?

[charred monolith]

mrabro

[Vencord/Installer] New comment on issue #120: MacOS sonoma 14.3.1 glitch

to solve the issue, try running the installer as root.

open a terminal and type sudo /path/to/VencordInstaller.app/Contents/MacOS/VencordInstaller, replacing /path/to with the path where you downloaded the installer to.

not working on mac sequoia

[charred monolith]

servicepipe

[Vencord/Installer] New star added

[odd heath]

Wdym

[scenic brook]

Have the toggle turn off after a message is sent

[charred monolith]

HaddajiDev

[Vendicated/Vencord] Pull request opened: #3109 loadingQuotes : added more "funny quotes"

added bunch of "funny quotes"

[brazen bone]

Too many unicode apostrophes

[shut vine]

@fossil inlet, <t:1735230694:R>: review

[rugged spire]

Cancel the typing start request if there isn't a message from yourself in the current channel posted within a certain period of time

[odd heath]

Oh yeah that is good for certain places

[charred monolith]

Zaxx69

[Vencord/Vendroid] New star added

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3108 feat(plugin): SpoilerReveal

sadan4

[Vendicated/Vencord] New review comment on pull request #3108: feat(plugin): SpoilerReveal

                match: /super\(\.\.\.\i\),/,
                replace: '$&,Vencord.Plugins.plugins.SpoilerReveal.createHoverWrapper(this),'

dont hardcode minified variable names

[jolly egret]

if nobody gets around to adding supoprt for ignored users to that unblock to jump plugin i'll support it

but just gonna put this here if anybody wants to get it first

[fossil inlet]

what experiment is that

i dont have it

[jolly egret]

i'm not sure what the name of it is and i don't think you could use it if you don't already have it though, its basically just block but less extreme

api will probably just say no if you try and use it

[long stream]

it's 2024-10_stealth_remediation

[fossil inlet]

ty ❤️

[long stream]

fyi the ignore part is api-locked

so you'll have to fool the client into thinking you've ignored someone

[fossil inlet]

tbh i mostly will just check the code then send it to @jolly egret to test

[long stream]

fair

[fossil inlet]

@jolly egret you should send me your token so i can test it

[jolly egret]

REAL

[limber skiff]

send me too

oh nvm i got yours already

[fossil inlet]

[limber skiff]

all good 👍

[fossil inlet]

@limber skiff do we hardcode new i18n keys?

nevermind

guessed the key

[limber skiff]

lmao

[fossil inlet]

hmmmm i wonder what the key for ignored users is

[odd heath]

[fossil inlet]

@jolly egret can you test out this branch https://github.com/sadan4/Vencord/tree/feat/noIngoreToJump

[jolly egret]

thought i was being stupid with git but theres a typo in your branch name

[odd heath]

LMAO

This is why you copy and paste

[jolly egret]

it jumps now

LGTM

[fossil inlet]

alr

im going to fix up the patches a bit then have you test again

[jolly egret]

👍

[limber skiff]

no in gore to jump

[fossil inlet]

@jolly egret can you pull and test

[jolly egret]

still works

[fossil inlet]

tysm

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #3110 NoUnblockToJump: Also jump for ignored users

Filtering is now done server-side in Discord

[odd heath]

Copy paste patches my beloved

[fossil inlet]

yopp

also why was that the pr message

[jolly egret]

lmao

was that from your discovery show hidden things PR/

[fossil inlet]

yea

@jolly egret i blocked you to get this ss lol

[jolly egret]

kek

all good

[odd heath]

Maybe bc that was the only commit body in all commits idek

Nvm you based in on dev immediately

Tf

[fossil inlet]

my commit for that never got merged

so it wouldnt be in the history

every new thing i do is based on its own branch off of dev

[odd heath]

Also wouldn't it make sense to just put an | and the two intl strings into the same match?

Since it's like the exact same thing

[fossil inlet]

ehhhhh

think this is a bit more readable

[odd heath]

It's regex it doesn't need to be readable

[fossil inlet]

also better because you would have to make one regex global

and that wouldnt report in reporter if only one fails

[odd heath]

Ya but it's still in the branch there

Like it's that exact same message

[fossil inlet]

@odd heath this is why it is better

[fossil inlet]

ah

[odd heath]

Yea that's fair

[fossil inlet]

• too lazy to make one regex

two is eaiser

[rugged spire]

i just called loadlazychunks on a mobile network how slow will this be

im dum

[rugged spire]

i think i made my plugger work

[charred monolith]

alyaseer2

[Vendicated/Vencord] Pull request opened: #3111 Create userplugins

[austere talon]

horror

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #3111 Create userplugins

Vendicated

[Vendicated/Vencord] New comment on pull request #3111: Create userplugins

there is no tooth fairy, and you can't use BetterDiscord plugins on Vencord :(

[gritty iris]

:(

[astral bone]

😦

[jolly egret]

[charred monolith]

alyaseer2

[Vendicated/Vencord] Pull request opened: #3112 Create userplugins

[jolly egret]

somebody is about to get blocked

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #3112 Create userplugins

DaviGit1

[Vencord/Vendroid] New star added

[charred monolith]

HaddajiDev

[Vendicated/Vencord] Issue opened: #3113 how to Run vencord locally ??

Content

how to run vencord locally

Request Agreement

• [X] I have read the requirements for opening an issue above

[brazen bone]

What does that even mean

[fossil inlet]

vs dev

guhhh

[charred monolith]

nin0-dev

[Vendicated/Vencord] New comment on issue #3113: how to Run vencord locally ??

It looks like you did not read the issue template as you have opened this issue, which suggests that you lack the ability to read through instructions (which in this case was to not use this form if you are not a maintainer). However, this skill is required to install a devbuild.

[dusk blaze]

@fossil inlet you love

[charred monolith]

HaddajiDev

[Vendicated/Vencord] Issue closed: #3113 how to Run vencord locally ??

HaddajiDev

[Vendicated/Vencord] Issue closed: #3113 how to Run vencord locally ??

[fossil inlet]

loll

[charred monolith]

HaddajiDev

[Vendicated/Vencord] Pull request closed: #3109 loadingQuotes : added more "funny quotes"

[fossil inlet]

@dusk blaze you bullied them too much 😭

[dusk blaze]

okay maybe i went a little too far

[fossil inlet]

the quotes were actually good

[dusk blaze]

but how can u miss a huuuuge header telling you not to open an issue

[dusk blaze]

true

[austere talon]

probably ai

[fossil inlet]

tbh considering he had an open pr, cant blame him that much for it if he didnt find the discord server

[charred monolith]

Vendicated

[Vendicated/Vencord] New comment on issue #3113: how to Run vencord locally ??

If you mean how to build it from source, check https://docs.vencord.dev/installing

But this is only recommended if you are a developer and know what you're doing. In any case, use our support channel instead of opening issues

[fossil inlet]

@warm bough if you need help with dev, get the programming role and use #🧩-plugin-development

[dusk blaze]

i don’t have access to this link

[fossil inlet]

whar

[dusk blaze]

hf!userinfo 767083087338274866

[grave mango]

AhmedTN (@ahmed_2018)

@warm bough

Created

<t:1602957259:R>

​

Avatar • Updated <t:1735428691:R>

ID: 767083087338274866

[dusk blaze]

mention was invalid for me

[fossil inlet]

he has roles?

[dusk blaze]

did he also leave

now i feel bad

oh he never was there i don’t see his join message

[fossil inlet]

i think so

[charred monolith]

HaddajiDev

[Vendicated/Vencord] New comment on issue #3113: how to Run vencord locally ??

i found no support in your support channel.. thank you though

[fossil inlet]

@dusk blaze can you give him programming

[dusk blaze]

v+ prog 767083087338274866

oh hes still here

[grave harness]

hello peoples :D hows everyone doing

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

HaddajiDev

[Vendicated/Vencord] Pull request opened: #3114 New Plugin : CustomCursor

Replace the default cursor with a custom cursor

[brazen bone]

That's impressively bad for something that's one line of css

[charred monolith]

nin0-dev

[Vendicated/Vencord] New comment on pull request #3114: New Plugin : CustomCursor

afaik you can add custom cursors with CSS directly

also in the future, avoid linking to external assets

[brazen bone]

It's also dom manip

[dusk blaze]

yop

i think vencord has a styles API

[brazen bone]

Oh and I love the use of Object.assign instead of just =

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #3114 New Plugin : CustomCursor

Vendicated

[Vendicated/Vencord] New comment on pull request #3114: New Plugin : CustomCursor

this can be done with pure css

biast12

[Vencord/Vencloud] Issue closed: #47 Crashing when i try to enable cloud integrations / accept the OAuth2

biast12

[Vencord/Vencloud] New comment on issue #47: Crashing when i try to enable cloud integrations / accept the OAuth2

ok so finally got home and time to fully look at this, no matter what i did didn't it work so i ended up just switching to #45 switch seems to work, i think the issue may be that Redis no matter has a "password", it's just if it's null or one that's set (this is just a guess tho), but i'll close the issue as it's technically fixed

[turbid hatch]

wot

no there's only a password if u set one

[austere talon]

how do they think we run it in production 😭

[jolly egret]

we don't run it, silly

Vencloud is a deceptive project that only exists to mask the fact that we use something else in the backend that collects personal data

[median rapids]

😭

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[limber skiff]

@fossil inlet https://github.com/Vendicated/Vencord/pull/3110

could you add a coment saying where each "find" is targetting

since it's basically three copy pasted patches

[fossil inlet]

yop

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request closed: #3104 QuickReply: Prevent caret from moving when selecting message

Nuckyz

[Vencord:dev] 1 new commit

79e2cb1 QuickReply: Prevent caret from moving when sele... - Sqaaakoi

Nuckyz

[Vencord:dev] 1 new commit

0e813e7 OpenInApp: Add support for geo.music.apple.com ... - faejr

Nuckyz

[Vendicated/Vencord] Pull request closed: #3101 OpenInApp: Add support for geo.music.apple.com links

[limber skiff]

once you do it I will push to main

[fossil inlet]

test

@limber skiff done

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request review submitted: #3110 NoUnblockToJump: Also jump for ignored users

Nuckyz

[Vendicated/Vencord] New review comment on pull request #3110: NoUnblockToJump: Also jump for ignored users

Removes the popup preventing you to jump to a message from a blocked/ignored user (eg: in search results)

[limber skiff]

thanks

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request closed: #3110 NoUnblockToJump: Also allow jump for ignored users

Nuckyz

[Vencord:dev] 1 new commit

0fd76ab NoUnblockToJump: Also allow jump for ignored us... - sadan4

Nuckyz

[Vencord:main] 5 new commits

9ccc74b use correct prodversion in chrome extension ins... - Vendicated
cca5d7d ShowHiddenThings: Discovery filter bypass is pa... - Nuckyz
79e2cb1 QuickReply: Prevent caret from moving when sele... - Sqaaakoi
0e813e7 OpenInApp: Add support for geo.music.apple.com ... - faejr
0fd76ab NoUnblockToJump: Also allow jump for ignored us... - sadan4

[fossil inlet]

@limber skiff https://github.com/Vendicated/Vencord/pull/2766 should be ready

[limber skiff]

okay I will see tomorrow

[fossil inlet]

ty

[rugged spire]

can someone close https://github.com/Vendicated/Vencord/issues/3085

[fossil inlet]

wait why did fixes not close it

[charred monolith]

Nuckyz

[Vendicated/Vencord] Issue closed: #3085 [Bug] QuickReply moves caret to the beginning of the message.

[rugged spire]

github

maybe because I explicitly typed the repo name?

also how is https://github.com/Vendicated/Vencord/issues/2708 still open I fixed this around 5 months ago

[limber skiff]

when the pr does not close the issue

[charred monolith]

Nuckyz

[Vendicated/Vencord] Issue closed: #2708 [Bug] ShowHiddenThings ModView

[rugged spire]

horror

[fossil inlet]

i will open five new valid bugs

[limber skiff]

(and then we just forget)

[rugged spire]

i love fixing obscure bugs

[jolly egret]

tfw PR targets a non default branch

[rugged spire]

tfw GitHub's UI explicitly said it will close when it is merged into main

[jolly egret]

well it sucks at that?

gh sucks

[rugged spire]

trol

[limber skiff]

@fossil inlet take a look at https://github.com/Vendicated/Vencord/pull/2766/files

I made it use the original component in the fallback

return Vencord.Plugins.plugins["FullUserInChatbox"].UserMentionComponent({
    ...arguments[0],
    OriginalComponent: (() => {
        if (null != u) {
            let e = c || u.isPomelo() ? null : "#".concat(u.discriminator);
            return (0,
            i.jsx)(s.Tooltip, {
                text: (0,
                i.jsxs)("div", {
                    className: A.userTooltip,
                    children: [(0,
                    i.jsx)(l.Z, {
                        user: u,
                        animate: !0,
                        size: s.AvatarSizes.SIZE_16,
                        className: A.avatar
                    }), b.ZP.getUserTag(u, {
                        mode: "username",
                        identifiable: c ? "never" : "always"
                    }), (0,
                    i.jsx)("span", {
                        className: A.discriminator,
                        children: e
                    })]
                }),
                delay: 750,
                position: "top",
                "aria-label": b.ZP.getUserTag(u, {
                    decoration: "never"
                }),
                children: e => (0,
                i.jsx)(s.Clickable, {
                    tag: "span",
                    ...e,
                    children: f
                })
            })
        }
        return f
    })()
});

[fossil inlet]

@limber skiff seems to work, the only thing i can think of is that the part of the match that matches the original component might be more likely to break

[limber skiff]

yep

[fossil inlet]

your choice

idrc either way

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request closed: #2766 Feat: FullUserInChatbox

Nuckyz

[Vencord:dev] 1 new commit

20ed7dc new plugin FullUserInChatbox (#2766) - sadan4

[limber skiff]

thanks

[fossil inlet]

[scenic brook]

Forgot I did this and got flashbanged by it

[rugged spire]

neat

[scenic brook]

If we're bumping PRs I'd appreciate any insight on this

I'm not confident in the way it's implemented

I hit enter at the same time as ] and sent early

[rugged spire]

i am all up to date with the new changes now

[limber skiff]

new changes: you are banned from making plugins

[rugged spire]

feature that tells you to log off and get a life

[limber skiff]

LOL

[rugged spire]

yet again I'm researching discord code to find which experiment activates which ugly feature

[limber skiff]

what feature?

i can help if you want

[rugged spire]

nvm my guess was right

it just hadn't rerendered

this one

[rugged spire]

can i make a plugin to track how much of my life i waste on discord

[limber skiff]

yes

[charred monolith]

Baget88

[Vendicated/Vencord] New comment on pull request #2982: New Plugin: messageCountdown

AHHH YESS PLEASE ADD THIS, ITS ACTUALLY RLLY GOOD FOR XP 🙏

[scenic brook]

I don't understand people that care that much about xp in servers tbh

[grizzled halo]

Me when people care more about xp than the social interaction

[brazen bone]

Those exp shits are literally spambots

[odd heath]

Wrong branch I think

[charred monolith]

blu3berryys

[Vendicated/Vencord] Pull request opened: #3115 Update actions

Updates actions

[charred monolith]

StRonKEA

[Vencord/Installer] New comment on issue #111: Request: Make support for discord-ptb-portable

I found a way to install it on Discord Portable via the Cli version

Can you share the solution you found?

[dusk blaze]

does this even do anything beyond adding indentation

contribution farming my beloved

[charred monolith]

tester5454

[Vendicated/Vencord] New comment on pull request #2982: New Plugin: messageCountdown

It's a good plugin why hasn't it been added yet :(
it helped with grinding in guilds and timing rank ups and i think it deserves to be in the plugin store

[charred monolith]

nin0-dev

[Vendicated/Vencord] New comment on pull request #2982: New Plugin: messageCountdown

not only is this plugin extremely niche and useless to 99% of people that have a life beyond XP grinding, it also needs to be reviewed before it even is merged

be patient

tester5454

[Vendicated/Vencord] New comment on pull request #2982: New Plugin: messageCountdown

This plugin's existence is 99% for the people that don't have a life and it's been 2 months how much longer are they gonna take

[jolly egret]

get a life lmao

xp grinding on a discord server

[weak thistle]

😭

[long stream]

it literally only changes some step names 😭

im surprised they didn't bother to add malware as well

[charred monolith]

Baget88

[Vendicated/Vencord] New comment on pull request #2982: New Plugin: messageCountdown

speaking on behalf of 100people in this server i am in, they want it and so do i
some servers give prizes for getting xp which is another reason that it is useful

[long stream]

okay soo... it's still an xp farming plugin

which is very niche

[dusk blaze]

@turbid hatch you might want to lock this until its reviewed, probably xp grinding enthusiast sent the PR to all of his friends

[grizzled halo]

i stand by this

[long stream]

real

[turbid hatch]

whats this one sorry

messagecountdown?

[dusk blaze]

yeah

[grizzled halo]

i was tempted to send it on the pr but i dont want to fuel the fire

[turbid hatch]

i'll do you one better

[weak thistle]

lewi about to cook

[long stream]

poor lewi is gonna write a paragraph that they won't read...

[grizzled halo]

lewi cooking is always a sight to see

at least i read it

[weak thistle]

we'll read it

[long stream]

[charred monolith]

lewisakura

[Vendicated/Vencord] Pull request closed: #2982 New Plugin: messageCountdown

lewisakura

[Vendicated/Vencord] New comment on pull request #2982: New Plugin: messageCountdown

Like nin0 has said, this plugin has zero use outside of grinding bot XP in guilds, and we recently updated our plugin guidelines to ban these sorts of plugins:

No plugins that interact with specific Discord bots (official Discord apps like Youtube WatchTogether are okay)

Since there was no actual given use case beyond this in the PR description (and the whole plugin is built around the concept of grinding XP based on the settings), I'm going to close and lock this.

[turbid hatch]

locking because of the people replying on it

[weak thistle]

[grizzled halo]

watch them try again

[turbid hatch]

ill ban them

prs like these do make me sad when i close them because i know people have some benefit out of these, but we have to keep the main build of the mod of high quality and relevant to most people

maybe one day we'll get a userplugin loader

[long stream]

the annoying grind: make a terrible pr, complain about it not being reviewed a minute after being open, get it closed, repeat

[turbid hatch]

today however is not that day

[grizzled halo]

please dont i already lose my sanity

[charred monolith]

lewisakura

[Vendicated/Vencord] Pull request closed: #3115 Update actions

lewisakura

[Vendicated/Vencord] New comment on pull request #3115: Update actions

?

[long stream]

make sure to add a giant warning saying they have userplugins loaded
(they'll ignore it and post in the support channel anyway)

[turbid hatch]

if its ever added they wont be able to visit the support channel with userplugins loaded

it'll ask them to disable all userplugins, check for the issue again, and then report it

[grizzled halo]

have it auto ban people who vencord-debug in support with userplugins

[turbid hatch]

i just realised most of my contributions on the repo nowadays are moderation lol

[charred monolith]

Ryuu43

[Vencord/Installer] New comment on issue #111: Request: Make support for discord-ptb-portable

I don't use it anymore but I used the cli and installed vencord in the Discord Portable folder and it

[jolly egret]

Funny how them spamming on a post ended up getting it closed

you sealed your own fate

[fossil inlet]

Have it also ban devs that do that

[long stream]

hmm i wonder, how useful would it be to allow installing vencord in a custom directory (assuming it has discord files)

oh

it already has it, im stupid

[fossil inlet]

frreeeeessss

[inland fable]

https://github.com/Vendicated/Vencord/blob/0fd76ab15a51a8426786b696d422f59bd1250099/src/utils/types.ts#L83
I think this would be more useful as a LiteralUnion with API plugins and string such as this:

dependencies?: LiteralUnion<"UserSettingsAPI" | "MessageAccessoriesAPI" | "MessageEventsAPI" | "MessagePopoverAPI" | "ChatInputButtonAPI" | "MessageUpdaterAPI" | "MessageDecorationsAPI" | "MemberListDecoratorsAPI" | "ServerListAPI" | "DynamicImageModalAPI", string>[],

(perhaps would be better to have the builtin API plugins union be a separate type)
this would help for intellisense because you most likely will use one of those in dependencies

[grave mango]

types.ts: Line 83

dependencies?: string[],

[fossil inlet]

ehhhhh

why not just have some runtime warn if a dep isnt resolved

[inland fable]

better dev experience to get to choose from a dropdown imo

[fossil inlet]

yea but wouldnt you have to add every new dep to a list

[inland fable]

any time a new API plugin is added to vencord it would have to be added to the union type yeah

[scenic brook]

Seems like a pretty minor thing to do if you're already doing the work of adding an API anyway

[inland fable]

i think i might be missing some API plugins i am not sure

[scenic brook]

I think just typing API into the plugin search should show you them all

[fossil inlet]

they're hidden

just object.keys plugins then filter for ends with api

[scenic brook]

Searching API overrides the filter

[fossil inlet]

[inland fable]

ah that works this is the full list right now

"BadgeAPI" | "ChatInputButtonAPI" | "CommandsAPI" | "ContextMenuAPI" | "DynamicImageModalAPI" | "MemberListDecoratorsAPI" | "MessageAccessoriesAPI" | "MessageDecorationsAPI" | "MessageEventsAPI" | "MessagePopoverAPI" | "MessageUpdaterAPI" | "NoticesAPI" | "ServerListAPI" | "UserSettingsAPI"

[scenic brook]

Has to be caps

[fossil inlet]

ah

[charred monolith]

vaclavec

[Vencord/Installer] New star added

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[rugged spire]

this is so true

[charred monolith]

Eveeifyeve

[Vencord/Vencloud] New comment on issue #28: Nixos 24.05 Cloud slider cannot be turned on Wayland Gnome

I am making an package for vencloud and module, I would recommend asking support or pinging me in the nixos matrix rather than here as this is not the offical support for nix.

[rugged spire]

nix user moment

[opaque silo]

nix users complaining that something requiring disk writes isnt working

[limber skiff]

@scenic brook I see you made drag and drop from scratch for https://github.com/Vendicated/Vencord/pull/3048/files

however discord has this lib included in the modules, since they use it in some places https://react-dnd.github.io/react-dnd/about
would it not be easier to use this instead?

[scenic brook]

I did look around for any prebuilt kinda thing for it but I didn't find that, thanks

I'll look into it later

[limber skiff]

alright, nice

[charred monolith]

scarrrr316

[Vendicated/Vencord] Pull request opened: #3116 UserVoiceShow: Add option to show username

Demo:

[charred monolith]

Glitchstolfo

[Vencord/Vendroid] New star added

[charred monolith]

scarrrr316

[Vendicated/Vencord] Pull request opened: #3117 Translate: Add support for DeepLX

• Main: Add support for DeepLX, a powerful and free DeepL API that does not require token.
• Resolved a previous issue where the source language was not displayed correctly when src was the base language.

[analog knoll]

Does the discord's game sdk's RPC work for you on Vesktop linux?
It says that f.kio.core: "/var/home/neo/.local/share/flatpak/exports/share/applications/com.discordapp.Discord.desktop" contains supported protocols but doesn't use %u or %U in its Exec line! This is inconsistent.
with vesktop and works normally with the official discord client opened.
interestingly on macos it works

I'll make an issue, but just making sure I am not forgetting something

[fossil inlet]

Vesktop doesn't support rpc

Only arrpc iirc

Also #🖥-vesktop-development

[analog knoll]

oh, this is vencord only, sorry. Will copy my messages over

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[ripe oxide]

skill issue

[charred monolith]

fairhopeweb

[Vencord/Installer] New star added

[odd heath]

Were gonna get a terrible update right when they return from holiday lol

[dusk blaze]

yop

[fossil inlet]

NO FUCKING WAY

@dusk blaze LMFAO

[fossil inlet]

The funniest part is that my website links my discord in like three places

[jolly egret]

lmao

[fossil inlet]

And I don’t think I ever worked on that plugin

[dusk blaze]

sadanic...

[opaque silo]

sadans large hole dot com???

[dusk blaze]

@opaque silo @opaque silo

[odd heath]

Tasty

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #3118 ConsoleShortcuts: Add openModal and openModalLazy

they're useful for adding breakpoints to find out where a modal is
opened from, and annoying to find

[charred monolith]

Nitikpsn

[Vencord/Vendroid] New star added

Nitikpsn

[Vencord/Vendroid] Fork created: Nitikpsn/Vendroid

[charred monolith]

grapeloverr

[Vencord/Vendroid] New star added

[astral bone]

is anyone else having path issues on dev shell?

[fossil inlet]

What do you mean

[astral bone]

When building with user plugins, I get this

The plugin 'glob-plugins' was triggered by this import:

src/api/Badges.ts:22:20:
  22 │ import Plugins from '~plugins';
     ╵                     ~~~~~~~~~~

I think this is bcs of the folder name mix-up because both the plugins and userplugins folders contain 'plugin' in their names.

also this

same import

[fossil inlet]

what command are you running

pnpm build or pnpm watch

[astral bone]

pnpm build

[fossil inlet]

check if you have any empty directories

with no files in them in src/plugins or src/userplugins

[astral bone]

its a clean clone

one sec

[fossil inlet]

userplugins is under gitignore

please just check

[fossil inlet]

also please show the full error

[fossil inlet]

yea you have an empty directory

please check and make sure none are empty

[astral bone]

nothing comes up as empty, i also looked through each one manually and nth was empty.

[fossil inlet]

yea, just tried it and cant manage to get that same error

@astral bone clone vencord into an new dir and try building there

do you get the same error

[astral bone]

works fine without userplugins, build perfectly. im js trying to find the directory thats empty

[fossil inlet]

it might not be an empty dir

[astral bone]

for you it works fine right? with both plugins and a userplugins folder?

[fossil inlet]

yeah

[austere talon]

send the whole output...

[scenic brook]

^

[fossil inlet]

they did
#👾-core-development message

[austere talon]

follow the docs properly and you wouldn't have this issue

you put an index.ts[x] file right in your plugin folder

why would you do that

[jolly egret]

[fossil inlet]

[jolly egret]

maybe you shouldn't have the role because you're using our channels as a substitute for reading

because before you didn't install depedencies and were complaining in #🏥-vencord-support-🏥 😭

[fossil inlet]

[astral bone]

yes i do, its this one
https://github.com/Vendicated/Vencord/blob/main/src/plugins/index.ts, the repo has the same thing? all lone index.ts files that i made are in the userplugins folder.

[austere talon]

and that's not valid. you would know that if you read the docs properly

are you actually interested in developing your own plugins?

[astral bone]

i have already made a few, maybe only "/" commands for now but yes

[austere talon]

and this is not it

you have a different index.ts file

anyway you should figure it out yourself instead of littering this channel

follow the docs and you'll figure it out, they describe everything

[astral bone]

thank you for your time, all of you

[austere talon]

https://docs.vencord.dev/installing/custom-plugins/#adding-your-plugin

Your plugin should be either a simple myCoolPlugin.ts or myCoolPlugin.tsx file, or a folder containing an index.ts or index.tsx file

[charred monolith]

kodenamekrak

[Vendicated/Vencord] Pull request opened: #3119 New Plugin: fixupLinks

Adds configurable domain replacement in messages, primarily intended for easier use of fixup websites such as fxtwitter that provide prettier discord embeds

[fossil inlet]

me when textreplace

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #3119 New Plugin: fixupLinks

Vendicated

[Vendicated/Vencord] New comment on pull request #3119: New Plugin: fixupLinks

TextReplace can do this

[jolly egret]

thats just a worse version of textreplace

[weak thistle]

tbf you could add like a toggle to textreplace with defaults for the fixup links or smth

[scenic brook]

You never know when they could just lapse and become links to literally anything though

[charred monolith]

dimabreus

[Vendicated/Vencord] New comment on issue #615: [Feature Request] Array Settings type

Any update on this?

[odd heath]

Oh no I'm getting the terrible idea to attempt to implement that

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3084 quickSnip!

needs a readme.md

splatterxl

[Vendicated/Vencord] Pull request review submitted: #3087 EmoteCloner: Fix a hang when the sticker/original server is deleted

cleaner code suggestions but lgtm otherwise

splatterxl

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

format to have normal key names not in quotes

splatterxl

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

                if (!sticker) return;

splatterxl

[Vendicated/Vencord] New review comment on pull request #3087: EmoteCloner: Fix a hang when the sticker/original server is deleted

                    }
                    
                    return fetchedSticker;

[charred monolith]

sadan4

[Vendicated/Vencord] New comment on pull request #3084: quickSnip!

i feel like this would be better as an addition to message tags instead of its own plugin

XoticStoz1fy

[Vencord/Vendroid] Fork created: XoticStoz1fy/vendroid

[charred monolith]

Metadorius

[Vendicated/Vencord] New comment on pull request #2769: Clarify how the translation plugin functions to prevent confusion

Hello?

[odd heath]

okay now how did i achieve this LMAO

[fossil inlet]

did vencord even load?

[odd heath]

yesn't

[fossil inlet]

if vencord is undefined then how

[odd heath]

i made it error while loading i just needed a moment to realise

[fossil inlet]

becuase $self in plugins would just error

[odd heath]

bc of me being dumb lmao

[charred monolith]

Err0r430

[Vendicated/Vencord] New comment on pull request #3084: quickSnip!

Added the README as requested. I'm unsure of the format of these (I took a look at a few but wasn't consistent) so I just wrote one that highlighted its features.

i feel like this would be better as an addition to message tags instead of its own plugin

I considered this, but I felt as though messageTags is geared towards a more keyboard-based usage experience, whereas QuickSnip is a simple button interface aimed at server admins/mods who repeatedly send the same basic messages to use...

[charred monolith]

sadan4

[Vendicated/Vencord] New comment on pull request #3084: quickSnip!

I considered this, but I felt as though messageTags is geared towards a more keyboard-based usage experience, whereas QuickSnip is a simple button interface aimed at server admins/mods who repeatedly send the same basic messages to users.
i see no reason not to combine the two, sometimes I don't want to type a command / would rather type a command. plus it would be confusing having snippets in two separate places

Err0r430

[Vendicated/Vencord] New comment on pull request #3084: quickSnip!

So shall I merge this plugin with messageTags? I still feel as though this could be a standalone plugin but am happy to merge if you think so.

[odd heath]

is there a way to force writing the current settings to the settings file

[fossil inlet]

backup and restore > export settings?

might not be what you want

[odd heath]

no i meant from code 😭

im trying to make it update when i add an item to an array of the plugin settings

[limber skiff]

overwrite the array instead of pushing

[odd heath]

o

couldve thought of that 😭

[odd heath]

guhhhhhhhhh

how do i fix

[limber skiff]

you messed up something, I dont know what

[odd heath]

i didnt tho

[limber skiff]

show your code

[odd heath]

fixed itself after restarting everything so

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[limber skiff]

uhm

weird

[odd heath]

i switched to dev and it didnt go away

cant be my code

[frail sky]

Bad Patches

PictureInPicture (had no effect):
ID: 546432
Match: ```
/.nonMediaMosaicItem]:.{0,40}children:[(?<=showDownload:(\i).+?isVisualMediaType:(\i).+?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[odd heath]

restarded and switched back and its fine now

lmao

[limber skiff]

they just went back to work and already exploded something

[odd heath]

yop

[jolly egret]

incredible

[fossil inlet]

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #3120 PictureInPicutre: Fix patch

not on stable yet

[odd heath]

@fossil inlet im gonna shamelessly borrow your code

[fossil inlet]

from where

[odd heath]

i needed the user mention component and remembered you just made a pr with it

[fossil inlet]

[odd heath]

love when my code doesnt work bc the place that calls it is commented out

trol

[fossil inlet]

@odd heath you should give me plugin ideas

[odd heath]

hydration reminder in dev mode or smth idek

just me not having drank anything the last 5h points to that being a good idea

[dusk blaze]

DiscordOs

@fossil inlet do i try making discord terminal

plugin

[fossil inlet]

add vim to discord

[odd heath]

when will i learn react

[dusk blaze]

i would need to make a websocket server from native.ts and spawn bash and spit out stdout to that websocket and make client connect to that websocket

[dusk blaze]

never

[odd heath]

😭

at least it doesnt crash lmao

oh

im so dumbb

[odd heath]

real

[fossil inlet]

does this happen for anyone else when clicking on a channel descriptioin

[limber skiff]

now I'm surprised discord doesn't have something like

const states = VoiceStatesStore.use(() => this.getVoiceState(channelId), channelId)

shortcut for useStateFromStores

[limber skiff]

nop

[fossil inlet]

could you /vencord-plugins

[limber skiff]

we will patch the prototype and make

Enabled Plugins (103):

AccountPanelServerProfile, AlwaysExpandRoles, AlwaysTrust, BetterGifAltText, BetterRoleContext, BetterSettings, BiggerStreamPreview, CallTimer, ClearURLs, ClientTheme, ConsoleJanitor, ConsoleShortcuts, CopyEmojiMarkdown, CopyFileContents, CopyUserURLs, CrashHandler, Dearrow, Decor, DevCompanion, DisableCallIdle, DontRoundMyTimestamps, EmoteCloner, Experiments, FakeNitro, FakeProfileThemes, FavoriteGifSearch, FixImagesQuality, FixSpotifyEmbeds, FixYoutubeEmbeds, ForceOwnerCrown, FriendsSince, FullSearchContext, FullUserInChatbox, GameActivityToggle, GreetStickerPicker, IgnoreActivities, iLoveSpam, ImageZoom, ImplicitRelationships, MentionAvatars, MessageClickActions, MessageLatency, MessageLinkEmbeds, MessageLogger, MoreUserTags, Moyai, MutualGroupDMs, NewGuildSettings, NoDevtoolsWarning, NoMaskedUrlPaste, NoOnboardingDelay, NoPendingCount, NormalizeMessageLinks, NoUnblockToJump, NSFWGateBypass, OpenInApp, PauseInvitesForever, PermissionFreeWill, PermissionsViewer, petpet, PictureInPicture, PinDMs, PlatformIndicators, ReactErrorDecoder, ReadAllNotificationsButton, ReplaceGoogleSearch, ReplyTimestamp, RevealAllSpoilers, ReverseImageSearch, ReviewDB, RoleColorEverywhere, Summaries, SendTimestamps, ServerInfo, ShikiCodeblocks, ShowAllMessageButtons, ShowConnections, ShowHiddenThings, ShowTimeoutDuration, SilentMessageToggle, SortFriendRequests, SpotifyControls, SpotifyCrack, StartupTimings, SuperReactionTweaks, ThemeAttributes, Translate, TypingIndicator, TypingTweaks, UnsuppressEmbeds, UserMessagesPronouns, UserVoiceShow, USRBG, ValidReply, ValidUser, VencordToolbox, ViewIcons, ViewRaw, VoiceDownload, VoiceMessages, VolumeBooster, WhoReacted, YoutubeAdblock
```**Enabled UserPlugins (1):**

AliucordDetector

[fossil inlet]

Enabled Plugins (88):

AccountPanelServerProfile, AlwaysTrust, WebRichPresence (arRPC), BANger, BetterFolders, BetterGifAltText, BetterNotesBox, BetterRoleContext, BetterRoleDot, BetterSettings, BetterUploadButton, BiggerStreamPreview, BlurNSFW, CallTimer, ClearURLs, ConsoleJanitor, ConsoleShortcuts, CopyFileContents, CrashHandler, Dearrow, DevCompanion, EmoteCloner, Experiments, FakeNitro, FakeProfileThemes, FixYoutubeEmbeds, ForceOwnerCrown, FriendInvites, FriendsSince, GifPaste, iLoveSpam, ImageZoom, ImplicitRelationships, LastFMRichPresence, LoadingQuotes, MemberCount, MessageLogger, MessageTags, MoreKaomoji, MutualGroupDMs, NewGuildSettings, NoBlockedMessages, NoDevtoolsWarning, NoF1, NoProfileThemes, NoUnblockToJump, NSFWGateBypass, OpenInApp, PermissionsViewer, petpet, PictureInPicture, PinDMs, PlainFolderIcon, PlatformIndicators, QuickMention, ReactErrorDecoder, RelationshipNotifier, RevealAllSpoilers, ReverseImageSearch, ReviewDB, RoleColorEverywhere, Summaries, ServerInfo, ShikiCodeblocks, ShowHiddenChannels, ShowHiddenThings, ShowMeYourName, SilentTyping, SortFriendRequests, SpotifyControls, SpotifyCrack, StartupTimings, StickerPaste, TextReplace, Translate, TypingIndicator, TypingTweaks, UserVoiceShow, USRBG, ValidUser, VencordToolbox, ViewIcons, ViewRaw, VoiceMessages, VolumeBooster, WebKeybinds, WebScreenShareFixes, WhoReacted
```**Enabled UserPlugins (11):**

FriendCodes, CopyFolderId, CopyStatusUrls, CtrlEnterSave, DarkDevTools, EmojiOnMouseUp, CustomFolderIcons, UnitConverter, ShowChars, StaticTitle, UrbanDictionary

[limber skiff]

[fossil inlet]

[limber skiff]

😞

well it probably works

[fossil inlet]

somehow it happens when vencord doesnt load

[limber skiff]

what do we think of that?

[fossil inlet]

cant you not bind this with arrow funcs, or am i crazy

[limber skiff]

i think you can

[fossil inlet]

||or am going even crazier||

Arrow functions don't have their own bindings to this, arguments, or super, and should not be used as methods.

[limber skiff]

you are right lol

[fossil inlet]

i love when reading mdn at 3 am for no reason is useful

[limber skiff]

ehmm

better

I'm gonna monkey patch 🔥

in this case VoiceStateStore is any so it cant do magic, but yeah

it worked

[fossil inlet]

@limber skiff how does discord use state from store in their code

or do they do something else entirely

[limber skiff]

they do the same as us currently

[fossil inlet]

im a bit stupid

for some reason i thought the useStateFromStores function was ours

[rugged spire]

nop

just make a common hooks script and add a useVoiceStates in there?

also what are you even doing with voice states

and can vcnarrator be less cursed afterwards

[limber skiff]

me?

that wasn't the point I was just experimenting

[rugged spire]

oh

[odd heath]

I will make

[rugged spire]

If you do, do not just make an array setting type, add options for lists of users, channels, and guilds

[odd heath]

Yop

Alr did

Just need to make the plugin modal render properly

And then fix some things

(the code is so husk)

I also added the adding to array via context menu thingy

[rugged spire]

Guh

[odd heath]

The api proposal says filtering for user arrays by roles and names, I don't really see how that would be useful?

[rugged spire]

I would consider that out of scope. At that point add a regex config type somehow

they probably just want to match every moderator role in every server for example

[odd heath]

You can just use string and manually parse the regex

[rugged spire]

[odd heath]

Like textreplace does

[rugged spire]

true

~~but thats also how array config effectively works already ~~

[odd heath]

It doesn't save tho

my implementation for array config of textreplace is just to put the arrays that it already has into another array instead of data store

I might be able to finish it on train later and open PR

Just needs some more polishing tho the code is still terrible lmao

[charred monolith]

EepyElvyra

[Vendicated/Vencord] Pull request opened: #3121 feat: Add an array option type

Not completely finished but mostly functional, tho i think the code is pretty bad

feedback and testing would be appreciated

[odd heath]

bwa

So Horror

[fossil inlet]

@odd heath

[odd heath]

I didn't know how to access the content of the element otherwise 😭

And it was 4am when I made this I think

[jolly egret]

real

i know its super unlikely but the old way most plugins were doing could allow user id confusion

[odd heath]

No that's real you never knew what I'd belonged to who lol

So annoying

[jolly egret]

lol

[odd heath]

I wanna add channel and guild mentions kinda but I was too lazy to find out how it works

Soontm

[granite wharf]

who ping

[opaque silo]

the ghost

[odd heath]

Is there an alternative tho?

[fossil inlet]

Probably, remind me to review your code latet

[odd heath]

Guhh when

[fossil inlet]

Until I get around go it (I loose track of things easily

[odd heath]

I'll remind you hourly

Eval setTimeout createmessage

[fossil inlet]

[odd heath]

@fossil inlet @fossil inlet Hi

[fossil inlet]

@odd heath shouldnt src/plugins/_api/settingArrays.tsx go under _core instead

wait maybe not

guhhh idk

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #3121 feat: Add an array option type

sadan4

[Vendicated/Vencord] New review comment on pull request #3121: feat: Add an array option type

afaik <>/*code*/</> is the same thing as <React.Fragment>/*code*/</React.Fragment>

[odd heath]

No it's only needed if wanted

[odd heath]

Idk I stole it from textreplace 😭

[fossil inlet]

@odd heath for something like this, when an invalid value is entered, wouldnt it be better so the user can fix any typos, etc... instead of erasing it

[odd heath]

Uh yeah True

I just had copy paste in mind in which case I thought clearing it out makes more sense

But yeah

[fossil inlet]

even with copy paste

user could hit a key by accident

just annoying to have to re-enter it

[odd heath]

True

[odd heath]

Fixed

[fossil inlet]

@odd heath is there any reason to not make these javadoc comments?

[odd heath]

Nop

Will change

[jolly egret]

explode

[fossil inlet]

check your mailbox

[jolly egret]

jokes on you i don' thave one

[odd heath]

Nop

[frail sky]

Bad Patches

PictureInPicture (had no effect):
ID: 546432
Match: ```
/.nonMediaMosaicItem]:.{0,40}children:[(?<=showDownload:(\i).+?isVisualMediaType:(\i).+?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

PictureInPicture (had no effect):
ID: 546432
Match: ```
/.nonMediaMosaicItem]:.{0,40}children:[(?<=showDownload:(\i).+?isVisualMediaType:(\i).+?)/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[odd heath]

Also @fossil inlet What do you think about the guild and channel rendering, should it be text or a mention?

[fossil inlet]

havent tried it yet

[limber skiff]

guild icon and name

channel symbol and name

like voice, text, etc

[fossil inlet]

@limber skiff when you have time
https://github.com/Vendicated/Vencord/pull/3120

[odd heath]

Okay

[limber skiff]

group dm icon or users icon

(like user voice show)

[odd heath]

Ob right I need to add gdm

[odd heath]

Does it make sense to prefix it with guild name

[limber skiff]

yep don't worry

[odd heath]

Bc a lot of guild have generic names like general

[limber skiff]

sort by guild

and add a guild icon and name on top of it each section

[odd heath]

Okie

?remind 12h this shit

[shut vine]

Alright @odd heath, in 12 hours: this shit

[odd heath]

[limber skiff]

you might wanna focus on just array cuz all of this is a lot

and it's honestly pretty hard to implement in a extensible way

[odd heath]

True

I'm still gonna try

[limber skiff]

is there any pr someone would like a quick look rn

preferably a new plugin, but nothing too big

[fossil inlet]

not a new plugin, but pretty small

https://github.com/Vendicated/Vencord/pull/3118

[limber skiff]

oh yeah that's minimum

oh yeah I need to finish the dependencies update

[fossil inlet]

which pr is that

[limber skiff]

one from vee

it might be almost ready

[jolly egret]

oh fire the update which causes 100 people in #🏥-vencord-support-🏥 to complain because their clients won't autoupdate 🔥

if only people didn't ask

[limber skiff]

the devbuild people yes

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request closed: #3103 SpotifyControls: Setting to restart playing song if playtime >3s

Nuckyz

[Vencord:dev] 1 new commit

3462930 SpotifyControls: Setting to restart playing son... - nin0-dev

Nuckyz

[Vendicated/Vencord] Pull request closed: #3118 ConsoleShortcuts: Add openModal and openModalLazy

Nuckyz

[Vencord:dev] 1 new commit

3af06ed ConsoleShortcuts: Add openModal and openModalLa... - sadan4

Nuckyz

[Vendicated/Vencord] Pull request closed: #3120 PictureInPicture: Fix picture in picture button

Nuckyz

[Vencord:dev] 1 new commit

d60a8ef PictureInPicture: Fix picture in picture button... - sadan4

[limber skiff]

time for it https://github.com/Vendicated/Vencord/pull/3090

[charred monolith]

Nuckyz

[Vencord:update-dependencies-eslint] 8 new commits

79e2cb1 QuickReply: Prevent caret from moving when sele... - Sqaaakoi
0e813e7 OpenInApp: Add support for geo.music.apple.com ... - faejr
0fd76ab NoUnblockToJump: Also allow jump for ignored us... - sadan4
20ed7dc new plugin FullUserInChatbox (#2766) - sadan4
3462930 SpotifyControls: Setting to restart playing son... - nin0-dev

[fossil inlet]

@limber skiff dont push to main yet, i think d60a8efcbff5f6eebdc29c6ed73e6012f6b9f064 might have a bug

[limber skiff]

uhmm alright

[fossil inlet]

@limber skiff unshift returns the new length 😭

[limber skiff]

nahh u gotta be kidding me

LOL

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request review submitted: #3090 Add React eslint & update depencenies

Nuckyz

[Vendicated/Vencord] New review comment on pull request #3090: Add React eslint & update depencenies

I looked into it and didnt found Promise<ReactElement> anywhere, I'm reverting this

[limber skiff]

didnt found

peak grammar

[charred monolith]

Nuckyz

[Vencord:dev2] 7 new commits

79e2cb1 QuickReply: Prevent caret from moving when sele... - Sqaaakoi
0e813e7 OpenInApp: Add support for geo.music.apple.com ... - faejr
0fd76ab NoUnblockToJump: Also allow jump for ignored us... - sadan4
20ed7dc new plugin FullUserInChatbox (#2766) - sadan4
3462930 SpotifyControls: Setting to restart playing son... - nin0-dev

[limber skiff]

@fossil inlet thanks for it

I completely forgot about that

(and trusted my simple change)

[fossil inlet]

np

did you fix

[charred monolith]

Nuckyz

[Vencord] Branch dev was force-pushed to `16a1c44`

Compare changes

[limber skiff]

yeah

[charred monolith]

Nuckyz

[Vencord:update-dependencies-eslint] 4 new commits

026cf35 This should be ReactNode instead - Nuckyz
abc6694 Use FunctionalComponent instead - Nuckyz
16a1c44 PictureInPicture: Fix picture in picture button... - sadan4
fa49167 Merge branch 'dev' into update-dependencies-eslint - Nuckyz

[limber skiff]

...

I literally ran tests before pushing lmao

[fossil inlet]

[limber skiff]

now you tell me there are problems

god

wait why are we even updating react types @austere talon

discord is still on v18

there is no point on having types for a different version

I'm reverting that

[austere talon]

nah

I just updated everything, only halfway through I realised it should probably match version

[limber skiff]

oh

[austere talon]

but it doesn't change much and it was already done

and future proofing :p

so i decided to just leave it in

[limber skiff]

alright I will see a better way to fix this awaitable stuff

[austere talon]

even on canary?

[limber skiff]

yeah

they prob arent updating so soon either way

will likely have exploding type definitions like us

[austere talon]

anyway it's only types so it hardly matters xD

if anything it made me find a part of code that was using deprecated stuff

[austere talon]

if we make our types ahead of discords version, we can future proof for when they update to versions that make breaking changes

I'm mostly joking but it really was that way lmao

(with the react dom root in console shortcuts plugin)

[limber skiff]

uhh

how does one module patch

do I clone the repository in the specific version, do the diffs and then make a .patch from it

[fossil inlet]

pnpm patch iirc

[austere talon]

do you mean how to patch npm modules?

[limber skiff]

yeah

[austere talon]

yeah you just use the pnpm patch command

[limber skiff]

oh

[austere talon]

it creates a folder with the files in tmp folder

you edit

then you run a second command to submit

it generates patch and installs it

Super easy

[limber skiff]

god

the other day I cloned a repo for it

and couldnt even produce the correct patch file

[fossil inlet]

before i knew about the pnpm patch command i just had a script to edit node_modules 😭

[austere talon]

lmao

insane

[austere talon]

I mean i still do this (manually edit node modules file for quick dirty local edits)

[fossil inlet]

yea, but i had it run as postinstall

[limber skiff]

alright that was easy

[austere talon]

why

you can return promise

it's part of new react stuff

[limber skiff]

in v19

not in v18 as we currently are using

so for now lets patch that out

[austere talon]

nah that's terrible 😭

[limber skiff]

how?

it's the only conflicting types right now

[fossil inlet]

why have types for something thats not supported yet?

[limber skiff]

if we dont do this we have to write a custom functional type for every single part

or custom ReactNode type

[austere talon]

no

it works fine everywhere else

just that one place

[limber skiff]

yeah but at the same time we don't want to allow Promise stuff

current react does not support it

it makes no sense to have it in the types

as you said, future proofing

but what's causing issues we take off

it's just a patch file that can easily be removed in the future

[austere talon]

it's very cursed to do and just not necessary in the slightest

the way it is is perfect

[limber skiff]

I dont think it's cursed at all

I removed all the references of promise stuff in the types

everything continues to work as expected

I find the alternative of making a custom functional type more hacky and worse

since it's not perfect types for it

[austere talon]

just leave it the way it is

[limber skiff]

the patch seems more correct

it has no issues either

[junior olive]

hehehehehehe

[fossil inlet]

since when is there a shadow avatar decoration 😭

[junior olive]

since my favorite hot topic hedgehog went to the big screen

[fossil inlet]

😭

sending this to my friend right now

(saw the movie with him opening night)

[austere talon]

idk why i need to tell you this but editing a library to make their types incorrect is not more correct

the correct way is manually typing the specific thing you need

[limber skiff]

well but it's very annoying thing

[junior olive]

Isn't this a issue of installing the wrong version of types?

[limber skiff]

yes

[fossil inlet]

@junior olive is it no longer in the shop?

[junior olive]

it was a quest

[junior olive]

so why not install the correct version

[limber skiff]

future proofing

[austere talon]

it's really not a big deal :p

this was one specific thing

[limber skiff]

I mean, the types are already incorrect, I don't see a reason to not edit them and make them a little more correct

[austere talon]

just leave it as is it's perfectly fine

[limber skiff]

I'll just do this then

and pretend that's how it's supposed to be

[charred monolith]

Nuckyz

[Vencord:update-dependencies-eslint] 1 new commit

f6a795f Update deps again and make types a little less ... - Nuckyz

Nuckyz

[Vendicated/Vencord] Pull request closed: #3090 Add React eslint & update depencenies

Nuckyz

[Vencord:dev] 1 new commit

7be3a40 Add React eslint & update depencenies (#3090) - Vendicated

[limber skiff]

this is gonna explode so many devbuilds

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request closed: #3079 Bump nanoid from 5.0.7 to 5.0.9

dependabot[bot]

[Vendicated/Vencord] New comment on pull request #3079: Bump nanoid from 5.0.7 to 5.0.9

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

dependabot[bot]

[Vendicated/Vencord] branch deleted: dependabot/npm_and_yarn/nanoid-5.0.9

[junior olive]

@dependabot fuck off

[grizzled halo]

let them flood support

[austere talon]

we should merge this one too https://github.com/Vendicated/Vencord/pull/3028

it renames a bunch of api methods

[limber skiff]

yep

[austere talon]

but it's not fully ready yet

[limber skiff]

but that one needs a bit more work

i'll leave it for another day

[austere talon]

I'll do tomorrow

[limber skiff]

o

alright

I will review again after you do

I'll wait for tomorrow to push to main

lets break all the stuff at once

[charred monolith]

sadan4

[Vendicated/Vencord] Issue opened: #3123 [Bug] Image Zoom context menu options appear even when you can't zoom

Discord Account

_sadan.

What happens when the bug or crash occurs?

What is the expected behaviour?

Image zoom to not add context menu options when you cant zoom

How do you recreate this bug or crash?

1. right click on an image that cant be zoomed, eg: profile status emoji in profile popout
2. see image zoom options

Errors

N/A

Request Agreement

• [X] I am using Discor...

sadan4

[Vendicated/Vencord] Pull request closed: #2685 Emote cloner improvements

sadan4

[Vendicated/Vencord] New comment on pull request #2685: Emote cloner improvements

this is horrorcode, im rewriting

[desert cosmos]

you will explode

[shut vine]

@odd heath, <t:1735950944:R>: this shit

[odd heath]

Guhhh

[rugged spire]

you love documenting something that is well known but nobody cares about

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] New comment on issue #3123: [Bug] Image Zoom context menu options appear even when you can't zoom

also occurs for some links as they want to reuse the copy and open link buttons

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #3121 feat: Add an array option type

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #3121: feat: Add an array option type

is the fragment even required at all?

[odd heath]

nop

isnt

[rugged spire]

[odd heath]

horror

i did not know that diff was 600 lines 😭

[rugged spire]

HOW

are you writing the next fakenitro by accident

[odd heath]

[odd heath]

that was solely the last commit btw

[charred monolith]

c45513v

[Vendicated/Vencord] New comment on pull request #2536: [Plugin] Plural Kit Integration

thanks for your contribution!

unfortunately this is way too niche, sorry

For the record, a lot of us who would use this plugin see your reply as pure bigotry. I know in a previous response it was mentioned that its not common in the servers that you as developers are in- That may be true, but that's an extremely selfcentered point of view. I highly implore you to reconsider.

[rugged spire]

i would so love to leave my comment on this if it wasnt for the fact that such comment would basically be worthlessly neutral

[odd heath]

now does discord have any kind of picker one could hijack for these

or do i keep it with text boxes

[rugged spire]

There is this design systems page

You should check it out

[odd heath]

i didnt know that existed lol

[rugged spire]

Maybe you could also steal the modal from the roles settings?

nah

steal the components from the forwarding menu instead

they're not as fucked up for your use-case as they are for selecting a channel

[odd heath]

good idea

[rugged spire]

actually

vee will kill you for stealing components for a settings menu

[odd heath]

why

lmao

[rugged spire]

also forwarding menu is so awful

you cant type an ID into it

maybe just take the design from it

[odd heath]

can keep text input and picker as extra menu next to it

[brazen bone]

Forward menu deliberately excludes current channel

It's retarded

[odd heath]

dont need that menu for that either way

[rugged spire]

What are you talking about

[brazen bone]

Did they change that?

I made a plugin to fix it

[rugged spire]

No I'm trolling you.

oh come on dont tell me you're the 3rd person to make that same plugin

[brazen bone]

Bad sqaa, stop fooling me into thinking discord would ever improve any feature

[odd heath]

so should i try to put the forward menu in there or should i just leave it as is

[rugged spire]

Use the list for inspiration.

Make use of the Checkbox component

The types for it are very poorly documented iirc

[rugged spire]

Sorry but my Nitro™️ expired recently and I had to witness the send longer messages with nitro upsell component again

[rugged spire]

no but seriously did you also make this plugin @brazen bone

[odd heath]

guhhhhhhhhhhhh

[brazen bone]

https://github.com/Kyuuhachi/VencordPlugins/blob/main/Onward/index.tsx

[odd heath]

tbf i just need the search component technically

[brazen bone]

Also tweaks the menu prioritization

[rugged spire]

okay, so you did the sort the search results array tactic

is that right?

[brazen bone]

What

I remove the "is current channel" check

[rugged spire]

I implemented it in a really weird way

How

[brazen bone]

Don't remember, was a while ago

[rugged spire]

2 MONTHS AGO?

vencord's worst problem is any new development happens without any discussion so everyone with a contributor role here likely has their own secret plugins that are published somewhere but nobody knows they exist
not to mention that if they are submitted they never get accepted

[rugged spire]

so you're actually the first person

[dusk blaze]

yop

i have so many private plugins

[odd heath]

I have 0

[charred monolith]

Ransomwave

[Vendicated/Vencord] New comment on pull request #2558: New Plugin: Custom folder icons

Hey. As I correctly guessed, this likely will never get merged considering they archived the "plugin-requests" repository. Is there any way I can add this to my client now considering this branch is out of date? Thanks.

[rugged spire]

~~Merge it and see what breaks ~~

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request closed: #2558 New Plugin: Custom folder icons

sadan4

[Vendicated/Vencord] New comment on pull request #2558: New Plugin: Custom folder icons

closing this for now as the code is terrible I will rewrite it sometime in the future

[charred monolith]

Ransomwave

[Vendicated/Vencord] New comment on pull request #2558: New Plugin: Custom folder icons

</3

[fossil inlet]

@main swallow if you want it sooner, fix it yourself

[astral bone]

Intriguing

[odd heath]

mfw i spent 1h looking for something only to realise i was looking at the wrong place

[charred monolith]

lewisakura

[Vendicated/Vencord] New comment on pull request #2536: [Plugin] Plural Kit Integration

@c45513v Please read #3058 with an updated comment, and please note that we do not accept plugins that only work with specific bots under the latest plugin rules.

[turbid hatch]

i believe their "previous response" is that PR, but i added it just to make sure

and also highlighted that its against our plugin rules now anyway

once again, i wish userplugins were easily accessible and we had a proper plugin loader, but not today

[austere talon]

(and never)

and that person has been blocked

[granite wharf]

@turbid hatch I've wrote most if not all the backend needed for the tauri installer, could you help me incorperate it? Currently there is a CLI, but the project is structured severely different than what currently is present within the tauri branch, and I have no experience in working with tauri in the slightest

[turbid hatch]

ive never worked with tauri :p

i only started my rust adventure a few days ago

but ill take a look tomorrow

[austere talon]

it should be interactive like the current one

not type number