Oh!
#👾-core-development
limber skiff
dang
high oracle
Once you submit, you have to wait
limber skiff
that sucks
high oracle
The best you can do is wait
jolly egret
goddamn it we have to wait, to submit another fix to wait again?
limber skiff
yep
jolly egret
that just sucks
fossil inlet
+FcYMz
yup
@limber skiff should i make a searchable thing of all old keys and their hashes
limber skiff
let me send you a mapping
sex
@fossil inlet wait are you planning in putting that json inside vencord
don't do DJSFHDJSFDS
fossil inlet
<@521819891141967883> wait are you planning in putting that json inside vencord
nooooooooooooo
horror
jolly egret
10 minutes after being shafted by automod later for trying to say a word nuckyz said, i have returned to ask if that also fixes message logger with collapse deleted enabled?
limber skiff
no idea
limber skiff
nvm
rugged spire
yes 
still maple
they pushed intl changes
limber skiff
someone delete messages for me
rugged spire
guhhhhh fuck off
limber skiff
ugh
rugged spire
FORCE PUSHING IS A FUCK
i hope this branch gets to die soon
?remindme 3mo hey have you made a v3 of "your stable plugins" yet due to git hell
shut vineBOT
Alright @rugged spire, in 3 months: hey have you made a v3 of "your stable plugins" yet due to git hell
rugged spire
funny
fossil inlet
10 minutes after being shafted by automod later for trying to say a word nuckyz ...
no, but im fixing bothj
fossil inlet
fixed both 
limber skiff
to fix that
fossil inlet
i hate discords new formatting system
limber skiff
we are gonna have to figure out how to add a new message
did u do that lol
limber skiff
NO
rugged spire
this is fucking cursed
limber skiff
that's not happening
rugged spire
IS DISCORD USING AN ENTRIES LIKE FORMAT BECAUSE THEY CANT SET ARRAYS AS KEYS
insane as fuck
rugged spire
i know what it is
squash merge fucked stuff up on that branch
i should've pulled
rugged spire
squash merge fucked stuff up on that branch
trol
dusk blaze
on that note
we should really have something to push messages to all vencord users
similar to revanced alerts
dusk blaze
we should really have something to push messages to all vencord users
(could be disabled but enabled by default)
rugged spire
we should really have something to push messages to all vencord users
i have a shitty system for this on my soft-fork but it is hardcoded in
rugged spire
the origins of you running sudo init 0 and getting trolled
@dusk blaze@dusk blaze@dusk blaze@dusk blaze@dusk blaze@dusk blaze@dusk blaze do you know what this message means
vfjd?
nimble pendant
rugged spire
im stupid
dusk blaze
what is this thing
rugged spire
git submodule hell
limber skiff
I have no idea what they use to generate an ast
and I'm looking at the non minified source
it might not even be included in the client
fossil inlet
it might not even be included in the client
yea its not
its parsed and generated at compile-time
limber skiff
yeah
fossil inlet
ive been looking at it for the past bit
fossil inlet
its native rust code
limber skiff
oh
limber skiff
damn
limber skiff
do this then
limber skiff
and add @TODO: Find a better way to generate this
fossil inlet
@limber skiff am i crazy or did your review vanish
limber skiff
I deleted it
fossil inlet
ah
limber skiff
i made a mistake
limber skiff
mark it as ready
fossil inlet
alr did 😭
limber skiff
we should work together and make a package for generating the ast
which other mods can use too
fossil inlet
alr
fossil inlet
we should work together and make a package for generating the ast
at runtime, right
fossil inlet
any plans to type i18n
fossil inlet
i figured go deep on .intl and .t , but dont to that deep on other props
jolly egret
<@158567567487795200>
done
austere talon
@shy veldt
shy veldt
<@343383572805058560>
try on japanese
odd heath
me
fossil inlet
try on japanese
guhhhhh
i will fix soon™️
charred monolithBOT
brazen bone
A sha256 of the original filename? ...why
brazen bone
Why does it change the svg
Oh, it moves the } to the same line. That took a while to find
And removes the noop: true? What is this guy smoking
fossil inlet
this isnt a bad idea, but it does a bunch other random stuff
fossil inlet
And removes the noop: true? What is this guy smoking
tbh ive never understood error boundaries
brazen bone
I think noop: true makes it give nothing instead of large red box
shy veldt
its turk
fossil inlet
the syntax just confuses me
shy veldt
what did you expect :3
brazen bone
Which is probably good if the element is smaller than the large red box
glass jasper
This gotta be a bot account
shut vineBOT
@rugged spire, <t:1730674213:R>: find a suitable name and description for simplifiedprofilenotes
charred monolithBOT
austere talon
tbh ive never understood error boundaries
catches errors inside your component
austere talon
function MyComponent() {
throw "balls";
}
const MySafeComponent = ErrorBoundary.wrap(MyComponent);
const MySafeSilentComponent = ErrorBoundary.wrap(MyComponent, { noop: true })
<MyComponent /> // crashes entire app
<MySafeComponent /> // renders red error box
<MySafeSilentComponent /> // renders nothing
how do you pass props?
austere talon
same way
brazen bone
The component returned by ErrorBoundary.wrap behaves exactly like the wrapped component except it doesn't crash
It's something like ```js
function wrap(Component, errorProps) {
return (props) => (<ErrorBoundary {...errorProps}><Component {...props} /></ErrorBoundary>);
}
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/components/ErrorBoundary.tsx...
ErrorBoundary.tsx: Lines 111-115
ErrorBoundary.wrap = (Component, errorBoundaryProps) => props => (
<ErrorBoundary {...errorBoundaryProps} wrappedProps={props}>
<Component {...props} />
</ErrorBoundary>
);
Oh so there's a wrappedProps too. That's surely useful for... something
austere talon
it's used in onError
const Thing = ErrorBoundary.wrap(Component, {
onError: ({ error, props }) => {
console.log("Failed to render Component with foo =", props.foo);
}
});
i don't think this is used anywhere tho xD
charred monolithBOT
fossil inlet
i think i know whats causing the typing tweaks crash @shy veldt
discord issue that results in vencord issue
discord tries to format the username to be bold
but for some reason it results in a markdown string instead of a <strong> react element
note the markdown string doesnt get formatted
it just shows up as **user** is typing
@austere talon do i fix the bug in discords i18n if the plugin is enabled
long stream
wouldn't that be out of scope for the plugin though
especially since it's gonna be fixed in like a week or two probably
fossil inlet
yea, prob
austere talon
eh bad fix
use React.isValidElement
or something else
the .username check is very weird
fossil inlet
like this?
austere talon
idk
test it
how does that even work for discord
we're just returning their "element"
why does it crash for us but not them
jolly egret
wait didn't you already fix this
austere talon
or does it crash on stock discord too
fossil inlet
jolly egret
bruh the fix was broken 
fossil inlet
user object gets passed instead of name wrapped in strong/>
fossil inlet
wait didn't you already fix this
this is a bug in discords i18n
jolly egret
oh
austere talon
or does it crash on stock discord too
?
fossil inlet
only for Japanese locales
austere talon
I found something similar to this that caused crashes on most locales and got $2k bug bounty from their hackerone
trol
fossil inlet
@austere talon is there something like react.isvalidelement for anything react can render
string, elements, ...
austere talon
idk really
austere talon
const isInvalid = e => typeof e === "object" && !e.type
maybe this
no
hmmm
it's $$type or smth like that
I'm not at my computer
I still don't understand how this causes crashes for us not but discord
austere talon
so good
find a way to abuse this to crash someone (not yourself) using the Japanese locale
if you manage and report it to discord, you can claim free moneys
jolly egret
spreads a problem around publicly (on an alt) so it becomes a big issue then reports it to discord to get even more money 😎
(don't do this)
austere talon
it doesn't have to be a big issue
that's the point of bug bounties
finding issues before they become problems and cause damage
it just has to be impactful, e.g. if you can crash other people just by doing something
fossil inlet
who reacted determins if something is a user component by checking if it a react element with the strong type
normally the children looks something like this [<strong>username</strong>, "is typing"]
however, the Japanese i18n is broken and returns ["**", userObj, "**istyping"]
normally this would be ["**username**istyping"], but because typing indicators replaces the map of usernames, with userObjs, discord
's parser returns ["**", userObj, "**istyping"] instead
@austere talon guhhhh
austere talon
lmao
fossil inlet
find a way to abuse this to crash someone (not yourself) using the Japanese loca...
i doubt you can with this bug, as you would need to pass an object to the format function, which would prob get caught by type checkers
jolly egret
i'd say its a fair time to unlock #🏥-vencord-support-🏥 now
it should have calmed down by now
limber skiff
done
rugged spire
it should have calmed down by now
Wrong
fossil inlet
does anyone know why where is an extra char in the short hash here
@rugged spire explain
rugged spire
idk
cunning canyon
devbuild vs not devbuild
fossil inlet
devbuild vs not devbuild
yea, but like where does that difference come from
ive been looking the code but cant find it
brazen bone
does anyone know why where is an extra char in the short hash here
Different git version I guess
austere talon
the short commit length is implementation dependant
charred monolithBOT
astral bone
I wonder how hard the logic for that plugin will be
jolly egret
I wonder how hard the logic for that plugin will be
i mean.. you're looking at it
astral bone
Yeah
jolly egret
Is it just me thats experiencing occassional weirdness in the positioning of Vencords settings? Sometimes its pinned to the bottom (restarting discord fixes it)
limber skiff
that's weird
jolly egret
i think i saw somebody in #🏥-vencord-support-🏥 mention this too, but i can't find it now
trim gull
I wonder how hard the logic for that plugin will be
for what plugin? xd
astral bone
for what plugin? xd
#👾-core-development message
not rlly a plugin, js added functionality to an existent plugin
jolly egret
thats what i'm sayin
charred monolithBOT
fossil inlet
i think better folder might be a tad folders
@grizzled halo has anyone reported this yet?
charred monolithBOT
fossil inlet
diff --git a/src/plugins/betterFolders/index.tsx b/src/plugins/betterFolders/index.tsx
index bb1a67ebb0..50dee4f563 100644
--- a/src/plugins/betterFolders/index.tsx
+++ b/src/plugins/betterFolders/index.tsx
@@ -274,12 +275,16 @@ export default definePlugin({
},
makeGuildsBarGuildListFilter(isBetterFolders: boolean) {
- return child => {
- if (isBetterFolders) {
- return child?.props?.["aria-label"] === i18n.Messages.SERVERS;
- }
+ try {
+ return child => {
+ if (isBetterFolders) {
+ return child?.props?.["aria-label"] === getIntlMessage("SERVERS");
+ }
+ return true;
+ };
+ } catch {
return true;
- };
+ }
},
makeGuildsBarTreeFilter(isBetterFolders: boolean) {
@limber skiff i might be stupid, but shouldn't this try-catch be inside of the returned function
fossil inlet
nah it's fine
wait then whats the point of it
fossil inlet
because i dont think returning a function can throw
fossil inlet
alr
charred monolithBOT
Basically as the title describes.
Normal block just restrains certain users from messaging you etc. -> This also voicemutes them.
Option to do this automatic or with button.
Before:
After:
Also for the crybabies on discord:
brazen bone
Oh
jolly egret
tbf, if PRs were merged more often there would be less duplicates
especially with a project like this where discord breaks stuff so PRs go constantly stale Maintainers time is precious and we all love you
shut vineBOT
@fossil inlet, <t:1730322928:R>: plugin to replace github links with lines with the actual code
limber skiff
how?
the link should be returning as webp
that's the whole point of animated in getEmojiURL
fossil inlet
that's the whole point of animated in getEmojiURL
animated webp embeds as a static image in discord
discords media proxy doesnt support it
limber skiff
god everything is broken
fossil inlet
guhhh
turns out this only happens when switching accounts
idk if this was a thing before
charred monolithBOT
ShowMessageEmbeds
ShowMessageEmbeds
Adds a context menu option to show embeds for links that don't have one.
Right click on the link and select "Show Embed" to use.
The new embed is only visible locally, allowing you to view embeds of links sent by users that don't have embed permissions or surrounded the link with in their message.
scenic brook
I kinda wanted to add settings so you could define url replacements, so if you clicked show embed on, say, a twitter link, it'd give you a vxtwitter embed instead
But maybe in future
limber skiff
#{intl::+2QBZW::raw}
scenic brook
What's the difference between that and just using "+2QBZW" directly?
limber skiff
gets transformed to ["+2QBZW"]
just like if you used the non hashed key
it's meant to be a universal way of targetting intl keys
so that we can easily change things
scenic brook
Gotcha
gritty iris
so that we can easily change things
I dont understand exactly from what I can tell it just does for instance ["9RNkeH"] without raw and with raw ["APP_TAG"]?
charred monolithBOT
limber skiff
I dont understand exactly from what I can tell it just does for instance `["9RNk...
ur using the non hashed key
raw is for when you are using the hashed key
gritty iris
ah alr
limber skiff
scenic brook
I have another plugin that shares a lot of code with this but I feel like they do different enough things that I'm not sure if I should keep them separate or just merge them into one
ShowMessageEmbed lets you fetch and embed for a link in a message
EmbedReplace fetches a new embed with TextReplace-like rules applied to the url first and replaces the original embed
At the moment I have them slightly integrated anyway so that you can prevent the Show Embed button appearing for an embed that's been EmbedReplaced
But I don't know if maybe the EmbedReplace rules should just be part of the ShowMessageEmbeds settings
This is probably more #🧩-plugin-development but I forgot in replying to the github message
dusk blaze
this will fuck up my feature branches soon
STOP BASİNG ON UNSTABLE BRANCHES
rugged spire
STOP BASİNG ON UNSTABLE BRANCHES
i do what i must to avoid doing work later
sorry
i mean
i fix my plugins on what is apparently a stable API
jagged cloak
well dont bse on temp branches or just deal wit xd
charred monolithBOT
fossil inlet
is it possible to set the path vesktop loads from in console
opaque silo
nop
actually you can modify the path in the settings.json
but not as a launch arg if thats what you meant
you could sed "match" && vesktop
fossil inlet
nop
not sure if this works but after a bit of digging i found VesktopNative.fileManager.selectVencordDir
fossil inlet
yea 😭
my vesktop was stuck on a old commit and it wouldnt update
so i needed to swap it
opaque silo
buh
charred monolithBOT
austere talon
not sure if this works but after a bit of digging i found `VesktopNative.fileMan...
yes that's right
but it doesn't take argument, instead it shows a file picker prompt
fossil inlet
Yea, that was all I needed
jolly egret
Anyway chrome extension is updated now, so if you wanna push a second round of fixes you can do that
fossil inlet
i think i have a few fixes open rn
@jolly egret have people found any bugs that arent fixed yet?
fossil inlet
i also found the most minor possible bug in permission viewer
jolly egret
incredible
fossil inlet
it doesnt render formatted permission info tooltips, only the raw text
odd heath
Wtf did they do now
fossil inlet
Wtf did they do now
odd heath
Uh
Okay
Because I get full crash on loading vesktop on canary
Looks like it's only decor tho?
odd heath
yeah its decor
jolly egret
bruh
spice python
could parts of this be written with ai
jolly egret
probably
fossil inlet
looking into decor now
brazen bone
It's weird that ai manages to squeeze in so many comments despite being trained on human code
jolly egret
ai slop
crude raptor
It's weird that ai manages to squeeze in so many comments despite being trained ...
fr fr
jolly egret
i love removing lines in suggestions
scenic brook
Also for the crybabies on discord:
Seems a bit unnecessarily antagonistic
scenic brook
https://discord.com/channels/1015060230222131221/1015063227299811479/13037263500...
It's referring to this but I don't really see that as crying, I think they just didn't realise they were speaking to the pr author
jolly egret
can anybody reproduce the crash with Decor on ptb/canary?
I can't reproduce it, but others can. I just want something conclusive before i throw anything in #1257025907625951423
scenic brook
Yeah I ran reporter on ptb and it crashed me
grizzled halo
can anybody reproduce the crash with Decor on ptb/canary?
I can
jolly egret
aight i'll post something then
limber skiff
woah
jolly egret
wtf is the second one 💀
fossil inlet
so if no one fixes
I won't have fixes for decor until tonight if you don't get to them firt
first
jolly egret
nah, i get cursed stuff but i'm trying to figure out what the zustand persist middleware is doing in discords code
jolly egret
ah
charred monolithBOT
SortFriendList
Adds to the Friend List the date you became friends and sorts them.
shut vineBOT
Alright @fossil inlet, in 2 days: review
edgy nova
I just noticed the sorting itself may not be working no longer;
The dates work 100%
scenic brook
Yeah the sorting definitely doesn't work
Oh unless the sort is by name then yeah it's fine
odd heath
name is default yeah
edgy nova
No idea how to fix it; They can change the name to FriendListDates if needed, or if someone want to help out fix the sorting that would work out too I guess
It's just been super useful for me to clean my friend list, so thought of sharing it
odd heath
if its only for dates it should probably be integrated with friendsSince
because it does the same thing just in another place
edgy nova
To be fair it should be integrated with friend requests and change the name, then fix the sorting
that would make the most sense imo
edgy nova
Is it possible to get the "last active" date of a user?
scenic brook
Which would become creepy
odd heath
yeah
edgy nova
I mean, dont think it's creepy? I just want it for friend purging
limber skiff
plot twist
edgy nova
But tracking would be weird
scenic brook
I guess if it's only on friends it's not too bad
scenic brook
plot twist
The logs are spamming this, maybe you can find it by that lol
Just in case you missed it filling the entire console
edgy nova
Is that the friend plugin?
scenic brook
Nah just discord in general
edgy nova
Ah alright
scenic brook
No idea how to fix it; They can change the name to FriendListDates if needed, or...
It's because type 3 and 4 are incoming and outgoing requests, type 1 is existing friends
Just changing to type 1 fixes
fossil inlet
limber skiff
so many issuesss
limber skiff
fossil inlet
dev2 
fossil inlet
did discord change it
limber skiff
fossil inlet
how are emojis being returned as webp
try passing a size
limber skiff
still works
fossil inlet
are you on stable or canary
limber skiff
this is on stable
limber skiff
I knew something was wrong
fossil inlet
are you going to fix this some other way?
limber skiff
are you going to fix this some other way?
no need
we just gotta wait for discord to bump stable to canary
which should happen soon
let me fix this
fossil inlet
doesnt that only happen when switching accounts
fossil inlet
that has annoyed me more times than i can count
limber skiff
@fossil inlet what does this fix exactly?
limber skiff
that has annoyed me more times than i can count
you could have bumped me that
I didnt remember lol
fossil inlet
<@521819891141967883> what does this fix exactly?
hold on
let me find the message
@limber skiff #👾-core-development message
limber skiff
does it crash
charred monolithBOT
limber skiff
what if you have multiple categories
still works
you didnt just collapse direct messages right?
fossil inlet
yea
odd heath
sorrryyy
fossil inlet
tbh i didnt either untill someone else told me
odd heath
is that a stock feature or is pindms adding that
fossil inlet
is that a stock feature or is pindms adding that
prob the component being patch
limber skiff
is that a stock feature or is pindms adding that
stock haha
don't worry
happens to all of us
odd heath
good to know
limber skiff
oh really?
limber skiff
I could swear it was stock
austere talon
cause it confuses people
limber skiff
yeah it doesnt have a proper indication
limber skiff
launches a headless chrome instance, injects vencord and loads the discord website
then force loads everything and checks what wasn't applied after
astral bone
Very cool
Is it also opensource
I wanna peep at it's code
Like
How does it launch it
And force run everything
limber skiff
this launches chrome, opens discord and injects vencord
and also listens for console messages to capture failed patches logs, or the signal to end
and this is what loads everything and checks for bad patches or finds
beware the code is kinda messy
limber skiff
https://github.com/Vendicated/Vencord/blob/main/src/debug/runReporter.ts
Vencord has basically a different type of build that has every plugin enabled and runs this file at startup, to load everything
astral bone
So it js runs everything on the login screen?
limber skiff
yeah
it current does a login with a token
but you dont actually need to be logged in
astral bone
And how would i run it locally
If i wanted to
Bcs i assume it checks for patches even in dev shell
So is it possible that i find errors in dev shell with it?
limber skiff
And how would i run it locally
you have to set an environment variable for a chromium binary
then
pnpm buildReporter
pnpm esbuild scripts/generateReport.ts > dist
node dist/generateReport.js
i love zustand
I'm ambivalent about zustand, being that I don't know what it is
astral bone
then
```
pnpm buildReporter
pnpm esbuild scripts/generateReport.ts > dist
node ...
And the report will be posted here?
limber skiff
it will output in your terminal only
astral bone
Alright great, new side quest made
glass jasper
why do i have to spam Ctrl Shift I couple times before the dev console actually pops up
fossil inlet
why do i have to spam `Ctrl Shift I` couple times before the dev console actuall...
windows?
fossil inlet
ive heard the amd driver binds that as a hotkey
fossil inlet
https://tenor.com/view/nvidia-nvidia-gif-nvidia-accepted-gif-19751391
novideo
jolly egret
nooo
crude raptor
jolly egret
oh it hit stable
fossil inlet
oh it hit stable
no, discord reverted
jolly egret
oh
rugged spire
@scenic brook thank you for making this PR
also can you explain where the open link incognito comes from in the example I need that so bad https://github.com/user-attachments/assets/c943d74a-04a0-4d24-9d04-eca2970b8483
charred monolithBOT
charred monolithBOT
scenic brook
also can you explain where the open link incognito comes from in the example I n...
That's another one I made but I'm not sure what I wanna do with it because supporting different browsers and different install paths and everything sounds awful, plus I think I need to make it more secure since it's running a shell cmd (I hadn't bothered doing any of this since it's only me using it and I only use chrome lol)
I'll upload it as it currently is later 
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
fossil inlet
@limber skiff could you run reporter
fossil inlet
not my backup patch
was that the i18n crash?
limber skiff
they added this huge key
fossil inlet
it's a backup in case this patch fails
so if that errors it falls back to that one
limber skiff
yep
astral bone
🔥
limber skiff
@grizzled halo any new broken things that people mentioned or everything seems fine now?
grizzled halo
Everything seems fine
limber skiff
alright
limber skiff
I suppose I can push a tag without pushing to main
limber skiff
I suppose I can push a tag without pushing to main
@austere talon technically wouldn't cause any issues right?
austere talon
don't do that
jolly egret
Actually, do y'all wanna investigate the weird behaviour with imagezoom?
multiple users now have reported that its not saving the zoom level properly
i can kinda reproduce it?
it sometimes sticks, othertimes not
cunning canyon
is it about zoom by scrolling wheel
limber skiff
don't do that
what's the reason
spark pivot
lmao
brazen bone
Just adblock it then
charred monolithBOT
shut vineBOT
@fossil inlet, <t:1730995961:R>: review
glass jasper
Did Nuckyz and Elias not add the icon for a NSFW Vc into userVoiceShow?
limber skiff
nop
fossil inlet
Did Nuckyz and Elias not add the icon for a `NSFW` Vc into userVoiceShow?
wait, are nsfw vcs a thing
glass jasper
wait, are nsfw vcs a thing
rugged spire
just found that discord is using https://github.com/sebbo2002/ical-generator
fossil inlet
is that for server events
rugged spire
Yes
This
Fun fact
That button doesn't work on Vesktop because it tries to open a blob URI in a new tab
Worth making an issue?
fossil inlet
That button doesn't work on Vesktop because it tries to open a blob URI in a new...
how is it handled on normal desktop
rugged spire
f.isPlatformEmbedded ? s.Z.fileManager.saveWithDialog(n.toString(), "discord-event.ics") : window.open(n.toURL(), "_blank")
where n is the event object
s.Z is likely DiscordNative
fossil inlet
yea
thats what i figured
if i had the time/cared about this
id impliment that native func on vesktop
rugged spire
This is in webpack module 70877
fossil inlet
then just patch it
marsh spruce
then just patch it
if i Patched in a react button and have a callback for it what you suggest for a modal and managing code for a list of information?
rugged spire
what are you trying to do
marsh spruce
I had a suggest about the group dms thing before,
me and someone else managed to figure out how to patch the button I was talking about before in
however we are not sure how to render the group dms in the response to the react button
rugged spire
are you talking about the thing in your bio you want discord to make but you know they wont
marsh spruce
https://github.com/nebulamoe/Vencord/tree/main/src/plugins/groupDMs
I assume the components file will list What I want
I assume the response needs to come from the button callback but we are not sure how that would work
rugged spire
There is a lot of stuff that will break and generally isn't clean in the button itself
marsh spruce
so where should the callback go?
the button callback should call a function right?
rugged spire
You should be using Discord's own react components
marsh spruce
React components like what, their discord react components?
we patched in a button similar to the friends button
rugged spire
can you show me an example of where you are talking about
rugged spire
You should be using Discord's own react components
https://github.com/nebulamoe/Vencord/blob/main/src/plugins/groupDMs/components/GroupDMsButton.tsx shows that you've tried to recreate everything from scratch
@marsh spruce Please just take a look at how MutualGroupDMs does things
marsh spruce
https://github.com/nebulamoe/Vencord/blob/main/src/plugins/groupDMs/components/G...
what do you mean I tried to recreate everything from scratch?
did my accquitance render it incorrectly?
was the react object supposed to be rendered by something else?
rugged spire
what do you mean I tried to recreate everything from scratch?
1: don't do https://github.com/nebulamoe/Vencord/blob/main/src/plugins/groupDMs/components/GroupDMsButton.tsx#L4-L17 instead do findByProps with a unique set of those keys
2: There are so many react components that already exist and are better than writing the raw HTML elements every time. Doing that is much easier to read
3: Additionally, hardcoding the icon is a bad idea. You should try using #1293357944498556969 and importing Icons from @webpack/common and using those components
4: MutualGroupDMs code already likely has what you are after and can be easily tweaked for your needs
grave mangoBOT
1: don't do https://github.com/nebulamoe/Vencord/blob/main/src/plugins/groupDMs/...
GroupDMsButton.tsx: Lines 4-17
const classes = {
channel: "channel_c91bad",
container: "container_d91ad9",
interactive: "interactive_f5eb4b",
linkButton: "linkButton_c91bad",
link: "link_c91bad",
avatarWithText: "avatarWithText_c91bad",
layout: "layout_ec8679",
avatar: "avatar_ec8679",
linkButtonIcon: "icon_fc4f04",
content: "content_ec8679",
nameAndDecorators: "nameAndDecorators_ec8679",
name: "name_ec8679"
};
so the icon viewer has the group dms sybmol?
We're using the memberlist here
marsh spruce
**GroupDMsButton.tsx:** Lines 4-17
```tsx
const classes = {
channel: "channe...
so could you link me to the documenation alternative of this?
or an example?
rugged spire
Go to Vencord source code and search for findByPropsLazy( there are tons of examples of that
marsh spruce
Go to Vencord source code and search for `findByPropsLazy(` there are tons of ex...
findByPropsLazy for the button making?
rugged spire
That is found for you
Please just go read through some other plugins
It will help a lot
marsh spruce
I barely know javascript so what plugins?
rugged spire
just go look at https://github.com/Vendicated/Vencord/blob/main/src/plugins/mutualGroupDMs/index.tsx and if you have an IDE such as vscode, you can hover over the functions to see what they do, most of the common webpack finding things explain how they work that way
I don't think I can help further if you're not able to take a look and understand how similar existing plugins work
versed fern
looking at existing plugins was by far the most helpful thing for me when i made my plugin.
marsh spruce
The documentation is effectively the comments on commonly used functions
so do we grab the icon from webpack common or do we convert the icon from svg to an asset?
rugged spire
you can grab the icon using webpack
marsh spruce
I see the div path uses icon_fc4f04
rugged spire
that suffix should not be relied upon
marsh spruce
well it is called the
"Hide Member List"
"Show Member List"
button
rugged spire
that suffix **should not be relied upon**
thats why you use findByPropsLazy which looks for modules that export an object that contain all the properties passed as arguments
you need to find a set of keys in the object (same as the prefix of the class name) that are unique and not shared by any other classes object
do note you can leave it and it will work fine, it'll just break eventually as those suffixes change
marsh spruce
This is what the html renders:
rugged spire
here is an example taken from permissionviewer of finding one of these classes; the arguments map to keys of the object
you may notice that I use findByProps directly here, findByPropsLazy is used in the code as it won't look for the object until the properties are used in your code, without that your plugin will try to look for it immediately on start, fail to find it, and crash
marsh spruce
I see, so lazy works when the code actually needs it and findbyprops runs on client startup?
rugged spire
findByProps does the find immediately
which is good for when you are manually checking
marsh spruce
so lazy is the way to go then?
rugged spire
Yes
You should never statically declare a find of any type (props, code in a function, etc) without it being lazy loaded
Most of this is more relevant to generally developing a plugin rather than this use-case specifically
marsh spruce
aria-label="Hide Member List"
aria-label="Show Member List"
marsh spruce
here is an example taken from permissionviewer of finding one of these classes; ...
well the arial label appears to be the unique object
<div class="iconWrapper_fc4f04 clickable_fc4f04 selected_fc4f04" role="button" aria-label="Hide Member List" tabindex="0"><svg x="0" y="0" class="icon_fc4f04" aria-hidden="true" role="img" xmlns="http://www.w3.org/2000/svg" width="24" height="24" fill="none" viewBox="0 0 24 24"><path fill="currentColor" d="M14.5 8a3 3 0 1 0-2.7-4.3c-.2.4.06.86.44 1.12a5 5 0 0 1 2.14 3.08c.01.06.06.1.12.1ZM18.44 17.27c.15.43.54.73 1 .73h1.06c.83 0 1.5-.67 1.5-1.5a7.5 7.5 0 0 0-6.5-7.43c-.55-.08-.99.38-1.1.92-.06.3-.15.6-.26.87-.23.58-.05 1.3.47 1.63a9.53 9.53 0 0 1 3.83 4.78ZM12.5 9a3 3 0 1 1-6 0 3 3 0 0 1 6 0ZM2 20.5a7.5 7.5 0 0 1 15 0c0 .83-.67 1.5-1.5 1.5a.2.2 0 0 1-.2-.16c-.2-.96-.56-1.87-.88-2.54-.1-.23-.42-.15-.42.1v2.1a.5.5 0 0 1-.5.5h-8a.5.5 0 0 1-.5-.5v-2.1c0-.25-.31-.33-.42-.1-.32.67-.67 1.58-.88 2.54a.2.2 0 0 1-.2.16A1.5 1.5 0 0 1 2 20.5Z" class=""></path></svg></div>
idk what I am looking for here
charred monolithBOT
astral bone
Ppl love vendroid
shut vineBOT
@fossil inlet, <t:1730653179:R>: update all my prs
charred monolithBOT
rugged spire
rugged spire
userplugger time
this seems fine to me other than that Vencord.Settings.plugins.LetterEmojiShortcut should be replaced with settings.store throughout the whole plugin file
charred monolithBOT
desert cosmos
this is much cleaner than textreplace anyway
just use +
charred monolithBOT
jolly egret
and then force push them outside of history so people don't have to pull an extra 100kb every time they clone the repo
fossil inlet
~~and then force push them outside of history so people don't have to pull an ex...
shouldnt matter bcs prs get squashed
jolly egret
oh right forgor we squash merge
fossil inlet
@rugged spire i will squash you
clever sierraBOT
<@259558259491340288> i will squash you
@fossil inlet's Message: @rugged spire i will squash you
3.84% Identity attack
7.63% Compassion (beta)
7.84% Sexually explicit
15.6% Inflammatory
21.9% Severe toxicity
24.15% Profanity
36.81% Affinity (beta)
54.82% Toxicity
61.64% Threat ```
Powered by <https://www.perspectiveapi.com/>it worked
rugged spire
were you baiting me into running that
fossil inlet
no
i mean it was accurate
there should be something like vencord bisect to find out which plugin is causing a bug
@rugged spire rate idea
charred monolithBOT
still maple
there should be something like `vencord bisect` to find out which plugin is caus...
Telling people about binary searching is smth we do inside of the MC community to make people not try to remove 300 mods one by one
I have this tag for it
A binary search can be used to quickly find a specific mod causing trouble, which can be especially useful when logs don't give a conclusive answer to your issue.
Start by removing or disabling half of your mods, then test if the problem still occurs. If it does, remove half of the remaining mods and test again. If it doesn't, add back half of the mods you just removed.
Keep in mind you don't have to stick strictly to halves each time, and may have to enable some library mods like Fabric API out of order.
By repeating this on an increasingly smaller set of mods, you'll find the problematic mod within a few iterations.
Making a command to do it automatically like what git bisect do would be 300IQ+ move proving you are 100 parallel universe ahead of us
fossil inlet
fossil inlet
this happens with any group icon
I could only get it to work with stock group icons
Setting a custom one didn't work
scenic brook
Including the music in your screen recording is the fun part
rugged spire
can you repro with this
idk if I didnt merge in buggy code yet or it just doesnt occur for me
guhhhh
charred monolithBOT
charred monolithBOT
limber skiff
<@235834946571337729> can you repro
only seems to happen with stock group icons
lol funny
charred monolithBOT
limber skiff
I'll see later
charred monolithBOT
jolly egret
#1304101843399348305 message apparently this change is live again if you could remove this message
scenic brook
Wouldn't that be super unreliable
jagged cloak
https://discord.com/channels/1015060230222131221/1304101843399348305/13043846013...
avg discord
canary n ptb
limber skiff
bitches
frail skyBOT
frail skyBOT
limber skiff
nvm...
austere talon
why does it even crash
we should crash prove vencord
make all webpack finds fail and fix any
limber skiff
jolly egret
fun!
fossil inlet
I swear they must have forked zustand
Forked v3 or v4
limber skiff
v4
long stream
I swear they must have forked zustand
why listen to the warnings when you can simply remove the warnings 
limber skiff
the warnings are kinda stupid actually
limber skiff
right
austere talon
like we patch eslint to make it recognise \i
limber skiff
yeah
austere talon
make all webpack finds fail and fix any
im gonna do this rn
nvm
later
should we make that a build type?
force enables every plugin & makes every webpack find fail
to detect potential crashes
limber skiff
okay I fixed crashing
limber skiff
what's the worst that can happen by try catching a hook
lets just hope it always errors when it does LOL
austere talon
is it like a hook it calls inside patch?
austere talon
force enables every plugin & makes every webpack find fail
i still wanna do this
im sure there are more things that could cause crashes
maybe we can even automate that test somehow
like detect if there are any unusual errors
limber skiff
yeah
there sure is
I think we should have branch specific builds too
anyways I'm pushing this to main
austere talon
I think we should have branch specific builds too
thats kinda tough to do
we would have to base it on build id
but we cant get that that early can we?
limber skiff
nop
austere talon
GLOBAL_ENV.SENTRY_TAGS.buildId
long stream
build hash you can get from response headers
build id you can get from the chunkloader
austere talon
build id you can get from the chunkloader
too late lol
long stream
o
limber skiff
uhh
I guess the bump commit is gonna stay there
but lets push the tag another day
austere talon
oh i thought u alr did
limber skiff
nop
I was kinda expecting somethign like this to happen
or another plugin to have an issue which we didnt see
limber skiff
ughhh
limber skiff
alright finally
grizzled halo
can someone lock support I cant be bothered dealing with people who cant read
jolly egret
yes
its on stable
lock #🏥-vencord-support-🏥 until you push something to fix please
limber skiff
oop
limber skiff
@granite wharf tell people to update
jolly egret
All fixed?
limber skiff
yeah
granite wharf
frail skyBOT
jolly egret
#1257025907625951423 is updated but the joins are still high
maybe lets... wait an hour
frail skyBOT
limber skiff
but either way most people wouldnt have updated in time
as soon as update is pushed the join activity goes down lmao
I just remembered we have a popup to update to Vencord when it crashes
I hope that still works
grizzled halo
it did, i got it
limber skiff
that has to be the reason a lot of people dont even complain
since a lot wouldnt know they had to use the installer or something to fix it
granite wharf
just keep it broken so we gain 5k members like that one time
grizzled halo
Break things to inflate the member count
limber skiff
just keep it broken so we gain 5k members like that one time
that's so true
glass jasper
just keep it broken so we gain 5k members like that one time
get ntts to talk about vencord too… since that makes the member count go up
sterile oak
ITS SO OVER
what if we shown a message in top like this to alert vencord users
scenic brook
If they're joining because their vencord is crashing they're not gonna see it
rugged spire
ITS SO OVER
LMAO
rugged spire
its on stable
wtf did they do while I was sleeping
glass jasper
wtf did they do while I was sleeping
my bad I’ll tell them to wait next time 
rugged spire
vscode loves shoving so much useless fucking info in my face
fossil inlet
this is why I dont bother updating
im pinned to 1.89.1 because they decided to break source maps when debugging js in later versions
rugged spire
fossil inlet
needed to find out what plugin was causing an issue so i made this
normally, you would reload after pressing each button but i didnt want the video to be five years long
fossil inlet
stock discord bug my beloved
fossil inlet
the stock discord bug being you cant filter by tags in forum channels you dont have the permission to set
fossil inlet
@limber skiff was trying to fix viewicons opening when it shouldnt with gdm icons
and ran into weird issue
this patch
{
find: /\.recipients\.length>=2(?!<isMultiUserDM.{0,50})/,
replacement: {
match: /null==\i\.icon\?.+?src:(\(0,\i\.\i\).+?\))(?=[,}])/,
replace: (m, iconUrl) => `${m},onClick:()=>$self.openAvatar(${iconUrl})`
}
},
applies to module 515753
but when i add this patch
which only matches module
266076
{
find: "[\"aria-hidden\"],\"aria-label\":",
replacement: {
match: /(src:(.*?))(?=})/,
replace: "$1,onClick:()=>$self.openAvatar($2)"
}
},
the first patch matches module 266076 and fails with a syntax error
nevermind
i found it out