👾-core-development

[jagged cloak]

anyway just added it and blocked it too

ffs lol

[limber skiff]

fair enough

[fossil inlet]

WHAT

WHERE ARE VENCORD SETTINGS

[limber skiff]

don't bother fixing it for now

[fossil inlet]

why?

[limber skiff]

we might as well just change everything with the hashed variant

[fossil inlet]

huh

[limber skiff]

read what happened

scroll up

[fossil inlet]

wait

can we no longer find by intl strings

or where there be some util to map the contents of intl strings to their hashes

[limber skiff]

there is a way to calculate the hash from the old key

and yes we can

but

[fossil inlet]

oh, neat

[limber skiff]

as I said to vee too

for future keys, we won't know their original

the reason for the hashing is to obsfucate

which means, might as well just change everything to the hashed variant

it's consistent and doesn't change between builds

[fossil inlet]

if its a hash, it shouldnt it be just as stable as the normal one

meaning it will just be less readable

[limber skiff]

it is

[fossil inlet]

oh

[limber skiff]

it's based only in the key name

[fossil inlet]

this is just a pain in the ass more than a headache

[limber skiff]

so just like before if they change it the find breaks

it's just gonna be a magic string

[fossil inlet]

rip to #🔧-discord-changes i guess

[limber skiff]

our finds already have so many

[brazen bone]

Do we know that for certain?

[limber skiff]

yes

but yeah we just need to calculate the hash for our old finds and update our patches

[fossil inlet]

is this what they're using?

https://github.com/discord/discord-intl

[limber skiff]

yeah

[limber skiff]

and change a bit since it's no longer .Messages.SOMETHING

now it's

[fossil inlet]

i might make something to convert your clipboard for you in vscode

[limber skiff]

children: s.intl.format(s.t.l5FFq6, {
    name: c
})

[fossil inlet]

so its easy to hash

[limber skiff]

vs

children: N.Z.Messages.REMOVE_FRIEND_CONFIRMATION.format({
    name: I.ZP.getName(t)
})

[fossil inlet]

?remind one month hover for intl strings in companion

[shut vine]

Alright @fossil inlet, in 1 month and 1 hour: hover for intl strings in companion

[brazen bone]

Make a \I{unhashed_string} fake escape, if it's deterministic

[fossil inlet]

we dont know the new unhashed strings

[limber skiff]

as I'm saying I think it's not needed to do the conversation

[fossil inlet]

#👾-core-development message

[limber skiff]

for our current keys we could

but we won't be able to know future keys

[fossil inlet]

tbh might be worth for current keys

[limber skiff]

I dont think so

we would have to hash in patches

i18n usage

webpack finds

many places

[fossil inlet]

isnt that what canonicalize<...> is for

eaiser than updating with the hashed variant

[limber skiff]

gonna need to update the code regardless

but I will consider it

[fossil inlet]

alr

[fossil inlet]

also it would preserve readability for a bit longer

[brazen bone]

Could put comments for what the keys used to be

[limber skiff]

if someone else wants to work on it for now

[brazen bone]

Or just git blane

[limber skiff]

here´s the hasher

/**
 * Returns a consistent, short hash of the given key by first processing it through a hash digest,
 * then encoding the first few bytes to base64.
 *
 * This function is specifically written to mirror the native backend hashing function used by
 * `@discord/intl-loader-core`, to be able to hash names at runtime.
 */
export function runtimeHashMessageKey(key: string): string {
  const hash = h64(key, 0);
  const bytes = numberToBytes(hash);
  return [
    BASE64_TABLE[bytes[0] >> 2],
    BASE64_TABLE[((bytes[0] & 0x03) << 4) | (bytes[1] >> 4)],
    BASE64_TABLE[((bytes[1] & 0x0f) << 2) | (bytes[2] >> 6)],
    BASE64_TABLE[bytes[2] & 0x3f],
    BASE64_TABLE[bytes[3] >> 2],
    BASE64_TABLE[((bytes[3] & 0x03) << 4) | (bytes[3] >> 4)],
  ].join('');
}

I'm busy with other stuff

[fossil inlet]

ill throw something together

[fossil inlet]

whats the function h64

[limber skiff]

find it here

it's part of that

[fossil inlet]

oh this is from their code

[limber skiff]

they were kindly enough to make it open worse so everything is easier

[fossil inlet]

open worse my beloved ❤️

everything should be closed source

[austere talon]

guhhh even .Messages is obfuscated

so bad

[limber skiff]

cursed

[charred monolith]

MattTheTekie

[Vencord/Vendroid] New star added

[jolly egret]

so turns out it isn't as bad as we thought?

but its not great either

[austere talon]

😭

the last one lmao

why is it generating invalid identifiers

[fossil inlet]

[charred monolith]

driyqnn

[Vencord/Vendroid] New star added

[fossil inlet]

@limber skiff guhhhhhhhh is this related?

[limber skiff]

idk whats the error

[fossil inlet]

@brazen bone does that download all lazy chunks?

[brazen bone]

Yes

Including the one that makes everything pink, annoyingly

Doesn't download css though; I've thought about including that but haven't had the energy to do that yet

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[fossil inlet]

am i going fucking insane

[fringe basalt]

not on my watch

i've already fixed the strings differ, i will just have to go through node package hell tomorrow cuz discord decided to use a library with type: "module" which makes it impossible to import from ts without making your whole project a module as well

[fossil inlet]

i only have bad experiences from dealing with node modules not working

[fringe basalt]

well it could be worse, it could be python

[fossil inlet]

python has the worst package manager ive every had the displeasure of working with

[fossil inlet]

@limber skiff settings fixed

im not sure if how im fixing things is the best way

but guh

also loadLazyChunks is broken and idfk how to fix that

nevermind

it fixed itself after i fixed the settings patch

who knows

wait
no

its still broken

it just only fails when vencord is built with reporter

[fossil inlet]

i eep now

pray this doesnt hit stable

[fossil inlet]

@rugged spire you will help me fix i18n

[limber skiff]

okay maybe I will be able to work on it today later

i'll see

[scenic brook]

Thankful not to be a vencord maintainer in times like this

[limber skiff]

wouldn't be an issue if I wasn't busy

since when this happens you need time

[scenic brook]

Show of appreciation

I'd help if I weren't too dumb and new

[torpid vessel]

u should dm vee if u have donated 5$ or more or vgh in #🤖-bot-commands to get ur donor role

[limber skiff]

this is so bad

[limber skiff]

okay this is kinda neat

did I cook?

[austere talon]

wtf is that lmao

oh

it's cool but like u said before it won't work for new keys xd

[limber skiff]

yes

but I guess it doesnt hurt having for now

[austere talon]

mmhhh

I think we shouldn't rely on i18n keys much anymore

try to find better way

only rely on it if absolutely necessary

[limber skiff]

I mean

they are still consistent

why not?

[austere talon]

otherwise imagine if they ever change their hash function

everything breaks again

[limber skiff]

hmm

[austere talon]

I wouldn't rely on it as much as we did before if possible

[limber skiff]

you are right

[charred monolith]

Hl2Feitan

[Vencord/Installer] New star added

[fossil inlet]

@limber skiff what plugins have you done so far

[limber skiff]

untested tho

and I havent touched i18n usage

[charred monolith]

Nuckyz

[Vendicated/Vencord] New branch created: i18-fix

Nuckyz

[Vencord:i18-fix] 1 new commit

a3952b3 wip - Nuckyz

[limber skiff]

forgot an n

[fossil inlet]

That’s what I started with last night

[limber skiff]

but whatever

[fossil inlet]

I’ll start on that

[charred monolith]

Nuckyz

[Vendicated/Vencord] New branch created: i18n-fix

Nuckyz

[Vendicated/Vencord] branch deleted: i18-fix

[fossil inlet]

Wait did you ever manage to recreate the load lazy chunks not working on reporter

[limber skiff]

I havent tested any of it

[fossil inlet]

@limber skiff how cursed is this

export const { i18n } = mapMangledModuleLazy(['"en-GB":()=>', "getBinds"], {
    i18n: m => true
});```

[limber skiff]

just write a proper filter for it

instead of doing true

[fossil inlet]

i tried a find by code but it woudnt work

[limber skiff]

I mean like

[fossil inlet]

and wreq(number) gives it as an es module

[limber skiff]

use mapMangled

but put an actual filter in the i18n too

[fossil inlet]

heres the id

613338

[fossil inlet]

oh, wait im stupid

this better?

export const { i18n } = mapMangledModuleLazy(['"en-GB":()=>', "getBinds"], {
    // can be any i18n key
    i18n: m => m["0+11F"]
});

[limber skiff]

do this actually

[charred monolith]

Scyye

[Vendicated/Vencord] New comment on pull request #2710: feat(plugin): StatusWhilePlaying

why?

[fossil inlet]

@limber skiff i happen to be a bit stupid

there was another module that is 10x better

[limber skiff]

how lol

[limber skiff]

@fossil inlet macros in js

jokes that gonna be horrible to work with inside regex lmao

[fossil inlet]

[limber skiff]

lmao

[fossil inlet]

im doing a horror untold to the formatting side of i18n

[limber skiff]

🔥

[fossil inlet]

[limber skiff]

what's that

[unkempt oak]

[limber skiff]

I'm not sure which syntax to use

#intl<KEY> is ugly

[fossil inlet]

making something to work with the old formatting syntax

because i dont want to change everything to the new sytnax

[limber skiff]

using paranthesis makes it shit to work inside regex

same thing with $

[limber skiff]

nah

just do

but have a helper function which hashes and uses the correct functions inside

so it's easier

no need to keep this much backwards compability

ideas

#intl<KEY>
#[intl::KEY] yes rust

[fossil inlet]

intl::key is better

imo

[limber skiff]

just intl::KEY?

[fossil inlet]

no, the second

one

[limber skiff]

chat gpt with horrible ideas

[fossil inlet]

#[intl::key]

[fossil inlet]

i was doing to to change less things 😭

[limber skiff]

no point honestly

and there isn't much usage of i18n inside Vencord I think

sorryy if you put a lot of work into it already

[fossil inlet]

nah it was just this horror code

export const formati18n = {
    Messages: new Proxy<Record<string, ReturnType<typeof formatUtils>>>({}, {
        get(target, key) {
            if (!(typeof key === "string")) throw new Error("key is not string");
            formatUtils(key);
        }
    })
};

emphasis on horror code

[limber skiff]

HAHAHA

@austere talon this is perfect

new syntax is fire

even better

[fossil inlet]

xml

[limber skiff]

ugh

it turns into a set in regex

I'll just do #intl::KEY

looks pretty nice like that

[limber skiff]

ugh actually this won't work

can't find where it ends like that

[unkempt oak]

maybe intl:ABC

or since <> is used in ecmascript regex, ::ABC:: or something like that

[austere talon]

NAAAHHHHH

[fossil inlet]

did old intl always format as react

IT WORKS

finally

[fringe basalt]

HORROR

[fossil inlet]

i am aware that this is horror code, but it works

export const i18n: t.i18n & { Messages: ReturnType<typeof formatUtils>; } = proxyLazy(() => {
    return {
        ...findLazy(m => m?.intl?.format),
        Messages: new Proxy<Record<string, ReturnType<typeof formatUtils>>>({}, {
            get(target, key) {
                if (!(typeof key === "string")) throw new Error("key is not string");
                return formatUtils(key);
            }
        })
    };
});
// FIXME: fix types
export const formatUtils = a => {
    console.log("running format utils");
    const k = i18n.t[runtimeHashMessageKey(a)];
    if (typeof (k().ast) === "string") return k().ast;
    return Object.assign(k, {
        format: (a: any) => i18n.intl.format(k, a),
        formatToMarkdownString: (a: any) => i18n.intl.formatToMarkdownString(k, a),
        formatToParts: (a: any) => i18n.intl.formatToParts(k, a),
        formatToPlainString: (a: any) => i18n.intl.formatToPlainString(k, a),
    });
};

[limber skiff]

#{intl::KEY}

will be it

[austere talon]

guh

just don't do this lmao

it's gonna be useless for new keys anyway

for finds you can use string interpolation

or just add a comment

[limber skiff]

it's fine

[austere talon]

you're overengineering this so hard xD

I get it it's a cool idea but it's not gonna be effective for new stuff

[limber skiff]

dont worry I'm enjoying it lol

[limber skiff]

just for now :)

slowly we can migrate to finds which dont use that

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

40b948b switch syntax - Nuckyz

[limber skiff]

okay back to actually fixing now

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

f213045 Fix more patches - Nuckyz

[rugged spire]

FUCK YOU DISCORD

[frail sky]

Bad Patches

MoreUserTags (had no effect):
ID: 385499
Match: ```
/(switch(((?:\i))){.+?)case ((?:\i)(?:.(?:\i))?).BOT:default:((?:\i))=.{0,40}((?:\i).(?:\i).Messages).APP_TAG/

**__TypingTweaks (had no effect):__**
ID: `738619`
Match: ```
/(?<=((?:\i))\.length\?(?:\i).(?:\i)\.Messages.THREE_USERS_TYPING\.format\({(?:\i):((?:\i)),(?:(?:\i):)?((?:\i)),(?:\i):(?:\i)}\):)(?:\i)\.(?:\i)\.Messages\.SEVERAL_USERS_TYPING/

IgnoreActivities (had no effect):
ID: 293389
Match: ```
/(?:["1+O+Tk"]).+?}(),(?<={overlay:(?:\i),.+?=((?:\i)),.+?)(?=!((?:\i)))/

**__FakeProfileThemes (had no effect):__**
ID: `451392`
Match: ```
/RESET_PROFILE_THEME}\)(?<=color:((?:\i)),.{0,500}?color:((?:\i)),.{0,500}?)/

SupportHelper (had no effect):
ID: 600084
Match: ```
/BEGINNING_DM.format({.+?}),(?=.{0,300}((?:\i)).isMultiUserDM)/

**__ImplicitRelationships (had no effect):__**
ID: `270759`
Match: ```
/(\(0,(?:\i)\.jsx\)\((?:\i)\.TabBar\.Item,\{id:(?:\i)\.(?:\i))\.BLOCKED,className:([^\s]+?)\.item,children:(?:\i)\.(?:\i)\.Messages\.BLOCKED\}\)/

ServerListAPI (found no module):
ID: -
Match: ```
["7hB4kp),children

**__CrashHandler (found no module):__**
ID: `-`
Match: ```
#{intl:;ERRORS_UNEXPECTED_CRASH}

DisableCallIdle (found no module):
ID: -
Match: ```
.pps9zM

**__MoreUserTags (found no module):__**
ID: `-`
Match: ```
#{ìntl::USER_PROFILE_PRONOUNS}

PermissionsViewer (found no module):
ID: -
Match: ```
.VIEW_ALL_ROLES,

**__ReplyTimestamp (found no module):__**
ID: `-`
Match: ```
#[intl::REPLY_QUOTE_MESSAGE_BLOCKED}

ShowHiddenChannels (found no module):
ID: -
Match: ```
.Messages.CHANNEL_TOOLTIP_DIRECTORY

**__ValidReply (found no module):__**
ID: `-`
Match: ```
#{intl::REPLY_QUOTE_MESSAGE_NOT_LOADED

WebContextMenus (found no module):
ID: -
Match: ```
.Messages.SEARCH_WITH_GOOGLE

**__WebContextMenus (found no module):__**
ID: `-`
Match: ```
.Messages.COPY,hint:

Bad Webpack Finds

waitForComponent(t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...)

find(e=>e.Messages?.["en-US"]...)

findByCode(".ATTACHMENT_TOO_MANY_ERROR_TITLE,")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

extractAndLoadChunks(["USER_SETTINGS_PROFILE_COLOR_DEFAULT_BUTTON.format"], /createPromise:\(\)=>\i\.\i(\("?.+?"?\)).then\(\i\.bind\(\i,"?(.+?)"?\)\)/)

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".CONNECTIONS_ROLE_OFFICIAL_ICON_TOOLTIP")

findComponentByCode(".Messages.ROLE_REQUIRED_SINGLE_USER_MESSAGE")

findComponent(e=>{if(typeof e!="function")return!1;let t=Function.prototype.toString.call(e);return t.includes(".Messages.FORUM_TAG_A11Y_FILTER_BY_TAG")&&!t.incl...)

findComponent(e=>e.prototype?.render?.toString().includes(".MAX_AGE_NEVER")...)

mapMangledModule(".Messages.GROUP_DM_ALONE", {
	useChannelName: t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...
})

Bad Starts

None

Discord Errors

None

[rugged spire]

Ughhhhhhhhhhhhhhhhh

[limber skiff]

lol

did you just find about it?

[dusk blaze]

sorry i was hungry
ate all of the i18n keys

[rugged spire]

i have been asleep for way too long and only just got up

well

i woke up multiple times in the night and saw @fossil inlet's message but thats it

[limber skiff]

welcome welcome

[fossil inlet]

@rugged spire rate

[limber skiff]

hmm

I wonder

what failed here

I see nvm

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

aef8a1a even more - Nuckyz

[frail sky]

Bad Patches

ValidReply (had no effect):
ID: 267128
Match: ```
/(?:["1i+hMj"]))/

**__MoreUserTags (had no effect):__**
ID: `385499`
Match: ```
/(switch\(((?:\i))\){.+?)case ((?:\i)(?:\.(?:\i))?)\.BOT:default:((?:\i))=.{0,40}((?:\i)\.(?:\i)\.Messages)\.APP_TAG/

TypingTweaks (had no effect):
ID: 738619
Match: ```
/(?<=((?:\i)).length?(?:\i).(?:\i).Messages.THREE_USERS_TYPING.format({(?:\i):((?:\i)),(?:(?:\i):)?((?:\i)),(?:\i):(?:\i)}):)(?:\i).(?:\i).Messages.SEVERAL_USERS_TYPING/

**__IgnoreActivities (had no effect):__**
ID: `293389`
Match: ```
/(?:\["1+O+Tk"\]).+?}\(\),(?<={overlay:(?:\i),.+?=((?:\i)),.+?)(?=!((?:\i)))/

FakeProfileThemes (had no effect):
ID: 451392
Match: ```
/RESET_PROFILE_THEME})(?<=color:((?:\i)),.{0,500}?color:((?:\i)),.{0,500}?)/

**__SupportHelper (had no effect):__**
ID: `600084`
Match: ```
/BEGINNING_DM\.format\(\{.+?\}\),(?=.{0,300}((?:\i))\.isMultiUserDM)/

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,(?:\i).jsx)((?:\i).TabBar.Item,{id:(?:\i).(?:\i)).BLOCKED,className:([^\s]+?).item,children:(?:\i).(?:\i).Messages.BLOCKED})/

**__MoreUserTags (found no module):__**
ID: `-`
Match: ```
#{ìntl::USER_PROFILE_PRONOUNS}

Bad Webpack Finds

waitForComponent(t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...)

find(e=>e.Messages?.["en-US"]...)

findByCode(".ATTACHMENT_TOO_MANY_ERROR_TITLE,")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

extractAndLoadChunks(["USER_SETTINGS_PROFILE_COLOR_DEFAULT_BUTTON.format"], /createPromise:\(\)=>\i\.\i(\("?.+?"?\)).then\(\i\.bind\(\i,"?(.+?)"?\)\)/)

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".CONNECTIONS_ROLE_OFFICIAL_ICON_TOOLTIP")

findComponentByCode(".Messages.ROLE_REQUIRED_SINGLE_USER_MESSAGE")

findComponent(e=>{if(typeof e!="function")return!1;let t=Function.prototype.toString.call(e);return t.includes(".Messages.FORUM_TAG_A11Y_FILTER_BY_TAG")&&!t.incl...)

findComponent(e=>e.prototype?.render?.toString().includes(".MAX_AGE_NEVER")...)

mapMangledModule(".Messages.GROUP_DM_ALONE", {
	useChannelName: t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...
})

Bad Starts

None

Discord Errors

None

[limber skiff]

#{ìntl::USER_PROFILE_PRONOUNS}

omg the typos

[rugged spire]

LOL WTF ARE YOU DOING

[limber skiff]

calculating hashes at runtime and making finds/matches based on that

[rugged spire]

DID YOU WRITE A SYSTEM LOOK UP THE HASHES

awesome

[limber skiff]

yeah

[rugged spire]

this takes 5 hours of torture and shrinks it down to 1 hour of torture

im too fucking scared to restart my canary client

i already see breakage

You can't even open settings.

@limber skiff I maintain 20+ plugins I've developed myself and each one is maintained on its own branch

See why I want to

[prime dew]

Is this going to be unleashed upon the stable branch in the immediate future?

[rugged spire]

Probably

[prime dew]

Gosh

[rugged spire]

I daily drive canary btw

[fossil inlet]

Last night I spent a hour writing a script to hash the clipboard

[rugged spire]

and I've been called insane for it

[rugged spire]

1 hour wasted?

[fossil inlet]

I do just to fix things faster

[fossil inlet]

Nah

Very useful

While testing

[prime dew]

I mean, kudos to y'all that maintain the project and fix stuff every time discord fucks it up

[fossil inlet]

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

d099aff and more - Nuckyz

[rugged spire]

It's okay. I only have this many plugins to fix

[limber skiff]

if you are only using the messages for finds it's pretty straightforward

[rugged spire]

I know

[fossil inlet]

?remind one week update all my prs

[shut vine]

Alright @fossil inlet, in 1 week: update all my prs

[rugged spire]

"i need a break"

[frail sky]

Bad Patches

ValidReply (had no effect):
ID: 267128
Match: ```
/(?:["1i+hMj"])"])/

**__MoreUserTags (had no effect):__**
ID: `385499`
Match: ```
/(switch\(((?:\i))\){.+?)case ((?:\i)(?:\.(?:\i))?)\.BOT:default:((?:\i))=.{0,40}((?:\i)\.(?:\i)\.Messages)\.APP_TAG/

TypingTweaks (had no effect):
ID: 738619
Match: ```
/(?<=((?:\i)).length?(?:\i).(?:\i).Messages.THREE_USERS_TYPING.format({(?:\i):((?:\i)),(?:(?:\i):)?((?:\i)),(?:\i):(?:\i)}):)(?:\i).(?:\i).Messages.SEVERAL_USERS_TYPING/

**__IgnoreActivities (had no effect):__**
ID: `293389`
Match: ```
/(?:\["1+O+Tk"\]).+?}\(\),(?<={overlay:(?:\i),.+?=((?:\i)),.+?)(?=!((?:\i)))/

FakeProfileThemes (had no effect):
ID: 451392
Match: ```
/(?:["L+Gmoa"]))})(?<=color:((?:\i)),.{0,500}?color:((?:\i)),.{0,500}?)/

**__SupportHelper (had no effect):__**
ID: `600084`
Match: ```
/(?:\["Qvg+6+"\])"],{.+?}\),(?=.{0,300}((?:\i))\.isMultiUserDM)/

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,(?:\i).jsx)((?:\i).TabBar.Item,{id:(?:\i).(?:\i)).BLOCKED,className:([^\s]+?).item,children:(?:\i).(?:\i).Messages.BLOCKED})/

Bad Webpack Finds

waitForComponent(t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...)

find(e=>e.Messages?.["en-US"]...)

findByCode(".ATTACHMENT_TOO_MANY_ERROR_TITLE,")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

extractAndLoadChunks(["USER_SETTINGS_PROFILE_COLOR_DEFAULT_BUTTON.format"], /createPromise:\(\)=>\i\.\i(\("?.+?"?\)).then\(\i\.bind\(\i,"?(.+?)"?\)\)/)

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".CONNECTIONS_ROLE_OFFICIAL_ICON_TOOLTIP")

findComponentByCode(".Messages.ROLE_REQUIRED_SINGLE_USER_MESSAGE")

findComponent(e=>{if(typeof e!="function")return!1;let t=Function.prototype.toString.call(e);return t.includes(".Messages.FORUM_TAG_A11Y_FILTER_BY_TAG")&&!t.incl...)

findComponent(e=>e.prototype?.render?.toString().includes(".MAX_AGE_NEVER")...)

mapMangledModule(".Messages.GROUP_DM_ALONE", {
	useChannelName: t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...
})

Bad Starts

None

Discord Errors

None

[rugged spire]

i cant live without betterquickreact actually

[fossil inlet]

Tbh I have no more motivation to fix this update

[limber skiff]

bruh

did I make a typo

[rugged spire]

Real

[fossil inlet]

Got a lot of other work

[rugged spire]

See I'm the opposite

I don't really have much I need to do

[limber skiff]

ah

I did

[rugged spire]

@limber skiff are you fixing game activity toggle button plugin

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

e0098de lets work alright? - Nuckyz

[limber skiff]

alright did

[rugged spire]

love

[limber skiff]

first patches

then finds

and then usages of i18n inside vencord and inside patches

[fossil inlet]

I have work I need to do now, so I am going to go out and get tea.

[frail sky]

Bad Patches

ValidReply (had no effect):
ID: 267128
Match: ```
/(?:["1i+hMj)"])/

**__MoreUserTags (had no effect):__**
ID: `385499`
Match: ```
/(switch\(((?:\i))\){.+?)case ((?:\i)(?:\.(?:\i))?)\.BOT:default:((?:\i))=.{0,40}((?:\i)\.(?:\i)\.Messages)\.APP_TAG/

TypingTweaks (had no effect):
ID: 738619
Match: ```
/(?<=((?:\i)).length?(?:\i).(?:\i).Messages.THREE_USERS_TYPING.format({(?:\i):((?:\i)),(?:(?:\i):)?((?:\i)),(?:\i):(?:\i)}):)(?:\i).(?:\i).Messages.SEVERAL_USERS_TYPING/

**__IgnoreActivities (had no effect):__**
ID: `293389`
Match: ```
/(?:\["1+O+Tk).+?}\(\),(?<={overlay:(?:\i),.+?=((?:\i)),.+?)(?=!((?:\i)))/

FakeProfileThemes (had no effect):
ID: 451392
Match: ```
/(?:["L+Gmoa))})(?<=color:((?:\i)),.{0,500}?color:((?:\i)),.{0,500}?)/

**__Decor (had no effect):__**
ID: `532495`
Match: ```
/(?<=(?:\["7v0T9P)\)},"decoration"\),)/

ServerListAPI (had no effect):
ID: 416568
Match: ```
/(?<=(?:["7hB4kp)),children:)(?:\i).map((?:\i))/

**__SupportHelper (had no effect):__**
ID: `600084`
Match: ```
/(?:\["Qvg+6+)"],{.+?}\),(?=.{0,300}((?:\i))\.isMultiUserDM)/

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,(?:\i).jsx)((?:\i).TabBar.Item,{id:(?:\i).(?:\i)).BLOCKED,className:([^\s]+?).item,children:(?:\i).(?:\i).Messages.BLOCKED})/

Bad Webpack Finds

waitForComponent(t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...)

find(e=>e.Messages?.["en-US"]...)

findByCode(".ATTACHMENT_TOO_MANY_ERROR_TITLE,")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

extractAndLoadChunks(["USER_SETTINGS_PROFILE_COLOR_DEFAULT_BUTTON.format"], /createPromise:\(\)=>\i\.\i(\("?.+?"?\)).then\(\i\.bind\(\i,"?(.+?)"?\)\)/)

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".CONNECTIONS_ROLE_OFFICIAL_ICON_TOOLTIP")

findComponentByCode(".Messages.ROLE_REQUIRED_SINGLE_USER_MESSAGE")

findComponent(e=>{if(typeof e!="function")return!1;let t=Function.prototype.toString.call(e);return t.includes(".Messages.FORUM_TAG_A11Y_FILTER_BY_TAG")&&!t.incl...)

findComponent(e=>e.prototype?.render?.toString().includes(".MAX_AGE_NEVER")...)

mapMangledModule(".Messages.GROUP_DM_ALONE", {
	useChannelName: t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...
})

Bad Starts

None

Discord Errors

None

[rugged spire]

I like to believe it gave up listing what is broken

[jolly egret]

spam

[rugged spire]

ok

so

i need to base upon the existing branch

@limber skiff do you intend to force push the branch with all the fixes

[limber skiff]

no

[rugged spire]

[opaque silo]

20 dollars discord will revert

[rugged spire]

nuh uh

[limber skiff]

ughh

[rugged spire]

how it feels wanting to explode

[limber skiff]

I have to escape +

[rugged spire]

i will delete that showTimeoutDuration file

how do you vertical split in vscode?

oh i dont think i even edited that patch

[unkempt oak]

press f1 type "split horizontally" press enter

ok nvm

it's View: Split Editor Right

[rugged spire]

i worded it wrong and figured it out anyways

@limber skiff will this code still work?

[limber skiff]

nop

not rn

[rugged spire]

HOW DO I FIX

DO I NEED TO FIX

[limber skiff]

and I havent decided the approach for that

I dont know yet

wait

[rugged spire]

guh

praying to vencord gods

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

3cf79ec Fix most patches - Nuckyz

[limber skiff]

okay that's big progress

[rugged spire]

Most

[frail sky]

Bad Patches

MoreUserTags (had no effect):
ID: 385499
Match: ```
/(switch(((?:\i))){.+?)case ((?:\i)(?:.(?:\i))?).BOT:default:((?:\i))=.{0,40}((?:\i).(?:\i).Messages).APP_TAG/

**__TypingTweaks (had no effect):__**
ID: `738619`
Match: ```
/(?<=((?:\i))\.length\?(?:\i).(?:\i)\.Messages.THREE_USERS_TYPING\.format\({(?:\i):((?:\i)),(?:(?:\i):)?((?:\i)),(?:\i):(?:\i)}\):)(?:\i)\.(?:\i)\.Messages\.SEVERAL_USERS_TYPING/

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,(?:\i).jsx)((?:\i).TabBar.Item,{id:(?:\i).(?:\i)).BLOCKED,className:([^\s]+?).item,children:(?:\i).(?:\i).Messages.BLOCKED})/

Bad Webpack Finds

waitForComponent(t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...)

find(e=>e.Messages?.["en-US"]...)

findByCode(".ATTACHMENT_TOO_MANY_ERROR_TITLE,")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

extractAndLoadChunks(["USER_SETTINGS_PROFILE_COLOR_DEFAULT_BUTTON.format"], /createPromise:\(\)=>\i\.\i(\("?.+?"?\)).then\(\i\.bind\(\i,"?(.+?)"?\)\)/)

findComponentByCode(".Messages.USER_SETTINGS_PROFILE_COLOR_SELECT_COLOR", ".BACKGROUND_PRIMARY)")

findComponentByCode(".CONNECTIONS_ROLE_OFFICIAL_ICON_TOOLTIP")

findComponentByCode(".Messages.ROLE_REQUIRED_SINGLE_USER_MESSAGE")

findComponent(e=>{if(typeof e!="function")return!1;let t=Function.prototype.toString.call(e);return t.includes(".Messages.FORUM_TAG_A11Y_FILTER_BY_TAG")&&!t.incl...)

findComponent(e=>e.prototype?.render?.toString().includes(".MAX_AGE_NEVER")...)

mapMangledModule(".Messages.GROUP_DM_ALONE", {
	useChannelName: t=>typeof t!="function"?!1:wa(Function.prototype.toString.call(t),e)...
})

Bad Starts

None

Discord Errors

None

[rugged spire]

@limber skiff can you confirm you have not touched any finds yet

[limber skiff]

only three patches

will do those later

now finds

they should be pretty straightforward too

tf is this tho

found it

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

4c642bf Fix broken finds - Nuckyz

[limber skiff]

pretty easy

[rugged spire]

hello i love developing on a renamed version of an existing plugin

commit war

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

907bc25 Temp fix for settings - Nuckyz

[rugged spire]

That wasn't hard

basically just copy paste a few lines

[frail sky]

Bad Patches

MoreUserTags (had no effect):
ID: 385499
Match: ```
/(switch(((?:\i))){.+?)case ((?:\i)(?:.(?:\i))?).BOT:default:((?:\i))=.{0,40}((?:\i).(?:\i).Messages).APP_TAG/

**__TypingTweaks (had no effect):__**
ID: `738619`
Match: ```
/(?<=((?:\i))\.length\?(?:\i).(?:\i)\.Messages.THREE_USERS_TYPING\.format\({(?:\i):((?:\i)),(?:(?:\i):)?((?:\i)),(?:\i):(?:\i)}\):)(?:\i)\.(?:\i)\.Messages\.SEVERAL_USERS_TYPING/

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,(?:\i).jsx)((?:\i).TabBar.Item,{id:(?:\i).(?:\i)).BLOCKED,className:([^\s]+?).item,children:(?:\i).(?:\i).Messages.BLOCKED})/

Bad Webpack Finds

find(e=>e.Messages?.["en-US"]...)

Bad Starts

None

Discord Errors

None

[rugged spire]

WOAH

surely that isnt all thats left

right?

wtf happened here

[limber skiff]

only those 3 patches yes

and the usage of i18n

this

[limber skiff]

new dependency

[rugged spire]

guh

ok time to see if ShowTimeoutDetails works

I still cannot click into another channel.

[bleak blaze]

so all plugins that are merged into vencord you guys have to maintain yourself right?

unless a push is made

it’s not the developers that maintain those

that’s why alot of plugins get rejected (maybe)

[rugged spire]

from what i can see that is generally what happens

[rugged spire]

maybe? those plugins generally end up as userplugins though

[bleak blaze]

yeah they all end up as user plugins usually

[rugged spire]

i have to go through 20 of my own personal plugins today

and "fix" them

Oh

It's AutomodIndicator causing the crash

[glass jasper]

this is why i won’t use patch’s

[rugged spire]

nope

[glass jasper]

my three plugins are still find

[rugged spire]

your plugins likely touch i18n

that has no fix yet

I can finally enter settings

@limber skiff How are you thinking of solving i18n.Messages.MESSAGE

I propose the API should be compatible without changes if possible

i wonder how bd users are doing

[limber skiff]

nop

too much backwards compability in a project like this is kinda bad

[rugged spire]

true

how do formatted messages work

also

can we get a i18n message lookup page in settings?

[limber skiff]

or hashed

[rugged spire]

❤️

[limber skiff]

for formatted messages it will just be a second parameters which contain the values to be used

[rugged spire]

oh neat

have you committed this yet

can I just import the getIntlMessage function alone?

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

a1487b5 Fix settings properly - Nuckyz

[limber skiff]

there you go

lmk if you have issues

[rugged spire]

time to fix ShowTimeoutDetails and AutomodIndicator

how many times do you think I'll be running this today @limber skiff

[limber skiff]

I should be finishing soon I think

[rugged spire]

part of me thinks it'd be neat to have the API as a Proxy

[fossil inlet]

did you not see what i sent earlier 😭

[rugged spire]

No.

Please link it

[fossil inlet]

export const i18n: t.i18n & { Messages: ReturnType<typeof formatUtils>; } = proxyLazy(() => {
    return {
        ...findLazy(m => m?.intl?.format),
        Messages: new Proxy<Record<string, ReturnType<typeof formatUtils>>>({}, {
            get(target, key) {
                if (!(typeof key === "string")) throw new Error("key is not string");
                return formatUtils(key);
            }
        })
    };
});
// FIXME: fix types
export const formatUtils = a => {
    console.log("running format utils");
    const k = i18n.t[runtimeHashMessageKey(a)];
    if (typeof (k().ast) === "string") return k().ast;
    return Object.assign(k, {
        format: (a: any) => i18n.intl.format(k, a),
        formatToMarkdownString: (a: any) => i18n.intl.formatToMarkdownString(k, a),
        formatToParts: (a: any) => i18n.intl.formatToParts(k, a),
        formatToPlainString: (a: any) => i18n.intl.formatToPlainString(k, a),
    });
};

[rugged spire]

did you give a good reason why that is a horrible idea or something

[fossil inlet]

it works

[rugged spire]

Oh

The Compatibility Layer that @limber skiff doesn't want to support

[fossil inlet]

yop

i just made it because i thought it would be cool

and was bored

[rugged spire]

is that compatible with how it worked before

[fossil inlet]

yea

thats the whole point

[rugged spire]

ngl the older API was definitely easier to write

[fossil inlet]

yop

[rugged spire]

the function call is bad IMO

[fossil inlet]

where?

[charred monolith]

stick39

[Vendicated/Vencord] New comment on pull request #2978: New Plugin: Suppress Reply Mentions

would there by any way to add an option to invert the functionality? as in to add an option that makes reply messages that despite having reply ping off always ping?

[fossil inlet]

eh

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

80ae060 Fix i18n usage - Nuckyz

[limber skiff]

I'm not sure if this works lol

[rugged spire]

https://tryitands.ee/

[limber skiff]

someone type

[rugged spire]

,,

[limber skiff]

without silent typing

seems to work

good

[rugged spire]

can someone go clean up #🧊-off-topic-iceman-only

before my brain explodes

nvm

[frail sky]

Bad Patches

MoreUserTags (had no effect):
ID: 385499
Match: ```
/(switch(((?:\i))){.+?)case ((?:\i)(?:.(?:\i))?).BOT:default:((?:\i))=.{0,40}((?:\i).(?:\i).Messages).APP_TAG/

**__TypingTweaks (had no effect):__**
ID: `738619`
Match: ```
/(?<=((?:\i))\.length\?(?:\i).(?:\i)\.Messages.THREE_USERS_TYPING\.format\({(?:\i):((?:\i)),(?:(?:\i):)?((?:\i)),(?:\i):(?:\i)}\):)(?:\i)\.(?:\i)\.Messages\.SEVERAL_USERS_TYPING/

ImplicitRelationships (had no effect):
ID: 270759
Match: ```
/((0,(?:\i).jsx)((?:\i).TabBar.Item,{id:(?:\i).(?:\i)).BLOCKED,className:([^\s]+?).item,children:(?:\i).(?:\i).Messages.BLOCKED})/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[limber skiff]

now that's right

only those three patches left

[fossil inlet]

WHAT IS THAT PATCH

[limber skiff]

to change this

[fossil inlet]

@dapper tiger fix your plugin

[rugged spire]

something @dusk blaze would write

[fossil inlet]

i thought nin0 only wrote sandbox escapes

@dusk blaze make i18n unhahser

[rugged spire]

already exists

[fossil inlet]

where

[rugged spire]

https://github.com/Vendicated/Vencord/commit/a1487b50bebaa27cc4bfa125c0c81d0cb3a2f04d#diff-72085127736e61619b7a6db0851043ec423ce8dfba588f7b1418a1d7e1b75768R21

read

[fossil inlet]

thats doesnt get the intl key from the hashed intl key

thats what i ment

[rugged spire]

why do you need this?

i dont think that is actually implemented here

[fossil inlet]

yea

and

[rugged spire]

what i can see here is

hash to string
key to hash to string
key to hash

[fossil inlet]

hash to key

[limber skiff]

impossible

[fossil inlet]

brute force

[rugged spire]

lookup table

[fossil inlet]

not in vencord

but as something funny

[rugged spire]

I have a really horrible question?

How are we going to find new unhashed names

[fossil inlet]

thats the fun part

we dont

[rugged spire]

vencord hash cracking service

[fossil inlet]

yop

@rugged spire make https://github.com/Cyan4973/xxHash/tree/dev

[rugged spire]

they're only xxh32 right

[fossil inlet]

idk

check the js impl and compare

[rugged spire]

[fossil inlet]

iirc they're 64 bit

[rugged spire]

no

they are xxh64

FUCK

[fossil inlet]

but we know they're all caps, and delimited by _

[rugged spire]

yes

[fossil inlet]

@fringe basaltthoughts on cracking the i18n hashes

[rugged spire]

https://nelly.tools/builds/app/d9b80474cb7e4addb839851bb8cae0043adac9b0

[dusk blaze]

i am making it less sandbox escape

by preventing the discord sandbox from silently nuking your system

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

a514122 Fix rest of patches - Nuckyz

[limber skiff]

done

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[fossil inlet]

nuckyz so good

[fringe basalt]

probably possible to some degree with a dictionary attack, especially since xxhash is designed to be very fast

but idk about collisions

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

e038c10 remove trailing newline - Nuckyz

[fringe basalt]

if it's any similar to murmurhash then it will have a TON of collisions

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

17926c9 annoying error - Nuckyz

[limber skiff]

I am tired

[fossil inlet]

guhhhh didnt think of colisions

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request opened: #2993 Fix all plugins for new i18n lib

[dusk blaze]

amazing

[fossil inlet]

is it on stable yet?

[limber skiff]

nop

lol

I think I found one with noWarn

almost

[rugged spire]

you will explode

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

321ec84 it is hiding from me - Nuckyz

[rugged spire]

i will need to merge in the real changes soon

?remindme 6h merge dev into plugin branches

[shut vine]

Alright @rugged spire, in 6 hours: merge dev into plugin branches

[rugged spire]

nah

i will do now

[limber skiff]

okay so like

there's one major issue

[rugged spire]

yes

what is it

[limber skiff]

settings crash without the fixes

which means users will suffer to update

[rugged spire]

Oh

[fossil inlet]

not that bad tbh

people can just paste update into console

[rugged spire]

vee should make an announcement saying you might have to manually repatch vencord in a few days if it breaks

[prime dew]

Is there no way to force an update like you guys did a while back for that plugin issue?

[rugged spire]

This is called auto update

[prime dew]

I can't really remember which plugin it was in particular

[fossil inlet]

@grizzled halo how bad of an issue will it be if people cant open settings to update

[rugged spire]

#🏥-vencord-support-🏥 will be locked for a few days probs

[prime dew]

No, it was a popup telling you to update

[rugged spire]

When you went to #🏥-vencord-support-🏥 ?

or what

maybe I think a "if its broken now do update" thing was pushed idk'

I don't remember well

[prime dew]

I wish I could remember as well

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] New comment on pull request #2804: ShowTimeoutDetails (Timeout reasons + ShowTimeoutDuration)

Please ignore that this is based on #2993 for now

[limber skiff]

okay actually

it does not crash

but the patch is not applied

[rugged spire]

it only crashes if you patch settings itself with i18n

[limber skiff]

I'm pushing a fix to make it work

[rugged spire]

To main?

That is compatible with new AND old versions for now?

[fossil inlet]

why is my discord crashing randomly when idle

[rugged spire]

[prime dew]

[limber skiff]

yeah

[rugged spire]

wow thats not much for me to fix in terms of i18n messages being displayed

[charred monolith]

Nuckyz

[Vencord:dev2] 4 new commits

88e8fa7 NoPendingCount: Fix hiding offers count (#2975) - sadan4
d897dab ShowHiddenChannels: Fix viewing voice channels ... - sadan4
e7e298d ThemeAttributes: fix freezing when changing avatar - Vendicated
5216bcc Fix settings & updater for Canary - Nuckyz

[rugged spire]

only these

[charred monolith]

Nuckyz

[Vencord:dev] 1 new commit

5216bcc Fix settings & updater for Canary - Nuckyz

Nuckyz

[Vencord:main] 3 new commits

d897dab ShowHiddenChannels: Fix viewing voice channels ... - sadan4
e7e298d ThemeAttributes: fix freezing when changing avatar - Vendicated
5216bcc Fix settings & updater for Canary - Nuckyz

[fossil inlet]

wont this not work for non-eng users @limber skiff https://github.com/Vendicated/Vencord/commit/5216bcca1eca1b79a5a397e2128414ef653daee7#diff-ae0cebf157bf2cc41f1424ed4f7ea72c4e1a1e3de0177fee8ef426ddb81253abR160

[limber skiff]

pretty sure it does

it's an id, not a localized string

[fossil inlet]

ah

[rugged spire]

i've fixed one of these

at least I think I have

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 2 new commits

5216bcc Fix settings & updater for Canary - Nuckyz
f8bdd8e Merge branch 'dev2' into dev - Nuckyz

[rugged spire]

ok yes I fixed it 🙏

im sorry if i'm yapping

[limber skiff]

alright

I'm done

[rugged spire]

so the API is stable?

[limber skiff]

I suppose

you gotta remember I love changing stuff

but I think I wont change this one

[fossil inlet]

its vencord

[limber skiff]

so go ahead and use it

[rugged spire]

guhhhhhhh

[fossil inlet]

the only thing thats stable is that its unstable

[rugged spire]

I can't tell why BetterQuickReact broke

and I rely on that plugin

[limber skiff]

however the intl syntax is stable

[rugged spire]

if i dont have BetterQuickReact i will literally

[fossil inlet]

what even is betterquickreact

[limber skiff]

here's a brief explanation

#{intl:MESSAGE} gets transformed into .hash or ["hash

[rugged spire]

many emojis

[fossil inlet]

HORROR

[limber skiff]

the second case is used if the hash contains special characters like +

[fossil inlet]

SO BAD

[rugged spire]

i know its cursed af

thats why I like it

[limber skiff]

so if you to target all the intl usaged in a module you need to do #{intl:MESSAGE}\) or #{intl:MESSAGE}"\]

depending in the case

[rugged spire]

nvm I'm blind AF

[limber skiff]

#{intl:MESSAGE}\) will match \i.intl.string(\i.\i.hash)
^^^^^
#{intl:MESSAGE}"\] will match \i.intl.string(\i.\i["hash"])
^^^^^^

[austere talon]

lol intrnl

betterdiscord guy

[rugged spire]

[austere talon]

why do we need that dependency?

[limber skiff]

for 64 bits hashing

[fossil inlet]

@limber skiff

[austere talon]

is that what discord uses too?

[limber skiff]

yeah

[rugged spire]

yes

[austere talon]

oh funny

i see

[rugged spire]

@austere talon want to ?

this is hashing so we are effectively now forced to guess the translation keys

[limber skiff]

what am I supposed to see?

[austere talon]

hilarious

[fossil inlet]

match with \I

[rugged spire]

which we wont do

[fossil inlet]

[limber skiff]

sorry what?

[rugged spire]

/iYSo6

[fossil inlet]

nevermind

i think i need sleep

only got five hours

[limber skiff]

I think I need to escape \ too

but I havent had issues with any patches so maybe not

[rugged spire]

I have a problem

[limber skiff]

yes

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #2993 Fix all plugins for new i18n lib

Vendicated

[Vendicated/Vencord] New review comment on pull request #2993: Fix all plugins for new i18n lib

why remove this try catch? please add it back

[rugged spire]

I am trying to match this ```js
"aria-label": E.intl.formatToPlainString(E.t["/iYSo6"], {
emojiName: t.name
}),

"aria-label":E.intl.formatToPlainString(E.t["/iYSo6"],{emojiName:t.name}),

[limber skiff]

lol I just added that try catch @austere talon

[limber skiff]

what part

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #2993 Fix all plugins for new i18n lib

Vendicated

[Vendicated/Vencord] New review comment on pull request #2993: Fix all plugins for new i18n lib

this definitely needs a try catch (was also unsafe before)

[fossil inlet]

@dusk blaze forgot i installed this

[rugged spire]

Grandmaster at Pain & Suffering

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

4cf5b58 re-add try catch - Nuckyz

[limber skiff]

what's the key for this?

the original before hashed

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #2993 Fix all plugins for new i18n lib

Vendicated

[Vendicated/Vencord] New review comment on pull request #2993: Fix all plugins for new i18n lib

this definitely needs a try catch (was also unsafe before)

[austere talon]

oh it wasnt unsafe before

but still needs try catch

[limber skiff]

yep

[rugged spire]

ADD_REACTION_NAMED

I think I've got it though

This is going to be much harder than I thought

@fossil inlet i need emotional support

[fossil inlet]

are those all your plugibns

[rugged spire]

some of them are

[fossil inlet]

send repo

ill help fix

[rugged spire]

i dont need help

[fossil inlet]

ok

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #2993 Fix all plugins for new i18n lib

Vendicated

[Vendicated/Vencord] New review comment on pull request #2993: Fix all plugins for new i18n lib

Vendicated

[Vendicated/Vencord] New review comment on pull request #2993: Fix all plugins for new i18n lib

if this throws an error, entirety of vencord will explode so this absolutely needs a try catch

Vendicated

[Vendicated/Vencord] New review comment on pull request #2993: Fix all plugins for new i18n lib

please verify this won't cause crashes in case this throws (just make runtimeHashMessageKey throw and see). if it does, we need to add error handling somewhere - if it doesn't it's better not to

[limber skiff]

@austere talon this one doesn't need

it only tries if it's the better folders sidebar

which is wrapped in an error boundary

[rugged spire]

shitty highlighter job

[austere talon]

oh is it?

i would still add just for safety

[limber skiff]

yeah

okay

[austere talon]

basically to test just make ur getIntlMessage() throw an error always

and if shit crashes that needs fixing

it should still work worst case

[limber skiff]

HAHA

copilot leaked

[rugged spire]

ok

BetterQuickReact is fixed

[austere talon]

maybe getIntlMessage() should have its own try catch and return the i18n key?

so if it breaks in the future shit will still kinda work

[limber skiff]

sorry but how would it throw?

[austere talon]

you're using discord module

if lookup fails it will throw

[limber skiff]

I'm not

[austere talon]

oh right

it's using our function only

[limber skiff]

I copied discord code

[austere talon]

yeah fair

[limber skiff]

this is too early to do a webpack find

[austere talon]

but all getIntlMessage calls need catch

[limber skiff]

yep

[austere talon]

or maybe

function getIntlMessage(key) {
  try {
    return blahBlah;
  } catch (e) {
    console.error(`#getIntlMessage(${key})`, e);
    return key;
  }
}

it could catch on its own

[dusk blaze]

what were the others again?

[austere talon]

so vencord is still semi functional worst case

[austere talon]

i confused runtimeHashKey with getIntlMessage

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2993 Fix all plugins for new i18n lib

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2993: Fix all plugins for new i18n lib

is there any reason why the "] isn't checked for here? it makes patches look ugly

I have just done #{intl::ADD_REACTION_NAMED}\"],{emojiName because of this (previously it was .ADD_REACTION_NAMED.format)

[fossil inlet]

gave money to
unpaid intern
corporate slave

poor soul

[rugged spire]

what am I

[dusk blaze]

my greatest works

[rugged spire]

unpaid intern?

[limber skiff]

good enough?

[rugged spire]

[limber skiff]

actually I didnt even read the error message copilot just made it up 😭

[austere talon]

put logger in a top level variable and return key

it's more useful to see ui string like VIEW_USER than just empty text XD

but yeah

[fossil inlet]

wouldnt it be a hashed

[limber skiff]

well actually that's the one that accepts the hash

[fossil inlet]

shtring

[rugged spire]

@fossil inlet lets patch all of discord to remove hashed translation keys

[fossil inlet]

yes

[austere talon]

yeah then not useful

but

well idk

[rugged spire]

i want opinions

[limber skiff]

alright done

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

e4aba77 try catch getIntlMessageFromHash - Nuckyz

Nuckyz

[Vendicated/Vencord] Pull request review submitted: #2993 Fix all plugins for new i18n lib

Nuckyz

[Vendicated/Vencord] New review comment on pull request #2993: Fix all plugins for new i18n lib

I guess you are right, it can be checked

[rugged spire]

?remindme 10m bqr patch

[shut vine]

Alright @rugged spire, in 10 minutes: bqr patch

[rugged spire]

someone should pin a warning in #1256395889354997771 saying that many plugins might be broken due to these changes

VV       VV              sqaaakoi
 VV     VV               Version: 1.10.5 ~ 61acc9af (Dev) - 2 Nov 2024
  VV   VV                Client: Canary ~ Vesktop v1.5.3
   VV VV                 Build Number: 341146 ~ Hash: d69a6c6
    VVV
        CCCCCCC          Platform: Linux (Linux x86_64)
       CC                Plugins: 104 / 179 (official), 32 / 53 (userplugins)
      CC                 Uptime: 113388s
       CC
        CCCCCCC          Donor: no
                         Contributor: yes

                         ███████████████████████████

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

39de683 better intl transforming - Nuckyz

[limber skiff]

there you go @rugged spire

[rugged spire]

that is much more clean

[limber skiff]

yep

I agree

[frail sky]

Bad Patches

NoUnblockToJump (had no effect):
ID: 348238
Match: ```
/.?(.{1,10}.show({.{1,50}(?:.j7eA/v))/

**__NoUnblockToJump (had no effect):__**
ID: `494404`
Match: ```
/if\(.{1,10}\)(.{1,10}\.show\({.{1,50}(?:\.j7eA\/v))/

NoUnblockToJump (had no effect):
ID: 619753
Match: ```
/if(.{1,10})(.{1,10}.show({.{1,50}(?:.j7eA/v))/

**__NoOnboardingDelay (found no module):__**
ID: `-`
Match: ```
.Alcl/f

ThemeAttributes (found no module):
ID: -
Match: ```
./6mw19

**__WebContextMenus (found no module):__**
ID: `-`
Match: ```
.Rd/Mkp

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[limber skiff]

I broke stuff

[rugged spire]

[wary relic]

https://cdn.discordapp.com/attachments/1210212537178660905/1244025274312425502/togif-2.gif

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

b2dc81d fix - Nuckyz

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[limber skiff]

[shut vine]

@rugged spire, <t:1730661613:R>: bqr patch

[rugged spire]

done already

time to fix PollCommands

fuck

fixed another plugin

fuck

[limber skiff]

pretty straightforward to fix or having issues?

(the plugins)

[rugged spire]

Very straight forward

Just working through a list

[limber skiff]

nice

[rugged spire]

ughhhhh

JGDkfn GUILD_TEMPLATE_SELECTOR_OPTION_HEADER

WHY

[limber skiff]

btw theres a console shortcut to hash a key

[rugged spire]

love

need to fix

no thanks

[weary cave]

is it even worth having a cache when the mods themselves are max, a few kilobytes https://github.com/Legcord/Legcord/blob/dev/src/discord/extensions/modloader.ts

https://github.com/Legcord/Legcord/issues/763

okay maybe more like half a megabyte but still

[rugged spire]

This is the privilege of having good internet

Genuinely try stock Vendroid and you'll hate it

[weary cave]

mmm yeah the actual api checks are probably a few bytes

[rugged spire]

Ughhhhhhhhhhhhh

Finally getting around to SimplifiedProfileNotes

which is blatantly broken

[rugged spire]

lol wtf

@rugged spire@rugged spire@rugged spire@rugged spire@rugged spire

@limber skiff @fossil inlet i found an odd side effect from my broken plugin

[limber skiff]

what is it

[glass jasper]

honestly that plugin has seemed kinda of obsolete ever since the new profile popous came out

[rugged spire]

wrong

the point is to restore it to how it was

if there is a note rendered on a profile in my simplifiedprofilenotes plugin, and the profile popout was opened from a mention, the mention just Disappears

[glass jasper]

https://media.discordapp.net/attachments/1199708766384427102/1245575918731395183/caption.gif

damn

[rugged spire]

[rugged spire]

at this point i might as well rename the plugin

[glass jasper]

then do like Nuckyz did pronoundb

[charred monolith]

Kuromkkumi

[Vencord/Vendroid] New star added

[rugged spire]

i've noticed that failed patches aren't being logged at all

ok I regained my sanity

[rugged spire]

?remindme 2d find a suitable name and description for simplifiedprofilenotes

[shut vine]

Alright @rugged spire, in 2 days: find a suitable name and description for simplifiedprofilenotes

[rugged spire]

@fossil inlet i think I've fixed everything

[fossil inlet]

now i have to fix my plugins

[rugged spire]

it only took ~4 hours (including breaks)

[charred monolith]

ThaUnknown

[Vendicated/Vencord] Pull request opened: #2994 feat(plugin): WebPWA

This plugin makes discord installable as a PWA when used in browser, it's effectively a more than slightly worse version of Vesktop, but since it can re-use a browser that's already in use, does wonders for reducing RAM usage even further on devices which have little of it.

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

Brilliant idea with a few too many assumptions about where the code is running.

Ignore the outdated stuff, you made a lot of changes did many force pushes while I was trying to review this.

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

there has to be a better way of doing this. fetch this at runtime from within Discord

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

Remove this, it's irrelevant

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

This import is static. You do not want to be doing this with the styles you have. Take a look at GameActivityToggle for a good example as to why you should and how you can use a managed style

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

A PWA might be installed but the app might not be running within a PWA. Consider checking if you're in a PWA before overriding the stock behaviour. https://web.dev/learn/pwa/detection might help you

[rugged spire]

i can tell even though I've left my thoughts on it, this will be stuck in PR hell

[charred monolith]

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

quite literaly copied 1:1 from vestkop, with types and not any

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

vesktop didnt, but oh well

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

uuuuuh??? english pls?

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

IIRC it was required on some browsers to register a PWA

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

there's no PTB on web? or am I missing something?

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

there's no PTB on web? or am I missing something?

https://ptb.discord.com/app
https://canary.discord.com/app

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

I'm against this. It requires basic competence from the user, since this isn't reactive, if a user goes into pwa mode without restarting shit will break

[glass jasper]

Most seems like it’ll be closed because it’s very niche

[rugged spire]

Or that too

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

I'm against this. It requires basic competence from the user, since this isn't reactive, if a user goes into pwa mode without restarting shit will break

True. I'm not actually sure what this would look like. Perhaps some hackery with CSS media queries could be done directly? I say this as I don't know if using a React hook would work here. Is it even worth checking?

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

Assuming other web plugins like web right click and web keybindns dont... no?

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

I see little value in inlining this, so i wont

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

uuuuuh??? english pls?

You might not need to be loading it all like this, if you lazy load the stores using findStoreLazy you should be able to directly call addChangeListener on the stores here.

If that doesn't work, I would recommend replacing waitForAndSubscribeToStore with a promise wrapper around waitFor that also attaches the listeners and then using. Promise.all like Promise.all(["Store"].map(waitForAndSubscribeToStore)).then(() => setBadge()).
Make sure to replace the...

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

@Sqaaakoi any chance if you know if discord still hardcodes 720p 30fps for screensharing? I remember from GM days the browser code looked something like:

screenShare(videoQuality, audioQuality) {
// just ignore the settings lol
return navigator.mediaDevices.getDisplayMedia({ video: { height: 720, frameRate: 30 } })
}

but I'm struggling to navigate the new minified code, I wanted to fix that in this plugin too, but I can't verify if it's an issue

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

Assuming other web plugins like web right click and web keybindns dont... no?

They check a different way, which reminds me, Vencord plugins can be specified as web only by adding a .web suffix to the plugin folder name. You should probably do this for your plugin.

ThaUnknown

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

ThaUnknown

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

right, wish this was documented lmao

[opaque silo]

theres a web vencor plugin for this already

[rugged spire]

isnt that just the 2500kbps patch

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[rugged spire]

Not For Long

I am so sorry if I unleash horrors from my next comment

[shut vine]

@rugged spire, <t:1730659145:R>: merge dev into plugin branches

[rugged spire]

already did

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

@Sqaaakoi any chance if you know if discord still hardcodes 720p 30fps for screensharing? I remember from GM days the browser code looked something like:

screenShare(videoQuality, audioQuality) {
// just ignore the settings lol
return navigator.mediaDevices.getDisplayMedia({ video: { height: 720, frameRate: 30 } })
}

but I'm struggling to navigate the new minified code, I wanted to fix that in this plugin too, but I can't verify if it's an issue

I'm...

[charred monolith]

Z1xus

[Vendicated/Vencord] Pull request opened: #2995 mutual server members tab

adds a new tab to serverinfo plugin that shows server members that are also in your other servers, sorted by amount of mutual servers

[charred monolith]

Faf4a

[Vendicated/Vencord] New review comment on pull request #2994: feat(plugin): WebPWA

file name mismatches

import style from "./styles.css?managed";

Faf4a

[Vendicated/Vencord] Pull request review submitted: #2994 feat(plugin): WebPWA

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

60c2188 KeepCurrentChannel: Fix when switching accounts - Nuckyz

[limber skiff]

lol why did I write a good commit

forgot that wasn't dev

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

8a73c4f Fix it properly - Nuckyz

[charred monolith]

sprain57

[Vencord/Vendroid] New star added

[torpid vessel]

amend it

[austere talon]

did they push stable yet

[rugged spire]

no?

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

jeanz3ra

[Vencord/Vendroid] New star added

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

liliantdn

[Vendicated/Vencord] New comment on pull request #2288: feat(plugin): AltKrispSwitch

any update on this?

[charred monolith]

xPaw

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

I suspect this isn't going to work when using the userscript version because of Discord's CSP. I tried to manually inject the webmanifest just by copying the code out of here:

Refused to load manifest from 'blob:https://discord.com/2720f46f-fefa-4280-ac70-2df63a550683' because it violates the following Content Security Policy directive: "default-src 'self'". Note that 'manifest-src' was not explicitly set, so 'default-src' is used as a fallback.

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

I'm unsure why? This plugin works fine on my end? I'm running brave with the vencord extension

xPaw

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

I mean the userscript version of Vencord, not the extension.

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

ah yeah, it defo won't work there, nothing you can do about it, but it's a non issue, the extension is fine, and it's not heavy or problematic in any ways, the bigger issue is discord calls randomly dying because chromium suspends audiocontext in the tab for inactivity

xPaw

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

I tried the extension build, and it's dying on document.querySelector('link[rel="icon"]') being null. For some reason Discord replaces that icon on load with a base64 version? Don't know why it's not being found by this code during load.

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

ah right, that'd make sense, hmmmm

claymorwan

[Vencord/Vendroid] New star added

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

@xPaw try that

xPaw

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

That worked. However the scope needs to be scope: location.origin because it's trying to make a relative url to the base64 blob (Chrome reports this as an invalid url).

window-controls-overlay should be removed if you don't plan on handling that. Trying to hide control just draws it on top of the discord ui:

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

because it's trying to make a relative url to the base64 blob (Chrome reports this as an invalid url).

que? this part works fine for me?

window-controls-overlay should be removed if you don't plan on handling that.

that's what this is for

xPaw

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

que? this part works fine for me?

open devtools and look at the application > manifest, it reports an invalid scope url.

that's what this is for

I don't know what that does, if anything.

[charred monolith]

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

I'm uncertain why that patch wouldn't work for you, I copied it 1:1 from vesktop

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

I'm uncertain why that patch wouldn't work for you, I copied it 1:1 from vesktop

xPaw

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

Does it for you? Can you make a screenshot.

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

I'm doing these updates from my lap on my phone

xPaw

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

https://developer.mozilla.org/en-US/docs/Web/API/Window_Controls_Overlay_API is what that option is for.

ThaUnknown

[Vendicated/Vencord] New comment on pull request #2994: feat(plugin): WebPWA

yes im aware, but i'm patching discord to use native title bar, it's not for some reason

[limber skiff]

it's been so long since they pushed to stable

[glass jasper]

nelly.tools shoutout

[charred monolith]

waresnew

[Vendicated/Vencord] New comment on pull request #2288: feat(plugin): AltKrispSwitch

idk if adding new plugins is their priority rn but for now you can just use this as a 3rd party plugin

[long stream]

they probably won't push to stable for a while

new intl still has bugs on other languages

[glass jasper]

well id imagine with Vencord half broken rn, cause discord won’t push to stable that no plugin might be merged rn

[limber skiff]

yeah...

[long stream]

[jolly egret]

despite the breakages i think my PRs still work 😎

[jolly egret]

They pushed stable

[opaque silo]

nuckyz manifested it...

[glass jasper]

nuckyz what did you do

[limber skiff]

oh

it's time

[jolly egret]

wanna do a deploy?

i was thinking about pinging you

i'm sick of the 500 people in #🏥-vencord-support-🏥 complaining

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

Nuckyz

[Vencord:i18n-fix] 1 new commit

a1192c7 Bump to 1.10.6 - Nuckyz

Nuckyz

[Vendicated/Vencord] Pull request closed: #2993 Fix all plugins for new i18n lib

Nuckyz

[Vencord:dev] 1 new commit

eb72b28 Fix all plugins for new i18n lib (#2993) - Nuckyz

[limber skiff]

uhh

I should have put the bump in a separate commit

lol

[charred monolith]

Nuckyz

[Vencord:dev2] 1 new commit

00f82e9 Fix all plugins for new i18n lib (#2993) - Nuckyz

Nuckyz

[Vencord:dev2] 1 new commit

439a4f8 Bump to 1.10.6 - Nuckyz

Nuckyz

[Vencord] Branch dev was force-pushed to `439a4f8`

Compare changes

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

Nuckyz

[Vencord:main] 2 new commits

00f82e9 Fix all plugins for new i18n lib (#2993) - Nuckyz
439a4f8 Bump to 1.10.6 - Nuckyz

Nuckyz

[Vendicated/Vencord] New tag created: v1.10.6

[limber skiff]

@jolly egret

[jolly egret]

thanks

[glass jasper]

we just need to close the whole server and post a message telling people to update

[jolly egret]

tbh so true

like just lock the support channel for 30 minutes lol

[fossil inlet]

Wait did discord push?

[jolly egret]

yep

and so did we, so everything but chrome extension is fixed

[fossil inlet]

[jolly egret]

it kinda surprises me how many people can come in on breakages like these, how often are y'all starting/restarting discord so that our joins increase 500%

[fossil inlet]

General will be flooded in two seconds

[fossil inlet]

I think it's more that it has such a large user base that within any given period of time x amount of users restart their discord.

[austere talon]

there are 1mil+ users

[jolly egret]

insane

[austere talon]

thank you guys, good work

especially nuckyz and sadan

[austere talon]

hopefully I didnt forget anyone who also did a lot

[long stream]

my bad

[jolly egret]

imagine they revert because theres some bug thats apparent with stable

(please don't)

[glass jasper]

dont even joke about that

[limber skiff]

then we revert too

LOL

but not the extension of course

[jolly egret]

btw, noblockedmessages seems to crash right now

#1303451511464132648 message noticed it here and tested it myself

[jolly egret]

you need to hotfix the hotfix 😭

[fossil inlet]

ill take a look

[jolly egret]

👍

[fossil inlet]

oh, iirc no blocked messages read i18n values

i was the one who pushed that change 😭

[jolly egret]

you doomed us

[fossil inlet]

[jolly egret]

surely we can change what stuff we push for review on the extension or else we are gonna be pushing another one so soon lol

[limber skiff]

we can't...

happens

[jolly egret]

oof

[odd heath]

messagelogger also crashes when you have the collapse option on

[fossil inlet]

prob same issue

[odd heath]

yea

[fossil inlet]

ill look into that aswell

fixing no blocked rn

[limber skiff]

@austere talon lol we really need remote plugin disabling

[fossil inlet]

disable for devs

[jolly egret]

fwiw you can kinda do that by pushing an update zzzz

[fossil inlet]

me when no auto-update

[glass jasper]

Elvyra jumpscare

[limber skiff]

chrome extension

[glass jasper]

rce

[limber skiff]

I should have waited a bit before bumping

[odd heath]

i lurk here often

lmao

[jolly egret]

happens

[limber skiff]

@austere talon is it possible to cancel a review

[jolly egret]

hopefully we can do that, force push the tag and submit for review again 🙏

[odd heath]

itd be weird if you couldnt

there must be a way

[austere talon]

@high oracle

[high oracle]

We can report the review to Google for them to delete it

I’m not sure if there’s a way to delete your review from the userside, let me check

[limber skiff]

extension update review lol

not user