#👾-core-development

1 messages · Page 219 of 1

austere talon
#

should i just copy paste

fossil inlet
#

oh

austere talon
#

without it you get this beauty

fossil inlet
#

iirc it was m => m.modal && object.entries(m).length ===1

austere talon
#

ImageZoom hides it so if you didn't notice, that's why XD

austere talon
#

but its not really safe

#

i will copy paste the css

fossil inlet
#

also i could be misunderstanding how API plugins work

#

but wouldnt this need it as a dep

#

since it has only one size prop

austere talon
#

yop

#

good catch

fossil inlet
#

and for the spotify one

#

the height and width are props on track.album.image

#

if you want to use those instead of a constant size

austere talon
#

true

charred monolithBOT
austere talon
#

thanks for ur work btw

frail skyBOT
#
Bad Patches

OpenInApp (had no effect):
ID: 740605
Match: ```
/\i.\i.isProtocolRegistered()(.{0,100})window.open/g

Bad Webpack Finds
findComponentByCode(".mutualFriendItem]")
Bad Starts

None

Discord Errors

None

austere talon
#

oh guh

frail skyBOT
#
Bad Patches

OpenInApp (had no effect):
ID: 740605
Match: ```
/\i.\i.isProtocolRegistered()(.{0,100})window.open/g

Bad Webpack Finds
findComponentByCode(".mutualFriendItem]")
Bad Starts

None

Discord Errors

None

fossil inlet
austere talon
#

how tf does it work even without the component

fossil inlet
austere talon
#

"why did my changes not apply"

fossil inlet
#

istg if discord pushes more code tomorrow

cunning canyon
austere talon
#

(remove the patch)

austere talon
#

hmm good catch

#

idk how to fix

#

it doesnt get the props i think

#

well someone else can fix it

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

im gonna release

charred monolithBOT
glass jasper
austere talon
#

and messed up formatting midoristare

charred monolithBOT
#
[Vendicated/Vencord] New tag created: v1.10.5
jolly egret
#

gg

austere talon
fossil inlet
#

idk if its caused by pindms

charred monolithBOT
#

Discord Account

No response

What happens when the bug or crash occurs?

When you open an image carousel and switch to the next image, ImageZoom stops working

What is the expected behaviour?

it keeps working

How do you recreate this bug or crash?

  1. Open Image in a message with multiple images
  2. Try to zoom ~ works
  3. Switch to the next image
  4. Try to zoom ~ borked

Errors

nop

Request Agreement

  • [X] I am using Discord Stable or tried on Stable and this ...
jolly egret
#

smh you only fixed half the issue i demand a refund of $0

#

I wonder why that happens though

austere talon
#

i think it's because the makeProps() only is used in the intiial element creation

#

if you switch to diff image it takes some other path

fossil inlet
#

@austere talon do you see the message user buttons on profile modals

austere talon
#

nop

jolly egret
#

unrelated discord issue

#

they fucked up

austere talon
#

funny discord

#

i was confused earlier cause i was trying to dm someone

fossil inlet
#
        {
            find: "SimplifiedUserProfileModal",
            replacement: {
                match: /(?<=isCurrentUser:)!0/,
                replace: "false"
            }
        },
#

they have it as a constant

austere talon
#

did they mess that up somehow XD

fossil inlet
#

which fucks it up

#

but making it false

jolly egret
#

its literally impossible to dm or friend somebody outside of the small profile in guilds

fossil inlet
#

also fucks it up on your own profile

fossil inlet
weary cave
#

(im sorry)

fossil inlet
austere talon
#

show

fossil inlet
#
    updateMagnifier(instance) {
        this.unMountMagnifier();
        this.renderMagnifier(instance);
    },
austere talon
#

nah that's reasonable

fossil inlet
#

should i pr?

austere talon
#

makes sense

#

I would make the match a bit more specific tho

fossil inlet
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
#

Discord Account

mylloon

What happens when the bug or crash occurs?

The pronouns are only loaded when clicking on the profile

What is the expected behaviour?

I expect pronouns to be loaded without the need of a click

How do you recreate this bug or crash?

  1. Conversation with a user you don't have in the cache
  2. No pronoun
  3. Click on user's profile
  4. Pronouns

Errors

No response

Request Agreement

  • [X] I am using Discord Stable or tried on Stable and t...
jolly egret
#

Like other plugins not much we can really do about it othre than spam apis?

#

where contributor agreement...

rugged spire
limber skiff
#

requesting profiles is so ass

#

it has insane rate limiting

scenic brook
#

It'd be cool if the pronouns had their own css class so you could style it separately from the timestamp as well

limber skiff
#

discord should give that shit on the user object

scenic brook
#

I'd like to make them stand out more

jolly egret
charred monolithBOT
limber skiff
#

can we beg advaith for a gateway request for bulk profiles

rugged spire
limber skiff
#

gonna open an issue and say it's for client mods to use

#

💪

rugged spire
#

discord be like: yea sure the clause in our ToS is for our liability anyway blobcatcozy

rugged spire
limber skiff
#

they unironically should have it

rugged spire
#

yes

limber skiff
#

it would be so useful

rugged spire
#

i kinda hate how bots cant really view profiles though (to my knowledge)

limber skiff
#

lol I wonder if one can even request such stuff

#

as a suggestion

rugged spire
#

i think the user profile separation is stupid anyway

scenic brook
#

What legit reason would there be for it in the stock client?

#

Bundle it alongside a request for pronouns in member list to justify the endpoint

rugged spire
scenic brook
#

Aren't they on the user object?

rugged spire
#

they are

#

I thought they weren't

#

for some reason

brazen bone
charred monolithBOT
#

I've already dumped [some thoughts](#👾-core-development message) about this days ago

I've just been trying this out today and I've found a few things that feel weird about the plugin
I wouldn't be surprised if these existed in the PronounDB plugin too

  1. The tooltip showing "Pronouns" feels off-center, because it includes the
  2. Pronouns are not cached by the plugin itself, so every time the client i...
rugged spire
#

whats the point of bulk notes

brazen bone
#

No idea but it exists

#
              NOTES: '/users/@me/notes',
              NOTE: e => '/users/@me/notes/'.concat(e),
rugged spire
#

oh

#

this is useful

#

i thought it would need everyone to be specified

limber skiff
#

there's a gateway flag to include all notes in the initial connection info

#

lol

rugged spire
#

i just manually called that endpoint to find I have notes left that are husk worthy

limber skiff
#

do bots really have no way to get pronouns

scenic brook
#

If you're hitting the rate limit but you wait for the retry time and then immediately hit the rate limit again with the next bulk of requests, is that problematic or just how you're expected to handle it?

fossil inlet
#

I wonder if it would just be better to cache them in the data store or smth

#

But not sure if that's a good idea

rugged spire
scenic brook
#

I don't think bots can access profiles at all

limber skiff
#

that's shit

rugged spire
#

you can get connections with an oauth scope

scenic brook
#

They added the banner field to the member object for bots to avoid letting them get profiles lol

rugged spire
#

i think

limber skiff
#

vencord api for getting profiles soon (somehow)

#

probably not possible tho

scenic brook
#

Every profile request from vencord gets uploaded to a db and every other vencord client can access that suffoPeepoMischief
(this is a joke)

#

Crowdsourced profiles

limber skiff
#

hugeee privacy leak

#

does requesting profiles require a mutual server?

limber skiff
#

ugh

fossil inlet
jolly egret
#

what a bot can access about a profile is extremely minimal

charred monolithBOT
#

... to work around scrobblers like Plex.

For whatever reason, Plex scrobbler doesn't broadcast "Now Playing" / "Now scrobbling" actions, and only broadcasts that a song was played, halfway through the song. This means that currently this Vencord plugin is unable to show songs being scrobbled by i.e. Plexamp.

This CR adds a new toggle under plugin settings that allows the user to override the default plugin behaviour and simply use the most recent last.fm song for "listening to" activity...

charred monolithBOT
austere talon
#

MutationObserver 😭

charred monolithBOT
glass jasper
charred monolithBOT
charred monolithBOT
grizzled halo
#

did discord change the avatars again, got a few people complaining viewicon is broken on latest + stable

grizzled halo
#

if useful

fossil inlet
#

I'll take a look

#

ITS LAZY LOADED

fossil inlet
#

if someone can make a better find for 312097 than

findByCode("openModalLazy", "?await", "default:")
// OR
findByCode(/\}=\i\?await/)
#

please ping me

brazen bone
#

I find six modules that match that, none of which is 312097

#

I don't see a module 312097 at all

fossil inlet
brazen bone
#

Stable

fossil inlet
#

im on canary

#

idk if that matters

brazen bone
#

I don't have any module matching location:\w+,contextKey at all

#

So probably a canary thing

fossil inlet
#

@brazen bone do you have a module matching .MEDIA_MODAL_CLOSE

#

as text, not regex

#

and as a component

brazen bone
#

175724, 950120, and 981631 all match that

fossil inlet
brazen bone
#

Only 950120 looks like a component of those three

fossil inlet
#

alr that checks

#

tysm ❤️

brazen bone
#

175724 looks like it might be the handler for the escape key, and 981631 exports a hundred different enums and mappings

fossil inlet
#

WHAT IS THIS NEW UI

#

HORROR

brazen bone
#

950120 has some props like shouldRedactExplicitContent and shouldAnimateCarousel which look like they'd have to do with an image viewer

#

My avatar did not have that much jpeg when I uploaded it

fossil inlet
#

@limber skiff guhhhh

#

does extractAndLoadChunksLazy not load all chunks

#

there a module where two are loaded

#

seprately

#

not with a promise.all

#

and its only loading the first one

#

(discord broke imagemodals again)

charred monolithBOT
#

Thank you for your feedback.
At first, I was trying to achieve this with CSS, but while changing the size of the image is fine, it creates extra space in the parent element. This results in areas where the image isn't displayed, causing the preview not to close when clicked. Therefore, it was necessary to use JavaScript to make both elements the same size as the image. Additionally, using a plugin allowed for adding finer settings.
If I fix the code and there are no issues, I plan to submit...

long stream
fossil inlet
#

Also I have a fix, just not home rn

#
  • lazy issue
austere talon
#

omfg

#

why did they break it again

jolly egret
#

they want to torture us despairge

charred monolithBOT
#

Fixes #2967

Implement a caching mechanism for pronouns to load them without the need to click on the user's profile.

  • Caching Mechanism:

    • Implement caching using DataStore in src/plugins/userMessagesPronouns/utils.ts.
    • Add functions to get, set, and fetch pronouns with caching.
    • Modify useDiscordPronouns to check the cache before fetching pronouns.
    • Export fetchAndCachePronouns function.
  • PronounsChatComponent:

    • Update PronounsChatComponent in `src/plugin...
fossil inlet
# fossil inlet

@austere talon you love discord pushing a new unfinished ui

charred monolithBOT
#

Fixes #2752

Fix the TypingIndicator Plugin to prevent the chat area from jumping while editing a message.

  • CSS Changes

    • Add CSS rules to set position: absolute, bottom: 0, and width: 100% for .vc-typing-indicator in src/plugins/typingIndicator/style.css.
  • Component Changes

    • Modify TypingIndicator component in src/plugins/typingIndicator/index.tsx to use absolute positioning for the TypingIndicator element.
  • Devcontainer Configuration

    • Add `.devcontain...
fossil inlet
jolly egret
#

they also added a _tmp file in both

#

whats the bet this was done by an LLM

#

Yeah they 100% are

#

Looking at their history on github they have references of copilot in their descriptions and doing shit like this

jolly egret
# charred monolith

Also I don't like the look of this, if thats caching everybody who is sending a message and enough messages are being sent you are just gonna ratelimit yourself

austere talon
jolly egret
#

yeah....

austere talon
jolly egret
#

yep!

#

😭

austere talon
#

requesting an Aliucord plugin that disables a feature that isn't a thing on the old mobile app

jolly egret
#

crazy

rugged spire
#

IS THAT WHY IT BROKE

fossil inlet
rugged spire
charred monolithBOT
fossil inlet
#

@austere talon guhhhhhh

jolly egret
#

can't wait for 1.10.6 already

#

put some other things in the release too as to make it look less weird

fossil inlet
jolly egret
#

i know

fossil inlet
#

thanks vscode

#

that makes it really easy to lint

jolly egret
#

better than getting this for every file i look at

#

i don't care to fix it

sterile oak
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

dusk blaze
sterile oak
# sterile oak
poll_question_text

IDK what to do today so vote (mysterious poll)

victor_answer_votes

3

total_votes

4

victor_answer_id

2

victor_answer_text

2

victor_answer_emoji_name

2️⃣

sterile oak
rugged spire
limber skiff
#

that's why you write a custom matcher

charred monolithBOT
austere talon
#

brush

limber skiff
#

brush

#

I meant broom

#

but whatever blobwob

charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

ImageZoom doesn't work in the new modal implementation

#

but I guess we should wait a bit and see what they do with it

#

it has a "zoom" button

long stream
#

it would probably be a lot better in terms of qol xd

#

unless they remember that desktops that don't have a touch screen exist

charred monolithBOT
#

I have seen Github doesn't let you change the source code zip so it is outdated, please refer to the main branch for the latest source code. being in the description of the DevBuild, so I thought I make a change that also updates the source code options. I searched for source code in both pull requests and issues but didn't find something there.

It basically just updates and force-pushes the devbuild tag.

I'm not sure if commits are squashed, so it would be nice to know if I should ...

fossil inlet
#

Or is it just an experiment?

limber skiff
#

experiment

fossil inlet
#

What's it called

limber skiff
#

improved desktop media viewer

fossil inlet
#

also cant find it

limber skiff
sterile oak
# rugged spire sounds like a skill issue

found out after restarting the whole system that its was vscode playing with my heart, it wasn't saving the native.ts, I injected vencord 3 times because of vscode issue. didn't even show me a warning, I am reverting back to sublime text next time

charred monolithBOT
charred monolithBOT
pine topaz
#

kitty

rugged spire
#

WTF DO I MEAN YEARS

#

my brain is cooked

rugged spire
#

very good UI thanks discord

#

i wonder if this is broken by the patches made to vencord itself

frail skyBOT
#
Bad Patches

NoPendingCount (had no effect):
ID: 222059
Match: ```
/(?<={unviewedTrialCount:(\i),unviewedDiscountCount:(\i)}.{0,200}\i=)\1+\2/


**__NoTrack (found no module):__**
ID: `-`
Match: ```
.installedLogHooks)
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

NoPendingCount (had no effect):
ID: 222059
Match: ```
/(?<={unviewedTrialCount:(\i),unviewedDiscountCount:(\i)}.{0,200}\i=)\1+\2/

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

glass jasper
#

discord so ugly without this plugin

fossil inlet
#

guhhhhuhhhh

shut vineBOT
#

@fossil inlet, <t:1727235658:R>: port extension to generic LSP

charred monolithBOT
fossil inlet
#

also the fixed patch for no track

#

but its not broken on canary
so who know what they're doing

#
{
    find: "getDebugLogging(){return!!",
    replacement: {
        match: /(?<=getDebugLogging\(\){)(?=return!!)/,
        replace: "return false;"
    }
}
rugged spire
#

can someone run reporter

#

Discord went and kaboomed DM user profile sidebar again

fossil inlet
rugged spire
#

no they definitely exploded everything there

#

even on stable

#

i'm currently patching MutualGroupDMs

fossil inlet
#

@rugged spire you're outdated i think

#

mutual group dms broke a while back

#

its been fixed for a while

rugged spire
#

oh husk

#

my bad

#

i still wonder if I can fix something I've just noticed

#

yeah

#

its fixed exactly how I expected

#

however

#

that has made me discover a bug

fossil inlet
#

?remind saturday fix discord settings

shut vineBOT
#

Alright @fossil inlet, in 1 day: fix discord settings

fossil inlet
#

iirc someone else said they would do it

#

but its not done yet blobcatcozy

rugged spire
#

@fossil inlet should I PR my fix to an issue that nobody would've noticed

#

love

rugged spire
#

I Love Fixing Niche Issues

#

what do you mean the simplifiedprofilenotes patch can be fixed by increasing a quantifier

rugged spire
charred monolithBOT
frail skyBOT
#
Bad Patches

NoTrack (found no module):
ID: -
Match: ```
.installedLogHooks)

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
dusk blaze
#

WHAT İS ALİUCORD DOİNG HERE husk

rugged spire
#

ALSO IS NEVERONLINEGIT BACK UP YET

#

vfjd?

nimble pendantBOT
rugged spire
#

FINISH YOUR BACKUP WHEN bombcatcozy2

brazen bone
#

What's vfjd

#

Sounds like a button mash

rugged spire
#

vh fjd?

nimble pendantBOT
charred monolithBOT
charred monolithBOT
#

Plugin: BlurMediasToggle

Description:
The BlurMediasToggle plugin blurs all media content (images, videos) within channels, allowing users to keep sensitive content private from onlookers. The plugin offers a toggle key for quick enable/disable functionality. Additionally, media will unblur temporarily when hovered over, ensuring convenient access without compromising privacy.

Key Features:

  • Blurs all images and videos in channels.
  • Quickly toggle the blur effect with...
dusk blaze
#

chatgpt slop

charred monolithBOT
charred monolithBOT
turbid hatch
#

dnd?

opaque silo
#

I have ping sounds just off 💀

#

I will click the red circle when I click it

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jolly egret
#

crazy

#

we're green

jolly egret
fossil inlet
#

?remind tomorrow LSP for gd on $self. in replace

shut vineBOT
#

Alright @fossil inlet, in 1 day: LSP for gd on $self. in replace

fossil inlet
#

guhh i suck at git

shut vineBOT
shut vineBOT
#

@fossil inlet, <t:1729832511:R>: fix discord settings

fossil inlet
#

i really need to start using something other than r danny reminders

charred monolithBOT
charred monolithBOT
charred monolithBOT
long stream
#

turning off the ping just makes it way easier to accidentally miss the reply

jolly egret
#

i don't even mind when people i am talking to ping me in a conversation

rugged spire
#

?remindme 1w make restoresoundpacks

shut vineBOT
#

Alright @rugged spire, in 1 week: make restoresoundpacks

rugged spire
#

How is this seriously still not the default

charred monolithBOT
jolly egret
#

because its seriously ugly for literally everybody else not using fakenitro

#

its obnoxious imo

rugged spire
#

Is that for what it sends too?

#

No

#

I don't think that setting does what you think it does @jolly egret

#

FakeNitro uses that setting when rendering messages

#

NOT when sending them

jolly egret
jolly egret
#

if its compounded it doesn't embed inline which looks ugly af for everyone not using fake nitro with that setting enabled

rugged spire
#

you're confused

#

try toggling it for yourself

#

am I confused?

jolly egret
#

When you don't have fake nitro enabled with that setting enabled if a compounded "emote" is sent, it renders like the text which is ugly

#

i think a setting that prettifies everything that is still very ugly for everyone else should be disabled by default

rugged spire
#

I don't think there is a solution here without downsides

limber skiff
#

that one setting was so fucking complex to implement

#

and it's disabled by default lol

charred monolithBOT
shut vineBOT
#

@fossil inlet, <t:1727369711:R>: regex 101 extension for vencord patches

rugged spire
# rugged spire I don't think there is a solution here without downsides

oop i didnt post earlier but

Cons of having it enabled by default:
Users might think it is magic and works exactly like nitro emojis and not be aware of how it looks without FakeNitro
Users might post it in servers that automod all URLs for some reason and be confused
Same but with masked links being automoderated

Cons of having it disabled by default:
Users will think that the plugin is broken

anything else?

jolly egret
#

Guys... ViewIcons is broken again

#

how many times are they gonna break it this month

fossil inlet
jolly egret
#

nop

fossil inlet
#

All right, I’ll shower then fix it

rugged spire
jolly egret
#

viewraw is broken on message context too

austere talon
#

yop

#

ViewIcons works for me

#

nvm

#

had to reload

jolly egret
#

Am i tripping

brazen bone
#

Yeah it's not on right click

#

It's one of those hover buttons for sone reason

austere talon
#

uh nah ViewIcons works

#

maybe you're outdated?

rugged spire
rugged spire
jolly egret
#

huh i refreshed again (without running the updater) and it works again

#

but me and another user both could reproduce thonk

#

it is wiggling though i can reproduce that lmao

glass jasper
jolly egret
#

I swear every time i report something being broken its magically fixed when somebody else tries to reproduce it, I swear i'm not schizophenic or this prone to user error

fossil inlet
#

@rugged spire why are you shit brown

rugged spire
#

your plugger

#

sorry

#

do you have some kind of EditUsers

#

??

fossil inlet
rugged spire
#

What the hell

#

Clear your mobile app cache

fossil inlet
#

You can do that

#

Never knew

rugged spire
#

Can you even do this on iPadOS

fossil inlet
#

Yea

jolly egret
#

aww man the allowedmentions plugin (in the PR) broke i loved that shit

#

time to (try) and fix it

#

yeah this is harder than i thought trying to patch stuff when you didn't even know exactly what the old patches were doing is hard

charred monolithBOT
fossil inlet
#

?remind 6 hours fix wiggling in imagemodals

shut vineBOT
#

Alright @fossil inlet, in 6 hours: fix wiggling in imagemodals

jolly egret
#

can you make it wiggle more

brazen bone
#

Make ModalWiggle plugin

rugged spire
shut vineBOT
#

Alright @rugged spire, in 10 hours: patch earthquake to shake modals

rugged spire
#

You're welcome.

charred monolithBOT
graceful locust
#

Is there the ability to specify a vencord instance in settings.json?

#

for vesktop

charred monolithBOT
charred monolithBOT
fossil inlet
#

@jolly egret lol I was planning on making that

jolly egret
#

lol

#

lots of small stuff like this could be added to support helper

#

const plugin_name actually is this "illegal" naming

#

i am a rusty gal so idk

glass jasper
# charred monolith

@jolly egret I see this going in one way, and that is someone pressing the button, then complaining that a plugin that they didn’t enable is enabled. The debug and plugins button already shows that every single white name has the, monkey see button monkey press button mentality

jolly egret
#

Yeah I get that, but i don't think its a big deal

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jolly egret
#

Like.. its not like any of the plugins really do anything massive on their own, so users "accidentally" enabling them shouldn't really be a problem

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

jolly egret
#

I mean... have you seen how many plugins people have enabled here? I've seen nons with like... 130+ plugins casually whereas I only have like 53

#

I don't think it'll really bother them that much if they "accidentally" press buttons

glass jasper
#

💀 its going to happen but ight whatever you say

jolly egret
#

I mean i'm not the one who makes that decision anyway lol

#

its vee's/whoever merges it

#

can always be removed if its trouble though

glass jasper
#

SKULL_SKELETON ok

jolly egret
#

I don't like having the mentality of "We can't have new features because users are idiots"

#

Like regardless of what you do to idiot proof, there is always a better idiot to come crashing down

#

we can't just not add stuff because of that imo

#

Like alternatively maybe I could try and figure out how to open the plugin list with the plugin name already plugged in

#

not that familiar with the vencord core stuff so I wouldn't know where to write stuff like that

glass jasper
#

I think it’s a very good idea, I just foresee this happening a lot

jolly egret
#

but i don't wanna do workkkkkkk

#

surely theres an easy way to do that

brazen bone
#

SendTimestamps doesn't seem to handle DST correctly. If I write `02:00`, the resulting timestamp says 01:00

#

Probably not worth fixing though, timezones can go die in a ditch

jolly egret
#

only affects like 0.02% of the year wontfix !!

jolly egret
shut vineBOT
#

@fossil inlet, <t:1729970872:R>: fix wiggling in imagemodals

jolly egret
#

Would be great if theres an easy, non hacky way of filling in the search bar now

#

i'm gonna leave it for a bit and look into it later

#

not the best at vencord react or even js

fossil inlet
#

@jolly egret what are you talking about

fossil inlet
#

is this for the enable plugin thing

#

restarting a pluign

jolly egret
#

Yes

fossil inlet
#

maybe the contrib modal could help

jolly egret
#

People click too much so alternatively open the plugin search with it prefilled so they can enable it

fossil inlet
#

something like this

#

or just a modal with a plugin card

jolly egret
#

mm maybe...

#

I'm shit with UI and wouldn't know how to not make that ugly

#

also feels weird to open a modal with one plugin card on it

#

Maybe i'm just being picky but if theres a nice solution i could just do with settings instead i'd rather do that

jolly egret
shut vineBOT
#

@fossil inlet, <t:1729907420:R>: LSP for gd on $self. in replace

shut vineBOT
#

@rugged spire, <t:1729971830:R>: patch earthquake to shake modals

charred monolithBOT
charred monolithBOT
jagged cloak
#

i feel bad for people genuinely trying to give feedback and we're just memers

#

but F R I D G E

#

lol

limber skiff
#

fridge

rugged spire
opaque silo
#

where do the other platform indicators icons even come from

charred monolithBOT
dusk blaze
charred monolithBOT
charred monolithBOT
brazen bone
#

I think a 🎮 would be more informative but. Fridge.

rugged spire
#

rare moment where meme thread isnt locked

rugged spire
#

sounds a lot like "PR with some major changes sneaked in wasn't merged yet"

charred monolithBOT
rugged spire
#

GUH

#

i reviewed OLD file where change was INITIALLY made

charred monolithBOT
uneven needle
#

but then realised you could review a whole file

rugged spire
#

yeah

#

the UI for it

#

is dumb

charred monolithBOT
rugged spire
#

how bad is littering custom data in the message object

rugged spire
#

i did horrors #🤖-bot-commands message

uneven needle
rugged spire
#

DO NOT ACTUALLY USE THIS CURSED

#

i am begging you please make it less "hacky"

uneven needle
rugged spire
#

i copied half of this code directly from the plugins tab

charred monolithBOT
fossil inlet
#

a

charred monolithBOT
charred monolithBOT
charred monolithBOT
fossil inlet
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
rugged spire
fossil inlet
#

prob would have been closed anyway

rugged spire
#

idk why people want plugins that make the user experience intentionally worse without any fun aspect

charred monolithBOT
desert cosmos
#

close pr
open new pr
blobcatcozy

desert cosmos
#

is noscreensharepreview still needed as plugin? looks like discord added it recently

#

unless its not rolled out fully yet

limber skiff
#

not needed anymore

fossil inlet
#

Didn't it get removed or am I crazy

#

(The plugin )

jolly egret
#

thing is removing the plugin now would leave users with the preview enabled until they turn it off in discord settings

fossil inlet
#

After a few months, remove it

still maple
charred monolithBOT
brazen bone
#

Dom manip

charred monolithBOT
shut vineBOT
#

@fossil inlet, <t:1728926512:R>: …

spice python
#

can't you change emoji font with css

swift fjord
#

they aren't a font in discord

scenic brook
# charred monolith

tbf the css in that is kinda insane, if I were looking for this feature I'd probably prefer a plugin over 50k lines of css

brazen bone
#

Yeah I'd rather have 15 lines of plugin than 50k lines of css that probably needs updating whenever the emoji list changes and interacts poorly with copypaste

surreal fiber
#

devilbro css best css

charred monolithBOT
opaque silo
#

i will now feature request in github commit comments

prime dew
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

heavy cedar
#

guys is firefox devtools super slow for anyone else when doing basic stuff like ctrl+shift+f on discord or using react devtools to select a component
my firefox reached 9gb ram usage and constnat 30% cpu

#

meanwhile on desktop discord it's fine

charred monolithBOT
fossil inlet
#

firefox sucks tbh

#

react devtools has never worked on it

#

on two laptops and a desktop

#

across a dozen verisons

#

it is missing quite a few features compared to chrome

#

just pinning to the last version with mv2 on chrome

limber skiff
#

I once had to debug a vencord issue that only happened in Firefox

fossil inlet
limber skiff
#

it didn't end well because their devtools is shit

fossil inlet
#

i wonder if there will be chrome forks or something of that kind that just keep mv2

#

that would be nice

limber skiff
#

ungoogled chromium likely

fossil inlet
#

yea

limber skiff
#

but idk if I wanna use it

fossil inlet
#

it would need some kind of sync

#

if it didnt have that, it wouldnt really work well with school work

limber skiff
#

yeah sync is good

#

my college gives a google account so it's pretty useful

austere talon
fossil inlet
limber skiff
#

for now I've just enabled extended support for mv2

fossil inlet
#

i have a few that use mv2 that arent ubo

austere talon
#

mv3 is superior in many regards. but at the same time has some limitations, but they only really matter for adblocking

#

the majority of extensions can benefit from upgrading to mv3

fossil inlet
austere talon
#

the main breaking change is that there's now a hard limit on net request filters and it's not as powerful as previously

#

no normal extension needs more than like 10k rules

#

only adblockers

austere talon
#

vencord has been using mv3 for ages

fossil inlet
limber skiff
#

we need a fork of chrome that just enables mv2

#

I don't mind google taking my data they provide me a good browser experience

fossil inlet
#

there are so many sites ive only ever seen on desktop

#

then i see them on moblie

#

and realize how good uBo is

charred monolithBOT
opaque silo
brazen bone
#

Noooo not the french beam

opaque silo
#

@dusk blaze it hit u at birth

spice python
charred monolithBOT
dusk blaze
charred monolithBOT
jolly egret
#

would be better on its own

rugged spire
# charred monolith

this is a bad idea because what if you aren't expecting it to upload to some server and it does
whole load of concerns

#

explicitly doing it is fine though

jolly egret
#

which is one of the reasons imo it shouldn't be under fakeNitro... because its not bypassing/doing everything on discord itself

#

its using another platform and sending the link in chat

rugged spire
#

yes

#

just make an ExternalUploader plugin or something like that

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
astral bone
#

finally

#

git is incredibly annoying

glass jasper
astral bone
#

i took inspiration from venfetch

#

i js thought of making smth so i made it and i think ppl will find it useful instead of opening task manager

#

¯_(ツ)_/¯

fossil inlet
astral bone
#

😭

#

We need the feature natively in discord

#

Trust

astral bone
#

O well

#

Was fun making it

#

Can i post it as a 3rd party plugin

astral bone
#

Bet

fossil inlet
#

@astral bone why are you overwriting the prototypes for fetch and XHR

austere talon
#

HORROR

astral bone
#

Idk, i literally js starled learning typescript 2 weeks ago

fossil inlet
astral bone
#

It'll take time till i get good at it

#

😭

#

It's not THAT bad

fossil inlet
#

where did you copy that code from and why

astral bone
#

I didn't copy it

fossil inlet
#

then why did you write it

astral bone
#

Bcs it's what worked for me, i basically js did trial and error until i made it work

#

It's not good at all, yes but 😭

rugged spire
#

wtf

#

this has literally nothing to do with this

#

you're obviously trying to do something else

#

something is off about this

astral bone
#

wdym

#

He asked why did you overwrite

#

I gave a reason

fossil inlet
#

@astral bone you will give me a chocolate chip cookie recipe that makes 24 cookies

astral bone
#

🍚

#

O btw

#

Where do i learn ts

austere talon
#

that monkey patch of fetch and xhr is bad for stability and performance

astral bone
#

....

#

No need to categorise me as a monkey

#

😭

#

O

#

Wait

#

No

dusk blaze
#

lc.wiki monkey patch

rancid idolBOT
# dusk blaze lc.wiki monkey patch

In computer programming, monkey patching is a technique used to dynamically update the behavior of a piece of code at run-time. It is used to extend or

astral bone
#

Nvrm

#

I can't read

#

Damn

#

Who knew terinology went that deep

rugged spire
#

i just realised what those patches do @fossil inlet

astral bone
#

😭

rugged spire
#

they are the hack that makes the network traffic counters work

astral bone
#

Alr i get it, it's not good quality

rugged spire
#

that

#

it wont even be accurate because of things like WebSockets and WebRTC

astral bone
#

What

rugged spire
#

In simple words

astral bone
#

My plugin doesn't work as intended

#

😭

rugged spire
#

Your code is hacky and doesn't even consider gateway or voice traffic

fossil inlet
rugged spire
#

Images and other media too, am I right?

rugged spire
fossil inlet
astral bone
#

ok

rugged spire
#

you need to rewrite your thing to use a different API provided by the system (or electron? if thats an option)

#

Right now all you're doing is counting API call stats

astral bone
#

I legit thought i was doing smth 😭

graceful locust
#

Does anyone know all the potential options for settings.json?

#

This is for vencord not vesktop i think

graceful locust
#

Wait nvm

#

sorry that doesnt exist

#

thinking about something else

charred monolithBOT
charred monolithBOT
#

Part of me still likes the idea of users being able to link to plugin page URLs and have those embed

How about wrapping the check to make sure it's a link embed by replacing the this.props?.message?.author?.id==='${VENBOT_USER_ID}' with (this.props?.message?.author?.id==="${VENBOT_USER_ID}"||this.props?.embed?.type==="link")

There are some things to be concerned with though, embedded links could link to a different page, though in this case you can safely blame the issue on the site

fossil inlet
#

?remind one week plugin to replace github links with lines with the actual code

shut vineBOT
#

Alright @fossil inlet, in 1 week and 1 hour: plugin to replace github links with lines with the actual code

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
charred monolithBOT
glass jasper
# charred monolith

agreed 10mb upload size is fuckin ridiculous and this is the best way of giving someone a bigger upload size

limber skiff
#

I can see it being it's own plugin

#

but not as part of FakeNitro

rugged spire
#

what is currently a userplugin could be submitted just fine

austere talon
#

bruh just use sharex

#

you don't need this inside discord

bleak blaze
#

for that you’d need embed perms

#

otherwise you won’t be able to view the image in some servers you’re uploading to because they won’t allow that

#

same for not allowing links

bleak blaze
rugged spire
jolly egret
#

^

#

this isn't bypassing the upload limit this is literally just uploading elsewhere

rugged spire
#

yes

austere talon
#

it's a link either way lol

#

a plugin like that would just be recreating sharex

#

which is a bad idea because the plugin could never be as feature rich & good

#

just use sharex

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
gritty iris
#

git didnt want to clone the repo from that org for some reason

charred monolithBOT
#

Delete plugin fixImagesQuality.
There is no reason for WEBP to cause quality loss when it isn't called for by the connection speed of the user. While it is both a lossy and lossless format, it's very effective compression algorithm enables it to decrease file sizes enough to often load it at acceptably high qualities on weaker connections.
All this plugin does is replace any image which would be loaded a WEBP with PNG, which while it is a lossless format, it might take significantly longer...

glass jasper
opaque silo
#

webp is cool actually

rugged spire
opaque silo
glass jasper
brazen bone
#

Back in my day we used .bmp and .gif, and we liked it

opaque silo
glass jasper
#

ok unc

brazen bone
#

Just kidding nobody has ever liked bmp

glass jasper
glass jasper
rugged spire
#

we need jxl

opaque silo
#

horrible name

rugged spire
#

i will leave a detailed comment on the pr

rugged spire
#

i'm about to leave a comment explaining the history of the plugin

charred monolithBOT
rugged spire
#

this was broken at one point

glass jasper
crude raptor
#

agree

rugged spire
#

Yes

#

I was going to amend my comment saying that I can't vouch for it being fixed but bleh

limber skiff
#

"It also means that this plugin completely disables discord's ability to match users internet speed and image quality."

#

and how would this even happen

rugged spire
#

discord does not even do that

#

images are too small to measurably do this

#

part of me has to say

#

who the hell cares discord already loads bloated JSON and whatnot and you are constantly being bombarded with useless gateway messages

jolly egret
charred monolithBOT
#

The reason the plugin exists because Discord had an issue where their media service would send a lossy image when a client requests a lossless image Do note that the plugin has been removed in the past because Discord has fixed issues and then readded due to that issue being discovered

This is Interesting, and I see why it would dismiss my pull request. But why then not just add this information, together with a warning that this plugin may slow loading times, to the plugin description?

glass jasper
jolly egret
#

loads full quality
takes longer

rugged spire
#

its only an issue if you have bad internet and it'd be an issue with and without the plugin anyway

charred monolithBOT
charred monolithBOT
astral bone
#

huh

#

Does the bot record everything related to vendicated?

jolly egret
#

its a webhook on some stuff yes

granite wharf
#

Its not a bot, you can add webhooks to github and it will send information

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#

Description

Enhanced the BlurNSFW plugin to support blurring images in DMs. Added a toggle option in settings to enable/disable DM blurring independently of NSFW channel blurring.

Changes

  • Added new blurDirectMessage toggle option in settings
  • Added DM detection and blur functionality
  • Maintained all existing NSFW channel blur functionality

Testing

Tested functionality in:

  • NSFW channels (existing blur working as expected)
  • Direct Messages (new blur working with to...
charred monolithBOT
charred monolithBOT
#

Description

Enhanced the BlurNSFW plugin to support blurring images in DMs and group chats. Added a toggle option in settings to enable/disable DM blurring independently of NSFW channel blurring.

Changes

  • Added new blur direct message toggle option in settings
  • Added DM and group DM detection and blur functionality
  • Blur amount settings affect both channel and DM blurring

Testing

Tested functionality in:

  • NSFW channels (existing blur working as expected)
  • Direct Me...
brazen bone
#

Does this person know you can push more commits into a pr

still maple
#

Nah

shut vineBOT
#

@rugged spire, <t:1729947622:R>: make restoresoundpacks

rugged spire
jolly egret
rugged spire
charred monolithBOT
charred monolithBOT
somber thorn
#

<@&1073655264923881602> (I failed)

P.S. I have reached out to the original author, who welcomed this PR.
but like, why?

granite wharf
#

Gm

rugged spire
#

and never submitted PR

#

idk why

#

mostly because I was removing bloat too

#

and it was highly opinionated

brazen bone
#

Not okay, no opinions plz

fringe basalt
#

calm before the storm

austere talon
#

nop

fringe basalt
#

yop

#

the new strings system is out on canary

austere talon
#

what does that mean

fringe basalt
#

it means

#

no more string keys

austere talon
#

what strings

fringe basalt
austere talon
#

i18n?

fringe basalt
#

ye

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

why

fringe basalt
#

yes

austere talon
#

malware

fringe basalt
#

and also the keys change every update

austere talon
#

kys discord

limber skiff
#

holy

#

actual

#

fuck

#

ggs for our finds

austere talon
#

what's the point 😭

limber skiff
#

ugh

#

the worst is

#

I had already noticed thoes changing keys every new build

#

but I didnt realize every string was going to become that

grave mangoBOT
limber skiff
#

they are so mean

#

obfuscating it...

jolly egret
#

doomsday

limber skiff
#

this might be the worst one ngl

austere talon
#

anyway that means there's no chance they're reverting it

limber skiff
#

yeah

#

they won't

austere talon
austere talon
#

yeah i know

#

but

limber skiff
#

oh

austere talon
#

we just need to find a new way to match

limber skiff
#

yeah

#

but that's horrible

austere talon
#

best to update before they push to stable / download sources now

limber skiff
#

not only we need to fix finds

austere talon
#

so we can crossreference for new finds

limber skiff
#

we need to fix matches that use it

#

doesn't @brazen bone have a tool to download it

#

which includes all chunks

fringe basalt
#

i've already reversed half of it from the client code 😭

dusk blaze
#

insane

jolly egret
#

i sure hope we can get the most of this fixed before they push to stable

brazen bone
limber skiff
#

yeah

brazen bone
#

Yeah I have a WebpackTarball for that

limber skiff
#

can you do it?

brazen bone
#

I thinm I'm missing a bit of context here

limber skiff
#

use your tool and download the current stable source

#

they did this

brazen bone
#

I can do that when I get home

limber skiff
#

alright

brazen bone
austere talon
#

clearly not keeping up with github dot com slash discord...

brazen bone
#

So basically all Messages.FOOBAR finds are broken now?

fringe basalt
#

yes

fringe basalt
#

okay nvm this package sucks, can't import what i want

jagged cloak
#

WHY

#

anyway free pr idea: ignoreactivities update for their new stuff

#

discord engineers blanket categorizing all steam apps as games applemoyai

limber skiff
#

already is

jagged cloak
#

i could look at it actually

#

how

limber skiff
#

it already prevents game from appearing there

jagged cloak
#

how come bro saw it then

#

its blocked

grave mangoBOT
limber skiff
#

this one patch in specific

#

unless they changed something

jagged cloak
#

im checking src rn

limber skiff
#

but in the past I tested and that patch fixed the issue

jagged cloak
#

but i have to eat

limber skiff
#

check your network tab and gateway events when you launch the game

#

to see if they are still tracking and sending that data somehow

jagged cloak
#

curse of electron

#

main process is blocked in discord but theyre still picking up the electron process

limber skiff
#

lmao