👾-core-development

[rugged spire]

yeah vencord doesn't patch this

[charred monolith]

byeoon

[Vendicated/Vencord] New comment on pull request #2256: feat(plugin) WebhookManager

hi hi

[jolly egret]

its always after merge

[charred monolith]

McRoyce

[Vencord/Vendroid] New star added

[charred monolith]

MiguVT

[Vendicated/Vencord] New comment on pull request #2882: New Plugin: DayNight Switcher

There was no reply, should i change something?

[fossil inlet]

😭

Whar

[rugged spire]

I'm just surprised that this wasnt fixed earlier

[fossil inlet]

Look at how many patches show hidden channels has

[rugged spire]

Oh no

what the fuck 😭

i understand now

[fossil inlet]

Once I found the patch it was pretty easy to fix

(It was also the first patch I tried

[limber skiff]

hehe

[fossil inlet]

Wonder if those are all needed

[limber skiff]

I mean theres an explanation in every single one

[fossil inlet]

Not all

I knew because I read every single one while fixing it

Most do tho

[limber skiff]

most are just hiding or replacing components

for the channel screen

making mentions work and etc

[fossil inlet]

I remember quite a few for stage channels

[limber skiff]

voice

stages

lol

[uneven needle]

whats up with that look behind on the last one lol?

[limber skiff]

trick to capture variables

[uneven needle]

it doesnt even capture anything tho?

[limber skiff]

it does

channel:(\i)

[uneven needle]

?

[limber skiff]

oh

uhh

optimization trick

shouldnt matter much

but it matches callContainer first (which has no wildcard)

and makes sure it's the right thing by matching \i.callContainer after (rematching the previous callContainer)

[uneven needle]

neat i guess

[limber skiff]

the context menu api patches (which apply so many modules) use the same trick

match: /Menu,{(?<=\.jsxs?\)\(\i\.Menu,{)/g

[fossil inlet]

how much time does it save?

[brazen bone]

Four

[limber skiff]

it's definitely not needed in that case

[hot hatch]

Is there a reason why or is it simply no one just wanted to?
Also I wonder how expensive performance-wise it’d be to uh modify that list of the strings every time the class gets constructed to do something like that (not really familiar with js but it seems like that’s the way you can add one array to another): this.terms = […original_list, …list_from_vencord];

[limber skiff]

no one looked at it

[hot hatch]

gotcha

[limber skiff]

@austere talon we are gonna do something similar 💪 https://codeberg.org/vee/cord-legacy/commit/fd56dfd441f861ffcfc712fa56596eab55baa0b5

[austere talon]

😨

dont look at that code

[limber skiff]

prettier in client when

[austere talon]

it's so bad

[limber skiff]

nah honestly

pretty clean code

ngl

[austere talon]

wpex with prettier

[limber skiff]

sure could be bad practices

[austere talon]

[limber skiff]

but it's pretty clean

[rugged spire]

fyi there is another array of objects containing an array of settings pages
These must be populated too

[limber skiff]

would be fire

[hot hatch]

eh?

[rugged spire]

Not only is this useless, it's an anti-feature
browser devtools does this for me, and i can toggle it off
It is actually super useful to be able to toggle it off there

[limber skiff]

electron.webFrame.executeJavaScript((() => (${patchPush.toString()})())(););

hehehe

[rugged spire]

if you go to that list, same chunk file should have what I'm talking about above it

Not directly above

[hot hatch]

oh I see what you mean now, thank you, I’ll see what I can do

[rugged spire]

what is this useful for

[brazen bone]

It's for when you want to write lisp, but you're stuck in jsland

[austere talon]

DONT LOOK AT THAT

it used an old method to bypass context isolation whcih was very bad

xd

[limber skiff]

yeah i saw

lol

[rugged spire]

Thanks for confirming that I'm not a dumbass and that this is cursed

[austere talon]

legit it's so fucking bad

running in preload instead of renderer for no reason

i copied that from powercord cause i didn't know what i was doing back then

but it's just bad lol

bad for security cause you break the isolation of nodejs and the browser
bad for integrity cause if any error happens (like react error), entire app will crash
does not have any benefit

[fossil inlet]

I'm using prettier for the extracted modules in the companion

Its pretty good

[charred monolith]

kisames

[Vendicated/Vencord] New comment on pull request #1452: Plugin Addition: copyProfileThemes

how can i use this plugin?

[charred monolith]

Darxoon

[Vendicated/Vencord] Pull request opened: #2943 Add disableMiddlePaste plugin

Disables pasting with middle click on Linux. Useful over something like XMousePasteBlock because it works more reliably in my experience and doesn't require a third party program.

[opaque silo]

how insane are you gonna go

[hot hatch]

wha

[opaque silo]

are you gonna manually write out each entry or are you gonna automate it somehow

[hot hatch]

uhhhh

I mean the vencord settings is just an array of settings like that, I guess I could uh make a func that would gen an array of searchable strings based on that array

idrk much tbh

[opaque silo]

2 billion entries for plugin settings

[hot hatch]

sorry wdym?

I'm missing the point

[austere talon]

ignore her she had too many cookies today

her brain is sugar poisoned

[opaque silo]

STOO

SOTP

STOP

[austere talon]

see

she cant even type

[opaque silo]

including plugin settings in the array will balloon its size

[austere talon]

eh it's fine

[hot hatch]

like you want to make recursive search that'd include each plugin name?

[opaque silo]

I love searching an array that has 2 trillion entries

[austere talon]

its fine

[hot hatch]

I still don't get what 2 trillion entries there will be
the settings searchbar just searches for the tab name (and maybe some other keywords)

[opaque silo]

you can search the individual settings no?

[hot hatch]

uhh no?

huh actually

[opaque silo]

yeah you can

[hot hatch]

yeah you can but ig there's no point in making it search for EACH plugin's settings

[opaque silo]

feature parity smil

no point implementing it if if its not the best it can be

[austere talon]

yeah

but with how vencord plugin settings works idk how to do it

and have to restructure a lot to make it work like discord

it's not as simple as just adding vencord's section names

a lot of the code has to be rewritten

[opaque silo]

write insane parser

maybe just highlight the plugin with the setting for now

showing the popup and filtering would be insane

[hot hatch]

oh god I just reliazed that it not only finds the tab that has this string but also removes everything but the string you've searched for if it's in the tab's body

[opaque silo]

yeah its good design but def horror to patch

[hot hatch]

yeah and the fact that it's just a big list rather than like automatically generated one is ehhhhhh

[opaque silo]

i bet the dev who wrote it made a script to generate it from their source

[hot hatch]

alright ig it's time to set up the dev env to actually start making something

how can I test a patch without vencord vscode plugin?

if I got it right it can be done with just vencord client?

assuming from the plugin src code

[sterile oak]

patch helper

[sterile oak]

wdym

[hot hatch]

oh thanks

[hot hatch]

uhhh nevermind

also back to the settings thing, I just noticed this tab in settings lol

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[fossil inlet]

?remind 5 days fix companion erroring when extracting a patch with all:true

[shut vine]

Alright @fossil inlet, in 5 days: fix companion erroring when extracting a patch with all:true

[charred monolith]

WhoIsSahidur

[Vencord/Vendroid] New star added

[glass jasper]

Discord exploded clienttheme

[limber skiff]

canary?

[glass jasper]

both i think, just people reporting it #🏥-vencord-support-🏥 message and im/a friend is able to replicate

[oak hull]

(me)

[limber skiff]

works for me

[glass jasper]

hum…

[grizzled halo]

works for me too

[glass jasper]

nvm its broken on desktop refresh only

[long stream]

i think the destkop refresh uses completely different css vars now

[charred monolith]

guibzo

[Vendicated/Vencord] New comment on pull request #499: feat(plugin): ChannelTabs

just wondering, why is there 300 commits for 4 archives? 💀

[rugged spire]

I think you are looking at why the PR was closed

[rugged spire]

I'm probably the first person to ever discover this bug (softlock?)
https://github.com/Vendicated/Vencord/blob/dev/src/main/ipcMain.ts#L111-L113 can error with
UnhandledPromiseRejectionWarning: Error: EMFILE: too many open files, watch '/home/sqaaakoi/.config/Vencord/themes'
Shouldn't this be wrapped in a try catch block (or something similar?)
Completely blocks the desktop client from loading

[grave mango]

ipcMain.ts: Lines 111-113

const themesWatcher = watch(THEMES_DIR, { persistent: false }, debounce(() => {
    mainWindow.webContents.postMessage(IpcEvents.THEME_UPDATE, void 0);
}));

[rugged spire]

With OpenAsar it would lock up their loading page and without it wouldn't open anything at all

If anyone wants to know why this happened, try breaking r2modman in some weird way where it sits in the background after being closed eating many file handles

[oak hull]

i found a small fix, but its better on dark mode than light mode
no idea why

const newVariableRegex = /(--neutral-([1-9]|[1-9][0-9])-hsl):.*?(\S*)%;/g;
const newLightVariableRegex = /^--neutral-([1-9]|[1-5][0-9])-hsl/g;
const newDarkVariableRegex = /^--neutral-[5-9][0-9]-hsl/g;```

```ts
createStyleSheet("clientThemeNewOffsets", [
        `.theme-light {\n ${genThemeSpecificOffsets(variableLightness, newLightVariableRegex, "--neutral-24-hsl")} \n}`,
        `.theme-dark {\n ${genThemeSpecificOffsets(variableLightness, newDarkVariableRegex, "--neutral-55-hsl")} \n}`,
    ].join("\n\n"));```

[opaque silo]

it does and its wondedful

99% of the client is var based

[charred monolith]

real-shivam

[Vendicated/Vencord] Issue opened: #2944 [PinDMs Plugin] Invisible's most DMs while scrolling or navigating through them

Discord Account

shivam01

What happens when the bug or crash occurs?

I have 3 categories in DMs. First 2 have 5-10 pinned. 3rd is the Group DM category and it has like 15 pinned. Like scrolling or navigating through them, the bottom part of the DM becomes invisible (more than half of the screen can't view the DM list)

Video Proof: https://drive.google.com/file/d/1kSGCMcRXsBplnPSPpPSPScbq0Ejhkp9V/view?usp=sharing

What is the expected behaviour?

I expect my DMs to act normall...

real-shivam

[Vendicated/Vencord] New comment on issue #2944: [PinDMs Plugin] Invisible's most DMs while scrolling or navigating through them

Discord Account

shivam01

What happens when the bug or crash occurs?

I have 3 categories in DMs. First 2 have 5-10 pinned. 3rd is the Group DM category and it has like 15 pinned. Like scrolling or navigating through them, the bottom part of the DM becomes invisible (more than half of the screen can't view the DM list)

Video Proof: https://drive.google.com/file/d/1kSGCMcRXsBplnPSPpPSPScbq0Ejhkp9V/view?usp=sharing

What is the expected behaviour?

I expe...

[jolly egret]

oh my god did you need to quote reply the entire message

[glass jasper]

https://tenor.com/view/see-you-tomorrow-gif-2020647686865295985

[jolly egret]

also they edited their message to untick the stable requirement 😁

[charred monolith]

MomoMiles

[Vencord/Vencloud] Pull request opened: #45 Added Redis Password Input

Changelog

Redis Allows Passwords

Allowed a redis password to be inputted into the bot, preventing an error lacking authentication.

File Changes

1. globals/globals.go
   • Added REDIS_PASS as variable
2. .env.example
   • Added REDIS_PASS as example variable
3. main.go
   • Added error for missing password to client console
4. routes/discord.go
   • Added error for missing password to client console

[austere talon]

into the bot

did he use ai for the description

[brazen bone]

The "file changes" is also silly, there's a whole tab for files changed

[hot hatch]

what does \i in find regexp mean? is it vencord custom thingy as I couldn't find such token

[fossil inlet]

It is custom built into vencord.

It references any JavaScript identifier.

If you want to learn more look at the canonicalize functions

[hot hatch]

thank you!

just noticed this tho

[charred monolith]

lewisakura

[Vencord/Vencloud] New comment on pull request #45: Added Redis Password Input

This isn't necessary in the supported Vencloud deployment since it runs its own isolated Redis instance. Why do you need this?

[dusk blaze]

true

useless if u use docker

[jolly egret]

i don't get why you would need password support

like unless you're running this on an untrusted machine (you really shouldn't run something like this on an untrusted machine) password shouldn't be needed

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[long stream]

wouldn't it be pointless eitherway?

if it's on a vulnerable machine then you can just read the .env file

[charred monolith]

MomoMiles

[Vencord/Vencloud] New comment on pull request #45: Added Redis Password Input

While not exactly necessary, I always try to choose redundant security when
possible, so I personally put a password on it. I know its a very niche
case but it does allow for a more clear error if some other random person
does try to do it. Simply put, I don't see a reason not to do it.

On Fri, Oct 11, 2024 at 2:26 PM lewisakura @.***> wrote:

This isn't necessary in the supported Vencloud deployment since it runs
its own isolated Redis instance. Why do you need this?

...

[austere talon]

[charred monolith]

MomoMiles

[Vencord/Vencloud] New comment on pull request #45: Added Redis Password Input

For my case also, I run unraid, so i built the redis container separate from the vencloud container. I could've done it differently, but personally it allowed more control within the unraid panel that way.

leierlisa

[Vendicated/AliucordPlugins] New star added

[rugged spire]

why did i ever the initial message am i crazy

[brazen bone]

Probably

[still wasp]

Ironic

[charred monolith]

freddyspringtrap

[Vendicated/Vencord] Pull request opened: #2945 Update index.ts

[rugged spire]

wtf

i am confident that this will be closed as soon as a maintainer looks at it

[scenic brook]

I can only imagine they don't understand what a pull request is

[rugged spire]

the proof:

[cunning canyon]

monkey see a big green button appears after changed a file, monkey press

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #2945 Update index.ts

[charred monolith]

ssssobek

[Vendicated/Vencord] Pull request opened: #2946 feat(VoiceDownload): add native file picker

This PR adds a native file picker dialog from electron to VoiceDownload, removing the need to open a browser window.

Vendicated

[Vendicated/Vencord] New comment on pull request #2946: feat(VoiceDownload): add native file picker

this is iincredibly unsafe. but you can use DiscordNative.fileManager.saveWithDialog(data, filename); to download safely.

[limber skiff]

what's unsafe about it?

[rugged spire]

renderer gets to pick download path

[limber skiff]

makes sense

[charred monolith]

ssssobek

[Vendicated/Vencord] New comment on pull request #2946: feat(VoiceDownload): add native file picker

Sorry about that. Fixed now.

[austere talon]

full sandbox escape

arbitary file write

you can write malware to Discord.exe

[limber skiff]

yeah I didnt notice renderer was handling the file writing path

[glass jasper]

write malware into malware /joke

[desert cosmos]

good idea

[charred monolith]

AdalynBlack

[Vendicated/Vencord] Pull request opened: #2947 fix: pronoundb duplicate pronouns in normal mode

PronounDB had a bug for me on Vesktop where the compact mode pronouns would show up in normal mode, resulting in two sets of pronouns being visible. This change fixes that issue by explicitly checking if compact mode is enabled

[weary cave]

is there a way to tell vencord to disable certain plugins?

[fossil inlet]

dont think so

[weary cave]

ex, for legcord, I want to disable the ability to enable the arRPC plugin

[fossil inlet]

wait, why is it called legcord now?

[spark pivot]

delete it idk

[weary cave]

https://public.aspy.dev/000-DMCA-INFO/RECORDS/2024.10.10-Cease_and_Desist-ArmCord-redacted-1-1-1.pdf

[fossil inlet]

bit full of themselves

[weary cave]

I KNOW RIGHT

[dusk blaze]

maybe nuke plugin from Vencord.Plugins.plugins

idk

also is armcord unironically legcord now

[weary cave]

I dont want to fork or patch it husk

we just fetch the dist

[fossil inlet]

@weary cave guhhh

[weary cave]

bruh

is that already in there

[fossil inlet]

yes

[weary cave]

husk

[fossil inlet]

did you change your global to legcord?

[weary cave]

probably

one sec

[fossil inlet]

pr a fix or smth if it works

[weary cave]

yeah

[charred monolith]

SomeAspy

[Vendicated/Vencord] Pull request opened: #2948 armcord -> legcord

I'm telling you, I was really cooking with this one. Some might even call this THE best Vencord update.

[opaque silo]

where were u when armcor was kill

[jolly egret]

would've been more funny to just completely rebrand from ArmCord to armcord and just remove all references to the company

i don't think they would be very happy with that one tho

[austere talon]

should have rebranded to 💪cord

🦾cord

with the emoji

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[long stream]

i would say that it's dum but i do kinda see where they're coming from

i always thought armcord was an arm-native discord client or something

[fossil inlet]

i always knew armcord was a custom client, but thought it was arm only

[charred monolith]

websharik

[Vendicated/Vencord] Issue opened: #2949 [Bug] Plugin FakeNitro not working

Discord Account

No response

What happens when the bug or crash occurs?

Cant stream in nitro quality anymore.

What is the expected behaviour?

Success change stream quality.

How do you recreate this bug or crash?

Try to change stream quality.

Errors

No response

Request Agreement

• [X] I am using Discord Stable or tried on Stable and this bug happens there as well
• [X] I have read the requirements for opening an issue above

[charred monolith]

Vendicated

[Vendicated/Vencord] Issue closed: #2949 [Bug] Plugin FakeNitro not working

[charred monolith]

i3vie

[Vendicated/Vencord] New comment on pull request #2860: [Plugin] Hide a message clientside

bump

[sterile oak]

those situations are so rare and this could be easily abused

[still wasp]

Whitename discovers inspect element 2024 (colourised)

[brazen bone]

Why are you colorizing a whitename

[jagged cloak]

LOOOL

[haughty valley]

just block the person??

[limber skiff]

is this how pronouns in compact mode are supposed to look

[charred monolith]

Nuckyz

[Vencord:dev2] 1 new commit

248617d Rework PronounDB -> UserMessagesPronouns - Nuckyz

[limber skiff]

any suggestions?

(besides a readme ill add that later)

[charred monolith]

Nuckyz

[Vencord] Branch dev2 was force-pushed to `8cdacbb`

Compare changes

[charred monolith]

lilosn

[Vencord/Installer] New star added

[charred monolith]

Golonchy

[Vendicated/Vencord] New comment on pull request #2948: armcord -> legcord

Legcord

[woeful sable]

Legcord

[sterile oak]

what's armcord or legcord that everyone keeps yapping about

[glass jasper]

Legcord is the rebrand of armcord after they DMCA'ed by ARM

https://github.com/Legcord/Legcord

Issue #745

[fair forum]

They arent even related 💀 ARM LLC really looking to be a douche to anyone ong

[brazen bone]

Are they gonna sue the human body

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[jagged cloak]

before clan/whatever tag better imo

[bleak blaze]

@uneven needle doesn't open when in vc and clicking button

WebpackModule493683:2 Uncaught (in promise) TypeError: Cannot read properties of undefined (reading '_getRecipients')

you have to open a DM, first in order for it to open the sidebar chat otherwise it'll error out like that

[uneven needle]

I thought i handled that tf

[torpid vessel]

move it next to the time so it looks somewhat uniform

if in compact mode

[limber skiff]

I'll see

thanks for the suggestions

[torpid vessel]

eh

[limber skiff]

before the clan tag is probably the best option

[torpid vessel]

yop

[rugged spire]

is this seriously what compact mode looks like

[torpid vessel]

yop

[rugged spire]

i refuse to believe anyone uses this

[prime dew]

If you add stuff like badges that's going to be so messy

[torpid vessel]

compact mode is a disaster to begin with

just strip everything because compact mode is supposed to emulate irc

[glass jasper]

showBadgesInChat for compact mode

[prime dew]

Didn't know that

[rugged spire]

Show us the screenshot

[prime dew]

90% plugins stuff
10% actual message

[glass jasper]

🔥

[prime dew]

Vencord's new fork
Bloatcord

[torpid vessel]

omw

[rugged spire]

discord 2026:

[prime dew]

Love it

[bleak blaze]

we have gc, vc, dm, server channels but what about servers alone being added to sidebar?

so you can add an entire server and go through channels and select one and if the server, is selected add a back arrow so once selecting a channel you can go back

you’d obviously have to make adjustments to the width and height but it’d work out probably

(suggestion) ^

[uneven needle]

more trouble than it's worth

[charred monolith]

Hiro3328

[Vencord/Installer] New star added

[bleak blaze]

yeah you’re right. have you considered adding voice channel members to the right? so when you’re navigating you can see who’s in a call to mute / deafen / disable their camera

option to add a voice call i don’t know if that was implemented

[uneven needle]

use this?

[limber skiff]

@austere talon https://github.com/discord/discord-intl

they are cooking

[austere talon]

👀

[limber skiff]

they already have it in the client lol

[long stream]

ye it's been in the client for a while

this uses new intl

[limber skiff]

dope

[bleak blaze]

yeah i use that already

[uneven needle]

Why does it need to be added as sidebar then, its sidebarchat anyways

[fossil inlet]

has anyone else noticed whoReacted not updating untill you hover/click

[glass jasper]

yeah, but only in big servers of like 1000+

[austere talon]

you will fix

[fossil inlet]

?remind two weeks

[shut vine]

Alright @fossil inlet, in 2 weeks: …

[still wasp]

Vencord reference wtf

[bleak blaze]

i’m not sure to easily monitor activity states within the call, know who joins and leaves without having to hover over the avatar uh

easily access the voice chat channel?

when there’s multiple people in the call using what you mentioned it’ll be like (+8) rather than rendering all the users

[austere talon]

this is just the best way to have type safe definitions in typescript

I didnt invent this xd

many js build tools and such do similar things

because typescript doesn't allow you to type default exports and using a define function is more powerful because it allows you to use generics

for example vencord's plugin definition allows you to have custom members like functions. if you did const plugin: Plugin = {}, then

1. typescript would complain if you add new members
2. it wouldn't have the information that this member exists so you can reference it in another member function

[charred monolith]

Tassadaritze

[Vendicated/Vencord] Pull request opened: #2950 feat(Dearrow): add channel allow list

Adds a setting to the Dearrow plugin that allows specifying YouTube channel IDs of channels whose videos should not be dearrowed by default.

When an embed is altered as a result of this setting, toggling dearrowing on it won't save its new state as the default state in settings.

[charred monolith]

Brunoxd21

[Vendicated/Vencord] Issue opened: #2951 [Bug] Theres this bug that makes the cyberpunk 77 theme the default one...

Discord Account

.dead.

What happens when the bug or crash occurs?

The bug started bc i deleted the theme while it was activated i believe, i also put the theme newer vesion in there while that...

What is the expected behaviour?

IT will simply be like that, i tried re installing vencord, i tried uninstalling, clearing temp, restarting the pc and it lead to noth...

Vendicated

[Vendicated/Vencord] Issue closed: #2951 [Bug] Theres this bug that makes the cyberpunk 77 theme the default one...

[opaque silo]

can the Vencord category get a submenu for these buttons

[fossil inlet]

you can edit quickcss from the vencord toolbox

[opaque silo]

THERES A CAT ON MY SCREEN

[glass jasper]

That’s what I was about to say. The only ones useful there would be the top three and the one can be done from the toolbox.

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

VillainsRule

[Vendicated/Vencord] New comment on pull request #2672: add invite defaults

the vines grow 🗿

[charred monolith]

programminglaboratorys

[Vendicated/Vencord] Pull request opened: #2952 new plugin: StatusPresets

programminglaboratorys

[Vendicated/Vencord] New comment on pull request #2952: new plugin: StatusPresets

oh shit

programminglaboratorys

[Vendicated/Vencord] Pull request closed: #2952 new plugin: StatusPresets

[sterile oak]

ahm, don't mind me

someone delete this..

[jagged cloak]

whar

oh lmaoo

[fossil inlet]

Did you accidentally pr the entirety of eqicord

[jagged cloak]

happens to everyone at least once unless you educate on git lol

[fossil inlet]

Even if you know git, you’ll still forget sometimes

[jagged cloak]

trol

i do not know git i just search how to do whatever with git when i need it

[fossil inlet]

I don’t know git that well either I just use lazygit because I’m lazy

It’s so good

[limber skiff]

just an interactive rebase is already so powerful

u can do so much with it to fix issues

[brazen bone]

And you can do so much with it to cause bigger issues

[charred monolith]

thetoastedpotato

[Vencord/Vendroid] Fork created: thetoastedpotato/Vendroid

thetoastedpotato

[Vencord/Vendroid] Pull request opened: #20 Removed Vendetta as it's dead completely, added bunny/pyoncord

Vendetta is dead. No matter what anyone else says, It is dead.

[Vendroid] GitHub Actions checks action required on main

[gritty iris]

I only did this when I used GitHub website because my git install was broken and was 2 lazy to fix it lol

[charred monolith]

Seppy-Dev

[Vencord/Installer] New star added

Seppy-Dev

[Vencord/Vendroid] New star added

[charred monolith]

ofvv

[Vendicated/Vencord] Pull request opened: #2953 Add "To GIF" plugin

Adds a /gif slash command which will convert any image or url to .gif format

[opaque silo]

shouldn't this be in moreCommands

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #2953 Add "To GIF" plugin

Vendicated

[Vendicated/Vencord] New comment on pull request #2953: Add "To GIF" plugin

better done via a bot https://github.com/Vendicated/Vencord/blob/main/CONTRIBUTING.md#plugin-rules

[charred monolith]

galactic-org

[Vencord/Vendroid] Fork created: galactic-org/Galacticdroid

galactic-org

[Vencord/Installer] Fork created: galactic-org/Installer

[jolly egret]

Whats with all the forks

https://github.com/galactic-org/Installer/commit/791e61a8f835224c523071e21f228d0d16a13823#diff-25015a3bc3d26727834056ce5eb165af6fc8f8d5ee4142eb2a96872ec8fe501fR4 is that even allowed?

[wary relic]

mope, changing the license isnt

[hot hatch]

this is much funnier to me

[glass jasper]

We love when code skids violate licenses because they can’t read

[jolly egret]

anyway... vee/lewi/any of the maintainers wanna open an issue?

on both the installer and the mod lol

because they finally patched the mod too

[glass jasper]

prolly vee will when they wake up or whatever

[hot hatch]

also not to mention his persona looks kinda sus

gh account created a week ago
created 3 orgs
followed 148 people
literally faked his blog posts creation date on his site 😭 (<t:1726010673:f>)

oh wait

wrong timestamp

lmfao

[glass jasper]

prolly a botted account

[hot hatch]

mhm

[jolly egret]

seems a bit unusual for everything to be botted

[glass jasper]

its what code skids do, they’ll bot anything

[jolly egret]

they have actual plugins in the tree

[glass jasper]

prolly skidded from somewhere/someone else is the thing

[jolly egret]

It gets worse while i'm looking over this

they changed all the developers in the client mod to themselves

[glass jasper]

mooncord for example, they have “noMouseNavigation” and “2FaOnServers” but its stolen from @spring gorge

They just took their plug-ins, slapped to their name on it and claimed it as their own

[hot hatch]

not so open-source heart

[somber thorn]

man some people suck

[glass jasper]

aint i right @summer surge

^they are the code skid that stole them

[jolly egret]

no way this person is human

discord.gg/example 🔥

@obtuse vessel

its a 2016 discord account

https://github.com/galactic-org/Galactic/blob/94145ac7ef5ee1053fb8e8e68bbd5c15592b5661/src/constants.ts#L34-L39

[grave mango]

constants.ts: Lines 34-39

export const Developer = /* #__PURE__*/ Object.freeze({
    Zach: {
        name: "Zach J Murphy",
        id: 238034217580232704n
    }
} satisfies Record<string, Dev>);

[glass jasper]

So stolen, or bought it

[jolly egret]

guessing so

Anyway hope this shit stain of a project gets taken down this is pure evil

if it was just the license headers and they actually fixed it i wouldn't care but you can't just remove everyone else from the developers list

[glass jasper]

sadly knowing GitHub, probably not

They don’t really care about this kind of stuff

[jolly egret]

well... right now its a license violation and they usually are quite good with that

[glass jasper]

report it

I KNEW I RECOGNIZED THIS PERSON
Issue #187
Pull Request #186

[jolly egret]

lmao

[austere talon]

i opened an issue

but also do not harass them like https://github.com/galactic-org/Galactic/issues/1 thats just cringe

i think they just don't know better

[jolly egret]

thanks vee

wtf i looked at it like 10 seconds ago and the repo is gone

did they make them private?

[glass jasper]

Yeah thx, im sorry i wont do that again

[glass jasper]

Github doesnt let you, if its an actual fork

[jolly egret]

oh yeah

forgor if the main repo was though

the installer is gone too so its deleted, right?

[austere talon]

they took it all private

probably to have time to fix it

valid

cant complain

i've seen this guy before

i really think he just didnt know better

else he wouldnt have edited the gpl text 😭

i still have to be strict and enforce the license

not just for myself but also for everyone else who contributed, especially cause he stripped out all plugin authors

honestly even without knowledge about how licenses works, removing all plugin authors and claiming you're the author kinda is just fucked up

[jolly egret]

Yeah fucking up the headers is kinda just clueless behaviour but removing all the plugin authors is just fucked up

[jolly egret]

The org is gone and they removed their pfp on github

i sure wonder what they are doing

[rugged spire]

[spring gorge]

i didn't make noMouseNavigation, but i appreciate the recognition for my other thing lol 🫡

[spring gorge]

cleaning up iden? funny asf lol

[opaque silo]

removing pfp is so emo lmao 😭

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__FakeNitro (had no effect):__**
ID: `938353`
Match: ```
/renderAttachments\(\i\){let{attachments:(\i).+?;/

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

[glass jasper]

rip ig we aint updating tonight

[jolly egret]

uh oh

can discord please stop killing fake nitro

[fossil inlet]

guhh

time to fix

[rugged spire]

on github its not really, on discord it totally is

[shut vine]

@fossil inlet, <t:1728624121:R>: fix companion erroring when extracting a patch with all:true

[fossil inlet]

from what ive done, it seems like discord has moved some things around in their code

cant be bothered to fix it

theres also a find that's broken that didnt get reported

[fossil inlet]

got it working but it feels wrong

||ping me if you want to see my shitty code||

||its also pushed to a branch on my fork if I don't respond||

[rugged spire]

https://tenor.com/view/sound-the-car-alarm-cat-gif-9895924581726852336

[rugged spire]

you should make PR then

[charred monolith]

mantikafasi

[Vendicated/Vencord] Pull request opened: #2954 fix misinformation

[still wasp]

@rugged spire you did this

[rugged spire]

mantika a real BetterUploadButton hater

[limber skiff]

I'll fix the patches if no one does

gotta merge some stuff to main anyways

[glass jasper]

ViewIcons crashing on canary btw

[limber skiff]

send error

they really came back from break days to break 25 patches

[glass jasper]

im not at my computer pookie

[limber skiff]

neither am I

😔

don't worry about it

[glass jasper]

assuming it might be what he’s talking about here ^

[jolly egret]

such is the maintainer life

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #2954 fix misinformation

Vendicated

[Vendicated/Vencord] New comment on pull request #2954: fix misinformation

BetterUploadButton

[austere talon]

did they break everything again

[charred monolith]

mantikafasi

[Vendicated/Vencord] New comment on pull request #2954: fix misinformation

better upload button is not standart behaivour

[crude hearth]

and tbh most people probably dont use it

[limber skiff]

nah only a little

I was being sarcastic

[fossil inlet]

https://github.com/sadan4/Vencord/commit/5cea351ff9266ec80bc3bef69f37bb23943552cf

Shitty being the key word

Need to update types and finds

[jolly egret]

tbh the default and more popular behaviour should be mentioned

[brazen bone]

Is ImageModal the one when you click on an image?

[fossil inlet]

Yea

[jolly egret]

at least in my opinion

[charred monolith]

Vendicated

[Vendicated/Vencord] New comment on pull request #2954: fix misinformation

oh true i thought it was the reverse, as in you have the plugin enabled and are complaining it's wrong for you

[limber skiff]

WHY IS THERE A FIND INSIDE A COMPONENT

[fossil inlet]

Testing and haven't made it lazy yet

shitty fix
look inside
shitty code

[limber skiff]

lol

[glass jasper]

[charred monolith]

MiguVT

[Vendicated/Vencord] New comment on pull request #2882: New Plugin: DayNight Switcher

@Vendicated any update?

MiguVT

[Vendicated/Vencord] New comment on pull request #2882: New Plugin: DayNight Switcher

I was using it for 1 month and no issues

programminglaboratorys

[Vendicated/Vencord] New comment on pull request #2882: New Plugin: DayNight Switcher

@Vendicated any update?

be patient, you pr'ed, you forget about it. pinging ven won't get you anywhere

MiguVT

[Vendicated/Vencord] New comment on pull request #2882: New Plugin: DayNight Switcher

@Vendicated any update?

be patient, you pr'ed, you forget about it. pinging ven won't get you anywhere

I dont forgotten it, i was waiting one month without reply about this contribution and my friend wants this feature, but its ok, i will wait more, tysm for your reply

[sterile oak]

is she making this about herself?

[glass jasper]

They waited a month. I’ve been waiting half a year. People have been waiting longer. You can wait.

[jolly egret]

its besides the point, not everyone wants to use dev builds forever

its kinda expected that you get impatient at some point

[sterile oak]

we should list the five stages of prs

last one is depression for sure

[glass jasper]

1st 2nd 3rd 4th are also depression

[opaque silo]

am I insane why is day night switcher needed

just set theme to auto and have your system do the switching

[austere talon]

ya

[fossil inlet]

yup

[charred monolith]

imjustprism

[Vendicated/Vencord] Pull request closed: #2853 messageClickActions: Added message Pin/Unpin function

[jolly egret]

The changes hit stable btw

[fossil inlet]

Guhh

I will fix when I get home

[limber skiff]

ehh no need to hurry

I'll only push later

[charred monolith]

ssnob

[Vendicated/Vencord] Pull request opened: #2955 feat(plugin) AutoVX Links

useful for sharing links that don't automatically embed such as tiktok and twitter

jamesbt365

[Vendicated/Vencord] New comment on pull request #2955: feat(plugin) AutoVX Links

ssnob

[Vendicated/Vencord] Pull request closed: #2955 feat(plugin) AutoVX Links

[jolly egret]

they deleted their github account

[jagged reef]

lol this plugin is definitely chatgpted judging by the amount of random botty comments

[jolly egret]

new programmers have that problem too

though... i can't even tell you whats going on here there are multiple easier ways of doing what they did

[fossil inlet]

@limber skiff been taking a look at the imageModal thing
cant figure out how to get it to display an image without a height and a width

||oops double ping||

[charred monolith]

shaunbharat

[Vencord/Vendroid] New star added

[glass jasper]

They also changed their name on discord

[jolly egret]

bruh

what plugin is that that lets you see the integrations without sharing a mutual?

[glass jasper]

Vp showConnections

[nimble pendant]

ShowConnections

Show connected accounts in user popouts

Authors

TheKodeToad

[frail sky]

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__FakeNitro (had no effect):__**
ID: `938353`
Match: ```
/renderAttachments\(\i\){let{attachments:(\i).+?;/

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__FakeNitro (had no effect):__**
ID: `938353`
Match: ```
/renderAttachments\(\i\){let{attachments:(\i).+?;/

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

[rugged spire]

@fossil inlet you will PR your fix

[fossil inlet]

see my previous message

#👾-core-development message

[rugged spire]

oh

why dont you just PR the FakeNitro attachments fix?

inb4 "I didn't fix that"

[fossil inlet]

@rugged spire it does fucky things for banners @placid wave as an example

[rugged spire]

i might be a dumbass

[fossil inlet]

||and other things that arent squares||

[rugged spire]

i tried to imagezoom on that image itself

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #2956 Fix: FakeNitro

fixes the broken fake nitro patch

(the object got nested, so it is no longer the top level)

[fossil inlet]

@rugged spire you love

[opaque silo]

this is why we need patch ai (real)

[fossil inlet]

what?

[opaque silo]

ai to fix patches .,.,,..,

[fossil inlet]

oh

[opaque silo]

(it will be nin0 locked in a cage)

[glass jasper]

itll kill nin0 too

[rugged spire]

https://cdn.discordapp.com/attachments/1024286218801926184/1291576574453354608/togif.gif

[charred monolith]

forivall

[Vencord/Vendroid] New star added

[scenic brook]

[fossil inlet]

wait till you find out about lazy loaded modules

[scenic brook]

Hmm true

Oh well

[sterile oak]

force load all modules

[bleak blaze]

pro

[limber skiff]

pronouns before clan now

[charred monolith]

Nuckyz

[Vendicated/Vencord] New comment on issue #1749: Plugin README images thread

UserMessagesPronouns

Nuckyz

[Vencord] Branch dev2 was force-pushed to `229ec9b`

Compare changes

[limber skiff]

yeah this image modal change is pretty annoying to fix

[fossil inlet]

Any progress

[limber skiff]

havent tried yet

[dusk blaze]

what does kakerlakenplätzchen mean

[brazen bone]

I would guess it means cockroach palace

Google translate says it's cookies, not palace though

[austere talon]

cookies

well technically it would also mean place

[limber skiff]

I think it not working with a set width and height is discord fault lol

it's supposed to support

L is whether width and height exists

but when rendering the one with "img" tag it simply shows nothing

where is it 😭

it's the css breaking it

LOL this is definitely not a good fix

[fossil inlet]

What module is that?

[limber skiff]

341176

[fossil inlet]

Alr

[limber skiff]

it's just the css shitting it up

[fossil inlet]

Nice to know I wasn't going crazy the whole time

[limber skiff]

I dont know how to fix tho

typing items is a pain in the ass

[scenic brook]

Seems pretty easy to me

[limber skiff]

😭

[fossil inlet]

@limber skiff is it worth making a patch for this to fix it, it is causing crashes right now

[limber skiff]

view icons?

crash handler is catching it tho

[fossil inlet]

and all other ImageModal things

[fossil inlet]

yea, but its still annoying for people

[limber skiff]

if you find a way to fix

because it's just a css problem

[fossil inlet]

oh, what css fixes it

you can just pass a class

[limber skiff]

of this element

play with it in devtools ur gonna see

[fossil inlet]

horror

[fossil inlet]

@limber skiff I FIXED IT

FINALLY

I FUCKING HATE CSS

[limber skiff]

lmao

how did u do it

[fossil inlet]

position: inherit

they had it set to absolute

which fucked something up

[limber skiff]

do things not get huge?

like the vencord icon

[limber skiff]

haha

nice

[fossil inlet]

is that huge?

[limber skiff]

nah

that's perfectly normal

did you add your own class or edit css

[fossil inlet]

you need a css class with position: inherit !important;

if you want this to be the fix

where would be the best place to put this class

[limber skiff]

ugh I have no idea

[fossil inlet]

do i just import a css file?

[limber skiff]

does that work?

[fossil inlet]

thats how all the plugins do it

[limber skiff]

yes but I mean outside a plugin

place it near discord.tsx

just leave it to me regardless tho

I'll commit later and add you as co author

[fossil inlet]

alr

[limber skiff]

I got everything done just missing the css fix

[fossil inlet]

i also have a pr for the fakenitro

do you want me to close that

[limber skiff]

ya

oh

if you dont mind sure

[rugged spire]

has that been fixed already

[limber skiff]

I would like do the patch in a different way too

[fossil inlet]

alr

[limber skiff]

thanks a lot regardless

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request closed: #2956 Fix: FakeNitro

[fossil inlet]

np

@limber skiff guhhh

[limber skiff]

uhh

[fossil inlet]

a patch was also needed with the css fix

there was bad logic + bad css

[limber skiff]

huh

what bad logic

[fossil inlet]

guhh gtg now

will explain when i get back if you havent solved it yet

[jolly egret]

are you still working on a fix 😭

[charred monolith]

Charlignon

[Vendicated/Vencord] New comment on issue #1271: [Feature Request] Middle mouse button scrolling

Hello ! TL;DR the need for such a plugin exist and is not negligible, so I would suggest to reopen the issue :)

Middle click auto-scroll does exist on Chromium/Electron, but it is enabled only on Windows. Mac and Linux user can use the --enable-blink-features=MiddleClickAutoscroll flag when start their browser/app, but it is considered a bad practice to use these flags....

[rugged spire]

why is it being discussed in a 16 months since last active thread

[fossil inlet]

@limber skiff from what i can tell now, with the modals fixed, there were two issues.

one: discord sets the position to absolute on all image modals, breaking it when no height/width is provided

two: discord does not pass the height or width if both are not there

[limber skiff]

what's the issue on second

[fossil inlet]

second just makes it really big and not respect any height/width if you dont pass both height and width

there is a simple patch for the second

[limber skiff]

it's just that boolean L right

[fossil inlet]

yea

i changed it from this

, L = !(null == p || 0 === p || null == I || 0 === I);

to L = !((null == p || 0 === p) && (null == I || 0 === I));

or you could pass style props to the other image modal

[limber skiff]

where are we passing only one

and why can't we pass both

seems wrong to just do one?

[fossil inlet]

we dont know the size of the image

so we set the height to a sane number

if we set both, we can ruin the aspect ratio

[limber skiff]

yk at this point we could just make L always true

[fossil inlet]

its a patch either way

figure id keep as close as possible

[limber skiff]

I'll see

[frail sky]

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__ShowHiddenChannels (had no effect):__**
ID: `557135`
Match: ```
/(?<=getCurrentClientVoiceChannelId\((\i)\.guild_id\);return)/

FakeNitro (had no effect):
ID: 938353
Match: ```
/renderAttachments(\i){let{attachments:(\i).+?;/

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__ShowHiddenChannels (had no effect):__**
ID: `557135`
Match: ```
/(?<=getCurrentClientVoiceChannelId\((\i)\.guild_id\);return)/

FakeNitro (had no effect):
ID: 938353
Match: ```
/renderAttachments(\i){let{attachments:(\i).+?;/

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

[fossil inlet]

SHC time 🎉

[fossil inlet]

its an easy fix

                {
                    // Do not show confirmation to join a voice channel when already connected to another if clicking on a hidden voice channel
                    match: /(?<=getBlockedUsersForVoiceChannel\((\i)\.id\);return)/,
                    replace: (_, channel) => `!$self.isHiddenChannel(${channel})&&`
                },

[charred monolith]

NumericalGandalf

[Vencord/Installer] New star added

[limber skiff]

okay I will fix stuff at maximum today

already took too long :)

[fossil inlet]

[jolly egret]

lets grow

[fossil inlet]

@limber skiff let me know when you fix the image-modal things, I'm curious how you'll fix it in the end

[limber skiff]

aight

[charred monolith]

iakzs

[Vendicated/Vencord] Pull request opened: #2957 New plugin: WeatherRPC, a RPC to show the temperature in a city.

Hello!

I just did this plugin which lets you show the temperature and chance of raining on your RPC. All using open sourced and free APIs.

(Sorry for the different sizes of the images 🙏 )

If there's any needed...

[fossil inlet]

hiiiii i really want a niche plugin that doxxes me

im sure they put effort into it, but this is just a stupid idea

[jolly egret]

why would anybody want that wtf

straight up just doxxes you for no reason

Not even useful for IRL friends because you're very likely to just be in the same area and why the weather of all things?

Like if you want to doxx yourself use this as a 3rd party plugin why would this be official 😭

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request closed: #2957 New plugin: WeatherRPC, a RPC to show the temperature in a city.

Vendicated

[Vendicated/Vencord] New comment on pull request #2957: New plugin: WeatherRPC, a RPC to show the temperature in a city.

this can easily be done with an external progam, no plugin is needed

iakzs

[Vendicated/Vencord] New comment on pull request #2957: New plugin: WeatherRPC, a RPC to show the temperature in a city.

yeah i know, i actually did it with python (it's on my profile) but i was thinking of having it directly on discord instead of running another thing every time.

MBear227

[Vendicated/Vencord] New comment on pull request #2740: feat(plugin): UnreadCountBadge

I noticed right clicking or click-and-holding a channel in the channel list will add the unread count even if you never loaded the channel, maybe this could be used to make the count work for unloaded messages?

[rugged spire]

[rugged spire]

@night creek may i introduce you to the #1256395889354997771 channel where niche things go

[glass jasper]

I think the only thing that plug-in is missing is some sort of detection to tell whether or not your live or sharing your screen and then the info would hide itself other than that, it would be good for #1256395889354997771 heck I might even use it

[rugged spire]

why would that make a difference?

[glass jasper]

so you dont

[rugged spire]

clueless

you know thats an issue if you aren't streaming

just don't set the location too accurate

[glass jasper]

https://media.discordapp.net/attachments/1199708766384427102/1245575918731395183/caption.gif

[frail sky]

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__ShowHiddenChannels (had no effect):__**
ID: `557135`
Match: ```
/(?<=getCurrentClientVoiceChannelId\((\i)\.guild_id\);return)/

FakeNitro (had no effect):
ID: 938353
Match: ```
/renderAttachments(\i){let{attachments:(\i).+?;/

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__ShowHiddenChannels (had no effect):__**
ID: `557135`
Match: ```
/(?<=getCurrentClientVoiceChannelId\((\i)\.guild_id\);return)/

FakeNitro (had no effect):
ID: 938353
Match: ```
/renderAttachments(\i){let{attachments:(\i).+?;/

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

[jolly egret]

now showhiddenchannels have a broken patch? incredible

[fossil inlet]

#👾-core-development message

not a breaking change

[rugged spire]

discord will bomb it in 3 months anyways

[glass jasper]

the pr it gang

[jolly egret]

please keep gatekeeping fixes we love it 😋

[glass jasper]

ong

[rugged spire]

i hate discord-types

so out of date

[jolly egret]

I wonder if its worth maintaining a fork

[fossil inlet]

theres a pr for that

[jolly egret]

neat

[charred monolith]

fres621

[Vendicated/Vencord] Pull request opened: #2958 new plugin FixImagesQuality

Fix FakeNitro patch for rendering FakeStickers
This patch might be a little sensitive but it doesn't currently conflict with any other code in the module and I don't think it will
An alternative less sensitive patch would be a lookbehind for the function's name "renderAttachments"

To test this patch enable these 3 options and send a FakeNitro's FakeSticker

If the patch applied correctly it should ...

[inland fable]

RAHHHH

[jolly egret]

new plugin FixImagesQuality
Is a one line change to FakeNitro

Did you write that with AI? 😭

[fossil inlet]

github default pr title is the earliest commit to the branch you are pr-ing to

by default that is the main branch

the last commit on dev is new plugin fix images quality

even if you are pr-ing to the dev branch

[inland fable]

the title did itself

WHAT

[fossil inlet]

it does not change the title

[inland fable]

I DIDNT EVEN NOTICE

MY COMMIT TITLE WAS FIX FAKENITRO PATCH

[jolly egret]

It should be the one of the commits that you are PRing (either first or last I can't remember)

it shouldn't be anything to do with what branch you are targeting or their commits

[inland fable]

anyway i fixed title in the pr

[fossil inlet]

has anyone ever seen that before

[inland fable]

LOVE

[rugged spire]

basically React DevTools will explode at random

close devtools and reopen

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #2959 Fix: show hidden channels patch

[charred monolith]

wagyourtail

[Vendicated/Vencord] Pull request opened: #2960 feat(BetterFolders): add folder nesting & multi-column mode.

I have implemented 2 new modes for better folders.
the first simply makes each folder open in its own column:

and the nested mode actually implements a tree-like structure:

for the nest mode, folders are simply parsed by name and split on /, so on an unmodified client, the folders would simply be displaye...

[rugged spire]

wait this is fire?

in theory?

[mortal marlin]

yeah. tho the only reason I actually decided to implement it is because I'm in way too many servers

[charred monolith]

NotPiny

[Vendicated/Vencord] Pull request closed: #2843 Prevent preview message button from appearing on chat input commands

[jolly egret]

just move the servers you want to the top zzzzz

unless you actually actively use like 50 servers? (wtf is wrong with you)

[dusk blaze]

fire

[limber skiff]

view icons working as intended

totally not stretched

[limber skiff]

@fossil inlet doesnt really work properly without setting both height and width now lol

ughh wtf did they do

[charred monolith]

Nuckyz

[Vencord:dev] 1 new commit

4e89352 Fix ShowHiddenChannels & FakeNitro broken funct... - sadan4

Nuckyz

[Vendicated/Vencord] Pull request closed: #2959 Fix: ShowHiddenChannels & FakeNitro patch

Nuckyz

[Vendicated/Vencord] New comment on pull request #2958: Fix FakeNitro patch for FakeStickers

Done by https://github.com/Vendicated/Vencord/commit/4e893527583a8ec2cdfb3d815b9d49851e7b6614, thanks regardless!

Nuckyz

[Vendicated/Vencord] Pull request closed: #2958 Fix FakeNitro patch for FakeStickers

Nuckyz

[Vencord] Branch dev2 was force-pushed to `58c3032`

Compare changes

Nuckyz

[Vencord:dev] 1 new commit

58c3032 Rework PronounDB -> UserMessagesPronouns - Nuckyz

[limber skiff]

img zoom patch fix

{
    find: ".contain,SCALE_DOWN:",
    replacement: {
        match: /\.slide,\i\),/g,
        replace: `$&id:"${ELEMENT_ID}",`
    }
},

@fossil inlet okay so basically the issue is:

when an image doesnt have width and height it uses the plain img element, which the css makes the image disappear. fixing the css and changing position to inherit has the issue of images being too big (from my testing)

and then, patching the boolean check for if an image has width and height to use their other component has the same issue with css, or if you do put a width or height (not both) then the image gets fucked up

(ImageZoom also doesnt work properly when it uses the plain img element)

so we need to fix images getting fucked up if you miss a height or width, fix them being too big, and also make it always use the custom component

(they bullied us on this one)

here's a patch if you wanna experiment with it

[cunning canyon]

imagezoom doesnt work when you switched image in carousel too

[charred monolith]

nin0-dev

[Vendicated/Vencord] New comment on pull request #2954: fix misinformation

what if the description changed based on if you had betteruploadbutton enabled 🚀

[rugged spire]

fuck_you_discord.patch

[fossil inlet]

I will have to retry my fix, that wasn’t what happened when i tried it last

Even if that is the case

I can think of another way to easily patch it

[charred monolith]

KrstlSkll69

[Vendicated/Vencord] New comment on pull request #2954: fix misinformation

what if the description changed based on if you had betteruploadbutton enabled 🚀

[fossil inlet]

@limber skiff my fix works fine for me

[limber skiff]

which

[fossil inlet]

also
in what file would i put the needed patch

[fossil inlet]

for ImageModal

[limber skiff]

which fix

[fossil inlet]

the patch + css

[limber skiff]

send here

ill test again later

[fossil inlet]

        {
            find: "SCALE_DOWN:",
            replacement: {
                match: /!\(null==(\i)\|\|0===\i\|\|null==(\i)\|\|0===\i\)/,
                replace: (_, width, height) => `!((null == ${width} || 0 === ${width}) && (null == ${height} || 0 === ${height}))`
            }
        }

you could also patch the img component with a style prop

that has the width and/or height

[charred monolith]

DrippingMellow

[Vencord/Installer] New star added

[frail sky]

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

[glass jasper]

RIP imagezoom

[jolly egret]

viewicons and stuff are still borked

[glass jasper]

On main yeah

This ran on dev

They are fix on dev

[jolly egret]

i haven't been keeping up

[rugged spire]

time to merge in dev

[glass jasper]

I try to fix image Zoom, and that other thing first and then yeah

[fossil inlet]

view icons is still broken on dev

[bleak blaze]

it’s been almost a week now and viewicons, still not resolved yet

height and width go wild

[swift fjord]

be patient

[bleak blaze]

i am

[rugged spire]

@limber skiff I've just been trying this out today and I've found a few things that feel weird about the plugin
I wouldn't be surprised if these existed in the PronounDB plugin too

1. The tooltip showing "Pronouns" feels off-center, because it includes the •
2. Pronouns are not cached by the plugin itself, so every time the client is restarted, pronouns do not show until the user profile is opened, defeating the point of the plugin

1 is trivial to solve, the second isn't so much. How do you propose solving that? Cache in DataStore every time it's rendered, if Discord can't provide pronouns then load from cache?

WHAT ARE YOU

must be for those annoying particles

[limber skiff]

1 is weird because it's all inside a span

idk about 2 tho

[rugged spire]

does this look right

[limber skiff]

huh

oh so you mean the tooltip should not include the •

[rugged spire]

Yes

[limber skiff]

put it inside a div with the classes

and then both spans there

without the classes

and see if it works

check compact too

[rugged spire]

I never actually explained this but

I'm using timestampInline for the spacing

[rugged spire]

oh what i've got looks really wrong on compact mode

why?

ah

i see

the timestamp class itself adds this massive margin on both sides

should the • even be used in compact mode?

[limber skiff]

yeah

[rugged spire]

is that how it's always been?

oh also

how about server profiles?

[limber skiff]

wdym

[rugged spire]

server specific pronouns aren't considered

[limber skiff]

oh

that needs to be fixed

[rugged spire]

it just looks like pronoundb code was ripped out without even refactoring away from that system

[charred monolith]

jamesbt365

[Vendicated/Vencord] New comment on pull request #2954: fix misinformation

Any interest in reopening and merging this? The default behaviour (left click) without any plugins in my opinion should be listed as more people are not going to be using BetterUploadButton than are using the plugin.

mantikafasi

[Vendicated/Vencord] New comment on pull request #2954: fix misinformation

@Vendicated merge

20 Eki 2024 Paz 17:43 tarihinde jamesbt365 @.***> şunu
yazdı:

Any interest in reopening and merging this? The default behaviour (left
click) without any plugins in my opinion should be listed as more people
are not going to be using BetterUploadButton than are using the plugin.

—
Reply to this email directly, view it on GitHub
https://github.com/Vendicated/Vencord/pull/2954#issuecomment-2425020666,
or unsubscribe
<https://github.com/n...

[jolly egret]

yeah vee MERGE (best way to get something merged is to to demand it)

[torpid vessel]

rare

[dusk blaze]

@crude hearth WHY İS İT TÜRK

[crude hearth]

idk

[charred monolith]

mouse0017782

[Vencord/Vendroid] New comment on pull request #20: Removed Vendetta as it's dead completely, added bunny/pyoncord

I would approve this issue but sadly I'm not a maintainer, good luck.

[fossil inlet]

@limber skiff have you fixed image zoom yet?

[limber skiff]

ya

[charred monolith]

nin0-dev

[Vencord/Vendroid] Pull request review submitted: #20 Removed Vendetta as it's dead completely, added bunny/pyoncord

nin0-dev

[Vencord/Vendroid] New review comment on pull request #20: Removed Vendetta as it's dead completely, added bunny/pyoncord

love accidental uppercase Or

[charred monolith]

Myrkie

[Vendicated/Vencord] Pull request opened: #2961 add keybind option to messageClickActions delete action.

adds 3 more key bind override option for the messageClickActions plugin for deleting while clicking.

the following key binds have been added

1. Backspace
2. Delete
3. Control
4. Shift

[charred monolith]

ScruffyEspy

[Vendicated/Vencord] Issue opened: #2962 [Bug] ViewIcons is not working properly

Discord Account

.serious_person_not_found

What happens when the bug or crash occurs?

The bug happens then i wanna see someone pfp or banner but instead of image there appear grey rectangle

What is the expected behaviour?

I expect Vencord/Discord to makes avatars and banners in user profiles clickable and being able to download them

How do you recreate this bug or crash?

...

nin0-dev

[Vendicated/Vencord] New comment on issue #2962: [Bug] ViewIcons is not working properly

this issue is known and is being fixed. also, do not open issues without permission of a support server moderator

[charred monolith]

Vendicated

[Vendicated/Vencord] Issue closed: #2962 [Bug] ViewIcons is not working properly

[fossil inlet]

?remind 23.5 hours open link on stickers

[shut vine]

Alright @fossil inlet, in 23 hours and 30 minutes: open link on stickers

[frail sky]

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

[charred monolith]

PoolloverNathan

[Vencord/Vendroid] Pull request review submitted: #20 Removed Vendetta as it's dead completely, added bunny/pyoncord

PoolloverNathan

[Vencord/Vendroid] New review comment on pull request #20: Removed Vendetta as it's dead completely, added bunny/pyoncord

making it one click to apply

You are likely better off using [Aliucord](https://github.com/Aliucord/Aliucord) or [Pyoncord](https://github.com/pyoncord/Bunny) that are proper mods of the old and new Discord Android app respectively.

[charred monolith]

lewisakura

[Vencord/Vendroid] Pull request closed: #20 docs: replace vendetta reference with pyoncord

lewisakura

[Vendroid:main] 1 new commit

ab4e56f docs: replace vendetta reference with pyoncord ... - thetoastedpotato

[Vendroid] build failure on main

[Vendroid] GitHub Actions checks failure on main

[Vendroid] GitHub Actions checks success on main

[Vendroid] build success on main

[fossil inlet]

is it possible to specify the location vencord is loaded from in the command line for discord desktop

[topaz thistle]

Anyone here aware of discord desktop rendering video calls with some cursed electron feature or do they just use plain html elements as the web version does?

[rugged spire]

There's a load of references to this "electron video" thing in media engine and related places so it's highly likely that is what's happening

[topaz thistle]

Is that some electron feature that allows to render raw-data from native into the webview?

[charred monolith]

AU518987077

[Vencord/Vendroid] New star added

[shut vine]

@fossil inlet, <t:1729466835:R>: open link on stickers

[frail sky]

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

Bad Starts

None

Discord Errors

None

[opaque silo]

not again 😭

[jolly egret]

we hadn't fixed them yet !!

[charred monolith]

Rairof

[Vendicated/Vencord] New comment on pull request #2948: armcord -> legcord

Legocord!

korbosoft

[Vendicated/Vencord] New comment on pull request #2948: armcord -> legcord

lgtm. i think ven should NOT look at the 2nd commit

korbosoft

[Vendicated/Vencord] New comment on pull request #2948: armcord -> legcord

or the third one

[charred monolith]

Rairof

[Vendicated/Vencord] Pull request review submitted: #2948 armcord -> legcord

Looks good <3

[limber skiff]

@fossil inlet can you put up together our tests and pr a fix

I'm busy to able to find something that works correctly and put it together

I'll still review and we can do necessary changes based on it

if you search for imagezoom in this channel you can find a fix for it's patch

but ideally view icons should work with imagezoom too

use the patch file I sent here as a starting point

[fossil inlet]

Yea I'll throw something together

[crude hearth]

WHY IS IMAGE ZOOM STILL BROKEN

@austere talon fix or I will no longer donate to you

[fossil inlet]

im pr'ing soon

you love

[crude hearth]

be faster

[fossil inlet]

@limber skiff @crude hearth pr incoming

[crude hearth]

GOOD

[rugged spire]

wow

did you know your arRPC server isn't running?

you are insane for having this toggled on

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #2963 Fix: ImageModals and ImageZoom

the ImageModal still needs to be typed

not sure if that is the best/correct place to put the patch needed to fix it, but image modal is used by a few plugins

[crude hearth]

@austere talon merge

[jolly egret]

megre

[crude hearth]

I think it looks good

yes you should merge

no need to review

[fossil inlet]

[rugged spire]

i don't like the fact a whole "API" was implemented for this

even though it was just a patch fix

[fossil inlet]

where else would i put the patch

seriously

[rugged spire]

idk

[fossil inlet]

imagemodals are used by more than one plugin

[rugged spire]

yop

[fossil inlet]

and without the patch, you cant set a min height or min width

[rugged spire]

husk

was anything actually setting the min height/width

[fossil inlet]

yes

[rugged spire]

what

[fossil inlet]

for good reason

[rugged spire]

where

[fossil inlet]

view icons

[rugged spire]

ah

thanks for explaining to me like i am stupid (i am a bit)

[jolly egret]

fwiw it was a nasty breakage in comparison to normal ones, i think its fine

[fossil inlet]

@rugged spire testing more

[jolly egret]

it failed the tests!!!

[fossil inlet]

and i need to add a size limit to server info as well

its massie without it

[rugged spire]

serverinfo needs a rewrite anyway

should i redo serverinfo to be more useful

[crude hearth]

what if imagezoom got merged instead

[bleak blaze]

Yes

Instead of pressing a button make something when hovering over the icon it’ll display information

similar to betterdiscord

[rugged spire]

[bleak blaze]

it’s way better than always manually pressing button

[bleak blaze]

trust trust

[austere talon]

how

[rugged spire]

make some things less prominent and add stuff like features + some other values

i'm busy doing something called making my laptop useful again though

[jolly egret]

UnlockedAvatarZoom is borked too idk if this specifically fixes that

Will give it a little test if i remember too later

[long stream]

wait my plugin broke as well?

nooo

[austere talon]

[jolly egret]

yep!

actually nvm, don't understood what made it not work for me, i tried after a user reported it and it wasn't working properly but i guess it is

I'm guessing i am also capable of user error

[fossil inlet]

LOVE

@limber skiff i swear im going crazy

[long stream]

my plugin is still going strong

[jolly egret]

gonna bribe discord devs to break it brb

[long stream]

smh

[glass jasper]

They probably do it for free

[frail sky]

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__OpenInApp (had no effect):__**
ID: `740605`
Match: ```
/\i\.\i\.isProtocolRegistered\(\)(.{0,100})window.open/g

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

findComponentByCode(".mutualFriendItem]")

Bad Starts

None

Discord Errors

None

[jolly egret]

more breakage

[frail sky]

Bad Patches

ImageZoom (had no effect):
ID: 288229
Match: ```
/return.{1,200}.wrapper.{1,200}src:\i,/g

**__OpenInApp (had no effect):__**
ID: `740605`
Match: ```
/\i\.\i\.isProtocolRegistered\(\)(.{0,100})window.open/g

Bad Webpack Finds

findComponentByCode(".MEDIA_MODAL_CLOSE", "responsive")

findComponentByCode(".mutualFriendItem]")

Bad Starts

None

Discord Errors

None

[austere talon]

the new modal stuff seems like a bitch to work with

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #2964 Fix: MutualGroupDMs

making a seprate pr because the other one might take a while and this was an easy fix

[fossil inlet]

the open in app fix looks easy

i just dont know how to use it to test it

[fossil inlet]

LMFAO

[fossil inlet]

ignore that

its just a hardcoded true

when it should be false

[charred monolith]

Vendicated

[Vencord:dev] 1 new commit

a11ccde Fix ViewIcons & plugins that use image modals - Vendicated

Vendicated

[Vendicated/Vencord] Pull request closed: #2963 Fix: ImageModals and ImageZoom

Vendicated

[Vendicated/Vencord] New comment on pull request #2963: Fix: ImageModals and ImageZoom

superseded by https://github.com/Vendicated/Vencord/commit/a11ccde40fdba6157da006542d6709c1488b5c4c

[austere talon]

your pr didnt update any other plugins

[fossil inlet]

yes it did

[austere talon]

you didnt add width / height to any of them

[fossil inlet]

didnt need them

[austere talon]

[fossil inlet]

i added it to the ones that needed it

https://github.com/Vendicated/Vencord/pull/2963/files#diff-461d900e8103d2a5b682ea475ad56bcaa58050b20fb524a99e073118e37e1634L92-R94

[austere talon]

anyway another thing

this in imageZoom

pushes the image modal down so it's off centre

[fossil inlet]

tbh never noticed that

[austere talon]

cause it didnt happen before

[fossil inlet]

*in my few hours of fixing and testing the image modals

[austere talon]

it also happens on stock discord images

[fossil inlet]

[fossil inlet]

@austere talon do you plan to merge to main sometime tonight or tomorrow

[austere talon]

GUHHH

pickle

how to webpack find this 😭