#👾-core-development

1 messages · Page 212 of 1

quaint sapphire
#

fully uninstalled it, reinstalled it, cleared the plugins

#

nada

#

it just decided to die on me

fossil inlet
#

did you try codium?

quaint sapphire
#

nope but I am already used to webstorm by now

austere talon
#

just hold shift while calling 😭

quaint sapphire
#

this reverses that behaviour

#

holding shift will ring the others

#

not holding it will start the call w/o ringing others

fossil inlet
#

tbh idk anyone who would use this

#

when i call someone

#

i want it to ring

quaint sapphire
#

this is more meant for group DMs

#

I may want to hop on a call in case someone wants to join
doesn't mean I want to annoy them into joining

quaint sapphire
fallen vale
#

I love web storm

charred monolithBOT
#
[Vendicated/Vencord] New branch created: chore/reverse-review-order
#
[Vendicated/Vencord] branch deleted: chore/reverse-review-order
austere talon
#

why delete xd

frail skyBOT
#
Bad Patches

NoTrack (found no module):
ID: -
Match: ```
.METRICS,


**__IgnoreActivities (found no module):__**
ID: `-`
Match: ```
.activityCardDetails,children
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

NoTrack (found no module):
ID: -
Match: ```
.METRICS,


**__IgnoreActivities (found no module):__**
ID: `-`
Match: ```
.activityCardDetails,children
Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

gritty iris
# frail sky

Notrack should be ".METRICS_V2," now from what I can tell

charred monolithBOT
austere talon
#

the horror

#

maybe just try removing the comma instead

gritty iris
#

alr

#

yup it works

#

!

fossil inlet
#

is there any reason for this

#

isnt it just syntax highlighting

limber skiff
#

what

austere talon
#

I was too lazy to write new esbuild code to bundle it into the extension zip

#

so i just made it desktop only

charred monolithBOT
dusk blaze
#

love accidentally sending 2 gifs in core dev blobcatcozy

charred monolithBOT
scenic brook
#

Is there any reason toolboxActions doesn't currently let you define your own MenuItems to put in it?

#

I chucked together a thing to let me do it which I'm sure could be done more gracefully but I didn't want to put too much effort in if it's an intentional choice

grave mangoBOT
turbid hatch
#

but the toolbox is not meant for anything more than simple actions

#

we dont want to add another place to change your settings, it is better to keep it centralised

scenic brook
#

Oh I know it takes functions but it just puts those in a basic MenuItem, I meant more so you can add other types of MenuItems like the checkbox

#

It's fine if it's not wanted, just figured I'd ask

turbid hatch
#

yeah it complicates it a bit too much

scenic brook
#

I'll just save it for myself then

austere talon
#

imagine once 20 plugins do that

scenic brook
#

Harsh but point taken

austere talon
#

there was an idea to let users pin settings of the plugins they want up there

#

but it'll only be a shortcut that opens a modal, not all settings in there

#

(or maybe nested context menu)

scenic brook
#

Makes sense. For this specific use case I kinda just wanted something more easily accessible than going into the plugin settings but not important enough for the context menu

#

So toolbox felt like the good middle ground

scenic brook
#

So pointless overall but still good learning material poking around

limber skiff
#

context menu api so powerful

still maple
#

i'm currently modernizing the github worflow for the Vencord Installer to make it so that the workflow :

  • use the new versions of the actions cause some will deprecate soon
  • use a matrix for the OSes and gates for steps so there is less repetitions in case of needed changes
  • always build on push but only release on tag push
    issues i still face is windows taking an awfully long time because of msys2, but nothing i can really do for now, i have to dig deeper into it

is that change welcome as a PR or is the current thing fine and you don't care ?

austere talon
#

don't change what's not broken

#

also that installer codebase is deprecated

#

it will be rewritten in rust with tauri

still maple
austere talon
#

there's a branch for it it's kinda been stale cause it's waiting on something else that's also been stale

still maple
#

i would guess a proper new workflow will be made for it then so no need

brazen bone
glass jasper
still maple
#

also discord has 4 layered

spice python
brazen bone
still maple
#

holy i never checked experiments

#

it even has a search bar

brazen bone
#

I made it

dapper crest
#

Why do people dislike that

#

Good idea

gritty canyon
#

This is such a good plugin and in my opinion should be merged immediately.

#

@ vee get on this!

charred monolithBOT
fossil inlet
frail skyBOT
#
Bad Patches

NoTrack (found no module):
ID: -
Match: ```
.METRICS,


**__IgnoreActivities (found no module):__**
ID: `-`
Match: ```
.activityCardDetails,children

NoPendingCount (found no module):
ID: -
Match: ```
location:"use-message-requests-count"

Bad Webpack Finds
findComponentByCode(".Millis.HALF_SECOND", ".bar", ".progress")
Bad Starts

None

Discord Errors

None

#
Bad Patches

NoTrack (found no module):
ID: -
Match: ```
.METRICS,


**__IgnoreActivities (found no module):__**
ID: `-`
Match: ```
.activityCardDetails,children

NoPendingCount (found no module):
ID: -
Match: ```
location:"use-message-requests-count"

Bad Webpack Finds
findComponentByCode(".Millis.HALF_SECOND", ".bar", ".progress")
Bad Starts

None

Discord Errors

None

limber skiff
#

guh

#

I will push fixes today

opaque silo
#

make nuckyz ai to auto fix patches

glass jasper
limber skiff
#

yeah

charred monolithBOT
#

After multiple requests to fix my plugin i actually did. Please merge, i'm tired.

Resolves Issue #2664
Resolves Pulls #2798 #2665 #1783 #1669

Changelog

Fixed:

  • [x] User profile popout patch
  • [x] User profile modal patch

Removed:

  • [x] Setting to disable header

Added:

  • [x] Button to view the voice channel (eye)
  • [x] Decorator to view channel when clicked (blue speaker)

Images

![image](https://github.com/user-attachments/assets/b4ff83ad-fd60-4eac-8c33...

charred monolithBOT
#

A very simple plugin that lets you right click and hide a message without blocking its author. Hides it just for you.

Oftentimes I see a message and think, "I don't want to block this person, but I just don't want to see this particular thing on my screen right now". This plugin lets you do that, no more, no less.

I am aware that this PR may look like a duplicate, but other closed/rejected versions of this idea had larger scopes and/or complex code. Mine is intentionally small in scope,...

desert cosmos
fossil inlet
limber skiff
#

oh sorry forgot to answer

#

I saw someone complain better folders broke clan pending invitations or something

fossil inlet
#

yea

limber skiff
#

I havent tried to fix

fossil inlet
#

saw that myself

limber skiff
#

feel free to do if you want

fossil inlet
#

dont have time to fix this week due to school but will on weekend

#

might do this week if time opens up

limber skiff
#

though I wonder how that happens?

#

it barely touches the main bar

fossil inlet
#

i think its implimented as some kind of folder

limber skiff
#

oh

fossil inlet
#

given it tries to overlay the folder icon

limber skiff
#

peak discord

charred monolithBOT
charred monolithBOT
brazen bone
#

find: ".METRICS" seems very imprecise imo

limber skiff
#

we good

brazen bone
#

I'm not saying it doesn't work, but it's smelly

limber skiff
#

It's fine

#

can anyone confirm NoPendingCount with message requests still works

#

I got no message request

scenic brook
#

Do you wanna try dming me? I imagine that'd go in requests

charred monolithBOT
limber skiff
scenic brook
#

Sure

#

Just sent

limber skiff
#

works

#

thanks

scenic brook
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
fallen vale
spice python
#

I love dom manip

brazen bone
#

It's dom manip, that runs once per second, and only works in english language

charred monolithBOT
spice python
rugged spire
torpid vessel
#

i ran it and it didnt work but took out the highest role

brazen bone
#

And the stop() doesn't even stop the setinterval :)

rugged spire
#

though

#

I'm guilty of that

torpid vessel
#

same

rugged spire
#

6 months ago I made a plugin that uses "dom manipulation" (setting event listeners on document.body) and I had the stop function add the event listener again

I only fixed it 2 days ago

#

also, if Discord wasn't using React and this wasn't possible with CSS, it'd be more appropriate to use MutationObserver

MDN Web Docs

The MutationObserver interface provides the ability to watch for changes being made to the DOM tree. It is designed as a replacement for the older Mutation Events feature, which was part of the DOM3 Events specification.

brazen bone
#

Yep

rugged spire
brazen bone
#

If nothing else works, you can always just patch react's core

rugged spire
#

@brazen bone uses React.__SECRET_INTERNALS_DO_NOT_USE_OR_YOU_WILL_BE_FIRED

brazen bone
#

Of course I don't, that'd get me fired

#

So that's some certified misinformation right there, gj

scenic brook
#

I used to add a mutation observer via devtools to fix a bunch of stuff that bugged me in discord before I found vencord

brazen bone
#

That is valid

scenic brook
#

Fun times rerunning it every time I needed to restart

brazen bone
#

Tell your local monkey to do it

scenic brook
#

Those times are behind me now

brazen bone
#

There's a builtin button to hide members list if that's what you want, which it probably isn't

scenic brook
#

I think they mean to say that CSS snippet would hide the members as well as activities when they don't want to but that's what #🎨-css-snippets message is for

charred monolithBOT
austere talon
#

im reviewing rn chiiill

charred monolithBOT
austere talon
#

horror api

#

can u give an example url

#

WHAT IS THAT

#

yeah it's fine then

opaque silo
#

now make ytmusic rpc

quaint sapphire
#

💀
the apple music rpc does the equivalent of using powershell

#

ig it is better than having a third party program provide the rich presence data

charred monolithBOT
torpid vessel
# charred monolith

the comment is wrong lmao
the current commit has .container(?=.+?a&&(this)) utilizing positive lookahead, already updated on PR

torpid vessel
#

i forgot the definition of minified

limber skiff
#

if this is gonna be hardcoded in the regex just hardcode it in the replace instead

torpid vessel
#

fair point

#

ill do that

#

then the capturing group isnt necessary right

#

wtf is happening with my brain rce_FacePalm

limber skiff
#

the whole lookahead isnt

#

also is that regex matching more than one place or not

#

if not make it non global

torpid vessel
#

there is only .container and i was so focused on making a regexp i didnt even oh my god

#

can i squash my commits

austere talon
#

no need

#

pr will be merged squashed on merge anyway

#

don't rebase pr commits it's confusing and makes it harder to review

torpid vessel
#

okie okie

gritty canyon
torpid vessel
#

tunnel visioned

#

i was so concerned about .container repeating multiple times and getting the channel var i forgot to skim the actual file

scenic brook
#

No music this time

gritty canyon
#

a ton of people suggest using lookaheads

#

whats the deal with that

#

except special syntax for eating more performance

torpid vessel
#

for me it helps matching patterns based on surrounding context

#

esp if there are multiple matches and u only wanna match 1

limber skiff
limber skiff
gritty canyon
limber skiff
#

pretty much all my patches is target a context .+? to where I want

limber skiff
#

but they can be used for powerful cheats too

gritty canyon
#

i get that they are cleaner but like is that it

limber skiff
#

that's pretty good?

grave mangoBOT
grave mangoBOT
limber skiff
#

other cheat

glass jasper
#

@limber skiff this new plugin 9/10, cant wait for the #plugin-news in a few months about it

limber skiff
#

I dont understand what you said

wary relic
#

me neither

glass jasper
#

im on 4 hours of sleep gang

limber skiff
#

It wont take months

limber skiff
#

I'll see if we have more news soon, if not then I will announce it alone or maybe with one more thing too

#

I just wanna avoid a ping for one plugin

austere talon
gritty canyon
#

but thats not very useful when you can just do (match, _1, component) => `${_1}your_suff_here` right?

austere talon
#

it's cleaner and more performant

gritty canyon
austere talon
#

and some things you can't do without lookarounds

austere talon
gritty canyon
#

researching i only see people saying its less performant

#

is there any source of them being more performant?

#

genuinely curious

#

just googling, all the top results are already saying you should avoid them because of performance impact

#

in fact the only sources i find that are not against them are tutorials

#

now im extremely curious on the obsession of them

austere talon
#

the match is faster

#

but the replacement is much much slower

gritty canyon
#

hm okay i guess

austere talon
#

beause it has to create large strings

#

and uses more memory

#

if you're matching a few thousand bytes of garbage, it's better to not match them at all

austere talon
#

also lookarounds let u do super powerful stuff

gritty canyon
austere talon
#

for example grabbing the closest match next to it

austere talon
#

assuming you have a file like this:

function a(b1) {
  // random code here
}

function b(b2) {
  // random code here
  return "hi"
}
#

try capturing b2 inside a group without lookbehind

austere talon
#

if you do the same thing without lookaround it will match b1 instead

#

it's not really possible to match the closest thing that is before smth else

limber skiff
#

the one case you are likely gonna cause your regex to get super slow is when u do this

/(?<=something.+?something_way_head)b/
or
/(?<=something.+?)b/
#

in other cases it has no difference, if not faster

torpid vessel
#

non-fixed length lookbehind

#

(i fell victim to that)

limber skiff
#

the issue is not even that it's non fixed length

#

more that it's at the start of the regex

#

and it repeats steps over and over to try to match the look behind

#

on every fail it redoes the entire look behind, but with one more character

torpid vessel
#

damn so thats why my query took 208ms

limber skiff
#

yeah

#

in those cases it's better to just match normally and re add in the replacement

#

lots of patches were changed to that for more performance

limber skiff
#

and it's non fixed length

austere talon
#

yeah you can put lookbehind BEHIND your regex instead of in front

#

and it's so much faster most of the time xD

#

the worst performance is generic lookbehind that can match many characters

#

(?<=a.+?)hi

#

if you have a file like this
aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaai it will check for every a from left to right and have take exponential complexity

#

but if you just avoid that, e.g. via hi(?<=a.+?) boom fast again

torpid vessel
#

brain blown

#

learned something new

austere talon
#

we should notarise the vencord installer on mac

#

xD

#

@turbid hatch u down?

turbid hatch
#

😭

austere talon
#

this is so funny btw

turbid hatch
#

lmfao

wary relic
#

😭

#

how does that happen

#

oh nvm

turbid hatch
#

@woeful bison

wary relic
#

im stupid

austere talon
#

cause lewi is sponsoring me but im also sponsoring him

#

lmaooo

turbid hatch
#

@woeful bison ping

woeful bisonBOT
#

🏓 Pong!

Latency: 88ms
Shard Latency: 28ms
#

You need to provide an image/GIF to add a caption! (Tip: try right-clicking/holding on a message and press Apps -> Select Image, then try again.)

gritty canyon
#

can we make the vencord installer install wires on my wireless device

woeful bisonBOT
austere talon
#

i think i sponsor lewi for more than he sponsors me tho

turbid hatch
#

idk how much are you sponsoring me for

austere talon
#

uhhh idk

turbid hatch
#

oh you sponsor me for 10

#

i sponsor you for 5

#

xd

austere talon
#

so we launder 5 and you get 5

turbid hatch
#

yes

#

profit

austere talon
#

the 5$ is your payment for the laundering

turbid hatch
#

with notarizing, i need to get the certificate out of the vesktop action

#

because i uh

#

Lost My Certificate

austere talon
#

lmaoo

turbid hatch
#

and i Do Not Own A Mac Device

austere talon
#

you'd have to push a new workflow to some branch that just posts the token to your api or smth

#

xD

turbid hatch
#

yeah lmfao

#

the api keys i can get easily they're just listed on the website

#

but the signing cert i cannot

austere talon
#

well it won't be as simple as just doing that

#

we also need the entitlements plist thingie

turbid hatch
#

ye

#

i think personally

#

we should wait until we're going ahead with the rewritten installer

#

before we put the effort into notarizing

austere talon
#

hmmm

turbid hatch
#

cuz otherwise

austere talon
#

tauri does support it ootb

turbid hatch
#

we're gonna notarize this

#

and 1-2 releases later we're replacing it with a different system

#

xd

austere talon
#

wait do u use windows or linux

turbid hatch
#

both

austere talon
#

i kinda lost motivation to work on the asar pr

#

it's essentially finished, just need to test updater on windows

turbid hatch
#

my translators are sobbing in the corner right now hearing that

austere talon
#

specifically because of file locking

turbid hatch
#

alright

#

what do i need to set up

austere talon
#

if u wanna look into that it'd help greatly with getting it merged

turbid hatch
#

yip

#

i assume i can do it in vesktop

austere talon
#

uhh basically just the pr and you need to test the http updater

#

what you'll want to do is use just a normal vanilla vesktop install (NOT from source) and edit the repo variable in main.js / patcher.js to your vencord fork

#

and then you push the pr to your fork's main branch so it builds the new builds

#

then you should get an update, then once u restart it should migrate your install to asar and restart (it prints to terminal)

#

then from there on it uses asar and updates from asar

#

and the asar updater also needs testing

#

so just push some dummy commits to ur repo to trigger updates

#

basically that's all

turbid hatch
#

hello from vesktop

#

okay

#

let me read a sec

#

okay, so i need to build a dev version of vencord, point the updater to a fork with the PR merged, and then trigger an update

#

then send some blank commits off

#

okie dokie

austere talon
#

use vanilla official install

#

and just edit the bundled vencordDesktopMain.js

turbid hatch
#

oh you just want me to edit the files

#

okay

austere talon
#

to change repo from Vendicated/Vencord to your repo

#

this makes it so you can test the migration proccess

turbid hatch
#

where does vesktop store the files again

#

oh roaming

#

got it

#

i am

#

very confused

#

i've edited the files for vesktop's vencord install but they're still pointing to the old repo

#

are these the wrong files..?

austere talon
#

whats their path

turbid hatch
#

"C:\Users\Lewis\AppData\Roaming\vesktop\vencordDist"

#

is apparently where it should be getting them from

#

but that doesnt line up with the source code where it says "vencordFiles", and there is no such folder in the data directory

#

the state file also does not specify any path

#

the app just says "default location"

#

okay lemme play a valo match cuz i said id play with my friend and then ill come back to it

austere talon
turbid hatch
#

no, i clean installed vesktop and made sure to reset the location, then performed an update to make sure i was on latest vanilla

turbid hatch
#

from my understanding this should be DATA_DIR/vencordFiles but that literally doesnt exist xd

austere talon
#

it's in sessionData/vencordFiles

#

vencordDist is no longer used

turbid hatch
#

o i see

#

weird that it doesnt look like that in code xd

#

maybe i misread it

austere talon
#

u did

turbid hatch
#

one thing

#

i dont know why

#

it doesnt even matter how hard i try

#

keep that in mind when i tell you this rhyme

austere talon
#

NOT THE TIME FOR LINKIN PARK

turbid hatch
#

that i forgot to enable github actions~ 🎵

grave mangoBOT
# austere talon https://github.com/Vencord/Vesktop/blob/main/src/main/constants.ts#L18-L20 https...

constants.ts: Lines 18-20

const LEGACY_DATA_DIR = join(app.getPath("appData"), "VencordDesktop", "VencordDesktop");
export const DATA_DIR =
    process.env.VENCORD_USER_DATA_DIR || (PORTABLE ? join(vesktopDir, "Data") : join(app.getPath("userData")));

constants.ts: Line 40

const SESSION_DATA_DIR = join(DATA_DIR, "sessionData");

constants.ts: Lines 50-52

export const VENCORD_FILES_DIR =
    (require("./settings") as typeof import("./settings")).State.store.vencordDir ||
    join(SESSION_DATA_DIR, "vencordFiles");
turbid hatch
#

yeah i misread it

#

i erased SESSION_ from that prefix

#

oh i need to setup a vencord builds repo

#

oopsies

#

no i dont xd

#

@austere talon is there nothing i need to do vesktop wise?

#

cuz its just stuck loading now

#

do i not need to switch to the asar version

austere talon
#

it migrates once u update

turbid hatch
#

i dont think it worked

#

cuz its just stuck

austere talon
#

run from terminal to see output

turbid hatch
#

kay

#
[Vencord] Starting up...
(node:40284) UnhandledPromiseRejectionWarning: Error: Cannot find module 'C:\Users\Lewis\AppData\Local\vesktop\resources\app.asar\dist\_app.asar\package.json'
Require stack:
- C:\Users\Lewis\AppData\Roaming\vesktop\sessionData\vencordFiles\vencordDesktopMain.js
- C:\Users\Lewis\AppData\Local\vesktop\resources\app.asar\dist\js\main.js
-
    at Module._resolveFilename (node:internal/modules/cjs/loader:1152:15)
    at s._resolveFilename (node:electron/js2c/browser_init:2:120699)
    at Module._load (node:internal/modules/cjs/loader:993:27)
    at c._load (node:electron/js2c/node_init:2:17025)
    at Module.require (node:internal/modules/cjs/loader:1240:19)
    at require (node:internal/modules/helpers:179:18)
    at VencordMain:5:5161
    at VencordMain:5:225
    at VencordMain:8:454
    at VencordMain:5:225
(Use `Vesktop --trace-warnings ...` to show where the warning was created)
(node:40284) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
Update for version 1.5.3 is not available (latest version: 1.5.3, downgrade is disallowed).
checkForUpdatesAndNotify called, downloadPromise is null
charred monolithBOT
turbid hatch
fossil inlet
#

@hushed flicker you can also discuss plugins here

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
fossil inlet
#

@limber skiff while im fixing betterfolders not rendering guild apps, should i also give it a readme.md

hushed flicker
#

shit

charred monolithBOT
limber skiff
#

can u fix formatting too

#

in your pr

fossil inlet
#

just booted into windows 😭
time for github web editor

fossil inlet
limber skiff
#

spacing in if

fossil inlet
#

ah, missed that

#

@limber skiff fixed the formatting and wrote a readme

not sure how good the readme is, if you dont like it just remove it or edit it

#

i eep now

limber skiff
#

alright thanks

charred monolithBOT
fossil inlet
#

!remind saturday dragging support for pindms

shut vineBOT
#

Alright @fossil inlet, in 2 days: dragging support for pindms

fossil inlet
#

!remind saturday also drag favorite emotes

shut vineBOT
#

Alright @fossil inlet, in 2 days: also drag favorite emotes

charred monolithBOT
gritty canyon
#

ew..

scenic brook
#

Just add them as a friend and then look here suffoBigBrain

glass jasper
scenic brook
#

Unfortunate that this is the actual plugin and not a request for one so they already have and are probably using this

austere talon
charred monolithBOT
turbid hatch
#

just saw that

#

that is a horribly creepy plugin

#

ah yes please let me watch what this user is doing automatically

#

yeah i dont like that either and i find it creepy

#

i dont mind activity status since i dont mind if people see what im playing or where i am, but i find it weird to have a centralised place for people to work that out, and i find it especially creepy to have a plugin that automatically notifies what im up to to people that i dont know lol

#

like at least the built-in one is for your friends

#

of course this is discord, privacy is not to be expected

rugged spire
#

silent role trolley

turbid hatch
#

but i would like to at least not be immediately stalked by software that i contribute to :p

#

hop on

#

vp silent

nimble pendantBOT
turbid hatch
#

wrong one

#

vp silentmes

nimble pendantBOT
rugged spire
#

needs context menu only option for me to want to enable it lol

brazen bone
#

You don't need more than that

turbid hatch
#

i mean look at mine ryan

brazen bone
#

Your screen is puny

turbid hatch
#

i need to kill the gift and sticker button

#

and the gif button

scenic brook
#

Collapsible chat bar buttons suffoPeepoMischief

charred monolithBOT
turbid hatch
#

idk why there are three buttons that go to the same dialogue

charred monolithBOT
turbid hatch
#

i think im also kinda

#

like

desert cosmos
turbid hatch
#

biased about things cuz i've had a bit of a stalking incident as of late

rugged spire
turbid hatch
#

so maybe this plugin upsets me more than it really should'

#

but oh well

rugged spire
scenic brook
rugged spire
#

iirc I made a plugin that did something like the plugin in question a long time ago when I started out with making plugins I think it was for friends only

i abandoned it because it got annoying

desert cosmos
#

insane selector

rugged spire
#

YES

austere talon
#

THAT DOESN'T SOUND VERY PROMISING

rugged spire
turbid hatch
#

is it not

rugged spire
#

no lol

turbid hatch
#

ive only seen it for my friends, never anyone else

#

im talking about this one

rugged spire
#

ive been shown randos in there since like 2018 or whenever it was released

turbid hatch
#

not the one in servers

rugged spire
#

i know

turbid hatch
#

well i dont know because it specifically states >Friends

#

so maybe its because your friends are with randoms?

#

i've never seen anyone i dont know in that list

rugged spire
#

no

turbid hatch
rugged spire
#

it genuinely shows randoms

#

well

turbid hatch
#

cnr

rugged spire
#

it did in the past?

#

it only shows one group of friends in a vc rn

#

i need to look into it

cunning canyon
#

implict relationship

rugged spire
#

yes

#

god i hate the user affinity system

limber skiff
austere talon
#

ye

limber skiff
#

you are right

austere talon
#

if they rename folderNode to smth else

#

enjoy crash loop

#

always use try catch or optional chaining

limber skiff
#

yeah I know

#

I didnt realize that one part could error

#

should I also

rugged spire
#

Yop

#

eh

#

maybe

#

it should never error there

#

the error would be the find/match breaking

limber skiff
#

actually yeah

#

components cant be arrow functions right?

#

or can them

rugged spire
#

they can but i dont think its common

limber skiff
#

because arrow functions dont have arguments

#

hmm

#

ill just do it

charred monolithBOT
limber skiff
#

haters about to hate

charred monolithBOT
rugged spire
#

why tho

#

its just adding 1 commit

limber skiff
#

it's redoing a commit

rugged spire
#

husk

#

why didnt i do this earlier

limber skiff
#

then base on main

#

dev is literally for that

#

base on main and I will change to dev before merging

#

I always do

charred monolithBOT
rugged spire
#

i will base on dev

limber skiff
#

why would u @rugged spire

rugged spire
#

nuckyz gonna kill me

limber skiff
#

specially with the force pushes

rugged spire
charred monolithBOT
fossil inlet
jolly egret
#

Pull requests can be made either to the main or the dev branch. However, unless you're an advanced user, I recommend sticking to main. This is because the dev branch might contain unstable changes and be force pushed frequently, which could cause conflicts in your pull request.
😭

#

There are genuine reasons to force push branches to keep them properly inline, we have a similar workflow in a project I work on and a quick rebase fixes it

#

Not really all that annoying I guess

limber skiff
#

it's so useful to be able to rebase

opaque silo
#

how horror would it be to find the check for web on quests so they could be done on web/vesktop with arrpc

charred monolithBOT
turbid hatch
#

ive got nothing to do for a while so

austere talon
#

I'll check code in a bit

turbid hatch
#

kay

austere talon
#

but also try to figure out yourself why that happens

turbid hatch
#

i couldnt spot anything obvious xd

austere talon
#

it worked for me

grave mangoBOT
turbid hatch
#

so its obviously this bit

#

hm

austere talon
#

that's not used on vesktop

turbid hatch
#

it is in my logs

austere talon
#

then you did smth wrong xd

turbid hatch
#

[Vencord] Starting up comes from here

austere talon
#

what exactly did you do

turbid hatch
#

clean installed vesktop

#

updated vencord

#

modified the instance of vencord to point to my repo at lewisakura/vencord (which has the PR on and built)

#

updated

#

restarted vesktop

#

hm

#

its definitely pulling it from my branch

#

so why oh why...

#

@austere talon i dont need the asar version of vesktop for this to work, right?

#

cause i know that's a PR

#

oh wait no of course not

#

we want it to load the downloaded files, not the asar

turbid hatch
#

why did you tell me to use normal vesktop then 😭

#

still though i wanna see why its loading the patcher for discord desktop

#

i dont get it

#

i dont understand why its building the patcher into the vesktop bundle

#

wait what?

#

it's building a normal build for the vesktop files...?

#

that's why its broken

#

wtf

#

okay, let me try asar vesktop

#

@austere talon with asar vesktop, it downloads the (old) version of vencord from the main repo, and it seems to load it fine from there

neither the desktop.asar or the vesktop.asar file built from my repo works though

#
Skip checkForUpdates because application is not packed and dev update config is not forced
checkForUpdatesAndNotify called, downloadPromise is null
[Vencord] Starting up...
(node:32992) UnhandledPromiseRejectionWarning: TypeError: Cannot read properties of undefined (reading 'filename')
    at VencordPatcher:5:5148
    at VencordPatcher:5:225
    at VencordPatcher:8:454
    at VencordPatcher:5:225
    at VencordPatcher:8:1136
    at VencordPatcher:5:225
    at VencordPatcher:23:1501
    at VencordPatcher:5:225
    at Object.<anonymous> (VencordPatcher:23:2763)
    at Module._compile (node:internal/modules/cjs/loader:1373:14)
(Use `electron --trace-warnings ...` to show where the warning was created)
(node:32992) UnhandledPromiseRejectionWarning: Unhandled promise rejection. This error originated either by throwing inside of an async function without a catch block, or by rejecting a promise which was not handled with .catch(). To terminate the node process on unhandled promise rejection, use the CLI flag `--unhandled-rejections=strict` (see https://nodejs.org/api/cli.html#cli_unhandled_rejections_mode). (rejection id: 1)
#

i think this is related to my faulty vesktop builds though

#

i dont know why it's building it wrong

#

it looks fine on the scripts

#

so... i guess it works fine??? but i dont know if the migration stuff does

austere talon
#

xD

turbid hatch
#

it "Works Fine" he says, with a massive error in his logs that breaks the whole app

#

well either way, i know it loads the asar fine

#

because it does on the older version

quaint sapphire
#

just discovered there is a chatbar button api

#

which is 90% what I needed

#

(my old patches from 2023 stopped working)

#

but it doesn't allow to insert a button in between other buttons 😔

sterile oak
quaint sapphire
#

is there a reason in anything?

#

anyways, I gave up since I found a better solution that didn't need a new button

charred monolithBOT
sterile oak
quaint sapphire
#

yeah it was THE spaghetti

#

I will try to keep the code as minimal as possible this time

#

the reason it is so many lines of code, is because I remade the entire sticker picker UI

#

from scratch

sterile oak
#

I am impressed that you took the time to rewrite the sticker panel code.

#

maybe if were able to patch where it loads the stickers and insert new stickers it would do better

#

instead of yk writing the thing from scratch

quaint sapphire
#

that wouldn't work well with what I want to achieve

#

but I plan to re-use components from the sticker picker

#

instead of recreating them

sterile oak
quaint sapphire
#

hmm?

#

the json files contain a list of packs, as well as their thumbnails

I do not scrape the packs themselves, that would be done client side

#

anyways, gotta go sleep

fossil inlet
#

that you append

quaint sapphire
#

The list is not exposed by the plugin api

#

You just register ur button, and the plugin api appends it

quaint sapphire
opaque silo
#

someone explain why open.spotify.com links dont auto open in the desktop app from chome and firefox

#

infact spotify:// isnt even working in firefox at all 😭

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

opaque silo
#

potify

charred monolithBOT
#

The stock profile effect setting still falsely shows the "Remove Effect" button

Or should I try to automatically detect preexisting FPTE strings and strings from other plugins, and remove them from the user's bio, showing an error if there still isn't enough space?

Bio processing is already in place, can you not just replace the detected/processed fpte string

Should I send an API request to save the user's bio, or should I have the user do it manually?

The user should do it m...

charred monolithBOT
dapper crest
#

Github Username is permanent (or a pain in ass to change idk which)

#

But then I have to change remote origin on everything

opaque silo
dapper tiger
#

@opaque silo

#

hi

#

i just noticed something

#

wait

opaque silo
#

hi just noticed something

#

I cookiw

dapper tiger
#

okay nvm i see now

dapper crest
opaque silo
#

Discord/users/Cassie

opaque silo
dapper tiger
#

i see the truth

opaque silo
dapper tiger
#

yop

dapper crest
#

Yop

opaque silo
dapper crest
#

I will continue using f53 as a way to get a unique easy to type tag

opaque silo
dapper crest
#

CassieF53 f53cozy

dapper tiger
#

nini

#

eep well

fossil inlet
brazen bone
#

Remind me to make a bot that scrapes github for renamed accounts and registers the previous username

shut vineBOT
#

Alright @somber thorn, in 1 day: remind kyuu

sterile oak
swift fjord
wary relic
#

😭

austere talon
#

recommended for u 🔥

austere talon
#

wanna make a react native mod? trollzoom

#

same model as vencord

#

everything built in

dusk blaze
#

first rpceditor will be part of vencord

#

and inrole

#

and goodperson

charred monolithBOT
dusk blaze
#

literally nobody cares lol

charred monolithBOT
swift fjord
#

don't let enmitter team take over android

rugged spire
# dusk blaze why

don't worry they are coping that I made a plugin like this ????? ago and never bothered to fix it when it exploded because i didnt find it useful and stopped maintaining it

Sources: #👾-core-development message https://github.com/Sqaaakoi/Vencord/issues/2

GitHub

VoiceChannelLog and VoiceJoinMessages are causing GatewaySocket to constantly reset. Both of the plugins are under your unmaintained plugins section, but you've also marked both plugins as &quo...

charred monolithBOT
#

Would it be possible to cut down on the amount of conditions? I feel like two or three of these (e.g. Number.isNaN(trackData.duration) && trackData.playerPosition === 0) would be reasonably enough.
I'm not sure, Apple Music may return some of these values in other situations, e.g. if the track is not fully loaded. I did this long check for safety, but if you think some can be removed, please tell me which!

rugged spire
#

who did this

austere talon
#

you

rugged spire
#

discord will never add those events to audit log

jolly egret
#

they won't

#

ever!

#

its so annoying

austere talon
#

sometimes they just have bugs with channel order too

#

I vividly remember when my private channel #v kept changing position with other channel below it

#

megu and I were the only people with access to it so I asked about it and he said he hadn't done it

#

but i knew it wasn't me either so I figured it must have been megu, maybe by accident

anyway, I ended up reworking permissions to limit how many permissions mods have and it made megu no longer have access to it, but shortly after the channel changed order again husk

#

turns out it was just a bug at the time

gritty iris
rugged spire
gritty iris
#

they should just fix them thumbsup

rugged spire
#

i did fix something due to a bug being discovered there but thats because i actually liked the thing I made

#

REAL

gritty iris
#

(even I know how to fix some things)

gritty iris
#

oh my

#

what did they do aquaCry

rugged spire
#

probably fucked with the Devs constant

gritty iris
#

wanna give me the links for the plugins they complained abt?

#

(aka what branch)

rugged spire
#

.

gritty iris
rugged spire
gritty iris
#

hey I found them

#

wait nope nvm

nimble plaza
#

should i open an issue asking them to remove my plugins :3

rugged spire
#

no thats just toxic like what happened with equicord

nimble plaza
#

ik its fine under the license but

#

yeah fair

gritty iris
rugged spire
gritty iris
#

it was smth color

#

client theme

rugged spire
#

my take on plugins is its fine as long as you aren't really harming people with it

gritty iris
rugged spire
#

oh its awful

#

i know its bad

gritty iris
#

I know

#

im looking at it

rugged spire
#

i forgot how half of it even works

gritty iris
rugged spire
#

i can promise you

gritty iris
#

burn*

rugged spire
#

yes

#

i did not cook

#

i did indeed burn

#

i probably copied this from some other place btw

#

and adapted it

#

and thought "this is fine"

gritty iris
#

you did

rugged spire
#

i knew it

austere talon
#

the difference is that those places used findBulk

#

which can find multiple things in one go

rugged spire
#

Yop

#

and I thought I didnt need it so I just removed the "bulk" part

gritty iris
#

now I have 2 figure out how they work

#

finds are fixed

rugged spire
#

are you trying to tell me that you are fixing my shitcode from ???? ago

gritty iris
#

yes

#

not properly aka im not fixing lazycomponent

#

that is beyond me

#

actually I might try

#

hm

rugged spire
#

Do I look like I know how it worked?

gritty iris
rugged spire
#

you could probably just use findbyprops outside

gritty iris
#

you can

rugged spire
# gritty iris lmao

Click spoiler if you want to hurt your soul

||I have stolen that hacky code for voice join/leave events at least 3 other times. No I am not joking.||

gritty iris
#

cl is defined in every file

rugged spire
#

just move it to the index or a constants file if it exists and export it

gritty iris
#

same lol

rugged spire
#

😭

gritty iris
#

it might work now

turbid hatch
#

how do you mess it up THAT bad

gritty iris
turbid hatch
#

thats not even like

#

the mod doesnt even build???

#

because there's just missing props outright

#

and modules

#

they genuinely just dont know how to do a vencord fork

#

jfc

gritty iris
rugged spire
gritty iris
#

now I gotta look at the other one

#

(its finds are good idk what it does)

gritty iris
rugged spire
#

good lord this ugly plugin still works

gritty iris
#

after find fixes and removing divider stuff yes

rugged spire
#

a similar plugin got rejected from upstream for good reason btw dont consider submitting this to upstream blobcatcozy

dusk blaze
rugged spire
#

yes but its something I made like too long ago and don't care about

gritty iris
#

best logging sys ever lmfao

charred monolithBOT
charred monolithBOT
fossil inlet
sterile oak
charred monolithBOT
austere talon
#

it fine

charred monolithBOT
rugged spire
#

this is why plugin requests were closed

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

sterile oak
#

wait I could

rugged spire
#

how the fuck

#

are you changing shit and watching it break for "no reason"

#

when in reality its that you are using a space for a margin?

sterile oak
sterile oak
austere talon
#

it does

dapper tiger
#

@opaque silo hii

glass jasper
opaque silo
#

alien

dapper tiger
#

@opaque silo what do we say to lord vee

opaque silo
#

the day of reckoning has come for Vesktop aur packages

dapper tiger
#

yes

#

@austere talon the day of reckoning has come for Vesktop aur packages

opaque silo
#

Covking/pkgbuild into Vencord/pkgbuild fr

dapper tiger
#

soon

opaque silo
#

ok back to roblox

austere talon
#

random nonsense changes

spark pivot
austere talon
#

vesktop pr incoming

charred monolithBOT
#

the current code checks for a non error exit code which is the recommended and most robust way. your PR changes it to check for whether the command prints anything, which is a very bad way of doing it and could easily lead to false positives if some implementation printed 'command not found'

before trying to make further contributions, please consider whether your contributions are actually productive. there is little point changing code that is not broken. prs should add (good) features...

shut vineBOT
#

@fossil inlet, <t:1726119327:R>: dragging support for pindms

#

@fossil inlet, <t:1726119390:R>: also drag favorite emotes

rugged spire
#

what is wrong with that

#

the := part?

#

inside of the set command

shut vineBOT
#

@somber thorn, <t:1726207213:R>: remind kyuu

charred monolithBOT
somber thorn
sterile oak
cunning canyon
#

maybe reduced motion

sterile oak
#

I reviewed 70-80% of plugin-requests wires. some issues already have a pr pending but they aren't tagged or other that should be closed as they are fulfilled or creepy(1). could I like dm vee or nvhhr?

fossil inlet
charred monolithBOT
sterile oak
# charred monolith

guys what if I declare the variables in the component than used them in another patch?

limber skiff
#

I think separate it into multiple patches

#

and move what you can to a function $self

charred monolithBOT
torpid vessel
#

but if i bring it to the others i might just consolidate all 3 into BetterExpressionsVisibility or some short name then retain GifPaste as is and put my changes towards paste functionality under GifPaste

charred monolithBOT
austere talon
#

true true

#

hi fawni

dusk blaze