#πŸ‘Ύ-core-development

1 messages Β· Page 210 of 1

rugged spire
#

IT IS NOT

#

that is MANAGE ROLES iirc

fossil inlet
#

nop

#

testing server time

#

nevermind, im stupid

limber skiff
#

@austere talon ping plugin announcements for me lol

rugged spire
#

@limber skiff did you even make a proper release?

charred monolithBOT
limber skiff
#

last one was a week ago so I guess we can do

charred monolithBOT
fossil inlet
#

guhhh why is the there a default role avatar instead of nothing

image.png
charred monolithBOT
rugged spire
fossil inlet
rugged spire
#

idk trolley

limber skiff
#

do we wanna change that or should I release

fossil inlet
#

i was going to pr something that added toggles and added an option for the default icon, but that can wait for the next release

rugged spire
#

its a highly opinionated change that got merged

fossil inlet
#

ehh

rugged spire
#

it's fine

fossil inlet
#

i could do something now

rugged spire
#

but needs to be changed by next release

#

what I really wanted is the role icon to replace the @ like avatars do

fossil inlet
rugged spire
#

idk why it is implemented the way it is and i think the way it is implemented now is illogical and ugly

fossil inlet
#

yea

charred monolithBOT
limber skiff
#

okay that can wait

charred monolithBOT
#
Nuckyz
[Vendicated/Vencord] New tag created: v1.9.9
rugged spire
#

time to enjoy

#

@fossil inlet do you mind if I make a branch for MentionAvatars?

fossil inlet
#

already did

rugged spire
#

show me what you've got

fossil inlet
#

just started 😭

#

watch here

rugged spire
#

i need your thingy lol

fossil inlet
#

my what?

rugged spire
#

your dev companion changes

#

hold on

fossil inlet
#

ill update my branch

#

for the devcompanion

rugged spire
#

no

#

dont bother

#

i'm just gonna merge my branch into a branch off of it that includes your changes

#

@fossil inlet i have a feeling the icon was put after as an excuse to not implement the show at symbol and as an easier regex to write?

#

because the at is already injected much earlier

fossil inlet
#

im still going to do it

rugged spire
fossil inlet
#

HOW THE FUCK IS THIS NOT ITERABLE

image.png
rugged spire
fossil inlet
#

yea, but it works

#

<@&1167970304027533312>

rugged spire
fossil inlet
#

WE LOVE

image.png
rugged spire
#
poll_question_text

does Segoe UI look generic

victor_answer_votes

0

total_votes

0

fossil inlet
#

πŸŽ‰

charred monolithBOT
austere talon
#

don't put it in front

rugged spire
fossil inlet
rugged spire
#

it looks ugly at the end

austere talon
#

stop with this weird obsession of having 2 million switches

rugged spire
fossil inlet
rugged spire
#

i do understand "it should be identifiable at a glance if it is a role or a user mention"

do not force people into aesthetic choices like this though
and i'm begging everyone in this channel to not ship common UI changes as CSS snippets

austere talon
#

it's not a common ui change

#

it's a super minor detail that no one should waste a sweat about

rugged spire
austere talon
#

adding 3 million options for every minor ui thing adds extra work, makes the code less maintainable, and is bad for the user because no one wants 3 million switches

#

there should be one single good look that corresponds to what's best for most people

rugged spire
austere talon
#

anything else can be done with css.

rugged spire
austere talon
#

switches should be only for alternative designs

#

like the show timeouts

rugged spire
#

@fossil inlet drop the take

#

here right now

fossil inlet
#

this isnt even an alternative design, this just brings it in line with the avatar part of MentionAvatars

rugged spire
rugged spire
austere talon
#

discord also shows role icons after the role

rugged spire
#

that is true

austere talon
#

it's consistent with discord thus the better design

rugged spire
#

doesn't mean it makes sense in this context

fossil inlet
austere talon
#

it makes role mentions match exactly what's displayed inside the profile

rugged spire
austere talon
#

In any case it also has the great benefit of easily differentiating role mentions and user mentions

rugged spire
austere talon
#

no.

#

in any case i'm going to sleep

fossil inlet
austere talon
#

silly super minor ui difference switches will never be accepted and there's no point trying to argue for them

#

this is not how you design a good app and by demanding this you show you have no clue about app design

#

you make one single ui that most people will be satisfied with and then allow people to tweak every small detail to their liking via distributable themes

#

switches should be reserved for major changes like toggling a feature

still wasp
#

Having a config for it seems useless but putting it in front looks significantly better and seems more natural

fossil inlet
#

Also, the toggle is just to enable or disable users and roles individually, Some people might not want both.

charred monolithBOT
limber skiff
#

godly change

rugged spire
#

we have discovered 1 bug in 2 plugins at once

rugged spire
# charred monolith

that icon is squished in the recently merged in mentionavatars AND in this PR

charred monolithBOT
charred monolithBOT
rugged spire
charred monolithBOT
charred monolithBOT
dusk blaze
#

@scenic canopy actually fire plugin

charred monolithBOT
#
electricsteve
[Vendicated/Vencord] New comment on pull request #2818: Add invert option to dearrow plugin

Instead of being an option to invert we should do something like how ShowHiddenChannels does: ![image](https://private-user-images.githubusercontent.com/61953774/363452670-a8a1ae76-7a76-419a-a887-3e573a7c3847.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MjUxODg2NzQsIm5iZiI6MTcyNTE4ODM3NCwicGF0aCI6Ii82MTk1Mzc3NC8zNjM0NTI2NzAtYThhMWFlNzYtN2E3Ni00MTlhLWE4ODctM2U1NzNhN2MzODQ3LnBuZz9YLUFtei1BbGdvc...

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
dusk blaze
#

guhjhhh why

charred monolithBOT
charred monolithBOT
somber thorn
#

kill me ​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​​

fallen vale
rapid merlin
#

I mean does IS_DISCORD_DESKTOP is true for web and Vencord

grave mangoBOT
#

buildWeb.mjs: Line 48

IS_DISCORD_DESKTOP: false,
fossil inlet
rapid merlin
#

Oh sorry, okay)

#

Makes sense

charred monolithBOT
fossil inlet
charred monolithBOT
fallen vale
charred monolithBOT
#
ryan-0324
[Vendicated/Vencord] New comment on pull request #1930: feat(plugin): FakeProfileThemesAndEffects

Some issues:

  1. The stock profile effect editor is patched by this plugin resulting in it displaying all effects as unlocked and are unable to apply any & it falsely showing the remove effect button. Should behave like Decor where it doesn't modify the stock feature.
  2. The FPTE Builder should auto fill with the values from the bio.
  3. The FPTE Builder should have buttons to save to bio without manual copy & pasting being required And likewise have a clear button.
  1. This se...
dusk blaze
gritty canyon
charred monolithBOT
glass jasper
dusk blaze
charred monolithBOT
brazen bone
glass jasper
gritty canyon
#

but i hate interfaces starting with i

charred monolithBOT
charred monolithBOT
desert cosmos
#

The hell is Knocklive Development SKULL_SKELETON

dusk blaze
crude raptor
#

oh

dusk blaze
#

individuals can assert copyright

crude raptor
#

someone changed the copyright attribution marker at the top of their file to say "[username] development" and someone's questioning if that would even work

#

(someone points out that changing that is fine cause even if it lists "vendicated and contributors" you are the one who owns your code)

#

ig it does raise the question of like... an individual can assert copyright- but the way they wrote it makes it sound like a legal entity rather than an individual- so would that still work?

glass jasper
crude raptor
#

but is that an entity that exists?

fossil inlet
#

prob not

glass jasper
#

I mean, I copyright a lot of my stuff as β€œThe Crossed Axe”

fossil inlet
#

this chat is just yapping rn

glass jasper
crude raptor
#

ig it doesnt matter as long as the person who made the code knows it either does or doesnt

glass jasper
crude raptor
#

mfer on a messaging platform and be like "damn these bitches messaging"

still wasp
#

These bitches messaging tho

glass jasper
still wasp
#

I'm gonna kill someone

glass jasper
# charred monolith

Anyways, I would just leave this up to Vee and creator of the code to decide

fallen vale
#

you are allowed to change the copyright owner, and you're allowed to own your own code.

fallen vale
fallen vale
glass jasper
#

this isn’t what this discussion was about about everyone knows you can do that, the problem is the name they chose makes it sound like a legal entity and not a person

#

Okay, that wording is not good

#

i mean

#

in this case it isnt a github organization but the post is still relevant

#

But we are past that as we know that this is a person and they can hold legal given someone named β€œKnocklive” reacted to Scyye’s message

#

I’m gonna stop talking now

charred monolithBOT
limber skiff
#

@fossil inlet I'm putting extra fixes in ur pr

fossil inlet
#

okie

limber skiff
#

nice

#

git didn't mark it as a rename

fossil inlet
limber skiff
#

got it

#

had to use git mv

fossil inlet
#

huh, never heard of that

#

always just used normal mv

limber skiff
#

I think they work the same lol

#

I just knew it existed so I used it instead

fossil inlet
#

off-topic, but is there a plan to add readme's to plugins that dont have them already

limber skiff
#

I dont remember but probably

#

not a priority though

charred monolithBOT
limber skiff
fossil inlet
#

vee had some choice words about that pr

fossil inlet
limber skiff
#

what is "it"

fossil inlet
#

but scroll down and you'll see

limber skiff
#

I'll leave it to them I guess

#

very useful

#

drunk?

#

plugins/CopyFileContents does not exist git

fossil inlet
limber skiff
#

I mean the scrolling changes lol

fossil inlet
#

oh

fossil inlet
limber skiff
#

I'm thinking the icon couldnt fit in the line

#

it went down and boom oversized

fossil inlet
#

thats what i thought

limber skiff
#

dang

fossil inlet
#

is that a public server?

limber skiff
#

what do you meannn

limber skiff
limber skiff
#

like what is even happening

fossil inlet
limber skiff
#

no way

image.png
#

did I mess something up/

fossil inlet
#

git reset my beloved

limber skiff
#

I literally cant fix it

#

OMG FINALLY

#

30 MINUTES TO FIX A GIT ISSUE

dusk blaze
#

stop using git

#

start using Copy of Copy of Copy of Copy of Copy of pluginthing.ts

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
limber skiff
#

NOOOOOOOOO

charred monolithBOT
fallen vale
#

#1827 which got moved to #1765.
wait what

#

am i missing context here

#

i mean i def am, but still

charred monolithBOT
desert cosmos
charred monolithBOT
limber skiff
#

holy identation

spark pivot
#

I hate programming permissions

#

Worst thing ever

fossil inlet
#

what

limber skiff
#

so stretched

#

nicee

#

like mod view does it

image.png
#

I should just make the text a bit bigger

#

hmm why is the color different

charred monolithBOT
limber skiff
#

this took so long

charred monolithBOT
limber skiff
#

okay not gonna lie this is cool

limber skiff
#

dang

#

can't get the matched groups

charred monolithBOT
#
Nuckyz
[Vencord:dev2] 5 new commits

74fd85b VolumeBooster: Fix on Vesktop (#2828) - sadan4
0c71d6c PermissionsViewer: Show RoleIcons & which role ... - vishnyanetchereshnya
d0ad4e6 MutualGroupDMs: Add Mutual Groups to DM Sidebar... - Masterjoona
27e81b2 Allow online themes to be applied only in dark ... - maddie480
accfc15 Ban ts-pattern normal import - Nuckyz

fallen vale
#

that pr is STILL open??

charred monolithBOT
fossil inlet
#

am i stupid, whats P

image.png
limber skiff
#

shorthand for patterns

fossil inlet
#

ah

limber skiff
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
Nuckyz
[Vencord:main] 5 new commits

74fd85b VolumeBooster: Fix on Vesktop (#2828) - sadan4
0c71d6c PermissionsViewer: Show RoleIcons & which role ... - vishnyanetchereshnya
d0ad4e6 MutualGroupDMs: Add Mutual Groups to DM Sidebar... - Masterjoona
27e81b2 Allow online themes to be applied only in dark ... - maddie480
accfc15 Ban ts-pattern normal import - Nuckyz

limber skiff
#

just SHUT THE FUCK UP

fossil inlet
#

LMAO

#

are you still dealing with that

limber skiff
#

IT KEEPS SHITTING

#

and like

fossil inlet
#

sorry trolley

limber skiff
#

I did nothing wrong

fossil inlet
#

relevant XKCD

limber skiff
#

it's my local git that's fucked up

#

I genuinely ont know wht to do

#

I'm gonna go insane I swear

#

????????????????

image.png
#

@fossil inlet can you pull dev and try to switch between old branches

#

please tell me it's not fucked up for you too

fossil inlet
#

which old branches in specific

limber skiff
#

anything that doesnt have the latest commits

fossil inlet
#

i have no issue with dev@head and main@968e688c

limber skiff
#

WHAT

#

where

#

tell me. where.

fossil inlet
limber skiff
#

actually ignore it im stupid

fossil inlet
#

i hid it

#

duality of man

limber skiff
#

I cant bro

#

it's literally not the working tree

fossil inlet
#

can you git rm them?

limber skiff
fossil inlet
#

@limber skiff git clean --help thats all i can think of

limber skiff
#

ive ran git clean with all the options lmao

fossil inlet
#

horror

#

tbh at this point it might be worth pulling vencord to another dir and dealing with this later

limber skiff
#

I never thought git would break so bad

charred monolithBOT
glass jasper
#

@limber skiff you still aint done this?

charred monolithBOT
limber skiff
glass jasper
limber skiff
#

It might be broken on the extension

#

it's definitely fixed

glass jasper
#

when was the last time y’all submitted the google extension?

limber skiff
#

yesterday

glass jasper
#

oof

#

ight ig there is a commit somewhere i’m not seeing

limber skiff
glass jasper
#

Xinto reference

IMG_7714.png
rugged spire
charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
#
maddie480
[Vendicated/Vencord] Pull request opened: #2832 PronounDB: fix pronoun tooltip

The text in the tooltip (after patching) is:

d.Z.Messages.USER_PROFILE_PRONOUNS + vcHasPendingPronouns ? "" : ` (${vcPronounSource})`

... which ends up checking if 'Pronomsfalse' is truthy, so the whole thing ends up evaluating to '', and we end up with an empty tooltip on the pronouns field in the profile.

Adding parentheses makes sure it's checking vcHasPendingPronouns only:

d.Z.Messages.USER_PROFILE_PRONOUNS + (vcHasPendingPronouns ? "" : ` (${vcPronounSource...
limber skiff
#

oh

#

lmao

#

that's funny

charred monolithBOT
charred monolithBOT
limber skiff
charred monolithBOT
rugged spire
scenic brook
#

That's how you stay better than them

fossil inlet
limber skiff
nimble plaza
#

the api to put the buttons there he means

shut vineBOT
#

@fossil inlet, <t:1725161682:R>: bundle font with webview

charred monolithBOT
fossil inlet
charred monolithBOT
scenic fog
#

what's the screenshot about πŸ€”

long stream
#

discord uses integers as references to enum values

scenic fog
#

oh I'm blind

long stream
#

silly

charred monolithBOT
scenic fog
#

am I supposed to just use 0 instead? πŸ€” that seems to be what FakeNitro does

long stream
#

im pretty sure you're supposed to use 1

#

the enum might be like this:

enum EmojiType = {
  Unicode = 0,
  Guild = 1,
}
#

lemme see if i can find it

scenic fog
#

ah yeah, emoji.type !== "GUILD_EMOJI" becomes emoji.type !== 1

#

yeah the values match those defined in the emoji types

attachment.png
long stream
#

guessed it xd

#

o i didnt see ur screenshot oops

charred monolithBOT
limber skiff
#

@fossil inlet

fossil inlet
#

cant work on it rn as school starts tomorrow

#

will try and fix this weekend

#

!remind saturday fix

shut vineBOT
#

Alright @fossil inlet, in 5 days: fix

frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

fallen vale
#

my beloved

limber skiff
#

hear me out

#

I think we should start normalizing plugins having space in their names

#

try to implement their readme parsing

fallen vale
limber skiff
#

and have the plugins page be a full screen thing like application browser

#

we need more space for better listing

#

vencord plugins list is huge and I think we are currently too limited by small cards

#

(settings layout also need a rewrite but that's something else)

#

perhaps category to divide plugins

limber skiff
#

@austere talon what do you think

austere talon
#

why the spaces

#

i agree with the rest though

limber skiff
#

easier to read

fallen vale
limber skiff
#

we can keep plugins name being the identifier

#

we just need an extra field for the display name

austere talon
#

idk people are used to single word names from other mods

#

Show Hidden Channels looks wrong xd

limber skiff
#

lol

#

Fake Nitro

fallen vale
limber skiff
#

the only one I have no idea how to do is readme support

glass jasper
limber skiff
#

I'm also horrible at UI design but hey it could be a good learning experience

glass jasper
scenic brook
#

Plugin to change My Cool Plugin name back to MyCoolPlugin

limber skiff
#

imagine a category called tweaks

#

and we just have every better plugin there

#

but without the Better

glass jasper
#

Spaces in names it’s just a crime to all that is holy

charred monolithBOT
limber skiff
#

I guess we can keep plugins without spaces but use spaces in the README?

charred monolithBOT
glass jasper
glass jasper
#

Still a crime but a little bit better

austere talon
#

we can just iframe vencord.dev/plugins/Plugin

limber skiff
#

oh

austere talon
#

we might have to change the website a little to allow only embedding the readme

limber skiff
#

I thought we were gonna embed the readmes inside of the js somehow

austere talon
#

without the rest of the site

limber skiff
#

and render them

limber skiff
#

gotta figure how to create a full screen page like application browser too

#

anyways I think it's definitely a good idea to improve the user experience next

#

then we can merge 57k more plugins

fossil inlet
long stream
#

expandedmarkdown plugin wen

limber skiff
austere talon
#

maybe we could render markdowns to raw html ahead of time

#

and just use that

limber skiff
#

we need to make it fit the discord theme though

limber skiff
#

I would personally not wanna scroll through all the list

#

and that's not a good thing

#

with bigger page we can do nicer settings too

austere talon
#

we need better cards maybe with image

limber skiff
#

oh yeah definitely

#

images

austere talon
#

i think images will immediately improve it so much

limber skiff
#

I completely agree

austere talon
#

anyway we need to make sure images are high quality (as in not bad images) and also as small as possible

limber skiff
#

we can lazy load them

austere talon
#

every plugin should have one banner which should be specific dimensions and showcase the main feature

limber skiff
#

with schooling

#

scrolling

austere talon
#

nah

#

just need to optimise them well

austere talon
#

should i add discord-api-docs github repo webhook here @limber skiff

glass jasper
austere talon
#

i don't mean in this very channel 😭

#

i mean to the server

glass jasper
#

oh…

limber skiff
#

they are always behind on documentation

austere talon
#

xd

#

i like seeing discussion of new features

limber skiff
#

well

#

if you want to sure

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
limber skiff
#

feels weird having our buttons added before the reactions

limber skiff
limber skiff
limber skiff
#

anyone smart enough to understand how this bypasses the audio element sinkId

image.png
#

I've tried setting the sinkId on the audio context too but no win

charred monolithBOT
charred monolithBOT
charred monolithBOT
#
MightyLoggor
[Vendicated/Vencord] Issue opened: #2837 [FEATURE REQUEST - BlurNSFW] - Blur Embedded Media

Content

[The topic in the discord support](#πŸ₯-vencord-support-πŸ₯ message)

Regarding the BlurNSFW, it would be ideal that it worked on linked images and embeds too.

At the moment it only blurs images(files) sent in the channel. If the image is embedded in a link or it's a pure image link from the web, the image is not blurred.

It would be interesting for the plugin to blur those embedded media too. Especially images.

E...

glass jasper
# limber skiff

I knew I recognized this from somewhere, Discord stole it from Slack

image.png
#

which I’m sure they stole from someone else

charred monolithBOT
fossil inlet
#

really helpful

charred monolithBOT
gritty canyon
#

oh my god

charred monolithBOT
charred monolithBOT
#
dependabot[bot]
[Vencord/Installer] New branch created: dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7
#
dependabot[bot]
[Vencord/Installer] Pull request opened: #140 Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows

Bumps actions/download-artifact from 3 to 4.1.7.

Release notes
Sourced from actions/download-artifact's releases.

v4.1.7
What's Changed

Update @​actions/artifact dependency by @​bethanyj28 in actions/download-artifact#325

Full Changelog: https://github.com/actions/download-artifact/compare/v4.1.6...v4.1.7
v4.1.6
What's Changed

updating @actions/artifact dependency to v2.1.6 by @​eggyhead in actions/download-artifact#324

Full Changelog: htt...

glass jasper
#

we have dependabot?

spark pivot
#

give dependabot contributer badge

glass jasper
charred monolithBOT
#
dependabot[bot]
[Vencord/Installer] New comment on pull request #140: Bump actions/download-artifact from 3 to 4.1.7 in /.github/workflows

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

#
dependabot[bot]
[Vencord/Installer] branch deleted: dependabot/github_actions/dot-github/workflows/actions/download-artifact-4.1.7
austere talon
glass jasper
austere talon
glass jasper
austere talon
#

until I realised it's the gif for once and not discord

glass jasper
#

what wrong with gif?

austere talon
#

funny stretched

glass jasper
#

ohh yea i also have a long plink

fossil inlet
#

@limber skiff did you ever try to fix the output issue with vekstop

limber skiff
#

yeah

#

and I failed

limber skiff
rugged spire
#

i have no idea how to manipulate sinkid there and i want to manipulate sinkid in many places (only theoretical for now)

fossil inlet
#

did discord push a new update

#

i think better Folders is broken

umbral hillBOT
# fossil inlet

⚠️ vencord.app is a fake malicious site! The only real website is https://vencord.dev! If you have downloaded anything from vencord.app, remove everything you have downloaded immediately, run a malware scan and change your Discord password.

fossil inlet
#

tessie L

jolly egret
#

it is trying!

fossil inlet
#

i did something

fallen vale
#

what is that something

frail skyBOT
#
Bad Patches

ServerListAPI (had no effect):
ID: 416568
Match: ```
/(?<=Messages.SERVERS,children:).+?default:return null}})/


**__BetterFolders (had no effect):__**
ID: `416568`
Match: ```
/(?<=\.Messages\.SERVERS.+?switch\((\i)\.type\){case \i\.\i\.FOLDER:.+?folderNode:\i,)/
Bad Webpack Finds 
find(e=>e.section!==void 0&&e.heading!==void 0&&Object.values(e).length===2...)
Bad Starts

None

Discord Errors

None

#
Bad Patches

ServerListAPI (had no effect):
ID: 416568
Match: ```
/(?<=Messages.SERVERS,children:).+?default:return null}})/


**__BetterFolders (had no effect):__**
ID: `416568`
Match: ```
/(?<=\.Messages\.SERVERS.+?switch\((\i)\.type\){case \i\.\i\.FOLDER:.+?folderNode:\i,)/
Bad Webpack Finds 
find(e=>e.section!==void 0&&e.heading!==void 0&&Object.values(e).length===2...)
Bad Starts

None

Discord Errors

None

fossil inlet
#

i seem to have fixed better folders

#

idk if you guys want my patch

fossil inlet
#

i tried to fix serverlistapi

#

but i cant understand that patch for the life of me

limber skiff
#

do you wanna leave that for me and take a look at volume booster

fossil inlet
limber skiff
#

is it easy fix or much changed

fossil inlet
#

easy fix

limber skiff
#

nah it's okay then

fossil inlet
#

order of functions was moved in module

limber skiff
#

I see

fossil inlet
#

and it used the order

fossil inlet
#

GUHHHH

image.png
#

is this a known issue with patch helper?

limber skiff
#

lol is it not in a try catch

fossil inlet
#

@limber skiff fixed the volume booster thingie

limber skiff
#

yo how

#

I stayed like an hour trying lmao

charred monolithBOT
fossil inlet
#

the method to change it is expermental, but chrome has had it since version 110

#

so it wasnt showing up in types

#

this does mean, it wont work in firefox on web (or safari)

#

i dont think theres a way around that

limber skiff
#

bro

#

I used that

#

it didn't work

fossil inlet
limber skiff
#

literally did the same thing

fossil inlet
#

ill send video one sec

limber skiff
#

however it was before creating the gain node

#

hmm

#

but yeah I found that method too

fossil inlet
limber skiff
#

okay but does it actually play in the other device

fossil inlet
#

neither of the devices i selected were default

limber skiff
#

ah

grizzled halo
limber skiff
#

yeah it's okay

fossil inlet
#

did discord remove hang statuses

charred monolithBOT
vivid garden
glass jasper
vivid garden
#

love how they broadcasted "i'm in a vc!" even to people who aren't mutuals in your server

glass jasper
charred monolithBOT
fossil inlet
vivid garden
#

nobody has it anymore

#

they've done this like four times at this point lmao

fossil inlet
#

Ah

#

Tbh it was a neat feature

vivid garden
#

it was alright but its shortcomings ruined it

#

the fact that it went after the (LIVE) badge
the fact it leaked you were in a vc even to people not in the server
the default "chilling" status

fossil inlet
vivid garden
#

i'm not sure if it was limited by whether people could see your "playing" status but it went out to everyone

#

it was noticable because you could go to the activity tab and if they had no other activities it would be blank

#

normally if there's no activities the tab didn't show up at all

charred monolithBOT
austere talon
#

format your code properly JeanDead

limber skiff
#

is setSinkId not yet typed in typescript πŸ’”

austere talon
#

he alr said no

#

ts doesn't type experimental stuff

limber skiff
charred monolithBOT
frail skyBOT
#
Bad Patches

ServerListAPI (had no effect):
ID: 416568
Match: ```
/(?<=Messages.SERVERS,children:).+?default:return null}})/


**__BetterFolders (had no effect):__**
ID: `416568`
Match: ```
/(?<=\.Messages\.SERVERS.+?switch\((\i)\.type\){case \i\.\i\.FOLDER:.+?folderNode:\i,)/
Bad Webpack Finds 
find(e=>e.section!==void 0&&e.heading!==void 0&&Object.values(e).length===2...)
Bad Starts

None

Discord Errors

None

#
Bad Patches

ServerListAPI (had no effect):
ID: 416568
Match: ```
/(?<=Messages.SERVERS,children:).+?default:return null}})/


**__BetterFolders (had no effect):__**
ID: `416568`
Match: ```
/(?<=\.Messages\.SERVERS.+?switch\((\i)\.type\){case \i\.\i\.FOLDER:.+?folderNode:\i,)/
Bad Webpack Finds 
find(e=>e.section!==void 0&&e.heading!==void 0&&Object.values(e).length===2...)
Bad Starts

None

Discord Errors

None

charred monolithBOT
#
Nuckyz
[Vencord:dev2] 5 new commits

c51d7b8 ReviewDB: Fix wording in server reviews (#2826) - junepark678
4c4f289 PronounDB: Fix patched pronoun tooltip (#2832) - maddie480
30e4e83 NoServerEmojis: Fix detecting server emojis (#2... - maddie480
7f784be SecretRingToneEnabler: Option to always play Sn... - ramzialhaddad
59aac4c Fix BetterFolders and FriendsSince - Nuckyz

charred monolithBOT
charred monolithBOT
austere talon
#

that option is also the wrong way round

#

I would fix it before merging

# 
- Do not dearrow by default
+ Dearrow videos automatically
limber skiff
#

I forgot that you prefer it like that

limber skiff
#

fucking typo made me not merge

austere talon
#

"invert" is an awful name

limber skiff
#

I agree with you

austere talon
#

"dearrowByDefault" is much better

#

but thanks for reviewing stuff

#

should bump too unless there's more stuff that should be merged in the coming few days

limber skiff
#

I wanna merge the roles plugin first

austere talon
#

idk how to make that one not confusing as hell

#

also is the current design even good

#

it might be a better idea to add a button to switch to the server member profile for yourself

#

instead of just hacking roles in

charred monolithBOT
limber skiff
austere talon
#

like a button or smth

#

that opens the server member profile

limber skiff
#

there isnt much to see though

#

I feel like roles is the most important

#

and maybe the nickname or something

austere talon
#

Nick
server avatar
server banner
etc

limber skiff
#

I wonder how easy would it be to add a button to close the panel profile and open the server profile in the same place

#

I'm not sure how it decides where to open a popoup at

austere talon
#

shouldn't be hard with the popout

charred monolithBOT
#
Nuckyz
[Vencord:main] 7 new commits

c51d7b8 ReviewDB: Fix wording in server reviews (#2826) - junepark678
4c4f289 PronounDB: Fix patched pronoun tooltip (#2832) - maddie480
30e4e83 NoServerEmojis: Fix detecting server emojis (#2... - maddie480
7f784be SecretRingToneEnabler: Option to always play Sn... - ramzialhaddad
d10e649 VolumeBooster: Fix playing sound in wrong outpu... - sadan4

limber skiff
#

I

#

forgot the commit name

#

it's fine

#

@grizzled halo quicker than me

image.png
grizzled halo
#

:3

charred monolithBOT
#
Scyye
[Vendicated/Vencord] New comment on pull request #2836: feat(Plugin): OwnProfileRoles

I'm thinking rename the plugin to AccountPanelRoles and change the description to Allows you to view your roles in the current server through the account panel in the bottom left, without having search for your server profile in another place, like the member list

Allows you to view your roles in the current server through the account panel in the bottom left, without having to search for your server profile in another place, like the member list

gritty canyon
#

shortest plugin description ever

opaque silo
#

just

Show your server roles in account panel popout

limber skiff
#

okay so understand correct

#

if I make a button inside the panel profile component, which renders a popout it's going to render it according to the place of that button

#

but I want to render in the same place as the old panel profile

#

should I modify the renderPopout of it somehow and change the component being rendered

charred monolithBOT
austere talon
limber skiff
#

a boolean in the plugin object should do the work

#

πŸ˜›

charred monolithBOT
austere talon
#

add a toggle which will switch between Y.Z and the member profile

limber skiff
#

I thought of a button that makes it happen once

#

and place that button somewhere here

image.png
#

a context menu option should be good enough

hexed star
limber skiff
#

ngl

#

all this simplified profiles stuff

#

was great

#

the new code is so much better

#

and they actually re-use components instead of duplicate stuff everywhere

hexed star
#

yea, agree with u, but those 4 buttons taking up almost 50% of profile area.. πŸ₯Ή (excluding profile bio + activity)

charred monolithBOT
limber skiff
#

LO

#

if (embed.thumbnail.proxyURL) embed.thumbnail.proxyURL = replacementProxyURL;

charred monolithBOT
opaque silo
uneven needle
#

I feel like in the user popout it would get crowded
and i dont think its useful there

opaque silo
#

and the compacted text alternative?

#

honestly I disagree that its not useful there. that entry in the pop out is meant to convey connections u have to the person

uneven needle
inland fable
grave mangoBOT
inland fable
#

I think either

align?: "left" | "right" | "center";

or

align?: LiteralUnion<"left" | "right" | "center", string>;

would be better

#

i see a few other places where I could pr better string specificity as well
i'll pr soon

charred monolithBOT
charred monolithBOT
fallen vale
scenic brook
#

Seems to be matching slash commands

#

Oh the title says it already lol

fallen vale
#

why

scenic brook
#

I don't know what as you can just copy your message bar to get it means but I imagine it's because it previews the literal command text you wrote and not the result of it?

fallen vale
#

im still quite confused

long heart
#

hello chat

#

important announcement incoming

long stream
#

support helper (and other plugins that register slash commands probably) seem to be causing a crash now when searching for slash commands cuz the commands lack the untranslatedName field

dusk blaze
#

moremorecommands so done for :(

long stream
#

whats with the fire reactions 😭

gritty canyon
#

thats a fire issue

charred monolithBOT
long stream
#

(i got unlazy)

#

omg a test failed 😭

#

wait how the heck did it build for me but not for the workflow

long heart
#

make the fields optional

long stream
#

omg right 😭

charred monolithBOT
long heart
#

actually nvm

#

you should use nullish coalescence in case plugins want to specify it

#

??=

long stream
#

til

austere talon
#

what now

long heart
#

is there a case in which untranslatedName takes precedence

#

otherwise no point tbf

rugged spire
austere talon
#

cant repro

#

skill issue unfortunately...

wary relic
austere talon
#

ye

wary relic
#

it crashes for me as well

long stream
#

it happens on latest canary

wary relic
#

yeah

austere talon
#

hop off canary

wary relic
#

i ❀️ canary

long stream
#

dont wanna

#

canary <3

austere talon
#

true..

image.png
long stream
#

tbh a better fix would be finding what in the client registers a command

#

with the proper object

#

but im too lazy

charred monolithBOT
austere talon
#

harukie pushing malware...

image.png
long stream
#

okayy finee im gonna setup gpg keys again 😭

rugged spire
wary relic
#

just type slash and then any letter

rugged spire
#

ah

#

yeah it does crash

#

i thought it was invalid because i use arrow keys up/down to select commands usually

#

well

#

at least when i initially tested it

fossil inlet
rugged spire
#

I WAS LITERALLY GOING TO SAY THAT BUT I DIDNT

dusk blaze
#

gpg has lots of uses

#

can also sign messages

fossil inlet
#

gpg too much of a pain in the ass

dusk blaze
#

and it works anywhere

#

some git forges dont have ssh

fossil inlet
#

so does ssh

dusk blaze
#

(mine)

fossil inlet
dusk blaze
#

oh

rugged spire
#

i sign my commits with my ssh key and never use git over ssh

glass jasper
#

i just add files via upload

rugged spire
umbral hillBOT
glass jasper
#

I’m not joking until recently that’s how I used to do things and @dapper crest can actually vouch for that because they were the ones who helped me set up VS code to do that

dapper crest
glass jasper
fallen vale
#

delete the vencord repo, and reupload everything with drag and drop :3

dapper crest
glass jasper
charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New review comment on pull request #2803: feat: hideRepliesToBlockedMessages 
        if (!Settings.plugins.NoBlockedMessages.hideRepliesToBlockedMessages || !message)
            return false;

		try {
        	const { messageReference } = message;
	        if (!messageReference) return false;
	        
	        const replyMessage = MessageStore.getMessage(messageReference.channel_id, messageReference.message_id);
	        return this.isBlocked(replyMessage);
	    } catch (e) {
            new Logger("NoBlockedMessages").error("Failed to check...
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

BadgeAPI (had no effect):
ID: 184325
Match: ```
/(?<=text:(\i).description,.{0,50})children:/


**__RoleColorEverywhere (found no module):__**
ID: `-`
Match: ```
location:"UserMention
Bad Webpack Finds

None

Bad Starts

None

Discord Errors 
Failed to load CommandsApi
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

austere talon
#

guhhh

frail skyBOT
#
Bad Patches

BadgeAPI (had no effect):
ID: 184325
Match: ```
/(?<=text:(\i).description,.{0,50})children:/


**__RoleColorEverywhere (found no module):__**
ID: `-`
Match: ```
location:"UserMention
Bad Webpack Finds

None

Bad Starts

None

Discord Errors 
Failed to load CommandsApi
austere talon
#

Failed to load CommandsApi

rugged spire
#

no way remotecodeexecution broke again blobcatnom

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

#
Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

charred monolithBOT
austere talon
#

okay now

charred monolithBOT
#
Vendicated
[Vendicated/Vencord] New tag created: v1.10.1
dusk blaze
charred monolithBOT
rugged spire
austere talon
#

it was funny the first time but now it's just kinda annoying

#

force pushing is part of normal git operations

rugged spire
#

true i will admit i force push over my fuckups occasionally blobcatcozy

dusk blaze
#

tbh i occasionally force push

#

i love

#

especially on personal projects where idc about overriding history

rugged spire
#

though force pushing to dev is somewhat husk because what if innocent user like me likes to base upon that branch for my horrible curesd things

dusk blaze
#

STOP BASΔ°NG ON DEV

charred monolithBOT
dusk blaze
rugged spire
dusk blaze
median rapids
#

git over ssh so good

#

except for random public wifis that block port 22

fossil inlet
charred monolithBOT
fallen vale
charred monolithBOT
#
Nuckyz
[Vendicated/Vencord] New comment on pull request #2836: feat(Plugin): AccountPanelRoles

saw the discussion on discord and thought maybe adding something like a server name/tag above roles would improve usability? i don't think the ability to switch between user and member profile would be easier to maintain and I can't imagine how it would be from UX perspective. one more click to just see roles?

I'll experiment with it switching the member profile and see what I can do

rugged spire
#

explode

#

you love a PR where 70% of the commits are just merging main in

limber skiff
#

347475

image.png
limber skiff
rugged spire
#

not what i was talking about but I totally get it

limber skiff
#

yeah but mine suffers from that too

rugged spire
#

yours has a good reason

limber skiff
#

yeah I got port the new stuff

#

If I leave it for later im gonna forget something

rugged spire
#

im just going through my github notifications and seeing what interesting things I've commented on and are getting notifications for

fossil inlet
#

@rugged spire you will review 2791 blobcatcozy

limber skiff
rugged spire
#

this is an issue on regular devcompanion tbh

#

it doesnt auto reconnect

limber skiff
#

okay so what i need is

fossil inlet
limber skiff
#

userId, guildId and channelId

#

cool

fossil inlet
#

my idea was on disconnect, it will try five times to reconnect
once every 30 seonds

rugged spire
#

no

fossil inlet
rugged spire
#

dum questionℒ️: why shouldnt it try to reconnect forever if its localhost

fossil inlet
#

the common sense in me says thats a terrible idea

rugged spire
#

ok

#

so

#

you know how theres this filesystem watcher for css changes in dev builds

fossil inlet
#

yea...

rugged spire
#

something like that for the server to tell the client that it should connect back to the dev companion server

fossil inlet
#

it would be nice if my editor loaded in less that 10 seconds

#

nevermind, still loading

#

how can neovim be this fucking slow

rugged spire
#

are you using neovim to make a vscode extension????

#

crazy

fossil inlet
#

@rugged spire do you know where the code that handles hot reloading css is?

rugged spire
#

i forgot

#

i am busy

fossil inlet
#

guhhh its 2 am

#

i eep

#

ill do this on the weekend

#

remind me

rugged spire
#

nop

limber skiff
#

LOL

#

FIRST TRY

rugged spire
#

you set the reminder yourself

rugged spire
limber skiff
limber skiff
rugged spire
#

OH

limber skiff
#

cool as fuck

charred monolithBOT
rugged spire
#

am i too brutally honest or am I mean

limber skiff
#

hmm

#

that's sooo cool

charred monolithBOT
limber skiff
#

INTERESTING

#

it doesnt render when shift click πŸ’”

limber skiff
#

this has to not be the best way

#

a little better

brazen bone
#

Huh, so there are react internals that you don't get fired for using?

limber skiff
#

PEAK

limber skiff
#

I did it

scenic brook
#

Was sick of clicking reconnect just because I restarted the sandbox the plugin was in