👾-core-development

[dusk blaze]

core development more like "what is best editor for" core development

[limber skiff]

but outside of that it works perfectly

[fossil inlet]

@limber skiff yea, the patch is no longer needed from what i can see

huh

[limber skiff]

try it

[austere talon]

we're not saying it's better

the point is that vencord is made to be developed using vscode

[granite sky]

Nobody stops you from using the formatter in nvim
The only benefit that I gave with using vs code for plugin dev - companion extension

[austere talon]

by not using vscode you miss out on a lot of the configuration which leads to you pushing badly formatted code like this

[fossil inlet]

yea, its going to zero when its at ~0-10%

[limber skiff]

yep

is it fixable?

[fossil inlet]

off the top of my head, i could set the volume on the element to just the volume if its less than 100% and use the gainNode for anything over 100

[limber skiff]

seems like a good idea

but then you also need to clean up stuff if it's set to <100 later

[fossil inlet]

figured id just something like this

[limber skiff]

yeah but dont you need to delete the gainNode

[fossil inlet]

let me try it

ill see

hopefully not

[limber skiff]

can you also enable this in your pr

I wanna push a commit

[fossil inlet]

ok

[austere talon]

always enable that

never disable

[limber skiff]

guhh

why doesnt it work

[austere talon]

the only time you wanna disable that is if you're pring from a branch that people are actively using and you don't trust the maintainers

[austere talon]

use gh cli

[limber skiff]

I am

[austere talon]

oh

[limber skiff]

but it didnt setup the git push properly

[austere talon]

wtf is that remote

[austere talon]

wdym?

gh pr checkout 123
git push

[limber skiff]

yep

[austere talon]

if the person prd from main branch it will error but tells you the command to run

just copy paste the top one

[austere talon]

insane

[limber skiff]

it worked before idk why its not now

[austere talon]

why does it tell you to run that

[limber skiff]

that command actually works too

but now it's not either

now it worked??

fucking insane

[fossil inlet]

@limber skiff this fixes the low volume issues, but you have a bit of clipping when chainging to over/under 100%

if(data._volume <= 100){
            if(data.gainNode){
                data.gainNode.gain.value = 0;
            }
            return data._volume / 100;
        }

[limber skiff]

by clipping you mean a small window where it becomes 0 and then comes back?

[fossil inlet]

let me get a recording

[austere talon]

can we always have the gain node and have it set to 1?

is 1 noop?

or is 0 noop

[fossil inlet]

let me try 1

i think 1 wouldnt work tho

[limber skiff]

i did something

my ears exploded

[fossil inlet]

😭

[fossil inlet]

0 is noop

1 removed all adjustment below 100%

[austere talon]

oh

https://developer.mozilla.org/en-US/docs/Web/API/AudioParam/linearRampToValueAtTime

maybe this might help

yop

If modified, the new gain is instantly applied, causing unaesthetic 'clicks' in the resulting audio. To prevent this from happening, never change the value directly but use the exponential interpolation methods on the AudioParam interface.

but it says to use exponential instead of linear

[limber skiff]

i fucked up

[fossil inlet]

😭

[limber skiff]

my fault

[fossil inlet]

how?

[limber skiff]

pull from github

I fixed it

[fossil inlet]

i didnt pull anything that you pushed yet 😭

[limber skiff]

oh

I broke it anyways

[fossil inlet]

[fossil inlet]

just tried this, couldnt get it to sound better, it just added more clicking

[fossil inlet]

@limber skiff do you think this sounds better or worse that the message i replied to

[limber skiff]

ehhh it's fine probably

[austere talon]

it'd be better to fix it

do we even need discords function

what if we don't use it

[limber skiff]

wouldnt it be better to debug why it doesnt work when the gain is low

[austere talon]

how much does it change things

[limber skiff]

and always use the gainNode

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request review submitted: #2730 Port volume booster to web/vesktop

sadan4

[Vendicated/Vencord] New review comment on pull request #2730: Port volume booster to web/vesktop

I'll push the fixes to your changes when I push my fix for low volumes

2JENO

[Vendicated/Vencord] Issue opened: #2758 [Bug] button is invisible

Discord Account

LJeno

What happens when the bug or crash occurs?

What is the expected behaviour?

idk

How do you recreate this bug or crash?

just move mouse on messege

Errors

Replace this text with your crash-log.

Request Agreement

• [X] I am using Discord Stable or tried on Stable and this bug happens there as well
• [X] I have read the requirements for op...

[pine topaz]

horror

[charred monolith]

surgedevs

[Vendicated/Vencord] New comment on issue #2758: [Bug] button is invisible

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

2JENO

[Vendicated/Vencord] Issue closed: #2758 [Bug] button is invisible

2JENO

[Vendicated/Vencord] New comment on issue #2758: [Bug] button is invisible

oh sorry

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[charred monolith]

2JENO

[Vendicated/Vencord] New comment on issue #2758: [Bug] button is invisible

oh and fixed on current update sorry..........

[gritty canyon]

i wish i was allowed to harm people like this

[charred monolith]

2JENO

[Vendicated/Vencord] New comment on issue #2758: [Bug] button is invisible

nvm fixed

[glass jasper]

https://media.discordapp.net/attachments/974367202130157599/1223143677027680276/4x-ezgif.com-avif-to-gif-converter.gif

[gritty canyon]

DUDE

[gritty canyon]

im upgrading this to i wish i was allowed to KILL

[glass jasper]

https://media.discordapp.net/attachments/974367202130157599/1223143677027680276/4x-ezgif.com-avif-to-gif-converter.gif

[fossil inlet]

@limber skiff think i solved it
it seems we only need to call amplitudeToPerceptual on higher values

if it is called on lower values it just brings things lower than 20 to 0

[charred monolith]

Nuckyz

[Vencord:immediate-finds] 1 new commit

f398a1c fix breaking settings :sob: - Nuckyz

[limber skiff]

how did you find about amplitudeToPerceptual?

[fossil inlet]

the volume i was geting passed when the slider was at 400 was 759 iirc

dug in discords code for 30 minutes to find out why

[limber skiff]

and how doesnt it break when discord uses it?

[fossil inlet]

i have no idea

working on that now

[limber skiff]

troll

let me see if I can find

works fine

I think the issue is the gain being too low

0.05

[fossil inlet]

still looking into it, as the values that get passed change with one of my patches

[limber skiff]

also that really is the right name of the function

[fossil inlet]

thats what vee wanted to call it, wasnt going to argue

is this just what the max volume gets multiplied by?

[limber skiff]

yeah

[charred monolith]

I-uselinuxbtw

[Vencord/Vendroid] New star added

[limber skiff]

utils/PerceptualVolumeUtils.tsx

[limber skiff]

this just changes the max value of the sliders btw

[fossil inlet]

me wondering why the changes arent up

[fossil inlet]

yea, ik

[charred monolith]

imZuxi

[Vendicated/Vencord] New comment on pull request #2641: feat(MessageLogger): Ignored Word

could you describe a use case for this feature that wouldn't be solved by blacklisting specific users? the only use case I can imagine are things like automated messages that regularely get deleted and have no significance after deletion but you can just blacklist the bot in question

The use case primarily intended is for when a server uses a bot to delete spam messages. By blocking commonly posted items from being logged, such as links, I can prevent spam links from being logged. For in...

[fossil inlet]

@limber skiff idk if i'm going crazy, but from what i just tried, with the plugin disabled, i get zero output below 8%

seems like a stock discord issue

[limber skiff]

lmao?

[fossil inlet]

good way to disable vencord

[shut vine]

@jagged cloak, <t:1722480529:R>: maybe

[jagged cloak]

already did xdd

[charred monolith]

thororen1234

[Vendicated/Vencord] Pull request review submitted: #2710 feat(plugin): StatusWhilePlaying

thororen1234

[Vendicated/Vencord] New review comment on pull request #2710: feat(plugin): StatusWhilePlaying

In my testing on game launch it does set saved status to the prior status and then on game close it sets it to the status prior to launching the game.
However it might be best to declare it outside the function what are your thoughts?

[gritty iris]

I don't understand what I was doing with this code when I made saved status the hell

[fossil inlet]

Me writing code at 3am

[charred monolith]

thororen1234

[Vendicated/Vencord] Pull request review submitted: #2710 feat(plugin): StatusWhilePlaying

thororen1234

[Vendicated/Vencord] New review comment on pull request #2710: feat(plugin): StatusWhilePlaying

Nvm I have no clue why I did that such a weird way. savedStatus doesn't exist anymore and now just uses status in place of it, no redefines nothing.

[gritty iris]

It was doing savedStatus= ""

And then when a game was launched

(get status)
savedStatus = status

I have 0 why I did that but it's fine now

I screwed up the spacing... - nvm web is bugging

I just realized why savedstatus existed - im still lost

[rugged spire]

how do i convince advaith to fix Mod View depending on MemberSafetyStore being loaded properly so my patch to fix it isn't required anymore

[gritty iris]

I made it a switch statement (it didnt matter)

[charred monolith]

sunnniee

[Vendicated/Vencord] Pull request review submitted: #2692 add more stuff to vencord debug

sunnniee

[Vendicated/Vencord] New review comment on pull request #2692: add more stuff to vencord debug

i get what you mean, but they're more of a "why not". it's a lot quicker to tell someone to /vencord-debug than asking questions, and at least with moyai you can def make a vague support request like "why does my discord make random sounds". maybe replace the ⚠️ with a ℹ️ to indicate its not necessarily a bad thing?

thororen1234

[Vendicated/Vencord] New comment on pull request #2710: feat(plugin): StatusWhilePlaying

Alright so it now checks if the status being set and the current status are the same. For the savedStatus it will get a value when a game is launched (game length is above 0) and used when the game is closed ( game length is 0) I have also moved it outside of the flux event and it also checks if it isn't "" when updating to the old status.

[gritty iris]

my brain had a stroke looking at my code for some reason

[charred monolith]

aloshTM

[Vendicated/Vencord] Issue opened: #2759 [Bug] [Minor bug] ShowHiddenChannels has inaccuracies with the lock icon based on permissions

Discord Account

ayelosh

What happens when the bug or crash occurs?

The lock icon shown should either be the Discord lock icon or the plugin icon based on the permissions of the user and the channel.
If the channel disallows Connect, but still allows View Channel, the Discord lock icon will be shown instead of the plugin one.

This is a very small bug/unsure if it even is one so please take this with a grain of salt

![image](https://github.com/user-attachments/assets/abad...

aloshTM

[Vendicated/Vencord] Issue opened: #2760 [Minor bug] "Plugins that require a restart" notice at above of plugins page when toggling a plugin does not persist upon closing/reopening

Discord Account

ayelosh

What happens when the bug or crash occurs?

When toggling a plugin, the notice for "This plugin requires a restart" does not persist if you close and reopen the plugins page. This could be an issue if a person toggled a plugin on accident and didn't know about it

What is the expected behaviour?

The notice should persist

How do you recreate this bug or crash?

1. Go to Vencord Plugins menu
2. Toggle a plugin
3. Observe the notice being there
4. C...

surgedevs

[Vendicated/Vencord] New comment on issue #2760: [Minor bug] "Plugins that require a restart" notice at above of plugins page when toggling a plugin does not persist upon closing/reopening

This happens because Vencord gives you a warning before you leave the plugin page:

Furthermore I have not yet seen you report these in the Vencord Discord server. Please read the requirements for opening issues:

[gritty canyon]

the world if people would read issue requirements 💔

[austere talon]

well it's fine if the issues are competent which these seem to be

that requirement is just there because like 90% of issues we would otherwise get are invalid 😭

[shut vine]

@austere talon, <t:1722726559:R>: https://eslint.org/docs/latest/rules/space-after-keywords

[rugged spire]

can we blame sadan for this

I love clicking links saying "This was depreciated" and it takes you to another page saying "This is also depreciated"

[gritty canyon]

WTF

[rugged spire]

I am not joking btw

[gritty canyon]

space-after-keywords deprecated by keyword-spacing deprecated by @stylistic/eslint-plugin-js's keyword-spacing but its recommended to use @stylistic/eslint-plugin

[rugged spire]

[rugged spire]

i love javascript ecosystem

[dusk blaze]

petition for shiggybot to kill off all non contributor issues

[rugged spire]

nop

[analog knoll]

Isn't ScreenCaptureKit a macos api :D

https://github.com/Vencord/Vesktop/issues/324 is this the issue you're mentioning

[analog knoll]

I tried to look into implementing the option to set volume above 100% in vesktop. I am I correct that I would ideally need to modify vencord to give me the needed user context action sections?

This is the vesktop implementation of adding another settings section as an example of getting needed stuff from vencord

const customSettingsSections = (
    Vencord.Plugins.plugins.Settings as any as { customSections: ((ID: Record<string, unknown>) => any)[] }
).customSections;

customSettingsSections.push(() => ({
    section: "Vesktop",
    label: "Vesktop Settings",
    element: SettingsUi,
    className: "vc-vesktop-settings"
}));

Where Vencord.Plugins.plugins is this export declare const plugins: Record<string, Plugin>; imported from vencord

[rugged spire]

Yeah makes sense you can also look at how #1257070841372610581 does it?

[uneven needle]

There's an open pr for implementing that

[austere talon]

this has nothing to do with it

anyway theres a pr for >100% vol

[analog knoll]

Could you link it, I tried searching prior to exploring the possible implementations, but didn't find it

[uneven needle]

https://github.com/Vendicated/Vencord/pull/2730

[fossil inlet]

use eslint as my formatter of choice
project uses eslint
project doesn't have the eslint rules they want
mfw

[rugged spire]

you will also see why eslint rules arent in place

[rugged spire]

@fossil inlet what the fuck is that

[fossil inlet]

I have a personal eslint config that if you saw it you would probably have a stroke

[rugged spire]

Care to show me what code it produces

[fossil inlet]

I think you can find the config in my .files repo.

[fossil inlet]

https://eslint.style/rules/js/keyword-spacing

[charred monolith]

LukDun

[Vendicated/Vencord] Issue opened: #2761 [Bug] translating other people's messages button not appearing.

Discord Account

lukdun

What happens when the bug or crash occurs?

I checked and translate is on and my then cord is updated but the button that usually appears on messages to translate them to different languages is not there put the button on the send a message bar at the bottom for translate is there and I can translate my messages into other languages I just can't translate other people's messages into English or any other language because the button for it is not on the message...

[fossil inlet]

me when i cant read

[charred monolith]

ZoamIl

[Vendicated/Vencord] New comment on pull request #2749: Introduce StyleListener API

cool idea but did your idea die

[gritty canyon]

btw @dapper crest https://github.com/Vendicated/Vencord/pull/2749#discussion_r1700442809

no response ☹️

(icymi)

[charred monolith]

Vendicated

[Vendicated/Vencord] Issue closed: #2761 [Bug] translating other people's messages button not appearing.

[austere talon]

why is this guy acting like years have passed

[scenic fog]

a whole four days of inactivity 😱

[crude hearth]

this guy hasnt seen the fate of pull request 376

[dapper crest]

Lazy
I will get to it eventually

[glass jasper]

that’s just most of your Pr(s) Mantika

[charred monolith]

aspauldingcode

[Vencord/Installer] New comment on issue #128: CLI version for mac?

+1

Sanceilaks

[Vendicated/Vencord] Issue closed: #1786 [Feature Request] Use DeepL in translate plugin

[fallen vale]

very useful comment, thanknyou

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[fallen vale]

fucking miracle

[still wasp]

Rare occurance

[dusk blaze]

love

[pine topaz]

how it feels to have no broken patches

[charred monolith]

Scyye

[Vendicated/Vencord] Pull request review submitted: #2642 feat(plugin): ExtraConnectionLinks

nitpicky, but you requested a review so you got it.

Scyye

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

what?
whats this doing?

Scyye

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

This is located in the readme, theres no technical issue with having it here too, just seems redundant from a readability perspective.

Scyye

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

Why not just go based off the names of the types themselves?
and rename Epic to EpicGames;?

Scyye

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

I personally dont think its needed to have a title thats just 2 subtitles concatenated

ryanccn

[Vendicated/Vencord] Pull request opened: #2762 fix(ServerInfo): don't display avatar in modal when MentionAvatars is enabled

Before	After

[desert cosmos]

waiting for discord to add md table support

[spark cove]

ok my morning has started

do i investigate this in windows sandbox now, or do i make >100% volume

i have some code for the latter already from an equalizer browser extension i made earlier

[rugged spire]

[spark cove]

LMAO

why was that even changed 😭

[rugged spire]

i dont know

WHEN WAS IT EVEN CHANGED???

[brazen bone]

I guess someone dislikes "don't do x" bools

[spark cove]

oh wait ur right

i forgot current does not mean from remote

[rugged spire]

im guessing I merged this PR into my own fork myself

before that happened

and this appeared due to squashed merges

Yop https://github.com/Vendicated/Vencord/pull/2725/commits/d86ded501e3bf2c2c2ccaa625c013b4c7dfc1eae

ok time to get back to stealing guilded features

[austere talon]

yes

they're bad

confusing to the user

feature switches should usually be positive

[brazen bone]

Positive and negative is sometimes hard to define

But I think off should be "don't change vanilla discord behavior" when applicable

[austere talon]

100 vol alr exists

[spark cove]

ohh wait actually

i was reading vesktop roadmap and it was unchecked

so i thought it wasnt

[austere talon]

cause its wip

[spark cove]

ah

[charred monolith]

aloshTM

[Vendicated/Vencord] Issue closed: #2759 [Bug] [Minor bug] ShowHiddenChannels has inaccuracies with the lock icon based on permissions

aloshTM

[Vendicated/Vencord] Issue closed: #2760 [Minor bug] "Plugins that require a restart" notice at above of plugins page when toggling a plugin does not persist upon closing/reopening

aloshTM

[Vendicated/Vencord] New comment on issue #2760: [Minor bug] "Plugins that require a restart" notice at above of plugins page when toggling a plugin does not persist upon closing/reopening

q

[austere talon]

q

[verbal pumice]

q

[glass jasper]

q

[gritty canyon]

q

[rugged spire]

q

[somber thorn]

q

[fallen vale]

p

[brazen bone]

b

[rugged spire]

d

[long stream]

https://youtu.be/EQH2Pb8FTac

[rugged spire]

youtube ad jumpscare

oh

i never updated my vencord

oops

this even broke uploading files

[brazen bone]

My favorite plugin

I especially like how it {feature}

[charred monolith]

konek101

[Vendicated/Vencord] Pull request opened: #2763 Vc notifier plugin

this plugin adds notifications to the voice channels for now only the notification for when the voice channel has a slot available for the user but i want to expand it to allow for overall custom notifications if anyone has any ideas i started with this notification as it was an issue of mine that this is a solution for

its just an addition to the channel context menu that pops up this

i unders...

miklosakos

[Vendicated/Vencord] Issue opened: #2764 [Bug] Vencord on macOS does not support multi-user setups

Discord Account

miklos_akos

What happens when the bug or crash occurs?

If user x installs Vencord using the installer on macOS where more than one user is present, user y's instance will try to read from user x's Application Support directory.

What is the expected behaviour?

I expect Vencord to be able to handle multi-user setups.

How do you recreate this bug or crash?

1. Create user x
2. Install Vencord as user x
3. Sign into Vencord as user x
4. Switch to use...

[fallen vale]

what

[limber skiff]

stretched vee

[charred monolith]

Nuckyz

[Vendicated/Vencord] Pull request review submitted: #2762 fix(ServerInfo): don't display avatar in modal when MentionAvatars is enabled

Nuckyz

[Vendicated/Vencord] New review comment on pull request #2762: fix(ServerInfo): don't display avatar in modal when MentionAvatars is enabled

Nuckyz

[Vendicated/Vencord] New review comment on pull request #2762: fix(ServerInfo): don't display avatar in modal when MentionAvatars is enabled

            {Vencord.Plugins.isPluginEnabled("MentionAvatars") ? null : <img src={ownerAvatarUrl} alt="" onClick={() => openImageModal(ownerAvatarUrl)} />}

[austere talon]

hop off ? null :

[limber skiff]

why

[austere talon]

&&

[limber skiff]

react doesnt like a boolean to be used

[rugged spire]

ok but

[austere talon]

false?

[limber skiff]

it only works cuz enabled is any

[rugged spire]

why not use ||

[austere talon]

no

[limber skiff]

are you sure?

[rugged spire]

lol what

[austere talon]

yes

react ignores false, undefined, null, ...

you just can't use number

or it will put 0 in there

[rugged spire]

what heppens if you pass true

[austere talon]

i think it will render "true"

[rugged spire]

horror

oh thats right

i want to edit ShowTimeoutDuration again

[rugged spire]

mfw client warns me sending this message

[limber skiff]

I had an issue somewhere with it

let me see if I can find

[austere talon]

if u use number

{array.length && <div>hi</div>}

this will render 0

but this works

{!!array.length && <div>hi</div>}
{array.length > 0 && <div>hi</div>}

[charred monolith]

Pkp107

[Vendicated/Vencord] New comment on pull request #730: feat(plugin): BetterScreenshare, BetterMicrophone, PhilsPluginLibrary

Stupid question but how do I download this masterpiece?

[limber skiff]

tf?

I promise you this was erroring before

cursed

[charred monolith]

Nuckyz

[Vencord:immediate-finds] 1 new commit

473109b idk anymore - Nuckyz

[rugged spire]

[scenic fog]

Wow

[rugged spire]

[spice python]

seems like a direct port from some bd plugin

[rugged spire]

because it is

lol

[spice python]

[austere talon]

ya it's nowhere near mergeable

[rugged spire]

bd boilerplate horrors

[charred monolith]

twisty-nado

[Vendicated/Vencord] New comment on pull request #730: feat(plugin): BetterScreenshare, BetterMicrophone, PhilsPluginLibrary

Stupid question but how do I download this masterpiece?

also curious lol

twisty-nado

[Vendicated/Vencord] New comment on pull request #730: feat(plugin): BetterScreenshare, BetterMicrophone, PhilsPluginLibrary

found it https://github.com/philhk/better-discord-screenshare-plugin

[limber skiff]

[charred monolith]

3941

[Vendicated/Vencord] New comment on pull request #730: feat(plugin): BetterScreenshare, BetterMicrophone, PhilsPluginLibrary

Stupid question but how do I download this masterpiece?

No point anymore. The branch was deleted and afaik never developed any further, while Discord changed many things in the meantime. Best you can do, for better screenshare anyways, is Betterdiscord and YABDP4Nitro plugin.

@twisty-nado that's been deprecated even before the Vencord version was started. Useless, I'm afraid.

[fossil inlet]

Why is this pr getting so much attention

[limber skiff]

ntts

[fossil inlet]

[scenic fog]

Someone commented on it and it acted as a bump I guess

[austere talon]

nop

[gritty canyon]

why do people event want this

[turbid hatch]

because you can crash people with it

[gritty canyon]

oh

:/

[turbid hatch]

that is objectively the only reason why people suddenly want it

its not for any legitimate reason

[limber skiff]

people are so smart they are downloading the unnoficial plugin, crashing and complaining

[gritty canyon]

yea i was gonna go like "this doesnt seem useful for the average person"

[fossil inlet]

I was in the call with sqaaakoi when they found the crash and I thought I might make a plug-in for that one day as a joke but I never got around to it

Sad

[austere talon]

this is actually hilarious

people downloading a plugin trying to crash other people and instead they crash themselves

instant karma

[limber skiff]

DFHJDHFDFDS

[turbid hatch]

thank you phil for not maintaining your fork

🙏

[limber skiff]

it's insane for his plugin has 94 files

[verbal pumice]

wait is it actually busted

thats huge

[turbid hatch]

yeahb its broken

[fossil inlet]

Iirc he didn’t update in a few months

[limber skiff]

that's more than the entirety of the guild home feature

[turbid hatch]

its been broken for at least 2 months, it doesnt even pass testing anymore

[limber skiff]

94 files for a modal

[austere talon]

nah he has his fork

oh wait

2 months

[turbid hatch]

yeah his fork is the one that doesnt pass testing

[verbal pumice]

thank you ntts for putting the wrong link 🙏

[turbid hatch]

[austere talon]

yeah it mighr be dead

[turbid hatch]

because we have definePlugin as a requirement now

and his code doesnt use it at all

it just shoots itself during buildtime

so he cant update base vencord

[gritty canyon]

why would someone even do it like that

or did defineplugin not exist yet

[turbid hatch]

direct port from BD

[gritty canyon]

😭

alr

[turbid hatch]

and he did it like that because it was technically possible

the classes expose the right props and stuff and its "good enough" for it to work as a plugin

[austere talon]

lewi you're always too polite

i fixed ur support reply

[turbid hatch]

m?

[austere talon]

#🏥-vencord-support-🏥 message

the british in you is too strong

[turbid hatch]

o

sorry 😭

[gritty canyon]

you gotta be more ANGRY

become german

[austere talon]

"we don't provide support but check this channel"
then they check the channel and then ask more questions

it doesn't matter if you say it's not supported

if u help they will ask more

that's why i'm also so strict on support questions outside of the support channel

[turbid hatch]

fair enough

[scenic fog]

Ah I see, some YouTuber posted a video saying "beware, people can crash your Discord using this!", and now everyone wants to use this to crash other people
Fun

[charred monolith]

coopeeo

[Vendicated/Vencord] Pull request review submitted: #2642 feat(plugin): ExtraConnectionLinks

coopeeo

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

It's shorter and I like it better lol that's all

coopeeo

[Vendicated/Vencord] Pull request review submitted: #2642 feat(plugin): ExtraConnectionLinks

coopeeo

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

because enums in typescript like to do a number thingy, meaning the Object.keys will return something like

[
	0,
	"Xbox",
	1,
	"PSN",
	etc...
]

coopeeo

[Vendicated/Vencord] Pull request review submitted: #2642 feat(plugin): ExtraConnectionLinks

coopeeo

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

yea i can delete this as this was basically just for tracking my progress as i went along doing stuff

[jagged reef]

NTTS moment

[jagged cloak]

horror why did he make a video on that

it usually has the opposite effect

with slimy 12 yrolds

[woeful sleet]

I don't think Vee was clear enough. They're saying you should call people who ask for support slurs. Really just ream them. Make them regret ever considering using Vencord

[fallen vale]

...

[charred monolith]

Scyye

[Vendicated/Vencord] New comment on pull request #2763: Vc notifier plugin

What?

What's the use case for this?
Why would you need a notification when the channel youre in is one person away from filling?

[charred monolith]

Scyye

[Vendicated/Vencord] New comment on pull request #2749: Introduce StyleListener API

cool idea but did your idea die

what?

[gritty canyon]

LMFAO

[charred monolith]

crwn1337

[Vendicated/Vencord] Pull request closed: #2144 Add a plugin that hides server avatars

[spark cove]

@limber skiff hey what were the lockfile bugs

you had with the new installer on windows

i wanted to investigate them

[limber skiff]

just try updating

its gonna explode

[spark cove]

okay i'm gonna set up Windows Sandbox scripts for this lol

[charred monolith]

sadan4

[Vendicated/Vencord] New comment on pull request #2763: Vc notifier plugin

What?

What's the use case for this? Why would you need a notification when the channel youre in is one person away from filling?

while it seems niche, some servers cap their voice chats at low member counts
this seems like it would notify you when a slot opens up so you can join

[rugged spire]

isnt there also a 3rd party plugin that already does this but puts you in the channel

well maybe in a slightly different way

[fallen vale]

sounds really stalky

[rugged spire]

yes but it got published in #1256395889354997771 somehow

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[fossil inlet]

is there a way to force all lazy loaded modules to load

[long stream]

yes, loadLazyChunks()

[fossil inlet]

ty

[long stream]

np

[fossil inlet]

and everythings pink

[long stream]

make sure to enable consoleshortcuts first tho

[fossil inlet]

yea, i have that on

[brazen bone]

I fail to see the issur

It's a nice color

[charred monolith]

konek101

[Vendicated/Vencord] New comment on pull request #2763: Vc notifier plugin

well yes it would notify you when a slot for you would open up and the notification when clicked will join you to that channel but as i said i want to make it have more than that notification its just that i dont have ideas for it

konek101

[Vendicated/Vencord] New comment on pull request #2763: Vc notifier plugin

if you want to know i started it as a thing for me cuz i played games in servers that capped their vcs to the max amount of players allow in a game lobby and you had to wait for slot to open up and join before someone else

[charred monolith]

TheBrunoRM

[Vendicated/Vencord] Pull request opened: #2765 feat(plugin) VoiceMessages: allow dropping files as input

Romix17

[Vencord/Vendroid] New star added

[charred monolith]

nakinami

[Vencord/Vencloud] New star added

[charred monolith]

HexoKnight

[Vendicated/Vencord] New comment on pull request #1695: feat(plugin): commandHistory

The motivating usecase was commands in bot DMs, rather than in servers. Though I'm not planning on working on this as that usecase is gone for me, I haven't used this branch in months. I'm fine with this being closed.
Thanks for all your work on Vencord!!

[dusk blaze]

nicest vencord user with a closed pr

[still wasp]

Tbh i see the reason for plugins that add commands not being accepted, if everything was accepted shit would get bloated QUICK

[fossil inlet]

can someone try and reproduce this bug

1. go to settings page
2. make sure you have the settings search bar enabled
3. type without a text input focused in an injected settings page

[spice python]

can reproduce (it just goes blank till escape is pressed)

[fossil inlet]

yea

[dusk blaze]

happens

[rugged spire]

yes i can reproduce this
although your conditions arent what causes it, i think its just 2 or more characters in the search bar on an injected page

[charred monolith]

philhk

[Vencord/Installer] Fork created: philhk/Installer

[limber skiff]

here we go

buddy is about to make a installer for their fork with better screenshare

[fossil inlet]

it would be kinda funny if he installed a tokenlogger/malware

[rugged spire]

https://tenor.com/view/devilbro-betterdiscord-discord-memory-leak-mwittrien-gif-26859667

that will be so unmaintained soon

[rugged spire]

This will happen

oh no

no wonder its so hard to find what anything does

its all in this "Library"

LMAO

so obvious people only care about betterscreenshare

[woeful sable]

yeah

and the library depends on the 2 plugins as well 😭

[woeful sable]

when someone requested for bettermicrophone in a fork, i had to re-write the plugin definition stuff so it doesn't fail tests 😭

i have no idea why he does it like this

[rugged spire]

LMAO

its so shit

[woeful sable]

does he come from like betterdiscord

[rugged spire]

YES

[woeful sable]

cause thats what it looks like 😭

[rugged spire]

I HAVE NEVER EVEN WRITTEN BD PLUGINS AND I KNOW IT LOOKS LIKE BD BOILERPLATE CODE

[woeful sable]

its the first thing i thought of when i saw the gigantic library

i couldn't understand jack shit he was doing in it

[rugged spire]

I cant even fucking navigate this shit

what the fuck

[rugged spire]

its not even a library

[woeful sable]

it sort of is

[rugged spire]

i dont believe it is

[brazen bone]

It's great that there's both patchers and patches

[rugged spire]

so much stuff that depends on it is actually hardcoded inside of it

[rugged spire]

WHY

did i mention the library depends on itself?

[woeful sable]

iirc i only saw patchers be used for adding stuff to this area

but i also never checked his other plugins

but i might also be incorrect

[rugged spire]

this is fucking unreadable

[woeful sable]

yeah it is

[rugged spire]

should i

[woeful sable]

😭

[rugged spire]

[brazen bone]

For BD I can kinda understand wanting to use a shared library, but VC already has a pretty decent library builtin so what's the point

[rugged spire]

[woeful sable]

there's just so much bloat into one "plugin/library"

[charred monolith]

Scyye

[Vendicated/Vencord] New comment on pull request #2642: feat(plugin): ExtraConnectionLinks

I gave you my review already lol

[dusk blaze]

nin0lib when

[brazen bone]

Closest thing I have to a library is an optional file that loads all my other plugins

[austere talon]

MAKE

[limber skiff]

we should just discard every api we have and make veePluginsLibrary

[fallen vale]

but it has to be like BDFDB, and every plugin has to be formatted like a devilbro plugin

[charred monolith]

schoeneBiene

[Vendicated/Vencord] Pull request review submitted: #2642 feat(plugin): ExtraConnectionLinks

schoeneBiene

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

this really isn't needed

* Amazon Music (nothing references to the actual amazon music user id in discord)

Scyye

[Vendicated/Vencord] Pull request review submitted: #2642 feat(plugin): ExtraConnectionLinks

Scyye

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

is it really that big of a deal lol

its kinda funny

[fallen vale]

i tried sending that thing thats at the start of all the plugins to install the library or whatever, and its 400 characters over the non-nitro character limit.

[dusk blaze]

every vencord contributor will have their own plugin library

[limber skiff]

findByMessageString soon

findByMessageString("GUILD_OWNER")

boom duplicate explode

[glass jasper]

ok phil
(the joke is their plug-ins requires the use of their library)

[charred monolith]

coopeeo

[Vendicated/Vencord] Pull request review submitted: #2642 feat(plugin): ExtraConnectionLinks

coopeeo

[Vendicated/Vencord] New review comment on pull request #2642: feat(plugin): ExtraConnectionLinks

Quote reply
Reference in n

it's very needed

[cold patio]

Yes it is. I actually considered abandoning the fork entirely because it has become quite a mess. The reason my commit history looks so strange is that I’m no longer sure what I’m doing. I can’t remember much at all. The only reason why I have updated it now is because people want to use it. If someone with more experience or knowledge wants to create a better fork, I’d be happy to see a custom screenshare plugin developed by someone else. I’m also not sure why I used a class instead of definePlugin. I created this a while ago for myself and my friends and decided to publish the plugin because it turned out to be quite useful.

[rugged spire]

Honestly, that's understandable

[cold patio]

Also I hate myself too for creating a library inside Vencord. I guess I was tweaking

[rugged spire]

You carried your BD knowledge to Vencord

and that's understandable

[rugged spire]

I'm going to be honest and admit it probably has some useful things Vencord doesn't already have but I haven't actually studied what it does enough to answer that

[fossil inlet]

i think it would be funny if i made it sane

converted it to the vencord style

[rugged spire]

I can promise you that there would be a 50-70% decrease in the count of files/folders in the plugin if it was rewritten

[fossil inlet]

would be a fun project for me rn

im stuck with all the plugins i want to make

[rugged spire]

folder with index pointing to 1 other files' export

[rugged spire]

what are those

[fossil inlet]

terminalChatBoxBinds, textProfileView, userPopoutImageSend

[rugged spire]

what are the first 2

[fossil inlet]

add binds like ctrl+w to delete word to the chatbox

[cold patio]

Yeah my folder structure is really weird. I just don't know how to do it properly. I thought this was good at the time. But to be honest I didn't really improve when it comes to that xD

[rugged spire]

@fossil inlet (testing

yeah you should just replace those with the actual mention components

not that fake thing

[fossil inlet]

whar

[rugged spire]

the mention in the chatbox isnt a real mention

[fossil inlet]

yea, ik

[rugged spire]

it would be easiest to replace it with a real mention anyway

would fix MentionAvatars too

[fossil inlet]

hmm

maybe

[rugged spire]

I say this fully aware that I'm about to go reimplement an existing component in Discord

[fossil inlet]

which one?

[rugged spire]

this one

specifically the hover slider bar

[fossil inlet]

have fun

[rugged spire]

to inject it here

[fossil inlet]

thats a neat idea

[rugged spire]

No it is NOT as easy as replacing the Tooltip

i have to rewrite it a tiny bit

surely i can just use MediaEngineStore for the settings right

wtf

nop

i have to reverse engineer the existing context menu there

[limber skiff]

what do you need

way to change the volume?

[rugged spire]

set/get volume

as a hook ideally for the getter

[limber skiff]

these ones?

[rugged spire]

yeah

[limber skiff]

v

976758

should give everything you need

[rugged spire]

thanks

[limber skiff]

useState for the current values

and how to change

[rugged spire]

alright

793148 is what I'm recreating

the component

[limber skiff]

is it really not generic to be usable in another place?

[rugged spire]

I don't know

doesnt seem like it

hm no

[fossil inlet]

guhhh
i think im just going to recreate the context menu

[rugged spire]

I dont want to render a default icon

[rugged spire]

[fossil inlet]

guhhhh why does src/userplugins have to be in the gitignore

[rugged spire]

"Why is the folder intentionally in gitignore in the gitignore"

[brazen bone]

Otherwise some fool would accidentally commit it and include it in prs

[rugged spire]

Dont worry this happens already

guhh I think 619031 is more useful for my case

[austere talon]

you have to try being a bit nicer 😭

you can give constructive criticism without calling other people's work shit

yes it might be questionable code but hey in the end it works

that's still an achievement

[fossil inlet]

is it possible to load a lazy loaded component

[rugged spire]

yes I will admit I was too harsh on it :/

i need to unlearn the "wow this isnt ideal" and learn "it works" or some other mentality

[rugged spire]

extractAndLoadChunksLazy

takes a list of finds for a module that contains the associated code to lazy load whatever you need and returns an async function to load it

[fossil inlet]

thanks

[fossil inlet]

guhhh, am i doing something obviously wrong?

[austere talon]

why are u passing an array

[rugged spire]

guhh i havent used in ages

[austere talon]

it doesn't take an array

[rugged spire]

are you trying to find the resulting module?

[austere talon]

it takes string(s)

[rugged spire]

lol what

[fossil inlet]

uhh

[austere talon]

oh wait

I was still thinking about webpack extract

[rugged spire]

why is it that when I went to find whatever the name of it was it had an array where it was used

[austere talon]

#🌺-regulars message

[rugged spire]

you need to somehow figure out where the lazy require code is

[austere talon]

the find should not be for the lazy module you want

it should be for the module that loads it

[fossil inlet]

oh

oh okay

[rugged spire]

you need to find something that looks like this

[fossil inlet]

i thought the find was for the module itself

[austere talon]

the load code looks like n.e(12345).then(n.bind(n, 1892)

it will have the id of ur module in the end

you need to find that

[rugged spire]

with the network tab in devtools open, i would recommend reloading the app, and doing stuff until you load the lazy module, then when it loads js go to the initiator tab to try to find that code

[fossil inlet]

i already know where its loaded from

[rugged spire]

oh

[fossil inlet]

im just trying to steal a component

[rugged spire]

why is it always with components

all I can say is be careful and make sure to load it

yes it is safe to call it multiple times iirc

[fossil inlet]

GUHH

its loaded from another lazy chunk

[fossil inlet]

thanks, i love nested lazy loaded chunks

[rugged spire]

horror

discord will explode

[fossil inlet]

something about this seems wrong, but it works

[limber skiff]

move the component find outside

and use extractAndLoadChunksLazy instead

[rugged spire]

whats the benefit of this here

[limber skiff]

reporter testing

[rugged spire]

is it that it remembers that its loaded

oh

[fossil inlet]

should that be in the top of the file, or the start block?

[limber skiff]

the normal extractAndLoadChunks wont even exist in the future

[limber skiff]

file

[rugged spire]

isnt this your immediate finds branch

[limber skiff]

yeah

[fossil inlet]

@limber skiff like this?

[limber skiff]

extractAndLoadChunksLazy returns a function

then inside the open modalLazy you await that function

[fossil inlet]

oh, okay

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[glass jasper]

https://tenor.com/view/yippee-happy-yippee-creature-yippee-meme-yippee-gif-gif-1489386840712152603

[charred monolith]

RedMan13

[Vencord/Vencloud] New star added

[fossil inlet]

@rugged spire rate the plugin (fullUserInChatbox)

[glass jasper]

what is with the music some people put behind the videos they send

[fossil inlet]

its just what im listening to 😭

[glass jasper]

💀

[fossil inlet]

wdym skull

[glass jasper]

idk 🤷‍♀️

[glass jasper]

anyways, looks cool to me 7/10 would probably use it

[fossil inlet]

im going to release in #1256395889354997771 as soon as the mods respond to my current one, but i can send you the repo link if you want

[glass jasper]

https://tenor.com/view/plink-wide-cat-plink-cat-meow-gif-27396868

nah, I can’t be bothered setting up a dev build rn

[fallen vale]

jesus christ that music-

[fossil inlet]

😭

[fallen vale]

im sitting next to my grandparents, and i just hear the n word 4 times straight full volume

[fossil inlet]

sorry 😭

i think ill mute the audio next time

[rugged spire]

You should submit this upstream

[jagged reef]

Lmao same, I’m playing Spotify full volume on speakers and this comes on

[charred monolith]

sadan4

[Vendicated/Vencord] Pull request opened: #2766 new plugin: fullUserInChatbox

adds the full user mention component to the chatbox, this has a good amount of benefits, which ill fill out later

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2766 new plugin: fullUserInChatbox

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2766: new plugin: fullUserInChatbox

you should probably remove this file, it provides no use in upstream

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2766: new plugin: fullUserInChatbox

add a description (you probably know to do this already)

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2766: new plugin: fullUserInChatbox

seems very generic

sadan4

[Vendicated/Vencord] Pull request review submitted: #2766 new plugin: fullUserInChatbox

sadan4

[Vendicated/Vencord] New review comment on pull request #2766: new plugin: fullUserInChatbox

im going to change it to a normal readme, that's why this is a draft

sadan4

[Vendicated/Vencord] Pull request review submitted: #2766 new plugin: fullUserInChatbox

sadan4

[Vendicated/Vencord] New review comment on pull request #2766: new plugin: fullUserInChatbox

im aware, thats what discord passes from what I can see, leaving it because its generic, will look into it more later

sadan4

[Vendicated/Vencord] New comment on pull request #2766: new plugin: fullUserInChatbox

i think the name on this also needs some work

[gritty iris]

You use every plugin this means nothing

[austere talon]

wtf is this song bro 😭

[crude hearth]

I understand black metal listeners to some point

but not that

the hell is that music

is that even a music

[spark cove]

JID

banger

[woeful sable]

i listen to about any genre that exists 🙏

[spark cove]

i understand black metal listeners less than JID but i keep my useless thoughts in my head

[austere talon]

black metal is fire

[spark cove]

real

even tho i dont like it i find that fire because music is beautiful

[glass jasper]

fair

[charred monolith]

iTrooz

[Vendicated/Vencord] New comment on pull request #1975: [Plugin] ReplyPingControl

I think it would be better to first focus on merging this, and then adding features with another PR

[fallen vale]

lol

[desert cosmos]

what 🔥

lets merge unfinished prs

[gritty canyon]

isnt this plugin quite literally built into vanilla discord?

tab -> arrow keys -> r (reply)/ e (edit)

[fallen vale]

that's stupid tho

[fallen vale]

my tab doesn't do anything lol

[gritty canyon]

works fine for me

[fallen vale]

well mine doesn't do anything cuz I made a plugin that cancels the tab action

[gritty canyon]

????????????????????

[austere talon]

yes but that sucks

[gritty canyon]

wdym it sucks its almost the exact same 😭

just with EVEN MORE! options

the plugin should at least then focus the message so its possible to use the other actions

this is the first actual working discord feature i have seen and yall are complaining about it insane 😭

[austere talon]

no one is complaining about it

[fallen vale]

vee can I get my no programming removed so I can react to messages

thanks bestie

[glass jasper]

Schizophrenia

[still wasp]

I love how you literally just copied the unofficial readme

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #2766 new plugin: fullUserInChatbox

Vendicated

[Vendicated/Vencord] New review comment on pull request #2766: new plugin: fullUserInChatbox

import { Devs } from "@utils/constants";
import definePlugin from "@utils/types";
import { findByCodeLazy } from "@webpack";

const normalMessageComponent = findByCodeLazy(".USER_MENTION)");

export default definePlugin({

[still wasp]

Neovim strikes again

[dusk blaze]

hop on vscode

[gritty canyon]

Why is this a nvim moment

[jagged cloak]

i had to take a moment to understand what the plugin was supposed to do

[teal nest]

that name is not very good

"seeUserProfilesFromChatbox" would be better i guess

and even then... ehh

[gritty canyon]

i just dont think its an extremely useful plugin in general, sorry 😭

[teal nest]

same tbh

[desert cosmos]

i would use

[gritty canyon]

maybe part of a general better chatbox plugin?

[gritty canyon]

youd use everything

[desert cosmos]

yes

[gritty canyon]

youd use a token logging plugin if there was one

[desert cosmos]

there is one

[teal nest]

if only there was a way to see full profiles from there...

[desert cosmos]

betterscreenshare

[gritty canyon]

i WILL pull user token and use it in fetch with the api

i WILL introduce a bug that accidentally leaks it into the request body

i WILL make sure it happens on message send requests

[jagged cloak]

[fossil inlet]

First of all, that's not neovim, that's my script to make plugins.
Second of all, it's a draft for a reason, I'm planning to remove it.

[still wasp]

Neovim moment tbh....

[gritty canyon]

your "script to make plugins"?

[fossil inlet]

https://github.com/sadan4/vc-userplugins/blob/main/_scripts%2Fnew

[fallen vale]

jesus

[austere talon]

nah would happen on vscode too

it can't enforce newlines

actually nvm

it enforces after imports iirc

[gritty canyon]

it does with most lsps

[fossil inlet]

i swear to god ii'm gonna make my own fucking eslint config just for vencord

[gritty canyon]

will probably fail tests

[fossil inlet]

The goal in making it is so that it doesn't fail tests.

[gritty canyon]

😵‍💫

[charred monolith]

Masterjoona

[Vendicated/Vencord] Pull request opened: #2767 Fix SpotifyControls shuffle sync

https://github.com/Vencord/plugin-requests/issues/1006

[charred monolith]

Vendicated

[Vendicated/Vencord] Pull request review submitted: #2767 Fix SpotifyControls shuffle sync

Vendicated

[Vendicated/Vencord] New review comment on pull request #2767: Fix SpotifyControls shuffle sync

                    replace: "shuffle:arguments[2]?.shuffle_state??false,actual_repeat:$1,$&"

Vendicated

[Vendicated/Vencord] New review comment on pull request #2767: Fix SpotifyControls shuffle sync

i know this is old but always good to refactor old stuff while you're already editing it

                    match: /repeat:"off"!==(\i),/,

[austere talon]

@limber skiff jumpscare

they are patching ShowHiddenChannels

[limber skiff]

no way lmao

[verbal pumice]

the skids will be fuming

[teal nest]

"help i can't see mod channels i dont have access to in my favorite discord server 😭"

support will go crazy

[still wasp]

Obfuscation (don't send the information to the client)

[teal nest]

i wonder how they'll get around channel access permissions problems

[dawn coyote]

not surprised of them fixing it, i’m surprised how long it took

[jagged cloak]

oh i just said that in the other channel lol

discord loves band aids to their own problems

[spark pivot]

it's a basic thing that shouldn't have been like that in the first place

[jagged cloak]

can they not send it if/when access is given to a client

my only guess is tech debt idk

[crude hearth]

it would require another gateway event

or maybe channel_update would be enough

but channel wont exist in the first place

so update can cause crashes too idk

[crude hearth]

advaith is working aganist us now 😔

I feel like discord devs would be very lazy to do this change

considering they didnt do in the past 9 years

[rugged spire]

i cant wait for it to break in the same way that disabling message history for people doesnt automatically load in the channels when permissions are granted

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[limber skiff]

W

[latent magnet]

its a good thing to be honest

w for privacy

[sterile oak]

they finally decided to patch it after years

could spent the time in better thing tbh

[opaque silo]

#staff-furry-roleplay can now be real

[latent magnet]

always has been

[opaque silo]

[rugged spire]

ignore that see #🧩-plugin-development

[opaque silo]

[Thu Aug 08 2024 01:50:13 GMT-0400 (Eastern Daylight Saving Time)]  "OPTIONS /dist/web/catppuccin-mocha-peach.theme.css" Error (404): "Not found"```
Vencord seems to be correctly fetching the theme then failing but still loading it  then not pulling updates?

[rugged spire]

sounds like a cache issue

can you open devtools and go to network

disable cache

[opaque silo]

wheres that option?

[rugged spire]

at the literal top of the page

check that

[opaque silo]

me when imb lind

[rugged spire]

hate this fucking feature

VSCode, I am maintaining a fucked up branch and this looks Ugly

[opaque silo]

no change

oh new error

"CORS error"

[rugged spire]

your web server issue

I LOVE VSCODE

[opaque silo]

cope

[rugged spire]

reloading it fixed it

its probably just the per branch editors setting breaking with unsaved file that doesnt exist anywhere

[fossil inlet]

nvim ❤️

(ignore the fact that eslint just broke for no reason)

[opaque silo]

WE ARE NOT IN 1980 WE HAVE MICE FOR A REASON

[rugged spire]

im tired af time to PR my SHITCODE to upstream

is it possible to import components from Dev Portal in any way?

Oh I hate this

Fuck that

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] Pull request closed: #2196 VoiceJoinMessages plugin

Sqaaakoi

[Vendicated/Vencord] New comment on pull request #2196: VoiceJoinMessages plugin

I haven't worked on this code for a long time and I want to start this idea from scratch with the knowledge I've gained since I tried to make this mess. It's been broken for over 2 and half months

[rugged spire]

how it feels to close a draft pr that hasnt been touched for months

[austere talon]

probably not

they have a lot of shared code but still separate bundles

[rugged spire]

i was thinking of stealing their components for server insights stuff but uhhhh they're just using some 3rd party library and it feels ultra cursed to deal with

i will write my own fucked up SVG path writer algorithm

[austere talon]

what for

using canvas is probably easier

[rugged spire]

guhhhhhhhh u sure

no but i can use fucked up discord components like Tooltip if i dont

[charred monolith]

kripikripi

[Vencord/Vendroid] New star added

[crude hearth]

actually arent their webpack global variable names are different

if you load entire bundle I believe it can be possibl

dev portal uses webpackChunkdiscord_developers

[rugged spire]

[crude hearth]

feels like good challenge but idk if this is good idea ngl

also lazyness

[charred monolith]

Metadorius

[Vendicated/Vencord] Pull request opened: #2768 Expose "translate to" settings publicly

Reason: I recommended this plugin to my non-English-speaking friends, and apparently you can't edit the target language without manually exporting/importing the settings. I realize it's probably not the best impl. since it's unconstrained to the list of languages unlike the select option type, but I am not sure if you can supplement a dynamicly changing list of languages based on translation provider since I am not familiar with the "framework" you people are working in. If anyone can nudge m...

Vendicated

[Vendicated/Vencord] New comment on pull request #2768: Expose "translate to" settings publicly in Translate plugin

you're supposed to use the translate button in the chatbar

[charred monolith]

Metadorius

[Vendicated/Vencord] New comment on pull request #2768: Expose "translate to" settings publicly in Translate plugin

Lol, I thought it's just a button that translates the message. There's nothing in the UI indicating that it's not simply a translation button, in fact even the settings reference it like so.

Is there a way we could make it a bit more obvious so such cases won't happen and I don't need to explain to people how to use it?

Metadorius

[Vendicated/Vencord] Pull request closed: #2768 Expose "translate to" settings publicly in Translate plugin

[charred monolith]

Metadorius

[Vendicated/Vencord] Pull request opened: #2769 Clarify how the translation plugin functions to prevent confusion

see discussion on #2768 for context

[fallen vale]

so why not just click it?

[gritty canyon]

some people arent monkeys and press every button they see

[fallen vale]

that was- aggressive

[austere talon]

it wasnt

https://tenor.com/view/hatsune-miku-anime-vocaloid-lamazep-dance-gif-16231326

[fallen vale]

calling me a monkey is decently aggressive lol

[brazen bone]

I interpreted it as "aren't monkeys that press everything"

[gritty canyon]

i wasnt calling you a monkey well unless you do press every button you see and are a monkey

[teal nest]

that won't solve it, a better solution would be to edit the translate svg icon in the chat bar to add some sort of settings icon in it, such as a gear

[fossil inlet]

i might be stupid, but how do i get rid of this

[desert cosmos]

you can ignore it after you resolved it iirc

github just wants the same person to review again

https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/dismissing-a-pull-request-review

[glass jasper]

(about my showbadges plugin)

[fossil inlet]

https://tenor.com/view/drake-computer-notebook-explaning-gif-21152267

[desert cosmos]

showbadges plugin coming to vendor in 2026

[gritty iris]

I can believe you made this

[swift fjord]

https://tenor.com/view/drake-yachty-censored-not-drake-tech-support-gif-8658410013845332703

[frail sky]

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

Bad Patches

None

Bad Webpack Finds

None

Bad Starts

None

Discord Errors

None

[fallen vale]

poggers

[charred monolith]

NexWan

[Vendicated/Vencord] Pull request opened: #2770 feat(plugin): Custom background plugin

Some basic implementation which targets the custom-theme-background class of Discord and overrides it with an image, it doesn't affect any other style (as far as I've tested it)

Some images with the plugin active:

[glass jasper]

I know I’m one for sending…
1984_canbedonewithcss.gif but this is literally just BasicBackground

[vague vapor]

oh, that sucks, didn't knew that existed lol, I just wanted a custom background lmao, I haven't used betterdiscord ever so mb

[charred monolith]

alepouna

[Vendicated/Vencord] Issue opened: #2771 [Bug] Vencord's "Notifications style" are not showing up for pings/notifications

Discord Account

Alepouna

What happens when the bug or crash occurs?

As the title implies, whenever a ping or message notification is 'created', when the Notification Style is set to "Always use Vencord notifications" (img. 1) there is no notifications shown in app for them. When the "Only use Desktop notifications when Discord is not focused" (img. 2) notifications on the OS level are shown, but still no Vencord ones.
![image](https://github.com/user-attachments/assets/089bcdfa-f...

[charred monolith]

alepouna

[Vencord/Vencloud] New star added

alepouna

[Vencord/Vencloud] Fork created: alepouna/Vencloud

[rugged spire]

BASICBACKGROUND BY DEVILBRO in titlebar

[fossil inlet]

DevilBro
DevilBro
DevilBro Slave

[still wasp]

Bevildro

[fallen vale]

Bevildrone

[glass jasper]

ik, but it’s like the one not bad devilbro thing

[rugged spire]

how

[glass jasper]

Because it’s the most normal thing he’s ever done

[gritty canyon]

It’s the only thing without js so there is no way to leak memory

[glass jasper]

no, any of his other CSS leaks memory too but somehow in my experience BasicBackground doesn’t soo… i still plug it

[gritty canyon]

😨

[surreal fiber]

basic background, only 7000 lines of css

[glass jasper]

omg i’m fuckin god it actually is

[surreal fiber]

yep

[teal nest]

lord have mercy

[glass jasper]

why so much for something so simple?

[rugged spire]

What the FUCK?

[teal nest]

he hid a token logger in the css code

source trust me

[rugged spire]

did he actually just copy most of discord's stock CSS

[glass jasper]

certified DevilBro moment ☝️ 🤓

[gritty canyon]

oh okay

wait how the fuck does this not break every single update?

[rugged spire]

it almost certainly does break

[teal nest]

what the actual fuck

[brazen bone]

That sort of selectors are completely meaningless anyway

[fallen vale]

what is that even meant to do 😭

[glass jasper]

erm… BasicBackground Stuff

[verbal pumice]

it does

devilbro made his own thing to compile with proper classes instead of doing it properly

[rugged spire]

if it parses like findmyprops does then it isnt stupid

[charred monolith]

Vap0r1ze

[Vendicated/Vencord] Pull request opened: #2772 make prerelease builds for commits & branches

this makes it so commits create/update a commit-{SHA1} & branch-{BRANCH} tagged release, and gives us an API we can use like VencordNative.updater.setUpdateSource("branch", "asar-bundle") to make updater testing easier

[charred monolith]

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

I like this. I have noticed this is mostly just an API thing in the client though. Is the idea of adding remote repository switching an option that is willing to be added, and how about the idea of switching branches on local builds?

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

why not just call git checkout somehow?

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

also, why not set --latest=true if it's on main branch?

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

GITHUB_REF_NAME isn't even defined below, unless I'm wrong and it's already in the environment somehow

Sqaaakoi

[Vendicated/Vencord] New comment on issue #2764: [Bug] Vencord on macOS does not support multi-user setups

Not a macOS only issue, can occur on Linux too. Could be be fixed (in theory) by chmod -R 666 the Vencord directory and moved to a non-user specific path.
This might be easier to fix along with the asar-bundle feature branch

[austere talon]

@spark cove meanwhile I just made a separate repo and pushed random commits

https://github.com/Vendicated/VencordStaging

[rugged spire]

would that make the idea of switching remotes more relevant

or less

[spark cove]

yea i tried this but

it made me want to cry

[austere talon]

tbh build / updater changes are always scary scary

cause if we mess anything up it means we have to help thousands of lost sheep with manually updating

[rugged spire]

i already want to cry with how you leave one tag in the releases that just gets hackily edited

[austere talon]

can't you just solve that by installing discord to your user folder instead of system folder

[rugged spire]

probably

i never considered that

though

using more than one user account on a desktop computer is fucking insane

more than 1 person shares your device? they are probably dum and install weird software

such a security hack

shared directories will always exist and bad software will write to it

[charred monolith]

Vap0r1ze

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

Vap0r1ze

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

it wont be on main branch, theres a github.ref_name != 'main' condition because otherwise this would make a branch-main release. we dont need that because we have that already (devbuild)

Vap0r1ze

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

Vap0r1ze

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

yea https://docs.github.com/en/actions/writing-workflows/choosing-what-your-workflow-does/variables

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

guh

Vap0r1ze

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

Vap0r1ze

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

DevBuild is neither for developers or for the dev branch so i didnt care to make it make sense

[rugged spire]

@spark cove thank you for teaching me github actions by accident

[rugged spire]

real

[charred monolith]

Vap0r1ze

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

someone before made it so releases weren't created in forks, i assume did this to retain the behaviour of "dont make a release unless u want to"

Vap0r1ze

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

Vap0r1ze

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

Vap0r1ze

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

this isnt really related to the git updater because it doesnt use releases

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

makes a lot more sense now that you've told me devbuild release is still intended to be used

Sqaaakoi

[Vendicated/Vencord] Pull request review submitted: #2772 make prerelease builds for commits & branches

Sqaaakoi

[Vendicated/Vencord] New review comment on pull request #2772: make prerelease builds for commits & branches

eh true. I don't know if you intend to add UI for this or not?

[spark cove]

real

[rugged spire]

is there going to be UI for any of this

[spark cove]

probably not

i dont want to make this a big change

[spark cove]

cus yea they are scary

[spark cove]

wym

oh you mean devbuild

yea its pretty horror

considering the updater already just uses /latest lol

[rugged spire]

reading this feels like dragging a stone across my eyes

[austere talon]

hoes mad

https://tenor.com/view/hoes-mad-anime-angry-dance-gif-16119680

[spark cove]

if/when u merge that

i will make another pr to merge asar-bundle with latest main

[charred monolith]

CodeF53

[Vendicated/Vencord] Pull request review submitted: #2749 Introduce StyleListener API

CodeF53

[Vendicated/Vencord] New review comment on pull request #2749: Introduce StyleListener API

Honestly no idea, I spent like 30 minutes today trying to figure out why.

[charred monolith]

SomeRandom-Dev

[Vencord/Installer] Fork created: SomeRandom-Dev/Vencord-Installer

[rugged spire]

nothing good coming from this https://github.com/LockBlock-dev/Vencord-without-rainbows/issues/1#issuecomment-2278365498

[glass jasper]

how sad does your life have to be to fill the need to make something “anti-gay”

[fallen vale]

i dont think it actually has anything to do with the lgbtq

[fossil inlet]

Have to agree with this

[fallen vale]

the naming is just, unfortunate

[glass jasper]

It’s name is quite literally
“vencord without rainbows”

[rugged spire]

tbh it just looks like a shitty fork that will die in 3 days

[fallen vale]

#👾-core-development message

nah

[glass jasper]

There’s only one reason someone would name it that

[fallen vale]

rainbows could be "pizzazz" or smth like that

[glass jasper]

Scyee that is the most boomer thing I’ve heard on this app

[fossil inlet]

They haven't done anything homophobic yet, Im going to reserve judgement

[fallen vale]

none of the changes have anything to do with homophobia or transphobia as far as i can tell

[fallen vale]

inddiannna, what about that is "boomer" 💀

[desert cosmos]

"github doesn't ban for homophobia"

[fallen vale]

genuinely, what change did they make that can be considered homophobic?

its a weird concept for a fork, and i dont understand it, but calling it homophobic because of how you interpret the name doesnt seem fair.

[austere talon]

@dawn coyote job for u

[glass jasper]

also can we talk about the straight up removal of these files

[fallen vale]

okay now thats crazy 💀

[desert cosmos]

what do you think does "removing rainbows" mean in this context

[glass jasper]

@desert cosmos this

[fallen vale]

given the lack of removing anything that has anything to do with gay people,
"pizzazz" or if thats too boomer, "extra sparkly not-needed stuff"

[glass jasper]

oh God forbid my client has a little bit of “Pizzazz”

IDK what you wanna think this is just Chadcord 2.0

[fallen vale]

its a weird concept for a fork, and i dont understand it

i entirely agree

[desert cosmos]

true

[glass jasper]

also, we’re moving the code of conduct file and the ability to donate has to go a little bit against the license or whatever

[fallen vale]

the license changing is a bit sketchy tho imo

[desert cosmos]

i might be stupid but are there even rainbows in vencord 😭

[fallen vale]

not well versed with GPL, so im not sure if thats allowed or not

(i release most my stuff under MIT, which requires anything you fork of it to also be released under MIT)

[glass jasper]

other then some donor badges and possibly shiggy/vinnie. No.

[austere talon]

straight up license violation

which requires anything you fork of it to also be released under MIT
no?

[fallen vale]

well, the portions

[austere talon]

you can relicense but must keep intact original license

you can't relicense gpl to agpl that's not valid

and you can't just erase copyright names or year

[glass jasper]

that’s what iam saying, also the removal of code of conduct, cause I guess that’s not important

[still wasp]

LMAO THE ENTIRE CIRCUS

[fallen vale]

the entire circus is crazy 💀

[desert cosmos]

watch them delete your issue