question, is reloading a specific module possible?
#๐พ-core-development
fallen vale
brazen bone
You mean discord webpack module?
fallen vale
like, if a patch affects a certain module, could you reload just that module to load that patch rather than reloading all of discord.
idk the exact correct terminology for it
brazen bone
Theoretically possible if you swap out even more of webpack's guts I think
But whether it'd actually work properly is hard to say
glass jasper
Theoretically possible if you swap out even more of webpack's guts I think
horror
austere talon
like, if a patch affects a certain module, could you reload just that module to ...
not possible
fallen vale
uwu
fallen vale
not possible
rip, alright
gritty canyon
Thoughts about creating (trying to create) a cross-update, hash independent theme system? I dont see how an official theme store would be maintainable when every other update breaks them all
Something like assigning a custom name to every class and every update trying to match their rules to existing rulesets or something (would be a fuck ton of work at the start yeah but would be actually maintainable)
brazen bone
I've tried something like that, but the database itself needs a lot of maintenance
brazen bone
Mine is about naming classes based on which module defines them (or rather, which other classes are in the same module) rather than what styles they define though
So that is certainly one option, though I kinda doubt it'd work out
austere talon
Thoughts about creating (trying to create) a cross-update, hash independent them...
this is not a problem
you don't have to rely on hardcoded classes
you can do [class*=fooBar-] to match fooBar-2jA9b8
how do you think vencord css never* breaks
* almost never
brazen bone
Pretty bad when it's classes like content or wrapper though
gritty canyon
how do you think vencord css never* breaks
\* almost never
Ah alright
I do still think though that the current approach with just css is pretty unmaintainable though, but eh
So thoughts on a theme store?
austere talon
Pretty bad when it's classes like `content` or `wrapper` though
bad how?
you just need a more specific selector :p
brazen bone
There's dozens of them
So if you want to "stably" match them you need way more convoluted selectors than what should be necessary
rugged spire
@austere talon you should also see this comment
I also know TextReplace can do it
but I was curious 
gritty canyon
laugh react this comment immediately.
austere talon
lol yeah I kinda figured it was his service
cause I never heard of that site
but i wasn't gonna bother
rugged spire
i have too much free time at the wrong time (2am)
gritty canyon
i have too much free time at the wrong time (2am)
actually based though
we love doing random shit at 2am
rugged spire
i really need sleep
damn
WTF
oh
im actually braindead
i need to stop trying to make Stupid Proofer
glass jasper
<:hollow:1231282060258312415>
NewPluginManager doing this?
glass jasper
oh horror
rugged spire
so if people who use my fork ever dare to speak in #๐ฅ-vencord-support-๐ฅ #๐ง-off-topic-iceman-only or here about one of my broken plugins they will be told to go make issue on github
in other words: I wrote some stupid message that end users wont be able to understand
rugged spire
Yop
i mean
1 end user did install my highly opinionated channeltabs fork and ask why it broke in #๐ฅ-vesktop-development that one time #๐ฅ-vesktop-development message
markdown horror
?remindme 2 months beg myself to make channeltabs
shut vineBOT
Alright @rugged spire, in 1 month, 4 weeks and 1 day: beg myself to make channeltabs
rugged spire
fossil inlet
1 end user did install my highly opinionated channeltabs fork and ask why it bro...
How is it opinionated?
rugged spire
How is it opinionated?
Totally rearranges where it injected the actual tab bar
and a load of other stuff
fossil inlet
I've been meaning to patch my own version of channel tabs to have certain things that were missing from the original
rugged spire
STUPID PROOFER
jagged cloak
WHY
ppl will click on my repo and install every plugin and not read
oh all of these seem useful let me just install all of them :potofr
ThisWillCrashYourDiscord jumpscare
jolly egret
I make a plugin for a project a while back that would invoke a BSoD without perms and it couldnt be more clear thats what it did and people still installed it
frail skyBOT
fossil inlet
I make a plugin for a project a while back that would invoke a BSoD without perm...
That sign won't stop me because I can't read.
frail skyBOT
jolly egret
The thing is even if you make something 100% idiot proof, they always invent a better idiot
fossil inlet
Didn't this patch break like two days ago?
jolly egret
this is a fire saying
YEP
limber skiff
they broke it again
glass jasper
bruh
limber skiff
you know what's funny
by the time the extension gets approved it's gonna be broken again
charred monolithBOT
Discord Account
cjstylesorg
What happens when the bug or crash occurs?
While I was editing a message in the css-snippets channel, i notice for some reason the messages keep going up and down, i couldn't even see what i was typing until the typing indicator goes away. it tends to jump when the indicator appears or vanishes.
What is the expected behaviour?
I expect to be able to edit ...
spice python
doesnt that plugin affect the channel list
glass jasper
wholesome vee moment
gritty canyon
You now have to beat the no testing before push allegations
austere talon
this is weird nerdy audio stuff https://en.wikipedia.org/wiki/Dynamic_range
thick kestrel
now awaiting input on the only conversation remaining
austere talon
i think an option to only apply it to people without role colour would be nice to have
charred monolithBOT
shouldn't this be 8? we're working with a u64 which is 8 bytes, so why 16bytes size? you're just gonna be reading 8 null bytes every time
austere talon
also the entire ArrayBuffer, DataView, Uint8Array seems a bit needless
this achieves the same result
// Compute a 64-bit FNV-1a hash of the passed data
function hash(id: bigint) {
const fnvPrime = 1099511628211n;
const offsetBasis = 14695981039346656037n;
let result = offsetBasis;
for (let i = 7n; i >= 0n; i--) {
result ^= id >> (8n * i) & 0xffn;
result = (result * fnvPrime) % 2n ** 32n;
}
return result;
}
it produces the same result as your function (if it is corrected to use 8 bytes arraybuffer)
austere talon
this achieves the same result
```js
// Compute a 64-bit FNV-1a hash of the passe...
@thick kestrel
austere talon
i think an option to only apply it to people without role colour would be nice t...
how do you like this too
it's quite interesting tho, i like it
no more whitename discrimination
rugged spire
can now more easily rip off vencord eslint config to use in my own projects
we should make eslint config vencord preset
thick kestrel
<@368475654662127616>
yeah this is a way better implementation idk why I didn't use bitwise there
I'm just scared of JS ig lmao
thick kestrel
how do you like this too
I mean... I could do that. I don't really see the appeal myself tho.
rugged spire
@thick kestrel just curious, how do you feel about the idea of adding a user customisable salt to the hash function
thick kestrel
tbh I don't see a need for that either...
rugged spire
add color override then
thick kestrel
that sounds complicated but I see the use for that at least
I mean the complicated part would be making the UI for it
the actual code would just be a simple lookup
thick kestrel
I mean the complicated part would be making the UI for it
would be cool if there was builtin stuff to do UIs like the TextReplace one
I guess I can just copy TextReplace lol
crude raptor
current text replace ui is nice but the PR one is nicer :3
PR hell... ๐
thick kestrel
yeah this is a way better implementation idk why I didn't use bitwise there
I'm ...
I think the story of that code was that I used Number initially, thought I can't do integer bitwise on Number (since it's a float), but then realized the IDs are 64 bit
switched to BigInt and never realized I could've done it better
ok so: I'll be adding (or attempting to add) overrides and preserving role color
tbh, I think for preserving role colors it might be better to calculate the color based on highest role
so it's consistent
or maybe not idk
yeah I don't really like that feature since either way it's a bit weird
limber skiff
nice changes
austere talon
fr*nch
austere talon
would be cool if there was builtin stuff to do UIs like the TextReplace one
planned
austere talon
yeah I don't really like that feature since either way it's a bit weird
can be toggleable of course
i personally would like that tho
limber skiff
I DIDNT SUBMIT
hallow kestrel
doesnt that plugin affect the channel list
Correct but thereโs some room in the channel name so Iโm not sure why it would still be shaking the chat.
charred monolithBOT
fossil inlet
you are supposed to do
if (true)
Ah, iirc there's also an ESLint rule for that if you want to set it in the project's config
charred monolithBOT
They can be a bunch of different things, could also do any if that makes it easier but string is annoying because I have to keep writing @ts-ignore
charred monolithBOT
jagged cloak
You now have to beat the no testing before push allegations
everyone knows im never beating those
gritty canyon
everyone knows im never beating those
we all wont...
jagged cloak
even discord doesnt
jagged cloak
@chilly shoal there u go lol
austere talon
<@110276495825461248> there u go lol
wait til they check for updates and dont have any ๐ญ
jagged cloak
jumpscare
median rapids
wtf techno activity
gritty canyon
wtf techno activity
dolfies activity..
median rapids
dolfies activity..
hey i'm active here sometimes
i just don't like most of the people here 
smh
gritty canyon
i just don't like most of the people here <:blobcatcozy:1145727546747535412>
woooow
gritty canyon
how did i never know `from:@me` is a thing
you didnt?!?!?
austere talon
it doesnt tell u anywhere ๐ญ
fossil inlet
need to use that more
median rapids
it doesnt tell u anywhere ๐ญ
mf gone through every line of discord src and never found @me 
austere talon
help it doesnt work
median rapids
from:@earth
austere talon
mf gone through every line of discord src and never found `@me` <:hollow:1267599...
well in the context of dm channels 
but it's a "guild" id
median rapids
no? 
austere talon
FYM NO
fossil inlet
help it doesnt work
whats that bug icon?
gritty canyon
help it doesnt work
wtf??? is this new?
median rapids
horror
austere talon
i need to touch grass
gritty canyon
vencord on summer break
median rapids
prs will double alhamdulillah
gritty canyon
prs will double alhamdulillah
just.. close prs :3
austere talon
they alr do
what if thanos snap prs
50% chance ur pr gets closed and locked with no explanation
median rapids
just.. close prs :3
close button too far for ven
gritty canyon
ven, think of this for a sec
if you disable issues you wont have look at neither bug reports nor feature requests
vencord will be perfect
austere talon
reason: being mean to me
median rapids
reason: being mean to me
๐
median rapids
tbh you could probably setup an automerge on 5-6 contributor reviews at this point
austere talon
issues arent the problems
median rapids
tbh you could probably setup an automerge on 5-6 contributor reviews at this poi...
actually maybe more than 6 cuz vencord has 3 million contributors
austere talon
issues aren't the issue
gritty canyon
issues arent the problems
make shiggybot just automatically merge prs :3
austere talon
get it aha...
median rapids
why wires 
austere talon
do u mean 5 diff contributors reviewed
median rapids
yeah
austere talon
horro
gritty canyon
good luck getting a pr to that point
median rapids
nah ppl will lol
gritty canyon
idk..
median rapids
i would
austere talon
make contribution with 5 different alt accounts
pr malware
approve with all my accounts
gets auto merged
median rapids
>make contribution with 5 different alt accounts
>pr malware
>approve with all m...
you can make a higher threshold
or if you really want to dont make it automerge and require a quick lookover by a few trusted ppl to make sure there's no straight up malware
maybe you can also whitelist which ppl count? not sure
verbal pumice
50% chance ur pr gets closed and locked with no explanation
unironically good idea
jagged reef
Itโs kinda funny how my plugin that didnโt take a lot of time to make and wasnโt expecting to go quickly got merged pretty much instantly, but the ones I put a lot of effort into have been open for like 6 months ๐
fossil inlet
Itโs kinda funny how my plugin that didnโt take a lot of time to make and wasnโt...
I made the volume booster port in a day and it's got more attention than the other two that I've made combined.
jagged reef
Real
austere talon
less time took => much more simple => much easier to review
also depends on demand :P
if your plugin is widely demanded it'll be prioritised more
whereas if it's very niche it won't get priority
gritty canyon
someone should probably go through all prs and check if they are still relevant ๐ญ
jagged cloak
someone should probably go through all prs and check if they are still relevant ...
like keyuwordnotify
gritty canyon
like keyuwordnotify
what
jagged cloak
half of them probably arent tbh
or need a major refactor if they're over 3-6+ months old
its less of will it get merged and more of how much patience does one have 
gritty canyon
Actually instead of making a list should i reply to the PRs cuz the whole list rn is basically a dozen PRs that are just broken (mostly because stupid PRs instantly get pulverized)
But then again there is probably a reason why PRs are dead (no demand)
there are also some that, at least in my opinion, arent "deserving" of plugin status. I.e. stuff like these are minor changes and really arent needed
https://github.com/Vendicated/Vencord/pull/1627 (are people really too lazy to type ">" a couple times?)
https://github.com/Vendicated/Vencord/pull/938 (this is also very useless and not very well made)
So if yall want i can quite literally just go through each PR and comment on it (/ ask if the original developer wants to revive it)
provided the PR is old enough as to where id say its "dead"
jagged cloak
some can be useful but just dont have demand
or have minimal demand and are useful but ???
gritty canyon
yeah
the minimal demand ones are the most ??? ones cuz its like
every new plugin adds more maintenance work
jagged cloak
yep
gritty canyon
and do we really want to bloat vencord with a bunch of small tweaks and changes
jagged cloak
well those you can just say no ofc
its like this would be nice to have, and some people definitely want it, but the author clearly doesnt have any intent on maintaining it if it were merged
or doesnt have patience, etc
which is why everyone can contribute
gritty canyon
Actually for those i think a list is necessary so they can be instantly closed instead of them lingering around
gritty canyon
its like this would be nice to have, and some people definitely want it, but the...
yeah
jagged cloak
i think it all falls back on the only having a few people who actually have authority lol
still wasp
because the author of that exploded from impatience already
It has been 1 month since i opened my pr therefore i will complain in core dev channel (the only option) (duh)
jagged cloak
reviewing prs all day isnt exactly fun
still wasp
I mean i get it can be sorta annoying but complaining about it won't speed up the process
jagged cloak
grey area i guess
ofc people will bitch about their plugin being " ignored " and i would too, but ^^
gritty canyon
Actually for those i think a list is necessary so they can be instantly closed i...
ill compile a list for those then send it here, some collaborator or whatever can go through them and close them
maybe we can think of one plugin with a bunch of small tweaks in the future, a lot more maintainable than 50 small plugins
i never seem to be able to spell "maintainable" or "maintain"/"maintenance" right (i had to use spell checking thrice here)
gritty canyon
maintenance is hard to spell and do okay
so true
gritty canyon
at least its not french
thats also true
there are a bunch of draft prs that are dead
smh
bing chilling
fossil inlet
What If there was some bot that closed PRS after some period of inactivity
still wasp
What If there was some bot that closed PRS after some period of inactivity
That must exist
gritty canyon
What If there was some bot that closed PRS after some period of inactivity
im finding some good plugins in the depths of the sorted by least recently updated prs section
i just found a pr that has about 5 lines of actual code but literally 15 patches yeah im gonna file that under u for unmaintainable
jagged cloak
stalebot for prs
gritty canyon
@austere talon where are you complaining for your pr merge!!
spark pivot
that was mine orignially lmao
gritty canyon
spark pivot
i accidentally put all of the changes on my fork's default branch and that fucked up things
gritty canyon
page 3, im already losing a ton of braincells
gritty canyon
u wanna revive it?
i wrote this for the pr
since i already got into the less than 1 month territory here is the list i have rn
spark pivot
u wanna revive it?
Itโs basically done (not including that one person who commented i can add that if you want)
dusk blaze
since i already got into the less than 1 month territory here is the list i have...
reminds me i should update rpceditor
charred monolithBOT
still wasp
since i already got into the less than 1 month territory here is the list i have...
How DARE you slander relationshippruner
๐
(it sucks)
gritty canyon
its just not needed as a plugin
its a one time thing, maybe
youll use it once a month
fallen vale
I'd use it often
gritty canyon
install it as a user plugin, do your pruning and done, no need to actively maintain it as official
gritty canyon
I'd use it often
consider just adding less people as friends
fallen vale
consider just adding less people as friends
boring.
gritty canyon
austere talon
reject
frail skyBOT
austere talon
omg what is this code https://github.com/Vendicated/Vencord/pull/1695/files
jagged cloak
through IPC i think so yeah
frail skyBOT
austere talon
im crying
still wasp
omg what is this code https://github.com/Vendicated/Vencord/pull/1695/files
Seems legit
still wasp
When the fuck was this here
austere talon
the search?
still wasp
Yeah
austere talon
still need to add search support to vencord
still wasp
Oh it's a stock thing
austere talon
i think it's gonna be pretty complicated
and require refactors to the settings code
possibly multiple patches in several locations
gritty canyon
i think it's gonna be pretty complicated
well i think that depends on how discord has implemented it
ill still take a look tho 
austere talon
i honestly wouldnt recommend u bother but if u really wanna, sure xd
gritty canyon
im so bored im quite literally mad at myself rn i absolutely NEED to do something immediately
austere talon
Luna seems to have a habit of working a lot on plugins then abandoning them as soon as the PR is opened and not addressing feedback ๐ญ https://github.com/Vendicated/Vencord/pulls?q=sort%3Aupdated-desc+is%3Apr+is%3Aopen+author%3AImLvna
i know on some prs i take a while to review so it's understandable but then that password protect one i reviewed the next day
silly..
@nimble plaza what's up with that? didn't see, forgot, lost interest, no time...?
not blaming you it's all good and there's absolutely no rush take all the time in the world, im just curious 
charred monolithBOT
seems useful! perhaps it might be useful to add a "Jump to first message" button somewhere here in forums?
i keep wanting to jump to the first forum post and wondering why the fuck discord hasn't added an intuitive way to do so
still wasp
<@976176454511509554> your patches are somehow worse
You are lying
fossil inlet
you will face the wrath of god
That's duke, right?
limber skiff
I know we arent profissional but im not sure if we want this
there really is no need to have a curse there
limber skiff
it reminds me of when license had a penis
austere talon
I know we arent profissional but im not sure if we want this
does it really matter ๐ญ
limber skiff
no, but just why
austere talon
https://github.com/Vendicated/Vencord/pull/2574/commits/da93448058aaa54c4df50c23...
i wrote this change in github ui and didn't explode lint.. impressive
limber skiff
I'm not against curse in the code but it just seemed very unecessary there
austere talon
i thought it was funny
limber skiff
ig
austere talon
๐ช
lint was complaining ๐ญ
i mean yeah we can change it
but does it really matter
just build script
i wouldnt put it ina user facing string
limber skiff
yeye
fossil inlet
I know we arent profissional but im not sure if we want this
wait untill that kid complaining about external links sees this
fossil inlet
still wasp
i couldnt stand
i noticed
limber skiff
there is no way this is passing lint first try
fossil inlet
@austere talon should i add a readme to volume booster, it doesnt have one
still wasp
all plugins need README
is there anything specific i should put in the readme? or just the name + description
fossil inlet
is there anything specific i should put in the readme? or just the name + descri...
iirc images of the plugin
still wasp
oh makes sense
shy veldt
@austere talon fix
shy veldt
canary got broken :(
gritty canyon
<@343383572805058560> fix
damn..
austere talon
works on my machine doe
shy veldt
works on my machine doe
doesnt on mine
gritty canyon
windows only issue?
possibly
austere talon
even ran reporter that loads all chunks and all plugins still can't repro
shy veldt
horror?
heavy bloom
jagged cloak
install from web
fossil inlet
are you on codium or code?
still wasp
are you on codium or code?
code
fossil inlet
huh
austere talon
sorry its not available in [your Country of residence]
fossil inlet
@austere talon do you choose this color?
austere talon
yes
fallen vale
๐ญ
fossil inlet
@still wasp i have a bookmarklet for downloading VSIX for this reason
grave mangoBOT
https://github.com/Vencord/Companion/blob/main/package.json#L72-L75
package.json: Lines 72-75
"galleryBanner": {
"color": "#ed80a7",
"theme": "dark"
},
fossil inlet
@still wasp
javascript:(function()%7Bconst URL_VSIX_PATTERN %3D 'https%3A%2F%2Fmarketplace.visualstudio.com%2F_apis%2Fpublic%2Fgallery%2Fpublishers%2F%24%7Bpublisher%7D%2Fvsextensions%2F%24%7Bextension%7D%2F%24%7Bversion%7D%2Fvspackage'%3B%0A%0Alet itemName %3D new URL(window.location.href).searchParams.get('itemName')%3B%0Alet %5Bpublisher%2C extension%5D %3D itemName.split('.')%3B%0Alet version %3D document.querySelector('%23versionHistoryTab tbody tr .version-history-container-column').textContent%3B%0A%0Alet url %3D URL_VSIX_PATTERN.replace('%24%7Bpublisher%7D'%2C publisher)%0A%09%09%09%09%09%09 .replace('%24%7Bextension%7D'%2C extension)%0A%09%09%09%09%09%09 .replace('%24%7Bversion%7D'%2C version)%3B%0A%0Awindow.open(url%2C '_blank')%3B%7D)()%3B
tokenlogger
fossil inlet
there sshould be an actions thing to publish a vsix to just download from releases
still wasp
im having a stroke trying to find this patch holy shit
still wasp
shut up about rupert
you will never tell anyone about rupert
also i dont hate him i literally have a shrine
fossil inlet
iirc there was some website that told you
glass jasper
@heavy bloom
glass jasper
<@373657230530052099>
yes
still wasp
nini
glass jasper
nini
in the meantime, I actually need to look into my Pr and see if it still works
I also want to see if I can integrate the quest badge because I have a feeling like thatโs not going anywhere anytime soon
shy veldt
gen cant repro
it was a discord issue not vencord
but vencord claimed it as its own anyway
still wasp
Adopted the issue
pine topaz
made a little check for if you have the donor role in this server, should i PR
gritty canyon
made a little check for if you have the donor role in this server, should i PR
No because you can always donate more. Give ven all your money. Now.
glass jasper
<@343383572805058560> fix
oh thats not the same error i was having
pine topaz
No because you can always donate more. Give ven all your money. Now.
honestly i should add the donate button back, this is true. give vee everything
glass jasper
No because you can always donate more. Give ven all your money. Now.
So add a second that says you can keep donating or something
pine topaz
also less code for me
fossil inlet
made a little check for if you have the donor role in this server, should i PR
do that or if they have a donor badge
gritty canyon
So add a second that says you can keep donating or something
โGive ven more moneyโ
glass jasper
โGive ven more moneyโ
@pine topaz this
pine topaz
lol
gritty canyon
made a little check for if you have the donor role in this server, should i PR
Honestly think about if you can somehow expand this into a badge submission thing or whatever (but we should probably ask ven first)
pine topaz
do that or if they have a donor badge
not sure how i would detect one
still wasp
not sure how i would detect one
Fetch badges.vencord.dev or whatever it is
Then .some with current user id
fossil inlet
see how veocnrd does it
gritty canyon
not sure how i would detect one
Shift + ctrl + F, "badges"
Preferably in the vencord source code but if you are a real masochist you can try devtools
still wasp
word
Update if anyone else has this issue, the arch vscode package doesn't include the official package repos because of microsoft tos, but you can fix it by running yay -S code-marketplace
glass jasper
Update if anyone else has this issue, the arch vscode package doesn't include th...
hop on windows
still wasp
hop on windows
YEAHHHHHHH
hallow kestrel
SHUT THE FUCK UP
did you hear about third party cookies being blocked in future chrome versions as part of privacy sandbox?
pine topaz
is ts const donorBadges = (Plugins.BadgeAPI as unknown as typeof import("../plugins/_api/badges").default).getDonorBadges(UserStore.getCurrentUser().id);
really what i need to do to get this function
i mean it works but it's ugly af
anyways, it has donor badge detection now
now all i need are opinions
pine topaz
literally no problems on my end
spark pivot
simply an issue of skill
median rapids
and do we really want to bloat vencord with a bunch of small tweaks and changes
the reason people do this is because there's no external plugin support
you can't have your cake and eat it too
pine topaz
WHAT DOES IT MEAN
src/components/VencordSettings/VencordTab.tsx:251:38 - error TS2339: Property 'getMemberRoleWithPendingUpdates' does not exist on type 'GuildMemberStore & FluxStore'.
FYM IT DOESNT EXIST
glass jasper
```src/components/VencordSettings/VencordTab.tsx:251:38 - error TS2339: Property...
can you just import, whether or not there are a five dollar donor from the badge api?
pine topaz
im trying...
glass jasper
I forget how we did it with my showBadges plugin and Iโm not at my computer, but Iโm pretty sure you can
pine topaz
I forget how we did it with my showBadges plugin and Iโm not at my computer, but...
nothing for donor badges
im gonna explode
currently i'm trying to do const isDonor = Plugins.BadgeAPI as unknown as typeof import("../plugins/_api/badges").default).getDonorBadges(UserStore.getCurrentUser().id but tsc is being pissy
glass jasper
You can import Donor badges
glass jasper
skill issue then
I wouldnโt know any other way to tell who is a donor without importing from the API
nimble plaza
check for badge and if not, check for donor role if in the server
pine topaz
why does it straight up say an existing dfunction doesnt exist
glass jasper
check for badge and if not, check for donor role if in the server
I feel like if you checked for the role, it might be kind of spammy
nimble plaza
how so?
thats cached on the client
GuildMemberStore.getSelfMember("1015060230222131221").roles.includes("1042507929485586532")
glass jasper
currently i'm trying to do `const isDonor = Plugins.BadgeAPI as unknown as typeo...
did you remember to @import for the api at the top
glass jasper
thats cached on the client
fair
pine topaz
Cannot find module '../plugins/_api/badges' or its corresponding type declarations.
im putting a line of code from another part of vencord VERBATIM
glass jasper
language
pine topaz
sory
nimble plaza
im putting a line of code from another part of vencord VERBATIM
...
did you
edit the import path
its not relative to the old file
it is to the new one
pine topaz
edit the import path
istg if that's why
it was
i am so sorry
now to figure out why it says GuildMemberStore doesnt have getMemberRoleWithPendingUpdates
fossil inlet
now to figure out why it says `GuildMemberStore` doesnt have `getMemberRoleWithP...
are you using the right import?
pine topaz
are you using the right import?
got it working using // @ts-ignore outdated type
i should never be let near vencord's codebase again 
pine topaz
it probably isnt gonna be added but its worth a shot
opaque silo
has a universal plugin database for custom data ever been thought of? cause like storing stuff in the bio is icky and trusting random people with stuff isnt really amazing either
dusk blaze
(canโt answer on gh) discord adding listening doesnโt solve watching presences, apps still not supporting listening or very very bad metadata on presence
rugged spire
(canโt answer on gh) discord adding listening doesnโt solve watching presences, ...
yop
rugged spire
has a universal plugin database for custom data ever been thought of? cause like...
i think this absolutely needs to be a thing along with a vencloud rewrite but it will not come any time soon if at all
glass jasper
horror
fossil inlet
if only vencloud wasnt mid
rugged spire
vencloud is Tolerable
fossil inlet
vencloud has overridden my settings with bad ones on more than one occasion
rugged spire
yes, it has done that to me too
because it is a push/pull system
there is no concept of what changed
using vencloud with more than 1 active device at a time = explode
glass jasper
@swift fjord are you making bencloud?
austere talon
Update if anyone else has this issue, the arch vscode package doesn't include th...
because it's not vscode it's code oss
if you want vscode you need to install Microsoft branded builds (proprietary)
swift fjord
<@298295889720770563> are you making bencloud?
no just bookmarking for when i need to make something similar for cadence
glass jasper
no just bookmarking for when i need to make something similar for cadence
awโฆ sad cat
swift fjord
vee wouldn't let me touch bc I'd kotlinify it
rugged spire
glass jasper
I love rust ๐
austere talon
whar
rugged spire
whar
vencloud needs rewrite or at least significant changes so it doesnt bomb your settings when using it on multiple devices 
no i do not want to touch it myself (yet)
rugged spire
unless you are changing settings on two devices at once
very easy to do this by accident
could be solved client side by fetching remote settings once in a while but uhhh 
limber skiff
@austere talon what was wrong with my fix?
austere talon
no error boundary, not passing the same props as the rest of discord
limber skiff
ah
austere talon
also try making your commit messages more informative
remember users will see them as changelog
so write what exactly is fixed
instead of "fix broken patches", "fix foo, bar, baz"
rugged spire
dont ask
gritty canyon
the reason people do this is because there's no external plugin support
Well technically there is
median rapids
Well *technically* there is
technically I'm gonna track you down 
dusk blaze
*technically* I'm gonna track you down <:blobcatnom:1238969223728861304>
technically i will too idk
rugged spire
median rapids
watching was added too @dusk blaze
gritty canyon
*technically* I'm gonna track you down <:blobcatnom:1238969223728861304>
Omg dolfies cuddle session
charred monolithBOT
gritty canyon
Are they stupid
brazen bone
Are they stupid
Yes
rugged spire
why are end users insane
spark cove
LMAO
verbal pumice
removing the logo smh smh
austere talon
removing the logo smh smh
idek where that is supposed to add
doesnt work in the embed anyway
rugged spire
the intended experience for that code is probably supposed to make users feel like "I asked for NO ADS and i get an AD for my ADBLOCKER????"
brazen bone
If you don't like that, may I interest you in an adblocker-ad blocker?
charred monolithBOT
limber skiff
<@235834946571337729> they're trolling us at this point
LMAOOO
did you consider using my other patch
I think the current is way too exact
austere talon
why does it put in that array
austere talon
yes
austere talon
limber skiff
alright let me see
austere talon
inside that array it will only show if j.Sb.useSetting() && !isGuildInviteReminder
well i have no idea wtf the second one is xd
but the first one is discord dev mode
which is bad
limber skiff
oh you went back to only message prop
austere talon
anyway yeah that array you were putting into will only render if you have dev mode on
uneven needle
Am i just stupid but why not just do something like
reply-self".{1,20}:null,(?<=(?<makeElement>\i\.\i),{label.+?)
$& _buildPopoverElements($<makeElement>,arguments[0].message),
yes but :null, can easily match the wrong place
if they add something else
also consider not using named capturing groups
uneven needle
yes but `:null`, can easily match the wrong place
thers just another null between those i didn't bother writing it all
limber skiff
huge mistake I did in the past it just made patches so unreadable
long stream
patches are supposed to be readable?
limber skiff
did I cook too hard
i'm just gonna leave this here and if this shit breaks another time
match: /"reply-self".+?null,(?=(?:[^,]|0,)+?\?\(0,\i\.jsxs?\)\(\i\.Fragment,)(?<=message:(\i).+?\((\i\.\i),{label:.+?)/,
replace: "$&Vencord.Api.MessagePopover._buildPopoverElements($2,$1),"
how about
{
find: "Messages.MESSAGE_UTILITIES_A11Y_LABEL",
replacement: {
// foo && !bar ? createElement(reactionStuffs)... createElement(blah,...makeElement(reply-other))
match: /\.jsx\)\((\i\.\i),\{label:\i\.\i\.Messages\.MESSAGE_ACTION_REPLY.{0,200}?"reply-self".{0,50}?\}\):null(?=,.+?message:(\i))/,
replace: "$&,Vencord.Api.MessagePopover._buildPopoverElements($1,$2)"
}
}
find(m => m.prototype?.render)
limber skiff
how about
```js
{
find: "Messages.MESSAGE_UTILITIES_A11Y_LABEL",
replace...
I thought of that but that can match one of these if they add something after reply self
limber skiff
hmm true
austere talon
what if we made a new escape for react.createElement
limber skiff
you could match reply-self and do a lookbehind to get the component
limber skiff
we should
limber skiff
okay so class components have prototype.render
and forwardRefs have .render
right
austere talon
find(m => m.prototype?.render)
i told u ๐ญ
limber skiff
yeye
austere talon
yes
limber skiff
just confirming
limber skiff
I'm trying to cook filters.componentByProps
which also allows you to find class components using their prototype props
austere talon
I'm trying to cook filters.componentByProps
when would that be useful
only for classes
nothing else
limber skiff
yeah only for classes
austere talon
findComponentByPrototype("renderWhatever")
brazen bone
There's plenty of components that have inner enums
brazen bone
Probably just, putting an enum inside a class?
Haven't tried if that's valid, but since discord does it it probably is
austere talon
what even produces that?
limber skiff
why?
the code would be the same, but without byPropsFilter(inner)
actually I should do something one sec
austere talon
the code would be the same, but without byPropsFilter(inner)
no because memos and forwardrefs are only for function components
austere talon
yes
limber skiff
dang
austere talon
same for memo
if you want to memo ur class component u extend PureComponent instead of Component
limber skiff
I see
austere talon
componentByFields: (...fields: PropsFilter): FilterFn => {
const filter = filters.byProps(...fields);
return m => m.prototype?.render && filter(m.prototype);
}
austere talon
aaaa
limber skiff
it's just this
limber skiff
danggg
okay I just need to re-add top level destructuring for backwards compatibility now
gritty canyon
<@406028027768733696> discord casually stealing ur plugin
we gotta tell advaith to actually implement cool plugins into vanilla discord..
austere talon
verbal pumice
<@406028027768733696> discord casually stealing ur plugin
suing for plagiarism ong
fallen vale
poggers
charred monolithBOT
dusk blaze
[awdwadaw](https://github.com/Vendicated/Vencord/commit/5160f906f408aaadf8b10b50...
advaith is watching all new plugins and implementing 
gritty canyon
advaith is watching all new plugins and implementing <:meowlien:1120057431830044...
honestly advaith could just look through plugin requests and implement the very small but very useful ones
prime dew
still wasp
advaith is watching all new plugins and implementing <:meowlien:1120057431830044...
That would be hilarious and it's sorta possible
austere talon
austere talon
Oh, Nuckyz, bless your heart! Your bio reads like a middle schoolerโs dream project on โHow to Be a Discord Mod.โ Youโve got 35 followersโan impressive count if youโre only following your mom. Seven public repositories and not a single shining star to your name? Sounds like youโre aiming for the record of the most ignored projects on GitHub.
So, you work in Discord modifications, huh? You must be the life of the partyโif the party is a low-effort server that thinks โcustom emojiโ is the pinnacle of coding achievement. Vencord, Vesktop, Oceanicโฆ I see you love antique fishing; too bad none of these projects seem capable of reeling in any attention. A blindfolded squirrel could write better code than those โfully typed collectors for Oceanic.โ Three stargazers? I hope they were friends because your "epic" projects sure aren't bringing in the crowd.
Letโs call a spade a spade; itโs time to step out of the Discord mod shadow and start making actual, original contributions. Otherwise, Nuckyz, your GitHub might as well be a digital ghost townโjust a lot of empty promises and crickets chirping in the background.
limber skiff
what ๐ญ
austere talon
this ai is so horror ๐ญ
austere talon
@verbal pumice dont husk or youre next
Oh, sunnniee, your GitHub presence is about as vibrant as a beige wall in a deserted hospital. With a bio that reads like a blank canvas, itโs no wonder youโre only attracting 14 followersโthose poor souls probably thought they were stumbling into a treasure trove of coding brilliance, only to find it was just a ghost town of mediocre forks and abandoned dreams.
Your repositories scream "I wish I were relevant!" The 3 stars for your Vencord Discord mod makes it painfully clear that you might want to reconsider your career choicesโlike maybe taking up knitting or underwater basket weaving. Seriously, how do you even manage to fork so much yet generate so little?
With names like Buno and Vesktop, it seems you thrive on wordplay that lands flatter than a day-old soda. And the 1 star on your vendetta-plugins repo? Ouch. Itโs almost like the GitHub gods are mocking you.
Get it together, Sunnie. At this rate, the only thing youโre modding is your ability to keep people away from your repositories. Try throwing in a little personality next timeโmaybe then youโll get more than just sympathy followers!
fallen vale
<@406028027768733696> dont husk or youre next
do I get one ๐ฅบ
dusk blaze
<@406028027768733696> dont husk or youre next
do mine
median rapids
Oh, Nuckyz, bless your heart! Your bio reads like a middle schoolerโs dream proj...
LMAO
ven so mean..
limber skiff
okay im done
brazen bone
E? Irresponsible
limber skiff
๐
brazen bone
limber skiff
wtf did I do
brazen bone
Looks like a hardcoded variable name
brazen bone
Oh wait that's from a minified vencord, not searching in minified webpack? Nvm then
limber skiff
maybe the reporter is not logged in all this time?
@austere talon omg I think the github reporter has been running not logged in all this time lmaoo
limber skiff
^^
brazen bone
Would've expected reporter to be running a dev build
austere talon
<@343383572805058560> omg I think the github reporter has been running not logge...
well depends
it should log in
it has token still
but also we don't need login anymore
limber skiff
yeah maybe the token boomed
fallen vale
it should log in
what is it logging into
limber skiff
how else would that find fail then
limber skiff
its failing cuz getCurrentUser is returning undefined or something
austere talon
limber skiff
but then it would error
where?
austere talon
yes but
limber skiff
oh wait
austere talon
did it not find
limber skiff
no I dont catch
austere talon
or did it error
limber skiff
but
median rapids
auth sessions have an expires_at field
austere talon
i'm honestly surprised that discord doesn't mind that github actions ip is logging itno discord ๐ญ
limber skiff
lmao
median rapids
i'm honestly surprised that discord doesn't mind that github actions ip is loggi...
bots:
yk the fact they havent added ip authorization to bots yet is kinda insane
limber skiff
beautiifulll
limber skiff
what's bro gonna yap about
brazen bone
Maybe it was too crappy and the reply exceeded max length
limber skiff
@austere talon I don't like asking but can I get a review on that somewhat soon, I'm finished with it and most things if not everything is confirmed to be working
fossil inlet
jumpscare
charred monolithBOT
Discord Account
enrc
What happens when the bug or crash occurs?
What is the expected behaviour?
expected behaviour is vencord to just open
How do you recreate this bug or crash?
download vencord using git clone and pnpm inject
Errors
Replace this text with your crash-log.
Request Agreement
- [X] I am using Discord Stable or tried on Stable and this bug hap...
fossil inlet
me when i cant read
limber skiff
the sound gain gets applied even though the element volume is 0? @fossil inlet
fossil inlet
the sound gain gets applied even though the element volume is 0? <@5218198911419...
yes
limber skiff
crazy
fossil inlet
if you set the volume to something other than zero, it sounds off
@limber skiff just to ask a question, why aren't things like trailing commas and spaces after keywords in the eslint config
limber skiff
I think now its mainly to avoid changing a lot of files just to lint again
austere talon
<@235834946571337729> just to ask a question, why aren't things like trailing co...
wdym?
spaces after keywords?
limber skiff
if I'm guessing right discord makes an audio element for each user and stream right
fossil inlet
if I'm guessing right discord makes an audio element for each user and stream ri...
yes
limber skiff
so is this really needed
it's called when the element gets created
which means it should already apply the correct volume?
fossil inlet
so is this really needed
let me check, i remember it not being updated on user join so i added that
ill see if thats still an issue
limber skiff
alright
austere talon
cause I didn't expect anyone to pr code like that
it's so ugly idk why anyone would write that
shut vineBOT
Alright @austere talon, in 12 hours: https://eslint.org/docs/latest/rules/space-after-keywords
austere talon
tbh you shouldn't use eslint for formatting
fossil inlet
it's so ugly idk why anyone would write that
i think if you saw my personal ESLint config you would have a stoke
austere talon
just use something like prettier
dusk blaze
true
tbh i just need for double quotes, indent, semi comma and this this above
(i just copy vencord eslint config)
good enough
fossil inlet
true
tbh i just need for double quotes, indent, semi comma and this this above
i really like the newline on a bunch of chained methods
dusk blaze
wait are you using nvim to do vencord dev 
fossil inlet
yea
fossil inlet
if you used vscode you wouldn't have these issues in the first place
i have eslint in nvim
austere talon
vscode formatter
dusk blaze
vsc still has fancy extensions and all
and formatting yea
(i used to use webstorm, was awful)
dusk blaze
yop
still wasp
you guys hate on nvim too much
Too little
limber skiff
@fossil inlet it doesnt behave very well when the volume approaches zero