guh
#👾-core-development
median rapids
damn early bday
gritty iris
That will either be used as an actual fork or be left there to rot idk which yet
Idrk why none our stuff was forked to begin with
charred monolithBOT
need to make avatars centered. it's surprisingly hard because it's in an inline context (span) and none of the vertical-aligns seem to work. using flex isn't an option cause it messes up alignment with other types of mentions like role mentions
austere talon
conflioct with RCE its over
swift fjord
new update soon
charred monolithBOT
verbal pumice
can you add noprofilethemes next to norpc in vencord debug 🙏
actually ill do it myself
rugged spire
Explode https://github.com/Vendicated/Vencord/pull/2652/commits/07f031b8e2e5fcb4c62fd8fb0e77063c73f86889
@rugged spire
fossil inlet
@rugged spire
wary dew
@rugged spire
rugged spire
@austere talon will make less ugly by adding option to disable @ and patch chatbox mentions too
other than that I think this plugin will stay on and I am confused why this isnt a stock discord feature
sterile oak
there is now types of message references, maybe because of the new experimental feature?
rugged spire
there is now types of message references, maybe because of the new experimental ...
yes likely because of forwarding
yes
forwarding is type 1
reply is type 0
shut vineBOT
Alright @rugged spire, in 2 hours, 36 minutes and 25 seconds: resizablesidebar crashes on mobile web
shut vineBOT
@rugged spire, <t:1720941815:R>: resizablesidebar crashes on mobile web
austere talon
enchancement
charred monolithBOT
dusk blaze
challenge people read request agreement (IMPOSSIBLE)
spark pivot
what if there was /vencord-themes so we could see if someone actually has themes on or not
fossil inlet
what if there was /vencord-themes so we could see if someone actually has themes...
thought this was a good idea, so i made this as a proof of concept
still wasp
thought this was a good idea, so i made this as a proof of concept
THAT'S HOW YOU BROKE YOUR DISCORD 😭
fossil inlet
THAT'S HOW YOU BROKE YOUR DISCORD 😭
i didnt thing example.com would do anything 😭
spring gorge
thought this was a good idea, so i made this as a proof of concept
quickcss beign 1000+ lines for me:
fossil inlet
quickcss beign 1000+ lines for me:
its uploaded as a file
fossil inlet
its also optionally uploaded, not automatically
spring gorge
oh?
fossil inlet
after you run the command, it is prompted as a file upload
charred monolithBOT
it would be much better to use Discord's TabBar component for this. Check out the Themes settings component for an example
austere talon
actually maybe i might do it myself
charred monolithBOT
shell shuttle
why was globalbadges never a plugin built into vencord
i forgot
and if not globalbadges
at least badges from other clients
like imagine being able to see aliuxord contributor, other client badges, etc
austere talon
cause misleading and against the point
limber skiff
I use it on my daily basis
and to also avoid having to fix so many conflicts in the future
a lot of times a conflict emerges
charred monolithBOT
topaz spoke
dusk blaze
don't we all?
chilly parcel
is there something already in place for doing a setting value isValid check only once the user stops typing? or do I need to do it myself
I don't think sending a web request on each keystroke would be the best idea...
rugged spire
what are you trying to validate
chilly parcel
what are you trying to validate
if the user has this setting toggled on it just... doesn't work
get's a 403
and never reports that to the user of the plugin
rugged spire
maybe settings isnt the best way of validating and displaying that info?
chilly parcel
maybe settings isnt the best way of validating and displaying that info?
it would be really intuitive to have it just... tell you if it's wrong though
and it could probably also be easily made to report an invalid api key for those who are incapable of reading and copy paste the client secret instead of the key
austere talon
I don't think this is a real use case
such a rare edge case
noone turns that off or if they do they should realise
and no one has ever complained about it
just a note should be enough
chilly parcel
fair
rugged spire
just modal first time it is detected and save to datastore that the warning has been seen
chilly parcel
I had it off for ages and completely forgot about it when enabling the plugin, but an addition to the settings info card is probably more than enough
rugged spire
ailucord plugins repo jumpscare
granite sky
Insane
granite sky
rugged spire
fuck you
rugged spire
why do you even have thirdpartyplugins folder
I have soft-fork with all of #1256395889354997771 imported as submodules
austere talon
v+ programming @scenic fog
rugged spire
thats why .git/info/exclude exists
this will come back to bite me in 2 days
scenic fog
even nativeTheme.shouldUseDarkColors is false 
I'm resorting to an scheduled-dark-theme extension in VSCode as well, which makes me suspect this is a Chromium/Electron thing
rugged spire
even `nativeTheme.shouldUseDarkColors` is `false` <:FRICK:971378048303783939>
I...
tl;dr: chromium devs take 5 years to implement any semi-niche compatibility with modern protocols on linux
rugged spire
google employee will come to my house and kill me if i do it
google only cares about making wayland experience worse 
mfw newer chromium version adds MORE FUCKING BUGS RATHER THAN FIXING THEM
this has happened twice btw
rugged spire
this has happened twice btw
specifically regarding wayland stuff when talking about this
granite sky
google employee will come to my house and kill me if i do it
Fork chromium and use a repo like a storage 🙏🏽
woeful sable
sucks that you cant make forks private 🙏
rugged spire
github issue
austere talon
even `nativeTheme.shouldUseDarkColors` is `false` <:FRICK:971378048303783939>
I...
seems like a system issue
scenic fog
so I'm not changing whatever Chromium is looking at 🤔
Firefox is definitely dark though
rugged spire
in that case its a DE issue
austere talon
discord sync also works
rugged spire
@scenic fog what DE are you using
scenic fog
Cinnamon (I'm using Linux Mint)
rugged spire
yeah thats your issue
i dont even need to be confident but
linux mint so out of date with modern anything protocols
its an xdg-desktop-portal thing that chromium is using
and i dont need to check to be confident that cinnamon does not support it
scenic fog
ah, seems like I found the setting
scenic fog
well, there's a thing in Themes that lets you pick between "Prefer dark mode", "Prefer light mode" and ... "Let the apps decide", I had that one selected
rugged spire
wait
it is supported
how
am i just assuming mint supports barely anything because of cinnamon wayland stuff taking so long and how they ship outdated stable kernels
scenic fog
so I'll be able to use the system theme option like a normal user now I guess :p
scenic fog
so, how would you make it so a certain online theme only applies on light or dark mode? two fields like I did for the auto theme switcher plugin, or just a prefix on the line like @light / @dark? (or is that already possible in some way :p)
rugged spire
html.theme-light html.theme-dark selectors
scenic fog
To put a condition on theme links I mean
(I could definitely download the css files and mess with them though, which makes that useless 😅)
rugged spire
Oh
I just thought i had a good idea
then I remembered @import had to be at the top of the file
and isnt conditional
@scenic fog You have 2 options
Modify Vencord to add that conditional theme support
Modify your themes and wrap them in CSS selectors
austere talon
Modify Vencord to add that conditional theme support
yes that's what they're talking about...
rugged spire
i need some fucking sleep 😭
topaz spoke
@austere talon would this channel be the correct one, to talk about the installer rewrite?
austere talon
yes
charred monolithBOT
Discord Account
No response
What happens when the bug or crash occurs?
Whenever I do anything, this popup is being opened over and over again:
Also, you have to dismiss every popup before the app is accepting any further interactions.
What is the expected behaviour?
These popups should obviously not be there. I suppose Discord changed something about their Sentry packages.
How d...
scenic fog
so, how would you make it so a certain online theme only applies on light or dar...
something like this maybe? 🤔
somber thorn
would not be surprised if people forgot they did this and came back to complain
fossil inlet
would not be surprised if people forgot they did this and came back to complain
Only remember after an hour long convo in #🏥-vencord-support-🏥
granite sky
Only remember after an hour long convo in <#1026515880080842772>
They closed an issue after a 27 minutes of it's existence
fossil inlet
They closed an issue after a 27 minutes of it's existence
Whar
granite sky
i'm braindead
fossil inlet
most badges, arent affected that much
a few look a lot worse, a few look a lot better
(from what was in the file)
fallen vale
is it reasonable to have the style per-badge? or is that too much
fossil inlet
is it reasonable to have the style per-badge? or is that too much
nah, just make a tool to preview badges
scenic fog
most badges, arent affected that much
a few look a lot worse, a few look a lot b...
Yeah seems like it
It seems easier to make the badges square if they look better that way, than adding an option 🤔
(for people that care about that and ask for it, that is :p)
scenic fog
(hi ^^')
scenic fog
for some reason it looks more zoomed in when on light theme too 🤔
fossil inlet
for some reason it looks more zoomed in when on light theme too 🤔
looks the same to me 
scenic fog
hm yeah, I was thinking that as I posted this
that'd explain why I couldn't quite figure why it was different ^^'
austere talon
for some reason it looks more zoomed in when on light theme too 🤔
I noticed that LOL
same happens with the vencord badge
like the vencord logo
why tf is it that way
charred monolithBOT
dusk blaze
this plugin had potential until it didn't have setting to not upload file to some random file host
rugged spire
WHAT IS discord.new/PJ6VvgEJYg45 AND WHY DID I FIND IN SOURCE CODE
7150 PEOPLE USED THIS?
discord.new/UqzZCTj2zfwy
frail skyBOT
rugged spire
do ask what I am researching
discord.new/2TffvPucqHkN
34699 people used this template
https://tenor.com/view/lie-lie-detector-cap-you-are-lying-stop-lying-gif-12198388917433403789
frail skyBOT
rugged spire
discord.new/2TffvPucqHkN
Discord LOVES inconsistency
why is GuildTemplateStore absolutely useless for what I want to do?
@nova chasm
still wasp
@discordapp my beloved
rugged spire
ok what the fuck...
rugged spire
ok what the fuck...
Discord has 2 create server endpoints
the standard one
and the template one
both accept template codes
dusk hill
discord moment
rugged spire
the standard one
FUCK THIS ENDPOINT IN PARTICULAR
dapper crest
Lmao
rugged spire
no but why does one endpoint ask you supply the channels/roles AND the template code
and the other endpoint asks you to submit just the template code in the URL
dapper crest
Discord shit code
rugged spire
Real
rugged spire
the standard one
Whats even funnier is how the UI for the channels/roles isnt shown here where it is required
rugged spire
and the template one
but the UI is shown here and the endpoint doesnt need it
charred monolithBOT
Changes your status on Steam with protocol URIs:
Preview images
This works by using the Steam friends protocol: steam://friends/status/{online|away|invisible|offline} to change your status on Steam when your Discord status updates.
While it technically also could work on web, in my testing it crea...
oak hull
closed, i merged around 100 commits and i know this wont be accepted anymore
granite sky
Vee is giving everyone time to think about the uselessness of their pr
still wasp
Mm maybe friendshipranks isn't a good plugin after all
median rapids
the standard one
this one's template field doesn't do anything
pretty sure it's analytics
median rapids
i mean the guild_template_code field in POST /guilds
rugged spire
i mean the `guild_template_code` field in `POST /guilds`
Does that really do nothing because the channels and roles are supplied in the request
median rapids
the channels and roles are what actually do something lol
median rapids
also for a while the default template was localized
so the server would create channels with spaces
when the locale had them
median rapids
dont believe so
rugged spire
Or did they fix on client
median rapids
wasnt client issue
glass jasper
Mm maybe friendshipranks isn't a good plugin after all
rugged spire
You still send the channel list to the server
still wasp
https://tenor.com/view/lie-lie-detector-cap-you-are-lying-stop-lying-gif-1219838...
There is like no way it's gonna get merged lmao
glass jasper
There is like no way it's gonna get merged lmao
Even if it’s still a good plugin
I love it very much
median rapids
im writing a mildly insane plugin rn
rugged spire
https://i.dolfi.es/aDjKWwA6Lh.png?key=ZqpHff58x4ijbW
From my knowledge/experience this makes a server with default channels and categories
median rapids
yes
#general was localized
to #idk foreign lang where the word general has a space
still wasp
I just had an idea
That probably sucks
Translate channel names / topics and cache them
rugged spire
insane ram usage as a feature
DevilBro? Is that you?
rugged spire
Translate channel names / topics and cache them
Logic for this would be so good for those shitty servers that use unicode math symbols for channel names making them hard to mention and ugly
still wasp
Incredible
Honestly maybe just a general cleaner ui plugin would be cool
Like, remove emojis/symbols from channel names and other places
woeful sable
Logic for this would be so good for those shitty servers that use unicode math s...
i dont understand why they even allow those characters
median rapids
DevilBro? Is that you?
unfortunately not 😔
rugged spire
i dont understand why they even allow those characters
discord too dum to allow space and caps in channel names for some reason but allows this
charred monolithBOT
still wasp
Horror
charred monolithBOT
Adds the possibility to make an online theme only apply when Discord is in light or dark mode:
QuickCSS snippets can already be conditionally applied with the .theme-light and .theme-dark selectors.
This is what remains of the AutoThemeSwitcher idea... the light dark theme switching is better handled with the "system theme" option.
Wrong repository, read the Issue template descriptions.
Requests plugins here: https://github.com/Vencord/plugin-requests
charred monolithBOT
prime dew
textreplace
granite sky
This plugin will be useful for business using Discord that want to have their business signature under their messages.
2 new devs for a preSend
Are they insane
median rapids
actually true
median rapids
forum signatures are back lmao
fallen vale
specifying addition of devs in the PR is crazy
scenic fog
corporate email signatures that say that the message of the employee does not represent the stance of the company, that it isn't guaranteed that the message is virus-free, that the message is only to be read by its intended recipient, etc
fallen vale
> textreplace
how would you use text replace for that?/genq
granite sky
how would you use text replace for that?/genq
$ as regex
scenic fog
actually there was https://github.com/Vencord/plugin-requests/issues/883 that got rejected 5 days ago
prime dew
how would you use text replace for that?/genq
Find: (*+)
Replace: $1\nsignature
And yes, that was on a plugin request the other day
granite sky
$ as regex
scenic fog
> This plugin will be useful for business using Discord that want to have their ...
also a bit weird that it was submitted as a PR by a third person 🤔
fallen vale
also a bit weird that it was submitted as a PR by a third person 🤔
it looks like thats an org, that for some reason is using an account rather than an org.
💀
austere talon
poor self advertising attempt
dusk blaze
awful grammar
clearly didn't have eslint
cant follow var naming conventions
wait was this person that you removed submission pass from
dusk blaze
poor self advertising attempt
really bad attempt
fallen vale
oh god-
dusk blaze
his site
woeful sable
ah
fallen vale
their dc banner is just... ew.
that banner, with
god got me here ✞
in the top of their bio is crazy
woeful sable
whats their discord
fallen vale
just click on their website
it opens up their profile
more specifically, on the discord thing on their website
woeful sable
it opens up their profile
im on mobile 😭
spice python
@stone falcon ignore
woeful sable
banner seems fine..?
bro puts his site and shit everywhere
self advert in his bio, pronouns, status and custom status
😭
fallen vale
banner seems fine..?
open the main profile
dusk blaze
(nsfw)
woeful sable
😭
dusk blaze
god i hate mobile
you have to start dm and view profile from there
no need to send messages
fallen vale
discord mobile my beloved
woeful sable
you have to start dm and view profile from there
figured ye
spice python
the github on his website leads nowhere 😭
fallen vale
the other site (the one belonging to the opener of the PR) opens a 403 page lol
spice python
the github on his website leads nowhere 😭
wait did he get termed maybe
spice python
i kinda wanna report that other account
because github doesnt allow having multiple accounts afaik
woeful sable
discord mobile my beloved
i use aliucord as well 😭
fallen vale
really bad attempt
#👾-core-development message
#👾-core-development message
i mean he isnt exactly the least racist person ever
spice python
the other site (the one belonging to the opener of the PR) opens a 403 page lol
THEY HAVE A DISCORD
anyways we should probably stop before vee sees this
dusk blaze
we should hop on #🌺-regulars 
fallen vale
nice channel
charred monolithBOT
fossil inlet
What is bro yapping about
keen blaze
spark pivot
me when i spread misinformation
taking a quick gander in the support channel shows no sign of this ever happening
fallen vale
no, love, no it doesnt.
fossil inlet
what does this pr even do
fallen vale
why does interacting with anything on a review say you submitted another review..
charred monolithBOT
dusk blaze
why does interacting with anything on a review say you submitted another review....
github webhooks are soooo bad
spark pivot
github webhooks are soooo bad
github are soooo bad
still wasp
Github are soooo bad
fallen vale
glass jasper
horror
austere talon
evil
charred monolithBOT
charred monolithBOT
glass jasper
We love Cancary 
spark pivot
this guy 😭
glass jasper
Discord Canary shout-out
hallow kestrel
debating weather adding tint support for spoilers cover in message logger is a good idea or not.
so far support for subtext, mention and codeblock are added to the PR.
hallow kestrel
Discord Canary shout-out <:canary:1252721945699549327>
catbox exposing me out here. 😭
glass jasper
catbox exposing me out here. 😭
nest.rip does the exact same thing too me
austere talon
discord moment
limber skiff
might be a me moment
limber skiff
I see
austere talon
idk how to reproduce it
limber skiff
neither am I
limber skiff
fake user?
limber skiff
I see
austere talon
i think it could just remove that update
idk why i added it
wow it's your fault smh /s
limber skiff
omg
austere talon
limber skiff
ah
austere talon
charred monolithBOT
austere talon
should fix it
rugged spire
I made a disgusting fix for the issue when using the new deb package. It somehow works.
lmao now i get to try native streaming
it... doesn't work
I would add this to NoTrack but it needs to be done before renderer is even loaded
austere talon
le native.ts
rugged spire
le native.ts
99% chance that is too late too.
This HAS to be done before Discord's own script even loads (I think?)
This just stops anything Sentry from loading
austere talon
99% chance that is too late too.
its not
rugged spire
its not
when are native modules loaded
must be loaded before discord's own desktop script
rugged spire
must be loaded before discord's own desktop script
any later and it's useless and discord error spam comes back I think
lol what
is vscode assuming my bashrc is malicious LMAO
wait
no
vscode inserts their own bashrc
thats why
rugged spire
vscode inserts their own bashrc
which may or may not be safe
this native.ts doesn't run at all
austere talon
idk if build script is set up to support folders in _core
rugged spire
idk if build script is set up to support folders in _core
Works for non-native.
austere talon
is vscode assuming my bashrc is malicious LMAO
no
they're asking if u trust the folder
you should only check it if u... trust the folder
rugged spire
yeah
austere talon
u can create various config files that will execute code
rugged spire
but it's assuming their own bashrc will auto-run code there
austere talon
like .eslintrc.js
austere talon
but it's assuming their own bashrc will auto-run code there <:blobcatcozy:102653...
no?
there are so many config files that can run code
austere talon
like .eslintrc.js
^
rugged spire
true
idk why vscode explicitly blocks terminal from even opening though
maybe it should warn you that your own config might run stuff
anyway
austere talon
it has nothing to do with that
vscode restricts a lot of features in untrusted folders
Restricted Mode tries to prevent automatic code execution by disabling or limiting the operation of several VS Code features: tasks, debugging, workspace settings, and extensions.
rugged spire
I know what Restricted Mode is
I just feel like they didn't consider the built-in terminal extension integration and just blanket disabled it
anyway back to native code hell
rugged spire
idk if build script is set up to support folders in _core
yeah this is half the issue
I need your advice
Do I
- Leave it in patcher.ts (benefit of not having to explicitly specify when to load in my own native.ts file)
- Edit the native loading code to load natives in src/_core (slightly more annoying but keeps code related to the same concept together)
lol what is discord smoking
austere talon
^
rugged spire
no this is me smoking some git pull upstream dev and not merging on my other branch
limber skiff
no one saw it
rugged spire
whats funny is that was actually being patched by ConsoleJanitor
limber skiff
shh
rugged spire
@limber skiff I saw it
austere talon
saw what
limber skiff
actually no cuz then i wouldnt be able to run reporter
austere talon
rugged spire
I should have made these branches on my fork
it is never too late to do so
rugged spire
u can run reporter on fork tho
needs token
austere talon
austere talon
see
USER_UPDATE expects an API user which is plain json
but the plugin was dispatching user class instances
which has getters and shit
including getter for clan
that's what caused the error
limber skiff
should I stop with my two pull requests and just merge them and make a single one
austere talon
uhh idk
limber skiff
they are already huge it makes no difference 😭
limber skiff
yep
austere talon
too much going on
austere talon
including getter for clan
limber skiff
to be fair I can give my word that they are stable
but I would want still want you to at least give an opinion on the changes
not that they work
send me a list of your enabled plugins vee
I wanna compare to mine
austere talon
for?
limber skiff
to see if you use plugins differently from me which then you could use my branch a little to make sure no plugin is broken
not that you need to test, just use it normally and you would notice
austere talon
simply daily drive all plugins enabled
Enabled Plugins (92):
AutomodContext, BetterGifAltText, BetterGifPicker, BetterRoleContext, BetterRoleDot, BetterSettings, BetterUploadButton, BiggerStreamPreview, CallTimer, ClearURLs, ClientTheme, ConsoleShortcuts, CopyEmojiMarkdown, CrashHandler, Dearrow, Decor, DevCompanion, EmoteCloner, Experiments, F8Break, FakeNitro, FavoriteGifSearch, FixCodeblockGap, FixSpotifyEmbeds, FixYoutubeEmbeds, FriendsSince, GameActivityToggle, GifPaste, GreetStickerPicker, HideAttachments, iLoveSpam, ImageZoom, KeepCurrentChannel, LastFMRichPresence, LoadingQuotes, MemberCount, MentionAvatars, MessageClickActions, MessageLatency, MessageLinkEmbeds, MessageLogger, MessageTags, MoreUserTags, MutualGroupDMs, NoDevtoolsWarning, NoF1, NoOnboardingDelay, NoReplyMention, OnePingPerDM, OpenInApp, PauseInvitesForever, PermissionFreeWill, PermissionsViewer, petpet, PictureInPicture, PlatformIndicators, QuickMention, QuickReply, ReactErrorDecoder, RelationshipNotifier, ReverseImageSearch, ReviewDB, RoleColorEverywhere, SearchReply, Summaries, SendTimestamps, ServerInfo, ShowConnections, ShowHiddenThings, ShowMeYourName, ShowTimeoutDuration, SpotifyControls, SpotifyCrack, ThemeAttributes, Translate, TypingIndicator, TypingTweaks, Unindent, UnsuppressEmbeds, USRBG, ValidReply, ValidUser, VcNarrator, VencordToolbox, ViewIcons, ViewRaw, VoiceDownload, VoiceMessages, WatchTogetherAdblock, WebKeybinds, WebScreenShareFixes, WhoReacted
```**Enabled UserPlugins (2):**
QuickReactFrequents, UnicodeInspector
what is UnicodeInspector userplugin and why isnt it included by default
limber skiff
I make another branch
which merges my two pull requests
and this
the biggest branch of vencord
rugged spire
I make another branch
I will steal your github access tokens and force push it and explode it
limber skiff
the conflicts are gonna be crazy
austere talon
what is UnicodeInspector userplugin and why isnt it included by default
- too niche
- i am too lazy to make the ui not ugly
- can be done with user-app
rugged spire
the conflicts are gonna be crazy
so true
austere talon
1. too niche
2. i am too lazy to make the ui not ugly
3. can be done with user-a...
it's just plugin version of
nimble pendantBOT
vchars
s LATIN SMALL LETTER S
o LATIN SMALL LETTER O
SPACE
t LATIN SMALL LETTER T
r LATIN SMALL LETTER R
u LATIN SMALL LETTER U
e LATIN SMALL LETTER E
rugged spire
1. too niche
2. i am too lazy to make the ui not ugly
3. can be done with user-a...
so are you going to port some of venbot to use slash commands and allow some of its functionality to be used as userapp?
(no)
austere talon
no
rugged spire
there is already
rugged spire
what do you use it for
nimble pendantBOT
owo
swift fjord
only let people that don't use userapps use it as a userapp
rugged spire
owo
i honestly thought this sent me "explode" in DMs when it was just vee
is /say ephemeral in servers?
rugged spire
yeah i meant like that
nimble pendantBOT
owo
fallen vale
okay now thats gonna get spammed to oblivion
shell shuttle
done
nimble pendantBOT
owo
hallow kestrel
debating weather adding tint support for spoilers cover in message logger is a g...
still deciding if this is a good idea or not.
nimble pendantBOT
owo
glass jasper
still deciding if this is a good idea or not.
seems like a good idea to me
charred monolithBOT
added spoiler support while preventing changing the entire spoiler's background color upon reveal. tbh it looks like someone is probably just using row of emojis until you actually click on it and it's a spoiler lmao.
rugged spire
is it just me or do i find it really fucking funny how discord already ignores VencordPatcher errors (and other client mods)?
what if I just uhhhhhhh 
disabled the rest of their error logging
charred monolithBOT
still wasp
is it just me or do i find it really fucking funny how discord already ignores V...
That is actually pretty hilarious
Vencord is discord canon
austere talon
const sentryPath = require.resolve("@sentry/electron");
require.cache[sentryPath] = {
id: sentryPath,
loaded: true,
exports: null,
}
rugged spire
i was just about to say what is this psuedocode 😭
austere talon
wdym pseudo code
it wasn't
it just added all fields, some of which aren't needed
what was dirname()
austere talon
<:blobhuskcozy:1026533139608252436> what was dirname()
?????
austere talon
a function
rugged spire
rugged spire
<:nyabom:1124686162540371968>
see my issue
i originally tried this by replicating https://github.com/Sqaaakoi/Vencord/blob/078e89f77c56128c581a1d2b0285b4c17df68c20/src/main/patcher.ts#L112-L118
grave mangoBOT
i originally tried this by replicating https://github.com/Sqaaakoi/Vencord/blob/...
patcher.ts: Lines 112-118
// Replace electrons exports with our custom BrowserWindow
const electronPath = require.resolve("electron");
delete require.cache[electronPath]!.exports;
require.cache[electronPath]!.exports = {
...electron,
BrowserWindow
};
cause it doesnt have the asar in search path
austere talon
so how do I load it earlier?
import Module from "module";
const sentryPath = Module._resolveFilename("@sentry/electron", {
paths: require.main!.paths
})
troll
rugged spire
dont worry i figured it out just as you posted that
but what you have might be more reliable
austere talon
whatd u come up with
rugged spire
something that didnt work
rugged spire
wdym "core"
rugged spire
it's in the node_modules of their asar
austere talon
yes its in discord desktop core
rugged spire
thought thats what you meant
austere talon
wait both have it
austere talon
okay sorry
i forgot how my own code works
// @ts-ignore
import { _nodeModulePaths, _resolveFilename } from "module";
const sentryPath = _resolveFilename("@sentry/electron", {
paths: _nodeModulePaths(dirname(require.main!.filename))
});
require.cache[sentryPath] = {
loaded: true,
id: sentryPath,
exports: null
} as any;
try this
rugged spire
still doesnt work
rugged spire
just sends Error: Cannot find module '@sentry/electron' and a stack trace to the console
austere talon
yeah skill issue im afraid
works for me
don't try to require it
copy code
anyway idek if this works or if the discord asar has a different require cache
it should work
cause electron also works
rugged spire
works for me
console log the path it returns
spark pivot
austere talon
wait this is cool https://github.com/Kyuuhachi/VencordPlugins/blob/main/MessageLinkTooltip/index.tsx
should be added as an option of the messagelinkembeds plugin
limber skiff
in kyuu webpack tarball
brazen bone
can just set a variable
Been a while since I wrote that code, but I think the intention was that it should throw an exception anyway to avoid running the function for real, so why not use the value as the exception for extra cursedness?
But since the function is just an object lookup there shouldn't really be any harm in running the actual thing
charred monolithBOT
desert cosmos
im pretty sure uploaded stuff expires after some time, is it really worth it to log anything media related
somber thorn
if your discord client caches the image/preview, yeah, it would still display
topaz spoke
so I am currently trying to figure out the structure of the tauri installer rewrite, but bumped into some issues. From my understanding the appended code for the install function just reopens the installer with higher privileges with the install argument. So my question is, if I should follow the same structure for both the repair and uninstall functions and later parse the argumenst to run the actual install/uninstall functionality. My second question is, why you would reopen the installer with the argument, instead of directly running the code to patch/uninstall. Is it related to, the installer not having the privileges to manipulate the file system or something else?
dusk blaze
me when i don't know how to git pull a pr
austere talon
so I am currently trying to figure out the structure of the tauri installer rewr...
it's very unfinished I wouldn't pr to that
but yes it's to elevate to root
topaz spoke
but yes it's to elevate to root
what does that mean?
brazen bone
It means being able to write to directories like /opt/discord, which are owned by root
spark cove
@austere talon my idea was to:
- with an esbuild plugin, create a global similar to
Vencordbut it auto exports every exported value in the renderer build (excluding exports from plugins). - generate type information for that global every build, and publish the types to something like
@vencord/renderer - create an vite-based plugin dev cli tool, like
@vencord/cli. would have HMR support, and would transform imports into using the global. - plugins would be built targeting a specific vencord build version, and the build would include metadata about what imports it uses. when updating, the client could check the type signature differences and determine what plugins to disable due to breaking changes.
- the loading system would be as simple as u said, although probably using
new Functioninstead ofevalso v8 can still JIT it.
i've played with vite hmr a BUNCH lately, and I probably could just add plugin HMR to regular vencord tbh, if you wanted that
it would require switching from esbuild to vite tho, which would be pretty easy i think, i'd be very down to do it if you had any interest in it
austere talon
<@343383572805058560> my idea was to:
- with an esbuild plugin, create a global ...
first 3 were already done
this was already fully functional
the example plugin worked
but i scratched the entire idea because I simply don't want modularity
austere talon
the entire point of vencord is that everything is inbuilt so we have full quality control and can make a functionality guarantee
with external plugins it's way worse
plugins get abandoned, people write bad code, etc
Also we can't provide support with plugins we don't control
Also always security aspect
spark cove
yea pretty true, if it was added you'd want control over where they came from and stuff, rather than letting anything install them
i got the urge to do this because i had a plugin idea for the first time in a long time.. and it's been making me think about vencord again
austere talon
i've played with vite hmr a BUNCH lately, and I probably could just add plugin H...
idk how useful that would be
ig for ui code yeah but as soon as you change patches you need to reload
but i would hold out with it for a bit cause I'm currently reworking how vencord build works
austere talon
^
spark cove
oo interesting okay
austere talon
im not opposed to using vite as long as you can replicate all plugins and such
brazen bone
What's hmr?
spark cove
hot module replacement
austere talon
hot module reload
spark cove
yea
brazen bone
Oh, that's cool
austere talon
like you change code and it hot reloads in place instead of needing to reload
we could absolutely hmr ui code
like your react components
spark cove
idk how useful that would be
ig for ui code yeah but as soon as you change patc...
yea but i think that's just patches, hmr could hot swap pretty much everything else
austere talon
yeah
spark cove
even the other stuff inside index.ts that isnt patches
and if the dev wanted,, hmr could help with patches by auto-refreshing on change
austere talon
What's hmr?
this
austere talon
oh wow this is pretty sick
tbh i wish I had done that from the start
the current model makes it impossible to add new files
once we have asar we can add new files easily without having to make changes to the installer and updater
spark cove
oh like css/main/preload/renderer currently
spark cove
yea thats awesome
austere talon
maybe bundle dependencies into the asar instead of loading from cdn
the entire reason we load from cdn is cause of this limitation
spark cove
yea that would be VERY sick
austere talon
it's probably kinda pain to do with vencord tho
cause we don't control the react instance and such
crude hearth
what advantage does asar even give
spark cove
they just said lolol
crude hearth
once we have asar we can add new files easily without having to make changes to ...
oh
spark cove
no i havent really seen much from the last like year and a half
other than what you've dmed me
that sounds fire
crude hearth
vencord installer webapp
spark cove
no i havent really seen much from the last like year and a half
oh yea i did see that theres a cli installer binary now, that has been so awesome to use
crude hearth
truly sad piece of history is getting created
I still use this installer whenever vencord breaks 
spark cove
with the asar thing, I think I definitely want to try switching to vite after the PR design is finalized
and i wanna review the asar PR when its undrafted
austere talon
how will you even port our plugins
gonna have to port them to rollup plugins probably?
spark cove
not really, the vite plugin api has enough to do it there
austere talon
(i mean the bundler plugins)
spark cove
yea
vite plugin api is capable of doing virtual modules in the same way
and can be designed with hmr in mind
austere talon
oh nice
spark cove
cant be just esbuild or rollup, cus vite uses esbuild in dev, and rollup in prod
(lol)
austere talon
lmao
just make sure this won't make building much slower
well prod doesn't matter much
spark cove
sure yea i'll include benchmarks or something when i get to it
austere talon
naaaah u don't have to include benchmarks lmaooo
spark cove
but it sounds fun :)
crude hearth
the motivation addreall gave to vap is increadible
spark cove
LOL
austere talon
and i wanna review the asar PR when its undrafted
the pr is kinda finished, just need to test and update installer and also update git updater
spark cove
oh interesting its not a very big PR lol
does this apply to web?
spark cove
ah true
austere talon
the main obstacle with this shit is backwards compat
cause people will use ancient installers and take months to update
fallen vale
cause people will use ancient installers and take months to update
i feel like thats on them, no?
spark cove
not really, good backwards compat should be expected tbh
austere talon
i feel like thats on them, no?
kinda but it's our problem in the end
spark cove
i think i see what u mean tho
like an old installer will not download the asar
but would try to fetch the legacy files on the latest release
austere talon
yes
that's why it will still create the old files https://github.com/Vendicated/Vencord/pull/2707/files#diff-5c3fa597431eda03ac3339ae6bf7f05e1a50d6fc7333679ec38e21b337cb6721R54
and the in-app updater needs to be aware
spark cove
am i wrong in assuming those legacy files are trying to be working versions of vencord
i think the ideal solution would be to ship legacy files that just turn discord into a static window telling the user to use a newer installer version
spark cove
or it could download and run the installer itself, since precense of legacy files indicates intent to update
spark cove
yea exactly
austere talon
the main reason I didn't is cause im scared of windows file locking
not sure if it can delete the directory nodejs files are being run from
spark cove
i think there's probably a way for the main process to spawn another process without it being a child
so then the "child" can kill discord and do the installation
worst case scenario you simply have to guide to users to manually do it
austere talon
they could just force update to asar
i can already envision nixos users crying in support
i hate how painful testing updater stuff is tho
spark cove
testing the git updater seems easy enough but yea http updater sounds pain
austere talon
have to make a separate repo
austere talon
testing the git updater seems easy enough but yea http updater sounds pain
yeah testing git updater just be like git reset --hard HEAD~1
spark cove
couldnt you make a staging branch that makes releases under the staging tag
and tell the http updater to target that tag
spark cove
i mean isnt latest just a reserved tag
nope i was remembering the URLs wrong
it does seem like u could replace "latest" with "tag/staging" though and it would work the same way
charred monolithBOT
granite sky
Can someone please explain the benefits of using Vendord as an asar file?
spark cove
Right now Vencord loads uses multiple files to run: renderer.js, preload.js, main.js (per platform), renderer.css, etc.. (maybe more)
Every time Vencord needs a new file to run, the installers have to hardcode support for updating each file and mapping what platform (Vesktop / Discord Desktop / etc) each file is needed for. I remember how painful it was when we started using renderer.css (i think) lol
Shipping Vencord builds as an asar would de-couple the individual modules from the updater, and make adding new modules to builds in the future SO much safer & easier
granite sky
Just to check if I got it right:
Every time a new file in vencord build is added - installer requires an update to map this file
Using asar makes sure that even old installers will have an ability to ship everything needed, which makes adding translation/new modules easier?
turbid hatch
plus it means we can ship translations separately instead of baking them in to the js
granite sky
Okay, thank you for the explanation!
dusk blaze
question; does this only affect desktop, or does it also target browsers
(the .asar switch)
spark cove
extensions already are build to .zip files, and also the updater doesnt deal with extensions anyways
fallen vale
question; does this only affect desktop, or does it also target browsers
i dont think web is affected
spark cove
im not sure how the userscript handles files, iirc all it would use right now is renderer.js and renderer.css
austere talon
yeah
userscript probably either won't support translations or have separate language builds
otherwise it will become massive
2mb userscript
woeful sable
seems fine 🙏
fallen vale
we gotta make sure you can load vencord off a floppy disk
woeful sable
😭
fossil inlet
we gotta make sure you can load vencord off a floppy disk
@timber bay
verbal pumice
2mb userscript
good
crude hearth
2mb userscript
translations shouldnt take that much
dusk blaze
userscript probably either won't support translations or have separate language ...
load translations from server
crude hearth
wouldnt be too dumb actually
have english as default
and load language asynchoriously
spark cove
You can trigger github workflows from personal access tokens.. Imagine on the site you could customize your own (cached) builds lmao
timber bay
<@604867037235511297>
Hell with the size lmao, Couldn't care less if it were a half GB. I'd be ecstatic if it ran on a x86 only CPU with no x64, supreme bonus points if it ran on Windows 7. This next part may be far fetched, but even cooler if it were to be set up for SSE2 CPUs instead of SSE3.
I run on some ultimate potato computers over here lol.
austere talon
okay so backwards compat with dev install is like impossible
i think that's acceptable
brazen bone
Dev installs are already I-know-what-I'm-doing mode