and inside initialize it gets data and initialises self
#๐พ-core-development
austere talon
crude hearth
so theoritically we can just patch that
austere talon
and theres a persist method thats called for backing up
hmmmmm
i have a good idea how to patch this store in a performant way
but its hard to explain
WAITTT
nvm
crude hearth
WHAT
austere talon
RECEIVE_CHANNEL_SUMMARIES_BULK(data) {
...
y = {
...y,
...s.summariesByChannel
},
P = {
...P,
...s.summaryFetchStatusByChannel
}
you just need to dispatch that evenbt
with all summaries
crude hearth
do I just give it the flux dispatcher event
also what kind of objects will those be
crude hearth
```js
RECEIVE_CHANNEL_SUMMARIES_BULK(data) {
...
y = {
...y,
.....
tbh I would rather just get the store and modify it
it would be easier if we could enable discord to persist it
but if that doesnt prob modifying store is better
austere talon
do I just give it the flux dispatcher event
i think yes big array of them
austere talon
it would be easier if we could enable discord to persist it
yes but you dont want to store tens of thousands of summaries in localStorage
it will cause freezing and localStorage has 256kb total size limit
crude hearth
hmm yeah that wont work
how does discord cache other stuff then
do they not use idb
austere talon
i have a good idea how to patch this store in a performant way
my idea here was that we would basically add persist method to the store, overriding the parent function
then inside that we will dump y to indexeddb
and add a second patch that will just load from indexeddb and set y to it
austere talon
hmmm maybe we could make getLocalVars use that
thats only for PersistedStore
not normal stores
median rapids
better than nothing
crude hearth
my idea here was that we would basically add `persist` method to the store, over...
oh I thought they implemented the persistence code but it didnt work because of some checks
austere talon
better than nothing
AccessibilityStore
AppIconPersistedStoreState
ApplicationCommandFrecencyV2
ApplicationFrecency
ApplicationStoreUserSettingsStore
ApplicationStreamingSettingStore
ChannelSectionStore2
ClanSetupStore
ClientThemesBackgroundStore
ClipsStore
CollectiblesPersistedStoreV2
CollectiblesProductFreshnessStore
CommandsMigrationStore
DefaultRouteStore
DevToolsSettingsStore
DeveloperActivityShelfStore
DismissibleContentFrameworkStore
DraftStore
EmbeddedActivities
EmojiCaptionsStore
EmojiStoreV2
ExpandedGuildFolderStore
FavoritesSuggestionStore
FrecencyStore
GameStore
GuildAffinitiesStore
GuildAutomodMessages
GuildOnboardingHomeNavigationStore
GuildProgressStore
GuildSettingsOnboardingHomeSettingsStore
HangStatusStore
HighlightsTestStore
InventoryStore
LayoutStore
LoginRequiredActionStore
MultiAccountStore
MyGuildApplicationsStore
NewlyAddedEmojiStore
NotificationCenterItemsStore_v2
NotificationCenterStore
OverlayStoreV2
OverridePremiumTypeStore
PhoneStore
PoggermodeAchievementStore
PoggermodeSettingsStore
PopoutWindowStore
PremiumGuildGracePeriodNoticeStore
PremiumGuildProgressBarPersistedStore
PromotionsPersistedStore
PurchasedItemsFestivityStore
QuickSwitcherStore
RTCRegionStore
SelectedGuildStore
SelectivelySyncedUserSettingsStore
SoundboardEventStore
StageMusicStore
StickersPersistedStoreV2
StreamerModeStore
SummaryStore
SurveyStore
TTSStore
TenureRewardStore
TestModeStore
ThemeStore
TopEmojiStore
UnreadSettingNoticeStore
UnsyncedUserSettingsStore
UpcomingEventNotices
UserAffinitiesStore
UserOfferStore
UserSettingsOverridesStore
UserSettingsProtoStore-Cache
ViewHistoryStore
VoiceChannelEffectsPersistedStore
collapsedCategories
collapsedChannels
collapsedGuilds
habitualDND
hotspots
keybinds
liveChannelNotices_v2
notifications
it works but they only backup shouldShowTopicsBar
getState() tells it what to back up basically
crude hearth
austere talon
UNKNOWN
austere talon
anyway try using RECEIVE_CHANNEL_SUMMARIES_BULK event
just feed it that array u have
maybe it will work
crude hearth
fiiiine
austere talon
LMAOOO why does devtools search find my message json
crude hearth
I was just gonna map those to channelid:array map and directly modify store but whateveer
crude hearth
LMAOOO why does devtools search find my message json
IT ALWAYS DOES THAT ON ME
and fails to find the original match
austere talon
anyway try using `RECEIVE_CHANNEL_SUMMARIES_BULK` event
read code of that event
let {summaries: t, receivedAt: n, error: i, requestArgs: {channelIds: r}} = e
heres what to pass
crude hearth
is channelIds required
median rapids
LMAOOO why does devtools search find my message json
yea it searches api reqs now
idk how to make it stop
crude hearth
and wth is error
austere talon
maybe manual is indeed easier but then you have to do this hell
a = I().toPairs(t).reduce((e,t)=>{
let[n,i] = t
, r = I().chain(i.map(e=>(0,
D.createSummaryFromServer)(e, n))).sortBy(e=>v.default.extractTimestamp(e.startId)).takeRight(75).reverse().filter(e=>Object.keys(e).length > 0).value();
return e[n] = r,
e
}
pretty sure u can change it
median rapids
howw
crude hearth
```js
let {summaries: t, receivedAt: n, error: i, requestArgs: {channelIds: r}} ...
btw what kind of data does this take
is summaries a map or array of this
median rapids
probs an array of the inner summaries object
austere talon
wtf chrome adblocking
yeah its a feature
median rapids
not the event lol
austere talon
if chroem detects a site has too intrusive ads it will block ads
median rapids
i thought that was mobile only
austere talon
if chroem detects a site has too intrusive ads it will block ads
some chromium forks force enable that on every site to lbock ads
crude hearth
probs an array of the inner summaries object
inner summaries object doesnt have channelId
charred monolithBOT
Changes the name of music rich presences to inherit the currently playing song's title.
charred monolithBOT
median rapids
it would be nice if it didn't
just patch fetchSummaries() to check for the feature
crude hearth
if we had monkey patching this would be so easy 
spark pivot
if we had monkey patching this would be so easy <:sadJoe:859796078643904523>
we should add this then let users install bd plugins
dusk blaze
if we had monkey patching this would be so easy <:sadJoe:859796078643904523>
Hop on DetterBiscord
fair wolf
if we had monkey patching this would be so easy <:sadJoe:859796078643904523>
the regex match can't be that hard
crude hearth
ok I patched shouldFetch too
shouldFetch(channelId: string) {
const channel = ChannelStore.getChannel(channelId);
return (!channel.hasFlag(1 << 11) && GuildStore.getGuild(channel.guild_id).hasFeature("SUMMARIES_ENABLED"));
}
ig this is enough
median rapids
```js
shouldFetch(channelId: string) {
const channel = ChannelStore.getChann...
hasFlag is probs unnecessary as that should already be checked elsewhere
austere talon
doubt?
doesn't it fetch when you expand the summaries
maybe if u scroll down or smth
doubt they check it elsewhere or it wouldn't fetch in the first place
crude hearth
doesn't it fetch when you expand the summaries
it fetches when you change channel
crude hearth
hasFlag is probs unnecessary as that should already be checked elsewhere
then I'm removing it
but also I think it was in shouldFetch function
eeeeh maybe just leave it as it is
crude hearth
that fetch doesn't fail anyways
how
median rapids
then I'm removing it
ya just remove it
crude hearth
oh okat
median rapids
i checked channel.py ๐
crude hearth
okay pushed
btw #๐บ-regulars have soo much stuff
maybe I should remove the oldest ones 
and limit to 25 or smthn
median rapids
yea one sec
lemme see what the api limit is
@crude hearth limit to 50
api returns 50
crude hearth
okay
okay good
does shift make a new array hm
time to test
nvm it returns removed element
or do I just splice(0, summaries.length - 50)
actually it should fine this way
whatever
desert cosmos
discord apparently broke the edit message logger on canary, no clue if theyll push it to stable though 
desert cosmos
pretty sure that report wasnt on the main branch
median rapids
I decided 3 days is fine
just keep the last 50 regardless of date
crude hearth
just keep the last 50 regardless of date
eh but wouldnt it get so big due to inactive servers
median rapids
eh but wouldnt it get so big due to inactive servers
oh well
u could make it configurable maybe
crude hearth
hmm
oh god I was getting random errors
then realized copilot made a patch 
also I am now checking both
return guild.hasFeature("SUMMARIES_ENABLED") || guild.hasFeature("SUMMARIES_ENABLED_GA");
because even on servers that have summaries enabled "SUMMARIES_ENABLED" is not present
rugged spire
then realized copilot made a patch <:dread:1179115897248563231>
do not let AI cook
crude hearth
ok also added settings
fair wolf
do we have any snowflake utils?
crude hearth
One is GA
jagged cloak
gateway probably
jagged cloak
oh
median rapids
limber skiff
good
limber skiff
now the question is, do they work with each other?
frail skyBOT
limber skiff
okay that's fucking fire
frail skyBOT
limber skiff
really
austere talon
LMAOOO
nuckyz never escaping the Incomplete URL substring sanitization allegations
limber skiff
๐ญ
median rapids
nookies hates me
limber skiff
sorry :/
limber skiff
I'm debating whether we should apply patches when the module needs to be executed or when it's pushed to .m
my new implementation supports both, I'm just not sure which one I should do
it currently does when it needs to be executed, that means faster startup timings but means it needs apply the patches when it needs to be executed, so technically lazy required stuff will take a little longer (but it's pretty much nothing)
changing it is as easy as making the patch occur in the set instead of get
median rapids
personally I think faster startup is better
you could always make it an option too no?
median rapids
idk might as well
woeful sable
literally wasted
woeful sable
lmfao
charred monolithBOT
fair wolf
Horror gateway implementation
it can be adapted to just use the native one, but I wanted to work on all the rest first
austere talon
soonit will be
turbid hatch
@night fossil unfortunately this plugin is basically a selfbot
so yes, the viable alternatives are just
selfbots
we don't want to include these features like vee said
vencord has a goal of being as "legitimate" as possible, but this pushes that boundary too far
night fossil
<@1080661733531729940> unfortunately this plugin is basically a selfbot
yeah no i get that, see my latest comment ^
turbid hatch
yeah no i get that, see my latest comment ^
saw
austere talon
i said it's risky to do it manually, not that it's risky in general
because you will most likely get it wrong. ^
hence why you should use a library instead
night fossil
oh
austere talon
for example one of the libraries i recommended:
https://github.com/dolfies/discord.py-self/blob/master/discord/utils.py#L1455-L1492
it does everything right to minimise risk
a
night fossil
yeah, have used that one before
austere talon
okay bot doesn't wanna embed
median rapids
tbf probably nothing would happen if you're just connecting to the gateway
but there's plenty of other problems with this
i.e. the logistics (and resource usage) of multiple active gateway connections in a client
and people are gonna be confused as to why their other accounts are randomly online
etc.
austere talon
how so
austere talon
because it's intended for bots and users
but it allows you to set custom headers
obviously you'd just do that :p
you can see example of it in dissent
austere talon
grave mangoBOT
https://github.com/diamondburned/arikawa/blob/9289cfc9e82057f823dbc8adc08d11ac67...
identify.go: Lines 97-135
// DefaultIdentity is used as the default identity when initializing a new
// Gateway.
var DefaultIdentity = IdentifyProperties{
OS: runtime.GOOS,
Browser: "Arikawa",
Device: "Arikawa",
}
// IdentifyCommand is a command for Op 2. It is the struct for a data that's
// sent over in an Identify command.
type IdentifyCommand struct {
Token string `json:"token"`
Properties IdentifyProperties `json:"properties"`
Compress bool `json:"compress,omitempty"` // true
LargeThreshold uint `json:"large_threshold,omitempty"` // 50
Shard *Shard `json:"shard,omitempty"` // [ shard_id, num_shards ]
Presence *UpdatePresenceCommand `json:"presence,omitempty"`
// ClientState is the client state for a user's accuont. Bot accounts should
// NOT touch this field.
ClientState *ClientState `json:"client_state,omitempty"`
// Capabilities defines the client's capabilities when connecting to the
// gateway with a user account. Bot accounts should NOT touch this field.
// The official client sets this at 125 at the time of this commit.
Capabilities int `json:"capabilities,omitempty"`
// Intents specifies which groups of events the gateway
// connection will receive.
//
// For user accounts, it must be nil.
//
// For bot accounts, it must not be nil, and
// Gateway.AddIntents(0) can be used if you want to
// specify no intents.
Intents option.Uint `json:"intents"`
}
it provides a default identify payload but you can override it for users
crude hearth
btw why gateway connection
cant you reverse push notifs on android
probably would require firebase tinkerng tho hmm
austere talon
cant you reverse push notifs on android
yeah i said that
to just use firebase
probably doesn't work anymore cause no updates in 5 years
but yeah 
crude hearth
probably doesn't work anymore cause no updates in 5 years
its 2 file anyway
and nearly 0 code
like 60 line
and 40 line constants
median rapids
cant you reverse push notifs on android
yeah
would also be great for docs 
i've never bothered cuz idk how firebase works
i could probs figure it out though
crude hearth
hmm
btw firebase supports web too
we can directly use the library and use creds from android app maybe
actually wait is this even same
surreal compass
quick question; when Vencord injects it currently just selects the latest app-x.x.xxxx folder based on the version number being higher, however, it seems like in some cases it is possible that Discord will pull down a later version but still elect to launch the older version. For example, I currently (without doing anything special) have ended up with these two builds on my machine, and that as a result has seemingly interrupted the Vencord installation process as it is only injecting into the [unused] newer version.
Is there a reason we don't inject into all app versions present? This is likely a rare issue but I'd be inclined to contribute to add a app version selector in the cli installer if that is useful, as it would be in this instance.
crude hearth
their android service extends firebase messaging service
so I'd assume they are same
austere talon
quick question; when Vencord injects it currently just selects the latest ``app-...
it used to patch old versions, but old versions may be corrupt
if your discord isn't using the latest version something went wrong
crude hearth
<string name="google_api_key">AIzaSyCY8pVLbcOlWDz6NdLbaGckvwhOmfNu02U</string>
<string name="google_app_id">1:162066849712:android:db38e83be74de1b6</string>
<string name="firebase_database_url">https://adept-ethos-91518.firebaseio.com</string>
<string name="gcm_defaultSenderId">162066849712</string>
<string name="google_crash_reporting_api_key">AIzaSyCY8pVLbcOlWDz6NdLbaGckvwhOmfNu02U</string>
<string name="google_storage_bucket">adept-ethos-91518.appspot.com</string>
I wonder if I can set up a firebase messaging on web with these
median rapids
we can directly use the library and use creds from android app maybe
i just got notifs working using an ancient python library with a few mods
median rapids
surreal compass
if your discord isn't using the latest version something went wrong
fixed it, thanks, I would like to contribute to Vencord though so I'll poke around for something to do. c:
median rapids
how does that python libwork though
the api seems simple
just a couple of protos
this could def be made to work
crude hearth
google moment
median rapids
other acc notifs from acc switcher on desktop using fcm would be rlly cool
crude hearth
btw how does it know which account you are logged into
crude hearth
then it registers you
crude hearth
how does it identify device though
google_api_key is same on all apks
does it generate a id per device
crude hearth
nice
crude hearth
oh now I understood the loop
when you estabilish a FCM connection it gives you a unique string
you sendthat to discord
okokokok
crude hearth
then theres 2 options
1: we can use https://firebase.google.com/docs/cloud-messaging/js/client offical client
which would add lots of bloat probably
unless we dynamically load it
or implement it ourselfes
<script src="https://www.gstatic.com/firebasejs/10.12.0/firebase-app-compat.js"></script>
<script src="https://www.gstatic.com/firebasejs/10.12.0/firebase-firestore-compat.js"></script>
<script src="https://www.gstatic.com/firebasejs/10.12.0/firebase-auth-compat.js"></script>
median rapids
1: we can use https://firebase.google.com/docs/cloud-messaging/js/client offical...
we can't use this
it uses vapid
we don't have discord vapid keys i don't think
unless it's AIzaSyCY8pVLbcOlWDz6NdLbaGckvwhOmfNu02U
crude hearth
we can't use this
var firebaseConfig = {
apiKey: "AIzaSyCY8pVLbcOlWDz6NdLbaGckvwhOmfNu02U",
authDomain: "adept-ethos-91518.firebaseapp.com",
databaseURL: "https://adept-ethos-91518.firebaseio.com/",
projectId: "adept-ethos-91518",
storageBucket: "adept-ethos-91518.appspot.com",
messagingSenderId: "162066849712",
appId: "1:162066849712:android:db38e83be74de1b6",
};
we only need those it seems
where did you see vapid
median rapids
no i think this is web only
crude hearth
guhhh
austere talon
yeah its web only
median rapids
you can work off this
that's what the one i'm using is based off
it's very simple, probs doesn't need much fixing
at worst we steal the prs
median rapids
message logger edit logs broke huh
yea i thought i was losing it
austere talon
what did i forget
somber thorn
ShowTimeoutDuration from v1.8.3
as for current v1.8.5
NoServerEmoji
NoDefaultHangStatus
is what I could find
shell shuttle
somber thorn
march 13th
shell shuttle
wha
ngl its justified because the code originally was really shit
so it took me a few months to polish it
with advice and help from the community
somber thorn
is it now ๐ต๐ฑed?
shell shuttle
is it now ๐ต๐ฑed?
absolutely
somber thorn
dobrze wiedzieฤ
median rapids
looks like the window suspension isn't related to DisableCallIdle
i can fully repro with the plugin disabled
charred monolithBOT
im pretty sure it's because they fully display: none this section which also hides our colour pickers
that's why i meant you could see which element they hide and force display: block/grid/flex/... it. hope you understand what i'm trying to say?
austere talon
looks like the window suspension isn't related to DisableCallIdle
then try the cli flag
discord.exe --disable-renderer-backgrounding
median rapids
or shit wont work
looks like it works
desert cosmos
๐ฝ
charred monolithBOT
looks good, thanks!
please make sure to always have this enabled (checked โ
) in the future
austere talon
it really was a false positive wtf
@limber skiff look at this lol
wtf happened here
limber skiff
idk what is happening
median rapids
cosmic wave bit shift
austere talon
it doesnt seem related to a discord change, they did push a new update between those two tests but we would have noticed
median rapids
it's probably just discord shitcode lol
limber skiff
oh wait
austere talon
Cannot read properties of undefined (reading 'call')
limber skiff
you see the call error?
limber skiff
thats when trying to get the module factory
austere talon
btw look how rarely they push updates to stable
what if we made it so patchhelper automatically runs whenever they push stable
limber skiff
m[id].call(...)
median rapids
btw look how rarely they push updates to stable
what if we made it so patchhelp...
oh i thought reporter already ran on every stable update
yea they're not insanely frequent usually
austere talon
nah it runs once a day
limber skiff
maybe we somehow dont load some chunk sometimes?
it only runs the entry point if it exists in wreq.m
austere talon
we could also make it so that if there is more than 10 broken things it pings us
limber skiff
so it's a require inside a nested module
median rapids
we could also make it so that if there is more than 10 broken things it pings us
dw that'll probably happen anyway
median rapids
i will ping you when there are no broken things
austere talon
how does it only sometimes fail
limber skiff
the false positive is always the same webpack find
austere talon
thats so weird lol
median rapids
something's racing somewhere
limber skiff
so it's always the same factory not existing
limber skiff
something's racing somewhere
yep maybe
austere talon
btw look how rarely they push updates to stable
what if we made it so patchhelp...
anyway we should really do this tbh
median rapids
i should learn more abt how webpacker works
austere talon
something's racing somewhere
nuckyz accidently added racism to patchhelper its over
how do we detect new stable push
do u just fetch every 5 mins or smth and see if hash changed
median rapids
yea you could fetch every second even lol
austere talon
EVERY SECOND
median rapids
austere talon
is there no rate limit
median rapids
no it's a static json
austere talon
LMAO what is this error bro
i tried to spam requests to the endpoint to see if theres truly no rate limit
but chromium said nuh uh
maybe sending 10k requests at once is not a good idea
median rapids
use python
import asyncio
import aiohttp
session = aiohttp.ClientSession()
await asyncio.gather(*[session.get('https://discord.com/assets/version.stable.json') for _ in range(10000)])
shell shuttle
o
limber skiff
okay anyways
if the false positive is a racing condition it's gonna be hard to debug I think
one because it only happens sometimes, and second because the code for force loading chunks uses cursed logic
but also I don't think it's a lazy loaded module?
it's simply this
limber skiff
very weird
hmm it is not caused by the webpack finding at least
because it errors before it finishes loading chunks
I guess I will just have to keep trying until it happens
fucking shit
@austere talon I can't get it to happen without headless
median rapids
husk
limber skiff
okay I got more info
it is literally the component
lazy loaded by this
chunk is 86557
limber skiff
when I want this shit to happen it doesnt
somber thorn
message logger edit logs broke huh
just reminding about that after getting 3 people in a row in vencord-support asking about it
tropic wagon
interesting inlay hints
limber skiff
why?
wary dew
Quest IDs for the quest bypass thing:
Honkai Star Rail V2.2 Bundle: 1232852290197655573
Genshin Impact V4.6 Bundle: 1227767407154561034
Lost Ark Mokoko: 1227395355193118750
PUBG Erangel Classic: 1235258834524700703
desert cosmos
doesnt quest bypass just fetch the latest quest
jagged cloak
yea i think lol
tulip radish
long stream
contributor badge doesn't show on the new profiles
very known 
tulip radish
Poggers, dare I say
long stream
i wonder if it would be worth making a pr for simplified profiles now?
since it's being rolled out
jagged cloak
yea
charred monolithBOT
desert cosmos
turbid hatch
contributor badge doesn't show on the new profiles
none of the vc badges do
badgeapi hasnt been updated :p
charred monolithBOT
austere talon
flop
sterile oak
@austere talon perfect timing, is this really worth being added to the authors of RoleColorEverywhere?
I am creating the pr rn
somber thorn
AI is not worth the effort
Right it's GPT-4 so it's not that shit
That's probably just a copy from the original code though still
halcyon salmon
somber thorn
topaz thistle
thank god
topaz thistle
lucky, i was about to kill u
based
austere talon
(hes replying to the last reply on that pr, not the pr itself)
verbal pumice
i did not realize it had replies, thanks github mobile 
austere talon
<@343383572805058560> ai has no words to say
let's see
somber thorn
ohgod
charred monolithBOT
austere talon
charred monolithBOT
crude hearth
die ai agent
crude hearth
it doe
somber thorn
it will
crude hearth
vindicated
jagged cloak
i forgot slash
rugged spire
YAPPING BOT
somber thorn
ย
rugged spire
ah yes "ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย "
charred monolithBOT
limber skiff
okay so it's not a fault of me maybe
austere talon
wait was the ai actually useful for once
lime stone
ye
charred monolithBOT
limber skiff
I wonder what the ai thinks of my prs
austere talon
ask it for review on waitfor finds
limber skiff
lets see
charred monolithBOT
rugged spire
yes more ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย ย we love
charred monolithBOT
rugged spire
explode
austere talon
TERROR
limber skiff
hmm some of the possible bugs maybe
austere talon
1984
limber skiff
lmaoooo
austere talon
HAHAHHAHA it knows
median rapids
throw @ven
median rapids
nobody catching me 
๐ธ
woeful bisonBOT
median rapids
some exceptions apply
jagged cloak
me when i FINALLY you
sterile oak
the fact I use codiumAi to write plugins
limber skiff
I still have to finish debugging the false positives of the reporter
it's so annoying cuz I have to keep trying until it happens every time I add a new debug
but it's crazy how the latest thing I did to change how we patch modules is helping me with it
because I have super easy control of when a module is being accessed or set
charred monolithBOT
median rapids
that wouldn't work too well
median rapids
it's so annoying cuz I have to keep trying until it happens every time I add a n...
just run it like 50 times concurrently
discor gateway won't rly care
limber skiff
troll
austere talon
that wouldn't work too well
banner everywhere?
i mean yeah u won't have everyone's banner
but the cached ones
plus usrbg
median rapids
i mean yeah u won't have everyone's banner
yea exactly
most people's wouldn't be cached
cunning canyon
skill issue?
uh mine doesnt work too
idk why. dont have any error
stable dev branch
limber skiff
it's gonna be something I did
austere talon
what did u change
limber skiff
regex exec -> matchAll
austere talon
wait why did you limit nest length
austere talon
why change this https://github.com/Vendicated/Vencord/commit/a94b88cd5610de1f4dee27a01cf1005d856dc01b
cunning canyon
so it works with this commit https://github.com/Vendicated/Vencord/commit/b33b5bdc9f5b15f74e4a169d1072cb41d95819cc
and breaks with this commit https://github.com/Vendicated/Vencord/commit/a94b88cd5610de1f4dee27a01cf1005d856dc01b
austere talon
ofc because it is stateful
limber skiff
I searched it up and it only talked about exec
median rapids
that's horrifying
limber skiff
that's so dumb
austere talon
ve ```js
const re = /a/g
console.log(re.test("a"))
console.log(re.test("a"))
nimble pendantBOT
ve ```js
const re = /a/g
console.log(re.test("a"))
console.log(re.test("a"))
``...
undefined```
true
false```
limber skiff
jeez...
limber skiff
I thought it was something about exec
austere talon
js devs try not to make normal devs cry challenge
there's nothing wrong with this behaviour
austere talon
with test too
limber skiff
๐
austere talon
you're operating on a global regex
whenever you use a global regex you want all matches
so it's important that test and exec keep state
so you can keep calling .test and get next and next matches
if you don't want that behaviour that means you shouldn't be using global regex
limber skiff
that makes sense
austere talon
const re = /a/g;
const indexesOfAInText = []
while (re.test(longText)) {
indexesOfAInText.push(re.lastIndex)
}
empty string
limber skiff
okay good
limber skiff
yeah I know
just need to undo this
https://github.com/Vendicated/Vencord/commit/a94b88cd5610de1f4dee27a01cf1005d856dc01b
the other works
median rapids
there's nothing wrong with this behaviour
state management should be in a separate object
austere talon
how
austere talon
nah java regex is very different
austere talon
I think it's also stateful
yes but with a dedicated class
median rapids
with a .math() or something
austere talon
just return a match object
then you'd just use .exec or .match lol
test has different purpose
limber skiff
ngl matchAll is fire
the fact it returns an iterable with easy access for the groups of every match is so good
and no special handling cuz if no match the iterable is just empty
limber skiff
ayo
why is it not loaded
I mean, yeah i know why, the factory was null when it tried to call it
hmmm, super small chunk is trying to require it
@austere talon so it's actually a racing condition, we are force loading a chunk for a context menu item, but it doesnt specify the dependencies correctly because it's a context menu, which makes it try to require the message component because the chunk that contains it loaded
ultra fix
jagged cloak
nicest vencord user
jagged cloak
it loves commit
inland fable
I am currently documenting the webpack require
you're amazing
limber skiff
it does require some searching...
limber skiff
idk how this didnt cause issues
limber skiff
I see, that functions simply removes already loaded chunks from the chunkIds to avoid checking if they are loaded again
webpack code is just crazy
limber skiff
I did it people
limber skiff
somber thorn
most descriptive commit message
somber thorn
more descriptive commit message
somber thorn
but here's the fixer
austere talon
brooo what is this typing
old webpack probably
charred monolithBOT
This plugin allows editing any Rich Presence's type from playing to watching, listening or competing.
It also has an option to remove the large image text, which tends to be used as a way to show version info. This large image text gets shown as the 3rd line of the RPC when the listening, watching, competing types are used.
Currently not finished, the actual rpc changing lo...
lone briar
makes sense to me, fixes quite a few minor bugs
shell shuttle
by unloading do you mean like
soft crash
to where discord feeezes up and doesn't respond when its alt tabbed for a certain time
austere talon
yes
somber thorn
<title>
austere talon
someone translate please
median rapids
this is cool
median rapids
should we just add that flag in vencord
is this a vencor or stock issue
i don't see how it could be a vencor issue
austere talon
idk bro, it def happens on stock too but vencord apparently makes it more likely to happen
some person said disabling NoCallIdle fixes it for them but for other people it doesnt
then some other people say its fixed once they uninstall vencord, but then you also have people on reddit complaining about it with stock discord
its a really strange issue so i have 0 info
verbal pumice
it happens to me on stock a lot
austere talon
but if the flag fixes it then we can just add it
median rapids
vencor now fixing stock issues
jagged cloak
verbal pumice
vencord will send a later to jason's house telling him to fix the bug
median rapids
we need a vencor to staff backchannel
austere talon
tbf idk how discord could fix it either
its a really weird bug
basically chrome for some reason deciding ur page should be hibernated to save battery
there are really cursed workarounds like playing silent audio 24/7
that people apply in production
charred monolithBOT
This plugin adds a new button to the message popover that allows you to quickly "star" react a message:
This is intended to be used with starboard bots, but the emoji that is reacted is customizable per-server so you could use it for other things as well:
limber skiff
btw vee where should I put the file for wreq typings?
I'm not sure it it should be in common
charred monolithBOT
median rapids
tbf idk how discord could fix it either
just apply the flag lol
they also have a custom electron fork anyway
somber thorn
somber thorn
awaiting ย
charred monolithBOT
charred monolithBOT
median rapids
yorp
charred monolithBOT
austere talon
jagged cloak
@dusk blaze if you wanna yoink my plugin you can lol i had no intentions on pr'ing it
jagged cloak
premix apparently claims they can do listening without a mod now
jagged cloak
yeah me neither lol
dusk blaze
since discord automatically explodes any rpc that isn't playing
or doesn't have matching name and app name
so maybe with arRPC
since it doesn't check
median rapids
premix apparently claims they can do listening without a mod now
i think they can
iirc they got approved for the activities.write scope
which allows direct api access to create activities
austere talon
yeah maybe that
could be abused
for ads, scams etc
and clueless users "help why is my discord advertising stuff"