tropic wagon
yeah
#๐พ-core-development
woeful sable
peak
austere talon
now just need to test what this looks like if youre not in the server
rugged spire
hide it if the user is friends
desert cosmos
"Also, I've heard that Message Logger is bannable on Better Discord"
me when I use a client modification which is bannable in the first place: 
charred monolithBOT
austere talon
another thing that didnt find https://cdn.discordapp.com/attachments/1026515880080842772/1236697494209957938/image.png?ex=6638f3cb&is=6637a24b&hm=c1b7ff8ff92b6a982202b8dc9fcbaa0bf31a52e52cf50329863ec4df195b8ef7&
@limber skiff maybe related to webpack changes
somehow
charred monolithBOT
median rapids
nah p sure it does do a couple things wrong
the way member lists work is complicated
austere talon
yeah
i rewrote the logic a few times
its pain
if u feel u know better please pr 
rugged spire
me sitting here cozy running my own fucked up branch not having any issues loading stuff somehow
austere talon
even this is flawed cause it just picks the first channel u can view
https://github.com/Vendicated/Vencord/blob/main/src/plugins/memberCount/OnlineMemberCountStore.ts#L25
grave mangoBOT
even this is flawed cause it just picks the first channel u can view
https://git...
**OnlineMemberCountStore.ts: **Line 25
await PrivateChannelsStore.preload(guildId, GuildChannelStore.getDefaultChannel(guildId).id);
if the first viewable channel is a private channel only you can read it gives very wrong results
rugged spire
even this is flawed cause it just picks the first channel u can view
https://git...
this is how bots do it too lmao
stupid question
do you NEED to relate the online count to a channel
or is there a query online members thing for entire server
shell shuttle
absolutely
austere talon
weell theres https://discord.gg/6PExezNU
median rapids
if the first viewable channel is a private channel only you can read it gives ve...
yeah you need to check the member list id
austere talon
count on invites
rugged spire
oh?
median rapids
they use an alg to calculate it but because you're just checking for "everyone" you can skip half of it for perf reasons
rugged spire
hold on
median rapids
weell theres https://discord.gg/6PExezNU
it's presence count, which includes invis members
austere talon
austere talon
it's presence count, which includes invis members
funny
rugged spire
nono it includes members online
austere talon
i mean discord does it that way, maybe we can just do it too
good enough for discord, good enough for us
median rapids
i mean discord does it that way, maybe we can just do it too
would be a lot of reqs and would get outdated
austere talon
true
median rapids
what i would want to do is change this one to reflect the channel's member/online count
median rapids
and change this one to be the full server count
austere talon
the first number is online members in the current channel
median rapids
median rapids
well the second number is always total guild count
yea thats the issue
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/memberCount/OnlineMe...
**OnlineMemberCountStore.ts: **Lines 41-51
return new OnlineMemberCountStore(FluxDispatcher, {
GUILD_MEMBER_LIST_UPDATE({ guildId, groups }: { guildId: string, groups: { count: number; id: string; }[]; }) {
onlineMemberMap.set(
guildId,
groups.reduce((total, curr) => total + (curr.id === "offline" ? 0 : curr.count), 0)
);
},
ONLINE_GUILD_MEMBER_COUNT_UPDATE({ guildId, count }) {
onlineMemberMap.set(guildId, count);
}
});
well this is the current logic
rugged spire
ok stupid question
median rapids
rugged spire
how does the tooltip online count work then
median rapids
blehh
median rapids
how does the tooltip online count work then
it's also added by the plugin
austere talon
how does the tooltip online count work then
like i said it finds the first channel in the server that you can view and uses that channel's member list
austere talon
**OnlineMemberCountStore.ts: **Line 25
```ts
await PrivateChannelsStore.preload(...
thats this code ^
rugged spire
if thats the case then why is it that when i hover over my friends server it is definitely showing for not the first channel in the list
first channel is mod only channel and it shows 9 people in there online on the guild tooltip
austere talon
also that name is clearly wrong cause its not just private channels and its not a store
ChannelRestUtils or smth
rugged spire
rugged spire
approximate 
rugged spire
what huskworthy
median rapids
it's in the discoverable guild object
ooh a good plugin would be removing the forced requirements for guilds to appear in discovery
actually i could add that to ShowHiddenThings
rugged spire
isn't it a query param
median rapids
yes
rugged spire
for the agolia search
austere talon
ooh a good plugin would be removing the forced requirements for guilds to appear...
wdym?
what forced requirements
median rapids
(it used to be a higher number and they decreased it to 0 for some reason)
median rapids
why do guilds get autoremoved
not meeting discovery reqs
rugged spire
and guilds with less than 0 members <:blobcatcozy:1026533070955872337>
sounds like requirement to use the endpoint
median rapids
what
median rapids
https://i.dolfi.es/NWS7Crt4AB.png?key=L3gj3IEhPr3XAe
yk there was a funny vuln
rugged spire
is it even possible to use the endpoint without those 2 fields
median rapids
where you could race condition the approx member count
and get it negative
and hide guilds from discovery
rugged spire
how
median rapids
is it even possible to use the endpoint without those 2 fields
yes
rugged spire
shell shuttle
omg thank god for the badge overflow change
also uhh
anyone else have discord freeze whenever screemnshares occurr?
spark pivot
what is going on lol
austere talon
@mortal forum why would a client still be using discordapp.com? is it just very old installs?
we've had quite a good number of people with this issue so it seems fairly common
mortal forum
what the fuck
mortal forum
is this your machine?
discord has a thing in desktop_core to auto migrate
unless the install is super super old
mortal forum
lol
austere talon
and there were at least 15 people with this issue so far
mortal forum
is this a recent thing or always been a thing
the actual code is ```js
function checkCanMigrate() {
return _fs.default.existsSync(_path.default.join(_paths.paths.getUserData(), 'userDataCache.json'));
}
function checkAlreadyMigrated() {
return _fs.default.existsSync(_path.default.join(_paths.paths.getUserData(), 'domainMigrated'));
}
const canMigrate = checkCanMigrate();
const alreadyMigrated = checkAlreadyMigrated();
if (canMigrate || alreadyMigrated) {
endpoint = 'https://discord.com';
} else {
endpoint = 'https://discordapp.com';
}```
(how migration works is more complicated)
median rapids
<@506482395269169153> why would a client still be using discordapp.com? is it ju...
in links?
that happens sometimes for unknown reasons
i'm pretty sure they broke migration now
mortal forum
welp
it is weird for sure
i presume they just deleted/broke migration at some point
austere talon
in links?
like for everything
it loads discordapp.com/app instead of discord.com/app
mortal fractal
it loads `discordapp.com/app` instead of `discord.com/app`
manually set in their settings.json?
austere talon
naaah xd people should just reinstall
austere talon
it's not a big deal it was just that we only checked for discord.com ^
median rapids
it loads `discordapp.com/app` instead of `discord.com/app`
just tell em to reinstall lol
how did the install even work
discordapp.com/app just redirects now
austere talon
discordapp.com/app just redirects now
mortal fractal
discord...
austere talon
naaah xd people should just reinstall
:p
glass jasper
mortal fractal
closed this by deleting the head repository
lmao
oh they made that username an archive org
and archived it
wild
austere talon
two commits
limber skiff
ahh
mortal fractal
๐ค it could be made simpler if you checked with /discord(app)?\.com/
charred monolithBOT
austere talon
why'd the uvpote that reply but not fix it
still wasp
Maybe fixyoutubeembeds could remove age restrictions too
austere talon
probably not
mortal fractal
Maybe fixyoutubeembeds could remove age restrictions too
the only way to is to use an alternative frontend like piped or invidious
still wasp
the only way to is to use an alternative frontend like piped or invidious
It might be different for embeds
mortal fractal
idk i dont look into this shit cause i have an 18+ account and live in the US
mortal fractal
the only way to is to use an alternative frontend like piped or invidious
but also i just redirect embeds to piped within discord so
austere talon
oh thanks for rebase
rugged spire
probably not
you could patch the youtube embed 
thats insane as fuck for a discord client mod though
limber skiff
what if we eval the userscript of the extension
median rapids
https://github.com/zerodytrash/Simple-YouTube-Age-Restriction-Bypass
this uses a proxy
there's an easier way
austere talon
it doesn't
median rapids
huh
limber skiff
it's saying it uses as a fallback
austere talon
this extension uses some API tricks to access age-restricted videos from YouTube anonymously. as a fallback (in case that the API bypass methods does not work) an open source account proxy server is used
limber skiff
there's an easier way
what's the easier way
median rapids
what's the easier way
you can patch the client info to identify as an embedded tv client
mortal fractal
but also i just redirect embeds to piped within discord so
(you get a bonus of no ads)
limber skiff
wait you are right
median rapids
@dapper tiger knows
mortal fractal
innertube api is absolutely terrifying
i was using youtubei.js in my bot before i switched to just using piped's api for that as well
rugged spire
you can patch the client info to identify as an embedded tv client
wtf
median rapids
i was using youtubei.js in my bot before i switched to just using piped's api fo...
i tried making an innertube api wrapper
i gave up pretty quickly because it was impossible to be thorough
and i don't like leaving stuff out
median rapids
some things are like impossible to figure out
mortal fractal
thats why you just use youtubei.js 
median rapids
none of the wrappers are very good
mortal fractal
limber skiff
oh same guy
wdym same guy?
mortal fractal
it works for the most part ยฏ_(ใ)_/ยฏ
mortal fractal
wdym same guy?
as age restriction bypass
median rapids
wdym same guy?
as the age restriction bypass
charred monolithBOT
This now also removes algolia filters that hide servers that don't meet the requirements from discovery 
mortal fractal
real
median rapids
oh i should rename it
limber skiff
idk enough to be able to patch this in the youtube embed
but it seems pretty doable
median rapids
it'd be cooler to have adblock
median rapids
age restriction bypass isnt that huge
mortal fractal
idk enough to be able to patch this in the youtube embed
it would only work on desktop is the issue
limber skiff
it would only work on desktop is the issue
true true
mortal fractal
since theres no way to inject into iframes on web
limber skiff
but it's okay
dapper tiger
.
mortal fractal
with vencord
idk i know a couple people with it installed
limber skiff
if anyone that actually knows how to do it wanna do, have fun
mortal fractal
as far as regularly i couldnt tell you
median rapids
venlytics when
mortal fractal
venlytics when
how to piss off idiots 101
(we should do it if it means culling the userbase)
dapper tiger
@median rapids :c
median rapids
(we should do it if it means culling the userbase)
yop
median rapids
<@852892297661906993> :c
:p
austere talon
anyway we need to fix relationshipnotifier falsely saying you got kicked when a server goes unavailable
but it's hard to debug / test cause it's so rare xd
lime stone
rugged spire
anyway we need to fix relationshipnotifier falsely saying you got kicked when a ...
I think this might've recently happened to my friend
mortal fractal
anyway we need to fix relationshipnotifier falsely saying you got kicked when a ...
the event should have a field that says if it is due to unavailable or not
but idk if thats sent to user accounts
i assume it is
limber skiff
anyway we need to fix relationshipnotifier falsely saying you got kicked when a ...
you know the reason it may be happening?
limber skiff
the event should have a field that says if it is due to unavailable or not
the plugin checks if it's unavailable already ๐
so idk if it's because of that
austere talon
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/relationshipNotifier...
**functions.ts: **Lines 64-66
export function onGuildDelete({ guild: { id, unavailable } }: GuildDelete) {
if (!settings.store.servers) return;
if (unavailable) return;
not anymore ๐
austere talon
i feel like that'd give good money on h1
median rapids
it does
austere talon
median rapids
usually a high
median rapids
https://github.com/Vendicated/Vencord/blob/main/src/plugins/relationshipNotifier...
my guess is that the handling is broken when a guild is unavailable on READY
because then there's not an event
it's shrimply missing from the guild store
mortal fractal
usually a high
yeah cause its technically classed as a denial of service
median rapids
yeah cause its technically classed as a denial of service
half the sec team is schizophrenic and thinks denials of service are invalid
mortal fractal
bruh
median rapids
have i not shown you
austere talon
half the sec team is schizophrenic and thinks denials of service are invalid
and then they accept gatbage like endpoints leaking if a guild id is valid or not ๐ญ
how is their program so chaotic
median rapids
ofc
jagged cloak
anyway we need to fix relationshipnotifier falsely saying you got kicked when a ...
i mean it also does it for second instances
i love opening vesktop to a reminder that i left like 20 servers or that 3 people unfriended me in the laast month
austere talon
yeah but that's not fixable
just a limitation with the plugin
unless you like cloud sync it but don't think people would want to upload info on who they're friends with and what servers they're in to our server
nor would i feel comfortable storing that data
jagged cloak
yeah i wouldnt lol
charred monolithBOT
desert cosmos
#๐ฅ-vencord-support-๐ฅ message
probably qol to add this in fakenitro settings idk
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/fakeNitro/index.tsx#...
**index.tsx: **Lines 170-172
}).withPrivateSettings<{
disableEmbedPermissionCheck: boolean;
}>();
let me cook real quick
charred monolithBOT
austere talon
btw @limber skiff this discordapp.com fiasco was an immediate example of it being a bad idea to skip webpack patching if webpack init failed xd
cause it made webpack init fail entirely which broke a shit ton of stuff, but the updater tab still worked
charred monolithBOT
median rapids
so it was possible before <:trolldayruined:986365564870078466>
anything is possible if you try hard enough
crude hearth
anything is possible if you try hard enough
teach me dolfierrr
crude hearth
@median rapids WHY DID YOU REACT SKULL
median rapids
<@852892297661906993> WHY DID YOU REACT SKULL
crude hearth
๐ข ๐ข ๐ข ๐ข
topaz thistle
limber skiff
btw <@235834946571337729> this discordapp.com fiasco was an immediate example of...
I couldn't have done the future proof of fake nitro and experiments in a better time
those would not let the person access discord
quaint sapphire
oooooh what happened? give me the juice
charred monolithBOT
rugged spire
this is why dev install catches many idiots
austere talon
and people apparently got scammed from that too
even though it prints a horror banner
they disabled devtools on stable cause of it 
and nah i wouldn't say so, people are gonna be much more inclined to paste something into discord ui than in a nerdy looking console that screams at you that you're getting scammed
rugged spire
end users are stupid
median rapids
and nah i wouldn't say so, people are gonna be much more inclined to paste somet...
well
you have to enable a plugin whose whole purpose is running code first lol
austere talon
"omg i found a vencord nitro script!! enable the scriptrunner plugin and paste this code"
some people have the iq of a carpet my friend
i lost fate in the users' intelligence ages ago
median rapids
pov: natural selection
rugged spire
natural selection is when i tell users to run a script that wipes their computer and don't even hide what it does
austere talon
also even besides selfXss im also worried that people will paste dumb shit then cry for help why their discord is crashlooping ๐ญ
will definitely happen
rugged spire
The unwritten rule: Do not build anything that could cause more stupid #๐ฅ-vencord-support-๐ฅ users
guh #๐ณ-plugin-requests being stupid again
median rapids
also even besides selfXss im also worried that people will paste dumb shit then ...
same thing applies to quickcss lol
rugged spire
same thing applies to quickcss lol
you can literally tell people to add ```css
- { display: none; }
to their quick css and they will literally do itanyway im not generally opposed to the plugin, there's just a lot of potential risks/caveats to consider
rugged spire
just make it work only in dev builds
median rapids
true
median rapids
vf snippers wen
rugged spire
the challenge is installing node and git and not fucking up the installation
users fail at this step
someone DMed me today about why pnpm version mismatch
prime dew
Isn't this also similar to the old "add snippet to quickcss" button plugin someone tried to make a few months ago (I think?) ?
median rapids
or just require enabling from console or something
rugged spire
how tf do you fuck up that bad
rugged spire
Isn't this also similar to the old "add snippet to quickcss" button plugin someo...
Nop thats different and not even a month old
median rapids
cuz nodejs package management sucks lol
austere talon
just make it work only in dev builds
that's kinda nonsense tbh
if you're already building from source you don't need a script runner plugin cause you could just make a userplugin instead
rugged spire
cuz nodejs package management sucks lol
true
prime dew
Nop thats different and not even a month old
I know you're currently working on one
rugged spire
thats different
prime dew
But I remember someone had proposed it already a few months ago
rugged spire
my idea is effectively depreciating quick css
quickcss turns into horror very quick
prime dew
Can relate
austere talon
we definitely need to add a fat red warning in the plugin
and maybe hide it if you don't have discord developer mode enabled
rugged spire
the concept has reached its "well it's good enough for me i'm gonna forget about it for 3 weeks until i can be bothered fixing it fully" stage though
we love
my problem is making the uh monaco editor load properly
i will fix eventually
rugged spire
we definitely need to add a fat red warning in the plugin
and maybe hide it if ...
this is a good idea
and then
we basically tell people to not teach #๐ฅ-vencord-support-๐ฅ how to enable
because too easy and they will fuck up
i don't mind teaching support users how to setup dev build from a guide because they can fail
prime dew
It would be a good idea, too bad that the average ntts viewers learned how to enable dev mode ages ago
rugged spire
ntts users
prime dew
Unironically
rugged spire
oh
austere talon
my problem is making the uh monaco editor load properly
why?
we can make it more modular
like the ipc call
prime dew
I'm not in there
I simply watch his videos and laugh at discord crap
rugged spire
how would you suggest making the Ipc call more modular
half my stuff is figuring out why you built the ipc for quickcss the way you did
lmao
rugged spire
I simply watch his videos and laugh at discord crap
yop
prime dew
It would be a good idea, too bad that the average ntts viewers learned how to en...
Can't blame the guy tho, it's not like discord made it hard to find
prime dew
Wouldn't it be funnier if it was like on mobile phones, where you have to tap on the build version multiple times before unlocking the dev options?
long heart
and nah i wouldn't say so, people are gonna be much more inclined to paste somet...
What if I made the settings modal all monospaced and made it scream
rugged spire
my unfinished fucked up code https://github.com/Vendicated/Vencord/compare/dev...Sqaaakoi:Vencord:quickThemes
It really is cursed. Don't look into it
And no it doesn't work fully (yet)
i wrote half of this dead as fuck at 7am after staying awake overnight
prime dew
It might be a cool, although niche, plugin when it's done though
rugged spire
This isn't a plugin this is actual core changes
Okay fine
It edits VencordToolbox plugin
prime dew
I like the idea, but it's like having css files in the themes folder
Pretty much the same thing
rugged spire
I like the idea, but it's like having css files in the themes folder
The issue there is those are local :/
prime dew
True
median rapids
What if I made the settings modal all monospaced and made it scream
yeah that sounds pretty good, you could add a warning box like modals have
real flower
I don't mean to nag, just curious as to what the status of merging https://github.com/Vendicated/Vencord/pull/2405 is? @austere talon
charred monolithBOT
charred monolithBOT
glass jasper
limber skiff
peak webpack testing
at least I can see the logging that isnt right this way
cuz this clearly isnt MASKED_LINK
this is more like it
fleet depot
oh that's why my patch broke
fleet depot
? i also was getting undefined tho
limber skiff
it still works
fleet depot
and then discord was crashing-
limber skiff
show the code that was failing
fleet depot
show the code that was failing
it's my very badly coded dev build so who knows what i could be doing wrong here but here goes nothing:
i added a new patch to rolecoloreverywhere and yes I know that i shouldn't use variable names in my find it's just such a tiny module there are no other unique strings to distinguish it. Here's the module if you want to check it out: #๐งฉ-plugin-development message
there's almost certainly a better way but I haven't found it yet:
{
find: "className:s()(r.title,n),",
replacement: [
{
match: /color:"none"/,
replace: "color:\"roleColor\""
},
{
match: /variant:"text-sm\/normal"/,
replace: "variant:\"text-sm/medium\""
},
]
},
{
find: "default.colors).map(",
replacement: {
match: /case"none.{0,15};/,
replace: "case\"roleColor\":t=$self.getGuildChannelId();"
}
}
getGuildChannelId() {
return this.getColor(UserStore.getCurrentUser().id, {
channelId: SelectedChannelStore.getChannelId(),
guildId: SelectedGuildStore.getGuildId(),
});
},
getGuildChannelId uses UserStore.getCurrentUser() as you can see and the error I'm getting is that t=$self.getGuildChannelId(); is undefined.
This code worked before but the most recent update it's now causing a crash.
here's what the patched module looks like pretty printed
and this is more specifically the error i'm getting
fleet depot
it still works
i've also been trying to recreate this and I have no idea why but i get undefined here too
but again, probably user error
fleet depot
i've also been trying to recreate this and I have no idea why but i get undefine...
Okay all this above to say it's not user store
It still crashes if i hard code the ids
ยฏ_(ใ)_/ยฏ
limber skiff
I smoked something when I thought I could remove that here https://github.com/Vendicated/Vencord/pull/2237/commits/6e26b180622df20a47df11c97009f2e6a3a67ace
austere talon
why did you change this to manual proxy @limber skiff
and didn't even use webpack version
limber skiff
why did you change this to manual proxy <@235834946571337729>
stupid jsdoc didnt work no matter what I tried with destructuring
that was the cleanest other way
but yeah I used wrong method
in like 8+ hours I fix it and force push
now I sleep
austere talon
xd
median rapids
vesktop should probably have a patch to use desktop idle behavior
charred monolithBOT
charred monolithBOT
austere talon
charred monolithBOT
Found a bug: it shows the wrong character count in the About Me section.
limber skiff
<@235834946571337729> https://github.com/Vendicated/Vencord/commit/97acffafcc756...
lmao that works?
austere talon
well yeah just .prop instead of destructure
limber skiff
shocked
austere talon
so its a plain variable
limber skiff
yep
mortal fractal
* @param idk some thing, idk just pass null
mortal fractal
nuh uh
austere talon
so i wanna work on list api... does this api look good?
const lists = defineLists({
ignoredUsers: {
type: "user",
name: "Users to ignore messages from"
},
ignoredChannels: {
type: "channel",
name: "Channels to ignore messages from"
},
ignoredGuilds: {
type: "guild",
name: "Guilds to ignore messages from"
}
})
export default definePlugin({
name: "MessageLogger",
lists,
shouldLog(message) {
if (
lists.ignoredUsers.has(message.author.id)
|| lists.ignoredChannels.has(message.channel_id)
|| lists.ignoredGuilds.has(message.guild_id)
) return false;
}
})
would auto-generate context menu entries like this and also settings ui
i dont like having to put it on ur plugin instance but otherwise you'd need to do like
const lists = defineLists("MessageLogger", {
})
which is imo worse and has potential to get out of sync with the plugin name
well maybe we could make you just export it instead?
export const lists = defineLists({})
export default definePlugin({})
silk cypress
would auto-generate context menu entries like this and also settings ui
great idea
the context menu entry should maybe be changed though to say something like "Add to plugin list"
charred monolithBOT
mortal fractal
i will wait for this api before i work on highlight again
austere talon
so i wanna work on list api... does this api look good?
```js
const lists = defi...
these are the 3 types i would consider right now, anything else im missing?
shell shuttle
anyone know how to fix a random conflict
i never edited a certain file but it shows it's conflicting
charred monolithBOT
silk cypress
anyone know how to fix a random conflict
in git right?
mortal fractal
just checkout the file if you know you never edited it
shell shuttle
in git right?
yea
silk cypress
just checkout the file if you know you never edited it
do this I guess
shell shuttle
oh
charred monolithBOT
odd heath
HORROR
desert cosmos
we love force pushing
real flower
whar
austere talon
its hard to reproduce
odd heath
rugged spire
fuck idk. i would blame fakenitro at first glance though
does it happen when you right click messages?
charred monolithBOT
limber skiff
fuck idk. i would blame fakenitro at first glance though
๐คจ
austere talon
because edits arent just used for content edits
desert cosmos
i did https://cdn.discordapp.com/attachments/1029315212521771020/123750456574253...
ntts viewers would still get scammed (somehow)
charred monolithBOT
rugged spire
ntts viewers would still get scammed (somehow)
natural selection
midnight raven
fire
long stream
charred monolithBOT
limber skiff
omg I hate vee!!!!
limber skiff
I love the branch name
rugged spire
I love the branch name
Same
austere talon
guh i lost this code somehow https://cdn.discordapp.com/attachments/1015063227299811479/1236690899782860993/image.png?ex=663b90a7&is=663a3f27&hm=5ac7c7d06beb3b774a66066dd048cc3069e3b831f25c55b48562f64441f6a4a2&
unless its on my laptop
but that screen looks like my pc
mortal fractal
just make it again it isnt that hard
austere talon
mortal fractal
literally just a div, some css, markdown parser, errorboundary for sanity, checking user id from props of the header
austere talon
yeah um it was on my pc i still have the compiled code
austere talon
literally just a div, some css, markdown parser, errorboundary for sanity, check...
how do u know exactly what i did
bro knows too much
mortal fractal
cause its not rocket science
austere talon
even the ErrorBoundary detail..
limber skiff
lmaooo
charred monolithBOT
mortal fractal
what doesnt use errorbounary in vencord (dont look cause then you're going to have to fix it )
austere talon
most things use them
limber skiff
yeah but not all
mortal fractal
i need to use errorboundaries more in hh
limber skiff
also when we patch discord component code and something errors it causes crashes too
but not much we can do about that
mortal fractal
sadly other than adding something like patch grouping
mortal fractal
but thats rare cases
thats something i would need more because of some old ass patches that have things split
limber skiff
oh yeah I had done this
for (const pluginName in plugins) {
const plugin = plugins[pluginName];
for (const prop in plugin) {
const value = plugin[prop];
if (value == null) continue;
const valueStr = value.toString();
if (valueStr.includes("VencordCreateElement") && !valueStr.includes("ErrorBoundary")) {
console.log("plugin:", pluginName, "prop:", prop, "=", value);
}
}
}
to check what didnt use error boundary
limber skiff
sadly other than adding something like patch grouping
yeah but then when a webpack find failed and we use it in something called from the patch there's really nothing we can do
handling all those errors would suck so much
mortal fractal
inevitibilitiy
rugged spire
@austere talon i want your feedback on my changes to this
mortal fractal
how does it work
rugged spire
austere talon
okay done
charred monolithBOT
lost smelt
meow meow purrr
austere talon
this time i wont accidently delete it
real flower
guh i lost this code somehow https://cdn.discordapp.com/attachments/101506322729...
does this just appear for anyone with the dev badge?
austere talon
yes
real flower
that is so cool
austere talon
^
austere talon
next i wanna improve /vencord-debug
i alr reduced info to
#๐ค-bot-commands message
but if someone has a loooooott of plugins
enjoy 2k char limit
limber skiff
holy fuck
limber skiff
yep
limber skiff
57kb
austere talon
omg it grew by 11kb
rugged spire
<:blobcatcozy:1026533070955872337>
cba making a PR for this
austere talon
we need just 1 more event to fix this app
limber skiff
I updated the comment too lmao
lost smelt
wtf
limber skiff
I added the new permissions too
rugged spire
cba making a PR for this
diff --git a/src/plugins/_core/supportHelper.tsx b/src/plugins/_core/supportHelper.tsx
index 078efd99..31a414cc 100644
--- a/src/plugins/_core/supportHelper.tsx
+++ b/src/plugins/_core/supportHelper.tsx
@@ -152,9 +152,13 @@ ${makeCodeblock(enabledPlugins.join(", "))}
<Forms.FormText>You are using a fork of Vencord, which we do not provide support for!</Forms.FormText>
<Forms.FormText className={Margins.top8}>
Please either switch to an <Link href="https://vencord.dev/download">officially supported version of Vencord</Link>, or
- contact your package maintainer for support instead.
+ contact your fork maintainer for support instead.
</Forms.FormText>
</div>,
+ confirmText: "View fork information",
+ onConfirm() {
+ VencordNative.native.openExternal(repo.value);
+ },
onCloseCallback: () => setTimeout(() => NavigationRouter.back(), 50)
});
}
could we do this maybe?
lost smelt
will it show as #Unknown
rugged spire
Yop 
limber skiff
should I update i18nMessages?
austere talon
what happens if the user isn't in the vencord server
lost smelt
rip
lost smelt
is it not <#channelid>
limber skiff
should I update i18nMessages?
nah wont touch that
granite wharf
happens with discoverable servers I think
lost smelt
fr
granite wharf
any ordinary server wouldn't work
austere talon
ye u can lurk discoverable servers only
austere talon
nah wont touch that
yeah it doesnt have all
charred monolithBOT
limber skiff
only 255?
charred monolithBOT
mortal fractal
meow meow purr
limber skiff
@austere talon im gonna document the messages!!!!
limber skiff
austere talon
LMAOO
limber skiff
jk I'm not
austere talon
ts will die
limber skiff
lmao
mortal fractal
680 kb of events WTF
s/events/i18n keys/
rugged spire
limber skiff
what happen?
limber skiff
ah
mortal fractal
limber skiff
@austere talon btw when you want to do a initial review in immediate finds, I recommend reading the pr description, as I explain what I did that and also point out the most important files for a review
but no worries
charred monolithBOT
glass jasper
one can only hope my PR will get noticed
charred monolithBOT
mortal fractal
damn i wanna steal this idea now
austere talon
u dont have to ping me buddy
lost smelt
fr
mortal fractal
u dont have to ping me buddy
im not your buddy pal
also god this patch sucks to read
(in general)
mortal fractal
not just that, i just hate string based replacements
austere talon
what do u prefer, functions?
mortal fractal
yeah just for the fact of named variables
austere talon
it depends how complex imo
austere talon
damn i wanna steal this idea now
its cool yeah
frail skyBOT
mortal fractal
id prob do something cursed with my css and move it to the right with the other ones
frail skyBOT
real flower
hmm
idk if there's something that could cleanly be done
but
this is kinda bad looking imo
maybe make the title cut off like "StreamerModeOnStr..."
idk
real flower
maybe make the title cut off like "StreamerModeOnStr..."
i dont like this solution
mortal fractal
its a shame discord just uses OverflowTooltip instead of marquees ๐
real flower
marquee is far better imo
maybe not the easiest or nicest for accessibility sure
but way prettier
charred monolithBOT
turbid hatch
marquee is far better imo
maybe not the easiest or nicest for accessibility sure
i had a version that used an svg
using the text element
and then it forcefully resized the text as needed
it was quite funny
charred monolithBOT
limber skiff
less explosions ๐ฅ
charred monolithBOT
charred monolithBOT
Content
it's not working as u can see it shows that i'm listening to Spotify and my brother can see it too on his account
and when i click on it there's no screen sharing sound
Request Agreement
- [X] I have read the requirements for opening an issue above
woeful sable
charred monolithBOT
somber ginkgo
just a thought, this checks for all contribs as if they were all plugin devs, so perhaps itd be an idea to either change the string to say contribs, or change the check to only include plugin devs?
charred monolithBOT
shell shuttle
stars
austere talon
apparentlz u broke betterfolders nuckyz
charred monolithBOT
limber skiff
apparentlz u broke betterfolders nuckyz
how so?
limber skiff
hmm
maybe I mesed up the patch
it was so simple I didnt test
but I double checked
welp let me see
the patch is in the place it wss supposed to be at least
easy fix
limber skiff
a new component is decided with a predicate and they slapped a null here
the old method wasnt prepared for nulls
austere talon
@drowsy hemlock
mortal fractal
me too
limber skiff
oh god
austere talon
well its not a big deal lmao
just wait til it calmed down
how tf do we fix this
limber skiff
this one was manually lmao
austere talon
i dont think it can be fixed
limber skiff
work ๐
austere talon
NOOO
limber skiff
VENDICATEDDD
austere talon
limber skiff
SDFHDSFDSFS
austere talon
lmaooo
limber skiff
stop force pushing my branches!!!!
austere talon
was that manual
limber skiff
dont do it again.
austere talon
oh yeah it has to be
austere talon
i dont think it can be fixed
maybe we could make the mirror only one way
charred monolithBOT
frail skyBOT