#👾-core-development
1 messages · Page 175 of 1
??
ok that is shit.
oh wait
ig Promise.all is loading dependencies
yes
Are you gonna migrate it or can I make a pr (im bored and have nothing to do)
you do it
i dont care about reviewdb anymore
you can prob do this let me show you
HOW IS THAT RELATED TO RDB
so what exactly is the use case? why would a user want this feature?
i can see many use cases as giveaways or other important stuff that needs exact timing. i would use this.
as per my opinion
extractAndLoadChunks(["openAvatarDecorationModal:", /Promise\.resolve(\(\))\.then\(\i\.bind\(\i,"(.+?)"\)\)/])
nah
you just need to make sure the first group is not empty string
and the second is the entry point
so instead of empty string I match ()
does it work?
oh I forgot a thing
fixed
i fixed the api itself
okay
guh why does decor fetch 3 morbillion users
IT DOESNT
fake outage to get people to upgrade
You will die
the everything plugin
true
Ven every db plugin is NOT reviewdb
do u think cyn is mad cause 99% of pronoundb requests still use old api
probs
is that why there's an "outage" with it
nono
dont remove the regex from the lazy
the default one
why
it's used by the reporter
oh right
well i mean
if it is undefined we know
i dont like the duplication of it
also does that actually work well
it works for decor
because the first group now only happens sometimes
im the only one that can be shortened to cyn, fuck all the other cynthias
it'll just be undefined
if it doesnt take that path
makes sense
the realest cyn

do you want me to explicitly check for if its undefined or not?
nono
this should have same behaviour as old thing
if its empty string
is that a possible case
oh sure
actually nah its not possible lol
like this will always at least contain at least one
yes but
it's for the case that someone made a custom regex for it
not the default one haha
ohhh
i think its probably fine like this?
it prob is yeah
unless you wanna also add this
alsoo I'm not sure but maybe there is a case where only 1 chunk is loaded
so it uses wreq.e
then directly
just a guess honestly
i ran reporter
i did alr
msiddkjddjs
its going slow
None
None
None
None
nice
RoleColorEverywhere (had no effect):
ID: 805009
Match: /renderName\(\).{0,100}speaking:.{50,100}jsx.{5,10}{/
None
None
None
lol just make an actions script with a pre-compiled copy
sorry about that
yes this is reasonable\
what isn't reasonable is what I got in DMs at 3am
this probably sucks but it works :3
my defense contains no more no less than a screenshot of amia
oop i didnt mean to remove that patch
force push again
btw does anyone else have this issue where if you use the debugger, it fucks up the cursor? like it always stays default cursor and doesnt turn into pointer when you hover links
note how the cursor doesnt change to pointer
the only fix i found was to restart discord but its so annoyiong
I have that even when not using the debugger iirc (I got used to it)
I can check if it's still there
I just blamed wayland for it
I usually get that pretty much every time I open devtools
to fix it, I simply open devtools again and select something with the top left button
i havent had that issue and im not using wayland, still waiting on the explicit sync stuff to percolate thru the whole ecosystem
why ru gatekeeping utility plugins when plugins like banger and oneko exist lmao
oneko is silly
banger wouldn't be accepted today
cant you do it with css
am i trippin
yeah lol
wait which character wallpaper is that
vorp
true
actually tbh this is a really interesting plugin and can be useful in seeing if the person who you're talking to is having networking issues or not - the other tooltips are mainly just fun things but the connection delay is genuinely a useful stat
kind of like how ping commands are technically useless but are helpful in working out delays in bots
had the same issue a few minutes ago
If there was a way to manually edit plugin's source code locally, then everyone who wants to localize something could do it for themselves, that would be nice imo
If there was a way to manually edit plugin's source code locally, then everyone who wants to localize something could do it for themselves, that would be nice imo
You can... Clone the repository and build vencord locally with all the changes you want...?
Well, I guess it's true lul, but it can be said about any feature request basically.
If I would go this way tho I think:
- Probably will need to consider lots of things with managing how updates work and recompile everything from scratch with each incoming update
- It's much more actions than opening edit for plugin inside client
I am suggesting this mostly for a reason that this is possible in BetterDiscord and I've done that for my plugins so that extra buttons will fit my discord's...
if it can't fetch the message, it'll update the reply to say it was deleted now (i tried manually looking for a reply that couldn't be loaded by the plugin and it turns out it was indeed deleted)
this is mainly a UX thing
ok so, the plugin works fine but doesnt show when you listen with friends on spotify
is it fixable?
You don't need to keep merging this, it is automatic on this pr merge unless any of your files was changed on main.
right I need to add ghwp back
do you think they stared it enough times?
nah
nah gotta star it 500 more times
while im here this is a crime and will be rectified immediately
i’m going to use a auto clicker to start it hundreds of times
it's no longer flagged by defender @bb010g thanks for reporting
Using an effect should really be unnecessary here and the actual problem needs to be found rather than using a bandaid solution
Can this be written in a way that doesn't cause it to re-eval the script every time? e.g. inject a way of modifying the speed without restarting script, or expose the speed variable to window and modify it here.
is cross-plugin behavior like that even allowed?
Plugins should be naturally compatible with each other (that's why patches are written in a specific way, to preserve functionality), and ideally we shouldn't be adding checks to see if other plugins are enabled. If it's absolutely necessary, then so be it, but please prefer finding a solution where both can work at once without special handling.
Vencord has a built in way of handling Flux subscriptions that mean plugins don't have to do it themselves. Have a look at the coreplugin SupportHelper.
If it can be lazy-loaded remotely and it's genuinely that large then set it up as a dynamically loaded dependency: https://github.com/Vendicated/Vencord/blob/main/src/utils/dependencies.ts
Good point; But the variable onekoSpeed is declared as "const" in the og script, Meaning the value cant be modified; +this is really inconsequential when coming to performance;
@lewisakura Good point; But the variable onekoSpeed is declared as a "const" in the OG script, Meaning the value cant be modified; +This is really inconsequential when coming to performance;
Also i tried that initally and it did not work for some reason :/
I think its ready to be commited now (i have been waiting for a few months 🙏)
Remove this useless return, or remove the entire onChange function if you find my suggestion above would make it work without needing to restart it
What's with the multiple chained .then for replacing text, when the line below just continues this replacement statement?
Discord Account
No response
What happens when the bug or crash occurs?
always
What is the expected behaviour?
it literally doesnt work.
How do you recreate this bug or crash?
turn the plugin on
Errors
No response
Request Agreement
- [X] I am using Discord Stable or tried on Stable and this bug happens there as well
- [X] I have read the requirements for opening an issue above
what
i think they forgot to update.
Looks to be genuinely broken for me atleast (referencing the 2 broken patches it gave me)
these are the 3 I noticed had broken patches but could also just be my client
nomosaic
pictureinpicture
messagelogger
you will have people exploding in #support about messagelogger if that is true
stable?
its to do with .removeAttachmentHoverButton
what does this do and how crucial is it
renders the attachments as deleted and such
i dont see any broken other than nomosaic
donno then ill reinstall my stuff
aren't messagelogger attachments supposed to be grayed out?
I think they were grayed out before
duh how do i not remember that
but I could be wrong
same
PiP I couldn't tell you because I don't use it
yeah they werre
neat
all i know is not patch broke for message logger and pip
we just had the discussion messagelogger is broken lmfao
it turns gray because of a patch
it says the find
its broken
just did a patch test
ill check pip
same with pip
no find matches where found
ic
also im too dumb for nomosaic 
pip is an easy fix i think
@gritty iris which find is broken for messagelogger?
.removeAttachmentHoverButton
?
they renamed sstuff to "MosaicItem"
I see
that happened to pip and I think to message logger too
HOLY SHIT
I JUST HAD A SUDDEN REALISATION
I just came across somewhere I need to patch
I would've found such a plugin useful. I also wouldn't want to disable the middle-click pasting behavior on a System-Level. I wouldn't call it a waste of time.
I second this, only reason keeping me from using vencord
idgi
Discord Account
What happens when the bug or crash occurs?
RoleColorEverywhere's voice users list settings is no longer working (maybe due to a recent discord update?)
What is the expected behaviour?
Should show all usernames in the voice channel list with role col...
the main issue is that the core code for the oneko plugin (the cat) isn't mine and I don't wanna repost it to make changes (cuz I don't wanna upset the og creator of oneko)
just for organization;+ (remember we are talking the script from another creator and modifying it slightly to work with discord) + I added like 26 bu the other .then statements where already there
as started previously the only way would be to take the code of og creator (which we eval from their script) make our own fork of it and modify it (which I don't know if they will be ok with).
- we don't need to go through all that hastle as this is a very very minor performance improvement that is not worth the hastle
NoMosaic (had no effect):
ID: 310043
Match: /null!==\(\i=\i\.get\(\i\)\)&&void 0!==\i\?\i:"INVALID"/
RoleColorEverywhere (had no effect):
ID: 805009
Match: /renderName\(\).{0,100}speaking:.{50,100}jsx.{5,10}{/
MessageLogger (found no module):
ID: -
Match: .removeAttachmentHoverButton
NoMosaic (found no module):
ID: -
Match: .messageAttachment,
PictureInPicture (found no module):
ID: -
Match: .nonMediaAttachment]
None
None
None
NoMosaic (had no effect):
ID: 310043
Match: /null!==\(\i=\i\.get\(\i\)\)&&void 0!==\i\?\i:"INVALID"/
RoleColorEverywhere (had no effect):
ID: 805009
Match: /renderName\(\).{0,100}speaking:.{50,100}jsx.{5,10}{/
MessageLogger (found no module):
ID: -
Match: .removeAttachmentHoverButton
NoMosaic (found no module):
ID: -
Match: .messageAttachment,
PictureInPicture (found no module):
ID: -
Match: .nonMediaAttachment]
None
None
None
most of them have prs
.messageAttachment is gonna be .messageMosaicItem or .messageItem i assume
I take that back lol
I can confirm that this is happening for me as well.
356a2c2 fix: RoleColorEverywhere, PictureInPicture, NoM... - AutumnVN
None
None
None
None
None
None
None
None

.then(s => eval(s.replace(/(?<=const\s+nekoSpeed\s*=\s*)\S+?(?=\s*;)/, `${settings.store.speed}`)
.replace("./oneko.gif", "https://raw.githubusercontent.com/adryd325/oneko.js/14bab15a755d0e35cd4ae19c931d96d306f99f42/oneko.gif")
.replace("(isReducedMotion)", "(false)")));
I recommend making the search value for the nekoSpeed replace more robust, as it seems the author of oneko.js occasionally makes changes to the script.
Also, I believe that, as @Sqaaakoi previously mentioned, the extra chained then() methods are unnecessary, since the replace() method of String does not return a Promise object.
wasn’t ryan banned why they giving there input on pr’s
as long as they're not harrassing people on github i think it's fine
far enough, just crazy to me. You get banned from a server and then go up in the github and still give your input
not mention how they was shittalking my pr in my DMs
Shows if you are typing. Works with all other typing-related plugins
open pr #5
real
i've actually wanted this for a while
i thought i'd be more complicated but discord actually stores that you are typing so i just removed the check
well yea u still get the event
true
filtering it in the backend makes no sense
it's almost the first birthday of my first ever merged pr
this was before i was even in this server lol
is still your pr from jan 4 being reviewed?
lmao, I hope I don't wait that long
I literally fixed the conflicting files but wtv
None
findByProps("profileColors")
findByCode(","--profile-gradient-primary-color"")
None
None
None
findByProps("profileColors")
findByCode(","--profile-gradient-primary-color"")
None
None
can someone fix this
it causes ugly error in profile
mm whats the first one
cant find
its gone
wait thats not right
well someone else can fix it lol
gonn sleep
they also changed the apis
so it will always use dark theme which makes icons white on white theme
lol i tried same as you
then oh it's wrong
btw idk about CustomRPC
the class it was using is gone and profile activity doesn't use any similar class
it looks fine without it
well anyway i already released browser extension so showconnections is gonna have broken theme for now xd
shrug
the button doesnt have background color without that class ig
oh
mmm
well need some other class then
or we could just apply the styles ourselves
yep we already discussed about this in the past
my basic idea was to allow plugins to define white-/blacklists with a function similar to defineSettings:
const lists = defineLists({ userWhitelist: { type: "user", name: "Users to log messages from" } }) const isUsedWhitelisted = lists.userWhitelist.includes(someId);this would then automatically add a context menu and settings ui for you and .
I was not sure if naming it "MEE6 Voice Channel Shortcuts" was a smart idea due to trademarks, so I chose a neutral name.
Selfbot
This is pretty niche if you are literally sending commands to a bot, this definitely won't get merged if it stays like this
mee6 
i love paying to change server prefix
lmfao
can't even disable message based commands for free
plugin would be better if it wasn't designed for one specific bot (that is very much widely hated)
also use slash commands instead
LMFAO
to use slash commands you'd have to load them and find the id by name i think
yes
it shouldn't be too hard
but maybe i'm wrong 
in any case it would still be hardcoded for a specific bot, and if it was changed to be configurable it wouldn't work for bots without slash commands
what bots exist that do this
fuck
me when i remember there are bots that do this with a control panel channel and button interactions
good luck
wdym
gearbot, zeppelin, vortex, skyra, mousey all don't have slash commands 
installer rewrite in rust soon
just curious: how many of those are paid bots
? none lol
i swear i remember some of those at least looking like they try to hide how to invite them
anyway
or were you asking about which bots have configurable command names
nope
really?
yeah this is way too niche, sorry
especiiiially not mee6 i want nothing to do with that spawn of hell in the mod
(also for future reference, usage of their name in the plugin name or description would fall under fair use, as long as you don't make it seem like you're officially endorsed by mee6. "CommandsForMee6" would be fine, something like "Mee6Pro" probably wouldn't)
i think it would be fine if you had a plugin which just had blank textboxes to put the command name
maybe
@austere talon thank you for saying The Thing that I am too kind to say
make your mind up /lh
now if you made this more generic to work for any bot, that could possibly be considered
like being able to add custom command shortcuts to various context menus
i mean there was nothing stopping me from replying "||fuck mee6 lmao piece of shit bot
nft grifter bullshit bot||"
ah
vee will see my comment i am about to post and immediately mark as spam because i am yapping about theoretical ideas and shit again
native channel commands would be nice
||This comment was marked as spam||
i should make a plugin to add slash commands to rename channels
use case: stupid fucking admin abusing admin perms while laughing too hard in vc reasons
make a plugin to make built-in commands useable with prefixes 
do you actually want this
kinda
i could probably make this by modifying a regex
why do you want this??
i thought it would be funny to make a plugin which makes slash commands less terrible but it's impossible probably
i could try
OH
would anyone want the option to set defaults for command arguments?
now if you made this more generic to work for any bot, that could possibly be considered
like being able to add custom command shortcuts to various context menus
potential idea for this could be a mod bot that allows you to quickly lock/unlock a channel
however i had this as an idea before (but with internal slash commands), where it would just overwrite the channel permissions directly, instead of using a mod bot (which would be... too overcomplicated?)
yes i am yapping again
this would be useful
yapping above
or maybe presets
i will use with @woeful bison
for slash commands
like a template
already a thing
wdym
How
optional commands
but only settable for the the dev
**optional options
a template where something is alr filled out and some stuff is not
like VSCode snippets
@scarlet musk you should add option to esmBot to auto configure /speechbubble to use togif:True alpha:True flip:True
please
self-trolleyer
yes
i will trolley myself
btw
i will confess
i took someone's idea from #🗳-plugin-requests
made it
and just forgot about it
last night
Just want to confirm, Vencloud does NOT do any checking of what you upload to it?
I looked at the source
var 
this shows it does check
why should it
idk lmao
@cunning canyon any luck with the customrpc / ShowConns stuff? or did u give up
fellas
i love my screen being all messagelogger red deleted messages
i wonder where slash commands permissions are retrieved from 
ohh wait should i be doing this in #🧩-plugin-development now
sorry
i forgot so havent tried anything 

i thought showconnections was already fixed 
It is
yes but
theme code is broken, it always uses dark theme (aka white) icons
they changed how the function works
i only fixed the find, not the usage
riight
plugin would be better if it wasn't designed for one specific bot (that is very much widely hated)
This was exactly my thought, but the plugin settings seemed too limited for that (i.e. only single-line textbox). Maybe a JSON format with presets for popular bots and a web UI to generate them would be a good idea - I'm open for any suggestions.
also use slash commands instead
For some reason they didn't work, maybe because I used the wrong message type.
I'm pretty sure you don't use the message creation endpoint, but the interaction creation endpoint.
However, multiple slash commands could have the same name and it would be a pain to deal with :/
i will make quick themes
Esm bot commands vencord port when
i have considered this in the past
Shit i forgot those exist 
they're gonna be non-ephemeral in all servers at some point i believe
discord has been doing experiments
Esmbot vencord port that applies magik to every image you send
somebody figured out a life hack which got themselves banned
(that life hack was actually an exploit for spamming)
it's built in
legacy input
it's funny it lets you do multiline which still isn't supported with slash commands
this is a
test ¯_(ツ)_/¯
lmfao

this is a\n line break ¯_(ツ)_/¯
there is
the size limit isnt enforced on the client
that would be stupid
**.env.example: **Line 13
SIZE_LIMIT=33554432
is that actually the limit
is it higher than that
im not going to disclose that
okay but can you answer this
and anyway, there's no point checking what people upload to it because it's arbitrary data anyway, we cant check it and that would be an invasion of privacy
if you brick your own cloud data, thats your fault
am I able to fit a couple themes in that size
if your themes arent ludicrously large, but you shouldnt really
there's a reason why theme links exist
how about splitting quickCSS off into it's own fake files
regular quickcss doesnt hit the limit in almost all cases
surely that shouldn't fill up the cloud storage
so
oh
huh
i thought that limit was changed
nvm it is 32mb
i thought i raised or lowered it because someone abused it for something
but no you have 32mb you can put in cloud storage
so go nuts i suppose, just dont cause memory leaks by doing that lol
32MiB is probably almost too much
oh most certainly
it's the size of a few optimized executable files
so if you manage to hit that limit
i would be
concerned
and would most likely be bonking you off of the service for abuse lol
and if users install hundreds of themes into their client with this thing I am building
- you should not be doing it like that, this is for people who want quick css but better
- congratulations you win nothing
mhm
i will kill vee for giving me brain rot
getSnippetList() {
// is there any point of this being its own thing?
return VencordNative.cssSnippets.getRawData();
},
here
husk this bullshit
this is its own thing so electron can have another implementation afaik
OH WAIT
It has a purpose now
I still have a video uploaded in my vencloud 

mp4
holy shit it finally started
wait a bit more
what the fuck
windows 
is this the "i must test vencord on windows official client" system
windows so fucking awful
idk how i ever used this in the past
i was on it for like 10 mins and alr got cancer
simple, you used 10 not 11
I'll send it here bc it doesn't really fit in #🏥-vencord-support-🏥 anymore
I wrote this monstrosity
#!/usr/bin/env bash
if ! command -v discord &> /dev/null
then
echo "Discord is not installed."
exit 1
fi
SCRIPT_LOCATION="$(realpath "$(which discord)")"
SCRIPT="$(cat "$SCRIPT_LOCATION")"
ASAR_FILE="$(echo "$SCRIPT" | grep 'app\.asar' -B 1 -A 2 | sed ':a;N;$!ba;s/\\\n/ /g' | awk '{ print $3 }')"
if ! test -f "$ASAR_FILE"; then
# Failed to detect app.asar file
echo "Fatal error, unable to find app.asar"
exit 2
fi
NEW_SCRIPT=$(cat <<EOF
import "/home/arjix/Documents/repos/Vencord/dist/patcher.js";
import "$ASAR_FILE/app_bootstrap/index.js";
EOF
)
NEW_SCRIPT_LOCATION="${TMPDIR:-${TEMP:-${TMP:-/tmp}}}/.vencord.launcher.mjs"
echo "$NEW_SCRIPT" > "$NEW_SCRIPT_LOCATION";
SCRIPT=$(echo "$SCRIPT" | sed "s#$ASAR_FILE#$NEW_SCRIPT_LOCATION#")
AUTO_UPDATE="true"
if ! command -v git &> /dev/null
then
# git is not installed, therefore we cannot auto-update vencord
AUTO_UPDATE="false"
fi
if ! test -f /home/arjix/Documents/repos/Vencord/package.json; then
# Vencord is not properly cloned, or missing.
AUTO_UPDATE="false"
fi
# Forcibly disable for now
AUTO_UPDATE=false
if [[ "$AUTO_UPDATE" == "true" ]]
then
pushd "/home/arjix/Documents/repos/Vencord" > /dev/null || exit 1
git fetch
if [[ $(git rev-parse HEAD) != $(git rev-parse @{u}) ]]
then
git pull > /dev/null
sudo -u arjix pnpm i
sudo -u arjix pnpm build
fi
popd > /dev/null|| exit 1
fi
eval "$SCRIPT"
in order to not dirty the discord files
but no, god said "fuck you in particular"
bro
there are 6 different patches for settings category
only one of them broke: the one that's the default option
meanie discord
oh the patches to set where the vencord category appears?
yes
oof
what the fuck does this do
is this just a coping mechanism for upstream discord
It is a wrapper around the AUR package discord-electron (or was it discord-system-electron?)
And it injects vencord using a temporary file as the entrypoint
It also has updating functionality bc why not
But sadly it doesn't work
Because of the electron version(?)
Too tired for now, will try again tomorrow
like i said unpackaged electron wont work
aka no discord-arch-electron
theres 0 reason to still be using that package
The normal discord package on arch is annoying
Whenever there is an update it wants me to update the package, but when I try it does not fucking do it, maybe the mirrors I am using do not have the new version within 2 days of the update
So I turned to smth I knew did not ask for package updates
become vesktopchad
Meh, I prefer normal discord NGL
I've used vesktop a lot on my work laptop though
@cunning canyon i fixed xd
kinda amazing
None
None
None
None
None
None
None
None

LMAOO
3 updates in 1w
i think they hate me now
they probably have some good diff program that can ignore variable name changes
why does vencor have to be bundled with the extension
well they dont ask for source code lol
WHAT
chrome store rules
wtf
you cant have remote code
how is tampermonkey allowed
how they review the bundled code
i mean if they study it a bit they will find source code
are they crazy
but yeah they dont ask for source
because it doesnt have remote code
user adds remote code
horro
(pastes github link)
because if they have commit changes it's like a 1 scroll to see if there is a thing breaking a rule
well theres no guarantee that the source code is whats in the bundled code
like i could just build different code
well yeah
but yeah google doesnt ask for anything
but poor then having to review those
meanwhile firefox asks for full source code, build steps and even asked me to give them discord credentials for testing
imagine how many updates daily on extension

bro what
😭
firefox is just stupid
funniest thing is firefox has a cli tool to auto publish
but their cli tool doesnt publish source code
so i always had to manually upload source
horror
man
oh and
i love half-baked developer tools
Hi
the reviewers are retarded like they flagged electron code thats not even bundled for firefox
we need a way to bypass chrome webstore updates
hide remote code execution
muahahahaa
so from that point on i always deleted native files before uploading source code

and then just eval vencord
lmao
they flagged the electron code for removing csp
UWAAAAAH NOT ALLOWED 🥺
actually so funny
bro 😭😭
cant make this shit up bro
**index.ts: **Line 84
const stringifyPolicy = (policy: PolicyResult): string =>
yeah man im bundling electron into the firefox addon 
so yeah i just started deleting the native files before submitting
but then they asked me for discord login credentials 
that is when i took down the extension
you will give firefox your token
what else do they want
also no way they want you to provide a free account lmao
a theme to test quick css
bro imagine making an extension for a bank website and then they ask u for an account

idk what theyre thinking
firefox ext became super shit anyway cause no csp remove #announcements message
"please upload your dna for verification purposes"
and then asking me for my account and more garbage
they'll take some donations while they're at it 
This is FINALLY ready to merge now 🙏

it only took 5 years dw
lmao no rush u got all the time in the world
what's the point of having 3 functions for that
fixed, it was old code so i kinda mentally forgot about it
typo 
workflow is failing in your pr
yeah cuz typo
toggleStreamerMode(StreamData, false);
toggleStreamerMode(StreamData, true);
the addPreSendListener doesn't work anymore, is it just me?
while testing those two snippets
Vencord.Api.MessageEvents.addPreSendListener((_, ctx) => {
let res;
try {
res = eval(ctx.content);
if (res) res = res.toString();
} catch (e) {
return { cancel: true };
}
ctx.content = !res || res.length == 0 ? "no output" : res;
});
let e = document.getElementsByClassName("textArea_a86690 textAreaSlate__8578d slateContainer__1d1fd")[0];
Vencord.Api.MessageEvents.addPreSendListener((_, ctx) => {
let { x, y, width } = e.getBoundingClientRect();
Game.collectCookie({ clientX: (x + width + 60), clientY: y - 10 });
});
what? this is a vendored file and comments are compiled away, why would we change anything about this
Who makes a whole pr to update a single comment 😭
Tbh, I don't see a point in this
Is there text in your message input? congrats, you are typing!
Dieee
You dont know how to use
Also you use 11 
Context for that latest commit:
<img width="389" alt="Screenshot 2024-04-17 at 10 31 29 PM" src="https://github.com/Vendicated/Vencord/assets/70721372/8f9cdebb-4297-463e-ab30-b8fd95a48c9c">
Discord Account
fairwellnoob
What happens when the bug or crash occurs?
Forum channels
What is the expected behaviour?
Forum channel is read
How do you recreate this bug or crash?
- Have someone message in a forum channel
- Click the ReadAllNotificationsButton read button
- Message is not read
Errors
discord.com-1713439265861.log
[discord.com-1713439260545.log](https://gith...
Seems fine, but needing an API key seems a bit inconvenient.
i wonder if it would be a good idea to show a message box for when the settings patch fails and there's an update available
kinda like the one that gets shown upon opening #🏥-vencord-support-🏥 while having updates available
how would that be different from the existing update popup
this one?
ye
there's no good way to detect whether a patch worked or not
especially not the settings one
cause it patches lazy loaded stuff

not the greatest idea but i guess we could just assume that the worst happened if a core plugin like settings has a broken patch?
thoo that might become an annoyance on canary
Has this rolled out for everyone? Maybe it should check the experiment if possible (I haven't seen any other plugin do this 🤷🏻♀️)
like i said we have no way of properly detecting that
we would have to make a rest api or smth
o i misunderstood my bad
some api you send your discord hash and vencord version and it returns info about what's broken
then uses that to disable plugins or smth
Requested in https://github.com/Vencord/plugin-requests/issues/361 by @TonyE2, betterQuests is a fairly simple plugin which introduces new button on the Home screen of the client - Quests
Said quests button functions as an easier/faster way to navigate through settings to Quests menu.
a better solution might be to use a modal for the updater notification
so it doesn't rely on settings
true
it should be really easy to do
just slightly refractor the updater component to render in a modal
it's still possible that modal api breaks but it's unlikely that both modal and settings code break

wowie
im not touching this one from now on
Like a global kill switch?
but ill just push it with some later commit
ill put it in dev
can work on it later
I made a new pr
nah
main?
nah
leave it?
^
its not relevant to have its own commit so it should just be tucked in with some other commit
google been approving these updates blazingly fast
just like trust
rust
anyway yah i can have a look at the remote plugin disabling thing
with opt out of course
it'll be under the cloud section
i should get a new badge for myself
I feel like there should be a pop-up you can't dismiss for 3 seconds that says something like "Plugins: ... have been disable due to issues. Read more in the #announcements channel"
it'll be a regular model
modal
Has this rolled out for everyone? Maybe it should check the experiment if possible (I haven't seen any other plugin do this 🤷🏻♀️)
I don't know if it has an experiment and I'm not sure how to check. Could you please let me know if you find one?
Has this rolled out for everyone? Maybe it should check the experiment if possible (I haven't seen any other plugin do this 🤷🏻♀️)
afaik it doesn't have an experiment. The change is also on stable now.
what? this is a vendored file and comments are compiled away, why would we change anything about this
It an attempt to get that cool contributor badge 😔
i knew it hah
😔 it's always like that...
97ce410 bump to v1.7.8 - Vendicated
a5cd44a Merge branch 'dev' of https://github.com/Vendic... - Nuckyz
None
None
None
None
None
None
None
None
So this is why all the good PRs aren’t being reviewed
Contributor badges are not granted because you made a single PR, nor are they granted automatically, they are for significant contributions to the project as a token of gratitude. Please do not try and spoil that goodwill for others by making these sorts of PRs.
i hate people who do things just for a cool and shiny badge
especially when they clearly dont know how said badge works or is vendored
(p sure you cant reopen issues closed by collaborators)
(i think so too yeah)
badge hunting white names whom come from NTTS
I love when people add themselves to contributors/devs for one patch change 
can u repro it on canary?
nop

then i might just have a borked install
the heck is that
well i tried on vesktop canary
why would you put that
i dont have normal discord canary
to make regex more hungry?
then try on normal canary?
it probably wont change anything buut it might be worth a try
monkey patch on bencord when
actually I think there was one
webpack patch is monkey patch at least, even though its hand crafted
maybe its time to https://github.com/diced/dvm
no offense 😂 we have lives
oh i alr have canary installed lol
doubt
mean 😭
it entirely removes the activity category
and moves everything that was there to a new tab at the top called "games"
oh god theyre all the way up

discord has added predicated: () => !eb to that which broke the regex, i just added .+? so it matches any keys that are after label
that makes no sense, it doesn't break the regex
you're just adding addiitional matchers that don't change anything about functionality. this change makes no sense
you don't add yourself to authors for such minor changes
uhm, why close the pr when people are having issues with vencord settings not showing when below activity is choosed
uhm, why close the pr when people are having issues with vencord settings not showing when below activity is choosed
Because it is a low quality PR where all it looks like is you're trying to cobble things together just to get le funny contributor badge

yeah when half of commits are "add me to devs" it means you're doing it for the contributor badge 
like come on go to plugin requests and make a plugin
theres your free badge (speaking of experience there)

huh, so your telling me i posted a low quality PR to get the contributor badge? your so funny. like bro i just solved an problem i dont even care to have a badge
i jsut looked at the repo of this apparently it doesnt work on desktop i honestly just expected this to just be a vencord fork
uhm, why close the pr when people are having issues with vencord settings not showing when below activity is choosed
because this pr does absolutely nothing.
settings were already fixed via https://github.com/Vendicated/Vencord/commit/89c82e2cd173b26b0eee938022afad5684e174cd
this pr just makes the regex longer, it doesn't even change anything. There is exactly one match anyway and the outcome is exactly the same
btw how will users update for this fix that you implemented?
btw how will users update for this fix that you implemented?
https://github.com/Vencord/Installer
and
use your brain.





