searching "pull request" in the discord gif picker is an experience
#👾-core-development
sly veldt
https://tenor.com/view/pull-request-pr-jira-bitbucket-merged-gif-27373367
top 10 least realistic videos (this one is so fake it must have been ai generated)
glass jasper
glass jasper
https://tenor.com/view/pull-request-pr-jira-bitbucket-merged-gif-27373367
top 1...
me if Vee ever notices my pr cough, cough
https://github.com/Vendicated/Vencord/pull/2302
again this is just a joke
but actually :3
sly veldt
your pr is younger than mine
mine is #2161
they said they ignored it since it appears over-engineered
which honestly is fair
patches are an absolute pain to read and write
but each one is (sadly) necessary for it to function
austere talon
stop constantly bringing it up
sly veldt
stop constantly bringing it up
sorry
austere talon
not you
austere talon
they said they ignored it since it appears over-engineered
only temporarily, ill get back to it
austere talon
okay then stop joking it's not funny
glass jasper
understandable i’ll stop
sly veldt
only temporarily, ill get back to it
Thanks, I was referring to before I clarified it a few days ago. Life's busy and I don't expect you to review every PR in 2 seconds
glass jasper
Thanks, I was referring to before I clarified it a few days ago. Life's busy and...
same, i’m just proud of my first ever pr
sly veldt
same, i’m just proud of my first ever pr
Same boat
glass jasper
but i promise too stop being it up
sly veldt
i love this
it's beautiful
i'm specifically talking about the ones that spell vencord
Viewing someone's profile on Discord:
shell shuttle
is beautiful
sly veldt
I agree with that as well
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
shy veldt
why is it tracking me 😟
charred monolithBOT
brazen bone
Because it knows you are not to be trusted
devout river
fun fact there's a native port of chomik for like ubuntu 12
austere talon
wdym
median rapids
oh you meant rebase specifically
austere talon
ofc
median rapids
nah I do merge for prs
austere talon
yeah there u go :p
median rapids
I only rebase in other cases
austere talon
charred monolithBOT
median rapids
scary
charred monolithBOT
charred monolithBOT
junior olive
@austere talon discord try not to push breaking changes to both channels twice a day challenge
austere talon
r u saying they pushed some insane again
junior olive
No
crude hearth
charred monolithBOT
limber skiff
it's okay
topaz thistle
https://github.com/Vencord/venmic/issues/15#issuecomment-2027863989
@vending.machine#0000 is the Flatpak broken with venmic? I don't get what he means
austere talon
https://github.com/Vencord/venmic/issues/15#issuecomment-2027863989
@vending.ma...
no clue you'll have to wait for him to clarify
glass jasper
shell shuttle
yipee
odd heath
Damn someone lost an old account lmao
glass jasper
Damn someone lost an old account lmao
glass jasper
yippe
austere talon
right
canUseEmote(e: CustomEmoji, channelId: string) {
if (!e.require_colons) return true;
if (e.available === false) return false;
if (this.canUseEmotes)
return e.guildId === this.guildId || hasExternalEmojiPerms(channelId);
return e.guildId === this.guildId && !e.animated;
},
is this logic correct
actually im just not gonna touch it
well no actually
because the old logic isnt really correct
const canUseEmotes = this.canUseEmotes && hasExternalEmojiPerms(channelId);
if (emoji.available !== false && canUseEmotes) return emojiStr;
if (emoji.guildId === guildId && !emoji.animated && emoji.available !== false) return emojiStr;
if you have nitro but no external emoji perms, it will fake animated emojis of the current guild
limber skiff
```js
canUseEmote(e: CustomEmoji, channelId: string) {
if (!e.require_colons...
it seems correct
charred monolithBOT
austere talon
AHHAHAHA
rugged spire
Am I an unpaid intern?
limber skiff
yes
charred monolithBOT
rugged spire
Hello Vencord Company. I have noticed an increase in "Slavery" at the company recently.
stark flint
Please forward your report to #📩-modmail and we will deal with it as soon as possible
rugged spire
This is not a Vencord issue. Is this still welcome in #📩-modmail
glass jasper
Please forward your report to <#1161412933050437682> and we will deal with it as...
In 10-11 business months
faint geyser
**In 10-11 business months**
only months? shoulda been years
glass jasper
only months? shoulda been years
nah that’s for PRs us unpaid interns are forced too make
faint geyser
nah that’s for PRs us unpaid interns are forced too make
modern day slavery frfr
odd heath
nah that’s for PRs us unpaid interns are forced too make
Gotta be glad to be cmo, all my prs got merged at a decent speed
glass jasper
Gotta be glad to be cmo, all my prs got merged at a decent speed
real
rugged spire
Gotta be glad to be cmo, all my prs got merged at a decent speed
Because you are very established contributor
odd heath
Because you are very established contributor
All I did was fix 2 plugins and make 1 plugin
sterile oak
lol the name
austere talon
💢
wary dew
if i dont get my contributor!!! 😡😡 /j
limber skiff
contributor just for that is kinda crazy
wary dew
ik i was joking lmaoo
wary dew
yeah u need to do more than a single character change for contrib sooooryy besti...
alright guys, it's time to rewrite vencord
odd heath
yeah u need to do more than a single character change for contrib sooooryy besti...
Didn't i get it for 6 characters 
crude raptor
if the text replace PR gets merged it will have done like
some html and (inline?) css-
read: "Please merge the text replace PR 🥺"
wary dew
Are there any docs for vencord's api
im trying to make a enable streamer mode on screenshare thing
Nvm, I figured it out
charred monolithBOT
This adds an option to show user avatars to the left of the typing indicator.
Default behaviour is to show only the typing dots, so for existing users nothing will change.
yes I did leave this for a month and forget about it, yes it has been stable for that whole time.
wary dew
🔥
mortal fractal
🤓 cause streamer mode is only for external streaming
gritty iris
genius level features at discord
Sorry their IQ is too big for that
shell shuttle
woah new channel name?!!
we must meet here
https://tenor.com/view/amongus-amongsdp-black-emergency-meeting-black-emergency-meeting-gif-18720662
glass jasper
among us is not tolerated on the job
tepid knoll
i was ranting about this not being a thing in discord being really dumb like a week ago thank god for this
mortal fractal
@austere talon when are we getting a general development channel again but its rolelocked like this channel is
glass jasper
<@343383572805058560> when are we getting a general development channel again bu...
just rebrand #🧩-plugin-development or something
mortal fractal
*unrebrand
glass jasper
*unrebrand
wary dew
i was ranting about this not being a thing in discord being really dumb like a w...
you're welcome 🙏
now we just need venn to merge it
junior olive
Hello!
rugged spire
NO I wont do this I am just curious wtf I have made over the past few months
livid heath
rugged spire
The Vencord Company has decided that it is not worth merging PRs as it is a liability to the company.
brazen bone
I wanna be a liability to the company too
rugged spire
~~I wanna be a liability to the company too~~
idk
sterile oak
~~Are there any docs for vencord's api~~
the docs are the plugins and the api code 👍
brazen bone
Some functions have comments on them
sterile oak
Some functions have comments on them
I see the comments quite useful
charred monolithBOT
rugged spire
<#1223973149222375536>
i hope you know that this will turn into people using it for vencord plugin dev instead of #🧩-plugin-development ONLY because it is locked
if you dont want that, unlock #🧩-plugin-development (and keep this channel locked)
charred monolithBOT
mortal fractal
@austere talon why is your aliucord plugins repo webhooked here lmao
mortal fractal
ah
mortal fractal
real
wary dew
merge when?™️
sly veldt
I love the new nicknames
sly veldt
wdym nicknames
I mean the Discord feature
austere talon
big company announcement coming tomorrow
sly veldt
we are just stating our positiong
And yes I agree that it's a good decision for clarity
austere talon
stay tuned guys
we got great things planned for the future of the vencord company of Düsseldorf
sly veldt
We have a bright future ahead of us!
odd heath
big company announcement coming tomorrow
I wonder what date tmrw is 
@austere talon at what time tomorrow
limber skiff
1st of january
sly veldt
1st of january
The best time for an announcement
limber skiff
for real
spark pivot
luckily my pfp is canonically a ceo so i dont have to change it
sly veldt
I actually have an announcement in line for tomorrow for another project of mine
I totaly didn't find this one on google images and it's totally me
austere talon
oh yeah same for me
and for all our other staff
these are definitely not stock images and anyone who might insinuate such is a total idiot!
lime stone
theyre totally stock images lmao
sly veldt
No they aren't, obviously
These are professional portraits that indicate a bright future for The Vencord Company of Düsseldorf
lime stone
yours looks a bit like simon cowell
sly veldt
Maybe from afar, yes
lime stone
is that dad
sly veldt
I've come back with the milk
wary dew
Vee, this is not very professional of you 😡
sly veldt
Oh i completely forgot that comments were logged here
lmao i just searched my username and found this #👾-core-development message
i'm flattered that my old replugged plugin was found
mortal fractal
i dont get why people hate media mosiac so much
and it annoys me that "here's a plugin to remove it" instead of "heres a plugin to fix issues with it"
lime stone
and it annoys me that "here's a plugin to remove it" instead of "heres a plugin ...
it's unfixable...
austere talon
cynthia made media mosaic before discord did it
lime stone
blocked
mortal fractal
yeah i did it in all css too
mortal fractal
it's unfixable...
nop
lime stone
yeah i did it in all css too
vbanned
charred monolithBOT
charred monolithBOT
woeful sable
charred monolithBOT
This pull request simply improves the quality of stickers so that they get cloned to 2048.
Before:
After:
shell shuttle
sly veldt
i dont get why people hate media mosiac so much
personally, when I look at an image, I prefer to see all of my image at the same time. The media mosaic gives you a choice: Either it cuts large chunks of the images off by the horrendous cropping that it does, or you are forced to click and view each image in full one by one. I much prefer to quickly vertically scroll through the whole, uncropped images, even if it does take up more vertical space in the chat window
You're welcome to have a differing opinion, that's just my view on the subject
mortal fractal
how about a middle ground then
hovering enlargement and/or click to enlarge and then click again to throw into the modal
if not just have hover buttons show up for both of those
limber skiff
muy bueno
charred monolithBOT
jagged reef
and it annoys me that "here's a plugin to remove it" instead of "heres a plugin ...
Which one?
charred monolithBOT
charred monolithBOT
mortal fractal
yes and most of them dont have toggles most likely
austere talon
is this intended? I don't remember this being a thing
?
shell shuttle
why’s the font looks so big
charred monolithBOT
lime stone
why’s the font looks so big
because I need glasses!
glass jasper
because I need glasses!
Skill issue (i’m legally blind and also need glasses)
spark pivot
Skill issue *(i’m legally blind and also need glasses)*
Skill issue (I just have glasses)
odd heath
Skill issue *(i’m legally blind and also need glasses)*
Skill issue (I just have glasses (how blind are you?))
glass jasper
Skill issue (I just have glasses (how blind are you?))
Like without glass i can only see like 1 foot infront of me
brazen bone
Sounds about right
odd heath
Like without glass i can only see like 1 foot infront of me
Normal vision 
brazen bone
Normal is for wimps
glass jasper
Normal vision <:cozy:1208476525444206702>
nah after 1 foot everything is black
odd heath
HORROR
brazen bone
I hate when video games do that
austere talon
lol wrong ping
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
limber skiff
I'm the manual reporter activator now
limber skiff
that's just the thing that makes the Force Server Home work lmao
limber skiff
oh wait it can be simpler
rugged spire
is the favourite gifs thing still broken or is that me being on a fucked up branch when i noticed
shell shuttle
still broken
rugged spire
cba to fix myself
my ass would take 1 month to submit PR and it would take another month to get accepted
shell shuttle
i'd get a PR merge before the time i get into the github sponsor program
it's been 3 weeks
said it would take at least 1-2
rugged spire
and i don't mind waiting cuz devs need time to review
yeah ik
rugged spire
Get real https://github.com/Vendicated/Vencord/pull/2319
DO NOT read into this
shell shuttle
i used fiscal host because stripe locked my account
can't delete my account either
limber skiff
oh yeah I used stripe
shell shuttle
Get real https://github.com/Vendicated/Vencord/pull/2319
lmao what are the odds
shell shuttle
I don't receive a single email
2 years ago
limber skiff
I mean it seems like you had an issue you needed to fix
shell shuttle
I mean it seems like you had an issue you needed to fix
ehhhhhhhhh
rugged spire
i will deal with it in 3 hours
shell shuttle
i uhhhh
jagged reef
Huh
jagged cloak
2 years ago
stripe loves emailing me
rugged spire
i will deal with it in 3 hours
i am dealing with it now
odd heath
i am dealing with it now
That wasn't 3 hours you liar
rugged spire
shut
charred monolithBOT
median rapids
stripe emails me all the time because i have like 6 fraudulent accounts used for testing discord payouts
i love random ssn generator
shell shuttle
i love random ssn generator
ooooo
median rapids
they kept asking for reverif
but now it hasnt for a while
so ig i got a good ssn
😊
jagged cloak
hmm
shell shuttle
so ig i got a good ssn
you should show me how
austere talon
please do not discuss cybercrime in the vencord vendor venchor server
limber skiff
what if we do something like oceanic does @austere talon
it's a linked role that's given automatically
shell shuttle
please do not discuss cybercrime in the vencord vendor venchor server
sorry
limber skiff
contributor role?
yeah
quick isle
running pnpm inject triggers windows antivirus?
golden gulch
running pnpm inject triggers windows antivirus?
probably because injecting into another application's files is a pretty suspicious thing to do
and malware the modify's discord's data to steal tokens isn't uncommon
austere talon
nyonm
quick isle
uhhh
ok i barely have any idea what im doing
where does the arguments[0] come from?
brazen bone
It's a js builtin keyword
quick isle
ah
austere talon
brazen bone
It's quite useful for things like this but honestly pretty useless other than that, since we have default and rest parameters natively nowadays
quick isle
ok im tryign to fix https://github.com/Vendicated/Vencord/issues/2129
i seem to have found the right part where the typing indicator names are inserted
L, P, D are usernames apparently, not actual user objects
is there a way to trace where O comes from?
brazen bone
Check where it's defined
quick isle
O = g ? [] : r()(o).keys().filter(e=>e !== (null == I ? void 0 : I.id)).reject(e=>x.default.isBlocked(e)).map(e=>M.default.getUser(e)).filter(w.isNotNullish).map(e=>F.default.getName(t, this.props.channel.id, e)).value()```so patching it would involve getting the user and replacing O i guess?
austere talon
ah it's only doing it if one user is typing, not if 2 or 3
brazen bone
Patch that getName call perhaps
austere talon
```
O = g ? [] : r()(o).keys().filter(e=>e !== (null == I ? void 0 : I.id)).reje...
you could replace the F.default.getName call here, but that only gives you the ability to return a string
if you want to have the proper formatting with different colour and the (), you'd need to do it differently
quick isle
oh ok
proper formatting would require replacing the whole span with multiple i presume?
and then rewriting all of their logic for multiple people
brazen bone
Why would getName only be able to do a string?
austere talon
because you're using the values of o inside the LOCALE_MESSAGE.format()
which does string interpolation iirc
brazen bone
You are already replacing the value sent to .format() though
quick isle
ok im tryign to fix https://github.com/Vendicated/Vencord/issues/2129
i seem to ...
o is passed into e which formats the names into a string
and e is the value of the span
austere talon
btw have a look at TypingTweaks it changes the same code to inject avatars
you'd likely need to do something similar to it
surreal fiber
I wish the users typing thing wasn't the way it is.. I've tried to make it nicer looking with css but the way it works makes it impossible to make it perfect.. what I mean is with my font the spacing is all weird and if I force spacing on the usernames, when there's a comma it also gets a space and there's no workaround
quick isle
well by default it's just one span so you cant do much with it
surreal fiber
it would also be cool if there was a way to just show everyone always and not that "and 4 more users" or whatever
austere talon
well by default it's just one span so you cant do much with it
doesn't it have strongs for the usernames
surreal fiber
yes
austere talon
so seems like MESSAGE.format() returns an array of react nodes
quick isle
oh maybe yeah
austere talon
it would also be cool if there was a way to just show everyone always and not th...
that's already a thing
in typingtweaks
surreal fiber
wait what
austere talon
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/typingTweaks/index.t...
**index.tsx: **Lines 45-52
export function buildSeveralUsers({ a, b, count }: { a: string, b: string, count: number; }) {
return [
<strong key="0">{a}</strong>,
", ",
<strong key="1">{b}</strong>,
`, and ${count} others are typing...`
];
}
it's not that elegant if you use non english discord cause then the several users typing is english while the other messages are your native language
but yeah
surreal fiber
yeah I have that option enabled, but yeah I mean if 13 people were typing I'd like it to just show all of them
quick isle
won't be too bad in most cases
brazen bone
Showing 50 users would be pretty bad
gritty iris
I want 100 avatars if 100 people are typing 🤡
gritty iris
I think 5 would be good enough no?
austere talon
maybe a dropdown thingie
brazen bone
Configurable
austere talon
where you can hover to see a vertical list of other people typing
like if you hover "and 32 others" it shows the people
as a tooltip
quick isle
honestly i wouldn't mind if it was just a long list that was clipped at the end
brazen bone
If nobody else claims it I might give that a shot later
As part of TypingTweaks obviously
austere talon
too bad im not on my pc or i would make a silly mockup of 100 people typing
brazen bone
Just grab a pen and paper
surreal fiber
honestly i wouldn't mind if it was just a long list that was clipped at the end
yeah I'd like this tbh
gritty iris
I can see it now just 100 random people as a drop-down lol
brazen bone
An issue with 100-people-are-typing is that it tends to move insanely quickly
gritty iris
True if 100 people were typing it would flux between 90-110 actually
As an estimate for activity atleast from my prior knowledge
Imagine how fast the avatars would disappear from the dropdown
lime stone
for?
sorry for necropost but you should probably use venbot to give the contributor role instead of the new linked role feature
(it's not very good iirc, but also you can't manually add and remove the role which could be an issue?)
dusk blaze
(it's not very good iirc, but also you can't manually add and remove the role wh...
vroles command
would allow for example showing/hiding your donor/contrib roles
and maybe an API to hide the contrib badge
lime stone
would allow for example showing/hiding your donor/contrib roles
no, once a role is a linked role admins can't take it off people
shell shuttle
that's it
i keep seeing replies to that one commit
mods i would appreciate it if this could get deleted
brazen bone
Pretty harmless imo
shell shuttle
i mean yeah but
wrong account 
that account is basically unused now
and i don't want traces back to it
brazen bone
The stars are spammier
shell shuttle
true
austere talon
and maybe an API to hide the contrib badge
you can already do this
by setting a boolean in your dev object
austere talon
<a:NekoVeryShy:1224722938289193142> mods i would appreciate it if this could get...
sure
how do u accidently reply from wrong account tho 😭
shell shuttle
thank u so much
dusk blaze
can i "real"
shell shuttle
idk i was on mobile and for some reason logged onto that account
dusk blaze
by setting a boolean in your dev object
good to know
shell shuttle
now time for the correct reply
brazen bone
Just your imagination
sterile oak
is anyone notice this? I see my searchs in the local storage in the discord app, what i am concern about that those searchs made in another account in chrome. is this even safe?
brazen bone
Clarify
shell shuttle
is anyone notice this? I see my searchs in the local storage in the discord app,...
what
sterile oak
is anyone notice this? I see my searchs in the local storage in the discord app,...
nah forget this. I was mistaken, when looking into the actual searchStore data. I guess that discord doesn't clear it on switching accounts
searchStore is the thing that saves the servers search history
so make sure to clear it before dying
charred monolithBOT
limber skiff
oh right forgot to push to that branch
shell shuttle
womp womp
crude raptor
is there any reason why you would want to copy a sticker/emote at a lower quality than max
shell shuttle
is there any reason why you would want to copy a sticker/emote at a lower qualit...
- because it would be funny
- might hit max file size (rare occasion)
crude raptor
file size? sorry- it might not fully understand what that plugin does
shell shuttle
file size? sorry- it might not fully understand what that plugin does
??????
crude raptor
the plugin just clones directly to your server no? shouldn't have any issue with filesize unless discord suddenly runs out of CDN space?
shell shuttle
the plugin just clones directly to your server no? shouldn't have any issue with...
nah what i mean is
emotes have 256kb hard limit (they don't compress anymore, 257kb emotes don't fucking upload)
and stickers have 512kb limit
if you upscale it, wouldn't it increase the size?
charred monolithBOT
crude raptor
oh fair enough
maybe the plugin could automatically copy at highest allowed quality
austere talon
- because it would be funny
- might hit max file size (rare occasion)
the plugin could handle this automatically
if it errors with too large it can decrease size until it works
also fyi discord doesn't upscale, so if the original emote is 128x128, even size=4096 will still be 128x128
shell shuttle
the plugin could handle this automatically
if it errors with too large it can d...
ooooh
austere talon
there shouldn't be a case where a sticker is too large to upload
so i doubt you need to handle it
but emotes might be too large
austere talon
ages ago you could upload larger emotes
so old emotes might be bigger
i have a 1mb emote
shell shuttle
i wish they brought that back
i have to run emotes through 3 different compressors
woeful bisonBOT
austere talon
https://cdn.discordapp.com/emojis/393687671144185856.gif
1.16mb
shell shuttle
DAMN
austere talon
funny that it doesn't embed
austere talon
yea
shell shuttle
was it created using an api request or directly through the upload emote button
shell shuttle
rip
also there's a bug where for some reason the ability to choose my server disappears when there's 10 emote slots left
40 normal
31 animated
(i'll try to fix this when i get home 
)
austere talon
limber skiff
doesn't happen for me
rugged spire
yeah
warning: linked roles cant be applied manually
so this will remove contributor from a lot of people
spark pivot
warning: linked roles cant be applied manually
so this will remove contributor f...
It would make sense to also add a command to control the role (if possible)
rugged spire
It would make sense to also add a command to control the role (if possible)
doesnt that already exist in @nimble pendant
rugged spire
Does that actually work?
charred monolithBOT
austere talon
why does he talk different this doesn't seem like arjix
charred monolithBOT
shell shuttle
OBAMA INTEGRATION??
median rapids
we're so barack
shell shuttle
bruh whaaat
charred monolithBOT
quick isle
?
dapper crest
If that plugin gets good I will definitely start using ollama more
austere talon
?
overriding properties on discords structures might cause issues so we generally try to avoid it
brazen bone
MessageLogger does it though
charred monolithBOT
austere talon
oh is this actually SHC bug #🏥-vencord-support-🏥 message
rugged spire
oh is this actually SHC bug https://discord.com/channels/1015060230222131221/102...
Based on having to disable SHC for issues trying to rearrange channels in the past, I would believe this is real
quick isle
overriding properties on discords structures might cause issues so we generally ...
wait i removed that part though
originally i was just adding a nick property to the member object
i switched to using GuildMemberStore to get the nick later on, when the actual names are rendered
is there something wrong with that method?
lime stone
Code reviews are so much more organized
actually it doesn't make much sense to write suggestions under the settings declaration
glass jasper
Yippe, i can still main canary
shell shuttle
mortal fractal
packId: (0,A.isStandardSticker)(e) ? e.pack_id : "TODO - fix",
charred monolithBOT
rugged spire
Is this ever used anywhere else? https://github.com/Vendicated/Vencord/blob/main/src/api/Commands/index.ts#L28
grave mangoBOT
Is this ever used anywhere else? https://github.com/Vendicated/Vencord/blob/main...
**index.ts: **Line 28
export const commands = {} as Record<string, Command>;
austere talon
Is this ever used anywhere else? https://github.com/Vendicated/Vencord/blob/main...
wdym??
it's the object used for storing commands
rugged spire
is it referenced within a patch
nop
i ask because https://github.com/Vendicated/Vencord/blob/main/src/api/Commands/index.ts#L27 seems to be used instead
grave mangoBOT
i ask because https://github.com/Vendicated/Vencord/blob/main/src/api/Commands/i...
**index.ts: **Line 27
export let BUILT_IN: Command[];
limber skiff
oh there is stuff broken
rugged spire
oh ok
gritty iris
oh there is stuff broken
I was right!!!
charred monolithBOT
charred monolithBOT
Adds the nifty mobile feature to copy the message contents (including formatting such as boldness, headers, and mentions).
Message button:
Results: plugin (left) vs selecting and copying (right)
brazen bone
Hm, okay
charred monolithBOT
shell shuttle
omg same
charred monolithBOT
charred monolithBOT
fair wolf
Should I even report bugs about the hidding blocked messages plugin
bcs it has a few, some relating to other plugins and others that i think would take too much to fix
charred monolithBOT
charred monolithBOT
charred monolithBOT
topaz spoke
why are these strings being concatinated||?|| ?
in https://github.com/vendicated/Vencord/blob/main/src/Vencord.ts#L52-L53
limber skiff
easier to read
mortal fractal
if you didnt delete your original messages you couldve just reacted with ❌ to delete the code preview
charred monolithBOT
limber skiff
if you didnt delete your original messages you couldve just reacted with ❌ to de...
that's neat
limber skiff
just delete it manually lol
topaz spoke
if you didnt delete your original messages you couldve just reacted with ❌ to de...
oh, didn't know that, thank you for the tip
mortal fractal
@lime stone i know i should make it automatic but its a conceptual pain because of "do i only do it for with in the lifespan of the bot's session or do i deal with database shit"
lime stone
after restarts doesn't matter
you probably don't want to data to exist forever anyway
maybe just keep it for 30 minutes
charred monolithBOT
limber skiff
guh
frail skyBOT
frail skyBOT
shell shuttle
me forcepush jumpscare
AAAAH jumpscare
austere talon
me forcepush jumpscare
i love that it makes it look like im just randomly force pushing out of nowhere to troll nookies
limber skiff
it's because you are...
rugged spire
I am rewriting a plugin, and I have also stumbled upon another plugin using DataStore for stuff I would expect to consider as "settings that should be synced but aren't" purely because they use an array
or some other special object
Plugins in question being MessageTags and TextReplace
lime stone
I am rewriting a plugin, and I have also stumbled upon another plugin using Data...
I think it uses DataStore cos the list can potentially get large
rugged spire
I think it uses DataStore cos the list can potentially get large
How much of a risk is it to store dozens of kilobytes directly into a settings entry?
lime stone
a 33% risk
shell shuttle
am i uhhh
able to mark myself as a contributor
idk if it's like
important enough or something
but i wanted to ask
charred monolithBOT
golden gulch
going to do a silly and review some prs
rugged spire
have fun
golden gulch
will approve ones that I fully understand and look alright 
golden gulch
i do think it's funny how github displays reviews from people not associated with the project though
like it's official but it's actually not in any way
brazen bone
No reason you can't hop into some random project somewhere, review a couple of prs, and then never be seen again
austere talon
autumn always makes good prs 
golden gulch
vee do you have a merge schedule/plan or do you sorta just do it whenever you feel like it
(mostly just curious, I don't think it matters whatever you do)
jagged cloak
latter usually
austere talon
vee do you have a merge schedule/plan or do you sorta just do it whenever you fe...
whenever i feel like it for new features
asap for fixes
but also im on vacation rn so neither for now
rugged spire
very good idea @golden gulch
golden gulch
charred monolithBOT
oak hull
charred monolithBOT
Updated the hidden channel function to show unread channels in collapsed categories; better mimics the behaviour of collapsing categories in servers and gives you more visibility on chats you may want to respond to, along with the option to leave a chat visible by marking messages as unread :3
Also fixed a few issues in relation to hidden channels:
- Active channels in the DMs section w...
charred monolithBOT
charred monolithBOT
analog knoll
This might not be specific to Vencord development, but I'll ask here anyways - Recently I tried ncspot (terminal music player that connects to Spotify). I enjoy showing the song that I am currently listening to as my discord status - so I did research on how to do it. I found out it works well with dbus on linux, but couldn't find any alternatives for MacOS. Could I ask if there's anyone knowlegeble about these things,.. RPCs and such. Does Vencord/Vesktop reimplement any of such logic to make this stuff work?
analog knoll
This might not be specific to Vencord development, but I'll ask here anyways - R...
If I understand correctly Discord (or electron for that matter) opens an RPC port locally that apps that want to support such functionalitites talk to and dbus is here to redirect it to the correct port (because the app has to be versatile and not only work with discord). I am I wrong?
quick isle
since monaco still doesnt support newer css features (https://github.com/microsoft/monaco-editor/issues/4071), would it be worth using the temporary workaround of setting the editor language to scss? doing this seems to get rid of error highlighting with stuff like nesting and oklch
austere talon
absolutely not imo
that will also add other scss feature highlighting and such
it seems like a really easy fix just need to bump the npm package
i might try doing it myself and maybe we can use a custom build
still wasp
autumn always makes good prs <:MenheraFlower:1225158450116563076>
I read that as autism
quick isle
that will also add other scss feature highlighting and such
i'd rather have that over valid css being errored tbh
quick isle
i might try doing it myself and maybe we can use a custom build
but yeah this is a better solution
verbal pumice
can probably be the same plugin tbh
heavy cedar
yeah i think
verbal pumice
or an option
verbal pumice
ig
median rapids
nah separate plugin is better
charred monolithBOT
Before:
After:
I made it so modifying initialValue from the parent will cause a re-render anyway, since otherwise, you would only be able to change the textbox's contents through onChange
I think externalValue would be a better name now bc you can ...
spark pivot
since this problem is relevant again- I wanted to bring up that checkedtextinput was designed to not let you change the value externally
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/components/CheckedTextInput....
**CheckedTextInput.tsx: **Lines 22-26
interface TextInputProps {
/**
* WARNING: Changing this between renders will have no effect!
*/
value: string;
yo lemme test ur change rn
spark pivot
i believe i tested it and it worked
heavy cedar
it has the side effect where it won't let u type anything if there's an error
heavy cedar
but ven said it broke cloudsync or something
i think i'll turn this into a draft pr and figure out another way to do it
spark pivot
idek at this point
either way this problem would only be fixed by changing CheckedTextInput
heavy cedar
^^
still ended up doing useeffect
i feel like this change is kinda cheeky but there aren't any bad onchange triggers anymore
jagged cloak
thats so derp
rare shale
you will probably husk but steam hardware survey styled info about what plugins are mostly used?
when you log in every month or so, itll pop up with a question if you want to share the info
so its opt in
rare shale
yop
wary dew
@golden gulch uh, so my github account got suspended and they didn't even give me a reason for it. So, expect another pull request from me if they don't unsuspend it
😭
wary dew
ik, it might have something to do with github sponsors since i ghosted stripe
charred monolithBOT
austere talon
<@250322741406859265> uh, so my github account got suspended and they didn't eve...
wait wtf!??
wary dew
wait wtf!??
yeah
they wont even tell me what i did
i just randomly got suspended
i was literally in the middle of using it then i got logged out, so i tried logging back in and i got terminated
still wasp
Sned
wary dew
did u sned appeal alresdy
yeah
its stupid how they remove literally every pull request from your account
austere talon
well cause normally you get banned for abuse
if they unban you they will probably restore your prs
charred monolithBOT
austere talon
there's no reason why someone shouldn't be allowed to use github just because they're transphobic
as long as they don't harass other users
charred monolithBOT
quaint sapphire
there's no reason why someone shouldn't be allowed to use github just because th...
There are clearly worse things allowed on GitHub, like open source credential stealers, or open source spyware
And it ain't against GitHub TOS because they are not maliciously hidden.
median rapids
yeah github should really not be banning people based on that
and they don't tbf to them
lime stone
there's no reason why someone shouldn't be allowed to use github just because th...
but i've seen people get perma banned for doing seemingly nothing
and this person got banned for a while and got unbanned so it's super weird
lime stone
(I'm not disagreeing as such, it's just kinda weird -- also their transphobia was in a gist comment on github and it remained deleted)
charred monolithBOT
findByPropsLazy makes the properties of the lazy object also lazy, but that doesn't work for primitives bc Reflect.get can't be run on primitives
Before:
After:
charred monolithBOT
charred monolithBOT
limber skiff
OHHH
limber skiff
this is the wrong fix but I may be able to fix other issues with
the main problem here is that component file is only required when you open the tab, so it turns out the AppStartPerformance proxy is accessing the props in the same tick
so this logic is being used, when it shouldnt
austere talon
yeah its not correct fix
that change seems really wrong i dont really understand what they were going for
austere talon
wtf is proxyInner
limber skiff
that's for the branch where finds use wait for internally
I was testing the fix there cuz I had a case where a primitive gave me issues
median rapids
this entire file scares me
limber skiff
how does their fix even work lmao
limber skiff
like this doesnt even access the prop
"string".toString turns into () => "string"
@heavy cedar do the change I suggested and I can merge
your fix not really correct but I will credit you anyway
limber skiff
should be redo but whatever
limber skiff
you just return the value of the prop or the function binded
instead of calling Reflect.get on the primitive
limber skiff
look here
radiant reef
limber skiff
you cant proxy primitives
I found out today you can
austere talon
no you cant
limber skiff
test it, it works
austere talon
