Just rewrite the whole thing from scratch, no biggie
#👾-core-development
brazen bone
spark pivot
SettingTextComponent does the same thing lol
i feel like it's kinda unnecessary to make a whole css file for one class with one attribute
brazen bone
Then check if discord already has a class for that I guess
spark pivot
porbablyt
brazen bone
Would be surprised if it doesn't
I do agree that single-rule sheets does feel a bit silly, but classes do have benefits regarding theming
spark pivot
oh nvm found a css file that is related to the components im working in
i'll just put it in that
i just didnt want to make a whole new css file
turbid hatch
spark pivot
this person also thinks that you can just
- "electron": "^28.1.3",
+ "tauri": "whatever"
charred monolithBOT
austere talon
SettingTextComponent does the same thing lol
then refactor it. a bunch of our code is legacy code from when we didn't have native css support
charred monolithBOT
austere talon
i feel like it's kinda unnecessary to make a whole css file for one class with o...
- then don't?
- why? it doesn't matter much
austere talon
the point is that inline styles are meh and awful for themes to override because they have to spam !important
v+ programming @bleak gyro
bleak gyro
thank you
uncut glen
vee its not ment to show the google in the plugin in the end we just made it as more engines to use
bleak gyro
okay so an idea for third-party resources is (amazingly draw by moxxie)
we might not need the filters on the side since from what we've thought of there are only 2
uncut glen
im a grate artist and i can totally spell fr fr
lime stone
why did you star your own message
brazen bone
Why didn't you?
uncut glen
why did you star your own message
if you star your own msg it will make ppl want to star it fr fr
lime stone
vee will take down starboard machine again
charred monolithBOT
charred monolithBOT
charred monolithBOT
rugged spire
for context as to why this needs a 
:
#🏥-vencord-support-🏥 message
then spends 30 minutes signing up to github
only to post this shit that doesnt include logs because of course not
explode please
charred monolithBOT
brazen bone
Very nice branch names, mcpower:push-znykrnwkpypw mcpower:push-ymqkwqwlyrmr mcpower:push-quorwosyorxo mcpower:push-otqpxxlwqnuk
shy veldt
yeah
brazen bone
Okay that's a pretty weird bug in FastMenu/BetterSettings... Why does changing the name of a role make the left sidebar disappear
charred monolithBOT
brazen bone
Cause found... Attempting to rectify
brazen bone
Right, fixed. What was I thinking when I wrote that patch like that
bleak gyro
How could I improve this?
ill probably add something like "Copy this content and put it in your Quick CSS file"
crude raptor
would there be any way to have a simple button to auto-append it to your quickcss?
bleak gyro
That could be a great feature
brazen bone
Alternatively, have a link to the raw css that you can put in the themes list (and maybe a way to automatically add it there)
austere talon
i have a cool idea for fakenitro maybe @limber skiff
it could let you use emotes from anywhere
like you just copy paste an emote and it sends it even if youre not in that server
you can already do that by copying the emote link when someone else sends it but it doesnt get the fakenitrogoodies like name
crude raptor
right clicking an emoji or /emojis/ embed could have an option to store the link locally as a pseudo-emote-server
limber skiff
like you just copy paste an emote and it sends it even if youre not in that serv...
and how do we get the emoji info
limber skiff
you are right, none actually
austere talon
the emoji code is everything thats needed
limber skiff
so you mean like our own emote browser
austere talon
noo
limber skiff
okay I dont quite get it
crude raptor
it likes its idea :3
crude raptor
vee's idea is basically just let fakenitro use emojis that other people have posted, not just from your servers
it thinks itd be cool if you could also store a local list of emoji links and names by right clicking
limber skiff
oh yeah it's very doable
emoji links don't even need the guild id
I think we just need to modify the preSend a bit?
austere talon
it thinks itd be cool if you could also store a local list of emoji links and na...
i dont understand the use case. just make a proper server and use emotecloner
crude raptor
idk saves making a server
limber skiff
@austere talon btw if you plan or merging something, merge to dev2 since it already has commits we need to merge too
austere talon
merge dev2 into dev1
limber skiff
sure
austere talon
🐝
austere talon
oh not those
austere talon
not the webpack changes
limber skiff
they work fine
may prevent us future issues
specially reporter related
let me reset to previous commit for now
wtff lma
how did I not notice that
austere talon
brazen bone
Isn't it easier to use like an interactive rebase for that
charred monolithBOT
austere talon
please format your commit messages like PluginName: message
limber skiff
ye
austere talon
you should rebase your webpack changes in a different branch and make them a single commit
limber skiff
aight
austere talon
i need to properly look at them first
austere talon
Webpack: Refactor for future proofing
- Rework how webpackRequire is grabbed
- Add beforeWebpackInit and factory listener apis
- Future proof extractAndLoadChunks & reporter
charred monolithBOT
median rapids
@limber skiff as promised 
i have no idea how to fix the message history thing though
median rapids
charred monolithBOT
spark pivot
i just thought of something
what if there was a button in css code blocks that just adds the css to your quickcss
brazen bone
So you mean like, I write ```css
- { transform: rotate(1deg) !important; }
That'd be cool
spark pivot
yeah
crude hearth
<@235834946571337729> as promised <:meowlien:1116579379535937536>
OH MY GOD
DOLFIES HOLY SHEET
wait
dolfies pred before too
I always thought you as a person that is too busy with other stuff so you couldnt pr ever
median rapids
charred monolithBOT
charred monolithBOT
median rapids
this is terrifying
charred monolithBOT
(Resubmission after requested fixes)
Encryptcord allows you to have an end-to-end encrypted conversation with your friends by simple clicking the lock icon in your chatbar:
The system uses a 4096 bit RSA keypair to ensure that your message is safe. The keys are regenerated after every restart.
limber skiff
this is terrifying
why is it haha
median rapids
just force push to main
man i love how all the app command search stuff is still in the client
despite that backend service being deactivated
rugged spire
what fucking branch are y'all even supppsed to base your new stuff on
limber skiff
how do you even find that stuff
rugged spire
despite that backend service being deactivated
what?
median rapids
how do you even find that stuff
search for Endpoints.APPLICATION_COMMANDS_SEARCH
limber skiff
yeah but I mean why are you looking into that?
limber skiff
what fucking branch are y'all even supppsed to base your new stuff on
dev or main
median rapids
oh ran into it accidentally lol
limber skiff
I see
austere talon
what fucking branch are y'all even supppsed to base your new stuff on
pick the weirdest branch you can find
glass jasper
pick the weirdest branch you can find
based
rugged spire
pick the weirdest branch you can find
commit to my personal stable branch in my own fork directly and PR all my fucked up code to upstream
rugged spire
Slight Mistake
austere talon
that plugin won't be merged anyway
median rapids
rugged spire
let me guess, hacky
median rapids
yeah i don't think this is a concept that works very well lol
austere talon
sending encrypted text files on discord is kinda insane
and you can't prevent discord from being able to mitm
rugged spire
@jagged reef userplugin time
rugged spire
and you can't prevent discord from being able to mitm
very true
median rapids
(unless a bot or someone with an older client joins)
austere talon
and you can't prevent discord from being able to mitm
unless you add like some key verification process
median rapids
oh actually did that even roll out lol
glass jasper
<@761777382041714690> userplugin time
certainly something I’d might use if it was a third party
austere talon
but even then you would never be able to prevent discord from accessing the key if fhey really wanted
median rapids
certainly something I’d might use if it was a third party
what is the usecase for this
brazen bone
I bet shoulder surfing is a bigger security issue than mitming
rugged spire
I bet shoulder surfing is a bigger security issue than mitming
Agreed
The shit I say on Discord would horrify people IRL
brazen bone
Oh don't worry I'm sure it horrifies people online too
rugged spire
Oh don't worry I'm sure it horrifies people online too
Real
crude hearth
sending encrypted text files on discord is kinda insane
Lets be real will they write specific code to do that
rugged spire
HEARTWARMING: User discovers their issue is unrelated to the project by themselves
jagged cloak
lol
crude hearth
hyprland users:
jagged cloak
hyprland users are an even smaller subset of people than arch users
crude hearth
I am not fatphobic but hyprland users are really something else
limber skiff
@median rapids it's actually so shit to fix the home issue with server guide
it's a single boolean, but adding a second thing to the channel list for the home/server guide to appear at the same time is horrible
the fact they share the same route 💀
brazen bone
Add a new path to the router 
charred monolithBOT
rugged spire
channel tabs if it was epic
limber skiff
@median rapids this took more than an hour but I fixed request spam for the home
turns out when LOAD_MESSAGES_SUCCESS is dispatched, if isBefore or isAfter are both false, it resets the cache
and the focusMessage function which the home uses fetches messages around an id, but since it tries more than one message in the same channel it would reset and clear the messages previously fetched
the fix... add a before which is the same id as the message 💀
austere talon
HEARTWARMING: User discovers their issue is unrelated to the project by themselv...
people really love blaming vencord for every single issue that arises #🏥-vencord-support-🏥 message
this is like the 20th complaint about listen along not working
austere talon
you'd think people would at least put in the minimum effort of testing if the issue also happens on stock discord but no
rugged spire
i'm playing around with channel tabs Thinkies
this is fine
i just had an awful fucking idea
holy fuck the existing code is already just as fucked up as my idea
cool vencord facts: someone has already made a hackier plugin than you
shit is fucked
limber skiff
what is?
rugged spire
my attempt to inject channeltabs instead of the titlebar and update it properly
limber skiff
I mean dont you just need to change where it patches
limber skiff
just useStateFromStore with SelectedChannelStore
charred monolithBOT
rugged spire
still fucked up
charred monolithBOT
rugged spire
just useStateFromStore with SelectedChannelStore
yeah this worked
lime stone
what about it
if you do this it won't support linux
rugged spire
should've listened
rugged spire
if you do this it won't support linux
Just override the entire switch statement deciding which titlebar to use
lime stone
linux doesn't have any titlebar though?
i don't think mac does either nvm, there's probably a drag area
rugged spire
it does a check even if there is no titlebar applied in the end
rugged spire
please rate my custom titlebar
brazen bone
Change the background to some sick flames and it'll be 33% more rad
median rapids
the fix... add a before which is the same id as the message 💀
you're a genius
median rapids
<@852892297661906993> it's actually so shit to fix the home issue with server gu...
yea idk if this one's possible 😔
maybe a setting to just outright replace server guide with home is better
or a toggle when you right click
rugged spire
Good luck installing it
You can blame the upstream channel tabs devs for that
limber skiff
or a toggle when you right click
okay that's not a bad idea
I think it uses a hook so we can change the value and the button will update
but if it doesn't we can make the function do
rugged spire
You can blame the upstream channel tabs devs for that
git conflict hell on a branch with 200+ commits
rugged spire
please rate my custom titlebar
Thinkies Still needs some work
limber skiff
@median rapids we can add a context menu check mark to force useCanSeeOnboardingHome to return false
it's a hook so if we add a state and update it accordingly, server guide will turn into home and vice versa reactively
limber skiff
seems doable, but I wont do it rn cuz sleep
rugged spire
what is this
lime stone
channeltabs
lime stone
i made it look nice but since then it has become very inconsistent
charred monolithBOT
median rapids
<@852892297661906993> we can add a context menu check mark to force useCanSeeOnb...
amazing
gn 🥰
charred monolithBOT
charred monolithBOT
glass jasper
@still wasp weren’t you working on a sticker blocker?
charred monolithBOT
charred monolithBOT
brazen bone
I keep seeing terms like upsell and sku in the code. I assume upsell is related to nitro shilling, but wtf is a sku
limber skiff
related to decorations
it's something to do with their identification
that's all I know
brazen bone
Oh there's docs https://discord.com/developers/docs/monetization/skus
brazen bone
So marketing stuff, nothing to care about
limber skiff
upsells is related to nitro ads maybe?
brazen bone
Well, I'd assume the term refers to selling something
limber skiff
yeah makes sense
austere talon
upsell is basically just nitro ads yeah
brazen bone
So eliminate on sight but otherwise not worth caring about
austere talon
upselling is a sales technique where a seller invites the customer to purchase more expensive items, upgrades, or other add-ons to generate more revenue. while it usually involves marketing more profitable services or products,[1] it can be simply exposing the customer to other options that were perhaps not considered
so like when you open someone else's profile and it says "wow such a shiny banner don't you want one too?"
that's a nitro upsell
rugged spire
please rate my custom titlebar
I am still super proud of this despite it being super jank under the hood
median rapids
related to decorations
sku is a LOT more
they were first used for the game store
then billing was rebuilt untop of them
then server subs was hacked into them
then server products
then app subs
then avatar decos
then profile effects
etc...
limber skiff
yeah it makes sense from the docs
I mentioned decorations cuz I reviewed decor so I saw them being used
charred monolithBOT
still wasp
<@976176454511509554> weren’t you working on a sticker blocker?
https://discord...
Yeah its fully finished but I lost motivation because of a bug
rugged spire
i wonder what my custom channel tabs looks like on my desktop
channel taaaaaaaaaaaaaaaaaaabs
rugged spire
Refactor shit code time
limber skiff
@median rapids https://github.com/Vendicated/Vencord/pull/2232/commits/9f33c5e6f7ddfd1a0f4c66e9afcb2dca97f2779f
alien jumpscare
tell me if everything is good and I can merge
still wasp
Yeah its fully finished but I lost motivation because of a bug
WHY HUSK ME
I'M LAZY
💀
limber skiff
what was the bug?
still wasp
what was the bug?
When you unblock a sticker in the settings ui, it stays there until you refresh
I couldn't figure out how to re render the component lmao
limber skiff
hmm
it's prob an issue with how the Datastore is async
I don't know how you did, but I recommend having a cache and use it to render the components
so you always update the cache and later update the datastore async
still wasp
Oh i didn't think of that
NEVERMIND I AM AN IDIOT 
I was calling the update function before the sticker was unblocked 
limber skiff
lol
still wasp
Works great now 
limber skiff
rugged spire
I decoupled my titlebar from the channeltabs component please judge :)
https://github.com/Sqaaakoi/Vencord/commit/2c069d395cb332679daae307f4fe1f39a9c10c3c
This is absolutely horrible so far btw
yet it looks so clean
rugged spire
very true
i hang around here, #🧩-plugin-development and #🧊-off-topic-iceman-only, occasionally i might dip my eyes into #🏥-vencord-support-🏥 and if it isn't too brain rotting, say something
limber skiff
yeah I help in support sometimes too
rugged spire
sometimes
brazen bone
That place is too braindead for me
odd heath
Yeah occasionally ill be in support too but rarely
I've gotten enough damage from support channels
rugged spire
Pro tip: Copy random bullshit
brazen bone
Well yeah that's why discord's code is there
But why the leading comma format
It's ugly
rugged spire
But why the leading comma format
That's how it was when I stole it from DevTools
brazen bone
Consider rewriting your code into something human readable after copypasting
Got a really nasty case of comma operator there
rugged spire
Badge Obtained
charred monolithBOT
median rapids
tell me if everything is good and I can merge
looks perfect
hm the jumping to message when clicking is still slightly broken
but it works if you click if a couple times 😭
limber skiff
but it works if you click if a couple times 😭
it's okay normal messages are like that too😂
brazen bone
Now that's how you report a bug
Find a year-old merged PR and provide no relevant details
crude raptor
true
mortal fractal
rugged spire
what commit did you base on
Latest channeltabs branch but I did WAY too many changes, including that
lime stone
so you reverted the style changes?
that's how they looked before my commit to make them firefox style xd
firefox style just makes more sense because it's impossible to make them look attached due to the multiple colours
looks so weird
but at least the height is back to being consistent
charred monolithBOT
rugged spire
that's how they looked before my commit to make them firefox style xd
Can you link your commit? I reparented the actual clickable tab to contain the information instead of tab with button information
Sorry if this makes no sense I am running on not enough sleep
lime stone
Can you link your commit? I reparented the actual clickable tab to contain the i...
since then tabs started having inconsistent height :(
but in that commit i changed the tabs to be rounded on all sides
rugged spire
How much of ChannelTabs was removed and forgotten about since then
lime stone
wdym
rugged spire
Native discord experiment favourites support got completely removed in favour of the favourites bar
Leading to broken display when in the favourites experiment
Take your time with your long message
lime stone
it's not long (ocd moment)
rugged spire
That's also fine
lime stone
xd
i'm confused whether you're on an old commit or reverted the tab changes
oh i think you said you did
rugged spire
I reworked it to effectively make the button hitbox bigger
The tab style could be a setting
lime stone
well, i thought firefox style was a more sane default - and you can use css
doesn't middle click close tabs anyway
other tweaks look cool though
rugged spire
doesn't middle click close tabs anyway
thats not what I changed
lime stone
ohh
rugged spire
Each tab is now just a button itself instead of a div containing the button to activate it
rugged spire
It's visually no different the way I have styled it, but you can FEEL it.
In other words, you can throw your cursor to the top and actually click the tab
verbal pumice
Native discord experiment favourites support got completely removed in favour of...
it wasn't removed because of the favorites bar, it was removed before adding it because it was a broken mess even beforehand
lime stone
It's visually no different the way I have styled it, but you can FEEL it.
In ot...
make the hitbox extend outside the actual area like firefox then
i mainly use gnome and macos so throwing cursor to top places your mouse on the time etc. xd
rugged spire
make the hitbox extend outside the actual area like firefox then
Thats what I did...?
rugged spire
it wasn't removed because of the favorites bar, it was removed before adding it ...
Sounds about right
charred monolithBOT
charred monolithBOT
rugged spire
o o o o o o o i am answering stupid issues
rugged spire
thank you vee
lime stone
it was probably mute
lime stone
the folder treats muted guilds as read
charred monolithBOT
limber skiff
@austere talon any idea how to fix states in our context menu patches not updating the components? I think it has something to do with the context we call the patches, like if they arent in react or something
you know more than me about react so perhaps you have an idea
austere talon
<@343383572805058560> any idea how to fix states in our context menu patches not...
could you explain a bit deeper?
or show a code example
limber skiff
yeah
say I have this patch
if I click the checkmark it doesnt re-render the checkmark as checked
austere talon
well the way the api works the func is only called once per identical children array
austere talon
you'd need to not use the callback
and even then it might not work
at this point it might be a good idea to patch the menu api to add our own menu item component so we can use a proper component with state and not have to do this cursed workaround
brazen bone
You could add a custom component to the menu that wraps a MenuCheckboxItem and has hooks
limber skiff
this is shit
maybe there is a better place to patch
hmmm but I see what yall mean
that could work prob yeah
I'll experiment later
brazen bone
On the other hand, the menu api only allows a few specific component types, so that probably wouldn't work...
austere talon
that's what i mean by patching it
to add our own component to it
but also i think there's a way to use a custom react component in a menu
brazen bone
There is MenuControlItem
...Why does it use .reduce instead of .flatmap
Discord's menu code, that is
brazen bone
I may be mistaken, but isn't the whole problem with the context menu stuff that it does _patchContextMenu(props); rather than props = _patchContextMenu(props);?
limber skiff
how so?
brazen bone
Mutating the props makes rendering impure, which requires the menu hooks to be run only once, which makes react hooks not work
brazen bone
If you do not mutate the props, this would allow the menu hooks to be run as part of the regular rendering cycle, including react hooks
limber skiff
they already run more than once
however our callback to push items to the children only runs once
because otherwise the menu would get 1000000 copies of the same button
limber skiff
If you say so
I'm not that much of an expert on react to know that deep
but if that does fix the problem, then thanks a lot
okay I cannot find the assets place
brazen bone
I'll have to experiment a bit to know for sure, but I'm pretty sure that is at least part of the issue
brazen bone
say I have this patch
Do you have a repo or similar with this non-working code? Wanna see if my fix does indeed fix it
limber skiff
pull from dev and modify resurrect home
it's pretty easy
you have to remove ContextMenuApi.closeContextMenu();btw
that's the hacky fix for it not updating
ideally the menu should re-render a billion times and our old items disappear
@brazen bone is that what you think it should fix?
brazen bone
Yes
limber skiff
okay don't forget to push the child in the first callback instead of the second
because the second only runs once
just return nothing
if that works we can remove all of that anyways
brazen bone
Though an issue is that many of the patches mutate children deeply, so a shallow clone won't be enough
limber skiff
don't worry about it
use lodash deep clone
only 1 context menu can be open at once anyways
median rapids
brazen bone
Yep, this seems to work; the menu item is not duplicated and the hook works
limber skiff
how did you do?
brazen bone
Pretty much just inserting a deepClone on the props
Though I don't like that; it might break things if some menuitem is passed a ref or something
limber skiff
hm
I think it's fine for now
easier than wrapping components
how does it perform on user settings context menu
that's the biggest I think
brazen bone
I don't notice any slowdown
brazen bone
Sure
If things do need to be done once in the menus, I think that can be done with a plain ol' useLayout or similar
limber skiff
changing the second patch is needed?
brazen bone
Without that, lodash clones the Arguments object into { 0: a, 1: b } instead of [a, b]
limber skiff
horror
brazen bone
Won't be necessary once I make a more fine-grained cloning I think
There we go, this is much more selective about what it clones
Actually on second thought, if something edits a menu in the once part, this will make those edits ineffectual
austere talon
maybe use window.structuredClone instead of lodash if its available
likely a lot faster
brazen bone
That won't work, mdn says structuredClone throws errors on functions
And those menu items often contain callbacks
limber skiff
Actually on second thought, if something edits a menu in the once part, this wil...
the once part will be removed
the only reason it exists is because we were getting duplicates
brazen bone
Yeah but someone would have to go around and clean it up everywhere
limber skiff
yes
brazen bone
Actually wasn't there talk of making a ```js
contextMenuPatches: {
"guild-context"(children, props) { ... }
},
that's no issue
frail skyBOT
limber skiff
I can do it if you don't want to
frail skyBOT
austere talon
Yeah but someone would have to go around and clean it up everywhere
dont worry about refactorsl ike this, theyre really easy and quick to do
unless its like the settings api
brazen bone
Yeah options→settings is a bit overdue
austere talon
Yeah options→settings is a bit overdue
theres not really any benefit to migrating it
so itd just kinda be a waste of time
brazen bone
Perhaps
I haven't really looked into how they differ, I just know that any new plugins should use settings
austere talon
its the same, in fact even the new settings api still uses the options field internally
its just strongly typed instead of typed as any like nookies said, and also more convenient and shorter
brazen bone
I'm not sure how the contextMenuPatches: api would deal with addGlobalContextMenuPatch, but that one doesn't seem to ever be used anyway so
austere talon
also you don't have to repeat your plugin name everywhere (which leads to easy bugs if you try to rename the plugin)
austere talon
I'm not sure how the `contextMenuPatches:` api would deal with `addGlobalContext...
well you could just export some symbol like
contextMenuPatches: {
[CONTEXT_MENU_GLOBAL]() {
}
}
Or just "*"() {}
austere talon
true
but also yeah that api isnt that useful, i cant think of a usecase for it xd
other than debugging ig?
limber skiff
I mean no need to remove it though
brazen bone
In most cases it'd probably be more efficient to just patch the Menu component
austere talon
other than debugging ig?
like a quick addGlobalPatch(console.log)
in console
but other than that i cant think of much
brazen bone
I'm gonna try making the contextMenuPatches: api
Is it just iterate over all plugins or is there some more performant way to do it?
austere talon
we already iterate over all the plugins anyway
check how the flux prop is implemented :p
and replicate
brazen bone
Yeah I figure flux triggers way more often than menu, so if it's fast enough for that
austere talon
or rather change that code to also do the other one
uh what
do you mean whenever a context menu is opened it checks all plugins
dont do that
just keep the old api and make the property a wrapper around it
brazen bone
That makes more sense
Do you prefer contextMenuPatches: or contextMenus: or something else?
austere talon
actually im not really happy with the current flux: implementation
because its done inside startPlugin, which is called very late
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/index.ts#L121-L158
**index.ts: **Lines 121-158
export const startPlugin = traceFunction("startPlugin", function startPlugin(p: Plugin) {
const { name, commands, flux } = p;
if (p.start) {
logger.info("Starting plugin", name);
if (p.started) {
logger.warn(`${name} already started`);
return false;
}
try {
p.start();
p.started = true;
} catch (e) {
logger.error(`Failed to start ${name}\n`, e);
return false;
}
}
if (commands?.length) {
logger.info("Registering commands of plugin", name);
for (const cmd of commands) {
try {
registerCommand(cmd, name);
} catch (e) {
logger.error(`Failed to register command ${cmd.name}\n`, e);
return false;
}
}
}
if (flux) {
for (const event in flux) {
FluxDispatcher.subscribe(event as FluxEvents, flux[event]);
}
}
return true;
}, p => `startPlugin ${p.name}`);
it would likely be good to refactor it to add the necessary subscriptions immediately
but thats a task for a separate pr
brazen bone
Sounds fine for commands and menus, but yeah for flux it'd be good to have it immediately
limber skiff
we could just add the flux listeners when it's waitFor callback is ran
the same place where it sets the export
limber skiff
that's too hacky or not? what do you think ven
brazen bone
Remember to also add the listeners when the plugin is enabled from the menu
limber skiff
true
brazen bone
This also makes a good opportunity to fix a longstanding bug in ViewRaw where the plugin doesn't unregister its context menus properly when disabled
...Oh I'm dumb
The check for whether the once-callback has been run happens after cloning the props, so it's run always
charred monolithBOT
limber skiff
but remove it
brazen bone
Feels silly to remove the check separately from actually removing the callback, which I won't do until I've removed all the () => () => from everywhere
limber skiff
oh yaya
brazen bone
Do you think it's better to have ```js
contextMenus: {
"message": messageContextMenuPatch,
}
like that is fine
but this is good cuz you can type the function
and we don't need to use a const to type anymore
brazen bone
I'll have to move some of the patch definitions to above the plugin definition so it's in scope
That produces slightly bigger diffs than I'd quite like, but no way to avoid it
austere talon
wdym
brazen bone
There was one case where export default definePlugin() was before const ctxMenuPatch: NavContextMenuPatchCallback so I had to move that to be before
charred monolithBOT
Summary
Fetching a user ignores the accent color, banner, and premium type given. We can also deduce nearly all badges from the flags (like it used to work :p, but means the badge text will always be English).
glass jasper
jumpscare
limber skiff
so this just fills the profile info we can deduce from fetching the user?
median rapids
so this just fills the profile info we can deduce from fetching the user?
yea
charred monolithBOT
charred monolithBOT
Using Fedora 39 KDE here. I don't see the notification badge.
Icon from Papirus icon theme.
limber skiff
@brazen bone what's the reason for this check if it's a MenuControlItem, and why not for MenuItem too?
that's my only question, the rest looks good and I did some cleanups already
brazen bone
<@236588665420251137> what's the reason for this check if it's a MenuControlItem...
Discord does not recurse on MenuControlItem, so I do the sane
limber skiff
I don't understand
charred monolithBOT
brazen bone
I don't understand
The MenuControlItem does n.props.children rather than recursing with e(n.props.children) like other cases do
charred monolithBOT
charred monolithBOT
limber skiff
wall of text jumpscare
limber skiff
@median rapids checkout this branch and look at the force server home button working https://github.com/Vendicated/Vencord/pull/2236
it looks even better
because the menu no longer closes
charred monolithBOT
limber skiff
I would say this is a perfect pr to explode
wtf
Discord Development went back to Electron 22
limber skiff
The MenuControlItem does `n.props.children` rather than recursing with `e(n.prop...
can you explain this better, I can't understand why we shouldnt clone that
brazen bone
Because blindly cloning stuff can have weird side effects, like messing up arguments objects and probably breaking react refs
I can't say for certain that anything would indeed break, but I'd rather play it safe and only clone what's necessary
And as mentioned, it's not like window.structuredClone would be of use since that doesn't work on functions, so it's either a custom function or lodash
limber skiff
okay then
we also need to do this
it's likely another case where we do not know what it can be
and the reason for the second predicate
well actually the third is not needed
brazen bone
If we want to be very faithful to discord's code it'd be ```js
if (obj.type === Menu.MenuGroup || (obj.type === Menu.MenuItem && obj.props.render == null)) {
// clone children
}
MenuItem doesnt have children anyways
brazen bone
It does though, that's how you make submenus
limber skiff
I mean
when it has render it doesnt have children
so we dont need the predicate
I think this works, we can change if it causes issues but I doubt it will
as I said the third predicate is not needed because it render is present, then children isnt
brazen bone
I guess (type === MenuGroup || type === MenuItem) && children would be enough
limber skiff
hm okay
brazen bone
But what's going on with this module (the one where MenuControlItem and all that are supposedly defined) ```js
function (e, t, n) {
"use strict";
function i() { return null; }
function r(e) { return null; }
function o(e) { return null; }
function a(e) { return null; }
function s(e) { return null; }
function _(e) { return null; }
n.r(t),
n.d(t, {
MenuCheckboxItem: function () { return a; },
MenuControlItem: function () { return _; },
MenuGroup: function () { return r; },
MenuItem: function () { return o; },
MenuRadioItem: function () { return s; },
MenuSeparator: function () { return i; },
});
};
...I guess those aren't real components, since they just check for identity of the type
» Vencord.Webpack.Common.Menu.MenuCheckboxItem.toString()
function a(e){return null}
``` Yep those are the real definitions, funI sure wonder why they made it in such a convoluted way
limber skiff
it's sad that we have to deal with this cloning stuff
but it's honestly the least hacky way we can have a api which still gets access to the original context menu props
hmm actually
brazen bone
The only alternative I can see is making plugins manually patch each individual menu they need and that's bad
limber skiff
there is another way but it's complicated
need to patch openContextMenu but also need a way for the contextMenuApiArguments to reach it
and we would need to build our menu items manually too
this is okay for now
limber skiff
I guess `(type === MenuGroup || type === MenuItem) && children` would be enough
it's not
for some reason in some context menu items are being duplicated
I'm gonna keep this
seem to work for all
austere talon
I sure wonder why they made it in such a convoluted way
yeah like why not just make the menu components be the actual thing that's rendered
btw it was even funnier back when we had mangled exports so there was no way of knowing which function is which menu item
i wrote a cursed patch that properly named all of them
and nookies and i together wrote a really cursed dynamic patch generator that found all menu api usages in other files based on a minified name
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/1764206e19cfdb7f2a7e69497ab017853e7c9...
**apiMenuItemDeobfuscator.ts: **Lines 41-77
{
find: '"Menu API',
replacement: {
match: /function.{0,80}type===(.{1,3})\..{1,3}\).{0,50}navigable:.+?Menu API/s,
replace: (m, mod) => {
let nicenNames = "";
const redefines = [] as string[];
// if (t.type === m.MenuItem)
const typeCheckRe = /\(.{1,3}\.type===(.{1,5})\)/g;
// push({type:"item"})
const pushTypeRe = /type:"(\w+)"/g;
let typeMatch: RegExpExecArray | null;
// for each if (t.type === ...)
while ((typeMatch = typeCheckRe.exec(m)) !== null) {
// extract the current menu item
const item = typeMatch[1];
// Set the starting index of the second regex to that of the first to start
// matching from after the if
pushTypeRe.lastIndex = typeCheckRe.lastIndex;
// extract the first type: "..."
const type = pushTypeRe.exec(m)?.[1];
if (type && type in nameMap) {
const name = nameMap[type];
nicenNames += `Object.defineProperty(${item},"name",{value:"${name}"});`;
redefines.push(`${name}:${item}`);
}
}
if (redefines.length < 6) {
console.warn("[ApiMenuItemDeobfuscator] Expected to at least remap 6 items, only remapped", redefines.length);
}
// Merge all our redefines with the actual module
return `${nicenNames}Object.assign(${mod},{${redefines.join(",")}});${m}`;
},
},
},
basically it used this type: "control" to know which one it was
limber skiff
this was when we removed the curse
in fact the day I made that dynamic patch was when I learned about proxies
brazen bone
Exports having names is quite convenient
Discord could make this much harder if they wanted
limber skiff
it wasn't that worse
austere talon
it was fine yeah
limber skiff
you just had to guess more
austere talon
**apiMenuItemDeobfuscator.ts: **Lines 41-77
```ts
{
find: '"Menu API',
r...
like this was the only cursed thing
limber skiff
like hmmmm what does this function do
austere talon
and you had to findByCode everything
but other than that it was whatever
oh and their old compiler aggressively merged modules and killed a shit ton of exports
so we often had to use patches just to grab discord functions
while other mods just coped without those modules
limber skiff
findByCode was pretty stable anyways
brazen bone
I guess you still had prop names to navigate by
limber skiff
yeah
austere talon
so we often had to use patches just to grab discord functions
this was incredibly cursed
limber skiff
Decor still does it for some not exported stuff lol
honestly Vencord went to another level when ven made the reporter
it's life saving
brazen bone
Automated diagnostics is always good
limber skiff
but we didn't have webpack finds testing for a long time
only patches and bad starts
austere talon
honestly Vencord went to another level when ven made the reporter
vencord has so many crazy things that other mods don't have
limber skiff
and discord errors which has never been useful besides showing discord shit code when a variable isnt defined
austere talon
we're the future 🚀
limber skiff
and discord errors which has never been useful besides showing discord shit code...
some of the errors I wrote to ignore still happen
and it is not our fault
austere talon
and discord errors which has never been useful besides showing discord shit code...
lmaooo yeah it's mostly useless
but i originally added it to like see if our patches cause errors you know
livid heath
vencord has so many crazy things that other mods don't have
yeah vencord has me 
limber skiff
because the reporter nowdays loads chunks using their entry points
limber skiff
lmaooo yeah it's mostly useless
but i originally added it to like see if our pa...
yeah
if you merge my webpack refactor pr we will be the first mod to use that way of grabbing webpack stuff too
all the rest still push to the array
livid heath
how does the new system work?
austere talon
tbh i love that the webpack runtime is so monkey patchable
i wonder if they did that on purpose
limber skiff
how does the new system work?
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/0aff61cf812090d7b9d2a1ad4e4a9b51a78fb...
**patchWebpack.ts: **Lines 53-96
// wreq.O is the webpack onChunksLoaded function
// Discord uses it to await for all the chunks to be loaded before initializing the app
// We monkey patch it to get immediate access to the webpack require before the app runs,
// and to monkey patch the initialize app callback to run our listeners before doing it
Object.defineProperty(Function.prototype, "O", {
set(onChunksLoaded: any) {
const wreq = this;
// When using react devtools or other extensions, or even when discord loads the sentry, we may also catch their webpack here.
// This ensures we actually got the right one
if (new Error().stack?.includes("discord.com") && wreq.p === "/assets/") {
logger.info("Found Webpack onChunksLoaded");
delete (Function.prototype as any).O;
const originalOnChunksLoaded = onChunksLoaded.bind(wreq);
onChunksLoaded = function (result: any, chunkIds: string[], callback: () => any, priority: number) {
if (callback != null && initCallbackRegex.test(callback.toString())) {
Object.defineProperty(wreq, "O", {
value: originalOnChunksLoaded,
configurable: true
});
const originalCallback = callback;
callback = function () {
_initWebpack(wreq);
for (const beforeInitListener of beforeInitListeners) {
beforeInitListener();
}
originalCallback();
};
}
originalOnChunksLoaded(result, chunkIds, callback, priority);
};
}
Object.defineProperty(this, "O", {
value: onChunksLoaded,
configurable: true
});
},
configurable: true
});
o that's smart
limber skiff
so it's basically
initVencordWebpack()
beforeInitListeners()
callDiscordEntryPoint()
but all with monkey patch
brazen bone
i wonder if they did that on purpose
I kinda don't think so; like if they wanted that, they'd have made .u() a plain object instead of a function wrapping an object which I can only assume is to make it non-iterable
austere talon
wdym?
brazen bone
Not that it works, there are ways to get hold of it anyway
austere talon
i forgot what u is, remind me again
limber skiff
u is the chunk id to asset url map
brazen bone
Chunk id -> javascript asset mapping
brazen bone
Yeah
limber skiff
yeah
austere talon
yeah i extracted the map in the past it's really easy
const map = eval(wreq.u.toString().match(regex);```
limber skiff
not so long ago they made it worse
brazen bone
You can extract it either with prototype pollution or regex
limber skiff
you can't do that anymore
livid heath
ofc its .toString
austere talon
I kinda don't think so; like if they wanted that, they'd have made .u() a plain ...
tbh i wonder why it even is that way
don't you lose some performance by always declaring the object inline
instead of caching it in a variable
brazen bone
Probably not much, but yeah must be nonzero
livid heath
i wonder if browser's js engine does some optimization
brazen bone
Though getting chunk urls is hardly a bottleneck compared to the subsequent http request
livid heath
Though getting chunk urls is hardly a bottleneck compared to the subsequent http...
the https request pales in comparison to discord code performance
thank you gboard for correcting http to https
charred monolithBOT
austere talon
i wonder if browser's js engine does some optimization
yes ofc
austere talon
Though getting chunk urls is hardly a bottleneck compared to the subsequent http...
that is very true yeah
and it's nothing compared to discords own performance issues
charred monolithBOT
Bypass DND allows you to set specific guilds/channels/users to still receive a notification from when in DND mode.
You will only get the notification if:
- The message is pinging you (for guild and channel bypasses)
- All messages in DMs
rugged spire
and it's nothing compared to discords own performance issues
channeltabs has made me realise how fucking slow discord really is
brazen bone
Why are these bots special-cased? (used in a function getSystemMessageBotJoin) ```js
let a0 = {
"234395307759108106": "https://groovy.bot/commands",
"365975655608745985": "https://www.pokecord.com/getting-started",
"512412940897484800": "http://jameslantz.net/smilebot",
};
Thinkies Discord jank
shy veldt
Why are these bots special-cased? (used in a function `getSystemMessageBotJoin`)...
It was for 2017/2018
they had a section in guild settings
similiar to app directory or so
but they hand picked like 6 bots
and thats what its used for
well more like no longer used
rugged spire
i think i can vaguely remember something like that
brazen bone
Why does channel.getGuildId() exist? It's just return this.guild_id
rugged spire
Why does `channel.getGuildId()` exist? It's just `return this.guild_id`
idk, it causes no harm though
brazen bone
Except for being unnecessarily confusing
rugged spire
look at this disgusting hack i made yesterday
works really well btw
https://github.com/Sqaaakoi/Vencord/blob/betterChannelTabs/src/plugins/channelTabs/titlebarVars.css
Can someone judge this hackiness though (It has hardcoded class names in it, what should I do instead?)
charred monolithBOT
austere talon
look at this disgusting hack i made yesterday
don't do that
rugged spire
https://github.com/Sqaaakoi/Vencord/blob/betterChannelTabs/src/plugins/channelTa...
@austere talon this is worse though
rugged spire
https://github.com/Sqaaakoi/Vencord/blob/betterChannelTabs/src/plugins/channelTa...
See this
(Overriding heights used for the original Discord titlebar)
Oh and before anyone screams too hard at me, Yes I know that file is undisputably a hack
and I will not PR that into ChannelTabs
charred monolithBOT
Is your feature request related to a problem? Please describe.
The Notification Badge option only works when libunity is installed, but this might not be exactly clear to non-Ubuntu users.
Describe the solution you'd like
In the option's description, add a help text such as:
Note: if this is not working for you, be sure to install the "libunity" package for your distro.
**De...
brazen bone
What if :root { transform: rotate(90deg) }
rugged spire
why husk my idea
still wasp
What if `:root { transform: rotate(90deg) }`
What if * { transform: rotate(0.005deg) }
brazen bone
So true bestie
rugged spire
What have I done
:root { transform: rotate(-90deg); width: 100vh; height: 100vw; right: 0; bottom: 0; }
shy veldt
Why does `channel.getGuildId()` exist? It's just `return this.guild_id`
to like
get the guild id? idk man
rugged spire
I have a stupid question
Would automatically muting yourself in a voice channel be considered selfbotting
lime stone
depends how the action is triggered ig?
rugged spire
depends how the action is triggered ig?
inactivity
brazen bone
Inactivity is the opposite of action
rugged spire
I will respectfully refrain from submitting a PR until it has been determined whether the act of automatically muting yourself is considered selfbotting
lime stone
what is it
rugged spire
Automatically muting yourself in a voice channel if you haven't spoken for a certain amount of time
charred monolithBOT
spark pivot
Well it is a self bot but I think its fine since it will barely happen
lime stone
Well it is a self bot but I think its fine since it will barely happen
not really imo
austere talon
anything that doesn't spam requests is fine
rugged spire
anything that doesn't spam requests is fine
my idea definitely doesnt spam requests
austere talon
if the requests could reasonably be triggered by normal app usage, it's fine
rugged spire
the most it would send is a single mute yourself event
rugged spire
if the requests could reasonably be triggered by normal app usage, it's fine
yeah the request could be triggered normally too
the only concern I have is how it would precisely trigger after a certain time
which..... is the whole point
reusing code I already wrote time!!!!!
rugged spire
Would this be considered hacky
brazen bone
What's wrong with [15, ...makeRange(60, 900, 60)]?
rugged spire
Nothing at all.
Thank you for the suggestion on how to improve because I forgot you could do that with an array (for a moment)
lime stone
veetop
)
charred monolithBOT
crude raptor
[Vendicated/Vendroid] New star added