#👾-core-development
limber skiff
^ it does this
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
So yeah, i use another locale than english and besides last fix it still didn't work on an exaple video i tried it with, i checked why and it appears that the href of "watch on youtube" was http, so this pr adds support for that too
odd heath
fun
limber skiff
I ran it manually cuz I noticed a broken patch in my console
limber skiff
they may be removing channel emojis
limber skiff
I'm fixing dont worry
odd heath
oki
lime stone
they may be removing channel emojis
🤞
it'd be nice if they just didn't use ai tbh
✨
word of the year: ai powered
well, ai is a broad term
using chatgpt to generate icons and not allowing you to change it by default is bad
limber skiff
copy paste find 🔥
odd heath
lmao
limber skiff
I need some opinion on this @austere talon https://github.com/Vendicated/Vencord/pull/2153/files#diff-ca0d373b9a592ddb25c3913cefa2dc7dfd490f95af0aba3eaf7f5c3a25333816R85-R134
no embed bot?
guh
grave mangoBOT
**index.tsx: **Lines 86-134
const isAlreadyAdded = allowedIdsPushID?.(id);
if (isAlreadyAdded) {
showToast("CustomRPC application ID is already added.", Toasts.Type.FAILURE);
}
}}
>
Import CustomRPC ID
</Button>
</div>
</Flex>
);
}
let allowedIdsPushID: ((id: string) => boolean) | null = null;
function AllowedIdsComponent() {
const [allowedIds, setAllowedIds] = useState<string>(settings.store.allowedIds ?? "");
const componentWillUnmount = useRef(false);
allowedIdsPushID = (id: string) => {
const currentIds = new Set(allowedIds.split(",").map(id => id.trim()).filter(Boolean));
if (currentIds.has(id)) {
return true;
}
setAllowedIds(Array.from(currentIds.add(id)).join(", "));
return false;
};
useEffect(() => {
return () => {
allowedIdsPushID = null;
componentWillUnmount.current = true;
};
}, []);
useEffect(() => {
return () => {
if (!componentWillUnmount.current) return;
const ids = new Set(allowedIds.split(",").map(id => id.trim()).filter(Boolean));
settings.store.allowedIds = Array.from(ids).join(", ");
};
}, [allowedIds]);
function handleChange(newValue: string) {
setAllowedIds(newValue);
}
austere talon
**index.tsx: **Lines 86-134
```tsx
const isAlreadyAdded ...
wtf is that ref for
limber skiff
format the list every time the component is unmounted
and also update the component when you click to add custom rpc id
it's kinda cursed I didnt know how else to do it
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
limber skiff
grrr
olive aurora
jail
limber skiff
I'm sorry 😭
odd heath
Why do you even have 2 dev branches
uneven tiger
need at least 3
limber skiff
Why do you even have 2 dev branches
because dev is protected
I need commits to pass the test to push for it
dev2 is used to push commits without testing, them they get tested and are allowed to be pushed to dev
odd heath
Ooo
uneven tiger
le forcepush has arrived
austere talon
is that actually a good idea
the hyperlink stuff
some servers block it
should definitely be toggleable
limber skiff
is that actually a good idea
it is a good idea, but if some servers block it, then it should be an option
uneven tiger
you can block it?
austere talon
yes
limber skiff
I was making notices to check for embed links and attach files permissions when using fake nitro stuff
but alerts suck so much I dont want to deal with it rn
limber skiff
coool
charred monolithBOT
austere talon
@cobalt ledge please stop leaving spam comments or you will be blocked
charred monolithBOT
limber skiff
@austere talon this is so epic
onCloseCallback runs earlier than onConfirm, so I did that
austere talon
insane
austere talon
isn't onCancel obsolete
charred monolithBOT
charred monolithBOT
it does not stand out compared to the other icons 🤷🏻♂️
Did you see your own screenshot?
turbid hatch
to be fair we do need a better tray icon
and in general, smaller (i.e., 64x) icon
because using the fullsize image and making it smaller doesnt look good
oneko becomes a blurry mess and its just
it looks awful
the original issue appears to be a complaint about like
how they want the tray icon to fit the rest of the default windows icons
like how sharex, tailscale, and vmware fit in here:
but the rest of the issue does seem to mainly focus on how terrible it looks, and i do agree, we need to have something better for smaller sizes, even if it is just like
oneko
(although just using oneko is not a good idea, it's not distinct to it being vesktop)
its tough
we dont really have a proper logo that can work at such small sizes
limber skiff
to be fair sharex tray icon is colored on windows
turbid hatch
yes but it can be changed
that's a built in feature
and i understand why people want it cause i've obviously done it myself to make it fit in
it looks nicer
(i think it inverts when you go on light mode but ive never tried lol)
but point is
current tray icon does suck
at the very least we need a better one
crude raptor
it should be called like monochrome or something if it isn't pure white or black
austere talon
but the rest of the issue does seem to mainly focus on how terrible it looks, an...
someone could remake the pixel art in 64x64 or whatever size
turbid hatch
mhm
austere talon
a more minimal version
charred monolithBOT
charred monolithBOT
charred monolithBOT
Hello, I have resized the current Vesktop icon to a 64px one.
Sadly, although the icon does look more minimalistic, I had to remove Oneko from it because it wouldn't fit anymore.
There are 2 variants, with and without the inner shadow.
Hope this might be of help!
odd heath
Why are people so unhappy with vesktop icons
charred monolithBOT
swift fjord
it is arguably bad because it doesn't scale properly
i have svg versions you can use to make properly scaled icons
austere talon
tbf vesktop doesn't necessarily have to have the same logo
cause its kinda its own thing
charred monolithBOT
charred monolithBOT
spark pivot
Should be possible with the text replace “language” eventually
median rapids
real
austere talon
tbh we should move the reporter to a separate channel
austere talon
dev2 is so horror
limber skiff
BULLYING
limber skiff
tbh we should move the reporter to a separate channel
it's fine in my opinion
austere talon
i like looking at it to see if any plugins recentlöy broke
when people ask for help with them
limber skiff
I see
charred monolithBOT
charred monolithBOT
inland fable
bro forgot to change strings
charred monolithBOT
jagged cloak
lmao
charred monolithBOT
charred monolithBOT
Is your feature request related to a problem? Please describe.
Can't use Open Party or Game Invites. No activity bar (I don't know what to call it) above user (shown below)
Describe the solution you'd like
Some form of adding the features mentioned. Not sure whether it's possible, might be something in [Discord Datamining](https://github.com/Discord-Datami...
charred monolithBOT
charred monolithBOT
i havent noticed any interesting difference besides this
couldnt find any info online confirming your claims either, also experiments and tracing can both be added/blocked via existing plugins, what's the real benefit of a staging build?
limber skiff
@median rapids do you know anything about that?
we already have experiments plugin, disable tracking and even an option to add that staging banner 😂
does it actually make any other difference
median rapids
<@852892297661906993> do you know anything about that?
almost pointless
it enables a few more dev only options but it has to be set before the client loads
which this plugin doesn't do
it's another way to enable experiments though
I don't think it disables tracking
limber skiff
almost pointless
I see, thanks!
median rapids
np 🥰
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
still wasp
Yayyyyyy
jagged cloak
yiiiiiipeee
jagged cloak
havent touched vencord since like oct 2022
rushermod
still wasp
Wouldn't this get you rate limited from the translate api? i heard someone say that was why it wasn't a feature
turbid hatch
yes
charred monolithBOT
median rapids
Yay another pr to get buried
real
topaz thistle
Even if there was one could also add a waiting indicator that signals that the message may take a few seconds to get translated
charred monolithBOT
charred monolithBOT
austere talon
(no styling done yet)
shy veldt
<@852892297661906993> do you know anything about that?
pointless plugin confirmation by yours truly
dapper crest
<:trolley:1024751352028602449> (no styling done yet)
What did you make it in this time
spark pivot
Even if there was one could also add a waiting indicator that signals that the m...
Im honestly not worried about it
Also every time I did it it translated basically instantly
lime stone
<:trolley:1024751352028602449> (no styling done yet)
LMAO
at least use wxwidgets so that you don't have GTK on Windows
**if you're doing this for a native look but you might just be using it because GTK is the most gui framework of all time
charred monolithBOT
crude hearth
<:trolley:1024751352028602449> (no styling done yet)
they will dmca for using discord icons
someone should make vencord installer with imgui
spark pivot
Someone should make vencord installer os
spark pivot
lime stone
someone should make vencord installer with imgui
uhh pretty sure that's the current installer, windows 10 
(do you want to be called windows 10)
shy veldt
@austere talon 🤔
charred monolithBOT
topaz thistle
<:trolley:1024751352028602449> (no styling done yet)
What's it based on now?
lime stone
gtk
olive aurora
i will make a new installer in haskell
charred monolithBOT
thick kestrel
Someone should make vencord installer os
just make a Vencord OS
needs no installer
it's the entire OS
well guess you still need to install the OS...
charred monolithBOT
austere talon
discord changed the Timestamp component. now it takes a js Date instead of a moment object
it breaks server info, reviewdb, show hidden channels, and a few other things
i already fixed but it's not on stable yet, so we need to wait til its on stable
austere talon
^ dont push this commit to main until stable updates timestamp component
charred monolithBOT
austere talon
does anyone (no whitenames) want to moderate plugin requests:
- make sure they don't break rules
- close duplicates
- make sure they're possible
if multiple people want to moderate it, we can reopen them
charred monolithBOT
surreal fiber
I wouldn't mind helping moderate them, although I might not always know what is possible and what is not. What about plugins that are already implemented as third party or have a pr that maybe works?
odd heath
I'd also help moderate, same thing for me with the possibility part tho 
surreal fiber
I can also try to provide css solutions (compromises) for some requests as I've done before
odd heath
I can for sure help with duplicates and rules
charred monolithBOT
topaz thistle
does anyone (no whitenames) want to moderate plugin requests:
- make sure they d...
I could also help where possible, however I might not check them out semi frequently
still wasp
does anyone (no whitenames) want to moderate plugin requests:
- make sure they d...
I'm down to help
grizzled halo
I would help where i can, but I’m not sure how well ill be on the “make sure they’re possible” part
odd heath
Okay but how would we actually "moderate" those
austere talon
i will invite you to the repo to manage issues
austere talon
how to moderate requests:
- add 1 or more fitting labels
- close as "not planned"
- (optional): leave an explanation why you're closing it if the label isn't already self explanatory. in case of duplicate, linking the older issue is useful
if someone makes bad requests multiple times, warn them to be more careful. if they dont better, let me know and i'll block them
if you're unsure about requests, you can discuss in #🗳-plugin-requests
i'll invite you to the github repo. just accept the invite and you'll be able to manage issues
thick kestrel
is this making a comeback
thick kestrel
is this making a comeback
#plugin-requests message yes it is dummy
crude hearth
how to moderate requests:
- add 1 or more fitting labels
- close as "not planned...
just mark all as completed 
tawny cipher
I can keep an eye on those as well if needed
spark pivot
does anyone (no whitenames) want to moderate plugin requests:
- make sure they d...
I’ll also be willing to help
stoic echo
does anyone (no whitenames) want to moderate plugin requests:
- make sure they d...
ig i can
olive aurora
how to moderate requests:
- add 1 or more fitting labels
- close as "not planned...
i will close all requests as "this can be done with css"
spark pivot
Real
olive aurora
am i hired
stoic echo
am i
charred monolithBOT
charred monolithBOT
lime stone
how to moderate requests:
- add 1 or more fitting labels
- close as "not planned...
I guess I could try to help? I'm probably too nice / lenient at times.
swift fjord
how to moderate requests:
- add 1 or more fitting labels
- close as "not planned...
i can help, i had to do these things for vd so im familiar with the flow
swift fjord
stereo plugin pls
lime stone
somebody opened this issue on my project which used require("crypto")
they closed it themselves thankfully
swift fjord
💀
lime stone
i was worried about some kind of exploit when passing data through stdout so i used a secret
(this is the worst code ever anyway)
i was passing a command through stdout to use electron to open urls 💀
charred monolithBOT
austere talon
i was worried about some kind of exploit when passing data through stdout so i u...
elaborate?
curious
lime stone
it's nothing to do with vencord
if you must know though, i was passing message [secret] openUrl https://burgerking.gaming
then i was checking stdout for that and calling shell.openUrl
still wasp
WHY DO YOU DO THESE THIGNS TO ME
verbal pumice
<:lookWhatTheyTookFromUs:1090367103674101770> WHY DO YOU DO THESE THIGNS TO ME
delete node_modules and reinstall
make sure you use pnpm and not npm
odd heath
husk
stoic echo
i could probably help with managing requests since i typically have fuck all to do constantly
still wasp
That's certainly interesting
ok i think i fixed it
Maybe
Perchance
YEAHHHHHHHHHHH
charred monolithBOT
charred monolithBOT
odd heath
i didtn know about shift clicking users 😭
charred monolithBOT
stoic echo
discord users when they're restricted from something (its the end of the fucking world)
topaz thistle
Is the XDG-Global-Shortcuts support already in the latest KDE Release?
I can't seem to find the D-Bus Object responsible for the shortcuts
still wasp
i didtn know about shift clicking users 😭
Wtf i never knew that either lmao
charred monolithBOT
still wasp
Changed the button label
topaz thistle
Is the XDG-Global-Shortcuts support already in the latest KDE Release?
I can't s...
Is anyone here running KDE on wayland?
charred monolithBOT
topaz thistle
Lmfao
surreal fiber
yeah it's still in pr
stoic echo
wait whar
still wasp
stoic echo
couldve sworn it got merged with vencord
still wasp
Nope
stoic echo
well my point still stands it already exists
olive aurora
vee forgets abt all codeberg prs
still wasp
💀
thick kestrel
Is anyone here running KDE on wayland?
I am, on my laptop (X11 on PC)
do you need testing?
topaz thistle
Could you send in the output of qdbus | grep freedesktop
Would have to be in a Wayland session
thick kestrel
~ $ qdbus | grep freedesktop
org.freedesktop.ScreenSaver
org.freedesktop.IBus
org.freedesktop.IBus.Panel
org.freedesktop.portal.Fcitx
org.freedesktop.portal.IBus
org.freedesktop.secrets
org.freedesktop.portal.Desktop
org.freedesktop.portal.Documents
org.freedesktop.impl.portal.desktop.gtk
org.freedesktop.systemd1
org.freedesktop.Notifications
org.freedesktop.PowerManagement
org.freedesktop.PowerManagement.Inhibit
org.freedesktop.impl.portal.desktop.kde
org.freedesktop.background.Monitor
org.freedesktop.Flatpak
org.freedesktop.FileManager1
org.freedesktop.ReserveDevice1.Audio0
org.freedesktop.impl.portal.PermissionStore
org.freedesktop.DBus
Perfect
thick kestrel
5.27
topaz thistle
Thanks!
brazen bone
Why is it that all the plugin requests suck
odd heath
why you think they got locked
brazen bone
Point
charred monolithBOT
odd heath
i feel like messagelogger might be broken for edits on canary
unless that uses the timestamp thing too
charred monolithBOT
odd heath
Any idea how soon that change will land on stable?
when discord merges their shit into stable
otherwise vencord would break for all stable users
brazen bone
Yeah I mean how soon discord will merge it into stable
odd heath
nobody knwos
odd heath
i feel like messagelogger might be broken for edits on canary
uh from my testing its still broken even on the latest dev commit
but maybe im just dumb
oh yeah its the timestamp thing
it just wasnt included in the commit on the dev branch
odd heath
if you edit a message message logger will not show the edit
odd heath
yea i tried on canary with the latest commit on dev
its related to the timestamp thing because the e.gettime error shows up in console
limber skiff
so not a broken patch?
limber skiff
I see
charred monolithBOT
median rapids
family friendly vesktop??
thick kestrel
I have the idea to make a plugin that saves settings that Discord forgot about between account switches
the question is, are there more settings than just compact mode avatars that are broken like this
because compact mode avatars is what bothers me, so I'd call that SyncCompactModeAvatars and just do that, but I can broaden the scope if there are more and just call it SyncUnsyncedSettings
lime stone
I have the idea to make a plugin that saves settings that Discord forgot about b...
doesn't the reset only happen if you log out or am i mistaken
well being terminated or some weird error happening also has reset them for me in the past
thick kestrel
it happens every time when I switch accounts
I only ever noticed the compact mode avatars getting disabled tho
I was so annoyed by this that I formally complained about it in the README of Compact++
and just now I figured why not fix that
lime stone
i always have the text larger than default. does that reset for you?
thick kestrel
that one seems to sync
charred monolithBOT
austere talon
btw @golden gulch i never thought about this before but does an invidious plugin even have any purpose? does it add any new features to embeds?
golden gulch
before the reload thing was found out about, my main reason for making it was to get around the embed restriction things
a secondary usecase would be to not have your data sent to youtube (the same reason you'd use a 3rd party frontend in the first place) but personally that wasn't the reason I wanted it
since the reload thing was made for plain youtube embeds my personal reason for making the plugin is kinda moot
austere talon
makes sense
charred monolithBOT
austere talon
a secondary usecase would be to not have your data sent to youtube (the same rea...
i mean this doesn't seem like a valid use case because you're already using discord so it can't get much worse
austere talon
lmao 😭
golden gulch
I suppose one thing of potential merit could be the CORS header things but that's pretty minor
could serve to split the CORS rules into their own plugins instead of having the CDN domains in the main file though (for the plugins that embed js libs)
austere talon
do you mean csp
charred monolithBOT
charred monolithBOT
charred monolithBOT
lime stone
that one seems to sync
it does not.
but it seems to persist between account switches
¯_(ツ)_/¯
thick kestrel
interesting
thought that's the same thing, ie. if something doesn't sync it doesn't persist between switches
charred monolithBOT
still wasp
Github why do you do this to me
Oh i can't reopen the pr after changing the branch name 
Pain
charred monolithBOT
limber skiff
ugh
odd heath
whar?
dapper crest
I'll race your condition
limber skiff
I'll increase the millseconds
odd heath
I think discord might have pushed the broken timestamp thing to stable
looks like it from #🏥-vencord-support-🏥 at least
stoic echo
yeah im starting to think so too
ill see when i get home if the shits broken again
cause i use stable
if anyone else wants to test before me fucking go for it, i wont be home for another 3 hours
limber skiff
I fixed crash handler surelyy this time (please let this be the last time)
still wasp
Yayyyyyyyyy
odd heath
I fixed crash handler surelyy this time (please let this be the last time)
Can you fix message logger too 
odd heath
:3
austere talon
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/messageLogger/index....
**index.tsx: **Line 125
timestamp: moment?.call(newMessage.edited_timestamp),
literally just change this
charred monolithBOT
Discord Account
berrygod
What happens when the bug or crash occurs?
When i open a locked channel and im using the review plugin
What is the expected behaviour?
When using the review plugin and opening a locked channel
Tried reinstalling discord and vencord
How do...
austere talon
also bump version and push to main
and you have to create a tag v* matching the version number
odd heath
is something like this fine for fakenitro
limber skiff
aight
limber skiff
is something like this fine for fakenitro
ehh
limber skiff
I didnt do it because I hate this manually id inputs
odd heath
how would you do it
limber skiff
we need a component for selecting guilds and channels
but no one has done it yet
just keep it without it for now
odd heath
i just wont touch it
limber skiff
if they have issues they can just disable the hyperlinks, it doesnt make much difference
ya
austere talon
we need a component for selecting guilds and channels
meh
it'd probably be better to use context menus
limber skiff
hmm
austere talon
add something to all context menus that is like
Add to list >
MessageLogger >
[X] Whitelist
[ ] Blacklist
something like that
limber skiff
zero width space didnt work
austere talon
all plugins in central place
austere talon
add something to all context menus that is like
```
Add to list >
MessageLog...
and the code to register those menus is smth like
const lists = defineLists({
users: ["whitelist", "blacklist"]
})
const isWhitelisted = lists.users.whitelist.includes("id")
and it'll also be manageable in settings ig
limber skiff
yeah I like that
austere talon
https://github.com/Vendicated/Vencord/pull/2160/files
not rn, another time
brazen bone
A small correction: the Timestamp module (587904) has not been changed, it's 888400 (which defines things like isSameDay and dateFormat; I call it DateUtils) that has
Not that that makes any difference in practice
austere talon
what?
olive aurora
is momentjs dead finally
limber skiff
I used notepad 👍
spark pivot
I used notepad 👍
You can save without formatting
limber skiff
that's a nice tag number
odd heath
that's a nice tag number
True
limber skiff
these are the times we hope crash handler prompt for update works
limber skiff
I mean those who updated discord already and havent updated vencord
it saves them having to use installer
austere talon
I mean those who updated discord already and havent updated vencord
?
i don't understand
why would fhey have to use the installer
austere talon
no
austere talon
discord crashes if you open server info modal
and if you view hidden channel it shows error boundary, same if u olen profile
limber skiff
yeah I get it now
crude hearth
finalyy
crude hearth
did u guys fix types on Message Object etc
charred monolithBOT
crude hearth
ntts effect strikes again
still wasp
Real
shy veldt
yeah you wait
at least 2 years
charred monolithBOT
jagged cloak
true
but also annoying af
"just dont use x program" lol
(i have said this exact thing and i will continue to do so)
charred monolithBOT
charred monolithBOT
charred monolithBOT
i think the best solution to making it configurable per server would be smth like this
charred monolithBOT
charred monolithBOT
Closes https://github.com/Vencord/plugin-requests/issues/41 (doesn't work bc i don't have permissions but yeah)
Preview
olive aurora
it does work but only if its merged
maybe not cross repo
huh cool I just assumed it wouldn't work on another repo
charred monolithBOT
austere talon
lmao
how do they even dm you
i deliberately changed the authors to be a modal where you can't dm people 😭
olive aurora
new vencord core plugin if any whitename dms a contributor they explode
crude raptor
add it rn
limber skiff
why not this
does that let you cancel without cleaning the input
austere talon
does that let you cancel without cleaning the input
uhh why do you not want to clear the input
limber skiff
when they dont confirm they want to send an emoji without permissions
or edit
I want to let them remove it from the message and try again
the preSend listener already allows it, idk why the edit didn't
limber skiff
lmao
lime stone
should we enable auto update by default
maybe prompt on first start
still wasp
What the fuck
turbid hatch
piss off
crude hearth
maybe prompt on first start
first start or I say put it in installer
like have a checkbox saying "enable auto updates" which will be auto checked
lime stone
vesktop:
still wasp
Probably just best to enable it by default
lime stone
lime stone
I think it's important
lime stone
but maybe don't show it to existing users, that would be annoying (since they already had to be aware of the updater)
austere talon
people who care are also the type of people to go through settings and customise everything
lime stone
(i can imagine that happening if you used a new key to remember whether it had been seen)
austere talon
the rest does not care and doesn't want to be bothered
crude hearth
I actually doubt if existing users know auto updater exists
but also popping out a modal would be terrible user experience
maybe have a small notification like the "streamer mode disabled" thing
have one button which will say update and other will have enable auto updates
btw is this automaticly enabled for everyone
crude hearth
yeah
charred monolithBOT
charred monolithBOT
still wasp
Rip
limber skiff
horror
charred monolithBOT
