implemented in browser/VencordNativeStub.ts
#👾-core-development
austere talon
turbid hatch
ty
thick kestrel
funi stubs
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/browser/VencordNativeStub.ts#L45
**VencordNativeStub.ts: **Line 45
uploadTheme: (fileName: string, fileData: string) => DataStore.set(fileName, fileData, themeStore),
this is me not updating the stubs
austere talon
this needs updating
austere talon
we likely also need to migrate old stored values
austere talon
usercss doesnt work on web anyway - use stylus for that
right
thick kestrel
usercss doesnt work on web anyway - use stylus for that
it doesn't? :c
turbid hatch
it doesn't? :c
nope
turbid hatch
we cant bundle the compilers cause they're fat
and usercss is being taken from a browser extension
so just use the extension
xd
austere talon
i mean we absolutely can bundle them but its useless cause like... just install stylus
turbid hatch
ye
austere talon
why use vencord for it when u can have the real deal
thick kestrel
I mean... yeah ig lol
turbid hatch
the only thing vencord has an advantage over stylus with is @vc-requiredPlugins
since it flags up a warning on the theme card if you dont have a plugin enabled
but that's it
it's basically just a worser implementation of usercss
than the ext
austere talon
is there even any way to do this
i dont think flatpaks have the power to restart themselves
thick kestrel
sure
turbid hatch
i dont think flatpaks have the power to restart themselves
there was a proposal but nothing was made
placid wave
run vencord as a child process
austere talon
too complicated
placid wave
then if it exits with a specific exit code
it runs it again
steam client does that
turbid hatch
the official response is either what aa just suggested or tell people to restart
austere talon
not a bad idea what aa said
thick kestrel
sure
wait, you have the current version in your personal fork... I got it from the main repo
turbid hatch
we already have to write a wrapper
turbid hatch
wait, you have the current version in your personal fork... I got it from the ma...
yeah the one in the repo is uh
wrong
the branch was originally in my fork
before i had contrib rights xd
placid wave
btw
turbid hatch
we already have to write a wrapper
it shouldnt be too difficult
placid wave
@austere talon
insane vulkan error happens literally everywhere
it means nothing
it even happens on steamos
austere talon
insane vulkan error happens literally everywhere
that error is literally no driver found 😭
thick kestrel
yeah it works now
charred monolithBOT
placid wave
@austere talon@austere talonbomb
venmic broke again
on steamos appimagem
maybe works in shitpak
OH
right
you said it was broken
im fucking stupid
austere talon
my fan went racecar engine mode when i opened that issue https://github.com/Vencord/Vesktop/issues/191
placid wave
igjore
austere talon
you said it was broken
wait wdym?
placid wave
yop
LMAOOO it shows yomih as "Godot Engine" in the audio list
works
love
oh god
i think the sound is delayed a tad
its delayed
like 0.4s
@austere talon HORROR
austere talon
r u using bluetooth headphones
placid wave
no
might be firefox thing lemme try jrome
drome wont even load the screenshare
rtc connecting
we love jrome
turbid hatch
oh @austere talon usercss doesnt work in web anyway, im fairly certain most of it gets shaken out
well, a decent amount
compilers obviously will never get loaded since usercss is behind a !IS_WEB || "armcord" in window guard
turbid hatch
lmfdao
placid wave
yeah it syncs in chrome
we looove firefox webrtc
so good
very sane implementation
austere talon
ayy i also fixed the being muted every launch
{
find: '"MediaEngineStore"',
replacement: {
// eslint-disable-next-line no-useless-escape
match: /=\i\.supports\(\i\.Features.AUTO_ENABLE\)/,
replace: "=true"
}
}
// eslint-disable-next-line no-useless-escape
kill
charred monolithBOT
austere talon
@turbid hatch hows https://github.com/Vencord/Vesktop/pull/282 going btw?
i wanna make a release soon and dont want the broken start minimised implementation in it
foggy basin
this is /usr
austere talon
actually let me just revert the commit for now
turbid hatch
<@96269247411400704> hows https://github.com/Vencord/Vesktop/pull/282 going btw?
didnt have chance cause of other stuff
turbid hatch
when you release silly
foggy basin
hehehehehe
winter jungle
so what's the point of a virtmic if sinks are added to the voice engine device itself?
i have it setup like this and it appears to be working?
yeah it is working
austere talon
so what's the point of a virtmic if sinks are added to the voice engine device i...
what?
winter jungle
i meant chromium input in the screenshot
when i start a screenshare with audio two inputs are added
so there's no point in a virtmic
austere talon
there is
winter jungle
oh
austere talon
chromium can't record arbitrary sources, only microphones
winter jungle
oh i didn't know that
when i just routed the source itself and hooked up the monitor to my headphones i heard sound
austere talon
try it yourself, run await navigator.mediaDevices.enumerateDevices() in devtools and see what it returns
winter jungle
also the stream should be stereo, yes?
tested it, no it is not
unfortunate
welp nevermind
not possible
what about vencord on the discord app, not possible to implement the virtmic and sink addition?
others have probably asked this question before, sorries
austere talon
search for keywords that you think might help
granite vessel
i cant find docs though
charred monolithBOT
When streamer mode is on, you can only see the first letter of usernames with 3 dots afterwards. Now, if you have this plugin enabled, usernames are censored in the same way:
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
@crystal walrus https://x.lewisakura.moe/23/12/Vesktop_2023-12-28_13-20-56.mp4
will this work
hm
hm?
can you show me what you mean
oo i see
let me take a look
i wonder do we actually have those
probs
just need to find it
where'd you get these from
just so i can grab them myself
ty
they look close enough to discord's icon set so
bleak gyro
turbid hatch
@crystal walrus
fire
pushed
you can edit the json manually to cause invalid settings but it just makes it fail validation so in the end nothing actually breaks
it just doesnt parse certain stuff
if you add extra settings or remove stuff it'll ignore it too
so you can make tiny settings snippets if you want
for example
{"numberVar":"10","selectArrayVar":"Arial"}
also you might like this
@vc-requiredPlugins ThemeAttributes
it used to just be a warning but ive made it a proper error now
it wont disable themes already enabled if you turn off the plugin, but it'll prevent you from enabling/disabling them until you fix it
also added vencord variable during compilation
so you can do if vencord { } stuff in less and stylus
less useful in uso and default css
but i hope client mods adopt it xd
austere talon
<@928339066838216754> https://x.lewisakura.moe/23/12/Vesktop_2023-12-28_13-20-56...
copy to clipboard is yikes
make save to file
and load from file
like settings sync
faint echo
I'd do both
turbid hatch
these are just to share settings between people mainly, they're already synchronised through the settings sync feature
crude hearth
@austere talon I cant even talk in fork channel inane
austere talon
yop
crude hearth
giive perm
austere talon
kid named dude: 
valid whale
@valid whale
thick kestrel
@turbid hatch wanted to test your usercss on Vesktop, it broke for me in the same way as web before lol
the error is in the same place
turbid hatch
er
thick kestrel
thick kestrel
I have no idea lmao
thick kestrel
sure
turbid hatch
and filename
thick kestrel
content is undefined lol
the file itself is an old version of Compact++
I think I should consider a career as a software tester
I just look at some code wrong and it breaks
verbal pumice
pr's that have likely been abandoned (no update since rspack and either have unresolved reviews or were obviously broken by it)
open: #1728 #1721 #1719 #1573 #1452 #1324 #971 #966 #947 #534
draft: #1348 #1563 #1773 #1114(could def be brought back as the issue making it a draft was fixed) #696(is this still happening?) #553
doesn't include prs that are waiting for a review
might group all prs into abandoned and waiting for review tmr if i have the motivation
austere talon
thats helpful thanks
will likely close most of these to tidy up prs a little and make it more manageable again (they can still be reopened if the author wants to update them)
frail sky
austere talon
<@343383572805058560> maybe we should publish to chrome
right
obsidian timber
charred monolithBOT
placid wave
@placid hinge hii do you still have the source for this icon https://github.com/Vencord/Vesktop/blob/main/build/icon.icns id like to add it to vendroid but i want to make it an adaptive icon so i need the layer data
austere talon
what the hell is that nickname
placid wave
sanest discord user
austere talon
reminds me of me trying to download russian music and windows or whatever ruining the encoding so it's just gibberish
keen blaze
hai @austere talon
placid wave
thanks
keen blaze
@placid hinge wuts that username lmao
charred monolithBOT
charred monolithBOT
hollow slate
uh hello
i saw the plugin review db that was removed from vencord because of harassing and Vendicated requested the owners to add a feature so that users can remove reviews from their own profile and looks like the owners were not interested
well, i was just looking through the ReviewDB code and i found that its really simple to add that feature
its like one more line in a codeblock
i wanted to check if the api hosted by the owner is still working
and it does
verbal pumice
the api wont just let you delete reviews even if you add the button
otherwise that would've been done a good while ago
crude hearth
maybe i can try to fix the api if <@287555395151593473> shares the code
do you think its about hardness to add that feature 🥴
its not really hard I just didnt want
hollow slate
oh
well
do you mind if i recreate the api from scratch and use the same reviewDB plugin code?
hollow slate
oh it is?
crude hearth
but there is a possibility that I will add the feature and readd to vencord (if ven agrees)
I just dont want to mess with moderation atm because of universrity
crude hearth
also I will be totally honest
I dont really like someone rehosting the plugin/backend/idea at least I created
hollow slate
its alright, totally understandable
i was just bored and i wanted to try something new
crude hearth
yeah understandable
charred monolithBOT
If you resize a captured window, it will freeze the screen-share, but audio still plays. However, this only happens when using the "windows" option in the screen-share; capturing a full monitor/desktop does not freeze the screen-share when resizing a window.
There's an open issue on discord-screenaudio as well, which I assume your implem...
charred monolithBOT
hollow slate
h
is there any function for plugins to open a private channel but with no user id
i mea, i dont want to open up a dm with a user
just an empty private channel
livid heath
an alternative would be to create a gc with just yourself
but thats unrelated to vencord dev
soft dove
is there a way i could use the vencord dev cli installer with sudo on wayland?
weak thistle
why the fuck would you want to do that
also you'd be patching the discord installed to the root account
soft dove
why the fuck would you want to do that
i cant use the gui installer on wayland since it requires root to patch my discord installation
austere talon
you can use the gui on wayland too
soft dove
you can use the gui on wayland too
it downloads the x11 installer even though i am on wayland
livid heath
yeah it appears so
verbal pumice
it downloads the x11 installer even though i am on wayland
it should download the wayland one https://github.com/Vendicated/Vencord/blob/5dee2e8549de195f7bdb213ce7bb7f6dde840811/scripts/runInstaller.mjs#L41-L42
grave mangoBOT
it should download the wayland one https://github.com/Vendicated/Vencord/blob/5d...
**runInstaller.mjs: **Lines 41-42
case "linux":
return "VencordInstaller-" + (process.env.WAYLAND_DISPLAY ? "wayland" : "x11");
if i run it without sudo it gets the wayland one
but with sudo it downloads the x11 one because sudo messes with wayland display stuff
verbal pumice
i believe the regular installer allows setting an enviorment variable to set a custom vencord source location maybe try that?
soft dove
sudo -E pnpm inject
austere talon
stop using that horrid image host please, so much wasted space
"BSY" close whatever is still running the binary
soft dove
sorry ><
soft dove
tyy it worked <3
fair linden
hey is it possible to add third party plugins to the browser extension for chromium??
verbal pumice
build vencord with pnpm buildWeb
assuming you already have the whole third party plugin thing done
fair linden
assuming you already have the whole third party plugin thing done
its already done!
fair linden
build vencord with `pnpm buildWeb`
thanks for the help!
real zenith
nothing really, I've just been messing around with the code a big
verbal pumice
insert plugin native shenanigans
charred monolithBOT
real zenith
insert plugin native shenanigans
.. oh yeah all I did like a week ago (I tried overriding vencord stuff) was create a crappy plugin loader cause I hate having to manually recompile vencord 
is it cursed? yes
does it (barely) work? yes 
turbid hatch
what black magic is going on there
mostly just working out what plugins need and automagically generating the code for it internally when compiling so that the developer doesnt have to do anything, which is also why writing an external plugin loader sucks :p
charred monolithBOT
I've noticed that I get irrelevant definitions, so I made these changes:
Before, API gave only 10 results and the plugin chose the first result:
After, API gives the number of results you put in the settings and the plugin chooses the result with the most likes:
P.S:
These change...
brazen bone
Is it possible to have find: be a regex? I'm trying to match /'\{"use strict";\w+\.exports=\{(\w+:"\w+",?)*\}/, or in other words all modules that define class names
austere talon
no
just use .exports={
you can set noWarn to true to avoid warns for unmatched modules
brazen bone
So basically match way more than I actually need?
Good enough I guess
Does it patch all modules that contain the substring or only the first?
turbid hatch
re: it looks fine to me, and channeltabs has been open and maintained for a long time now
i think its time to give the people what they want
(also i desperately want it xd)
thick kestrel
lol the ChannelTabs thing looks incredibly funny
pastel belfry
is it possible to add a vencord plugin that allows you to set a folder for audio events (or can i make one and send it in for review)
i feel like that specifically would be fairly easy to implement with respect to futureproofing, as all you would need to do is change a relative path
brazen bone
Unfortunately it seems changing all class-definition modules from exports={foo:"foo_123456", ...} to exports={foo:"foo foo_123456", ...} causes a bunch of crashes
Too bad, would have made styling significantly easier (and possibly more performant)
thick kestrel
is it possible to add a vencord plugin that allows you to set a folder for audio...
(or can i make one and send it in for review)
feel free
worst case it doesn't get merged
pastel belfry
there seems to already be one
that didn't get merged
so i'll hop on that one
surely vencord development isn't terrible to set up
thick kestrel
it's pretty easy even if you don't normally do JS (I don't)
if you do I imagine you'll feel right at home
pastel belfry
eh, i dont all the time but i know JS enough to make do
thick kestrel
though there seems to be an ongoing war between Node developers as for which build system is best
pastel belfry
yeah
thick kestrel
Vencord uses pnpm, I've seen yarn and npm used before
also something else but I forgot the name
brazen bone
I've never made anything large enough in js to need any package manager :/
Just <script src="cdn link">
pastel belfry
tbh, pretty much same, but still learning how to use it is very valuable
just from a "i will probably need this in the future" stance
oh
thick kestrel
is plugin CSS really imported over QuickCSS...?
is it a bug?
(should I open an issue about this?)
brazen bone
Looks like normal css specificity shenanigans
If reordering the stylesheets does indeed give quickcss priority, that sounds like a good improvement to me
thick kestrel
If reordering the stylesheets does indeed give quickcss priority, that sounds li...
yes, that's how CSS works
that's how it is currently
ordering it like this fixes the issue
austere talon
ordering it like this fixes the issue
they should be like this
they are on desktop
if they aren't on userscript / browser then that's a bug
thick kestrel
ok so it is a bug
brazen bone
I get that order too, on userscript
thick kestrel
ok so I tested on Chromium (I initially suspected browser differences)
the extension imports CSS straight from it's resources
and that makes it have the correct order
the userscript adds the whole CSS as a node (since well, how else would you accomplish this, userscripts can't have resources) and the way it does that messes something up
austere talon
it's just race condition
thick kestrel
I made some new CSS for the ChannelTabs plugin, so it can be easily adjusted for a compact layout as well (sizes taken from Firefox). should I suggest it in the MR when it's done?
Discord crops the preview weirdly, huh
also found a bug - the folder icon is black when using dark theme
also, it'd be cool to be able to open a new tab by middleclicking on the empty area
thick kestrel
I made some new CSS for the ChannelTabs plugin, so it can be easily adjusted for...
also not sure if having a compact layout toggle would be in scope of the plugin, or should it be done with QuickCSS?
it kinda makes sense to have this I think
charred monolithBOT
charred monolithBOT
charred monolithBOT
real zenith
mostly just working out what plugins need and automagically generating the code ...
well yeah, but either I'm missing something or vsc picked up the native typings even before building
charred monolithBOT
green ermine
anyone have a badges plugin
nimble pendantBOT
anyone have a badges plugin
dusk blaze
charred monolithBOT
still wasp
#1185327646415003658 message if i did a pr would this plugin get merged potentially? ive never published a plugin before so idk how it works lmao
tawny cipher
p sure lumap pr'd this but declined and turned into console snippet
austere talon
it could be made part of emote cloner
still wasp
it could be made part of emote cloner
That's not a bad idea
olive aurora
PowerToys CropAndLock
long stream
i hate git so much
brazen bone
Eventually you'll figure out which subset of commands is less likely to break things
austere talon
limber skiff
maybe we should have a whitelist and blacklist thing plugins can use
for channels guilds and users
it would make the setting component automatically
and could potentially add context menus too
austere talon
true
limber skiff
and of course it would be better than just some id inputs 😂
austere talon
one combined context menu
austere talon
Whitelist
[ ] Plugin1
[ ] Plugin2
Blacklist
long stream
and could potentially add context menus too
would go nicely with an array/table setting component
limber skiff
nah
better than that
a proper selector for guilds and channels
and users
not just manual id inputs as I said
lots of plugins could benefit from it
long stream
austere talon
a proper selector for guilds and channels
effort
limber skiff
tbf the ui shouldnt be too hard
austere talon
eh kinda
optimally you'd want search and stuff
and good luck with making the user search
cache will fuck you over and people will complain they can't find their friend xd
mortal fractal
you should because its not something we can reasonably fix unless someone wants to spend hours making vesktop not use the web media engine, whether it be making own media engine or mangling the normal desktop media engine to not need discord_voice
web media engine is so negelected and the packet order bug shows that it is
i do think theres something with webrtc that is bottlenecking here
turbid hatch
well yeah, but either I'm missing something or vsc picked up the native typings ...
yes, its typed
oh this is a bug in theme loader itself
ill fix it
turbid hatch
shit
didnt see it wasnt based on dev
god damnit
fucking mobile
ugh
now i gotta
fack
@austere talon can you turn off branch protection temporarily
i need to force push main to fix my error
turbid hatch
yes'
i need to remove a commit
and move it to dev
hence why i am asking you to remove branch protection temporarily
:p
austere talon
you cannot
austere talon
you dont
turbid hatch
what
austere talon
how do you expect to be able to force push to main
it will break everyone's updater
just leave it there it doesnt matter
turbid hatch
mkay
now i gotta fix my repo
ez fix
git fetch origin git reset --hard origin/{main,dev}
turbid hatch
@crystal walrus should be "fixed" on the fork, it'll disable the themes that are invalid after complaining once
jaunty junco
are vencord plugins run in web context or node
turbid hatch
web, but can expose natives
jaunty junco
i'm trying to make a plugin that allows controlling discord via HTTP endpoints
so essentially a http server that is always running
jaunty junco
web, but can expose natives
do i just import the module after pnpm add?
turbid hatch
you want to run a http server in the browser?
turbid hatch
well your specific use case requires native -> renderer, which is unusual
jaunty junco
ipc as in the electron apis?
turbid hatch
yeah
jaunty junco
so i have inject code into the asar then
turbid hatch
no, we already have a natives system
jaunty junco
dont think your plugin apis support that
turbid hatch
we have stuff we have to do over IPC
jaunty junco
where do i add the native code in another file?
turbid hatch
the plugin IPC stuff i think only goes renderer -> native (callbacks of course), so you have to write it in a different way
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/plugins/voiceMessages/native...
**DesktopRecorder.tsx: **Line 25
const Native = VencordNative.pluginHelpers.VoiceMessages as PluginNative<typeof import("./native")>;
**DesktopRecorder.tsx: **Line 55
const buf = await Native.readRecording(filePath);
they need to run a webserver, so it would need to be the other way vee
austere talon
also i highly recommend you use vscode, not intellij
turbid hatch
unless they queue up on the native side and then the plugin constantly requests via IPC
but that seems inefficient
austere talon
they need to run a webserver, so it would need to be the other way vee
you can just eval code in renderer. pretty simple
jaunty junco
also i highly recommend you use vscode, not intellij
webstorm is so much nicer 😭
turbid hatch
you can just eval code in renderer. pretty simple
i am unsure how that would solve the problem of going native -> renderer
jaunty junco
you can just eval code in renderer. pretty simple
nah thats bad just send json payloads
turbid hatch
rather than renderer -> native
austere talon
i am unsure how that would solve the problem of going native -> renderer
thats exactlly how you go native -> renderer
jaunty junco
thats exactlly how you go native -> renderer
your right web server lives on native
the web server then calls the plugin on the renderer side
turbid hatch
yeah i dont quite follow
austere talon
server.handle((req, res) => {
const json = getJsonSomehow(req);
mainWin.webContents.executeJavascript(`Vencord.Plugins.plugins.YourPlugin.handleMessage(${JSON.stringify(json)})`);
res.status(200);
}
shesshhh
lime stone
```js
server.handle((req, res) => {
const json = getJsonSomehow(req);
mainWi...
as safe as this it's still very scary to read
jaunty junco
so what im trying to do is, request received(payload contains user id of the person you wanna call)-> start vc
austere talon
```js
server.handle((req, res) => {
const json = getJsonSomehow(req);
mainWi...
this isn't ideal, normally you'd mainWin.webContents.send("MESSAGE", JSON.stringify(data)), and then register a listener in preload. but plugins have no access to preload, so eval is the second best thing
jaunty junco
ngl the vencord plugin api is really nice
turbid hatch
full documentation soonish
austere talon
so what im trying to do is, request received(payload contains user id of the per...
only call or also other things
turbid hatch
they said a general control so i assume other things too
but you can write "hooks" in the plugin definition that you can eval-call from the webserver, if you parse it on that side
or you can parse it on the renderer side
both works
jaunty junco
yeah
jaunty junco
full documentation soonish
need
austere talon
<:WHAT:1167875888151539762> as safe as this it's still very scary to read
the JSON.stringify makes it safe
lime stone
the JSON.stringify makes it safe
I hope you can't do anything with __proto__
jaunty junco
i already gave you everything you need
working on ittt
turbid hatch
I hope you can't do anything with `__proto__`
u shouldnt be able to
turbid hatch
there's not really much you can do to begin with but stringify strips out __proto__ anyway
since it cant serialize it
austere talon
it doesnt actually
turbid hatch
does it not
lime stone
charred monolithBOT
lime stone
but you wouldn't be able to put code right since json obvs doesn't have functions
jaunty junco
is there a pnpm run dev or do i have to relaunch the client everytime i make changes
austere talon
but theres not much u can do
turbid hatch
is there a `pnpm run dev` or do i have to relaunch the client everytime i make c...
build --watch
jaunty junco
but you wouldn't be able to put code right since json obvs doesn't have function...
JSON.stringify removes all functions
jaunty junco
build --watch
and reload using command+r right?
turbid hatch
not even
turbid hatch
ye
austere talon
you can pollute the returned object's prototype with random shit but like
it doesnt do anything
turbid hatch
instead of it being passed through to the getter and setter
jaunty junco
did it
turbid hatch
which means that, in the case of a poorly defined website
{
"user": {
"__proto__": { "admin": true }
}
}
now i need to figure out how to call a function in renderer form native
lime stone
yes
turbid hatch
but it actually happened!
lime stone
you are stupid
lime stone
(/j)
austere talon
```json
{
"user": {
"__proto__": { "admin": true }
}
}
```
yes u can do that but that doesn't do anything unless you're dumb and trust the object xd
lime stone
I just called you stupid and it's fine because I used a tone tag! (i hope)
turbid hatch
im trying to remember it but there was a video essay from liveoverflow i believe that actually described this vulnerability in a production web app
from some big company
turbid hatch
yes u can do that but that doesn't do anything unless you're dumb and trust the ...
which a lot of people do xd
its stupid
please use a validator like ajv
🙏
jaunty junco
if my plugin uses another dependency do i have pnpm add?
austere talon
i mean
jaunty junco
like what's the proper way of doing it
turbid hatch
if my plugin uses another dependency do i have `pnpm add`?
if you really need the module
austere talon
jaunty junco
if you really need the module
idk but i feel like each plugin should have its own package.json
turbid hatch
only if u eval the json
its a mix, there are some poorly made libraries (several) that will read __proto__ and do stuff off of that
jaunty junco
monorepos
turbid hatch
idk but i feel like each plugin should have its own package.json
nope
austere talon
you must not trust __proto__
austere talon
idk but i feel like each plugin should have its own package.json
- no, our bundler bundles everything into one file anyway
- your plugin will definitely not get merged anyway
austere talon
horror
jaunty junco
1) no, our bundler bundles everything into one file anyway
2) your plugin will d...
why wouldn't it get merged 😭
some people might find it useful
turbid hatch
this commit makes me feel bad
but idk a better way atm
im on the other side of the drunk programming curve
not on it
:(
austere talon
why clone
turbid hatch
to prevent modifying the array during iteration
austere talon
why
turbid hatch
does nodejs not have the same issue where if you modify an array during an iteration it causes skips and weird things to happen
hm
i could remove after the iteration i suppose
thatd work too
use a temp array to store what needs to be removed
austere talon
does nodejs not have the same issue where if you modify an array during an itera...
if u go by index yes but u dont
turbid hatch
im using splice
austere talon
youre not using indexes
austere talon
the best way to do this kinda stuff is using a for loop that starts from the back
for (let i = arr.length - 1; i >= 0; i--) {
if (someCondition(arr[i])) arr.splice(i, 1);
}
wait
what happens if i reassign Settings.enabledThemes whilst im iterating over the destructured version of it
i assume it updates still right?
cause its the same reference to the proxy obj
lime stone
why would you not just do arr = arr.filter
turbid hatch
cause we're encountering the issues as we're iterating
austere talon
that too lol
turbid hatch
otherwise i have to fetch theme data twice
and that seems a bit antipattern
i dont really know the ideal way of doing this unless i iterate backwards i suppose, but then that creates an illogical sort order for theme loading
actually i suppose there is no theme load order
the last enabled theme should be the first to get loaded i guess?
so i could iterate backwards
seems fine
jaunty junco
its working i know what to do
bleak gyro
its working i know what to do
Just be careful of vulnerability’s
I feel like that could be very exploitable
shy veldt
what is this ☹️
why are they not using findByProps("selectVoiceChannel").selectVoiceChannel("channelId")
and findByProps("selectVoiceChannel").disconnect()
charred monolithBOT
spark pivot
Me when I install a program that spams 1675 with start vc 
spark pivot
1) no, our bundler bundles everything into one file anyway
2) your plugin will d...
your plugin will definitely not get merged anyway
bleak gyro
What’s the point in this? Especially the start-call like it’s gonna take longer to go to the user, right click and copy id then type the command compared to clicking on the user which tbh you are probably already have, and then just simply click on the button
austere talon
they literally explain in the description
what's more worrying is that it's literally XSS
cause they entirely ignored my code samples
bleak gyro
they literally explain in the description
Ohhh yeah
I’m just on mobile so I didn’t really look at it too much
faint echo
do people have ideas or something for how a vim keybind plugin should work
feel free to ping me
spark pivot
i would use that frfr
dusk crystal
is there a built in way to get the user auth header?
austere talon
is there a built in way to get the user auth header?
dusk crystal
im trying to make api calls from the client to
https://discord.com/api/v9/users/@me/collectibles-purchases
austere talon
RestAPI.get("/users/@me/collectibles")
dusk crystal
wow thanks that's what I wanted to find
charred monolithBOT
charred monolithBOT
turbid hatch
npnp
charred monolithBOT
hollow slate
uh?
verbal pumice
for vencord
verbal pumice
alternatively try renaming the file to something other than index.ts
hollow slate
i did
verbal pumice
or if its a plugin with multiple files make a subfolder and put it's files there, dont throw it in the root of userplugins
brazen bone
uh?
User plugins usually go in src/userplugins/*/index.ts, not src/plugins/userplugins/index.ts
still wasp
is there something i can call to restart the client?
hollow slate
same thing
hollow slate
kay
hollow slate
try deleting the node_modules folder and reinstalling dependencies ig
same error
verbal pumice
what's the exact command you used to install dependencies
hollow slate
pnpm install --frozen-lockfile
verbal pumice
is the issue only for the userplugin? if you temporarily remove it does vencord build fine?
hollow slate
let me try
yeah
its an error for only user plugin
it builds fine without userplugin
verbal pumice
sec i need to check something
hollow slate
kay
brazen bone
is there something i can call to restart the client?
Check src/plugins/consoleShortcuts/index.ts's reload and/or restart
still wasp
Check `src/plugins/consoleShortcuts/index.ts`'s `reload` and/or `restart`
oh awesome that works perfectly, thanks!
hollow slate
kay
wait
in node-modules, discord-types is a shortcut folder
is it the reason its saying yk external?
huh
it has a shortcut icon but its not a shortcut
crude hearth
pnpm?
verbal pumice
in node-modules, discord-types is a shortcut folder
no that's normal it's a symlink
yeah no idea
hollow slate
damn
mortal fractal
pnpm uses symlinks to save space by having a centralized node_modules (aka .pnpm-store)
so you dont have to install say react everytime for every project that uses react (minus version differences but thats inevitable)
spark pivot
(Pnpm is the best)
spark pivot
Pretty sure I’ve gotten that before, try deleting node_modules and rerunning pnpm i
brazen bone
Currently trying to make messagelogger show a select bar instead of just showing all edits after each other
The functionality works great, but as you can see I'm no good at ui
slim marsh
Si;;y
spark pivot
This looks better
make it a message accessory, look at the translate plugin
spark pivot
its just for simplicity and it makes more sense
jaunty junco
i know my plugin isn't getting merged but how do you guys find these
verbal pumice
looking through react devtools for components which might call the functions you want or just educated guesses
brazen bone
I'm not sure how to do state management in react, so passing state between the accessory and the message renderer seems difficult
brazen bone
To select which edit to display
verbal pumice
are you modifying the MessageLogger plugin or making it a separate plugin
brazen bone
Modifying it
verbal pumice
yeah then just
subscribe to the MESSAGE_UPDATE event and update the display every time its fired?
maybe combine the one already there with the new one?
austere talon
i know my plugin isn't getting merged but how do you guys find these
two methods:
- you can search all code files by pressing ctrl shift f in devtools. just search by random keywords til u find smth interesting
- find a ui component that does what you want (like the voice channel component in your case) and use react devtools to inspect it. you can look at all props passed to it and jump to its source code. try looking at the onClick or the entire source and you'll see exactly what it does
jaunty junco
right thanks
brazen bone
I made a plugin that creates a tarball of all webpack modules
Very useful for that sort of searching
Haven't posted it yet because no perms though
I can't get this messagestore stuff working at all
My current useState method is way easier
austere talon
more context?
brazen bone
I'm making a selector for edit history instead of drawing it all, which wastes a lot of space. Someone suggested using the addAccessory api for it, instead of rendering free-hand. This requires communicating between the accessory and the message renderer, which I assume is best done via the MessageStore, but I can't figure out how to do that.
I tried ```js
MessageStore.getMessages(message.channel_id)
.update(message.id, v => v.set('currentEdit', n))
i think the way you did it is kinda terrible im ngl
i think it'd be better if you hid edits by default and then clicking the (edited) either toggles edit showing or opens a modal
brazen bone
That does sound better, yeah
Not a fan of toggling (wastes a lot of space, and is useless for comparing the differences between revisions), but modal sounds nice
dusk crystal
is there any type of plugin that isnt allowed?
woeful sable
How i Can give suggestion to the dev?
dusk crystal
would a plugin that updates the user's pfp automatically in an interval be allowed?
slim marsh
How i Can give suggestion to the dev?
u cant
slim marsh
would a plugin that updates the user's pfp automatically in an interval be allow...
no thats considered selfbotting
against the rules
dusk crystal
ohh i see
whats the best way for a plugin to have persistent storage?
i guess ill just edit a json file
brazen bone
There's always LocalStorage, but maybe vc has something else that integrates with cloud or somesuch
austere talon
whats the best way for a plugin to have persistent storage?
vencord settings api or DataStore
dusk crystal
from my understanding it automatically saves on updated props but also stores to cloud automatically if authenticated?
hmm it may just be PlainSettings
in that case it works well for me
austere talon
from my understanding it automatically saves on updated props but also stores to...
yes
PlainSettings is readonly
don't use it
if you don't want data synced use DataStore
dusk crystal
i see got it thanks
woeful sable
Ok
spark pivot
i just had the idea of checking every possible domain ending to see if there are any others
running it rn
verbal pumice
if theres any others they'd show up in search results cause otherwise what's the point
spark pivot
there are a lot more tlds then i thought
spark pivot
if theres any others they'd show up in search results cause otherwise what's the...
true
welp only one other one came up and it's just some random company
we good
spark pivot
https://github.com/MrDiamondDog/vencord-website-impersonation-checker
i added a reporter that runs every week
jagged cloak
lime stone
i added a reporter that runs every week
tbh what are you gonna do?