one day it will happen
#πΎ-core-development
shy veldt
shy veldt
did they actually revert it
yes
tame escarp
by god theyre actually here
austere talon
maybe it was really just oopsie
austere talon
by god theyre actually here
YES π
shy veldt
maybe it was really just oopsie
well,,, as i said
they reverted it to build from 16h ago
sooo could be
austere talon
im kinda tempted to dm him and ask why he's here cause im really curious
tame escarp
yes i also know how javascript works
its just weird for discord to do when they dont really care about supporting old browsers that much
mortal fractal
what if he reverted it because he was like "damn, i broke vencord"
austere talon
he was like aww shucks my custom plugins broke ://
tame escarp
PLEASE that would be so funny
austere talon
aweary is an avid fan of show hidden channels
shy veldt
he was like aww shucks my custom plugins broke ://
aww my decor plugin brokey :(
austere talon
it's true
shy veldt
does he use fart decor
yes
austere talon
BASED
shy veldt
naw
shy veldt
he doesnt have it now
austere talon
NOT TERRIBLE
tame escarp
we will ping
shy veldt
actually did he ever have the deco
tame escarp
not andgy though
shy veldt
am i trippin
tame escarp
who is ANDGY
austere talon
fake andgy
mortal fractal
i love discord staff they're so cool
a11y staff is chill
tame escarp
im kinda tempted to dm him and ask why he's here cause im really curious
theyre here watching us seeing when we fix something and then breaking it even more
they will switch from rspack to vite
junior olive
the real andy
cat owner he is real
mortal fractal
i love when i get suggested a hidden channel
mortal fractal
<@94904689279107072>
no mutuals sad
shy veldt
i only have 1 mutual
verbal pumice
FORMER CHILD
that's so awesome!! never seen that before
austere talon
is there valid user for vendetter
shy veldt
nop
mortal fractal
i will make /profile for vendetta
shy veldt
virus
shy birch
β/profile my beloved
shy veldt
β/profile my beloved
/stripe-webhook my beloved
limber skiff
of course they reverted it, their app actually broke
shy veldt
of course they reverted it, their app actually broke
me when staff couldnt use discord:
limber skiff
resetSocketOnError TypeError: e.isStaff is not a function
moment
limber skiff
now we wait for them to unbreak it and break some patches again
austere talon
i will make /profile for vendetta
nop
instead you will make valid user
way better
make it so that clicking on invalid mentions will fetch that user then open their profile
shy veldt
pov: discord
austere talon
yop
tame escarp
@ aweary confirm or deny
verbal pumice
one of yall is gonna accidentally ping him
limber skiff
I dont even know who is aweary
shy veldt
I dont even know who is aweary
Brandon Dail
Discord staff
aπ©
limber skiff
okay I see
tame escarp
one of yall is gonna accidentally ping him
thats half the fun of it
shy veldt
was leading a11y team before
mortal fractal
a11y staff is chill
me forgetting aweary is a11y staff
tame escarp
first one to accidentally ping gets a free cookie
shy veldt
me forgetting aweary is a11y staff
realest
mortal fractal
first one to accidentally ping gets a free cookie
i almost did on my alt earlier
shy veldt
first one to accidentally ping gets a free cookie
sooooooo
mortal fractal
i almost misclicked the wave button
tame escarp
lmao
limber skiff
first one to accidentally ping gets a free cookie
me?
shy veldt
soon you will get a message saying
"hi guys check #moderator-only :3"
tame escarp
@austere talon make aweary a cute people
lime stone
@keen blaze never sorry
arctic mesa
btw they do standups
where is this from?
arctic mesa
their internal bot
hhow do you have access to it is the better question
or is it a old thing
lime stone
:bee_movie:
shy veldt
:bee_movie:
you want it?
lime stone
maybe
shy veldt
shrugged
tame escarp
JSJSJSKEKSKEKS
yesssss do it you know you want to
arctic mesa
actually no isnt that the /commands format
lime stone
<a:bee_movie_1_1:395328794107576341><a:bee_movie_1_2:395328887552344064><a:bee_m...
AAA RULE 1 π . banned.
shy veldt
AAA RULE 1 π . banned.
wooo
austere talon
<a:bee_movie_1_1:395328794107576341><a:bee_movie_1_2:395328887552344064><a:bee_m...
average owo
austere talon
it makes my phone lag
arctic mesa
<a:bee_movie_1_1:395328794107576341><a:bee_movie_1_2:395328887552344064><a:bee_m...
i fucking love discord piracy
shy veldt
it makes my phone lag
ofc
shy veldt
i fucking love discord piracy
yeah thing is
austere talon
okay I see
shy veldt
this is from discord staff's server
arctic mesa
fucking what π
shy veldt
https://nitter.com/aweary
real page not found
austere talon
does that not work with nitter
austere talon
bro i just typed nitter and my auto correct almost made me a gamer
tame escarp
WHAT
austere talon
i noticed right before sending it
shy veldt
actually i think i typod one t for g and that's why
muscle memory? π
austere talon
NO
shy veldt
lime stone
<a:bee_movie_1_1:395328794107576341><a:bee_movie_1_2:395328887552344064><a:bee_m...
~~actually what if you report this π ~~
tame escarp
@austere talon cancellation coming soon
charred monolithBOT
austere talon
nuh uh
half notch
its joever
shy veldt
it sure is
austere talon
half notch
shy veldt
real
austere talon
im busy playing clash of clans
half notch
discord without vencord how will i ever survive
half notch
opening the stable client for the first time in like 4 months 
austere talon
how or why people daily drive canary is beyond me
shy veldt
get rekt
somber ginkgo
how or why people daily drive canary is beyond me
pressing ctrl+r to daily drive some shit that @shy veldt just datamined lifestyle
shy veldt
early access to annoying changes
junior olive
how or why people daily drive canary is beyond me
i installed it when discord first added categories bcuz i wanted to try them
and then that stuck with me even after not using discord for years
shy veldt
also canary has x64
ptb does too
junior olive
imagine needing a specific client for x64,,,
shy veldt
imagine needing a specific client for x64,,,
personally i use discord staging
somber ginkgo
discord development
canary, but with free electron security vulnerabilities
half notch
x86 crashes so often that its genuinely annoying
leave discord open for more than an hour and it crashes
austere talon
install vesktop now
half notch
the other half of my entire internet presence revolves around a game that uses EAC
could never use linux if i wanted to lol
somber ginkgo
install vesktop now
add global hotkeys NOW 
somber ginkgo
real and true https://the.yog.zone/78MJjVQ.png
half notch
i forget that vencords install is isolated so it can be used across diff clients
just reinstalled it on stable for the time being lol
shy veldt
real and true https://the.yog.zone/78MJjVQ.png
chat is this real?
somber ginkgo
yearly reminder that keyboard mode fucking SUCKS
plugin to disable it entirely instead of fucking overriding keybinds when
half notch
textreplace filters didnt transfer back to stable π
austere talon
ye they don't
frail skyBOT
half notch
austere talon
exploded again ol
half notch
discord got their employees working the week before the holidays lort π
limber skiff
oh wait I think I know
austere talon
okay i fixed the crashing
charred monolithBOT
half notch
charred monolithBOT
frail skyBOT
austere talon
wdym
limber skiff
look at how many patches
half notch
do i dare open canary
austere talon
look at how many patches
yeah cause they changed their bundler settings
we're going back to stoneage
limber skiff
not again
austere talon
most fixes are easy tho
half notch
do i dare open canary
oh yeah its very scuffed lol
limber skiff
I'm gonna cry
austere talon
theme issue
half notch
austere talon
vencord theme still works flawlessly
vencord theme literally survived both rspack and what they did just now
its cause the themes hardcode classes
half notch
guess ill have to wait for the creator of the theme to fix it
limber skiff
brb will continue to debug reporter after
half notch
gonna stick to stable for the time being
austere talon
jumpscare
hallow kestrel
profile decorations getting scary nowadays ^
limber skiff
cause it confuses me a lot
what does confuse you
austere talon
makes no sense
why polyfill es6 again
its pointless
cause they literally use es6 features in other places
limber skiff
true
shy veldt
insane
shy veldt
do u think he will bite my head off
no
austere talon
i asked him if the change was intended and showed him that discord still uses es6 in many places
tame escarp
bro ur fucked
limber skiff
oh hell nah
somber ginkgo
its cause the themes hardcode classes
meanwhile im out here using attribute selectors for literally fucking everything 
limber skiff
just to make sure that plugin doesnt explode vencord
LOL
possibly vencord
I forgot a word π
austere talon
possibly Vencord
somber ginkgo
a distinct chance
austere talon
i love undefined.js
@limber skiff maybe we could make reporter run more than once a day
so we catch issues faster
have it run every few hours or smth
so it doesnt spam this channel like crazy, we could make a dedicated channel for it and have it edit the old message https://discord.com/developers/docs/resources/webhook#edit-webhook-message
slim marsh
or post here only if it errors or something
mortal fractal
did they ununrevert again
i swear to god if we're having another moment where the ci keeps building using mobile's config for web
mortal fractal
i mean everything is working normally rn
austere talon
not for me anyway
i dmed brandon and he said it was unintentional
and now its reverted
soo
mortal fractal
i swear to god if we're having another moment where the ci keeps building using ...
am i potentially right?
austere talon
ig its gonna stay reverted?
olive aurora
reporter should run every 30 seconds but using a random token from vencord_tokens.csv
austere talon
TRUE
austere talon
yes
nimble plaza
wha
half notch
canary seems to be working fine again, for now
unless i wasnt paying attention and you guys fixed it already lol
nvm i see they reverted it lol
rapid walrus
<@&1026509424686284924> is this plugin broken ?
nimble pendantBOT
limber skiff
@verbal pumice is that fix actually still needed or is it fixed
limber skiff
I see
limber skiff
<@235834946571337729> maybe we could make reporter run more than once a day
once a day seems fine, and when big stuff changes we notice way earlier anyways cuz people say
for those cases we can run it manually already to see what it needs fixing
also having it post message here makes us aware of the results easier since it's a channel we look at frequently
charred monolithBOT
woeful sable
how does one make vencord plugins
charred monolithBOT
lone charm
how can I read/write to the vesktop config file?
still wasp
how does one make vencord plugins
woeful sable
https://github.com/Vendicated/Vencord/blob/main/docs/2_PLUGINS.md
ty
charred monolithBOT
shy veldt
did u dm discord employee
ye
lime stone
LMAO
charred monolithBOT
charred monolithBOT
Here's how the ZWJ issue looked like (pretty funny if you ask me):
Now it works correctly:
placid wave
https://github.com/Vencord/Vesktop/pull/283 @turbid hatch are you able to give this a look sometime? ven seems busy and i'd love for vesktop's flatpak to not be a janky experience for everyone installing it on a deck
i've tested it on my deck and it works both under flatpak and as an appinmage
turbid hatch
i was waiting on feedback for the fp
placid wave
i was waiting on feedback for the fp
for the flatpak?
placid wave
is there any way I can help with that?
turbid hatch
compile it and run it under the flatpak using the finstructions
uhh
ask ven on how to do it
placid wave
im unsure if it works with current changes, but it works on the version at the time that pr was made
but there's nothing that should have broken
turbid hatch
you will have to note that it wont be in the flatpak for a while
placid wave
I can retest today though if needed
turbid hatch
a new version of vesktop will need to be published first
placid wave
yeah
turbid hatch
actually
placid wave
the Nvidia one I would hold off on
until it's more tested
but the steam one should work
turbid hatch
@ me when a new vesktop release occurs
turbid hatch
yep
uhh @still surge just double checking with your fp pr
is that all that's needed for it to build?
turbid hatch
if so ill merge it as is
still surge
Oh, I forgot to explain the issue with it
It solves the issue with git not being available, but when you change the location, the flatpak can't access the root of the repo
Because we give it access to Vencord/dist and not Vencord/
austere talon
https://github.com/flathub/dev.vencord.Vesktop/pull/6/
do we really want this in the normal flatpak
this is gonna be pointless for 99% of users
turbid hatch
im unsure, it would provide a feature thats supported by the app but its expensive so
charred monolithBOT
turbid hatch
also ^ this is correct, my assumption due to the name is that this is a fifo
charred monolithBOT
placid wave
yeah it's a pipe that's why flatpak can't sanely mount it
placid wave
yeah it's a pipe that's why flatpak can't sanely mount it
cc @still surge if you know anything about this since none of us have found a way around it https://github.com/flathub/dev.vencord.Vesktop/pull/5/files#diff-2e3eefd459a53d9ad71b3c12949154c82e38921bcbc50a56cfbf43edfd67080dR25
would be super nice if there's any way to mount just the pipe without mounting the entire steam client directory in
still surge
I'm not sure tbh
placid wave
yeah it just sucks since you have to give it write access to all of steam
since it's the same directory
still surge
Yeah Flatpak's --filesystem is only for directories
placid wave
I assume there's no option for pipes yet?
still surge
I don't know what pipes are, so I can't comment on it
turbid hatch
I don't know what pipes are, so I can't comment on it
unix socket without the protocol
just bytes
best comparison i can give you
still surge
Yeah... I'm still clueless about it π
placid wave
maybe I should open an issue on flatpak
still surge
Go for it
austere talon
i would still change the fifo write to writeFileSync or use a queue to make sure its synchronised
placid wave
It should already be sync...?
placid wave
I don't think async writes to a special file are allowed in nodejs
like I think you can only do that with a normal file
livid heath
better safe than sorry
austere talon
^ "i think" isn't enough
placid wave
the steam protocol does get called instantly then so I don't really think it's a problem?
I mean sure change it I just don't realistically see how it could be an issue
placid wave
^ "i think" isn't enough
sorry I had no way to know about this as no feedback was given until after I pinged and it was merged
austere talon
async writeFiles can race. i googled and apparently writes to pipes up to 4k are atomic
what if an attacker feeds a longer than 4k string into your function, then immediately calls it again in a way that makes the two writes race and somehow creates a malicious command
it's very unlikely but still better be safe than sorry and end up with a sandbox escape somehow
livid heath
gl with overlapping writes
placid wave
there really isn't anything malicious you can do with the steam url protocol tmk but sure change it
placid wave
it's not a command
it's just idiotic
they make the syntax like a command
it doesn't run that
austere talon
// replace ' to prevent argument injection
`'${process.env.HOME}/.local/share/Steam/ubuntu12_32/steam' '-ifrunning' '${url.replaceAll("'", "%27")}'\n`,
then why do you talk about "argument injection"
placid wave
you can pass some normal steam arguments there and it will parse them as if you're running steam with those arguments
however you aren't
this does not start a new process
it parses them in the current steam process they just reuse the deranged syntax
If you pass in a binary path other than steam nothing happebs
and it doesn't have the same delay you always get when running the steam binary to execute a uri
since it never calls into the updater
livid heath
```js
// replace ' to prevent argument injection
`'${process.env.HOME}/....
HOME="/path/to/exec args # "
ez injection
placid wave
doesn't work
livid heath
oh it ignores other paths
placid wave
it's not a shell, it's not running a process
livid heath
i see
placid wave
steam parses this as if it's steam's command line options but it does it in the already running process
hexed nova
How to i install it
placid wave
oh my god
livid heath
How to i install it
placid wave
vns
nimble pendantBOT
placid wave
```js
// replace ' to prevent argument injection
`'${process.env.HOME}/....
The reason for this tho is
for the open url one
if ur url has quotes
it breaks the url
austere talon
sorry I had no way to know about this as no feedback was given until after I pin...
it's not my fault lewi merged early without proper review
placid wave
it's not your fault i got no response for two weeks after pinging you multiple times for any kind of response even if it's a delay
turbid hatch
it's not my fault lewi merged early without proper review
my understanding of pipes means that what is being described here is impossible
O_NONBLOCK has to be set for the underlying calls to be async
but from my understanding of how the steam pipe is set up it doesnt have this flag
placid wave
if you have steam installed on your pc just run it and that file shows up and you can poke around with it using echo -n iirc
placid wave
```js
// replace ' to prevent argument injection
`'${process.env.HOME}/....
I think the real reason it's like this is
when you run that as a normal command
the steam binary starts
sees thst there's another instance
and writes it's own entire commandline into that pipe
to let the already existing process handle parsing it
turbid hatch
the way this system works is a bit strange
turbid hatch
but yes, my understanding is you cant cause a race condition because unix itself will block the engine from making the write call
until it is read by steam
hence it is safe to merge in its current state and i see no issue in doing so
i did do my review
:p
thick kestrel
Yeah... I'm still clueless about it π
it's a file you can write stuff into, and then you can read the stuff from it in the order you wrote it. when you read the stuff, it disappears from the file.
in technical terms, it's a byte queue in form of a file
austere talon
but yes, my understanding is you cant cause a race condition because unix itself...
like i said, writes are only atomic up to 4k so you might be able to cause a race condition with larger than 4k writes
turbid hatch
i do not see this 4k limit in the manual, where did you read it?
austere talon
and why even speculate on things we don't know if we could just write it safely by using writeFileSync
placid wave
then change it
austere talon
don't rush merges, you already also rushed the start minimised pr 
turbid hatch
the way that is worded is strange because the actual manual page is described as "if the pipe is full, then a write(2) will block or fail, depending on whether the o_nonblock flag is set"
placid wave
IF YOU PURPOSELY IGNORE ME FOR TWO WEEKS I HAVE NO IDEA WHAT TO DO
turbid hatch
but here it's saying if you hit the pipe_buf then it'll just let you write more but it wont be atomic? so.. what?
that sounds like it violates unix spec if it does that...
what is rms smoking
austere talon
IF YOU PURPOSELY IGNORE ME FOR TWO WEEKS I HAVE NO IDEA WHAT TO DO
relax
i also have other things to do
turbid hatch
don't rush merges, you already also rushed the start minimised pr <:BataanCry:66...
i actually thought this one was fine after looking through it, thats why i merged it because i looked into how pipes and stuff work before i just forgot to comment
turbid hatch
<:ConfusedThinking:924310723981611009> the way that is worded is strange because...
https://man7.org/linux/man-pages/man7/pipe.7.html src btw so that it doesnt sound like i made it up
placid wave
i do as well and when someone asks about a pr i tell them I'm busy with other stuff and I'll get to it when I can, sometimes an approximate eta
i don't just completely ignore their question for weeks
turbid hatch
https://www.gnu.org/software/libc/manual/html_node/Pipe-Atomicity.html
i wonder if this is a glibc thing?
turbid hatch
https://man7.org/linux/man-pages/man7/pipe.7.html src btw so that it doesnt soun...
because this is the actual behaviour in the kernel
in which case, fuck me that's stupid if the libc does that
thick kestrel
in technical terms, it's a byte queue in form of a file
in Unix terms, a named pipe is a pipe that's named (has a path). Unix already has pipes, but they are ephemeral: doing curl | less makes a pipe from curl to less, but if you had a named pipe pipe, you could do curl > pipe & less < pipe which is equivalent
turbid hatch
they dont seem to have any technical information on how the steam pipe works, beyond that steam itself uses it if you run a duplicate instance to forward the command to the original instance (which is actually quite smart im going to steal that idea)
if multiple applications write to the pipe, assuming libc's explanation holds true, then it will simply just wait until each program finishes writing before allowing another to do so
in 4096 byte chunks
if an app goes over that limit, it means another app might be able to inject data into the pipe at the same time
in which case, you're fucked anyway
if not, then your app just carries on with its write call
austere talon
i also tried 100k
turbid hatch
yeah
austere talon
lolw rong video
turbid hatch
there doesnt seem to be an attack vector here, just a data corruption vector if steam itself decides to try and write something
turbid hatch
like even taking the worst case scenario into account there isnt anything really particularly bad that can happen
placid wave
seems ok to me
austere talon
actually nvm?
turbid hatch
hm?
austere talon
turbid hatch
if an app goes over that limit, it means another app *might* be able to inject d...
correction to the assumption then
it means another write call can go through
in which case this is still a data corruption thing, since itll just fuck up the order of writes non-deterministically
austere talon
i tried again with writeFileSync and it doesn't happen
turbid hatch
since it wont run the write calls on the thread pool
itll run them on the main thread
so the order becomes deterministic
that does make sense but what happens during that? does the entire app pause until the writes go through?
charred monolithBOT
austere talon
yes
turbid hatch
in which case
what if something isnt on the other end
you just crash?
since fifos need to be read
austere talon
or just use a promise queue
placid wave
if steam goes down your app goes down
that's how the gamescope session works
impossible condition
austere talon
import { writeFile } from "fs/promises"
let p = Promise.resolve();
function writePipe(content) {
p = p.then(() => writeFile("/tmp/pipe", content));
}
writePipe("a".repeat(100_000))
writePipe("b".repeat(100_000))
writePipe("c".repeat(100_000))
writePipe("d".repeat(100_000))
writePipe("e".repeat(100_000))
ig
austere talon
heres how to do it with promises
turbid hatch
promise queue is probs the best way
turbid hatch
lets patch
placid wave
you will do
placid wave
lmk when done and I can test
turbid hatch
let me get food forst
austere talon
```js
import { writeFile } from "fs/promises"
let p = Promise.resolve();
functi...
this is how vencord settings saves work
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/main/ipcMain.ts#L123-L125
**ipcMain.ts: **Lines 123-125
ipcMain.handle(IpcEvents.SET_SETTINGS, (_, s) => {
settingsWriteQueue.push(() => writeFile(SETTINGS_FILE, s));
});
WTF IS A VODKA SANDWICH
real zenith
does the vencord injector script thingy available in the dev env have some support layer for vesktop?
real zenith
does the vencord injector script thingy available in the dev env have some suppo...
injector script as in pnpm inject
austere talon
LMAO WHAT IS THAT
austere talon
does the vencord injector script thingy available in the dev env have some suppo...
scroll down in vesktop settings
keen blaze
LMAO WHAT IS THAT
SORRY WRONG REPO HJUHTGVHJ
stoic echo
sorry wrong repo
turbid hatch
@placid wave test when free
real zenith
scroll down in vesktop settings
are you telling me vesktop has been loading the default vencord files also used for the vanilla client this entire time
turbid hatch
yes!
charred monolithBOT
turbid hatch
yes
real zenith
les go
lime stone
real zenith
rickblock 
still surge
it's a file you can write stuff into, and then you can read the stuff from it in...
Thanks
wet trellis
I was testing that and I clicked the wrong button π
charred monolithBOT
spark pivot
Not this again 
wet trellis
why do people just want more badges
long stream
why do people just want more badges
ego boost
charred monolithBOT
dapper crest
Brain rot
charred monolithBOT
real zenith
does the userplugins dir accept tsx components just like normal plugins?
charred monolithBOT
real zenith
does the userplugins dir accept tsx components just like normal plugins?
or rather, what is the diff between the two folders?
austere talon
nothing
real zenith
oh
charred monolithBOT
livid heath
It's client side though?
self appreciation then
real zenith
I'm assuming when pnpm injecting vencord
- the updater is not gonna be available
or - updating vencord through the in-app updater is gonna void local changes,
correct?
didn't have time to test yet, forgive me 
real zenith
wait what happens if the user doesn't have git installed-
nimble plaza
it doesnt work then
real zenith
anyways, wouldn't git pull wipe local changes
nimble plaza
doesnt do anything
nimble plaza
anyways, wouldn't git pull wipe local changes
no
verbal pumice
anyways, wouldn't git pull wipe local changes
if you have local changes in non-userplugins folder updating will just fail
real zenith
oh so that's why there's a userplugins folder 
austere talon
wait what happens if the user doesn't have git installed-
not possible
you can't build vencord without git installed
lime stone
actually, i had an issue when using the devbuild with flatpak and it not being able to access git
charred monolithBOT
real zenith
you can't build vencord without git installed
ok right, but the prod built also got the updater
real zenith
oh
thick kestrel
(I also closed the other discussion, but the webhook doesn't show that it seems)
thanks for reviewing btw
you can take a look at my other MRs if you want
turbid hatch
you
dont use the installer
you just point your vesktop install to your custom vencord
thick kestrel
~~you can take a look at my other MRs if you want~~
also rebased with main
thick kestrel
oh
well then need to rebase again
and rebase all my MRs probably
I think I started all of them from main lol
lime stone
oops
i meant [class^="reaction_"]
basically to match the start for when the hash changes
thick kestrel
well then need to rebase again
I don't
main and dev are currently at the same commit
good
but I will start from dev and rebase with dev from now on
I need to change the base branch in all MRs anyways
thick kestrel
basically to match the start for when the hash changes
so this can change between updates? eh...
I assumed it's generated but constant
I need to fix my theme as well then
wonders of being new to thing
(in this case Discord modding)
thick kestrel
I need to change the base branch in all MRs anyways
done
thick kestrel
and done
thick kestrel
use merge commit
okay, gonna keep that in mind in the future
I just mostly use rebase instead of merge since it looks cleaner in the history
if it isn't a branch people would normally work on
austere talon
I just mostly use rebase instead of merge since it looks cleaner in the history
yes but that implies only to main branch
not pr branches
spark pivot
real zenith
Does Vencord have some fancy method that allows code injection into the electron backend (if available)
stoic echo
why didnβt you just
nimble pendantBOT
stoic echo
oh wait
spark pivot
i was posting the picture from the github convo
stoic echo
iβm stupid
real zenith
lime stone
you mean C++? 
real zenith
welp, vencordnative it is ig 
lime stone
what did you mean? there might be a way to do it but i probably wouldn't know lol i'm just curious what that cursed thing is
lime stone
ohhh
isn't that against the whole fancy sandboxing thing (i don't know the word adsjashdkjsajd)
real zenith
yeah, ig
lime stone
uh i mean like it's impossible to require("child_process") from the rendering process for security reasons right?
real zenith
uh i mean like it's impossible to require("child_process") from the rendering pr...
yeah, the render process isn't even node afaik
so idea would be to use vencordnative to send an event from the frontend to the main process ig
.. event? idk what electron calls these
real zenith
<-- has zero idea what she is talking about
real zenith
wait hol up
does vencordnative apply to vesktop or does that require some extra fancy cloned code β¨
austere talon
Does Vencord have some fancy method that allows code injection _into the electro...
yes
real zenith
the vencordnative ipc thingy ig, right?
austere talon
native.ts file in ur plugin folder
real zenith
err what
austere talon
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/5dee2e8549de195f7bdb213ce7bb7f6dde840...
**index.ts: **Line 48
const Native = VencordNative.pluginHelpers.OpenInApp as PluginNative<typeof import("./native")>;
**index.ts: **Line 89
url = await Native.resolveRedirect(url);
it's quite simple
- add a
native.tsfile in your plugin. this file can have any nodejs code. it can also export functions that will be available to your plugin to use (via ipc) - if you exported any functions, you can use them as done by the OpenInApp plugin (the example i linked)
austere talon
that seems way too simple
it's actually not that simple but i made the build script autogenerate bindings
turbid hatch
vencord is very compiler powered its fire
austere talon
there's more going on under the hood but you don't see any of it :p
real zenith
vencord is very compiler powered its fire
yeah I've noticed
I was kinda suprised how easy adding a plugin was
austere talon
it's actually not that simple but i made the build script autogenerate bindings
normally you would need to
- register an ipc event listener in the main process:
ipcMain.handle("SomeEvent", someCallback - expose a function to invoke this event to the renderer in the preload process:
contextBridge.exposeInMainWorld("callMyFunc", () => ipcRenderer.invoke("SomeEvent")) - now it'd be available in the browser as
callMyFunc()
but the build script auto generates code that does that for you, all you gotta do is export a function from native.ts and done
real zenith
oh yeah.. I've used electron recently (haven't in years) and to this day I don't understand why the exposeInMainWorld is necessary
like yeah security.. but then just don't define an ipc handler for something you don't want the frontend to call
idk I'm probably just dumb
turbid hatch
because there are other things than what we're doing that can expose stuff to the main world
real zenith
placid wave
contextbridge is a terrible horrible API that never should have existed
real zenith
^
austere talon
contextbridge is a terrible horrible API that never should have existed
how
it's really good lol
shrewd crane
Is there something in the existing vencord api that lets me run code every time a user types a new character into the message input?
Or do I have to figure out a way to watch the state of the react component for changes in it's text value
spark pivot
Or do I have to figure out a way to watch the state of the react component for c...
You are wayy over complicating it
Just get the input and add an event listener
Easy
If you want to modify it though then the react state would be best
thick kestrel
not pr branches
I do it like this on my personal projects (which, keep in mind, I am the only developer for - I'm not experienced with collaborative git, though I heard people often use a similar approach):
- create feature branch
featurebased off master branchmaster - work on the feature and commit stuff to
feature - have some changes done to
masterthat makefeaturebe unable to be merged anymore - rebase
featureoffmasterand resolve conflicts - do further work on the feature
- merge
featureintomaster
that's why I just did the same thing here, unaware of that this project prefers master to be merged into feature instead of being rebased
turbid hatch
what
our branch flow is the same except you replace master with dev
all work happens on the dev branch
then when its done, dev gets merged into main
we very rarely push commits straight to main
thick kestrel
guess there's a misunderstanding somewhere then...
#πΎ-core-development message here Ven said that I should use a "merge commit" instead of "rebase merge" (which I think means merge and rebase, when translated from GitHub terminology to Git terminology, no?)
turbid hatch
we dont use rebases because they cause issues
when we merge prs
and also it dirties the commit history
we use squash and merge
but that shouldnt matter
thick kestrel
for feature -> master, yeah, that's what I do as well
turbid hatch
you need to base your PR off of dev
not main
usually we will fix it for you if its wrong since we can do that
thick kestrel
but for master -> feature I prefer rebase, while the project prefers merge as well (if I understand correctly), which I wasn't aware of
turbid hatch
just use git pull
it will create a merge commit
it'll get squashed down
dont rebase
thick kestrel
you need to base your PR off of dev
yes, that part I get now, my master is your dev, not your main (this layout is called Gitflow I think)
turbid hatch
yes, except we dont use release branches
nor do we use hotfix branches
main is preserved to the best of our ability to be the golden standard release branch containing the latest version of vencord
dev is the next version with new fixes and features
thick kestrel
nor do we use hotfix branches
yeah that wouldn't much sense in a project like this would it
turbid hatch
i mean i dont really see the point of them in the first place
maybe its just cause im not an enterprise developer
thick kestrel
that's for corporate/big projects where you support multiple versions at once
turbid hatch
true gitflow is an extremely complicated solution that i have never really seen used in the wild
i mean at work we use a single branch via svn and that works just fine for our dev workflow
but anyway
thick kestrel
it will create a merge commit
if I use git pull while feature is checked out it'll just pull from origin/feature, not upstream/dev (where origin is my fork, upstream is the official repo) since that's what it tracks
to create a merge commit I'd need to git fetch upstream then git merge upstream/dev
turbid hatch
do git pull origin master
thick kestrel
you mean upstream?
thick kestrel
(where
originis my fork,upstreamis the official repo)
thick kestrel
I don't know what it'd do without checking the docs but I guess it's just fetch-then-merge but shorter
turbid hatch
git pull is git fetch && git merge (there are rules internally for if it does a fast-forward, rebase or merge, but it basically boils down to this)
austere talon
but for `master` -> `feature` I prefer rebase, while the project prefers merge a...
you don't force push in feature prs
feature prs are squashed into one single commit once they're merged into the main branch
so the history in prs is irrelevant
force pushing makes it harder to understand how the pr changed over time and messes up reviews
thick kestrel
okay, so the project does prefer merge here. understood, won't do it otherwise anymore.
thick kestrel
`git pull` is `git fetch && git merge` (there are rules internally for if it doe...
somehow I never realized it but yeah this is true!
turbid hatch
i mean the first line of the docs gives it away
Fetch from and integrate with another repository or a local branch
turbid hatch
i do recommend reading all of the man pages for git - as boring as they are it gives good technical insight into why certain things happen or break
thick kestrel
I always just used git pull for one thing only - update the current branch from a remote. I didn't realize "update the current branch from a remote" actually means "fetch the local copy of the remote and rebase the local branch off it"...
the only parameter I ever used for git pull was a origin-http remote that's just the regular origin but over HTTP lol
for more complex stuff I always fetched then rebased/merged
thick kestrel
the only parameter I ever used for `git pull` was a `origin-http` remote that's ...
(the reason is school firewall if you are wondering)
(they block TCP 22 for some reason jfkdlas)
also sorry if discussing with me is a pain, the language barrier hits me hard during technical discussions
well, honestly any discussions
mine english no good sory
tame escarp
also sorry if discussing with me is a pain, the language barrier hits me hard du...
only the ppl who have like perfect english say this
always i swear
charred monolithBOT
bleak gyro
Does anyone know the flux event for when someone accepts your friend request?
austere talon
look through the list of flux events and you'll likely find it
bleak gyro
oh yeah i got it: RELATIONSHIP_ADD
austere talon
that contains blocks and stuff too
charred monolithBOT
shadow mango
how do i get past cors
specificallyl
other ones like wikisearch send requests to wikipedia fine
charred monolithBOT
shadow mango
figured it out (i added all the access control allow origin headers + the ones need for the options request)
livid heath
specificallyl
use https, pisscord allows https connections to localhost
shadow mango
is pisscord vencor
livid heath
I mean it's in the stock discord cors list
so shouldn't really matter (it should work with Vencord)
shrewd crane
Just get the input and add an event listener
That was my first try. I added an event listener for the "input" event to the contenteditable div that is the input field, but it did not work
I am trying to create a charCounter plugin, that let's you see how many characters you wrote, so you see if you are over the limit, and by how much
olive aurora
patch the component that displays char count when you're near/over the limit to always display
livid heath
Ryan already made a chat counter plugin
olive aurora
wasnt it the evil ryan
livid heath
also instead of using input event patch the slate wrapper
livid heath
wasnt it the evil ryan
the Ryan who got banned
real zenith
is there some way to register custom settings tabs?
livid heath
there sure is
olive aurora
i think that completely replaced the char counter for no reason
real zenith
(inside the vencord category)
livid heath
i think that completely replaced the char counter for no reason
ah i see
real zenith
the settings core plugin got a makeSettingsCategories(SectionTypes: Record<string, unknown>), but that doesn't seem to do anything on my end
not sure where/how I'm supposed to call that, doesn't seem to be doing anything by itself
livid heath
Ryan already made a chat counter plugin
real zenith
the settings core plugin got a `makeSettingsCategories(SectionTypes: Record<stri...
wait hold up I think I'm stupid
I didn't see the patch
real zenith
ok err
super simple question, but I'm dumb
how do I only replace the second match group of a patch regex
sweet night
copy paste
verbal pumice
how do I only replace the second match group of a patch regex
wdym
can you show your patch
real zenith
tbh I got no clue what I'm doing, there's probably a better way to do this without modifying the core plugin
/onClick:.{0,20}=>{(await..{0,100}"Update Success!".{0,200}onCancel:\w}\)}\)\))}\)/
I'm basically trying to replace what the update button does, and this is probably the worst way to do it
real zenith
real zenith
what
sweet night
what
real zenith
wait hol up what am I supposed to put into the "find" thingy
real zenith
tbh I got no clue what I'm doing, there's probably a better way to do this witho...
ok I'm clueless by now
patches: [{
find: 'Update Now', // This prepends the check button, so I thought I might as well use that for now
replacement: {
// match: /onClick:.{0,20}=>{(await..{0,100}"Update Success!".{0,200}onCancel:\w}\)}\)\))}\)/,
match: /onClick:.{0,20}=>{await..{0,100}"No updates found!".{0,200}}/,
replace: "onClick: () => (console.info('test :3'), $self.forceUpdate(), $self.reloadPlugins())"
}
}],
```idek what I'm doing you cant patch vencord's code lmao
real zenith
austere talon
I mean it's in the stock discord cors list
so shouldn't really matter (it should...
csp != cors
lime stone
why would you modify vencord itself in a plugin
real zenith
I felt like overriding the files itself would break the entire thing if they ever get breaking changes
charred monolithBOT
limber skiff
π
thick kestrel
can you use Vencord plugins in Vencord tho
shadow mango
does someone know how i can get the messages when you go into a channel
i wrote a voice message transcriber and im watching for message create but that means it doesnt work on old messages
charred monolithBOT
Discord recently introduced a "Capture Devices" option to screen sharing that allows you to directly stream the video and audio of a capture device such as an external capture card to a voice channel / call.
It'd be great to see this implemented in Vesktop, if possible.
shadow mango
maybe i can hook into the voice message renderer or something?
spark pivot
maybe i can hook into the voice message renderer or something?
yes
shadow mango
is there another plugin that does something similar that i could look at
austere talon
maybe i can hook into the voice message renderer or something?
that'd be the cleanest way
use react devtools to inspect them and patch
spark pivot
ofc firefox has absolutely no support for it lol
austere talon
ofc firefox has absolutely no support for it lol
all browsers that implement it via an api
aka you're sending your audio to a remote server
ig mozilla either didn't like that for privacy reasons, or don't have the resources to do so
spark pivot
makes sense
quick bear
somewhat dumb question
is it possible for vencord to inject into Activities? if so, how difficult would that be?
I'm half tempted to see if I can modify the Watch Together activity since I don't wanna use it if youtube can track my watch habits and tie them to my discord account
I saw an invidious plugin in #1032200195582197831 but i dunno if that same functionality can be extended to that degree
austere talon
somewhat dumb question
is it possible for vencord to inject into Activities? if...
very easy