#👾-core-development
grizzled crow
Is the TypingIndicator plugin open source?
nimble plaza
all plugins are
grizzled crow
found it, thank you
austere talon
the easiest way to find source code is to go the plugin's page on https://vencord.dev/plugins and clicking the github button
grizzled crow
yeah I was looking through the GitHub's of the developers linked in the plugin settings page, haha
austere talon
what's with the approvals 😭
nimble plaza
spark pivot
what's with the approvals 😭
charred monolithBOT
mortal fractal
what's with the approvals 😭
i only did it because im on the devs list 😔
the rest are sheep
shut ridge
what's with the approvals 😭
the gang really want this PR
nimble plaza
masy for contrib :pitchfork:
mortal fractal
clearly
spark pivot
tame escarp
evil
nimble plaza
you love
shut ridge
aww i can't approve my own PR
charred monolithBOT
nimble plaza
shut ridge
mortal fractal
thinking about the bruh moment kernel panic pr
nimble plaza
the WHAT
mortal fractal
||i just remembered someone i knew that passed away approved that pr...||
mortal fractal
https://github.com/torvalds/linux/pull/684
this is like the pr that shows how small the world is because i know so many people
swift fjord
https://github.com/torvalds/linux/pull/684
nimble plaza
its horrible
limber skiff
@austere talon reminding you of branch protection
shut ridge
wtff
yeah i was looking at that and thinking "hmm"
decided i did not want to do regexing tonight but maybe another time
limber skiff
it's fine we all wrote bad regex in the past
charred monolithBOT
nimble plaza
watch cobu eat it again
austere talon
nah
it's a silly race condition
basically whenever you push a commit to github, it syncs to cobu
whenever you push a commit to cobu, it syncs to github
- push commit to github
- github syncs to cobu
- cobu syncs to github (nothing to do)
if you push a second commit between 2 and 3 it will eat that commit
limber skiff
what's the difference of a hidden setting and a private setting
austere talon
hidden is still handled by the proxy so it will handle default values and such
which also means you can only use a type supported by the settings api
limber skiff
oh
austere talon
private is not handled at all for you, meaning you need to handle default value yourself, but also allows arbitrary types
limber skiff
welp we dont have array type so I will just keep using private lol
austere talon
:p
limber skiff
I thought it was a nested destructuring
long stream
dummy
austere talon
try a force push (from a non conflicting branch, so rebase first lol)
i think u can force pushj but not normal push
limber skiff
nope
turbid hatch
disable the actions check
turbid hatch
then no force push for nuckyz :p
i meant disable it for one second to let him push
silly
limber skiff
disabling for every push is horror though
limber skiff
yeah ik
turbid hatch
cause its a personal repo not in an orv
org
unfortunately personal repo issues strike again
limber skiff
github kinda stupid with that
turbid hatch
it makes sense
they assume if multiple devs work on a project youll put it in an org
not keep it on one dev's account
thats why pretty much all of the multidev options are in orgs exclusively
limber skiff
it's still stupid that they limit it
turbid hatch
shrug
austere talon
u can push now
turbid hatch
discourages using personal accounts for orgs ig
limber skiff
what did you do?
austere talon
i disabled it :/
limber skiff
cool that works
austere talon
bad logic?
limber skiff
git push upstream dev:main
since tests pass
austere talon
mm
limber skiff
bad logic?
yeah it worked but the logic wasnt how it was supposed to be
austere talon
`git push upstream dev:main`
since tests pass
we could introduce a third branch and then u can first push to that
then to dev
cursed
limber skiff
it's still has the same result anyways
austere talon
limber skiff
lets try it
limber skiff
I mean it's the only way no?
austere talon
well i can just turn off required test
limber skiff
push
wait 30s
push again
it's finee
austere talon
well i can just turn off required test
it means u can merge without ci pass but like just dont merge without ci pass
limber skiff
I dont merge without ci pass
limber skiff
but again, if you want to keep it, it's fine
austere talon
rip auto merge
refinedgithub
limber skiff
the third branch works for me
turbid hatch
im fairly certain you cant just
close the tab after clicking automerge with rgh
which is what i do
austere talon
yeah u cant
limber skiff
@austere talon turn ci pass testing again I'm gonna test
turbid hatch
the protection rule doesnt make the ci run
turbid hatch
the rule just enforces that you cant merge without ci
austere talon
actually
limber skiff
or do we need to push to main
austere talon
why do we even make ci only run on those branches
why not make it run on all branches
limber skiff
true
turbid hatch
because we'll usually pr it
and then itll run the ci twice
once for the branch, once for the pr
they are separate events
and its sorta annoying and wastes time
limber skiff
this should work right
austere talon
yes
limber skiff
also can I rename test to Test
austere talon
insane
turbid hatch
yeah go for it
austere talon
oh fair
limber skiff
bro why is my vscode changing this automatically
austere talon
bro why is my vscode changing this automatically
LOL mine did too
limber skiff
did you turn on ci testing on dev
limber skiff
okay do
spark pivot
What mine did that too in my aoc repo
austere talon
actually idk if thats job name or workflow name
limber skiff
horror
limber skiff
e
austere talon
cant believe youre polluting dev with spammmm
limber skiff
I thought you had it enabled lol
austere talon
💢🗯️
austere talon
I thought you had it enabled lol
I FORGOT TO SAVE AGAIN
austere talon
u know how most github settings immediately save if u change a checkbox
branch portection makes u scroll down to the bottom for this button
i did now
turbid hatch
bro why is my vscode changing this automatically
yeah mine did too
i think that option is deprecated thats why its changing it
woeful sable
let embed = {
title: "Test Title",
description: "*mimimimimimi*",
type: "rich",
fields: fields,
video: {
url: "https://cdn.discordapp.com/attachments/1001667507809165472/1182136867634823249/minecraft-dog.mp4?ex=658399c0&is=657124c0&hm=e7187f073fd80a6ff3c47a610da088b0585b819b05bccde3619224bd5c0cc31e&"
}
}
return sendBotMessage(ctx.channel.id, {
// @ts-ignore
embeds: [embed]
});
Apologise for weird indentation, trying to send this embed through clyde but it's not showing the video, the other fields are fine
austere talon
NONO
austere talon
```js
let embed = {
title: "Test Title",
description: "*mimimimimimi...
u need to pass proxy_url and width and height
limber skiff
shit that isnt tested cuz I removed the commit
woeful sable
now force push test
isnt this scary nono
limber skiff
it's on dev
woeful sable
will overrite
limber skiff
not on main
austere talon
rm -rf .git
git init .
git add .
git commit -m "initial commit"
git push --force origin main
beautiful
limber skiff
pog it worked
woeful sable
u need to pass proxy_url and width and height
Can proxy_url be the same?
Doesn't seem to be working 😢
I'll read discord docs
austere talon
Doesn't seem to be working 😢
yes
austere talon
Doesn't seem to be working 😢
show ur code
limber skiff
what should I call my branch
austere talon
LMAO
charred monolithBOT
austere talon
yeah i understand
just saying in general we should always try the portal
the current code seems like you'd only use the portal on flatpak
charred monolithBOT
Summary of changes
- Update
GameActivityToggleicon to match new mute, deafen icons.- Before:
- After:
- Before:
Why this is needed
- Discord recently updated mute and deafen icons, so they no longer match.
sharp venture
: )))
austere talon
cause otherwise someone might accidently use this on non steamos without noticing
austere talon
@turbid hatch this needs a new perm on the flatpak:
- --filesystem=~/.steam # Needed for SteamOS integration, as the XDG OpenURL portal doesn't work properly in Game Mode. We only need ~/.steam/steam.pipe but Flatpak can't correctly mount just that: 'File "/home/deck/.steam/steam.pipe" has unsupported type 0o10000'
frail sky
cunning canyon
do ven not see the oneko pr 😭 it have been 2 weeks
adryd disables it in reduce motion so people forced to live with windows animation to have oneko
austere talon
who tf uses reduced motion
woeful sable
Would enabling reduced motion improve gaming performance
austere talon
closing discord will improve gaming performance
woeful sable
Okay is it possible to access Local Storage through vencords api?
austere talon
why
woeful sable
so useless
I have 1 alt I made with temp mail that I usually access through their tokens
woeful sable
I don't recall the original password
I mostly just use it to lurk in specific communities I don't want my main in lol
spark pivot
alright well good luck with your plugin ig
charred monolithBOT
I haven't tested it locally, because I was using a custom Vencord location
austere talon
untested changes <:fear:1126220232176975942>
i mean if u just change css it won't break anything :p
nimble plaza
fair
still surge
also yeah updater works <@848382340937023528>
The updater doesn't seem to work when I use a custom location
austere talon
The updater doesn't seem to work when I use a custom location
when you build from source it uses git for the updater which obv won't be accessible from flatpak
austere talon
you can fix it by giving the flatpak access to use flatpak-spawn (idk what perm that is) but that kinda goes against the point of sandboxing :p
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/main/updater/git.ts#L38
**git.ts: **Line 38
if (isFlatpak) return execFile("flatpak-spawn", ["--host", "git", ...args], opts);
yeah you'd need to include git inside the flatpak or smth
austere talon
but bundling git with the vesktop flatpak just for the 20 users who build vencord from source is a bit silly
if anything a separate release like dev.vencord.Vesktop.devel would probably make more sense (?)
still surge
We could use https://github.com/bilelmoussaoui/flatpak-github-actions and build flatpaks using GitHub CI
That's what we do with Bottles
woeful sable
meow
charred monolithBOT
analog knoll
@junior olive hi, how did your adventure with brew go in regards of vesktop?
analog knoll
Meaning you don't have to update manually much? Since i would appreciate it being in the brew repositories. Is there something blocking us from putting it there?
junior olive
i have to update manually a shit ton
but vesktop doesn't fit my needs
I use discord's official app as they added screen capture kit support
analog knoll
I see. Well shall I try putting it there though? It'll be put into quarantine after install most likely, but fortunately you can also include post install instructions that will display in the terminal after installing, that's how many packages do it
turbid hatch
We could use https://github.com/bilelmoussaoui/flatpak-github-actions and build ...
we can't submit them to flathub like this though
direct submit requires special privilege
turbid hatch
<@96269247411400704> this needs a new perm on the flatpak:
```yml
- --filesystem...
yop
analog knoll
is their name really tikka masalla 😄 It looks like windows/KDE plasma
still surge
we can't submit them to flathub like this though
It doesn't submit anything. It creates GitHub artifacts and uploads the .flatpak files for testing purposes
turbid hatch
yes, but ideally we'd want to submit them to flathub directly if we're building them ourselves
otherwise we're then maintaining two flatpaks
this is the issue OBS had
we should just stick to one source of truth, it's confusing otherwise
still surge
Why is it confusing? It's one source for testing purposes, and the other source for everything else
turbid hatch
because we're still trying to work out how we even want the flatpak to work fully
i'm working on like 3 different things for the flatpak for better functionality and build
and then i have to have another manifest for testing
it's going to make me explode
still surge
So it's less about confusion and more about tasks you're not willing to take, which is fair just to be clear
turbid hatch
it's confusion where we have two sources of truth for building two different flatpaks in two different repos
we have one that's shipped to everyone, in flathub, and one that we use for testing, in the vesktop repo
i then have to keep both of them in sync otherwise we'll end up with two builds that are done differently even though they should be the same
and that is not a task i'm willing to take on when there are more important things like actually having the flatpaks be built properly for flathub
currently they're not, it has an appstream file in the flathub repo and i need a new release to test if my changes will work before i deploy it
still surge
Yeah that's fair, I'm not pushing you to have testing flatpaks
The problem I was solving is extremely niche anyway
turbid hatch
unfortunately i'm not the most fantastic maintainer for this, my usage of flatpak has mainly been consuming rather than authoring
this is the first one i've ever authored and i have tons to learn about
still surge
That's fine, I respect your work :)
It's why I suggested to have git built with the flatpak
It's less maintenance in general and we can actually test an area that couldn't be tested inside the flatpak
turbid hatch
it probably is actually a good idea so i'll have to investigate on how to do it another time
just don't want to make the flatpak too large but i dont think git will be too bad
still surge
You can base it on another manifest
turbid hatch
yeah i'll take a look
still surge
I'm moderately sure you can just copy and paste
Sure
I can work on it, and submit an MR, if you want
turbid hatch
@placid wave re: steamos issues, flatpak install --user https://dl.flathub.org/build-repo/69617/dev.vencord.Vesktop.flatpakref
when you can
this contains the steamos perm in the flatpak
charred monolithBOT
placid wave
this contains the steamos perm in the flatpak
does it contain my changes?
it seems like it doesnt
so it's useless for now
turbid hatch
its just the perm
austere talon
yeah but it doesnt contain their changes xd
austere talon
so it's useless for now
u will replace the asar
placid wave
its just the perm
the perm needs the changes from the pr
austere talon
sudo cp your.asar /var/lib/flatpak/app/dev.vencord.Vesktop/current/active/files/bin/vesktop/resources/app.asar
do
austere talon
```sh
sudo cp your.asar /var/lib/flatpak/app/dev.vencord.Vesktop/current/active/...
i just checked that file and its bundling node_modules
whyyyy
i specifically configured it not to
it shouldnt bundle node modules...
placid wave
it shouldnt bundle node modules...
just use devdependencies
charred monolithBOT
austere talon
cause youre choosing dist?
we could change vesktop to have u select the entire vesktop folder
to work around that
still surge
to work around that
Yeah
proven sandal
is there a any way I can lookup a user's ID by his username?
ivory orchid
is this the correct place to make feature request for the spotify plugin ? if not can you point me to it ?
oak hull
#plugin-requests but closed
ivory orchid
F Is it opening up anytime soon ?
oak hull
no idea
warped turret
How can I load my plugin last (after all other ones)?
lime stone
yeah what do you actually want to do? that sounds worrying
you'd have to change the plugin loading code
i believe? 
crude raptor
amazing
warped turret
yeah what do you actually want to do? that sounds worrying
I want to create a plugin that allows to sort buttons on chat panel.
All plugins as far as I can see, use the same patch for adding a custom button and as the result buttons are added in alphabetical order by plugin's name
find: "ChannelTextAreaButtons",
replacement: {
match: /(\i)\.push.{1,30}disabled:(\i),.{1,20}\},"gift"\)\)/,
replace: "$&,(()=>{try{$2||$1.push($self.chatBarIcon(arguments[0]))}catch{}})()",
}
(what ?)
warped turret
what's the issue then?
The issue is that I need to wait for all plugins to load in order to have all items in the array to perform a sort
lime stone
create an API then lmao
oak hull
"sort buttons on chat panel." is this not possible with css or do you want to make it user friendly
nimble plaza
edit the chat bar api
lime stone
if it's not an API, make it 
warped turret
"sort buttons on chat panel." is this not possible with css or do you want to ma...
Yes even with a ui that displays the actual buttons and drag and drop ability on a separate modal
oak hull
good luck with that
grizzled crow
I don't have access to #1032200195582197831 , so I'll post it here. I made a small personal edit to the TypingIndicator plugin, adding the option to exclude the currently selected channel from the typing indicator.
It's basically my first time using Typescript, and I don't know what I am doing. Hope the code quality is acceptable, haha
crude raptor
if its an edit of a preexisting plugin i think the typical solution is to make a pull request for it on the github
and then hope it gets merged before the heat death of the universe
charred monolithBOT
grizzled crow
if its an edit of a preexisting plugin i think the typical solution is to make a...
Alright yeah, I can do that. It's like 10 lines of code or something really small though
warped turret
I don't have access to <#1032200195582197831> , so I'll post it here. I made a s...
What if I want to exclude multiple channels at a time?
It sounds really time consuming and unintuitive to open a channel first, head over settings and click on switch. Better add a context menu button
grizzled crow
yeah, it just excludes the channel you are in
crude raptor
honestly find it kinda odd that thats the default behaviour (haven't used it) lol
grizzled crow
like, I would get the typing indicator in css-snippets, but not vencord-dev with the option set to false
the default is true to maintain how the plugin works now
grizzled crow
honestly find it kinda odd that thats the default behaviour (haven't used it) lo...
It's the behavior in the BetterDiscord version of the plugin, haha
crude raptor
unusual !!
woeful sable
is there a any way I can lookup a user's ID by his username?
Ngl I don't even think that's possible with api in general
To my knowledge*
charred monolithBOT
This PR allows the user to choose whether or not the plugin's typing indicator appears on the channel sidebar of the currently selected channel.
The default value is TRUE, as to maintain the same functionality as previous versions of the plugin.
crude raptor
yippee !!
nimble plaza
@grizzled crow If you make any changes that arent tiny, u can add yourself to the devs for that plugin jsyn :3
grizzled crow
eh, I think this is a tiny enough change that adding myself to the authors would be a bit presumptuous
crude raptor
my dumb ass adding myself to authors because i came up with ideas and did some CSS for textreplace
shy veldt
grizzled crow
small tweak to previewMessage that changes the 👀 emote to a custom SVG that attempts to match the style of the default Discord icons
Before:
After:
austere talon
format it as a git patch instead
and i get the idea but that icon is hella creepy lmao
junior olive
👁️
grizzled crow
and i get the idea but that icon is hella creepy lmao
yeah lol I didn't know what to do with it, it is such a pain to make SVGs
rotating a 3d cow in my mind excersize as I look at the numbers and imagine how it is supposed to be
I built and injected it four times and then said, that's it
doing this without an IDE was a mistake haha
charred monolithBOT
This PR changes the SVG icon in the plugin previewMessage with one that attempts to closer match the style of Discord's chat bar icons.
Before:
After:
lucid blade
my laptop is haunted why does this happen
limber skiff
using the eye emoji is bad
limber skiff
???
that's not how it works buddy
you dont choose what manager to use on every project
the project decides and you use what it tells you to
lucid blade
boy do i love installing different package managers for every repo
limber skiff
crazy
grizzled crow
I would try to find another icon as a whole
what type of icon do you think would be better than the eyes?
this one is too wide IMO
grizzled crow
I'm just making small personal edits to some plugins I use. My flat :eyes: svg is better than 👀, and that is good enough for me
lucid blade
this one is too wide IMO
then make is square-er
throw it in a box and make it fit the container
grizzled crow
doesn't look too bad actually
lucid blade
what about with the new discord icons
ik they changed a bit of spacing with stuff
they're like smaller kinda
or maybe that's just me
grizzled crow
completely forgot to test with them on lol
lucid blade
is there a specific way to format PRs or do you just do whatever for the title and desc and stuff because there is very little information on contributing in the markdown file
grizzled crow
I just looked at what other people did
and here is how it looks with my updated padding on the new icons
old icons:
charred monolithBOT
Alternately, use the same icon that Discord has for these types of messages.
austere talon
boy do i love installing different package managers for every repo
corepack enable
qhar
austere talon
run that command
inbuilt nodejs feature that automatically does it for u and makes u use the right package manager
lucid blade
m
austere talon
is that debian
lucid blade
technically yes
austere talon
blud got the stone age nodejs
lucid blade
i have 18.13.0..
lucid blade
last i saw it was the most up-to-date in the ubuntu repo
austere talon
corepack is pretty cool https://nodejs.org/api/corepack.html
lucid blade
i should probably upgrade it anyway
austere talon
last i saw it was the most up-to-date in the ubuntu repo
yeah ubuntu does that (giving u super old versions)
charred monolithBOT
lucid blade
yeah ubuntu does that (giving u super old versions)
i would use another distro but this is an old ass laptop and im too used to ubuntu
i also rarely use this laptop anyway
i have a desktop pc my ethernet cable running under the entire house is just broken
oh
austere talon
SNAP
lucid blade
wait i probably installed it a different way because it also says i don't have it installed
austere talon
SNAP NODE 😭
lucid blade
because i hate snap
austere talon
yeah snap is horrible
i recommend fedora next time
it's way more updated and uses flatpak instead of sn*p
lucid blade
i have flatpak installed
as well as pacman
or i did?
it may have been removed when i had to reinstall the kernel because it got corrupted idfk
i know i've used it because i've specifically installed uwufetch with it
limber skiff
@junior olive you should apply ven review on the decor guidelines pr
limber skiff
pr to it
junior olive
mmmh
junior olive
true
also nookies
rn trying to change decor without plugin enabled crashes
how should we disable the setting component when the plugin isnt enabled
limber skiff
ignore it
junior olive
sad
limber skiff
not our fault if someone wants to use the menu when they disable the plugin
they have to restart their client
austere talon
he means if u press the button in settings
junior olive
yea
limber skiff
oh
junior olive
u can still access this even when disabled
austere talon
how should we disable the setting component when the plugin isnt enabled
u can just
function Component() {
if (!Vencord.Plugins.isPluginEnabled("PluginName")) return null;
}
instead of that func u can also just use settings.store.enabled
junior olive
oh huh
austere talon
or the started prop on ur plugin
junior olive
ill just use settings.store.enabled ig
austere talon
that will still crash if people enable it then dont restart
junior olive
um ok
austere talon
is it just cause the component is not available
junior olive
it's because 2 of the components we steal aren't available yeah
austere talon
just check if theyre defined?
junior olive
can't really
it's all a little funky
we steal them from a lazy loaded module.. that we only load when we need to
austere talon
or just use an ErrorBoundary
junior olive
best bet is probably started prop
limber skiff
we steal them from a lazy loaded module.. that we only load when we need to
how aren't those required when you click the button then
junior olive
how aren't those required when you click the button then
they are
limber skiff
so it shouldnt crash
limber skiff
or do you mean the ones you steal with patches
limber skiff
maybe default them to Noop components
there's an import for that
or use error boundary
austere talon
- if your component failing crashes discord, that's bad. always use an ErrorBoundary
- use an ErrorBoundary for your settings component that renders smth like
Enable plugin & restart to set your decor
junior olive
These should probably be done nonetheless but I think disabling the ability to go into that UI before enabling the plugin is what should be done too
Ok where exactly should I be using errorboundary bc
the failing components are in the modal
using a error boundary in the settings component isn't gonna catch that is it?
I don't think errorboundary is suitable in the settings component
austere talon
why not?
austere talon
?
limber skiff
just use the console
junior olive
oh true
nexx told me about this funkiness
can we remove the guidelines popup from the stack before adding the create one
limber skiff
why isn't clicking continue removing from the stack
austere talon
just close the modal first
austere talon
openModal(modalProps => (
<ModalRoot {...modalProps}>
<Button onClick={() => {
modalProps.onClose();
openModal();
}} />
</ModalRoot>
);
})
should juszt work
junior olive
yea its fine idk what they had
charred monolithBOT
Viewers are unable to hear the streamed app and hear an echo of me.
Chromium input (red) appears and disappears as I start and stop streaming, but vencord-screen-share appears when I stream, but persists after I stop streaming.
Linux Mint 21.2 w/ PipeWire 1.0.0
Vesktop v0.4.4 (flatpak)
junior olive
@austere talon the reason its using text components is to match the various customization modals
they use text there instead of formtitle for the titles
guhh
noopcomponent time?
yeah.. noopcomponent..
orr i could make it return like
"enable the plugin and restart your client to change your decoration"
horr or
that's quite use friendly innit
Maybe the error boundaries should be used further down the chain like
eh..
junior olive
i feel like this is better but not by much
junior olive
like.. atleast it's in a modal
austere talon
and type ur props
junior olive
use an arrow func
I ended up not wrapping the full thing
austere talon
u should
austere talon
default modal props type
ModalProps
junior olive
that's quite use friendly innit
.
austere talon
more userfriendly than a crash
junior olive
im still using error boundary
but not on the full thing
just the bit that can fail
(the modal contents)
if the modal components fail then there's way bigger problems for vencord than decor not opening lol
junior olive
i feel like this is better but not by much
see this
clear way for the user to close the modal even tho it failed
thick kestrel
when is it okay to hardcode e and when is it not?
austere talon
never
thick kestrel
short and to the point
junior olive
https://github.com/nexpid/Vendicated.Vencord/pull/1/commits/f47335baddb8f97f51b6a027762dcd0c2c1a2301
charred monolithBOT
charred monolithBOT
proven sandal
To my knowledge*
hmmm
charred monolithBOT
charred monolithBOT
analog knoll
when is it okay to hardcode `e` and when is it not?
I am wondering what do you mean by this :D Could you give an example
austere talon
don't worry about it
thick kestrel
I am wondering what do you mean by this :D Could you give an example
Vencord docs state that you shouldn't hardcode minified parameter names
however, they also state that e, passed as the first argument to many functions, can be an exception to that rule
Never hardcode variable or parameter names or any other minified names. They will change in the future. The only Exception to this rule are the react props parameter which seems to always be e, but even then only rely on this if it is necessary.
they do not state the circumstances in which it would be okay to do that
seemingly the answer is "just don't"
austere talon
those docs are very old
lime stone
just use arguments[0] if it's a function
thick kestrel
just use arguments[0] if it's a function
that's smart, didn't think about that
charred monolithBOT
analog knoll
Vencord docs state that you shouldn't hardcode minified parameter names
oooh cool. Do you mean when working with discord's code
thick kestrel
this is #👾-core-development so yeah lol
I have another question
what is the preffered naming scheme for plugins
it seems to be CamelCase, but what to do when having acronyms as one of the words?
do I do ApiStuff or APIStuff?
(that's a bad non-descriptive name I'm just giving an example lol)
I tend to use the first when I use CamelCase
I see
...lol
thick kestrel
my rationale for using Api, Gif, Nsfw instead of API, GIF, NSFW etc. is that by being an acronym it is a word
and words should be written in CamelCase by making the first letter uppercase and all others lowercase
same as I would write api_stuff in snake_case, and not API_stuff
I've seen both variants though so idk
(I also spell GIF as GIF, assuming I pay attention at all)
(if I don't pay attention I sometimes spell own names lowercase as well)
woeful sable
The real debate is whether you pronounce it Gif or Jif
lime stone
noone spells gif as GIF
GIF is much clearer than gif tbh
Gif is like writing Lol
or Tbh
although in some code styles you write e.g. Json instead of JSON and of course Gif instead of GIF
but that feels like a programming thing
charred monolithBOT
charred monolithBOT
sharp venture
my rationale for using Api, Gif, Nsfw instead of API, GIF, NSFW etc. is that by ...
acronyms as part of camelcase always treated as words, agree
never be the guy making ABCValidation variable names
there’s a style rule for this forgor the name
charred monolithBOT
uneven tiger
hey, would apng stickers not properly working with fakenitro be considered a bug?
i mean they do "work", it just displays the apng itself and discord does not display any animation (which i see previous discussion via search is known, so that's not really the issue)
uneven tiger
it looks like it should already be doing a client side transcode and upload it as a gif
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/a9568bc0552ef0cac57c24da453af4033e692...
**index.ts: **Line 792
this.sendAnimatedSticker(link, sticker.id, channelId);
austere talon
uneven tiger
why are you shooing me away to the support channel i'm just trying to contribute 😦
is this not a bug? is it known about somehow
it seems bug shaped
austere talon
because this is a support request
you're probably just using the userscript or firefox/brave and that's why gif conversion fails
uneven tiger
i'm on client
uneven tiger
Stable 253047 (95fcdd4)
Vencord A9568bc (Standalone)
Electron 22.3.26
Chromium 108.0.5359.215
Host 1.0.9026 x86 (40844)
OpenAsar Nightly (1c24e09)*
Windows 10 64-Bit (10.0.19045)
Nothing in verbose network console ( related to anything seeming relevant.
*Happens with or without openasar.
Tested on a fresh install of the client, every other apng sticker i've found works as expected. seems like either discord api bug / update or vencord is catching what type the sticker is incorrectly somehow - maybe some stickers aren't StickerType.APNG even though... they're apngs
is typescript compiled
Aughhhh
austere talon
you can just use the debugger in client
open the source tab and search for FakeNitro via ctrl shift f
jump to the code and put breakpoints
step through it and see where it goes wrong
uneven tiger
yeah sticker.format_type is ending up as 4 somehow
which is "gif"
it's definitely not a gif
nimble plaza
@austere talon im making a patch helper for another clientmod and am having trouble with regexes, would you care if i just used vencord's and licensed it appropriately
regex groups killing me
charred monolithBOT
Content
Sorry
First of all, sorry. I know, I am not supposed to open an issue thread here, I am sorry for doing it anyway.
Yes, I have read this.
However, I checked the Discord server, and even there I am not allowed to make a suggestion because other people have made suggestions that were too stupid ...
charred monolithBOT
austere talon
limber skiff
@junior olive idk what's about it but animated decorations are super slow and buddy to load in the decoration modal
it's actually hard to know what's animated and what's not because they dont load properly, or take ages
along with trying to fix that somehow I would add an indicator that shows whether it's animated or not
junior olive
<@890228870559698955> idk what's about it but animated decorations are super slo...
i've kinda noticed this?
it's weird i don't know where the issue is
limber skiff
like I know there's animated portal one and I cant find it cuz it doesnt load
junior olive
doesn't load in what sense
limber skiff
none show animated
junior olive
yea they dont animate until you hover
junior olive
guh wtf
limber skiff
and the ones that do work take ages sometimes
or they dont animate at all unless you try some more times
limber skiff
which one is animated
junior olive
door at the bottom
limber skiff
oh
it loaded, but it took like 5 seconds or more
honestly
it might be because they are too big
in size I mean
junior olive
the limit is 3mb
part of the issue is probably that we don't have multiple sizes
and i don't think we can do that in a cf worker very well
they would have to be preprocessed
junior olive
their cdn has resizing we do not
junior olive
this is discord biggest one
rlly?
limber skiff
I think so?
limber skiff
yeah
junior olive
hmmm
limber skiff
along with trying to fix that somehow I would add an indicator that shows whethe...
either way this would help for now
junior olive
maybe but that would probably require reimplementing the decoration grid decoration item
@limber skiff just updated the server, new submissions will be resized to 288x288 but for now older submissions will remain as what they were submitted as
updating existing ones is more complicated
limber skiff
pog
charred monolithBOT
The plugin generates unique colors for usernames in chat, similar to how it works in many IRC clients.
junior olive
we'll go over older ones in the future
thick kestrel
go easy on me I never did this before lol
#2^11
eh
on my machine I had errors, but not in my code
is this perhaps because I'm using an object literal to define authorship?
other plugins seem to use pre-made objects from the constants module
the docs say to do it like I'm doing it, but then they are apparently outdated
nimble plaza
on my machine I had errors, but not in my code
pnpm i
thick kestrel
`pnpm i`
thanks, now it breaks the way it's supposed to on my machine as well :D
and yeah, I changed it to use the constants module and it passes
so I guess that's what I'm supposed to be doing
limber skiff
yes
charred monolithBOT
charred monolithBOT
thick kestrel
yes, yes you should
junior olive
@limber skiff kasi resized all of them to 288x288
open the modal with networking page/cache disabled
thick kestrel
added a Vim mode to the QuickCSS Editor
limber skiff
@junior olive they load instantly now
thick kestrel
also makes the editor not work 80% of the time
junior olive
<@890228870559698955> they load instantly now
cool
olive aurora
why dont you just use vim
thick kestrel
I would if I could edit QuickCSS with it
thick kestrel
I use the userscript
austere talon
it will auto reload on changes
thick kestrel
don't want to use two browsers
one is enough
how much time does it normally take to get a plugin MR accepted?
thick kestrel
lol
crude raptor
you have to wait for a cosmic ray to toggle a bit and accept the merge request automatically
prevents bias https://cdn.discordapp.com/emojis/505791796564066306.webp?size=64&name=thinksmart&quality=lossless
austere talon
the bigger your pr or the worse the code, the longer it takes or less likely it is to get merged
the smaller, the better and the more useful it is, the faster it gets merged
:p
thick kestrel
understandable
guess if it doesn't get merged in a week or so I'm gonna ask for it to get posted on #1032200195582197831
I'd assume that's much quicker to get access to
my plugin is definitely small (one short rule + one rather simple function), no idea if it's good code as I have no experience (though I tried my best to comply with the contributing guidelines) and it's useful for the 5 people out there who use Compact mode and want better readability (so not very useful)
I know the Discord compression removal plugin got in very fast, pretty sure was the next day after I noticed they added it (not sure how fast compared to when it rolled out)
funnily enough it's not very useful now, as they switched the compression to lossless mode for PNGs
and on JPEGs the additional lossy compression is barely (if at all) noticeable
limber skiff
well mainly cuz the plugin was made by me so I instantly pushed it to dev version
thick kestrel
lol
gritty iris
what would I make this now var channels = findByProps("getChannels"); so i can do channels.getChannels()?
gritty iris
it's a common you can import
I would use that but I need to be able to actually use getChannels so I can then map the vocal channels
charred monolithBOT
limber skiff
I would use that but I need to be able to actually use getChannels so I can then...
GuildChannelStore?
I dont remember which one has getChannels
charred monolithBOT
limber skiff
how
junior olive
how
idk maybe something to do with the 30k users in less than a week idk idk
well more like
limber skiff
oh wait you can add the bot?
junior olive
No
It's probably a conjunction of tons of users using it's oauth (17k -> 30k in under 12h) and it dming the result of decoration reviews
ive emailed discord
now we wait
junior olive
its a little wild yeah
glad geode
man
half notch
charred monolithBOT
near karma
Hi
idk if this is the right place to ask this but
Someone should make a plugin that adds a menu where you can compare servers and see mutual people that are in both servers
or something similar
uneven tiger
fixed this stupid apng gif bug
i think it's a bug in discord api
discord api is returning "not an apng" even though... i mean it's not an apng? but it has a gif component? but the api is returning a .png link? but the format type is .gif??
tawny cipher
kek, vesktop also inoperable on network with self signed CA cert, very sadge
https://adriancastro.dev/zvk2a00tpsj1.png
gleaming trellis
kek, vesktop also inoperable on network with self signed CA cert, very sadge
htt...
if you build it yourself you can add some manual overrides to the certificate check
if you know what you're set it to callback(0) on the self signed certificates you have
charred monolithBOT
I installed Vesktop from Flatpak,
Autostart option enabled when first start,
Application doesnt even start after restart so i added the app to autostart manually,
Then every restart it throw this error:
Ctrl+R doesn't work in this window,
after hitting OK from error VC symbol comes and Vesktop Stuck in this animation
austere talon
wait how 😭 @topaz thistle
charred monolithBOT
topaz thistle
Don't know but vesktop is not taking venmics output
topaz thistle
Which is very likely not a Venmic issue because I don't do anything with output to vesktop
austere talon
ic
warped turret
How can I make soft depend? It means that if the dependency plugin is not loaded, it's ok, but if it's loaded, then an additional functionality appears
nimble plaza
How can I make soft depend? It means that if the dependency plugin is not loaded...
just dont mark it as a dependency, add a note in the description that says u get additional functionality
warped turret
just dont mark it as a dependency, add a note in the description that says u get...
How can I guarantee that my plugin loads after soft dependency plugin if it's enabled?
teal dew
crude raptor
wait did it get discovered cause of a video? lmao
RIP RIP
"the devloper of this plugin doesn't want to be nuked by discord's legal team" LMFAO
foreshadowing is a literary device-
austere talon
How can I guarantee that my plugin loads after soft dependency plugin if it's en...
make its name come after the desired plugin alphabetically
austere talon
"the devloper of this plugin doesn't want to be nuked by discord's legal team" L...
he didn't get nuked
austere talon
his bot got automatically flagged as spam
cause it was getting so many new oauths and dming thousands of users
crude raptor
huh... is decor included in vencord by default?
cause my vencord says its up to date but i don't got decor (probably wouldn't use it but think it'd be cool to see others')
