#👾-core-development
charred monolithBOT
dusk hill
holy shit
topaz thistle
@austere talon https://github.com/Vencord/Vesktop/pull/235 pls merge :3
radiant reef
uh
charred monolithBOT
toxic bough
Okk when do you think it'll be out?
spark pivot
Don’t know just be patient
void echo
If anyone gets some time could we have some more reviews on ReplyPingControl PR? thx <3
olive aurora
@austere talon i will kill you if you force push to dev again
olive aurora
epic embed
charred monolithBOT
Discord Account
vasilisiscool
What happens when the bug or crash occurs?
Programs using RPC (example: JetBrains Discord Integration) currently seem to still be able to talk with the rpc server and even show an rpc on the client.
junior olive
Okk when do you think it'll be out?
No clue :/
dusky sonnet
most it would say is run autofix to sort these imports!
i mean yeah, i just want to get rid of the yellow dot
also imports should be sorted
the only thing im a bit worried about is the header
because my local install doesnt like it for some reason
jagged cloak
it should format and header on save usually lol
olive aurora
update
dusky sonnet
because that makes sense
olive aurora
pnpm i
dusky sonnet
yeah tried that
olive aurora
skill issue
dusky sonnet
had this convo with @void echo yesterday
dusky sonnet
skill issue
:(
dusky sonnet
@lime stone youre not supposed to have spaces in there no?
dusky sonnet
think i read that somewhere
void echo
.
dusky sonnet
sorry for pinging
olive aurora
thats on the match
olive aurora
ppl usually minify the replace out of habit
void echo
yea
dusky sonnet
yeah im probably just deluded lol
lime stone
well it's harder to read for No Reason
I do not know why I captilised No Reason there
olive aurora
barely any harder to read
olive aurora
u need glasses
dusky sonnet
i have glasses 
dusky sonnet
im an avid code golf afficionado so ofc its gotta be unreadable
olive aurora
consistency is good
lime stone
u need glasses
shut up /lh
dusky sonnet
this is my bible https://javascript.info/ninja-code
austere talon
ajay jumpscare
charred monolithBOT
olive aurora
also you love quickreply making you able to mention yourself on replies
glass jasper
This is the best plug-in
austere talon
BUILD FAILED
junior olive
LMAO
austere talon
how get log
junior olive
one of my workers throws errors and i cant debug it i love
junior olive
THIS IS MY ACCOUNT STILL BEING BROKEN
how tf did u break it
turbid hatch
@austere talon you can watch the log live but you should be able to expand those sections too
charred monolithBOT
austere talon
<@343383572805058560> you can watch the log live but you should be able to expan...
it was just broken
BUILD SUCCESS
nooo it failed
:(
austere talon
"message": [
"10:28:00 PM [ssr] TypeError: Cannot read properties of undefined (reading 'href')\n at functionsWorker-0.6542425200816036.js:5740:44\n at Object.Tm (functionsWorker-0.6542425200816036.js:7852:34)\n at ma (functionsWorker-0.6542425200816036.js:582:12)\n at of (functionsWorker-0.6542425200816036.js:1560:91)\n at ja (functionsWorker-0.6542425200816036.js:1615:20)\n at Kr.render (functionsWorker-0.6542425200816036.js:2225:19)\n at async Object.fetch (functionsWorker-0.6542425200816036.js:8306:44) (x2)"
],
combust
austere talon
const CanvasKit = await initCanvasKit({
locateFile: file => new URL(file, url).href,
});
HOW IS IT UNDEFINED??
void echo
FUCK i had a really old tampermonkey script i made that was marking changes as resolved when i actually meant to merge
that would explain a lot 
i had the exension icon hidden
austere talon
WHY DOES THIS LIBRARY ONLY SHIP MINIFIED JS
ebon frigate
hi!
I'm not great at programming but
i know few things
can someone help me where is vencordDep.mjs?
austere talon
why
ebon frigate
I'm trying to make plugins locally available
so that i can load them from folder and not from github
void echo
so that i can load them from folder and not from github
You can already get them from #1032200195582197831 and just build it
Just put them in a userplugins folder and build it like that
ebon frigate
oo ty!
charred monolithBOT
void echo
why
for future reference, where's that guide on installing 3rd party plugins i cant find it
charred monolithBOT
ebon frigate
wait. i dont want to make a new plugin. i want to keep all the plugins locally so that i can edit the already existing ones. i want to change the plugin path in vesktop
austere talon
not possible.
ebon frigate
yeah forgot to mention vesktop in first msg
austere talon
charred monolithBOT
ebon frigate
https://github.com/Vendicated/Vencord/tree/main/docs
this is very useful! ty!
void echo
https://github.com/Vendicated/Vencord/tree/main/docs
Is it worth me editing the plugins guide to add that they need readmes and dev constants
charred monolithBOT
junior olive
d
junior olive
LMAO
austere talon
god im gonna have to fork this shit
at this point i might as well just fork
and like now it fails locally for some reason
WEHY DO THEY EVE NSHIP MINIFIED CODE
NO
AAAAAH MONOREPO
i will cry
charred monolithBOT
ebon frigate
charred monolithBOT
patent nova
@rustic nova where is the folder cashed images saved in
also the option ignore muted servers isn't working
it still logs it
patent nova
?
austere talon
they cant read here anymore
https://github.com/thororen1234/Installer people need to stop making vencord rebrands
junior olive
yeah i swear ive seen them in here so much
junior olive
https://github.com/thororen1234/Installer people need to stop making vencord reb...
i wonder why they do it
like
just pr ur additions to vencord
austere talon
well the wait :p
junior olive
nobody is gonna use <x>cord
junior olive
bc he did it
can we talk about that please :/
I'm really confused
I understand if stuff came up or u didnt feel like doing it but I'm so confused as to why any mention of it has gone ignored
I don't mind when it gets reviewed (obviously I'd prefer it to be sooner) but please communicate a littleee
are they gonna fucking rebrand a fork 😭
void echo
PLS
junior olive
bc he did it
@austere talon to explain a lil bit more he posted it bc it was his undertaking as a temporary measure until decor is merged
kasi best janitor
nO
austere talon
i need to merge decor fast before fiery makes DecorCord
tepid tiger
olive aurora
decord
junior olive
i need to merge decor fast before fiery makes DecorCord
I don't want to vee
seriously I want to get it in vencord
austere talon
yeah ofc im just memeing
junior olive
I'm just confused how it went from :) to nothing instantly
austere talon
loss of motivation
junior olive
That's fine and you can tell me that
But leaving me in the dark just leaves me confused and wondering wtf is up
void echo
That sponsors grid is so cool
junior olive
cuz to me it went from "we can probably get it merged within a few days" to "is it actually going to be merged at all"
the way it was ignored at any mention
do u get where i'm coming from
thundr
junior olive
decor got partially reviewed and ven said they'd review the rest <x> day and when i asked late on <x> day it got ignored and since then it's been ignored at any mention that's why i was so confused
void echo
junior olive
ven i have adhd too, how do you think decor went from 0 to 100 for vencord in a day 
i get that shit i just have no idea what to think when left in the dark
austere talon
it caches too long
oh waits its cloudflare caching
ig 4 hours is fine
are u a current sponsor
or past
it only shows current, idk if github api can do past
junior olive
anyways
austere talon
theyre in #1164494686472380546
austere talon
my head hurts
frail skyBOT
limber skiff
jumpscare
junior olive
guh ill deal with pindms
frail skyBOT
junior olive
@austere talon is the getRowHeight fix even needed anymore??
i don't see what it was matching at aaall
junior olive
was it matching something in getRowHeight before
this.getRowHeight = (e,t)=>{
let {privateChannelIds: n} = this.props;
return 1 === e && 0 === t && 0 === n.length ? 428 : 44
}
this is it now
olive aurora
before there was a func call
junior olive
e and t are both numbers
olive aurora
dms is 1
austere talon
it might just ben inlined now
1 & 0 seem like enum values
like these
check which is DMS and itll be that
olive aurora
it was 1 and 0 was home stuff
junior olive
yeah
olive aurora
top links
olive aurora
iirc we make pindms 1 and modify dms to be 2
olive aurora
we subtracted 1 from e
junior olive
i need to see the older code
olive aurora
not ===
olive aurora
yea took me a while to figure this part out when i fixed for rspack lol
junior olive
{
find: ".privateChannelsHeaderContainer,",
replacement: {
match: /1===\i/,
replace: "$&-1"
}
}
that theoretically should work
\i is e
is that good
olive aurora
m you probably need to make it more specific
unless tha module got split into a smaller one
olive aurora
yea maybe
junior olive
(?<=getRowHeight=\(.{2,50}?)1===\i
dire trench
@spark pivot asking cuz i do not know but why use an object over an array in this case?
isnt an object overkill and uneeded?
nimble plaza
makes it harder for code to be understood
dire trench
in this case its very simple
the array is short and its right above the function
the array in question:
const dcBadges: [number, string, string][] = [
[0, "Discord Staff", "5e74e9b61934fc1f67c65515d1f7e60d"],
[1, "Partnered Server Owner", "3f9748e53446a137a052f3454e2de41e"],
[2, "HypeSquad Events", "bf01d1073931f921909045f3a39fd264"],
[6, "HypeSquad Bravery", "8a88d63823d8a71cd5e390baa45efa02"],
[7, "HypeSquad Brilliance", "011940fd013da3f7fb926e4a1cd2e618"],
[8, "HypeSquad Balance", "3aa41de486fa12454c3761e8e223442e"],
[3, "Discord Bug Hunter", "2717692c7dca7289b35297368a940dd0"],
[14, "Discord Bug Hunter", "848f79194d4be5ff5f81505cbd0ce1e6"],
[22, "Active Developer", "6bdc42827a38498929a4920da12695d9"],
[17, "Early Verified Bot Developer", "6df5892e0f35b051f8b61eace34f4967"],
[9, "Early Supporter", "7060786766c9c840eb3019e725d2b358"],
[18, "Moderator Programs Alumni", "fee1624003e2fee35cb398e125dc479b"]
];
Object.freeze(dcBadges);
function getUserDCBadges(flags: number): [string, string][] {
const userDCBadges: [string, string][] = [];
for (let i: number = 0; i < dcBadges.length; i++)
if (flags & (1 << dcBadges[i][0]))
userDCBadges.push([dcBadges[i][1], dcBadges[i][2]]);
return userDCBadges;
}
no reason to freeze ithnkb
dire trench
first index in each entry is the bit position of the badge
second index is the badge name
third index is the badge image
austere talon
simply dont freeze
inland fable
makes it harder for code to be understood
objects are unordered and we'd have to add an order key if we want to display the badges in the same order as the profile does, an array lets us choose the order in which theyre displayed
we can move to object if preferred though
spark pivot
<@523338295644782592> asking cuz i do not know but why use an object over an arr...
It’s a lot more readable and makes more sense for a static variable
spark pivot
objects are unordered and we'd have to add an order key if we want to display th...
Yeah this is easy if you want to preserve order and just use array.sort
Or just order them in the array as they should be
inland fable
Yeah this is easy if you want to preserve order and just use array.sort
huh can you rephrase this sentence
would you prefer us to move to an object and add an order key to know the order in which badges should be rendered or is going with an array fine
junior olive
the array in question:
```ts
const dcBadges: [number, string, string][] = [
...
this is pointless optimization
it'd be best if it was a array of objects
livid heath
me when #👾-core-development message
junior olive
wow those 0.2ms saved matter so much
livid heath
ikr
tbf aren't they running that on like every message
eh at most you have 20 messages in view
just use filter
junior olive
it's not going to be that performance intensive
dire trench
not everything has to be .map, .some, .filter, .reduce etc.
livid heath
why not
junior olive
it's way clearer
livid heath
they exist to be used
dire trench
no
junior olive
not a unnecessary optimization
dire trench
i need to push to a new array without only the second and third indexs of each entry
i cant do that with just filter
it makes it more complicated and hard to understand later on in the code when that array is reused
only the badge name and image is needed
junior olive
ooo so scary ryan
livid heath
no
so you're saying filter wasn't made to help people shorten const foo = []; for(const e of bar) {if(condition){foo.push(bar)}}
thats just wrong
junior olive
only the badge name and image is needed
.map:
dire trench
ooo so scary ryan
that is way less readable
junior olive
ur deranged
dire trench
its like ur doing code golf
livid heath
that is more legible than writing 5 loops my guy
dire trench
i wrote 1 loop
livid heath
referring to the image fiery sent
livid heath
that is way less readable
.
livid heath
code golfing is just making code shorter
.filter, .map etc are to make code easier to read not just shorter
there's a clear distinction
junior olive
function getUserDCBadges(flags: number): [string, string][] {
return dcBadges.filter(badge => flags & (1 << badge[0])).map(badge => [badge[1], badge[2]])
}
its readable idk what ur on
junior olive
it is
dire trench
in this case no
junior olive
it is so much more clear as to what it does
livid heath
it literally is more readable
dire trench
i disagree
i could make it a foreach
that could be more readable
but not filter then map
junior olive
foreach won't do what you want to do
livid heath
how
junior olive
you still need to filter out the invalid entries
livid heath
foreach would add unnecessary code
junior olive
filter and map is literally perfect
livid heath
filter and map is literally perfect
^
dire trench
function getUserDCBadges(flags: number): [string, string][] {
const userDCBadges: [string, string][] = [];
dcBadges.forEach(badge => {
if (flags & (1 << badge[0]))
userDCBadges.push(badge[1], badge[2]]);
});
return userDCBadges;
}
and you consider this more readable than filter + map?
tame escarp
filter and map is literally perfect
but uhm 🤓 ur iterating over the array twice 🤓 itll be so slow 🤓
dire trench
its more clear as to what it does
junior olive
ryan u have this tendency to sacrifice readability for unnecessary optimization
junior olive
its more clear as to what it does
it is not at all
dire trench
how is squishing everything into one long line more readable 💀
livid heath
what part of filter + map is less clear to you
if anything it makes the operations more explicit, you are filtering and mapping the values of the array
junior olive
literally don't squish it and it becomes even more readable
livid heath
how is squishing everything into one long line more readable 💀
function getUserDCBadges(flags: number): [string, string][] {
return dcBadges
.filter(badge => flags & (1 << badge[0]))
.map(badge => [badge[1], badge[2]])
}
unsquished
happy?
junior olive
function getUserDCBadges(flags: number): [string, string][] {
return dcBadges
.filter(badge => flags & (1 << badge[0]))
.map(badge => [badge[1], badge[2]])
}
ermm too much indentation 🤓
livid heath
ermm too much indentation 🤓
idk man i let prettier handle my indentation
dire trench
this is what happens when u only do js
livid heath
formatting to code has nothing to do with this ryan
dire trench
anything other than those array functions is unreadable to u
tame escarp
this is what happens when u only do js
man who has never seen a functional language in his life
junior olive
if vencord was ryancord i bet it wouldn't allow calling functions on your plugin
u have to put ALL your code in the patches fr
livid heath
man who has never seen a functional language in his life
haskell users in shambles
junior olive
ryan get with the program filter and map are your friends
dire trench
if vencord was ryancord i bet it wouldn't allow calling functions on your plugin...
i never made any generalizations about that
that was a single very specific case
where it was just something1 && !something2
why do a function call for that
junior olive
because it's more clearer as to what the fuck is happening lol
livid heath
because it makes it more explicit and is also much cleaner
junior olive
easier to extend in the future too
dire trench
do i have to make an adder function too?
function addTwoNumbers(number1, number2) {
return number1 + number2;
}
yes?? 🙄
livid heath
you... just did
junior olive
fr
livid heath
the point here is that Array has a utility which can simply your function and make it much more cleaner
junior olive
ryan u have like 3 different people telling you "THIS IS BETTER" on top of vee saying it's weird just do it
dire trench
yes they can help when code needs to be made more compact / readable
this is not the case tho
again, its like ur doing code golf
why dont we minify everything?
junior olive
bro just shut up and accept it's nicer i fear
livid heath
yes they can help when code needs to be made more compact / readable
so you ultimately dont want to write readable code 😭
dire trench
its already readable tho
junior olive
ryan ur writing code for a ts/js project write in ts/js ways
livid heath
again, its like ur doing code golf
10 minutes ago
spark pivot
huh can you rephrase this sentence
I mean an array of objects
Just keep it in the order they’re supposed to be in the array
tame escarp
u would write "Hello, world!".upper().split() as ```js
let string = "Hello, world!"
let uppercasedString = "";
for (let i = 0; i < string.length; i++) {
uppercasedString += string[i] // manually convert to uppercase but i aint writin allat
}
let splitString = [];
for(let i = 0; i < uppercasedString.length: i++) {
splitString.push(uppercasedString[i])
}
using foreign ways in a project predominantly programmed by js/ts devs just adds confusion
dire trench
u would write `"Hello, world!".upper().split()` as ```js
let string = "Hello, wo...
what is the point of that
livid heath
u would write `"Hello, world!".upper().split()` as ```js
let string = "Hello, wo...
🤓 erm .toUpperCase() ackshually 
tame escarp
u hate functions on primitives that return a modified copy so much
junior olive
fr
tame escarp
might as well make those for loops too
livid heath
you are allocating a new array either way
junior olive
noooo how could my programming language have nice convenient functions to manipulate a thing 😭 😭 😭 😭
livid heath
this is like rust devs (totally not me) crying about someone's code creating a single copy of a string
junior olive
fr
dire trench
u complained about the for loop so i made it a foreach
now u still complaining
do not understand why im getting so much shit
junior olive
bc ur still doing something that is pointlessly optimized and doesn't match other code style
dire trench
i think ur really blowing this out of proportion
limber skiff
is this for a third party or official plugin
junior olive
it's a pr
tame escarp
do not understand why im getting so much shit
bc ur a bad human and do not deserve to exist because you program differently. simply combust
limber skiff
for a plugin?
junior olive
yea
austere talon
why r u arguging over such a small thing
dire trench
bc ur a bad human and do not deserve to exist because you program differently. s...
arent u that ruthenic mf
limber skiff
then use filter and map
tame escarp
whar is that supposed to mean
tame escarp
why r u arguging over such a small thing
its fun
limber skiff
it's pointless to care about performance on this case, and filter map is more readable
dire trench
calm down
junior olive
not our fault you can't accept you're overoptimizing
tame escarp
arent u that ruthenic mf
but nononono ryan what does this mean
dire trench
but nononono ryan what does this mean
on github
tame escarp
yop
crude raptor
i think someone should make a plugin that does pluralkit's switch tracking (using slash commands that have autocomplete omg thatd be so nice) and add a tag to a message based on who's fronting (kinda like pk's autoproxy switch and keepproxy true)
dire trench
how can you agree with "what is all of this needed?"
just read the code or ask about specifics
how is that a review
not constructive plus how do i respond to that?
tame escarp
i think someone should make a plugin that does pluralkit's switch tracking (usin...
hewo i wanna do a plugin for plurality/proxying bots eventually thank u for the feature ideas
junior olive
not constructive plus how do i respond to that?
we've already gone over it mate I was just adding it as a proper suggestion
crude raptor
omg thats epic ✨ please hurry up i want to be able to have cool message effects everywhere automatically based on who's fronting
livid heath
not constructive plus how do i respond to that?
was this discussion here not enough
junior olive
omg thats epic ✨ please hurry up i want to be able to have cool message effects ...
what plugin are you talking about
dire trench
forEach is readable enough
junior olive
no
dire trench
not everything has to be chained array functions
inland fable
PluralKit has an api not sure if u can switch front with that
tame escarp
omg thats epic ✨ please hurry up i want to be able to have cool message effects ...
(blatant self advertising) fwiw my proxying bot has custom message signatures that get added to proxying messages
crude raptor
i did something kinda like that with text replace but then i realised it requires a prefix or somethinng to actually know who's fronting
tame escarp
PluralKit has an api not sure if u can switch front with that
u can
junior olive
ryan u were literally told by a vencord maintainer use filter and map
junior olive
why are u fighting it so hard
crude raptor
(blatant self advertising) fwiw my proxying bot has custom message signatures th...
oh i saw about that in the chat being discussed- didn't know it was added! i'll check that quicklly
dire trench
do i have to add jdoc comments too?
junior olive
yes
dire trench
why are u fighting it so hard
i could say the same to u
inland fable
whats sp
junior olive
i could say the same to u
i fear i am on the right side of this argument
livid heath
if you really wanna avoid 2 iterations
then you are already doing a map here
so just return dcBadges.filter(badge => flags & (1 << badge[0])) and do badge[1] & badge[2]
literally as simple as that
dire trench
it already works and its already readable
dire trench
if you really wanna avoid 2 iterations
then you are already doing a map here
so ...
i didnt make the whole plugin
there are 3 devs
we were helping shalev make a plugin
livid heath
i didnt make the whole plugin
where
where did i say you made the whole plugin
crude raptor
(blatant self advertising) fwiw my proxying bot has custom message signatures th...
what command is that ?
livid heath
aight i give up
dire trench
if you really wanna avoid 2 iterations
then you are already doing a map here
so ...
ill look at it later
tame escarp
what command is that ?
if u have a mate (imported or whatev) then you can just /edit mate signature:[before]text[after] is the same as proxy tag formats
crude raptor
oh im fucking stupid of course it'd be in edit
austere talon
if you really wanna avoid 2 iterations
then you are already doing a map here
so ...
STOP OVERENGINEERING
write readable maintainable code
livid heath
where am i overengineering
junior olive
i would dare to say the array in array is a overoptimization
tame escarp
i would dare say all computers are overoptimization. just do the math in ur head silly
dusk hill
so true
livid heath
i would dare say all computers are overoptimization. just do the math in ur head...
i actually do that in CS class
dire trench
i would dare to say the array in array is a overoptimization
its shorter and simpler
junior olive
and less clear to a newcomer what each thing is
dapper tiger
what would this be in C++
dapper tiger
the &int thing
livid heath
cast?
charred monolithBOT
Pasting your patch into the Full Patch field will auto-fill all the other fields
dusk hill
why u always gotta start shit with me dawg
dapper tiger
oh im in dev channel
junior olive
sorry i was in different channels
crude raptor
#1032200195582197831 message sorry what does this do?? does it change the message invite feature to say "hop on __" ?? either way it sounds hillarious
livid heath
https://discord.com/channels/1015060230222131221/1032200195582197831/11734611319...
opens a url whenever someone says "hop on __"
crude raptor
thats wild
spark cove
hop on fn
austere talon
hop on dn
spark cove
oh ok
elder garnet
hop on existential crisis
spark cove
dortnite
woeful sable
does vencord automatically block ack requests?
austere talon
what
charred monolithBOT
livid heath
intentional challenges, cant have them know about the secret token logger
woeful sable
Does anybody got idea on how to add custom button to context menu?
crude hearth
@austere talon you
spark pivot
<@343383572805058560> you
you WHAT
livid heath
he whar
cunning canyon
what
lol that person have just talked to me few hours ago about how did i start contributing to big repo like vencord 
crude raptor
i haven't asked in a while so hows the text replace PR going- is it merged or whatever?
and then also- when would the update roll out ?
cunning canyon
i haven't asked in a while so hows the text replace PR going- is it merged or wh...
not merge yet
ven have just reviewed your code about the invite link component
not main textreplace code
crude hearth
i haven't asked in a while so hows the text replace PR going- is it merged or wh...
Estimated merge time: 8 months and 13 days
TimezoneDB is on 11th month anniversy
cunning canyon
ooo what did they say
move openInviteModal to utils and remove some code that do nothing lol
i did it
oak hull
🔥
crude raptor
cool
anyway i hope it gets merged soon
not even for the features- but because it moved all my textreplace rules to the new storage location and i want them back
woeful sable
do I really need to restart discord everytime I make change to my plugin code?
crude raptor
yeah about that idk what happened but it is the old version and idk why
crude raptor
do I really need to restart discord everytime I make change to my plugin code?
no who told you that
woeful sable
no who told you that
because the new changes dont take any effect
crude raptor
pnpm watch then reload
crude raptor
hm
woeful sable
you still have to reload
realized lmao
which kinda sucks because loading discord takes like forever
woeful sable
yes that takes long too
olive aurora
impatient fr
void echo
/*
* Vencord, a Discord client mod
* Copyright (c) 2023 Vendicated, MrDiamond, ant0n, and contributors
* SPDX-License-Identifier: GPL-3.0-or-later
*/
import { definePluginSettings } from "@api/Settings";
import { Devs } from "@utils/constants";
import definePlugin, { OptionType } from "@utils/types";
import { MessageStore, UserStore } from "@webpack/common";
import { MessageJSON } from "discord-types/general";
export const settings = definePluginSettings({
alwaysPingOnReply: {
type: OptionType.BOOLEAN,
description: "Always get pinged when someone replies to your messages",
default: false,
},
replyPingWhitelist: {
type: OptionType.STRING,
description: "Comma-separated list of User IDs to always receive reply pings from",
default: "",
}
});
export default definePlugin({
name: "ReplyPingControl",
description: "Control whether to always or never get pinged on message replies, with a whitelist feature",
authors: [Devs.ant0n, Devs.MrDiamond],
settings,
patches: [{
find: "_channelMessages",
replacement: {
match: /receiveMessage\((\i)\)\{/,
replace: "$&$self.modifyMentions($1);"
}
}],
modifyMentions(message: MessageJSON) {
const user = UserStore.getCurrentUser();
if (message.author.id === user.id)
return;
const repliedMessage = this.getRepliedMessage(message);
if (!repliedMessage || repliedMessage.author.id !== user.id)
return;
const whitelist = settings.store.replyPingWhitelist.split(",").map(id => id.trim());
const isWhitelisted = whitelist.includes(message.author.id);
if (isWhitelisted) {
if (!message.mentions.some(mention => mention.id === user.id))
message.mentions.push(user as any);
return;
}
if (settings.store.alwaysPingOnReply) {
if (!message.mentions.some(mention => mention.id === user.id))
message.mentions.push(user as any);
} else {
message.mentions = message.mentions.filter(mention => mention.id !== user.id);
}
},
getRepliedMessage(message: MessageJSON) {
const ref = message.message_reference;
return ref && MessageStore.getMessage(ref.channel_id, ref.message_id);
},
});
@spark pivot I added in a whitelist thing, you reckon we should add it to the pr or no
spark pivot
It’s your pr now
junior olive
you still have to reload
I wonder if a autoreload feature would be welcome
could be added to vcc
@austere talon what do you think, autoreload vencord from vencord companion?
actually
austere talon
how
junior olive
yeah i realize
austere talon
do u mean ctrl r
junior olive
yeah
i forgot vencord companion is in vsc
and the build is in cli
nevermind i think
void echo
how can i trigger an update so that this ungreys when toggled rather than me having to hit save and close
junior olive
how can i trigger an update so that this ungreys when toggled rather than me hav...
i too wonder this
for super reaction tweaks
void echo
I can only seem to find examples for dropdowns
junior olive
send
void echo
options: {
method: {
description: "Anonymising method",
type: OptionType.SELECT,
options: [
{ label: "Random Characters", value: Methods.Random, default: true },
{ label: "Consistent", value: Methods.Consistent },
{ label: "Timestamp (4chan-like)", value: Methods.Timestamp },
],
},
randomisedLength: {
description: "Random characters length",
type: OptionType.NUMBER,
default: 7,
disabled: () => Settings.plugins.AnonymiseFileNames.method !== Methods.Random,
},
consistent: {
description: "Consistent filename",
type: OptionType.STRING,
default: "image",
disabled: () => Settings.plugins.AnonymiseFileNames.method !== Methods.Consistent,
},
},
AnonymiseFileNames does this
which is what i've done
junior olive
does it properly grey out?
junior olive
lol
void echo
im trippin
spark cove
iirc the temporary settings object doesnt get passed to anything but the component things
the about component and maybe the component option type too
olive aurora
make it an option tho i personally save way too often
void echo
tried to create a custom component for the whitelist setting that can react to changes in the alwaysPingOnReply setting but it didnt work
bleh
woeful sable
Huh?
index.ts:22 Uncaught TypeError: Cannot set property ackChannel of #<Object> which has only a getter
at Object.patchAckChannelFunction
This normally works in console
void echo
Is there actually a way to update cache when settings change
this would be delicious
direct event listening would be soooo much better for this
charred monolithBOT
turbid hatch
it was just broken
oh weird
austere talon
direct event listening would be soooo much better for this
in the definition you can have an onChange
definePluginSettings({
banana: {
type: OptionType.STRING,
onChange: doThing
}
})
ooh ok ty!!
void echo
in the definition you can have an onChange
also im training an llm to create readmes for the fun of it
elder garnet
make readmes for me
void echo
make readmes for me
yep thats the idea
anything become readme
i'm gna make it go through all non readme plugins, read the index and generate one based on that
then i'll just make a pr with em all
junior olive
fear
void echo
don't pr ai generated content you will be blocked permanently
im not actually dw
it would genuinely take longer than writing them
charred monolithBOT
woeful sable
Is there any way to intercept https requests?
dire trench
Is there any way to intercept https requests?
service workers
woeful sable
service workers
i dont think service workers work for vencord
charred monolithBOT
Seemingly not solved, I just ran into the same issue.
As rendered in vanilla:
And in Shiki, regardless of highlight preference setting:
charred monolithBOT
charred monolithBOT
@D3SOX fixed the volume in the user modals and made it play when on deafen!
We also added a soundboard cloner option
Sound Cloning
accessible by the context menu in sounds in the soundboard log :3
lime stone
LOL
limber skiff
uncut glen
lol
charred monolithBOT
Seemingly not solved, I just ran into the same issue. As rendered in vanilla:
And in Shiki, regardless of highlight preference setting:
Seems like a separate bug where highlighting just breaks sometimes
livid heath
isn't it written in the doc strings that you shouldn't destructure lazy searches 
uncut glen
isn't it written in the doc strings that you shouldn't destructure lazy searches...
shhhhh
lol
charred monolithBOT
nimble plaza
suggestion: have fakenitro modify the char counter to get an accurate count for the emoji links
( https://cdn.discordapp.com/emojis/785677280763445279.webp?size=48&name=firLick&quality=lossless :3)
lime stone
it's not implemented for textreplace either
nimble plaza
ah
lime stone
they created an account for an issue ig
dusky sonnet
rate this patch :D ```js
{
find: ".LABEL_WITH_ONLINE_STATUS",
replacement: {
match: /(src:null!=\i?)(\i)/,
replace: "$1($2.replace(/(80|128)$/,$self.settings.store.imgSize))"
}
}
replace ok
match bad
make it match a text that is sure to not change before the src: and then .{0,..} to reach the src
dusky sonnet
make it match a text that is sure to not change before the src: and then .{0,..}...
👍
limber skiff
@verbal pumice why did you delete your suggestion?
didnt their find match 3 modules?
if it does it should change too
dusky sonnet
im using the online patch helper
verbal pumice
it doesnt
dusky sonnet
i would think that it would tell me if it matches multiple
limber skiff
i would think that it would tell me if it matches multiple
search it on discord devtools
It probably does match more than one
limber skiff
/"img",{(src:null!=\i\?)(\i)/
yeah way better
verbal pumice
limber skiff
oh it's a message
dusky sonnet
isnt that because of a patch?
verbal pumice
yeah
limber skiff
nvm then
verbal pumice
it's fine
dusky sonnet
just out of curiosity
verbal pumice
im just dumb
dusky sonnet
which plugin?
verbal pumice
// Webpack Module 913365 - Patched by PlatformIndicators, ViewIcons
dusky sonnet
actually where is that search thing?
verbal pumice
ctrl+shift+f in devtools
charred monolithBOT
charred monolithBOT
jagged cloak
shitvidia
junior olive
@austere talon does vencord support web workers
junior olive
<@343383572805058560> does vencord support web workers
i will just try
topaz thistle
i invited u to the vencord org curve
Thanks!
placid wave
you are keith the rat
lime stone
Hm... would it lag?
nimble plaza
uhhhhh idk
it would apply rules on every change
doesnt seem to lag at all for me tho
got 2nd patch to work
:D
now i need to make it work on both fakenitro and textreplace 
should i just modify presendlistener?
jagged cloak
I will make iCord
nimble plaza
should i just modify presendlistener?
itd fix all these plugins
wait thatd cause api spam with translate guhhhhhh
what ab messageEvents.add/removeCharCountListener or smt
@austere talon ?
placid wave
I will make iCord
thats just scor
dire trench
persian vencord.dev
hot sierra
what happened with volumebooster
nimble pendantBOT
nimble plaza
i dont think i18n is setup
yea its not
@rare shale can you yoink i18n from vendicated/vendicated.dev
austere talon
<@712639419785412668> can you yoink i18n from vendicated/vendicated.dev
horror
charred monolithBOT
charred monolithBOT
Highlight works just fine for Rust, same issue is still observed for ANSI, so its not highlighting just breaking entirely, it seemingly is an issue specific to ANSI. And especially weird that not even the HLJS fallback functions as intended.
void echo
https://github.com/Vendicated/Vencord/pull/1975
Need some more reviews on the revised version if anyone has a moment <3
jagged cloak
when get rid of discord types
2021 types my beloved
at least most of them are mostly okay still
spark pivot
when get rid of discord types
Types are so a year ago let’s just type everything as any
junior olive
at least most of them are mostly okay still
the two mf plugins im making both use types that just don't exis
jagged cloak
lol
void echo
UserJSON :(
olive aurora
theres 0 advantage
if you have to cast anyway
its pushing to something that already has a type
void echo
Whats this issue with avatar decorations
user doesnt have them n userJson does
do i need to transform one to the other 
charred monolithBOT
olive aurora
it prob doesn matter
void echo
its ok i did it all fancy now
olive aurora
whatd u do
void echo
i should js leave it as it was?
olive aurora
yea
void echo
yea i its not maybe "technically right" but there wont be an issue
modifyMentions(message: MessageJSON) {
const user = UserStore.getCurrentUser();
const userJSON: UserJSON = {
...user,
avatarDecoration: null
};
if (message.author.id === user.id)
return;
const repliedMessage = this.getRepliedMessage(message);
if (!repliedMessage || repliedMessage.author.id !== user.id)
return;
const isWhitelisted = cachedWhitelist.includes(message.author.id);
if (isWhitelisted || settings.store.alwaysPingOnReply) {
if (!message.mentions.some(mention => mention.id === user.id))
message.mentions.push(userJSON);
} else {
message.mentions = message.mentions.filter(mention => mention.id !== user.id);
}
},
i alr did this anyway
olive aurora
yeah no thats just unnecessary
void echo
if ven wants it changed or smtng i will but meh
jagged cloak
DISCORD CAN DETECT IF YOU'RE NOT ACTUALLY ON MOBILE, PERHAPS THIS OPTION SHOULD BE REMOVED
xdd
vc/1548
jagged cloak
i love how theres two seperate patches for the same thing
inland fable
can i ask a contributor to close it i did not see #1548
i did search before pull request but i looked for device instead of platform .(
jagged cloak
also u pred from main branhc lol lol
inland fable
also u pred from main branhc lol lol
what does this eman
idk how to use git(hub) .(
jagged cloak
create a branch and send the pr from that branch instead of using main branch
inland fable
ohh i see
jagged cloak
#👾-core-development message see this
jagged cloak
you dontxd revert the changes and push changes to a different branch simply
or for less experienced/lazy people you can just delete repo and redo xd
inland fable
aight ty
jagged cloak
i am a hypocrite using gui but do as i say not as i do
inland fable
tysm
@jagged cloak 1 last question, i should start the branch name with feat/ right?
jagged cloak
depends
feat: is usually for new features (plugins in this case), then theres fix: among many others
jagged cloak
commit example: fix(your mom): change fatness or feat(settings): add fatness slider
branch ex: feat/fatness-slider
okay dont trust me with making examples lol
just lookup conventional commits youll find a lot
inland fable
oki thank you so much
fresh cloak
hiya, once again having some trouble getting something
fresh cloak
the regex would probably look like this
replacement: {
// eslint-disable-next-line no-useless-escape
match: /!\i\.isPlatformEmbedded/,
replace: "true"
}
what i'm struggling with is: what goes in the findfield?
the class it's on is just this
class H
i'm assuming in module 656395
how do i construct the find for this?
cunning canyon
Messages.ADD_KEYBIND_WARNING
cunning canyon
why does your regex have ! at start
cunning canyon
R.isPlatformEmbedded is just \i\.isPlatformEmbedded
fresh cloak
never been a regex user
thanks! that worked
don't even know why they don't enable custom keybinds
they work when focused
junior olive
[Plugin] goes harder
ant0n this is a miss tbh
dire trench
decor merged <t:8640000000000:R>
dire trench
how can i reliably get the username associated with a user id
Vencord.Webpack.Common.UserUtils.getUser() and Vencord.Webpack.Common.UserStore.getUser() return undefined for real users
and using restapi to get users even when i cache the users still gets me rate limitted
its only called when you load a message whos author is married to someone in relationshipdb and i still get rate limitted somehow
junior olive
and using restapi to get users even when i cache the users still gets me rate li...
That's not going to magically have different rate limits
charred monolithBOT
livid heath
oki thank you so much
https://www.conventionalcommits.org/en/v1.0.0/ good resource
nimble plaza
what ab messageEvents.add/removeCharCountListener or smt
@austere talon sorry for doubleping but u didnt respond
woeful sable
@junior olive is that the companion cube
mighty hinge
How would i toggle mute using a plugin?
woeful sable
is there a way to move the edit user profile to left or right ( in settings )
dusky sonnet
is there a way to move the **edit user profile** to left or right ( in settings ...
probably the wrong channel but with CSS imma say yes?
woeful sable
yes
charred monolithBOT
shy veldt
Vencord.Webpack.Common.UserUtils.getUser() and Vencord.Webpack.Common.UserStore....
what
jagged cloak
probably skill issue tbh
shy veldt
yeah
livid heath
maybe its just that the users you are referring to as "real" are not cached
spark pivot
Vencord.Webpack.Common.UserUtils.getUser() and Vencord.Webpack.Common.UserStore....
What are you passing into them
verbal pumice
wait, someone can read?
void echo
wait, someone can read?
i think hes a professional
olive aurora
no way they put a tracker on their discord profile
dire trench
What are you passing into them
user ids as strings
im using the site relationshipDB uses to fetch usernames rn as a workaround
kinda scuffed
austere talon
Vencord.Webpack.Common.UserUtils.getUser() and Vencord.Webpack.Common.UserStore....
if they return undefined then the user isn't cached. you can fetch them, optimally using a queue
ebon frigate
it has some issues tho
cant see that the server is running
PS C:\Users\jasdi\Documents\vesktop2\arrpc> node src
[arRPC] arRPC v3.1.0
(node:62904) ExperimentalWarning: Importing JSON modules is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
[arRPC > bridge] listening on 1337
[arRPC > ipc] not available, trying again (attempt 1)
[arRPC > ipc] listening at \\?\pipe\discord-ipc-1
[arRPC > websocket] 6463 in use!
[arRPC > websocket] listening on 6464
[arRPC > process] started