#๐Ÿ‘พ-core-development

1 messages ยท Page 86 of 1

river cobalt
#

(idea here) ^

turbid hatch
#

@spark cove nerd

charred monolithBOT
#

Discord Account

masalaking

What is it that you'd like to see?

An additional setting option on the BetterFolders plugin, where the folder sidebar will automatically close once you select a server within that folder.

The BetterFolders offers extreme convenience for folder navigation, but it does take up some screen real estate. It could feel unnatural to have the folder sidebar visible at all times, especially for new Vencord users coming from regular Discord, so some users would prefer to have it closed, when on a server. As of now, to close the folder sidebar, when you are on a server within a folder, you have to click on the folder icon again.

For users who tend not to navigate much between folders and within folders, this option would offer that extra bit of convenience by clearing some of that taken-up screen real estate by the folder sidebar, by automatically closing whenever you select a server within a folder.

As for the setting option title and description, I propose the following:

  • Title: Auto-Close
  • Description: Close the folder sidebar when selecting a server

NOTE: Apologies if this doesn't fit the feature request requirements. I was unable to locate where the discussions tab was located on the repo.

Request Agreement

  • [ ] This is not a plugin request
#

Discord Account

masalaking

What is it that you'd like to see?

An additional setting option on the BetterFolders plugin, where the folder sidebar will automatically close once you select a server within that folder.

The BetterFolders offers extreme convenience for folder navigation, but it does take up some screen real estate. It could feel unnatural to have the folder sidebar visible at all times, especially for new Vencord users coming from regular Discord, so some users would prefer to have it closed, when on a server. As of now, to close the folder sidebar, when you are on a server within a folder, you have to click on the folder icon again.

For users who tend not to navigate much between folders and within folders, this option would offer that extra bit of convenience by clearing some of that taken-up screen real estate by the folder sidebar, by automatically closing whenever you select a server within a folder.

As for the setting option title and description, I propose the following:

  • Title: Auto-Close
  • Description: Close the folder sidebar when selecting a server

NOTE: Apologies if this doesn't fit the feature request requirements. I was unable to locate where the discussions tab was located on the repo.

Request Agreement

  • [x] This is not a plugin request
#

Discord Account

masalaking

What is it that you'd like to see?

An additional setting option on the BetterFolders plugin, where the folder sidebar will automatically close once you select a server within that folder.

The BetterFolders offers extreme convenience for folder navigation, but it does take up some screen real estate. It could feel unnatural to have the folder sidebar visible at all times, especially for new Vencord users coming from regular Discord, so some users would prefer to have it closed, when on a server. As of now, to close the folder sidebar, when you are on a server within a folder, you have to click on the folder icon again.

For users who tend not to navigate much between folders and within folders, this option would offer that extra bit of convenience by clearing some of that taken-up screen real estate by the folder sidebar, by automatically closing whenever you select a server within a folder.

As for the setting option title and description, I propose the following:

  • Title: Auto-Close
  • Description: Close the folder sidebar when selecting a server

NOTE: Apologies if this doesn't fit the feature request requirements. I was unable to locate where the discussions tab was located on the repo.

Request Agreement

  • [ ] This is not a plugin request
austere talon
#

bro really opened issues on codeburger cause closed on github

charred monolithBOT
verbal pumice
#

why does it send edits horror

charred monolithBOT
#
Ven

Discord Account

masalaking

What is it that you'd like to see?

An additional setting option on the BetterFolders plugin, where the folder sidebar will automatically close once you select a server within that folder.

The BetterFolders offers extreme convenience for folder navigation, but it does take up some screen real estate. It could feel unnatural to have the folder sidebar visible at all times, especially for new Vencord users coming from regular Discord, so some users would prefer to have it closed, when on a server. As of now, to close the folder sidebar, when you are on a server within a folder, you have to click on the folder icon again.

For users who tend not to navigate much between folders and within folders, this option would offer that extra bit of convenience by clearing some of that taken-up screen real estate by the folder sidebar, by automatically closing whenever you select a server within a folder.

As for the setting option title and description, I propose the following:

  • Title: Auto-Close
  • Description: Close the folder sidebar when selecting a server

NOTE: Apologies if this doesn't fit the feature request requirements. I was unable to locate where the discussions tab was located on the repo.

Request Agreement

  • [x] This is not a plugin request
austere talon
#

it does lmao

#

funny

#

jumpscare

river cobalt
turbid hatch
#

veeeeeen

#

i made it workie

#

:3

#

well

#

i embedded the installer site

#

i havent actually made the installer work though

#

i'll leave it as is as a proof of concept, so if we want to carry on with it we can, but the shell app works now just fine

#

wails is actually super cool

#

it literally is just tauri but in go

#

and if you dont have a webview installed it will install it for you, which is ace

#

you can embed a version as well but its a bit eh

#

but yeah it shouldnt be too difficult to port this tbh

austere talon
#

but uh

turbid hatch
#

yeah its funny

#

but we wouldnt be using the daemon in this context anyway

#

so

austere talon
#

if we do webview we wouldn't need it

#

ye

charred monolithBOT
turbid hatch
#

and i've CIed it

#

๐Ÿ’ช

#

so now we can autobuild the wails version of the installer

#

very hot

charred monolithBOT
eager venture
#

how to build?

turbid hatch
#

it's not usable as an installer yet

#

but you need to use wails build to compile it

#

its a custom cli

eager venture
#

Oh ok thanks

river cobalt
#

@turbid hatch h - do you have those repos yet

turbid hatch
#

?

spark cove
#

wth is wails

turbid hatch
#

go's answer to tauri @spark cove

#

but even smaller

spark cove
#

oh based

wind breach
#

snerks

spark cove
#

i kinda thought of rails

wind breach
#

xD

turbid hatch
#

yeah its named after the ruby on rails thing

wind breach
#

omg I wasn't even wrong

#

Hahahahah

turbid hatch
#

When I saw WebView, I thought "What I really want is tooling around building a WebView app, a bit like Rails is to Ruby". So initially it was a play on words (Webview on Rails). It just so happened to also be a homophone of the English name for the Country I am from. So it stuck.

wind breach
#

Ayyyy nice

spark cove
#

wales

wind breach
#

ye

charred monolithBOT
charred monolithBOT
turbid hatch
#

oh i didnt know that

pine topaz
#

interesting, the text goes higher than neko

#

and so does the badge and arrow

#

also now neko is an HTML element

tight forge
#

hi, i need some help creating my own plugin. i dont really understand where do i find the source code to match and replace

tight forge
#

do i j open the current.js from discordscrapping and scroll till i find the needed functions or what

marsh cave
#

ctrl+shift+f

#

in discord devtools

tight forge
#

thanks, but it is still harder than i expected

#

i thought there was some sort of api

pine topaz
#

expect coding to be harder than you think it will be

charred monolithBOT
olive aurora
#

got damn

#

pull request opened #878924 depends on #878923 depends on #878922 depends on #878921 depends on #878920

austere talon
#

what's the point of all these changes

#

don't fix what's not broken

#

and node: import prefix is kinda obsolete

olive aurora
austere talon
#

sorry

olive aurora
#

smh

#

is funny i remember u replying a while ago "oh i kept saying obsolete but it sounded weird"

austere talon
charred monolithBOT
olive aurora
#

WTH

#

MEAN

charred monolithBOT
tawny cipher
#

reduntsolete

austere talon
#

๐Ÿ”ฅ

olive aurora
#

tiny refactor

teal halo
#

tiny

charred monolithBOT
teal halo
#

my god

pine topaz
#

i think my PR should be good now

charred monolithBOT
austere talon
#

before making major style changes / refactors, you should bring it up first

pine topaz
#

the build warning seems to not be related to my code

austere talon
#

so it can be discussed

pine topaz
pine wadi
# austere talon and node: import prefix is kinda obsolete

See https://github.com/nodejs/node/issues/36098 and https://github.com/nodejs/node/pull/37246 . The node URL scheme has been supported for builtin module imports since v16.0.0. Per the first linked issue, any future builtโ€‘in modules may use the node: prefix to not risk ecosystem breakage. Transitioning now means we're consistent. Additionally, outside of Node.js proper, JavaScript runtimes like Deno require the node scheme for their Node compatibility modules. Additionally, Node can throw slightly nicer errors:

Welcome to Node.js v20.2.0.
Type ".help" for more information.
> require("internal/test/binding")
Uncaught Error: Cannot find module 'internal/test/binding'
Require stack:
- <repl>
    at Module._resolveFilename (node:internal/modules/cjs/loader:1070:15)
    at Module._load (node:internal/modules/cjs/loader:923:27)
    at Module.require (node:internal/modules/cjs/loader:1137:19)
    at require (node:internal/modules/helpers:121:18) {
  code: 'MODULE_NOT_FOUND',
  requireStack: [ '<repl>' ]
}
> require("node:internal/test/binding")
Uncaught:
Error [ERR_UNKNOWN_BUILTIN_MODULE]: No such built-in module: node:internal/test/binding
    at __node_internal_captureLargerStackTrace (node:internal/errors:490:5)
    at new NodeError (node:internal/errors:399:5)
    at Module._load (node:internal/modules/cjs/loader:916:13)
    at Module.require (node:internal/modules/cjs/loader:1137:19)
    at require (node:internal/modules/helpers:121:18) {
  code: 'ERR_UNKNOWN_BUILTIN_MODULE'
}

You can also see Node preferring the node URL scheme in these errors when talking about its builtin modules.

GitHub

See the 2020โ€‘10โ€‘29 TSC Meeting notes, where it was decided that CommonJS should also support node:โ€‘prefixed imports, so that any future builtโ€‘in modules (e.g.: diagnostics_channel) donโ€™t risk possi...

GitHub

Fixes: #36098 (appliesย only toย commitย 1d8c8b7)
Refs: #37178 (appliesย only toย commitย b0fbc91)

austere talon
#

none of that is relevant

#

this code will never run outside of node and there is no risk of ecosystem breakage

pine wadi
# austere talon don't fix what's not broken

i was hacking around on runInstaller because the Node process keeps hanging for me after running a reinstall of Vencord & exiting. haven't figured out what's wrong yet but that's why I've been cleaning up the script

turbid hatch
#

it might be correct style by modern standard but we dont really have a reason to do so

austere talon
#

it's not even correct style

#

it's optional

turbid hatch
#

depends on the eslint config you use

#

:^)

#

(its enforced on all of mine)

austere talon
#

thats not relevant tho

#

thats lkike saying single quotes are correct

turbid hatch
#

yeah ik im teasing xd

austere talon
#

no theyre a preference

pine wadi
turbid hatch
#

this does not scream preferred

pine wadi
#

literally all their examples use node:

tawny cipher
#

okay and

turbid hatch
#

so?

austere talon
#

please just do not

#

do not make style changes

#

do not make lint changes

turbid hatch
#

anyway

#

lets move the topic

#

wails!

#

i will begin porting the go daemon tomorrow

#

well

#

no i'll port the daemon and webinstaller

#

and we can play around with it more

#

linux has issues with execution except on ubuntu so i'll investigate trying to move to appimages

#

or using a static build

#

(i know static builds are possible so)

austere talon
#

issues with execution?

turbid hatch
#

our resident linuxer couldn't get it to run on fedora

#

worked fine on ubuntu though

austere talon
#

couldnt get it to run how

turbid hatch
#

as in

austere talon
#

why not

turbid hatch
#

it wouldn't run

#

we dont know

#

presumably because libraries are missing

austere talon
#

elaborate

#

what errors

turbid hatch
#

no such file or directory

austere talon
#

fuill error

turbid hatch
#

taht is the full error lol

#

it's the library missing error on linux

#

linux just worksโ„ข๏ธ

pine wadi
# austere talon please just do not

alright. the project did not document whether the avoidance of node: was intentional, so I at least wanted to offer what I believed to be best practice. i'm fine with the project style taking a position against it

olive aurora
#

like 1% easier

#

wins

#

shifft + 2 vs shift + 7

tawny cipher
#

just make a lang that uses chevrons for strings ๐Ÿ‘

austere talon
#

double quotes are better cause in languages with chars ' is char and " is string

olive aurora
#

real

pine wadi
#

i like backticks as the default string literal in JavaScript but i'm also a weirdo. they work pretty nicely for CSS selectors to sidestep escaping issues almost entirely

olive aurora
#

husk

pine wadi
#

also it's easy to drop in interpolations later

tawny cipher
#

I get internal agressive tendencies when I see backticks without any string interpolation

olive aurora
#

alias ld (laserdisc) into cd

#

compilers will love

charred monolithBOT
austere talon
#

thats also not it

#

there is no preference towards either of them

turbid hatch
#

can we just

#

not edit the styleguide

pine wadi
# turbid hatch not edit the styleguide

i just want to be consistent with whatever the project style is. "we are informed and intentionally have no preference" is fine but it's alsoโ€ฆnot documented to my knowledge anywhere. this is a good thing to document in your style guide

turbid hatch
#

yes but we said multiple times not to change it

#

so i dont understand why you keep opening prs

austere talon
#

use existing code as style guide

turbid hatch
#

hmm..

#

im trying to work out how to fix wails for multilinux

#

ah well

#

i'll do it tomorrow

#

if i do a static build it'll work fine most likely so

austere talon
turbid hatch
#

yes

#

ven

#

the full error is

austere talon
#

that is definitely not the full error

pine wadi
# turbid hatch so i dont understand why you keep opening prs

i opened the PR for node: because i started debugging a .mjs script that used node builtin imports. it's the same reason i opened the PR for linting .mjs filesโ€”I discovered they were missing from the script and wanted to make sure I wasn't accidentally deviating from what style is enforced.

turbid hatch
#

"no such file or directory"

#

it's a library error

#

that IS the error

austere talon
#

no

#

it would tell u what file

turbid hatch
#

VEN

#

I'M BEING SERIOUS

#

THAT IS THE FULL ERROR

austere talon
#

then they should get the full error

turbid hatch
#

"bash: ./VencordInstaller: no such file or directory"

#

I JUST DID IT MYSELF VEN

#

PLS

austere talon
turbid hatch
#

VEN

#

I BEG OF YOU

#

LISTEN

#

THAT IS THE ERROR

#

***THAT IS IT ***

#

I ALREADY MADE IT EXECUTABLE

olive aurora
#

ldd VencordInstaller

turbid hatch
#

I ALREADY CHECKED THAT IT EXISTED

#

PLSSSS

#

oh yeah ldd exists doesnt it

olive aurora
#

you are probably missing a lib

turbid hatch
#

let me check

#

oh yeah its missing like

#

gtk

#

lol

#

wait what?

olive aurora
#

em

#

show

turbid hatch
#

libgtk-3.so.0 => not found

frail skyBOT
#
Bad Patches

IgnoreActivities (had no effect):
ID: 614711
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
austere talon
#

so ur missing webview lib

turbid hatch
#

sir

#

no im missing gtk apparently

#

lol

#

oh and webkit2

#

hm

#

static build would fix that but eh..

#

that would make it quite large

#

also this is nixos so its stupid

#

ah fuck it i'll static build it

olive aurora
#

fix ur system

olive aurora
#

you need to specify gtk as a dep or sm

charred monolithBOT
#

please avoid redundant style changes / unnecessary refactors, this contributes nothing relevant and just pollutes history and wastes both of our time

Could this be reopened? It actually fixes a handful of bugs, or at least brings a few things to type compliance. It's also been refactored to no longer land on top of on #1662.

Ideally, this would also fix hang I'm running into with this script on Windows, but I'm still debugging that.

olive aurora
#

or its just not accessible

#

i hate nix so much

#

why isolate EVERYTHING

pine wadi
#

nix my beloved

pine wadi
frail skyBOT
#
Bad Patches

IgnoreActivities (had no effect):
ID: 614711
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
austere talon
#

dont use nix

pine wadi
pine wadi
austere talon
turbid hatch
#

xd

#

so i need to work it out a different way

#

i dont actually care about nix so

austere talon
#

send link

turbid hatch
#

and there's already a nixos overlay for vencord

austere talon
#

omg u need to be logged in

#

fucking shithub

turbid hatch
#

its so u dont use actions as a cdn

#

because its ephemeral

austere talon
pine wadi
# austere talon yes

that was because of https://github.com/Vendicated/Vencord/pull/1662. GitHub offers no built-in support for PR stacks. I'd love if they did! (See https://sapling-scm.com/docs/git/intro/ for discussion of this; Sapling offers multiple options to get around GitHub's lack of support. Vencord is not using Sapling.) The best I can do here is document that this is a stacked PR in its description. The commits unique to https://github.com/Vendicated/Vencord/pull/1663 change 1 file.

Because you have now closed the PR, these statistics won't update until it's re-opened.

#

discord truly is incredible at parsing

pine wadi
#

https://github.com/ezyang/ghstack produces stacked PRs with (more) normal Git that look better in GitHub's UI, but you have to merge those PRs using ghstack land $PR_URL. again, this project doesn't use ghstack and i doubt you want to start right now.

#

i would have made these changes on top of main but then my commits wouldn't be linted by CI, even without the change from .mjs โ†’ .mts.

tame escarp
pine wadi
#

sapling is indeed neat

tame escarp
#

i scrolled down to the bottom of the page for the first time and got meta open source jumpscared

pine wadi
#

yeah that's my biggest concern about it. meta open-source can be weird to depend on

olive aurora
#

lewi why is your system so broken

olive aurora
pine wadi
# austere talon yes

as for why this was on top of https://github.com/Vendicated/Vencord/pull/1662 at all, that's because I didn't want my commits to cause the node module scheme to be introduced just for this file. the changes i was making in the build/tsScripts patch stack did not logically depend on node:, so that change wasn't made within that patch stack. my default for style changes like that is to introduce them properly, project-wide, so that they can get properly reviewed, like what happened here. when the style changes got refused, removing them from the build/tsScripts patch stack was a matter of rebasing, removing node: in the merge conflicts, & testing again to ensure that nothing I introduced depended on node:. i am trying very hard to make things clear, easy to review, & not slip things by you all.

austere talon
#

@turbid hatch hiii

#

whats the uhm vencloud stats page again

#

:3

austere talon
#

thanks lewi!

olive barn
#

ofc :D

charred monolithBOT
fleet depot
# charred monolith

@quiet arrow when I tried to do this a few months ago it was inexplicably incredibly laggy

#

I ended up binding it to a keybind instead

#

Would you be interested in that?

fleet depot
#

But I also wanted that

turbid hatch
#

@austere talon what luna said!

olive barn
#

:D

charred monolithBOT
charred monolithBOT
charred monolithBOT
#

the code should simply skip rendering the irrelevant permissions

Done. While handling this I realized that the list rendering wasn't keyed, which gets more relevant when adding/removing classes from a list, so that's done for both listings now.

The nesting got severe after introducing <Fragment> to handle permissions that aren't rendered, so permission item display has been factored out to a standalone PermissionItem component.

pine wadi
#

also, in case you're wondering why getPermissionValue and getOverwriteValue have explicit return types on the final declaration, those are required for TypeScript override sets.

charred monolithBOT
tawny cipher
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
verbal pumice
#

or split into multiple lines which is generally discouraged for a ternary

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
crude hearth
#

If its gonna be multiple lines why use ternary ๐Ÿฅด

charred monolithBOT
charred monolithBOT
turbid hatch
#

@spark cove you free to join vc and dev for a bit

turbid hatch
tawny cipher
#

kek, 700 forks, farm acc

austere talon
olive aurora
#
const stuff = if boolean {
    ifTrue
} else {
    ifFalse
};
#

๐Ÿš€๐Ÿš€๐Ÿš€๐Ÿš€๐Ÿš€๐Ÿš€๐Ÿš€

turbid hatch
#

@austere talon VEN

#

IT WORKS

austere talon
#

Hi

turbid hatch
#

THE WAILS INSTALLER ACTUALLY WORKS

#

I PORTED ALL OF IT

#

:D

austere talon
turbid hatch
austere talon
#

niiice good job

turbid hatch
#

we added a loader because we got bored xd

austere talon
#

I shall test later

#

we?

#

and what loader

turbid hatch
#

me and vap have been working on this together

austere talon
#

oh i see

turbid hatch
#

also ill fix the terminal thing

#

its a carryover from the old installer

austere talon
#

why does it open some terminal

#

jumpscare

turbid hatch
#

because you're executing the command line xd

#

to kill discord

austere talon
#

but

#

why is it so weird for you

turbid hatch
#

because i have windows terminal not to close on failure

austere talon
#
  • we can probably make it kill using winapi or smth to avoid popup maybe?
turbid hatch
#

and because discord dev isnt running it fails

#

xd

#

and yeah probs

#

but the installer does work

#

which is the bit im happy about

austere talon
#

nicee

turbid hatch
#

anyway pc build time

#

see you in 30 mins

river cobalt
#

@austere talon I am commiting sin

#

trying to patch discord's http requests TrolleyCrazy

austere talon
#

why tho

river cobalt
#

so like if you update a channel and it 403s

#

its just like "lol didn't work"

#

so im adding a way for people to see that error

austere talon
#

patch discords rest api module then

verbal pumice
#

on the topic of the terminal

#

cant you kill discord with taskkill instead of powershell command so you dont have to wait 6 years for powershell to start on older pcs

ornate kayak
#

can anyone help me i want to download vencord

verbal pumice
ornate kayak
#

i am yt a content creater

royal bane
#

read

pine topaz
#

could someone check my oneko PR, i made some pretty drastic changes

#

i dont think that the build warning is related to my code, as deleting the plugin entirely still gives the same warning

#

and the only other thing i did was add myself to the contributor list

inland zinc
quiet arrow
fleet depot
#

the powershell goes away quick but it's still a bit of a jumpscare

fleet depot
#

i ask because on windows i have it bound it escape and on linux i bind it to win+escape

#

also do you have any experience with the dev build of vencord?

#

i can walk you through it, it's pretty easy. but every time vencord updates you'll have to repull

charred monolithBOT
river cobalt
charred monolithBOT
royal bane
#

is this a thing

azure jay
charred monolithBOT
charred monolithBOT
#

I have the same error. When running vencord on terminal, I get ths.

[9489:0818/193802.709839:ERROR:object_proxy.cc(590)] Failed to call method: org.freedesktop.DBus.Properties.Get: object_path= /org/freedesktop/portal/desktop: org.freedesktop.DBus.Error.InvalidArgs: Nรฃo existe o ambiente โ€œorg.freedesktop.portal.FileChooserโ€
[9489:0818/193802.709894:ERROR:select_file_dialog_linux_portal.cc(274)] Failed to read portal version property
(node:9489) UnhandledPromiseRejectionWarning: Error [ER...

charred monolithBOT
quiet arrow
fleet depot
turbid hatch
#

@azure jay just fyi we might not be maintaining that repo for much longer

#

xd

azure jay
#

lmao

#

why

turbid hatch
#

Vencord/WailsInstaller

azure jay
#

it was such a fun concept tho

fleet depot
# fleet depot are you familiar with building a dev version of vencord?

cuz there are two ways we can do this:

  1. you make your own fork and i tell you what to change
    (you'll have to maintain it and make sure it syncs every so often)

  2. you use my fork with my changes but then you'll have to rely on me for maintaining it and making sure it syncs. which for the forseeable future id do but the point is you have less control

charred monolithBOT
fleet depot
#

i mean (3) i make a PR for it but then id have to figure out how to make it work with a mac tho i do not have a mac

#

sooo i never bothered

charred monolithBOT
spark cove
#

oh i just probably look here before responding to github stuff

azure jay
#

so sad, merge it before you remove the repo at least

turbid hatch
#

@spark cove im so confused how the go installer even works lol

#

find_discord_* doesn't have conditional compilation, so how does it know which file to include in the build

#

ah well

#

i've added conditional compilation to it now

spark cove
#

same idk

turbid hatch
#

@austere talon u wrote it xd

#

how does it work

austere talon
#

what?

#

*_windows.go is automatically windows only

turbid hatch
#

eh?

#

does go do that?

austere talon
#

yes

turbid hatch
#

i couldnt find that behaviour in the compiler docs

#

huh

#

i.. actually really dislike that as a feature lol

austere talon
austere talon
#

it's intuitive

turbid hatch
#

i dont like stuff being conditionally compiled based on file names, i much prefer explicitly defining the go:build condition

turbid hatch
#

i was reading something else then

#

now

#

next order of business

#

working out whatever the hell is wrong with the go compiler

#

well

#

more specifically

#

ld

#

these dependencies are present

#

oh

#

wait im dumb

#

you cant static build those lol

#

annoying

turbid hatch
austere talon
#

just leave it the way it is :p

turbid hatch
#

aaaaand also it means that file names have meaning, which is not a good idea ("find_windows.go" wouldn't be compiled on other operating systems besides windows)

austere talon
#

don't fix what's not broken

turbid hatch
#

ye i will

austere talon
#

the filename convention is used by many projects

#

cause it just makes sense to me

turbid hatch
#

shrug

#

well anyway linux is a bit of a fucky build

#

because gtk poi_thumbsup

#

mac and windows should work fine

#

so all we have to do really is just actually finish the installer

#

since it's a directly 1:1 port of the websocket based system to the IPC based system there's not really much different atm

austere talon
#

go also uses filename for test files

#

check filenames here shiggy

turbid hatch
#

tbf that is a universal convention at this point, every language uses that

#

ye i know

austere talon
turbid hatch
#

yeah

austere talon
turbid hatch
#

the websocket code is gone

#

its replaced with an IPC binding

austere talon
#

and instead use what

#

I see

turbid hatch
#

wails includes a native IPC system that just works

#

and generates typedefs for you

austere talon
#

I guess porting it was trivial cause its just the same shit but via ipc instead of socket

turbid hatch
#

pretty much

#

all i had to do was

#

this

#

and then tell wails that i wanted thees bound to the frontend app

#

like this

austere talon
#

why do you even use string formatting

#

I find it less readable than just +

turbid hatch
#

because its recommended

#

by go style

spark cove
#

the porting was funny how drop-in it was

austere talon
turbid hatch
#

and i got yelled at by the language server when i used +

#

because it said i should just use errorf

austere talon
#

I always just use + and it never complained

turbid hatch
#

shrug

austere talon
turbid hatch
#

it gets upset with your error names btw

#

because they violate go error convention

#

xd

turbid hatch
#

i literally have to do no work, it just works

turbid hatch
#

the typedefs are a little funny though

austere talon
#

does this work?

#

I don't remember tbh

turbid hatch
#

yes but i dont know why you would do that

#

xd

austere talon
#

wdym

turbid hatch
#

well

#

what are you

#

actually trying to do with that

austere talon
turbid hatch
#

oh i see

#

yes

austere talon
#

any is new thing introduced in go 18 that's the same but less confusing

turbid hatch
#

because any is just interface{}

austere talon
#

I find interface{} kinda confusing lol

austere talon
#

well not anymore but the first time I used it

turbid hatch
#

this was literally just a copypaste

#

from the wails docs

#

lmfao

austere talon
turbid hatch
#

its surprising how little effort all of this was

#

as vap said it was quite literally drag and drop for the most part

#

most of the effort was me putting the installer into its own module

austere talon
turbid hatch
#

yeah thats what i mean

#

lol

#

it cant get the arg name

#

and also the generated code is horror

austere talon
#

lol wtf is that comment on the first line

turbid hatch
#

it's welsh

#

for

#

well

#

the second comment

austere talon
#

๐Ÿ˜ญ

#

welsh

turbid hatch
#

the dev is welsh and the entire project is literally names

#

wales

#

xd

austere talon
#

lmaoo

#

that's fine tho tbh

turbid hatch
#

i love window.go

#

the best global

#

it is yeah

austere talon
#

it's ugly but who care

turbid hatch
austere talon
#

can u rename the global?

turbid hatch
#

no

austere talon
spark cove
#

go

turbid hatch
#

well

austere talon
#

agony

turbid hatch
#

maybe

#

lets see

austere talon
#

that's pretty cool tho

#

tho if we're gonna need the typings generated by the installer

#

it might be better to make a monorepo after all

turbid hatch
#

yea you cant

turbid hatch
#

i copied and pasted the installer code in, and webinstaller too

#

but this is quite a modified webinstaller anyway

#

so

#

oh also

spark cove
#

yea im probably gonna add back the installer as a window

#

but with the title bar like

#

a lot more hidden so it doesnt look weird with 2

turbid hatch
#

ye if u want

spark cove
#

i have to

turbid hatch
#
Mac: &mac.Options{
    TitleBar: &mac.TitleBar{
        TitlebarAppearsTransparent: true,
        HideTitle:                  false,
        HideTitleBar:               false,
        FullSizeContent:            false,
        UseToolbar:                 false,
        HideToolbarSeparator:       true,
    },
    Appearance:           mac.NSAppearanceNameDarkAqua,
    WebviewIsTransparent: true,
    WindowIsTranslucent:  false,
    About: &mac.AboutInfo{
        Title:   "My Application",
        Message: "ยฉ 2021 Me",
        Icon:    icon,
    },
},
Linux: &linux.Options{
    Icon: icon,
    WindowIsTranslucent: false,
    WebviewGpuPolicy: linux.WebviewGpuPolicyAlways,
},
spark cove
#

or else no shiggy clicker

turbid hatch
#

we have these options to fiddle with

#

so we can make the mac version look nicer

#

by removing the titlebar and inlaying it

#

which might be fancy

#

but of course i dont have a mac so i cant test it

#

anyway

#

the Future Of Vencord Installer

charred monolithBOT
spark cove
#
DEB | Invalid JSON passed to callback: Expected double-quoted property name in JSON at position 87. Message: {"result":[{"branch":"canary","path":"C:\\Users\\super\\AppData\\Local\\DiscordCanary",```
charred monolithBOT
torn knot
#

something I noticed between vesktop and discord, vesktop is top

#

discord uses its own user agent, but that makes me wonder if that would make any difference

austere talon
#

what exactly are you trying to say?

charred monolithBOT
stark flint
#

Hi

royal bane
#

hi

torn knot
#

nothing did

#

so forget I even mentioned UAs

austere talon
#

we deliberately spoof the user agent to a browser user agent as otherwise vc is just broken

pine topaz
#

how did i send that right as it closed

#

329 ms before closing

torn knot
#

also, a plugin/setting for auto unmute on app startup would be nice, saving a few clicks here and there (my ocd is going crazy seeing myself muted whenever I start the app)

austere talon
#

having electron user agent makes discord assume you support their custom voice chat thingie instead of using webrtc

#

since that's just not supported on web you get weird errors

charred monolithBOT
charred monolithBOT
austere talon
#

ah fair

#

it seems like its just that the PronounResponse type isnt fully correct

charred monolithBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

IgnoreActivities (had no effect):
ID: 770343
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 resetSocketOnError Cannot access 'pfe' before initialization
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
charred monolithBOT
frail skyBOT
#
Bad Patches

IgnoreActivities (had no effect):
ID: 12422
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
charred monolithBOT
quiet arrow
turbid hatch
#

@austere talon aaaa im just checking out this merge queue feature, its genuinely a shame its only for orgs because it would be so useful for the main vencord repo

#

it really does work just like bors, you add a bunch of PRs to the queue and it'll run them all at once and remove the ones that fail

#

also lol "only merge non-failing pull requests" being an option is so funny

maiden sapphire
#

message preview button makes me uncomfortable

austere talon
#

LMAOOO

#

real

limber skiff
#

Vencord has more stars than Aliucord party

maiden sapphire
#

padding: "0 2px"

#

should have padding top fix

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
#

then ur build process is fucked

#

lol

#

that's the simple answer to that one

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
pine topaz
#

pretty please

olive aurora
#

horror

pine topaz
#

ugly please?

pine topaz
stark flint
#

youโ€™ve been asking multiple times a day, be more patient
if everyone that had a pending PR did the same thing this channel would be chaos

pine topaz
#

ok

charred monolithBOT
lime stone
#

prs taking time to be reviewed is pretty normal lol

#

On an active repo, your time shall come

#

on an inactive repo, your pr will sit there for three years

charred monolithBOT
charred monolithBOT
verbal pumice
#

@woeful sable you

charred monolithBOT
charred monolithBOT
woeful sable
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
torpid thicket
#

So I am trying to update my vencord build but everytime I run pnpm build I get Build failed with 1 error: src/plugins/rnnoise.web/index.tsx:24:48: ERROR: Could not resolve "@sapphi-red/web-noise-suppressor" does anyone know how to fix this?

woeful sable
#

did you pnpm i

#

also

#

vns

nimble pendantBOT
charred monolithBOT
frail skyBOT
#
Bad Patches

IgnoreActivities (had no effect):
ID: 770343
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 resetSocketOnError Cannot access 'pfe' before initialization
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
#
Bad Patches

IgnoreActivities (had no effect):
ID: 913184
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
charred monolithBOT
charred monolithBOT
tame escarp
#

rip the old fxtwitter plugin

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
verbal pumice
#

2749

teal halo
#

never

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
olive aurora
#

electron issue we can't do anything

gleaming sapphire
#

ok everyone, sorry if this is not the right place, can i ask, i wanted to change the sprite sheet for oneko plugin ( https:// raw.githubusercontent.com/adryd325/oneko.js/5977144dce83e4d71af1de005d16e38eebeb7b72/oneko.gif ) but it seems like everyng is hosted and fetch()ed from the web, so i cant just change the code. so far i was spending hours, trying to trace the way vencord loads and download everything to my pc and have it fetch() from a path instead of url, but it struck me that that 1) might not even work 2) there's a radically easier way, so here i am. asking: " is there an easier way to do the things i have described ? "

tawny cipher
#

can't you just swap it out with a css snippet

gleaming sapphire
#

huhhh ???

#

but the image is on the internet and the code that loads the image as well

#

*images

gleaming sapphire
#

ah damn

#

i feel stupid now

#

thanks lol

#

no idea how thats possible but thanks

tawny cipher
#

it just replaces the url

gleaming sapphire
#

ok ok, im here again, is there an equally magical line of css to change the dimensions of the sprites on the spritesheet ?

charred monolithBOT
frail skyBOT
#
Bad Patches

IgnoreActivities (had no effect):
ID: 770343
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 resetSocketOnError Cannot access 'pfe' before initialization
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
#
Bad Patches

IgnoreActivities (had no effect):
ID: 913184
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 [kb store] KeybindStore: Looking for callback action SOUNDBOARD_HOLD but it doesn't exist in this version. Skipping
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
charred monolithBOT
charred monolithBOT
spark pivot
#

How would I store user inputted data, not settings, but like the user clicks something, opens a modal, types some string in and it saves?

spark pivot
#

thank you

charred monolithBOT
charred monolithBOT
elder garnet
charred monolithBOT
charred monolithBOT
charred monolithBOT
austere talon
#

what ๐Ÿ˜ญ

teal halo
#

๐Ÿคจ

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
teal halo
#

compact mode is good

grizzled halo
#

๐ŸŽ‰

#

whats this nickname

#

wtf

#

ok changed it

#

wadahel

charred monolithBOT
teal halo
#

any way to see if the user has compact mode or cozy mode selected?

charred monolithBOT
charred monolithBOT
spark cove
teal halo
#

k

charred monolithBOT
grizzled halo
austere talon
#

get the preference

teal halo
#

i have no idea how SettingsStore works

#

or if it's even the right store

spark cove
#

lol i mean to actually grab the class

#

but yea settingsstore would be better

frail skyBOT
#
Bad Patches

IgnoreActivities (had no effect):
ID: 870640
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 resetSocketOnError Cannot access 'xfe' before initialization
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
#
Bad Patches

IgnoreActivities (had no effect):
ID: 870640
Match: /!([A-Za-z_$][\w$]*)(\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors
font-weight: bold;
color: purple;
 resetSocketOnError Cannot access 'xfe' before initialization
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Unable to process domain list delta: Client revision number is null
%c[FetchBlockedDomain] 
font-weight: bold;
color: purple;
 Downloading the full bad domains file ```
marsh cave
# teal halo any way to see if the user has compact mode or cozy mode selected?
import { getSettingStoreLazy } from "@api/SettingsStore";
import definePlugin from "@utils/types";

const IsCompact = getSettingStoreLazy<boolean>("textAndImages", "messageDisplayCompact");

export default definePlugin({
    name: "IsCompact",
    description: "",
    authors: [],
    dependencies: ["SettingsStoreAPI"],

    start: () => {
        // there's also the useSetting hook
        // https://github.com/Vendicated/Vencord/blob/main/src/plugins/gameActivityToggle/index.tsx#L46-L58
        console.info("messageDisplayCompact:", IsCompact?.getSetting());
    }
});
charred monolithBOT
teal halo
charred monolithBOT
austere talon
#

why so many stars did anything happen

charred monolithBOT
verbal pumice
#

new vencord tiktok video ๐Ÿ”ฅ

charred monolithBOT
charred monolithBOT
proven sierra
#

star

cunning canyon
proven sierra
#

๐Ÿ˜จ

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
turbid hatch
#

@austere talon o ye can you add the webhook to wails

#

i dont know what the url is that you use

austere talon
#

whar

#

done

grizzled halo
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
grizzled halo
#

hi >.<

npm ERR! While resolving: vencord@1.4.5
npm ERR! Found: eslint@8.47.0
npm ERR! node_modules/eslint
npm ERR!   dev eslint@"^8.46.0" from the root project``` during `npm i`
grizzled halo
#

ty

#

how gullible of me to forget a p fr

olive barn
#

would a plugin with hacky importing be accepted

#

and once its loaded

#

otherwise it throws this, presumably because its loading the list of plugins while its still null

tawny cipher
#

pascal case jumpscare

nocturne haven
#

dynamic import it

nocturne haven
#

you can

austere talon
#

lazycomponent is uir friend

#
const PluginCard = LazyComponent(() => require("@components/PluginSettings").PluginCard as typeof import("@components/PluginSettings)".PluginCard);
olive barn
#

i mean it still builds and works

nocturne haven
#

here's for your understanding

olive barn
#

ahhhh tysm

#
const PluginCard = LazyComponent(() => require("@components/PluginSettings").PluginCard as
    // @ts-ignore
    typeof import("@components/PluginSettings)").PluginCard);```

![trolley](https://cdn.discordapp.com/emojis/1024751352028602449.webp?size=128 "trolley")
nocturne haven
#

iirc just get rid of the typeof should fix it โ„ข๏ธ

olive barn
#

[[FakeNitro]]

#

:D

tawny cipher
#

not a huge fan of the bracket notation but I don't have any better idea either

olive barn
#

stole bracket notation from ios jailbreaking servers

nocturne haven
#

make it a link such as vencord://plugin/FakeNitro

tawny cipher
#

too convoluted

teal halo
#

vencord://settings when

nocturne haven
olive barn
tawny cipher
#

well might as well make an actual vc protocol then

#

just faking the url is kinda eh

teal halo
nocturne haven
nocturne haven
#

but you can also optionally urlencode, but that seems complicated

teal halo
#

AI%20Noise%20Suppression

#

yeah sounds good to me

austere talon
#

the [[ is cool

#

also would be really easy to make that real

#

oh wait is that what youre making

olive barn
#

yeah

austere talon
#

pog

#

using accessories api?

olive barn
#

yep !

teal halo
#

[[]]

#

๐Ÿ‘

olive barn
#

checks if the plugin exists :3

teal halo
#

nice

charred monolithBOT
olive barn
#

:D

teal halo
#

me when i click on codeberg: damn nice github theme

olive aurora
tawny cipher
#

actually, easy fix for the notation, could you add a setting to not render the notation in messages when used

olive aurora
#

thats the old header

olive barn
#

oh awa

#

it was taken from whatever tab was open

teal halo
olive aurora
#

dont do that