#πŸ‘Ύ-core-development

1 messages Β· Page 74 of 1

turbid hatch
#

owned by an organization

#

well if the option is there

#

might as well try ut

#

it

#

if not, oh well

austere talon
#

activities pr has so much code i look another time okay

#

what happened to sun

#

godi just reviewed like 7 prs and theres still 50 more

charred monolithBOT
#
[Vencord/Vesktop] New tag created: v0.2.7
teal halo
#

extremely scary stuff (real)

austere talon
#

okay enough work done for today

#

time to go on hiatus for 2 weeks again

#

/hj

#

well i cant wait for vap to finish noise cancellation

#

speaking of which hows that going @spark cove

jagged cloak
#

nop hiatus for a month

austere talon
#

any roblox that are still in ur way?

spark cove
#

also

#

yea just need people to test it

austere talon
#

ohhh real

spark cove
#

to make sure it isnt useless long term

austere talon
#

i will test tomorrow

spark cove
#

wait imma be in a call for

austere talon
spark cove
#

a while toay

austere talon
#

itll help feel better

spark cove
#

but someone with a worse cpu should test too

austere talon
#

btw i never told u but ur profile colours sooo good

jagged cloak
#

true

#

dj khaled loves talking about life's roblox

austere talon
#

are u sure my approach wontr work out

#

where u just use the js api

spark cove
#

its my life's color palette

#

u can just use computed style on a temp element right

#

i love when websites try to have anti scam messages in their consols

#

but in reality when someone opens their console all they will see is this

austere talon
#

LMAOO

#

real

#

i mean thats ublocks fault

spark cove
#

oop ur so right

austere talon
#

whar

spark cove
#

ayo check this out

austere talon
#

fire

spark cove
#

is this based

woeful sable
spark cove
#

i saw that video earlier

#

and sent it to like 3 poeple

#

i dont remember where

austere talon
#

i feel bad for ryan

#

did so much effort for nothing

#

yes

#

you dont even have to credit cause its same licensers

spark cove
#

well ryan's thing supports like

#

a lot of colors formats i think arent valid css colors

#

so kinda firerer

#

thats insane

#

is oklab like

#

a different color space

#

so its not projecting to rgb

#

or is it just too spicy πŸ”₯ πŸ”₯ πŸ”₯

#

ven got spicy with the pr queues

charred monolithBOT
#
  • FakeNitro: Fix crash
  • Add "Show New" option in plugin settings (#1416)
  • delete uwuifier plugin (#1414)
  • Bump monaco editor
  • chore: Update dev ids
  • feat(MessageLogger): add option to ignore channels and guilds (#1420)
  • classNameFactory: Allow (& ignore) all sorts of falsy values (#1427)
  • [chore] Update DisableDMCallIdle description (#1422)
  • fix vencord toolbox being unusable with drag region (#1480)
  • New plugin: VoiceMessages (#1380)
  • Themes tab: Add QuickCss button (#1475)
  • fix(P...
austere talon
#

no

#

well codeburger forcepushes

#

for repo sync

quasi solstice
#

why are linux terminals so nice its not fair :(

#

meh both have nice terminals

austere talon
#

windows can have nice terms too

austere talon
#

?

#

how would it be a vuln

#

it would just break popouts

#

or im misunderstanding

austere talon
#

I don't understand

austere talon
charred monolithBOT
twin cape
cosmic grove
patent minnow
charred monolithBOT
tawny cipher
#

would be good if someone else could try as well

cunning canyon
tawny cipher
#

can you send the raw message content

cunning canyon
tawny cipher
#

consider me extremely dumbfounded

#

I cannot replicate it not working

jagged cloak
#

thats a nope for me too

tawny cipher
#

I have about zero ideas as to what's happening

jagged cloak
#

id start at the context menu patch

#

ig

austere talon
#

I didnt investigate further because at that point I was already pretty drained cause I reviewed a shit ton yesterday and there weren't any errors in the console

#

but I can check it out more

#

I suspect its related to your code relying on some data to already be existing

#

like it not functioning properly if you have an absolutely clean slate

#

try deleting all DataStore entries of the plugin and seeing if you can then reproduce

tawny cipher
#

alrighty-oh will try that

teal halo
#

it just doesnt appear for me

#

btw would something that adds more themes here (theme-amoled and theme-darker) be considered a third party plugin or worth pushing into main

jagged cloak
#

considering theyre going to be adding those exact two themes into regular client soon i dont think theyd be there for very long

tawny cipher
median rapids
#

dtest me

median rapids
teal halo
#

id be surprised id they release it and darker soon tbh

median rapids
#

understood

teal halo
median rapids
#

wdym?

teal halo
#

why would anything make sense

#

with discord

median rapids
austere talon
long heart
#

you can’t register in the account switcher too

median rapids
#

that makes sense sk

long heart
#

it’s just the form

charred monolithBOT
torn knot
#

I'm screwed if they do

#

ello

charred monolithBOT
tawny cipher
#

kek injecting a local build on mac breaks discord, is anyone aware of that

charred monolithBOT
tawny cipher
#

ultrakek, no I didn't

#

it should probably not let you inject without building, or just do it automatically lol, brain signed off

#

my bad

charred monolithBOT
glass cedar
#

Me when [Plugin}

spark cove
#

set interval notation

charred monolithBOT
spark cove
#

my life would be so much better if server list was similar to channel list

#

and also had a search bar and folders

golden gulch
#

devilbro jumpscare

verbal pumice
spark cove
#

no

#

but similar so i get the connection

charred monolithBOT
golden gulch
spark cove
#

devilbro jumpscare

verbal pumice
charred monolithBOT
spark cove
#

discord already has a basic version of that

charred monolithBOT
spark cove
#

maybe im just misunderstanding

austere talon
spark cove
#

wtf

#

i use ctrl + k

austere talon
#

ctrl k soooo mid

#

ctrl t >>>>

spark cove
#

what is the difference

#

wtFF

austere talon
#

same thing

#

just different bind

spark cove
#

stupid

#

bloat

austere talon
spark cove
#

kinda

austere talon
#

* for servers
# for channels
@ for users

#

I HATE THE NEW MARKDOWN

woeful sable
#

why is it on 2 binds husk

charred monolithBOT
fleet depot
fleet depot
woeful sable
#

horror

charred monolithBOT
olive aurora
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
cloud sandal
#

Hello, I have a question is the FakeNitro's stream quality bypass affecting performance? Like is it more performance taxing than regular nitro streaming quality?

teal halo
#

i did this one last week but i suck at git

charred monolithBOT
#

Discord Account

Azvidplayz

What happens when the bug or crash occurs?

I click the install button on the installer and it says I have a broken install, and I tried uninstalling and reinstalling Discord, but the same thing happened

What is the expected behaviour?

I expected Vencord to install but instead, it showed an error (see image)

How do you recreate this bug or crash?

I'm not sure how to recreate it, it just happened after I opened the installer

Errors

charred monolithBOT
#

Discord Account

@rainydaysout

What is it that you'd like to see?

The feature itself would allow you to change the clock without changing your Language Settings simply allowing you to enjoy your preferred clock format without having to change the language.
This feature would also allow you to change the Date format as well.
So you could have you your own format that's easiest for you to read without having to find the right language.

The settings would pretty much be like this....

#

Discord Account

No response

What happens when the bug or crash occurs?

The bug always happens when I try to record myself speaking while using the new voice message feature. The error message "Failed to finish recording" appears.

What is the expected behaviour?

I expect the recording to feature to work.

How do you recreate this bug or crash?

  1. Click the + sign near the chat prompt
  2. Click send voice message
  3. A voice recording prompt appears
  4. Click start recor...
austere talon
#

what is it with people and being unable to edit the title 😭

stark flint
#

[Bug] <title>

jagged cloak
#

[Bug] <title>

austere talon
#

@placid hinge pretty please could you fix the vesktop update link logic

grave mangoBOT
austere talon
#

this used to work fine but now we have both amd64 and arm64 so it gives some people the wrong link

#

it needs to properly determine which one should be used

teal halo
#

why are there so many dmg/mac files πŸ’€

austere talon
#

zip is standalone

#

or smth

#

idk

teal halo
#

thats confusing

austere talon
teal halo
#

as in has both arm64 and intel in the same app

teal halo
austere talon
#

part of me wants to just disable issues

#

but they're useful for tracking stuff

#

and feature requests

charred monolithBOT
austere talon
#

?

jagged cloak
#

mount virtual disk to install one application kinda insane

#

but i dont know how mac works so

#

didnt i say i would shut up

charred monolithBOT
austere talon
#

wtf is sparkle

charred monolithBOT
austere talon
#

why does mac not have tray

teal halo
#

it doesnt need a tray

#

the dock already does everything

stark flint
austere talon
#

probably not possible without code signing

charred monolithBOT
teal halo
stark flint
#

i will make pr #69 trolley

teal halo
#

bet

charred monolithBOT
#

is this just about having 24h time and english? if so, Discord Settings > Language > English, UK

in any case, this isn't the right place to put plugin requests, please use discussions

Ah okie, thanks I'll go to discussions then.
It's not just about the English with that, it's also so you can have any date & time formats without having to find the region that has your preferred format.
The idea was to just make those separate to where anybody from any region could have whatever f...

teal halo
#

i failed

stark flint
#

NOOOO

#

dammit

austere talon
#

u can under two conditions:

  • it doesn't add considerable bloat. that's why i didn't use electron-builder updater, cause it quadrupled bundle size
  • it doesn't require code signing
charred monolithBOT
austere talon
#

does this look good to you ryan

#

idk anything about mac you have now become vesktop mac maintainer congratulation

teal halo
#

we already have this anyway

#

yes cta_dies_dead

austere talon
#

LMAO

#

okay but seriously how is mac this shit 😭

#

like

#

didnt they think for one second "hey maybe we shouldnt display the full resolution icon here"

austere talon
#

😭

charred monolithBOT
austere talon
#

ryaaaan

#

did u try the thing that someone said

#

where u put the colour on a temp element

charred monolithBOT
teal halo
#

imagine if discord had this exact issue when they made their mac app πŸ’€

charred monolithBOT
#

Discord Account
rainydaysout

This is just feature that should be there normally.
The feature itself would allow you to change the clock format without changing your Language Settings simply allowing you to enjoy your preferred clock format without having to change the language.
This feature would also allow you to change the Date format as well.
So you could have you your own format that's easiest for you to read without having to find the right language.

The settings would pretty m...

austere talon
#

if it works on chrome its fine i think

charred monolithBOT
teal halo
#

i will get pr 70 tho

#

i'll need a bit of help before that

#

how can i fix this error? it seems that platform node is already specified to it in the build script

#

is it just stupid

charred monolithBOT
#

What if there's a feature that could tell us if someone is pretending to be offline? I personally believe this should be an option mainly because there are some friends who pretend that they have to get off but in reality it's not the case, knowing if they are actually fake being offline helps you understand that these are really not the kind of people you would like to keep in touch with them. It's important to be honest with you in all aspects of the relationship, whether it's something sma...

teal halo
#

how to get OS

#

ive literally never used react

#

dunno how that shit works

#

ty

#

let's just ignore that

#

"MacIntel"

#

i guess m1 doesnt exist

jagged cloak
#

why the hell

#

misleading

#

lol

#

me when the non intel mac is MacIntel

charred monolithBOT
austere talon
#

not true i think

#

or maybe im thinking about smth else

charred monolithBOT
austere talon
#

YES THAT

charred monolithBOT
#

decrypted text:

Summoning pixels of power...
Spinning up the hamster wheels...
Loading awesomeness, please wait.
Reticulating splines...
Brewing a virtual potion...
Sending emojis to the server...
Warming up the servers like a boss!
Venturing into the digital abyss...
Loading... because waiting builds character!
Holding space and time together...
Putting on a disco for the bits and bytes...
Tickling the code into action...
Spreading digital stardust...
Loading like it's the...
austere talon
#

okay im stupid lmao

#

ico is pretty fire formart

stark flint
#

amazing

austere talon
#

i kind of wanna make a new release alr

#

because i broke tray last update

#

well ryan did technically πŸ’’ (but i didnt notice either so its both of our faults and if anything its just my code's fault)

charred monolithBOT
austere talon
#

Sir this is vencord dev

austere talon
#

anyway I fixed it sooopog

warm moon
#

alr then, i checked the v badge and is donation a little bit of money, but that gives the badge v? or if i donate good ammount it gives v, e, n, c, o, r, d badges?

jagged cloak
#

none of them

#

thats just ven being silly

warm moon
#

nice

jagged cloak
#

only a spoonful of badges

teal halo
#

ew badges

jagged cloak
#

discord bug hunter spotted

#

they are in your skin

teal halo
woeful sable
#

lumap hates badges

charred monolithBOT
charred monolithBOT
charred monolithBOT
austere talon
#

yus

#

not now im too tired but tmrw

charred monolithBOT
quaint sapphire
#

Back

jagged cloak
#

lol

quaint sapphire
#

well, didn't know impersonation was allowed here

jagged cloak
#

i mean server is usually chill

#

try it sometimes

#

@crude hearth fix timedones

#

delete reviewdb when

crude hearth
crude hearth
#

Ben doesnt want to merge

quaint sapphire
#

ah yes, ben

jagged cloak
cunning canyon
#

πŸ…±οΈencord

charred monolithBOT
jagged cloak
#

ive really got 14 pages of github comments

charred monolithBOT
charred monolithBOT
charred monolithBOT
quaint sapphire
#

ayy

#

huh?

#

github is confused

#

I starred, but it is not starred?

austere talon
#

technically you could the installer but it's really pointless

#

like why would you want an installer for an installer

teal halo
#

bro cant double click an app icon

#

that would make way more sense

charred monolithBOT
austere talon
#

oh yeah speaking of which someone wanted to put it into Windows repos

#

like scoop or smth I don't remember

#

but the threshold was 100 stars

#

which we now long have

charred monolithBOT
#

Discord Account

No response

What is it that you'd like to see?

Make it easier for people to add their own plugins from other people just by a github link or something. The current method for third party plugins is too hard for my pea brain to understand.

Request Agreement

  • [X] This is not a plugin request
stark flint
#

why

#

use damn quick css

teal halo
#

wtf you dont need plugins for that cta_wtf_shock

stark flint
#

people are so stupid

merry raven
#

counter point css is scary and strange and I don't know what I'm doing

stark flint
charred monolithBOT
charred monolithBOT
teal halo
#

use one at a time

charred monolithBOT
jagged cloak
#

i thought they had a star requirement or something

#

at least for the main repo or whatever they call it

#

ok well it doesnt matter (ignore highlighted part i was searching for something)

charred monolithBOT
charred monolithBOT
teal halo
#

just buy a phone

tidal cloud
#

but but I need to look cool and cringe infront of my egirls!!!!!

charred monolithBOT
fair crown
charred monolithBOT
grim jungle
charred monolithBOT
rugged arrow
#

I have an idea for a plug in

stark flint
#

and read it properly don’t post a duplicate

charred monolithBOT
#

Discord Account

Akitake_

What happens when the bug or crash occurs?

The "opened folder" sidebar doesn't close when emptied .

What is the expected behaviour?

I expect the sidebar to dissapear when a folder also does, much like it does when closing a folder.

How do you recreate this bug or crash?

  1. Group up servers in a folder
  2. Take servers out one by one (must have the sidebar open there obviously)
  3. When there is none left, the sidebar will remain opened yet empty...
weary cave
charred monolithBOT
#

Discord Account

𝕄𝕣. 𝕄𝕔𝕐𝕖𝕖π•₯#9300 (@"Kotlin Enthusiast" in Vencord discord)

What is it that you'd like to see?

I find that I don't care when people edit their messages, I mainly use the message logger plugin to keep track of deleted messages. With that in mind, I find it quite annoying to have to right click -> remove message history for messages, as the circles I find myself in tend to edit their messages 3, 4, 5, even 6+ times in some cases, and it can become quit...

fleet depot
#

Tho changing the plugin to have that built in doesn't seem like a bad idea so people stop asking

austere talon
#

am i using a different windows?

stark flint
#

i think they mean the default icons

#

not when it’s inside the tray container

austere talon
#

this looks perfectly fine to me

charred monolithBOT
austere talon
#

vc doesnt stand out

stark flint
#

oh true the taskbar one is dumb

#

but probably here

#

9/10 it ends up in the container with other colored icons though idk what the issue is

charred monolithBOT
#
  • Gives you the option to search thru the members list and to add a scrollbar to it.
  • Also a configurable option to give you a - / + button to the left of the role name to minimize the role (i.e. to just show the role name and hide all of its members) (+ option to autominimize all roles potentially)
  • Maybe an option to always make yourself stand out (like rainbow color or something, probably a configurable css color/gradient/etc.)
  • Potentially an option to show a member in every single ...
austere talon
stark flint
#

lmao yea

teal halo
#

πŸ’€

stark flint
#

who even looks in there anyway

teal halo
#

every single third party app is colored cmon

stark flint
#

you look there for 3 seconds a day

#

if at all

charred monolithBOT
#

This isn't really a fix per se, more of a heads up to the end user. As more people have started to use Vesktop, people are confused on why Cloud Integrations doesn't work correctly (because the secret doesn't carry over, only their settings, which contains the Cloud Integrations enable state).

The alternative is to move it to IndexedDB, but it would require rewriting a bit of the code whilst I think the temporary bandaid is a good solution until we can get around to redoing it correctly.

charred monolithBOT
teal halo
#

πŸ”₯ useless plugins

#

could just use a discord bot for that πŸ’€

woeful sable
#

uwuifier

teal halo
#

uwufier will be missed

woeful sable
#

its funny because its not useless

charred monolithBOT
pulsar steppe
#

literally kyza

#

sorry

#

Literally Kyza.

teal halo
#

tf is oldcord

#

a theme?

woeful sable
#

prob

charred monolithBOT
teal halo
#

autocorrect go fuck yourself

pulsar steppe
#

not actually oldcord, its not blinding light theme with funny circuitry background

#

fake old person

#

smh

#

it didnt even have the circuitry back then actually

teal halo
#

the heck

charred monolithBOT
teal halo
#

what

#

actually what the fuck

charred monolithBOT
charred monolithBOT
charred monolithBOT
fleet depot
#

i'm starting to think im going about this entirely the wrong way

#

i wanted to make the settings section dynamic, basically "if vencord plugin has toolbox action, then add a toggle setting for it in settings"

#

that seemed simple enough right

#

i created a function that can take in a list of strings and create settings from that list

#

but as soon as i put in something where i make a list of all the toolbox action names... it fails

#

vencord just stops patching

charred monolithBOT
fleet depot
#

it's cuz it's js and not a react component

#

that's probably it

austere talon
#

I have no clue what that's supposed to mean sorry

fleet depot
#

i lied

austere talon
#

maybe show a code example

fleet depot
#

i don't actually know

#

uh

fleet depot
#

?

#

and this is what's causing vencord to not inject

const toolboxActionNames = Object.values(plugins)
    .filter(p => Vencord.Plugins.isPluginEnabled(p.name) && p.toolboxActions)
    .flatMap(plugin => Object.keys(plugin.toolboxActions!));
#

ig this is what you mean

austere talon
#

is that code on top level

fleet depot
#

i just don't love it cuz it's messy

austere talon
#

it can't be

#

see console error

#

for why it's not loading

fleet depot
#

ah

teal halo
fleet depot
#

seems like Vencord.Plugins.plugins is not real in my created function

#

but if moved to VencordPopout it becomes real

austere talon
#

if your code is top level then the Vencord global doesn't exist yet

fleet depot
#

essentially?

#

oke

austere talon
#

no

#

it's cause your code runs on top level

#

make it not run on top level

fleet depot
#

sorry, still confused. what exactly is making it run top level if not the fact it's not in a react component

#

or in other words, because it's outside of a react component, doesn't that mean it's top level?

#

you're using the term top level but not defining it

austere talon
#

top level means code that runs instantly

#
thisIsTopLevel()
export default definePlugin({
    name: thisIsAlsoTopLevel(),
    start() {
       thisIsnt()
    }
})
#

oh wait actually your error is plugins being undefined

#

which is also caused by top level code

#

show your full code

fleet depot
#
function createPluginSettings() {
    const definedSettings = Object.values(Vencord.Plugins.plugins)
        .filter(p => Vencord.Plugins.isPluginEnabled(p.name) && p.toolboxActions)
        .flatMap(plugin => Object.keys(plugin.toolboxActions!))
        .map(v => ({ [v]: settingsBool(v) }))
        .reduce((k, t) => ({ ...k, ...t }), {});

    return definedSettings;
}

const settings = definePluginSettings({
    ...createPluginSettings(),
}).withPrivateSettings<{
    pinnedPlugins: string[];
    sidebarVisible: boolean;
}>();
#

full code

#

terror

#

there are probably a whole ton of better ways to do this, but i wanted something working first before i tried making it better

#

it's filtering, mapping, and reducing which seems like too much

#

but essentially it's just grabbing every plugin that's enabled and has a toolbox action, finding the action's name, and making a settings toggle for that plugin

austere talon
#

yes so top level code

#

you can't have code like this

#

that's a bad way of doing it anyway

fleet depot
#

i don't mean to write it badly

#

i'm just trying to execute an idea

austere talon
#

you make the code run on top level

#

it tries to use the global on top level which is not supported

#

either make the settings property on your plugin a getter so it's lazy or better yet don't use settings like this

#

you can use a component setting to render your own ui

#

or don't use settings at all

fleet depot
#

the other way i was considering hiding toolbox actions was jank css...

fleet depot
fleet depot
#

there aren't that many yet

#

but if there's like 5... 8... it feels like something someone shoud be able to hide

#

i could... make another checkbox

#

have dueling checkboxes

#

k

charred monolithBOT
torpid summit
upbeat spindle
#

ooh, am i qualified to get that role?

charred monolithBOT
upbeat spindle
#

i mean. i'm short but still, just to be sure.

oak hull
#

idk
ask politely maybe

#

i dont have it either

olive aurora
#

nop

upbeat spindle
#

is it required to be a girl?

oak hull
#

no...

upbeat spindle
#

I didn't see cute boy role

oak hull
#

this role

upbeat spindle
#

oh,. universal usage.

jagged cloak
#

it was locked cause crap quality snippets

charred monolithBOT
#
  • Made changes to UpdaterBody creating jsx components and removing custom close from modal
  • changed the custom switch to default boolean function
  • created a singular for loop to sort all the plugins to their correct display list
  • now plugin actions can be added and removed using a checkbox system instead of settings

There are three types of toolbox items:
Plugin Custom Actions (toolbox actions custom set by plugins)
Plugin Settings (pinning plugin settings for easy access)
App To...

fleet depot
#

hm iunno how to tell github i made those changes

#

that probably counts

#

im thinking i can make the two checkbox drop downs the same code

#

halve it ideally

charred monolithBOT
charred monolithBOT
jagged cloak
#

i guess this is a stupid question i've probably asked before
but how come discord's naming is off in places SKULL_SKELETON
example: stickerItems in view raw but sticker_items inside dispatched (message_create) obj

#

genuinely confused

#

also causing type errors, simply using sticker_items and ts-ignoring seems to be working fine, meanwhile the "real" stickerItems gives me jack shit despite the message containing sticker items

#

its not just stickers btw this was just a good example since it's what i last had this issue with

#

now that im reading this probably types fail but eh

median rapids
#

you love snake case in api and camel case in client

tame escarp
#

prob because their backend is mostly snakecased languages (at least the parts they mention)

#

python, rust, elixir

charred monolithBOT
charred monolithBOT
#

Discord Account

Fr_g

What happens when the bug or crash occurs?

Server that have previewmode, don't get muted once you actually join the server.

What is the expected behaviour?

Those servers should also be muted.

How do you recreate this bug or crash?

  1. Join a server with previewmode enabled.

Errors

Replace this text with your crash-log.

Request Agreement

  • [X] I am using Discord Stable or tried on Stable and this bug happens there as well
sacred rune
#

who is the dev of vencord?

oak hull
#

vee

rare shale
charred monolithBOT
cunning canyon
# charred monolith

@sterile lagoon wtf are you doing 😭 , git clone to your computer and do it there, not on github

rare shale
merry raven
jagged cloak
hybrid crater
#

I'm have one dumb question is possible to make one click to delete all your messages from chats

austere talon
fleet depot
#

(in other words, deleting all your messages from chats would be self botting)

hybrid crater
#

Basically i got interesting about it

charred monolithBOT
median rapids
charred monolithBOT
acoustic dune
#

Ayo probably not the right place for this but a note, the nickname remover feature of this is nice for accessibility ❀️ I struggle remembering people who I've never met because I associate people with their faces, so online I often only have profile picture and name to associate someones person with - so when someone changes their pfp and nickname, it takes time to re-associate that person with their nickname, and as a result its hard to remember who's who - so seeing everyone's usernames first and nicknames second is really helpful for me
So I just wanna say thanks to y'all who put your time into developing Vencord ❀️ It's really helpful for a lot of people for many different reasons

#

Also a thing I wanted to ask about, the plugins, are they stored anywhere in a repository or something? There's like no way to find any more information about the plugins than the vague at-most-five-words that are written in their descriptions

austere talon
#

documenting plugins better has been a thing i've been meaning to work on

#

but tons of effort

acoustic dune
#

Aa thanks

#

Could the documentating of them be done by the creators?

#

I tried BetterDisc before this (laggy af and not as cute btw) and there each plugin had a link to its source code repository, and people had themselves written pretty detailed descriptions in there

#

So I think people are willing to if it's easy enough

austere talon
acoustic dune
#

Ohh yes that looks perfect

#

I was just about to say that it looks like the way you can document your plugins is extremely limited rn if it's just these two fields

austere talon
#

yes thats true

tawny cipher
#

well the thing is people just don't use that field properly anyway

acoustic dune
#

Gotta think about the UX for the developer too, if there's just a single string field to describe your plugin, you're not encouraged to write a lot of details

charred monolithBOT
tawny cipher
#

it's always the most vague desc you can think of

acoustic dune
#

Yeah the field doesn't make it clear how you're supposed to use it

tawny cipher
#

most plugins are just try and see if you find out how it works

verbal pumice
acoustic dune
tawny cipher
#

yeah I don't see a decent way to do it either

#

except a convoluted usage popup

acoustic dune
#

Meanwhile with BetterDisc people are forced to use github repos for it, and there its the most natural thing to add a readme.md file, which makes it much easier and intuitive to write more details

acoustic dune
#

Use a markdown description file

#

Like, does description support newlines?

tawny cipher
#

looks like it just wraps automatically

acoustic dune
#

Then it's kinda impossible to write good descriptions

#

Imo not the plugin devs fault, it needs to be intuitive for them too

tawny cipher
#

ven is smort, including a readme is gud so it'll be better at some point

charred monolithBOT
teal halo
acoustic dune
#

Yaa its a great solution

charred monolithBOT
acoustic dune
#

Honestly perfect solution, md is so universal

teal halo
#

and tbh who cares about merge conflicts for PRs

#

if u rly wanna put ur plugin into main, a little structuration rework wont hurt anyone

acoustic dune
#

Yah exactly

#

Also btw,
a repository for third party plugins would be great for encouraging devs to make their own
I wouldn't've known vencord had third party plugin support unless I joined this discord to ask a question

oak hull
#

you need a role to post

acoustic dune
#

The easiest way to encourage plugin development imo, with minimal changes, would be to have a separate Repo for plugins
It's just like now, except it's discoverable by devs - because the first place a dev will look for how to contribute plugins is the GitHub repository, they will see that it's an option when they see the separate repository for it, instead of having to join the discord

#

It also makes it easy for open source nerds like me to see that the plugins source codes are also open, which wasn't intuitive to me at first

oak hull
#

understandable

charred monolithBOT
austere talon
#

that's not how vencord functions

acoustic dune
#

How so?

austere talon
#

it's centralised, plugins are inbuilt

acoustic dune
#

Yeah I've seen that

tawny cipher
#

there's no third party plugins as you conventionally think of

acoustic dune
#

Ik, you gotta like add them to source

#

But it seems like that's still kinda the point of vencord though

austere talon
#

btw adrian did u figure out why snippet importer isnt working for others

#

or do i need to investigate

acoustic dune
#

Except plugins are very seriously vetted before being added to the code

#

Because without plugins what does vencord do

austere talon
#

plugins are all inbuilt

acoustic dune
#

Yeah but they're made by the community are they not

austere talon
#

yes they are

acoustic dune
#

Yeah so their development and sharing should be encouraged

austere talon
#

it is

acoustic dune
#

Right now you can only see that plugins can be made by joining the discord, is my point

austere talon
teal halo
#

any reason why QuickCSS has lower priority than themes? e.g. if you edit a theme-specific variable in quickcss the theme will override it anyway

tawny cipher
austere talon
#

feel free to pr a fix

tawny cipher
#

but I couldn't tell you why

acoustic dune
austere talon
#

i dont think thats true

acoustic dune
teal halo
acoustic dune
#

Where's that button?

tawny cipher
#

vencord settings

acoustic dune
#

Oh there

#

I came here asking for where the plugins were located though, to highlight my point

#

They're under src

tawny cipher
#

where else would they be

acoustic dune
#

When open source projects have plugin support they usually have a separate repo for them or something along those lines

#

Or it's written somewhere that you can contribute, such as the plugins page

austere talon
acoustic dune
#

Making people open a PR directly to the main central repository for plugins seems a bit unusual

tawny cipher
#

dunno, seems straightforward enough for me

charred monolithBOT
tawny cipher
#

don't think anyone's been complaining

austere talon
acoustic dune
acoustic dune
#

In my experience

tawny cipher
#

have a look at discord.js

austere talon
#

there are almost only advantages to having them in the same repo

#

to a point where i almost wish vencord and vesktop were in the same repo

acoustic dune
austere talon
#

plugins very often also modify vencord itself

#

that wouldn't be possible if they weren't in the same repo

tawny cipher
#

okay whatever you say mate

acoustic dune
#

The separate plugin repo doesn't need to be completely separate though, it could just be the current plugins folder as a git submodule or something

#

Which would do that

tawny cipher
#

I don't see any reason for that

acoustic dune
#

As I said, discoverability for developers

#

To make it clear to devs that use vencord that hey, you can make plugins

tawny cipher
#

ask around I don't think anyone had any issues there

acoustic dune
#

Because plugins is the core of vencord

#

Yeah because the people here have already discovered it

#

I'm talking about the large amount of people who presumably don't

tawny cipher
austere talon
#

with all due respect i think someone who can't find the plugins folder likely also can't make plugins

teal halo
#

bad wording mb

#

english sucks

acoustic dune
#

Yeah but it's not clear where unless you join the discord

#

And the contributor guide doesn't mention it either

acoustic dune
#

But devs still need UX

#

What I'm saying is that currently there are plugin devs, but there could be more, if it was made clear where plugin development happens

worn rivet
acoustic dune
#

As I saaid, it doesn't tell you where

teal halo
tawny cipher
teal halo
#

i did require a bit of help when i first wanted to do things with vencord (mostly which pnpm commands i should use and when), but that's about it

acoustic dune
#

Not to be a NERD but survivorship bias or whatever it's called
I might be the only one you've heard talking about this, but that doesn't mean I'm the only one who's had the problem, I could just be the only one who bothered coming here and saying so

teal halo
#

everything else after that, you can figure out

teal halo
#

favorite gifs:

#

convert every "media" you wanna favorite to a GIF

#

ez

acoustic dune
#

Yeah you can figure it out, but you're not encouraged to - I think more people would contribute to plugins if they were encouraged to do so in some way

#

And since vencord is driven by plugins, that'd be a good thing

tawny cipher
#

I feel like if skids would open pr's those would mostly be rejected anyway, so I mean if as you say it requires a bit of neuron usage to figure it out, I actually think that's a good thing in terms of the quality

olive aurora
#

so true

#

mandated brain check

acoustic dune
#

Possibly, but like again, I'm a full time dev, and I came here asking for where I could contribute

#

But yeah it's a filtering mechanism

#

True

tawny cipher
#

full time anything doesn't always equal competent anything to be fair

teal halo
#

just do this

tawny cipher
#

you could probably print it in braille and still find it rather quickly

austere talon
#

making it super easy to find is, just like writing extensive documentation, a wasted effort

#

if people can't even find the plugins folder how will they find the correct function in Discord's minified code with 0 documentation

acoustic dune
#

If you bother doing that congrats
I look at a lot of open source projects, and I don't have time to scourge their folders to figure out where like, a plugin directory is, if I feel like figuring out if I want to contribute
Sometimes it's obvious, like /src/plugins, but other times you can look through folders for minutes without finding anything
So when I expect a project to want contributions, it's normal to expect it to write how
And the point is its so fucking easy to just write anywhere that you can contribute plugins in /src/plugins

tawny cipher
acoustic dune
# teal halo

Oh the horror, adding an extra line of text to make plugin contribution discoverable

acoustic dune
austere talon
#

anyway

#

113 people have found it so far

#

that's plenty

#

:P

acoustic dune
#

True if you're happy with that

tawny cipher
#

114 if my pr starts working kyujinkek

acoustic dune
#

What I'm talking about is if you want to get as many devs as possible

#

That requires some ux

austere talon
#

i dont

acoustic dune
#

Valid

austere talon
#

i want to get clever high quality long time contributors

#

not tons of pretty stupid one time contributors who abandon their plugins after i guide them through improving their code

acoustic dune
#

That's very valid and in that case you don't need to make it discoverable, because you have a decent contributor base already

teal halo
tawny cipher
limber skiff
#

If you can't find a plugin folder how are you gonna find how to patch the right stuff on discord

austere talon
#

good code

tawny cipher
#

thank you

acoustic dune
#

Dear lord no

tawny cipher
acoustic dune
#

Why does Github exist then

#

Or github desktop or gitkraken

austere talon
acoustic dune
#

They don't make anything possible that isnt doable through commandline

#

Yeah but it exists for devs ux

#

Anyways this is getting besides the point

olive aurora
#

gh desktop so bad

tawny cipher
#

true and real

teal halo
#

making the plugins folder accessible wont help if you cant code a plugin anyway (99% of people cant do that anyway)

olive aurora
#

use git cli like a normal person

tawny cipher
#

double true and double real

acoustic dune
#

It's really good honestly
And it prevents devs who didn't grow up with git cli, like anyone over the age of 30, from fucking up

tidal cloud
teal halo
#

git cli is based

acoustic dune
#

It's not

#

Because people who don't know it well use it wrong

austere talon
#

thats a skill issue kinda

teal halo
#

here's the middle ground then

austere talon
#

i exclusively use git cli

acoustic dune
#

With GitHub Desktop devs are encouraged to commit even singular lines of code

tawny cipher
#

wat

acoustic dune
#

Devs who use CLI in my experience commit irregularly and lots of things at the same time

olive aurora
#

I use lazygit sometimes when I need to do smth w part of a file

acoustic dune
#

Whereas with Github Desktop, because of the UX, it's so intuitive to commit just parts of a file or individual files at the time that thats what people end up doing more

#

Leading to a much better git repository

teal halo
#

UI* πŸ€“

acoustic dune
#

GitHub Desktop encourages the correct usage of Git, whereas Git CLI kids just feel cool using it and end up having terrible commit practices

tawny cipher
#

I do cli only except for some stuff in xcode and vsc depending on how I'm feeling

olive aurora
acoustic dune
#

Like a function

teal halo
#

bro is gonna do 960 commits for a 40 lines file

tawny cipher
acoustic dune
#

When you make a lot of changes to a file but only one function is relevant to the branch or even pushable, a CLI user wont bother commiting just the function

charred monolithBOT
acoustic dune
#

UX for devs matters

olive aurora
#

yknow you can also do that from ur ide

acoustic dune
#

Some IDE's can with the right extensions

oak hull
#

i dont know how to setup a github repo from any ide (except vsc and vs)
so i either

  1. dont attempt to make a repo
  2. upload files manually
teal halo
#

use vscode for built-in git management

#

use vim if ur a nerd