#👾-core-development

1 messages · Page 37 of 1

brave bolt
#

yeah

honest geyser
#

but who cares

#

just copy paste the content of the file

brave bolt
#

idk it doesnt work on my firefox and probably many other

#

its in faq

honest geyser
#

yeah idk why it works for me

brave bolt
#

odd that librewolf would have a more relaxed csp

honest geyser
#

csp is enabled in about:config

brave bolt
#

i did find a workaround by exporting and importing settings and pasting css in the json

#

scuff tho

honest geyser
#

oh I see

#

good idea

brave bolt
#

annoying to update tho

#

im using NotAnotherAnimeTheme

honest geyser
#

yeah

austere talon
#

no

#

thats the value in our astro config

#

we prerender that page so it has no way of knowing the actual url

#

it just uses the one in the astro config

honest geyser
#

I'm using some unrecognisable thing salvaged from some random places

#

pretty sure there is many conficts

turbid hatch
#

oh

#

i thought it was meant to be the actual url

#

nvm then!

charred monolithBOT
brave bolt
#

can someone put this on github lol

honest geyser
#

based

turbid hatch
#

its the best page

honest geyser
#

that thing is unknown lol

turbid hatch
#

also yeah this reads like an extended feature card

#

🥴

#

dont know what to do with it, might just scrap it like ven said

honest geyser
brave bolt
honest geyser
#

whoa

#

transition:300ms linear; does not work for some reason, what else can I use?

turbid hatch
#

there's some for me

limber skiff
#

holy fuck

#

51 files changed????

turbid hatch
#

i think its a 1-to-1 port of an existing plugin

#

yeah it is

spark cove
#

yea it uses class stuff

#

a lot of files that are just 1 declaration and then another file that reexports it

#

and a lot of the typings are way too exhaustive

#

i will pr the pr tomorrow methink

pallid lava
#

id love to see like a personal pins plugin in vencord

#

or well something that replicates discord's "message todos" experiment

#

because rn that doesnt work!!!

spark cove
#

do u have screenshots

#

im in my coding era

pallid lava
#

its like pins but only shows up for you

#

but it doesnt work so

#

bowomp

spark cove
#

god i hate that tab

#

if i open unreads

#

my client just DIES

pallid lava
#

but even if i open it im on web vencord so it doesnt instantly crash

honest geyser
#

why doesn't transition work in this css?

.vc-pronoundb-compact {
  height: 0;
  width: 0;
  overflow: hidden;
  transition: width 0.4s, height 0.4s, transform 0.4s;
}

[class*="compact"]:hover .vc-pronoundb-compact {
  height: auto;
  width: auto;
  overflow: visible;
}
#

ok it seems that you can't make a transitition unless you directly specify a value for the height and the width

#

so Its not possible to make a transition that way because the pronoun div don't have a fixed size

#

@austere talon

#

so width can't work and transform doesn't seem to be able to change the dom, do you have an alternative to both of these method?

charred monolithBOT
woeful sable
spark cove
#

real consideration i was gonna but then i started eating ice cream

woeful sable
#

ic crem

charred monolithBOT
carmine anvil
#

wait

honest geyser
#

?

#

I finnaly got it working by changing the widht and using transform!

#

@austere talon how does that css looks to you?

.vc-pronoundb-compact {
  height: 0;
  width: 0;
  overflow: hidden;
}

[class*="compact"]:hover .vc-pronoundb-compact {
  height: auto;
  width: auto;
  overflow: visible;
}

/* fixes flickering */
[class*="pointerCover-"]{
  display: none;
}

.vc-pronoundb-compact, .vc-pronoundb-cozy {
  transform: scaleX(0) translateX(-42px);
  opacity: 0;
  will-change: transform, opacity;
  transition: .4s ease;
  transform-origin: 0 50%;
}

[class*="compact"]:hover .vc-pronoundb-compact, [class*="cozy"]:hover .vc-pronoundb-cozy {
  transform: scaleX(1) translateX(0px);
  opacity: 1;
}
cunning canyon
#

you both red pfp

honest geyser
#

Oh I have pfps disabled

carmine anvil
#

oh lmao 💀

honest geyser
#

pfp comrades 🙂

carmine anvil
#

our pfp

woeful sable
#

@austere talon im on hyprland again

#

place ur bets in when it'll start breaking

honest geyser
woeful sable
#

wait this is vencord-dev

#

wtf

honest geyser
#

I’m done with everything and just need that bit of logic, can you give me a more detailed example please, I can’t find examples

charred monolithBOT
#

Discord Account

No response

What happens when the bug or crash occurs?

Using Vencord with OpenAsar Discord, with the CustomRPC plugin active.
You can see your own RPC status, but nobody else can.

What is the expected behaviour?

People should be able to see my activity just like how it is with everything else.

How do you recreate this bug or crash?

Enable Custom RPC, fill in the application and image fields, tell someone to see your RPC, and notice how nothing shows u...

honest geyser
charred monolithBOT
honest geyser
austere talon
#

why so much duplicated code

#

just to change one class

#

you can use classNameFactory

honest geyser
honest geyser
#

how do I do that?

#

oh I see

#

ok

#

I can try that

honest geyser
austere talon
#

jsdoc

honest geyser
# austere talon jsdoc

what should I run jsdoc on?
It returns an error with jsdoc dist/browser.js and jsdoc dist/Vencord.user.js

#

I understand that className={classes(styles.timestampInline, styles.timestamp, cl("cozy"))} would evaluate as vc-pronoundb-cozy (with const cl = classNameFactory("vc-pronoundb-");) but how can I make it conditional for the cozy-hover?

honest geyser
#

what does jsdoc means?

austere talon
honest geyser
#

oh ok

#

well I even installed it

austere talon
honest geyser
#

but I thought it was a documentation generator

austere talon
#

it's the documentation comments above functions

#

almost every function in vencord will have it and you can read it by just hovering the function

honest geyser
#

ok I found how to do it

#

gimme 5min and I'll update my PR

honest geyser
#

I'm done! can I add myself to src/utils/constants.ts?

charred monolithBOT
charred monolithBOT
#

Discord Account

BOSS05#3366

What happens when the bug or crash occurs?

When I type, the indicator should be viewable on other accounts, as the plugin is disabled, however, it is not - people cannot see me type while I use Vencord.

What is the expected behaviour?

The typing indicator should appear when I type, especially if the plugin is turned off or outright disabled, however this does not happen.

How do you recreate this bug or crash?

  1. Turn on the silent typing indi...
charred monolithBOT
#

What should the plugin/feature do?
Let a user reorder the buttons (including ones from plugins) in the message popover, as well as letting them put said buttons in the overflow menu that only shows while holding Shift.

How does it work?

  1. User opens the settings for the plugin
  2. Buttons currently available are retrieved
  3. User is presented with all available buttons, and would be able to reorder them all together by dragging them, even if they wouldn't all be included on ...
charred monolithBOT
#

As some of you might have heard, discord updated to a twemoji fork by jdecked that replaced the :face_holding_back_tears: emoji, and the :pleading_face: emoji.

These new ones are awful, and the OG ones are a million times better. There should be a plugin that lets users revert back to the regular twemoji and not this fork that discord forced on the new update.

Here's picture comparisons:
[https://images-ext-2.discordapp.net/external/ctTXwJ6U5fqHm3_Q7xEjMkix8fjvlwVeYfmc81Eh-nM/https/mos...

honest geyser
#

@austere talon thank you for the tourough review

#

do you sleep btw?

austere talon
#

nuh uh

smoky moat
#

can i repost the link to my idea here since it kinda went unnoticed (1 upvote excluding mine)

austere talon
#

no

honest geyser
#

srlsy ven, where do you live like what's your timezone?

austere talon
#

Germany

#

it's 16:35 rn

honest geyser
#

same

#

so you didn't sleep of the night

austere talon
#

I did

honest geyser
#

great

#

I didn't

austere talon
#

F

austere talon
#

@turbid hatch you tend to make selectors too specific

#

remember this is astro, styles are always scoped only to the current file

charred monolithBOT
charred monolithBOT
austere talon
turbid hatch
#

xd

#

ill reduce their specifics when im home

#

^^

turbid hatch
#

idk why i didnt think about that

austere talon
#

but once u get used to it it's awesome

#

me using section instead of div just so I don't need to use a classname sorrykirino

charred monolithBOT
austere talon
#

do u think discords code is in grep.app

honest geyser
#

not but themes are in grep.app

#

and no theme use it

#

in fact no one use it

honest geyser
grave mangoBOT
austere talon
#

lol

honest geyser
#

how did you find that?

#

like where

austere talon
#

discords css file

honest geyser
#

oh ok

#

where can I get this file?

honest geyser
#

thx

honest geyser
charred monolithBOT
austere talon
#

i was just giving a suggestion, not saying u must use this exact class :P

honest geyser
#

I prefer it for the consistency

#

Well in the end It's always your decision that matter

#

It's your project

#

I have an issue:
I cant do

className={classes(styles.timestampInline, styles.timestamp, cl("cozy", { cozy-hoveronly: Settings.plugins.PronounDB.showOnHover }))}

how can I use a "-" for the cozy-hoveronly?

austere talon
#

by quoting the key

honest geyser
#

Ok I fixed the names
Now I'll try to merge the css

charred monolithBOT
winged sparrow
#

is there not a channel where we can request features?

honest geyser
#

you can requests features on the github

winged sparrow
#

owki

honest geyser
#

@austere talon do you prefer that css?

/* Handles compact mode */
.vc-pronoundb-compact {
    display: none;
}

[class*="compact"] .vc-pronoundb-compact {
    display: inline-block;
    margin-left: -2px;
    margin-right: 0.25rem;
}


/* Handles the showOnHover option */
.vc-pronoundb-compact-hoveronly,
.vc-pronoundb-cozy-hoveronly {
    transform: scaleX(0) translateX(-42px);
    opacity: 0;
    height: 0;
    width: 0;
    overflow: hidden;
    transition: 0.4s ease;
    transform-origin: 0 50%;
    will-change: transform, opacity, height, width;
}

[class*="compact"]:hover .vc-pronoundb-compact-hoveronly,
[class*="cozy"]:hover .vc-pronoundb-cozy-hoveronly {
    transform: scaleX(1) translateX(0);
    opacity: 1;
    height: auto;
    width: auto;
    overflow: visible;
}


/* fixes flickering */
[class*="pointerCover-"] {
    display: none;
}
austere talon
#

i think transitioning height and width is likely weird

#

but I'll have to see it for myself

charred monolithBOT
honest geyser
charred monolithBOT
winged sparrow
#

thats sick alright ty

charred monolithBOT
spark cove
#
a
honest geyser
#

?

spark cove
#

wrong channel

turbid hatch
#

i think i do specific stuff on my site too when it's unneeded

#

so i need to fix that too xd

austere talon
#

(obviously only where it makes sense)

#

section makes sense to use

austere talon
#

what's that for?

#

@spark cove

spark cove
austere talon
#

but what does that solve

spark cove
#

oh so that it knows how to interpret like ["(a)", "g"] as /(a)/g

#

in the settings

#

i didnt wanna do it in the proxy but i did see that u added a cache

austere talon
#

the cache is just to avoid allocations

#

otherwise if you do like predicate: () => Settings.plugins.MyPlugin.foo it creates and destroys 3 proxies for each module

spark cove
#

ahh i see

#

not related

austere talon
#

Settings. Create proxy
plugins. Create proxy, delete previous proxy
MyPlugin. Create proxy, delete previous proxy
foo Delete previous proxy

spark cove
#

almost there

#

nice

austere talon
#

there

spark cove
#

NO

#

ur font is bugged

austere talon
#

it looks aligned for me

#

Ur so mad

spark cove
#

im so mad

#

😡

austere talon
#

yop

spark cove
#

anyways yea thats why i did that

austere talon
spark cove
#

any thoughts

austere talon
#

I think (but haven't really tested lol) caching it like this is better

spark cove
turbid hatch
#

oh @austere talon

#

i remember what .faq-content was for

#

it was for this

#

to do the dual tone

charred monolithBOT
winged sparrow
#

can someone explain this plugin to me?

winged sparrow
#

i still dont get it?

spark cove
winged sparrow
#

OOOOOOOOOOOHHHHHH i see it now, basically it adds a reply option on the dropdown

#

oki ty

spark cove
#

ye

#

np

charred monolithBOT
verbal pumice
#

was the settings rework merged

#

cause it cant write settings on web correctly anymore

#

wait that has nothing to do with it cause im on an older commit

charred monolithBOT
austere talon
verbal pumice
#

trying some stuff then i'll send actual info

charred monolithBOT
#

Discord Account

No response

What is it that you'd like to see?

When sending a file with AnonymiseFileNames enabled, I think it would be nice to have a 'checkbox' like "Spoiler Attachment" available for when do not want to send a file with an anonymised name.
If I want to share a mp3 file to a friend, it's kinda annoying if the filename changes, because of the anonymised name it's hard to identity who the artist and what the song title is for example. Same with some documents...

verbal pumice
#

yeah localStorage is undefined when it loads settings, but instead of just not loading settings it completely bricks discord somehow

and also works fine after a hard refresh but not a normal one ???

charred monolithBOT
verbal pumice
#

i dont even know what im supposed to send to help

austere talon
#

the browser is loading our extension too late or kept state from the last discord session so localStorage is already deleted (discord deletes localStorage from the window)

#

nothing we can do to fix it

verbal pumice
#

fair enough

austere talon
#

but also that last error sounds bad

#

and unrelated to vencord

austere talon
#

based on the fact that a soft reload doesn't work but a hard one does I assume the browser does cache some state somehow

#

maybe there's a way we can force it to never keep stats

#

state

verbal pumice
#

i dont think its an issue of localStorage being deleted too quickly but of vencord reading it too late

#

but honestly idk

austere talon
#

aka before it loads discord

charred monolithBOT
honest geyser
austere talon
#

read the extended description

#

you might have an idea

#

multiple people had whitescreen issues

quick ibex
#

@austere talon fixed

signal rover
#

wa

#

What os of the people having freezing issues

quick ibex
#

TempleOS

signal rover
#

damn

#

well discord isnt holy so i assume thats why

honest geyser
#

Yeah a new patch alows to use discord in an holy way

#

You must destroy 10 windows computer to use it

austere talon
#

that person uses windows 10 it seems

signal rover
#

any custom theme?

#

the discord window at start is transparent until it launches fine

#

no matter the theme

austere talon
#

this is the theme they used

signal rover
#

are we sure disabling the setting fixes the issue?

austere talon
#

yes

#

see here

#

right above

signal rover
#

any console log?

austere talon
#

they had no way of accessing them, just impossible to open devtools

signal rover
#

I can access them if my discord gets stuck in a invisible freeze

#

so thats odd

#

Its very weird that this causes an issue because this is basically the same exact thing better discord does

#

I need someone to test changes Im going to make

#

since discord is running a really outdated electron

#

and we have to suffer with this

#

im going to backport the fix that was pushed into electron last year

charred monolithBOT
austere talon
#

they use 22 now

#

but if u wanna debug further u should probably talk to @untold rune directly

#

they're pretty smart and seem nice so they're probably willing to help

signal rover
#

yah very weird

#

because better discord does the same thing as what my code does

#

so its odd that vencord refuses to load

#

@untold rune are you also disabling window frame?

#

From what im reading this has a conflicting effect when using windows

austere talon
#

Discord is frameless by default on windows

#

because of their custom titlebar

#

@signal rover

signal rover
#

Oh yah

#

forgot

#

ive been on linux for too long

austere talon
#

but BD doesn't set frame to true

#

and it works for them

signal rover
#

thats so weird

#

I wonder whats causing it to just not work with vencord

austere talon
#

hold on let me see if i can repro it at all

#

i cannot

signal rover
#

So what exactly is the cause

#

hmmmmmm

austere talon
#

applied their theme and it still works

#

god i do not like this theme Lmao

#

but yeah it works fine

signal rover
#

🤢

austere talon
#

hmm

#

this is so strange

#

why does it only happen for them

signal rover
#

thats what im going to figure out

#

im going to see if i can launch the dev tools on boot

#

see if that helps with getting some sort of console log

austere talon
#

disabled hardware acceleration and it still works fine

#

openasar also doesn't cause it with any of its settings

signal rover
#

Lets just say a random cosmic bit flip caused it to get corrupted and call it a day

signal rover
#

very true

austere talon
#

well i tried on electron 22

#

it might be electron 13 exclusive

signal rover
#

how would someone still have electron 13 for discord on windows still

#

shouldn't it be updated

austere talon
#

electron 22 is still in A/B testing

#

not everyone got it

signal rover
#

Odd

austere talon
#

only canary has full e22 rollout

signal rover
#

So make it electron 22 only then

#

and hope that just blocks anyone from an older version from using the setting until they are updated

austere talon
#

Well this would require us to know it's electron 13 only

signal rover
#

Well the only person able to repo the issue is @untold rune

#

so @untold rune any way for you to install and test vencord with transparency on canary

#

or discord development

austere talon
#

LOL don't ping them so often 😭

#

let them get those victory royales in peace

charred monolithBOT
woeful sable
#

hello, is there any plug in that displays all common users between servers?!

charred monolithBOT
cunning canyon
#

BALLS

charred monolithBOT
frail skyBOT
#
Bad Patches

PronounDB (had no effect):
ID: 905464
Match: /[A-Za-z_$][\w$]*\.[A-Za-z_$][\w$]*\.useExperiment\({}\)\.showPronouns/

MessagePopoverAPI (had no effect):
ID: 76581
Match: /[A-Za-z_$][\w$]*&&![A-Za-z_$][\w$]*\?\(0,[A-Za-z_$][\w$]*\.jsxs?\)\(.{0,200}renderPopout:.{0,300}?([A-Za-z_$][\w$]*)\(.{3,20}\{key:"add-reaction".+?\}/

IgnoreActivities (had no effect):
ID: 881951
Match: /!([A-Za-z_$][\w$]*)\|\|(null==[A-Za-z_$][\w$]*\)return null;var [A-Za-z_$][\w$]*=([A-Za-z_$][\w$]*)\.overlay.+?children:)(\[.{0,70}overlayStatusText.+?\])(?=}\)}\(\))/

Bad Starts

None

Discord Errors

austere talon
#

wtf everything broke

cunning canyon
#

jumpscare blobcatfearful

limber skiff
#

message popover has to be the thing that breaks the most

#

maybe this still works?

austere talon
#

now vaius can also do faqs by tag

#

and we can use those tags in faq page search later on

#

i was also gonna push smth else but lewi would hate me

dusk umbra
#

hey guys

#

I'm looking forward to creating a plugin for vencord

#

could someone guide me a little bit on how to?

dusk umbra
cunning canyon
dusk umbra
austere talon
#

documentation isn't that good yet, you can look at existing plugins & read the limited docs we have for now though!!

#

better docs planned very soon

dusk umbra
#

also the readme just lists the already preinstalled plugins

dusk umbra
#

but could you tell me abt the plugins path? I kinda got the idea for making custom plugins but haven't found the path to them yet dx

cunning canyon
#

src/plugins

cunning canyon
dusk umbra
dusk umbra
cunning canyon
#

nope you need to clone the source in order to make plugin

austere talon
#

you need to follow docs/installing to install from source

dusk umbra
#

uh

#

yea ig these are the ones

#

i'll follow them up

#

ty

charred monolithBOT
astral vigil
#

the guide should get rid of this section now since it has nothing there

dusk umbra
#

is there any guide on how to create a plugin?

charred monolithBOT
austere talon
#

because the code changed a bit and i cant find what u match anymore

#

so not sure how to change it or maybe its obsolete now

#

i fixed the others tho

limber skiff
#

aight

charred monolithBOT
limber skiff
#

gonna fix it rn

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
woeful sable
cunning canyon
#

i cant

cunning bobcat
#

how do i read the users discord settings (specifically this one)

#

i could theoretically subscribe to USER_SETTINGS_PROTO_UPDATE or w/e but that seems like jank to me

charred monolithBOT
#

Discord Account

yun#7077

What happens when the bug or crash occurs?

If I'm using an application that has an activity that changes based on my usage such as league, it will not ignore it.
Example: I open league, the activity will be hidden as it should, then I go in a lobby and the activity is no longer hidden, same with going in champ select and going in-game.

What is the expected behaviour?

I expected it to be hidden all the way, not just when the client is open.

How ...

charred monolithBOT
fossil otter
#

I can't seem to get the app to shake with this: ```js
Vencord.Webpack.find((m) => m.emitter?._events?.SHAKE_APP).dispatch("SHAKE_APP", {
duration: 300,
intensity: 2,
});

Plan was to add this to the 🗿 plugin as a togglable setting but it doesn't shake the app when I run it
charred monolithBOT
jagged cloak
#

that should work idk what happened

#

or you find it by code trolley

fossil otter
fossil otter
jagged cloak
#

odd

charred monolithBOT
charred monolithBOT
austere talon
#

okay its behaving weirdly

#

now i cant reproduce it anymore grr

#

did u have this issue at all? @pure ledge

#

the one guild somehow wasnt loaded yet

pure ledge
#

tf

#

how does that happen

austere talon
#

dunno

pure ledge
#

might have to change it to fetch guilds from the api? idk

austere talon
#

well

#

the guild was there after i checked the second time

pure ledge
#

yea that hasn't happened to me which is really weird

#

im hoping it's a one off

austere talon
#

i think this might just fix

pure ledge
#

oh yeah that could work

austere talon
#

start still runs relatively early ig

charred monolithBOT
austere talon
#

might not have loaded all guilds yet

#

i wanna add Vencord notification log

#

but idk where would be a good place to add it

#

and should log persist permamently (with a limit perhaps) or delete after restart?

pure ledge
austere talon
pure ledge
#

you could add it as an inbox tab

austere talon
#

very rough prototype

#

i think like that could work

pure ledge
#

yeah that fits

honest geyser
austere talon
#

maybe

#

0.4 is very long btw

honest geyser
#

tell me what you preffer

austere talon
#

i usually use 0.2s

#

you should keep transitions short or it will feel laggy

#

im probably biased on this considering i set my animation duration scale to 0.25x on anndroid

#

so i have super fast animations

#

i personally think shorter animations make the entire ui feel snappier and faster

honest geyser
#

well I personnally think no animations make the entire ui feel snappier and faster

#

do I

-  will-change: transform, opacity, height, width;
+  will-change: transform, opacity;
```?
austere talon
#

no

#

you

-  will-change: transform, opacity, height, width;
austere talon
#

i opened this tab and switched between mentions and unread a few times

#

it was laggy asf

#

then my discord crashed

#

i forgor

#

discord amazing at coding

pure ledge
#

stable platform fr

honest geyser
#

and do I

-     transition-property: transform, opacity, height, width;
+     transition-property: transform, opacity;

?

austere talon
#

you should transition every property that changes

honest geyser
#

you will now merge my PR

#

🪄

charred monolithBOT
umbral hedge
#

brick web

charred monolithBOT
austere talon
#

feature is ready now

#

@pure ledge could you perhaps test it and see if it you're satisfied with it?

#

no convenient button for now, coming in the future

austere talon
#

I actually haven't tested whether the limit logic works

#

maybe I should

pure ledge
#

looks good so far but clearing notifications when you have more than 3 or 4 is a little bit choppy

#

and i think it moves you to the top of the notification list if you clear one while scrolled down

pure ledge
#

uhh not exactly

#

like its not smooth

austere talon
#

because it rerenders the entire list

pure ledge
#

ah

austere talon
#

I could maybe not actually remove the component

#

and instead set its height to 0

#

but idk

pure ledge
#

would that keep the notification log menu at the same size

austere talon
#

this is just react being terrible tbf

charred monolithBOT
signal rover
#

@austere talon how do i use unsafe settings

#

considering the transparency thing is now "unsafe"

austere talon
#

i temporarily added it back with that key until we find a robust solution and can add it back properly

#

you can enable it with the console

#

Vencord.Settings.whatever = "hi"

#

or by editing the json file

signal rover
#

Its set to true but doing nothing for me

austere talon
#

fully restart

signal rover
#

i did

#

It was working before I updated

#

i even manually pulled and built the latest version

#

ima just enable it in my local repo

#

oh

#

thats why

#

the settings is now called "transparentUNSAFE_USE_AT_OWN_RISK"

austere talon
#

yes lol

austere talon
#

react sucks

#

wait

#

i got it

#

the issue was this use of pending

#

essentially when a change was made, it refetched notifications so pending was true for a slight moment

#

which causes it to very shortly render only one line which scrolls you up to the top again then renders again

#

simply removing the pending logic fixed the flickering and scrolling

charred monolithBOT
austere talon
#

could you try again now? @pure ledge

austere talon
#

why did you add that

#

it causes issues like this

#

sure the data is pending but there's still data from before refetch

#

so it's not really pending

spark cove
#

oh it just seemed natural but that makes sense

austere talon
spark cove
#

theres two choices and it makes sense people would assume that way

austere talon
#

thats not what i meant

spark cove
austere talon
#

just asking if there's any specific reason you did it

spark cove
#

xdxd

#

no real reason just that theres two choices

#

and one has more info than the other

#

so i probably naturally picked the more info one

#

and didnt think of that case cus u can always !data && pending (if the usage was intuitive (which it clearly isnt from the bug))

austere talon
spark cove
#

true 'why did u add that' as a statement is a funny

#

giving people good interpretations by default 🔥🔥🔥🔥

pure ledge
#

i need another way to get a lot of notifs without spam adding and removing myself from a group

austere talon
#

uh

#
var fakeNotifs = Array.from({ length: 50 }, (_, i) => ({ body: "Example notif" + i, title: "dummy" + i, timestamp: Date.now() - i * 10_000 }))
Vencord.Api.DataStore.set("notification-log", fakeNotifs)
#

LOL

spark cove
#

@pure ledge

#

@pure ledge

#

@pure ledge

#

@pure ledge

#

@pure ledge

#

easy

austere talon
#

nuh uh

#

this is for vencord notifs

pure ledge
pure ledge
#

ok yeah

#

much better

#

everything else seems great

austere talon
#

as for the easily accessible button, I had the idea to add a Vencord button here that would house quickactions for all plugin

jagged cloak
#

nuh uh you dont have a vencord icon

austere talon
woeful sable
austere talon
#

why is it not 100% width???

#

oh

#

wait im confused

#

so

#

its a block element

#

due to display flex, no?

#

ohhh

#

cause its a button

#

which is inline-block

#

IM GOING INSANE

#

ohhh

#

cause of the still existent gap i think

spark cove
#

lolol

austere talon
#

god im going so insane

#

the code is so deranmged

spark cove
#

what does that animation looke like when its just 1

austere talon
#

cause some idiot decided you cant transition height: auto

#

nah i know what the issue is i think

spark cove
#

real

austere talon
#

ye

#

its the gap

#

i finally did it

#

this was so unnecessarily complicated because css is dumb

charred monolithBOT
austere talon
#

@limber skiff

spark cove
austere talon
#

you made clicking notifications always dismiss

#

can we change it to only dismiss if there is an onclick

#

or mm

#

maybe we can add a prop for it

#

dismissOnClick

charred monolithBOT
austere talon
#
const ref = React.useRef<HTMLDivElement>(null);

useEffect(() => {
    const div = ref.current!;

    const setHeight = () => {
        if (div.clientHeight === 0) return requestAnimationFrame(setHeight);
        div.style.height = `${div.clientHeight}px`;
    };

    setHeight();
}, []);
#

i feel like there has to be a better way to do this

#

essentially, the notifications have dynamic height based on their content, so I can't explicitly set height. But it's not possible to transition auto properties so you HAVE TO set a fixed width. So that code just waits for the element to get layouted and then explicitly sets the height to its clientHeight (aka automatically computed height)

turbid hatch
#

couldnt you use an observer

#

rather than checking every frame

austere talon
#

it should only take 2 frames

#

i also noticed an error in the code

#

since we use Date.now() as key

#

if you send two notifications at the same time

#

explode

turbid hatch
#

Date.now() + Math.random()

austere talon
#

need to find smth else as key

turbid hatch
#

same tick moment

austere talon
#

actually wait

#

we await a promise in showNotification

#

so it might be a non issue

turbid hatch
#

probs

turbid hatch
#

even if only a little

austere talon
#

oh

#

i have a race conditon anyway

#

:3

#

i just noticed due to testing

turbid hatch
#

hm?

austere talon
#

we do a little

#

basically

#
function persist() {
  const logs = getLogs()
  logs.push()
  saveLogs(logs)
}
#

race condition

turbid hatch
#

oops

austere talon
#

oh

#

the library we use has an atomic update method

#

should i just use discords uid lib

limber skiff
charred monolithBOT
austere talon
#

okay ready finally

austere talon
#

just not in the notification log xD

charred monolithBOT
frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

woeful sable
#

Whar

charred monolithBOT
austere talon
charred monolithBOT
austere talon
limber skiff
#

well cuz it's another game then

#

the lobby and league client

charred monolithBOT
austere talon
#

key is a react feature to uniquely identify elements in an array

#

so it can optimise rerenders

#

key should something that is unique for the current element

limber skiff
#

can I just do the emoji id then

#

ah

#

hmm

austere talon
#

no because that wouldn't be unique if the message contains multiple of the same emoji

charred monolithBOT
austere talon
charred monolithBOT
charred monolithBOT
charred monolithBOT
untold harbor
#

hi there im pretty new here, can i ask question about vencord here

cunning canyon
untold harbor
#

ah ok thanks

charred monolithBOT
woeful sable
#

Hi, since the new update transparency is not working anymore (I'm on Linux (Compositor works), Discord Stable). Any idea how I can fix that?

cunning canyon
dawn coyote
#

.eval Vencord.Settings.transparentUNSAFE_USE_AT_OWN_RISK = true
true

woeful sable
#

it is true. but still not transparent

cunning canyon
#

did you restart discord

woeful sable
#

yes

#

i did

cunning canyon
#

hmm then idk trolley

woeful sable
woeful sable
cunning canyon
woeful sable
#

its literally the only thing why i use a custom client.

grave mangoBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
austere talon
#

tharki moment

charred monolithBOT
charred monolithBOT
cold patio
#

Hi all, I just wanted to ask how long it usually takes for a plugin to be reviewed? I'm only asking because I really want to share it with my friends if it even gets accepted.

turbid hatch
#

varies

#

couple of weeks usually

verbal pumice
#

depends on the complexity and whether ven feels like reviewing your plugin

cold patio
#

Ah that's great to know. Thank you guys 🙂

austere talon
#

u made betterscreenshare right

cold patio
#

Yes

austere talon
#

That plugin is massive so probably might take a bit

#

but also I'm not sure whether it would even be well suited for an inbuilt plugin since it seems very niche

cold patio
#

What does niche mean exactly? Sorry if it's too big or something I really tried to make it as user friendly as possible.

austere talon
#

I don't think it's very useful to most people, most people don't even know what half of those toggles mean

austere talon
cold patio
#

Yeah that would be cool as well.

austere talon
#

i might work on that very soon

austere talon
quick ibex
#

honestly i really like the idea of using links for plugins

#

unfortunately it would be really insecure

cold patio
#

I think so too but if there's a disclaimer or something that clarifies the risks maybe it would be ok? And a switch for the automatic update function would also be good. But these are just thoughts I've never done anything big or anything like that so I have no idea. But another thing how about a simple and advanced mode for my plugin? The advanced mode would be the same as it is now and the simple mode would only contain resolution, framerate and video bitrate. And the video bitrate tab would have 3 options (low, medium and high). I know there is already a plugin that unlocks the Screenshare Nitro features but you usually don't have a good bitrate especially if someone is watching the stream with bad internet because discord then throttles the stream for everyone. And the FPS also plays a role for some because if you have a >120hz monitor it really makes a big difference if you set the FPS higher than 60.

quick ibex
#

@austere talon i typed out a whole response for nothing

#

😭

#
Discord sends you events that you have permission to view. You dont have permission to view events from a channel you have no rights to see even exists. Only reason you can see hidden channels is because, to save server resources, when the client asks for the server channel list, the discord servers sends the list without filtering. (Extremely simplified for brainless users, but is actually more complicated) 
charred monolithBOT
austere talon
#

oh my god how are you this stupid

heavy widget
#

Lmfao

#

💀

charred monolithBOT
austere talon
#

why are people like this 😭

austere talon
verbal pumice
#

this is what happeneds when you turn yourself into besterdiscord

fleet depot
#

If you build it they will come
If you look like better discord...

verbal pumice
#

you either die a hero or live long enough to see yourself become the villan

#

i mean-

#

this is way better than vencord!

cold patio
# austere talon I don't think it's very useful to most people, most people don't even know what ...

I wrote it before but I think you missed it. What do you think about me adding a simple mode to my plugin? Simple mode would only contain framerate, resolution, video bitrate and audio source. The Video Bitrate tab would also only show Low, Medium, and High options for simplicity. The advantage of custom video bitrate would be that it is consistent. Discord usually uses a very low bitrate depending on the people watching. If someone has a bad to medium connection it will automatically reduce the quality and result in Minecraft quality. You probably know what I mean, but that wouldn't happen with my plugin. And another thing would be the custom framerate. A lot of my friends are >120hz so it might make sense to stream at a higher framerate so I think other users would like it too. Would that make the plugin more user friendly and more likely to be added? And btw I know my plugin seems big because of the structure but it actually isn't that big because it just has many typings and license headers which isn't really actual code.

quick ibex
cold patio
#

If the normal audio source of discord works then yes. I didn't tested it because I use windows.

spark cove
#

aka no

#

voice engine soon™️

austere talon
spark cove
charred monolithBOT
austere talon
#

tias

spark cove
#

oh real

woeful sable
austere talon
#

you're in the wrong channel

woeful sable
#

what would be the right channel?

austere talon
#

support

#

but also why would you use transparency on Linux

#

use a compositor

woeful sable
#

thanks

#

it worked until the last vencord update.
and my compositor is working fine

quick ibex
#

Transparency got removed lol

woeful sable
#

really?
why?

fleet depot
#

was breaking some people's discords

austere talon
woeful sable
#

thanks. is there a way to get it back?

#

oke

#

i already tried setting that variable. have it in my settings.json too. even powered off and on again after that

austere talon
#

can't help u then

#

nothing changed other than the name of the flag

woeful sable
#

okay. thats intresting

austere talon
#

run Vencord.Settings.transparentUNSAFE_USE_AT_OWN_RISK in the console

#

wait

#

now

woeful sable
#

its true

#

just like without the UNSAFE_USE_AT_YOUR_OWN_RISK part

austere talon
#

then it should work

#

did you fully close discord

woeful sable
#

yes

austere talon
woeful sable
#

even rebooted because i got to a friend after trying

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
woeful sable
#

1984

frail skyBOT
#
Bad Patches

None

Bad Starts

None

Discord Errors

woeful sable
#

fix webhook icon @austere talon

austere talon
#

true

#

wait why is it broken lmao

heavy widget
#

how

woeful sable
#

sorry i ate it

austere talon
grave mangoBOT
austere talon
#

im dum

quick ibex
#

wtf why did you actually delete trolley

austere talon
#

wdym

quick ibex
#

no more trolley emoji

#

wtf

#

am i blind?

#

I am

#

bro

charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
#

Discord Account

xv#3500

What happens when the bug or crash occurs?

It happens since the latest 2 updates when updating.

What is the expected behaviour?

I expect vencord to update and build properly.

How do you recreate this bug or crash?

  1. Go to user settings
  2. Go to the Updater tab
  3. Click the "Update Now" button
  4. Observe

Errors

Failed to update Object
r. @ 05cd3353f9a3e49ee3bc.js:9288

![image](https://user-images.githubusercontent.com/66337...

charred monolithBOT
charred monolithBOT
quick ibex
#

@austere talon how is my first review? 🥺

charred monolithBOT
#

current errors:

go build --tags cli
# github.com/Vendicated/VencordInstaller
.\cli.go:29:5: invalid operation: *client && (*client != "default" || *client != "stable" || *client != "ptb" || *client != "canary") (mismatched types string and untyped bool)
.\cli.go:43:21: not enough arguments in call to PromptDiscord
        have (string)
        want (string, *DiscordInstall, string)
.\cli.go:45:21: not enough arguments in call to PromptDiscord
        have (string)
        want (...
verbal pumice
#

maybe the Devs.mantikafasi should suggest that

solemn spoke
#

does vencord update packages when they're added or not?

austere talon
#

no

#

you need to manually install new dependencies

solemn spoke
#

time to do an issue time

austere talon
#

why

woeful sable
#

just pnpm install