#๐พ-core-development
charred monolithBOT
crude hearth
FREEEE ???
charred monolithBOT
charred monolithBOT
charred monolithBOT
charred monolithBOT
quaint sapphire
This tyranny can no longer exist, I have uncovered all your secrets @austere talon
You prioritize the PRs of the people that play overwatch with you
You are corrupt
Therefore I elect myself as the new VEn
Yes, not Ven but VEn
The superior version
/s
charred monolithBOT
spark cove
True
charred monolithBOT
quick ibex
jagged cloak
yop
charred monolithBOT
limber skiff
you suck
charred monolithBOT
crude hearth
@agile gullJUMPSCARE
agile gull
explod
tidal cloud
joobi jumpscare
charred monolithBOT
charred monolithBOT
charred monolithBOT
golden gulch
I don't super feel like opening up github right now, but to the person who is in that discussion (you don't seem to have the same discord username): rather than add more platforms to the FxTwitter plugin, the fix that is generally wanted from the devs is to replace the plugin entirely with a generic text replace plugin (potentially with presets or something similar that can be used for those media platforms)
charred monolithBOT
golden gulch
I don't super feel like opening up github right now, but to the person who is in...
@novel walrus
charred monolithBOT
charred monolithBOT
from my knowledge there is no other fix embed then these 3. FxTwitter, ddInstagram, and vxTiktok are the only ones exist and will be the only ones for who knows how long. No point making one for facebook cause most people on discord dont use it, yt already has native embed, reddit embed is been fine for ages. I can't think of any other major social media that has web version th...
turbid hatch
I don't super feel like opening up github right now, but to the person who is in...
guess i know what im doing later
charred monolithBOT
This plugin adds/fixes experimental search filters. Some of these are already available in the mobile app TabsV2 redesign as a part of the gui.
- fileType - already implemented in the desktop app, but it doesn't work
- fileName - should be implemented soon
- embedType
- sortBy / sortOrder - same thing as the buttons below the search bar
charred monolithBOT
Tell us all about it.
discord crashes when clicking any of these:
Request Agreement
- [X] This is not a support or plugin request
spark cove
real
austere talon
how do you see this and go "yes I should totally use the blank template"
spark cove
also is there a git hash displayed somewhere in standalone builds
like logged or something
austere talon
but if someone has the attention span of a hamburger to where they only see the first one and use it then they don't deserve help tbh
spark cove
im gonna eat a hamburger tpoday
austere talon
also is there a git hash displayed somewhere in standalone builds
Version info
quick ibex
how do you see this and go "yes I should totally use the blank template"
There are templates????
austere talon
im gonna eat a hamburger tpoday
real
austere talon
yeah
glass cedar
how do you see this and go "yes I should totally use the blank template"
ikr ppl do the same with my discord bot
glass cedar
how do you see this and go "yes I should totally use the blank template"
iirc i removed blank template
so they cant
ye i made it like this
turbid hatch
how do you see this and go "yes I should totally use the blank template"
you dont need this
austere talon
?
turbid hatch
there's a dedicated option called blank_issues_enabled which shoves it at the very bottom
austere talon
I know but I want the blank issue to still have a custom description and template
turbid hatch
suffer ig
people dont even read the template, they just click it because its the first one and then click the checkbox because its required
if its the actual blank_issues_enabled then its a tiny link at the bottom iirc
also if you really really still want a template, you can just create an issue_template.md in the .github folder and itll be used for blank issues only @austere talon
spark cove
L
charred monolithBOT
This plugin adds Alerts (also known as "Highlights") when someone sends a keyword.
Preview:
As always, feel free to suggest any changes, or report any bugs that I missed.
If a maintainer makes a change on this PR, please ping me in the discord (@Captain#3175) so I don't make the same ...
cunning bobcat
after 7 years and 2 months this is finally here
charred monolithBOT
cunning bobcat
I really gotta stop doing that
cunning bobcat
LMAO
charred monolithBOT
charred monolithBOT
cunning bobcat
the uppercase is because of this class
cunning bobcat
furthermore you could probably integrate this into the inbox as additional tab next to mentions
update: i am slamming my face into my keyboard
charred monolithBOT
The aliucord counterpart does this better
quaint sapphire
If someone w/o the plugin sends a Twitter link, the plugin will do nothing
It only does stuff if I am the one sending it
Therefore kinda useless
It is useful for abbreviations as I said tho
Bc you might wanna type the abbreviation but send the expanded text
tawny cipher
might as well opt for a generalized plugin that embeds most common social media urls with custom components altogether
austere talon
no
turbid hatch
@quaint sapphire this is the generic text replacement plugin ven wanted
its not meant to be a "oh you only see it for yourself"
its meant to kill the plugins like fxtwitter that we have now
austere talon
I never said it couldn't also apply to others
optimally it would, and that behaviour would be configurable
turbid hatch
ye
frail skyBOT
umbral hedge
so true
frail skyBOT
rigid venture
there should be multiple ppl merging not just ven
ofc she's gonna get burned out and it becomes tedious to review
there are multiple smart people with enough knowledge about the structure and stuff other thsn ven by now i think
MROWR
umbral hedge
@austere talon we don't use Tooltip.Positions anywhere so it should be safe to merge
should I just go for it
settings works :p
and user reviews
i dont really know anything about menuapi so I'll let someone else fix that 
i will merge
umbral hedge
I leave menu api in your hands
charred monolithBOT
austere talon
@aubrey#6933
not here
why do people open issues/prs then not join the discord
makes it pain to communicate
charred monolithBOT
Here's a mockup of what it would look like with the Windows Classic theme.
austere talon
why do people want their system to look like this
i think i know what they mean now
why does Discord even do custom titleBar on windows
charred monolithBOT
frail skyBOT
quick ibex
frail skyBOT
somber ginkgo
for bad patches? or complaining about github shidd
i support the latter
(or yk, just use #๐งฉ-plugin-development 
)
austere talon
reporter
umbral hedge
what the dog doin
quaint sapphire
ofc she's gonna get burned out and it becomes tedious to review
She's?
Did ven have a custom pronoun?
Or did you fall for the trap?
I don't know if this is legit a personal preference or ven is trolling
Which scares me
Ven is unpredictable
quaint sapphire
ven is any pronoun
So no pronoun bc having every pronoun is the same as having no pronoun
I saw the rainbow flag on Ben's github, so ig it's not trolling
Man, in the past I could use the rainbow flag w/o it having a special meaning
I hate this
Why not have a diff flag?
(this is not about ven)
Like, I don't care about LGBT or whatever, they can do their thing
But do they have to steal the rainbow from me?
I didn't steal anything from them
It's unfair
quaint sapphire
But if I do, everyone will be sure that it is about LGBT (and Q?)
quaint sapphire
I want to live in a world where the rainbow is not linked with having a different sexuality than your birth one.
Nothing wrong with having a diff sexuality, but why the rainbow?
umbral hedge
people have rainbow flag to say they're an ally
it doesnt have to mean you are lgbt
also
if anyone asks you can just say "it looks nice"
who cares
quaint sapphire
I ain't an ally
I ain't supporting straight people, why should I support the rest?
umbral hedge
quaint sapphire
I myself am straight, but I don't think of it as anything special
Cause it aint
If you are gay that's ok, but leave my rainbow alone
Yes I made it personal
Fight me
I want my rainbow
Do we have a flag for being straight? I hope not
umbral hedge
why are u mad over a rainbow 
just use the rainbow and be smug that it just means rainbow to you
quaint sapphire
In the past I used to love pink, but everyone thought I was gay for wearing pink as a man
Like, why do people associate colors like that?
umbral hedge
???
quaint sapphire
Yes, real story
umbral hedge
the only time I've ever heard someone get called gay for wearing pink was in fucking school
modest venture
who knows and who cares
umbral hedge
who cares + who cares
modest venture
just wear pink
modest venture
just use a rainbow
umbral hedge
quaint sapphire
who knows and who cares
Me ๐ญ
quaint sapphire
But then I won't have smth to complain about
You mean to tell me that I can just be happy?
That sounds boring
modest venture
omg so true!
quiet cairn
Social media mindset
umbral hedge
You mean to tell me that I can just be happy?
be british and complain about the weather
quaint sapphire
I am Greek and I complain about global warming
It fucked our great weather
We had just the perfect amount of sun
But now it's either too cold or too hot
charred monolithBOT
austere talon
this is not the right channel for this lol
charred monolithBOT
austere talon
haha
i said they would ask for it in custom status
but message is another funny
i wonder if thats possible with only css
likely no
umbral hedge
closing PR as not planned
spark cove
DEATH
austere talon
TRUE
spark cove
hand sanatizer on the code
quaint sapphire
this is not the right channel for this lol
this is the best channel for this
crude hearth
@austere talon if you ever remember
there is a pull request called timezones exist
and its been 3-4 months since I opened
@placid wave aagaming do something
its gonna be half year
placid wave
quaint sapphire
Uhh
crude hearth
this means yes
quaint sapphire
Did the select component change to the one with the search?
crude hearth
nop
quaint sapphire
I'm not talking about the plugin
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/webpack/common/components.ts...
**components.ts: **Line 49
export const SearchableSelect = waitForComponent<t.SearchableSelect>("SearchableSelect", m =>
Change the select to use that
That is the first step
And then we should move the list to somewhere else so it is not bundled together with vencord
And dynamically load it when needed
Only after that will ven consider merging
limber skiff
grave mangoBOT
<@343383572805058560> https://github.com/Vendicated/Vencord/blob/main/src/webpac...
**webpack.ts: **Line 98
for (const nestedMod in mod.exports) if (nestedMod.length <= 3) {
why webpack search it
you can make the patch put the function directly on ur plugin object
limber skiff
that is true
I will do that instead
also how does handleComponentFailed even work, you only call checkForUpdates on startup, and when that component renders checkForUpdates isnt called so isOutdated will be false
@austere talon standalone versions can update right
austere talon
ye
austere talon
also how does handleComponentFailed even work, you only call checkForUpdates on ...
wdym?
limber skiff
this seems correct then
also since you know about armcord how do we perform a full restart?
austere talon
it indeed doesn't recheck, maybe it should
limber skiff
yeah I'm making it do that
austere talon
also since you know about armcord how do we perform a full restart?
look at window.armcord
it likely has an ipc method to do so
but why do u need a full restart with armcord?
limber skiff
hmhm
I was thinking of full restarting it to maybe update vencord
but that seems bad
austere talon
standalone doesn't have any special meaning
Well the updater ig
Web is still standalone but doesn't have any updater, isOutdated will always return false on Web
limber skiff
I'm just trying to understand what can update by itself
limber skiff
okay
austere talon
adding an explicit IS_WEB check is not needed since isOutdated returns false on Web, however it is still good to add it because it will reduce dead code
idk if u know C macros
but IS_WEB and other globals are compiler variables that dynamically include or exclude code
limber skiff
okay this seems right now
austere talon
similar to a C #ifdef
limber skiff
I'm so confused on where the code decides to use git or http to update
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/src/ipcMain/updater/index.ts#L19
**index.ts: **Line 19
import(IS_STANDALONE ? "./http" : "./git");
lol
austere talon
they're two implementations that implement the same identical methods in their own way
the rest of the code isn't aware which updater backend is used
quaint sapphire
could have used a class for more clarity
but thats not necessary
austere talon
nah
they just implement ipc methods https://github.com/Vendicated/Vencord/blob/main/src/ipcMain/updater/http.ts#L84-L88
grave mangoBOT
they just implement ipc methods https://github.com/Vendicated/Vencord/blob/main/...
**http.ts: **Lines 84-88
ipcMain.handle(IpcEvents.GET_HASHES, serializeErrors(calculateHashes));
ipcMain.handle(IpcEvents.GET_REPO, serializeErrors(() => `https://github.com/${gitRemote}`));
ipcMain.handle(IpcEvents.GET_UPDATES, serializeErrors(calculateGitChanges));
ipcMain.handle(IpcEvents.UPDATE, serializeErrors(fetchUpdates));
ipcMain.handle(IpcEvents.BUILD, serializeErrors(applyUpdates));
not what i meant but ok
austere talon
using a class for that doesn't make much sense
quaint sapphire
considering that you wont add more backends, yes it doesnt make sense
it is useless
austere talon
plain object implementing an interface sure but this is fine
Well it would be trivial for someone to add their own updater 
quaint sapphire
actually, the IPC is kinda like an interface
austere talon
yeah that's what I meant
quaint sapphire
it just feels wrong
Please note that the CSS Editor, Themes loaded from remote sources and co. will not work in the UserScript. Use the extension if you need any of those
@austere talon
the readme says that, but what is the reason?
CSP?
austere talon
yes
austere talon
yes but I can't be bothered to reimplement everything just for userscript
and css editor no
quaint sapphire
do you go the extra mile to disable stuff that dont work in the userscript? if not I can try polyfilling them
austere talon
no
I guess making themes work would actually not be that hard. Does GM_addStyle bypass csp?
split hornet
yes but I can't be bothered to reimplement everything just for userscript
ask chatgpt to do it for you 
quaint sapphire
I guess making themes work would actually not be that hard. Does GM_addStyle byp...
GM_addStyle has never worked for me in any scenario, so I don't know
but it wouldn't be hard to fetch the css and append a style sheet
austere talon
true
but does discords csp allow inline styles
if it doesn't we're screwed
I think it does
yeah it should
quaint sapphire
I've been using myself a polyfill for GM_addStyle cause it never works
https://github.com/ArjixWasTaken/my-userscripts/blob/main/steam-workshop-downloader.user.js#L30-L52
grave mangoBOT
I've been using myself a polyfill for GM_addStyle cause it never works
https://g...
**steam-workshop-downloader.user.js: **Lines 30-52
function GM_addStyle(css) {
const style =
document.getElementById("GM_addStyleBy8626") ||
(function () {
const style = document.createElement("style");
style.type = "text/css";
style.id = "GM_addStyleBy8626";
document.head.appendChild(style);
return style;
})();
const sheet = style.sheet;
sheet.insertRule(css, (sheet.rules || sheet.cssRules || []).length);
}
//
GM_addStyle(`
.downloadIcon {
top: 0px;
left: 8px;
width: 16px;
background-position: 0px 0px;
background-repeat: no-repeat;
}`);
its from stackoverflow btw
austere talon
GM_addStyle has never worked for me in any scenario, so I don't know
but it woul...
the issue with that is that u now need to parse css
so you can recursively fetch resources
quaint sapphire
well yeah, it only works with a single selector per invocation
austere talon
otherwise if you fetch a theme and add it and that theme also uses imports, fonts, etc you're screwed
austere talon
no
austere talon
discords csp likely doesn't allow data links
figure out how to get GM_addStyle to work and maybe it bypasses csp
if it does we're set
if it doesn't, it's basically impossible
quaint sapphire
**steam-workshop-downloader.user.js: **Lines 30-52
```user.js
function GM_addSty...
well, we could also set the css as the inner html of a style
that doesnt require parsing
lol
but that is unsafe
austere talon
well, we could also set the css as the inner html of a style
no
quaint sapphire
no because discord users fall for any kind of scam
austere talon
it can't resolve imports, fonts, etc
quaint sapphire
or that
austere talon
since those are also remote sources thus also csp blocked
do you understand what I'm saying
austere talon
like say you're importing zelk.theme.css and zelk loads fonts.google.com/comic-sans, sure you can fetch zelk.theme.css and manually add it but now the browser sees hey Google fonts lemme fetch that and fails cause csp again. so you would need to fetch the theme, now parse all links in the theme, fetch that, recursively parse links in that and so on until you have everything, now you need to find a way to put it together and maybe use data links but those might not be allowed with their csp
just a huge headache
I don't see much reason to do this when people can just use the extension
but if GM_addStyle just works out of the box and bypasses csp that's perfect and definitely doable
3 weeks ago still has csp issues https://github.com/Tampermonkey/tampermonkey/issues/881#issuecomment-1421983170
so I don't think it will work
austere talon
yes
but you can fetch it and add and maybe it works idk
anyway is there any reason for people not to just use the extension?
quaint sapphire
ยฏ_(ใ)_/ยฏ
one reason could be mobile phones
you might have a userscript manager
but not extensions
(discord web on phones sucks either way)
quaint sapphire
you might have a userscript manager
for example Adguard can act as a global userscript manager
pretty nice
austere talon
one reason could be mobile phones
vencord android exists
quaint sapphire
that is cursed tho
austere talon
it's essentially unusable but so is discord in web (it's the same thing)
quaint sapphire
an android app for a webview is so cursed
austere talon
for example Adguard can act as a global userscript manager
what the fuck
quaint sapphire
what the fuck
hey, its pretty nice
quaint sapphire
why tf is adguard of all things doing that
lmao
austere talon
that seems so strange how does it inject scripts into ur browser
does it rewrite responses
quaint sapphire
that seems so strange how does it inject scripts into ur browser
adguard is a local vpn (or proxy if you have a rooted device)
it can do anything it wants
system apps ofc bypass it
limber skiff
ven ven review again
austere talon
I'm 99% certain this behaviour is fixed if you enable the NoConsoleWarn plugin
@fossil otter
since that disables their devtools open handler
quaint sapphire
megu is dum dum
limber skiff
yeah it's here
quaint sapphire
fossil otter
ah
limber skiff
seems to be encoded though
quaint sapphire
(the mobile app also has it ofc)
fossil otter
seems to be encoded though
i mean my code doesn't mess with the encoding part either
that's another function
limber skiff
ah
austere talon
yeah it's here
Nice token
fossil otter
austere talon
NoDevtoolsWarning, sorry
austere talon
does it do it correctly?
quaint sapphire
why re-install discord when you can rebuild vencord?
austere talon
I think the code is like
if (someStuff && "0.0.0" != DiscordNative.remoteApp.getVersion()) {
addDevToolsOpenHandler(() => {
hideToken(); spamWarninfg();
}
}```and vencord just changes it to if (false)
so the handlers are never added and hideToken never called
don't quote me on that though I would double check that's the case
split hornet
why re-install discord when you can rebuild vencord?
I am not really a tech nerd so I just reinstalled it
austere talon
if you enable that plugin then search for Patched by NoConsoleWarn you can double check
quaint sapphire
I am not really a tech nerd so I just reinstalled it
wait, why are you in #๐พ-core-development then?
oh, discord saves multiple tokens?
fossil otter
if you enable that plugin then search for `Patched by NoConsoleWarn` you can dou...
how do you even do that in the sources tab
austere talon
ctrl shift f
fossil otter
yes for account switcher
austere talon
searches all files at once
split hornet
wait, why are you in <#1015063227299811479> then?
I donโt know, just browsing through discord notifications because I am bored
quaint sapphire
but dont you need to re-login even when you have multiple accounts?
austere talon
no
Well maybe I didn't fully understand
with the account switcher you can add multiple accounts and switch between them without logging in
quaint sapphire
last time I used the account switch feature it asked for a password
austere talon
yeah, so it's like I thought, they call hideToken() in the devtools callback
but NoDevtoolsWarning changes that code to never run
little side effect lol
maybe if you want update the plugin description of NoDevtoolsWarning to add something like "Also prevents Discord from hiding your token, preventing random logouts" @fossil otter
fossil otter
yeah will do
austere talon
btw the code discord uses for checking devtools open is so silly
limber skiff
It's so cool seeing people that made the plugins I used on powercord here
austere talon
it runs an interval that checks a bunch of things like twice a second to guess if devtools are open
limber skiff
that prevents that right
limber skiff
๐
austere talon
lol
limber skiff
what
austere talon
that code still runs
limber skiff
๐คข
fossil otter
Disables the 'HOLD UP' banner in the console. As a side effect, also prevents Discord from hiding your token, which prevents random logouts.
fossil otter
does that sound good?
grave mangoBOT
https://github.com/sindresorhus/devtools-detect/blob/main/index.js
**index.js: **
/*!
devtools-detect
https://github.com/sindresorhus/devtools-detect
By Sindre Sorhus
MIT License
*/
const devtools = {
isOpen: false,
orientation: undefined,
};
const threshold = 170;
const emitEvent = (isOpen, orientation) => {
globalThis.dispatchEvent(new globalThis.CustomEvent('devtoolschange', {
detail: {
isOpen,
orientation,
},
}));
};
const main = ({emitEvents = true} = {}) => {
const widthThreshold = globalThis.outerWidth - globalThis.innerWidth > threshold;
const heightThreshold = globalThis.outerHeight - globalThis.innerHeight > threshold;
const orientation = widthThreshold ? 'vertical' : 'horizontal';
if (
!(heightThreshold && widthThreshold)
&& ((globalThis.Firebug && globalThis.Firebug.chrome && globalThis.Firebug.chrome.isInitialized) || widthThreshold || heightThreshold)
) {
if ((!devtools.isOpen || devtools.orientation !== orientation) && emitEvents) {
emitEvent(true, orientation);
}
devtools.isOpen = true;
devtools.orientation = orientation;
} else {
if (devtools.isOpen && emitEvents) {
emitEvent(false, undefined);
}
devtools.isOpen = false;
devtools.orientation = undefined;
}
};
main({emitEvents: false});
setInterval(main, 500);
export default devtools;
amazing
limber skiff
ew
fossil otter
this is what discord uses https://github.com/sindresorhus/devtools-detect
they love that guy
austere talon
does that sound good?
yeah
austere talon
but tbh it's probably not worth disabling that
Maybe we can start a general Unbloat plugin that kills shit code like that
idk if there's many more instances
austere talon
they love that guy
everyone in the js world does
me installing some random package off npm and checking my npm lock file only to see 20 new dependencies by sindresorhus
limber skiff
Maybe we can start a general Unbloat plugin that kills shit code like that
well we can make it a general unbloat from the start
turbid hatch
sindre micromodules
fossil otter
austere talon
vencord so bloatfree
I'm surprised we have nothing by him
since we have a shit ton of dev dependencies
austere talon
grave mangoBOT
like https://github.com/Vendicated/Vencord/blob/main/package.json#L38-L64
**package.json: **Lines 38-64
"devDependencies": {
"@types/diff": "^5.0.2",
"@types/lodash": "^4.14.191",
"@types/node": "^18.11.18",
"@types/react": "^18.0.27",
"@types/react-dom": "^18.0.10",
"@types/yazl": "^2.4.2",
"@typescript-eslint/eslint-plugin": "^5.49.0",
"@typescript-eslint/parser": "^5.49.0",
"diff": "^5.1.0",
"discord-types": "^1.3.26",
"esbuild": "^0.15.18",
"eslint": "^8.28.0",
"eslint-import-resolver-alias": "^1.1.2",
"eslint-plugin-header": "^3.1.1",
"eslint-plugin-path-alias": "^1.0.0",
"eslint-plugin-simple-import-sort": "^8.0.0",
"eslint-plugin-unused-imports": "^2.0.0",
"highlight.js": "10.6.0",
"moment": "^2.29.4",
"puppeteer-core": "^19.6.0",
"standalone-electron-types": "^1.0.0",
"stylelint": "^14.16.1",
"stylelint-config-standard": "^29.0.0",
"type-fest": "^3.5.3",
"typescript": "^4.9.4"
},
did find break
charred monolithBOT
Currently the Shiki Codeblocks plugin only affects code typed in fences. For inline code this isn't an issue as it allows for styling it to fit within a theme. But file previews are being rendered with whatever default Discord uses and that's plain ugly (something Shiki solves)
Shiki code block with custom TiffColors theme selected:
File preview in Discord Downbad
charred monolithBOT
quaint sapphire
https://discord.com/channels/1015060230222131221/1032770730703716362/10629423131...
austere talon
(the fix I added is just downloading old devtools)
they use some new extension api electron hasn't implemented
so the only fix is to downgrade which I did
limber skiff
the only thing that could fail there would be forceUpdate but okay
austere talon
as i said just to be safe
limber skiff
yaya
austere talon
imagine theres an error in the updater that causes the crash
then it checks updates in the handleCrash (which of course causes the crash again) and makes it even worse somehow or causes an infinite loop because now we crashed again so crashhandler called again and it checks updates and..... u know where this is going
austere talon
added indent
austere talon
i think instead of the alert we could also use a vencord notif
austere talon
iirc the only discord thing it depends on is react & react-dom
limber skiff
lets keep it as simple as possible
austere talon
and if those are broken then vencord is so majorly broken that it doesnt matter i think
but yeah this is fine
austere talon
actually no
notifications use forms and stuff
maybe should move away from that
eh nah its fine
theyre wrapped in errorboundy
worst thing that could happen is error box notif jumpscare
limber skiff
what?
austere talon
the one responsible of dismissing the notif is the notif component
so if it errors it never dismisses the notif
aka no new notifs show
limber skiff
yikes
austere talon
easy fix
austere talon
guh i need to edit erorrboundary api
limber skiff
it's insane
I spend most of my time doing plugins just reverse engineering discord
austere talon
had tomake ErrorBoundary.wrap onError give u the props of the wrapped component
limber skiff
makes sense
charred monolithBOT
limber skiff
yopp
austere talon
ye thats the joke
cause libdiscord is like c++
native lib
it segfaults discord i think
limber skiff
austere talon
this fix so dirty
idk how else to do it
ErrorBoundary now has slightly polluted props
cause if u use it like
<ErrorBoundary><div>balls</div></ErrorBoundary>```those props no apply
limber skiff
no idea how to help
charred monolithBOT
charred monolithBOT
charred monolithBOT
pure ledge
thanks i'll add this after school today
umbral hedge
suggestion
suggestion
verbal pumice
suggestion
austere talon
```
suggestion
```
funny discord not supporting empty codeblocks
happens when the suggestion is to delete that line lmao
umbral hedge
lmao
austere talon
btw @spark cove if you don't know why px is bad, basically it completely screws over users who change the default font size
spark cove
yea ikik
austere talon
if you use em or rem, the entire site will be scaled up or down if users change their default font size
spark cove
im converted by now but i first made spotimbed a WHILE ago
spark cove
so the css is old and i havent rewritten it eet
austere talon
btw <@454072114492866560> if you don't know why px is bad, basically it complete...
also regardless of that i find px units terrible to work with
em feel very natural
since i just go, okay i want the margin to be half as big as the text so just 0.5em
spark cove
lol yea i like the multiples
i only use px these days if its fixing a visual bug or something
calc(2em - 1px)
austere talon
yeah its okay when you have a specific use it for
and border-radius
and something that explicitly needs a specific height and width
spark cove
yea that fella is silly
austere talon
if you want tip for converting px to em/rem
default font size is smth like 16px i think
so just divide px amount by 16
and u get rem
spark cove
yop
austere talon
theres so many prs
spark cove
yeaep
austere talon
awesome header
turbid hatch
yeah i just looked on mdn
turbid hatch
yeah i will have to
working on it now
i was actually looking for something like it and couldnt find the right wording
so thank you for pointing me to it ^^
grave mangoBOT
https://github.com/Vendicated/Vencord/blob/main/scripts/runInstaller.mjs#L63-L73
**runInstaller.mjs: **Lines 63-73
const res = await fetch(BASE_URL + filename, {
headers: {
"User-Agent": "Vencord (https://github.com/Vendicated/Vencord)",
"If-None-Match": etag
}
});
if (res.status === 304) {
console.log("Up to date, not redownloading!");
return outputFile;
}
i use it here too
turbid hatch
oh thats cool
if ifm := c.Get("if-none-match"); ifm == written {
return c.SendStatus(304)
}
holy fuck i love this language
limber skiff
when context menu api ven ๐ข
turbid hatch
@austere talon fire idea btw
actually prefer the notifs
though not sure about the notifs on the setup procedure, i thought the toasts were alright
ill try them though
https://discord.coffee/7Sf2cfM.png nvm they do look alright
austere talon
though not sure about the notifs on the setup procedure, i thought the toasts we...
oh yeah I think toasts are fine for just enable confirm
but as soon as there's anything the user should read like error toasts are so bad
austere talon
notifications are nice yeah
turbid hatch
also are more obvious
limber skiff
welp
turbid hatch
toasts i almost missed and i was wondering where they went
limber skiff
we should have put the promptToUpdate function here
austere talon
Also the benefit of notifications is that people can extend their duration or make them permanent
like some people are slooooow so the toast is too short for them
turbid hatch
ye
limber skiff
can't update cuz it's broken
limber skiff
not good not good
austere talon
I deliberately made it so that you can't set notification duration via code
I think that's bad ux
austere talon
the user should decide how long notifications are, not the dev
powercord had it that way
turbid hatch
yip
austere talon
although I think I wanna add some more switches to toast api
a boolean that lets you send permanent notifications
for important data
for example
turbid hatch
hmm
might be a good idea
also i submitted all the requested changes for you, feel free to play when you're available 
austere talon
object has been destroyed
limber skiff
oh okay
austere talon
limber skiff
thanks
austere talon
what is this
I think this error means that something tried showing the browser window but it was already destroyed due to reloading
likely race condition in discords code
limber skiff
ah
austere talon
like maybe some async operation was done the same time you reloaded and then the callback tried using the browser window
somber ginkgo
could be worse, could have an ocd-triggering space just before a comma when typingtweaks is enabled... wait
charred monolithBOT
On linux (Fedora)- not working for me either.
No errors in the terminal if I launch it through there but discord still errors out.
I get this in dev tools on discord:
limber skiff
me on my way to trigger a react crash and force an update
charred monolithBOT
charred monolithBOT
limber skiff
@austere talon could it be the recover notification causing that Object got destroyed
solemn spoke
why the hell is the settings page breaking so much
limber skiff
discord being mean
swift fjord
guh
charred monolithBOT