i still have alot to learn
#plugins-dev-chat
celest thorn
slate flume
We all do
:)
You make a plugin for a ton of people on a server and they love it and at the end of the day that's what counts
true cedar
zero
slate flume
zero
true sierra
ive came up with a solution (to CustomRole.TryGet doing mean bad thingy), i overcomplicated it even more
who would like to see the monstrous code that should work
upper vapor
@slate flume talk about SRP when your custom items inherit from CustomEventsHandler? 
upper vapor
ive came up with a solution (to CustomRole.TryGet doing mean bad thingy), i over...
Yay
I love seeing horrible voice and crashing out
celest thorn
You make a plugin for a ton of people on a server and they love it and at the en...
idk like honestly its a year of development
and its almost done
celest thorn
I love seeing horrible voice and crashing out
you like this stuff
im sure you record them
upper vapor
No, I'm a toaster
upper vapor
426 reference 
slate flume
<@434572461011501067> talk about SRP when your custom items inherit from CustomE...
Wdym?
upper vapor
from a furry to a toaster
celest thorn
426 reference <:toomuchtrolling:974345880817791016>
old gradmas are like cameras
always been
hearty shard
It's the cleanest way to attach to multiple events
it also attaches every event afaik
upper vapor
It's the cleanest way to attach to multiple events
But it's not really SRP...
slate flume
But it's not really SRP...
How so?
unique crane
No, I'm a toaster
toaster
hearty shard
davy
slate flume
Attaching to multiple events doesn't mean something doesn't have a single purpose
true sierra
Yay
i've McFucking had it with exileds picky shit
public static bool TryGetCustomRoleFromPlayer(Player player, out CustomRole foundRole)
{
foundRole = null;
if (string.IsNullOrWhiteSpace(player.CustomInfo))
return false;
string[] lines = player.CustomInfo.Split('\n');
if (lines.Length < 2)
return false;
string roleIdentifier = lines[1];
foreach (var role in CustomRole.Registered)
{
if (role.CustomInfo == roleIdentifier)
{
foundRole = role;
return true;
}
}
return false;
}
Because you have the Item information and event handling in one class, probably not fully related
true cedar
fuck
slate flume
Because you have the Item information and event handling in one class, probably ...
They are because it serve the purpose of defining one item
true sierra
u wanna help test ruei v3
oooh, the api?
upper vapor
For your use case (no 079 damage) create a subclass, seal the hurting event and create another method that'll handle the event if it's not a recontainnent damage handler
slate flume
Wha
true cedar
oooh, the api?
yea
hearty shard
i've McFucking had it with exileds picky shit
```cs
public static bool TryGetCus...
what the flip
upper vapor
Wha
sealed override OnPlayerHurting(...)
{
if (ev.dh is not recontianment)
ProcessHurting(ev);
}
slate flume
Holy shit new keyword unlocked
upper vapor
So you don't accidentally override the original handler
upper vapor
Holy shit new keyword unlocked
slate flume
Fuck but that would still mean I would need to take all the onplayerhurting events and throw the keyword on
Cause it's not just custom items
upper vapor
Rider: extract superclass
And then replace the inherited class where applicable
And the event name too
slate flume
WAIT YOU RIGHT
Replace the
CustomEventsHandler
Is replacing all my customeventshandler inheritances with my own class going to far to deal with this issue?
Cause I could patch it and get the same effect
Idk which would be considered better
I'm okay with putting in the work for it
Just is it excessive
upper vapor
Is replacing all my customeventshandler inheritances with my own class going to ...
No need to replace all of them, only where you don't wanna check for 079 damage
slate flume
No need to replace all of them, only where you don't wanna check for 079 damage
I think I have like 10 classes where I don't want to check?
My plugin is very large
true cedar
it should be a lot easier than ruei v2
slate flume
Haha
true sierra
it should be a lot easier than ruei v2
I can help you test, give me a couple minutes
upper vapor
I think I have like 10 classes where I don't want to check?
Rider will yell at you 18 times if you use extract class
slate flume
I love it when rider yells at me
It loves yelling at me
I've learned a lot from it lmao
upper vapor
There isn't a refactoring to change the base type for multiple classes iirc
upper vapor
I've learned a lot from it lmao
true sierra
I love it when rider yells at me
Rider issues ๐คฃ๐คฃ๐คฃ
upper vapor
Rider issues ๐คฃ๐คฃ๐คฃ
My bad if I forgot something that's supposed to be obvious but vs is too dumb to highlight it
slate flume
I'll just make it so if damage handler is recontainment handler is doesn't call the onplayerhurting events
upper vapor
Bruh okay
slate flume
Or maybe just
upper vapor
UnAPI-ing the Lab
upper vapor
I gotta do that sometime
upper vapor
Make it ignore ev.IsAllowed
The former is easier
slate flume
Dope
worthy rune
huh
upper vapor
A plugin that un-API-s the Lab
slate flume
Me when
worthy rune
<@434572461011501067> talk about SRP when your custom items inherit from CustomE...
i feel like people that seperate their event handlers as a means to follow the SRP pattern are overdoing it
code patterns shouldn't be the rule, just guidelines
upper vapor
That's fine but then is it a single responsibility to handle everything there?
I'd make some extension methods to make the in-class code shorter at least
Like
Not the whole handler
But so it's less logic
worthy rune
the thing with SRP is that theres no end to how small you can split things up
slate flume
That's fine but then is it a single responsibility to handle everything there?
I...
I have a resources file where I put extraneous functions that I use in a few different classes
upper vapor
I have a resources file where I put extraneous functions that I use in a few dif...
static class Misc
worthy rune
which is the point im making, why have one external event handler class when you can have one for each event?
slate flume
I just find it easy to go
Abstract Base Class : Handles universal logic for all derived classes
Derived Class : Handles specific logic for that class
hearty shard
im so glad to finally be reworking my custom roles
slate flume
Rather than
Abstract Base Class : Handles universal logic for all derived classes + niche side cases and bonuses for different derived classes
Derived Class : Handles specific logic + uses base class logic to handle side cases
upper vapor
which is the point im making, why have one external event handler class when you...
Depends
E.g. if you're making a C4 then you wouldn't put the planted logic there
Although at that point it's not the item anymore, more so the planted "entity"
true cedar
static class Misc
bad practice!! starts throwing rocks
true sierra
chat i feel at peace now...
my custom teams are working
upper vapor
Rather than
Abstract Base Class : Handles universal logic for all derived classe...
Yep that's correct
I mean your point is correct
slate flume
๐ฅ I'm usually dumb and stupid
true sierra
๐ฅ I'm usually dumb and stupid
rip (not tide)
hearty shard
bad practice!! starts throwing rocks
nuh uh
worthy rune
which is the point im making, why have one external event handler class when you...
also when you follow one rule to its conclusion you usually break other principals which ends in code which is less maintainable
slate flume
The worst practice I have is my Resources class
It has like
15 extension methods
Of assorted variety
hearty shard
15 extension methods
seperate them 
hearty shard
slate flume
You can get an eclair
slate flume
I probably should
slate flume
do you like my docs
I've never made docs...
I never learned
I just try to make my classes as intuitive as possible to compensate
Lmao
upper vapor
also when you follow one rule to its conclusion you usually break other principa...
SRP KISS DI
and you're already cooked
upper vapor
I've never made docs...
I never learned
Make ai write docs for you
Realize that it's stupid
hearty shard
im honestly probably also gonna make HasFlagFast for every enum flag i use
slate flume
"I don't need docs I'll just remember 
"
upper vapor
im honestly probably also gonna make HasFlagFast for every enum flag i use <:kek...
When source generator or generic splution
hearty shard
When source generator or generic splution
idk if it could be done in an easy generic way
actually
it might
upper vapor
"I don't need docs I'll just remember <:think:737203678385143927>"
I'll just forget that I'm developing a public library
hearty shard
i should @ hubert to add to EnumUtils
slate flume
Make ai write docs for you
I have used AI in code maybe like
3 times
And it's for the boring manual labor-type shit
Like that lmao
celest thorn
@upper vapor PIRATE SOFTWARE
unique crane
and use that
unique crane
<@435474959595208704> PIRATE SOFTWARE
What
slate flume
Just get the EN translations file
Wait but you're right
But also
Idk how lmao
I'm stupid
You forget
slate flume
oh you mean
Okay yeah
I thought you meant some kind of interfacing
I'd still need to write the uh
Switch
For the room names
Or do interfacing with the translation file
Which sounds like
So much work
unique crane
Hmm does dedicated load translations too?
upper vapor
Alt+enter
Convert to switch expression
unique crane
Either check if dedicated load translations too
or just load the file yourself
Instead of hardcoding it like that ๐ญ
hearty shard
/// <summary>
/// Tries to get a role base from a <see cref="RoleTypeId"/>.
/// </summary>
/// <param name="roleTypeId">The <see cref="RoleTypeId"/> to get base of.</param>
/// <param name="role">The <see cref="PlayerRoleBase"/> found.</param>
/// <typeparam name="T">The <see cref="PlayerRoleBase"/>.</typeparam>
/// <returns>The role base found, else null. </returns>
public static bool TryGetRoleBase<T>(this RoleTypeId roleTypeId, [NotNullWhen(true)] out T? role)
=> PlayerRoleLoader.TryGetRoleTemplate(roleTypeId, out role);
/// <summary>
/// Gets the name of a <see cref="PlayerRoleBase"/> based on it's <see cref="RoleTypeId"/>.
/// </summary>
/// <param name="roleTypeId">The roletypeid to get name of.</param>
/// <returns>The found name.</returns>
public static string GetRoleName(this RoleTypeId roleTypeId)
=> roleTypeId.TryGetRoleBase(out PlayerRoleBase? playerRoleBase) ? playerRoleBase.RoleName : "Unknown";
upper vapor
or just load the file yourself
Can the dedi server change language easily
slate flume
Instead of hardcoding it like that ๐ญ
It's peak trust
unique crane
Seems like dedi only has english version
slate flume
use what i sent
Does .RoleName format it nicely?
unique crane
Copy paste it from client build
slate flume
I use it for UI stuff
hearty shard
Does .RoleName format it nicely?
it should
slate flume
I want it to look good
hearty shard
SCP-106
unique crane
Oh
slate flume
So it'll have spaces and shi
hearty shard
or smth
unique crane
I guess thats used
slate flume
Real shit
slate flume
You know
slate flume
I recently learned that
hearty shard
its up to nw what they named it
hearty shard
ye
slate flume
Generators spawn in nameless rooms
Well until you do
room.Base.name or some shit like that
Get the string name for the unity object rather than the enum
This shit rocked my world
I still need to update my plugin to handle it
upper vapor
RoomName enum doesn't encapsulate every room name
slate flume
That's so tuff
celest thorn
skibidi
celest thorn
She's so goated
thank you
hearty shard
<https://github.com/Axwabo/SCPSL-Helpers/blob/main/Axwabo.Helpers%2FConfig%2FRoo...
oh its just a room and .Contains
unique crane
I MEAN THE GAME
slender lynx
celest thorn
MAFIA IS PEAK
upper vapor
You are NOT gonna brainrot our national treasure
I support this statement
upper vapor
MAFIA IS FROM SICILY
Sillyci
hearty shard
@upper vapor why not EnumUtils<RoomType>.Values
upper vapor
Because it's old code
upper vapor
if i rewrite it will you fix it
Then I don't fix it cuz you fixed it
hearty shard
Then I don't fix it cuz you fixed it
yea but ur the the one that should put it on the github
hearty shard
also
i will NOT be giving you working code
probably
oh
actually you cant get attribute from an enum value
yea nvm im not fixing it, its good enough
upper vapor
Kek
true cedar
EVE
hearty shard
that one is the dev of RueI
ik
celest thorn
who is you
unique crane
who is this guy
Dementia
south socket
im so bored i dont even know.. can someone end me already? We love Lua ๐ฅ get the gmod guys
south socket
That reminds me to update my LuaLab
im doing this shit rn only because im bored
celest thorn
That reminds me to update my LuaLab
can i eat it?
south socket
(and we need more script kids in sl!!!!)
celest thorn
(and we need more script kids in sl!!!!)
script kiddies?
crazy we already have alot
celest thorn
i mean check how many people on exiled create chatgpt plugin
hearty shard
why can player be null in PlayerChangingRoleEventArgs
celest thorn
and complain that they don't work
celest thorn
why can player be null in PlayerChangingRoleEventArgs
Destroyed
south socket
and complain that they don't work
for that we need the LuaLab
(what am i talking about, they will break it too)
celest thorn
(what am i talking about, they will break it too)
i love breaking stuff
especially something called SCP:SL
south socket
i think i will just finish my lua API Wrapping and then publish it and then never maintain it again
south socket
especially something called SCP:SL
its there to be broken right
unique crane
Imma just find some node based programming framework
and make that for Lua
and for SL
south socket
can we add brainfuck for sl?
unique crane
Then do it
celest thorn
can we add SL in SL
true cedar
im so bored i dont even know.. can someone end me already? We love Lua ๐ฅ get th...
is this like ironlua or soem shit
celest thorn
Doom on SL
south socket
is this like ironlua or soem shit
MoonSharp
celest thorn
I used the uhhhhhh
yo david you know the chaos keycard instead of shitty snake
doom
unique crane
no
unique crane
No
obtuse spruce
Am i tripping or on this method the List is never returned to the pool ?
unique crane
Make it from texttoy
unique crane
Am i tripping or on this method the List is never returned to the pool ?
What would you get in return then
an empty list?
You can return it to the pool if you want (but not a big deal if you wont)
we plan on looking into this aswell
so its maybe gonna end up as IEnumerable
obtuse spruce
What would you get in return then
Why taking a List from the pool if its not for return it. Its not big deal bc i dont think there is a lot of peoples called that methods a lot of times but you rent it and never return it for the next time you need a Pickup List from the pool
worthy rune
idk about ienumberable for this one
true cedar
ienumerable prob wouldn't work yea
worthy rune
since its lazy it wont work unless you enumerate over it
unique crane
Why taking a List from the pool if its not for return it. Its not big deal bc i ...
Well, we do tell you about it.
obtuse spruce
i didnt have the comment :/
unique crane
Nuget is available
obtuse spruce
yea that what im gonna say. Probably cuz im a retard who use Managed Folder
celest thorn
Nuget is available
david whats the best piece of code inside the SL src that you like the most?
unique crane
idk
hearty shard
@unique crane when doing cola + anti cola
is it guaranteed that cola gets disabled
unique crane
I dont think either does
hearty shard
it does
unique crane
you just explode and die
unique crane
Seems like yea
hearty shard
wait actually
oh itll do the one that was on first
so if you drink cola first itll remove the cola
okay
doesnt that mean that if you do cola then anti you can survive
no. it was a no
hearty shard
this.GoingToExplode
what about it !
but yeah uh turns out
if anti cola isnt disabled by CokeBase, it jsut disables itself anyway
hearty shard
also turns out dummy 939s cant lunge properly
tulip kiln
Anyone knows why would this trigger an exception??
hearty shard
Anyone knows why would this trigger an exception??
room.IsDestroyed
tulip kiln
room.IsDestroyed
God bless ๐
hearty shard
God bless ๐
ok now i helped you so you help me right
hearty shard
generator.Room?.Base.name.Replace("(CLONE)", string.Empty) ?? "N/A"
why does this nto
replace
restive turret
Bc ??
tulip kiln
It's Clone
restive turret
Lmao
tulip kiln
Clone
restive turret
Skull issue
hearty shard
IM GONNA KILL YOU
restive turret
Do name.ToLower()
hearty shard
good idea
tulip kiln
I do that with names that the user can interact with
cause they can't use proper capitalization for shit
pallid galleon
anyone know how to hide the Dummy tag from a dummy when I spawn it?
I figured out how to disable it for all dummies but surely there's an easier way than just changing it to this and back when spawning it
celest thorn
I figured out how to disable it for all dummies but surely there's an easier way...
DummyUtils.DummyGroup = null;
:3
pallid galleon
But doesn't that do it for all dummies, not just certain ones?
celest thorn
But doesn't that do it for all dummies, not just certain ones?
for all dummies
pallid galleon
I'm trying to do it for certain dummies ๐
celest thorn
I'm trying to do it for certain dummies ๐
ig patch this code
ServerRoles::Start()
and make it just return when setting up the is dummy
and then make your own method wrapped around to SpawnDummy
pallid galleon
I think I'll just uhh.. disable it for all dummies
celest thorn
I think I'll just uhh.. disable it for all dummies
Oh ok
hearty shard
I figured out how to disable it for all dummies but surely there's an easier way...
um
errr
pallid galleon
I'm not that smart lol
celest thorn
I'm not that smart lol
if you want i can give you the code
directly
just let me open rider
hearty shard
I think I'll just uhh.. disable it for all dummies
r u trying to create npcs?
pallid galleon
I've never done any patch stuff so idk how to do that
celest thorn
I've never done any patch stuff so idk how to do that
let me do it for you
don't worry
pallid galleon
r u trying to create npcs?
Nah I'm making a custom role that spawns a dummy of itself as a decoy type thing
I just need the tag to not be there so people don't know it's a dummy
hearty shard
Nah I'm making a custom role that spawns a dummy of itself as a decoy type thing
so an npc.....
pallid galleon
sure, I just need it to sit there and pretend to be a real boy
celest thorn
Nah I'm making a custom role that spawns a dummy of itself as a decoy type thing
[HarmonyPatch(typeof(ServerRoles), nameof(ServerRoles.Start))]
public class PatchLol
{
public static bool Prefix(ServerRoles __instance)
{
__instance._hub = ReferenceHub.GetHub(__instance.gameObject);
return false;
}
}
Patch
pallid galleon
tyty, I'll see what I can do ๐
celest thorn
tyty, I'll see what I can do ๐
public static ReferenceHub SpawnDummy(string nickname = "Dummy", UserGroup? group = null)
{
ReferenceHub hub = DummyUtils.SpawnDummy(nickname);
hub.serverRoles.SetGroup(group);
return hub;
}
Here a code to actually spawn them with your own group or stuff you want note that if null the game will actually not display anything
Hope i helped
slate flume
[HarmonyPatch(typeof(PlayerEvents), nameof(PlayerEvents.OnHurting))]
public class Scp079InvulnerabilityFix
{
public static bool Prefix(PlayerHurtingEventArgs ev)
{
return ev.DamageHandler is not RecontainmentDamageHandler;
}
}```
NiceThat was an easier fix than I was expecting
slate flume
I'm a noob, where do I put the patch? ๐
Literally in any public class
Afaik
I'm on mobile I can read half the lines
barren pasture
Trying to add custom keybinds to my plugin, but they won't show up for players. What am I doing wrong?
Code here: https://github.com/malarada/CustomFramework-SCPSL/blob/master/CustomFramework/CustomFrameworkPlugin.cs#L129
true cedar
if any of u wanna help test out ruei v3 https://github.com/pawslee/RueI/releases/tag/v3.0.0-alpha.1
would greatly appreciate it since theres a lot to test and im really busy :^3
celest thorn
Helo
slate flume
Trying to add custom keybinds to my plugin, but they won't show up for players. ...
Try SecretAPI @hearty shard
https://github.com/Misfiy/SecretAPI/blob/master/SecretAPI.Examples/Settings/ExampleKeybindSetting.cs
celest thorn
SL is .net4.8 right?
yes
upper vapor
best you can do is .NET Standard
unfortunately
if only unity kept up with .NET releases (never happening)
slate flume
best you can do is .NET Standard
No INumber :'(((
celest thorn
someone knows the difference between Dedicated and SourceTV?
like what even is?
Oh
its a spectator game
crazy
upper vapor
git revert
celest thorn
git revert
NO
i already pushed like 3 other stuff
in case i can create a plugin and play around with it
but updating unless its like important
i will not
because as of rn i have another massive stuff to push
true cedar
new rewrite ;(
u knew the update was coming
true cedar
!!!
celest thorn
i'll wait for the Translation system to be pushed
then i will actually code a new update
with ruei v3
true cedar
i'll wait for the Translation system to be pushed
me or
true cedar
o
upper vapor
no its a pr im waiting for review
who's gonna review
celest thorn
who's gonna review <:d_rock:1041053522680098948>
none
maro will push it
directly lol
upper vapor
upper vapor
"please review"
"lgtm"
celest thorn
im just the only dev 
btw Exiled has a cool stuff
that decompiled git repo
im copying their idea
Because i need to be gone for some hours and that pc sucks ass
so git online is really useful
@upper vapor https://ratcentral.is-a-good.site/๐/r6pdngy5.png
decompiler moment
upper vapor
<@435474959595208704> https://ratcentral.is-a-good.site/๐/r6pdngy5.png
is this done with the vs decompiler
pine parcel
quick couple of questions if anyone knows the answer off the tops of their heads:
-
Is it possible to prevent scientists from escaping? (Like removing the event trigger off of them) or is it easier to make a new class rather than reuse scientist
-
Can I change the text that appears on spawn in (Ex. "You are a Scientist")
-
Can I change the colour and name of a role that someone has, or am I needed to implement a new class.
Thanks to anyone who takes the time to look at or answer my questions!!
celest thorn
is this done with the vs decompiler
dnspyex
and then pushed
with the console command
restive turret
Skill issue
restive turret
me when dotpeek has an export project feature
Tbh its worst than dnspyex
upper vapor
or whatever it's dependent on
upper vapor
Tbh its worst than dnspyex
idk about that
static meteor
quick couple of questions if anyone knows the answer off the tops of their heads...
- yes
- no
- irrc no
upper vapor
the decompiler itself is definitely better
upper vapor
quick couple of questions if anyone knows the answer off the tops of their heads...
for 2 and 3 you need to edit the translations yourlsef (clientside)
pine parcel
so that's nothing I can do from serverside then. Is implementing a new class also something needed server and client side modding?
pine parcel
1. yes
2. no
3. irrc no
Do you know how I would go about disabling escape scenarios for certain classes or players?
restive turret
@celest thorn
dotnet tool install --global ilspycmd
static meteor
Do you know how I would go about disabling escape scenarios for certain classes ...
public void OnEscaping(PlayerEscapingEventArgs ev)
{
if (ev.Player.Role == RoleTypeId.Scientist)
ev.IsAllowed = false;
}
Fuckin skill issue
restive turret
Stick with
true cedar
quick couple of questions if anyone knows the answer off the tops of their heads...
yes no kinda
celest thorn
ok fixed it
celest thorn
<@435474959595208704> https://ratcentral.is-a-good.site/๐/r6pdngy5.png
lol
yea more readable
upper vapor
VS decompiles it like that too
visual shittio
upper vapor
Dotpeak as switch
peak
celest thorn
Dotpeak as switch
now david i can pull up and say i have scp sl source code
unique crane
Yes
unique crane
now david i can pull up and say i have scp sl source code <:Trolley:113816368205...
No
celest thorn
(How to get sued speedrun)
celest thorn
No
Obv no this is fucking server
its a miracle its readable
but its really useful to have on git
upper vapor
celest thorn
https://cdn.discordapp.com/attachments/1159010897629548644/1181180083050917910/a...
i know one day the nw's snipers will find me
meow is too strong
upper vapor
they've found you already
upper vapor
๐ญ
restive turret
Ban
celest thorn
Why banning me im so cute :3
restive turret
celest thorn
<:KEK:837086637551910992>
meanie
restive turret
:catFlower:
slate flume
Is there a way to remove the severed hands models shit?
static meteor
The hands on the ground?
slate flume
Ye
static meteor
Ye
You might be able to patch SeveredHands.ChangeHandsState() idk if its synced with the client though
or if its the correct method ยฏ_(ใ)_/ยฏ
random scaffold
I wanted to tell you size of the next update
sizeof(nextUpdate) == 1 ? "nw moment" : "impossible"
restive turret
nextUpdate is not a type
celest thorn
10kb
celest thorn
Is chat alive?
restive turret
No
celest thorn
so sad
tepid sluice
can i modify 049's ability time of respawn a zombie?
celest thorn
can i modify 049's ability time of respawn a zombie?
Its client side if i remember correctly
i think tho you can do reset it
tepid sluice
did u remember where it is?
tepid sluice
thx
hearty shard
this is kinda fire
upper vapor
yayayayaya
unique crane
this is kinda fire
Whats so fire about it
hearty shard
Whats so fire about it
the brackets have colors
i didnt realize this was a thing ๐ญ
๐
a lot easier to see where smth starts and ends by its color than counting brackets
royal mica
Rainbow brackets, great plugin
upper vapor
gay brackets
hearty shard
@unique crane oi
why does this break shotgun
like shotgun ammo is 0, and you can get the reload animation.. it just doesnt add ammo
and its only seemingly when triggered through this method
worthy rune
do you have the processor code that spawns the shotgun
hearty shard
wdym
worthy rune
hmmm
worthy rune
where is this code
hearty shard
custom
worthy rune
yeah the item processor should handle it itself, no need for a static method(im not even sure if that would work in all cases)
base game might be doing stuff to the item before and after the upgrade
hearty shard
public virtual Scp914Result UpgradeInventoryItem(Scp914KnobSetting setting, ItemBase sourceItem)
{
ItemPickupBase sourcePickup = sourceItem.ServerDropItem(false);
Scp914Result scp914Result = this.UpgradePickup(setting, sourcePickup);
if (scp914Result.ResultingPickups == null || scp914Result.ResultingPickups.Length == 0)
return scp914Result;
InventoryInfo userInventory = sourceItem.OwnerInventory.UserInventory;
this.ClearCombiner();
foreach (ItemPickupBase resultingPickup in scp914Result.ResultingPickups)
{
if (!((UnityEngine.Object) resultingPickup == (UnityEngine.Object) null))
{
ISearchCompletor searchCompletor = resultingPickup.GetSearchCompletor(sourceItem.Owner.searchCoordinator, float.MaxValue);
if (searchCompletor.ValidateStart())
{
searchCompletor.Complete();
ItemBase resultingItem;
if (userInventory.Items.TryGetValue(resultingPickup.Info.Serial, out resultingItem))
this.AddResultToCombiner(resultingItem);
}
else
{
this.AddResultToCombiner(resultingPickup);
resultingPickup.Position = sourceItem.Owner.transform.position;
NetworkServer.Spawn(resultingPickup.gameObject);
}
}
}
return this.GenerateResultFromCombiner(sourceItem);
}
looks like this is what labapi does
this is labapi, which since im getting item handling for basegame without customs itd be BaseGameItemProcessor
so itd be what i showed above
unique crane
<@282125275930820608> oi
Fixed in next update
This itself doesnt break it
its that when shotgun is created
It has MagazineModule which gets set to inserted when given by RA or spawn
but it didnt account for 914 creation
slate flume
You guys know how sometimes loot clips through elevators?
Is it possible to fix that?
slate flume
but it didnt account for 914 creation
That's so funny
upper vapor
You guys know how sometimes loot clips through elevators?
wdym
restive turret
Fixed in next update
So when that?
unique crane
The next update
tepid sluice
hearty shard
@unique crane btw when is scale controller like actually reset in the role creation like time
hearty shard
cuz if you prevent scale change when is called and then disable scale prevention from there
unique crane
<@282125275930820608> btw when is scale controller like actually reset in the ro...
With the role initialization
hearty shard
it still prevents it
hearty shard
With the role initialization
wouldnt that be after PlayerChangingRoleEventArgs
unique crane
No thats called last
hearty shard
yea
unique crane
well then yea thats before that
makes sense
You cant initialize role and then event says "nuh uh"
hearty shard
OnRoleRemoved is called in Changing
but OnChangingScale seems to still prevent it
hearty shard
custom
unique crane
OnRoleRemoved is called in Changing
but OnChangingScale seems to still prevent i...
Just call the event in the property
Literally
hearty shard
Just call the event in the property
wdym
unique crane
Well then whats the problem
hearty shard
it still seems to prevent it
unique crane
Prevent what
hearty shard
Scale resetting
even tho on Changing i remove the event
so by the time role is being initialized it shouldnt be called
unique crane
Scale resetting
Wdym
unique crane
hm
hearty shard
but when role is removed (OnChangingRole) it seems to still be in affect
eg changing to 173 twice works
but the first time doesnt
the health works fine and doesnt seem to break
its just scale specifically
unique crane
I still dont understand what your trying to do
You want to set scale
when player changes role
hearty shard
prevent scale change while having the custom role
role is not removed on escape
Oh
why is Scale setter called every frame
i might be going insane
hearty shard
because i dont rly use FpcScaleController for anything except for yk
this patch rly
this is all uses of the setter
unique crane
how about player.Scale?
hearty shard
there is no uses for player.Scale either
unique crane
dont know then
hearty shard
ss didnt show but no results
wait
i might know
new SyncedScaleMessages.ScaleMessage(this._scale, this.Hub).SendToAuthenticated<SyncedScaleMessages.ScaleMessage>();
that sends to dedicated server
which sets .Scale
and i have a delay to fix issues
so
uh
new SyncedScaleMessages.ScaleMessage(__instance._scale, __instance.Hub).SendToHubsConditionally(hub => hub.Mode is not (ClientInstanceMode.Unverified or ClientInstanceMode.DedicatedServer));
problemo solved
unique crane
Oh
hearty shard
not into 14.1.1 at least
restive turret
next update
Ye as 15.0? Or still be something fix for 14.x
solid mica
Ye as 15.0? Or still be something fix for 14.x <:Fear:1172595228193067138>
In 14.1.1.1
keen berry
can't wait for 14.1.1.1
hearty shard
can't wait for 14.1.1.1
cant wait to KILL YOU
we need for 14.2 or 14.1.2
or
22.0
keen berry
cant wait to KILL YOU
hearty shard
It's the TLS Beta
i disagree
south socket
https://ratcentral.is-a-good.site/๐/zevf2hn6.png
nope what the helly
royal mica
https://ratcentral.is-a-good.site/๐/zevf2hn6.png
Is this in the game? Does it have an update loop?
celest thorn
Is this in the game? Does it have an update loop?
Its in the game
but i've never seen it
(Server Side)
south socket
Is this in the game? Does it have an update loop?
i mean it is but its literally doing nothing (so it seems)
south socket
Its in the game
but gets never loaded or initiated
spare zodiac
guys!
what happens when you change the speaker in voice message to someone else? Can you speak through someone?
keen berry
what happens when you change the speaker in voice message to someone else? Can y...
that sounds terrifying out of context
keen berry
truly
keen berry
LOL
spare zodiac
slate flume
Okay wait before I test, does changing the voice channel of a message sync with the client and actually work or no?
Eg. Override and redirect SCP messages to use proximity channels
I'm a little busy so I figured I'd ask in case anyone knows
hearty shard
Okay wait before I test, does changing the voice channel of a message sync with ...
yes
msg.Channel = VoiceChatChannel.Proximity;
slate flume
Fire
slate flume
Iirc I'd need to resend the message cause the message we get in the event is a copy
Right?
hearty shard
what
when PlayerSendingVoiceMessageEventArgs is called
you need to deny event
and then send it
just foreach every player, validate with their IVoiceRole::VoiceModule.ValidateReceive
and then set the msg channel and send it listener.Connection.Send(msg);
slate flume
Okay cool yeah that's what I thought
What I mean is that
The event doesn't give the actual original message, so making modifications to that message won't sync iirc
hearty shard
or maybe PlayerReceivingVoiceMessageEventArgs can be used instead without actually sending
slate flume
I remember seeing a whole debate in here about it
hearty shard
The event doesn't give the actual original message, so making modifications to t...
msg.Channel = VoiceChatChannel.Proximity;
listener.Connection.Send(msg);c
thats my code
ev.Message.SendProximityMessage(MaxProximityDistance);
this is how its called (from the event)
slate flume
Yeah I already do a prox chat thing I just wanted to know if changing message synced and that the ref thing was right
hearty shard
even if its not a ref
if you deny the event
and modify the new voice message
it will do the same
because ur still sending the correct data and client can handle it
slate flume
it will do the same
I know
I just wanted to make sure I was right that it wasn't a ref
Haha that was the extent of my inquiry into that
upper vapor
slate flume
I don't fully understand but very cool
hearty shard
slate flume
So
What
I'm confused
Does this mean I didn't need to set up my system around essentially doing the event myself and I could've just modified the message?
upper vapor
yea
upper vapor
skull emoji
grand flower
Bruh
true cedar
shut up eve!!!!!
celest thorn
Someone knows how to modify a out in a prefix?
upper vapor
ref Type param
restive turret
nice honkers
celest thorn
nice honkers
AHAHAAHHAHAHHAAHAHA
slate flume
nice honkers
I was surprised people were just overlooking the beginning part of that video
tepid sluice
bruh
celest thorn
lets change topic lol
upper vapor
lets change topic lol
OneTopic mentioned?
celest thorn
I have a stupid question is it too heavy to have a new Harmony for each module that i have
upper vapor
Why would you do that ๐ญ
celest thorn
Why would you do that ๐ญ
Because i have harmony patch for each of them and i want to be able to disable them
whenever i want
upper vapor
You can use SecretAPI's PatchCategory
celest thorn
You can use SecretAPI's PatchCategory
And unpatching?
upper vapor
Call unpatchcategory
celest thorn
just not pushed
can you give it to me :3
hearty shard
can you give it to me :3
next year
upper vapor
Merry Christmas
celest thorn
so sad
celest thorn
next year
Times up give me the code
๐ซ
like the only problem i got
is finding the MethodBase
for that type
harmony.Unpatch(harmony.GetPatchedMethods().First(x => x.DeclaringType == type), HarmonyPatchType.All, harmony.Id)
I mean this could work?
hearty shard
public void UnpatchAll(string harmonyID = null)
{
foreach (MethodBase methodBase in Harmony.GetAllPatchedMethods().ToList<MethodBase>())
{
MethodBase original = methodBase;
int num = original.HasMethodBody() ? 1 : 0;
Patches patchInfo1 = Harmony.GetPatchInfo(original);
if (num != 0)
{
patchInfo1.Postfixes.DoIf<HarmonyLib.Patch>(new Func<HarmonyLib.Patch, bool>(IDCheck), (Action<HarmonyLib.Patch>) (patchInfo => this.Unpatch(original, patchInfo.PatchMethod)));
patchInfo1.Prefixes.DoIf<HarmonyLib.Patch>(new Func<HarmonyLib.Patch, bool>(IDCheck), (Action<HarmonyLib.Patch>) (patchInfo => this.Unpatch(original, patchInfo.PatchMethod)));
}
patchInfo1.Transpilers.DoIf<HarmonyLib.Patch>(new Func<HarmonyLib.Patch, bool>(IDCheck), (Action<HarmonyLib.Patch>) (patchInfo => this.Unpatch(original, patchInfo.PatchMethod)));
if (num != 0)
patchInfo1.Finalizers.DoIf<HarmonyLib.Patch>(new Func<HarmonyLib.Patch, bool>(IDCheck), (Action<HarmonyLib.Patch>) (patchInfo => this.Unpatch(original, patchInfo.PatchMethod)));
}
bool IDCheck(HarmonyLib.Patch patchInfo) => harmonyID == null || patchInfo.owner == harmonyID;
}
this is what harmony does
upper vapor
@celest thorn as long as the modules are in separate assemblies, you can easily call PaychAll/UnpatchAll
celest thorn
<@642642727237845041> as long as the modules are in separate assemblies, you can...
no they aren't
plain gazelle
Hm, something in my code is causing the server to freeze and die to lack of heartbeat.
I cant find anything in ServerLogs or LocalAdminLogs about it.
Do i have to comment out parts of my code bit by bit until i find it or is there a better way? :c
grand flower
Hm, something in my code is causing the server to freeze and die to lack of hear...
Do you do anything player scale related
plain gazelle
Current theory that it is ScaleMessage(stuff).SendToAuthenticated();
since that was my most recent addition
hearty shard
Current theory that it is ScaleMessage(stuff).SendToAuthenticated();
since that...
do NOT do SendToAuthenticated
plain gazelle
okay .w.
hearty shard
this is the fixed nw version
the change is the bottom line, with SendToHubsConditionally
plain gazelle
oh
lol
yeah that fixed it
Thanks x.x
Is there any other use case of SendToAuthenticated that does not result in a server crash? xd
-# wondering why it exists
plain gazelle
I made fake scales that work, but how can i send a scale message to all (real) players to "fix"/resync the server scale?
My first smooth brain idea was player.Scale = player.Scale but that doesnt work xD
hearty shard
Conti
plain gazelle
I am spawning an explosion by doing
ExplosiveGrenadeProjectile.SpawnActive(spawnPosition, ItemType.GrenadeHE, null, 0);
but it isnt dealing any damage to anyone :c
hearty shard
I am spawning an explosion by doing
`ExplosiveGrenadeProjectile.SpawnActive(spaw...
dont use null
plain gazelle
even with a player it doesnt do anything ,_,
hearty shard
TimedGrenadeProjectile.SpawnActive(player.Position, ItemType.GrenadeHE, player, 0.1f);
works for me
plain gazelle
Explosion blows off all doors but leaves any player uninjured ?w?
unique crane
Do you have FF off or on
unique crane
Do you move between spawning the grenade and it exploding?
It might be that kind of bug
plain gazelle
I have a command that spawns an explosion at another player which works fine
Could it be that im destroying the script the grenade is made from at the same time?
grand flower
shouldn't be
unique crane
I have a command that spawns an explosion at another player which works fine
And that one spawns active grenade too?
Or you use ExplosionUtils?
plain gazelle
What is that :o
unique crane
Could it be that im destroying the script the grenade is made from at the same t...
t
plain gazelle
ExplosionUtils.ServerSpawnEffect or
ExplosionUtils.ServerExplode?
:o
hearty shard
ExplosionUtils.ServerSpawnEffect or
ExplosionUtils.ServerExplode?
:o
one does the effect one does the killing
plain gazelle
,_,
hearty shard
And that one spawns active grenade too?
i assume they both use labapi one
plain gazelle
Explode player:
ExplosiveGrenadeProjectile.SpawnActive(target.Position, ItemType.GrenadeHE, requester, 0);
Explode RPG:
ExplosiveGrenadeProjectile.SpawnActive(transform.position, ItemType.GrenadeHE, Owner, 0);
The script for it is on an rpg schematic that gets moved to "fly"
unique crane
And is the Owner really not null?
plain gazelle
yes
unique crane
Can you check
Because I would trust the requested player to not be null
but here your doing some
things
and I have honestly no idea what else it might be
plain gazelle
maybe the "Owner" variable on the script is the issue since the script gets deleted right after?
unique crane
Well your first passing it and then deleting it so no issue there
plain gazelle
will put a logger and see
Code:
Result:
I also commented out the Destroy(gameObject) and yeah that wasnt it
unique crane
Uhhhhh
plain gazelle
I increased the timer to 3s to test it again and now it deals damage waaaa
plain gazelle
Doesnt work again
restive turret
0.2
plain gazelle
Sometimes it worked with 0,
sometimes it worked with 4
Most often it doesnt work with 0,
Most often it doesnt work with 4
Seems like server restarts just choose something at random ๐ญ
plain gazelle
one does the effect one does the killing
So how would i use ExplosionUtils to manually create an instant explosion at a location? .w.
apparently null works now?? D: im confused
unique crane
Okay that is weird
celest thorn
How do i make a gun shoot at someone even if they are in great distance?
NetworkWriterPooled writer = NetworkWriterPool.Get();
int headerPos = writer.Position;
writer.WriteByte(0);
int payloadStart = writer.Position;
writer.WriteRelativePosition(new RelativePosition(player.Position));
writer.WriteQuaternion(player.Rotation);
writer.WriteReferenceHub(Player.DummyList.First().ReferenceHub);
writer.WriteRelativePosition(new RelativePosition(Player.DummyList.First().Position));
int payloadEnd = writer.Position;
writer.Position = headerPos;
writer.WriteByte((byte) ((payloadEnd - payloadStart) & 0xFF));
writer.Position = payloadEnd;
NetworkReader reader = new(writer.ToArraySegment());
new ShotBacktrackData(reader).ProcessShot(item.Base, null);
I tried this
but nothing
oh wait
why am i writing this info lol
it works im stupid
barren pasture
Working with RueI 2 to figure out how the fuck it works, and an example uses this code: AutoElement.Create(Roles.Scps, MyElement).UpdateEvery(TimeSpan.FromSeconds(0.7));, yet I can't find AutoElement.Create. The hell am I doing wrong?
true cedar
Working with RueI 2 to figure out how the fuck it works, and an example uses thi...
new AutoElement
but also
ruei v2 is being replaced with ruei v3 which is literally better in every way
so i wouldnt recommend trying to learn 2
barren pasture
I already looked at three, I thought they were gonna be somewhat similar at least, but no. Completely different.
barren pasture
its a lot easier to use tho so
Do I have to call something to make the DynamicElement initiate or does it automatically start working?