1.20.2 | The NeoForged Project | Page 12

prime quest Oct 30, 2023, 7:29 PM

#

feral moat Oct 30, 2023, 7:29 PM

#

how do you run the formatter/why does the xml in codeformat not play super nicely xpout

kindred fractal Oct 30, 2023, 7:30 PM

#

gradlew spotlessApply

dull bison Oct 30, 2023, 7:31 PM

#

they what? mom and dad are getting married? /s

prime quest Oct 30, 2023, 7:32 PM

#

feral moat Oct 30, 2023, 7:32 PM

#

no they didn't propose to each other

#

they proposed to FC

dull bison Oct 30, 2023, 7:33 PM

#

they are marrying ForgeCraft? /s

kindred fractal Oct 30, 2023, 8:33 PM

#

@glass ferry fyi antlr was updated to 0.4.13

glass ferry Oct 30, 2023, 8:34 PM

#

ye, I saw

#

ironically that's higher than I can use rn

#

but now I have a reason to update our stuff so it doesn't matter

#

um

#

@kindred fractal macos support may be broken

#

Exception in thread "main" java.lang.IllegalStateException: GLFW may only be used on the main thread and that thread must be the first thread in the process. Please run the JVM with -XstartOnFirstThread. This check may be disabled with Configuration.GLFW_CHECK_THREAD0.

#

i'm running with NG7

#

i can bypass it by adding -XstartOnFirstThread to jvm args

#

(though you have to make sure not to add this on linux/windows)

kindred fractal Oct 30, 2023, 8:41 PM

#

how come it's not on the main thread? thonk

#

also, is this a mod workspace or neoforged workspace?

true pivot Oct 30, 2023, 8:42 PM

#

some cursory research suggests its not just about being on the main thread, the jvm also has to make the main thread the actual first thread of the process

sly anvil Oct 30, 2023, 8:46 PM

#

Yeah, this is a universal thing for everything using LWJGL on OSX. All the launcher JSONs include this (e.g. https://piston-meta.mojang.com/v1/packages/75c25311ac5098c9a5c0b7747e932537752243f0/23w43b.json) - I thought NG would inherit those flags?

mental carbon Oct 30, 2023, 8:57 PM

#

sly anvil Yeah, this is a universal thing for everything using LWJGL on OSX. All the launc...

It should

kindred fractal Oct 30, 2023, 9:01 PM

#

maybe not in userdev?

mental carbon Oct 30, 2023, 9:02 PM

#

Hmm

#

That is indeed the case

kindred fractal Oct 30, 2023, 9:03 PM

#

do also check forgedev

sly anvil Oct 30, 2023, 9:05 PM

#

Yeah, looking at this now, the common plugin just ends up bringing in far too much extra stuff which doesn't make it practical to put in non-Forge projects. I think I can work around it for now, but making the sourceset extension optional would be nice.

#

Other than that, really liking NG. Been able to replace my usage of vanillagradle with it too, which is really nice. Thank you Orion <3!

stray scroll Oct 31, 2023, 8:50 AM

#

Since we've released NeoForge 20.2, this thread has outlived its purpose according to its title. In line with that, I'm going to close and lock this thread in an hour or so (if nobody objects)

kindred fractal Oct 31, 2023, 8:51 AM

#

Before locking it, maybe rename it to 1.20.2 and create a new one for 1.20.3 snapshots

mental carbon Oct 31, 2023, 8:52 AM

#

Yes please

#

What tech said

tawny iron Oct 31, 2023, 10:36 AM

#

I thought you’d only released a working beta

#

This thread still seems relevant until a stable release, no?

stray scroll Oct 31, 2023, 10:37 AM

#

discussion on stability can be done in the usual channels

#

as far as I'm concerned, this channel has served its purpose in getting us to a released 1.20.2 build of NF -- tracking work from MC snapshots to NF release

#

er, thread

winged hull Oct 31, 2023, 1:03 PM

#

stray scroll Since we've released NeoForge 20.2, this thread has outlived its purpose accordi...

an hour or so

formal plume Oct 31, 2023, 1:04 PM

#

1.20.2

nova sundial Oct 31, 2023, 1:05 PM

#

squirr

#1.20.2