1.20.2 | The NeoForged Project | Page 11

frail oriole Oct 21, 2023, 8:43 PM

#

Task :forge:neoFormJoined1.20.2-20230921.152923DownloadAssets FAILED

#

running setup

kindred fractal Oct 21, 2023, 8:43 PM

#

yeah you need to create the directory

frail oriole Oct 21, 2023, 8:43 PM

#

why?

kindred fractal Oct 21, 2023, 8:44 PM

#

in the error message it should tell you that you're missing some downloadAssets directory and you need to create it then do setup again

frail oriole Oct 21, 2023, 8:44 PM

#

yes. i get that. but why doesn't it create it automatically?

#

that's always been a sign of a significant issue previously

#

Some problems were found with the configuration of task ':base:neoFormMergeMappings' (type 'Execute').
  - In plugin 'net.neoforged.gradle.common.CommonProjectPlugin' type 'net.neoforged.gradle.common.runtime.tasks.Execute' property 'multiRuntimeArguments' is annotated with @PathSensitive but that is not allowed for 'Input' properties.

#

new error

mental carbon Oct 21, 2023, 8:46 PM

#

On it

frail oriole Oct 21, 2023, 8:46 PM

#

ah ok

mental carbon Oct 21, 2023, 8:46 PM

#

It is a bug in the caching engine

frail oriole Oct 21, 2023, 8:47 PM

#

ah ok

#

i'll give it another whirl in a bit

mental carbon Oct 21, 2023, 8:51 PM

#

@frail oriole Try again after pulling

#

Shit

#

Nevermind

kindred fractal Oct 21, 2023, 9:02 PM

#

you left a ton of spaces in dynproject irritatered
PS: tis a joke ^^

#

I'll push my stuff on a different branch just so we have forgedev stable-ish for idea

#

alright, pushed my stuff

#

we still need to do a lot of renaming, but it should just be moving neoforge classes around and not have any other impact on other parts of the toolchain

#

current setup:

1.20.2-rebased branch on Kits. you can add commits to this branch, but keep in mind they will appear as-is when we publish (so don't commit the MC sources)
neoforge-rename branch on NeoGradle for now

we need to do a bunch of renaming of basically every instance of forge to neoforge (except for tags)... see hackmd https://hackmd.io/@neoforged/SyPzw1Ryp for coordination and things to do in that regard

if you rename a class add it to the list here: https://hackmd.io/@neoforged/rJtC7ucZT

known issues:

assets generation needs you to create the directory
install works on the client, but not on server

kindred fractal Oct 21, 2023, 9:13 PM

#

kindred fractal current setup: - `1.20.2-rebased` branch on Kits. you can add commits to this br...

#

@frail oriole @dull bison @fallow sundial we need to rename any class that contains Forge and update all the resources...

#

I'll be gone tomorrow so I leave this to you guys 😄

frail oriole Oct 21, 2023, 9:17 PM

#

ok

kindred fractal Oct 21, 2023, 9:18 PM

#

Orion fyi I haven't applied your two latest gradle-related commits because I thought that they depend on the latest NG changes; whenever you think the latest NG fixes are ready just commit them on the rebase branch

#

for the class renames, we shouldn't blindly rename Forge -> NeoForge
ideally we should get rid of generic names like ForgeChunkManager and try to find something better (and IForgeXXX should become IXXXExtension)

kindred fractal Oct 21, 2023, 9:38 PM

#

ok yeah userdev data doesn't work... somehow the modules didn't get substituted

#

ok nvm I got it to work

mental carbon Oct 21, 2023, 9:45 PM

#

??????

kindred fractal Oct 21, 2023, 9:45 PM

#

runs {
    client {
        modSources.add(project.sourceSets.main)
    }

    server {
        modSources.add(project.sourceSets.main)
    }

    data {
        modSources.add(project.sourceSets.main)

        programArguments.addAll '--mod', 'examplemod'
    }
}

this works

mental carbon Oct 21, 2023, 9:45 PM

#

Yeah 😄

#

That is indeed it

kindred fractal Oct 21, 2023, 9:46 PM

#

a tried a million things that were all more complicated 😛

mental carbon Oct 21, 2023, 9:46 PM

#

You should just have checked the userdev artifact 😄

#

It is what I do

kindred fractal Oct 21, 2023, 9:46 PM

#

I ended up checking dynproj 😛

mental carbon Oct 21, 2023, 9:46 PM

#

Also possible since that generates them 😄

#

AND BOOOOOOJA

#

I got NG7s cache fixed for Execute

#

kindred fractal Oct 21, 2023, 9:48 PM

#

niiiice 😄

mental carbon Oct 21, 2023, 9:49 PM

#

Pushed

#

@fallow sundial and @frail oriole both of your errors should now be fixed

#

Please pull NG7

#

And reimport

kindred fractal Oct 21, 2023, 9:52 PM

#

you need to apply my changes to NG and your gradle changes to 1.20.2-rebased on kits too

mental carbon Oct 21, 2023, 9:56 PM

#

What changes to NG?

kindred fractal Oct 21, 2023, 9:57 PM

#

https://github.com/neoforged/NeoGradle/commit/2ab9cfd549fca39ae1f54856d25906f2288753e9

mental carbon Oct 21, 2023, 9:57 PM

#

Ah neoforge-rename

kindred fractal Oct 21, 2023, 9:57 PM

#

yeah just that

mental carbon Oct 21, 2023, 9:57 PM

#

I will have to hand reimplement those

#

Because that will be a pain

#

With the new afterEvaluate block

kindred fractal Oct 21, 2023, 9:58 PM

#

yeah probably manual apply... shouldn't be too bad

frail oriole Oct 21, 2023, 10:00 PM

#

it's supposed to be working, right?

#

do i need to manually clean anything?

#


FAILURE: Build failed with an exception.

* Where:
Build file '/home/cpw/projects/neoforged/NeoGradle/build.gradle' line: 31

#

this seems to be all i ever get

#

latest checkout

kindred fractal Oct 21, 2023, 10:02 PM

#

which NG and Kits branches?

mental carbon Oct 21, 2023, 10:02 PM

#

kindred fractal yeah probably manual apply... shouldn't be too bad

Okey implemented that

frail oriole Oct 21, 2023, 10:02 PM

#

1.20.2-ngnext and FG_7.0 as usual

#

even clean is erroring

mental carbon Oct 21, 2023, 10:03 PM

#

You seem to be having a build error in NeoGradle.....

frail oriole Oct 21, 2023, 10:03 PM

#

yes

mental carbon Oct 21, 2023, 10:04 PM

#

Can you run a build, from terminal in that project

#

?

frail oriole Oct 21, 2023, 10:04 PM

#

i'm cleaning all the .gradle and build dirs a second

mental carbon Oct 21, 2023, 10:05 PM

#

@stray scroll Is GU now ready for Config Cache? Or am I missing something?

frail oriole Oct 21, 2023, 10:06 PM

#


> Task :vanilla:validatePlugins FAILED
> Task :platform:validatePlugins FAILED

#

building just NG

#

latest FG_7.0

#

brb

kindred fractal Oct 21, 2023, 10:06 PM

#

yeah it's failing on TC too

mental carbon Oct 21, 2023, 10:07 PM

#

Wtf

kindred fractal Oct 21, 2023, 10:09 PM

#

something is missing an input or output annotation

mental carbon Oct 21, 2023, 10:10 PM

#

Fixed

#

I must have been smoking something

#

Just double checking that it works.....

#

Hold on

#

Pushed

#

@frail oriole You can pull

#

And try again

#

I was missing an annotation

#

If it does not work now

#

Then it will need to wait untill tomorrow

#

My brain is fried

#

From trying to fix all the caching issues

kindred fractal Oct 21, 2023, 10:14 PM

#

yeah no worries

frail oriole Oct 21, 2023, 10:14 PM

#

Ok. I'll give it a try shortly. Just getting supper now

mental carbon Oct 21, 2023, 10:14 PM

#

Okey

#

Have a good night people

#

I am too tired to think further on this

kindred fractal Oct 21, 2023, 10:15 PM

#

good night!

kindred fractal Oct 21, 2023, 10:31 PM

#

userdev gametest server is broken because of a wrong path in FML - I'll look for a fix on Monday that gets rid of these useless gametest launch handlers instead of just fixing the path

stray scroll Oct 22, 2023, 6:08 AM

#

mental carbon <@607058472709652501> Is GU now ready for Config Cache? Or am I missing somethin...

wdym you're missing something? thonk

mental carbon Oct 22, 2023, 9:49 AM

#

nevermind

#

@dull bison With respect to the 1.20.2 branch in Kits, is that still relevant?

#

I want to unify ngnext, and rename

#

And Wanted to do it in 1.20.2

#

But there are some commits I am failing to find in the ngnext/rename branch

#

So just checking

mental carbon Oct 22, 2023, 10:14 AM

#

@kindred fractal What was the squashing point for 1.20.2-rebased?

kindred fractal Oct 22, 2023, 10:17 AM

#

Schurli's commit

#

HEAD~2 now I think

mental carbon Oct 22, 2023, 10:18 AM

#

#

It at the earliest can be HEAD~4

#

Because I made 3 and you made 1

kindred fractal Oct 22, 2023, 10:18 AM

#

Ah yeah it's my commit

#

So HEAD~3

#

You can apply everything gradle as a single new commit on rebased I think

mental carbon Oct 22, 2023, 10:19 AM

#

So I need to port over the last 3 commits

#

And then make that 1.20.2 Cool 😄

kindred fractal Oct 22, 2023, 10:19 AM

#

Yeah 😉

mental carbon Oct 22, 2023, 10:20 AM

#

Funny thing is, the only thing relevant there is the last commit

#

The middle one reverts the first one

dull bison Oct 22, 2023, 12:07 PM

#

mental carbon <@213343613583622144> With respect to the 1.20.2 branch in Kits, is that still r...

nope I already stated that it can be overwritten

mental carbon Oct 22, 2023, 12:12 PM

#

Super

mental carbon Oct 22, 2023, 3:00 PM

#

@dull bison you around?

kindred fractal Oct 22, 2023, 3:27 PM

#

Remember to look into the server patch generation

mental carbon Oct 22, 2023, 3:39 PM

#

Yeah currently having a completely different issue

mental carbon Oct 22, 2023, 5:14 PM

#

Okey build now runs without issue with the config cache

#

@stray scroll Amazing work!

#

stray scroll Oct 22, 2023, 5:14 PM

#

thinkies

#

~~i can't believe it actually works~~ coughs I mean, I had no doubts thinkies

mental carbon Oct 22, 2023, 5:15 PM

#

#

Installer works

stray scroll Oct 22, 2023, 5:16 PM

#

but does prod work 👀

mental carbon Oct 22, 2023, 5:17 PM

#

Nope XD

fallow sundial Oct 22, 2023, 5:58 PM

#

FAILURE: Build failed with an exception.

* Where:
Build file 'P:\NeoForged\NeoGradle\build.gradle' line: 31

* What went wrong:
Configuration cache problems found in this build.

2 problems were found storing the configuration cache.
- Build file '..\NeoGradle\build.gradle': external process started 'C:\Program Files\Git\cmd\git.exe --version'
  See https://docs.gradle.org/8.1.1/userguide/configuration_cache.html#config_cache:requirements:external_processes
- Build file '..\NeoGradle\build.gradle': external process started 'C:\Program Files\Git\cmd\git.exe config --system --edit'
  See https://docs.gradle.org/8.1.1/userguide/configuration_cache.html#config_cache:requirements:external_processes

See the complete report at file:///P:/NeoForged/Kits/build/reports/configuration-cache/7ps9o5erkpl6t981o4yz3hrbw/1hejolm1ijf0s3ovodo726hot/configura
tion-cache-report.html
> Starting an external process 'C:\Program Files\Git\cmd\git.exe --version' during configuration time is unsupported.
> Starting an external process 'C:\Program Files\Git\cmd\git.exe config --system --edit' during configuration time is unsupported.

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 6m 45s

mental carbon Oct 22, 2023, 5:59 PM

#

@stray scroll Did you not fix this?

stray scroll Oct 22, 2023, 6:00 PM

#

thonk very weird

mental carbon Oct 22, 2023, 6:00 PM

#

fallow sundial ``` FAILURE: Build failed with an exception. * Where: Build file 'P:\NeoForged\...

How are you getting this

#

We are not using gradleutils at the moment

mental carbon Oct 22, 2023, 6:00 PM

#

stray scroll <:thonk:932605815221788672> very weird

We are not using gradleutils anywhere at the moment in kits

#

Ah it is NG

fallow sundial Oct 22, 2023, 6:00 PM

#

by running setup. it's failing NG

mental carbon Oct 22, 2023, 6:00 PM

#

Hold on a hot minute

#

That is why I don't get the error

#

I have it precompiled

#

@stray scroll Please publish a new GU version!

#

I forgot that you disabled building

stray scroll Oct 22, 2023, 6:02 PM

#

uh, that will have to wait since there's still going to be breaks 👀

mental carbon Oct 22, 2023, 6:02 PM

#

See and that is why I don't like manual builds........

stray scroll Oct 22, 2023, 6:03 PM

#

you don't like people not wanting to push out unfinished versions of projects...?

#

(yes, I am strawmanning a bit, but that's the reason why I've not enabled automatic builds here)

mental carbon Oct 22, 2023, 6:06 PM

#

stray scroll you don't like people not wanting to push out unfinished versions of projects......

This version works, and is finished, yes your next commit breaks, but right now we need to wait for you to consider this ready,......... Eventhough what we need from it is already there

#

But meh

drowsy condor Oct 22, 2023, 6:12 PM

#

Sorry if I am a bit late to the party, but what are the supposed post release networking changes

#

tl;dr would be great

prime quest Oct 22, 2023, 6:14 PM

#

https://github.com/FabricMC/fabric/pull/3244

GitHub

[1.20.2] Support common registration packets. Add configuration tas...

There is more! The original port was very rough, this is hopefully a better longer term solution!
Common channel registration packets
Previously we sent the play packet channels in a custom packet ...

stray scroll Oct 22, 2023, 6:14 PM

#

do you mean networking in general, behind the scenes? or the networking APIs which you, as a mod developer, will use

drowsy condor Oct 22, 2023, 6:15 PM

#

prime quest https://github.com/FabricMC/fabric/pull/3244

So you are planning to port over fabric's work if I am understanding correctly?

prime quest Oct 22, 2023, 6:16 PM

#

it's more that we (neo and fabric) created this to be a shared standard, but they happened to release before us :p

#

you can call it porting, but it's more that we agreed beforehand to both do this anyway

drowsy condor Oct 22, 2023, 6:18 PM

#

prime quest it's more that we (neo and fabric) created this to be a shared standard, but the...

Oh yeah I've read it in the PR now, it's great that fabric and neoforge can find some common ground

frail oriole Oct 22, 2023, 6:22 PM

#

Hmmm

#

@mental carbon still not buildable 😦

#

is the configuration cache problem supposed to kill the build?

#

it seems that is the cause

#

it's trying to run the git command line here

#

        at org.gradle.configurationcache.initialization.DefaultConfigurationCacheProblemsListener.onExternalProcessStarted(ConfigurationCacheProblemsListener.kt:87)

fallow sundial Oct 22, 2023, 6:29 PM

#

well the test framework is fully ported to 1.20.2

#

that was quick and painless

frail oriole Oct 22, 2023, 6:29 PM

#

good

#

i still seem to be crashing face first into a bunch of NG problems sadly 😦

fallow sundial Oct 22, 2023, 6:29 PM

#

i'll push to a new branch

mental carbon Oct 22, 2023, 6:36 PM

#

frail oriole is the configuration cache problem supposed to kill the build?

It errors out the build, but the task still succeeds

#

We are waiting for sci

frail oriole Oct 22, 2023, 6:36 PM

#

no worries

kindred hatchBOT Oct 22, 2023, 6:37 PM

#

oriononline

[Reference ➤ ](#1136320550168436798 message)@stray scroll Please publish a new GU version!

mental carbon Oct 22, 2023, 6:37 PM

#

Basically GU is on manual builds

frail oriole Oct 22, 2023, 6:37 PM

#

guess getting a local build isn't gonna happen for a minute

mental carbon Oct 22, 2023, 6:37 PM

#

Sure it is

#

Just run the build command

#

And ignore the error

frail oriole Oct 22, 2023, 6:37 PM

#

it fails

mental carbon Oct 22, 2023, 6:37 PM

#

The error only happens after the task completes

frail oriole Oct 22, 2023, 6:37 PM

#

no. it fails

mental carbon Oct 22, 2023, 6:37 PM

#

Log?

frail oriole Oct 22, 2023, 6:37 PM

#

sure. gimme a minute.

fallow sundial Oct 22, 2023, 6:38 PM

#

fallow sundial well the test framework is fully ported to 1.20.2

now for the fun-er part. testing if it works

frail oriole Oct 22, 2023, 6:39 PM

#

https://gist.github.com/cpw/72f8e7ea4c3b4bc96ee51c65358c6aff

#

it always fails at that line

#

note that building NG itself works

mental carbon Oct 22, 2023, 6:39 PM

#

Don't run clean

#

Can you run build

#

With -s

#

?

frail oriole Oct 22, 2023, 6:39 PM

#

why is clean broken?

mental carbon Oct 22, 2023, 6:40 PM

#

I actually don't know

frail oriole Oct 22, 2023, 6:40 PM

#

100 errors
20 warnings
only showing the first 100 errors, of 14492 total; use -Xmaxerrs if you would like to see more

> Task :neoforge:compileJava FAILED

mental carbon Oct 22, 2023, 6:40 PM

#

Funny enough

frail oriole Oct 22, 2023, 6:40 PM

#

hmmm

mental carbon Oct 22, 2023, 6:40 PM

#

running it twice works

frail oriole Oct 22, 2023, 6:40 PM

#

it is not working very well

mental carbon Oct 22, 2023, 6:40 PM

#

frail oriole ``` 100 errors 20 warnings only showing the first 100 errors, of 14492 total; us...

wtf...

#

Which branch are you on

frail oriole Oct 22, 2023, 6:41 PM

#

1.20.2

#

and NG_7.0

mental carbon Oct 22, 2023, 6:41 PM

#

Okey

#

Did you run setup?

#

And reimport?

frail oriole Oct 22, 2023, 6:41 PM

#

no. 1. this is cmd line, not in idea

mental carbon Oct 22, 2023, 6:41 PM

#

Ah okey

frail oriole Oct 22, 2023, 6:41 PM

#

you told me to run build, not clean 😛

mental carbon Oct 22, 2023, 6:41 PM

#

Okey

#

Let me test

frail oriole Oct 22, 2023, 6:41 PM

#

because my usual process is clean -> setup -> assemble

#

that's how this has been for a long time

mental carbon Oct 22, 2023, 6:42 PM

#

Yeah

frail oriole Oct 22, 2023, 6:42 PM

#

if clean fails, then it's assumed everything else if fucked too

mental carbon Oct 22, 2023, 6:42 PM

#

WTF

#

I have the same error

#

ls

frail oriole Oct 22, 2023, 6:42 PM

#

clean does not work "second time" for me btw

mental carbon Oct 22, 2023, 6:44 PM

#

Okey, the only way to solve this is when I can take a look at what you are doing

#

This is weird AF

frail oriole Oct 22, 2023, 6:44 PM

#

1 minute

fallow sundial Oct 22, 2023, 6:46 PM

#

thinkies

#

@mental carbon can I add another mod project as a runtime dep of the tests project. I tried implementation project(':testframework') but it doesn't work thinkies

#

is there another configuration or something

#

well this is annoying but somewhat expected

#

the idea run config doesn't work but the gradle task does

kindred fractal Oct 22, 2023, 6:58 PM

#

mental carbon

Did you fix patch generation then?

mental carbon Oct 22, 2023, 6:59 PM

#

Yes

#

Was trivial

#

But it is still broken

#

Because I need to interpolate the shell scripts still

#

Which is annoying but doable

kindred fractal Oct 22, 2023, 7:00 PM

#

What? The processor steps are wrong you mean?

mental carbon Oct 22, 2023, 7:00 PM

#

No

#

When I generate the installer jar in NG

#

I don't interpolate the tokens in the template scripts

kindred fractal Oct 22, 2023, 7:01 PM

#

Client did work though

#

(it installs and runs)

#

Is this broken now? The issue might just be with the server setup somewhere else

mental carbon Oct 22, 2023, 7:10 PM

#

No only dedicated server is

#

Somehow:

#

That section is not working

kindred fractal Oct 22, 2023, 7:18 PM

#

might have a look tomorrow

mental carbon Oct 22, 2023, 7:19 PM

#

WTF The filter is just not invoked

#

I could puke

fallow sundial Oct 22, 2023, 7:29 PM

#

catjam

fallow sundial Oct 22, 2023, 7:31 PM

#

fallow sundial the idea run config doesn't work but the gradle task does

this is quite annoying tho

mental carbon Oct 22, 2023, 7:32 PM

#

fallow sundial this is quite annoying tho

What is the error?

fallow sundial Oct 22, 2023, 7:33 PM

#

there's no error

#

the project simply isn't being detected as a mod because of the whole modsources shit

mental carbon Oct 22, 2023, 7:33 PM

#

Did you reimport?

mental carbon Oct 22, 2023, 7:34 PM

#

fallow sundial the project simply isn't being detected as a mod because of the whole modsources...

Show me your buildscript changes

#

Also server somewhat launching:

fallow sundial Oct 22, 2023, 7:34 PM

#

mental carbon Oct 22, 2023, 7:34 PM

#

fallow sundial

That is weird that that works with gradle at all

fallow sundial Oct 22, 2023, 7:34 PM

#

it's not

mental carbon Oct 22, 2023, 7:34 PM

#

You need to add it as a modSource

#

It is

#

Or actually no

#

It is not

#

Because it is on the CP

fallow sundial Oct 22, 2023, 7:34 PM

#

when ran by gradle it's got from the classpath, which contains the compiled jar

mental carbon Oct 22, 2023, 7:35 PM

#

Yeah when you run it with IDEA

#

It is a directory on the CP

#

So it is skipped by the locator

kindred fractal Oct 22, 2023, 7:35 PM

#

mental carbon Also server somewhat launching:

yeah just update what you generate

fallow sundial Oct 22, 2023, 7:35 PM

#

yay for cursedness

mental carbon Oct 22, 2023, 7:35 PM

#

Add it as a modSource

kindred fractal Oct 22, 2023, 7:35 PM

#

I changed forgeVersion and mcpVersion to what the argparser is complaining about

mental carbon Oct 22, 2023, 7:35 PM

#

And it will work @fallow sundial

#

You did not update the args.txt file XD

kindred fractal Oct 22, 2023, 7:36 PM

#

the what file? concern

mental carbon Oct 22, 2023, 7:36 PM

#

#

I will fix it

kindred fractal Oct 22, 2023, 7:36 PM

#

oh... didn't know it existed heh

fallow sundial Oct 22, 2023, 7:36 PM

#

kindred fractal the what file? <:concern:932605815318278205>

the annoying file

#

the args.txt file is the bane of forge's server existence

mental carbon Oct 22, 2023, 7:37 PM

#

We can generate it.....

#

We do it for the client

fallow sundial Oct 22, 2023, 7:38 PM

#

Can only transition State of build 'NeoGradle' to state BuildFinishHooks from states [Configure, TaskSchedule, ReadyToRun] however it is currently in state ReadyToReset. wat now

mental carbon Oct 22, 2023, 7:38 PM

#

WTF

#

That is new

#

#

@kindred fractal

fallow sundial Oct 22, 2023, 7:39 PM

#

i think i'll get rid of the includebuild locally and use mvnlocal, this is a PITA

mental carbon Oct 22, 2023, 7:40 PM

#

Please yes

mossy bobcat Oct 22, 2023, 7:41 PM

#

includeBuild and modding have never played nice

fallow sundial Oct 22, 2023, 7:41 PM

#

Calculating task graph as configuration cache cannot be reused because init script '......C:Users\rober\AppData\Local\Temp\ijMapper1.gradle' and
 1 more have been removed.```
 thanks IJ, love you too

fallow sundial Oct 22, 2023, 7:42 PM

#

mossy bobcat includeBuild and modding have never played nice

includeBuild ~~and modding~~ have never played nice

#

composite builds are always hell

mossy bobcat Oct 22, 2023, 7:43 PM

#

It's alright until you want, I dunno, weird things like working IDE integration or whatnot

fallow sundial Oct 22, 2023, 7:43 PM

#

weird things like working IDE integration

#

Task 'GameTest' is ambiguous in project ':tests'. Candidates are: 'GameTest ClientIdeBeforeRun', 'GameTest ServerIdeBeforeRun'. hwat

#

i'll just push to a new branch and go to bed, the more i look at it the worse it gets

kindred fractal Oct 22, 2023, 8:37 PM

#

includeBuild worked fine for me

kindred fractal Oct 22, 2023, 8:37 PM

#

mental carbon

Niiiiice!

mental carbon Oct 22, 2023, 8:39 PM

#

kindred fractal Niiiiice!

It is actually bugged

#

It crashes right there

dull bison Oct 22, 2023, 8:40 PM

#

mental carbon <@213343613583622144> you around?

I was pinged? Orion do you still need me?

kindred fractal Oct 22, 2023, 8:51 PM

#

mental carbon It crashes right there

I'll figure it out

fallow sundial Oct 23, 2023, 4:09 PM

#

why is there a task named GameTest ClientIdeBeforeRun with a space thonk

kindred fractal Oct 23, 2023, 4:12 PM

#

see my NG PR for gametest

#

I have it working locally

#

do you want to be running gametests?

fallow sundial Oct 23, 2023, 4:15 PM

#

kindred fractal see my NG PR for gametest

thinkies how does that fix it

dull bison Oct 23, 2023, 4:16 PM

#

fallow sundial <:thinkies:980924387333115914> how does that fix it

magic ... how else do you think, it's gradle

fallow sundial Oct 23, 2023, 4:16 PM

#

stab

kindred fractal Oct 23, 2023, 4:19 PM

#

alright pushed it for you 😛

#

tbh the space is another issue

#

CreateLauncherJson is failing now what

kindred fractal Oct 23, 2023, 5:20 PM

#

and the installer assets are now broken

#

let's try to get back to the NG_7.0 branch first and see if I need to fix the runs there too

#

yeah I do

#

gametest server doesn't actually run a gametest server?

#

alright it was my fault 😄

kindred fractal Oct 23, 2023, 5:59 PM

#

now userdev is broken

#

feels like playing whack a mole

#

ok it was my NG changes

rich void Oct 23, 2023, 6:32 PM

#

sounds like a fun time here xD

kindred fractal Oct 23, 2023, 6:40 PM

#

yeah....

mental carbon Oct 23, 2023, 6:41 PM

#

kindred fractal `CreateLauncherJson` is failing now what

What?

kindred fractal Oct 23, 2023, 6:41 PM

#

it was the assetIndex -> assets rename... NG branch has it

#

ok now the assetsIndex is incorrect in the launcher json

mental carbon Oct 23, 2023, 6:42 PM

#

?"?

#

I did that because I derped

kindred fractal Oct 23, 2023, 6:43 PM

#

no I mean this:

#

"assetIndex":{} yeah...

mental carbon Oct 23, 2023, 6:44 PM

#

Why is that there?!?

#

Am I setting it somewhere

kindred fractal Oct 23, 2023, 6:45 PM

#

the serialization deserialization roundtrip messes it up I think?

mental carbon Oct 23, 2023, 6:45 PM

#

It shouldn't

#

It only writes when the property is set

#

And only sets the property if the field is present

kindred fractal Oct 23, 2023, 6:47 PM

#

mental carbon Oct 23, 2023, 6:47 PM

#

Shit

#

I am setting it

kindred fractal Oct 23, 2023, 6:47 PM

#

shouldn't this be convention ?

mental carbon Oct 23, 2023, 6:47 PM

#

Am I

#

Well no

#

Because I need to set it

#

Because of the stupid shell handling

kindred fractal Oct 23, 2023, 6:49 PM

#

idk, it should be inherited from in the actual launcher

mental carbon Oct 23, 2023, 6:49 PM

#

Yeah

#

It should not write the values if the object is empty

kindred fractal Oct 23, 2023, 6:50 PM

#

I think the assetindex is empty but the property is obviously set

#

so convention might fix it

#

(at least for that field)

mental carbon Oct 23, 2023, 6:50 PM

#

No

#

Because convention won't work on the script

#

I think

#

@dull bison Did we ever merge Mixin support?

mental carbon Oct 23, 2023, 7:04 PM

#

kindred fractal so `convention` might fix it

Checking now

mossy bobcat Oct 23, 2023, 7:04 PM

#

mental carbon <@213343613583622144> Did we ever merge Mixin support?

I'm not sure there's anything needed now that runtime Mojmaps are a thing - the AP at least isn't needed

mental carbon Oct 23, 2023, 7:04 PM

#

There is

feral moat Oct 23, 2023, 7:04 PM

#

mental carbon <@213343613583622144> Did we ever merge Mixin support?

https://github.com/neoforged/NeoGradle/pull/9

mental carbon Oct 23, 2023, 7:04 PM

#

We have an open PR for it

kindred fractal Oct 23, 2023, 7:06 PM

#

it just adds the MixinConfigs manifest entry and the --mixin.config run flag apparently

mental carbon Oct 23, 2023, 7:06 PM

#

Yeah

#

It is just a QoL thingy

#

It also provides debugging mappings I think

#

Even though they are just passthrough

kindred fractal Oct 23, 2023, 7:07 PM

#

not sure what that does

#

BTW for NG7 publishing the TC config is still being sourced from the FG_6.0 branch so it didn't update the git revs

dull bison Oct 23, 2023, 7:08 PM

#

mental carbon <@213343613583622144> Did we ever merge Mixin support?

I'm gonna rebase and retarget and then we can merge it

mental carbon Oct 23, 2023, 7:10 PM

#

Perfect

mental carbon Oct 23, 2023, 7:12 PM

#

kindred fractal so `convention` might fix it

Convention does not work

#

Sadly

#

If a convention is set

#

Then the property technically is not empty

#

Okey fixed

#

@kindred fractal Pull and rebuild the json

kindred fractal Oct 23, 2023, 7:16 PM

#

Ok thanks, I'll be on the move for ~30 mins then I'll check

kindred fractal Oct 23, 2023, 7:16 PM

#

mental carbon Then the property technically is not empty

Disappointing

dull bison Oct 23, 2023, 7:18 PM

#

mental carbon Perfect

done

mossy bobcat Oct 23, 2023, 7:20 PM

#

mental carbon Then the property technically is not empty

Can you make the property @Optional and orElse when you retrieve it?

#

Assuming it's a gradle property that is

mental carbon Oct 23, 2023, 7:23 PM

#

mossy bobcat Can you make the property `@Optional` and orElse when you retrieve it?

No sadly not

#

It is a conflict between GDI and Out serialization code

feral moat Oct 23, 2023, 7:25 PM

#

is there potentially some fix that can be made in GDI to make it play nicer?

mental carbon Oct 23, 2023, 7:27 PM

#

Not really

#

Well with a lot of work maybe

kindred fractal Oct 23, 2023, 7:29 PM

#

Groovy magic not working with other kinds of groovy magic is a well-known problem 😛

dull bison Oct 23, 2023, 7:29 PM

#

mixin is ready (it is still missing automated tests tho)

mossy bobcat Oct 23, 2023, 7:29 PM

#

kindred fractal Groovy magic not working with other kinds of groovy magic is a well-known proble...

stabolb this is gradle magic, not groovy magic

mental carbon Oct 23, 2023, 7:30 PM

#

No it is actually groovy 😄

mossy bobcat Oct 23, 2023, 7:30 PM

#

Well, groovy magic in gradle

dull bison Oct 23, 2023, 7:30 PM

#

GDI is groovy

mossy bobcat Oct 23, 2023, 7:31 PM

#

Ah yeah, I see what you mean.

kindred fractal Oct 23, 2023, 7:31 PM

#

Btw do we need checkAts, checkExcs etc back?

mental carbon Oct 23, 2023, 7:33 PM

#

Some for sure

#

But I don't want them in Forge nor NG7

#

I want them in like a "StyleChecker" addon plugin

#

That does most

#

checkExcs can go

#

Not sure about checkPatches

#

Personally I would suggest we setup a formatter

#

And run that over the decompiled source

kindred fractal Oct 23, 2023, 7:35 PM

#

I think the style in the patches isn't too relevant

#

Maybe not worth more build complexity

#

Some task to validate ATs against a MC jar should exist in NG imo

quiet talon Oct 23, 2023, 7:38 PM

#

Does the excs file even exist anymore now that moj is everything?

kindred fractal Oct 23, 2023, 7:38 PM

#

It's for param names apparently so yes

#

We still need to add parchment support to forgedev heh

#

Obviously not before the release

kindred fractal Oct 23, 2023, 8:02 PM

#

@mental carbon prod client works again!

mental carbon Oct 23, 2023, 8:13 PM

#

Goo d:D

kindred fractal Oct 23, 2023, 8:17 PM

#

server crash was just the eula

#

idk why it doesn't appear in the logs

#

I think the log4j config is fucked

mental carbon Oct 23, 2023, 8:18 PM

#

Interesting

#

Possible

kindred fractal Oct 23, 2023, 8:31 PM

#

there's a ton of log markers scattered all over the place, blergh

kindred fractal Oct 23, 2023, 9:07 PM

#

apparently jarjar is pulling in an old version of slf4j

kindred fractal Oct 23, 2023, 9:23 PM

#

fixed!

#

installing thus works in all configurations 🙂

#

tomorrow I'll continue with the class renames then

mental carbon Oct 24, 2023, 6:26 PM

#

@kindred fractal :

Did you do any renames, which you have not yet pushed already?
Are you tracking your renames somewhere?

kindred fractal Oct 24, 2023, 6:30 PM

#

Didn't have time today, I don't have anything locally

#

Put them here: https://hackmd.io/@neoforged/rJtC7ucZT

HackMD

1.20.2 package changes - HackMD

List of repackages:

#

The todo list has a high level breakdown already

mental carbon Oct 24, 2023, 6:56 PM

#

Very nice! 😄

#

Thank you

mental carbon Oct 24, 2023, 9:22 PM

#

Initial pass done

#

About 20 are still open for renaming tomorrow

kindred fractal Oct 25, 2023, 6:57 AM

#

Nice

#

Do we want to prevent import changes in patches again?

mental carbon Oct 25, 2023, 7:01 AM

#

We can easily fix those later

#

There is an option in the IDE

kindred fractal Oct 25, 2023, 7:33 AM

#

yeah ofc - we can probably add a spotless rule for this

#

it won't autofix sadly

mental carbon Oct 25, 2023, 7:34 AM

#

Probably

#

I would really like to have like a styling system for the patches

#

That we can run after they are decompiled

#

On both NeoForm as well as NeoForge

#

To get a decently looking setup

#

And something that is easier for everybody

kindred fractal Oct 25, 2023, 7:36 AM

#

hmmm I wonder how that can be checked nicely

#

cause honestly we could tell people to follow standard java style in the patches and autoformat the normal forge source code

mental carbon Oct 25, 2023, 8:01 AM

#

We just need to agree on a specific format

#

And then find a formatter that gradle can work with

kindred fractal Oct 25, 2023, 8:03 AM

#

we should use spotless as the formatter, IMO, it is very nice

#

format will be a bit of a bikeshed 😄

mental carbon Oct 25, 2023, 8:04 AM

#

The actuall formatter is not relevant

#

As long as it can do a format

#

Yeah it will be

mossy bobcat Oct 25, 2023, 8:07 AM

#

Ah, spotless, having annoying caches that stop it from running since... I don't actually know when. But yeah, it's well known and commonly used for a reason

#

I had an idea for patches a while back I may poke if I have some free time; basically, I suspect it's possible to make a tool that automatically "inlines" added imports while making them patches, before making them, or after the fact depending on what ends up being most sensible

mental carbon Oct 25, 2023, 8:09 AM

#

I am not sure the IDEs can deal with spotless

mossy bobcat Oct 25, 2023, 8:10 AM

#

mental carbon I am not sure the IDEs can deal with spotless

Pretty sure intellij has a plugin, but if you want bear guaranteed ide integration you can go with checkstyle

mental carbon Oct 25, 2023, 8:10 AM

#

Oke so intelliJ and VSCode plugins exist

#

How about Eclipse?

mossy bobcat Oct 25, 2023, 8:10 AM

#

No clue. Eclipse isn't known for being compatible with stuff

#

But spotless is pretty common so it would surprise me if there isn't a plugin

#

Besides that, you don't necessarily need one - you can list violations and fix some of them with the relevant gradle tasks

#

Besides spotless and checkstyle, not sure what's out there

kindred fractal Oct 25, 2023, 8:21 AM

#

spotless uses the eclipse formatter so eclipse better support it

#

even then, you just do gradlew spotlessApply to fix style

mossy bobcat Oct 25, 2023, 8:23 AM

#

And hope that spotless's caches aren't so fucked up that that does nothing

kindred fractal Oct 25, 2023, 8:25 AM

#

I've been using spotless for years and don't remember this happening so /shrug

mental carbon Oct 25, 2023, 8:25 AM

#

I will do some research

mossy bobcat Oct 25, 2023, 8:27 AM

#

kindred fractal I've been using spotless for years and don't remember this happening so /shrug

"works on your machine" isn't "works on every machine". I killed gradle mid task once (accidently, was running through IntelliJ and it OOMed), and the cache was so fucked I wasn't able to run spotless afterwards. Not sure I ever did figure out where the heck it shoved that cache in order to clear it out

#

Or rather, I'd run spotless and it would tell me everything was fine when it definitely wasn't. Had to watch the CI output and fix violations manually

kindred fractal Oct 25, 2023, 8:29 AM

#

yes but it's also the 5th time you bring it up and it's getting old 😛

mental carbon Oct 25, 2023, 8:30 AM

#

My idea is that the system:

Applies the format to the decompiler output so that we can properly have comparative patches
Runs a check using a ratchetOffset to validate that a PR has the correct formatting

mossy bobcat Oct 25, 2023, 8:30 AM

#

And I'm going to bring it up every time spotless is recommended. Never had any issues with checkstyle

kindred fractal Oct 25, 2023, 8:31 AM

#

checkstyle doesn't autoformat so that's immediately a nope for me

mental carbon Oct 25, 2023, 8:31 AM

#

We need a formatter

#

Not a checker

mossy bobcat Oct 25, 2023, 8:31 AM

#

kindred fractal checkstyle doesn't autoformat so that's immediately a nope for me

thinkies you just import it into your IDE and then it does

tranquil salmon Oct 25, 2023, 8:32 AM

#

mental carbon My idea is that the system: 1) Applies the format to the decompiler output so th...

So I am going to need to redo all the neoform patches a second time?

kindred fractal Oct 25, 2023, 8:32 AM

#

you just run a formatter on them 😛

mossy bobcat Oct 25, 2023, 8:33 AM

#

I assume it would apply post neoform patches

#

Because otherwise you're assuming the formatter can format possibly invalid code

mental carbon Oct 25, 2023, 8:33 AM

#

tranquil salmon So I am going to need to redo all the neoform patches a second time?

No NG7 will run that

mossy bobcat Oct 25, 2023, 8:33 AM

#

Which seems iffy, though maybe fine as it's probably fine syntax wise

kindred fractal Oct 25, 2023, 8:35 AM

#

the intellij checkstyle plugin doesn't handle all checkstyle rules unfortunately

mossy bobcat Oct 25, 2023, 8:38 AM

#

It covers most of the ones likely to actually pop up in practice

#

That are difficult to fix at least

kindred fractal Oct 25, 2023, 8:39 AM

#

mental carbon No NG7 will run that

I'm just wary of shoving more things into NG

#

do we really need to autoformat the patches

mossy bobcat Oct 25, 2023, 8:39 AM

#

And with any good style guide, there's going to be rules an auto formatter can't sensibly fix

kindred fractal Oct 25, 2023, 8:40 AM

#

usually patches are quite small... sure some people might forget a space like if(...) but it's not the end of the world

mossy bobcat Oct 25, 2023, 8:40 AM

#

kindred fractal do we really need to autoformat the patches

Given that patch style has a lot of tricks you do differently from normal (not indenting a block when you've wrapped it in a conditional, for instance) I'd say no

kindred fractal Oct 25, 2023, 8:40 AM

#

yeah very true

mossy bobcat Oct 25, 2023, 8:43 AM

#

But the formatter/style guide debate is going to be bikeshedded to oblivion no matter what; luckily we can shove the worst of it in https://discord.com/channels/313125603924639766/1131782966989828156

kindred fractal Oct 25, 2023, 8:44 AM

#

I don't think anyone would object to standard java code style

#

import order etc I don't care about

mossy bobcat Oct 25, 2023, 8:44 AM

#

kindred fractal I don't think anyone would object to standard java code style

You want to fight out the same-line-vs-newline brackets battle?

#

Someone will disagree on either direction there

#

Same as they currently do with whether to keep the I prefix on interfaces

#

Let's see what will cause debate:

bracket position
use of var
I prefix on interfaces
tabs vs spaces
Yeah suffice to say I'm glad there's a dedicated channel for it

kindred fractal Oct 25, 2023, 8:46 AM

#

I prefix will definitely stay

#

bracket position falls under standard java code style

mossy bobcat Oct 25, 2023, 8:47 AM

#

If you're keeping "standard Java code style" you'd yeet the I prefix too...

kindred fractal Oct 25, 2023, 8:47 AM

#

yes but that is an exception because we have so much code using the I prefix already, and changing it is really pointless

mossy bobcat Oct 25, 2023, 8:48 AM

#

We have tons of code with newline brackets too

kindred fractal Oct 25, 2023, 8:48 AM

#

changing that doesn't affect mods

mossy bobcat Oct 25, 2023, 8:48 AM

#

(note that I'm in favor of switching brackets; I just think the fact that it's standard doesn't mean anything if you're not applying that consistently)

mossy bobcat Oct 25, 2023, 8:49 AM

#

kindred fractal changing that doesn't affect mods

Ah, so all new interfaces should have no prefix and we should slowly switch existing ones over whenever they're broken for other reasons?

#

Also, "standard Java style guide" unfortunately could mean a lot of different things

#

Doesn't google's style guide still recommend 2-space indentation or something?

kindred fractal Oct 25, 2023, 8:50 AM

#

meh I don't know you're trying to start a debate when there clearly isn't one...

mossy bobcat Oct 25, 2023, 8:50 AM

#

What's clear to you isn't clear to everyone

#

I'd say it's clear that neo should yeet the I prefix

kindred fractal Oct 25, 2023, 8:51 AM

#

what is clear to me is that the port shouldn't be delayed because of pointless debating

mossy bobcat Oct 25, 2023, 8:52 AM

#

kindred fractal what is clear to me is that the port shouldn't be delayed because of pointless d...

That was literally my point and yet you started bikeshedding about whether or not there would be bikeshedding for some reason. The formatting discussion should probably all go in https://discord.com/channels/313125603924639766/1131782966989828156 because if you make it part of the 20.2 port you'll never release

stray scroll Oct 25, 2023, 9:00 AM

#

mossy bobcat Doesn't google's style guide still recommend 2-space indentation or something?

sounds about right, at least from my recollections from trying to write a Forge code style guide based from that

kindred fractal Oct 25, 2023, 9:06 AM

#

we need the code to be formatted before the port, otherwise we'll disrupt all PRs again

mossy bobcat Oct 25, 2023, 9:17 AM

#

If you want to get through all the various style debates before having a 20.2 port... you're going to be waiting a bit

#

Easiest is to just leave it in the current style for now

#

Enforce style on some future version switch

#

(heck, you could make breaking changes like removing I from interfaces then too if you wanted!)

kindred fractal Oct 25, 2023, 12:23 PM

#

maybe we could write a custom intellij plugin for patch import changes 😄

mossy bobcat Oct 25, 2023, 12:25 PM

#

Custom IntelliJ plugin? That would be hell. Much easier to process the files before generating patches with something that can inline added imports

#

(custom IntelliJ plugins are really awful to write. Ask maty)

kindred fractal Oct 25, 2023, 12:26 PM

#

in theory it just has to diff the import section between the neoforge and base projects

mossy bobcat Oct 25, 2023, 12:27 PM

#

kindred fractal in theory it just has to diff the import section between the `neoforge` and `bas...

Oh sure, if it's a checker yeah. I was thinking something that lets you write the patches however you'd like and inlines the imports when the patch is generated

#

But a checker is simpler

kindred fractal Oct 25, 2023, 12:30 PM

#

the most annoying thing is unused import removals - IDEs like to remove unused imports

fallow sundial Oct 25, 2023, 12:35 PM

#

mossy bobcat (custom IntelliJ plugins are really awful to write. Ask maty)

concurd

rich void Oct 25, 2023, 1:12 PM

#

https://www.minecraft.net/en-us/article/test-new-decorative-blocks related to today's snapshot I think

dull bison Oct 25, 2023, 1:18 PM

#

ohno it snapshot day again

arctic sphinx Oct 25, 2023, 1:19 PM

#

Yep

arctic sphinx Oct 25, 2023, 1:19 PM

#

rich void https://www.minecraft.net/en-us/article/test-new-decorative-blocks related to to...

Mostly related to last weeks iirc

mossy bobcat Oct 25, 2023, 1:23 PM

#

kindred fractal the most annoying thing is unused import removals - IDEs like to remove unused i...

Yeah something like I'd proposed would deal with that, and with star imports and all that stuff

rich void Oct 25, 2023, 1:33 PM

#

arctic sphinx Mostly related to last weeks iirc

that was just the crafter last week :)

kindred fractal Oct 25, 2023, 1:33 PM

#

mossy bobcat Yeah something like I'd proposed would deal with that, and with star imports and...

I am looking for something simple that solves the practical problems we have

#

automatically adjusting code to fix imports etc sounds too complicated

rich void Oct 25, 2023, 1:35 PM

#

kindred fractal the most annoying thing is unused import removals - IDEs like to remove unused i...

do u want unused imports to stay?

kindred fractal Oct 25, 2023, 1:35 PM

#

they have to be added back if the IDE removed them, yes

rich void Oct 25, 2023, 1:37 PM

#

why do they need to be added back if you don't use them?

#

(just wondering why)

lean warren Oct 25, 2023, 1:42 PM

#

Because removing them would create unnecessary patch lines

rich void Oct 25, 2023, 1:44 PM

#

If u say so xD

kindred fractal Oct 25, 2023, 1:45 PM

#

you don't seem to understand...

#

the point is that the .patch files are source code patches and can thus contain import changes if we are not careful

dull bison Oct 25, 2023, 1:49 PM

#

we'd need a gradle task that replaces any imports that were added with fqns and replaces the imports block with the original before creating the patches

kindred fractal Oct 25, 2023, 1:49 PM

#

I don't know if changing the source code is that trivial

#

I would prefer a task that just replaced the import block, then you can check if it still compiles

#

many renames...

wise forge Oct 25, 2023, 1:53 PM

#

It might be with the clean and Forge version, though I think there's also an edge case I can't remember

mossy bobcat Oct 25, 2023, 2:14 PM

#

kindred fractal I don't know if changing the source code is that trivial

With spoon, it's actually pretty easy

mossy bobcat Oct 25, 2023, 2:15 PM

#

dull bison we'd need a gradle task that replaces any imports that were added with fqns and ...

That's exactly what I'm proposing, yeah

#

And spoon has the sorts of tools we'd want for this, in theory

arctic sphinx Oct 25, 2023, 2:57 PM

#

<@&1067092163520909374>
https://www.minecraft.net/en-us/article/minecraft-snapshot-23w43a
https://mdcfe.dev/mc-changes?ver=23w43a

#

(The blog post just went live)

fallow sundial Oct 25, 2023, 2:59 PM

#

TICK COMMAND
Added a new tick command. This is an adminstative and debugging command that allowsto control the ticking flow and measure the performance of the game.The command requires elevated permissions (admins and above) and so it is not by default available in command blocks and datapacks.

rich void Oct 25, 2023, 3:00 PM

#

new bat model?

stray scroll Oct 25, 2023, 3:00 PM

#

hmm, the properties of that Copper Bulb block kinda reads like a light-emitting T-flip flop to me

#

toggles on or off on a pulse, and a comparator reads full power when its on

dull bison Oct 25, 2023, 3:01 PM

#

stray scroll hmm, the properties of that Copper Bulb block kinda reads like a light-emitting ...

because it is

rich void Oct 25, 2023, 3:01 PM

#

Mojang has confirmed that, yes

dull bison Oct 25, 2023, 3:01 PM

#

a 2 block T-flip-flop

stray scroll Oct 25, 2023, 3:02 PM

#

did I miss that part of Minecraft Live kek

#

...probably

dull bison Oct 25, 2023, 3:03 PM

#

fallow sundial > TICK COMMAND > Added a new tick command. This is an adminstative and debugging...

OMG tick freeze

#

and tick step <time>

arctic sphinx Oct 25, 2023, 3:03 PM

#

Looks like Gnembon pulled in Carpet mod

rich void Oct 25, 2023, 3:04 PM

#

stray scroll did I miss that part of Minecraft Live <:kek:1134098707869073408>

it was something they told creators privately, but someone on YT made a video about it

dull bison Oct 25, 2023, 3:04 PM

#

arctic sphinx Looks like Gnembon pulled in Carpet mod

yep

lean warren Oct 25, 2023, 3:04 PM

#

The tick command sounds amazing

daring ginkgo Oct 25, 2023, 3:04 PM

#

arctic sphinx Looks like Gnembon pulled in Carpet mod

Yeah that was my thought exactly

stray scroll Oct 25, 2023, 3:04 PM

#

i'm curious how they implemented that command thinkies

arctic sphinx Oct 25, 2023, 3:04 PM

#

daring ginkgo Yeah that was my thought exactly

~~next snapshot the fake players?~~

tacit vale Oct 25, 2023, 3:05 PM

#

That's crazy

#

I never thought the day would come where vanilla would have Carpet

lean warren Oct 25, 2023, 3:06 PM

#

stray scroll i'm curious how they implemented that command <:thinkies:932605814995292192>

Time to blow the snow off 😄

tacit vale Oct 25, 2023, 3:06 PM

#

I bet they already had this command for a while for internal testing but didn't release it until now, probably with more polish

arctic sphinx Oct 25, 2023, 3:06 PM

#

tacit vale I never thought the day would come where vanilla would have Carpet

~~Smh they've had it since 1.6.1~~

fallow sundial Oct 25, 2023, 3:06 PM

#

still no more work on block types abolbsad

tacit vale Oct 25, 2023, 3:06 PM

#

the way they said "This is very useful for testing time sensitive gameplay elements" and stuff like that is just an example of why they probably had this beforehand

fallow sundial Oct 25, 2023, 3:06 PM

#

the properties codec is still unit(::of)

arctic sphinx Oct 25, 2023, 3:08 PM

#

lean warren Time to blow the snow off 😄

I looked at snowman and was like wtf is it on 1.16.5 harold , I didn't realise we recreate the whole repo

fallow sundial Oct 25, 2023, 3:08 PM

#

hm

dull bison Oct 25, 2023, 3:08 PM

#

for those with snowman access: https://github.com/neoforged/Snowman/commit/0d803382c65127e8e1292ccc6fb4e11e0c1aa965

tacit vale Oct 25, 2023, 3:15 PM

#

arctic sphinx I looked at snowman and was like wtf is it on 1.16.5 <:harold:932605815406342174...

Only if something became incompatible

#

It shouldn't have

#

Cuz nothing changed this time

#

It shoulda been just a new commit

lethal bane Oct 25, 2023, 3:15 PM

#

Does /tick freeze actually freeze most/all ticks?

fallow sundial Oct 25, 2023, 3:16 PM

#

tacit vale It shoulda been just a new commit

it wasn't

stable zephyr Oct 25, 2023, 3:20 PM

#

How can someone get snowman access 👀

rich void Oct 25, 2023, 3:21 PM

#

rich void new bat model?

looks very cute now

lethal bane Oct 25, 2023, 3:22 PM

#

stable zephyr How can someone get snowman access 👀

You can run snowblower locally

stable zephyr Oct 25, 2023, 3:23 PM

#

Can I get the link for it?

arctic sphinx Oct 25, 2023, 3:23 PM

#

stable zephyr How can someone get snowman access 👀

Become a Maintainer

Or if you want to run a local copy then it's generated via https://github.com/MinecraftForge/Snowblower this tool

stable zephyr Oct 25, 2023, 3:24 PM

#

Thx

wise forge Oct 25, 2023, 3:25 PM

#

fallow sundial > TICK COMMAND > Added a new tick command. This is an adminstative and debugging...

This sounds...interesting, and also a fun time when dealing with people who make mods that have changes on the same tick or between one tick

dull bison Oct 25, 2023, 3:35 PM

#

what happend to snowman?

#

the bot just nuked everything since february

arctic sphinx Oct 25, 2023, 3:46 PM

#

concern

#

I'm seeing up to 23w12a (March)

#

There's a Snowblower run still going, it looks like it triggered multiple times?

dull bison Oct 25, 2023, 3:51 PM

#

I think it is rebuilding everything since february

arctic sphinx Oct 25, 2023, 3:52 PM

#

Something for someone who knows TC to poke harold

dull bison Oct 25, 2023, 3:57 PM

#

looks like technician did something

lethal bane Oct 25, 2023, 3:59 PM

#

tc blame squirrelhat

daring ginkgo Oct 25, 2023, 4:24 PM

#

arctic sphinx ~~next snapshot the fake players?~~

👀

#

what if they just add carpet mod without any of the feature gamerules

rich void Oct 25, 2023, 4:34 PM

#

I would really like movable tile entities

#

and the chain link

#

which I think are part of carpet

#

so would be nice

tacit vale Oct 25, 2023, 10:07 PM

#

fallow sundial it wasn't

Why not, wut

tranquil salmon Oct 25, 2023, 10:47 PM

#

bat animations got moved to the net.minecraft.client.animation.definitions package

#

the checkbox gui component got a builder

#

mojang added a total of 53 blocks in this snapshot with 40 of those being related to copper

fallow sundial Oct 26, 2023, 4:40 AM

#

tacit vale Why not, wut

idk, I just know it recreated the entire repo twice

tranquil salmon Oct 26, 2023, 5:24 AM

#

The TeamcityTestReporter class has been removed

gaunt breach Oct 26, 2023, 5:27 AM

#

so where's the AzureDevOpsTestReporter

tranquil salmon Oct 26, 2023, 5:41 AM

#

nowhere currently, there is only the JUnitLikeTestReporter and LogTestReporter remaining

gaunt breach Oct 26, 2023, 6:08 AM

#

ah fun

mental carbon Oct 26, 2023, 6:29 AM

#

I did not understand why they had that in the first place

#

I mean, TeamCity properly processes the JUnitLike anyway

stray scroll Oct 26, 2023, 3:53 PM

#

i would assume the TC reporter came first, then the JUnit one came afterwards
and only now did someone have enough time to switch out the TC one with the JUnit one

arctic sphinx Oct 27, 2023, 1:31 PM

#

<@&1067092163520909374>
https://www.minecraft.net/en-us/article/minecraft-snapshot-23w43b
https://mdcfe.dev/mc-changes?ver=23w43b

dull bison Oct 27, 2023, 1:31 PM

#

what! again

arctic sphinx Oct 27, 2023, 1:31 PM

#

Looks like a couple of crash fixes according to the blogpost

#

Snowman commit https://github.com/neoforged/Snowman/commit/b7ddd363031e4b4f052ceaf0ddf6af59eb80e6ff

#

2 changes of Files.createDirectories to FileUtil.createDirectoriesSafe
A move of a setScreen call in RealmsConfigureWorldScreen
Plus changing a getMillis to a getNanos in the MinecraftServer, looks like they just missed it when they did the rest of those changes for the tick stuff

kindred fractal Oct 27, 2023, 1:56 PM

#

I wonder if they enjoy changing the structure files for every update kekw

fallow sundial Oct 27, 2023, 1:59 PM

#

that's automated more than certainly

kindred fractal Oct 27, 2023, 1:59 PM

#

of course but it seems like such a waste

vapid ledge Oct 27, 2023, 5:30 PM

#

fallow sundial that's automated more than certainly

The snbt to nbt converter in the data generators does run the DFU. (but only if the structure is in the minecraft namespace)

kindred fractal Oct 27, 2023, 7:30 PM

#

class renames are done

#

next up resources

kindred fractal Oct 27, 2023, 9:57 PM

#

ID/resource renaming done hopefully

kindred fractal Oct 27, 2023, 10:26 PM

#

@velvet plover updated zip ^

dull bison Oct 27, 2023, 10:31 PM

#

I don't think it is a good idea to post this publicly

kindred fractal Oct 27, 2023, 10:34 PM

#

meh idk... better not just in case

mental carbon Oct 28, 2023, 7:10 AM

#

Don't

#

There is a strict policy in place to not share kits with outsiders

kindred fractal Oct 28, 2023, 9:06 AM

#

any reasons besides not sharing MC source code?

inland mesa Oct 28, 2023, 9:07 AM

#

IMO, no

#

that's the whole reason to have a private repo

#

in forge we did the whole porting in the private repo until it was ready for public release but IMO that's unnecessary

#

as soon as the patches can do a successful round-trip, the mc sources should be removed and the code should be moved to a public porting branch

#

but I think some people from the team would prefer to keep it private so that users don't start building from the porting repo then running into issues and reporting them.... when the code is still being ported and those issues would have been resolved by the time it was released

dull bison Oct 28, 2023, 9:39 AM

#

tech shouldn't the licensing stuff be in the forge subproject

kindred fractal Oct 28, 2023, 9:41 AM

#

see the first commit - it needs a bit of a hack for the licenser

#

and spotless actually needs the sources to be in the project's tree so I figured we could put license and spotless in the root project

dull bison Oct 28, 2023, 1:09 PM

#

NG7 mixin support verified in production

kindred fractal Oct 28, 2023, 1:12 PM

#

excellent

mental carbon Oct 28, 2023, 2:34 PM

#

Perfect

kindred fractal Oct 29, 2023, 11:47 AM

#

remapping script is ready

mental carbon Oct 29, 2023, 11:48 AM

#

Okey

#

So tehre is one thing still on my plate:

#

Check the publishing system for NG7 UserDev

#

We should not be leaking our custom dependencies into that

kindred fractal Oct 29, 2023, 11:49 AM

#

ah yeah that would indeed be annoying

mental carbon Oct 29, 2023, 11:50 AM

#

Ng6 had this issue

#

So what we need is to figure out how to deal with it

kindred fractal Oct 29, 2023, 11:51 AM

#

is this a blocker?

#

also, if it's just the neoforge dependency... couldn't we exclude just that from the pom?

mental carbon Oct 29, 2023, 11:54 AM

#

Yeah we can rip it from the pom

#

Or replace it with something that makes sense

kindred fractal Oct 29, 2023, 11:55 AM

#

there is also schurli's mixin support PR for you to look into

mental carbon Oct 29, 2023, 11:57 AM

#

Yep

#

That is a blocker for sure

mossy bobcat Oct 29, 2023, 1:03 PM

#

mental carbon Yeah we can rip it from the pom

Can we like, not do it that way? That means you can't easily publish the module metadata and is generally a hacky way to go about it, I would say. Is it possible instead to shove the dependencies in question in a configuration that is on runtimeClasspath and compileClasspath but not runtimeElements or compileElements?

#

That's how I solve the issue for GroovyDuvet's weirdness at least

mental carbon Oct 29, 2023, 1:04 PM

#

mossy bobcat Can we like, not do it that way? That means you can't easily publish the module ...

That is not possible.

NG7 simply provides a dependency, it would be up to you to implement such a system.

Due note: This was already not possible in NG6 it is as such no regression, and without some way of cleaning of the POM using published maven metadata would break fg.deobf, and would still break fg.deobf

mossy bobcat Oct 29, 2023, 1:05 PM

#

mental carbon That is not possible. NG7 simply provides a dependency, it would be up to you t...

Which configuration does it put the dependency in? That's my question. I don't see why this isn't possible

kindred fractal Oct 29, 2023, 1:05 PM

#

well the user does implementation <neoforge>

mental carbon Oct 29, 2023, 1:05 PM

#

mossy bobcat Which configuration does it put the dependency _in_? That's my question. I don't...

It puts it where ever the user tells it to

mossy bobcat Oct 29, 2023, 1:06 PM

#

So why don't we just provide a configuration with those properties I specified ?

mental carbon Oct 29, 2023, 1:06 PM

#

If that is implementation then it is that, if it is api or some other sourceset name then it will be that

mossy bobcat Oct 29, 2023, 1:06 PM

#

All they have to do is put it in that configuration and it'll be excluded from the pom and module metadata

mental carbon Oct 29, 2023, 1:06 PM

#

mossy bobcat So why don't we just provide a configuration with those properties I specified ?

Why do we need to?

mossy bobcat Oct 29, 2023, 1:07 PM

#

mental carbon Why do we need to?

Because if we do, then all they have to do is put neoforge in that and suddenly this isn't an issue and there's nothing to hackily clean out of the pom

mental carbon Oct 29, 2023, 1:07 PM

#

Actually that does not work

#

Because even if I recreate the minecraft classpath

#

It would then be up to every single user to put that configuration where they need it to

#

And then to declare a dependency in that configuration to have it setup minecraft

#

Additionally this would result in the configuration still being part of the resolveable runtime classpath in the pom / module data

mossy bobcat Oct 29, 2023, 1:09 PM

#

mental carbon Additionally this would result in the configuration still being part of the reso...

I'm saying NG can do this: ```gradle
configurations {
implementationPrivate
runtimeClasspath.extendsFrom implementationPrivate
compileClasspath.extendsFrom implementationPrivate
}

The runtime classpath in the pom or module metadata _doesnt come from `runtimeClasspath`_. It comes from `runtimeElements`

mental carbon Oct 29, 2023, 1:10 PM

#

mossy bobcat I'm saying NG can do this: ```gradle configurations { implementationPrivate ...

Yeah no

#

Cause that would be terrible in cases where people have multiple sourcesets

#

Or any configurations where it goes across more then one project

kindred fractal Oct 29, 2023, 1:10 PM

#

would it be? people would still get the dependency via the classpaths

mental carbon Oct 29, 2023, 1:11 PM

#

kindred fractal would it be? people would still get the dependency via the classpaths

As to what is that question targetted?

#

To my statement that it is terrible in multi sourceset or multi project setups? Yes

#

It is terrible

#

The whole point of NG7 is to not do any of that what so ever

#

And to treat Forge / Minecraft as a normal dependency

#

Yes I need to check what I can do about the Maven publishing

mossy bobcat Oct 29, 2023, 1:12 PM

#

Then I'd argue you shouldn't strip stuff from the pom either

kindred fractal Oct 29, 2023, 1:12 PM

#

well it is not quite a normal dependency, so we have to choose where we put the special handling for it

mental carbon Oct 29, 2023, 1:12 PM

#

mossy bobcat Then I'd argue you shouldn't strip stuff from the pom either

We have been doing that for years!

mossy bobcat Oct 29, 2023, 1:12 PM

#

The proper way to avoid publication of a dependency is what I've described

mental carbon Oct 29, 2023, 1:12 PM

#

It just needs to be readded

#

or enabled

#

If needed

mossy bobcat Oct 29, 2023, 1:12 PM

#

mental carbon We have been doing that for years!

Yes, and it's a hacky mess and bad practice all around, and it prevents the use of the module metadata!

kindred fractal Oct 29, 2023, 1:12 PM

#

I don't know much, but wouldn't it be better to not add a dependency in the first place VS removing it after the fact?

mossy bobcat Oct 29, 2023, 1:13 PM

#

kindred fractal I don't know much, but wouldn't it be better to not add a dependency in the firs...

Which is what I'm describing, yes

mental carbon Oct 29, 2023, 1:13 PM

#

kindred fractal I don't know much, but wouldn't it be better to not add a dependency in the firs...

The problem is that "not adding it" is not really something NG7 is designed to do.

#

Simply said: NG7 simply adds the dependency to what ever it is told to

#

It is as simple as that

mossy bobcat Oct 29, 2023, 1:13 PM

#

It's something gradle is designed to do

mental carbon Oct 29, 2023, 1:13 PM

#

If luke wants to use the pattern above, that is perfectly fine

#

He is more then welcome to do so

kindred fractal Oct 29, 2023, 1:14 PM

#

we could put it in the mdk if we wanted to

mental carbon Oct 29, 2023, 1:14 PM

#

NG7 is not putting a single thing in his or her way

mossy bobcat Oct 29, 2023, 1:14 PM

#

mental carbon Simply said: NG7 simply adds the dependency to what ever it is told to

See we just provide people with those configurations by default so not every single mod is reimplementing them

mental carbon Oct 29, 2023, 1:14 PM

#

kindred fractal we could put it in the mdk if we wanted to

Yes that is something I would suggest

mental carbon Oct 29, 2023, 1:14 PM

#

mossy bobcat See we just provide people with those configurations by default so not every sin...

Sorry no. Because that is not our job

kindred fractal Oct 29, 2023, 1:14 PM

#

mossy bobcat See we just provide people with those configurations by default so not every sin...

there's an argument to be made against magic configurations, IMO

mossy bobcat Oct 29, 2023, 1:14 PM

#

mental carbon NG7 is not putting a single thing in his or her way

No, besides your hacky pom stripping logic that you want to add. As long as that's opt in or trivial to disable I suppose it's fine

mental carbon Oct 29, 2023, 1:14 PM

#

Yeah we are not going back to magic configurations

kindred fractal Oct 29, 2023, 1:14 PM

#

we don't need pom stripping if we tell people to use a separate configuration

mental carbon Oct 29, 2023, 1:14 PM

#

mossy bobcat No, besides your hacky pom stripping logic that you want to add. As long as that...

It always has been an opt in.....

mossy bobcat Oct 29, 2023, 1:15 PM

#

Good. As long as we don't have the MDK having to opt out of default NG behavior in order to do this the right way

kindred fractal Oct 29, 2023, 1:15 PM

#

speaking of MDK someone has to update it 😅

#

I'll write the blog post this afternoon

mossy bobcat Oct 29, 2023, 1:16 PM

#

The other option is to strip it on dependency resolve from the runtimeElements and compileElements configurations. That... gets a bit funkier

mossy bobcat Oct 29, 2023, 1:17 PM

#

kindred fractal there's an argument to be made against magic configurations, IMO

I'd argue this isn't a magic annotation any more than the api annotation added by java-library, or indeed any of the implementation or compileOnly configurations are. After all, this is just doing the same thing, just exposing a new configuration, xyzImplementationPrivate, for each source set

kindred fractal Oct 29, 2023, 1:18 PM

#

configurations are quite confusing if you're not familiar with them IMO

mossy bobcat Oct 29, 2023, 1:18 PM

#

That implementation has no special behavior besides being extended by the relevant classpath stuff

mossy bobcat Oct 29, 2023, 1:18 PM

#

kindred fractal configurations are quite confusing if you're not familiar with them IMO

So we're going to expose all that configuration creation in the MDK instead?

kindred fractal Oct 29, 2023, 1:19 PM

#

we could, with some comments to explain what is happening I think it would be sensible

mossy bobcat Oct 29, 2023, 1:19 PM

#

I guess in the end I don't really care as long as the MDK doesn't use hacky pom stripping, and, importantly, as long as we encourage people to start actually publishing useful module metadata which nobody can currently do

mental carbon Oct 29, 2023, 1:20 PM

#

So right now, I am going to be hones: Gradle Module data is not supported by NG7

#

And that will stay for now

mossy bobcat Oct 29, 2023, 1:20 PM

#

mental carbon So right now, I am going to be hones: Gradle Module data is not supported by NG7

I don't see why not?

mental carbon Oct 29, 2023, 1:20 PM

#

Because right now there are issues with the dynamic dependencies

mossy bobcat Oct 29, 2023, 1:21 PM

#

If people use the approach I'm describing there's literally nothing else that needs done for the dependencies to not show up there

mental carbon Oct 29, 2023, 1:21 PM

#

mossy bobcat If people use the approach I'm describing there's literally nothing else that ne...

Except that the versioning data is not working

#

Because right now the module data can generate wrongly if it is used in a multi sourceset or multi project setup

mossy bobcat Oct 29, 2023, 1:21 PM

#

mental carbon Except that the versioning data is not working

For what? Mods? That'll be all that's in the module metadata

mental carbon Oct 29, 2023, 1:21 PM

#

So right now we severely discourage modders from publishing gradle metadata in the first place

mental carbon Oct 29, 2023, 1:22 PM

#

mossy bobcat For what? Mods? That'll be all that's in the module metadata

No for for example the forge dynamic dependency!

mossy bobcat Oct 29, 2023, 1:22 PM

#

Oh, cross project dependencies you mean

mental carbon Oct 29, 2023, 1:23 PM

#

Yes

mossy bobcat Oct 29, 2023, 1:23 PM

#

Those work fine unless people aren't doing fuckery with base.archivesName or the like, and as long as they follow gradle good practice and make their project version and the version of their publication the same, which they really ought to be

mental carbon Oct 29, 2023, 1:23 PM

#

mossy bobcat Those work fine unless people aren't doing fuckery with base.archivesName or the...

Yeah but like you might actually be the only one that is doing "good" gradle practices

mossy bobcat Oct 29, 2023, 1:23 PM

#

The base archives name one is still fairly hard to break

mental carbon Oct 29, 2023, 1:23 PM

#

And as such

kindred fractal Oct 29, 2023, 1:24 PM

#

well we should encourage best practices if we can

mental carbon Oct 29, 2023, 1:24 PM

#

We should

kindred fractal Oct 29, 2023, 1:24 PM

#

NG7 is already a big step towards that

mossy bobcat Oct 29, 2023, 1:24 PM

#

mental carbon Yeah but like you might actually be the only one that is doing "good" gradle pra...

We should encourage people to follow good gradle practices, instead of ripping out a whole gradle system just because most people don't

mental carbon Oct 29, 2023, 1:24 PM

#

But we should also not turn ourselves in a twist to make features possible which can be done on a later date when gradle gets its head out of its arse!

kindred fractal Oct 29, 2023, 1:24 PM

#

luke I don't think anyone wants to not follow them

mossy bobcat Oct 29, 2023, 1:24 PM

#

And if they know enough gradle to write multiproject build systems, they can figure out how to do good practice

kindred fractal Oct 29, 2023, 1:24 PM

#

but we also don't have infinite time

mossy bobcat Oct 29, 2023, 1:24 PM

#

kindred fractal luke I don't think anyone wants to not follow them

No, it's a matter of not knowing what they are in many cases

kindred fractal Oct 29, 2023, 1:25 PM

#

mossy bobcat And if they know enough gradle to write multiproject build systems, they can fig...

that's quite a bold assumption you're making sadly

mental carbon Oct 29, 2023, 1:25 PM

#

IMHO I am for now going to do the POM cleanup

#

Cause I have the code

#

Know the concequences

#

And can trivially test it

#

The configuration setup can be added later as a better work around

mossy bobcat Oct 29, 2023, 1:25 PM

#

Can't NG just not touch the module metadata at all?

kindred fractal Oct 29, 2023, 1:25 PM

#

yeah let's do that for now

mossy bobcat Oct 29, 2023, 1:25 PM

#

Multiproject builds that don't want it can disable it themselves

mental carbon Oct 29, 2023, 1:25 PM

#

mossy bobcat Can't NG just not touch the module metadata at all?

No that is its whole fucking point!

#

It literally takes in your modules dependency data

#

And finds stuff it needs to replace with dynamic dependencies

#

If you do not like it

#

Then sorry but there is no way to setup the MC and Forge dependencies

mossy bobcat Oct 29, 2023, 1:26 PM

#

mental carbon No that is its whole fucking point!

Multiproject builds that don't want it can disable it themselves
Unless you're saying NG breaks with it in single or source set scenarios?

mental carbon Oct 29, 2023, 1:27 PM

#

NG Does not break in those scenarios

#

But that was a comment on your: "Can't NG just not touch the module metadata at all?" statement

#

Hell NG does not break at all if you just clean the damn pom

mossy bobcat Oct 29, 2023, 1:27 PM

#

mental carbon But that was a comment on your: "Can't NG just not touch the module metadata at ...

Then cool, multiproject setups can themselves disable the module metadata publication

mental carbon Oct 29, 2023, 1:27 PM

#

One way or another

#

So summary

#

Right now I noted lukes suggestion

#

But I decided not to follow it for the current implementation iteration

#

And research its concequences later on

kindred fractal Oct 29, 2023, 1:29 PM

#

👍

mossy bobcat Oct 29, 2023, 1:29 PM

#

Basically, as long as this all is configurable, and NG doesn't rip out the system entirely so I can still publish this stuff and we can encourage others to by having it published correctly in the MDK. I'm fine with it. I don't expect it to work by default in weird multiproject scenarios, as it wouldn't in base gradle either

mental carbon Oct 29, 2023, 1:29 PM

#

Of note: His requested configuration setup, can dynamically be generated based on the requested setup, however it does require a significant amount of testing, and will need a decent set of unit tests to cover the basics

#

Which I have no time to write or create right now

mossy bobcat Oct 29, 2023, 1:29 PM

#

Yeah, that can always be something to poke later. No big deal

mental carbon Oct 29, 2023, 1:30 PM

#

Again: The data published by gradle in its module file will always be broken unless you apply the fix you just suggested

#

Given that for now that won't be the default behaviour

#

We will keep on suggesting to not publish gradle module metadata, and will enable the cleaning by default

mossy bobcat Oct 29, 2023, 1:30 PM

#

mental carbon Again: The data published by gradle in its module file will always be broken unl...

Yes, once again, fine with that because it's true of the pom too unless you enable pom stripping

mental carbon Oct 29, 2023, 1:30 PM

#

Given that the cleaning only happens on the POM

#

And that it is not mutually exclusive with your configuration approach

#

It can be enabled by default without further issues

#

And without further intervention of a modder

mossy bobcat Oct 29, 2023, 1:31 PM

#

mental carbon We will keep on suggesting to not publish gradle module metadata, and will enabl...

Once again, can we not enable cleaning on the pom by default? Because the MDK should be doing this correctly, and that means not using the pom stripping properties and using configurations instead

#

(even if like Tech suggested those are set up in the MDK)

mental carbon Oct 29, 2023, 1:32 PM

#

The definition of correctly is what I just set within the context of NG7

#

For now doing this correctly means that it should just work with maven metadata

#

Regardless of the configuration used by the modder

mossy bobcat Oct 29, 2023, 1:32 PM

#

The MDK should promote gradle good practice

#

Gradle good practice here is to do this via a configuration

mental carbon Oct 29, 2023, 1:33 PM

#

Since that has been the preminition under NG4+, was the preminition when we implemented the cleaning under NG6, does not interfere with people using the weird configuration setup, and does not interfere with gradle module data

#

In other words, it is the most compatible setup, as of speaking

mossy bobcat Oct 29, 2023, 1:33 PM

#

And to publish the module metadata. If other projects want to not do that and NG provides tools to do it other ways easily - I see no issue with that, do long as the MDK is doing it the good practice way

mental carbon Oct 29, 2023, 1:33 PM

#

mossy bobcat Gradle good practice here is to do this via a configuration

It is also the most complicated setup, which is not something I feel comfortable with putting in the MDK as of right now, if we have support for this better later down the line I will revisit that opinion

mossy bobcat Oct 29, 2023, 1:34 PM

#

mental carbon It is also the most complicated setup, which is not something I feel comfortable...

It's a trivial setup. You make one configuration, and you add the dependency to that

mental carbon Oct 29, 2023, 1:34 PM

#

For you it is trivial

#

The behaviour of runtimeElements is only known to most experienced modders, if they even know it.

And given that they can deal with this themselves. I see no reason for now to make the MDK more complicated just because of the fact that it is the "right"/"correct" way of doing this in gradle.

mossy bobcat Oct 29, 2023, 1:36 PM

#

Is the NG 7 branch public? I'm willing to PR behavior to add that configuration to every source set

mental carbon Oct 29, 2023, 1:36 PM

#

Again we are not accepting magic configuration management as of now

mossy bobcat Oct 29, 2023, 1:36 PM

#

If it means the MDK publishing module metadata

mossy bobcat Oct 29, 2023, 1:37 PM

#

mental carbon Again we are not accepting magic configuration management as of now

It's not a magic configuration. Magic configurations are what loom uses. This one literally just is extended by a subset of the configurations implementation is

mental carbon Oct 29, 2023, 1:37 PM

#

Again not right now

#

We will revisit this on a later date

#

And then I am happy to figure this out properly

mossy bobcat Oct 29, 2023, 1:40 PM

#

You're saying that even though we know how to solve this, and even though said solution is all of 5 lines of code, we're going to stick with a hacky definitely-not-good-practice solution and encourage modders to do the same? Okay then, as long as I understand your stance on this right

mental carbon Oct 29, 2023, 1:47 PM

#

For now yes,

fallow sundial Oct 30, 2023, 3:48 PM

#

have we updated all deps we've transformed to neo?

#

and if so, someone should give ATs and coremods a bump because I updated antrl and nashorn

mental carbon Oct 30, 2023, 3:51 PM

#

@kindred fractal can you take care of that before you sign of?

kindred fractal Oct 30, 2023, 3:51 PM

#

yeah

#

alright fixed the beta warning hehe

rich void Oct 30, 2023, 3:59 PM

#

really awesome to see all the progress towards neoforge 20.2, looks like it is really close.
||just a bit annoying for me, since I am about to get into a testweek xD||

stray scroll Oct 30, 2023, 4:03 PM

#

kek

dull bison Oct 30, 2023, 4:05 PM

#

@mental carbon signing off on 20.2
everything that is left is for the public repo

mental carbon Oct 30, 2023, 4:07 PM

#

Ok. Thank you.

stray scroll Oct 30, 2023, 4:08 PM

#

🎉

#

closer and closer we go, bois

dull bison Oct 30, 2023, 4:11 PM

#

we just missing techs signoff and orions approval

kindred fractal Oct 30, 2023, 4:12 PM

#

updated the todo list for the last few tasks

#

@mental carbon I'm signing off on 20.2 too - I can handle the blog post whenever you ping me to, I'll be around

frigid bolt Oct 30, 2023, 4:16 PM

#

Super excited to finally see this (almost!) cross the finish line! 😄
Big congrats to all the team during what I'm sure has been a very stressfull time 😄

dull bison Oct 30, 2023, 4:16 PM

#

@frozen vapor @long cobalt How's the porting guide?

frozen vapor Oct 30, 2023, 4:17 PM

#

harold

long cobalt Oct 30, 2023, 4:17 PM

#

yeah I agree with Monica

frozen vapor Oct 30, 2023, 4:17 PM

#

I have some free time later today so I can work on it

dull bison Oct 30, 2023, 4:18 PM

#

you two have 3 hours /s

frozen vapor Oct 30, 2023, 4:18 PM

#

panicBasket

mental carbon Oct 30, 2023, 4:19 PM

#

kindred fractal <@304594425286361088> I'm signing off on 20.2 too - I can handle the blog post w...

Okey had to quickly jump to the supermarket to get dinner and then I will finish this up

#

@kindred fractal did you add gu3 to kits?

kindred fractal Oct 30, 2023, 4:20 PM

#

yes

mental carbon Oct 30, 2023, 4:20 PM

#

Perfect I saw the commit come in

#

Just wanted dtoncheck

mental carbon Oct 30, 2023, 5:02 PM

#

Eating dinner then we will release 😄

fallow sundial Oct 30, 2023, 5:07 PM

#

did you feed the release too

mental carbon Oct 30, 2023, 5:09 PM

#

Well not yet

#

But I will now

#

In voice

#

So lets do this

glass ferry Oct 30, 2023, 5:12 PM

#

vote on how badly something will break during release yortfuckinhaw

stray scroll Oct 30, 2023, 5:17 PM

#

glass ferry vote on how badly something will break during release <:yortfuckinhaw:9379346826...

pls no 🤞

frigid bolt Oct 30, 2023, 5:17 PM

#

Shh, it'll be fine, totally totally totally

shell torrent Oct 30, 2023, 5:18 PM

#

um...

glass ferry Oct 30, 2023, 5:19 PM

#

yes

fallow sundial Oct 30, 2023, 5:20 PM

#

glass ferry vote on how badly something will break during release <:yortfuckinhaw:9379346826...

my answer is "yes"

glass ferry Oct 30, 2023, 5:20 PM

#

orion leaves the server the second 1.20.2 appears on the site

kindred fractal Oct 30, 2023, 5:20 PM

#

we have an entire team that can fix issues 😉

#

I'll watch but only loosely; no sound or mic 😛

shell torrent Oct 30, 2023, 5:21 PM

#

It may contain bugs that are difficult to identify.

#

🤞

glass ferry Oct 30, 2023, 5:22 PM

#

life contains bugs that are difficult to identify

#

ioa

prime quest Oct 30, 2023, 5:22 PM

#

you ever tried identifying a bug?

glass ferry Oct 30, 2023, 5:22 PM

#

i have

prime quest Oct 30, 2023, 5:22 PM

#

they're creepy

dull bison Oct 30, 2023, 5:23 PM

#

tech do you want to do your capabilities stuff first or do you want to wait for the registries?

inland mesa Oct 30, 2023, 5:23 PM

#

https://tenor.com/view/spongebob-spongebob-meme-tiny-kitchen-sponge-bob-tiny-kitchen-burger-gif-25042540

Tenor

scenic radish Oct 30, 2023, 5:23 PM

#

https://tenor.com/view/eww-bugs-eww-bugs-ew-ew-bugs-gif-20566522

Tenor

glass ferry Oct 30, 2023, 5:23 PM

#

mosquitos existing is a bug in earth's source code

kindred fractal Oct 30, 2023, 5:23 PM

#

dull bison tech do you want to do your capabilities stuff first or do you want to wait for ...

we can work on them in parallel

#

I'll happily review registries but not do most of the work there

shell torrent Oct 30, 2023, 5:25 PM

#

glass ferry mosquitos existing is a bug in earth's source code

I confirm

inland mesa Oct 30, 2023, 5:25 PM

#

has anyone prepared a guide on how to move from FG5 to NG7? because all my projects are fg5 still :V

stray scroll Oct 30, 2023, 5:25 PM

#

can't wait for the big bug squash

dull bison Oct 30, 2023, 5:26 PM

#

kindred fractal we can work on them in parallel

so caps first since it just needs rebase (and maybe a few touch ups) and regs need a bit of additional work

kindred fractal Oct 30, 2023, 5:26 PM

#

maybe yeah - caps will need a lot of review

dull bison Oct 30, 2023, 5:27 PM

#

kindred fractal maybe yeah - caps will need a lot of review

so will regs

kindred fractal Oct 30, 2023, 5:27 PM

#

true true

frigid bolt Oct 30, 2023, 5:32 PM

#

shell torrent It may contain bugs that are difficult to identify.

for me, I'm just waiting for something I can build with, since I have full intention to have NeoForge supported in CraftPresence day-one once they pull the trigger on releasing.
Plus, there's not much Neo could break that would also break CraftPresence (I'd be impressed if CraftPresence did break in Neo)

shell torrent Oct 30, 2023, 5:38 PM

#

lul

kindred fractal Oct 30, 2023, 5:39 PM

#

already removed

shell torrent Oct 30, 2023, 5:39 PM

#

k

glass ferry Oct 30, 2023, 5:50 PM

#

how many issues so far

#

like 3?

#

someone needs to count

#

ioa

kindred fractal Oct 30, 2023, 5:52 PM

#

nothing bad so far 😛

glass ferry Oct 30, 2023, 5:53 PM

#

can't access discord voice, proxy moment agony

stray scroll Oct 30, 2023, 6:09 PM

#

i excitedly wait for 20.2 to release

#

if only so I can start making PRs kek

fallow sundial Oct 30, 2023, 6:38 PM

#

@kindred fractal i love how you haven't made us coauthors of the 1.20.2 commit stabolb

stray scroll Oct 30, 2023, 6:39 PM

#

kekw

fallow sundial Oct 30, 2023, 6:39 PM

#

thanks for caring about us

dull bison Oct 30, 2023, 6:40 PM

#

not cool tech

shell torrent Oct 30, 2023, 6:40 PM

#

Is there no longer a 1.20.1 branch?

glass ferry Oct 30, 2023, 6:41 PM

#

TeamCity thinks that the build will take 48m

lean warren Oct 30, 2023, 6:43 PM

#

shell torrent Is there no longer a 1.20.1 branch?

Nope, but it's trivial to make one from the last commit before the 1.20.2 port if it turns out to be needed

fallow sundial Oct 30, 2023, 6:43 PM

#

dull bison not cool tech

i move we kick him

#

he commited a serious crime

nova sundial Oct 30, 2023, 6:43 PM

#

that just means he takes all the git blame now harold

glass ferry Oct 30, 2023, 6:44 PM

#

true

shell torrent Oct 30, 2023, 6:44 PM

#

lean warren Nope, but it's trivial to make one from the last commit before the 1.20.2 port i...

btw, you can now fix all Forge's rendering bugs, (just kidding, take your time)

glass ferry Oct 30, 2023, 6:44 PM

#

run this on the entire repo with tech

#

https://github.com/jayphelps/git-blame-someone-else

GitHub

GitHub - jayphelps/git-blame-someone-else: Blame someone else for y...

Blame someone else for your bad code. Contribute to jayphelps/git-blame-someone-else development by creating an account on GitHub.

stray scroll Oct 30, 2023, 6:51 PM

#

@mental carbon once the build finishes, are we clear for PR takeoff

mental carbon Oct 30, 2023, 6:51 PM

#

Yes

kindred fractal Oct 30, 2023, 6:51 PM

#

lmao

kindred fractal Oct 30, 2023, 6:51 PM

#

fallow sundial <@298082405745426433> i love how you haven't made us coauthors of the 1.20.2 com...

yeah sorry I only thought about it much later 😅

#

@mental carbon I can update the blogpost

#

remember to update the timestamps

glass ferry Oct 30, 2023, 6:56 PM

#

Build finished

kindred fractal Oct 30, 2023, 6:57 PM

#

remember to update the timestamp for the blog posts

knotty harness Oct 30, 2023, 6:57 PM

#

public build complete, does that mean we can start porting our mods?

kindred fractal Oct 30, 2023, 6:57 PM

#

and eventbus is still a draft

prime quest Oct 30, 2023, 6:57 PM

#

if you can figure out how, yes lol

#

remember: major redesign.

#

treat it like a new modlauncher

#

with no documentation 🙈

kindred fractal Oct 30, 2023, 6:58 PM

#

there's the updated MDK

mossy bobcat Oct 30, 2023, 6:58 PM

#

prime quest if you can figure out how, yes lol

Sounds like a challenge to me. The MDK exists, right?

prime quest Oct 30, 2023, 6:58 PM

#

yes

#

also keep in mind most of the changes are yet to come - we wanted to keep the git history and changelogs completely clear as to what we're doing

mossy bobcat Oct 30, 2023, 6:58 PM

#

thinkies and this happens right as I have a bunch of work to do. Ah well, Biome Squisher will be released tomorrow instead I guess

prime quest Oct 30, 2023, 6:58 PM

#

so it's, uhhh

#

chaos!

true pivot Oct 30, 2023, 6:58 PM

#

wait there's no 1.20.1 branch?

prime quest Oct 30, 2023, 6:59 PM

#

there will be one if we need it

#

but not right now no

true pivot Oct 30, 2023, 6:59 PM

#

harold

mental carbon Oct 30, 2023, 6:59 PM

#

We use the same versioning strategy for the branches so 1.20.x is the curretn

dull bison Oct 30, 2023, 6:59 PM

#

knotty harness public build complete, does that mean we can start porting our mods?

not really because now is the breaking changes window so your mods will break if you port now

kindred fractal Oct 30, 2023, 7:00 PM

#

you can start porting but expect a few changes still

mossy bobcat Oct 30, 2023, 7:00 PM

#

might break. Depends how much of it is just mixins

glass ferry Oct 30, 2023, 7:00 PM

#

trolley if your entire mod is mixins, no update can break your mod

mossy bobcat Oct 30, 2023, 7:00 PM

#

You'd be surprised. Patches and mixins conflict in unexpected ways at times

arctic sphinx Oct 30, 2023, 7:01 PM

#

Patches can change the bytecode quite a bit in areas

#

(Lambda names are another one)

stray scroll Oct 30, 2023, 7:01 PM

#

time to setup my local dev workspace

arctic sphinx Oct 30, 2023, 7:01 PM

#

Also we may remove your target if for example we add an event in place

feral moat Oct 30, 2023, 7:02 PM

#

sad having to port a PR that doesn't touch vanilla code because of the class renames screm

kindred fractal Oct 30, 2023, 7:02 PM

#

we need an announcement now

feral moat Oct 30, 2023, 7:02 PM

#

though it was expected

dull bison Oct 30, 2023, 7:02 PM

#

mossy bobcat _might_ break. Depends how much of it is just mixins

no in case of the changes we have pending it is will not might

mossy bobcat Oct 30, 2023, 7:02 PM

#

I'll try to port my resource grouping changes PR in the next couple or so

mossy bobcat Oct 30, 2023, 7:03 PM

#

dull bison no in case of the changes we have pending it is will not might

You still have changes that'll affect every vanilla class mixing target pending?

dull bison Oct 30, 2023, 7:03 PM

#

mossy bobcat You still have changes that'll affect every vanilla class mixing target pending?

no but most mods will break

mossy bobcat Oct 30, 2023, 7:04 PM

#

Yeah, that's fair. Anything using registries for one

stray scroll Oct 30, 2023, 7:04 PM

#

@mental carbon what's the task to setup the workspace again

kindred fractal Oct 30, 2023, 7:04 PM

#

gradlew setup

stray scroll Oct 30, 2023, 7:04 PM

#

oh right, the subproject name changed

feral moat Oct 30, 2023, 7:04 PM

#

tech your murdering of forge for navor forge has failed us: https://github.com/neoforged/NeoForge/pull/178. Though I should probably comment on that PR to also change the tag as apparently capitalization matters

stray scroll Oct 30, 2023, 7:05 PM

#

gonna be a while to strange forge: outta my muscle memory

kindred fractal Oct 30, 2023, 7:05 PM

#

feral moat tech your murdering of forge for navor forge has failed us: <https://github.com/...

I'm sure there's 10s of such problems

mental carbon Oct 30, 2023, 7:05 PM

#

stray scroll gonna be a while to strange `forge:` outta my muscle memory

The system is designed to not need a project name anymore

sly anvil Oct 30, 2023, 7:05 PM

#

kindred fractal I'm sure there's 10s of such problems

The Jar-In-Jar locator still uses net.minecraftforge :D:.

mental carbon Oct 30, 2023, 7:06 PM

#

Simply type it out without a project and you are good 😄

stray scroll Oct 30, 2023, 7:06 PM

#

does this mean it doesn't try to decompile MC twice

#

in parallel, I might add

kindred fractal Oct 30, 2023, 7:06 PM

#

sly anvil The Jar-In-Jar locator still uses net.minecraftforge :D:.

huh

stray scroll Oct 30, 2023, 7:06 PM

#

because my laptop is still not prepared for that kek

mental carbon Oct 30, 2023, 7:06 PM

#

Ehm

dull bison Oct 30, 2023, 7:06 PM

#

kindred fractal gradlew setup

no its gradlew :neoforge:setup

fallow sundial Oct 30, 2023, 7:06 PM

#

sly anvil The Jar-In-Jar locator still uses net.minecraftforge :D:.

tech

kindred fractal Oct 30, 2023, 7:06 PM

#

full setup works

fallow sundial Oct 30, 2023, 7:06 PM

#

stab

kindred fractal Oct 30, 2023, 7:06 PM

#

😛

fallow sundial Oct 30, 2023, 7:07 PM

#

did you forget that

mental carbon Oct 30, 2023, 7:07 PM

#

Maybe in your case you should do :neoforge:setup

dull bison Oct 30, 2023, 7:07 PM

#

kindred fractal full setup works

but it takes longer

mental carbon Oct 30, 2023, 7:07 PM

#

Because your laptop might indeed be crap

stray scroll Oct 30, 2023, 7:07 PM

#

mental carbon Maybe in your case you should do `:neoforge:setup`

yea, that's what I thought kekw

sly anvil Oct 30, 2023, 7:07 PM

#

kindred fractal huh

Perils of using content { includeGroup(...) } for buildscript repositories is you find what weird groups people use for dependencies.

kindred fractal Oct 30, 2023, 7:07 PM

#

where https://github.com/neoforged/FancyModLoader/blob/main/loader/src/main/java/net/neoforged/fml/loading/moddiscovery/JarInJarDependencyLocator.java

stray scroll Oct 30, 2023, 7:07 PM

#

I have 7GB of (OS-available) memory, of which a healthy amount is taken by my OS and other apps

sly anvil Oct 30, 2023, 7:08 PM

#

kindred fractal where <https://github.com/neoforged/FancyModLoader/blob/main/loader/src/main/jav...

Oh no, as in the actual maven artifact name. Not at my computer right now, but will dig it up.

mental carbon Oct 30, 2023, 7:08 PM

#

kindred fractal where <https://github.com/neoforged/FancyModLoader/blob/main/loader/src/main/jav...

The JarJar library

#

It is not under neoforged 😄

kindred fractal Oct 30, 2023, 7:09 PM

#

https://github.com/neoforged/JarJar/blob/99c3169eb8db25dfe03baacdc19a09b244a54fdd/build.gradle#L7 thonk

mental carbon Oct 30, 2023, 7:12 PM

#

We might not have updated it ?

prime quest Oct 30, 2023, 7:14 PM

#

have we built and released since changing that :p

sly anvil Oct 30, 2023, 7:14 PM

#

Yeah, these two deps

mental carbon Oct 30, 2023, 7:15 PM

#

Ah yeah

#

those will need updating

sly anvil Oct 30, 2023, 7:15 PM

#

Yeah, it's not a major problem, just surprised me. There's also a dependency on Forge's srgutils and groovydslimprover.

#

Was "gdi" deliberately chosen so it can be read as "God damn it"?

dim sonnet Oct 30, 2023, 7:20 PM

#

nope, it was a quick name maty thought up of "GroovyDSLImprover"... except it's Gradle-specific and can't be used to improve Groovy DSLs outside of that

mossy bobcat Oct 30, 2023, 7:21 PM

#

Because only gradle needs it's DSLs improved that badly, because it's gradle

dim sonnet Oct 30, 2023, 7:21 PM

#

The choice of name was merely to get something out quickly rather than worrying about names

fallow sundial Oct 30, 2023, 7:22 PM

#

sly anvil Yeah, it's not a major problem, just surprised me. There's also a dependency on ...

gdi was republished under net.neoforged (and on central), but we don't have a srgutils fork

prime quest Oct 30, 2023, 7:22 PM

#

dim sonnet nope, it was a quick name maty thought up of "GroovyDSLImprover"... except it's ...

rich void Oct 30, 2023, 7:24 PM

#

is there a primer for neoforge 20.1 to .2?

dim sonnet Oct 30, 2023, 7:24 PM

#

I stand corrected, wasn't thought up by maty

kindred fractal Oct 30, 2023, 7:26 PM

#

rich void is there a primer for neoforge 20.1 to .2?

@frozen vapor and @long cobalt were working on something but idk how that is going now

frozen vapor Oct 30, 2023, 7:27 PM

#

there's a whole chunk of notes already but they're poorly formatted

prime quest Oct 30, 2023, 7:27 PM

#

dim sonnet I stand corrected, wasn't thought up by maty

:p i just figured it was interesting enough to post here

frozen vapor Oct 30, 2023, 7:27 PM

#

and probably outdated too

#

since a chunk of stuff happened like in neogradle

long cobalt Oct 30, 2023, 7:28 PM

#

kindred fractal <@81062087257755648> and <@535059714162032640> were working on something but idk...

Vanilla changelog should be complete, NeoForge I don't know the current status

fallow sundial Oct 30, 2023, 7:28 PM

#

i believe i did a quick rundown of the networking changes in #project-talk

dim sonnet Oct 30, 2023, 7:28 PM

#

prime quest :p i just figured it was interesting enough to post here

Who came up with the name NeoForge?

fallow sundial Oct 30, 2023, 7:28 PM

#

forgecraft harold

feral moat Oct 30, 2023, 7:29 PM

#

well

prime quest Oct 30, 2023, 7:29 PM

#

i did

feral moat Oct 30, 2023, 7:29 PM

#

cpw/curle proposed

prime quest Oct 30, 2023, 7:29 PM

#

fc just agreed with me :p

feral moat Oct 30, 2023, 7:29 PM

#

and we gave feedback on potentials

dim sonnet Oct 30, 2023, 7:29 PM

#

What's forgecraft?

kindred fractal Oct 30, 2023, 7:29 PM

#

hehehe

#

bunch of crazy modders

#1.20.2