docs-website

[opal flare]

let me know once it's ready for merging.

https://github.com/PaperMC/website/pull/107 too - rebase required

[still apex]

https://i.imgur.com/HebUNE6.png
rebased both

[vocal halo]

lmao

[still apex]

it was too much effort to put myself there

@neon epoch your tags pr looks very meh

[vocal halo]

Mini worked on that no?

[still apex]

https://github.com/PaperMC/website/pull/90

[fair river]

This looks good. Keep it cc: @opal flare

[vocal halo]

Ah he just did one commit

[young matrix]

I thought this was real for way too long

[vocal halo]

[still apex]

i put riley under triage

[neon epoch]

Thank you

Means a lot

[still apex]

looks weird

https://i.imgur.com/j91zWkP.png
https://i.imgur.com/yGbW4MT.png

Folia color looks weird on a mostly dark page

[vocal halo]

I like it, would make more sense now since velocity and paper devs are together now. So putting them together and having a tag would make sense now.

[still apex]

and your docs tag is useless since there's a docs team now

[vocal halo]

Now there is

[still apex]

wa

they're still seperate

[opal flare]

not on discord

[vocal halo]

^^

[opal flare]

is what noah means

[still apex]

So like getting rid of paper and velocity dev and just making a singluar "Developers" one and then each person a tag..?

[vocal halo]

I just said, the tags PR makes more sense if the sections would be merged

Maybe it looks better overall if there are more tags and not only 2

[still apex]

and need better colors

or not as bright

[vocal halo]

Yes I agree

[still apex]

rebasing this thing sucks

ok too much work

ollie can do it

[neon epoch]

I mean if there’s a docs team it could just be closed

[still apex]

astro?

[still apex]

https://github.com/PaperMC/website/commit/6cf6f96eac870b6398fc57934ce4020a7f8a9453#diff-95d291e9ce4c8739cc7e65ff7bf0838dd5294cf39ab787ba51a42d08fb2df663 tabs ):

[viscid thistle]

Hmm?

[opal flare]

indented using tabs

bad

[vocal halo]

Why astro?

[hearty briar]

why not astro, it is like the hot thing for mostly static sites nowadays

they announced server islands too, which makes it closer to Deno Fresh

[opal flare]

We're moving away from Next, and Astro is a logical choice for something that is mostly static

[vocal halo]

Just curious

[hearty briar]

Didn't know the site was in Next (or well, still is), since it is mostly static I'd have assumed it was in Gatsby or something

[viscid thistle]

We can probably just integrate biome or eslint or whatever formatter gets y'all gears turning

[opal flare]

eslint probably, people are likely used to how it works more

[viscid thistle]

Yeah it's in Next right now. Next has some problems with deployments on different areas outside of Vercel. We're giving Astro a shot for a few reasons

• No JavaScript by default (we're going to add some in for the interactive terminal and whatnot)
• Image processing at build time vs as SSR which is what Next does + easily generate multiple of the same images at different sizes based on devices
• It still has a react-like feel for it, but in all honesty, it's mostly a static site, so we don't need all this extra JS bloat

[opal flare]

but we can easily use react, or other frameworks, within astro if we want/need to

[viscid thistle]

^

We just don't need NextJS.

[hearty briar]

if I am not hosting in Vercel, then I'd just go for Vue rather, just feels more stable of an ecosystem

[viscid thistle]

We used to be on Vercel until they gave us a 24 hour notice that our sponsorship was ending

[hearty briar]

but astro is nice too, I've only heard nice things from folks that have worked with it

[viscid thistle]

The sponsorship lasted liked 60 days to give us time to think about what we wanted to do.

I've been using Astro for a few different projects and it just feels so nice.

[still apex]

btw what's wrong with the footer?

the last thing in the todo.md

oh i see

the copyirght thing

[viscid thistle]

I can't do design to save my life and just switching over caused some things to break while I was rewriting the components in Astro

We're going to remove the nav in react and switch that to Astro and Mini is also switching to unocss since windi is deprecated

[opal flare]

https://github.com/PaperMC/website/pull/112 comment on the PR if you notice anything

[hearty briar]

125 files PR, so fun

[viscid thistle]

But if you build the branch locally and then run the preview, you can see how fast that loads.

125 is like 1/3th of the project 😭

But we're going to switch to some libraries for fonts and icons that'll just bundle them at build time so we can drop them locally.

[hearty briar]

and that's not even in production mode, is it?

[opal flare]

we're also likely going to be moving to UnoCSS (away from Windi CSS) at the same time

[viscid thistle]

Well, it'll deploy to Cloudflare Pages

So it's going to be like an instant page load for everything

[still apex]

https://github.com/PaperMC/website/pull/112/files#diff-ba00f1d7bc63648f0861e03d786d6f1ed78307f1b40284e4db329586d3df2db2R40 this is a big nitpick but ij complains about this

[viscid thistle]

I was just copying over and migrating things to Astro components don't hate, comment and we'll fix it

[still apex]

not hating (:

[viscid thistle]

I haven't added anything new that wasn't already there project wise

Idk why that drop-down in the nav won't close, but, we're rewriting the nav anyways (ty Mini)

[still apex]

also did you mean to delete the license lol

[opal flare]

some files were deleted/overwritten (LICENSE, README) by accident

and will be restored

[viscid thistle]

^^

I just deleted the branch and created an Astro project not really thinking lol

Deleted the project files*

It builds hella fast though

We can also setup some TS aliases again so we can do like @/Component etc

That was just like 30 minutes of work over my lunch break

[opal flare]

I'm poking at it a bit right now, will push if I get things working

[still apex]

https://pastes.dev/RBPTV2Yim8

[opal flare]

this does not fix it locally

[still apex]

it did for me at first 2 sec

https://github.com/PaperMC/website/blob/31c2cd045c555f07ea78594d8af246f5da0cedad/src/components/nav/NavDropDown.tsx#L38C1-L40C18

need to get rid of that

[opal flare]

nice

[still apex]

https://github.com/PaperMC/website/pull/112/files#diff-ba00f1d7bc63648f0861e03d786d6f1ed78307f1b40284e4db329586d3df2db2R8 needs to be /nav/

at least that's not allowing me to do pnpm run dev

[opal flare]

pushed both

[spice temple]

Wouldn't mind giving biome a try (and if we like it rolling it out to the other projects)

It's a new formatter/linter build on the new rust tool chain

Eslint is slow and their new config format is a mess (which is why I haven't upgraded hangar to v9)

Eslint legit takes over a minute to lint hangar

[viscid thistle]

Biome has partial Astro support

But we can try it

[spice temple]

Oh right, they have some template lang too, didn't consider that

[viscid thistle]

I'm still down to give it a shot and see if it works

[spice temple]

Ye

Am omw to get my new ID, then I need to get some packages, then I can look at stuff

[viscid thistle]

Sounds like a plan!

[spice temple]

ok, enough errants, lets see what do did

4 space indented html is so hard to read, lmao

heh

getting there

astro does stuff to images, mmh

[radiant summit]

space indented anything is hard to look at would be sufficient

[spice temple]

mmmh

this is meh

[spice temple]

happy with stuff for now

[viscid thistle]

Great work

I can try to get the 3 icons in the nav bar working.

Did you investigate adding in biome?

[spice temple]

Nope

Just uno plus some style fixes (you added new classes I think?), the footer icon and fonts

[viscid thistle]

I did not add any new classes personally

Are you still planning to migrate the navbar out of react into astro? If so, I'll wait to add the icons.

Working on the team page atm.

[spice temple]

I am not doing stuff today

need to work on hangar

[viscid thistle]

Okie!

[viscid thistle]

Got the team page mostly done. Left a couple todos.

Will see if I can hammer out the start of the sponsor page before my lunch break ends.

[viscid thistle]

@opal flare For the sponsor / team images do you want it to download the images at build time and serve them locally (in the case that they were to disappear or GH or OC was down, etc) or do you want to just serve the remote image?

Pretty sure the limit for cf-pages is ~10,000 files in a deployment. We're at 525 right now if we include team / contributors / sponsors.

[opal flare]

Cloudflare Pages sites can contain up to 20,000 files.

[viscid thistle]

Ayy nice so we should be good.

[opal flare]

maybe bundle at build-time

yeah

[viscid thistle]

I reached out to Astro cause there's an issue. If an image at build time can't be downloaded remotely it fails the build. I'm waiting to hear if there's a way to set a fallback.

[opal flare]

Cloudflare Pages sites can contain up to 20,000 files.
The maximum file size for a single Cloudflare Pages site asset is 25 MiB.

are the limits for files

[viscid thistle]

Well, considering the entire deployment right now is ~8MB, I think we're good.

[opal flare]

heh yeah

[viscid thistle]

Going to push the sponsor page, but I'll leave a todo to check back in for the fallback image stuff.

[opal flare]

👍

I'm playing around with biome/eslint

[viscid thistle]

Kk. I'm pushing 2 more pages rq.

Well, I pushed, idk why the webhook didn't trigger.

Okay we might have a solution for the image stuff, I left a comment on the draft PR that an Astro core team member suggested to me.

[opal flare]

link?

[viscid thistle]

https://github.com/PaperMC/website/pull/112#issuecomment-2276430065

[opal flare]

we need to decide whether to use 2 or 4 spaces. lots of files have 2 spaces already, some have 4 spaces

[spice temple]

2

[still apex]

no spaces

[spice temple]

at least the other projects do use 2, right?

(for non java code)

[opal flare]

afaik yeah

[viscid thistle]

I'm indifferent as long as we can commit like a .vscode file or whatever so when I format it auto just does it for me.

[opal flare]

2 is the standard for web projects

[spice temple]

editorconfig

[opal flare]

I'm setting up editorconfig + biome etc atm

[spice temple]

@ glare, your IDE will pick up the editorconfig file automatically

[viscid thistle]

👍

So it looks like we'll create our own Astro image component wrapper that will handle the logic of checking if the image exist or not first during build time and then either place that image or a fallback. Should be super simple to do hopefully. Just finished reading more into it.

[opal flare]

pushed biome

Looks like we should look into https://docs.astro.build/en/guides/integrations-guide/sitemap/ too. /cc @spice temple

[viscid thistle]

Awesome!

It ignores the node_modules by default, right?

[opal flare]

yeah

[viscid thistle]

And did you run biome on everything? I just did a format document on the main page and it had formatting changes.

[opal flare]

probably not everything; feel free to push

[viscid thistle]

I'm not overly concerned about it. I'm going to see if I can build our image wrapper.

[viscid thistle]

Okay, I think I got it working again. Feel free to say it's shit and re-do it, but I basically just copied the regular image component and wrapped some logic to put in a fallback.

Can confirm it's building now and sets a fallback.

[spice temple]

maybe add a comment on why we did that

[viscid thistle]

I did in the commit but yeah we can definitely document it.

[viscid thistle]

Went through and fixed up some compile issues, documented it all in the comment. Astro build will be more noisy now as it will do type and lint checking too so nothing broken gets pushed.

[spice temple]

and I fixed up the user profile pics

[viscid thistle]

Thank you sir 🙂

Working on the software pages now.

[viscid thistle]

Alrighty, got those in for the most part minus the description on waterfall and then the project version groups. Left a TODO for those.

@opal flare We're getting to the point where we need to discuss next steps in terms of approaching SSR. We can utilize cf-pages, but any SSR endpoint will ofc hit a worker.

• Downloads page
• Build explorer
• Anything else I'm missing

[opal flare]

I think those are the only ones?

[viscid thistle]

Kk. Lemme add the cloudflare adapter.

Is there a way we can enable preview deployments on this branch?

[still apex]

probably by just adding the action for it no?

[opal flare]

not really

since the configuration is the same across the entire page config

next.js, etc

can't change that per-branch/environment

[still apex]

can’t you create another pages instance thing

[opal flare]

that's awkward since it's connected to GitHub

[viscid thistle]

https://docs.astro.build/en/guides/integrations-guide/cloudflare/#imageservice

Keep this in mind. We are utilizing compile by default, but for any pages that we SSR that have images on it will not be optimized.

Also with cloudflare adapter since it changes how the output is generated you won't be able to utilize pnpm preview, only pnpm dev for looking at it locally.

[opal flare]

never even used preview before, used dev

since dev is what every other framework uses too

[viscid thistle]

Yeah, preview just shows you the output after build so you can ensure everything looks file.

[opal flare]

if necessary, we can grab cloudflare images

free plan is likely enough, barely any variants we use really

[viscid thistle]

It'll be only for the pages that need SSR, so it should be very minimal.

I probably need to see if SWR works with Astro, eh?

I was hoping we'd be able to get away with just cronning a deploy at midnight to update the sponsors / team stuff.

Cause if we SSR that, that's going to bump up the images a ton as that is the most used page for images.

And if we're all good with that, we still can just have that update once a day, like the sponsors do in general.

[opal flare]

If you can do that on GitHub Actions, sure

[viscid thistle]

https://www.codemzy.com/blog/scheduling-builds-cloudflare

[opal flare]

ah

that works

[still apex]

Oh also, the iavadoc link for velocity needs to be updated to 3.3.0 on the website

it uses 3.0.0 since that’s the version group (which really, 3.3.0 should be a version group since 1.1.0 also is)

[viscid thistle]

Ope I need to add that page to Astro rq

[spice temple]

Cloudflare images is extremely overkill for this

Just commit optimized images

[viscid thistle]

I need to figure out if I can do a client side script fetch in astro and then pass that back into an astro component. That would help on the javadocs page and allow us to make it a static page.

But for now I have it just on SSR

Big sad.

Was trying to get around having to SSR a few pages.

[viscid thistle]

Good luck to the person who takes on the build explorer and tries to do it outside of react. I've pushed all my changes for the time being.

[still apex]

what’s it look like rn

[viscid thistle]

I got the sidebar, but the interactivity of switching between the builds will be interesting.

However, we might be able to get away with it if we do some URL modification and utilize the platform and version in the page URL, and just have that be dynamic based on project and version?

[opal flare]

If we keep react that isn't a big deal

[viscid thistle]

Kk. Well, that means once Mini redoes the navbar, theoretically the only React on the page is the downloads / builds explorer.

I can work on trying to implement that in React after dinner.

[opal flare]

That's the most complex page really, anyways

[still apex]

Why do the CC BY SA icons looks so horrible

https://i.imgur.com/jyHZadq.png astro
https://i.imgur.com/1JyYv2Y.png current

looks fine when using <img>

[vocal halo]

lol

[viscid thistle]

It's on the todo

[still apex]

also love the terminal spam when building

https://i.imgur.com/rmnJjKx.png

[opal flare]

I really wish IntelliJ would fuck off

very intelligent IDE

[still apex]

hey thats me

[opal flare]

it literally won't go away

[still apex]

https://pastes.dev/DP1UZJwjhc
https://pastes.dev/HE3Z0wcqvD

[viscid thistle]

Okay react doesn't like how I'm trying to change up the downloads tree lol

Might have to set it aside until tomorrow or let someone else try to migrate that part over.

[opal flare]

that second paste is not a fix powercas

[still apex]

https://i.imgur.com/RzfdIeY.png i mean looks fine to me?

bit too much spacing but otherwise

[opal flare]

we're specifically wanting to not bundle icons manually like that

and to use astro-icon

[viscid thistle]

It's using all local atm, we can change it to the bundle, we just need to install that package and then tell it to start using that.

[still apex]

ah

[opal flare]

yeah, the "icons/cc/cc" is referencing the local file in the current code

[viscid thistle]

I'd say we're at a solid 60% of the migration done.

SWR needs to be investigated still. Unsure if those count as worker hits.

About to make my last push. Adding back in readme, renovate, upgraded astro for a dev tool fix.

[still apex]

Now that spark is built in, should the spark folders also be slightly documented?

or well in the references thing

nvm

next complaint then, the info things are hard to click on mobile, when you click on it you get redirected, and when you go back a page you can see it

[viscid thistle]

I'd say the site is at like 70% migrated. If any CSS wizard wants to take on the navbar overhaul and remove react from it, and then also convert the terminal to regular vanilla JS, then I think the main thing that is left will be the download pages + build explorer.

[vocal halo]

What if you click on the (i)?

[still apex]

the whole thing is a link

[still apex]

stop breaking docs @drowsy zinc

[drowsy zinc]

you broke it

[still apex]

https://i.imgur.com/rouK9YZ.png

@drowsy zinc what do you think

[drowsy zinc]

what changed exactly?

the i is not clickable anymore?

[still apex]

yes

[drowsy zinc]

looks fine

not sure if you'll be able to click that to show the tooltip comfortably on phone though

[still apex]

you can

[gilded sparrow]

I mean the list items themselves are already too small to comfortably click for mobile, so I personally don't think thats too much of a problem

[still apex]

wdym?

my branch

[gilded sparrow]

I think it's perfect from the desktop side of view which most people will use anyways. But from a mobile UX point of view the list items are way too narrow to click consistently

[still apex]

i disagree

[gilded sparrow]

Well in any case I think the design you have right now works perfectly. The ability to click the description icon is imo more than enough for mobile

[hearty briar]

for mobile the more sensible approach is to action on hold rather than a clickable popup

but yeah, since the site isn't mobile-centered anyway, it doesn't matter

[still apex]

also cloudflare broke again for docs @opal flare

@opal flare proper ping

[hearty briar]

I hate how the navbar has a space in the top lol

[still apex]

i cut away the url

[drowsy zinc]

intentional

[still apex]

i meant for prod

ik about previews

[drowsy zinc]

pr looks fine but inline styles are yucky

make appropriately named classes

[still apex]

chatgpt

[vocal halo]

lmao

[still apex]

i did

[wet ferry]

Hi, I want to use the "Item Command Converter" tool to convert a command from Minecraft 1.20.4 to Minecraft 1.21, but I can't convert this command:
/give @p diamond_boots{Unbreakable:1,Enchantments:[{id:"minecraft:protection",lvl:4},{id:"minecraft:feather_falling",lvl:4},{id:"minecraft:depth_strider",lvl:3},{id:"minecraft:blast_protection",lvl:4}],display:{Name:'{"text":"Master's boots"}',Lore:['{"text":"The ultimate boot for every adventurer."}','{"text":"Increased walking speed."}']},HideFlags:4,AttributeModifiers:[{AttributeName:"minecraft:generic:movement_speed",Name:"generic.movement_speed",Amount:0.2,Operation:1,Slot:"feet"}]}

[eager plover]

well, what's wrong with it?

I just pasted that in and it gave a command out?

Can't test it right now though

[wet ferry]

The converted command does not work:
/give @p minecraft:diamond_boots[minecraft:lore=['{"text":"The ultimate boot for every adventurer."}','{"text":"Increased walking speed."}'],minecraft:attribute_modifiers={modifiers:[{amount:0.2d,name:"generic.movement_speed",operation:"add_multiplied_base",slot:"feet",type:"minecraft:generic:movement_speed"}]},minecraft:enchantments={levels:{"minecraft:blast_protection":4,"minecraft:depth_strider":3,"minecraft:feather_falling":4,"minecraft:protection":4}},minecraft:unbreakable={show_in_tooltip:0b},minecraft:custom_name='{"text":"Master's boots"}']

[eager plover]

You need to clarify how it's not working, I can't help

[wet ferry]

The command does not work in a command block

...modifiers={modifiers:[{amount:0.2d,name:"generic.movement_speed",operation:"add_multiplied_base",slot:"feet",type:"minecraft:generic:movement_speed"}]},minecraft:enchantments={levels:{"minecraft:blast_protection":4,"minecraft:depth_strider":3,"minecraft:feather_falling":4,"minecraft:protection":4}},minecraft:unbreakable={show_in_tooltip:0b},minecraft:custom_name='{"text":"Master's boots"}']<--[HERE]

[drowsy zinc]

that seems like the apostrophe in Master's boots isn't escaped correctly

try putting a backslash before it

[eager plover]

[15:03:43 INFO]: Malformed 'minecraft:attribute_modifiers' component: 'No key id in MapLike[{amount:0.2d,name:"generic.movement_speed",operation:"add_multiplied_base",slot:"feet",type:"minecraft:generic:movement_speed"}]; Not a valid resource location: minecraft:generic:movement_speed Non [a-z0-9/._-] character in path of location: minecraft:generic:movement_speed'

modifiers need an id now

AttributeName:"minecraft:generic:movement_speed"

[jagged pecan]

Are prod deployments meant to still be broken?

[neon atlas]

yea

[jagged pecan]

Odd choice but I won't judge

Too hard

[neon atlas]

Well they are meant to be broken until someone has the time to fix the action up

[drowsy zinc]

could have made workflows require manual approval for the time being

though the action pr seems fine to me with riley's changes

if it works that is

[inner kestrel]

the pr workflow is still bjork

[jagged pecan]

.

[still apex]

#docs-website message ITS BEEN THURSDAY

[opal flare]

I'm considering dropping OpenAPI from the next version of the application that serves the Downloads API, and instead we just document it better on docs.papermc.io

[spice temple]

Why?

I know people do use it to generate clients

[opal flare]

It's a nightmare to deal with :(

[drowsy zinc]

@still apex could you fix the format and merge in the latest changes on your PR so it builds?

[still apex]

no

[last bear]

OpenAPI is especially great for testing out queries there easily

Just let mini deal with it instead

[still apex]

what’s wrong with openapi

[drowsy zinc]

could write a schema manually and embed it in an interactive viewer on the doc site

if the springdoc integration is the painful thing

[still apex]

done

ok it's not ready yet

i think

non linked stuff is now white in it

@drowsy zinc before you merge it lol

[drowsy zinc]

wdym?

[still apex]

https://i.imgur.com/H0mrjhP.png
https://i.imgur.com/RJxDh6e.png

also some other small stuff i jsut noticed

[drowsy zinc]

it looks better white imo

[opal flare]

It is, yeah - the painful part is that you can only do so much with Java annotations

[still apex]

@drowsy zinc see latest commit preview

[drowsy zinc]

looks the exact same

[still apex]

no it doesn't

https://i.imgur.com/kKS1j1T.png before

https://i.imgur.com/4HqujUn.png now

[trail jasper]

is the font smaller ?

[opal flare]

less spacing between?

[trail jasper]

oh true

[opal flare]

it's hard to tell for me

[trail jasper]

indeed

[still apex]

i accidently had 2 css class names the same

just have both commit previews open and switch between tabs

[drowsy zinc]

what's config-explorer-node-content?

I can't find any reference to it

[trail jasper]

wait no 23 px diff on both

i see absolutely no difference

[still apex]

probably nothing

oh wait hold on

nvm im confused

[drowsy zinc]

it's definitely a better name than config-explorer-node-flex

[still apex]

or confusin g me with my own code

[drowsy zinc]

this is what happens when you use GPT to code

[trail jasper]

the files inside config plugins and <world> folder have a smaller gap

[mighty dirge]

What do you guys think about adding a page to the Velocity docs about the "hidden" environment variables? This came up in Velocity#1404.

[drowsy zinc]

why do we have so many system properties 😭

yes it'd be good to have them documented if they're something that's officially supported and not just an internal detail

[mighty dirge]

I guess it's because they are pretty advanced, as it is unwanted for the "general" user, who doesn't understand why the Vanilla limits are enforced, to easily circumvent them. But if they are completely "hidden," then they are also difficult to find for "advanced" users, if they even know they exist.

[vocal halo]

I mean the average user should not need to use systemproperties

[steady fulcrum]

one sec I'll make some more

[drowsy zinc]

[mighty dirge]

Exactly, but iirc, not even their existence is documented, so even "advanced" users may have difficulties with it.

[vocal halo]

Yes, I am all for adding all available system properties to documentation

[mighty dirge]

If no one else does, I will probably throw a PR together tomorrow.
Edit: Probably wednesday as I currently don't have all properties documented.

[opal flare]

preview (wip)

[opal flare]

springdoc is broken somehow, love that

[vocal halo]

ok so i am not satisfied with how i did the vanilla config thing. Im thinking of adding a vanilla field to the "normal" config-specs files instead of having a separate file for the vanilla values. this way people would not accidentally forget to remove/add a value in the other file. This way would also "fix" the description being "N/A" and actually show the description of what the config option does.

only-merge-items-horizontally:
  vanilla: "true"
  default: "false"
  description: >-
    Prevents merging items that are not on the same y level, preventing potential
    visual artifacts.

thoughts?

[opal flare]

I like

[vocal halo]

my only problem is that i don't really know how to detect if it's worth to render a parent node which doesn't have a child node that has a vanilla value. like for example the whole anticheat node can be removed. But how would i detect that? Is there any trick i don't know?

[fair river]

There is still a plan to have a vanilla-like preset right? I am just not sure how this would be approached

[vocal halo]

System property and a little refactoring of the config code

Adding a preset functionality for other people to provide custom preset files is a whole other topic

[opal flare]

Preview of some routes currently: https://gist.github.com/kashike/07a47a05916019617a19794127dbf254
Feedback would be appreciated.

[neon epoch]

I like this

[vocal halo]

You like what?

[neon epoch]

This look

I’m not sure how I would go about rendering it tho, without just sort of post processing it

[vocal halo]

So do you want to get rid of the empty nodes or do you want to keep them?

[neon epoch]

I guess you could keep them up to a certain depth? Maybe just the roots idk

[vocal halo]

I only want to keep the parent nodes if there is actually a vanilla node below it at some point.

[neon epoch]

Yeah that works

[mighty dirge]

I added a draft pr to document the environment variables of Velocity. If anyone would like to suggest changes, feel free to do so!

[vocal halo]

It’s a cool idea

Im not a fan of the current paper system properties page

[mighty dirge]

-# It's based on the paper permissions page.

[vocal halo]

Another idea would be to have a pseudo „start script“ with expandable system properties so it’s similar to the config references

But I think your current version is the best for now.

[mighty dirge]

You mean something like this, where the variables can be selected?

[drowsy zinc]

fyi they aren't environment variables, rather system properties

[vocal halo]

Not the generator. Just a start script, that if you click a property, expands and shows the description

[drowsy zinc]

environment variables are a concept provided by the os itself, while system properties are a jvm thing

[vocal halo]

Yeah I also wanted to note that ^^

[mighty dirge]

Yea, probably best to change that. I don't even remember why I stuck with that over system properties.

[vocal halo]

I would just copy the naming, slug and description from the paper page

[drowsy zinc]

also not sure whether it's worth it to introduce a component for that vs a plain markdown table

needs more input

I like the table but the format of the paper props page also allows you to make a link to a specific property, so I'm torn

[vocal halo]

That’s a good point

[mighty dirge]

~~Also about the:

Where a system property is stated as `unset`, setting it as `true` will work to enable it.

I just mentioned the value that will be used by Velocity if it is unset, as Velocity only sets one property on its own, so should I just leave this out or write that in the note?~~

[still apex]

https://i.imgur.com/Lryh9YW.png why

[mighty dirge]

I just didn't have a good idea at the time so I just used that.

[still apex]

also they should be sorted

[mighty dirge]

Also, I haven't made a specific order for the variables, so if you'd like to suggest changes, just mention it.

[mighty dirge]

I looked at other pages for inspiration, and for example, the normal config page also uses such a table. I wanted to stick with the Velocity docs theme rather than the theme of the Paper equivalent page. So, I'm not sure which one to stick with now.

[vocal halo]

I mean some people want a overhaul of the velocity documentation anyway

[still apex]

pretty sure velocity docs is mostly copied over from the old one

[rigid bluff]

I have a small suggestion, can someone add the latest JavaDoc link into this overview Page?
https://docs.papermc.io/paper/dev

Everytime if i click into the docs its very hard for me to find direct into JavaDocs

[hearty briar]

https://jd.papermc.io shows you a page which lets you select between the different javadocs (paper, folia, velocity, waterfall), just go there instead

same for https://jd.advntr.dev/ though I hate that this one doesn't have the API javadoc at the top of the list

[rigid bluff]

Well, I'm used to other software that there is usually a link to the API docs in the developer's docs. I only recognized this in the footer on a second look. You can just overlook that

[spice temple]

its still good to link to the javadocs from the docs

[mighty dirge]

Yea, but you can find it on the main website as well under any project. https://papermc.io/software/paper

[rigid bluff]

If you take the Docs workflow, where you would normally expect to find all of Docs, it is not directly available.

[spice temple]

open an issue pls so it doesnt get lost

[rigid bluff]

👍

[mighty dirge]

I'll change it to match the paper docs then.

[mighty dirge]

I think that the section warning that the constructor for the plugin main class is not safe for most things should be in an info/warning box, as it can be easy to miss.

[spice temple]

Sounds good, wanna shoot a PR?

[mighty dirge]

Already did :)

[mighty dirge]

Also I just noticed that this is wrong.
As Velocity also supports the resource pack api from adventure. Will check if there is anything else.

[drowsy zinc]

is there something else that needs to be done for the properties PR?

if not, should be undrafted and I'll approve it

though going to wait on a second pair of eyes before merging

[mighty dirge]

No, the comments about when the property was added are lost but they don't really hold any value so I think it is finished.

[quiet raven]

https://docs.papermc.io/folia/dev

I can't open Development Guide.

It's correct?

[sharp pivot]

there is no development guide yet

[last bear]

https://imgur.com/2YZv3Mb

[still apex]

not even waiting on a review wow

[drowsy zinc]

grave mistake

Vanilla should be uppercase

[neon atlas]

Well thankfully there is more work to do on the book docs

[drowsy zinc]

[echo canyon]

do we need to mention you have to set java toolchain version to 21 here? https://docs.papermc.io/paper/dev/userdev

You get some patching error if you don't

[neon epoch]

Could probs do with a complete example as well

[echo canyon]

@drowsy zinc @neon epoch wording OK? https://github.com/PaperMC/docs/pull/472

[still apex]

the fuck is a ellipsoid

[drowsy zinc]

looks fine

[echo canyon]

3d oval

[drowsy zinc]

Minecraft should be capitalized

[echo canyon]

ellipsoid is to oval as sphere is to circle

[neon epoch]

Looks good (I’m late I was shooting)

Gotta make use of my time in the US

[mental sleet]

(66cb7ef86ed5010734cf18d0) // @tacit onyx (@superyyt / 442167742263590932) has been banned by @neon atlas (202850073812402177)
Reason: Quick-banned for sending a message in #docs-website

[raw breach]

sounds yummi

no my 100 $ 😭

[neon atlas]

[drowsy zinc]

ollie I was about to just close that

that specific page needs more improvements too, like the repetition in the headings is so bad

[neon epoch]

Eh it’s whatever

Can just be done now

I told them not to bother doing it again

[still apex]

so rude

[spice temple]

Seo stonks tho

[neon epoch]

I’m always polite (not)

[storm mason]

how to enable mushrooms breaking end portals

[mighty dirge]

#paper-help

[storm mason]

oh sorry didnt check what channel i was in

[odd tundra]

3

[scenic gull]

Do you have a comment about our docs?

[supple comet]

is it possible to add ZGC flags here? https://docs.papermc.io/misc/tools/start-script-gen

[fair river]

There is no need for any flag using zgc

-Xms18432M -Xmx18432M -XX:+UseZGC -XX:+ZGenerational is literally all you needed @supple comet

Change ram value to whatever but low amount isn’t recommended.

[supple comet]

what about -XX:+UnlockExperimentalVMOptions -XX:+UseZGC -XX:+DisableExplicitGC -XX:+AlwaysPreTouch -XX:+PerfDisableSharedMem -XX:-ZUncommit -XX:+ParallelRefProcEnabled

i found this (the old owner removed the original so i had to fork it) https://github.com/kittech0/ZGC-For-Minecraft

[fair river]

Do you even know what those flag does lol

[supple comet]

i mean, it is described here ig

[fair river]

All you need to enable generational like the one I listed above. You don’t really need anymore

[inner flare]

I was thinking of writing a guide on how to use tailscale with velocity and your minecraft servers. I talked about it a week ago in general and was pointed over here.

If you'd like, I can drum up some example documentation so you could see how it looks in practice.

[eager plover]

Well, user guide stuff type things are always nice, I generally want the docs to be a place of reputable knowledge

rewriting the entire velocity section is on my eternal todo list, however

[supple comet]

isn't this just logmein hamachi?

[eager plover]

it's a VPN

it's basically just a nicer way to tunnel the connection

hamachi is also a VPN but it's not really intended to be used for professional stuff

[supple comet]

true.

like hamachi but modern

It works with its own DNS service.

[inner flare]

What does this mean?

[vocal halo]

people basically can connect to other peoples pc with it.

used it to host teraria servers with just opening them to lan or something and with logmein amachi you can "pretend" that people are in your lan.

[inner flare]

Yeah, no-- tailscale is quite different. It's mainly for bigger corporations with lots of servers, so that they don't have to manage a much more complex LAN, even across buildings. However, it's good for personal use still, especially if you have your velocity server in one place, and your backend in another, because it's completely free for up to 100 devices.

[jagged pecan]

I mean it's still similar at a base level, an overlay network / Vpn that acts like a local network

Actually was it hamachi that only supports TCP?

[inner flare]

But yeah, I've used tailscale for months to help secure my home server, I have a server in New York that runs velocity and then a server in my home that runs the actual back end, so I've used tailscale to connect the two and then I have a firewall on the home server that does not allow any external connections except through the tailscale interface

The only issue I've had with tail scale that you have to open the wire guard port for it, and if you don't, and your router is like mine and has a broken UPnP implementation, it can cause your router to have some weird shut off issue. But I'm fairly sure that's exclusively an issue to my router, so.

Even if though, most routers have UPnP disabled, and tailscale has ways to connect without it

[jagged pecan]

I use direct wireguard p2p from a vps + a home server (running caddy as a l4 TCP proxy for non-terminated Https, mostly)

As long as the connection is established by the home server, only 1 side needs a public address

[sudden folio]

Whilst writing the changes for https://github.com/PaperMC/docs/issues/476 , I saw this and am wondering.

Is the TileState explanation not written incorrectly? It says "as you need to cast the block to something that extends TileState", but surely that should be "cast the block's state", as you don't actually 'cast the block'? Perhaps I'm misinterpreting.

[drowsy zinc]

yes the state needs to be casted like in the example

feel free to fix that in your PR

[echo canyon]

pdc is also on more types than are listed on that docs page

[sudden folio]

👍

[sudden folio]

Are there any you'd like me to add in this PR?

I don't personally know the full list

or are you saying to clarify there's others

[echo canyon]

Its missing GeneratedStructure, Raid, and ItemStack, but ItemStack is a "read-only" view atm. I think just add GeneratedStructure and Raid to the list and ignore ItemSTack for now. When ItemStack gets its write functionality, it's gonna be a tad more complicated than the others and we can add it later. And for now its redundant cause you can just use ItemMeta

[sudden folio]

Alright I'll add both these then create the PR

[sudden folio]

done

[random pollen]

https://docs.papermc.io/paper/dev/userdev#adding-the-plugin I feel like this is probably the reason I keep seeing people using old userdev versions

if we don't have something to auto pull latest, might be best to just not have a version there and just have "VERSION" or something to force people to learn how to click the plugin portal link and check versions

[echo canyon]

I think I talked about seeing about expanding our "auto" version filler to fetch arbitrary package versions from whatever repository.

until then I'm fine doing that w/a link to the plugin portal as you said

so what about

can't have clickable links within the code comment in the kotlin block I don't think

[random pollen]

can maybe just edit the existing info box about snapshots

or if not, remove the part about releases from it

[echo canyon]

https://8abc8d9f.papermc-docs.pages.dev/paper/dev/userdev#adding-the-plugin

[random pollen]

You can find the latest versionrelease of paperweight-userdev on the Gradle Plugin Portal.

also maybe "paperweight-userdev SNAPSHOT (pre-release) versions are only available through Paper's Maven repository." in case people aren't familiar with snapshots

other than that looks good

[hearty briar]

would it be too annoying of me to do a PR to remove "The" from Velocity's Command API documentation title

or the inverse, add "the" to the paper's one, I don't like the fact that only one has a definite article

[opal flare]

Match the consistency that other docs articles have. You may PR.

[raw breach]

what is holding up https://github.com/PaperMC/website/pull/112 ?

[still apex]

probably the fact it’s not done yet

[spice temple]

I think the nav needs redoing to no longer use react (or hopefully it any JS)

I debated on taking a laptop with me but decided nah

So either glare finds time or I will have to find time in October

Or somebody else tries their luck

@viscid thistle is this up to date? https://github.com/PaperMC/website/blob/feat/astro/TODO.md

[neon epoch]

There’s a couple components left to convert iirc

[raw breach]

gave migrating the Terminal component a shot: https://github.com/PaperMC/website/pull/113

[viscid thistle]

I'll take a look at it soon, thank you.

[viscid thistle]

Yes this should be up to date. Really just have the build pages left. Those are fine to stay as React components, just need to be migrated over.

[viscid thistle]

Should be all good. Looked good to me, went ahead and merged it into the astro branch. The todo's should still be up to date.

Or at least now it should. I went ahead and cleaned up the to-do list.

[spice temple]

Thanks!

[inner kestrel]

who makes a docs framework that doesnt support SSR-only operation

[spice temple]

Not talking about docs

[neon epoch]

Yeah this is our website

[viscid thistle]

I just moved into my new house over the last weekend and I've got my work cut out for me so working on this is pretty low priority. It's honestly like a solid 2 hours from being done though so anyone can pick it up.

[neon atlas]

https://github.com/PaperMC/docs/pull/481 pretty please

[still apex]

no

box's looks weird

but so does boxes

[drowsy zinc]

the singular possessive form of box is box's

what is up with the long af field names

[vocal halo]

Ok wow

That’s crazy

[neon atlas]

naming ✨

[neon atlas]

https://github.com/PaperMC/docs/pull/481 done and dusted

pls merge if happy

[drowsy zinc]

I'm gonna trust you that it's correct

[neon atlas]

big mistake

[crimson spear]

I saw the page https://docs.papermc.io/paper/dev/custom-inventory-holder and I thought that md_5 said it was unsupported API to extend InventoryHolder? I know it's very unlikely to break at this point, but we shouldn't be recommending it to users. The proper way would be to store a reference to an Inventory and compare its identity

[serene vault]

md_5 also says ItemMeta is very flexible

that is perfectly supported API on Paper servers

pretty sure its still somewhat broken on Spigot, and they also don't have the getHolder(false) method, so getting a holder can cause lag on Spigot servers

[lean venture]

md_5 probably also thinks earth is flat. ^^

[spice temple]

I mean, he does live upside down

[peak torrent]

His pet is probably a kangaroo

[supple comet]

and hes fighting a war against emus

[abstract barn]

The great emo war

[mossy hatch]

was it mojang or paper devs that were responsible for the behavior of these enums

because i hate them

[spice temple]

What's your issues with them?

And no, attribute modifiers are a vanilla things

[mossy hatch]

i just hate that MULTIPLY_SCALAR isnt an option while MULTIPLY_SCALAR_1 is

[jagged pecan]

i mean vanilla calls them differently

[mossy hatch]

thats arguably worse

[tidal inlet]

#paper-dev

[rigid bluff]

Small question, is the dev docs pointet to newcomer for java or just newcomer of paper ?

Because if found this nice interactive Git Learning Platform for branching Models etc:
https://learngitbranching.js.org/

[drowsy zinc]

newcomers to paper, we definitely are presuming a certain level of existing programming knowledge

idk whether we do anything with git on the docs

[rigid bluff]

I think there was one in past something

[eager plover]

We have git stuff in the contrib docs but that's really because our git flow is non-standard

There is a pin in the general channel for java stuff, but the documentation has to make some assumptions

[drowsy zinc]

I could use some additional eyes on #479

[supple comet]

ye these never made sense to me

[neon epoch]

Looks generally good although I think the warning at the start may be in the wrong place

[last bone]

Just saying, something is up with the SEO cause searching up paper plugin dev leads you to the velocity page

that link is
https://docs.papermc.io/velocity/dev/creating-your-first-plugin

[hearty briar]

I mean, that's kinda inevitable

velocity plugins are plugins too

it'd be easier if the organization didn't have the same name as the server platform lol

[mighty dirge]

Note: Update description to say 1.20.5-1.21.1
https://docs.papermc.io/velocity/reference/system-properties#velocitystricterrorhandling

[neon epoch]

“Paper plugin api” yields the correct page, but dev does not. Very interesting.

We can work on SEO if we want by using the front matter

There is a “keywords” field that accepts a list of keywords to plug into SEO

[drowsy zinc]

that translates into <meta name="keywords" ...>, which isn't used by google

https://developers.google.com/search/docs/crawling-indexing/special-tags#unsupported

(https://docusaurus.io/docs/api/plugins/@docusaurus/plugin-content-pages#keywords)

[neon epoch]

Fun

[mellow crest]

.

[spice temple]

It's a trade off between seo friendly headlines and short headlines

So far you guys preferred short headlines without Keywords

And no repeated Keywords on the pages

If you want better seo, that has to change

I.e create your first plugin needs to be create your first paper plugin, "Creating the project in your IDE" down below needs to be "Creating the paper plugin project in your IDE", etc

Just spam the Keywords you want to rank for into headlines

[drowsy zinc]

well it's because such repetition doesn't work in such a structured doc setting

we could change the page and meta title with the front matter

i.e.

---
title: My Awesome SEO Title
hide_title: true
sidebar_label: My title
---

# My title

...

[spice temple]

Of course it's worse to read

I am saying it's a tradeoff

Google heavily prioritizes actual content over all technical seo things

I am playing this game every single day at work with much harder to competed keywords

(luckily I don't need to write the content, nor am I responsible for seo, but I sit in a room with them every single day)

[neon atlas]

https://github.com/PaperMC/docs/pull/483 for any reviewers around

[brazen moon]

the property doesn't match what is currently used void-min-build-height-offset -> void-damage-min-build-height-offset ?

[neon atlas]

✨ never has been

[sacred night]

What do you do for work? Web dev?

[drowsy zinc]

this is what happens when merging without approval

[neon atlas]

What happened?

nothing happend

[spice temple]

Little bit of everything, something between a tech lead, software architect and full stack dev

oh and devops stuff

[mighty dirge]

Loves the link into nowhere
-# on: https://docs.papermc.io/misc/assets#velocity

Is probably this now?
https://github.com/PaperMC/velocitypowered.com/tree/master/src/assets/img

[opal flare]

no, should just be removed

[still apex]

wasn’t there a assets repo

[opal flare]

yes, it's private, and has been for the entire lifetime of the repo

[still apex]

how tf do you use properties inside a code block for docs

[drowsy zinc]

properties? the java properties?

[still apex]

got it

[neon epoch]

Read the docs for the docs you goose

[still apex]

@neon epoch could've told me you touched my branch

[neon epoch]

Hey Cas I touched your branch

[spice temple]

@still apex u around? I have javaducks open rn, do you want to do the changes I requested yourself or should I do it? (adding a test and fixing a trailing slash issue)

(re https://github.com/seiama/javaducks/pull/22)

oh god, 1.8 pleb detected 😄

[still apex]

i am just bored on there

i can (try) to do it

[spice temple]

ill look at the updating 500 issue then

[spice temple]

oooh, I think I have it

we cache the zip file systems, which arent really valid anymore if the jar changed

so maybe we just need to evict that cache

thats also why it self fixes, the cache has a ttl of 10 min

yep, nice, that fixes it

[still apex]

should work now

[spice temple]

https://github.com/seiama/javaducks/pull/23 this is my fix

[spice temple]

looking good

almost wanted to complain that it doesnt work but gh cli doesnt set a tracking branch when you do pr checkout and so I didnt test with your changes, lol

wait something is broken

ye you mixed up the mappings 😄

[still apex]

oh right i see

[spice temple]

also, not sure if the redirect chain is worth it, I would just have called the method that does the actual redirect

else you have /paper -> /paper/ -> /paper/1.20.6/

also also, add a test for both mappings and this would have been caught 😛

ok, now everything is looking nice

@opal flare, when you have time, two small PRs to javaducks:
https://github.com/seiama/javaducks/pull/23 fixes the 500 errors we sometimes get for a few minutes after updating a jar
https://github.com/seiama/javaducks/pull/22 is a smol QOL thing

@still apex checkstyle is complaining about a missing this. ^^

[still apex]

bleh

[spice temple]

not sure what the status on https://github.com/seiama/javaducks/pull/15/ was

enough javaducks for today, lets look at grannys sculptor PR

[opal flare]

granny be lurking

@lilac edge 👁️ 👄 👁️

[spice temple]

I love opening my papertooling workspace, lol

[lilac edge]

@opal flare

[spice temple]

👀

may react burn in hell

pushed

somebody needs to figure out data fetching

[mossy hatch]

https://docs.papermc.io/folia/dev

is this supposed to only have one page with no info on it

i dont plan to use folia (at least not yet) but I'm very curious

[spice temple]

Yes, there is no dev guide yet, nobody wrote it yet

The readme of folia is where most info is at

[hidden turret]

/help

[green kernel]

I'm more on the trek way.
https://plugins.jetbrains.com/plugin/13341-startrek-progress-bar

[tidal inlet]

nyan progress bar ftw

[urban solar]

hey guys!
I've noticed that these popups have incorrect background color scheming in white mode:

[drowsy zinc]

should be fixed once the build goes through, thank you for reporting it

[still apex]

wonder who caused that

[drowsy zinc]

not me

[neon epoch]

not me

[drowsy zinc]

[craggy cedar]

Quick question: why is there a new Commands API doc since yesterday instead of my far more detailed one, which is waiting on getting merged for three months?

[neon atlas]

Good question cc @neon epoch @drowsy zinc

[eager plover]

looks like it just burned by workflow and githubs "changes requested" thing being somewhat dense, and so a quick intermediatary PR was pulled in vs the one which was still apparently pending changes

[craggy cedar]

ok. was just a bit irritated. I approved Ollies changes and he said that after that, it would be good to merge, so i was just a bit irritated

[mighty dirge]

Btw. is it intended that the Velocity Download Page still has the 3.3.0-SNAPSHOT version as latest? (while the docs auto-adopted the new 3.4.0-SNAPSHOT)
-# seems like the docs are not fully automated at least is the old version also present here

[neon epoch]

Yeah refined github decided it was of very low priority ill have a look now

looks like i got 2 files in

[neon epoch]

Could you maybe open an issue for this please

[mighty dirge]

ok

[mighty dirge]

https://github.com/PaperMC/docs/issues/487

[neon epoch]

Thank you for your work and I apologise for it being stuck in the PR queue, I merged main into your branch and merged your PR. Thanks 🥳

[craggy cedar]

🙏

[drowsy zinc]

I had a few reservations regarding the PR, which I noted in the review, but last time I checked, they were marked as resolved without a fix or explanation why stuff should stay the way it is, so I presumed the PR wasn't done yet

that being said, I haven't reviewed it with the later commits, because I forgot about it

[neon epoch]

I gave it a read, all seemed sensical

[drowsy zinc]

the enchantment types heading is wrong, because it isn't all about enchantments

[brazen moon]

i don't think this page should have that table it seems more appropriate to the registry api page or related and it's not strictly only used for commands.

the doc should probably also use jspecify now for code example

[brazen moon]

this part https://github.com/PaperMC/docs/commit/f29ea4b#diff-b88a6af91b137859db795eece09097d10533a204f007ae2e595ddaff8f58a30bL143-L162 seems still relevant and could be merged into the current page

[still apex]

I think this may just be like some caching issue? Since it's fine locally?

[eager plover]

is it querying the data from hangar? o.O

oh, no

https://api.papermc.io/v2/projects/velocity

I am just out of it today, nvm me

[still apex]

locally it’s fine haven’t even touched anything

[serene vault]

minor thing, but it probably would make sense to remove waterfall from that. whereever the embed text comes from

[still apex]

https://github.com/PaperMC/website/blob/8759b6acdd637e7f928190d162a5fb39f3851794/src/pages/downloads/index.tsx#L15

[drowsy zinc]

looking at docs#487, it's pretty peculiar that the velocity pages are not versioned

though I'm not fond of the paper versioned docs either

[eager plover]

I mean, the versioning mechanism is ass

and it's not like velocity is as movey when it comes to documented aspects

[drowsy zinc]

yea

I'd love to yeet it for paper altogether, since the latest pages have much more stuff documented even for those older versions

and the stuff removed across versions is minimal

not to mention stuff like the configs and recommended java refs are broken entirely, those don't have a versioned impl

[neon epoch]

It’s like “ok”

Like it’s ok for api that changed or was removed

But it’s not the greatest

[spice temple]

are velocity docs links automatically updated to 3.4.0?

because they were all dead because nobody setup the jd config for 3.4.0 😄

[drowsy zinc]

yes

it uses whatever's the latest in the manifest

[still apex]

did the website download get fixed yet

[mighty dirge]

doesn't seem like it

[eager plover]

Does the website just need a redeploy?

@spice temple

[still apex]

likely as locally it’s fine?

[spice temple]

No clue how next shit works

Isn't it doing isr stuff?

[eager plover]

Urgh, next

I'd guess its cached and needs aredeplot then

I forget where that is hosted, can you trigger a redeploy?

[spice temple]

Am already in bed, not feeling so good, but I can do it tomorrow

[eager plover]

Ty

[spice temple]

It's some random script on the legacy host

[eager plover]

I do not remember what access I had to that stuff and my eye is sore from today, so, it can wait

[spice temple]

ok lets see

coooool the script is bork

ok fixed the script but the pnpm lock is broke

ah, powercase broke it 😄

just as an fyi to everybody, the old website needs to be compatible with node 17 😄

so cant use pnpm 9

[spice temple]

you wat now

4 minutes of pnpm install

anyways

this was painful

but fixed

[still apex]

i blame whoever merged it

[spice temple]

I blame the stupid legacy server we should get away from

and that deployment isnt automated

[still apex]

actually my pr got reverted?

[sage veldt]

Why dont you deploy it on Vercel?

[drowsy zinc]

no one has had the time to transfer it somewhere else

and iirc vercel has cancelled their open source sponsorship program, so our choice is definitely cloudflare pages

[still apex]

nothing is run on vercel anymore afaik

[sage veldt]

Hobby plan isnt acceptable for this website? I dont really know the traffic etc 😄

[eager plover]

Because our website setup is a bit weird and so dealing with things across services is a bit of a headache

hence why we've been warning people for the past god knows how long to migrate their download URLs, etc

Vercel seemingly miscommunicated about their OSS program, but, it left a sour taste in a lot of peoples mouths

[sage veldt]

You mean you cannot get sponsorship when using their hosting?

[eager plover]

No

Well, idk what you mean by that

vercel have a plan which lets OSS orgs use their platform for free

Vercel announced that applications to their OSS plan would be paused or something, our OSS plan was due to expire shortly around that time, and so we ditched

[scenic gull]

More here - https://news.ycombinator.com/item?id=40682711

[eager plover]

Vercel seemingly clarrifed that they weren't killing existing things, but, it left us in a wierd confused state and, there were already alternatives out there without requring the sponsorship that would fit our needs, albeit with some potential quirks

[sage veldt]

I understand now 😄 thanks

I work with React, TypeScript, Tailwind, react-query etc. Used NextJS sometimes, maybe I can help you with something if you need

[eager plover]

The primary issue is that our site has various endpoints on it that proxy elsewhere, so, we cannot deploy the site itself on vercel

The goal is to just move it into our k8s infra when we can

[spice temple]

Fuck vercel, fuck nextjs 🙂

There's a branch that's like 80% done to move away from next

[scenic gull]

If you didn't call the branch "previous" that's a big missed opportunity.

[spice temple]

Blame @viscid thistle

[eager plover]

I was looking at that branch, I did start a few tweaks, but, backed out and went back to my coursework

[spice temple]

I think it's the download stuff that's the biggest to-do

Needs somebody to actually read the docs on how astro wants you to do data fetching, lol

[eager plover]

Well, I'm going to be moderatly busy for a week, and then god darned busy, but, after a recovery period, I might be able to take a look if nobody has done it yet

[spice temple]

There's no rush, I will not really be touching it, I wanna spend on my time on paperweight v2

If my brain can work thru the issues without jumping around all the time

[viscid thistle]

Smh

I'm surprised no one finished it by now. It is probably only an hour or two of work.

Also need the navbar to be migrated to Astro since we can probably just use CSS for the dropdowns.

[spice temple]

That I did

No react in the project anymore

[viscid thistle]

Wait you did?

I guess I should really pull first before working on it.

I did a Kenny 😦

[spice temple]

At least I remember doing something when I came back from my vacation and my fever passed and before I got the next fever

[viscid thistle]

Yeah no I am caught up now. This gives me a little motivation.

[spice temple]

Successfully baited, woo

[viscid thistle]

Only 24 errors right now

One of the issues I see right now with the icons like the nav button is that it's using images directly instead of the icon component so changing the color isn't playing nicely.

vs

[still apex]

looks identical to me

[viscid thistle]

?

It's dark on the first one

[still apex]

oh that

was in my status bar

[viscid thistle]

On top of that, I moved the Icons to use the icon directly vs the image and it fixed the social icons.

[viscid thistle]

Pushed some changes, but will probably need double checked.

[viscid thistle]

Kinda got the download button working but it's a bit messy. Gotta be a better way to approach this. There's some dropdowns and items using the headlessui/react.

[viscid thistle]

The annoying thing is going to be the dropdown box there with the link information on the jar.

Alrighty, all my stuff is pushed for probably the night. It's a little messy, but honestly it's probably 75% done? I think all that is really left is the global build explorer and then general cleanup.

I lied, one last push to appease Biome.

[viscid thistle]

Okay last update of the night if anyone wants to play with it:

Pushed some comments on the TODO and also made some various TODO comments in components. Will clean that up later if someone else doesn't get to it first.

The build explorer is a thing now, but it's not reactive, so we'll need to adjust that.

Pretty much all we have left should be in the TODO, lot of small things, but mainly just need to go through and introduce Vanilla JS reactivity where needed.

Also need to force the footer to the bottom on the javadocs page.

[spice temple]

Nice

[viscid thistle]

I did a test last night before bed deploying the Astro version on Pages and the TTFB was about 3x faster than the current Next. It's kinda insane, but it does make content shift a tad more noticable.

[hearty briar]

critical CSS when

content shift is just the worst unsolved problem yet, I'm surprised frameworks like Astro which center themselves on the SSR camp haven't tried to solve that

[viscid thistle]

To be fair, I believe they do offer some things that can help, but since we are doing a direct port over, we haven't really focused yet on any of the tools they may have to offer to help fight this problem.

Also I haven't used UnoCSS much and I know we are using an adpater on that for font loading.

[still apex]

https://github.com/powercasgamer/papermc-website/commit/55f030cc8d38241a329e303feb540943e9f10ce3
the social icons on the team page are the wrong color

[viscid thistle]

Ope, good catch.

If you PR it, I'll merge it in.

[still apex]

and on the sponsor page there's a space after the $ sign which gets 'fixed' if you do

      <b>
        $
        {sponsors && (sponsors.ocData.collective.stats.balance.valueInCents / 100)?.toLocaleString("en")}
      </b>

      <b>
        ${sponsors && (sponsors.ocData.collective.stats.balance.valueInCents / 100)?.toLocaleString("en")}
      </b>

i'm somehow hitting the github ratelimit lol

[viscid thistle]

Yeah I think I saw that too, also, the wording on that needs to be improved.

I think there needs to be an and after the balace is $,

But feel free to shove everything into a single PR once you stop getting ratelimited.

[still apex]

and for some reason wherever there's a   on the astro branch it's a space but on the old one it's not an extra space. If that makes sense?

https://i.imgur.com/uTpX0aV.png astro
https://i.imgur.com/qPZLBco.png next

our build explorer .

removes it fixes it but dunno if that's there for any specific reason

[viscid thistle]

I think it's just the way that React vs Astro was handling the syntax.

[still apex]

so removing it is fine yeah?

[viscid thistle]

There will probably be some other misc things. Yeah, there shouldn't be a space between that.

[still apex]

https://i.imgur.com/YvcDaZF.png

[eager plover]

bad dangling import?

[viscid thistle]

Did you try updating to the Astro 5.0 beta?

I got that too when testing with it.

The 5.0 Astro Beta uses the Vite v6 preview (when this goes stable, Astro 5.0 goes stable), and I think something changed in Vite's v6 update that caused that.

[spice temple]

they killed vite-node iirc

https://github.com/PaperMC/website/blob/feat/astro/src/components/Footer.astro#L6

not sure this is legal?

[viscid thistle]

It does work currently

[spice temple]

its platform dependent code

[viscid thistle]

True. I'll research another way.

[spice temple]

vite doesnt want you to do that anymore

vite 6 tries to be platform agnostic with their environment api

basically the goal is to make stuff that runs on vite run everywhere, node, bun, deno, workerd etc

[viscid thistle]

That makes sense.

So that means we could tie it into the build script.

[spice temple]

but like, that is meh code in any case

[viscid thistle]

Via like "build": "GIT_COMMIT_HASH=$(git rev-parse --short HEAD) astro build"

[spice temple]

you cant rely having git at runtime

yeah

thats nicer, iirc such an env var exists in actions anyways

so just need to forward that to the build step and the astro code should gravefully fallback

[viscid thistle]

Awesome, will keep that in mind once we actually start producing builds of that.

Cause right now we don't do pages or actions for this branch.

Though it would be nice, I think riley said something about it not being able to handle that properly at this current point in time.

[spice temple]

I might have time to deploy it to papermc.dev later this week

would need an option to disable indexing tho via a robots meta tag, like hangar has

[viscid thistle]

They have an integration for a robots.txt generation

But I do already see:

User-agent: *
Disallow: /downloads/all
Disallow: /repository/
Disallow: /repo/
Disallow: /api/
Allow: /

Sitemap: https://papermc.io/sitemap.xml

When building.

So we could also just modify that.

Also https://docs.astro.build/en/guides/integrations-guide/sitemap/ for the sitemap.

[still apex]

(that's what i was doing when i got the build error)

[viscid thistle]

Gotcha

Oh the robots.txt is just in our public folder, didn't realize that. So we don't really need to add an extra integration for that atm then.

@spice temple If the papermc.dev isn't in use right now, could you spin up a new pages project and set the feat/astro branch to it's production branch so it'll only build that?

[spice temple]

dont we need ssr?

else the download stuff is always outdated

[still apex]

doesn't work on 5.0.0-beta.5

[viscid thistle]

Once we mark the pages as prerender = false, the cloudflare adapter will route those pages through a worker.

[spice temple]

didnt we want to self host it?

[viscid thistle]

Well, the prod site is on pages right now.

I think riley wanted to get the Astro version for pages too.

[spice temple]

to get the fuck away from vercel

[viscid thistle]

Correct

And the whole thing with the move to Astro was to drop the overhead of NextJS, and then have all the static images be built during build-time vs on-demand transformations invoking worker functions.

Someone might have a better way to handle the build explorer interactivity for the client with Astro, but the only thing I've really come up with so far is using URL as state.

So an initial deploy on pages in it's current state would at least give us a baseline to work on, knowing that some things don't have client interaction yet.

[spice temple]

I always forget that astro has no runtime stuff

[still apex]

https://github.com/powercasgamer/papermc-website/compare/foot/astro...powercasgamer:papermc-website:foot/beta-astro?expand=1 sitemap + footer thing fix. did it on a seperate branch to not break my pr with the beta

[viscid thistle]

It was originally built to be static, with SSR added in later.

Oh so moving it out of the component and into the config made Vite happy?

[still apex]

yes

[viscid thistle]

That's awesome. Easier than I thought.

So do you want me to go ahead and merge that open PR?

[still apex]

that doesn't do the sitemap and footer

[viscid thistle]

That's fine

If Mini made this deploy to pages since it's on Astro v4 it shouldn't fail.

[still apex]

should be fine to merge yes? i do still have the gihub ratelimit thing in there which i can remove before u merge it

[viscid thistle]

Alright, feel free to remove that. Idk why you got rate limited and I haven't.

[still apex]

I think it's safe to assume that who/what-ever is running this will have git installed yeah?

[eager plover]

it exists in a git repo

[viscid thistle]

If we stick with Cloudflare Pages, yes.

[eager plover]

if they don't have their tooling setup properly, that is generally considered their problem

[viscid thistle]

I've used the previous commit hash trick on pages before, so I think we're good.

I did a test deploy to pages last night with the previous trick and it showed up just fine.

Also if you don't mind updating the robots.txt to disllow indexing on it all, just leave a todo to undo that once we get ready to merge this to production.

Ima dip for an hour but just ping me once that's ready and we can merge it and see if we can get a pages deployment going.

[still apex]

||probably|| good to merge

[spice temple]

If it's in the config it's build time, right?

Then I am fine with it

Since runtime might not have git

[still apex]

yes

also any objections if i update pnpm in the pr and make it use corepack

[viscid thistle]

I don't see a problem with that

Just lmk when it's all ready

[still apex]

ready

[viscid thistle]

Does the sitemap URL in the robots.txt need to be updated to the .dev domain too?

[still apex]

oh.. probably

now it's ready

[viscid thistle]

Awesome, merged. So now we just need to wait until Mini has some time to create a new pages project and hook it up to the Astro branch.

[still apex]

why is the terminal not paper based

[viscid thistle]

Wdym

[still apex]

https://i.imgur.com/GsYpvPT.png vanilla ):

[viscid thistle]

Ahh, idk.

Probably should update that 😛

[viscid thistle]

@spice temple An initial deploy should be ready to go whenever on the .dev domain. Indexing has been turned off, and I think that was the only major thing needed before we start getting a deployed visual of this branch.

[spice temple]

Yeah, we don't know yet how we want to deploy it

It's not so simple because there is stuff like PaperMC.io/API that still works

That's why I want to self host it, way simpler than doing with whatever cloud service is the hot shit rn

[viscid thistle]

Wasn't the whole reason that Riley went through with a pages deployment for prod is becuase the issues that were related to the /api and whatnot got fixed?

Cause wouldn't it be broken in production right now if that was the case?

Or iirc he has something handling it on the self host but it's still go through pages. So it's like domain -> backend -> pages

[spice temple]

The website is not hosted on pages

The website is hosted on the same ancient hetzner server it has been hosted on for the last decade

(the one which had a broken CPU fan for half a year....)

[viscid thistle]

#docs-website message ?

[spice temple]

Only the PR preview was ever on vercel or pages

Idk what Riley did or say, but that's not how it currently works

[viscid thistle]

I'm like 90% sure we shifted prod to pages because we had to do a paid runners for the NextJS images, which is another reason back to switching to Astro.

Hmm okay

[spice temple]

I literally did redeploy the website yesterday on that server

To fix the velocity download

[viscid thistle]

https://4b65d31d.papermc-website.pages.dev/

Idk why it's deploying to 2 places then

#website message

[spice temple]

Idk

I can just tell you what it does rn

[viscid thistle]

¯_(ツ)_/¯

[opal flare]

Yes it is

[opal flare]

This

[glad zodiac]

the minecraft movie should look like those old minecraft song animations, its going to be sad that it looks so bad

[spice temple]

Why did I have to login into the legacy server and redeploy the website to fix the velocity download then?

[opal flare]

you didn't, it probably just was a coincidence

[spice temple]

It was broken for days, lol

[opal flare]

see /etc/nginx/sites-enabled/papermc.io:

location / {
    proxy_pass https://papermc-website.pages.dev/;
    proxy_set_header Host "papermc-website.pages.dev";
    proxy_set_header X-Forwarded-For $proxy_add_x_forwarded_for;
    proxy_set_header X-Real-IP $remote_addr;
    proxy_ssl_server_name on;
  }

it's literally proxied, it isn't hitting the local deployment

[spice temple]

Strange

Maybe the SSR on pages is broken then and my commit forced a redeployment to pages?

[opal flare]

perhaps; it's definitely hosted on cfpages though

[viscid thistle]

I know next on pages does have some problems

They are working on a new OpenNext, but we won't have to worry about that with the change to Astro.

[viscid thistle]

So given this information, does that mean something can be done to at least get a POC running on .dev?

[supple comet]

yo how did u make that menu

🙏

[sharp pivot]

its the paper website

[neon epoch]

😭

[still apex]

wat

[drowsy zinc]

😭

[lilac edge]

they're in pain

can't you see

[viscid thistle]

Just a quick note on website progress - if anyone wants to take a stab at it, there's some TODOs in the code and the TODO file to take a look at. I was hoping to get more done this week, but work has been super busy. I will be out of town until next Saturday.

[rigid pasture]

Hello, where can I report a Paper bug?

[tropic kraken]

#paper-help

[drowsy zinc]

@neon epoch free review at https://github.com/PaperMC/docs/pull/492

[neon epoch]

Why have I gotta review it

Smh

Gimme a min

[still apex]

just leave it there for like 2 months

[neon epoch]

Looks good

[pseudo sundial]

19:33:04.215    ✘ [ERROR] Error: Pages only supports files up to 25 MiB in size
19:33:04.215    
19:33:04.215      cache/webpack/client-production/0.pack is 36.8 MiB in size

not related to paper docs, but i figured i could maybe ask this here, but could anyone know why our docs cache is so large? cloudflare pages doesnt like it
https://github.com/Mvndi/docs

[spice temple]

Mfw webpack

Doesn't web pack have a thing like vite-plugin-inspect to analyze your bundle?

What even is that file?

[pseudo sundial]

Yeah i figured it out, i was trying to upload the .next folder instead of /out

[mental sleet]

(672157c36ed5010734cf19a1) // @ebon cave (@xiaoxin9371 / 740765925426462771) has been banned by @ocean void (188417437295706113)
Reason: Spam.

[arctic spindle]

Is their a seperate discord for folia or, since folia is cooperated with papermc, is this discord for folia?

[tidal inlet]

#folia-dev #folia-help

[arctic spindle]

Thanks, due the "channel discovery" in discord I didn't see it

[still apex]

stupid experimental button

[still apex]

(i was talking about the astro branch)

someone else can deal with it

[spice temple]

pff, dont call it stupid, I worked hard on that!

[still apex]

also was there any progress on the preview on .dev?

[spice temple]

no, I am not touching cloudflare shit, that sounds like pain

[viscid thistle]

I have a fork deployed on pages for testing, but it's not a live update until they put it on .dev

The handling of experimental and the build explorer is pretty much all that's left in terms of JS iirc

So good luck to whoever wants to take that on. Idk how to better handle that without using query params.

I'm home from Universe, so I should be active again tomorrow and I can check out the PR you opened.

[viscid thistle]

@still apex You good if I push a few changes directly to your PR?

I added in the copy confirmation badge that appears when you copy the SHA.

[still apex]

go ahead

[viscid thistle]

Awesome. That's pushed. Feel free to look it over. If you agree, I think we can go ahead and merge this.

[still apex]

Looks good yeah

Probably not related to this PR but on the build explorer the dropdown only works for the latest build

other builds throw a https://i.imgur.com/HGVqQkR.png

[still apex]

well it opens a dropdown now, just the wrong one https://i.imgur.com/W4Sb59y.png

this is confusing

[viscid thistle]

I didn't even think about that, hmm.

I'll hold off on merging then until we can figure this out.

[spice temple]

ok I did enough paperweight hacking, back to some trusted webdev

what can I help with?

[eager plover]

lol